[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16001981#comment-16001981
]
stack commented on HBASE-17210:
---
Thanks [~yangzhe1991]
Yeah, it looks like lock is not released correctly.
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16001979#comment-16001979
]
Phil Yang commented on HBASE-17210:
---
Before this patch, if a Call with 1000ms timeout being blocked by
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16001696#comment-16001696
]
stack commented on HBASE-17210:
---
[~yangzhe1991] What brought about this change? Were you experiencing
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877712#comment-15877712
]
Hudson commented on HBASE-17210:
SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2549 (See
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877555#comment-15877555
]
Hudson commented on HBASE-17210:
SUCCESS: Integrated in Jenkins build HBase-1.4 #638 (See
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877431#comment-15877431
]
Phil Yang commented on HBASE-17210:
---
Pushed to master and branch-1, thanks [~tedyu] for review
> Set
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877316#comment-15877316
]
Phil Yang commented on HBASE-17210:
---
Will commit later if no more reviews
> Set timeout on trying
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875977#comment-15875977
]
Hadoop QA commented on HBASE-17210:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875571#comment-15875571
]
Hadoop QA commented on HBASE-17210:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875333#comment-15875333
]
Hadoop QA commented on HBASE-17210:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874659#comment-15874659
]
Ted Yu commented on HBASE-17210:
+1
> Set timeout on trying rowlock according to client's RPC timeout
>
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874440#comment-15874440
]
Hadoop QA commented on HBASE-17210:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874172#comment-15874172
]
Hadoop QA commented on HBASE-17210:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874036#comment-15874036
]
Phil Yang commented on HBASE-17210:
---
bq. I don't see assertion in new test. What is the behavior of the
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872206#comment-15872206
]
Ted Yu commented on HBASE-17210:
Client RPC timeout is normally set quite long.
Phil:
Have you
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871744#comment-15871744
]
Hadoop QA commented on HBASE-17210:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871694#comment-15871694
]
Ted Yu commented on HBASE-17210:
I don't see assertion in new test. What is the behavior of the test
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867669#comment-15867669
]
Hadoop QA commented on HBASE-17210:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867489#comment-15867489
]
Phil Yang commented on HBASE-17210:
---
Upload a rebased patch, let's see QA first
> Set timeout on
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711182#comment-15711182
]
Ted Yu commented on HBASE-17210:
bq. so we can use System.currentTimeMillis() directly
I don't have
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15710817#comment-15710817
]
Phil Yang commented on HBASE-17210:
---
Thanks for your review.
{quote}
Should timeout be set to
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15710399#comment-15710399
]
Ted Yu commented on HBASE-17210:
{code}
5343 if (call != null && call.getDeadline() <
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709827#comment-15709827
]
Ted Yu commented on HBASE-17210:
testBatchMutateWithWrongRegionException failed during QA run.
Please
[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709431#comment-15709431
]
Hadoop QA commented on HBASE-17210:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
24 matches
Mail list logo
