[jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private

2017-09-07 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156630#comment-16156630 ] stack commented on HBASE-18446: --- I wrote the pheonix dev list on CPs in general but asking for input on

[jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private

2017-09-06 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156292#comment-16156292 ] Duo Zhang commented on HBASE-18446: --- If no objections I will provide a patch soon. We need to decide

[jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private

2017-09-04 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152440#comment-16152440 ] Duo Zhang commented on HBASE-18446: --- Let's revive this. So I think we all agree that user should not

[jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private

2017-08-07 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116177#comment-16116177 ] Anoop Sam John commented on HBASE-18446: Regarding HBASE-6224 and load files in CP itself. I

[jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private

2017-07-28 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104881#comment-16104881 ] Duo Zhang commented on HBASE-18446: --- Oh, seems no problem. The compaction will also use the replaced

[jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private

2017-07-28 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104876#comment-16104876 ] Anoop Sam John commented on HBASE-18446: For the compaction purpose also, each of the region's

[jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private

2017-07-28 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104871#comment-16104871 ] Duo Zhang commented on HBASE-18446: --- {quote} but with local index we need to do full HFile scan and

[jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private

2017-07-28 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104860#comment-16104860 ] Anoop Sam John commented on HBASE-18446: Ya then StoreFileReader is what should be exposed. As

[jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private

2017-07-28 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104677#comment-16104677 ] Duo Zhang commented on HBASE-18446: --- OK, got it. Seems we need to introduce an interface for

[jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private

2017-07-27 Thread Rajeshbabu Chintaguntla (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104479#comment-16104479 ] Rajeshbabu Chintaguntla commented on HBASE-18446: - [~Apache9] [~anoop.hbase] We use

[jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private

2017-07-27 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104416#comment-16104416 ] Anoop Sam John commented on HBASE-18446: [~chrajeshbab...@gmail.com] Can you tell us the exact

[jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private

2017-07-27 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104314#comment-16104314 ] Duo Zhang commented on HBASE-18446: --- OK, seems there are lots of conflicts...{{StoreFileReader}} is

[jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private

2017-07-27 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103482#comment-16103482 ] Andrew Purtell commented on HBASE-18446: I don't know of any use cases for the preBulkLoadHFile

[jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private

2017-07-27 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103480#comment-16103480 ] Andrew Purtell commented on HBASE-18446: [~Apache9] Phoenix uses StoreFile and StoreFileReader in

[jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private

2017-07-27 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103197#comment-16103197 ] Duo Zhang commented on HBASE-18446: --- OK, we have this {code:title=RegionObserver.java} /** *

[jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private

2017-07-26 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101225#comment-16101225 ] Duo Zhang commented on HBASE-18446: --- OK, I think it is bit complicated here. In HBASE-6224, seems the