[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159574#comment-16159574
]
Hudson commented on HBASE-18621:
FAILURE: Integrated in Jenkins build HBase-2.0 #480 (See
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159565#comment-16159565
]
Hudson commented on HBASE-18621:
SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #3682 (See
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158370#comment-16158370
]
Chia-Ping Tsai commented on HBASE-18621:
+1. Will commit it tomorrow if no objections.
>
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158157#comment-16158157
]
Hadoop QA commented on HBASE-18621:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155192#comment-16155192
]
Chia-Ping Tsai commented on HBASE-18621:
Would you please add the tests for hashCode/equals?
>
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154921#comment-16154921
]
Hadoop QA commented on HBASE-18621:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153746#comment-16153746
]
Chia-Ping Tsai commented on HBASE-18621:
The fields in ClusterStatus may be null, so the NPE will
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152424#comment-16152424
]
Reid Chan commented on HBASE-18621:
---
thank you [~chia7712]
i will continue HBASE-18609 as soon as it is
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150354#comment-16150354
]
Chia-Ping Tsai commented on HBASE-18621:
LGTM.
[~mdrob] Any suggestions?
> Refactor
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150170#comment-16150170
]
Hadoop QA commented on HBASE-18621:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149128#comment-16149128
]
Chia-Ping Tsai commented on HBASE-18621:
Recently, tests are mainly time out. We have HBASE-18645
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149051#comment-16149051
]
Reid Chan commented on HBASE-18621:
---
QA is a bit long...
> Refactor ClusterOptions before applying to
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148513#comment-16148513
]
Chia-Ping Tsai commented on HBASE-18621:
we need javadoc for getClusterStatus(). Specially
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148403#comment-16148403
]
Hadoop QA commented on HBASE-18621:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147336#comment-16147336
]
Reid Chan commented on HBASE-18621:
---
Any other comments? [~chia7712]
> Refactor ClusterOptions before
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145890#comment-16145890
]
Hadoop QA commented on HBASE-18621:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145455#comment-16145455
]
Hadoop QA commented on HBASE-18621:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145026#comment-16145026
]
Chia-Ping Tsai commented on HBASE-18621:
Could we avoid the "ClusterStatus.Status"? That is
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144162#comment-16144162
]
Hadoop QA commented on HBASE-18621:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143838#comment-16143838
]
Reid Chan commented on HBASE-18621:
---
ping [~chia7712] [~mdrob] for a new review, thanks for your
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143723#comment-16143723
]
Hadoop QA commented on HBASE-18621:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143628#comment-16143628
]
Reid Chan commented on HBASE-18621:
---
I agree, and that's why i marked it private directly in one of the
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143606#comment-16143606
]
Chia-Ping Tsai commented on HBASE-18621:
There is a related issue here. Why do we expose
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137212#comment-16137212
]
Chia-Ping Tsai commented on HBASE-18621:
The changes looks like this.
{code}
enum Option {
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137131#comment-16137131
]
Mike Drob commented on HBASE-18621:
---
I don't know enough about protos to say whether that makes sense
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137032#comment-16137032
]
Chia-Ping Tsai commented on HBASE-18621:
Ditto for the ClusterStatus.proto ? Use *repeated* and
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136903#comment-16136903
]
Mike Drob commented on HBASE-18621:
---
Sure...
{code}
enum Status {
// this doesn't change from your
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136894#comment-16136894
]
Reid Chan commented on HBASE-18621:
---
I think i get it, let me try again.
> Refactor ClusterOptions
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136876#comment-16136876
]
Reid Chan commented on HBASE-18621:
---
Thanks [~mdrob], would you mind writing a piece of pseudocodes to
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136878#comment-16136878
]
Chia-Ping Tsai commented on HBASE-18621:
I like Mike's idea.
> Refactor ClusterOptions before
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136847#comment-16136847
]
Mike Drob commented on HBASE-18621:
---
{code}
+ * ClusterStatus status = admin.getClusterStatus(
+ *
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136709#comment-16136709
]
Reid Chan commented on HBASE-18621:
---
ping [~chia7712] [~mdrob]
if you have time to review
> Refactor
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136699#comment-16136699
]
Hadoop QA commented on HBASE-18621:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134158#comment-16134158
]
Reid Chan commented on HBASE-18621:
---
There is conflict with
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134028#comment-16134028
]
Reid Chan commented on HBASE-18621:
---
It's abnormal, trigger QA again.
> Refactor ClusterOptions before
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134011#comment-16134011
]
Hadoop QA commented on HBASE-18621:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133765#comment-16133765
]
Hadoop QA commented on HBASE-18621:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
37 matches
Mail list logo
