[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407271#comment-16407271
]
Andrew Purtell commented on HBASE-19024:
Thanks [~anoop.hbase], will proceed
> provide a
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403838#comment-16403838
]
Anoop Sam John commented on HBASE-19024:
+1 for doing asyncfswal stuff in another jira. Just can
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403681#comment-16403681
]
Andrew Purtell commented on HBASE-19024:
{quote}So we can enable hsync over hflush at server
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403324#comment-16403324
]
Anoop Sam John commented on HBASE-19024:
setForceSync - to be forceSync ?
isForceSync - Not
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403247#comment-16403247
]
Hadoop QA commented on HBASE-19024:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403167#comment-16403167
]
Andrew Purtell commented on HBASE-19024:
branch-1 patch still applies
> provide a configurable
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301648#comment-16301648
]
Chia-Ping Tsai commented on HBASE-19024:
[~harshaldjain] Would you please rebase the patch? This
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267547#comment-16267547
]
Hadoop QA commented on HBASE-19024:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267537#comment-16267537
]
Hadoop QA commented on HBASE-19024:
---
(!) A patch to the testing environment has been detected.
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267423#comment-16267423
]
Hadoop QA commented on HBASE-19024:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267379#comment-16267379
]
Hadoop QA commented on HBASE-19024:
---
(!) A patch to the testing environment has been detected.
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262949#comment-16262949
]
Harshal Jain commented on HBASE-19024:
--
[~apurtell] [~chia7712] - Please review the changes -
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262936#comment-16262936
]
Hadoop QA commented on HBASE-19024:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262761#comment-16262761
]
Hadoop QA commented on HBASE-19024:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262437#comment-16262437
]
Hadoop QA commented on HBASE-19024:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237195#comment-16237195
]
Harshal Jain commented on HBASE-19024:
--
Sure. I am working on these changes + new unit tests.
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237044#comment-16237044
]
Chia-Ping Tsai commented on HBASE-19024:
HBASE-19024 leave a TODO for this issue. Please also fix
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234631#comment-16234631
]
Chia-Ping Tsai commented on HBASE-19024:
Please revise the comment in {{Durability}}
{code}
/**
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234448#comment-16234448
]
Andrew Purtell commented on HBASE-19024:
Region is the public interface, HRegion is the private
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16233809#comment-16233809
]
Hadoop QA commented on HBASE-19024:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226672#comment-16226672
]
Hadoop QA commented on HBASE-19024:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225385#comment-16225385
]
Chia-Ping Tsai commented on HBASE-19024:
{code}
+ public static final String WAL_HSYNC_CONF_KEY
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225283#comment-16225283
]
Chia-Ping Tsai commented on HBASE-19024:
{code}
+ @Override
+ public void sync(long txid,
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223463#comment-16223463
]
Hadoop QA commented on HBASE-19024:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223034#comment-16223034
]
Andrew Purtell commented on HBASE-19024:
The reported unit test failures are legit and need to be
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223001#comment-16223001
]
Andrew Purtell commented on HBASE-19024:
Changes lgtm.
Let me check these failures locally
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222047#comment-16222047
]
Hadoop QA commented on HBASE-19024:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219728#comment-16219728
]
Andrew Purtell commented on HBASE-19024:
Mostly lgtm, one minor nit:
{code}
diff --git
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216866#comment-16216866
]
Hadoop QA commented on HBASE-19024:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209147#comment-16209147
]
Vikas Vishwakarma commented on HBASE-19024:
---
[~anoop.hbase] we carried few combinations of
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208889#comment-16208889
]
Anoop Sam John commented on HBASE-19024:
More details on the test that u did pls.
Ya make sense
31 matches
Mail list logo
