[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354157#comment-16354157
]
churro morales commented on HBASE-19528:
Thank you for your help [~stack] I really appreciate it
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353888#comment-16353888
]
stack commented on HBASE-19528:
---
I pushed it to branch-1 [~churromorales]
Sorry it was such a pain landing
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353535#comment-16353535
]
Hadoop QA commented on HBASE-19528:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353369#comment-16353369
]
stack commented on HBASE-19528:
---
I call the above a green build. The test failure is unrelated and the
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353363#comment-16353363
]
Hadoop QA commented on HBASE-19528:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353277#comment-16353277
]
stack commented on HBASE-19528:
---
Do nothing seems to pass. Let me retry branch-1.
> Major Compaction Tool
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353258#comment-16353258
]
Hadoop QA commented on HBASE-19528:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353118#comment-16353118
]
stack commented on HBASE-19528:
---
Failures are compiling thrift... Have seen them before. Unrelated to
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353091#comment-16353091
]
churro morales commented on HBASE-19528:
looks like the DoNothingPatch also breaks with
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353088#comment-16353088
]
Hadoop QA commented on HBASE-19528:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352943#comment-16352943
]
stack commented on HBASE-19528:
---
bq. I compiled with 2.4.1 and 2.5.2 locally just fine
Ugh. Not sure what
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352737#comment-16352737
]
churro morales commented on HBASE-19528:
I compiled with 2.4.1 and 2.5.2 locally just fine
>
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352721#comment-16352721
]
Hadoop QA commented on HBASE-19528:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352706#comment-16352706
]
Hadoop QA commented on HBASE-19528:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352703#comment-16352703
]
stack commented on HBASE-19528:
---
Added a do-nothing patch to see if this is just broke. The
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352698#comment-16352698
]
churro morales commented on HBASE-19528:
[~stack] ill try and reproduce, but the patch does not
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352696#comment-16352696
]
churro morales commented on HBASE-19528:
thanks [~stack] ill look at the hadoopcheck issues.
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352690#comment-16352690
]
stack commented on HBASE-19528:
---
[~churromorales] Here are the checkstyle issues
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352675#comment-16352675
]
churro morales commented on HBASE-19528:
[~stack] where did you see those errors? I want to try
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351455#comment-16351455
]
churro morales commented on HBASE-19528:
Yes you are absolutely correct, I'll fix thanks
>
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351446#comment-16351446
]
stack commented on HBASE-19528:
---
[~churromorales] What you think of the hadoop build failures?
[INFO]
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351344#comment-16351344
]
Hadoop QA commented on HBASE-19528:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351343#comment-16351343
]
Hadoop QA commented on HBASE-19528:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351295#comment-16351295
]
stack commented on HBASE-19528:
---
Looks to be getting further on this retry [~churromorales]...
> Major
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350768#comment-16350768
]
churro morales commented on HBASE-19528:
[~stack] I've retried a bunch of times, cant get that
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350759#comment-16350759
]
Hadoop QA commented on HBASE-19528:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349322#comment-16349322
]
stack commented on HBASE-19528:
---
Failed to launch Docker is an infra issue.. See
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349320#comment-16349320
]
Hadoop QA commented on HBASE-19528:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349139#comment-16349139
]
Hadoop QA commented on HBASE-19528:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347955#comment-16347955
]
Hadoop QA commented on HBASE-19528:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347917#comment-16347917
]
Hudson commented on HBASE-19528:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4505 (See
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347779#comment-16347779
]
churro morales commented on HBASE-19528:
oops looks like there was some left over java 1.8 code
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347755#comment-16347755
]
Hadoop QA commented on HBASE-19528:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347713#comment-16347713
]
churro morales commented on HBASE-19528:
squashed and pushed to branch-2 as well, waiting on
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347708#comment-16347708
]
stack commented on HBASE-19528:
---
bq. I'll squash the addendum and master patch and apply it to branch-2 as
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347701#comment-16347701
]
churro morales commented on HBASE-19528:
Thanks [~stack] , I'm putting up the branch-1 patch
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347698#comment-16347698
]
stack commented on HBASE-19528:
---
.001 is the addendum I pushed to master.
+1 on backport to branch-2.
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347697#comment-16347697
]
Hudson commented on HBASE-19528:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4504 (See
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347695#comment-16347695
]
stack commented on HBASE-19528:
---
Pushed patch caused this failure:
Failed
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347564#comment-16347564
]
churro morales commented on HBASE-19528:
Thanks [~apurtell] definitely will go through the usual
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347507#comment-16347507
]
Andrew Purtell commented on HBASE-19528:
+1 for branch-1 from me, as long as tests pass and there
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347307#comment-16347307
]
churro morales commented on HBASE-19528:
pushed to master, will put up branch-2 and branch-1
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345616#comment-16345616
]
churro morales commented on HBASE-19528:
@stack what do you think about me committing this? The
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345611#comment-16345611
]
Hadoop QA commented on HBASE-19528:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345516#comment-16345516
]
Dave Latham commented on HBASE-19528:
-
+1 for v8
> Major Compaction Tool
> --
>
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345514#comment-16345514
]
churro morales commented on HBASE-19528:
Thanks to [~davelatham] for the thorough review, I'm
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334877#comment-16334877
]
churro morales commented on HBASE-19528:
looks like Yu Li is busy, anyone else up for a review?
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324769#comment-16324769
]
Ted Yu commented on HBASE-19528:
If user presses Ctrl+C when MajorCompactor is running, how is cleanup
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324628#comment-16324628
]
churro morales commented on HBASE-19528:
[~tedyu] [~carp84] did you guys get a chance to review?
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320700#comment-16320700
]
churro morales commented on HBASE-19528:
Thank you [~carp84]
> Major Compaction Tool
>
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319618#comment-16319618
]
Yu Li commented on HBASE-19528:
---
bq. While yes the overall goal is similar, there are quite a few things it
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318876#comment-16318876
]
churro morales commented on HBASE-19528:
[~carp84], I looked at the github project over very
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317658#comment-16317658
]
Yu Li commented on HBASE-19528:
---
Just asking, that have you read [this thread|https://s.apache.org/3Uo5] in
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317405#comment-16317405
]
churro morales commented on HBASE-19528:
https://reviews.apache.org/r/65035/
> Major Compaction
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317374#comment-16317374
]
Ted Yu commented on HBASE-19528:
Please upload next patch to reviewboard.
> Major Compaction Tool
>
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317308#comment-16317308
]
churro morales commented on HBASE-19528:
Thanks [~tedyu] ill look over those changes and submit a
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317298#comment-16317298
]
Ted Yu commented on HBASE-19528:
Please add license header to the new files.
Also add audience
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317250#comment-16317250
]
Hadoop QA commented on HBASE-19528:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316925#comment-16316925
]
churro morales commented on HBASE-19528:
After review, I can put up backports. Thanks
> Major
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295869#comment-16295869
]
Dave Latham commented on HBASE-19528:
-
For this column family, we have disabled scheduled major
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295861#comment-16295861
]
stack commented on HBASE-19528:
---
[~churromorales] Yes. Thanks. You have turned off native hbase compactions
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295511#comment-16295511
]
Dave Latham commented on HBASE-19528:
-
Adding a couple notes - we wanted to avoid filling up the
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295491#comment-16295491
]
churro morales commented on HBASE-19528:
[~stack]
To answer your questions, we figure out
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293921#comment-16293921
]
Anastasia Braginsky commented on HBASE-19528:
-
Thanks [~stack]! Great initiative! And I have
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293458#comment-16293458
]
stack commented on HBASE-19528:
---
And you've seen the CompactionTool we already have in the code base
[
https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293439#comment-16293439
]
stack commented on HBASE-19528:
---
How you tell the region about the newly compacted files [~churromorales]?
66 matches
Mail list logo
