[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369633#comment-16369633
]
Hudson commented on HBASE-19950:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4614 (See
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368819#comment-16368819
]
Anoop Sam John commented on HBASE-19950:
Only on those specific cases, this filter to be used.
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368272#comment-16368272
]
Chia-Ping Tsai commented on HBASE-19950:
ping [~anoop.hbase]. Any comment? Does [~reidchan]
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367687#comment-16367687
]
Chia-Ping Tsai commented on HBASE-19950:
+1. Will commit it tomorrow if no objection.
This new
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362120#comment-16362120
]
Hadoop QA commented on HBASE-19950:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361956#comment-16361956
]
Reid Chan commented on HBASE-19950:
---
Fix two checkstyle warnings.
> Introduce a ColumnValueFilter
>
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360750#comment-16360750
]
Hadoop QA commented on HBASE-19950:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360570#comment-16360570
]
Reid Chan commented on HBASE-19950:
---
Trigger QA again
> Introduce a ColumnValueFilter
>
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360316#comment-16360316
]
Reid Chan commented on HBASE-19950:
---
I uploaded a wrong v8 patch...
> Introduce a ColumnValueFilter
>
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360315#comment-16360315
]
Reid Chan commented on HBASE-19950:
---
v8 patch adds javadoc for method
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360030#comment-16360030
]
Mike Drob commented on HBASE-19950:
---
nit: javadoc on createFilterFromArguments please
> Introduce a
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359775#comment-16359775
]
Reid Chan commented on HBASE-19950:
---
Do you mean this filter should not read other CFs?
bq. projecting
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359619#comment-16359619
]
Hadoop QA commented on HBASE-19950:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359542#comment-16359542
]
Anoop Sam John commented on HBASE-19950:
When we go with projecting only required column, only
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359505#comment-16359505
]
Reid Chan commented on HBASE-19950:
---
v7 patch fixed {{MethodLength}} checkstyle.
> Introduce a
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359464#comment-16359464
]
Hadoop QA commented on HBASE-19950:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359423#comment-16359423
]
Reid Chan commented on HBASE-19950:
---
Add {{FilterList}} cases (both PASS_ALL and PASS_ONE)
> Introduce
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359385#comment-16359385
]
Chia-Ping Tsai commented on HBASE-19950:
Given we said this new filter is practical for filter
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359380#comment-16359380
]
Hadoop QA commented on HBASE-19950:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359366#comment-16359366
]
Hadoop QA commented on HBASE-19950:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359332#comment-16359332
]
Reid Chan commented on HBASE-19950:
---
Nice review! Please check v5 patch if i got your mind
> Introduce
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359325#comment-16359325
]
Chia-Ping Tsai commented on HBASE-19950:
If the specified column of current row is found, could
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359313#comment-16359313
]
Reid Chan commented on HBASE-19950:
---
Thanks for the review Chia-Ping, v4 patch addressed your comments.
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359224#comment-16359224
]
Chia-Ping Tsai commented on HBASE-19950:
1) Why we don't allow user to pass the null qualifier?
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357975#comment-16357975
]
Reid Chan commented on HBASE-19950:
---
WDYT, [~anoop.hbase]
> Introduce a ColumnValueFilter
>
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357175#comment-16357175
]
Hadoop QA commented on HBASE-19950:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357085#comment-16357085
]
Reid Chan commented on HBASE-19950:
---
I got your mind, and thought over this Q myself.
When query comes
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357037#comment-16357037
]
Anoop Sam John commented on HBASE-19950:
One Q. In such a requirement, why we can not project
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356979#comment-16356979
]
Peter Somogyi commented on HBASE-19950:
---
+1
Thanks for addressing my review comments!
> Introduce
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356847#comment-16356847
]
Hadoop QA commented on HBASE-19950:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356832#comment-16356832
]
Reid Chan commented on HBASE-19950:
---
Thanks for the review [~psomogyi], i'll upload a new patch later.
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356825#comment-16356825
]
Peter Somogyi commented on HBASE-19950:
---
Nice patch [~reidchan]!
+1
A few nits:
* Import order
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356705#comment-16356705
]
Reid Chan commented on HBASE-19950:
---
Fixed checkstyle warning.
> Introduce a ColumnValueFilter
>
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356659#comment-16356659
]
Hadoop QA commented on HBASE-19950:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356534#comment-16356534
]
Reid Chan commented on HBASE-19950:
---
UTs passed on local machine. And following are the results from
[
https://issues.apache.org/jira/browse/HBASE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356526#comment-16356526
]
Reid Chan commented on HBASE-19950:
---
BTW, in {{ParseFilter}}, it is method {{# createCompareOp}}
36 matches
Mail list logo
