[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728377#comment-16728377
]
Hudson commented on HBASE-20136:
Results for branch branch-2
[build #1575 on
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728371#comment-16728371
]
Hudson commented on HBASE-20136:
Results for branch branch-2.1
[build #709 on
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728335#comment-16728335
]
Hudson commented on HBASE-20136:
Results for branch branch-2.0
[build #1192 on
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728027#comment-16728027
]
stack commented on HBASE-20136:
---
Linking follow-on JIRA on how best to find tests that are absent Category
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727941#comment-16727941
]
Hadoop QA commented on HBASE-20136:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727814#comment-16727814
]
stack commented on HBASE-20136:
---
.001 Backport to branch-2. Took a bit of jiggering so let the build check
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727812#comment-16727812
]
stack commented on HBASE-20136:
---
Thanks for the pointer here [~psomogyi]. Let me backport (this test is
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727568#comment-16727568
]
Hadoop QA commented on HBASE-20136:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727564#comment-16727564
]
Peter Somogyi commented on HBASE-20136:
---
I've just returned here from HBASE-21633 and found this
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391253#comment-16391253
]
Duo Zhang commented on HBASE-20136:
---
I have already placed my statement many times on this. The way we
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391249#comment-16391249
]
Josh Elser commented on HBASE-20136:
[~Apache9] if you cannot give me a technical justification for
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390699#comment-16390699
]
Duo Zhang commented on HBASE-20136:
---
Filed HBASE-20154 to address the missing category problem. Let's
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390690#comment-16390690
]
Josh Elser commented on HBASE-20136:
[~Apache9], I 100% understand what you are saying. I feel like
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390656#comment-16390656
]
Duo Zhang commented on HBASE-20136:
---
For now if you do not have a category then your test will never be
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390653#comment-16390653
]
Josh Elser commented on HBASE-20136:
bq, I mean the 'categories.length == 0' check in the addendum,
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390642#comment-16390642
]
Duo Zhang commented on HBASE-20136:
---
I mean the 'categories.length == 0' check in the addendum, not the
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390630#comment-16390630
]
Josh Elser commented on HBASE-20136:
{quote}My point is, we should not add code which will never be
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390564#comment-16390564
]
Duo Zhang commented on HBASE-20136:
---
My point is, we should not add code which will never be
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390551#comment-16390551
]
Josh Elser commented on HBASE-20136:
{quote}The problem is, we can not find the test which does not
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390524#comment-16390524
]
Duo Zhang commented on HBASE-20136:
---
{quote}
I'm a bit confused then, Duo. By that logic, you're saying
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390513#comment-16390513
]
Josh Elser commented on HBASE-20136:
{quote}So I do not think it is necessary to improve the test
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390487#comment-16390487
]
Hadoop QA commented on HBASE-20136:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390464#comment-16390464
]
Hadoop QA commented on HBASE-20136:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390456#comment-16390456
]
Duo Zhang commented on HBASE-20136:
---
As I said many times in this issue, we will not run a test if does
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390433#comment-16390433
]
Josh Elser commented on HBASE-20136:
Addendum looks like it would fix this issue for the future, but
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390407#comment-16390407
]
Ted Yu commented on HBASE-20136:
Agreed that HBaseClassTestRuleChecker can be enhanced.
Attached an
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390358#comment-16390358
]
Josh Elser commented on HBASE-20136:
{noformat}
Caused by: java.lang.ArrayIndexOutOfBoundsException:
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389713#comment-16389713
]
Josh Elser commented on HBASE-20136:
bq. The junit 3/4 style is not the problem, we must have a
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389114#comment-16389114
]
Duo Zhang commented on HBASE-20136:
---
{quote}
I spent some time digging the effect of -projects command
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389102#comment-16389102
]
Duo Zhang commented on HBASE-20136:
---
{quote}
I guess that means we need to check out all of the tests
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389000#comment-16389000
]
Ted Yu commented on HBASE-20136:
I spent some time digging the effect of -projects command line parameter
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388731#comment-16388731
]
Hudson commented on HBASE-20136:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4702 (See
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388296#comment-16388296
]
Ted Yu commented on HBASE-20136:
I should have put more background on how this test was found (not
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388278#comment-16388278
]
stack commented on HBASE-20136:
---
Problems with this issue:
* Out of left field a test is reported as
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387933#comment-16387933
]
Josh Elser commented on HBASE-20136:
{quote}Seems the problem is that, there is no small|medium|large
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387189#comment-16387189
]
Ted Yu commented on HBASE-20136:
The assertion above the catch is supposed to fail (due to bad
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387168#comment-16387168
]
Duo Zhang commented on HBASE-20136:
---
{code}
-} catch (junit.framework.AssertionFailedError e) {
+
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387165#comment-16387165
]
Hadoop QA commented on HBASE-20136:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387085#comment-16387085
]
stack commented on HBASE-20136:
---
Thanks [~Apache9] for identifying the actual issue.
> TestKeyValue misses
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387060#comment-16387060
]
Duo Zhang commented on HBASE-20136:
---
Seems the problem is that, there is no small|medium|large category
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387051#comment-16387051
]
Ted Yu commented on HBASE-20136:
Not in a hurry to commit.
bq. the rules actually work
I think it does,
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387037#comment-16387037
]
Duo Zhang commented on HBASE-20136:
---
Hold on committing. This is junit3 style test, I wonder whether
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387035#comment-16387035
]
Ted Yu commented on HBASE-20136:
bq. Why does the build not fail?
The following command can reproduce
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387006#comment-16387006
]
stack commented on HBASE-20136:
---
Why did HBaseClassTestRuleChecker not find this?
Why does the build not
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387001#comment-16387001
]
Hadoop QA commented on HBASE-20136:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386980#comment-16386980
]
Umesh Agashe commented on HBASE-20136:
--
+1 lgtm
> TestKeyValue misses ClassRule and Category
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386948#comment-16386948
]
Peter Somogyi commented on HBASE-20136:
---
+1
> TestKeyValue misses ClassRule and Category
[
https://issues.apache.org/jira/browse/HBASE-20136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386933#comment-16386933
]
Ted Yu commented on HBASE-20136:
This was discovered due to the following test error:
{code}
Tests run:
48 matches
Mail list logo
