[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874099#comment-16874099
]
Hudson commented on HBASE-20894:
Results for branch branch-2
[build #2029 on
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573011#comment-16573011
]
Anoop Sam John commented on HBASE-20894:
RL looks good.
> Move BucketCache from java
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571920#comment-16571920
]
Sean Busbey commented on HBASE-20894:
-
what happens to the old state? does it just get ignored
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571917#comment-16571917
]
Mike Drob commented on HBASE-20894:
---
bq. This change is affecting only the persisting cache. Even if
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571864#comment-16571864
]
Sean Busbey commented on HBASE-20894:
-
please file a follow-on jira to get the ref guide updated to
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567714#comment-16567714
]
Anoop Sam John commented on HBASE-20894:
This change is affecting only the persisting cache.
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1651#comment-1651
]
Hudson commented on HBASE-20894:
Results for branch master
[build #416 on
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566034#comment-16566034
]
Ted Yu commented on HBASE-20894:
No additional comment.
> Move BucketCache from java serialization to
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566029#comment-16566029
]
Mike Drob commented on HBASE-20894:
---
[~tedyu] - any additional comments?
> Move BucketCache from java
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566021#comment-16566021
]
Hadoop QA commented on HBASE-20894:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565897#comment-16565897
]
Hadoop QA commented on HBASE-20894:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565691#comment-16565691
]
stack commented on HBASE-20894:
---
bq. but don't think dropping the leading "is" is correct.
It is
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565677#comment-16565677
]
Mike Drob commented on HBASE-20894:
---
bq. required bool isPrimaryReplicaBlock = 4; is a bad name for a
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565652#comment-16565652
]
stack commented on HBASE-20894:
---
nit: 49 required bool isPrimaryReplicaBlock = 4; is a bad name for a
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564390#comment-16564390
]
Hadoop QA commented on HBASE-20894:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564174#comment-16564174
]
Mike Drob commented on HBASE-20894:
---
v4: does away with the UniqueIndexMap at stack's suggestion,
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562636#comment-16562636
]
stack commented on HBASE-20894:
---
bq. So the old code works because there's only one id ever registered?
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562573#comment-16562573
]
Mike Drob commented on HBASE-20894:
---
Thanks for the additional insight, [~stack]. Doing a further
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562077#comment-16562077
]
stack commented on HBASE-20894:
---
bq. removing the deserializer map would break compatibility between the
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562027#comment-16562027
]
Mike Drob commented on HBASE-20894:
---
[~stack] - removing the deserializer map would break
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560907#comment-16560907
]
Hadoop QA commented on HBASE-20894:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560894#comment-16560894
]
stack commented on HBASE-20894:
---
Added a suggestion (See
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560487#comment-16560487
]
Hadoop QA commented on HBASE-20894:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560323#comment-16560323
]
Mike Drob commented on HBASE-20894:
---
Address the checkstyle issues.
I was looking at this closer, and
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558834#comment-16558834
]
Hadoop QA commented on HBASE-20894:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556331#comment-16556331
]
Mike Drob commented on HBASE-20894:
---
I added the access counter to the list of things getting
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551358#comment-16551358
]
Ted Yu commented on HBASE-20894:
I was running related unit tests and got the following ?
{code}
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551155#comment-16551155
]
Mike Drob commented on HBASE-20894:
---
Conversion is almost done, still needs some more testing, a
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548729#comment-16548729
]
Mike Drob commented on HBASE-20894:
---
There are specific security issues with Java Object Serialization
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548550#comment-16548550
]
Vladimir Rodionov commented on HBASE-20894:
---
I do not see how protobuf helps here with
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548354#comment-16548354
]
Mike Drob commented on HBASE-20894:
---
Do you have a suggestion of a different library? It's also nice
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548330#comment-16548330
]
Vladimir Rodionov commented on HBASE-20894:
---
I was asked some times ago to replace all java
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548269#comment-16548269
]
Mike Drob commented on HBASE-20894:
---
Thanks for asking, [~vrodionov].
Java object serialization is
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548231#comment-16548231
]
Vladimir Rodionov commented on HBASE-20894:
---
[~md...@cloudera.com], I am going to ping you one
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545773#comment-16545773
]
Vladimir Rodionov commented on HBASE-20894:
---
What are criteria of "better", [~mdrob]? Protobuf
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545671#comment-16545671
]
Mike Drob commented on HBASE-20894:
---
Want to check with folks to see if there is agreement that this
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545614#comment-16545614
]
Mike Drob commented on HBASE-20894:
---
Hmm, starting to try to do the actual read/write here and maybe
[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545516#comment-16545516
]
Mike Drob commented on HBASE-20894:
---
Attaching WIP patch that includes the proposed new proto
38 matches
Mail list logo
