[jira] [Commented] (HBASE-20910) Fix dev-support/submit-patch.py by opening file with 'b' mode

[ https://issues.apache.org/jira/browse/HBASE-20910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959289#comment-16959289 ] Ankit Singhal commented on HBASE-20910: --- It seems [~yuzhih...@gmail.com] already committed this

[jira] [Commented] (HBASE-20910) Fix dev-support/submit-patch.py by opening file with 'b' mode

[ https://issues.apache.org/jira/browse/HBASE-20910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814773#comment-16814773 ] Josh Elser commented on HBASE-20910: Looks to me like someone has already made this change. > Fix

[jira] [Commented] (HBASE-20910) Fix dev-support/submit-patch.py by opening file with 'b' mode

[ https://issues.apache.org/jira/browse/HBASE-20910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813825#comment-16813825 ] Ankit Singhal commented on HBASE-20910: --- Was just clearing my open JIRAs and found this.

[jira] [Commented] (HBASE-20910) Fix dev-support/submit-patch.py by opening file with 'b' mode

[ https://issues.apache.org/jira/browse/HBASE-20910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551679#comment-16551679 ] Hudson commented on HBASE-20910: Results for branch master [build #403 on

[jira] [Commented] (HBASE-20910) Fix dev-support/submit-patch.py by opening file with 'b' mode

[ https://issues.apache.org/jira/browse/HBASE-20910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551381#comment-16551381 ] Ted Yu commented on HBASE-20910: Thanks for the patch, Ankit Thanks for the review, Mike > Fix

[jira] [Commented] (HBASE-20910) Fix dev-support/submit-patch.py

[ https://issues.apache.org/jira/browse/HBASE-20910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549882#comment-16549882 ] Mike Drob commented on HBASE-20910: --- Yea, I ran a few experiments locally and you're right that it's

[jira] [Commented] (HBASE-20910) Fix dev-support/submit-patch.py

[ https://issues.apache.org/jira/browse/HBASE-20910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549875#comment-16549875 ] Ankit Singhal commented on HBASE-20910: --- bq. I think this will break python2? bq. In python2,

[jira] [Commented] (HBASE-20910) Fix dev-support/submit-patch.py

[ https://issues.apache.org/jira/browse/HBASE-20910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549818#comment-16549818 ] Mike Drob commented on HBASE-20910: --- I think this will break python2? In python2, git.format_patch

[jira] [Commented] (HBASE-20910) Fix dev-support/submit-patch.py

[ https://issues.apache.org/jira/browse/HBASE-20910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549804#comment-16549804 ] Ted Yu commented on HBASE-20910: [~appy] [~mdrob]: Can you review ? Thanks > Fix