[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430266#comment-17430266
]
Andrew Kyle Purtell commented on HBASE-21154:
-
[~vjasani] I'd say if you want to give this a
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428331#comment-17428331
]
Sean Busbey commented on HBASE-21154:
-
FWIW I think it would benefit us for many reasons to get this
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428068#comment-17428068
]
Viraj Jasani commented on HBASE-21154:
--
Coming here after resolving a painful cluster outage where
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702016#comment-16702016
]
stack commented on HBASE-21154:
---
bq. The code for synchronous replication has only been merged to master
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701469#comment-16701469
]
Duo Zhang commented on HBASE-21154:
---
The code for synchronous replication has only been merged to
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700718#comment-16700718
]
Sean Busbey commented on HBASE-21154:
-
I'd like to see a draft of the docs for Upgrade Consideration
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700714#comment-16700714
]
Pankaj Kumar commented on HBASE-21154:
--
[~stack] Sir, It would be great if we have this improvement
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700695#comment-16700695
]
stack commented on HBASE-21154:
---
Pardon the misnaming, but yeah, synchronous replication doesn't work till
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699984#comment-16699984
]
Duo Zhang commented on HBASE-21154:
---
It is synchronous replication, not serial replication :)
>
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699976#comment-16699976
]
stack commented on HBASE-21154:
---
bq. For me I think it should be 3.0.0 only, as this is a big change,
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699965#comment-16699965
]
Duo Zhang commented on HBASE-21154:
---
For me I think it should be 3.0.0 only, as this is a big change,
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699953#comment-16699953
]
stack commented on HBASE-21154:
---
Is this a 3.0.0 only fix? We don't want this in 2.2.0? Or, should we do
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699014#comment-16699014
]
Duo Zhang commented on HBASE-21154:
---
You can either leave comments here or on the review board, I will
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699010#comment-16699010
]
Sean Busbey commented on HBASE-21154:
-
bq. HBASE-21508 has been committed, so let me commit the
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699005#comment-16699005
]
Sean Busbey commented on HBASE-21154:
-
bq. Sean Busbey Do you have any cycles to review the patch? I
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698823#comment-16698823
]
Hudson commented on HBASE-21154:
Results for branch master
[build #629 on
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698531#comment-16698531
]
Duo Zhang commented on HBASE-21154:
---
HBASE-21508 has been committed, so let me commit the patch here
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697665#comment-16697665
]
Duo Zhang commented on HBASE-21154:
---
[~busbey] Do you have any cycles to review the patch? I plan to
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697276#comment-16697276
]
Hadoop QA commented on HBASE-21154:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697015#comment-16697015
]
Duo Zhang commented on HBASE-21154:
---
Fix checkstyle issue, and also address the comment problem from
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696651#comment-16696651
]
Hadoop QA commented on HBASE-21154:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696649#comment-16696649
]
Peter Somogyi commented on HBASE-21154:
---
I tried again the migration with patch v6 and it works as
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696462#comment-16696462
]
Duo Zhang commented on HBASE-21154:
---
The patch v6 added a TestMigrateNamespaceTable to confirm that
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696406#comment-16696406
]
Duo Zhang commented on HBASE-21154:
---
Let me try to write an UT for the migration data.
> Remove
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696204#comment-16696204
]
Peter Somogyi commented on HBASE-21154:
---
Using an existing hbase-root directory fails when
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696126#comment-16696126
]
Hadoop QA commented on HBASE-21154:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695987#comment-16695987
]
Allan Yang commented on HBASE-21154:
{quote}
And for safety, maybe we should only disable the
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695739#comment-16695739
]
Hadoop QA commented on HBASE-21154:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695600#comment-16695600
]
Duo Zhang commented on HBASE-21154:
---
OK there is a problem that we should disable the namespace table
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695434#comment-16695434
]
Sean Busbey commented on HBASE-21154:
-
I would like to review, have started but need time. (in case
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694641#comment-16694641
]
Hadoop QA commented on HBASE-21154:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694323#comment-16694323
]
Hadoop QA commented on HBASE-21154:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694295#comment-16694295
]
Duo Zhang commented on HBASE-21154:
---
Review board link:
https://reviews.apache.org/r/69418/
> Remove
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694183#comment-16694183
]
stack commented on HBASE-21154:
---
I suppose rolling upgrade will just pick up new hardcoded meta then.
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694083#comment-16694083
]
Duo Zhang commented on HBASE-21154:
---
Adding new CF to hbase:meta is easy, just change the code, it
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693542#comment-16693542
]
stack commented on HBASE-21154:
---
Thanks for taking a look [~reidchan]
Patch looks great so far. Is adding
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693481#comment-16693481
]
Hadoop QA commented on HBASE-21154:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692888#comment-16692888
]
Duo Zhang commented on HBASE-21154:
---
The comment says region server will consume the information but
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692759#comment-16692759
]
Reid Chan commented on HBASE-21154:
---
{quote}ACL keeps cache of namespace names? The watcher triggers
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692704#comment-16692704
]
stack commented on HBASE-21154:
---
Looking at original patch, only ZNNamespaceManager references the
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692688#comment-16692688
]
stack commented on HBASE-21154:
---
bq. So what's purpose for ZKNamespaceManager?
It was there when
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692556#comment-16692556
]
Duo Zhang commented on HBASE-21154:
---
So what's purpose for ZKNamespaceManager? It will publish
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691300#comment-16691300
]
Duo Zhang commented on HBASE-21154:
---
OK when testing sync replication, I found that this problem lead
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605310#comment-16605310
]
stack commented on HBASE-21154:
---
Folding in acl too sounds good.
bq. thought I had heard chatter of
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605248#comment-16605248
]
Allan Yang commented on HBASE-21154:
+1 for folding it to hbase:meta. For now, we must wait before
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605182#comment-16605182
]
Duo Zhang commented on HBASE-21154:
---
What about the acl table? Do we want to fold into meta table too?
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605043#comment-16605043
]
Zach York commented on HBASE-21154:
---
I have a small concern (not with the actual change, but with the
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604993#comment-16604993
]
Sean Busbey commented on HBASE-21154:
-
bq. Could also assert that there is no system table but meta.
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604987#comment-16604987
]
stack commented on HBASE-21154:
---
bq. also could we document some considerations for the future about how
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604980#comment-16604980
]
stack commented on HBASE-21154:
---
[~mdrob] One thought is that adding to hbase:meta schema is tough given
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604903#comment-16604903
]
Sean Busbey commented on HBASE-21154:
-
also could we document some considerations for the future
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604901#comment-16604901
]
Sean Busbey commented on HBASE-21154:
-
given our community desire to make future major versions
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604868#comment-16604868
]
stack commented on HBASE-21154:
---
[~mdrob] Not sure. We tried to hide all access behind the
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604859#comment-16604859
]
Mike Drob commented on HBASE-21154:
---
this needs 3.0? or it can be in branch-2 you think?
> Remove
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604852#comment-16604852
]
Esteban Gutierrez commented on HBASE-21154:
---
+1
> Remove hbase:namespace table; fold it into
55 matches
Mail list logo
