[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657809#comment-16657809
]
Hudson commented on HBASE-21291:
Results for branch branch-2.1
[build #496 on
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657801#comment-16657801
]
Hudson commented on HBASE-21291:
Results for branch branch-2.0
[build #979 on
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656211#comment-16656211
]
Hudson commented on HBASE-21291:
Results for branch branch-2.1
[build #486 on
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656181#comment-16656181
]
Hudson commented on HBASE-21291:
Results for branch branch-2.0
[build #971 on
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655396#comment-16655396
]
stack commented on HBASE-21291:
---
bq. Thus if the procedure is stuck at a state (like stuck in a while
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655381#comment-16655381
]
Jingyun Tian commented on HBASE-21291:
--
[~stack]
I think if we need restart master depends on
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655218#comment-16655218
]
stack commented on HBASE-21291:
---
[~allan163] HBASE-21335 is to make a change in another repo, the hbck2
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655140#comment-16655140
]
Allan Yang commented on HBASE-21291:
Is HBASE-21335 filed to resolve the problem here?
> Add a test
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654846#comment-16654846
]
Jingyun Tian commented on HBASE-21291:
--
[~stack] I add the condition check to all procedures, not
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654628#comment-16654628
]
stack commented on HBASE-21291:
---
So, if override is set, make the waitTime some nominal amount -- say
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654621#comment-16654621
]
stack commented on HBASE-21291:
---
Also interesting is that I must pass waitTime of non-zero even when
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654619#comment-16654619
]
stack commented on HBASE-21291:
---
Is it possible that bypass no longer works. IIRC, I could bypass a stuck
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654608#comment-16654608
]
stack commented on HBASE-21291:
---
0 means wait forever I suppose? But I don't want to wait at all
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654561#comment-16654561
]
Jingyun Tian commented on HBASE-21291:
--
[~stack] hbase-operator-tools set the lockwait to 0 if we
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654551#comment-16654551
]
stack commented on HBASE-21291:
---
i.e. previously, I did not have to pass a lockWait value...
> Add a test
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654548#comment-16654548
]
stack commented on HBASE-21291:
---
[~tianjingyun] With this patch applied, now when I do bypass it does the
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653509#comment-16653509
]
Hudson commented on HBASE-21291:
Results for branch master
[build #551 on
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652720#comment-16652720
]
stack commented on HBASE-21291:
---
Let me test and see if we should pull it back further, into 2.0 and 2.1.
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652661#comment-16652661
]
Hudson commented on HBASE-21291:
Results for branch branch-2
[build #1399 on
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651776#comment-16651776
]
Allan Yang commented on HBASE-21291:
Sure, can you give me your E-mail, so I can include you name
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651476#comment-16651476
]
Jingyun Tian commented on HBASE-21291:
--
[~stack] Could you help commit this patch?
> Add a test
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649695#comment-16649695
]
Jingyun Tian commented on HBASE-21291:
--
[~allan163] Could you help commit this patch?
> Add a test
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648902#comment-16648902
]
Hadoop QA commented on HBASE-21291:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648834#comment-16648834
]
Hadoop QA commented on HBASE-21291:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648753#comment-16648753
]
stack commented on HBASE-21291:
---
Ok. Let me try testing it on cluster. Thanks.
> Add a test for bypassing
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648751#comment-16648751
]
Jingyun Tian commented on HBASE-21291:
--
[~stack] Yes, I think pass one second or a certain number
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648750#comment-16648750
]
stack commented on HBASE-21291:
---
Sorry for the dumb questions, so problem is that we've been passing '0'
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648745#comment-16648745
]
Hadoop QA commented on HBASE-21291:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648739#comment-16648739
]
Jingyun Tian commented on HBASE-21291:
--
{code}
IdLock.Entry lockEntry =
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648735#comment-16648735
]
stack commented on HBASE-21291:
---
Is there a fix here [~tianjingyun]? If bypass is called what happens?
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648730#comment-16648730
]
Jingyun Tian commented on HBASE-21291:
--
[~stack] Just uploaded the fixed one. Sorry for the late.
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648216#comment-16648216
]
stack commented on HBASE-21291:
---
Is the fix in the latest patch? If so, I don't see it (Pardon my
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647751#comment-16647751
]
Allan Yang commented on HBASE-21291:
{quote}
+Preconditions.checkArgument(lockWait > 0 ||
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647700#comment-16647700
]
Hadoop QA commented on HBASE-21291:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647579#comment-16647579
]
Jingyun Tian commented on HBASE-21291:
--
[~stack] We can skip getting lock by set force to true. But
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647484#comment-16647484
]
Hadoop QA commented on HBASE-21291:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647466#comment-16647466
]
stack commented on HBASE-21291:
---
[~tianjingyun] Great. What [~allan163] said.
How we fix this so
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647450#comment-16647450
]
Allan Yang commented on HBASE-21291:
{code}
+ProcedureTestingUtility.restart(procExecutor);
[
https://issues.apache.org/jira/browse/HBASE-21291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647345#comment-16647345
]
Jingyun Tian commented on HBASE-21291:
--
[~stack] A patch contains stuck state machine procedure is
39 matches
Mail list logo
