[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169628#comment-17169628
]
Lars Hofhansl commented on HBASE-24742:
---
Re: Tests. This is purely an internal optimization of
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162795#comment-17162795
]
Hudson commented on HBASE-24742:
Results for branch branch-2.3
[build #189 on
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162382#comment-17162382
]
Nick Dimiduk commented on HBASE-24742:
--
bq. Looks like HBASE-19863 added some coverage. Do we need
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162268#comment-17162268
]
Bharath Vissapragada commented on HBASE-24742:
--
Looks like HBASE-19863 added some
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162235#comment-17162235
]
Nick Dimiduk commented on HBASE-24742:
--
I'm still retrying toward a passing precommit run for
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160250#comment-17160250
]
Hudson commented on HBASE-24742:
Results for branch branch-2.2
[build #915 on
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159872#comment-17159872
]
Hudson commented on HBASE-24742:
Results for branch branch-1
[build #1327 on
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159861#comment-17159861
]
Hudson commented on HBASE-24742:
Results for branch master
[build #1787 on
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159706#comment-17159706
]
Hudson commented on HBASE-24742:
Results for branch branch-2
[build #2748 on
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159456#comment-17159456
]
Andrew Kyle Purtell commented on HBASE-24742:
-
Sounds good. The other issue is available for
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159444#comment-17159444
]
Lars Hofhansl commented on HBASE-24742:
---
Master (and branch-2) patch. Will just apply as they're
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159385#comment-17159385
]
Lars Hofhansl commented on HBASE-24742:
---
Merged into branch-1.
I'll look into master/branch-2,
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158497#comment-17158497
]
Lars Hofhansl commented on HBASE-24742:
---
Created a PR for observation #1 above.
> Improve
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158167#comment-17158167
]
Duo Zhang commented on HBASE-24742:
---
{quote}
I'm not sure how we can avoid passing the fake keys up,
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157895#comment-17157895
]
Lars Hofhansl commented on HBASE-24742:
---
Upon second thought. Perhaps a seek (not a reseek, but a
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157890#comment-17157890
]
Lars Hofhansl commented on HBASE-24742:
---
[~zhangduo] I'm with you there. The second part was
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157815#comment-17157815
]
Duo Zhang commented on HBASE-24742:
---
And on the fake cell, maybe we should not pass it to upper layer?
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157807#comment-17157807
]
Bharath Vissapragada commented on HBASE-24742:
--
> I think the discussion in HBASE-17958 is
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157791#comment-17157791
]
Andrew Kyle Purtell commented on HBASE-24742:
-
There is an actual regression in SKIP hint
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157787#comment-17157787
]
Duo Zhang commented on HBASE-24742:
---
I think the discussion in HBASE-17958 is enough to show that the
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157779#comment-17157779
]
Lars Hofhansl commented on HBASE-24742:
---
Passes the test added in HBASE-19863 and brings the
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157776#comment-17157776
]
Bharath Vissapragada commented on HBASE-24742:
--
To add more color, following is the tight
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157775#comment-17157775
]
Lars Hofhansl commented on HBASE-24742:
---
Here's a patch.
Please have a careful look, especially at
[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157774#comment-17157774
]
Lars Hofhansl commented on HBASE-24742:
---
There are two observations:
1. We do not need for "fake"
24 matches
Mail list logo
