[jira] [Commented] (HBASE-4716) Improve locking for single column family bulk load

2011-11-02 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142026#comment-13142026 ] Ted Yu commented on HBASE-4716: --- closeBulkRegionOperation() is at the beginning of finally

[jira] [Commented] (HBASE-4716) Improve locking for single column family bulk load

2011-11-02 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142172#comment-13142172 ] stack commented on HBASE-4716: -- Thanks. +1 on commit. Improve locking for

[jira] [Commented] (HBASE-4716) Improve locking for single column family bulk load

2011-11-02 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142257#comment-13142257 ] Ted Yu commented on HBASE-4716: --- Integrated to 0.92 and TRUNK. Thanks for the review Todd

[jira] [Commented] (HBASE-4716) Improve locking for single column family bulk load

2011-11-02 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142326#comment-13142326 ] Todd Lipcon commented on HBASE-4716: this was already committed, but I just got to my

[jira] [Commented] (HBASE-4716) Improve locking for single column family bulk load

2011-11-02 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142339#comment-13142339 ] Ted Yu commented on HBASE-4716: --- When creating a method for hasMultipleColumnFamilies(), I

[jira] [Commented] (HBASE-4716) Improve locking for single column family bulk load

2011-11-02 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142361#comment-13142361 ] Ted Yu commented on HBASE-4716: --- When familyPaths is null, hasMultipleColumnFamilies()

[jira] [Commented] (HBASE-4716) Improve locking for single column family bulk load

2011-11-02 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142399#comment-13142399 ] Todd Lipcon commented on HBASE-4716: +1 on addendum, thanks Ted

[jira] [Commented] (HBASE-4716) Improve locking for single column family bulk load

2011-11-02 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142643#comment-13142643 ] Hudson commented on HBASE-4716: --- Integrated in HBase-TRUNK #2402 (See

[jira] [Commented] (HBASE-4716) Improve locking for single column family bulk load

2011-11-01 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141389#comment-13141389 ] Todd Lipcon commented on HBASE-4716: - style: should move if statement bodies to own

[jira] [Commented] (HBASE-4716) Improve locking for single column family bulk load

2011-11-01 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141410#comment-13141410 ] Ted Yu commented on HBASE-4716: --- bq. - in the case that this.closed flips true, it's calling

[jira] [Commented] (HBASE-4716) Improve locking for single column family bulk load

2011-11-01 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141423#comment-13141423 ] Todd Lipcon commented on HBASE-4716: {code} +if (writeLockNeeded)

[jira] [Commented] (HBASE-4716) Improve locking for single column family bulk load

2011-11-01 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141473#comment-13141473 ] Hadoop QA commented on HBASE-4716: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-4716) Improve locking for single column family bulk load

2011-11-01 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141575#comment-13141575 ] Hadoop QA commented on HBASE-4716: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-4716) Improve locking for single column family bulk load

2011-11-01 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141599#comment-13141599 ] Ted Yu commented on HBASE-4716: --- The failed tests were due to 'Too many open files'

[jira] [Commented] (HBASE-4716) Improve locking for single column family bulk load

2011-11-01 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141937#comment-13141937 ] stack commented on HBASE-4716: -- Should locks be accompanied by try/finally's where locks get