[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13403271#comment-13403271
]
Hudson commented on HBASE-6200:
---
Integrated in HBase-0.94-security #38 (See
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401195#comment-13401195
]
Jieshan Bean commented on HBASE-6200:
-
Ya...You reminded me. I have one idea to
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401205#comment-13401205
]
Zhihong Ted Yu commented on HBASE-6200:
---
The above approach should work.
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401454#comment-13401454
]
stack commented on HBASE-6200:
--
Thanks for taking time on perf Jieshan. +1 on commit (It
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401483#comment-13401483
]
Hadoop QA commented on HBASE-6200:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401508#comment-13401508
]
Zhihong Ted Yu commented on HBASE-6200:
---
I ran the two tests listed above and they
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401807#comment-13401807
]
Zhihong Ted Yu commented on HBASE-6200:
---
Patch for 0.94 is same as the patch for
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401829#comment-13401829
]
Hudson commented on HBASE-6200:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #70 (See
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401841#comment-13401841
]
Jieshan Bean commented on HBASE-6200:
-
Thank you Ted. I will upload the patch for 90
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401851#comment-13401851
]
Hudson commented on HBASE-6200:
---
Integrated in HBase-0.94 #284 (See
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401861#comment-13401861
]
Jieshan Bean commented on HBASE-6200:
-
Sorry.. It was made based on V4 not V2..
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401868#comment-13401868
]
Hudson commented on HBASE-6200:
---
Integrated in HBase-TRUNK #3077 (See
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401927#comment-13401927
]
Hudson commented on HBASE-6200:
---
Integrated in HBase-0.92 #459 (See
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401943#comment-13401943
]
Jieshan Bean commented on HBASE-6200:
-
All tests passed for 90.
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401951#comment-13401951
]
Zhihong Ted Yu commented on HBASE-6200:
---
Integrated to 0.90 branch as well.
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400303#comment-13400303
]
Anoop Sam John commented on HBASE-6200:
---
{code}
- if (lcolumnlength == 0 ltype
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400323#comment-13400323
]
Jieshan Bean commented on HBASE-6200:
-
@Anoop:
Thanks for your carefully review.
Only
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400443#comment-13400443
]
Hadoop QA commented on HBASE-6200:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400462#comment-13400462
]
Lars Hofhansl commented on HBASE-6200:
--
So if I read that right 1.000.000 KV compares
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400529#comment-13400529
]
Zhihong Ted Yu commented on HBASE-6200:
---
@Lars:
What other tests do you think should
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400698#comment-13400698
]
Zhihong Ted Yu commented on HBASE-6200:
---
@Stack:
Do you have further comments on the
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401094#comment-13401094
]
Jieshan Bean commented on HBASE-6200:
-
bq.So if I read that right 1.000.000 KV
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401124#comment-13401124
]
Jieshan Bean commented on HBASE-6200:
-
1,000,000 * 2 comparison, 100ms Vs 121ms. In
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400205#comment-13400205
]
Lars Hofhansl commented on HBASE-6200:
--
Also with this change, since KVs are compared
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400248#comment-13400248
]
Jieshan Bean commented on HBASE-6200:
-
bq.Patch looks good. I'm not sure I'm clear
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400252#comment-13400252
]
Hadoop QA commented on HBASE-6200:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400254#comment-13400254
]
Zhihong Ted Yu commented on HBASE-6200:
---
For performance test, how about using
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400256#comment-13400256
]
Jieshan Bean commented on HBASE-6200:
-
I agree with this idea. We should create one
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400264#comment-13400264
]
Hadoop QA commented on HBASE-6200:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400265#comment-13400265
]
Hadoop QA commented on HBASE-6200:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400268#comment-13400268
]
Hadoop QA commented on HBASE-6200:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400276#comment-13400276
]
Zhihong Ted Yu commented on HBASE-6200:
---
@Jieshan:
Let's start with your test plan.
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13399202#comment-13399202
]
Zhihong Ted Yu commented on HBASE-6200:
---
All Apache build servers are offline.
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13399363#comment-13399363
]
Hadoop QA commented on HBASE-6200:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13399401#comment-13399401
]
stack commented on HBASE-6200:
--
Patch looks good. I'm not sure I'm clear what commonPrefix
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13399446#comment-13399446
]
Hadoop QA commented on HBASE-6200:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13399701#comment-13399701
]
Zhihong Ted Yu commented on HBASE-6200:
---
From earlier in the patch:
{code}
+
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398390#comment-13398390
]
Zhihong Ted Yu commented on HBASE-6200:
---
Hadoop QA is not functioning due to svn
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398460#comment-13398460
]
Zhihong Ted Yu commented on HBASE-6200:
---
Patch looks great.
Minor comments:
{code}
+
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398466#comment-13398466
]
Zhihong Ted Yu commented on HBASE-6200:
---
@Jieshan:
Please provide patches for other
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398505#comment-13398505
]
Jieshan Bean commented on HBASE-6200:
-
Thank you for your review, Ted. I will update
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398177#comment-13398177
]
Jieshan Bean commented on HBASE-6200:
-
bq.They should be compared separately, but then
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13393509#comment-13393509
]
Lars Hofhansl commented on HBASE-6200:
--
The problem is that families are not compared
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13393515#comment-13393515
]
Lars Hofhansl commented on HBASE-6200:
--
Meh... Looking again at the code. Families
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13393517#comment-13393517
]
Lars Hofhansl commented on HBASE-6200:
--
So family and qualifier are compared
[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13393626#comment-13393626
]
stack commented on HBASE-6200:
--
Seems like a 'hole' since elsewhere in KV we compare columns
46 matches
Mail list logo
