[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486500#comment-13486500
]
Hudson commented on HBASE-6707:
---
Integrated in HBase-TRUNK #3496 (See
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486578#comment-13486578
]
Hudson commented on HBASE-6707:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #244 (See
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485687#comment-13485687
]
Jesse Yates commented on HBASE-6707:
[~stack] i'd say commit v4-addendum.patch.
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485724#comment-13485724
]
stack commented on HBASE-6707:
--
Committed v4. Lets see how it does.
TEST
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485739#comment-13485739
]
Hudson commented on HBASE-6707:
---
Integrated in HBase-TRUNK #3494 (See
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485757#comment-13485757
]
Hudson commented on HBASE-6707:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #243 (See
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485760#comment-13485760
]
Jesse Yates commented on HBASE-6707:
Well, at least it didn't fail immediately.
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485180#comment-13485180
]
stack commented on HBASE-6707:
--
[~jesse_yates] So what to do here now Jesse to resolve the
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484364#comment-13484364
]
Jesse Yates commented on HBASE-6707:
With the recent changes to trunk (HBASE-6949) my
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469183#comment-13469183
]
Jesse Yates commented on HBASE-6707:
bq. If it passes hadoopqa, that is enough up to
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469194#comment-13469194
]
Jesse Yates commented on HBASE-6707:
bq. Why the addition of 3 above ?
So it checks
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469227#comment-13469227
]
Ted Yu commented on HBASE-6707:
---
bq. If we want to support both 1.6 and 1.7 that should be
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469597#comment-13469597
]
Jesse Yates commented on HBASE-6707:
bq. only check for files and delete directories
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469645#comment-13469645
]
Ted Yu commented on HBASE-6707:
---
I think this hunk is not needed:
{code}
@@ -50,16 +50,14 @@
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469665#comment-13469665
]
Jesse Yates commented on HBASE-6707:
bq. file turned out to be empty every time when
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469675#comment-13469675
]
Ted Yu commented on HBASE-6707:
---
If the first hunk is needed by HBASE-6949, it can go into
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469683#comment-13469683
]
Jesse Yates commented on HBASE-6707:
[~te...@apache.org] what do you mean by first and
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469691#comment-13469691
]
Ted Yu commented on HBASE-6707:
---
The first hunk is from line 5 to line 24 in the addendum.
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469724#comment-13469724
]
Jesse Yates commented on HBASE-6707:
bq. If the first hunk is needed by HBASE-6949, it
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469727#comment-13469727
]
Ted Yu commented on HBASE-6707:
---
My addendum fixes NullPointerException.
But it failed again
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469744#comment-13469744
]
Hadoop QA commented on HBASE-6707:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469752#comment-13469752
]
Hadoop QA commented on HBASE-6707:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469820#comment-13469820
]
Jesse Yates commented on HBASE-6707:
Hmmm, I think part of this complexity is due to
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469048#comment-13469048
]
Jesse Yates commented on HBASE-6707:
I miss counted the number of files looked at in
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469073#comment-13469073
]
Jesse Yates commented on HBASE-6707:
Ran patch 20x locally without seeing any weird
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469084#comment-13469084
]
Ted Yu commented on HBASE-6707:
---
Can you clarify whether you were using jdk 1.6 or jdk 1.7 ?
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469094#comment-13469094
]
stack commented on HBASE-6707:
--
bq. I think both jdk should be used: 1.6 is used by Hadoop
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469110#comment-13469110
]
Hadoop QA commented on HBASE-6707:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469159#comment-13469159
]
Ted Yu commented on HBASE-6707:
---
{code}
+CountDownLatch finished =
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467909#comment-13467909
]
Jesse Yates commented on HBASE-6707:
[~stack] are you sure you ran v4? I can't seem to
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467921#comment-13467921
]
Ted Yu commented on HBASE-6707:
---
@Jesse:
Do you mind updating review request on review board
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467927#comment-13467927
]
Jesse Yates commented on HBASE-6707:
@Ted - done. review can be found here:
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467939#comment-13467939
]
stack commented on HBASE-6707:
--
[~jesse_yates] I must have done something wrong. Sorry about
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13468033#comment-13468033
]
Ted Yu commented on HBASE-6707:
---
The gist of this JIRA is about making sure that HFiles for
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13468042#comment-13468042
]
Ted Yu commented on HBASE-6707:
---
I am sorry Jesse: HBASE-5699 has gone in and patch v4 is
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13468043#comment-13468043
]
Jesse Yates commented on HBASE-6707:
@Ted - which jira? That one's still open... I
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13468047#comment-13468047
]
Ted Yu commented on HBASE-6707:
---
Pardon me. Looks like Stack entered wrong JIRA:
{code}
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13468063#comment-13468063
]
Jesse Yates commented on HBASE-6707:
[~te...@apache.org][~stack] looks like stack
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13468136#comment-13468136
]
stack commented on HBASE-6707:
--
I backed out hbase-6707 bits that made it in as part of an
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13468139#comment-13468139
]
stack commented on HBASE-6707:
--
Let me just commit this. I tested it locally already so you
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13468146#comment-13468146
]
stack commented on HBASE-6707:
--
bq. Committed patch to trunk
Ted, it looked to me like
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13468176#comment-13468176
]
Hudson commented on HBASE-6707:
---
Integrated in HBase-TRUNK #3409 (See
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13468181#comment-13468181
]
Hudson commented on HBASE-6707:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #204 (See
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466901#comment-13466901
]
Ted Yu commented on HBASE-6707:
---
Now there seems to be another dimension to consider:
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466972#comment-13466972
]
Jesse Yates commented on HBASE-6707:
[~te...@apache.org] why would that change
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466981#comment-13466981
]
Ted Yu commented on HBASE-6707:
---
bq. so we know the fix works when the test passes
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466996#comment-13466996
]
Jesse Yates commented on HBASE-6707:
Yeah, but the test didn't always passing so we
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467001#comment-13467001
]
Ted Yu commented on HBASE-6707:
---
bq. if the test is always failing and then we fix it such
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467004#comment-13467004
]
Jesse Yates commented on HBASE-6707:
bq. It would be nice to confirm that this fix
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467008#comment-13467008
]
Ted Yu commented on HBASE-6707:
---
It's open to discussion.
If QA run returns with 196 test
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467100#comment-13467100
]
stack commented on HBASE-6707:
--
[~jesse_yates] Mind updating patch for trunk? It seems to
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467314#comment-13467314
]
Ted Yu commented on HBASE-6707:
---
As of build #3400, there were 198 test failures.
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467343#comment-13467343
]
Ted Yu commented on HBASE-6707:
---
Thanks for the quick response, Jesse.
My laptop is in Corp
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467349#comment-13467349
]
Jesse Yates commented on HBASE-6707:
that was 10x with jdk6 - looks like all the
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467375#comment-13467375
]
Ted Yu commented on HBASE-6707:
---
bq. Getting the same issue locally and for other tests that
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467377#comment-13467377
]
Jesse Yates commented on HBASE-6707:
[~te...@apache.org] yup. I'm looking into it
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467436#comment-13467436
]
stack commented on HBASE-6707:
--
bq. Isn't the above a blocker for this JIRA in terms of
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467452#comment-13467452
]
stack commented on HBASE-6707:
--
[~jesse_yates] This test is jinxed. Ran v4 here on linux:
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13465775#comment-13465775
]
Ted Yu commented on HBASE-6707:
---
Nice effort, Jesse.
bq. compactions and flushes never
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13465937#comment-13465937
]
Jesse Yates commented on HBASE-6707:
bq. compactions and flushes never seemed to be
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13465947#comment-13465947
]
Jesse Yates commented on HBASE-6707:
[~stack] bq. I will hold my nose when I commit
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13465959#comment-13465959
]
Jesse Yates commented on HBASE-6707:
bq. I think writing rows with different row keys
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13465960#comment-13465960
]
Jesse Yates commented on HBASE-6707:
bq. This is important for future test cases. Mind
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466025#comment-13466025
]
Ted Yu commented on HBASE-6707:
---
Updating javadocs or enriching hbase book would be good for
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13465308#comment-13465308
]
stack commented on HBASE-6707:
--
Pull MockRegionServer up to top level in test now its used by
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13456867#comment-13456867
]
Hudson commented on HBASE-6707:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #177 (See
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13456872#comment-13456872
]
Hudson commented on HBASE-6707:
---
Integrated in HBase-TRUNK #3340 (See
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13457202#comment-13457202
]
Jesse Yates commented on HBASE-6707:
@stack yeah, I'll take a look. This is getting
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13457219#comment-13457219
]
stack commented on HBASE-6707:
--
[~jesse_yates] Deep breaths.
TEST
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13457259#comment-13457259
]
Hudson commented on HBASE-6707:
---
Integrated in HBase-TRUNK #3343 (See
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13457475#comment-13457475
]
Hudson commented on HBASE-6707:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #178 (See
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13450424#comment-13450424
]
Hudson commented on HBASE-6707:
---
Integrated in HBase-TRUNK #3313 (See
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13450538#comment-13450538
]
Hudson commented on HBASE-6707:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #164 (See
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13451036#comment-13451036
]
Jesse Yates commented on HBASE-6707:
Also ran it 10x locally (and another 10x before
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13451119#comment-13451119
]
Hadoop QA commented on HBASE-6707:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13450352#comment-13450352
]
Hudson commented on HBASE-6707:
---
Integrated in HBase-TRUNK #3312 (See
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13450365#comment-13450365
]
Jesse Yates commented on HBASE-6707:
Looks like a missed failure mode. Taking a
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13450367#comment-13450367
]
stack commented on HBASE-6707:
--
Thanks for taking a look J.
TEST
[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447873#comment-13447873
]
Jesse Yates commented on HBASE-6707:
@Ted marked 6690 as a dup of this since this
79 matches
Mail list logo