[
https://issues.apache.org/jira/browse/HBASE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703520#comment-13703520
]
Nick Dimiduk commented on HBASE-7840:
-
bq. Or can we test for SUDO and have the test
[
https://issues.apache.org/jira/browse/HBASE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700503#comment-13700503
]
Nicolas Liochon commented on HBASE-7840:
bq. do you think it reasonable to expect
[
https://issues.apache.org/jira/browse/HBASE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700168#comment-13700168
]
Nicolas Liochon commented on HBASE-7840:
Thanks a lot for the reviews.
bq. What
[
https://issues.apache.org/jira/browse/HBASE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700212#comment-13700212
]
stack commented on HBASE-7840:
--
I'd say don't commit unless all pass. Do I need to have sudo
[
https://issues.apache.org/jira/browse/HBASE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700236#comment-13700236
]
Nicolas Liochon commented on HBASE-7840:
bq. I'd say don't commit unless all pass
[
https://issues.apache.org/jira/browse/HBASE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700290#comment-13700290
]
stack commented on HBASE-7840:
--
Hmmm It will mess up our green lights on test rigs? Or
[
https://issues.apache.org/jira/browse/HBASE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13697929#comment-13697929
]
Nick Dimiduk commented on HBASE-7840:
-
+1 on latest patch. This is good work, Nicolas.
[
https://issues.apache.org/jira/browse/HBASE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13698603#comment-13698603
]
stack commented on HBASE-7840:
--
What is this comment in ClusterManager.java?
{code}
+ //
[
https://issues.apache.org/jira/browse/HBASE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13693101#comment-13693101
]
Nicolas Liochon commented on HBASE-7840:
New version.
Enhance
[
https://issues.apache.org/jira/browse/HBASE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669260#comment-13669260
]
Nicolas Liochon commented on HBASE-7840:
My local version has evolved since my
[
https://issues.apache.org/jira/browse/HBASE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13639289#comment-13639289
]
stack commented on HBASE-7840:
--
Skimmed the patch. Looks like nice new test functionality.
[
https://issues.apache.org/jira/browse/HBASE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601454#comment-13601454
]
nkeywal commented on HBASE-7840:
Waiting for review or +1 on this one, I can rebase if you
[
https://issues.apache.org/jira/browse/HBASE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13588553#comment-13588553
]
nkeywal commented on HBASE-7840:
v3 on rb as well, rebased.
Enhance the
[
https://issues.apache.org/jira/browse/HBASE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13582210#comment-13582210
]
nkeywal commented on HBASE-7840:
I've put the v2 in the review boards a few days ago,
[
https://issues.apache.org/jira/browse/HBASE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577919#comment-13577919
]
nkeywal commented on HBASE-7840:
It's not perfect, but considering the subject it's in a
[
https://issues.apache.org/jira/browse/HBASE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577956#comment-13577956
]
Enis Soztutar commented on HBASE-7840:
--
Patch looks promising. Can you please put
[
https://issues.apache.org/jira/browse/HBASE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13578008#comment-13578008
]
nkeywal commented on HBASE-7840:
done: https://reviews.apache.org/r/9437/
17 matches
Mail list logo
