[jira] [Commented] (HBASE-9546) HFileContext should adopt Builder pattern

2013-10-09 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790289#comment-13790289 ] Hudson commented on HBASE-9546: --- FAILURE: Integrated in HBase-TRUNK #4601 (See

[jira] [Commented] (HBASE-9546) HFileContext should adopt Builder pattern

2013-10-09 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13791108#comment-13791108 ] Hudson commented on HBASE-9546: --- FAILURE: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #785

[jira] [Commented] (HBASE-9546) HFileContext should adopt Builder pattern

2013-10-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789216#comment-13789216 ] Hadoop QA commented on HBASE-9546: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-9546) HFileContext should adopt Builder pattern

2013-10-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789240#comment-13789240 ] Ted Yu commented on HBASE-9546: --- +1 HFileContext should adopt Builder pattern

[jira] [Commented] (HBASE-9546) HFileContext should adopt Builder pattern

2013-10-08 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789286#comment-13789286 ] Anoop Sam John commented on HBASE-9546: --- LGTM There are some TODOs. You want to do

[jira] [Commented] (HBASE-9546) HFileContext should adopt Builder pattern

2013-10-08 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789329#comment-13789329 ] ramkrishna.s.vasudevan commented on HBASE-9546: --- Not now. Because we need

[jira] [Commented] (HBASE-9546) HFileContext should adopt Builder pattern

2013-10-08 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790023#comment-13790023 ] ramkrishna.s.vasudevan commented on HBASE-9546: --- Done with cluster testing.

[jira] [Commented] (HBASE-9546) HFileContext should adopt Builder pattern

2013-10-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13784942#comment-13784942 ] Hadoop QA commented on HBASE-9546: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-9546) HFileContext should adopt Builder pattern

2013-10-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13785303#comment-13785303 ] Ted Yu commented on HBASE-9546: --- For HFileDataBlockEncoderImpl.java : {code} + private

[jira] [Commented] (HBASE-9546) HFileContext should adopt Builder pattern

2013-10-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13784820#comment-13784820 ] Ted Yu commented on HBASE-9546: --- {code} + public HFileContext(boolean useHBaseChecksum,

[jira] [Commented] (HBASE-9546) HFileContext should adopt Builder pattern

2013-09-16 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13768605#comment-13768605 ] stack commented on HBASE-9546: -- You have a patch? Otherwise lets close this issue that will