[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186055#comment-13186055
]
Lars Hofhansl commented on HBASE-3584:
--
Ran the 4 failing tests locally. All pass. Wi
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186051#comment-13186051
]
Hadoop QA commented on HBASE-3584:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186046#comment-13186046
]
Amitanand Aiyer commented on HBASE-3584:
Thanks Lars. I was indeed referring to th
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186035#comment-13186035
]
Zhihong Yu commented on HBASE-3584:
---
+1 if unit tests pass.
Nice work, Lars.
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185925#comment-13185925
]
Lars Hofhansl commented on HBASE-3584:
--
Yep... HTable.mutateRow(RowMutation)
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185914#comment-13185914
]
stack commented on HBASE-3584:
--
bq. Wanna call it mutateRow (in HTable/RegionServer/Region)?
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185911#comment-13185911
]
Lars Hofhansl commented on HBASE-3584:
--
Wanna call it mutateRow (in HTable/RegionServ
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185841#comment-13185841
]
jirapos...@reviews.apache.org commented on HBASE-3584:
--
bq. On 201
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185820#comment-13185820
]
jirapos...@reviews.apache.org commented on HBASE-3584:
--
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185817#comment-13185817
]
Zhihong Yu commented on HBASE-3584:
---
I agree.
Sorry for the confusion.
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185813#comment-13185813
]
Lars Hofhansl commented on HBASE-3584:
--
Now I am getting confused :)
These are the pa
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185807#comment-13185807
]
jirapos...@reviews.apache.org commented on HBASE-3584:
--
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185791#comment-13185791
]
Zhihong Yu commented on HBASE-3584:
---
The current logic is different from what I describe
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185785#comment-13185785
]
Lars Hofhansl commented on HBASE-3584:
--
Oh... and this is the piece of code that does
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185778#comment-13185778
]
Lars Hofhansl commented on HBASE-3584:
--
It's kind of how it works now. If walEdit is
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185762#comment-13185762
]
Zhihong Yu commented on HBASE-3584:
---
How about we always instantiate WALEdit, called loc
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185750#comment-13185750
]
Lars Hofhansl commented on HBASE-3584:
--
Hmm... Somehow I have to indicate that coproc
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185736#comment-13185736
]
Zhihong Yu commented on HBASE-3584:
---
The coprocessor hooks are contingent upon this cond
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185678#comment-13185678
]
jirapos...@reviews.apache.org commented on HBASE-3584:
--
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185459#comment-13185459
]
Hadoop QA commented on HBASE-3584:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185399#comment-13185399
]
Lars Hofhansl commented on HBASE-3584:
--
Hi Amit... Since AtomicRowMutation implements
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185357#comment-13185357
]
Amitanand Aiyer commented on HBASE-3584:
Nice feature, lars!!
Would be nice to h
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185343#comment-13185343
]
jirapos...@reviews.apache.org commented on HBASE-3584:
--
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185344#comment-13185344
]
jirapos...@reviews.apache.org commented on HBASE-3584:
--
bq. On 201
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185328#comment-13185328
]
jirapos...@reviews.apache.org commented on HBASE-3584:
--
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185288#comment-13185288
]
jirapos...@reviews.apache.org commented on HBASE-3584:
--
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185272#comment-13185272
]
Lars Hofhansl commented on HBASE-3584:
--
Thanks Ted. Looked at the coprocessor API mor
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185271#comment-13185271
]
jirapos...@reviews.apache.org commented on HBASE-3584:
--
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185265#comment-13185265
]
Zhihong Yu commented on HBASE-3584:
---
w.r.t. the coprocessor pre hooks, I think option 2
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185260#comment-13185260
]
jirapos...@reviews.apache.org commented on HBASE-3584:
--
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185251#comment-13185251
]
Zhihong Yu commented on HBASE-3584:
---
Putting the patch on review board would make review
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185243#comment-13185243
]
Lars Hofhansl commented on HBASE-3584:
--
Also this patch only addresses this for Put a
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182327#comment-13182327
]
Lars Hofhansl commented on HBASE-3584:
--
Should we do this before "client 2.0"?
What
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005880#comment-13005880
]
ryan rawson commented on HBASE-3584:
yes API 2.0. Just putting it in here for notabili
[
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000666#comment-13000666
]
stack commented on HBASE-3584:
--
You think this a client API 2.0 feature Ryan?
> We need to a
35 matches
Mail list logo