[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-13 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186055#comment-13186055 ] Lars Hofhansl commented on HBASE-3584: -- Ran the 4 failing tests locally. All pass. Wi

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-13 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186051#comment-13186051 ] Hadoop QA commented on HBASE-3584: -- -1 overall. Here are the results of testing the late

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-13 Thread Amitanand Aiyer (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186046#comment-13186046 ] Amitanand Aiyer commented on HBASE-3584: Thanks Lars. I was indeed referring to th

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186035#comment-13186035 ] Zhihong Yu commented on HBASE-3584: --- +1 if unit tests pass. Nice work, Lars.

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-13 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185925#comment-13185925 ] Lars Hofhansl commented on HBASE-3584: -- Yep... HTable.mutateRow(RowMutation)

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185914#comment-13185914 ] stack commented on HBASE-3584: -- bq. Wanna call it mutateRow (in HTable/RegionServer/Region)?

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-13 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185911#comment-13185911 ] Lars Hofhansl commented on HBASE-3584: -- Wanna call it mutateRow (in HTable/RegionServ

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-13 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185841#comment-13185841 ] jirapos...@reviews.apache.org commented on HBASE-3584: -- bq. On 201

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-13 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185820#comment-13185820 ] jirapos...@reviews.apache.org commented on HBASE-3584: --

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185817#comment-13185817 ] Zhihong Yu commented on HBASE-3584: --- I agree. Sorry for the confusion.

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-13 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185813#comment-13185813 ] Lars Hofhansl commented on HBASE-3584: -- Now I am getting confused :) These are the pa

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-13 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185807#comment-13185807 ] jirapos...@reviews.apache.org commented on HBASE-3584: --

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185791#comment-13185791 ] Zhihong Yu commented on HBASE-3584: --- The current logic is different from what I describe

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-13 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185785#comment-13185785 ] Lars Hofhansl commented on HBASE-3584: -- Oh... and this is the piece of code that does

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-13 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185778#comment-13185778 ] Lars Hofhansl commented on HBASE-3584: -- It's kind of how it works now. If walEdit is

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185762#comment-13185762 ] Zhihong Yu commented on HBASE-3584: --- How about we always instantiate WALEdit, called loc

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-13 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185750#comment-13185750 ] Lars Hofhansl commented on HBASE-3584: -- Hmm... Somehow I have to indicate that coproc

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185736#comment-13185736 ] Zhihong Yu commented on HBASE-3584: --- The coprocessor hooks are contingent upon this cond

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-13 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185678#comment-13185678 ] jirapos...@reviews.apache.org commented on HBASE-3584: --

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-12 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185459#comment-13185459 ] Hadoop QA commented on HBASE-3584: -- -1 overall. Here are the results of testing the late

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-12 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185399#comment-13185399 ] Lars Hofhansl commented on HBASE-3584: -- Hi Amit... Since AtomicRowMutation implements

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-12 Thread Amitanand Aiyer (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185357#comment-13185357 ] Amitanand Aiyer commented on HBASE-3584: Nice feature, lars!! Would be nice to h

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-12 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185343#comment-13185343 ] jirapos...@reviews.apache.org commented on HBASE-3584: --

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-12 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185344#comment-13185344 ] jirapos...@reviews.apache.org commented on HBASE-3584: -- bq. On 201

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-12 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185328#comment-13185328 ] jirapos...@reviews.apache.org commented on HBASE-3584: --

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-12 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185288#comment-13185288 ] jirapos...@reviews.apache.org commented on HBASE-3584: --

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-12 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185272#comment-13185272 ] Lars Hofhansl commented on HBASE-3584: -- Thanks Ted. Looked at the coprocessor API mor

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-12 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185271#comment-13185271 ] jirapos...@reviews.apache.org commented on HBASE-3584: --

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185265#comment-13185265 ] Zhihong Yu commented on HBASE-3584: --- w.r.t. the coprocessor pre hooks, I think option 2

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-12 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185260#comment-13185260 ] jirapos...@reviews.apache.org commented on HBASE-3584: --

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185251#comment-13185251 ] Zhihong Yu commented on HBASE-3584: --- Putting the patch on review board would make review

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-12 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185243#comment-13185243 ] Lars Hofhansl commented on HBASE-3584: -- Also this patch only addresses this for Put a

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-08 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182327#comment-13182327 ] Lars Hofhansl commented on HBASE-3584: -- Should we do this before "client 2.0"? What

[jira] Commented: (HBASE-3584) We need to atomically put/delete/increment in one call

2011-03-11 Thread ryan rawson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005880#comment-13005880 ] ryan rawson commented on HBASE-3584: yes API 2.0. Just putting it in here for notabili

[jira] Commented: (HBASE-3584) We need to atomically put/delete/increment in one call

2011-02-28 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000666#comment-13000666 ] stack commented on HBASE-3584: -- You think this a client API 2.0 feature Ryan? > We need to a