[jira] [Commented] (HBASE-5833) 0.92 build has been failing pretty consistently on TestMasterFailover....

2012-04-22 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259421#comment-13259421
 ] 

Hudson commented on HBASE-5833:
---

Integrated in HBase-0.92 #382 (See 
[https://builds.apache.org/job/HBase-0.92/382/])
HBASE-5833 0.92 build has been failing pretty consistently on 
TestMasterFailover; PART2 (Revision 1329052)

 Result = SUCCESS
stack : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* 
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
* 
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java
* 
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* 
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/filter/TestColumnPrefixFilter.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/filter/TestDependentColumnFilter.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/filter/TestMultipleColumnPrefixFilter.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestOpenedRegionHandler.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestColumnSeeking.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactSelection.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinVersions.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScanner.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestResettingCounters.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransaction.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestCloseRegionHandler.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java


> 0.92 build has been failing pretty consistently on TestMasterFailover
> -
>
> Key: HBASE-5833
> URL: https://issues.apache.org/jira/browse/HBASE-5833
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.92.2
>
> Attachments: 5833-trunk.txt, 5833-v2.092.txt, 5833.txt, 
> 5833v3092.txt, 5833v4092.txt, closehregions.txt
>
>
> Trunk seems fine but 0.92 fails on this test pretty regularly.  Running it 
> local it seems to hang for me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5848) Create table with EMPTY_START_ROW passed as splitKey causes the HMaster to abort

2012-04-22 Thread ramkrishna.s.vasudevan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259411#comment-13259411
 ] 

ramkrishna.s.vasudevan commented on HBASE-5848:
---

@Lars
I have analysed this problem.
First thing is if we pass an empty byte array it is trying to form two regions 
with empty start and end keys.
But the reason for it to abort is when it tries to form the two regions it so 
happens that the region id generated from the System.currenttimeInMillis 
becomes same and it tries to create the same node twice. And hence we get that 
aborting from the asyncSetOfflineInZooKeeper
{code}
CreateUnassignedAsyncCallback cb =
  new CreateUnassignedAsyncCallback(this.watcher, destination, counter);
for (RegionState state: states) {
  if (!asyncSetOfflineInZooKeeper(state, cb, state)) {
return;
  }
}
{code}
The region Id is formed from
{code}
 public HRegionInfo(final byte[] tableName, final byte[] startKey,
 final byte[] endKey, final boolean split)
  throws IllegalArgumentException {
this(tableName, startKey, endKey, split, System.currentTimeMillis());
  }
{code}

So there is always a chance that we get same region id but just because the 
start key and end key changes we were not encountering this problem.
I suggest we add a logic explicitly to avoid 2 regions from getting formed and 
also the main thing is can we take System.nanoTime for the region id.?

Even i was not able to get this repeatedly in testcases but a real cluster 
gives you the problem.

> Create table with EMPTY_START_ROW passed as splitKey causes the HMaster to 
> abort
> 
>
> Key: HBASE-5848
> URL: https://issues.apache.org/jira/browse/HBASE-5848
> Project: HBase
>  Issue Type: Bug
>  Components: client
>Reporter: Lars Hofhansl
>Assignee: Lars Hofhansl
>Priority: Minor
>
> A coworker of mine just had this scenario. It does not make sense the 
> EMPTY_START_ROW as splitKey (since the region with the empty start key is 
> implicit), but it should not cause the HMaster to abort.
> The abort happens because it tries to bulk assign the same region twice and 
> then runs into race conditions with ZK.
> The same would (presumably) happen when two identical split keys are passed, 
> but the client blocks that. The simplest solution here is to also block 
> passed null or EMPTY_START_ROW as split key by the client.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-1936) ClassLoader that loads from hdfs; useful adding filters to classpath without having to restart services

2012-04-22 Thread Lars Hofhansl (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259395#comment-13259395
 ] 

Lars Hofhansl commented on HBASE-1936:
--

Thank Jieshan. Yes, I think you should be able to reuse most of the CP 
classloading code. In the end you "only" need a classloader which can load a 
jar from HDFS. Filters (like coprocessors) then would be packed into a jar 
(together with any supporting classes needed).


> ClassLoader that loads from hdfs; useful adding filters to classpath without 
> having to restart services
> ---
>
> Key: HBASE-1936
> URL: https://issues.apache.org/jira/browse/HBASE-1936
> Project: HBase
>  Issue Type: New Feature
>Reporter: stack
>Assignee: Jieshan Bean
>  Labels: noob
> Attachments: HBASE-1936-trunk(forReview).patch, cp_from_hdfs.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5848) Create table with EMPTY_START_ROW passed as splitKey causes the HMaster to abort

2012-04-22 Thread Lars Hofhansl (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259392#comment-13259392
 ] 

Lars Hofhansl commented on HBASE-5848:
--

Interestingly, I cannot reproduce this in a test. MiniCluster seems to be 
different enough to not have this problem.

> Create table with EMPTY_START_ROW passed as splitKey causes the HMaster to 
> abort
> 
>
> Key: HBASE-5848
> URL: https://issues.apache.org/jira/browse/HBASE-5848
> Project: HBase
>  Issue Type: Bug
>  Components: client
>Reporter: Lars Hofhansl
>Assignee: Lars Hofhansl
>Priority: Minor
>
> A coworker of mine just had this scenario. It does not make sense the 
> EMPTY_START_ROW as splitKey (since the region with the empty start key is 
> implicit), but it should not cause the HMaster to abort.
> The abort happens because it tries to bulk assign the same region twice and 
> then runs into race conditions with ZK.
> The same would (presumably) happen when two identical split keys are passed, 
> but the client blocks that. The simplest solution here is to also block 
> passed null or EMPTY_START_ROW as split key by the client.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5833) 0.92 build has been failing pretty consistently on TestMasterFailover....

2012-04-22 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259380#comment-13259380
 ] 

stack commented on HBASE-5833:
--

Committed 5833v4092.txt to 0.92 branch.

> 0.92 build has been failing pretty consistently on TestMasterFailover
> -
>
> Key: HBASE-5833
> URL: https://issues.apache.org/jira/browse/HBASE-5833
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.92.2
>
> Attachments: 5833-trunk.txt, 5833-v2.092.txt, 5833.txt, 
> 5833v3092.txt, 5833v4092.txt, closehregions.txt
>
>
> Trunk seems fine but 0.92 fails on this test pretty regularly.  Running it 
> local it seems to hang for me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-1936) ClassLoader that loads from hdfs; useful adding filters to classpath without having to restart services

2012-04-22 Thread Jieshan Bean (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259364#comment-13259364
 ] 

Jieshan Bean commented on HBASE-1936:
-

I'm trying to unify the classLoader used in CP and Filter, it will take a few 
days. Sorry for the delay.

> ClassLoader that loads from hdfs; useful adding filters to classpath without 
> having to restart services
> ---
>
> Key: HBASE-1936
> URL: https://issues.apache.org/jira/browse/HBASE-1936
> Project: HBase
>  Issue Type: New Feature
>Reporter: stack
>Assignee: Jieshan Bean
>  Labels: noob
> Attachments: HBASE-1936-trunk(forReview).patch, cp_from_hdfs.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5833) 0.92 build has been failing pretty consistently on TestMasterFailover....

2012-04-22 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259357#comment-13259357
 ] 

Hadoop QA commented on HBASE-5833:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12523743/5833v4092.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 75 new or modified tests.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1604//console

This message is automatically generated.

> 0.92 build has been failing pretty consistently on TestMasterFailover
> -
>
> Key: HBASE-5833
> URL: https://issues.apache.org/jira/browse/HBASE-5833
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.92.2
>
> Attachments: 5833-trunk.txt, 5833-v2.092.txt, 5833.txt, 
> 5833v3092.txt, 5833v4092.txt, closehregions.txt
>
>
> Trunk seems fine but 0.92 fails on this test pretty regularly.  Running it 
> local it seems to hang for me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5833) 0.92 build has been failing pretty consistently on TestMasterFailover....

2012-04-22 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259355#comment-13259355
 ] 

stack commented on HBASE-5833:
--

I ran through complete test suite twice and got the following failures (I fixed 
the failed TestHRegion w/ last patch).  This is on 092.

{code}
Results :

Failed tests:   
testGetScanner_WithOkFamilies(org.apache.hadoop.hbase.regionserver.TestHRegion):
 Families could not be found in Region
  
testCyclicReplication(org.apache.hadoop.hbase.replication.TestMasterReplication):
 Waited too much time for put replication
  testLeaderSelection(org.apache.hadoop.hbase.zookeeper.TestZKLeaderManager): 
New leader should exist after stop

Tests in error: 
  testTableOperations(org.apache.hadoop.hbase.coprocessor.TestMasterObserver): 
org.apache.hadoop.hbase.InvalidFamilyOperationException: Column family 'fam2' 
does not exist
  
testRegionTransitionOperations(org.apache.hadoop.hbase.coprocessor.TestMasterObserver):
 org.apache.hadoop.hbase.TableExistsException: observed_table
  
testShouldCheckMasterFailOverWhenMETAIsInOpenedState(org.apache.hadoop.hbase.master.TestMasterFailover):
 test timed out after 18 milliseconds
  
testSimplePutDelete(org.apache.hadoop.hbase.replication.TestMasterReplication): 
Cluster already running at 
/Users/stack/checkouts/hbase/target/test-data/49fb7ad7-156f-4461-964b-7bb54d70db63/dfscluster_c7c5efc0-4085-4914-9be5-c2b3e1530af9

Tests run: 1074, Failures: 3, Errors: 4, Skipped: 8



Results :

Failed tests:   
testGetScanner_WithOkFamilies(org.apache.hadoop.hbase.regionserver.TestHRegion):
 Families could not be found in Region
  
testCyclicReplication(org.apache.hadoop.hbase.replication.TestMasterReplication):
 Waited too much time for put replication

Tests in error: 
  org.apache.hadoop.hbase.client.TestAdmin: No server address listed in -ROOT- 
for region .META.,,1.1028785192
  
testSimplePutDelete(org.apache.hadoop.hbase.replication.TestMasterReplication): 
Cluster already running at 
/Users/stack/checkouts/hbase/target/test-data/fcfffe27-e2ce-4f91-84fc-bd65521b6426/dfscluster_bd55ee62-0532-40d4-86e5-487bd45d9565

Tests run: 1075, Failures: 2, Errors: 2, Skipped: 8
{code}

Let me commit this on 0.92.  Will then work on getting it into 0.90 -- since 
same breakage is there but will take some massaging and testing to get this 
patch in -- and ditto on 0.94 and trunk (something up w/ TestHRegion on 
trunk at mo).

> 0.92 build has been failing pretty consistently on TestMasterFailover
> -
>
> Key: HBASE-5833
> URL: https://issues.apache.org/jira/browse/HBASE-5833
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.92.2
>
> Attachments: 5833-trunk.txt, 5833-v2.092.txt, 5833.txt, 
> 5833v3092.txt, 5833v4092.txt, closehregions.txt
>
>
> Trunk seems fine but 0.92 fails on this test pretty regularly.  Running it 
> local it seems to hang for me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5833) 0.92 build has been failing pretty consistently on TestMasterFailover....

2012-04-22 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5833:
-

Attachment: 5833v4092.txt

Address last of Ted's comments.

> 0.92 build has been failing pretty consistently on TestMasterFailover
> -
>
> Key: HBASE-5833
> URL: https://issues.apache.org/jira/browse/HBASE-5833
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.92.2
>
> Attachments: 5833-trunk.txt, 5833-v2.092.txt, 5833.txt, 
> 5833v3092.txt, 5833v4092.txt, closehregions.txt
>
>
> Trunk seems fine but 0.92 fails on this test pretty regularly.  Running it 
> local it seems to hang for me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5833) 0.92 build has been failing pretty consistently on TestMasterFailover....

2012-04-22 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259349#comment-13259349
 ] 

Hadoop QA commented on HBASE-5833:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12523740/5833v3092.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 75 new or modified tests.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1603//console

This message is automatically generated.

> 0.92 build has been failing pretty consistently on TestMasterFailover
> -
>
> Key: HBASE-5833
> URL: https://issues.apache.org/jira/browse/HBASE-5833
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.92.2
>
> Attachments: 5833-trunk.txt, 5833-v2.092.txt, 5833.txt, 
> 5833v3092.txt, closehregions.txt
>
>
> Trunk seems fine but 0.92 fails on this test pretty regularly.  Running it 
> local it seems to hang for me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5833) 0.92 build has been failing pretty consistently on TestMasterFailover....

2012-04-22 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5833:
-

Attachment: 5833v3092.txt

Running tests, I found that I'd failed convert a method in TestHRegion.

> 0.92 build has been failing pretty consistently on TestMasterFailover
> -
>
> Key: HBASE-5833
> URL: https://issues.apache.org/jira/browse/HBASE-5833
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.92.2
>
> Attachments: 5833-trunk.txt, 5833-v2.092.txt, 5833.txt, 
> 5833v3092.txt, closehregions.txt
>
>
> Trunk seems fine but 0.92 fails on this test pretty regularly.  Running it 
> local it seems to hang for me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-22 Thread Zhihong Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259347#comment-13259347
 ] 

Zhihong Yu commented on HBASE-5850:
---

Stack provided a patch to fix this test in HBASE-5833
Can you try his patch ?

Thanks

> Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
> is initialized
> ---
>
> Key: HBASE-5850
> URL: https://issues.apache.org/jira/browse/HBASE-5850
> Project: HBase
>  Issue Type: Bug
>Reporter: xufeng
>Assignee: xufeng
> Fix For: 0.90.7, 0.92.2, 0.94.1
>
> Attachments: 5850-trunk.txt, backport-5454(createTable)-to-94.patch, 
> backport-5454(createTable)-to-94_surefire-report.html, 
> backport-5454(createTable)-to-trunk.patch, 
> backport-5454(createTable)-to-trunk_surefire-report.html, 
> backport-5454-to-90.patch, backport-5454-to-92.patch, 
> backport-5454-to-92_surefire-report.html
>
>
> This issue is needed in 0.90 0.92 also.
> And update the hbase-5454 patch that add the checkInitialized() into 
> HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-22 Thread Zhihong Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhihong Yu updated HBASE-5850:
--

Comment: was deleted

(was: @Ted)

> Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
> is initialized
> ---
>
> Key: HBASE-5850
> URL: https://issues.apache.org/jira/browse/HBASE-5850
> Project: HBase
>  Issue Type: Bug
>Reporter: xufeng
>Assignee: xufeng
> Fix For: 0.90.7, 0.92.2, 0.94.1
>
> Attachments: 5850-trunk.txt, backport-5454(createTable)-to-94.patch, 
> backport-5454(createTable)-to-94_surefire-report.html, 
> backport-5454(createTable)-to-trunk.patch, 
> backport-5454(createTable)-to-trunk_surefire-report.html, 
> backport-5454-to-90.patch, backport-5454-to-92.patch, 
> backport-5454-to-92_surefire-report.html
>
>
> This issue is needed in 0.90 0.92 also.
> And update the hbase-5454 patch that add the checkInitialized() into 
> HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-22 Thread xufeng (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259346#comment-13259346
 ] 

xufeng commented on HBASE-5850:
---

@Ted
I get the 90 version at revision 1329041 from  
http://svn.apache.org/repos/asf/hbase/branches/0.90.
But this error also exist.
${noformat}
---
 T E S T S
---
Running org.apache.hadoop.hbase.master.TestMasterFailover
killed.
${noformat}

Does this error also exist in your test env?

> Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
> is initialized
> ---
>
> Key: HBASE-5850
> URL: https://issues.apache.org/jira/browse/HBASE-5850
> Project: HBase
>  Issue Type: Bug
>Reporter: xufeng
>Assignee: xufeng
> Fix For: 0.90.7, 0.92.2, 0.94.1
>
> Attachments: 5850-trunk.txt, backport-5454(createTable)-to-94.patch, 
> backport-5454(createTable)-to-94_surefire-report.html, 
> backport-5454(createTable)-to-trunk.patch, 
> backport-5454(createTable)-to-trunk_surefire-report.html, 
> backport-5454-to-90.patch, backport-5454-to-92.patch, 
> backport-5454-to-92_surefire-report.html
>
>
> This issue is needed in 0.90 0.92 also.
> And update the hbase-5454 patch that add the checkInitialized() into 
> HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-22 Thread xufeng (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259345#comment-13259345
 ] 

xufeng commented on HBASE-5850:
---

@Ted

> Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
> is initialized
> ---
>
> Key: HBASE-5850
> URL: https://issues.apache.org/jira/browse/HBASE-5850
> Project: HBase
>  Issue Type: Bug
>Reporter: xufeng
>Assignee: xufeng
> Fix For: 0.90.7, 0.92.2, 0.94.1
>
> Attachments: 5850-trunk.txt, backport-5454(createTable)-to-94.patch, 
> backport-5454(createTable)-to-94_surefire-report.html, 
> backport-5454(createTable)-to-trunk.patch, 
> backport-5454(createTable)-to-trunk_surefire-report.html, 
> backport-5454-to-90.patch, backport-5454-to-92.patch, 
> backport-5454-to-92_surefire-report.html
>
>
> This issue is needed in 0.90 0.92 also.
> And update the hbase-5454 patch that add the checkInitialized() into 
> HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-22 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259343#comment-13259343
 ] 

Hadoop QA commented on HBASE-5850:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12523736/5850-trunk.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 7 new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1602//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1602//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1602//console

This message is automatically generated.

> Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
> is initialized
> ---
>
> Key: HBASE-5850
> URL: https://issues.apache.org/jira/browse/HBASE-5850
> Project: HBase
>  Issue Type: Bug
>Reporter: xufeng
>Assignee: xufeng
> Fix For: 0.90.7, 0.92.2, 0.94.1
>
> Attachments: 5850-trunk.txt, backport-5454(createTable)-to-94.patch, 
> backport-5454(createTable)-to-94_surefire-report.html, 
> backport-5454(createTable)-to-trunk.patch, 
> backport-5454(createTable)-to-trunk_surefire-report.html, 
> backport-5454-to-90.patch, backport-5454-to-92.patch, 
> backport-5454-to-92_surefire-report.html
>
>
> This issue is needed in 0.90 0.92 also.
> And update the hbase-5454 patch that add the checkInitialized() into 
> HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5621) Convert admin protocol of HRegionInterface to PB

2012-04-22 Thread Jimmy Xiang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259334#comment-13259334
 ] 

Jimmy Xiang commented on HBASE-5621:


@Stack, let me check it again how many passed tests I got.

@Ted, sure. Let me fix the naming issues.

> Convert admin protocol of HRegionInterface to PB
> 
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
>  Issue Type: Sub-task
>  Components: ipc, master, migration, regionserver
>Reporter: Jimmy Xiang
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, 
> hbase_5621_v4.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-22 Thread Zhihong Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhihong Yu updated HBASE-5850:
--

Attachment: 5850-trunk.txt

Re-attaching patch for trunk.

> Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
> is initialized
> ---
>
> Key: HBASE-5850
> URL: https://issues.apache.org/jira/browse/HBASE-5850
> Project: HBase
>  Issue Type: Bug
>Reporter: xufeng
>Assignee: xufeng
> Fix For: 0.90.7, 0.92.2, 0.94.1
>
> Attachments: 5850-trunk.txt, backport-5454(createTable)-to-94.patch, 
> backport-5454(createTable)-to-94_surefire-report.html, 
> backport-5454(createTable)-to-trunk.patch, 
> backport-5454(createTable)-to-trunk_surefire-report.html, 
> backport-5454-to-90.patch, backport-5454-to-92.patch, 
> backport-5454-to-92_surefire-report.html
>
>
> This issue is needed in 0.90 0.92 also.
> And update the hbase-5454 patch that add the checkInitialized() into 
> HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-22 Thread Zhihong Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhihong Yu updated HBASE-5850:
--

Comment: was deleted

(was: -1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12523622/backport-5454-to-90.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1601//console

This message is automatically generated.)

> Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
> is initialized
> ---
>
> Key: HBASE-5850
> URL: https://issues.apache.org/jira/browse/HBASE-5850
> Project: HBase
>  Issue Type: Bug
>Reporter: xufeng
>Assignee: xufeng
> Fix For: 0.90.7, 0.92.2, 0.94.1
>
> Attachments: backport-5454(createTable)-to-94.patch, 
> backport-5454(createTable)-to-94_surefire-report.html, 
> backport-5454(createTable)-to-trunk.patch, 
> backport-5454(createTable)-to-trunk_surefire-report.html, 
> backport-5454-to-90.patch, backport-5454-to-92.patch, 
> backport-5454-to-92_surefire-report.html
>
>
> This issue is needed in 0.90 0.92 also.
> And update the hbase-5454 patch that add the checkInitialized() into 
> HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-22 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259322#comment-13259322
 ] 

Hadoop QA commented on HBASE-5850:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12523622/backport-5454-to-90.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1601//console

This message is automatically generated.

> Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
> is initialized
> ---
>
> Key: HBASE-5850
> URL: https://issues.apache.org/jira/browse/HBASE-5850
> Project: HBase
>  Issue Type: Bug
>Reporter: xufeng
>Assignee: xufeng
> Fix For: 0.90.7, 0.92.2, 0.94.1
>
> Attachments: backport-5454(createTable)-to-94.patch, 
> backport-5454(createTable)-to-94_surefire-report.html, 
> backport-5454(createTable)-to-trunk.patch, 
> backport-5454(createTable)-to-trunk_surefire-report.html, 
> backport-5454-to-90.patch, backport-5454-to-92.patch, 
> backport-5454-to-92_surefire-report.html
>
>
> This issue is needed in 0.90 0.92 also.
> And update the hbase-5454 patch that add the checkInitialized() into 
> HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-22 Thread Zhihong Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259321#comment-13259321
 ] 

Zhihong Yu commented on HBASE-5850:
---

@Xufeng:
Can you attach test suite result for 0.90 ?

Thanks

> Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
> is initialized
> ---
>
> Key: HBASE-5850
> URL: https://issues.apache.org/jira/browse/HBASE-5850
> Project: HBase
>  Issue Type: Bug
>Reporter: xufeng
>Assignee: xufeng
> Fix For: 0.90.7, 0.92.2, 0.94.1
>
> Attachments: backport-5454(createTable)-to-94.patch, 
> backport-5454(createTable)-to-94_surefire-report.html, 
> backport-5454(createTable)-to-trunk.patch, 
> backport-5454(createTable)-to-trunk_surefire-report.html, 
> backport-5454-to-90.patch, backport-5454-to-92.patch, 
> backport-5454-to-92_surefire-report.html
>
>
> This issue is needed in 0.90 0.92 also.
> And update the hbase-5454 patch that add the checkInitialized() into 
> HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-22 Thread Zhihong Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhihong Yu updated HBASE-5850:
--

Hadoop Flags: Reviewed
  Status: Patch Available  (was: Open)

> Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
> is initialized
> ---
>
> Key: HBASE-5850
> URL: https://issues.apache.org/jira/browse/HBASE-5850
> Project: HBase
>  Issue Type: Bug
>Reporter: xufeng
>Assignee: xufeng
> Fix For: 0.90.7, 0.92.2, 0.94.1
>
> Attachments: backport-5454(createTable)-to-94.patch, 
> backport-5454(createTable)-to-94_surefire-report.html, 
> backport-5454(createTable)-to-trunk.patch, 
> backport-5454(createTable)-to-trunk_surefire-report.html, 
> backport-5454-to-90.patch, backport-5454-to-92.patch, 
> backport-5454-to-92_surefire-report.html
>
>
> This issue is needed in 0.90 0.92 also.
> And update the hbase-5454 patch that add the checkInitialized() into 
> HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-22 Thread Lars Hofhansl (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl updated HBASE-5850:
-

Fix Version/s: 0.94.1

I see. Thanks xufeng. I assume this does not sink the RC, so I am targetting 
this for 0.94.1.

> Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
> is initialized
> ---
>
> Key: HBASE-5850
> URL: https://issues.apache.org/jira/browse/HBASE-5850
> Project: HBase
>  Issue Type: Bug
>Reporter: xufeng
>Assignee: xufeng
> Fix For: 0.90.7, 0.92.2, 0.94.1
>
> Attachments: backport-5454(createTable)-to-94.patch, 
> backport-5454(createTable)-to-94_surefire-report.html, 
> backport-5454(createTable)-to-trunk.patch, 
> backport-5454(createTable)-to-trunk_surefire-report.html, 
> backport-5454-to-90.patch, backport-5454-to-92.patch, 
> backport-5454-to-92_surefire-report.html
>
>
> This issue is needed in 0.90 0.92 also.
> And update the hbase-5454 patch that add the checkInitialized() into 
> HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5652) [findbugs] Fix lock release on all paths

2012-04-22 Thread Zhihong Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259277#comment-13259277
 ] 

Zhihong Yu commented on HBASE-5652:
---

I think we can release this.cacheFlushLock before setting this.logRollRunning 
to false.
We don't need the extra try/finally construct.

> [findbugs] Fix lock release on all paths 
> -
>
> Key: HBASE-5652
> URL: https://issues.apache.org/jira/browse/HBASE-5652
> Project: HBase
>  Issue Type: Sub-task
>  Components: scripts
>Reporter: Jonathan Hsieh
>Assignee: Gregory Chanan
> Attachments: HBASE-5652-v0.patch
>
>
> See 
> https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_MT_CORRECTNESS
> Category UL

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5652) [findbugs] Fix lock release on all paths

2012-04-22 Thread Gregory Chanan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259272#comment-13259272
 ] 

Gregory Chanan commented on HBASE-5652:
---

@Ted:
will update spacing

@Uma:
will update test-patch.properties

On the assignment not being able to throw an exception, I agree.  However it 
seems better to put it into a try/finally because:
1) it keeps the pattern the same with other usages
2) it works even if the line changes.  Imagine if we made it an exclude and 
then the line changed to something that could throw an exception.  We wouldn't 
see the warning because the exclude would hide it.
3) as noted by Uma, exceptions are fragile, e.g. if you rename the function you 
also have to change the exclude.

> [findbugs] Fix lock release on all paths 
> -
>
> Key: HBASE-5652
> URL: https://issues.apache.org/jira/browse/HBASE-5652
> Project: HBase
>  Issue Type: Sub-task
>  Components: scripts
>Reporter: Jonathan Hsieh
>Assignee: Gregory Chanan
> Attachments: HBASE-5652-v0.patch
>
>
> See 
> https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_MT_CORRECTNESS
> Category UL

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5652) [findbugs] Fix lock release on all paths

2012-04-22 Thread Uma Maheswara Rao G (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259177#comment-13259177
 ] 

Uma Maheswara Rao G commented on HBASE-5652:


@Gregory, Also please update the test-patch.properties reflecting to the 
current findbugs OK count with your patch

> [findbugs] Fix lock release on all paths 
> -
>
> Key: HBASE-5652
> URL: https://issues.apache.org/jira/browse/HBASE-5652
> Project: HBase
>  Issue Type: Sub-task
>  Components: scripts
>Reporter: Jonathan Hsieh
>Assignee: Gregory Chanan
> Attachments: HBASE-5652-v0.patch
>
>
> See 
> https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_MT_CORRECTNESS
> Category UL

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5833) 0.92 build has been failing pretty consistently on TestMasterFailover....

2012-04-22 Thread Zhihong Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259155#comment-13259155
 ] 

Zhihong Yu commented on HBASE-5833:
---

For the 0.92 patch, I ran TestMasterFailover 5 times and didn't see hanging.
Good job.

There're several places where line length exceeds 100 characters:
{code}
+   * This will do the necessary cleanup a call to {@link 
#createHRegion(HRegionInfo, Path, Configuration, HTableDescriptor)}
{code}
For JVMClusterUtil.java, is the following change needed ?
{code}
-  for (JVMClusterUtil.MasterThread t : masters) {
+  for (JVMClusterUtil.MasterThread t: masters) {
{code}
A new method, closeHRegion(), has been added to HRegion. 
In TestColumnPrefixFilter.java, etc. I see:
{code}
+} finally {
+  region.close();
+  region.getLog().closeAndDelete();
{code}
Can HRegion.closeHRegion() be used instead ?

> 0.92 build has been failing pretty consistently on TestMasterFailover
> -
>
> Key: HBASE-5833
> URL: https://issues.apache.org/jira/browse/HBASE-5833
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.92.2
>
> Attachments: 5833-trunk.txt, 5833-v2.092.txt, 5833.txt, 
> closehregions.txt
>
>
> Trunk seems fine but 0.92 fails on this test pretty regularly.  Running it 
> local it seems to hang for me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5621) Convert admin protocol of HRegionInterface to PB

2012-04-22 Thread Zhihong Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259090#comment-13259090
 ] 

Zhihong Yu commented on HBASE-5621:
---

For ServerManager.java:
{code}
-HRegionInterface hri = getServerConnection(server);
+AdminProtocol hri = getServerConnection(server);
{code}
Can we use a better variable name to hold the AdminProtocol ? Consider how it 
is used below:
{code}
+return ProtobufUtil.openRegion(hri, region, versionOfOfflineNode);
{code}
region is already HRegionInfo. hri used to denote HRegionInfo. Now it 
represents AdminProtocol.

> Convert admin protocol of HRegionInterface to PB
> 
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
>  Issue Type: Sub-task
>  Components: ipc, master, migration, regionserver
>Reporter: Jimmy Xiang
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, 
> hbase_5621_v4.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-2489) Make the "Filesystem needs to be upgraded" error message more useful.

2012-04-22 Thread Benoit Sigoure (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259035#comment-13259035
 ] 

Benoit Sigoure commented on HBASE-2489:
---

@chenning, this isn't a good place to ask for support, send an email to the 
user mailing list.

At this point you should be using a version of HBase that's much newer than the 
one in which this fix was made, so you shouldn't need to apply this fix.

> Make the "Filesystem needs to be upgraded" error message more useful.
> -
>
> Key: HBASE-2489
> URL: https://issues.apache.org/jira/browse/HBASE-2489
> Project: HBase
>  Issue Type: Improvement
>  Components: util
>Reporter: Benoit Sigoure
>Assignee: Benoit Sigoure
>Priority: Trivial
> Fix For: 0.90.0
>
> Attachments: 
> 0001-Improve-the-error-message-File-system-needs-to-be-up.patch
>
>
> The other day, when starting HBase I got this error:
> {noformat}
> 2010-04-23 09:38:14,847 ERROR org.apache.hadoop.hbase.master.HMaster: Failed 
> to start master
> org.apache.hadoop.hbase.util.FileSystemVersionException: File system needs to 
> be upgraded. Run the '${HBASE_HOME}/bin/hbase migrate' script.
> at org.apache.hadoop.hbase.util.FSUtils.checkVersion(FSUtils.java:187)
> {noformat}
> I was puzzled until I realized, after adding extra debug statements in the 
> code, that I forgot to properly set {{hbase.rootdir}} after re-deploying my 
> dev environment.  I think the message above was misleading and I'm proposing 
> a trivial patch to make it a little bit better:
> {noformat}
> 2010-04-23 09:48:29,000 ERROR org.apache.hadoop.hbase.master.HMaster: Failed 
> to start master
> org.apache.hadoop.hbase.util.FileSystemVersionException: File system needs to 
> be upgraded.  You have version null and I want version 7.  Run the 
> '${HBASE_HOME}/bin/hbase migrate' script.
> at org.apache.hadoop.hbase.util.FSUtils.checkVersion(FSUtils.java:189)
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5833) 0.92 build has been failing pretty consistently on TestMasterFailover....

2012-04-22 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259030#comment-13259030
 ] 

Hadoop QA commented on HBASE-5833:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12523667/5833-trunk.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 58 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 7 new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1600//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1600//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1600//console

This message is automatically generated.

> 0.92 build has been failing pretty consistently on TestMasterFailover
> -
>
> Key: HBASE-5833
> URL: https://issues.apache.org/jira/browse/HBASE-5833
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.92.2
>
> Attachments: 5833-trunk.txt, 5833-v2.092.txt, 5833.txt, 
> closehregions.txt
>
>
> Trunk seems fine but 0.92 fails on this test pretty regularly.  Running it 
> local it seems to hang for me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira