[jira] [Commented] (HBASE-22725) Remove all remaining javadoc warnings
[
https://issues.apache.org/jira/browse/HBASE-22725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904898#comment-16904898
]
Hudson commented on HBASE-22725:
Results for branch branch-2
[build #2161 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2161/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2161//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2161//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2161//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove all remaining javadoc warnings
> --
>
> Key: HBASE-22725
> URL: https://issues.apache.org/jira/browse/HBASE-22725
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 3.0.0
>Reporter: Murtaza Hassan
>Assignee: Murtaza Hassan
>Priority: Trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22725) Remove all remaining javadoc warnings
[
https://issues.apache.org/jira/browse/HBASE-22725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904903#comment-16904903
]
Hudson commented on HBASE-22725:
Results for branch branch-2.2
[build #508 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/508/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/508//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/508//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/508//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove all remaining javadoc warnings
> --
>
> Key: HBASE-22725
> URL: https://issues.apache.org/jira/browse/HBASE-22725
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 3.0.0
>Reporter: Murtaza Hassan
>Assignee: Murtaza Hassan
>Priority: Trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22728: - Attachment: HBASE-22728.branch-1.16.patch > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch, > HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch, > HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch, > HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch, > HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch, > HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] PierreZ commented on a change in pull request #439: HBASE-22618 Provide a way to have Heterogeneous deployment
PierreZ commented on a change in pull request #439: HBASE-22618 Provide a way
to have Heterogeneous deployment
URL: https://github.com/apache/hbase/pull/439#discussion_r312798067
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
##
@@ -457,6 +450,13 @@ public void testLosingRs() throws Exception {
assertNull(plans);
}
Review comment:
Awesome!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22631) assign failed may make gced parent region appear again !!!
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904923#comment-16904923 ] yuhuiyang commented on HBASE-22631: --- [~wchevreuil] [~elserj] Thank you for your suggestions. Is the submitted file assignProcedure.txt ok to support my original analysis ? And I will try to provide a unit test later . > assign failed may make gced parent region appear again !!! > -- > > Key: HBASE-22631 > URL: https://issues.apache.org/jira/browse/HBASE-22631 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Affects Versions: 2.1.1 >Reporter: yuhuiyang >Priority: Major > Attachments: HBASE-22631-branch-2.1-01.patch, assignProcedure.txt > > > When i assign a region A the process is as follows： > step1 : A is assigned to rs1 , and rs1 fails to open it . > step2 : assignProcedure handleFailure . > step3 : A is assign to rs2 and rs success to open it . > Above is the normal flow . However when rs1 is restart after the reigon A was > split and GCRegionProcedure was successed , the region A appare again ! > The region is that reigon A is not removed from the serverMap correctly when > assignprocedure handleFailure . Because the code regionNode.offline() make > the regionNode's regionLocation to be null and make regionNode's state to > OFFLINE . So when the code > env.getAssignmentManager().undoRegionAsOpening(regionNode) do nothing . So > when the rs1 restart event triggers a serverCrashProcedure, it will get > reigons from serverMap and it will get the region A then A will be assigned > and hdfs dir will be created. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn to the store with ROWCOL bloom filter throws AssertionError of scan order check
[ https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeongmin Kim updated HBASE-22835: - Attachment: HBASE-22835.patch > Scan/Get with setColumn to the store with ROWCOL bloom filter throws > AssertionError of scan order check > --- > > Key: HBASE-22835 > URL: https://issues.apache.org/jira/browse/HBASE-22835 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.12, 1.3.5 >Reporter: Jeongmin Kim >Priority: Major > Attachments: HBASE-22835.patch > > > Scan/Get with setColumn to the store with ROWCOL bloom filter could throw > AssertionError of scan order check. > which is resolved by HBASE-19863 for 1.4 or 2.x + later. > A same bug exists in branch 1.3 or older, and also my cluster suffered from > the same problem. > > When ROWCOL bloomFilter is enabled and fake cell is the prevCell, > actual hfs offset can be behind, in this case heap.next() is not enough. it > requiring reseek to find right next cell. > > I created a backport patch of HBASE-19863. > Exact same testcase included. And changed StoreScanner due to the difference > of codes. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (HBASE-22835) Scan/Get with setColumn to the store with ROWCOL bloom filter throws AssertionError of scan order check
Jeongmin Kim created HBASE-22835: Summary: Scan/Get with setColumn to the store with ROWCOL bloom filter throws AssertionError of scan order check Key: HBASE-22835 URL: https://issues.apache.org/jira/browse/HBASE-22835 Project: HBase Issue Type: Bug Affects Versions: 1.3.5, 1.2.12 Reporter: Jeongmin Kim Attachments: HBASE-22835.patch Scan/Get with setColumn to the store with ROWCOL bloom filter could throw AssertionError of scan order check. which is resolved by HBASE-19863 for 1.4 or 2.x + later. A same bug exists in branch 1.3 or older, and also my cluster suffered from the same problem. When ROWCOL bloomFilter is enabled and fake cell is the prevCell, actual hfs offset can be behind, in this case heap.next() is not enough. it requiring reseek to find right next cell. I created a backport patch of HBASE-19863. Exact same testcase included. And changed StoreScanner due to the difference of codes. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn to the store with ROWCOL bloom filter throws AssertionError of scan order check
[ https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeongmin Kim updated HBASE-22835: - Description: Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError of scan order check. which is resolved by HBASE-19863 for 1.4 or 2.x + later. A same bug exists in branch 1.3 or older, and also my cluster suffered from the same problem. When ROWCOL bloomFilter is enabled and fake cell is the prevCell, actual hfs offset can be behind, in this case heap.next() is not enough. it requiring reseek to find right next cell. I created a backport patch of HBASE-19863. Exact same testcase included. And changed StoreScanner due to the difference of codes. was: Scan/Get with setColumn to the store with ROWCOL bloom filter could throw AssertionError of scan order check. which is resolved by HBASE-19863 for 1.4 or 2.x + later. A same bug exists in branch 1.3 or older, and also my cluster suffered from the same problem. When ROWCOL bloomFilter is enabled and fake cell is the prevCell, actual hfs offset can be behind, in this case heap.next() is not enough. it requiring reseek to find right next cell. I created a backport patch of HBASE-19863. Exact same testcase included. And changed StoreScanner due to the difference of codes. > Scan/Get with setColumn to the store with ROWCOL bloom filter throws > AssertionError of scan order check > --- > > Key: HBASE-22835 > URL: https://issues.apache.org/jira/browse/HBASE-22835 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.12, 1.3.5 >Reporter: Jeongmin Kim >Priority: Major > Attachments: HBASE-22835.patch > > > Scan/Get with setColumn and the store with ROWCOL bloom filter could throw > AssertionError of scan order check. > which is resolved by HBASE-19863 for 1.4 or 2.x + later. > A same bug exists in branch 1.3 or older, and also my cluster suffered from > the same problem. > > When ROWCOL bloomFilter is enabled and fake cell is the prevCell, > actual hfs offset can be behind, in this case heap.next() is not enough. it > requiring reseek to find right next cell. > > I created a backport patch of HBASE-19863. > Exact same testcase included. And changed StoreScanner due to the difference > of codes. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn to the store with ROWCOL bloom filter throws AssertionError of scan order check
[ https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeongmin Kim updated HBASE-22835: - Description: Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError of scan order check. which is resolved by HBASE-19863 for 1.4, 2.x, or later version. A same bug exists in branch 1.3 or older, and also my cluster suffered from the same problem. When ROWCOL bloomFilter is enabled and fake cell is the prevCell, actual hfs offset can be behind, in this case heap.next() is not enough. it requiring reseek to find right next cell. I created a backport patch of HBASE-19863. Exact same testcase included. And changed StoreScanner due to the difference of codes. was: Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError of scan order check. which is resolved by HBASE-19863 for 1.4 or 2.x + later. A same bug exists in branch 1.3 or older, and also my cluster suffered from the same problem. When ROWCOL bloomFilter is enabled and fake cell is the prevCell, actual hfs offset can be behind, in this case heap.next() is not enough. it requiring reseek to find right next cell. I created a backport patch of HBASE-19863. Exact same testcase included. And changed StoreScanner due to the difference of codes. > Scan/Get with setColumn to the store with ROWCOL bloom filter throws > AssertionError of scan order check > --- > > Key: HBASE-22835 > URL: https://issues.apache.org/jira/browse/HBASE-22835 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.12, 1.3.5 >Reporter: Jeongmin Kim >Priority: Major > Attachments: HBASE-22835.patch > > > Scan/Get with setColumn and the store with ROWCOL bloom filter could throw > AssertionError of scan order check. > which is resolved by HBASE-19863 for 1.4, 2.x, or later version. > A same bug exists in branch 1.3 or older, and also my cluster suffered from > the same problem. > > When ROWCOL bloomFilter is enabled and fake cell is the prevCell, > actual hfs offset can be behind, in this case heap.next() is not enough. it > requiring reseek to find right next cell. > > I created a backport patch of HBASE-19863. > Exact same testcase included. And changed StoreScanner due to the difference > of codes. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn to the store with ROWCOL bloom filter throws AssertionError of scan order check
[ https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeongmin Kim updated HBASE-22835: - Description: Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError of scan order check. which is resolved by HBASE-19863 for 1.4, 2.x, or later version. A same bug exists in branch 1.3 and older, and also my cluster suffered from the same problem. When ROWCOL bloomFilter is enabled and fake cell is the prevCell, actual hfs offset can be behind, in this case heap.next() is not enough. it requiring reseek to find right next cell. I created a backport patch of HBASE-19863. Exact same testcase included. And changed StoreScanner due to the difference of codes. was: Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError of scan order check. which is resolved by HBASE-19863 for 1.4, 2.x, or later version. A same bug exists in branch 1.3 or older, and also my cluster suffered from the same problem. When ROWCOL bloomFilter is enabled and fake cell is the prevCell, actual hfs offset can be behind, in this case heap.next() is not enough. it requiring reseek to find right next cell. I created a backport patch of HBASE-19863. Exact same testcase included. And changed StoreScanner due to the difference of codes. > Scan/Get with setColumn to the store with ROWCOL bloom filter throws > AssertionError of scan order check > --- > > Key: HBASE-22835 > URL: https://issues.apache.org/jira/browse/HBASE-22835 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.12, 1.3.5 >Reporter: Jeongmin Kim >Priority: Major > Attachments: HBASE-22835.patch > > > Scan/Get with setColumn and the store with ROWCOL bloom filter could throw > AssertionError of scan order check. > which is resolved by HBASE-19863 for 1.4, 2.x, or later version. > A same bug exists in branch 1.3 and older, and also my cluster suffered from > the same problem. > > When ROWCOL bloomFilter is enabled and fake cell is the prevCell, > actual hfs offset can be behind, in this case heap.next() is not enough. it > requiring reseek to find right next cell. > > I created a backport patch of HBASE-19863. > Exact same testcase included. And changed StoreScanner due to the difference > of codes. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn to the store with ROWCOL bloom filter throws AssertionError of scan order check
[ https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeongmin Kim updated HBASE-22835: - Description: Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError of scan order check. which is resolved by HBASE-19863 for 1.4, 2.x, or later version. A same bug exists in branch 1.3 and older, and also my cluster suffered from the same problem. When ROWCOL bloomFilter is enabled and fake cell is the prevCell, actual hfs offset can be behind, in this case heap.next() is not enough. it requires reseek to find right next cell. I created a backport patch of HBASE-19863. Exact same testcase included. And changed StoreScanner due to the difference of codes. was: Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError of scan order check. which is resolved by HBASE-19863 for 1.4, 2.x, or later version. A same bug exists in branch 1.3 and older, and also my cluster suffered from the same problem. When ROWCOL bloomFilter is enabled and fake cell is the prevCell, actual hfs offset can be behind, in this case heap.next() is not enough. it requiring reseek to find right next cell. I created a backport patch of HBASE-19863. Exact same testcase included. And changed StoreScanner due to the difference of codes. > Scan/Get with setColumn to the store with ROWCOL bloom filter throws > AssertionError of scan order check > --- > > Key: HBASE-22835 > URL: https://issues.apache.org/jira/browse/HBASE-22835 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.12, 1.3.5 >Reporter: Jeongmin Kim >Priority: Major > Attachments: HBASE-22835.patch > > > Scan/Get with setColumn and the store with ROWCOL bloom filter could throw > AssertionError of scan order check. > which is resolved by HBASE-19863 for 1.4, 2.x, or later version. > A same bug exists in branch 1.3 and older, and also my cluster suffered from > the same problem. > > When ROWCOL bloomFilter is enabled and fake cell is the prevCell, > actual hfs offset can be behind, in this case heap.next() is not enough. it > requires reseek to find right next cell. > > I created a backport patch of HBASE-19863. > Exact same testcase included. And changed StoreScanner due to the difference > of codes. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException
Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/436#issuecomment-520326052 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 79 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 330 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 31 | master passed | | +1 | shadedjars | 281 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 23 | master passed | | 0 | spotbugs | 72 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 71 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 308 | the patch passed | | +1 | compile | 25 | the patch passed | | +1 | javac | 25 | the patch passed | | +1 | checkstyle | 31 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 289 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1012 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 21 | the patch passed | | +1 | findbugs | 74 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 100 | hbase-client in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 3098 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/44/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/436 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 13078273ee67 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-436/out/precommit/personality/provided.sh | | git revision | master / 3867fae04d | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/44/testReport/ | | Max. process+thread count | 243 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/44/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn to the store with ROWCOL bloom filter throws AssertionError of scan order check
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Description:
Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
AssertionError of scan order check.
which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
A same bug exists in branch 1.3 and older, and also my cluster suffered from
the same problem.
When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
actual hfs offset can be behind, in this case heap.next() is not enough. it
requires reseek to find right next cell.
{code:java}
Mon Jan 29 19:01:06 UTC 2018, RpcRetryingCaller{globalStartTime=1517252466261,
pause=250, retries=6}, java.io.IOException: java.io.IOException: Key
key10018/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
key key10018/0:C04/1517252461198/Put/vlen=3/seqid=4 in cf 0
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2412)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277)
Caused by: java.lang.AssertionError: Key
key10018/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
key key10018/0:C04/1517252461198/Put/vlen=3/seqid=4 in cf 0
at
org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:975)
at
org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:555)
at
org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:152)
at
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6219)
at
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6379)
at
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6151)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2808)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3045)
at
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:36613)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2354)
... 3 more
{code}
I created a backport patch of HBASE-19863.
Exact same testcase included. And changed StoreScanner due to the difference of
codes.
was:
Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
AssertionError of scan order check.
which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
A same bug exists in branch 1.3 and older, and also my cluster suffered from
the same problem.
When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
actual hfs offset can be behind, in this case heap.next() is not enough. it
requires reseek to find right next cell.
I created a backport patch of HBASE-19863.
Exact same testcase included. And changed StoreScanner due to the difference of
codes.
> Scan/Get with setColumn to the store with ROWCOL bloom filter throws
> AssertionError of scan order check
> ---
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.12, 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Attachments: HBASE-22835.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> Mon Jan 29 19:01:06 UTC 2018,
> RpcRetryingCaller{globalStartTime=1517252466261, pause=250, retries=6},
> java.io.IOException: java.io.IOException: Key
> key10018/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key10018/0:C04/1517252461198/Put/vlen=3/seqid=4 in cf 0
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2412)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277)
> Caused by: java.lang.AssertionError: Key
> key10018/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn to the store with ROWCOL bloom filter throws AssertionError of scan order check
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Attachment: (was: HBASE-22835.patch)
> Scan/Get with setColumn to the store with ROWCOL bloom filter throws
> AssertionError of scan order check
> ---
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> Mon Jan 29 19:01:06 UTC 2018,
> RpcRetryingCaller{globalStartTime=1517252466261, pause=250, retries=6},
> java.io.IOException: java.io.IOException: Key
> key10018/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key10018/0:C04/1517252461198/Put/vlen=3/seqid=4 in cf 0
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2412)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277)
> Caused by: java.lang.AssertionError: Key
> key10018/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key10018/0:C04/1517252461198/Put/vlen=3/seqid=4 in cf 0
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:975)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:555)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:152)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6219)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6379)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6151)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2808)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3045)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:36613)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2354)
> ... 3 more
> {code}
>
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn to the store with ROWCOL bloom filter throws AssertionError of scan order check
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Fix Version/s: 1.3.6
Affects Version/s: (was: 1.2.12)
Attachment: HBASE-22835.patch
Status: Patch Available (was: Open)
> Scan/Get with setColumn to the store with ROWCOL bloom filter throws
> AssertionError of scan order check
> ---
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> Mon Jan 29 19:01:06 UTC 2018,
> RpcRetryingCaller{globalStartTime=1517252466261, pause=250, retries=6},
> java.io.IOException: java.io.IOException: Key
> key10018/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key10018/0:C04/1517252461198/Put/vlen=3/seqid=4 in cf 0
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2412)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277)
> Caused by: java.lang.AssertionError: Key
> key10018/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key10018/0:C04/1517252461198/Put/vlen=3/seqid=4 in cf 0
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:975)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:555)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:152)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6219)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6379)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6151)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2808)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3045)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:36613)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2354)
> ... 3 more
> {code}
>
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-520327023 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 36 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 323 | master passed | | +1 | compile | 25 | master passed | | +1 | checkstyle | 15 | master passed | | +1 | shadedjars | 276 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 21 | master passed | | 0 | spotbugs | 50 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 49 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 296 | the patch passed | | +1 | compile | 25 | the patch passed | | +1 | javac | 25 | the patch passed | | +1 | checkstyle | 13 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 277 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 930 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 19 | the patch passed | | +1 | findbugs | 50 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 417 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 3330 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/81/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 830acdebf223 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / 3867fae04d | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/81/testReport/ | | Max. process+thread count | 4505 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/81/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22835) Scan/Get with setColumn to the store with ROWCOL bloom filter throws AssertionError of scan order check
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904940#comment-16904940
]
HBase QA commented on HBASE-22835:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color}
| {color:red} HBASE-22835 does not apply to master. Rebase required? Wrong
Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-22835 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12977305/HBASE-22835.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/752/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> Scan/Get with setColumn to the store with ROWCOL bloom filter throws
> AssertionError of scan order check
> ---
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> Mon Jan 29 19:01:06 UTC 2018,
> RpcRetryingCaller{globalStartTime=1517252466261, pause=250, retries=6},
> java.io.IOException: java.io.IOException: Key
> key10018/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key10018/0:C04/1517252461198/Put/vlen=3/seqid=4 in cf 0
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2412)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277)
> Caused by: java.lang.AssertionError: Key
> key10018/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key10018/0:C04/1517252461198/Put/vlen=3/seqid=4 in cf 0
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:975)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:555)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:152)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6219)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6379)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6151)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2808)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3045)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:36613)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2354)
> ... 3 more
> {code}
>
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn to the store with ROWCOL bloom filter throws AssertionError of scan order check
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Description:
Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
AssertionError of scan order check.
which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
A same bug exists in branch 1.3 and older, and also my cluster suffered from
the same problem.
When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
actual hfs offset can be behind, in this case heap.next() is not enough. it
requires reseek to find right next cell.
{code:java}
java.lang.AssertionError: Key
key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller key
key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
at
org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
at
org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
at
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
at
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
at
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
at
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168) {code}
I created a backport patch of HBASE-19863.
Exact same testcase included. And changed StoreScanner due to the difference of
codes.
was:
Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
AssertionError of scan order check.
which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
A same bug exists in branch 1.3 and older, and also my cluster suffered from
the same problem.
When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
actual hfs offset can be behind, in this case heap.next() is not enough. it
requires reseek to find right next cell.
{code:java}
Mon Jan 29 19:01:06 UTC 2018, RpcRetryingCaller{globalStartTime=1517252466261,
pause=250, retries=6}, java.io.IOException: java.io.IOException: Key
key10018/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
key key10018/0:C04/1517252461198/Put/vlen=3/seqid=4 in cf 0
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2412)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277)
Caused by: java.lang.AssertionError: Key
key10018/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
key key10018/0:C04/1517252461198/Put/vlen=3/seqid=4 in cf 0
at
org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:975)
at
org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:555)
at
org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:152)
at
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6219)
at
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6379)
at
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6151)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2808)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3045)
at
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:36613)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2354)
... 3 more
{code}
I created a backport patch of HBASE-19863.
Exact same testcase included. And changed StoreScanner due to the difference of
codes.
> Scan/Get with setColumn to the store with ROWCOL bloom filter throws
> AssertionError of scan order check
> ---
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongm
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Summary: Scan/Get with setColumn and the store with ROWCOL bloom filter
could throw AssertionError (backport of HBASE-19863) (was: Scan/Get with
setColumn and the store with ROWCOL bloom filter could throw AssertionError)
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Summary: Scan/Get with setColumn and the store with ROWCOL bloom filter
could throw AssertionError (was: Scan/Get with setColumn to the store with
ROWCOL bloom filter throws AssertionError of scan order check)
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError
> -
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Attachment: HBASE-22835.branch-1.3.patch
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch, HBASE-22835.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Attachment: (was: HBASE-22835.patch)
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache9 merged pull request #436: HBASE-22699 refactor isMetaClearingException
Apache9 merged pull request #436: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/436 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904944#comment-16904944
]
HBase QA commented on HBASE-22835:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} HBASE-22835 does not apply to branch-1.3. Rebase required? Wrong
Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-22835 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12977308/HBASE-22835.branch-1.3.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/753/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22699) refactor isMetaClearingException
[ https://issues.apache.org/jira/browse/HBASE-22699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22699: -- Component/s: Client > refactor isMetaClearingException > > > Key: HBASE-22699 > URL: https://issues.apache.org/jira/browse/HBASE-22699 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Junhong Xu >Assignee: Junhong Xu >Priority: Minor > > It is not so readable -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] HuiHang-Yu commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again
HuiHang-Yu commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again URL: https://github.com/apache/hbase/pull/456#issuecomment-520335860 @saintstack Thank you for your comment. Yes i was cofused by how to write a UT for it . How can i simulate that the region can not be open for hdfs problem (maybe like Missing table descriptor for in my assignProcedure.txt [assignProcedure.txt](https://github.com/apache/hbase/files/3491479/assignProcedure.txt) ) and can be opend in another regionserver . The logic I modified is simple : RegionNode.offline() makes region location to null and when the code execute the following line env.getAssignmentManager().undoRegionAsOpening(regionNode) it will do nothing . So the regionstates in assignmanager will not remove this region from rs regions according to serverMap . So the serverMap will retain the relation rs tempt20 (for example in my assignProcedure.txt) <- region forever even the region is open in regionserver tempt21 (for example in my assignProcedure.txt) .  When the rs tempt20 crash it will create a subprocedure assignprocedure for this region which may be open in another rs according to serverMap . So the region info will be put into the meta table even if this region has been split and gced in another rs (delete from meta table) .   This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22631) assign failed may make gced parent region appear again !!!
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuhuiyang updated HBASE-22631: -- Attachment: (was: assignProcedure.txt) > assign failed may make gced parent region appear again !!! > -- > > Key: HBASE-22631 > URL: https://issues.apache.org/jira/browse/HBASE-22631 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Affects Versions: 2.1.1 >Reporter: yuhuiyang >Priority: Major > Attachments: HBASE-22631-branch-2.1-01.patch > > > When i assign a region A the process is as follows： > step1 : A is assigned to rs1 , and rs1 fails to open it . > step2 : assignProcedure handleFailure . > step3 : A is assign to rs2 and rs success to open it . > Above is the normal flow . However when rs1 is restart after the reigon A was > split and GCRegionProcedure was successed , the region A appare again ! > The region is that reigon A is not removed from the serverMap correctly when > assignprocedure handleFailure . Because the code regionNode.offline() make > the regionNode's regionLocation to be null and make regionNode's state to > OFFLINE . So when the code > env.getAssignmentManager().undoRegionAsOpening(regionNode) do nothing . So > when the rs1 restart event triggers a serverCrashProcedure, it will get > reigons from serverMap and it will get the region A then A will be assigned > and hdfs dir will be created. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Attachment: (was: HBASE-22835.branch-1.3.patch)
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Attachment: HBASE-22835.branch-1.3.patch
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] PierreZ commented on a change in pull request #439: HBASE-22618 Provide a way to have Heterogeneous deployment
PierreZ commented on a change in pull request #439: HBASE-22618 Provide a way to have Heterogeneous deployment URL: https://github.com/apache/hbase/pull/439#discussion_r312817418 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java ## @@ -53,6 +47,10 @@ import org.junit.Test; import org.junit.experimental.categories.Category; +import static org.junit.Assert.*; Review comment: I'm sorry for the trouble, I must admit that I was trusting the import style of my IDE 😄 Will fix it in another commit that will be checked locally this time This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22631) assign failed may make gced parent region appear again !!!
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuhuiyang updated HBASE-22631: -- Attachment: assignProcedure.txt > assign failed may make gced parent region appear again !!! > -- > > Key: HBASE-22631 > URL: https://issues.apache.org/jira/browse/HBASE-22631 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Affects Versions: 2.1.1 >Reporter: yuhuiyang >Priority: Major > Attachments: HBASE-22631-branch-2.1-01.patch, assignProcedure.txt > > > When i assign a region A the process is as follows： > step1 : A is assigned to rs1 , and rs1 fails to open it . > step2 : assignProcedure handleFailure . > step3 : A is assign to rs2 and rs success to open it . > Above is the normal flow . However when rs1 is restart after the reigon A was > split and GCRegionProcedure was successed , the region A appare again ! > The region is that reigon A is not removed from the serverMap correctly when > assignprocedure handleFailure . Because the code regionNode.offline() make > the regionNode's regionLocation to be null and make regionNode's state to > OFFLINE . So when the code > env.getAssignmentManager().undoRegionAsOpening(regionNode) do nothing . So > when the rs1 restart event triggers a serverCrashProcedure, it will get > reigons from serverMap and it will get the region A then A will be assigned > and hdfs dir will be created. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22631) assign failed may make gced parent region appear again !!!
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuhuiyang updated HBASE-22631: -- Attachment: assign.png > assign failed may make gced parent region appear again !!! > -- > > Key: HBASE-22631 > URL: https://issues.apache.org/jira/browse/HBASE-22631 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Affects Versions: 2.1.1 >Reporter: yuhuiyang >Priority: Major > Attachments: HBASE-22631-branch-2.1-01.patch, assign.png, > assignProcedure.txt > > > When i assign a region A the process is as follows： > step1 : A is assigned to rs1 , and rs1 fails to open it . > step2 : assignProcedure handleFailure . > step3 : A is assign to rs2 and rs success to open it . > Above is the normal flow . However when rs1 is restart after the reigon A was > split and GCRegionProcedure was successed , the region A appare again ! > The region is that reigon A is not removed from the serverMap correctly when > assignprocedure handleFailure . Because the code regionNode.offline() make > the regionNode's regionLocation to be null and make regionNode's state to > OFFLINE . So when the code > env.getAssignmentManager().undoRegionAsOpening(regionNode) do nothing . So > when the rs1 restart event triggers a serverCrashProcedure, it will get > reigons from serverMap and it will get the region A then A will be assigned > and hdfs dir will be created. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22631) assign failed may make gced parent region appear again !!!
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuhuiyang updated HBASE-22631: -- Attachment: splitAndGc.png > assign failed may make gced parent region appear again !!! > -- > > Key: HBASE-22631 > URL: https://issues.apache.org/jira/browse/HBASE-22631 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Affects Versions: 2.1.1 >Reporter: yuhuiyang >Priority: Major > Attachments: HBASE-22631-branch-2.1-01.patch, assign.png, > assignProcedure.txt, serverCrash.png, splitAndGc.png > > > When i assign a region A the process is as follows： > step1 : A is assigned to rs1 , and rs1 fails to open it . > step2 : assignProcedure handleFailure . > step3 : A is assign to rs2 and rs success to open it . > Above is the normal flow . However when rs1 is restart after the reigon A was > split and GCRegionProcedure was successed , the region A appare again ! > The region is that reigon A is not removed from the serverMap correctly when > assignprocedure handleFailure . Because the code regionNode.offline() make > the regionNode's regionLocation to be null and make regionNode's state to > OFFLINE . So when the code > env.getAssignmentManager().undoRegionAsOpening(regionNode) do nothing . So > when the rs1 restart event triggers a serverCrashProcedure, it will get > reigons from serverMap and it will get the region A then A will be assigned > and hdfs dir will be created. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (HBASE-22699) refactor isMetaClearingException
[ https://issues.apache.org/jira/browse/HBASE-22699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-22699. --- Resolution: Fixed Hadoop Flags: Reviewed Pushed to branch-2.0+. Thanks [~Joseph295] for contributing. > refactor isMetaClearingException > > > Key: HBASE-22699 > URL: https://issues.apache.org/jira/browse/HBASE-22699 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Junhong Xu >Assignee: Junhong Xu >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > > It is not so readable -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22631) assign failed may make gced parent region appear again !!!
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuhuiyang updated HBASE-22631: -- Attachment: serverCrash.png > assign failed may make gced parent region appear again !!! > -- > > Key: HBASE-22631 > URL: https://issues.apache.org/jira/browse/HBASE-22631 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Affects Versions: 2.1.1 >Reporter: yuhuiyang >Priority: Major > Attachments: HBASE-22631-branch-2.1-01.patch, assign.png, > assignProcedure.txt, serverCrash.png, splitAndGc.png > > > When i assign a region A the process is as follows： > step1 : A is assigned to rs1 , and rs1 fails to open it . > step2 : assignProcedure handleFailure . > step3 : A is assign to rs2 and rs success to open it . > Above is the normal flow . However when rs1 is restart after the reigon A was > split and GCRegionProcedure was successed , the region A appare again ! > The region is that reigon A is not removed from the serverMap correctly when > assignprocedure handleFailure . Because the code regionNode.offline() make > the regionNode's regionLocation to be null and make regionNode's state to > OFFLINE . So when the code > env.getAssignmentManager().undoRegionAsOpening(regionNode) do nothing . So > when the rs1 restart event triggers a serverCrashProcedure, it will get > reigons from serverMap and it will get the region A then A will be assigned > and hdfs dir will be created. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22699) refactor isMetaClearingException
[ https://issues.apache.org/jira/browse/HBASE-22699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22699: -- Fix Version/s: 2.1.6 2.2.1 2.0.6 2.3.0 3.0.0 > refactor isMetaClearingException > > > Key: HBASE-22699 > URL: https://issues.apache.org/jira/browse/HBASE-22699 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Junhong Xu >Assignee: Junhong Xu >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > > It is not so readable -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22631) assign failed may make gced parent region appear again !!!
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904969#comment-16904969 ] yuhuiyang commented on HBASE-22631: --- I am cofused by how to write a UT for it . How can i simulate that the region can not be open for hdfs can be opend in another regionserver . [^assignProcedure.txt] is my test log . Follows are my test log photo for third stages: stage1 : assign failure in tempt20 and success in tempt21. !assign.png! stage2: split and deleted for gcprocedure. !splitAndGc.png! stage3: tempt20 crash and region appear again . !serverCrash.png! > assign failed may make gced parent region appear again !!! > -- > > Key: HBASE-22631 > URL: https://issues.apache.org/jira/browse/HBASE-22631 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Affects Versions: 2.1.1 >Reporter: yuhuiyang >Priority: Major > Attachments: HBASE-22631-branch-2.1-01.patch, assign.png, > assignProcedure.txt, serverCrash.png, splitAndGc.png > > > When i assign a region A the process is as follows： > step1 : A is assigned to rs1 , and rs1 fails to open it . > step2 : assignProcedure handleFailure . > step3 : A is assign to rs2 and rs success to open it . > Above is the normal flow . However when rs1 is restart after the reigon A was > split and GCRegionProcedure was successed , the region A appare again ! > The region is that reigon A is not removed from the serverMap correctly when > assignprocedure handleFailure . Because the code regionNode.offline() make > the regionNode's regionLocation to be null and make regionNode's state to > OFFLINE . So when the code > env.getAssignmentManager().undoRegionAsOpening(regionNode) do nothing . So > when the rs1 restart event triggers a serverCrashProcedure, it will get > reigons from serverMap and it will get the region A then A will be assigned > and hdfs dir will be created. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] HuiHang-Yu edited a comment on issue #456: HBASE-22631 assign failed may make gced parent region appear again
HuiHang-Yu edited a comment on issue #456: HBASE-22631 assign failed may make gced parent region appear again URL: https://github.com/apache/hbase/pull/456#issuecomment-520335860 @saintstack Thank you for your comment. Yes i was cofused by how to write a UT for it . How can i simulate that the region can not be open for hdfs problem (maybe like Missing table descriptor for in my assignProcedure.txt [assignProcedure.txt](https://github.com/apache/hbase/files/3491479/assignProcedure.txt) ) and can be opend in another regionserver for hdfs problem fixed. The logic I modified is simple : RegionNode.offline() makes region location to null and when the code execute the following line env.getAssignmentManager().undoRegionAsOpening(regionNode) it will do nothing . So the regionstates in assignmanager will not remove this region from rs regions according to serverMap . So the serverMap will retain the relation rs tempt20 (for example in my assignProcedure.txt) <- region forever even the region is open in regionserver tempt21 (for example in my assignProcedure.txt) .  When the rs tempt20 crash it will create a subprocedure assignprocedure for this region which may be open in another rs according to serverMap . So the region info will be put into the meta table even if this region has been split and gced in another rs (delete from meta table) .   This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-22631) assign failed may make gced parent region appear again !!!
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904969#comment-16904969 ] yuhuiyang edited comment on HBASE-22631 at 8/12/19 8:28 AM: I am cofused by how to write a UT for it . How can i simulate that the region can not be open for hdfs problem but can be opend in another regionserver for hdfs problem fixed. [^assignProcedure.txt] is my test log . Follows are my test log photo for third stages: stage1 : assign failure in tempt20 and success in tempt21. !assign.png! stage2: split and deleted for gcprocedure. !splitAndGc.png! stage3: tempt20 crash and region appear again . !serverCrash.png! was (Author: yu-huiyang): I am cofused by how to write a UT for it . How can i simulate that the region can not be open for hdfs can be opend in another regionserver . [^assignProcedure.txt] is my test log . Follows are my test log photo for third stages: stage1 : assign failure in tempt20 and success in tempt21. !assign.png! stage2: split and deleted for gcprocedure. !splitAndGc.png! stage3: tempt20 crash and region appear again . !serverCrash.png! > assign failed may make gced parent region appear again !!! > -- > > Key: HBASE-22631 > URL: https://issues.apache.org/jira/browse/HBASE-22631 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Affects Versions: 2.1.1 >Reporter: yuhuiyang >Priority: Major > Attachments: HBASE-22631-branch-2.1-01.patch, assign.png, > assignProcedure.txt, serverCrash.png, splitAndGc.png > > > When i assign a region A the process is as follows： > step1 : A is assigned to rs1 , and rs1 fails to open it . > step2 : assignProcedure handleFailure . > step3 : A is assign to rs2 and rs success to open it . > Above is the normal flow . However when rs1 is restart after the reigon A was > split and GCRegionProcedure was successed , the region A appare again ! > The region is that reigon A is not removed from the serverMap correctly when > assignprocedure handleFailure . Because the code regionNode.offline() make > the regionNode's regionLocation to be null and make regionNode's state to > OFFLINE . So when the code > env.getAssignmentManager().undoRegionAsOpening(regionNode) do nothing . So > when the rs1 restart event triggers a serverCrashProcedure, it will get > reigons from serverMap and it will get the region A then A will be assigned > and hdfs dir will be created. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904976#comment-16904976
]
HBase QA commented on HBASE-22835:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 8s{color}
| {color:red} HBASE-22835 does not apply to branch-1.3. Rebase required? Wrong
Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-22835 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12977310/HBASE-22835.branch-1.3.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/754/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904984#comment-16904984
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #56 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/56/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/56//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/56//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/56//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904985#comment-16904985
]
Reid Chan commented on HBASE-22835:
---
Ensure you code is based on up-to-data branch-1.3
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] virajjasani commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
virajjasani commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-520348269 @Reidd Hence, balancer will be turned off before starting with rolling restart and turned on after all n servers are restarted (not in-between restarts of individuals servers). However, I am just wondering if there are any other such scenarios where we keep turning on/off balancer quite frequently as part of some workflow? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani edited a comment on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
virajjasani edited a comment on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-520348269 @Reidd Hence, balancer will be turned off before starting with rolling restart and turned on after all n servers are restarted (not in-between restarts of individual servers). However, I am just wondering if there are any other such scenarios where we keep turning on/off balancer quite frequently as part of some workflow? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-520350419 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 98 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 381 | master passed | | +1 | compile | 26 | master passed | | +1 | checkstyle | 14 | master passed | | +1 | shadedjars | 303 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 22 | master passed | | 0 | spotbugs | 55 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 53 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 346 | the patch passed | | +1 | compile | 26 | the patch passed | | +1 | javac | 26 | the patch passed | | +1 | checkstyle | 12 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 304 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1085 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 26 | the patch passed | | +1 | findbugs | 68 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 981 | hbase-rsgroup in the patch failed. | | +1 | asflicense | 17 | The patch does not generate ASF License warnings. | | | | 4242 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.rsgroup.TestRSGroupsKillRS | | | hadoop.hbase.rsgroup.TestRSGroupsAdmin1 | | | hadoop.hbase.rsgroup.TestRSGroupsAdmin2 | | | hadoop.hbase.rsgroup.TestRSGroupsBasics | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/82/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2f3a71689a02 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / 009851d680 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/82/artifact/out/patch-unit-hbase-rsgroup.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/82/testReport/ | | Max. process+thread count | 4879 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/82/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-520353383 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 85 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 368 | branch-2.1 passed | | +1 | compile | 27 | branch-2.1 passed | | +1 | checkstyle | 41 | branch-2.1 passed | | +1 | shadedjars | 266 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 26 | branch-2.1 passed | | 0 | spotbugs | 82 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 79 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 309 | the patch passed | | +1 | compile | 28 | the patch passed | | +1 | javac | 28 | the patch passed | | +1 | checkstyle | 40 | hbase-client: The patch generated 0 new + 56 unchanged - 4 fixed = 56 total (was 60) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 294 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1359 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 23 | the patch passed | | +1 | findbugs | 89 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 210 | hbase-client in the patch failed. | | +1 | asflicense | 15 | The patch does not generate ASF License warnings. | | | | 3650 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAsyncProcess | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/56/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/343 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux a619cf8d4c1c 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh | | git revision | branch-2.1 / a0d5627a33 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/56/artifact/out/patch-unit-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/56/testReport/ | | Max. process+thread count | 262 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/56/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Attachment: HBASE-22835.branch-1.3.patch
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch,
> HBASE-22835.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Attachment: (was: HBASE-22835.branch-1.3.patch)
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22784) OldWALs not cleared in a replication slave cluster (cyclic replication bw 2 clusters)
[ https://issues.apache.org/jira/browse/HBASE-22784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905028#comment-16905028 ] Wellington Chevreuil commented on HBASE-22784: -- Tested branch-2, which does not seem affected by this problem. > OldWALs not cleared in a replication slave cluster (cyclic replication bw 2 > clusters) > - > > Key: HBASE-22784 > URL: https://issues.apache.org/jira/browse/HBASE-22784 > Project: HBase > Issue Type: Bug > Components: regionserver, Replication >Affects Versions: 1.4.9, 1.4.10 >Reporter: Solvannan R M >Assignee: Wellington Chevreuil >Priority: Blocker > Fix For: 1.5.0 > > Attachments: HBASE-22784.branch-1.001.patch, > HBASE-22784.branch-1.002.patch, HBASE-22784.branch-1.003.patch, > HBASE-22784.branch-1.004.patch > > > When a cluster is passive (receiving edits only via replication) in a cyclic > replication setup of 2 clusters, OldWALs size keeps on growing. On analysing, > we observed the following behaviour. > # New entry is added to WAL (Edit replicated from other cluster). > # ReplicationSourceWALReaderThread(RSWALRT) reads and applies the configured > filters (due to cyclic replication setup, ClusterMarkingEntryFilter discards > new entry from other cluster). > # Entry is null, RSWALRT neither updates the batch stats > (WALEntryBatch.lastWalPosition) nor puts it in the entryBatchQueue. > # ReplicationSource thread is blocked in entryBachQueue.take(). > # So ReplicationSource#updateLogPosition has never invoked and WAL file is > never cleared from ReplicationQueue. > # Hence LogCleaner on the master, doesn't deletes the oldWAL files from > hadoop. > NOTE: When a new edit is added via hbase-client, ReplicationSource thread > process and clears the oldWAL files from replication queues and hence master > cleans up the WALs > Please provide us a solution > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Reidddddd commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
Reidd commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-520361140 > Hence, balancer will be turned off before starting with rolling restart and turned on after all n servers are restarted (not in-between restarts of individual servers). Hmm, right. But it only works for master and branch-2. But even it only targets to a single RS where balance off is only a temporary move, do you really think it is a good practice or worthy of destructing then constructing a task, just within few minutes? > However, I am just wondering if there are any other such scenarios where we keep turning on/off balancer quite frequently as part of some workflow? Just rolling restart, maybe. One place I'm not sure is RSGroup's move_regions op. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Status: Open (was: Patch Available)
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22830) Remove deprecated method from StoreFile
[
https://issues.apache.org/jira/browse/HBASE-22830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905037#comment-16905037
]
Hudson commented on HBASE-22830:
Results for branch master
[build #1327 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1327/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1327//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1327//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1327//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove deprecated method from StoreFile
> ---
>
> Key: HBASE-22830
> URL: https://issues.apache.org/jira/browse/HBASE-22830
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0
>
>
> {{getModificationTimeStamp}} in {{StoreFile}} is deprecated and should be
> removed in 3.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22831) Remove deprecated constructor from TableRecordWriter
[
https://issues.apache.org/jira/browse/HBASE-22831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905034#comment-16905034
]
Hudson commented on HBASE-22831:
Results for branch master
[build #1327 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1327/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1327//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1327//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1327//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove deprecated constructor from TableRecordWriter
>
>
> Key: HBASE-22831
> URL: https://issues.apache.org/jira/browse/HBASE-22831
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0
>
>
> {{TableRecordWriter}} has a deprecated constructor, which should be removed
> in 3.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22725) Remove all remaining javadoc warnings
[
https://issues.apache.org/jira/browse/HBASE-22725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905036#comment-16905036
]
Hudson commented on HBASE-22725:
Results for branch master
[build #1327 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1327/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1327//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1327//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1327//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove all remaining javadoc warnings
> --
>
> Key: HBASE-22725
> URL: https://issues.apache.org/jira/browse/HBASE-22725
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 3.0.0
>Reporter: Murtaza Hassan
>Assignee: Murtaza Hassan
>Priority: Trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22832) Remove deprecated method in HFileOutputFormat2
[
https://issues.apache.org/jira/browse/HBASE-22832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905035#comment-16905035
]
Hudson commented on HBASE-22832:
Results for branch master
[build #1327 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1327/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1327//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1327//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1327//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove deprecated method in HFileOutputFormat2
> --
>
> Key: HBASE-22832
> URL: https://issues.apache.org/jira/browse/HBASE-22832
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0
>
>
> The method {{getHTableDescriptor}} was deprecated in {{HFileOutputFormat2}}
> and should be removed for 3.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
Apache-HBase commented on issue #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/467#issuecomment-520369487 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 51 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 59 | Maven dependency ordering for branch | | +1 | mvninstall | 306 | master passed | | +1 | compile | 76 | master passed | | +1 | checkstyle | 101 | master passed | | +1 | shadedjars | 259 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 51 | master passed | | 0 | spotbugs | 234 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 279 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 280 | the patch passed | | +1 | compile | 73 | the patch passed | | +1 | javac | 73 | the patch passed | | +1 | checkstyle | 91 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 467 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 892 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 52 | the patch passed | | +1 | findbugs | 302 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 177 | hbase-common in the patch passed. | | +1 | unit | 8517 | hbase-server in the patch passed. | | +1 | asflicense | 39 | The patch does not generate ASF License warnings. | | | | 12459 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-467/11/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/467 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 5c1d53a4a919 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-467/out/precommit/personality/provided.sh | | git revision | master / 3867fae04d | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-467/11/testReport/ | | Max. process+thread count | 4551 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-467/11/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22631) assign failed may make gced parent region appear again !!!
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905053#comment-16905053 ] Wellington Chevreuil commented on HBASE-22631: -- Thanks for the extra details, [~yu-huiyang]. So the issue seems to be that this region was supposedly deleted already, as we could see the _GCRegionProcedure_ has completed *success* for that region, but then it comes back when a given RS crashes and an SCP is submitted to it. Is it possible to share this Master log file, together with the tempt20 RS log file, covering this period between "2019-06-26 10:40" and "2019-06-26 10:42"? I suspect this might be same issue as the one addressed in HBASE-21843, where RS holding meta crashes, then meta wal edits are skipped in the wal replay, which misses some recent updates to meta. > assign failed may make gced parent region appear again !!! > -- > > Key: HBASE-22631 > URL: https://issues.apache.org/jira/browse/HBASE-22631 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Affects Versions: 2.1.1 >Reporter: yuhuiyang >Priority: Major > Attachments: HBASE-22631-branch-2.1-01.patch, assign.png, > assignProcedure.txt, serverCrash.png, splitAndGc.png > > > When i assign a region A the process is as follows： > step1 : A is assigned to rs1 , and rs1 fails to open it . > step2 : assignProcedure handleFailure . > step3 : A is assign to rs2 and rs success to open it . > Above is the normal flow . However when rs1 is restart after the reigon A was > split and GCRegionProcedure was successed , the region A appare again ! > The region is that reigon A is not removed from the serverMap correctly when > assignprocedure handleFailure . Because the code regionNode.offline() make > the regionNode's regionLocation to be null and make regionNode's state to > OFFLINE . So when the code > env.getAssignmentManager().undoRegionAsOpening(regionNode) do nothing . So > when the rs1 restart event triggers a serverCrashProcedure, it will get > reigons from serverMap and it will get the region A then A will be assigned > and hdfs dir will be created. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #471: HBASE-22828 Log a region close journal
Apache-HBase commented on issue #471: HBASE-22828 Log a region close journal URL: https://github.com/apache/hbase/pull/471#issuecomment-520373703 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 32 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 343 | master passed | | +1 | compile | 56 | master passed | | +1 | checkstyle | 92 | master passed | | +1 | shadedjars | 297 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | master passed | | 0 | spotbugs | 280 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 278 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 321 | the patch passed | | +1 | compile | 57 | the patch passed | | +1 | javac | 57 | the patch passed | | +1 | checkstyle | 89 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 299 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1036 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 34 | the patch passed | | +1 | findbugs | 269 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 9754 | hbase-server in the patch failed. | | +1 | asflicense | 29 | The patch does not generate ASF License warnings. | | | | 13415 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-471/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/471 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c1998531376c 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-471/out/precommit/personality/provided.sh | | git revision | master / 3867fae04d | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-471/4/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-471/4/testReport/ | | Max. process+thread count | 4547 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-471/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1
[
https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905060#comment-16905060
]
HBase QA commented on HBASE-22728:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
23s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 12 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
24s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
49s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
31s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 12m
12s{color} | {color:green} branch-1 passed {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 0m
12s{color} | {color:red} branch has 10 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
33s{color} | {color:green} branch-1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} The patch passed checkstyle in hbase-common {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch passed checkstyle in hbase-procedure
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} The patch passed checkstyle in hbase-client {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
8s{color} | {color:green} The patch passed checkstyle in hbase-metrics-api
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} The patch passed checkstyle in hbase-metrics {color}
|
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch passed checkstyle in hbase-hadoop2-compat
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch passed checkstyle in hbase-prefix-tree
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
31s{color} | {color:green} hbase-server: The patch generated 0 new + 260
unchanged - 3 fixed = 260 total (was 263) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s{color} | {color:green} The patch passed checkstyle in hbase-testing-util
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} The patch passed checkstyle in hbase-thrift {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} hbase-rest: The patch generated 0 new + 66 unchanged
- 7 fixed = 66 total (was 73) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch passed checkstyle in hbase-rsgroup {color}
|
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} The patch passed checkstyle in hbase-shell {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {
[GitHub] [hbase] Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment
Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment URL: https://github.com/apache/hbase/pull/439#issuecomment-520380140 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 90 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 346 | master passed | | +1 | compile | 57 | master passed | | +1 | checkstyle | 91 | master passed | | +1 | shadedjars | 301 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | master passed | | 0 | spotbugs | 283 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 280 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 336 | the patch passed | | +1 | compile | 62 | the patch passed | | +1 | javac | 62 | the patch passed | | -1 | checkstyle | 91 | hbase-server: The patch generated 2 new + 64 unchanged - 0 fixed = 66 total (was 64) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 312 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1048 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 37 | the patch passed | | +1 | findbugs | 250 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 4 | hbase-server in the patch failed. | | +1 | asflicense | 48 | The patch does not generate ASF License warnings. | | | | 14913 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.balancer.TestStochasticLoadBalancerRegionReplicaSameHosts | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/42/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/439 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e18a934e5b43 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-439/out/precommit/personality/provided.sh | | git revision | master / 3867fae04d | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/42/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/42/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/42/testReport/ | | Max. process+thread count | 4874 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/42/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop
Apache-HBase commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-520380487 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 35 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 22 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for branch | | +1 | mvninstall | 327 | master passed | | +1 | compile | 165 | master passed | | +1 | checkstyle | 147 | master passed | | +1 | shadedjars | 275 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 179 | master passed | | 0 | spotbugs | 28 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 28 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 297 | the patch passed | | +1 | compile | 171 | the patch passed | | +1 | javac | 171 | the patch passed | | +1 | checkstyle | 149 | the patch passed | | +1 | shellcheck | 1 | There were no new shellcheck issues. | | +1 | whitespace | 1 | The patch has no whitespace issues. | | +1 | xml | 4 | The patch has no ill-formed XML file. | | +1 | shadedjars | 273 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 947 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 182 | the patch passed | | 0 | findbugs | 27 | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | -1 | unit | 9435 | root in the patch failed. | | +1 | asflicense | 68 | The patch does not generate ASF License warnings. | | | | 14998 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.io.hfile.bucket.TestBucketCache | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/476 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux 191b7936a83c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-476/out/precommit/personality/provided.sh | | git revision | master / 3867fae04d | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/4/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/4/testReport/ | | Max. process+thread count | 4879 (vs. ulimit of 1) | | modules | C: hbase-hbtop . hbase-assembly U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Attachment: (was: HBASE-22835.branch-1.3.patch)
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] petersomogyi commented on a change in pull request #460: HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split
petersomogyi commented on a change in pull request #460: HBASE-22774 [WAL]
RegionGroupingStrategy loses its function after split
URL: https://github.com/apache/hbase/pull/460#discussion_r312875348
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedGroupingStrategy.java
##
@@ -72,7 +72,7 @@ public void init(Configuration config, String providerId) {
int regionGroupNumber = config.getInt(NUM_REGION_GROUPS,
DEFAULT_NUM_REGION_GROUPS);
groupNames = new String[regionGroupNumber];
for (int i = 0; i < regionGroupNumber; i++) {
- groupNames[i] = providerId + GROUP_NAME_DELIMITER + "regiongroup-" + i;
Review comment:
GROUP_NAME_DELIMITER is unused from now on. Can it be removed? It is in
IA.Private class.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] petersomogyi commented on a change in pull request #460: HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split
petersomogyi commented on a change in pull request #460: HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split URL: https://github.com/apache/hbase/pull/460#discussion_r312873624 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -7177,8 +7177,9 @@ HRegion createDaughterRegionFromSplits(final HRegionInfo hri) throws IOException fs.commitDaughterRegion(hri); // Create the daughter HRegion instance -HRegion r = HRegion.newHRegion(this.fs.getTableDir(), this.getWAL(), fs.getFileSystem(), -this.getBaseConf(), hri, this.getTableDesc(), rsServices); +HRegion r = HRegion.newHRegion(this.fs.getTableDir(), + rsServices == null ? getWAL() :rsServices.getWAL(hri), // rsServices can be null in UT Review comment: Please extract this expression to a variable. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] petersomogyi commented on a change in pull request #460: HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split
petersomogyi commented on a change in pull request #460: HBASE-22774 [WAL]
RegionGroupingStrategy loses its function after split
URL: https://github.com/apache/hbase/pull/460#discussion_r312875941
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransaction.java
##
@@ -277,7 +323,7 @@ public void testWholesomeSplit() throws IOException {
assertTrue(count > 0 && count != rowcount);
daughtersRowCount += count;
} finally {
-HRegion.closeHRegion((HRegion)openRegion);
Review comment:
Makes sense! 👍
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22833) MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters
[
https://issues.apache.org/jira/browse/HBASE-22833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905099#comment-16905099
]
Itsuki Toyota commented on HBASE-22833:
---
[~openinx] Thanks for your reply and the neat article!
> I think we did not expand the MultiRowRangeFilter as multiple start/stop
> ranges
My understanding was _MultiRowRangeFilter_ could handle multiple start/stop
ranges since it has the constructor of
_MultiRowRangeFilter(List list)_ and
_MultiRowRangeFilter.RowRange_ is composed of _startRow_, _stopRow_, and flags
that indicate given start/stop row is inclusive or not. [0][1]
I found the following mention in your article:
> 例如对PrefixFilter(333)来说，碰到rowkey=111的行时，其实是可以根据前缀为333直接定位到下一个rowkey=333的Cell，只是当前的PrefixFilter没有做这个优化。
(In English)
> For example, for the PrefixFilter (333), when the row of rowkey=111 is
> encountered, it can be directly positioned to the next one according to the
> prefix 333. Rowkey=333's Cell, but the current PrefixFilter does not do this
> optimization.
I thought a filter which contains multiple stop/row pairs (e.g.,
_MultiRowRangeFilter_) can achieve this kind of optimization. ("it's better
than the current formal way" means this optimization)
Could you tell me if my understanding contains something incorrect?
Cheers,
[0]
https://hbase.apache.org/apidocs/org/apache/hadoop/hbase/filter/MultiRowRangeFilter.html
[1]
https://hbase.apache.org/apidocs/org/apache/hadoop/hbase/filter/MultiRowRangeFilter.RowRange.html
> MultiRowRangeFilter should provide a method for creating a filter which is
> functionally equivalent to multiple prefix filters
> -
>
> Key: HBASE-22833
> URL: https://issues.apache.org/jira/browse/HBASE-22833
> Project: HBase
> Issue Type: Wish
> Components: Client
>Affects Versions: 3.0.0
>Reporter: Itsuki Toyota
>Priority: Minor
>
> HI,
> I think current formal way to make multiple prefix filters is to create a
> _FilterList_ and add _PrefixFilter_ instances to the list:
> {code:java}
> FilterList allFilters = new FilterList(FilterList.Operator.MUST_PASS_ONE);
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("123")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("456")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("678")));
> scan.setFilter(allFilters);
> {code}
> (c.f.,
> https://stackoverflow.com/questions/41074213/hbase-how-to-specify-multiple-prefix-filters-in-a-single-scan-operation
> )
> However, in the case of creating a single prefix filter, HBase provides
> _scan.setRowPrefixFilter_ method.
> This method creates a range filter by setting a start row and a stop row.
> The value of a stop row is decided by calling
> _calculateTheClosestNextRowKeyForPrefix_ ( c.f.,
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java#L574-L597
> )
> _MultiRowRangeFilter_ could leverage a list of start row and stop row pairs
> and _calculateTheClosestNextRowKeyForPrefix_ could compute the stop row value
> corresponding to given start row (i.e., a prefix).
> I think this kind of filter (a filter which is functionally equivalent to
> multiple prefix filters) should be creatable by _MultiRowRangeFilter_ and
> it's better than the current formal way.
> Cheers,
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Attachment: HBASE-22835.branch-1.3.patch
Status: Patch Available (was: Open)
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation
Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation URL: https://github.com/apache/hbase/pull/478#issuecomment-520394246 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 93 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for branch | | +1 | mvninstall | 349 | master passed | | +1 | compile | 85 | master passed | | +1 | checkstyle | 122 | master passed | | +1 | shadedjars | 306 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 60 | master passed | | 0 | spotbugs | 285 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 360 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 353 | the patch passed | | +1 | compile | 92 | the patch passed | | +1 | javac | 92 | the patch passed | | +1 | checkstyle | 122 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 297 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1025 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 56 | the patch passed | | +1 | findbugs | 302 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 104 | hbase-client in the patch passed. | | -1 | unit | 13945 | hbase-server in the patch failed. | | +1 | asflicense | 48 | The patch does not generate ASF License warnings. | | | | 18191 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/478 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1d7eeb042803 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-478/out/precommit/personality/provided.sh | | git revision | master / 3867fae04d | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/3/testReport/ | | Max. process+thread count | 4988 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Reopened] (HBASE-22833) MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters
[
https://issues.apache.org/jira/browse/HBASE-22833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Itsuki Toyota reopened HBASE-22833:
---
(Reopened since I added a question)
> MultiRowRangeFilter should provide a method for creating a filter which is
> functionally equivalent to multiple prefix filters
> -
>
> Key: HBASE-22833
> URL: https://issues.apache.org/jira/browse/HBASE-22833
> Project: HBase
> Issue Type: Wish
> Components: Client
>Affects Versions: 3.0.0
>Reporter: Itsuki Toyota
>Priority: Minor
>
> HI,
> I think current formal way to make multiple prefix filters is to create a
> _FilterList_ and add _PrefixFilter_ instances to the list:
> {code:java}
> FilterList allFilters = new FilterList(FilterList.Operator.MUST_PASS_ONE);
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("123")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("456")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("678")));
> scan.setFilter(allFilters);
> {code}
> (c.f.,
> https://stackoverflow.com/questions/41074213/hbase-how-to-specify-multiple-prefix-filters-in-a-single-scan-operation
> )
> However, in the case of creating a single prefix filter, HBase provides
> _scan.setRowPrefixFilter_ method.
> This method creates a range filter by setting a start row and a stop row.
> The value of a stop row is decided by calling
> _calculateTheClosestNextRowKeyForPrefix_ ( c.f.,
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java#L574-L597
> )
> _MultiRowRangeFilter_ could leverage a list of start row and stop row pairs
> and _calculateTheClosestNextRowKeyForPrefix_ could compute the stop row value
> corresponding to given start row (i.e., a prefix).
> I think this kind of filter (a filter which is functionally equivalent to
> multiple prefix filters) should be creatable by _MultiRowRangeFilter_ and
> it's better than the current formal way.
> Cheers,
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes… URL: https://github.com/apache/hbase/pull/446#issuecomment-520406651 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 36 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 318 | master passed | | +1 | compile | 51 | master passed | | +1 | checkstyle | 70 | master passed | | +1 | shadedjars | 255 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 34 | master passed | | 0 | spotbugs | 267 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 265 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 297 | the patch passed | | +1 | compile | 51 | the patch passed | | +1 | javac | 51 | the patch passed | | +1 | checkstyle | 72 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 258 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 889 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 271 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 13196 | hbase-server in the patch failed. | | +1 | asflicense | 40 | The patch does not generate ASF License warnings. | | | | 16489 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestEndToEndSplitTransaction | | | hadoop.hbase.coprocessor.TestOpenTableInCoprocessor | | | hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster | | | hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay | | | hadoop.hbase.replication.TestAddToSerialReplicationPeer | | | hadoop.hbase.client.TestAsyncClientPauseForCallQueueTooBig | | | hadoop.hbase.client.TestSmallReversedScanner | | | hadoop.hbase.client.TestMetaWithReplicas | | | hadoop.hbase.master.TestSplitRegionWhileRSCrash | | | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure | | | hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient | | | hadoop.hbase.TestRegionRebalancing | | | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | | hadoop.hbase.client.TestTableSnapshotScanner | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed | | | hadoop.hbase.TestPartialResultsFromClientSide | | | hadoop.hbase.regionserver.wal.TestWALReplay | | | hadoop.hbase.client.TestRestoreSnapshotFromClientAfterSplittingRegions | | | hadoop.hbase.regionserver.wal.TestWALReplayBoundedLogWriterCreation | | | hadoop.hbase.client.TestAsyncTableLocateRegionForDeletedTable | | | hadoop.hbase.regionserver.wal.TestWALReplayCompressed | | | hadoop.hbase.quotas.TestQuotaAdmin | | | hadoop.hbase.client.TestRestoreSnapshotFromClientSimple | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.client.TestAsyncMetaRegionLocator | | | hadoop.hbase.client.TestRestoreSnapshotFromClientSchemaChange | | | hadoop.hbase.quotas.TestFileArchiverNotifierImpl | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterSplittingRegions | | | hadoop.hbase.client.TestRestoreSnapshotFromClientAfterTruncate | | | hadoop.hbase.client.TestAsyncSnapshotAdminApi | | | hadoop.hbase.tool.TestBulkLoadHFilesSplitRecovery | | | hadoop.hbase.client.TestSeparateClientZKCluster | | | hadoop.hbase.master.assignment.TestSplitTableRegionProcedure | | | hadoop.hbase.snapshot.TestFlushSnapshotFromClient | | | hadoop.hbase.client.TestRestoreSnapshotFromClientClone | | | hadoop.hbase.regionserver.TestHRegionOnCluster | | | hadoop.hbase.replication.TestSerialReplication | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplay | | | hadoop.hbase.util.TestRegionMover | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientSchemaChange | | | hadoop.hbase.client.TestAsyncSingleRequestRpcRetryingCaller | | | hadoop.hbase.tool.TestSecureBulkLoadHFilesSplitRecovery | | | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.client.TestAdmin2 | | | hadoop.hbase.client.TestSizeFailures | | | hadoop.hbase.client.TestAsyncTableGetMultiThreaded | | | hadoop.hbase.regionserver.wal.TestSecureWALReplay | |
[GitHub] [hbase] Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment
Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment URL: https://github.com/apache/hbase/pull/439#issuecomment-520407013 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 35 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 309 | master passed | | +1 | compile | 54 | master passed | | +1 | checkstyle | 71 | master passed | | +1 | shadedjars | 254 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 37 | master passed | | 0 | spotbugs | 274 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 271 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 291 | the patch passed | | +1 | compile | 53 | the patch passed | | +1 | javac | 53 | the patch passed | | -1 | checkstyle | 71 | hbase-server: The patch generated 2 new + 64 unchanged - 0 fixed = 66 total (was 64) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 257 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 879 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 267 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 13272 | hbase-server in the patch failed. | | +1 | asflicense | 38 | The patch does not generate ASF License warnings. | | | | 16556 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestEndToEndSplitTransaction | | | hadoop.hbase.coprocessor.TestOpenTableInCoprocessor | | | hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster | | | hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay | | | hadoop.hbase.replication.TestAddToSerialReplicationPeer | | | hadoop.hbase.client.TestAsyncClientPauseForCallQueueTooBig | | | hadoop.hbase.client.TestSmallReversedScanner | | | hadoop.hbase.client.TestMetaWithReplicas | | | hadoop.hbase.master.TestSplitRegionWhileRSCrash | | | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure | | | hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient | | | hadoop.hbase.TestRegionRebalancing | | | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | | hadoop.hbase.client.TestTableSnapshotScanner | | | hadoop.hbase.TestPartialResultsFromClientSide | | | hadoop.hbase.regionserver.wal.TestWALReplay | | | hadoop.hbase.client.TestRestoreSnapshotFromClientAfterSplittingRegions | | | hadoop.hbase.regionserver.wal.TestWALReplayBoundedLogWriterCreation | | | hadoop.hbase.client.TestAsyncTableLocateRegionForDeletedTable | | | hadoop.hbase.regionserver.wal.TestWALReplayCompressed | | | hadoop.hbase.quotas.TestQuotaAdmin | | | hadoop.hbase.client.TestRestoreSnapshotFromClientSimple | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.client.TestAsyncMetaRegionLocator | | | hadoop.hbase.client.TestRestoreSnapshotFromClientSchemaChange | | | hadoop.hbase.quotas.TestFileArchiverNotifierImpl | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterSplittingRegions | | | hadoop.hbase.client.TestRestoreSnapshotFromClientAfterTruncate | | | hadoop.hbase.client.TestAsyncSnapshotAdminApi | | | hadoop.hbase.tool.TestBulkLoadHFilesSplitRecovery | | | hadoop.hbase.client.TestSeparateClientZKCluster | | | hadoop.hbase.master.assignment.TestSplitTableRegionProcedure | | | hadoop.hbase.snapshot.TestFlushSnapshotFromClient | | | hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash | | | hadoop.hbase.client.TestRestoreSnapshotFromClientClone | | | hadoop.hbase.regionserver.TestHRegionOnCluster | | | hadoop.hbase.replication.TestSerialReplication | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplay | | | hadoop.hbase.util.TestRegionMover | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientSchemaChange | | | hadoop.hbase.client.TestAsyncSingleRequestRpcRetryingCaller | | | hadoop.hbase.tool.TestSecureBulkLoadHFilesSplitRecovery | | | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.client.TestAdmin2 | | | hadoop.hbase.client.TestSizeFailures | | | hadoop.hbase.client.TestAsyncTableGetMultiThreaded | | |
[jira] [Commented] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905142#comment-16905142
]
HBase QA commented on HBASE-22835:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
43s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} branch-1.3 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
12s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
40s{color} | {color:green} branch-1.3 passed {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 0m
13s{color} | {color:red} branch has 10 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} branch-1.3 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
36s{color} | {color:red} hbase-server: The patch generated 141 new + 373
unchanged - 22 fixed = 514 total (was 395) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 0m
10s{color} | {color:red} patch has 10 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
9m 19s{color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1
2.5.2 2.6.5 2.7.7. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 23m 54s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 50m 40s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestScanner |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/757/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22835 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12977345/HBASE-22835.branch-1.3.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux dc17f49e435b 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4
22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-1.3 / 9b1298c |
| maven | version: Apache Maven 3.0.5 |
| Default Java | 1.8.0_222 |
| shadedjars |
https://builds.apache.org/job/PreCommit-HBASE-Build/757/artifact/patchprocess/branch-shadedjars.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/757/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/757/artifact/patchprocess/whitespace-eol
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-520413186 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 94 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for branch | | +1 | mvninstall | 325 | master passed | | +1 | compile | 82 | master passed | | +1 | checkstyle | 106 | master passed | | +1 | shadedjars | 269 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 58 | master passed | | 0 | spotbugs | 241 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 305 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 314 | the patch passed | | +1 | compile | 78 | the patch passed | | +1 | javac | 78 | the patch passed | | +1 | checkstyle | 107 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 278 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 996 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 54 | the patch passed | | +1 | findbugs | 316 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 110 | hbase-client in the patch passed. | | -1 | unit | 17890 | hbase-server in the patch failed. | | +1 | asflicense | 50 | The patch does not generate ASF License warnings. | | | | 21884 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.master.procedure.TestProcedurePriority | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.client.TestAsyncTableAdminApi | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/91/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 274167ee7dca 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / 3867fae04d | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/91/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/91/testReport/ | | Max. process+thread count | 5109 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/91/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-520414516 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for branch | | +1 | mvninstall | 308 | master passed | | +1 | compile | 104 | master passed | | +1 | checkstyle | 116 | master passed | | +1 | shadedjars | 275 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 78 | master passed | | 0 | spotbugs | 245 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 335 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 299 | the patch passed | | +1 | compile | 102 | the patch passed | | +1 | javac | 102 | the patch passed | | -1 | checkstyle | 76 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 273 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 928 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 77 | the patch passed | | -1 | findbugs | 57 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 186 | hbase-common in the patch passed. | | -1 | unit | 12795 | hbase-server in the patch failed. | | -1 | unit | 998 | hbase-rsgroup in the patch failed. | | +1 | asflicense | 70 | The patch does not generate ASF License warnings. | | | | 17929 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Failed junit tests | hadoop.hbase.client.TestMultiRespectsLimits | | | hadoop.hbase.client.TestAdmin2 | | | hadoop.hbase.regionserver.TestCompactSplitThread | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplay | | | hadoop.hbase.client.TestAsyncTableLocateRegionForDeletedTable | | | hadoop.hbase.quotas.TestFileArchiverNotifierImpl | | | hadoop.hbase.replication.TestSerialReplication | | | hadoop.hbase.client.TestRestoreSnapshotFromClientClone | | | hadoop.hbase.client.TestMvccConsistentScanner | | | hadoop.hbase.client.TestTableSnapshotScanner | | | hadoop.hbase.client.TestAsyncMetaRegionLocator | | | hadoop.hbase.master.TestMergeTableRegionsWhileRSCrash | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterSplittingRegions | | | hadoop.hbase.TestRegionRebalancing | | | hadoop.hbase.client.TestAdmin | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientSchemaChange | | | hadoop.hbase.client.TestAsyncSnapshotAdminApi | | | hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay | | | hadoop.hbase.client.TestSeparateClientZKCluster | | | hadoop.hbase.regionserver.wal.TestWALReplayCompressed | | | hadoop.hbase.regionserver.wal.TestSecureWALReplay | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed | | | hadoop.hbase.TestPartialResultsFromClientSide | | | hadoop.hbase.tool.TestBulkLoadHFilesSplitRecovery | | | hadoop.hbase.tool.TestSecureBulkLoadHFilesSplitRecovery | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.client.TestRestoreSnapshotFromClientSimple | | | hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient | | | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | | hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster | | | hadoop.hbase.replication.TestAddToSerialReplicationPeer | | | hadoop.hbase.client.TestRestoreSnapshotFromClientSchemaChange | | | hadoop.hbase.coprocessor.TestOpenTableInCoprocessor | | | hadoop.hbase.regionserver.wal.TestWALReplay | | | hadoop.hbase.client.TestAsyncTableBatch | | | hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures | | | hadoop.hbase.regionserver.wal.Tes
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-520415405 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 64 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 35 | Maven dependency ordering for branch | | +1 | mvninstall | 312 | master passed | | +1 | compile | 99 | master passed | | +1 | checkstyle | 109 | master passed | | +1 | shadedjars | 267 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 72 | master passed | | 0 | spotbugs | 246 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 335 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 310 | the patch passed | | +1 | compile | 100 | the patch passed | | +1 | javac | 100 | the patch passed | | -1 | checkstyle | 72 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 303 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1009 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 71 | the patch passed | | -1 | findbugs | 57 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 172 | hbase-common in the patch passed. | | -1 | unit | 17452 | hbase-server in the patch failed. | | +1 | unit | 556 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 72 | The patch does not generate ASF License warnings. | | | | 22283 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Failed junit tests | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.client.TestCloneSnapshotFromClientNormal | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.client.TestAsyncTableAdminApi3 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/37/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 996b98df57ff 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / 3867fae04d | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/37/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/37/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/37/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/37/testReport/ | | Max. process+thread count | 4938 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/37/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH
[GitHub] [hbase] Apache-HBase commented on issue #471: HBASE-22828 Log a region close journal
Apache-HBase commented on issue #471: HBASE-22828 Log a region close journal URL: https://github.com/apache/hbase/pull/471#issuecomment-520416941 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 32 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 360 | master passed | | +1 | compile | 60 | master passed | | +1 | checkstyle | 94 | master passed | | +1 | shadedjars | 304 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 41 | master passed | | 0 | spotbugs | 290 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 286 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 380 | the patch passed | | +1 | compile | 70 | the patch passed | | +1 | javac | 70 | the patch passed | | +1 | checkstyle | 105 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 348 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1227 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 41 | the patch passed | | +1 | findbugs | 345 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 14174 | hbase-server in the patch failed. | | +1 | asflicense | 30 | The patch does not generate ASF License warnings. | | | | 18358 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures | | | hadoop.hbase.replication.TestAddToSerialReplicationPeer | | | hadoop.hbase.client.TestMultiRespectsLimits | | | hadoop.hbase.quotas.TestFileArchiverNotifierImpl | | | hadoop.hbase.tool.TestSecureBulkLoadHFilesSplitRecovery | | | hadoop.hbase.master.assignment.TestSplitTableRegionProcedure | | | hadoop.hbase.client.TestAdmin | | | hadoop.hbase.quotas.TestQuotaAdmin | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed | | | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.master.TestSplitRegionWhileRSCrash | | | hadoop.hbase.client.TestRestoreSnapshotFromClientSchemaChange | | | hadoop.hbase.regionserver.TestCompactSplitThread | | | hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay | | | hadoop.hbase.client.TestAsyncTableLocateRegionForDeletedTable | | | hadoop.hbase.regionserver.wal.TestLogRolling | | | hadoop.hbase.client.TestRestoreSnapshotFromClientAfterTruncate | | | hadoop.hbase.TestPartialResultsFromClientSide | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientSchemaChange | | | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | | hadoop.hbase.client.TestSizeFailures | | | hadoop.hbase.regionserver.wal.TestSecureWALReplay | | | hadoop.hbase.regionserver.TestEndToEndSplitTransaction | | | hadoop.hbase.coprocessor.TestOpenTableInCoprocessor | | | hadoop.hbase.client.TestAsyncSingleRequestRpcRetryingCaller | | | hadoop.hbase.util.TestRegionMover | | | hadoop.hbase.regionserver.wal.TestWALReplayBoundedLogWriterCreation | | | hadoop.hbase.client.TestAsyncNonMetaRegionLocator | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterSplittingRegions | | | hadoop.hbase.client.TestMvccConsistentScanner | | | hadoop.hbase.client.TestRestoreSnapshotFromClientAfterSplittingRegions | | | hadoop.hbase.client.TestRestoreSnapshotFromClientSimple | | | hadoop.hbase.client.TestRestoreSnapshotFromClientClone | | | hadoop.hbase.master.TestMergeTableRegionsWhileRSCrash | | | hadoop.hbase.master.replication.TestTransitPeerSyncReplicationStateProcedureRetry | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.client.TestMultiParallel | | | hadoop.hbase.regionserver.TestHRegionOnCluster | | | hadoop.hbase.client.TestAsyncSnapshotAdminApi | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplay | | | hadoop.hbase.regionserver.wal.TestWALReplayCompressed | | | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure | | | hadoop.hbase.client.TestAsyncTableBatch
[jira] [Commented] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905176#comment-16905176
]
Jeongmin Kim commented on HBASE-22835:
--
There’s some test failed. I’ll make another patch soon.
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop
Apache-HBase commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-520423923 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 34 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 22 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for branch | | +1 | mvninstall | 304 | master passed | | +1 | compile | 166 | master passed | | +1 | checkstyle | 149 | master passed | | +1 | shadedjars | 263 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 173 | master passed | | 0 | spotbugs | 27 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 27 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 285 | the patch passed | | +1 | compile | 168 | the patch passed | | +1 | javac | 168 | the patch passed | | +1 | checkstyle | 145 | the patch passed | | +1 | shellcheck | 1 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 4 | The patch has no ill-formed XML file. | | +1 | shadedjars | 263 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 930 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 205 | the patch passed | | 0 | findbugs | 30 | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | -1 | unit | 14000 | root in the patch failed. | | +1 | asflicense | 103 | The patch does not generate ASF License warnings. | | | | 19590 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestMultiRespectsLimits | | | hadoop.hbase.client.TestAdmin2 | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientSchemaChange | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplay | | | hadoop.hbase.master.assignment.TestSplitTableRegionProcedure | | | hadoop.hbase.client.TestRestoreSnapshotFromClientSchemaChange | | | hadoop.hbase.regionserver.wal.TestAsyncLogRolling | | | hadoop.hbase.coprocessor.TestOpenTableInCoprocessor | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed | | | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure | | | hadoop.hbase.client.TestMvccConsistentScanner | | | hadoop.hbase.client.TestSeparateClientZKCluster | | | hadoop.hbase.regionserver.wal.TestSecureWALReplay | | | hadoop.hbase.client.TestRestoreSnapshotFromClientAfterTruncate | | | hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures | | | hadoop.hbase.client.TestAdmin | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.client.TestRestoreSnapshotFromClientClone | | | hadoop.hbase.regionserver.wal.TestWALReplay | | | hadoop.hbase.client.TestTableSnapshotScanner | | | hadoop.hbase.client.TestRestoreSnapshotFromClientSimple | | | hadoop.hbase.util.TestRegionMover | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.quotas.TestQuotaAdmin | | | hadoop.hbase.regionserver.TestCompactSplitThread | | | hadoop.hbase.TestRegionRebalancing | | | hadoop.hbase.client.TestAsyncTableLocateRegionForDeletedTable | | | hadoop.hbase.TestPartialResultsFromClientSide | | | hadoop.hbase.client.TestAsyncSnapshotAdminApi | | | hadoop.hbase.client.TestAsyncSingleRequestRpcRetryingCaller | | | hadoop.hbase.client.TestAsyncNonMetaRegionLocator | | | hadoop.hbase.tool.TestBulkLoadHFilesSplitRecovery | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.client.TestRestoreSnapshotFromClientAfterSplittingRegions | | | hadoop.hbase.regionserver.wal.TestLogRolling | | | hadoop.hbase.regionserver.TestHRegionOnCluster | | | hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient | | | hadoop.hbase.snapshot.TestFlushSnapshotFromClient | | | hadoop.hbase.replication.TestSerialReplication | | | hadoop.hbase.quotas.TestFileArchiverNotifierImpl | | | hadoop.hbase.regionserver.wal.TestWALReplayBoundedLogWriterCreation | | | hadoop.hbase.client.TestAsyncTableGetMultiThreaded | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterSplittingR
[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes… URL: https://github.com/apache/hbase/pull/446#issuecomment-520429931 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 247 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 409 | master passed | | +1 | compile | 68 | master passed | | +1 | checkstyle | 93 | master passed | | +1 | shadedjars | 344 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 43 | master passed | | 0 | spotbugs | 316 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 314 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 409 | the patch passed | | +1 | compile | 68 | the patch passed | | +1 | javac | 68 | the patch passed | | +1 | checkstyle | 104 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 368 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1305 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 40 | the patch passed | | +1 | findbugs | 311 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 20050 | hbase-server in the patch failed. | | +1 | asflicense | 66 | The patch does not generate ASF License warnings. | | | | 24742 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.client.TestCloneSnapshotFromClientNormal | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure | | | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/35/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/446 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2e916a8fe0bc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-446/out/precommit/personality/provided.sh | | git revision | master / 3867fae04d | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/35/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/35/testReport/ | | Max. process+thread count | 4905 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/35/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose
[
https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905237#comment-16905237
]
Hudson commented on HBASE-21879:
Results for branch HBASE-21879
[build #206 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/206/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/206//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/206//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/206//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Read HFile's block to ByteBuffer directly instead of to byte for reducing
> young gc purpose
> --
>
> Key: HBASE-21879
> URL: https://issues.apache.org/jira/browse/HBASE-21879
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-21879.v1.patch, HBASE-21879.v1.patch,
> QPS-latencies-before-HBASE-21879.png, gc-data-before-HBASE-21879.png
>
>
> In HFileBlock#readBlockDataInternal, we have the following:
> {code}
> @VisibleForTesting
> protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset,
> long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum,
> boolean updateMetrics)
> throws IOException {
> // .
> // TODO: Make this ByteBuffer-based. Will make it easier to go to HDFS with
> BBPool (offheap).
> byte [] onDiskBlock = new byte[onDiskSizeWithHeader + hdrSize];
> int nextBlockOnDiskSize = readAtOffset(is, onDiskBlock, preReadHeaderSize,
> onDiskSizeWithHeader - preReadHeaderSize, true, offset +
> preReadHeaderSize, pread);
> if (headerBuf != null) {
> // ...
> }
> // ...
> }
> {code}
> In the read path, we still read the block from hfile to on-heap byte[], then
> copy the on-heap byte[] to offheap bucket cache asynchronously, and in my
> 100% get performance test, I also observed some frequent young gc, The
> largest memory footprint in the young gen should be the on-heap block byte[].
> In fact, we can read HFile's block to ByteBuffer directly instead of to
> byte[] for reducing young gc purpose. we did not implement this before,
> because no ByteBuffer reading interface in the older HDFS client, but 2.7+
> has supported this now, so we can fix this now. I think.
> Will provide an patch and some perf-comparison for this.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-520441089 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 72 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 33 | Maven dependency ordering for branch | | +1 | mvninstall | 338 | master passed | | +1 | compile | 82 | master passed | | +1 | checkstyle | 120 | master passed | | +1 | shadedjars | 297 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 58 | master passed | | 0 | spotbugs | 270 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 341 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 428 | the patch passed | | +1 | compile | 105 | the patch passed | | +1 | javac | 105 | the patch passed | | +1 | checkstyle | 128 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 314 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1069 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 70 | the patch passed | | +1 | findbugs | 349 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 119 | hbase-client in the patch passed. | | -1 | unit | 17731 | hbase-server in the patch failed. | | +1 | asflicense | 53 | The patch does not generate ASF License warnings. | | | | 22233 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAsyncSingleRequestRpcRetryingCaller | | | hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster | | | hadoop.hbase.replication.TestSerialReplication | | | hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay | | | hadoop.hbase.client.TestMultiParallel | | | hadoop.hbase.client.TestRestoreSnapshotFromClientAfterTruncate | | | hadoop.hbase.regionserver.wal.TestAsyncLogRolling | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientSchemaChange | | | hadoop.hbase.master.TestMergeTableRegionsWhileRSCrash | | | hadoop.hbase.regionserver.wal.TestLogRolling | | | hadoop.hbase.regionserver.wal.TestSecureWALReplay | | | hadoop.hbase.util.TestRegionMover | | | hadoop.hbase.client.TestRestoreSnapshotFromClientClone | | | hadoop.hbase.regionserver.wal.TestWALReplayBoundedLogWriterCreation | | | hadoop.hbase.regionserver.TestHRegionOnCluster | | | hadoop.hbase.regionserver.TestCompactSplitThread | | | hadoop.hbase.coprocessor.TestOpenTableInCoprocessor | | | hadoop.hbase.client.TestSeparateClientZKCluster | | | hadoop.hbase.client.TestAsyncTableGetMultiThreaded | | | hadoop.hbase.regionserver.wal.TestWALReplay | | | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.client.TestAdmin | | | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure | | | hadoop.hbase.client.TestAsyncTableLocateRegionForDeletedTable | | | hadoop.hbase.TestRegionRebalancing | | | hadoop.hbase.client.TestAsyncMetaRegionLocator | | | hadoop.hbase.snapshot.TestFlushSnapshotFromClient | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed | | | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | | hadoop.hbase.client.TestAsyncNonMetaRegionLocator | | | hadoop.hbase.client.TestRestoreSnapshotFromClientSimple | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplay | | | hadoop.hbase.client.TestRestoreSnapshotFromClientAfterSplittingRegions | | | hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.client.TestMvccConsistentScanner | | | hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient | | | hadoop.hbase.replication.TestAddToSerialReplicationPeer | | | hadoop.hbase.client.TestSizeFailures | | | hadoop.hbase.client.TestSmallReversedScanner | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterSplittingRegions | | | hadoop.hbase.TestPartialResultsFromClientSide | | | hadoop.hbase.client.TestTableSnapshotScanner | | | hadoop.hbase.master.TestSplitRegionWhileRSCrash | | | hadoop.hbase.re
[jira] [Created] (HBASE-22836) MemcachedBlockCache parameter error
Zhao created HBASE-22836: Summary: MemcachedBlockCache parameter error Key: HBASE-22836 URL: https://issues.apache.org/jira/browse/HBASE-22836 Project: HBase Issue Type: Bug Components: BlockCache Affects Versions: 1.4.10, 1.4.9 Reporter: Zhao When cache a block，the expiration is always set MAX_SIZE (which is a static final field). MAX_SIZE was mistakenly thought to be the max size of block. In fact, this parameter represents the expiration of the cached block. MAX_SIZE should be set 0 which means forever. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation
Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation URL: https://github.com/apache/hbase/pull/478#issuecomment-520448470 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 64 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 33 | Maven dependency ordering for branch | | +1 | mvninstall | 420 | master passed | | +1 | compile | 104 | master passed | | +1 | checkstyle | 131 | master passed | | +1 | shadedjars | 338 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 71 | master passed | | 0 | spotbugs | 293 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 369 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 421 | the patch passed | | +1 | compile | 95 | the patch passed | | +1 | javac | 95 | the patch passed | | +1 | checkstyle | 131 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 331 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1213 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 65 | the patch passed | | +1 | findbugs | 358 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 106 | hbase-client in the patch passed. | | -1 | unit | 18547 | hbase-server in the patch failed. | | +1 | asflicense | 71 | The patch does not generate ASF License warnings. | | | | 23336 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.wal.TestLogRolling | | | hadoop.hbase.client.TestAsyncMetaRegionLocator | | | hadoop.hbase.tool.TestSecureBulkLoadHFilesSplitRecovery | | | hadoop.hbase.regionserver.wal.TestWALReplayCompressed | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.client.TestAsyncSingleRequestRpcRetryingCaller | | | hadoop.hbase.TestRegionRebalancing | | | hadoop.hbase.quotas.TestQuotaAdmin | | | hadoop.hbase.client.TestRestoreSnapshotFromClientAfterSplittingRegions | | | hadoop.hbase.client.TestSeparateClientZKCluster | | | hadoop.hbase.replication.TestSerialReplication | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.regionserver.wal.TestAsyncLogRolling | | | hadoop.hbase.client.TestMultiRespectsLimits | | | hadoop.hbase.regionserver.TestEndToEndSplitTransaction | | | hadoop.hbase.regionserver.wal.TestWALReplay | | | hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient | | | hadoop.hbase.master.TestSplitRegionWhileRSCrash | | | hadoop.hbase.regionserver.TestHRegionOnCluster | | | hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster | | | hadoop.hbase.regionserver.wal.TestWALReplayBoundedLogWriterCreation | | | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterSplittingRegions | | | hadoop.hbase.master.assignment.TestSplitTableRegionProcedure | | | hadoop.hbase.client.TestMvccConsistentScanner | | | hadoop.hbase.client.TestRestoreSnapshotFromClientSimple | | | hadoop.hbase.client.TestAdmin2 | | | hadoop.hbase.TestPartialResultsFromClientSide | | | hadoop.hbase.client.TestAsyncTableGetMultiThreaded | | | hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay | | | hadoop.hbase.client.TestRestoreSnapshotFromClientAfterTruncate | | | hadoop.hbase.client.TestAdmin | | | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientSchemaChange | | | hadoop.hbase.coprocessor.TestOpenTableInCoprocessor | | | hadoop.hbase.client.TestAsyncTableLocateRegionForDeletedTable | | | hadoop.hbase.client.TestTableSnapshotScanner | | | hadoop.hbase.client.TestRestoreSnapshotFromClientClone | | | hadoop.hbase.regionserver.TestCompactSplitThread | | | hadoop.hbase.regionserver.wal.TestSecureWALReplay | | | hadoop.hbase.util.TestRegionMover | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.client.TestSmallReversedScanner | | | hadoop.hbase.tool.TestBulkLoadHFilesSplitRecovery | | | hadoop.hbase.client.TestAsyncSnapshotAdminApi | | | hadoop.hb
[GitHub] [hbase] Apache-HBase commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again
Apache-HBase commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again URL: https://github.com/apache/hbase/pull/456#issuecomment-520451548 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 218 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 393 | branch-2.1 passed | | +1 | compile | 66 | branch-2.1 passed | | +1 | checkstyle | 98 | branch-2.1 passed | | +1 | shadedjars | 293 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 41 | branch-2.1 passed | | 0 | spotbugs | 199 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 196 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 363 | the patch passed | | +1 | compile | 65 | the patch passed | | +1 | javac | 65 | the patch passed | | +1 | checkstyle | 95 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 305 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1518 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 39 | the patch passed | | +1 | findbugs | 207 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 18144 | hbase-server in the patch failed. | | +1 | asflicense | 67 | The patch does not generate ASF License warnings. | | | | 22564 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSmallReversedScanner | | | hadoop.hbase.security.access.TestAccessController | | | hadoop.hbase.tool.TestSecureLoadIncrementalHFilesSplitRecovery | | | hadoop.hbase.client.TestAsyncTableGetMultiThreaded | | | hadoop.hbase.client.TestAsyncMetaRegionLocator | | | hadoop.hbase.regionserver.TestCompactSplitThread | | | hadoop.hbase.tool.TestLoadIncrementalHFilesSplitRecovery | | | hadoop.hbase.client.TestAsyncSingleRequestRpcRetryingCaller | | | hadoop.hbase.master.procedure.TestTruncateTableProcedure | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed | | | hadoop.hbase.regionserver.TestHRegionOnCluster | | | hadoop.hbase.client.TestConnectionImplementation | | | hadoop.hbase.quotas.TestSnapshotQuotaObserverChore | | | hadoop.hbase.regionserver.wal.TestAsyncLogRolling | | | hadoop.hbase.client.TestMultiRespectsLimits | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.regionserver.TestEndToEndSplitTransaction | | | hadoop.hbase.regionserver.TestSplitTransactionOnCluster | | | hadoop.hbase.client.TestMvccConsistentScanner | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplay | | | hadoop.hbase.TestRegionRebalancing | | | hadoop.hbase.regionserver.wal.TestWALReplayBoundedLogWriterCreation | | | hadoop.hbase.client.TestAsyncTableLocateRegionForDeletedTable | | | hadoop.hbase.regionserver.wal.TestSecureWALReplay | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterSplittingRegions | | | hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay | | | hadoop.hbase.client.TestAsyncTableBatch | | | hadoop.hbase.regionserver.wal.TestWALReplayCompressed | | | hadoop.hbase.client.TestSeparateClientZKCluster | | | hadoop.hbase.client.TestTableSnapshotScanner | | | hadoop.hbase.regionserver.wal.TestWALReplay | | | hadoop.hbase.regionserver.wal.TestLogRolling | | | hadoop.hbase.coprocessor.TestOpenTableInCoprocessor | | | hadoop.hbase.replication.TestSerialReplication | | | hadoop.hbase.client.TestAsyncNonMetaRegionLocator | | | hadoop.hbase.util.TestRegionMover | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/19/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/456 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 55c98ec1dd22 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-456/out/preco
[jira] [Commented] (HBASE-22699) refactor isMetaClearingException
[
https://issues.apache.org/jira/browse/HBASE-22699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905265#comment-16905265
]
Hudson commented on HBASE-22699:
Results for branch branch-2.0
[build #1855 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1855/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1855//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1855//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1855//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> refactor isMetaClearingException
>
>
> Key: HBASE-22699
> URL: https://issues.apache.org/jira/browse/HBASE-22699
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Junhong Xu
>Assignee: Junhong Xu
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> It is not so readable
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-520457761 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 167 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 364 | master passed | | +1 | compile | 58 | master passed | | +1 | checkstyle | 79 | master passed | | +1 | shadedjars | 264 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 37 | master passed | | 0 | spotbugs | 250 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 248 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 334 | the patch passed | | +1 | compile | 57 | the patch passed | | +1 | javac | 57 | the patch passed | | +1 | checkstyle | 76 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 298 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1018 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 31 | the patch passed | | +1 | findbugs | 256 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 20948 | hbase-server in the patch failed. | | +1 | asflicense | 50 | The patch does not generate ASF License warnings. | | | | 24654 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestTableSnapshotScanner | | | hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient | | | hadoop.hbase.master.assignment.TestSplitTableRegionProcedure | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.master.TestSplitRegionWhileRSCrash | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed | | | hadoop.hbase.regionserver.wal.TestWALReplayBoundedLogWriterCreation | | | hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay | | | hadoop.hbase.client.TestRestoreSnapshotFromClientClone | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.regionserver.wal.TestLogRolling | | | hadoop.hbase.client.TestAsyncSnapshotAdminApi | | | hadoop.hbase.tool.TestSecureBulkLoadHFilesSplitRecovery | | | hadoop.hbase.client.TestSeparateClientZKCluster | | | hadoop.hbase.replication.TestSerialReplication | | | hadoop.hbase.client.TestRestoreSnapshotFromClientAfterSplittingRegions | | | hadoop.hbase.client.TestAsyncSingleRequestRpcRetryingCaller | | | hadoop.hbase.coprocessor.TestOpenTableInCoprocessor | | | hadoop.hbase.client.TestMetaWithReplicas | | | hadoop.hbase.client.TestAsyncNonMetaRegionLocator | | | hadoop.hbase.quotas.TestFileArchiverNotifierImpl | | | hadoop.hbase.client.TestRestoreSnapshotFromClientSchemaChange | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.client.TestAsyncTableBatch | | | hadoop.hbase.client.TestRestoreSnapshotFromClientAfterTruncate | | | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.client.TestAsyncMetaRegionLocator | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientSchemaChange | | | hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster | | | hadoop.hbase.client.TestAdmin2 | | | hadoop.hbase.client.TestMvccConsistentScanner | | | hadoop.hbase.regionserver.TestEndToEndSplitTransaction | | | hadoop.hbase.client.TestAdmin | | | hadoop.hbase.regionserver.TestCompactSplitThread | | | hadoop.hbase.regionserver.wal.TestWALReplayCompressed | | | hadoop.hbase.regionserver.wal.TestWALReplay | | | hadoop.hbase.client.TestAsyncTableGetMultiThreaded | | | hadoop.hbase.client.TestAsyncTableLocateRegionForDeletedTable | | | hadoop.hbase.TestRegionRebalancing | | | hadoop.hbase.master.TestMergeTableRegionsWhileRSCrash | | | hadoop.hbase.TestPartialResultsFromClientSide | | | hadoop.hbase.client.TestSizeFailures | | | hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplay | | | hadoop.hbase.util.TestRegionMover | | | hadoop.hbase.tool.TestBulkLoadHFilesSplitRecovery | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterSplittingRegions | | | hadoop.hbase.client.TestRestoreSnapshotFromClientSimple | | | hadoop.hbase.client.TestMultiRespectsLi
[jira] [Commented] (HBASE-22699) refactor isMetaClearingException
[
https://issues.apache.org/jira/browse/HBASE-22699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905283#comment-16905283
]
Hudson commented on HBASE-22699:
Results for branch branch-2.1
[build #1475 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1475/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1475//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1475//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1475//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> refactor isMetaClearingException
>
>
> Key: HBASE-22699
> URL: https://issues.apache.org/jira/browse/HBASE-22699
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Junhong Xu
>Assignee: Junhong Xu
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> It is not so readable
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22699) refactor isMetaClearingException
[
https://issues.apache.org/jira/browse/HBASE-22699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905300#comment-16905300
]
Hudson commented on HBASE-22699:
Results for branch master
[build #1328 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1328/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1328//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1328//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1328//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> refactor isMetaClearingException
>
>
> Key: HBASE-22699
> URL: https://issues.apache.org/jira/browse/HBASE-22699
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Junhong Xu
>Assignee: Junhong Xu
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> It is not so readable
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22829) Remove deprecated methods from SnapshotDescription
[
https://issues.apache.org/jira/browse/HBASE-22829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905299#comment-16905299
]
Hudson commented on HBASE-22829:
Results for branch master
[build #1328 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1328/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1328//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1328//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1328//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove deprecated methods from SnapshotDescription
> --
>
> Key: HBASE-22829
> URL: https://issues.apache.org/jira/browse/HBASE-22829
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0
>
>
> {{SnapshotDescription}} contains some deprecated constructors and methods,
> which should be removed for 3.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] wchevreuil commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again
wchevreuil commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again URL: https://github.com/apache/hbase/pull/456#issuecomment-520468069 Thanks for the extra details, yuhuiyang. So the issue seems to be that this region was supposedly deleted already, as we could see the _GCRegionProcedure_ has completed **success** for that region, but then it comes back when a given RS crashes and an SCP is submitted to it. Is it possible to share this Master log file, together with the tempt20 RS log file, covering this period between "2019-06-26 10:40" and "2019-06-26 10:42"? I suspect this might be same issue as the one addressed in **HBASE-21843**, where RS holding meta crashes, then meta wal edits are skipped in the wal replay, which misses some recent updates to meta. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-21745) Make HBCK2 be able to fix issues other than region assignment
[ https://issues.apache.org/jira/browse/HBASE-21745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905312#comment-16905312 ] stack commented on HBASE-21745: --- bq. We found some orphan regions on our test cluster. The regions dir is empty. And no region holes in meta. For this case, the orphan region dir shouled be remove directly. Yes. If an adoption service, we'd give the master these dirs and it would just delete them. bq. I thought we can do this at HBCK tool (client-side). But should not add 'adopt' API to hbck Service now (master-side). Ok. Lets see how we do. I think adoption service is what we want in the end. Maybe we get there incrementally. So, for empty dirs, the answer is easy... just delete. If a region in HDFS and a hole in meta that corresponds, there is the tool that [~wchevreuil] added to HBCK2 which should find the region in HDFS and then hoists it up into hbase:meta filling the hole. For anything else, an overlap found in HDFS... we'll need to add something ... to the master? Otherwise its HBCK2 figuring where the hfiles should go, placing them there, then reopen of the touched regions. > Make HBCK2 be able to fix issues other than region assignment > - > > Key: HBASE-21745 > URL: https://issues.apache.org/jira/browse/HBASE-21745 > Project: HBase > Issue Type: Umbrella > Components: hbase-operator-tools, hbck2 >Reporter: Duo Zhang >Assignee: stack >Priority: Critical > > This is what [~apurtell] posted on mailing-list, HBCK2 should support > * -Rebuild meta from region metadata in the filesystem, aka offline meta > rebuild.- > * -Fix assignment errors (undeployed regions, double assignments (yes, > should not be possible), etc)- (See > https://issues.apache.org/jira/browse/HBASE-21745?focusedCommentId=16888302&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16888302) > * Fix region holes, overlaps, and other errors in the region chain > * Fix failed split and merge transactions that have failed to roll back due > to some bug (related to previous) > * -Enumerate store files to determine file level corruption and sideline > corrupt files- > * -Fix hfile link problems (dangling / broken)- -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
Apache-HBase commented on issue #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/467#issuecomment-520478669 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 0 | Docker mode activated. | | -1 | patch | 16 | https://github.com/apache/hbase/pull/467 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/467 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-467/13/console | | versions | git=2.7.4 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] chenxu14 commented on issue #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
chenxu14 commented on issue #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/467#issuecomment-520485482 sorry, do the wrong rebase, close this pr first This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] chenxu14 closed pull request #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
chenxu14 closed pull request #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/467 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] chenxu14 opened a new pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
chenxu14 opened a new pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22699) refactor isMetaClearingException
[
https://issues.apache.org/jira/browse/HBASE-22699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905347#comment-16905347
]
Hudson commented on HBASE-22699:
Results for branch branch-2.2
[build #509 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/509/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/509//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/509//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/509//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> refactor isMetaClearingException
>
>
> Key: HBASE-22699
> URL: https://issues.apache.org/jira/browse/HBASE-22699
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Junhong Xu
>Assignee: Junhong Xu
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> It is not so readable
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22380) break circle replication when doing bulkload
[ https://issues.apache.org/jira/browse/HBASE-22380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905351#comment-16905351 ] Wellington Chevreuil commented on HBASE-22380: -- Maybe we can change bulk load RPC to add an optional cluster id parameter, so that marker would include this id in the bulk load wal entry event? _HFileReplicator_ would then use the cluster id retrieved from the wal entry, then pass to _LoadIncrementalHFiles._ That way, we would preserve/forward cluster id of from bulk load originator cluster through the wal entry events. > break circle replication when doing bulkload > > > Key: HBASE-22380 > URL: https://issues.apache.org/jira/browse/HBASE-22380 > Project: HBase > Issue Type: Bug > Components: Replication >Reporter: chenxu >Priority: Critical > Labels: bulkload > > when enabled master-master bulkload replication, HFiles will be replicated > circularly between two clusters -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22699) refactor isMetaClearingException
[
https://issues.apache.org/jira/browse/HBASE-22699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905353#comment-16905353
]
Hudson commented on HBASE-22699:
Results for branch branch-2
[build #2162 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2162/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2162//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2162//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2162//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> refactor isMetaClearingException
>
>
> Key: HBASE-22699
> URL: https://issues.apache.org/jira/browse/HBASE-22699
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Junhong Xu
>Assignee: Junhong Xu
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> It is not so readable
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905424#comment-16905424
]
Caroline commented on HBASE-22804:
--
Thanks Andrew, stack, and Mingliang for reviewing.
@[~apurtell]:
_>_ Therefore I propose that there be a follow up patch which makes Canary
Public/Evolving.
I can make this change after this one has been committed.
@[~stack]:
> ... see how avoid direct reference to guava and instead use a shaded internal
>version at org.apache.hbase.thirdparty. That is probably what the above
>shadedjars complaints are about.
Thanks for the suggestion. As Mingliang pointed out, I can replace that line
with private Map regionMap = new
ConcurrentHashMap<>().
> Should this be an Interface so we can add more methods to it w/o breaking it
>(using 'default' implementations?) given it looks like you have to embed the
>Canary to get access to these new APIs?
Only region mode would use this API.. so I'm not sure there's a need for an
interface.
> Oh, maybe say a bit on how you intend to use this new API? Would help. Thanks.
We hope to address two concerns here: 1) was the region reachable (did
read/write succeed)? This will allow us to derive a more accurate HBase
availability metric by calculating a percentage of regions which are
responsive; and 2) did the request complete in time to meet the use case SLO?
(To determine this, we need read/write latencies for each region.)
@[~liuml07]:
I generally agree with your suggestions.
> {{TableName tableName = TableName.valueOf("testTable");}} Test table name can
>be a variable and be referenced later. The value can be the test method name
>to avoid potential conflict.
While this is a good suggestion, I will not change the other test cases already
present in order to conform to this strategy, because it seems irrelevant to
this patch. I will use a different table name for the new unit test.
> {{private Map regionMap =
>Maps.newConcurrentMap();}} can be replaced with {{private MapRegionTaskResult> regionMap = new ConcurrentHashMap<>();}} to not use guava?
>Actually I'm thinking do we need it to be concurrent Map? We populate all
>regions before the sniff and then all other places simply get the individual
>item to update. Thoughts?
I think it's safer to use a Concurrent Map because there are 16 threads to
contact the regions, and they each need to access the map whenever they
publishReadTiming() or publishWriteTiming(). Although I highly doubt they will
try to access the same key, I think it's better to use a thread-safe
implementation when there are multiple threads. It should not have a
performance issue since the locking is at hashmap bucket level, not object
level.
> Provide an API to get list of successful regions and total expected regions
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
> Issue Type: Improvement
> Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
> Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch,
> HBASE-22804.branch-2.001.patch, HBASE-22804.master.001.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs.
> Providing an API to get the list of successes, as well as total number of
> expected regions, will make it easier to get a more accurate availability
> estimate.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22828) Log a region close journal
[ https://issues.apache.org/jira/browse/HBASE-22828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905438#comment-16905438 ] Xu Cang commented on HBASE-22828: - +1 > Log a region close journal > -- > > Key: HBASE-22828 > URL: https://issues.apache.org/jira/browse/HBASE-22828 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 3.0.0, 1.5.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11 > > Attachments: HBASE-22828-branch-1.patch, HBASE-22828.patch > > > We already track region close activity with a MonitoredTask. Enable the > status journal and dump it at DEBUG log level so if for some reasons region > closes are taking a long time we have a timestamped journal of the activity > and how long each step took. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
