[jira] [Commented] (HBASE-22810) Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
[
https://issues.apache.org/jira/browse/HBASE-22810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907867#comment-16907867
]
Hudson commented on HBASE-22810:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #618 (See
[https://builds.apache.org/job/HBase-1.3-IT/618/])
HBASE-22810 Initialize an separate ThreadPoolExecutor for (openinx: rev
b97621b30216dc39ad605e06738a070a69a47da3)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/executor/ExecutorType.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/executor/EventType.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/executor/TestExecutorService.java
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
> Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
>
>
> Key: HBASE-22810
> URL: https://issues.apache.org/jira/browse/HBASE-22810
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> In EventType class, we have the following definition, means taking snapshot
> & restoring snapshot are use the MASTER_TABLE_OPERATIONS Executor now.
> {code}
> /**
>* Messages originating from Client to Master.
>* C_M_SNAPSHOT_TABLE
>* Client asking Master to snapshot an offline table.
>*/
> C_M_SNAPSHOT_TABLE(48, ExecutorType.MASTER_TABLE_OPERATIONS),
> /**
>* Messages originating from Client to Master.
>* C_M_RESTORE_SNAPSHOT
>* Client asking Master to restore a snapshot.
>*/
> C_M_RESTORE_SNAPSHOT (49, ExecutorType.MASTER_TABLE_OPERATIONS),
> {code}
> But when I checked the MASTER_TABLE_OPERATIONS thread pool initialization, I
> see :
> {code}
> private void startServiceThreads() throws IOException{
>// ... some other code initializing
>// We depend on there being only one instance of this executor running
>// at a time. To do concurrency, would need fencing of enable/disable of
>// tables.
>// Any time changing this maxThreads to > 1, pls see the comment at
>// AccessController#postCompletedCreateTableAction
>
> this.executorService.startExecutorService(ExecutorType.MASTER_TABLE_OPERATIONS,
> 1);
>startProcedureExecutor();
> {code}
> That's to say, for CPs enable or disable table sequencely, we will create
> a ThreadPoolExecutor with threadPoolSize=1. Then we actually cann't
> accomplish the snapshoting concurrence even if they are total difference
> tables, says if there are two table snapshoting request, and the Table A cost
> 5min for snapshoting, then the Table B need to wait 5min and once Table A
> finish its snapshot , then Table B will start the snapshot.
> While we've setting the snapshot timeout, so it will be easy to timeout for
> table B snapshoting . Actually, we can create a separate thead pool for
> snapshot operations only.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22856) HBASE-Find-Flaky-Tests fails with pip error
[
https://issues.apache.org/jira/browse/HBASE-22856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907866#comment-16907866
]
Hudson commented on HBASE-22856:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #618 (See
[https://builds.apache.org/job/HBase-1.3-IT/618/])
HBASE-22856 HBASE-Find-Flaky-Tests fails with pip error (zhangduo: rev
1500d9a9b2af30140c3938301e6fd9d156bd8bfd)
* (edit) dev-support/Dockerfile
> HBASE-Find-Flaky-Tests fails with pip error
> ---
>
> Key: HBASE-22856
> URL: https://issues.apache.org/jira/browse/HBASE-22856
> Project: HBase
> Issue Type: Bug
> Components: build, test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22856.patch
>
>
> {noformat}
> 09:59:16 Downloading/unpacking future (from -r
> /hbase/dev-support/python-requirements.txt (line 19))
> 09:59:16Running setup.py (path:/tmp/pip_build_root/future/setup.py)
> egg_info for package future
> 09:59:16 /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown
> distribution option: 'python_requires'
> 09:59:16warnings.warn(msg)
> 09:59:16
> 09:59:16 warning: no files found matching '*.au' under directory 'tests'
> 09:59:16 warning: no files found matching '*.gif' under directory 'tests'
> 09:59:16 warning: no files found matching '*.txt' under directory 'tests'
> 09:59:16 Downloading/unpacking gitpython (from -r
> /hbase/dev-support/python-requirements.txt (line 20))
> 09:59:16Running setup.py (path:/tmp/pip_build_root/gitpython/setup.py)
> egg_info for package gitpython
> 09:59:16 /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown
> distribution option: 'python_requires'
> 09:59:16warnings.warn(msg)
> 09:59:16 error in GitPython setup command: 'install_requires' must be a
> string or list of strings containing valid project/version requirement
> specifiers
> 09:59:16 Complete output from command python setup.py egg_info:
> 09:59:16 /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown
> distribution option: 'python_requires'
> 09:59:16
> 09:59:16warnings.warn(msg)
> 09:59:16
> 09:59:16 error in GitPython setup command: 'install_requires' must be a
> string or list of strings containing valid project/version requirement
> specifiers
> 09:59:16
> 09:59:16
> 09:59:16 Cleaning up...
> 09:59:16 Command python setup.py egg_info failed with error code 1 in
> /tmp/pip_build_root/gitpython
> 09:59:16 Storing debug log for failure in /root/.pip/pip.log
> 09:59:17 The command '/bin/sh -c apt-get -y update && apt-get -y install
> curl python-pip && pip install -r
> /hbase/dev-support/python-requirements.txt' returned a non-zero code: 1
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #490: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Apache-HBase commented on issue #490: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/490#issuecomment-521538612 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 1813 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1.3 Compile Tests _ | | +1 | mvninstall | 461 | branch-1.3 passed | | +1 | compile | 44 | branch-1.3 passed with JDK v1.8.0_222 | | +1 | compile | 46 | branch-1.3 passed with JDK v1.7.0_232 | | +1 | checkstyle | 108 | branch-1.3 passed | | +1 | shadedjars | 198 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 42 | branch-1.3 passed with JDK v1.8.0_222 | | +1 | javadoc | 47 | branch-1.3 passed with JDK v1.7.0_232 | | 0 | spotbugs | 202 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 197 | branch-1.3 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 140 | the patch passed | | +1 | compile | 45 | the patch passed with JDK v1.8.0_222 | | +1 | javac | 45 | the patch passed | | +1 | compile | 49 | the patch passed with JDK v1.7.0_232 | | +1 | javac | 49 | the patch passed | | +1 | checkstyle | 104 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 186 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 645 | Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7. | | +1 | javadoc | 34 | the patch passed with JDK v1.8.0_222 | | +1 | javadoc | 47 | the patch passed with JDK v1.7.0_232 | | +1 | findbugs | 207 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 8873 | hbase-server in the patch failed. | | +1 | asflicense | 82 | The patch does not generate ASF License warnings. | | | | 13489 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestReplicationSource | | | hadoop.hbase.regionserver.TestRemoveRegionMetrics | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-490/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/490 | | JIRA Issue | HBASE-22601 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2f42b5b47026 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-490/out/precommit/personality/provided.sh | | git revision | branch-1.3 / 1500d9a | | Default Java | 1.7.0_232 | | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-490/4/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-490/4/testReport/ | | Max. process+thread count | 3843 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-490/4/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.
[
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907869#comment-16907869
]
Hadoop QA commented on HBASE-22601:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 30m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1.3 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
41s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
48s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
18s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_232 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
22s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
17s{color} | {color:green} branch-1.3 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} the patch passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} the patch passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
6s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
10m 45s{color} | {color:green} Patch does not cause any errors with Hadoop
2.4.1 2.5.2 2.6.5 2.7.7. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} the patch passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
27s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}147m 53s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black
[GitHub] [hbase] Apache-HBase commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again
Apache-HBase commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again URL: https://github.com/apache/hbase/pull/456#issuecomment-521539376 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 35 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 330 | branch-2.1 passed | | +1 | compile | 57 | branch-2.1 passed | | +1 | checkstyle | 89 | branch-2.1 passed | | +1 | shadedjars | 258 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 38 | branch-2.1 passed | | 0 | spotbugs | 183 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 181 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 309 | the patch passed | | +1 | compile | 67 | the patch passed | | +1 | javac | 67 | the patch passed | | +1 | checkstyle | 95 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 257 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1283 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 34 | the patch passed | | +1 | findbugs | 178 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 10296 | hbase-server in the patch passed. | | +1 | asflicense | 30 | The patch does not generate ASF License warnings. | | | | 13919 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/27/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/456 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 73b8beae4b6a 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-456/out/precommit/personality/provided.sh | | git revision | branch-2.1 / d06f877233 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/27/testReport/ | | Max. process+thread count | 4775 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/27/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22860) Master's webui returns NPE/HTTP 500 under maintenance mode
Daisuke Kobayashi created HBASE-22860:
-
Summary: Master's webui returns NPE/HTTP 500 under maintenance mode
Key: HBASE-22860
URL: https://issues.apache.org/jira/browse/HBASE-22860
Project: HBase
Issue Type: Bug
Components: master, UI
Reporter: Daisuke Kobayashi
Master's webui is not accessible when {{hbase.master.maintenance_mode}} is set
to true. This is because it's trying to load a coprocessor
{{RSGroupAdminEndpoint}}.
{code}
java.lang.NullPointerException
at
org.apache.hadoop.hbase.tmpl.master.MasterStatusTmplImpl.renderNoFlush(MasterStatusTmplImpl.java:326)
at
org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.renderNoFlush(MasterStatusTmpl.java:397)
at
org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.render(MasterStatusTmpl.java:388)
at
org.apache.hadoop.hbase.master.MasterStatusServlet.doGet(MasterStatusServlet.java:81)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
at
org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:848)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1780)
at
org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:112)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
at
org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
at
org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1374)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
at
org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
at
org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
at
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:583)
at
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
at
org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548)
at
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226)
at
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
at
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:513)
at
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
at
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
at
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
at
org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119)
at
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
at org.eclipse.jetty.server.Server.handle(Server.java:539)
at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:333)
at
org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
at
org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:283)
at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:108)
at
org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93)
at
org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.executeProduceConsume(ExecuteProduceConsume.java:303)
at
org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceConsume(ExecuteProduceConsume.java:148)
at
org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.run(ExecuteProduceConsume.java:136)
at
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:671)
at
org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:589)
at java.lang.Thread.run(Thread.java:748)
{code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22860) Master's webui returns NPE/HTTP 500 under maintenance mode
[
https://issues.apache.org/jira/browse/HBASE-22860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daisuke Kobayashi updated HBASE-22860:
--
Assignee: Daisuke Kobayashi
Attachment: HBASE-22860.master.001.patch
Status: Patch Available (was: Open)
Submitting the first patch.
> Master's webui returns NPE/HTTP 500 under maintenance mode
> --
>
> Key: HBASE-22860
> URL: https://issues.apache.org/jira/browse/HBASE-22860
> Project: HBase
> Issue Type: Bug
> Components: master, UI
>Reporter: Daisuke Kobayashi
>Assignee: Daisuke Kobayashi
>Priority: Major
> Attachments: HBASE-22860.master.001.patch
>
>
> Master's webui is not accessible when {{hbase.master.maintenance_mode}} is
> set to true. This is because it's trying to load a coprocessor
> {{RSGroupAdminEndpoint}}.
> {code}
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmplImpl.renderNoFlush(MasterStatusTmplImpl.java:326)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.renderNoFlush(MasterStatusTmpl.java:397)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.render(MasterStatusTmpl.java:388)
> at
> org.apache.hadoop.hbase.master.MasterStatusServlet.doGet(MasterStatusServlet.java:81)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:848)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1780)
> at
> org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:112)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1374)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:583)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
> at
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548)
> at
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:513)
> at
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
> at
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
> at org.eclipse.jetty.server.Server.handle(Server.java:539)
> at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:333)
> at
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
> at
> org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:283)
> at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:108)
> at
> org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.executeProduceConsume(ExecuteProduceConsume.java:303)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceConsume(ExecuteProduceConsume.java:148)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.run(ExecuteProduceConsume.java:136)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:671)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:589)
> at java.lang.Thread.run(Thread.java:748)
>
[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop
Apache-HBase commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-521541989 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 1 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 22 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 36 | Maven dependency ordering for branch | | +1 | mvninstall | 302 | master passed | | +1 | compile | 166 | master passed | | +1 | checkstyle | 142 | master passed | | +1 | shadedjars | 267 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 174 | master passed | | 0 | spotbugs | 27 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 27 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for patch | | +1 | mvninstall | 291 | the patch passed | | +1 | compile | 166 | the patch passed | | +1 | javac | 166 | the patch passed | | +1 | checkstyle | 140 | the patch passed | | +1 | shellcheck | 1 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 4 | The patch has no ill-formed XML file. | | +1 | shadedjars | 257 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 924 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 190 | the patch passed | | 0 | findbugs | 27 | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | -1 | unit | 12286 | root in the patch failed. | | +1 | asflicense | 89 | The patch does not generate ASF License warnings. | | | | 17763 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshotNoCluster | | | hadoop.hbase.client.TestAdminShell2 | | | hadoop.hbase.client.TestShell | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/14/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/476 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux 3e030b58b2f1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-476/out/precommit/personality/provided.sh | | git revision | master / d9d5f69fc6 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/14/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/14/testReport/ | | Max. process+thread count | 5473 (vs. ulimit of 1) | | modules | C: hbase-hbtop . hbase-assembly U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/14/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-22860) Master's webui returns NPE/HTTP 500 under maintenance mode
[
https://issues.apache.org/jira/browse/HBASE-22860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907880#comment-16907880
]
Daisuke Kobayashi edited comment on HBASE-22860 at 8/15/19 7:16 AM:
Submitting the first patch. Attaching the screenshot with the patch as well.
was (Author: daisuke.kobayashi):
Submitting the first patch.
> Master's webui returns NPE/HTTP 500 under maintenance mode
> --
>
> Key: HBASE-22860
> URL: https://issues.apache.org/jira/browse/HBASE-22860
> Project: HBase
> Issue Type: Bug
> Components: master, UI
>Reporter: Daisuke Kobayashi
>Assignee: Daisuke Kobayashi
>Priority: Major
> Attachments: HBASE-22860.master.001.patch, Screen Shot 2019-08-15 at
> 4.15.51 PM.png
>
>
> Master's webui is not accessible when {{hbase.master.maintenance_mode}} is
> set to true. This is because it's trying to load a coprocessor
> {{RSGroupAdminEndpoint}}.
> {code}
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmplImpl.renderNoFlush(MasterStatusTmplImpl.java:326)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.renderNoFlush(MasterStatusTmpl.java:397)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.render(MasterStatusTmpl.java:388)
> at
> org.apache.hadoop.hbase.master.MasterStatusServlet.doGet(MasterStatusServlet.java:81)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:848)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1780)
> at
> org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:112)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1374)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:583)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
> at
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548)
> at
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:513)
> at
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
> at
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
> at org.eclipse.jetty.server.Server.handle(Server.java:539)
> at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:333)
> at
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
> at
> org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:283)
> at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:108)
> at
> org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.executeProduceConsume(ExecuteProduceConsume.java:303)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceConsume(ExecuteProduceConsume.java:148)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.run(ExecuteProduceConsume.java:136)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:671)
>
[jira] [Updated] (HBASE-22860) Master's webui returns NPE/HTTP 500 under maintenance mode
[
https://issues.apache.org/jira/browse/HBASE-22860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daisuke Kobayashi updated HBASE-22860:
--
Attachment: Screen Shot 2019-08-15 at 4.15.51 PM.png
> Master's webui returns NPE/HTTP 500 under maintenance mode
> --
>
> Key: HBASE-22860
> URL: https://issues.apache.org/jira/browse/HBASE-22860
> Project: HBase
> Issue Type: Bug
> Components: master, UI
>Reporter: Daisuke Kobayashi
>Assignee: Daisuke Kobayashi
>Priority: Major
> Attachments: HBASE-22860.master.001.patch, Screen Shot 2019-08-15 at
> 4.15.51 PM.png
>
>
> Master's webui is not accessible when {{hbase.master.maintenance_mode}} is
> set to true. This is because it's trying to load a coprocessor
> {{RSGroupAdminEndpoint}}.
> {code}
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmplImpl.renderNoFlush(MasterStatusTmplImpl.java:326)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.renderNoFlush(MasterStatusTmpl.java:397)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.render(MasterStatusTmpl.java:388)
> at
> org.apache.hadoop.hbase.master.MasterStatusServlet.doGet(MasterStatusServlet.java:81)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:848)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1780)
> at
> org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:112)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1374)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:583)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
> at
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548)
> at
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:513)
> at
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
> at
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
> at org.eclipse.jetty.server.Server.handle(Server.java:539)
> at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:333)
> at
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
> at
> org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:283)
> at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:108)
> at
> org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.executeProduceConsume(ExecuteProduceConsume.java:303)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceConsume(ExecuteProduceConsume.java:148)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.run(ExecuteProduceConsume.java:136)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:671)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:589)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian JIRA
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-521542848 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 38 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 35 | Maven dependency ordering for branch | | +1 | mvninstall | 356 | master passed | | +1 | compile | 82 | master passed | | +1 | checkstyle | 112 | master passed | | +1 | shadedjars | 299 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 58 | master passed | | 0 | spotbugs | 268 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 338 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 324 | the patch passed | | +1 | compile | 89 | the patch passed | | +1 | javac | 89 | the patch passed | | +1 | checkstyle | 106 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 274 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1000 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 64 | the patch passed | | +1 | findbugs | 394 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 114 | hbase-client in the patch passed. | | -1 | unit | 8924 | hbase-server in the patch failed. | | +1 | asflicense | 55 | The patch does not generate ASF License warnings. | | | | 13099 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/100/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 61bc5484af9e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / 8ffc45ab8b | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/100/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/100/testReport/ | | Max. process+thread count | 4687 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/100/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #483: HBASE-22841 Add more factory functions to TimeRange
Apache-HBase commented on issue #483: HBASE-22841 Add more factory functions to TimeRange URL: https://github.com/apache/hbase/pull/483#issuecomment-521543341 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 76 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 35 | Maven dependency ordering for branch | | +1 | mvninstall | 326 | master passed | | +1 | compile | 81 | master passed | | +1 | checkstyle | 111 | master passed | | +1 | shadedjars | 290 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 55 | master passed | | 0 | spotbugs | 222 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 270 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 303 | the patch passed | | +1 | compile | 76 | the patch passed | | +1 | javac | 76 | the patch passed | | +1 | checkstyle | 106 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 276 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 964 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 59 | the patch passed | | +1 | findbugs | 345 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 171 | hbase-common in the patch passed. | | -1 | unit | 14059 | hbase-server in the patch failed. | | +1 | asflicense | 78 | The patch does not generate ASF License warnings. | | | | 18131 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.TestMasterOperationsForRegionReplicas | | | hadoop.hbase.client.TestFromClientSide | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/483 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9a4fd6aaf454 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-483/out/precommit/personality/provided.sh | | git revision | master / d9d5f69fc6 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/8/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/8/testReport/ | | Max. process+thread count | 4811 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/8/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #485: HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature
Apache-HBase commented on issue #485: HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature URL: https://github.com/apache/hbase/pull/485#issuecomment-521545182 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 29 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 354 | master passed | | +1 | compile | 59 | master passed | | +1 | checkstyle | 91 | master passed | | +1 | shadedjars | 308 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 38 | master passed | | 0 | spotbugs | 286 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 284 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 328 | the patch passed | | +1 | compile | 62 | the patch passed | | +1 | javac | 62 | the patch passed | | +1 | checkstyle | 87 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 297 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1021 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 39 | the patch passed | | +1 | findbugs | 290 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 11431 | hbase-server in the patch failed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 15156 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.snapshot.TestFlushSnapshotFromClient | | | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/485 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux da8b701f9f52 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-485/out/precommit/personality/provided.sh | | git revision | master / 8ffc45ab8b | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/10/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/10/testReport/ | | Max. process+thread count | 4667 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/10/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907889#comment-16907889 ] Viraj Jasani commented on HBASE-22728: -- Oh yes, I just saw one project having hbase-common dependency. Hence, hbase-common should have provided scope for Jackson1. The only issue is without including dependencies at compile scope in hbase-common, they are not getting included as jar with assembly:single tar. Let me see what we can do here, may be some changes in hbase-assembly could help. Initially I tried including Jackson1 mapper as compile scope only in hbase-assembly, but that didn't even have jackson*jar included in lib of extracted tarball. > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch, > HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch, > HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch, > HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch, > HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch, > HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch, > HBASE-22728.branch-1.18.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #485: HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature
Apache-HBase commented on issue #485: HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature URL: https://github.com/apache/hbase/pull/485#issuecomment-521546085 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 96 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 361 | master passed | | +1 | compile | 58 | master passed | | +1 | checkstyle | 91 | master passed | | +1 | shadedjars | 297 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 41 | master passed | | 0 | spotbugs | 302 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 298 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 346 | the patch passed | | +1 | compile | 64 | the patch passed | | +1 | javac | 64 | the patch passed | | +1 | checkstyle | 102 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 315 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1232 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 45 | the patch passed | | +1 | findbugs | 332 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 17582 | hbase-server in the patch failed. | | +1 | asflicense | 38 | The patch does not generate ASF License warnings. | | | | 21805 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAsyncTableAdminApi3 | | | hadoop.hbase.regionserver.TestRegionReplicaFailover | | | hadoop.hbase.client.TestAdmin2 | | | hadoop.hbase.master.TestMasterShutdown | | | hadoop.hbase.client.TestCloneSnapshotFromClientNormal | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang | | | hadoop.hbase.client.TestAsyncReplicationAdminApiWithClusters | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/485 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux be5c109ad6db 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-485/out/precommit/personality/provided.sh | | git revision | master / 53db390f60 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/8/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/8/testReport/ | | Max. process+thread count | 4965 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/8/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f…
Apache-HBase commented on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f… URL: https://github.com/apache/hbase/pull/484#issuecomment-521548469 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 159 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ branch-1.3 Compile Tests _ | | +1 | mvninstall | 485 | branch-1.3 passed | | +1 | compile | 55 | branch-1.3 passed | | +1 | checkstyle | 126 | branch-1.3 passed | | -1 | shadedjars | 15 | branch has 10 errors when building our shaded downstream artifacts. | | +1 | javadoc | 57 | branch-1.3 passed | | 0 | spotbugs | 183 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 179 | branch-1.3 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 151 | the patch passed | | +1 | compile | 54 | the patch passed | | +1 | javac | 54 | the patch passed | | +1 | checkstyle | 122 | hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | -1 | shadedjars | 12 | patch has 10 errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 676 | Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7. | | +1 | javadoc | 39 | the patch passed | | +1 | findbugs | 176 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 9407 | hbase-server in the patch failed. | | +1 | asflicense | 22 | The patch does not generate ASF License warnings. | | | | 11838 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.snapshot.TestFlushSnapshotFromClient | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/484 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c2b8c7ef6615 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh | | git revision | branch-1.3 / b97621b | | Default Java | 1.8.0_222 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/7/artifact/out/branch-shadedjars.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/7/artifact/out/patch-shadedjars.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/7/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/7/testReport/ | | Max. process+thread count | 4499 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/7/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] chenxu14 commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
chenxu14 commented on a change in pull request #479: HBASE-22802 Avoid temp
ByteBuffer allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/479#discussion_r314206957
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/nio/MultiByteBuff.java
##
@@ -53,6 +55,19 @@
private int markedItemIndex = -1;
private final int[] itemBeginPos;
+ private Iterator buffsIterator = new Iterator() {
+@Override
+public boolean hasNext() {
+ return curItemIndex <= limitedItemIndex &&
items[curItemIndex].hasRemaining();
Review comment:
how about change it like this
`curItemIndex < limitedItemIndex || (curItemIndex == limitedItemIndex &&
items[curItemIndex].hasRemaining())`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #495: HBASE-22857 Fix the failed ut TestHRegion and TestHRegionWithInMemoryFlush
Apache-HBase commented on issue #495: HBASE-22857 Fix the failed ut TestHRegion and TestHRegionWithInMemoryFlush URL: https://github.com/apache/hbase/pull/495#issuecomment-521551389 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 73 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ branch-2.2 Compile Tests _ | | +1 | mvninstall | 295 | branch-2.2 passed | | +1 | compile | 54 | branch-2.2 passed | | +1 | checkstyle | 77 | branch-2.2 passed | | +1 | shadedjars | 243 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 34 | branch-2.2 passed | | 0 | spotbugs | 166 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 165 | branch-2.2 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 282 | the patch passed | | +1 | compile | 53 | the patch passed | | +1 | javac | 53 | the patch passed | | +1 | checkstyle | 79 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 238 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 885 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 32 | the patch passed | | +1 | findbugs | 164 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 15802 | hbase-server in the patch failed. | | +1 | asflicense | 34 | The patch does not generate ASF License warnings. | | | | 18876 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-495/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/495 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux aa1e6a631bbb 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-495/out/precommit/personality/provided.sh | | git revision | branch-2.2 / c04dcc49e7 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-495/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-495/1/testReport/ | | Max. process+thread count | 4130 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-495/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22856) HBASE-Find-Flaky-Tests fails with pip error
[
https://issues.apache.org/jira/browse/HBASE-22856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907901#comment-16907901
]
Peter Somogyi commented on HBASE-22856:
---
belated +1
> HBASE-Find-Flaky-Tests fails with pip error
> ---
>
> Key: HBASE-22856
> URL: https://issues.apache.org/jira/browse/HBASE-22856
> Project: HBase
> Issue Type: Bug
> Components: build, test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22856.patch
>
>
> {noformat}
> 09:59:16 Downloading/unpacking future (from -r
> /hbase/dev-support/python-requirements.txt (line 19))
> 09:59:16Running setup.py (path:/tmp/pip_build_root/future/setup.py)
> egg_info for package future
> 09:59:16 /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown
> distribution option: 'python_requires'
> 09:59:16warnings.warn(msg)
> 09:59:16
> 09:59:16 warning: no files found matching '*.au' under directory 'tests'
> 09:59:16 warning: no files found matching '*.gif' under directory 'tests'
> 09:59:16 warning: no files found matching '*.txt' under directory 'tests'
> 09:59:16 Downloading/unpacking gitpython (from -r
> /hbase/dev-support/python-requirements.txt (line 20))
> 09:59:16Running setup.py (path:/tmp/pip_build_root/gitpython/setup.py)
> egg_info for package gitpython
> 09:59:16 /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown
> distribution option: 'python_requires'
> 09:59:16warnings.warn(msg)
> 09:59:16 error in GitPython setup command: 'install_requires' must be a
> string or list of strings containing valid project/version requirement
> specifiers
> 09:59:16 Complete output from command python setup.py egg_info:
> 09:59:16 /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown
> distribution option: 'python_requires'
> 09:59:16
> 09:59:16warnings.warn(msg)
> 09:59:16
> 09:59:16 error in GitPython setup command: 'install_requires' must be a
> string or list of strings containing valid project/version requirement
> specifiers
> 09:59:16
> 09:59:16
> 09:59:16 Cleaning up...
> 09:59:16 Command python setup.py egg_info failed with error code 1 in
> /tmp/pip_build_root/gitpython
> 09:59:16 Storing debug log for failure in /root/.pip/pip.log
> 09:59:17 The command '/bin/sh -c apt-get -y update && apt-get -y install
> curl python-pip && pip install -r
> /hbase/dev-support/python-requirements.txt' returned a non-zero code: 1
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#issuecomment-521552742 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 138 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 47 | Maven dependency ordering for branch | | +1 | mvninstall | 476 | master passed | | +1 | compile | 102 | master passed | | +1 | checkstyle | 129 | master passed | | +1 | shadedjars | 355 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 73 | master passed | | 0 | spotbugs | 352 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 413 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 426 | the patch passed | | +1 | compile | 97 | the patch passed | | +1 | javac | 97 | the patch passed | | +1 | checkstyle | 38 | hbase-common: The patch generated 0 new + 48 unchanged - 2 fixed = 48 total (was 50) | | +1 | checkstyle | 108 | The patch passed checkstyle in hbase-server | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 367 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1326 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 70 | the patch passed | | -1 | findbugs | 71 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 203 | hbase-common in the patch passed. | | -1 | unit | 15014 | hbase-server in the patch failed. | | +1 | asflicense | 48 | The patch does not generate ASF License warnings. | | | | 20391 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.nio.MultiByteBuff$1.next() can't throw NoSuchElementException At MultiByteBuff.java:At MultiByteBuff.java:[lines 66-67] | | Failed junit tests | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/11/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/479 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 0ad3ddbdc959 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-479/out/precommit/personality/provided.sh | | git revision | master / d9d5f69fc6 | | Default Java | 1.8.0_181 | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/11/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/11/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/11/testReport/ | | Max. process+thread count | 4836 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/11/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907889#comment-16907889 ] Viraj Jasani edited comment on HBASE-22728 at 8/15/19 8:03 AM: --- Oh yes, I just saw one project having hbase-common dependency. Hence, hbase-common should have provided scope for Jackson1. The only issue is without including dependencies at compile scope in hbase-common, they are not getting included as jar with assembly:single tar. Let me see what we can do here, may be some changes in hbase-assembly could help. Initially I tried including Jackson1 mapper as compile scope only in hbase-assembly(everywhere else had provided), but that didn't even include jar in lib of extracted tarball. was (Author: vjasani): Oh yes, I just saw one project having hbase-common dependency. Hence, hbase-common should have provided scope for Jackson1. The only issue is without including dependencies at compile scope in hbase-common, they are not getting included as jar with assembly:single tar. Let me see what we can do here, may be some changes in hbase-assembly could help. Initially I tried including Jackson1 mapper as compile scope only in hbase-assembly, but that didn't even have jackson*jar included in lib of extracted tarball. > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch, > HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch, > HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch, > HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch, > HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch, > HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch, > HBASE-22728.branch-1.18.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907906#comment-16907906
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #59 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/59/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/59//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/59//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/59//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22830) Remove deprecated method from StoreFile
[
https://issues.apache.org/jira/browse/HBASE-22830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907914#comment-16907914
]
Hudson commented on HBASE-22830:
Results for branch master
[build #1334 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1334/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove deprecated method from StoreFile
> ---
>
> Key: HBASE-22830
> URL: https://issues.apache.org/jira/browse/HBASE-22830
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0
>
>
> {{getModificationTimeStamp}} in {{StoreFile}} is deprecated and should be
> removed in 3.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22831) Remove deprecated constructor from TableRecordWriter
[
https://issues.apache.org/jira/browse/HBASE-22831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907911#comment-16907911
]
Hudson commented on HBASE-22831:
Results for branch master
[build #1334 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1334/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove deprecated constructor from TableRecordWriter
>
>
> Key: HBASE-22831
> URL: https://issues.apache.org/jira/browse/HBASE-22831
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0
>
>
> {{TableRecordWriter}} has a deprecated constructor, which should be removed
> in 3.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22837) Move "Custom WAL Directory" section from "Bulk Loading" to "Write Ahead Log (WAL)" chapter
[
https://issues.apache.org/jira/browse/HBASE-22837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907918#comment-16907918
]
Hudson commented on HBASE-22837:
Results for branch master
[build #1334 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1334/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move "Custom WAL Directory" section from "Bulk Loading" to "Write Ahead Log
> (WAL)" chapter
> --
>
> Key: HBASE-22837
> URL: https://issues.apache.org/jira/browse/HBASE-22837
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-22837.master.001.patch
>
>
> Currently, explanation about *Custom WAL Directory* configuration is a
> sub-topic of *Bulk Loading,* chapter, yet this subject has not much relation
> with bulk loading at all. It should rather be moved to a sub-section of the
> *Write Ahead Log (WAL)* chapter.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22832) Remove deprecated method in HFileOutputFormat2
[
https://issues.apache.org/jira/browse/HBASE-22832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907912#comment-16907912
]
Hudson commented on HBASE-22832:
Results for branch master
[build #1334 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1334/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove deprecated method in HFileOutputFormat2
> --
>
> Key: HBASE-22832
> URL: https://issues.apache.org/jira/browse/HBASE-22832
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0
>
>
> The method {{getHTableDescriptor}} was deprecated in {{HFileOutputFormat2}}
> and should be removed for 3.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22725) Remove all remaining javadoc warnings
[
https://issues.apache.org/jira/browse/HBASE-22725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907913#comment-16907913
]
Hudson commented on HBASE-22725:
Results for branch master
[build #1334 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1334/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove all remaining javadoc warnings
> --
>
> Key: HBASE-22725
> URL: https://issues.apache.org/jira/browse/HBASE-22725
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 3.0.0
>Reporter: Murtaza Hassan
>Assignee: Murtaza Hassan
>Priority: Trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22845) Revert MetaTableAccessor#makePutFromTableState access to public
[
https://issues.apache.org/jira/browse/HBASE-22845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907919#comment-16907919
]
Hudson commented on HBASE-22845:
Results for branch master
[build #1334 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1334/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Revert MetaTableAccessor#makePutFromTableState access to public
> ---
>
> Key: HBASE-22845
> URL: https://issues.apache.org/jira/browse/HBASE-22845
> Project: HBase
> Issue Type: Sub-task
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Blocker
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> Discussions in HBASE-22843.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22828) Log a region close journal
[
https://issues.apache.org/jira/browse/HBASE-22828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907920#comment-16907920
]
Hudson commented on HBASE-22828:
Results for branch master
[build #1334 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1334/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Log a region close journal
> --
>
> Key: HBASE-22828
> URL: https://issues.apache.org/jira/browse/HBASE-22828
> Project: HBase
> Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22828-branch-1.patch, HBASE-22828.patch
>
>
> We already track region close activity with a MonitoredTask. Enable the
> status journal and dump it at DEBUG log level so if for some reasons region
> closes are taking a long time we have a timestamped journal of the activity
> and how long each step took.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22699) refactor isMetaClearingException
[
https://issues.apache.org/jira/browse/HBASE-22699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907916#comment-16907916
]
Hudson commented on HBASE-22699:
Results for branch master
[build #1334 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1334/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> refactor isMetaClearingException
>
>
> Key: HBASE-22699
> URL: https://issues.apache.org/jira/browse/HBASE-22699
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Junhong Xu
>Assignee: Junhong Xu
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> It is not so readable
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22838) assembly:single failure: user id or group id 'xxxxx' is too big
[
https://issues.apache.org/jira/browse/HBASE-22838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907917#comment-16907917
]
Hudson commented on HBASE-22838:
Results for branch master
[build #1334 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1334/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> assembly:single failure: user id or group id 'x' is too big
> ---
>
> Key: HBASE-22838
> URL: https://issues.apache.org/jira/browse/HBASE-22838
> Project: HBase
> Issue Type: Bug
> Components: build
>Affects Versions: 3.0.0, 1.5.0, 2.3.0
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
>
> tarball build with assembly:single command fails with user id(mac) or group
> id(ubuntu) too big error:
> {code:java}
> $ mvn clean install package assembly:single -DskipTests
>
>
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-assembly-plugin:3.0.0:single (default-cli) on
> project hbase-assembly: Execution default-cli of goal
> org.apache.maven.plugins:maven-assembly-plugin:3.0.0:single failed: user id
> '' is too big ( > 2097151 ). -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn -rf :hbase-assembly
> {code}
> To avoid this error and to get better features for tarball build, we should
> upgrade tarLongFileMode from gnu to posix: MPOM-132
> This works for assembly plugin >= 2.5.0: MASSEMBLY-728
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22829) Remove deprecated methods from SnapshotDescription
[
https://issues.apache.org/jira/browse/HBASE-22829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907915#comment-16907915
]
Hudson commented on HBASE-22829:
Results for branch master
[build #1334 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1334/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove deprecated methods from SnapshotDescription
> --
>
> Key: HBASE-22829
> URL: https://issues.apache.org/jira/browse/HBASE-22829
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0
>
>
> {{SnapshotDescription}} contains some deprecated constructors and methods,
> which should be removed for 3.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22856) HBASE-Find-Flaky-Tests fails with pip error
[
https://issues.apache.org/jira/browse/HBASE-22856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907922#comment-16907922
]
Hudson commented on HBASE-22856:
Results for branch master
[build #1334 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1334/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> HBASE-Find-Flaky-Tests fails with pip error
> ---
>
> Key: HBASE-22856
> URL: https://issues.apache.org/jira/browse/HBASE-22856
> Project: HBase
> Issue Type: Bug
> Components: build, test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22856.patch
>
>
> {noformat}
> 09:59:16 Downloading/unpacking future (from -r
> /hbase/dev-support/python-requirements.txt (line 19))
> 09:59:16Running setup.py (path:/tmp/pip_build_root/future/setup.py)
> egg_info for package future
> 09:59:16 /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown
> distribution option: 'python_requires'
> 09:59:16warnings.warn(msg)
> 09:59:16
> 09:59:16 warning: no files found matching '*.au' under directory 'tests'
> 09:59:16 warning: no files found matching '*.gif' under directory 'tests'
> 09:59:16 warning: no files found matching '*.txt' under directory 'tests'
> 09:59:16 Downloading/unpacking gitpython (from -r
> /hbase/dev-support/python-requirements.txt (line 20))
> 09:59:16Running setup.py (path:/tmp/pip_build_root/gitpython/setup.py)
> egg_info for package gitpython
> 09:59:16 /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown
> distribution option: 'python_requires'
> 09:59:16warnings.warn(msg)
> 09:59:16 error in GitPython setup command: 'install_requires' must be a
> string or list of strings containing valid project/version requirement
> specifiers
> 09:59:16 Complete output from command python setup.py egg_info:
> 09:59:16 /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown
> distribution option: 'python_requires'
> 09:59:16
> 09:59:16warnings.warn(msg)
> 09:59:16
> 09:59:16 error in GitPython setup command: 'install_requires' must be a
> string or list of strings containing valid project/version requirement
> specifiers
> 09:59:16
> 09:59:16
> 09:59:16 Cleaning up...
> 09:59:16 Command python setup.py egg_info failed with error code 1 in
> /tmp/pip_build_root/gitpython
> 09:59:16 Storing debug log for failure in /root/.pip/pip.log
> 09:59:17 The command '/bin/sh -c apt-get -y update && apt-get -y install
> curl python-pip && pip install -r
> /hbase/dev-support/python-requirements.txt' returned a non-zero code: 1
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22854) Remove +x shell spew from do-release-*.sh create-release scripts
[
https://issues.apache.org/jira/browse/HBASE-22854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907921#comment-16907921
]
Hudson commented on HBASE-22854:
Results for branch master
[build #1334 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1334/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1334//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove +x shell spew from do-release-*.sh create-release scripts
>
>
> Key: HBASE-22854
> URL: https://issues.apache.org/jira/browse/HBASE-22854
> Project: HBase
> Issue Type: Improvement
> Components: RC
>Reporter: stack
>Assignee: stack
>Priority: Major
> Attachments:
> 0001-HBASE-22854-Remove-x-shell-spew-from-do-release-.sh-.patch
>
>
> Remove the +x from the create-release scripts now they seem to be working.
> Can consult build log anyways if issue. Also did minor tuneup to the 'making
> a release candidate doc' and add a README in the create-release dir that
> points there in case poor dev can't figure what this dir is all about.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1
[
https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907926#comment-16907926
]
Viraj Jasani commented on HBASE-22728:
--
Just a small summary so far:
# Replaced all vulnerable mapper dependency(jackson-mapper-asl) with Jackson2
mapper(jackson-databind) in all modules.
# Included Jackson2 at compile scope in hbase-rest.
# hbase-shell requires dependency of jackson-core-asl. To tackle this, we
might need to upgrade JRuby eventually. For now, it's fine to include
jackson-core-asl(not vulnerable).
# Since HBase code no longer needs jackson-mapper-asl( #1), we can live
without it, but once we generate tar and extract it, we get these warnings
since Hadoop requires this dependency:
{code:java}
2019-08-13 16:32:34,147 WARN [main] fs.FileSystem: Cannot load filesystem:
java.util.ServiceConfigurationError: org.apache.hadoop.fs.FileSystem: Provider
org.apache.hadoop.hdfs.web.WebHdfsFileSystem could not be instantiated
2019-08-13 16:32:34,147 WARN [main] fs.FileSystem:
java.lang.NoClassDefFoundError: org/codehaus/jackson/map/ObjectMapper{code}
# Without including jackson-mapper-asl / Jackson2 dependencies as 'compile'
scope in hbase-common, we are not getting corresponding jars in lib folder of
extracted tarball. Need to resolve this issue since we should not include
jackson-mapper-asl with 'compile' scope in hbase-common/hbase-client/dependent
hbase-* of client.
> Upgrade jackson dependencies in branch-1
>
>
> Key: HBASE-22728
> URL: https://issues.apache.org/jira/browse/HBASE-22728
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 1.4.10, 1.3.5
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch,
> HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch,
> HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch,
> HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch,
> HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch,
> HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch,
> HBASE-22728.branch-1.18.patch
>
>
> Avoid Jackson versions and dependencies with known CVEs
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22860) Master's webui returns NPE/HTTP 500 under maintenance mode
[
https://issues.apache.org/jira/browse/HBASE-22860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907932#comment-16907932
]
Wellington Chevreuil commented on HBASE-22860:
--
LGTM. Is this affecting all versions > 2.10 [~daisuke.kobayashi]?
> Master's webui returns NPE/HTTP 500 under maintenance mode
> --
>
> Key: HBASE-22860
> URL: https://issues.apache.org/jira/browse/HBASE-22860
> Project: HBase
> Issue Type: Bug
> Components: master, UI
>Reporter: Daisuke Kobayashi
>Assignee: Daisuke Kobayashi
>Priority: Major
> Attachments: HBASE-22860.master.001.patch, Screen Shot 2019-08-15 at
> 4.15.51 PM.png
>
>
> Master's webui is not accessible when {{hbase.master.maintenance_mode}} is
> set to true. This is because it's trying to load a coprocessor
> {{RSGroupAdminEndpoint}}.
> {code}
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmplImpl.renderNoFlush(MasterStatusTmplImpl.java:326)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.renderNoFlush(MasterStatusTmpl.java:397)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.render(MasterStatusTmpl.java:388)
> at
> org.apache.hadoop.hbase.master.MasterStatusServlet.doGet(MasterStatusServlet.java:81)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:848)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1780)
> at
> org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:112)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1374)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:583)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
> at
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548)
> at
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:513)
> at
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
> at
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
> at org.eclipse.jetty.server.Server.handle(Server.java:539)
> at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:333)
> at
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
> at
> org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:283)
> at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:108)
> at
> org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.executeProduceConsume(ExecuteProduceConsume.java:303)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceConsume(ExecuteProduceConsume.java:148)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.run(ExecuteProduceConsume.java:136)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:671)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:589)
> at java.lang.Thread.run
[GitHub] [hbase] Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility
Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/477#issuecomment-521560284 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 46 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 320 | master passed | | +1 | compile | 53 | master passed | | +1 | checkstyle | 86 | master passed | | +1 | shadedjars | 276 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 37 | master passed | | 0 | spotbugs | 248 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 246 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 300 | the patch passed | | +1 | compile | 51 | the patch passed | | +1 | javac | 51 | the patch passed | | +1 | checkstyle | 75 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 258 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 917 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 34 | the patch passed | | +1 | findbugs | 247 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 18780 | hbase-server in the patch failed. | | -1 | asflicense | 24 | The patch generated 35 ASF License warnings. | | | | 22117 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotFromClientWithRegionReplicas | | | hadoop.hbase.TestNamespace | | | hadoop.hbase.filter.TestScanRowPrefix | | | hadoop.hbase.client.TestAsyncTable | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService | | | hadoop.hbase.regionserver.TestNotCleanupCompactedFileWhenRegionWarmup | | | hadoop.hbase.client.TestMobCloneSnapshotFromClientAfterSplittingRegion | | | hadoop.hbase.coprocessor.TestCoprocessorMetrics | | | hadoop.hbase.client.TestMobSnapshotFromClient | | | hadoop.hbase.regionserver.TestRegionReplicasWithModifyTable | | | hadoop.hbase.ipc.TestNettyRpcServer | | | hadoop.hbase.security.token.TestDelegationTokenWithEncryption | | | hadoop.hbase.master.TestDeadServer | | | hadoop.hbase.TestIOFencing | | | hadoop.hbase.client.TestAdmin | | | hadoop.hbase.TestSequenceIdMonotonicallyIncreasing | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalCopyToRemote | | | hadoop.hbase.master.assignment.TestRegionAssignedToMultipleRegionServers | | | hadoop.hbase.replication.TestPerTableCFReplication | | | hadoop.hbase.coprocessor.TestOpenTableInCoprocessor | | | hadoop.hbase.filter.TestFilterListOnMini | | | hadoop.hbase.client.TestMobCloneSnapshotFromClientError | | | hadoop.hbase.client.TestAsyncTableScanner | | | hadoop.hbase.client.TestServerBusyException | | | hadoop.hbase.replication.TestSyncReplicationRemoveRemoteWAL | | | hadoop.hbase.TestFullLogReconstruction | | | hadoop.hbase.coprocessor.TestRegionObserverForAddingMutationsFromCoprocessors | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.TestMetaTableAccessor | | | hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithRemove | | | hadoop.hbase.security.access.TestAccessController2 | | | hadoop.hbase.regionserver.wal.TestAsyncFSWAL | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.master.procedure.TestDisableTableProcedure | | | hadoop.hbase.snapshot.TestFlushSnapshotFromClient | | | hadoop.hbase.quotas.TestQuotaTableUtil | | | hadoop.hbase.client.TestAsyncTableScanMetrics | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed | | | hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL | | | hadoop.hbase.TestMovedRegionsCleaner | | | hadoop.hbase.wal.TestWALSplitBoundedLogWriterCreation | | | hadoop.hbase.client.TestAsyncClusterAdminApi | | | hadoop.hbase.replication.TestNamespaceReplication | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientClone | | | hadoop.hbase.client.TestRestoreSnapshotFromClientSchemaChange | | | hadoop.hbase.coprocessor.TestRegionObserverInterface | | | hadoop.hbase.security.visibility.TestVisibility
[jira] [Comment Edited] (HBASE-22860) Master's webui returns NPE/HTTP 500 under maintenance mode
[
https://issues.apache.org/jira/browse/HBASE-22860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907932#comment-16907932
]
Wellington Chevreuil edited comment on HBASE-22860 at 8/15/19 8:28 AM:
---
LGTM. Is this affecting all versions > 2.1.0 [~daisuke.kobayashi]?
was (Author: wchevreuil):
LGTM. Is this affecting all versions > 2.10 [~daisuke.kobayashi]?
> Master's webui returns NPE/HTTP 500 under maintenance mode
> --
>
> Key: HBASE-22860
> URL: https://issues.apache.org/jira/browse/HBASE-22860
> Project: HBase
> Issue Type: Bug
> Components: master, UI
>Reporter: Daisuke Kobayashi
>Assignee: Daisuke Kobayashi
>Priority: Major
> Attachments: HBASE-22860.master.001.patch, Screen Shot 2019-08-15 at
> 4.15.51 PM.png
>
>
> Master's webui is not accessible when {{hbase.master.maintenance_mode}} is
> set to true. This is because it's trying to load a coprocessor
> {{RSGroupAdminEndpoint}}.
> {code}
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmplImpl.renderNoFlush(MasterStatusTmplImpl.java:326)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.renderNoFlush(MasterStatusTmpl.java:397)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.render(MasterStatusTmpl.java:388)
> at
> org.apache.hadoop.hbase.master.MasterStatusServlet.doGet(MasterStatusServlet.java:81)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:848)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1780)
> at
> org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:112)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1374)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:583)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
> at
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548)
> at
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:513)
> at
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
> at
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
> at org.eclipse.jetty.server.Server.handle(Server.java:539)
> at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:333)
> at
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
> at
> org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:283)
> at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:108)
> at
> org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.executeProduceConsume(ExecuteProduceConsume.java:303)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceConsume(ExecuteProduceConsume.java:148)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.run(ExecuteProduceConsume.java:136)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedTh
[GitHub] [hbase] Apache-HBase commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again
Apache-HBase commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again URL: https://github.com/apache/hbase/pull/456#issuecomment-521561782 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 93 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 337 | branch-2.1 passed | | +1 | compile | 54 | branch-2.1 passed | | +1 | checkstyle | 90 | branch-2.1 passed | | +1 | shadedjars | 261 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 37 | branch-2.1 passed | | 0 | spotbugs | 167 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 165 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 316 | the patch passed | | +1 | compile | 59 | the patch passed | | +1 | javac | 59 | the patch passed | | +1 | checkstyle | 90 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 268 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1352 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 35 | the patch passed | | +1 | findbugs | 188 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 12802 | hbase-server in the patch failed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 16562 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/28/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/456 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux caf3734796cc 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-456/out/precommit/personality/provided.sh | | git revision | branch-2.1 / f49a86ae4f | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/28/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/28/testReport/ | | Max. process+thread count | 4781 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/28/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-521562157 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 61 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 38 | Maven dependency ordering for branch | | +1 | mvninstall | 387 | master passed | | +1 | compile | 86 | master passed | | +1 | checkstyle | 108 | master passed | | +1 | shadedjars | 287 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 57 | master passed | | 0 | spotbugs | 275 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 349 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 364 | the patch passed | | +1 | compile | 83 | the patch passed | | +1 | javac | 83 | the patch passed | | +1 | checkstyle | 104 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 281 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 968 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 56 | the patch passed | | +1 | findbugs | 337 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 100 | hbase-client in the patch passed. | | -1 | unit | 18332 | hbase-server in the patch failed. | | +1 | asflicense | 66 | The patch does not generate ASF License warnings. | | | | 22525 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/99/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux fd36f9fe02b4 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / d9d5f69fc6 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/99/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/99/testReport/ | | Max. process+thread count | 5002 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/99/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f…
Apache-HBase commented on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f… URL: https://github.com/apache/hbase/pull/484#issuecomment-521568121 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 3163 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ branch-1.3 Compile Tests _ | | +1 | mvninstall | 465 | branch-1.3 passed | | +1 | compile | 52 | branch-1.3 passed with JDK v1.8.0_222 | | +1 | compile | 52 | branch-1.3 passed with JDK v1.7.0_232 | | +1 | checkstyle | 127 | branch-1.3 passed | | +1 | shadedjars | 206 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 41 | branch-1.3 passed with JDK v1.8.0_222 | | +1 | javadoc | 49 | branch-1.3 passed with JDK v1.7.0_232 | | 0 | spotbugs | 213 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 209 | branch-1.3 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 131 | the patch passed | | +1 | compile | 46 | the patch passed with JDK v1.8.0_222 | | +1 | javac | 46 | the patch passed | | +1 | compile | 50 | the patch passed with JDK v1.7.0_232 | | +1 | javac | 50 | the patch passed | | +1 | checkstyle | 119 | hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 199 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 666 | Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7. | | +1 | javadoc | 33 | the patch passed with JDK v1.8.0_222 | | +1 | javadoc | 50 | the patch passed with JDK v1.7.0_232 | | +1 | findbugs | 212 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 14119 | hbase-server in the patch failed. | | +1 | asflicense | 168 | The patch does not generate ASF License warnings. | | | | 20347 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.handler.TestEnableTableHandler | | | hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS | | | hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster | | | hadoop.hbase.regionserver.TestRegionReplicaFailover | | | hadoop.hbase.snapshot.TestFlushSnapshotFromClient | | | hadoop.hbase.client.TestAdmin2 | | | hadoop.hbase.regionserver.TestEncryptionKeyRotation | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/484 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux ddcf2e148861 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh | | git revision | branch-1.3 / b97621b | | Default Java | 1.7.0_232 | | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/6/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/6/testReport/ | | Max. process+thread count | 3815 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/6/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-521571973 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 56 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 33 | Maven dependency ordering for branch | | +1 | mvninstall | 316 | master passed | | +1 | compile | 108 | master passed | | +1 | checkstyle | 116 | master passed | | +1 | shadedjars | 307 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 74 | master passed | | 0 | spotbugs | 259 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 357 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 349 | the patch passed | | +1 | compile | 108 | the patch passed | | +1 | javac | 108 | the patch passed | | -1 | checkstyle | 75 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 267 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 951 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 77 | the patch passed | | -1 | findbugs | 58 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 177 | hbase-common in the patch passed. | | -1 | unit | 19750 | hbase-server in the patch failed. | | +1 | unit | 543 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 82 | The patch does not generate ASF License warnings. | | | | 24610 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Failed junit tests | hadoop.hbase.master.TestMasterShutdown | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.replication.TestReplicationSyncUpTool | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.tool.TestBulkLoadHFiles | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.replication.TestReplicationKillSlaveRS | | | hadoop.hbase.client.TestFromClientSide3 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/45/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f6ff39bdff5f 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / d9d5f69fc6 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/45/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/45/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/45/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/45/testReport/ | | Max. process+thread count | 4834 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/45/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0
[GitHub] [hbase] Apache-HBase commented on issue #486: HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
Apache-HBase commented on issue #486: HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot URL: https://github.com/apache/hbase/pull/486#issuecomment-521572113 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 58 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 39 | Maven dependency ordering for branch | | +1 | mvninstall | 426 | master passed | | +1 | compile | 100 | master passed | | +1 | checkstyle | 139 | master passed | | +1 | shadedjars | 343 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 70 | master passed | | 0 | spotbugs | 327 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 390 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 405 | the patch passed | | +1 | compile | 107 | the patch passed | | +1 | javac | 107 | the patch passed | | -1 | checkstyle | 104 | hbase-server: The patch generated 3 new + 162 unchanged - 7 fixed = 165 total (was 169) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 359 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1294 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 70 | the patch passed | | +1 | findbugs | 432 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 217 | hbase-common in the patch passed. | | -1 | unit | 19484 | hbase-server in the patch failed. | | +1 | asflicense | 58 | The patch does not generate ASF License warnings. | | | | 24660 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.snapshot.TestFlushSnapshotFromClient | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.replication.TestReplicationKillSlaveRSWithSeparateOldWALs | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-486/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/486 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8e8f7bc61373 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-486/out/precommit/personality/provided.sh | | git revision | master / d9d5f69fc6 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-486/6/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-486/6/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-486/6/testReport/ | | Max. process+thread count | 4829 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-486/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation
Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation URL: https://github.com/apache/hbase/pull/478#issuecomment-521575573 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 63 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 35 | Maven dependency ordering for branch | | +1 | mvninstall | 329 | master passed | | +1 | compile | 78 | master passed | | +1 | checkstyle | 107 | master passed | | +1 | shadedjars | 274 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 53 | master passed | | 0 | spotbugs | 250 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 316 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 305 | the patch passed | | +1 | compile | 75 | the patch passed | | +1 | javac | 75 | the patch passed | | +1 | checkstyle | 102 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 265 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1033 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 58 | the patch passed | | +1 | findbugs | 348 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 109 | hbase-client in the patch passed. | | -1 | unit | 21173 | hbase-server in the patch failed. | | +1 | asflicense | 46 | The patch does not generate ASF License warnings. | | | | 25229 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.replication.TestReplicationKillSlaveRS | | | hadoop.hbase.master.TestMasterOperationsForRegionReplicas | | | hadoop.hbase.replication.TestMasterReplication | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure | | | hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure | | | hadoop.hbase.namespace.TestNamespaceAuditor | | | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.tool.TestBulkLoadHFiles | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.replication.TestReplicationSmallTests | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/11/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/478 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d921755bba8d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-478/out/precommit/personality/provided.sh | | git revision | master / d9d5f69fc6 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/11/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/11/testReport/ | | Max. process+thread count | 4929 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/11/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please
[GitHub] [hbase] Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#issuecomment-521577550 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 60 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 35 | Maven dependency ordering for branch | | +1 | mvninstall | 310 | master passed | | +1 | compile | 76 | master passed | | +1 | checkstyle | 101 | master passed | | +1 | shadedjars | 269 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 56 | master passed | | 0 | spotbugs | 266 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 315 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 312 | the patch passed | | +1 | compile | 77 | the patch passed | | +1 | javac | 77 | the patch passed | | +1 | checkstyle | 24 | hbase-common: The patch generated 0 new + 48 unchanged - 2 fixed = 48 total (was 50) | | +1 | checkstyle | 76 | The patch passed checkstyle in hbase-server | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 273 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 976 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 52 | the patch passed | | -1 | findbugs | 54 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 171 | hbase-common in the patch passed. | | -1 | unit | 17664 | hbase-server in the patch failed. | | +1 | asflicense | 50 | The patch does not generate ASF License warnings. | | | | 21605 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.nio.MultiByteBuff$1.next() can't throw NoSuchElementException At MultiByteBuff.java:At MultiByteBuff.java:[lines 66-67] | | Failed junit tests | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.snapshot.TestFlushSnapshotFromClient | | | hadoop.hbase.client.TestFromClientSide | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/12/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/479 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f4a0cecc6007 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-479/out/precommit/personality/provided.sh | | git revision | master / 8ffc45ab8b | | Default Java | 1.8.0_181 | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/12/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/12/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/12/testReport/ | | Max. process+thread count | 5081 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/12/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes… URL: https://github.com/apache/hbase/pull/446#issuecomment-521578296 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 60 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 372 | master passed | | +1 | compile | 57 | master passed | | +1 | checkstyle | 78 | master passed | | +1 | shadedjars | 301 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | master passed | | 0 | spotbugs | 250 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 246 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 295 | the patch passed | | +1 | compile | 54 | the patch passed | | +1 | javac | 54 | the patch passed | | +1 | checkstyle | 77 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 268 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1169 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 34 | the patch passed | | +1 | findbugs | 259 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 17447 | hbase-server in the patch failed. | | +1 | asflicense | 29 | The patch does not generate ASF License warnings. | | | | 21189 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.snapshot.TestFlushSnapshotFromClient | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | | hadoop.hbase.client.TestFromClientSide | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/44/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/446 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 88c3f309e137 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-446/out/precommit/personality/provided.sh | | git revision | master / 8ffc45ab8b | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/44/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/44/testReport/ | | Max. process+thread count | 5228 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/44/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #497: HBASE-22858 Add HBCK Report to master's header.jsp
Apache-HBase commented on issue #497: HBASE-22858 Add HBCK Report to master's header.jsp URL: https://github.com/apache/hbase/pull/497#issuecomment-521578320 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 325 | master passed | | +1 | javadoc | 34 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 295 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | javadoc | 33 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 8587 | hbase-server in the patch failed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 9396 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-497/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/497 | | Optional Tests | dupname asflicense javac javadoc unit | | uname | Linux 389a2a604739 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-497/out/precommit/personality/provided.sh | | git revision | master / 8ffc45ab8b | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-497/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-497/1/testReport/ | | Max. process+thread count | 4799 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-497/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility
Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/477#issuecomment-521583630 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 70 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 46 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 360 | master passed | | +1 | compile | 52 | master passed | | +1 | checkstyle | 80 | master passed | | +1 | shadedjars | 273 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | master passed | | 0 | spotbugs | 260 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 256 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 306 | the patch passed | | +1 | compile | 53 | the patch passed | | +1 | javac | 53 | the patch passed | | +1 | checkstyle | 76 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 261 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 913 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 32 | the patch passed | | +1 | findbugs | 245 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 18817 | hbase-server in the patch failed. | | -1 | asflicense | 65 | The patch generated 17 ASF License warnings. | | | | 22285 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.TestMasterFailoverBalancerPersistence | | | hadoop.hbase.master.balancer.TestFavoredNodeTableImport | | | hadoop.hbase.coprocessor.TestRegionObserverForAddingMutationsFromCoprocessors | | | hadoop.hbase.client.TestSplitOrMergeAtTableLevel | | | hadoop.hbase.client.TestAsyncResultScannerCursor | | | hadoop.hbase.client.TestClientScannerRPCTimeout | | | hadoop.hbase.replication.TestSyncReplicationStandBy | | | hadoop.hbase.client.TestMobCloneSnapshotFromClientNormal | | | hadoop.hbase.client.TestCloneSnapshotFromClientError | | | hadoop.hbase.regionserver.TestMobStoreScanner | | | hadoop.hbase.client.TestMobCloneSnapshotFromClientError | | | hadoop.hbase.replication.regionserver.TestRaceWhenCreatingReplicationSource | | | hadoop.hbase.replication.TestReplicationMetricsforUI | | | hadoop.hbase.client.TestTableFavoredNodes | | | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL | | | hadoop.hbase.quotas.TestSuperUserQuotaPermissions | | | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.master.assignment.TestSplitTableRegionProcedure | | | hadoop.hbase.io.asyncfs.TestSaslFanOutOneBlockAsyncDFSOutput | | | hadoop.hbase.master.TestClusterRestartSplitWithoutZk | | | hadoop.hbase.regionserver.TestRegionServerMetrics | | | hadoop.hbase.wal.TestWALOpenAfterDNRollingStart | | | hadoop.hbase.replication.TestReplicationSyncUpTool | | | hadoop.hbase.coprocessor.TestRegionObserverInterface | | | hadoop.hbase.master.replication.TestModifyPeerProcedureRetryBackoff | | | hadoop.hbase.master.procedure.TestSCPWithoutZKCoordinated | | | hadoop.hbase.client.TestAsyncNonMetaRegionLocatorConcurrenyLimit | | | hadoop.hbase.quotas.TestMasterQuotasObserver | | | hadoop.hbase.TestHBaseOnOtherDfsCluster | | | hadoop.hbase.master.snapshot.TestSnapshotWhileRSCrashes | | | hadoop.hbase.io.encoding.TestChangingEncoding | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes | | | hadoop.hbase.replication.TestReplicationEmptyWALRecovery | | | hadoop.hbase.replication.TestReplicationChangingPeerRegionservers | | | hadoop.hbase.master.procedure.TestDeleteTableProcedure | | | hadoop.hbase.replication.TestReplicationWithTags | | | hadoop.hbase.quotas.TestSnapshotQuotaObserverChore | | | hadoop.hbase.regionserver.TestMultiLogThreshold | | | hadoop.hbase.client.TestAsyncTableGetMultiThreaded | | | hadoop.hbase.regionserver.TestDeleteMobTable | | | hadoop.hbase.fs.TestBlockReorderBlockLocation | | | hadoop.hbase.client.TestMetaWithReplicas | | | hadoop.hbase.TestGlobalMemStoreSize | | | hadoop.hbase.client.TestReplicaWithCluster | | | hadoop.hbase.coprocessor.TestPassCustomCellViaRegionObserver | | | hadoop.hbase.TestMetaTableAccessor | | | hadoop.hbase.regionserver.TestIsDeleteFailure | | | hadoop.hbase.master.
[GitHub] [hbase] Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation
Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation URL: https://github.com/apache/hbase/pull/478#issuecomment-521585001 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 185 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 40 | Maven dependency ordering for branch | | +1 | mvninstall | 366 | master passed | | +1 | compile | 82 | master passed | | +1 | checkstyle | 108 | master passed | | +1 | shadedjars | 314 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 58 | master passed | | 0 | spotbugs | 241 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 306 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 354 | the patch passed | | +1 | compile | 89 | the patch passed | | +1 | javac | 89 | the patch passed | | +1 | checkstyle | 108 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 286 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1018 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 57 | the patch passed | | +1 | findbugs | 342 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 102 | hbase-client in the patch passed. | | -1 | unit | 18271 | hbase-server in the patch failed. | | +1 | asflicense | 79 | The patch does not generate ASF License warnings. | | | | 22583 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.snapshot.TestFlushSnapshotFromClient | | | hadoop.hbase.client.TestAdmin1 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/12/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/478 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux acf7b11af60f 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-478/out/precommit/personality/provided.sh | | git revision | master / 8ffc45ab8b | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/12/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/12/testReport/ | | Max. process+thread count | 5015 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/12/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #483: HBASE-22841 Add more factory functions to TimeRange
Apache-HBase commented on issue #483: HBASE-22841 Add more factory functions to TimeRange URL: https://github.com/apache/hbase/pull/483#issuecomment-521587783 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 68 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 39 | Maven dependency ordering for branch | | +1 | mvninstall | 315 | master passed | | +1 | compile | 74 | master passed | | +1 | checkstyle | 97 | master passed | | +1 | shadedjars | 266 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 52 | master passed | | 0 | spotbugs | 238 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 288 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 288 | the patch passed | | +1 | compile | 72 | the patch passed | | +1 | javac | 72 | the patch passed | | +1 | checkstyle | 96 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 260 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 936 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 66 | the patch passed | | +1 | findbugs | 327 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 182 | hbase-common in the patch passed. | | -1 | unit | 20117 | hbase-server in the patch failed. | | +1 | asflicense | 61 | The patch does not generate ASF License warnings. | | | | 24025 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.tool.TestBulkLoadHFiles | | | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.snapshot.TestFlushSnapshotFromClient | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/483 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d2cd50ba05d4 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-483/out/precommit/personality/provided.sh | | git revision | master / 8ffc45ab8b | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/9/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/9/testReport/ | | Max. process+thread count | 5034 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/9/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #495: HBASE-22857 Fix the failed ut TestHRegion and TestHRegionWithInMemoryFlush
Apache-HBase commented on issue #495: HBASE-22857 Fix the failed ut TestHRegion and TestHRegionWithInMemoryFlush URL: https://github.com/apache/hbase/pull/495#issuecomment-521588932 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 79 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ branch-2.2 Compile Tests _ | | +1 | mvninstall | 454 | branch-2.2 passed | | +1 | compile | 62 | branch-2.2 passed | | +1 | checkstyle | 95 | branch-2.2 passed | | +1 | shadedjars | 300 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 41 | branch-2.2 passed | | 0 | spotbugs | 237 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 233 | branch-2.2 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 373 | the patch passed | | +1 | compile | 67 | the patch passed | | +1 | javac | 67 | the patch passed | | +1 | checkstyle | 96 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 315 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1198 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 36 | the patch passed | | +1 | findbugs | 228 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 17691 | hbase-server in the patch failed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 21797 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-495/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/495 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 51ee83b3fb2e 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-495/out/precommit/personality/provided.sh | | git revision | branch-2.2 / b4734e7667 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-495/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-495/3/testReport/ | | Max. process+thread count | 5041 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-495/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-521591301 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 58 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 1 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 39 | Maven dependency ordering for branch | | +1 | mvninstall | 434 | master passed | | +1 | compile | 121 | master passed | | +1 | checkstyle | 142 | master passed | | +1 | shadedjars | 341 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 87 | master passed | | 0 | spotbugs | 308 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 413 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 370 | the patch passed | | +1 | compile | 124 | the patch passed | | +1 | javac | 124 | the patch passed | | -1 | checkstyle | 90 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 335 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1159 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 83 | the patch passed | | -1 | findbugs | 65 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 195 | hbase-common in the patch passed. | | -1 | unit | 17706 | hbase-server in the patch failed. | | +1 | unit | 632 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 89 | The patch does not generate ASF License warnings. | | | | 23403 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Failed junit tests | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.master.TestMasterOperationsForRegionReplicas | | | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/46/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 4a2d33cdb264 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / 8ffc45ab8b | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/46/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/46/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/46/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/46/testReport/ | | Max. process+thread count | 4858 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/46/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22631) assign failed may make gced parent region appear again !!!
[
https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907977#comment-16907977
]
Wellington Chevreuil commented on HBASE-22631:
--
Hi [~yu-huiyang], thanks for reviewing on this. I still think the cause is more
likely to be some meta inconsistency, had shared some thoughts below:
{quote}But server tempt20 also contains the region in serverMap when
unassignedprocedure(pid=3) finished . Because tempt20 tried to open this region
in pid=1 and serverMap failed to remove this region from tempt20 according to
serverMap.
{quote}
That's not my understanding. Here's a short code walkthrough:
* Once the AP for this region on tempt20 failed, it will go through
_AssignProcedure.handleFailure_.
* There, it calls _AssignmentManager.undeRegionAsOpening_, which effectively
removes the region from this Server entry in _serverMap_ by calling
_RegionStates.removeFromRegionServer_. [Here the specific point where the
region gets removed from
_serverMap_|https://github.com/apache/hbase/blob/branch-2.1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java#L1168].
Would you think this scenario had deviated from the flow I had described above
(have you seen any log errors suggesting the AP failed to handle the assignment
failure)? I may try later to write a UT to simulate this condition.
> assign failed may make gced parent region appear again !!!
> --
>
> Key: HBASE-22631
> URL: https://issues.apache.org/jira/browse/HBASE-22631
> Project: HBase
> Issue Type: Bug
> Components: proc-v2
>Affects Versions: 2.1.1
>Reporter: yuhuiyang
>Priority: Major
> Attachments: HBASE-22631-branch-2.1-01.patch, assign.png,
> assignProcedure.txt, serverCrash.png, splitAndGc.png
>
>
> When i assign a region A the process is as follows：
> step1 : A is assigned to rs1 , and rs1 fails to open it .
> step2 : assignProcedure handleFailure .
> step3 : A is assign to rs2 and rs success to open it .
> Above is the normal flow . However when rs1 is restart after the reigon A was
> split and GCRegionProcedure was successed , the region A appare again !
> The region is that reigon A is not removed from the serverMap correctly when
> assignprocedure handleFailure . Because the code regionNode.offline() make
> the regionNode's regionLocation to be null and make regionNode's state to
> OFFLINE . So when the code
> env.getAssignmentManager().undoRegionAsOpening(regionNode) do nothing . So
> when the rs1 restart event triggers a serverCrashProcedure, it will get
> reigons from serverMap and it will get the region A then A will be assigned
> and hdfs dir will be created.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] wchevreuil closed pull request #456: HBASE-22631 assign failed may make gced parent region appear again
wchevreuil closed pull request #456: HBASE-22631 assign failed may make gced parent region appear again URL: https://github.com/apache/hbase/pull/456 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] wchevreuil commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again
wchevreuil commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again URL: https://github.com/apache/hbase/pull/456#issuecomment-521592427 The proposed change is quite simple, and we are not sure yet the problem is a new unsolved issue. To avoid confusion and forked discussions, am closing this PR for now. Let's keep discussing it on the jira only, for now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment
Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment URL: https://github.com/apache/hbase/pull/439#issuecomment-521593173 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 63 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 449 | master passed | | +1 | compile | 123 | master passed | | +1 | checkstyle | 132 | master passed | | +1 | shadedjars | 316 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 35 | master passed | | 0 | spotbugs | 261 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 256 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 358 | the patch passed | | +1 | compile | 129 | the patch passed | | +1 | javac | 129 | the patch passed | | +1 | checkstyle | 98 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 527 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1072 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 38 | the patch passed | | +1 | findbugs | 270 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 19656 | hbase-server in the patch failed. | | +1 | asflicense | 59 | The patch does not generate ASF License warnings. | | | | 24035 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleAsyncWAL | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.snapshot.TestFlushSnapshotFromClient | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.client.TestAsyncRegionAdminApi2 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/52/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/439 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 55272e007a94 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-439/out/precommit/personality/provided.sh | | git revision | master / 8ffc45ab8b | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/52/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/52/testReport/ | | Max. process+thread count | 5095 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/52/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop
Apache-HBase commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-521593161 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 251 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 2 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 22 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 39 | Maven dependency ordering for branch | | +1 | mvninstall | 381 | master passed | | +1 | compile | 203 | master passed | | +1 | checkstyle | 192 | master passed | | +1 | shadedjars | 323 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 199 | master passed | | 0 | spotbugs | 30 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 30 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 364 | the patch passed | | +1 | compile | 208 | the patch passed | | +1 | javac | 208 | the patch passed | | +1 | checkstyle | 174 | the patch passed | | +1 | shellcheck | 1 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 6 | The patch has no ill-formed XML file. | | +1 | shadedjars | 299 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1094 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 218 | the patch passed | | 0 | findbugs | 32 | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | -1 | unit | 17760 | root in the patch failed. | | +1 | asflicense | 121 | The patch does not generate ASF License warnings. | | | | 24413 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure | | | hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure | | | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.namespace.TestNamespaceAuditor | | | hadoop.hbase.TestClusterPortAssignment | | | hadoop.hbase.mob.compactions.TestMobCompactor | | | hadoop.hbase.snapshot.TestFlushSnapshotFromClient | | | hadoop.hbase.TestRegionRebalancing | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/15/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/476 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux 5e3de852aa7b 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-476/out/precommit/personality/provided.sh | | git revision | master / 8ffc45ab8b | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/15/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/15/testReport/ | | Max. process+thread count | 4858 (vs. ulimit of 1) | | modules | C: hbase-hbtop . hbase-assembly U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/15/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22856) HBASE-Find-Flaky-Tests fails with pip error
[
https://issues.apache.org/jira/browse/HBASE-22856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907987#comment-16907987
]
Hudson commented on HBASE-22856:
Results for branch branch-1
[build #1009 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1009/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1009//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1009//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1009//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> HBASE-Find-Flaky-Tests fails with pip error
> ---
>
> Key: HBASE-22856
> URL: https://issues.apache.org/jira/browse/HBASE-22856
> Project: HBase
> Issue Type: Bug
> Components: build, test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22856.patch
>
>
> {noformat}
> 09:59:16 Downloading/unpacking future (from -r
> /hbase/dev-support/python-requirements.txt (line 19))
> 09:59:16Running setup.py (path:/tmp/pip_build_root/future/setup.py)
> egg_info for package future
> 09:59:16 /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown
> distribution option: 'python_requires'
> 09:59:16warnings.warn(msg)
> 09:59:16
> 09:59:16 warning: no files found matching '*.au' under directory 'tests'
> 09:59:16 warning: no files found matching '*.gif' under directory 'tests'
> 09:59:16 warning: no files found matching '*.txt' under directory 'tests'
> 09:59:16 Downloading/unpacking gitpython (from -r
> /hbase/dev-support/python-requirements.txt (line 20))
> 09:59:16Running setup.py (path:/tmp/pip_build_root/gitpython/setup.py)
> egg_info for package gitpython
> 09:59:16 /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown
> distribution option: 'python_requires'
> 09:59:16warnings.warn(msg)
> 09:59:16 error in GitPython setup command: 'install_requires' must be a
> string or list of strings containing valid project/version requirement
> specifiers
> 09:59:16 Complete output from command python setup.py egg_info:
> 09:59:16 /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown
> distribution option: 'python_requires'
> 09:59:16
> 09:59:16warnings.warn(msg)
> 09:59:16
> 09:59:16 error in GitPython setup command: 'install_requires' must be a
> string or list of strings containing valid project/version requirement
> specifiers
> 09:59:16
> 09:59:16
> 09:59:16 Cleaning up...
> 09:59:16 Command python setup.py egg_info failed with error code 1 in
> /tmp/pip_build_root/gitpython
> 09:59:16 Storing debug log for failure in /root/.pip/pip.log
> 09:59:17 The command '/bin/sh -c apt-get -y update && apt-get -y install
> curl python-pip && pip install -r
> /hbase/dev-support/python-requirements.txt' returned a non-zero code: 1
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22810) Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
[
https://issues.apache.org/jira/browse/HBASE-22810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907988#comment-16907988
]
Hudson commented on HBASE-22810:
Results for branch branch-1
[build #1009 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1009/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1009//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1009//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1009//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
>
>
> Key: HBASE-22810
> URL: https://issues.apache.org/jira/browse/HBASE-22810
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> In EventType class, we have the following definition, means taking snapshot
> & restoring snapshot are use the MASTER_TABLE_OPERATIONS Executor now.
> {code}
> /**
>* Messages originating from Client to Master.
>* C_M_SNAPSHOT_TABLE
>* Client asking Master to snapshot an offline table.
>*/
> C_M_SNAPSHOT_TABLE(48, ExecutorType.MASTER_TABLE_OPERATIONS),
> /**
>* Messages originating from Client to Master.
>* C_M_RESTORE_SNAPSHOT
>* Client asking Master to restore a snapshot.
>*/
> C_M_RESTORE_SNAPSHOT (49, ExecutorType.MASTER_TABLE_OPERATIONS),
> {code}
> But when I checked the MASTER_TABLE_OPERATIONS thread pool initialization, I
> see :
> {code}
> private void startServiceThreads() throws IOException{
>// ... some other code initializing
>// We depend on there being only one instance of this executor running
>// at a time. To do concurrency, would need fencing of enable/disable of
>// tables.
>// Any time changing this maxThreads to > 1, pls see the comment at
>// AccessController#postCompletedCreateTableAction
>
> this.executorService.startExecutorService(ExecutorType.MASTER_TABLE_OPERATIONS,
> 1);
>startProcedureExecutor();
> {code}
> That's to say, for CPs enable or disable table sequencely, we will create
> a ThreadPoolExecutor with threadPoolSize=1. Then we actually cann't
> accomplish the snapshoting concurrence even if they are total difference
> tables, says if there are two table snapshoting request, and the Table A cost
> 5min for snapshoting, then the Table B need to wait 5min and once Table A
> finish its snapshot , then Table B will start the snapshot.
> While we've setting the snapshot timeout, so it will be easy to timeout for
> table B snapshoting . Actually, we can create a separate thead pool for
> snapshot operations only.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22728) Upgrade jackson dependencies in branch-1
[
https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907926#comment-16907926
]
Viraj Jasani edited comment on HBASE-22728 at 8/15/19 10:49 AM:
Just a small summary so far:
* Replaced all vulnerable mapper dependency(jackson-mapper-asl) with Jackson2
mapper(jackson-databind) in all modules.
* Included Jackson2 at compile scope in hbase-rest.
* hbase-shell requires dependency of jackson-core-asl. To tackle this, we
might need to upgrade JRuby eventually. For now, it's fine to include
jackson-core-asl(not vulnerable).
* Since HBase branch-1 no longer needs jackson-mapper-asl(as per #1), we can
live without it, but once we generate tar and extract it, we get these warnings
since Hadoop requires this dependency:
{code:java}
2019-08-13 16:32:34,147 WARN [main] fs.FileSystem: Cannot load filesystem:
java.util.ServiceConfigurationError: org.apache.hadoop.fs.FileSystem: Provider
org.apache.hadoop.hdfs.web.WebHdfsFileSystem could not be instantiated
2019-08-13 16:32:34,147 WARN [main] fs.FileSystem:
java.lang.NoClassDefFoundError: org/codehaus/jackson/map/ObjectMapper{code}
* Without including jackson-mapper-asl / Jackson2 dependencies as 'compile'
scope in hbase-common, we are not getting corresponding jars in lib folder of
extracted tarball. Need to resolve this issue since we should not include
jackson-mapper-asl with 'compile' scope in hbase-common/hbase-client/dependent
hbase-* of client.
was (Author: vjasani):
Just a small summary so far:
# Replaced all vulnerable mapper dependency(jackson-mapper-asl) with Jackson2
mapper(jackson-databind) in all modules.
# Included Jackson2 at compile scope in hbase-rest.
# hbase-shell requires dependency of jackson-core-asl. To tackle this, we
might need to upgrade JRuby eventually. For now, it's fine to include
jackson-core-asl(not vulnerable).
# Since HBase code no longer needs jackson-mapper-asl( #1), we can live
without it, but once we generate tar and extract it, we get these warnings
since Hadoop requires this dependency:
{code:java}
2019-08-13 16:32:34,147 WARN [main] fs.FileSystem: Cannot load filesystem:
java.util.ServiceConfigurationError: org.apache.hadoop.fs.FileSystem: Provider
org.apache.hadoop.hdfs.web.WebHdfsFileSystem could not be instantiated
2019-08-13 16:32:34,147 WARN [main] fs.FileSystem:
java.lang.NoClassDefFoundError: org/codehaus/jackson/map/ObjectMapper{code}
# Without including jackson-mapper-asl / Jackson2 dependencies as 'compile'
scope in hbase-common, we are not getting corresponding jars in lib folder of
extracted tarball. Need to resolve this issue since we should not include
jackson-mapper-asl with 'compile' scope in hbase-common/hbase-client/dependent
hbase-* of client.
> Upgrade jackson dependencies in branch-1
>
>
> Key: HBASE-22728
> URL: https://issues.apache.org/jira/browse/HBASE-22728
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 1.4.10, 1.3.5
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch,
> HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch,
> HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch,
> HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch,
> HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch,
> HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch,
> HBASE-22728.branch-1.18.patch
>
>
> Avoid Jackson versions and dependencies with known CVEs
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22728: - Attachment: HBASE-22728.branch-1.19.patch > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch, > HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch, > HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch, > HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch, > HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch, > HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch, > HBASE-22728.branch-1.18.patch, HBASE-22728.branch-1.19.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908020#comment-16908020 ] Viraj Jasani commented on HBASE-22728: -- Ok so we need to upgrade maven assembly plugin too :) With older version, jars not included at 'compile' scope in hbase-common are not getting included in tarball with assembly:single goal. > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch, > HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch, > HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch, > HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch, > HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch, > HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch, > HBASE-22728.branch-1.18.patch, HBASE-22728.branch-1.19.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22810) Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
[
https://issues.apache.org/jira/browse/HBASE-22810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908058#comment-16908058
]
Hudson commented on HBASE-22810:
Results for branch master
[build #1335 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1335/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1335//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1335//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1335//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
>
>
> Key: HBASE-22810
> URL: https://issues.apache.org/jira/browse/HBASE-22810
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> In EventType class, we have the following definition, means taking snapshot
> & restoring snapshot are use the MASTER_TABLE_OPERATIONS Executor now.
> {code}
> /**
>* Messages originating from Client to Master.
>* C_M_SNAPSHOT_TABLE
>* Client asking Master to snapshot an offline table.
>*/
> C_M_SNAPSHOT_TABLE(48, ExecutorType.MASTER_TABLE_OPERATIONS),
> /**
>* Messages originating from Client to Master.
>* C_M_RESTORE_SNAPSHOT
>* Client asking Master to restore a snapshot.
>*/
> C_M_RESTORE_SNAPSHOT (49, ExecutorType.MASTER_TABLE_OPERATIONS),
> {code}
> But when I checked the MASTER_TABLE_OPERATIONS thread pool initialization, I
> see :
> {code}
> private void startServiceThreads() throws IOException{
>// ... some other code initializing
>// We depend on there being only one instance of this executor running
>// at a time. To do concurrency, would need fencing of enable/disable of
>// tables.
>// Any time changing this maxThreads to > 1, pls see the comment at
>// AccessController#postCompletedCreateTableAction
>
> this.executorService.startExecutorService(ExecutorType.MASTER_TABLE_OPERATIONS,
> 1);
>startProcedureExecutor();
> {code}
> That's to say, for CPs enable or disable table sequencely, we will create
> a ThreadPoolExecutor with threadPoolSize=1. Then we actually cann't
> accomplish the snapshoting concurrence even if they are total difference
> tables, says if there are two table snapshoting request, and the Table A cost
> 5min for snapshoting, then the Table B need to wait 5min and once Table A
> finish its snapshot , then Table B will start the snapshot.
> While we've setting the snapshot timeout, so it will be easy to timeout for
> table B snapshoting . Actually, we can create a separate thead pool for
> snapshot operations only.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#issuecomment-521641657 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 120 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 45 | Maven dependency ordering for branch | | +1 | mvninstall | 430 | master passed | | +1 | compile | 97 | master passed | | +1 | checkstyle | 126 | master passed | | +1 | shadedjars | 341 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 68 | master passed | | 0 | spotbugs | 309 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 362 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 383 | the patch passed | | +1 | compile | 97 | the patch passed | | +1 | javac | 97 | the patch passed | | -1 | checkstyle | 31 | hbase-common: The patch generated 2 new + 48 unchanged - 2 fixed = 50 total (was 50) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 348 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1178 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 67 | the patch passed | | +1 | findbugs | 320 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 192 | hbase-common in the patch passed. | | -1 | unit | 14432 | hbase-server in the patch failed. | | +1 | asflicense | 46 | The patch does not generate ASF License warnings. | | | | 19294 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestRegionReplicaFailover | | | hadoop.hbase.master.TestMasterShutdown | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/13/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/479 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 392c5b2669a5 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-479/out/precommit/personality/provided.sh | | git revision | master / 8ffc45ab8b | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/13/artifact/out/diff-checkstyle-hbase-common.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/13/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/13/testReport/ | | Max. process+thread count | 4953 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/13/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22855) Find the root cause why still using the old hbase:meta location after meta region moving.
[ https://issues.apache.org/jira/browse/HBASE-22855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908073#comment-16908073 ] jianghua zhu commented on HBASE-22855: -- There is one possibility: Assuming that HMaster, HRegionServer1, and HRegionServer2 exist, the following processes occur. 1.HMaster sends a request to HRegionServer1 via RPC via the assign mechanism to load the Region information corresponding to hbase:meta. 2. The HRegionServer itself, for some reason, failed to report state to HMaster, and HMaster assumed that the HRegionServer was dead. 3.HMaster makes a request to HRegionServer2 via the assign mechanism to load the Region information corresponding to hbase:meta. And the HRegionServer2 loads quickly. 4. Retrieve the location of the hbase:meta at HRegionServer2 > Find the root cause why still using the old hbase:meta location after meta > region moving. > - > > Key: HBASE-22855 > URL: https://issues.apache.org/jira/browse/HBASE-22855 > Project: HBase > Issue Type: Bug >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > > In HBASE-214644, [~andrew.purt...@gmail.com] had a nice fix about the using > the stale hbase:meta location, say update the hbase:meta location > periodically.Also someone in user list also encountered this bug in > HBASE1.4.9 [1]. > [~wenbang] from DiDi also have a question about the root cause under > HBASE-214644 [2]. > I think we need to find out the root cause and fix it ? > [1]. > https://mail-archives.apache.org/mod_mbox/hbase-user/201908.mbox/%3C114F31E6-B7F9-4209-AAE3-32A022729593%40gmail.com%3E > [2]. > https://issues.apache.org/jira/browse/HBASE-21464?focusedCommentId=16902808&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16902808 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22855) Find the root cause why still using the old hbase:meta location after meta region moving.
[ https://issues.apache.org/jira/browse/HBASE-22855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908073#comment-16908073 ] jianghua zhu edited comment on HBASE-22855 at 8/15/19 1:36 PM: --- There is a possibility: If there are HMaster, HRegion Server 1, HRegion Server 2, the following process occurs. 1. HMaster sends requests to HRegionServer1 through RPC through assignment mechanism, and loads the region information corresponding to hbase: meta. 2. For some reason, HRegion Server itself did not report its status to HMaster. HMaster believed that HRegion Server had died at this time. 3. HMaster requests HRegionServer2 through assignment mechanism and loads the region information corresponding to hbase: meta. And HRegionServer2 loads quickly. 4. At this time, the location of hbase: meta is located at the HRegionServer2 node. 5. At this point, HRegionServer1 itself restores, reloads hbase: meta, and completes. At this point, the location of hbase: meta changes. was (Author: jianghuazhu): There is one possibility: Assuming that HMaster, HRegionServer1, and HRegionServer2 exist, the following processes occur. 1.HMaster sends a request to HRegionServer1 via RPC via the assign mechanism to load the Region information corresponding to hbase:meta. 2. The HRegionServer itself, for some reason, failed to report state to HMaster, and HMaster assumed that the HRegionServer was dead. 3.HMaster makes a request to HRegionServer2 via the assign mechanism to load the Region information corresponding to hbase:meta. And the HRegionServer2 loads quickly. 4. Retrieve the location of the hbase:meta at HRegionServer2 > Find the root cause why still using the old hbase:meta location after meta > region moving. > - > > Key: HBASE-22855 > URL: https://issues.apache.org/jira/browse/HBASE-22855 > Project: HBase > Issue Type: Bug >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > > In HBASE-214644, [~andrew.purt...@gmail.com] had a nice fix about the using > the stale hbase:meta location, say update the hbase:meta location > periodically.Also someone in user list also encountered this bug in > HBASE1.4.9 [1]. > [~wenbang] from DiDi also have a question about the root cause under > HBASE-214644 [2]. > I think we need to find out the root cause and fix it ? > [1]. > https://mail-archives.apache.org/mod_mbox/hbase-user/201908.mbox/%3C114F31E6-B7F9-4209-AAE3-32A022729593%40gmail.com%3E > [2]. > https://issues.apache.org/jira/browse/HBASE-21464?focusedCommentId=16902808&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16902808 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] titsuki commented on a change in pull request #493: HBASE-22833 MultiRowRangeFilter should provide a method for creating…
titsuki commented on a change in pull request #493: HBASE-22833
MultiRowRangeFilter should provide a method for creating…
URL: https://github.com/apache/hbase/pull/493#discussion_r314328812
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultiRowRangeFilter.java
##
@@ -71,6 +72,22 @@ public MultiRowRangeFilter(List list) {
this.ranges = new RangeIteration(rangeList);
}
+ /**
+ * @param rowKeyPrefixes the array of byte array
+ */
+ public MultiRowRangeFilter(byte[][] rowKeyPrefixes) {
+this(createRangeListFromRowKeyPrefixes(rowKeyPrefixes));
+ }
+
+ private static List createRangeListFromRowKeyPrefixes(byte[][]
rowKeyPrefixes) {
+List list = new ArrayList<>();
+for (byte[] rowKeyPrefix: rowKeyPrefixes) {
Review comment:
OK, I added null check.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] titsuki commented on a change in pull request #493: HBASE-22833 MultiRowRangeFilter should provide a method for creating…
titsuki commented on a change in pull request #493: HBASE-22833
MultiRowRangeFilter should provide a method for creating…
URL: https://github.com/apache/hbase/pull/493#discussion_r314329675
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultiRowRangeFilter.java
##
@@ -71,6 +72,22 @@ public MultiRowRangeFilter(List list) {
this.ranges = new RangeIteration(rangeList);
}
+ /**
+ * @param rowKeyPrefixes the array of byte array
Review comment:
OK, I added explanation for this constructor.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1
[
https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908143#comment-16908143
]
Sean Busbey commented on HBASE-22728:
-
{quote}
Ok so we need to upgrade maven assembly plugin too
With older version, jars not included at 'compile' scope in hbase-common are
not getting included in tarball with assembly:single goal.
{quote}
this is surprising. Can we not just include the needed library as a dependency
of the hbase-assembly module?
> Upgrade jackson dependencies in branch-1
>
>
> Key: HBASE-22728
> URL: https://issues.apache.org/jira/browse/HBASE-22728
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 1.4.10, 1.3.5
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch,
> HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch,
> HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch,
> HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch,
> HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch,
> HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch,
> HBASE-22728.branch-1.18.patch, HBASE-22728.branch-1.19.patch
>
>
> Avoid Jackson versions and dependencies with known CVEs
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1
[
https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908146#comment-16908146
]
Viraj Jasani commented on HBASE-22728:
--
{quote}this is surprising. Can we not just include the needed library as a
dependency of the hbase-assembly module?
{quote}
So far, this was not happening but after upgrading assembly plugin from 2.5 to
3.1.1, now we can include the needed lib as hbase-assembly dependency.
> Upgrade jackson dependencies in branch-1
>
>
> Key: HBASE-22728
> URL: https://issues.apache.org/jira/browse/HBASE-22728
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 1.4.10, 1.3.5
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch,
> HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch,
> HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch,
> HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch,
> HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch,
> HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch,
> HBASE-22728.branch-1.18.patch, HBASE-22728.branch-1.19.patch
>
>
> Avoid Jackson versions and dependencies with known CVEs
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose
[
https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908147#comment-16908147
]
Hudson commented on HBASE-21879:
Results for branch HBASE-21879
[build #209 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/209/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/209//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/209//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/209//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Read HFile's block to ByteBuffer directly instead of to byte for reducing
> young gc purpose
> --
>
> Key: HBASE-21879
> URL: https://issues.apache.org/jira/browse/HBASE-21879
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-21879.v1.patch, HBASE-21879.v1.patch,
> QPS-latencies-before-HBASE-21879.png, gc-data-before-HBASE-21879.png
>
>
> In HFileBlock#readBlockDataInternal, we have the following:
> {code}
> @VisibleForTesting
> protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset,
> long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum,
> boolean updateMetrics)
> throws IOException {
> // .
> // TODO: Make this ByteBuffer-based. Will make it easier to go to HDFS with
> BBPool (offheap).
> byte [] onDiskBlock = new byte[onDiskSizeWithHeader + hdrSize];
> int nextBlockOnDiskSize = readAtOffset(is, onDiskBlock, preReadHeaderSize,
> onDiskSizeWithHeader - preReadHeaderSize, true, offset +
> preReadHeaderSize, pread);
> if (headerBuf != null) {
> // ...
> }
> // ...
> }
> {code}
> In the read path, we still read the block from hfile to on-heap byte[], then
> copy the on-heap byte[] to offheap bucket cache asynchronously, and in my
> 100% get performance test, I also observed some frequent young gc, The
> largest memory footprint in the young gen should be the on-heap block byte[].
> In fact, we can read HFile's block to ByteBuffer directly instead of to
> byte[] for reducing young gc purpose. we did not implement this before,
> because no ByteBuffer reading interface in the older HDFS client, but 2.7+
> has supported this now, so we can fix this now. I think.
> Will provide an patch and some perf-comparison for this.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (HBASE-22861) [WAL] Merged region should get its WAL according to WALProvider.
Reid Chan created HBASE-22861:
-
Summary: [WAL] Merged region should get its WAL according to
WALProvider.
Key: HBASE-22861
URL: https://issues.apache.org/jira/browse/HBASE-22861
Project: HBase
Issue Type: Bug
Reporter: Reid Chan
This one is similar to HBASE-22774.
Merging regions works fine by default because all regions shared one wal. But
if multiwal is enabled, merged region should get its wal according to strategy.
{code:title=HRegion.java|borderStyle=solid}
HRegion createMergedRegionFromMerges(final HRegionInfo mergedRegionInfo,
final HRegion region_b) throws IOException {
HRegion r = HRegion.newHRegion(this.fs.getTableDir(),
this.getWAL(), // Here should use rsService.getWAL(mergedRegionInfo),
then wal provider and strategy if there is will take effect.
fs.getFileSystem(), this.getBaseConf(), mergedRegionInfo,
this.getTableDesc(), this.rsServices);
...
return r;
}
{code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22861) [WAL] Merged region should get its WAL according to WALProvider.
[
https://issues.apache.org/jira/browse/HBASE-22861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908151#comment-16908151
]
Reid Chan commented on HBASE-22861:
---
It only affects branch-1.
Branch-2 and master work fine.
> [WAL] Merged region should get its WAL according to WALProvider.
>
>
> Key: HBASE-22861
> URL: https://issues.apache.org/jira/browse/HBASE-22861
> Project: HBase
> Issue Type: Bug
>Reporter: Reid Chan
>Priority: Major
>
> This one is similar to HBASE-22774.
> Merging regions works fine by default because all regions shared one wal. But
> if multiwal is enabled, merged region should get its wal according to
> strategy.
> {code:title=HRegion.java|borderStyle=solid}
> HRegion createMergedRegionFromMerges(final HRegionInfo mergedRegionInfo,
> final HRegion region_b) throws IOException {
> HRegion r = HRegion.newHRegion(this.fs.getTableDir(),
> this.getWAL(), // Here should use rsService.getWAL(mergedRegionInfo),
> then wal provider and strategy if there is will take effect.
> fs.getFileSystem(), this.getBaseConf(), mergedRegionInfo,
> this.getTableDesc(), this.rsServices);
> ...
> return r;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22861) [WAL] Merged region should get its WAL according to WALProvider.
[
https://issues.apache.org/jira/browse/HBASE-22861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reid Chan updated HBASE-22861:
--
Component/s: wal
> [WAL] Merged region should get its WAL according to WALProvider.
>
>
> Key: HBASE-22861
> URL: https://issues.apache.org/jira/browse/HBASE-22861
> Project: HBase
> Issue Type: Bug
> Components: wal
>Reporter: Reid Chan
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
>
> This one is similar to HBASE-22774.
> Merging regions works fine by default because all regions shared one wal. But
> if multiwal is enabled, merged region should get its wal according to
> strategy.
> {code:title=HRegion.java|borderStyle=solid}
> HRegion createMergedRegionFromMerges(final HRegionInfo mergedRegionInfo,
> final HRegion region_b) throws IOException {
> HRegion r = HRegion.newHRegion(this.fs.getTableDir(),
> this.getWAL(), // Here should use rsService.getWAL(mergedRegionInfo),
> then wal provider and strategy if there is will take effect.
> fs.getFileSystem(), this.getBaseConf(), mergedRegionInfo,
> this.getTableDesc(), this.rsServices);
> ...
> return r;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache9 opened a new pull request #498: HBASE-22819 Automatically migrate the rs group config for table after…
Apache9 opened a new pull request #498: HBASE-22819 Automatically migrate the rs group config for table after… URL: https://github.com/apache/hbase/pull/498 … HBASE-22695 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (HBASE-22861) [WAL] Merged region should get its WAL according to WALProvider.
[
https://issues.apache.org/jira/browse/HBASE-22861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reid Chan reassigned HBASE-22861:
-
Assignee: Reid Chan
> [WAL] Merged region should get its WAL according to WALProvider.
>
>
> Key: HBASE-22861
> URL: https://issues.apache.org/jira/browse/HBASE-22861
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 1.4.10, 1.3.5
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
>
> This one is similar to HBASE-22774.
> Merging regions works fine by default because all regions shared one wal. But
> if multiwal is enabled, merged region should get its wal according to
> strategy.
> {code:title=HRegion.java|borderStyle=solid}
> HRegion createMergedRegionFromMerges(final HRegionInfo mergedRegionInfo,
> final HRegion region_b) throws IOException {
> HRegion r = HRegion.newHRegion(this.fs.getTableDir(),
> this.getWAL(), // Here should use rsService.getWAL(mergedRegionInfo),
> then wal provider and strategy if there is will take effect.
> fs.getFileSystem(), this.getBaseConf(), mergedRegionInfo,
> this.getTableDesc(), this.rsServices);
> ...
> return r;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22861) [WAL] Merged region should get its WAL according to WALProvider.
[
https://issues.apache.org/jira/browse/HBASE-22861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reid Chan updated HBASE-22861:
--
Description:
This one is similar to HBASE-22774.
Merging regions works fine by default because all regions shared one wal. But
if multiwal is enabled, merged region should get its wal according to wal
grouping strategy.
{code:title=HRegion.java|borderStyle=solid}
HRegion createMergedRegionFromMerges(final HRegionInfo mergedRegionInfo,
final HRegion region_b) throws IOException {
HRegion r = HRegion.newHRegion(this.fs.getTableDir(),
this.getWAL(), // Here should use rsService.getWAL(mergedRegionInfo),
then wal provider and strategy if there is will take effect.
fs.getFileSystem(), this.getBaseConf(), mergedRegionInfo,
this.getTableDesc(), this.rsServices);
...
return r;
}
{code}
was:
This one is similar to HBASE-22774.
Merging regions works fine by default because all regions shared one wal. But
if multiwal is enabled, merged region should get its wal according to strategy.
{code:title=HRegion.java|borderStyle=solid}
HRegion createMergedRegionFromMerges(final HRegionInfo mergedRegionInfo,
final HRegion region_b) throws IOException {
HRegion r = HRegion.newHRegion(this.fs.getTableDir(),
this.getWAL(), // Here should use rsService.getWAL(mergedRegionInfo),
then wal provider and strategy if there is will take effect.
fs.getFileSystem(), this.getBaseConf(), mergedRegionInfo,
this.getTableDesc(), this.rsServices);
...
return r;
}
{code}
> [WAL] Merged region should get its WAL according to WALProvider.
>
>
> Key: HBASE-22861
> URL: https://issues.apache.org/jira/browse/HBASE-22861
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 1.4.10, 1.3.5
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
>
> This one is similar to HBASE-22774.
> Merging regions works fine by default because all regions shared one wal. But
> if multiwal is enabled, merged region should get its wal according to wal
> grouping strategy.
> {code:title=HRegion.java|borderStyle=solid}
> HRegion createMergedRegionFromMerges(final HRegionInfo mergedRegionInfo,
> final HRegion region_b) throws IOException {
> HRegion r = HRegion.newHRegion(this.fs.getTableDir(),
> this.getWAL(), // Here should use rsService.getWAL(mergedRegionInfo),
> then wal provider and strategy if there is will take effect.
> fs.getFileSystem(), this.getBaseConf(), mergedRegionInfo,
> this.getTableDesc(), this.rsServices);
> ...
> return r;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22861) [WAL] Merged region should get its WAL according to WALProvider.
[
https://issues.apache.org/jira/browse/HBASE-22861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reid Chan updated HBASE-22861:
--
Fix Version/s: 1.4.11
1.3.6
1.5.0
> [WAL] Merged region should get its WAL according to WALProvider.
>
>
> Key: HBASE-22861
> URL: https://issues.apache.org/jira/browse/HBASE-22861
> Project: HBase
> Issue Type: Bug
>Reporter: Reid Chan
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
>
> This one is similar to HBASE-22774.
> Merging regions works fine by default because all regions shared one wal. But
> if multiwal is enabled, merged region should get its wal according to
> strategy.
> {code:title=HRegion.java|borderStyle=solid}
> HRegion createMergedRegionFromMerges(final HRegionInfo mergedRegionInfo,
> final HRegion region_b) throws IOException {
> HRegion r = HRegion.newHRegion(this.fs.getTableDir(),
> this.getWAL(), // Here should use rsService.getWAL(mergedRegionInfo),
> then wal provider and strategy if there is will take effect.
> fs.getFileSystem(), this.getBaseConf(), mergedRegionInfo,
> this.getTableDesc(), this.rsServices);
> ...
> return r;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22861) [WAL] Merged region should get its WAL according to WALProvider.
[
https://issues.apache.org/jira/browse/HBASE-22861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reid Chan updated HBASE-22861:
--
Affects Version/s: 1.4.10
1.3.5
> [WAL] Merged region should get its WAL according to WALProvider.
>
>
> Key: HBASE-22861
> URL: https://issues.apache.org/jira/browse/HBASE-22861
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 1.4.10, 1.3.5
>Reporter: Reid Chan
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
>
> This one is similar to HBASE-22774.
> Merging regions works fine by default because all regions shared one wal. But
> if multiwal is enabled, merged region should get its wal according to
> strategy.
> {code:title=HRegion.java|borderStyle=solid}
> HRegion createMergedRegionFromMerges(final HRegionInfo mergedRegionInfo,
> final HRegion region_b) throws IOException {
> HRegion r = HRegion.newHRegion(this.fs.getTableDir(),
> this.getWAL(), // Here should use rsService.getWAL(mergedRegionInfo),
> then wal provider and strategy if there is will take effect.
> fs.getFileSystem(), this.getBaseConf(), mergedRegionInfo,
> this.getTableDesc(), this.rsServices);
> ...
> return r;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22860) Master's webui returns NPE/HTTP 500 under maintenance mode
[
https://issues.apache.org/jira/browse/HBASE-22860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daisuke Kobayashi updated HBASE-22860:
--
Status: Open (was: Patch Available)
> Master's webui returns NPE/HTTP 500 under maintenance mode
> --
>
> Key: HBASE-22860
> URL: https://issues.apache.org/jira/browse/HBASE-22860
> Project: HBase
> Issue Type: Bug
> Components: master, UI
>Reporter: Daisuke Kobayashi
>Assignee: Daisuke Kobayashi
>Priority: Major
> Attachments: HBASE-22860.master.001.patch, Screen Shot 2019-08-15 at
> 4.15.51 PM.png
>
>
> Master's webui is not accessible when {{hbase.master.maintenance_mode}} is
> set to true. This is because it's trying to load a coprocessor
> {{RSGroupAdminEndpoint}}.
> {code}
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmplImpl.renderNoFlush(MasterStatusTmplImpl.java:326)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.renderNoFlush(MasterStatusTmpl.java:397)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.render(MasterStatusTmpl.java:388)
> at
> org.apache.hadoop.hbase.master.MasterStatusServlet.doGet(MasterStatusServlet.java:81)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:848)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1780)
> at
> org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:112)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1374)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:583)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
> at
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548)
> at
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:513)
> at
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
> at
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
> at org.eclipse.jetty.server.Server.handle(Server.java:539)
> at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:333)
> at
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
> at
> org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:283)
> at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:108)
> at
> org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.executeProduceConsume(ExecuteProduceConsume.java:303)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceConsume(ExecuteProduceConsume.java:148)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.run(ExecuteProduceConsume.java:136)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:671)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:589)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22860) Master's webui returns NPE/HTTP 500 under maintenance mode
[
https://issues.apache.org/jira/browse/HBASE-22860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daisuke Kobayashi updated HBASE-22860:
--
Attachment: HBASE-22860.master.002.patch
Status: Patch Available (was: Open)
Yes, [~wchevreuil]. The issue exists in 2.1.5 and 2.2.0 releases. I've
confirmed the patch works on either releases. Uploading the second patch, which
updated the warning message.
> Master's webui returns NPE/HTTP 500 under maintenance mode
> --
>
> Key: HBASE-22860
> URL: https://issues.apache.org/jira/browse/HBASE-22860
> Project: HBase
> Issue Type: Bug
> Components: master, UI
>Reporter: Daisuke Kobayashi
>Assignee: Daisuke Kobayashi
>Priority: Major
> Attachments: HBASE-22860.master.001.patch,
> HBASE-22860.master.002.patch, Screen Shot 2019-08-15 at 4.15.51 PM.png
>
>
> Master's webui is not accessible when {{hbase.master.maintenance_mode}} is
> set to true. This is because it's trying to load a coprocessor
> {{RSGroupAdminEndpoint}}.
> {code}
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmplImpl.renderNoFlush(MasterStatusTmplImpl.java:326)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.renderNoFlush(MasterStatusTmpl.java:397)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.render(MasterStatusTmpl.java:388)
> at
> org.apache.hadoop.hbase.master.MasterStatusServlet.doGet(MasterStatusServlet.java:81)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:848)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1780)
> at
> org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:112)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1374)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:583)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
> at
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548)
> at
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:513)
> at
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
> at
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
> at org.eclipse.jetty.server.Server.handle(Server.java:539)
> at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:333)
> at
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
> at
> org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:283)
> at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:108)
> at
> org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.executeProduceConsume(ExecuteProduceConsume.java:303)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceConsume(ExecuteProduceConsume.java:148)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.run(ExecuteProduceConsume.java:136)
> at
> org.eclipse.jetty.util.thread.Q
[jira] [Comment Edited] (HBASE-22728) Upgrade jackson dependencies in branch-1
[
https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908146#comment-16908146
]
Viraj Jasani edited comment on HBASE-22728 at 8/15/19 3:02 PM:
---
{quote}this is surprising. Can we not just include the needed library as a
dependency of the hbase-assembly module?
{quote}
So far, this was not happening but after upgrading assembly plugin from 2.5 to
3.1.1, now we can include the needed lib as hbase-assembly dependency.
master branch has assembly plugin version 3.0.0
was (Author: vjasani):
{quote}this is surprising. Can we not just include the needed library as a
dependency of the hbase-assembly module?
{quote}
So far, this was not happening but after upgrading assembly plugin from 2.5 to
3.1.1, now we can include the needed lib as hbase-assembly dependency.
> Upgrade jackson dependencies in branch-1
>
>
> Key: HBASE-22728
> URL: https://issues.apache.org/jira/browse/HBASE-22728
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 1.4.10, 1.3.5
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch,
> HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch,
> HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch,
> HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch,
> HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch,
> HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch,
> HBASE-22728.branch-1.18.patch, HBASE-22728.branch-1.19.patch
>
>
> Avoid Jackson versions and dependencies with known CVEs
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] wchevreuil commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment
wchevreuil commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment URL: https://github.com/apache/hbase/pull/439#issuecomment-521678510 The intermittent failures are not really related. Latest changes look good. Let me rebase it locally, get a patch and submit it in the jira for a last round of pre-commit tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix
HBCK2 after HBASE-22777 & HBASE-22758
URL:
https://github.com/apache/hbase-operator-tools/pull/14#discussion_r314360671
##
File path:
hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBCKMetaTableAccessor.java
##
@@ -0,0 +1,134 @@
+package org.apache.hbase.hbck1;
+
+import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.CellUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.Delete;
+import org.apache.hadoop.hbase.client.Mutation;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * hbck's local version of the MetaTableAccessor from the hbase repo
+ */
+@InterfaceAudience.Private
+class HBCKMetaTableAccessor {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(HBCKMetaTableAccessor.class);
+ private static final Logger HBCKMETALOG =
LoggerFactory.getLogger("org.apache.hadoop.hbase.META");
+
+ public static List getMergeRegions(Cell[] cells) {
Review comment:
For methods only used by this class make them private. Especially over here
in HBCK2. They are only used by this class?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix
HBCK2 after HBASE-22777 & HBASE-22758
URL:
https://github.com/apache/hbase-operator-tools/pull/14#discussion_r314362073
##
File path:
hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBCKMetaTableAccessor.java
##
@@ -0,0 +1,134 @@
+package org.apache.hbase.hbck1;
+
+import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.CellUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.Delete;
+import org.apache.hadoop.hbase.client.Mutation;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * hbck's local version of the MetaTableAccessor from the hbase repo
+ */
+@InterfaceAudience.Private
+class HBCKMetaTableAccessor {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(HBCKMetaTableAccessor.class);
+ private static final Logger HBCKMETALOG =
LoggerFactory.getLogger("org.apache.hadoop.hbase.META");
+
+ public static List getMergeRegions(Cell[] cells) {
+if (cells == null) {
+ return null;
+}
+List regionsToMerge = null;
+for (Cell cell: cells) {
+ if (!isMergeQualifierPrefix(cell)) {
+continue;
+ }
+ // Ok. This cell is that of a info:merge* column.
+ RegionInfo ri = RegionInfo.parseFromOrNull(cell.getValueArray(),
cell.getValueOffset(),
+ cell.getValueLength());
+ if (ri != null) {
+if (regionsToMerge == null) {
+ regionsToMerge = new ArrayList<>();
+}
+regionsToMerge.add(ri);
+ }
+}
+return regionsToMerge;
+ }
+
+ private static boolean isMergeQualifierPrefix(Cell cell) {
+// Check to see if has family and that qualifier starts with the merge
qualifier 'merge'
+return CellUtil.matchingFamily(cell, HConstants.CATALOG_FAMILY) &&
+HBCKPrivateCellUtil.qualifierStartsWith(cell,
HBCKConstants.MERGE_QUALIFIER_PREFIX);
+ }
+
+ /**
+ * Returns the column family used for meta columns.
+ * @return HConstants.CATALOG_FAMILY.
+ */
+ public static byte[] getCatalogFamily() {
Review comment:
Keep private. Maybe remove. Its a bit silly... could just use constant.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix
HBCK2 after HBASE-22777 & HBASE-22758
URL:
https://github.com/apache/hbase-operator-tools/pull/14#discussion_r314366634
##
File path:
hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBCKMetaTableAccessor.java
##
@@ -0,0 +1,134 @@
+package org.apache.hbase.hbck1;
+
+import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.CellUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.Delete;
+import org.apache.hadoop.hbase.client.Mutation;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * hbck's local version of the MetaTableAccessor from the hbase repo
+ */
+@InterfaceAudience.Private
+class HBCKMetaTableAccessor {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(HBCKMetaTableAccessor.class);
+ private static final Logger HBCKMETALOG =
LoggerFactory.getLogger("org.apache.hadoop.hbase.META");
+
+ public static List getMergeRegions(Cell[] cells) {
+if (cells == null) {
+ return null;
+}
+List regionsToMerge = null;
+for (Cell cell: cells) {
+ if (!isMergeQualifierPrefix(cell)) {
+continue;
+ }
+ // Ok. This cell is that of a info:merge* column.
+ RegionInfo ri = RegionInfo.parseFromOrNull(cell.getValueArray(),
cell.getValueOffset(),
+ cell.getValueLength());
+ if (ri != null) {
+if (regionsToMerge == null) {
+ regionsToMerge = new ArrayList<>();
+}
+regionsToMerge.add(ri);
+ }
+}
+return regionsToMerge;
+ }
+
+ private static boolean isMergeQualifierPrefix(Cell cell) {
+// Check to see if has family and that qualifier starts with the merge
qualifier 'merge'
+return CellUtil.matchingFamily(cell, HConstants.CATALOG_FAMILY) &&
+HBCKPrivateCellUtil.qualifierStartsWith(cell,
HBCKConstants.MERGE_QUALIFIER_PREFIX);
+ }
+
+ /**
+ * Returns the column family used for meta columns.
+ * @return HConstants.CATALOG_FAMILY.
+ */
+ public static byte[] getCatalogFamily() {
+return HConstants.CATALOG_FAMILY;
+ }
+
+ /**
+ * Delete the passed d from the hbase:meta table.
+ * @param connection connection we're using
+ * @param d Delete to add to hbase:meta
+ */
+ private static void deleteFromMetaTable(final Connection connection, final
Delete d)
+ throws IOException {
+List dels = new ArrayList<>(1);
+dels.add(d);
+deleteFromMetaTable(connection, dels);
+ }
+
+ /**
+ * Callers should call close on the returned {@link Table} instance.
+ * @param connection connection we're using to access Meta
+ * @return An {@link Table} for hbase:meta
+ */
+ public static Table getMetaHTable(final Connection connection)
Review comment:
s/getMetaHTable/getMetaTable/ or just getTable since this is for accessing
one table only.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix
HBCK2 after HBASE-22777 & HBASE-22758
URL:
https://github.com/apache/hbase-operator-tools/pull/14#discussion_r314361280
##
File path:
hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBCKMetaTableAccessor.java
##
@@ -0,0 +1,134 @@
+package org.apache.hbase.hbck1;
+
+import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.CellUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.Delete;
+import org.apache.hadoop.hbase.client.Mutation;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * hbck's local version of the MetaTableAccessor from the hbase repo
+ */
+@InterfaceAudience.Private
+class HBCKMetaTableAccessor {
Review comment:
Ok. So this makes sense I think -- dup'ing the notion that there is one way
to go to meta from HBCK2. Good, you have it package private.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix
HBCK2 after HBASE-22777 & HBASE-22758
URL:
https://github.com/apache/hbase-operator-tools/pull/14#discussion_r314367085
##
File path:
hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBCKMetaTableAccessor.java
##
@@ -0,0 +1,134 @@
+package org.apache.hbase.hbck1;
+
+import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.CellUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.Delete;
+import org.apache.hadoop.hbase.client.Mutation;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * hbck's local version of the MetaTableAccessor from the hbase repo
+ */
+@InterfaceAudience.Private
+class HBCKMetaTableAccessor {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(HBCKMetaTableAccessor.class);
+ private static final Logger HBCKMETALOG =
LoggerFactory.getLogger("org.apache.hadoop.hbase.META");
+
+ public static List getMergeRegions(Cell[] cells) {
+if (cells == null) {
+ return null;
+}
+List regionsToMerge = null;
+for (Cell cell: cells) {
+ if (!isMergeQualifierPrefix(cell)) {
+continue;
+ }
+ // Ok. This cell is that of a info:merge* column.
+ RegionInfo ri = RegionInfo.parseFromOrNull(cell.getValueArray(),
cell.getValueOffset(),
+ cell.getValueLength());
+ if (ri != null) {
+if (regionsToMerge == null) {
+ regionsToMerge = new ArrayList<>();
+}
+regionsToMerge.add(ri);
+ }
+}
+return regionsToMerge;
+ }
+
+ private static boolean isMergeQualifierPrefix(Cell cell) {
+// Check to see if has family and that qualifier starts with the merge
qualifier 'merge'
+return CellUtil.matchingFamily(cell, HConstants.CATALOG_FAMILY) &&
+HBCKPrivateCellUtil.qualifierStartsWith(cell,
HBCKConstants.MERGE_QUALIFIER_PREFIX);
+ }
+
+ /**
+ * Returns the column family used for meta columns.
+ * @return HConstants.CATALOG_FAMILY.
+ */
+ public static byte[] getCatalogFamily() {
+return HConstants.CATALOG_FAMILY;
+ }
+
+ /**
+ * Delete the passed d from the hbase:meta table.
+ * @param connection connection we're using
+ * @param d Delete to add to hbase:meta
+ */
+ private static void deleteFromMetaTable(final Connection connection, final
Delete d)
+ throws IOException {
+List dels = new ArrayList<>(1);
+dels.add(d);
+deleteFromMetaTable(connection, dels);
+ }
+
+ /**
+ * Callers should call close on the returned {@link Table} instance.
+ * @param connection connection we're using to access Meta
+ * @return An {@link Table} for hbase:meta
+ */
+ public static Table getMetaHTable(final Connection connection)
+ throws IOException {
+// We used to pass whole CatalogTracker in here, now we just pass in
Connection
+if (connection == null) {
+ throw new NullPointerException("No connection");
+} else if (connection.isClosed()) {
+ throw new IOException("connection is closed");
+}
+return connection.getTable(TableName.META_TABLE_NAME);
+ }
+
+ private static void debugLogMutations(List mutations)
throws IOException {
+if (!HBCKMETALOG.isDebugEnabled()) {
+ return;
+}
+// Logging each mutation in separate line makes it easier to see diff
between them visually
+// because of common starting indentation.
+for (Mutation mutation : mutations) {
+ debugLogMutation(mutation);
+}
+ }
+
+ private static void debugLogMutation(Mutation p) throws IOException {
Review comment:
Whats this about? We need it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix
HBCK2 after HBASE-22777 & HBASE-22758
URL:
https://github.com/apache/hbase-operator-tools/pull/14#discussion_r314366355
##
File path:
hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBCKMetaTableAccessor.java
##
@@ -0,0 +1,134 @@
+package org.apache.hbase.hbck1;
+
+import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.CellUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.Delete;
+import org.apache.hadoop.hbase.client.Mutation;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * hbck's local version of the MetaTableAccessor from the hbase repo
+ */
+@InterfaceAudience.Private
+class HBCKMetaTableAccessor {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(HBCKMetaTableAccessor.class);
+ private static final Logger HBCKMETALOG =
LoggerFactory.getLogger("org.apache.hadoop.hbase.META");
+
+ public static List getMergeRegions(Cell[] cells) {
+if (cells == null) {
+ return null;
+}
+List regionsToMerge = null;
+for (Cell cell: cells) {
+ if (!isMergeQualifierPrefix(cell)) {
+continue;
+ }
+ // Ok. This cell is that of a info:merge* column.
+ RegionInfo ri = RegionInfo.parseFromOrNull(cell.getValueArray(),
cell.getValueOffset(),
+ cell.getValueLength());
+ if (ri != null) {
+if (regionsToMerge == null) {
+ regionsToMerge = new ArrayList<>();
+}
+regionsToMerge.add(ri);
+ }
+}
+return regionsToMerge;
+ }
+
+ private static boolean isMergeQualifierPrefix(Cell cell) {
+// Check to see if has family and that qualifier starts with the merge
qualifier 'merge'
+return CellUtil.matchingFamily(cell, HConstants.CATALOG_FAMILY) &&
+HBCKPrivateCellUtil.qualifierStartsWith(cell,
HBCKConstants.MERGE_QUALIFIER_PREFIX);
+ }
+
+ /**
+ * Returns the column family used for meta columns.
+ * @return HConstants.CATALOG_FAMILY.
+ */
+ public static byte[] getCatalogFamily() {
+return HConstants.CATALOG_FAMILY;
+ }
+
+ /**
+ * Delete the passed d from the hbase:meta table.
+ * @param connection connection we're using
+ * @param d Delete to add to hbase:meta
+ */
+ private static void deleteFromMetaTable(final Connection connection, final
Delete d)
+ throws IOException {
+List dels = new ArrayList<>(1);
+dels.add(d);
+deleteFromMetaTable(connection, dels);
Review comment:
Not you I know but maybe better to write as
deleteFromMetaTable(connection, Arrays.asList(d));
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758 URL: https://github.com/apache/hbase-operator-tools/pull/14#discussion_r314364702 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBCKMetaTableAccessor.java ## @@ -0,0 +1,134 @@ +package org.apache.hbase.hbck1; Review comment: Yeah, wrong package. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix
HBCK2 after HBASE-22777 & HBASE-22758
URL:
https://github.com/apache/hbase-operator-tools/pull/14#discussion_r314363033
##
File path:
hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBaseFsckRepair.java
##
@@ -200,6 +200,6 @@ public static HRegion createHDFSRegionDir(Configuration
conf,
*/
public static void removeParentInMeta(Configuration conf, RegionInfo hri)
throws IOException {
Connection conn = ConnectionFactory.createConnection(conf);
-MetaTableAccessor.deleteRegion(conn, hri);
Review comment:
Is this only place where we use the internal MTA? If so, good.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758 URL: https://github.com/apache/hbase-operator-tools/pull/14#discussion_r314357400 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBCKPrivateCellUtil.java ## @@ -0,0 +1,32 @@ +package org.apache.hbase.hbck1; Review comment: Needs license. Why in this package? It is not hbck1 facility, right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix
HBCK2 after HBASE-22777 & HBASE-22758
URL:
https://github.com/apache/hbase-operator-tools/pull/14#discussion_r314360160
##
File path: hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBCKConstants.java
##
@@ -0,0 +1,22 @@
+package org.apache.hbase.hbck1;
+
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * HBCKConstants holds a bunch of HBase(HBCK)-related constants.
+ * hbck's local version of the HConstants from the hbase repo.
+ */
+@InterfaceAudience.Private
+final class HBCKConstants {
+ /**
+ * Merge qualifier prefix.
+ * We used to only allow two regions merge; mergeA and mergeB.
+ * Now we allow many to merge. Each region to merge will be referenced
+ * in a column whose qualifier starts with this define.
+ */
+ public static final String MERGE_QUALIFIER_PREFIX_STR = "merge";
+
+ public static final byte [] MERGE_QUALIFIER_PREFIX =
+ Bytes.toBytes(MERGE_QUALIFIER_PREFIX_STR);
+}
Review comment:
Where is this used? If used in one class only, add the define to that one
class.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix
HBCK2 after HBASE-22777 & HBASE-22758
URL:
https://github.com/apache/hbase-operator-tools/pull/14#discussion_r314363274
##
File path:
hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBaseFsckRepair.java
##
@@ -200,6 +200,6 @@ public static HRegion createHDFSRegionDir(Configuration
conf,
*/
public static void removeParentInMeta(Configuration conf, RegionInfo hri)
throws IOException {
Connection conn = ConnectionFactory.createConnection(conf);
-MetaTableAccessor.deleteRegion(conn, hri);
Review comment:
Oh, yeah, the method name changed. Good.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix
HBCK2 after HBASE-22777 & HBASE-22758
URL:
https://github.com/apache/hbase-operator-tools/pull/14#discussion_r314355466
##
File path: hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBCKConstants.java
##
@@ -0,0 +1,22 @@
+package org.apache.hbase.hbck1;
+
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * HBCKConstants holds a bunch of HBase(HBCK)-related constants.
+ * hbck's local version of the HConstants from the hbase repo.
+ */
+@InterfaceAudience.Private
+final class HBCKConstants {
+ /**
+ * Merge qualifier prefix.
+ * We used to only allow two regions merge; mergeA and mergeB.
+ * Now we allow many to merge. Each region to merge will be referenced
+ * in a column whose qualifier starts with this define.
+ */
+ public static final String MERGE_QUALIFIER_PREFIX_STR = "merge";
+
+ public static final byte [] MERGE_QUALIFIER_PREFIX =
+ Bytes.toBytes(MERGE_QUALIFIER_PREFIX_STR);
+}
Review comment:
We have Constants in hbase but this pulling out constants to be in their own
file is an anti-pattern (Constants is a mistake). Constants should be beside
where they are used. If shared, then put in base or first mention class or the
class that looks best like a 'home' for the constant.
FYI, new files need license.
I see here you are pulling over the new regex facility.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix
HBCK2 after HBASE-22777 & HBASE-22758
URL:
https://github.com/apache/hbase-operator-tools/pull/14#discussion_r314356813
##
File path: pom.xml
##
@@ -123,7 +123,7 @@
1.8
${compileSource}
3.3.3
-2.1.2
+2.1.6-SNAPSHOT
Review comment:
Why this? Makes me worried we'll end up w/ a dependency on new facility when
we are trying to keep HBCK 'universal'.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix
HBCK2 after HBASE-22777 & HBASE-22758
URL:
https://github.com/apache/hbase-operator-tools/pull/14#discussion_r314367336
##
File path:
hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBCKMetaTableAccessor.java
##
@@ -0,0 +1,134 @@
+package org.apache.hbase.hbck1;
+
+import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.CellUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.Delete;
+import org.apache.hadoop.hbase.client.Mutation;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * hbck's local version of the MetaTableAccessor from the hbase repo
+ */
+@InterfaceAudience.Private
+class HBCKMetaTableAccessor {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(HBCKMetaTableAccessor.class);
+ private static final Logger HBCKMETALOG =
LoggerFactory.getLogger("org.apache.hadoop.hbase.META");
+
+ public static List getMergeRegions(Cell[] cells) {
+if (cells == null) {
+ return null;
+}
+List regionsToMerge = null;
+for (Cell cell: cells) {
+ if (!isMergeQualifierPrefix(cell)) {
+continue;
+ }
+ // Ok. This cell is that of a info:merge* column.
+ RegionInfo ri = RegionInfo.parseFromOrNull(cell.getValueArray(),
cell.getValueOffset(),
+ cell.getValueLength());
+ if (ri != null) {
+if (regionsToMerge == null) {
+ regionsToMerge = new ArrayList<>();
+}
+regionsToMerge.add(ri);
+ }
+}
+return regionsToMerge;
+ }
+
+ private static boolean isMergeQualifierPrefix(Cell cell) {
+// Check to see if has family and that qualifier starts with the merge
qualifier 'merge'
+return CellUtil.matchingFamily(cell, HConstants.CATALOG_FAMILY) &&
+HBCKPrivateCellUtil.qualifierStartsWith(cell,
HBCKConstants.MERGE_QUALIFIER_PREFIX);
+ }
+
+ /**
+ * Returns the column family used for meta columns.
+ * @return HConstants.CATALOG_FAMILY.
+ */
+ public static byte[] getCatalogFamily() {
+return HConstants.CATALOG_FAMILY;
+ }
+
+ /**
+ * Delete the passed d from the hbase:meta table.
+ * @param connection connection we're using
+ * @param d Delete to add to hbase:meta
+ */
+ private static void deleteFromMetaTable(final Connection connection, final
Delete d)
+ throws IOException {
+List dels = new ArrayList<>(1);
+dels.add(d);
+deleteFromMetaTable(connection, dels);
+ }
+
+ /**
+ * Callers should call close on the returned {@link Table} instance.
+ * @param connection connection we're using to access Meta
+ * @return An {@link Table} for hbase:meta
+ */
+ public static Table getMetaHTable(final Connection connection)
Review comment:
Or do we even need this in this little class?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix
HBCK2 after HBASE-22777 & HBASE-22758
URL:
https://github.com/apache/hbase-operator-tools/pull/14#discussion_r314361747
##
File path:
hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBCKMetaTableAccessor.java
##
@@ -0,0 +1,134 @@
+package org.apache.hbase.hbck1;
+
+import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.CellUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.Delete;
+import org.apache.hadoop.hbase.client.Mutation;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * hbck's local version of the MetaTableAccessor from the hbase repo
+ */
+@InterfaceAudience.Private
+class HBCKMetaTableAccessor {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(HBCKMetaTableAccessor.class);
+ private static final Logger HBCKMETALOG =
LoggerFactory.getLogger("org.apache.hadoop.hbase.META");
+
+ public static List getMergeRegions(Cell[] cells) {
Review comment:
You might in comment point at the original version of this method... say
copied from ... blah, blah.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix
HBCK2 after HBASE-22777 & HBASE-22758
URL:
https://github.com/apache/hbase-operator-tools/pull/14#discussion_r314365185
##
File path:
hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBCKMetaTableAccessor.java
##
@@ -0,0 +1,134 @@
+package org.apache.hbase.hbck1;
+
+import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.CellUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.Delete;
+import org.apache.hadoop.hbase.client.Mutation;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * hbck's local version of the MetaTableAccessor from the hbase repo
+ */
+@InterfaceAudience.Private
+class HBCKMetaTableAccessor {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(HBCKMetaTableAccessor.class);
+ private static final Logger HBCKMETALOG =
LoggerFactory.getLogger("org.apache.hadoop.hbase.META");
+
+ public static List getMergeRegions(Cell[] cells) {
+if (cells == null) {
+ return null;
+}
+List regionsToMerge = null;
+for (Cell cell: cells) {
+ if (!isMergeQualifierPrefix(cell)) {
+continue;
+ }
+ // Ok. This cell is that of a info:merge* column.
+ RegionInfo ri = RegionInfo.parseFromOrNull(cell.getValueArray(),
cell.getValueOffset(),
+ cell.getValueLength());
+ if (ri != null) {
+if (regionsToMerge == null) {
+ regionsToMerge = new ArrayList<>();
+}
+regionsToMerge.add(ri);
+ }
+}
+return regionsToMerge;
+ }
+
+ private static boolean isMergeQualifierPrefix(Cell cell) {
+// Check to see if has family and that qualifier starts with the merge
qualifier 'merge'
+return CellUtil.matchingFamily(cell, HConstants.CATALOG_FAMILY) &&
+HBCKPrivateCellUtil.qualifierStartsWith(cell,
HBCKConstants.MERGE_QUALIFIER_PREFIX);
Review comment:
YEah, just move this method in here rather than create a whole new class.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix
HBCK2 after HBASE-22777 & HBASE-22758
URL:
https://github.com/apache/hbase-operator-tools/pull/14#discussion_r314356292
##
File path: hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBaseFsck.java
##
@@ -3924,13 +3924,14 @@ public boolean visit(Result result) throws IOException
{
throw new IOException("Two entries in hbase:meta are same " +
previous);
}
}
- PairOfSameType mergeRegions =
MetaTableAccessor.getMergeRegions(result);
- for (RegionInfo mergeRegion : new RegionInfo[] {
- mergeRegions.getFirst(), mergeRegions.getSecond() }) {
-if (mergeRegion != null) {
- // This region is already been merged
- HbckInfo hbInfo = getOrCreateInfo(mergeRegion.getEncodedName());
- hbInfo.setMerged(true);
+ List mergeParents =
HBCKMetaTableAccessor.getMergeRegions(result.rawCells());
Review comment:
This part is good.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
