[jira] [Commented] (HBASE-22993) HBCK report UI showed -1 if hbck chore not running

2019-09-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928313#comment-16928313 ] Hudson commented on HBASE-22993: Results for branch branch-2 [build #2254 on

[GitHub] [hbase] sunhelly closed pull request #601: HBASE-22932 Add rs group management methods in Admin and AsyncAdmin

2019-09-12 Thread GitBox
sunhelly closed pull request #601: HBASE-22932 Add rs group management methods in Admin and AsyncAdmin URL: https://github.com/apache/hbase/pull/601 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] sunhelly opened a new pull request #613: HBASE-22932 Add rs group management methods in Admin and AsyncAdmin

2019-09-12 Thread GitBox
sunhelly opened a new pull request #613: HBASE-22932 Add rs group management methods in Admin and AsyncAdmin URL: https://github.com/apache/hbase/pull/613 This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (HBASE-22993) HBCK report UI showed -1 if hbck chore not running

2019-09-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928258#comment-16928258 ] Hudson commented on HBASE-22993: Results for branch master [build #1429 on

[GitHub] [hbase] ZhaoBQ commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode

2019-09-12 Thread GitBox
ZhaoBQ commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode URL: https://github.com/apache/hbase/pull/528#discussion_r323574125 ## File path:

[jira] [Updated] (HBASE-23003) [HBCK2/hbase-operator-tools] Release-making scripts

2019-09-12 Thread stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-23003: -- Attachment: 0001-HBASE-23003-HBCK2-hbase-operator-tools-Release-makin.patch > [HBCK2/hbase-operator-tools]

[jira] [Updated] (HBASE-23003) [HBCK2/hbase-operator-tools] Release-making scripts

2019-09-12 Thread stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-23003: -- Attachment: (was: 0001-HBASE-23003-HBCK2-hbase-operator-tools-Release-makin.patch) >

[jira] [Commented] (HBASE-23003) [HBCK2/hbase-operator-tools] Release-making scripts

2019-09-12 Thread stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928301#comment-16928301 ] stack commented on HBASE-23003: --- New .0001 gets over problem selecting hbase-operator-tools modules in

[GitHub] [hbase] Apache-HBase commented on issue #613: HBASE-22932 Add rs group management methods in Admin and AsyncAdmin

2019-09-12 Thread GitBox
Apache-HBase commented on issue #613: HBASE-22932 Add rs group management methods in Admin and AsyncAdmin URL: https://github.com/apache/hbase/pull/613#issuecomment-530794177 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase-connectors] ravowlga123 commented on issue #41: HBASE-22338 LICENSE file only contains Apache 2.0.

2019-09-12 Thread GitBox
ravowlga123 commented on issue #41: HBASE-22338 LICENSE file only contains Apache 2.0. URL: https://github.com/apache/hbase-connectors/pull/41#issuecomment-530783327 @busbey I have made the necessary changes as suggested above. Please let me know if there still are changes that need to

[GitHub] [hbase] ravowlga123 commented on issue #593: HBASE-22927 Upgrade Mockito version for jdk11

2019-09-12 Thread GitBox
ravowlga123 commented on issue #593: HBASE-22927 Upgrade Mockito version for jdk11 URL: https://github.com/apache/hbase/pull/593#issuecomment-530783572 Added the module-info in ignore class again. This is an automated

[jira] [Commented] (HBASE-23003) [HBCK2/hbase-operator-tools] Release-making scripts

2019-09-12 Thread stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928317#comment-16928317 ] stack commented on HBASE-23003: --- The last patch seems to do the right thing. WIll push tomorrow unless

[GitHub] [hbase] Apache-HBase commented on issue #612: HBASE-22804 Provide an API to get list of successful regions and total expected regions in Canary

2019-09-12 Thread GitBox
Apache-HBase commented on issue #612: HBASE-22804 Provide an API to get list of successful regions and total expected regions in Canary URL: https://github.com/apache/hbase/pull/612#issuecomment-530773594 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime

[jira] [Comment Edited] (HBASE-18638) There are version-related dirty data caused by delete/ttl

2019-09-12 Thread Ashok shetty (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928477#comment-16928477 ] Ashok shetty edited comment on HBASE-18638 at 9/12/19 11:58 AM: I was

[jira] [Commented] (HBASE-22988) Backport HBASE-11062 "hbtop" to branch-1

2019-09-12 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928406#comment-16928406 ] Toshihiro Suzuki commented on HBASE-22988: -- {quote} It would make adoption easier. Right now we

[GitHub] [hbase] ramkrish86 opened a new pull request #614: HBASE-22929 - MemStoreLAB ChunkCreator may memory leak(ram)

2019-09-12 Thread GitBox
ramkrish86 opened a new pull request #614: HBASE-22929 - MemStoreLAB ChunkCreator may memory leak(ram) URL: https://github.com/apache/hbase/pull/614 The leak is caused as said by @binlijin. The updateReaders() has already the memstoreScanners() list and so that is not getting closed.

[GitHub] [hbase] chenxu14 commented on a change in pull request #603: HBASE-22965 RS Crash due to DBE reference to an reused ByteBuff

2019-09-12 Thread GitBox
chenxu14 commented on a change in pull request #603: HBASE-22965 RS Crash due to DBE reference to an reused ByteBuff URL: https://github.com/apache/hbase/pull/603#discussion_r323607393 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodingState.java

[jira] [Commented] (HBASE-22993) HBCK report UI showed -1 if hbck chore not running

2019-09-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928353#comment-16928353 ] Hudson commented on HBASE-22993: Results for branch branch-2.1 [build #1591 on

[GitHub] [hbase] binlijin commented on issue #614: HBASE-22929 - MemStoreLAB ChunkCreator may memory leak(ram)

2019-09-12 Thread GitBox
binlijin commented on issue #614: HBASE-22929 - MemStoreLAB ChunkCreator may memory leak(ram) URL: https://github.com/apache/hbase/pull/614#issuecomment-530768897 +1 This is an automated message from the Apache Git Service.

[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase

2019-09-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928445#comment-16928445 ] Hudson commented on HBASE-22514: Results for branch HBASE-22514 [build #107 on

[jira] [Updated] (HBASE-23015) branch-1 hbase-server, testing util, and shaded testing util need jackson

2019-09-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-23015: - Attachment: HBASE-23015.branch-1.003.patch > branch-1 hbase-server, testing util, and shaded

[GitHub] [hbase-connectors] ravowlga123 commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0.

2019-09-12 Thread GitBox
ravowlga123 commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0. URL: https://github.com/apache/hbase-connectors/pull/41#discussion_r323689033 ## File path: kafka/hbase-kafka-model/src/main/appended-resources/META-INF/NOTICE.txt

[GitHub] [hbase-connectors] asf-ci commented on issue #41: HBASE-22338 LICENSE file only contains Apache 2.0.

2019-09-12 Thread GitBox
asf-ci commented on issue #41: HBASE-22338 LICENSE file only contains Apache 2.0. URL: https://github.com/apache/hbase-connectors/pull/41#issuecomment-530782788 Refer to this link for build results (access rights to CI server needed):

[GitHub] [hbase] ZhaoBQ opened a new pull request #615: HBASE-22975 Add read and write QPS metrics at server level and table level

2019-09-12 Thread GitBox
ZhaoBQ opened a new pull request #615: HBASE-22975 Add read and write QPS metrics at server level and table level URL: https://github.com/apache/hbase/pull/615 [HBASE-22975](https://issues.apache.org/jira/browse/HBASE-22975)

[jira] [Commented] (HBASE-22993) HBCK report UI showed -1 if hbck chore not running

2019-09-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928341#comment-16928341 ] Hudson commented on HBASE-22993: Results for branch branch-2.2 [build #600 on

[GitHub] [hbase] Apache-HBase commented on issue #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode

2019-09-12 Thread GitBox
Apache-HBase commented on issue #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode URL: https://github.com/apache/hbase/pull/528#issuecomment-530734321 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime |

[jira] [Commented] (HBASE-23015) branch-1 hbase-server, testing util, and shaded testing util need jackson

2019-09-12 Thread HBase QA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928457#comment-16928457 ] HBase QA commented on HBASE-23015: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[GitHub] [hbase] wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload

2019-09-12 Thread GitBox
wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/566#discussion_r323690611 ## File path:

[jira] [Commented] (HBASE-18638) There are version-related dirty data caused by delete/ttl

2019-09-12 Thread Ashok shetty (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928477#comment-16928477 ] Ashok shetty commented on HBASE-18638: -- I was going through this Jiar and  reproduced the issue in

[GitHub] [hbase] chenxu14 commented on issue #614: HBASE-22929 - MemStoreLAB ChunkCreator may memory leak(ram)

2019-09-12 Thread GitBox
chenxu14 commented on issue #614: HBASE-22929 - MemStoreLAB ChunkCreator may memory leak(ram) URL: https://github.com/apache/hbase/pull/614#issuecomment-530799245 lgtm,Sir This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on issue #603: HBASE-22965 RS Crash due to DBE reference to an reused ByteBuff

2019-09-12 Thread GitBox
Apache-HBase commented on issue #603: HBASE-22965 RS Crash due to DBE reference to an reused ByteBuff URL: https://github.com/apache/hbase/pull/603#issuecomment-530815010 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Comment Edited] (HBASE-18638) There are version-related dirty data caused by delete/ttl

2019-09-12 Thread Ashok shetty (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928477#comment-16928477 ] Ashok shetty edited comment on HBASE-18638 at 9/12/19 1:20 PM: --- I was

[GitHub] [hbase] busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson

2019-09-12 Thread GitBox
busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson URL: https://github.com/apache/hbase/pull/616#discussion_r323773917 ## File path: hbase-shaded/hbase-shaded-testing-util-tester/pom.xml ## @@ -58,6 +58,11 @@

[GitHub] [hbase] busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson

2019-09-12 Thread GitBox
busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson URL: https://github.com/apache/hbase/pull/616#discussion_r323768816 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java ## @@

[GitHub] [hbase] busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson

2019-09-12 Thread GitBox
busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson URL: https://github.com/apache/hbase/pull/616#discussion_r323767796 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/http/jmx/JMXJsonServlet.java ## @@

[GitHub] [hbase] busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson

2019-09-12 Thread GitBox
busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson URL: https://github.com/apache/hbase/pull/616#discussion_r323774798 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java

[GitHub] [hbase] busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson

2019-09-12 Thread GitBox
busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson URL: https://github.com/apache/hbase/pull/616#discussion_r323774149 ## File path: hbase-testing-util/pom.xml ## @@ -164,6 +164,16 @@

[GitHub] [hbase] busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson

2019-09-12 Thread GitBox
busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson URL: https://github.com/apache/hbase/pull/616#discussion_r323773988 ## File path: hbase-shaded/hbase-shaded-testing-util/pom.xml ## @@ -177,6 +177,11 @@

[GitHub] [hbase] busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson

2019-09-12 Thread GitBox
busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson URL: https://github.com/apache/hbase/pull/616#discussion_r32373 ## File path: hbase-common/pom.xml ## @@ -277,6 +277,11 @@ jackson-mapper-asl provided

[GitHub] [hbase] busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson

2019-09-12 Thread GitBox
busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson URL: https://github.com/apache/hbase/pull/616#discussion_r323769269 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java ## @@

[GitHub] [hbase] busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson

2019-09-12 Thread GitBox
busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson URL: https://github.com/apache/hbase/pull/616#discussion_r323769088 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java ## @@

[GitHub] [hbase] busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson

2019-09-12 Thread GitBox
busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson URL: https://github.com/apache/hbase/pull/616#discussion_r323773818 ## File path: hbase-shaded/hbase-shaded-server/pom.xml ## @@ -188,6 +188,11 @@

[GitHub] [hbase] busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587)

2019-09-12 Thread GitBox
busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587) URL: https://github.com/apache/hbase/pull/616#discussion_r323807270 ## File path:

[jira] [Commented] (HBASE-22796) [HBCK2] Add fix of overlaps to fixMeta hbck Service

2019-09-12 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928491#comment-16928491 ] Peter Somogyi commented on HBASE-22796: --- I'm looking into the failure: 

[jira] [Commented] (HBASE-22796) [HBCK2] Add fix of overlaps to fixMeta hbck Service

2019-09-12 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928494#comment-16928494 ] Peter Somogyi commented on HBASE-22796: --- On branch-2 testPlugHoles and testOneRegionTable tests

[jira] [Commented] (HBASE-23003) [HBCK2/hbase-operator-tools] Release-making scripts

2019-09-12 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928497#comment-16928497 ] Peter Somogyi commented on HBASE-23003: --- [~stack], I'm having a hard time to review the patch.

[GitHub] [hbase] wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload

2019-09-12 Thread GitBox
wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/566#discussion_r323721693 ## File path:

[GitHub] [hbase] Apache-HBase commented on issue #615: HBASE-22975 Add read and write QPS metrics at server level and table level

2019-09-12 Thread GitBox
Apache-HBase commented on issue #615: HBASE-22975 Add read and write QPS metrics at server level and table level URL: https://github.com/apache/hbase/pull/615#issuecomment-530869771 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] ravowlga123 commented on issue #593: HBASE-22927 Upgrade Mockito version for jdk11

2019-09-12 Thread GitBox
ravowlga123 commented on issue #593: HBASE-22927 Upgrade Mockito version for jdk11 URL: https://github.com/apache/hbase/pull/593#issuecomment-530870040 Still test is failing with same error as previous one even though module-info.class was added in ignoreClass.

[GitHub] [hbase] busbey commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload

2019-09-12 Thread GitBox
busbey commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/566#discussion_r323802214 ## File path:

[GitHub] [hbase] busbey commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload

2019-09-12 Thread GitBox
busbey commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/566#discussion_r323801858 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java

[GitHub] [hbase] busbey commented on issue #593: HBASE-22927 Upgrade Mockito version for jdk11

2019-09-12 Thread GitBox
busbey commented on issue #593: HBASE-22927 Upgrade Mockito version for jdk11 URL: https://github.com/apache/hbase/pull/593#issuecomment-530878323 We ended up doing the same thing over in the `hbase-operator-tools` repo, and getting it to work required adding `extra-enforcer-rules` as a

[GitHub] [hbase] Apache-HBase commented on issue #612: HBASE-22804 Provide an API to get list of successful regions and total expected regions in Canary

2019-09-12 Thread GitBox
Apache-HBase commented on issue #612: HBASE-22804 Provide an API to get list of successful regions and total expected regions in Canary URL: https://github.com/apache/hbase/pull/612#issuecomment-530852974 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime

[GitHub] [hbase] virajjasani commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587)

2019-09-12 Thread GitBox
virajjasani commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587) URL: https://github.com/apache/hbase/pull/616#discussion_r323793457 ## File path:

[GitHub] [hbase] busbey commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload

2019-09-12 Thread GitBox
busbey commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/566#discussion_r323802918 ## File path:

[GitHub] [hbase] wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload

2019-09-12 Thread GitBox
wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/566#discussion_r323717010 ## File path:

[GitHub] [hbase] Apache-HBase commented on issue #593: HBASE-22927 Upgrade Mockito version for jdk11

2019-09-12 Thread GitBox
Apache-HBase commented on issue #593: HBASE-22927 Upgrade Mockito version for jdk11 URL: https://github.com/apache/hbase/pull/593#issuecomment-530810254 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-23015) branch-1 hbase-server, testing util, and shaded testing util need jackson

2019-09-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928500#comment-16928500 ] Viraj Jasani commented on HBASE-23015: -- Created PR to trigger the build > branch-1 hbase-server,

[jira] [Commented] (HBASE-22956) [HBCK2/hbase-operator-tools] Make first release, 1.0.0

2019-09-12 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928498#comment-16928498 ] Peter Somogyi commented on HBASE-22956: --- Do you have a script that makes this comparison? It would

[GitHub] [hbase] Apache-HBase commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson

2019-09-12 Thread GitBox
Apache-HBase commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson URL: https://github.com/apache/hbase/pull/616#issuecomment-530847638 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] virajjasani commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587)

2019-09-12 Thread GitBox
virajjasani commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587) URL: https://github.com/apache/hbase/pull/616#discussion_r323777027 ## File path:

[GitHub] [hbase] virajjasani commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587)

2019-09-12 Thread GitBox
virajjasani commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587) URL: https://github.com/apache/hbase/pull/616#discussion_r323776865 ## File path:

[GitHub] [hbase] busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587)

2019-09-12 Thread GitBox
busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587) URL: https://github.com/apache/hbase/pull/616#discussion_r323806868 ## File path:

[jira] [Comment Edited] (HBASE-18638) There are version-related dirty data caused by delete/ttl

2019-09-12 Thread Ashok shetty (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928477#comment-16928477 ] Ashok shetty edited comment on HBASE-18638 at 9/12/19 12:40 PM: I was

[GitHub] [hbase] virajjasani commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587)

2019-09-12 Thread GitBox
virajjasani commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587) URL: https://github.com/apache/hbase/pull/616#discussion_r323793457 ## File path:

[jira] [Reopened] (HBASE-22796) [HBCK2] Add fix of overlaps to fixMeta hbck Service

2019-09-12 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi reopened HBASE-22796: --- TestMetaFixer is broken on branch-2.1, branch-2.2 and branch-2. > [HBCK2] Add fix of overlaps

[GitHub] [hbase] virajjasani opened a new pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson

2019-09-12 Thread GitBox
virajjasani opened a new pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson URL: https://github.com/apache/hbase/pull/616 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on issue #614: HBASE-22929 - MemStoreLAB ChunkCreator may memory leak(ram)

2019-09-12 Thread GitBox
Apache-HBase commented on issue #614: HBASE-22929 - MemStoreLAB ChunkCreator may memory leak(ram) URL: https://github.com/apache/hbase/pull/614#issuecomment-530836941 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] busbey commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson

2019-09-12 Thread GitBox
busbey commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson URL: https://github.com/apache/hbase/pull/616#issuecomment-530854642 Is this a backport of HBASE-20587 or all new? This is an automated

[jira] [Commented] (HBASE-22749) Distributed MOB compactions

2019-09-12 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928597#comment-16928597 ] Sean Busbey commented on HBASE-22749: - could you open this as a PR? > Distributed MOB compactions

[GitHub] [hbase] wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload

2019-09-12 Thread GitBox
wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/566#discussion_r323798172 ## File path:

[jira] [Commented] (HBASE-19320) document the mysterious direct memory leak in hbase

2019-09-12 Thread Sakthi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-19320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928672#comment-16928672 ] Sakthi commented on HBASE-19320: I think we should get this one in.  > document the mysterious direct

[jira] [Commented] (HBASE-22796) [HBCK2] Add fix of overlaps to fixMeta hbck Service

2019-09-12 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928703#comment-16928703 ] Peter Somogyi commented on HBASE-22796: --- It can be fixed here with an addendum. The patch was only

[GitHub] [hbase] wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload

2019-09-12 Thread GitBox
wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/566#discussion_r323838187 ## File path:

[jira] [Commented] (HBASE-22866) Multiple slf4j-log4j provider versions included in binary package (branch-1)

2019-09-12 Thread Xu Cang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928782#comment-16928782 ] Xu Cang commented on HBASE-22866: - question for [~vjasani] and [~apurtell] this patch's hadoop-qa run

[GitHub] [hbase] busbey commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload

2019-09-12 Thread GitBox
busbey commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/566#discussion_r323840520 ## File path:

[jira] [Commented] (HBASE-22796) [HBCK2] Add fix of overlaps to fixMeta hbck Service

2019-09-12 Thread stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928712#comment-16928712 ] stack commented on HBASE-22796: --- I can do it since I committed this. > [HBCK2] Add fix of overlaps to

[jira] [Updated] (HBASE-22955) Branches-1 precommit and nightly yetus jobs are using jdk8 for jdk7 jobs

2019-09-12 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-22955: Summary: Branches-1 precommit and nightly yetus jobs are using jdk8 for jdk7 jobs (was:

[GitHub] [hbase] caroliney14 commented on issue #612: HBASE-22804 Provide an API to get list of successful regions and total expected regions in Canary

2019-09-12 Thread GitBox
caroliney14 commented on issue #612: HBASE-22804 Provide an API to get list of successful regions and total expected regions in Canary URL: https://github.com/apache/hbase/pull/612#issuecomment-530955761 @busbey do you mean run the shaded jars test locally? how do I run just that test

[GitHub] [hbase] wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload

2019-09-12 Thread GitBox
wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/566#discussion_r323811028 ## File path:

[GitHub] [hbase] ravowlga123 commented on issue #593: HBASE-22927 Upgrade Mockito version for jdk11

2019-09-12 Thread GitBox
ravowlga123 commented on issue #593: HBASE-22927 Upgrade Mockito version for jdk11 URL: https://github.com/apache/hbase/pull/593#issuecomment-530889920 Made the changes @busbey . Hopefully this will pass the test. This is an

[GitHub] [hbase] Apache-HBase commented on issue #566: HBASE-22380 break circle replication when doing bulkload

2019-09-12 Thread GitBox
Apache-HBase commented on issue #566: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/566#issuecomment-530899023 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload

2019-09-12 Thread GitBox
wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/566#discussion_r323837823 ## File path:

[GitHub] [hbase] wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload

2019-09-12 Thread GitBox
wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/566#discussion_r323837823 ## File path:

[jira] [Commented] (HBASE-22956) [HBCK2/hbase-operator-tools] Make first release, 1.0.0

2019-09-12 Thread stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928720#comment-16928720 ] stack commented on HBASE-22956: --- [~psomogyi] I don't. We need one though HBASE-22853 >

[jira] [Comment Edited] (HBASE-22866) Multiple slf4j-log4j provider versions included in binary package (branch-1)

2019-09-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928798#comment-16928798 ] Viraj Jasani edited comment on HBASE-22866 at 9/12/19 6:10 PM: --- [~xucang]

[jira] [Commented] (HBASE-22866) Multiple slf4j-log4j provider versions included in binary package (branch-1)

2019-09-12 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928812#comment-16928812 ] Sean Busbey commented on HBASE-22866: - the issue here and the issue on HBASE-22728 is HBASE-22955.

[jira] [Commented] (HBASE-22955) Branches-1 precommit and nightly yetus jobs are using jdk8 for jdk7 jobs

2019-09-12 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928811#comment-16928811 ] Sean Busbey commented on HBASE-22955: - also happening with precommit checks. > Branches-1 precommit

[GitHub] [hbase] busbey commented on issue #612: HBASE-22804 Provide an API to get list of successful regions and total expected regions in Canary

2019-09-12 Thread GitBox
busbey commented on issue #612: HBASE-22804 Provide an API to get list of successful regions and total expected regions in Canary URL: https://github.com/apache/hbase/pull/612#issuecomment-530950734 the shadedjars test failure is

[GitHub] [hbase] wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload

2019-09-12 Thread GitBox
wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/566#discussion_r323807923 ## File path:

[jira] [Commented] (HBASE-22796) [HBCK2] Add fix of overlaps to fixMeta hbck Service

2019-09-12 Thread Sakthi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928705#comment-16928705 ] Sakthi commented on HBASE-22796: Ah, I see you reopened this one.  > [HBCK2] Add fix of overlaps to

[jira] [Comment Edited] (HBASE-22796) [HBCK2] Add fix of overlaps to fixMeta hbck Service

2019-09-12 Thread Sakthi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928705#comment-16928705 ] Sakthi edited comment on HBASE-22796 at 9/12/19 4:24 PM: - Ah, I see you reopened

[jira] [Commented] (HBASE-22866) Multiple slf4j-log4j provider versions included in binary package (branch-1)

2019-09-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928798#comment-16928798 ] Viraj Jasani commented on HBASE-22866: -- This seems to be issue with branch-1, I am not much aware

[jira] [Commented] (HBASE-22749) Distributed MOB compactions

2019-09-12 Thread Vladimir Rodionov (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928796#comment-16928796 ] Vladimir Rodionov commented on HBASE-22749: --- It seems, that tip of branch-2.2 is broken. Not a

[GitHub] [hbase] virajjasani commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587)

2019-09-12 Thread GitBox
virajjasani commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587) URL: https://github.com/apache/hbase/pull/616#issuecomment-530947480 Except for supplemental-models.xml and adding hbase-shaded-miscellaneous dependency, mostly this is backport

[GitHub] [hbase] wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload

2019-09-12 Thread GitBox
wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/566#discussion_r323820464 ## File path:

[GitHub] [hbase] virajjasani commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587)

2019-09-12 Thread GitBox
virajjasani commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587) URL: https://github.com/apache/hbase/pull/616#discussion_r323820422 ## File path:

[jira] [Commented] (HBASE-22796) [HBCK2] Add fix of overlaps to fixMeta hbck Service

2019-09-12 Thread Sakthi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928700#comment-16928700 ] Sakthi commented on HBASE-22796: [~psomogyi] shall we file a separate Jira for fixing the failures on

[jira] [Commented] (HBASE-22749) Distributed MOB compactions

2019-09-12 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928761#comment-16928761 ] Sean Busbey commented on HBASE-22749: - The patch {{HBASE-22749-branch-2.2.v3.patch}} fails to build

[GitHub] [hbase] wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload

2019-09-12 Thread GitBox
wchevreuil commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/566#discussion_r323861908 ## File path:

  1   2   >