[GitHub] [hbase] mwkang commented on issue #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value
mwkang commented on issue #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value URL: https://github.com/apache/hbase/pull/1287#issuecomment-602430411 If this PR is merged, I will backport version 2. Because I am doing backport to version 2. ([HBASE-23973 Backport HBASE-23561 to branch-2](https://issues.apache.org/jira/browse/HBASE-23973)) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1325: HBASE-23975 make hbase-rest use shaded protobuf
Apache-HBase commented on issue #1325: HBASE-23975 make hbase-rest use shaded protobuf URL: https://github.com/apache/hbase/pull/1325#issuecomment-602494866 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 33s | master passed | | +1 :green_heart: | compile | 1m 29s | master passed | | -1 :x: | shadedjars | 0m 10s | branch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 23s | hbase-rest in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 21s | the patch passed | | +1 :green_heart: | compile | 1m 27s | the patch passed | | +1 :green_heart: | javac | 1m 27s | the patch passed | | -1 :x: | shadedjars | 0m 10s | patch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 20s | hbase-rest in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 0s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 2m 45s | hbase-rest in the patch passed. | | | | 23m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1325 | | Optional Tests | unit javac javadoc shadedjars compile | | uname | Linux 4c6e94f213bd 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8130858199 | | Default Java | 2020-01-14 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/testReport/ | | Max. process+thread count | 3602 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1325: HBASE-23975 make hbase-rest use shaded protobuf
Apache-HBase commented on issue #1325: HBASE-23975 make hbase-rest use shaded protobuf URL: https://github.com/apache/hbase/pull/1325#issuecomment-602504087 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | prototool | 0m 1s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 42s | master passed | | +1 :green_heart: | checkstyle | 0m 32s | master passed | | +1 :green_heart: | spotbugs | 3m 49s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 15s | the patch passed | | -0 :warning: | checkstyle | 0m 20s | hbase-rest: The patch generated 10 new + 152 unchanged - 3 fixed = 162 total (was 155) | | -0 :warning: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | -0 :warning: | whitespace | 0m 0s | The patch 1 line(s) with tabs. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 11m 22s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | hbaseprotoc | 1m 27s | the patch passed | | +1 :green_heart: | spotbugs | 4m 8s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. | | | | 41m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1325 | | Optional Tests | dupname asflicense cc hbaseprotoc prototool hadoopcheck xml spotbugs hbaseanti checkstyle | | uname | Linux ca91a2ef51c7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8130858199 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/artifact/yetus-general-check/output/whitespace-eol.txt | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/artifact/yetus-general-check/output/whitespace-tabs.txt | | Max. process+thread count | 93 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] infraio merged pull request #1254: HBASE-23741 Data loss when WAL split to HFile enabled
infraio merged pull request #1254: HBASE-23741 Data loss when WAL split to HFile enabled URL: https://github.com/apache/hbase/pull/1254 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (HBASE-23975) Make hbase-rest use our shaded protobuf
[ https://issues.apache.org/jira/browse/HBASE-23975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel reassigned HBASE-23975: - Assignee: Semen Komissarov > Make hbase-rest use our shaded protobuf > --- > > Key: HBASE-23975 > URL: https://issues.apache.org/jira/browse/HBASE-23975 > Project: HBase > Issue Type: Task > Components: Protobufs, REST >Reporter: Duo Zhang >Assignee: Semen Komissarov >Priority: Blocker > Fix For: 3.0.0 > > > This is a strange one, we also use protobuf in hbase-rest and it is a non > shaded version... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] nyl3532016 opened a new pull request #1324: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t…
nyl3532016 opened a new pull request #1324: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t… URL: https://github.com/apache/hbase/pull/1324 …able to achieve overallbalanced This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1324: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t…
Apache-HBase commented on issue #1324: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t… URL: https://github.com/apache/hbase/pull/1324#issuecomment-602447774 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 15s | branch-2 passed | | +1 :green_heart: | compile | 1m 35s | branch-2 passed | | -1 :x: | shadedjars | 0m 11s | branch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 24s | hbase-rsgroup in branch-2 failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in branch-2 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 14s | the patch passed | | +1 :green_heart: | compile | 1m 34s | the patch passed | | +1 :green_heart: | javac | 1m 34s | the patch passed | | -1 :x: | shadedjars | 0m 11s | patch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 22s | hbase-rsgroup in the patch failed. | ||| _ Other Tests _ | | -0 :warning: | unit | 66m 32s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 3m 1s | hbase-rsgroup in the patch passed. | | | | 91m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1324 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 52c864c51a48 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 1cede85a53 | | Default Java | 2020-01-14 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rsgroup.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rsgroup.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/1/testReport/ | | Max. process+thread count | 6387 (vs. ulimit of 1) | | modules | C: hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on issue #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value
HorizonNet commented on issue #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value URL: https://github.com/apache/hbase/pull/1287#issuecomment-602472891 Test failure is unrelated. Spotbugs still reports this one, even though `putIfAbsent` is not used anymore. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1325: HBASE-23975 make hbase-rest use shaded protobuf
Apache-HBase commented on issue #1325: HBASE-23975 make hbase-rest use shaded protobuf URL: https://github.com/apache/hbase/pull/1325#issuecomment-602498995 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 42s | master passed | | +1 :green_heart: | compile | 1m 15s | master passed | | +1 :green_heart: | shadedjars | 5m 19s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 37s | the patch passed | | +1 :green_heart: | compile | 1m 15s | the patch passed | | +1 :green_heart: | javac | 1m 15s | the patch passed | | +1 :green_heart: | shadedjars | 5m 11s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 32s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 45s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 3m 4s | hbase-rest in the patch passed. | | | | 32m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1325 | | Optional Tests | unit javac javadoc shadedjars compile | | uname | Linux afb6c8c1a78c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8130858199 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/testReport/ | | Max. process+thread count | 4372 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1325/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1324: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t…
Apache-HBase commented on issue #1324: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t… URL: https://github.com/apache/hbase/pull/1324#issuecomment-602429015 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 9s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 39s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 52s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 48s | the patch passed | | +1 :green_heart: | checkstyle | 1m 24s | hbase-server: The patch generated 0 new + 414 unchanged - 20 fixed = 414 total (was 434) | | +1 :green_heart: | checkstyle | 0m 13s | The patch passed checkstyle in hbase-rsgroup | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 53s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 3m 8s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 23s | The patch does not generate ASF License warnings. | | | | 42m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1324 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 2f4ac33fa35b 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 1cede85a53 | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23561) Look up of Region in Master by encoded region name is O(n)
[
https://issues.apache.org/jira/browse/HBASE-23561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064600#comment-17064600
]
Minwoo Kang commented on HBASE-23561:
-
[~zhangduo] Sorry to bother you.
> Look up of Region in Master by encoded region name is O(n)
> --
>
> Key: HBASE-23561
> URL: https://issues.apache.org/jira/browse/HBASE-23561
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Michael Stack
>Assignee: Minwoo Kang
>Priority: Trivial
> Fix For: 3.0.0
>
>
> {{ public RegionState getRegionState(final String encodedRegionName) {
> // TODO: Need a map but it is just dispatch merge...
> for (RegionStateNode node: regionsMap.values()) {
> if (node.getRegionInfo().getEncodedName().equals(encodedRegionName)) {
> return node.toRegionState();
> }
> }
> return null;
> }}}
> It is not used much so making it trivial.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] semensanyok opened a new pull request #1325: HBASE-23975 make hbase-rest use shaded protobuf
semensanyok opened a new pull request #1325: HBASE-23975 make hbase-rest use shaded protobuf URL: https://github.com/apache/hbase/pull/1325 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd opened a new pull request #1326: [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x
Reidd opened a new pull request #1326: [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x URL: https://github.com/apache/hbase/pull/1326 JIRA link: https://issues.apache.org/jira/browse/HBASE-22740 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1324: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t…
Apache-HBase commented on issue #1324: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t… URL: https://github.com/apache/hbase/pull/1324#issuecomment-602467010 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 22s | branch-2 passed | | +1 :green_heart: | compile | 1m 28s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 52s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 56s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 2s | the patch passed | | +1 :green_heart: | compile | 1m 26s | the patch passed | | +1 :green_heart: | javac | 1m 26s | the patch passed | | +1 :green_heart: | shadedjars | 4m 55s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 36s | hbase-server generated 2 new + 1 unchanged - 0 fixed = 3 total (was 1) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 101m 24s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 3m 32s | hbase-rsgroup in the patch passed. | | | | 135m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1324 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7f6bb36909f3 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 1cede85a53 | | Default Java | 1.8.0_232 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/1/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/1/testReport/ | | Max. process+thread count | 3894 (vs. ulimit of 1) | | modules | C: hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22740) [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x
[ https://issues.apache.org/jira/browse/HBASE-22740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064704#comment-17064704 ] Reid Chan commented on HBASE-22740: --- JIRA link: https://github.com/apache/hbase/pull/1326 > [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x > -- > > Key: HBASE-22740 > URL: https://issues.apache.org/jira/browse/HBASE-22740 > Project: HBase > Issue Type: Bug > Components: rsgroup >Reporter: Reid Chan >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-22740) [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x
[ https://issues.apache.org/jira/browse/HBASE-22740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan reassigned HBASE-22740: - Assignee: Reid Chan > [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x > -- > > Key: HBASE-22740 > URL: https://issues.apache.org/jira/browse/HBASE-22740 > Project: HBase > Issue Type: Bug > Components: rsgroup >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1326: [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x
Apache-HBase commented on issue #1326: [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x URL: https://github.com/apache/hbase/pull/1326#issuecomment-602521892 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 23s | master passed | | +1 :green_heart: | checkstyle | 1m 18s | master passed | | -1 :x: | spotbugs | 2m 12s | hbase-server in master has 1 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 57s | the patch passed | | -0 :warning: | checkstyle | 1m 15s | hbase-server: The patch generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 18s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 40m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1326 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 93b531f01928 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8130858199 | | spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1326: [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x
Apache-HBase commented on issue #1326: [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x URL: https://github.com/apache/hbase/pull/1326#issuecomment-602557265 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 27s | master passed | | +1 :green_heart: | compile | 1m 15s | master passed | | -1 :x: | shadedjars | 0m 10s | branch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 3s | the patch passed | | +1 :green_heart: | compile | 1m 13s | the patch passed | | +1 :green_heart: | javac | 1m 13s | the patch passed | | -1 :x: | shadedjars | 0m 9s | patch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 102m 54s | hbase-server in the patch passed. | | | | 124m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1326 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f79b09ada8d5 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8130858199 | | Default Java | 2020-01-14 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/testReport/ | | Max. process+thread count | 4400 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1326: [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x
Apache-HBase commented on issue #1326: [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x URL: https://github.com/apache/hbase/pull/1326#issuecomment-602544690 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 47s | master passed | | +1 :green_heart: | compile | 0m 57s | master passed | | +1 :green_heart: | shadedjars | 5m 1s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 28s | the patch passed | | +1 :green_heart: | compile | 0m 59s | the patch passed | | +1 :green_heart: | javac | 0m 59s | the patch passed | | +1 :green_heart: | shadedjars | 5m 0s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 65m 51s | hbase-server in the patch passed. | | | | 93m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1326 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 72fda1efafc9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8130858199 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/testReport/ | | Max. process+thread count | 5591 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1324: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t…
Apache-HBase commented on issue #1324: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t… URL: https://github.com/apache/hbase/pull/1324#issuecomment-602629460 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 42s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 33s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 50s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 48s | the patch passed | | +1 :green_heart: | checkstyle | 1m 22s | hbase-server: The patch generated 0 new + 414 unchanged - 20 fixed = 414 total (was 434) | | +1 :green_heart: | checkstyle | 0m 12s | The patch passed checkstyle in hbase-rsgroup | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 36s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 3m 7s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. | | | | 41m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1324 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux ac3d63b4f491 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f16cf1dd8d | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-23741) Data loss when WAL split to HFile enabled
[ https://issues.apache.org/jira/browse/HBASE-23741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-23741. Resolution: Fixed Pushed to branch-2.3+. Thanks [~zhangduo] for reviewing. > Data loss when WAL split to HFile enabled > - > > Key: HBASE-23741 > URL: https://issues.apache.org/jira/browse/HBASE-23741 > Project: HBase > Issue Type: Bug > Components: MTTR >Affects Versions: 3.0.0, 2.3.0 >Reporter: Pankaj Kumar >Assignee: Guanghao Zhang >Priority: Blocker > Fix For: 3.0.0, 2.3.0, 2.4.0 > > > Very simple steps as below, > 1. Create table with 1 region > 2. Insert 1 record > 3. Flush the table > 4. Scan table and observe timestamp of the inserted row > 5. Insert same row key with same timestamp as previously inserted but with > different value > 6. Kill -9 RS where table region is online > 7. Start RS > Scan the table and check the result, latest cell must be returned. > Thanks [~sreenivasulureddy] for finding this issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1324: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t…
Apache-HBase commented on issue #1324: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t… URL: https://github.com/apache/hbase/pull/1324#issuecomment-602726465 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 7m 32s | branch-2 passed | | +1 :green_heart: | compile | 1m 54s | branch-2 passed | | -1 :x: | shadedjars | 0m 9s | branch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 25s | hbase-rsgroup in branch-2 failed. | | -0 :warning: | javadoc | 0m 42s | hbase-server in branch-2 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 7m 9s | the patch passed | | +1 :green_heart: | compile | 1m 47s | the patch passed | | +1 :green_heart: | javac | 1m 47s | the patch passed | | -1 :x: | shadedjars | 0m 9s | patch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 46s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 22s | hbase-rsgroup in the patch failed. | ||| _ Other Tests _ | | -0 :warning: | unit | 158m 7s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 7m 5s | hbase-rsgroup in the patch passed. | | | | 190m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1324 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b40a5a8dcc29 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f16cf1dd8d | | Default Java | 2020-01-14 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/2/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rsgroup.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rsgroup.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/2/testReport/ | | Max. process+thread count | 3940 (vs. ulimit of 1) | | modules | C: hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] qiaoandxiang opened a new pull request #1327: brancBranch 2.hbase 23957
qiaoandxiang opened a new pull request #1327: brancBranch 2.hbase 23957 URL: https://github.com/apache/hbase/pull/1327 …e-site.xml (#1310) Signed-off-by: Nick Dimiduk ndimi...@apache.org Signed-off-by: stack This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] qiaoandxiang opened a new pull request #1329: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas…
qiaoandxiang opened a new pull request #1329: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas… URL: https://github.com/apache/hbase/pull/1329 …e-site.xml (#1310) Signed-off-by: Nick Dimiduk ndimi...@apache.org Signed-off-by: stack This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] jojochuang commented on issue #1297: HBASE-23998. Update license for jetty-client.
jojochuang commented on issue #1297: HBASE-23998. Update license for jetty-client. URL: https://github.com/apache/hbase/pull/1297#issuecomment-602702553 @Apache9 could you check again? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24033) Add ut for loading the corrupt recovered hfiles
[
https://issues.apache.org/jira/browse/HBASE-24033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064939#comment-17064939
]
Hudson commented on HBASE-24033:
Results for branch branch-2.3
[build #5 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/5/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/5//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/5//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/5//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/5//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/5//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Add ut for loading the corrupt recovered hfiles
> ---
>
> Key: HBASE-24033
> URL: https://issues.apache.org/jira/browse/HBASE-24033
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.4.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23850) [Flakey Test] TestAsyncTableRSCrashPublish times out VPN enabled
[ https://issues.apache.org/jira/browse/HBASE-23850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064958#comment-17064958 ] Michael Stack commented on HBASE-23850: --- TestOpenRegionFailedMemoryLeak seems to hang too when lots of local Interfaces. Turning off VPN makes it pass. > [Flakey Test] TestAsyncTableRSCrashPublish times out VPN enabled > > > Key: HBASE-23850 > URL: https://issues.apache.org/jira/browse/HBASE-23850 > Project: HBase > Issue Type: Bug >Reporter: Michael Stack >Priority: Major > > This is an odd one. If I put up VPN on my local machine, this > TestAsyncTableRSCrashPublish test times out. If I take down the VPN, the test > passes. This is actually an awkward issue to trace since the udp multicast > stuff doesn't log much about its operation. Digging, the VPN adds a utun8 > network interface to my box. When this eighth interface comes on line, the > TestAsyncTableRSCrashPublish test will select this new interface, which is > ipv4, for the master to publish events on, but the clients will choose the > seventh utun interface, which is ipv6, for listening. If no vpn, both pick an > en?? interface and all just works. I've messed around with the test and tried > having the master add the networkinterface its chosen to the configuration, > and then had the clients use same network interface, but somehow clients > insist on listening on ipv6. No matter how I mess -- even insisting on ipv4 > on client and server (see coming attached code), the clients don't get the > master broadcast. > Attached code is my hacking trying to make sense of this. Let me make a > trivial subtask to add the logging at least in case someone runs into this in > prod, they'll have a chance for figuring out mismatched networking (currently > there is no way to figure w/o changing code). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] qiaoandxiang opened a new pull request #1328: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas…
qiaoandxiang opened a new pull request #1328: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas… URL: https://github.com/apache/hbase/pull/1328 …e-site.xml (#1310) Signed-off-by: Nick Dimiduk ndimi...@apache.org Signed-off-by: stack This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani merged pull request #1317: HBASE-23936 : Thrift support for Online SlowLog APIs
virajjasani merged pull request #1317: HBASE-23936 : Thrift support for Online SlowLog APIs URL: https://github.com/apache/hbase/pull/1317 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23633) Find a way to handle the corrupt recovered hfiles
[
https://issues.apache.org/jira/browse/HBASE-23633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064938#comment-17064938
]
Hudson commented on HBASE-23633:
Results for branch branch-2.3
[build #5 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/5/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/5//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/5//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/5//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/5//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/5//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Find a way to handle the corrupt recovered hfiles
> -
>
> Key: HBASE-23633
> URL: https://issues.apache.org/jira/browse/HBASE-23633
> Project: HBase
> Issue Type: Bug
> Components: MTTR, wal
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Guanghao Zhang
>Assignee: Pankaj Kumar
>Priority: Critical
> Fix For: 3.0.0, 2.3.0, 2.4.0
>
>
> Copy the comment from PR review.
>
> If the file is a corrupt HFile, an exception will be thrown here, which will
> cause the region to fail to open.
> Maybe we can add a new parameter to control whether to skip the exception,
> similar to recover edits which has a parameter
> "hbase.hregion.edits.replay.skip.errors";
>
> Regions that can't be opened because of detached References or corrupt hfiles
> are a fact-of-life. We need work on this issue. This will be a new variant on
> the problem -- i.e. bad recovered hfiles.
> On adding a config to ignore bad files and just open, thats a bit dangerous
> as per @infraio as it could mean silent data loss.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1324: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t…
Apache-HBase commented on issue #1324: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t… URL: https://github.com/apache/hbase/pull/1324#issuecomment-602728693 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 32s | branch-2 passed | | +1 :green_heart: | compile | 1m 27s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 7s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 58s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 49s | the patch passed | | +1 :green_heart: | compile | 1m 35s | the patch passed | | +1 :green_heart: | javac | 1m 35s | the patch passed | | +1 :green_heart: | shadedjars | 6m 42s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 157m 0s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 3m 31s | hbase-rsgroup in the patch passed. | | | | 194m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1324 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0ff9426c3bfa 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f16cf1dd8d | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/2/testReport/ | | Max. process+thread count | 3859 (vs. ulimit of 1) | | modules | C: hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on issue #1297: HBASE-23998. Update license for jetty-client.
saintstack commented on issue #1297: HBASE-23998. Update license for jetty-client. URL: https://github.com/apache/hbase/pull/1297#issuecomment-602771325 I can push if you good by you @Apache9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1259: HBASE-23951: Avoid high speed recursion trap in AsyncRequestFutureImpl.
saintstack commented on a change in pull request #1259: HBASE-23951: Avoid high speed recursion trap in AsyncRequestFutureImpl. URL: https://github.com/apache/hbase/pull/1259#discussion_r396661168 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java ## @@ -747,9 +771,9 @@ private void resubmit(ServerName oldServer, List toReplay, // It should be possible to have some heuristics to take the right decision. Short term, // we go for one. boolean retryImmediately = throwable instanceof RetryImmediatelyException; -int nextAttemptNumber = retryImmediately ? numAttempt : numAttempt + 1; +int nextAttemptNumber = numAttempt + 1; Review comment: How does this change our behavior @markrmiller This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23936) Thrift support for get and clear slow_log APIs
[ https://issues.apache.org/jira/browse/HBASE-23936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-23936: - Resolution: Fixed Status: Resolved (was: Patch Available) > Thrift support for get and clear slow_log APIs > -- > > Key: HBASE-23936 > URL: https://issues.apache.org/jira/browse/HBASE-23936 > Project: HBase > Issue Type: Sub-task >Affects Versions: 3.0.0, 2.3.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.4.0 > > > Provide thrift support for get_slowlog_responses() and > clear_slowlog_responses() Admin APIs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack commented on a change in pull request #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time.
saintstack commented on a change in pull request #1274: HBASE-23968
Periodically check whether a system stop is requested in compaction by time.
URL: https://github.com/apache/hbase/pull/1274#discussion_r396671133
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
##
@@ -317,7 +318,14 @@ protected boolean performCompaction(FileDetails fd,
InternalScanner scanner, Cel
do {
hasMore = scanner.next(cells, scannerContext);
-now = EnvironmentEdgeManager.currentTime();
+currentTime = EnvironmentEdgeManager.currentTime();
+if (LOG.isDebugEnabled()) {
+ now = currentTime;
+}
+if (closeChecker.isClosedByTimeLimit(store, currentTime)) {
Review comment:
This is a bug fix?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time.
saintstack commented on a change in pull request #1274: HBASE-23968
Periodically check whether a system stop is requested in compaction by time.
URL: https://github.com/apache/hbase/pull/1274#discussion_r396672413
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CloseChecker.java
##
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver.compactions;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.regionserver.Store;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Check periodically to see if a system stop is requested
+ */
+@InterfaceAudience.Private
+public class CloseChecker {
+ public static final String SIZE_LIMIT_KEY =
"hbase.hstore.close.check.interval";
+ public static final String TIME_LIMIT_KEY =
"hbase.hstore.close.check.time.interval";
+
+ private final int closeCheckSizeLimit;
+ private final long closeCheckTimeLimit;
+
+ private long bytesWrittenProgressForCloseCheck;
+ private long lastCloseCheckMillis;
+
+ public CloseChecker(Configuration conf, long currentTime) {
+this.closeCheckSizeLimit = conf.getInt(SIZE_LIMIT_KEY, 10 * 1000 * 1000 /*
10 MB */);
+this.closeCheckTimeLimit = conf.getLong(TIME_LIMIT_KEY, 10 * 1000L /* 10 s
*/);
+this.bytesWrittenProgressForCloseCheck = 0;
+this.lastCloseCheckMillis = currentTime;
+ }
+
+ public boolean isClosedBySizeLimit(Store store, long bytesWritten) {
+if (closeCheckSizeLimit <= 0) {
+ return false;
+}
+
+bytesWrittenProgressForCloseCheck += bytesWritten;
+if (bytesWrittenProgressForCloseCheck <= closeCheckSizeLimit) {
+ return false;
+}
+
+bytesWrittenProgressForCloseCheck = 0;
+return !store.areWritesEnabled();
+ }
+
+ public boolean isClosedByTimeLimit(Store store, long now) {
+if (closeCheckTimeLimit <= 0) {
+ return false;
+}
+
+final long elapsedMillis = now - lastCloseCheckMillis;
+if (elapsedMillis <= closeCheckTimeLimit) {
+ return false;
+}
+
+lastCloseCheckMillis = now;
Review comment:
Better if can do w/o volatile (I think compactor will only have one driving
thread...)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time.
saintstack commented on a change in pull request #1274: HBASE-23968
Periodically check whether a system stop is requested in compaction by time.
URL: https://github.com/apache/hbase/pull/1274#discussion_r396669282
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CloseChecker.java
##
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver.compactions;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.regionserver.Store;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Check periodically to see if a system stop is requested
+ */
+@InterfaceAudience.Private
+public class CloseChecker {
+ public static final String SIZE_LIMIT_KEY =
"hbase.hstore.close.check.interval";
+ public static final String TIME_LIMIT_KEY =
"hbase.hstore.close.check.time.interval";
+
+ private final int closeCheckSizeLimit;
+ private final long closeCheckTimeLimit;
+
+ private long bytesWrittenProgressForCloseCheck;
+ private long lastCloseCheckMillis;
+
+ public CloseChecker(Configuration conf, long currentTime) {
+this.closeCheckSizeLimit = conf.getInt(SIZE_LIMIT_KEY, 10 * 1000 * 1000 /*
10 MB */);
+this.closeCheckTimeLimit = conf.getLong(TIME_LIMIT_KEY, 10 * 1000L /* 10 s
*/);
+this.bytesWrittenProgressForCloseCheck = 0;
+this.lastCloseCheckMillis = currentTime;
+ }
+
+ public boolean isClosedBySizeLimit(Store store, long bytesWritten) {
+if (closeCheckSizeLimit <= 0) {
+ return false;
+}
+
+bytesWrittenProgressForCloseCheck += bytesWritten;
+if (bytesWrittenProgressForCloseCheck <= closeCheckSizeLimit) {
+ return false;
+}
+
+bytesWrittenProgressForCloseCheck = 0;
+return !store.areWritesEnabled();
+ }
+
+ public boolean isClosedByTimeLimit(Store store, long now) {
+if (closeCheckTimeLimit <= 0) {
+ return false;
+}
+
+final long elapsedMillis = now - lastCloseCheckMillis;
+if (elapsedMillis <= closeCheckTimeLimit) {
+ return false;
+}
+
+lastCloseCheckMillis = now;
Review comment:
Single thread in here? Otherwise, perhaps this should be volatile?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time.
saintstack commented on a change in pull request #1274: HBASE-23968
Periodically check whether a system stop is requested in compaction by time.
URL: https://github.com/apache/hbase/pull/1274#discussion_r396673090
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CloseChecker.java
##
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver.compactions;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.regionserver.Store;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Check periodically to see if a system stop is requested
+ */
+@InterfaceAudience.Private
+public class CloseChecker {
+ public static final String SIZE_LIMIT_KEY =
"hbase.hstore.close.check.interval";
+ public static final String TIME_LIMIT_KEY =
"hbase.hstore.close.check.time.interval";
+
+ private final int closeCheckSizeLimit;
+ private final long closeCheckTimeLimit;
+
+ private long bytesWrittenProgressForCloseCheck;
+ private long lastCloseCheckMillis;
+
+ public CloseChecker(Configuration conf, long currentTime) {
+this.closeCheckSizeLimit = conf.getInt(SIZE_LIMIT_KEY, 10 * 1000 * 1000 /*
10 MB */);
+this.closeCheckTimeLimit = conf.getLong(TIME_LIMIT_KEY, 10 * 1000L /* 10 s
*/);
+this.bytesWrittenProgressForCloseCheck = 0;
+this.lastCloseCheckMillis = currentTime;
+ }
+
+ public boolean isClosedBySizeLimit(Store store, long bytesWritten) {
+if (closeCheckSizeLimit <= 0) {
+ return false;
+}
+
+bytesWrittenProgressForCloseCheck += bytesWritten;
+if (bytesWrittenProgressForCloseCheck <= closeCheckSizeLimit) {
+ return false;
+}
+
+bytesWrittenProgressForCloseCheck = 0;
+return !store.areWritesEnabled();
+ }
+
+ public boolean isClosedByTimeLimit(Store store, long now) {
Review comment:
s/isClosedByTimeLimit/isTimeLimit/g
... Class name provides the context ... i.e. that it is about close.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time.
saintstack commented on a change in pull request #1274: HBASE-23968
Periodically check whether a system stop is requested in compaction by time.
URL: https://github.com/apache/hbase/pull/1274#discussion_r396671715
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
##
@@ -317,7 +318,14 @@ protected boolean performCompaction(FileDetails fd,
InternalScanner scanner, Cel
do {
hasMore = scanner.next(cells, scannerContext);
-now = EnvironmentEdgeManager.currentTime();
+currentTime = EnvironmentEdgeManager.currentTime();
+if (LOG.isDebugEnabled()) {
+ now = currentTime;
+}
+if (closeChecker.isClosedByTimeLimit(store, currentTime)) {
Review comment:
s/isClosedByTimeLime/isTimeLimit/ ... and s/isClosedBySizeLiimt/isSizeLimit/
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time.
saintstack commented on a change in pull request #1274: HBASE-23968
Periodically check whether a system stop is requested in compaction by time.
URL: https://github.com/apache/hbase/pull/1274#discussion_r396672707
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CloseChecker.java
##
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver.compactions;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.regionserver.Store;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Check periodically to see if a system stop is requested
+ */
+@InterfaceAudience.Private
+public class CloseChecker {
+ public static final String SIZE_LIMIT_KEY =
"hbase.hstore.close.check.interval";
+ public static final String TIME_LIMIT_KEY =
"hbase.hstore.close.check.time.interval";
+
+ private final int closeCheckSizeLimit;
+ private final long closeCheckTimeLimit;
+
+ private long bytesWrittenProgressForCloseCheck;
+ private long lastCloseCheckMillis;
+
+ public CloseChecker(Configuration conf, long currentTime) {
+this.closeCheckSizeLimit = conf.getInt(SIZE_LIMIT_KEY, 10 * 1000 * 1000 /*
10 MB */);
+this.closeCheckTimeLimit = conf.getLong(TIME_LIMIT_KEY, 10 * 1000L /* 10 s
*/);
+this.bytesWrittenProgressForCloseCheck = 0;
+this.lastCloseCheckMillis = currentTime;
+ }
+
+ public boolean isClosedBySizeLimit(Store store, long bytesWritten) {
Review comment:
s/isClosedBySizeLimit/isSizeLimit/g
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time.
saintstack commented on a change in pull request #1274: HBASE-23968
Periodically check whether a system stop is requested in compaction by time.
URL: https://github.com/apache/hbase/pull/1274#discussion_r396669677
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CloseChecker.java
##
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver.compactions;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.regionserver.Store;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Check periodically to see if a system stop is requested
+ */
+@InterfaceAudience.Private
+public class CloseChecker {
+ public static final String SIZE_LIMIT_KEY =
"hbase.hstore.close.check.interval";
+ public static final String TIME_LIMIT_KEY =
"hbase.hstore.close.check.time.interval";
+
+ private final int closeCheckSizeLimit;
+ private final long closeCheckTimeLimit;
+
+ private long bytesWrittenProgressForCloseCheck;
+ private long lastCloseCheckMillis;
+
+ public CloseChecker(Configuration conf, long currentTime) {
Review comment:
ditto
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time.
saintstack commented on a change in pull request #1274: HBASE-23968
Periodically check whether a system stop is requested in compaction by time.
URL: https://github.com/apache/hbase/pull/1274#discussion_r396669567
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CloseChecker.java
##
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver.compactions;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.regionserver.Store;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Check periodically to see if a system stop is requested
+ */
+@InterfaceAudience.Private
+public class CloseChecker {
Review comment:
Does it have to be public? Can it be package local? It is only used in this
package?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-24033) Add ut for loading the corrupt recovered hfiles
[
https://issues.apache.org/jira/browse/HBASE-24033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064978#comment-17064978
]
Hudson commented on HBASE-24033:
Results for branch master
[build #1676 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1676/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Add ut for loading the corrupt recovered hfiles
> ---
>
> Key: HBASE-24033
> URL: https://issues.apache.org/jira/browse/HBASE-24033
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.4.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23741) Data loss when WAL split to HFile enabled
[
https://issues.apache.org/jira/browse/HBASE-23741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064981#comment-17064981
]
Hudson commented on HBASE-23741:
Results for branch master
[build #1676 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1676/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Data loss when WAL split to HFile enabled
> -
>
> Key: HBASE-23741
> URL: https://issues.apache.org/jira/browse/HBASE-23741
> Project: HBase
> Issue Type: Bug
> Components: MTTR
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Pankaj Kumar
>Assignee: Guanghao Zhang
>Priority: Blocker
> Fix For: 3.0.0, 2.3.0, 2.4.0
>
>
> Very simple steps as below,
> 1. Create table with 1 region
> 2. Insert 1 record
> 3. Flush the table
> 4. Scan table and observe timestamp of the inserted row
> 5. Insert same row key with same timestamp as previously inserted but with
> different value
> 6. Kill -9 RS where table region is online
> 7. Start RS
> Scan the table and check the result, latest cell must be returned.
> Thanks [~sreenivasulureddy] for finding this issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23799) Make our core coprocessors use shaded protobuf
[
https://issues.apache.org/jira/browse/HBASE-23799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064980#comment-17064980
]
Hudson commented on HBASE-23799:
Results for branch master
[build #1676 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1676/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Make our core coprocessors use shaded protobuf
> --
>
> Key: HBASE-23799
> URL: https://issues.apache.org/jira/browse/HBASE-23799
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors, Protobufs
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1327: brancBranch 2.hbase 23957
Apache-HBase commented on issue #1327: brancBranch 2.hbase 23957 URL: https://github.com/apache/hbase/pull/1327#issuecomment-602765484 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 51s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 6s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 5s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 22s | the patch passed | | +1 :green_heart: | checkstyle | 1m 7s | hbase-server: The patch generated 0 new + 1 unchanged - 3 fixed = 1 total (was 4) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 11m 13s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 3m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. | | | | 39m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1327/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1327 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle xml | | uname | Linux 26f93757a5b6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f16cf1dd8d | | Max. process+thread count | 93 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1327/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack edited a comment on issue #1261: HBASE-23952: Address thread safety issue with Map used in BufferCallB…
saintstack edited a comment on issue #1261: HBASE-23952: Address thread safety issue with Map used in BufferCallB… URL: https://github.com/apache/hbase/pull/1261#issuecomment-602776184 Progress here? Single-threaded or concurrent access? Should I close the issue? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on issue #1261: HBASE-23952: Address thread safety issue with Map used in BufferCallB…
saintstack commented on issue #1261: HBASE-23952: Address thread safety issue with Map used in BufferCallB… URL: https://github.com/apache/hbase/pull/1261#issuecomment-602776184 Progress here? Single-threaded or concurrent access? Should I resolve the issue? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1327: brancBranch 2.hbase 23957
Apache-HBase commented on issue #1327: brancBranch 2.hbase 23957 URL: https://github.com/apache/hbase/pull/1327#issuecomment-602790541 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 27s | branch-2 passed | | +1 :green_heart: | compile | 1m 6s | branch-2 passed | | -1 :x: | shadedjars | 0m 11s | branch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server in branch-2 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 2s | the patch passed | | +1 :green_heart: | compile | 1m 5s | the patch passed | | +1 :green_heart: | javac | 1m 5s | the patch passed | | -1 :x: | shadedjars | 0m 10s | patch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -0 :warning: | unit | 67m 37s | hbase-server in the patch failed. | | | | 86m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1327/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1327 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3c07dfd0912e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f16cf1dd8d | | Default Java | 2020-01-14 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1327/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1327/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1327/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1327/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1327/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1327/1/testReport/ | | Max. process+thread count | 5541 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1327/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23949) refactor loadBalancer implements for rsgroup balance by table to achieve overallbalanced
[
https://issues.apache.org/jira/browse/HBASE-23949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064977#comment-17064977
]
Hudson commented on HBASE-23949:
Results for branch master
[build #1676 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1676/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> refactor loadBalancer implements for rsgroup balance by table to achieve
> overallbalanced
> --
>
> Key: HBASE-23949
> URL: https://issues.apache.org/jira/browse/HBASE-23949
> Project: HBase
> Issue Type: Bug
> Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: niuyulin
>Assignee: niuyulin
>Priority: Major
>
> now can not achieve overallbalanced when use rsgroup balancer and by table
> is on,
> because balance every table actually use the clusterload only contain one
> table's load.
> we should use clusterload contain all this rsgroup table's load to balance
> overall
>
> hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
> {code:java}
> public boolean balance(boolean force) throws IOException {
> ..
> boolean isByTable =
> getConfiguration().getBoolean("hbase.master.loadbalance.bytable", false);
> Map>> assignments =
> this.assignmentManager.getRegionStates()
> .getAssignmentsForBalancer(tableStateManager,
> this.serverManager.getOnlineServersList(),
> isByTable);
> for (Map> serverMap : assignments.values()) {
>
> serverMap.keySet().removeAll(this.serverManager.getDrainingServersList());
> }
> //Give the balancer the current cluster state.
> this.balancer.setClusterMetrics(getClusterMetricsWithoutCoprocessor());
> this.balancer.setClusterLoad(assignments);
> List plans = new ArrayList<>();
> for (Entry>> e :
> assignments.entrySet()) {
> List partialPlans =
> this.balancer.balanceCluster(e.getKey(), e.getValue());
> if (partialPlans != null) {
> plans.addAll(partialPlans);
> }
> }
> {code}
> now do refactor:
> # add method 'balanceTable' in interface LoadBalancer
> # SimpleLoadBalancer and StochasticLoadBalancer do the real 'balanceTable' ,
> and 'balanceTable' is not support in BaseLoadBalancer and
> RSGroupBasedLoadBalancer
> # RSGroupBasedLoadBalancer invoke balanceCluster , and pass GroupClusterLoad
> to internal balacer by group
> # internal balancer balance cluster invoke 'balanceTable'
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23957) [flakey test] client.TestMultiParallel fails to read hbase-site.xml
[
https://issues.apache.org/jira/browse/HBASE-23957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064979#comment-17064979
]
Hudson commented on HBASE-23957:
Results for branch master
[build #1676 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1676/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1676//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> [flakey test] client.TestMultiParallel fails to read hbase-site.xml
> ---
>
> Key: HBASE-23957
> URL: https://issues.apache.org/jira/browse/HBASE-23957
> Project: HBase
> Issue Type: Test
> Components: test
>Reporter: Nick Dimiduk
>Priority: Minor
>
> Saw this on a [PreCommit
> run|https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1258/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt].
> Log file says
> {noformat}
> 2020-03-09 22:48:26,295 FATAL [Time-limited test] conf.Configuration(2853):
> error parsing conf hbase-site.xml
> java.io.FileNotFoundException:
> /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1258@2/yetus-jdk8-hadoop2-check/src/hbase-server/target/test-classes/hbase-site.xml
> (No such file or directory)
> at java.io.FileInputStream.open0(Native Method)
> at java.io.FileInputStream.open(FileInputStream.java:195)
> at java.io.FileInputStream.(FileInputStream.java:138)
> at java.io.FileInputStream.(FileInputStream.java:93)
> at
> sun.net.www.protocol.file.FileURLConnection.connect(FileURLConnection.java:90)
> at
> sun.net.www.protocol.file.FileURLConnection.getInputStream(FileURLConnection.java:188)
> at org.apache.hadoop.conf.Configuration.parse(Configuration.java:2672)
> at
> org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:2746)
> at
> org.apache.hadoop.conf.Configuration.loadResources(Configuration.java:2706)
> at
> org.apache.hadoop.conf.Configuration.getProps(Configuration.java:2579)
> at org.apache.hadoop.conf.Configuration.get(Configuration.java:1091)
> at
> org.apache.hadoop.conf.Configuration.getTrimmed(Configuration.java:1145)
> at
> org.apache.hadoop.conf.Configuration.getClass(Configuration.java:2363)
> at
> org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2793)
> at
> org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2810)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:100)
> at
> org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2849)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2831)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:389)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:181)
> at org.apache.hadoop.hbase.fs.HFileSystem.(HFileSystem.java:85)
> at org.apache.hadoop.hbase.fs.HFileSystem.get(HFileSystem.java:465)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getTestFileSystem(HBaseTestingUtility.java:3180)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getNewDataTestDirOnTestFS(HBaseTestingUtility.java:507)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.setupDataTestDirOnTestFS(HBaseTestingUtility.java:496)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getDataTestDirOnTestFS(HBaseTestingUtility.java:469)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getDataTestDirOnTestFS(HBaseTestingUtility.java:483)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.createDirsAndSetProperties(HBaseTestingUtility.java:651)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:603)
[GitHub] [hbase] Apache-HBase commented on issue #1328: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas…
Apache-HBase commented on issue #1328: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas… URL: https://github.com/apache/hbase/pull/1328#issuecomment-602766232 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 48s | branch-2.3 passed | | +1 :green_heart: | compile | 1m 20s | branch-2.3 passed | | -1 :x: | shadedjars | 0m 10s | branch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 46s | hbase-server in branch-2.3 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 4s | the patch passed | | +1 :green_heart: | compile | 1m 28s | the patch passed | | +1 :green_heart: | javac | 1m 28s | the patch passed | | -1 :x: | shadedjars | 0m 10s | patch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 54s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -0 :warning: | unit | 9m 20s | hbase-server in the patch failed. | | | | 30m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1328/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1328 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 8a283179cf8c 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / c519576fcb | | Default Java | 2020-01-14 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1328/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1328/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1328/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1328/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1328/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1328/1/testReport/ | | Max. process+thread count | 562 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1328/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1328: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas…
Apache-HBase commented on issue #1328: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas… URL: https://github.com/apache/hbase/pull/1328#issuecomment-602772137 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 53s | branch-2.3 passed | | +1 :green_heart: | checkstyle | 1m 13s | branch-2.3 passed | | +1 :green_heart: | spotbugs | 2m 3s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 23s | the patch passed | | +1 :green_heart: | checkstyle | 1m 4s | hbase-server: The patch generated 0 new + 1 unchanged - 3 fixed = 1 total (was 4) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 12m 22s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 3m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 18s | The patch does not generate ASF License warnings. | | | | 42m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1328/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1328 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle xml | | uname | Linux b76e18c43368 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / c519576fcb | | Max. process+thread count | 93 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1328/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1259: HBASE-23951: Avoid high speed recursion trap in AsyncRequestFutureImpl.
saintstack commented on a change in pull request #1259: HBASE-23951: Avoid high speed recursion trap in AsyncRequestFutureImpl. URL: https://github.com/apache/hbase/pull/1259#discussion_r396662327 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java ## @@ -747,9 +771,9 @@ private void resubmit(ServerName oldServer, List toReplay, // It should be possible to have some heuristics to take the right decision. Short term, // we go for one. boolean retryImmediately = throwable instanceof RetryImmediatelyException; -int nextAttemptNumber = retryImmediately ? numAttempt : numAttempt + 1; +int nextAttemptNumber = numAttempt + 1; Review comment: I read the JIRA. That helped. I think you need a comment here on why the arbitrary '3' even it is just referring back to the issue. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-24034) [Flakey Tests] A couple of fixes and cleanups
Michael Stack created HBASE-24034:
-
Summary: [Flakey Tests] A couple of fixes and cleanups
Key: HBASE-24034
URL: https://issues.apache.org/jira/browse/HBASE-24034
Project: HBase
Issue Type: Bug
Components: flakies
Reporter: Michael Stack
Assignee: Michael Stack
Here's a few cleanups and flakey fixes accumulated in last few days:
{code}
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupMajorCompactionTTL.java
Remove spurious assert. Just before this it waits an arbitrary 10
seconds. Compactions could have completed inside this time. The spirit
of the test remains.
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/HFileCleaner.java
Get log cleaner to go down promptly; its sticking around. See if this
helps with TestMasterShutdown
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
We get a rare NPE trying to sync. Make local copy of SyncFuture and see
if that helps.
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionAdminApi.java
Compaction may have completed when not expected; allow for it.
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestBlockEvictionFromClient.java
Add wait before testing. Compaction may not have completed. Let
compaction complete before progressing and then test for empty cache.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java
Less resources.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestDefaultLoadBalancer.java
Less resources.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java
Wait till online before we try and do compaction (else request is
ignored)
hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestCanaryTool.java
Disable test that tests for timeout that fails randomly w/ mockito
complaint on some mac os
x's.
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] saintstack opened a new pull request #1330: HBASE-24034 [Flakey Tests] A couple of fixes and cleanups
saintstack opened a new pull request #1330: HBASE-24034 [Flakey Tests] A couple of fixes and cleanups URL: https://github.com/apache/hbase/pull/1330 hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupMajorCompactionTTL.java Remove spurious assert. Just before this it waits an arbitrary 10 seconds. Compactions could have completed inside this time. The spirit of the test remains. hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/HFileCleaner.java Get log cleaner to go down promptly; its sticking around. See if this helps with TestMasterShutdown hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java We get a rare NPE trying to sync. Make local copy of SyncFuture and see if that helps. hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionAdminApi.java Compaction may have completed when not expected; allow for it. hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestBlockEvictionFromClient.java Add wait before testing. Compaction may not have completed. Let compaction complete before progressing and then test for empty cache. hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java Less resources. hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestDefaultLoadBalancer.java Less resources. hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java Wait till online before we try and do compaction (else request is ignored) hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestCanaryTool.java Disable test that fails randomly w/ mockito complaint on some mac os x's. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1328: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas…
Apache-HBase commented on issue #1328: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas… URL: https://github.com/apache/hbase/pull/1328#issuecomment-602803947 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 43s | branch-2.3 passed | | +1 :green_heart: | compile | 0m 57s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 4m 32s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 2s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed | | +1 :green_heart: | javac | 0m 58s | the patch passed | | +1 :green_heart: | shadedjars | 4m 25s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 34s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 76m 48s | hbase-server in the patch failed. | | | | 102m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1328/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1328 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0c014e384ac5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / c519576fcb | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1328/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1328/1/testReport/ | | Max. process+thread count | 5440 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1328/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on issue #1328: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas…
HorizonNet commented on issue #1328: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas… URL: https://github.com/apache/hbase/pull/1328#issuecomment-602825905 @qiaoandxiang Is the test failure related? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1323: HBASE-23981 PBType which is marked as IA.Public references protobuf M…
ndimiduk commented on issue #1323: HBASE-23981 PBType which is marked as IA.Public references protobuf M… URL: https://github.com/apache/hbase/pull/1323#issuecomment-602842867 * technically this needs a deprecation cycle. I'm okay with skipping it for this one though, since it's an unintentional part of our API, a class that (I imagine is) not heavily trafficked. * everything in `hbase-examples` should be `IA.Public`, right? * mind also update the javadoc to link off to `PBKeyValue` since it's now all in the same package? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-24035) [Flakey Tests] Disable TestClusterScopeQuotaThrottle#testUserNamespaceClusterScopeQuota
Michael Stack created HBASE-24035:
-
Summary: [Flakey Tests] Disable
TestClusterScopeQuotaThrottle#testUserNamespaceClusterScopeQuota
Key: HBASE-24035
URL: https://issues.apache.org/jira/browse/HBASE-24035
Project: HBase
Issue Type: Bug
Reporter: Michael Stack
testUserNamespaceClusterScopeQuota in TestClusterScopeQuotaThrottle is just
spewing:
{code}
2020-03-23 13:33:23,996 INFO [Listener at localhost/50281]
hbase.ChoreService(157): Chore ScheduledChore name=QuotaRefresherChore,
period=180, unit=MILLISECONDS is enabled.
2020-03-23 13:33:25,000 INFO [Listener at localhost/50281]
hbase.ChoreService(157): Chore ScheduledChore name=QuotaRefresherChore,
period=180, unit=MILLISECONDS is enabled.
2020-03-23 13:33:26,002 INFO [Listener at localhost/50281]
hbase.ChoreService(157): Chore ScheduledChore name=QuotaRefresherChore,
period=180, unit=MILLISECONDS is enabled.
2020-03-23 13:33:27,003 INFO [Listener at localhost/50281]
hbase.ChoreService(157): Chore ScheduledChore name=QuotaRefresherChore,
period=180, unit=MILLISECONDS is enabled.
{code}
If I run it standalone it passes. Fails in nightly currently.
Rather than spend time on this, disabling for now. It came in a good while ago
as part of HBASE-21820
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-24035) [Flakey Tests] Disable TestClusterScopeQuotaThrottle#testUserNamespaceClusterScopeQuota
[
https://issues.apache.org/jira/browse/HBASE-24035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-24035.
---
Fix Version/s: 2.3.0
3.0.0
Resolution: Fixed
Pushed on branch-2.3, branch-2, and master.
> [Flakey Tests] Disable
> TestClusterScopeQuotaThrottle#testUserNamespaceClusterScopeQuota
> ---
>
> Key: HBASE-24035
> URL: https://issues.apache.org/jira/browse/HBASE-24035
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> testUserNamespaceClusterScopeQuota in TestClusterScopeQuotaThrottle is just
> spewing:
> {code}
> 2020-03-23 13:33:23,996 INFO [Listener at localhost/50281]
> hbase.ChoreService(157): Chore ScheduledChore name=QuotaRefresherChore,
> period=180, unit=MILLISECONDS is enabled.
> 2020-03-23 13:33:25,000 INFO [Listener at localhost/50281]
> hbase.ChoreService(157): Chore ScheduledChore name=QuotaRefresherChore,
> period=180, unit=MILLISECONDS is enabled.
> 2020-03-23 13:33:26,002 INFO [Listener at localhost/50281]
> hbase.ChoreService(157): Chore ScheduledChore name=QuotaRefresherChore,
> period=180, unit=MILLISECONDS is enabled.
> 2020-03-23 13:33:27,003 INFO [Listener at localhost/50281]
> hbase.ChoreService(157): Chore ScheduledChore name=QuotaRefresherChore,
> period=180, unit=MILLISECONDS is enabled.
> {code}
> If I run it standalone it passes. Fails in nightly currently.
> Rather than spend time on this, disabling for now. It came in a good while
> ago as part of HBASE-21820
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24035) [Flakey Tests] Disable TestClusterScopeQuotaThrottle#testUserNamespaceClusterScopeQuota
[
https://issues.apache.org/jira/browse/HBASE-24035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065080#comment-17065080
]
Michael Stack commented on HBASE-24035:
---
Filed sub-issue to reenable test after it gets fixed.
> [Flakey Tests] Disable
> TestClusterScopeQuotaThrottle#testUserNamespaceClusterScopeQuota
> ---
>
> Key: HBASE-24035
> URL: https://issues.apache.org/jira/browse/HBASE-24035
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> testUserNamespaceClusterScopeQuota in TestClusterScopeQuotaThrottle is just
> spewing:
> {code}
> 2020-03-23 13:33:23,996 INFO [Listener at localhost/50281]
> hbase.ChoreService(157): Chore ScheduledChore name=QuotaRefresherChore,
> period=180, unit=MILLISECONDS is enabled.
> 2020-03-23 13:33:25,000 INFO [Listener at localhost/50281]
> hbase.ChoreService(157): Chore ScheduledChore name=QuotaRefresherChore,
> period=180, unit=MILLISECONDS is enabled.
> 2020-03-23 13:33:26,002 INFO [Listener at localhost/50281]
> hbase.ChoreService(157): Chore ScheduledChore name=QuotaRefresherChore,
> period=180, unit=MILLISECONDS is enabled.
> 2020-03-23 13:33:27,003 INFO [Listener at localhost/50281]
> hbase.ChoreService(157): Chore ScheduledChore name=QuotaRefresherChore,
> period=180, unit=MILLISECONDS is enabled.
> {code}
> If I run it standalone it passes. Fails in nightly currently.
> Rather than spend time on this, disabling for now. It came in a good while
> ago as part of HBASE-21820
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1327: brancBranch 2.hbase 23957
Apache-HBase commented on issue #1327: brancBranch 2.hbase 23957 URL: https://github.com/apache/hbase/pull/1327#issuecomment-602813532 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 9s | branch-2 passed | | +1 :green_heart: | compile | 1m 1s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 52s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 48s | the patch passed | | +1 :green_heart: | compile | 1m 0s | the patch passed | | +1 :green_heart: | javac | 1m 0s | the patch passed | | +1 :green_heart: | shadedjars | 4m 51s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 34s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 104m 22s | hbase-server in the patch passed. | | | | 132m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1327/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1327 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 08f70a4d4196 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f16cf1dd8d | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1327/1/testReport/ | | Max. process+thread count | 3885 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1327/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] huaxiangsun merged pull request #1327: brancBranch 2.hbase 23957
huaxiangsun merged pull request #1327: brancBranch 2.hbase 23957 URL: https://github.com/apache/hbase/pull/1327 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] huaxiangsun commented on issue #1327: brancBranch 2.hbase 23957
huaxiangsun commented on issue #1327: brancBranch 2.hbase 23957 URL: https://github.com/apache/hbase/pull/1327#issuecomment-602822563 TestHRegionWithInMemoryFlush test timed out, locally run of this test at my laptop passed for me. Does not seem related with the change here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1330: HBASE-24034 [Flakey Tests] A couple of fixes and cleanups
Apache-HBase commented on issue #1330: HBASE-24034 [Flakey Tests] A couple of fixes and cleanups URL: https://github.com/apache/hbase/pull/1330#issuecomment-602825787 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 16s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 4s | branch-2 passed | | +1 :green_heart: | spotbugs | 4m 28s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 57s | the patch passed | | -0 :warning: | checkstyle | 1m 16s | hbase-server: The patch generated 2 new + 69 unchanged - 4 fixed = 71 total (was 73) | | -0 :warning: | checkstyle | 0m 14s | hbase-rsgroup: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 15m 32s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 7m 21s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 51s | The patch does not generate ASF License warnings. | | | | 57m 15s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1330/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1330 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 3b88087212d7 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 94c06bd8f8 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1330/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1330/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-rsgroup.txt | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1330/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1323: HBASE-23981 PBType which is marked as IA.Public references protobuf M…
ndimiduk commented on issue #1323: HBASE-23981 PBType which is marked as IA.Public references protobuf M… URL: https://github.com/apache/hbase/pull/1323#issuecomment-602843351 Good find @Apache9 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] qiaoandxiang commented on issue #1328: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas…
qiaoandxiang commented on issue #1328: HBASE-23957 [flakey test]
client.TestMultiParallel fails to read hbas…
URL: https://github.com/apache/hbase/pull/1328#issuecomment-602843350
@HorizonNet Looked at it, found the following from the console, studying a
bit more.
12:18:35 Remote call on H12 failed
Error when executing always post condition:
java.io.IOException: Remote call on H12 failed
at hudson.remoting.Channel.call(Channel.java:963)
at hudson.FilePath.act(FilePath.java:1072)
at hudson.FilePath.act(FilePath.java:1061)
at hudson.tasks.junit.JUnitParser.parseResult(JUnitParser.java:114)
at
hudson.tasks.junit.JUnitResultArchiver.parse(JUnitResultArchiver.java:137)
at
hudson.tasks.junit.JUnitResultArchiver.parseAndAttach(JUnitResultArchiver.java:167)
at
hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:52)
at
hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:25)
at
org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.OutOfMemoryError: Java heap space
at java.util.Arrays.copyOf(Arrays.java:3332)
at
java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:124)
at
java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:448)
at java.lang.StringBuffer.append(StringBuffer.java:270)
at org.dom4j.io.SAXContentHandler.characters(SAXContentHandler.java:293)
at
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.characters(AbstractSAXParser.java:546)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:483)
at
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:842)
at
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:771)
at
com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
at
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1213)
at
com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:643)
at org.dom4j.io.SAXReader.read(SAXReader.java:465)
at org.dom4j.io.SAXReader.read(SAXReader.java:343)
at hudson.tasks.junit.SuiteResult.parse(SuiteResult.java:178)
at hudson.tasks.junit.TestResult.parse(TestResult.java:348)
at hudson.tasks.junit.TestResult.parsePossiblyEmpty(TestResult.java:281)
at hudson.tasks.junit.TestResult.parse(TestResult.java:206)
at hudson.tasks.junit.TestResult.parse(TestResult.java:178)
at hudson.tasks.junit.TestResult.(TestResult.java:143)
at
hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:146)
at
hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:118)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:3052)
at hudson.remoting.UserRequest.perform(UserRequest.java:212)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
... 4 more
[Pipeline] script
[Pipeline] {
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-23957) [flakey test] client.TestMultiParallel fails to read hbase-site.xml
[
https://issues.apache.org/jira/browse/HBASE-23957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065077#comment-17065077
]
Nick Dimiduk commented on HBASE-23957:
--
[~huaxiangsun] the target branches for this patch need to include at least
master, branch-2, and branch-2.3. Could be it also impacts earlier branches
too, i haven't looked. Mind checking the history on these three test classes?
> [flakey test] client.TestMultiParallel fails to read hbase-site.xml
> ---
>
> Key: HBASE-23957
> URL: https://issues.apache.org/jira/browse/HBASE-23957
> Project: HBase
> Issue Type: Test
> Components: test
>Reporter: Nick Dimiduk
>Priority: Minor
>
> Saw this on a [PreCommit
> run|https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1258/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt].
> Log file says
> {noformat}
> 2020-03-09 22:48:26,295 FATAL [Time-limited test] conf.Configuration(2853):
> error parsing conf hbase-site.xml
> java.io.FileNotFoundException:
> /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1258@2/yetus-jdk8-hadoop2-check/src/hbase-server/target/test-classes/hbase-site.xml
> (No such file or directory)
> at java.io.FileInputStream.open0(Native Method)
> at java.io.FileInputStream.open(FileInputStream.java:195)
> at java.io.FileInputStream.(FileInputStream.java:138)
> at java.io.FileInputStream.(FileInputStream.java:93)
> at
> sun.net.www.protocol.file.FileURLConnection.connect(FileURLConnection.java:90)
> at
> sun.net.www.protocol.file.FileURLConnection.getInputStream(FileURLConnection.java:188)
> at org.apache.hadoop.conf.Configuration.parse(Configuration.java:2672)
> at
> org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:2746)
> at
> org.apache.hadoop.conf.Configuration.loadResources(Configuration.java:2706)
> at
> org.apache.hadoop.conf.Configuration.getProps(Configuration.java:2579)
> at org.apache.hadoop.conf.Configuration.get(Configuration.java:1091)
> at
> org.apache.hadoop.conf.Configuration.getTrimmed(Configuration.java:1145)
> at
> org.apache.hadoop.conf.Configuration.getClass(Configuration.java:2363)
> at
> org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2793)
> at
> org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2810)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:100)
> at
> org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2849)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2831)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:389)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:181)
> at org.apache.hadoop.hbase.fs.HFileSystem.(HFileSystem.java:85)
> at org.apache.hadoop.hbase.fs.HFileSystem.get(HFileSystem.java:465)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getTestFileSystem(HBaseTestingUtility.java:3180)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getNewDataTestDirOnTestFS(HBaseTestingUtility.java:507)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.setupDataTestDirOnTestFS(HBaseTestingUtility.java:496)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getDataTestDirOnTestFS(HBaseTestingUtility.java:469)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getDataTestDirOnTestFS(HBaseTestingUtility.java:483)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.createDirsAndSetProperties(HBaseTestingUtility.java:651)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:603)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:586)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1039)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1004)
> at
> org.apache.hadoop.hbase.client.TestMultiParallel.beforeClass(TestMultiParallel.java:96)
> {noformat}
> This stage ran on H9.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] qiaoandxiang commented on issue #1328: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas…
qiaoandxiang commented on issue #1328: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas… URL: https://github.com/apache/hbase/pull/1328#issuecomment-602847295 The unittest did not finish because of out of heap memory error, let me retrigger the run. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-24036) [Flakey Tests] Re-enable TestClusterScopeQuotaThrottle#testUserNamespaceClusterScopeQuota
Michael Stack created HBASE-24036: - Summary: [Flakey Tests] Re-enable TestClusterScopeQuotaThrottle#testUserNamespaceClusterScopeQuota Key: HBASE-24036 URL: https://issues.apache.org/jira/browse/HBASE-24036 Project: HBase Issue Type: Sub-task Reporter: Michael Stack Disable in parent because flakey. Reenable after fix. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] qiaoandxiang commented on issue #1328: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas…
qiaoandxiang commented on issue #1328: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas… URL: https://github.com/apache/hbase/pull/1328#issuecomment-602857017 Touched the format of commit msg to trigger a new run. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1330: HBASE-24034 [Flakey Tests] A couple of fixes and cleanups
Apache-HBase commented on issue #1330: HBASE-24034 [Flakey Tests] A couple of fixes and cleanups URL: https://github.com/apache/hbase/pull/1330#issuecomment-602861878 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 4s | branch-2 passed | | +1 :green_heart: | compile | 1m 54s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 54s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 18s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 51s | the patch passed | | +1 :green_heart: | compile | 1m 53s | the patch passed | | +1 :green_heart: | javac | 1m 53s | the patch passed | | +1 :green_heart: | shadedjars | 4m 52s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 18s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 9s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 96m 54s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 3m 20s | hbase-rsgroup in the patch passed. | | | | 134m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1330/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1330 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 16e05faf1314 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 94c06bd8f8 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1330/1/testReport/ | | Max. process+thread count | 3840 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1330/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1330: HBASE-24034 [Flakey Tests] A couple of fixes and cleanups
Apache-HBase commented on issue #1330: HBASE-24034 [Flakey Tests] A couple of fixes and cleanups URL: https://github.com/apache/hbase/pull/1330#issuecomment-602863425 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 7m 19s | branch-2 passed | | +1 :green_heart: | compile | 2m 29s | branch-2 passed | | -1 :x: | shadedjars | 0m 10s | branch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 35s | hbase-client in branch-2 failed. | | -0 :warning: | javadoc | 0m 25s | hbase-rsgroup in branch-2 failed. | | -0 :warning: | javadoc | 0m 45s | hbase-server in branch-2 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 7m 9s | the patch passed | | +1 :green_heart: | compile | 2m 25s | the patch passed | | +1 :green_heart: | javac | 2m 25s | the patch passed | | -1 :x: | shadedjars | 0m 10s | patch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 32s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 47s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 23s | hbase-rsgroup in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 25s | hbase-client in the patch passed. | | -0 :warning: | unit | 104m 17s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 3m 25s | hbase-rsgroup in the patch passed. | | | | 137m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1330/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1330 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c520bdc4d939 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 94c06bd8f8 | | Default Java | 2020-01-14 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1330/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1330/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1330/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rsgroup.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1330/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1330/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1330/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1330/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1330/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rsgroup.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1330/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1330/1/testReport/ | | Max. process+thread count | 4050 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1330/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
[GitHub] [hbase] ndimiduk merged pull request #1313: HBASE-23980 Use enforcer plugin to print JVM info in maven output
ndimiduk merged pull request #1313: HBASE-23980 Use enforcer plugin to print JVM info in maven output URL: https://github.com/apache/hbase/pull/1313 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23980) Use enforcer plugin to print JVM info in maven output
[
https://issues.apache.org/jira/browse/HBASE-23980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-23980:
-
Fix Version/s: 3.0.0
> Use enforcer plugin to print JVM info in maven output
> -
>
> Key: HBASE-23980
> URL: https://issues.apache.org/jira/browse/HBASE-23980
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 3.0.0
>
>
> This is a little nice-to-have. We currently dump OS info using
> {{os-maven-plugin}}. Since we build on multiple JVM environments, would be
> nice to add that info too. Looking around, there wasn't an obvious source of
> this information, until I realized it's readily available via
> {{enforcer:display-info}}. Should add this to the top-level pom, if we can
> get it to run just once/build instead of with every module.
> {noformat}
> [INFO] --- maven-enforcer-plugin:3.0.0-M2:display-info (default-cli) @
> hbase-archetype-builder ---
> [INFO] Maven Version: 3.6.3
> [INFO] JDK Version: 1.8.0_222 normalized as: 1.8.0-222
> [INFO] OS Info: Arch: x86_64 Family: mac Name: mac os x Version: 10.14.6
> [INFO]
>
> {noformat}
> {noformat}
> [INFO] --- maven-enforcer-plugin:3.0.0-M2:display-info (default-cli) @
> hbase-archetype-builder ---
> [INFO] Maven Version: 3.6.3
> [INFO] JDK Version: 11.0.4 normalized as: 11.0.4
> [INFO] OS Info: Arch: x86_64 Family: mac Name: mac os x Version: 10.14.6
> [INFO]
>
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1328: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas…
Apache-HBase commented on issue #1328: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas… URL: https://github.com/apache/hbase/pull/1328#issuecomment-602871415 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 40s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 19s | branch-2.3 passed | | +1 :green_heart: | checkstyle | 1m 19s | branch-2.3 passed | | +1 :green_heart: | spotbugs | 2m 17s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 54s | the patch passed | | +1 :green_heart: | checkstyle | 1m 15s | hbase-server: The patch generated 0 new + 1 unchanged - 3 fixed = 1 total (was 4) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 13m 1s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 3m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. | | | | 45m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1328/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1328 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle xml | | uname | Linux 034f3248311d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / 12e5b07258 | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1328/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1313: HBASE-23980 Use enforcer plugin to print JVM info in maven output
Apache-HBase commented on issue #1313: HBASE-23980 Use enforcer plugin to print JVM info in maven output URL: https://github.com/apache/hbase/pull/1313#issuecomment-602872837 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 11m 23s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. | | | | 18m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1313 | | Optional Tests | dupname asflicense hadoopcheck xml | | uname | Linux 938a9ee08beb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2f26d8a623 | | Max. process+thread count | 76 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk opened a new pull request #1331: Backport "HBASE-23980 Use enforcer plugin to print JVM info in maven output" to branch-2
ndimiduk opened a new pull request #1331: Backport "HBASE-23980 Use enforcer plugin to print JVM info in maven output" to branch-2 URL: https://github.com/apache/hbase/pull/1331 Does what it says on the tin. Bound to `initialize` phase so that it runs early in lifecycle. Uses `false` so that the plugin will run only for the base pom's reactor stage and not for any children. Signed-off-by: Viraj Jasani Signed-off-by: Jan Hentschel This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk opened a new pull request #1332: Backport "HBASE-23980 Use enforcer plugin to print JVM info in maven output" to branch-2.3
ndimiduk opened a new pull request #1332: Backport "HBASE-23980 Use enforcer plugin to print JVM info in maven output" to branch-2.3 URL: https://github.com/apache/hbase/pull/1332 Does what it says on the tin. Bound to `initialize` phase so that it runs early in lifecycle. Uses `false` so that the plugin will run only for the base pom's reactor stage and not for any children. Signed-off-by: Viraj Jasani Signed-off-by: Jan Hentschel This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24032) [RSGroup] Assign created tables to respective rsgroup automatically instead of manual operations
[ https://issues.apache.org/jira/browse/HBASE-24032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065336#comment-17065336 ] Reid Chan commented on HBASE-24032: --- Applied to branch-1, branch-1.4 (I didn't see branch-1.5...), master. Need some works to apply patch to branch-2... > [RSGroup] Assign created tables to respective rsgroup automatically instead > of manual operations > - > > Key: HBASE-24032 > URL: https://issues.apache.org/jira/browse/HBASE-24032 > Project: HBase > Issue Type: Improvement > Components: master, rsgroup >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Major > > In prod practise, it's time consuming and tiring to assign tables to their > rsgroups for HBase admin by shell, especially in 1.x rsgroup client is > IA.private, we could not even write some programs to do that. > And I'm here proposing a solution to do the automated rsgroup assignment by > allowing running a shell in postCreateTable to determine which table should > go to which rsgroup (way in branch-1 not master). The benefit is obvious, > admin can determine or change at any time the mapping rule in script without > restarting or re-config anything. It's flexible, convenience and time saving. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1324: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t…
Apache-HBase commented on issue #1324: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t… URL: https://github.com/apache/hbase/pull/1324#issuecomment-603028239 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 7s | branch-2 passed | | +1 :green_heart: | compile | 1m 29s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 48s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 59s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 40s | the patch passed | | +1 :green_heart: | compile | 1m 30s | the patch passed | | +1 :green_heart: | javac | 1m 30s | the patch passed | | +1 :green_heart: | shadedjars | 4m 55s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 0s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 72m 51s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 3m 4s | hbase-rsgroup in the patch passed. | | | | 106m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1324 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 304a832e3420 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 50161f2de4 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/3/testReport/ | | Max. process+thread count | 5449 (vs. ulimit of 1) | | modules | C: hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/3/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23995) Snapshoting a splitting region results in corrupted snapshot
[
https://issues.apache.org/jira/browse/HBASE-23995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065182#comment-17065182
]
Josh Elser commented on HBASE-23995:
bq. And when snapshoting, we will hold the procedure lock on the table, and
when splitting, we will hold the procedure lock on the region thus also on the
table too, which will prevent them running together.
Glancing at branch-2, it looks like we grab a lock in the Master before taking
a snapshot (via LockManager/MasterLock), rather than a lock in PV2 which is
what the split/merge code would be grabbing. At least on the surface, it does
look like we have two competing "locking" solutions which are unaware of each
other, but I'm only looking on the surface. All of the snapshot "procedures"
are the old procedure(1) code.
Do we push Snapshots into PV2 and then rely on PV2 locking the whole way down?
Sounds like a good idea to dog-food this, but I'm wondering if there is a
reason we didn't port snapshots right away. Maybe you remember, Duo?
I know you've thought through some potential scenarios on a "less invasive"
fix, Szabolcs. Maybe share them here, with the downsides of them? e.g. detect
in-progress splits in prepareSnapshot, snapshot only on disabled tables, and
others.
> Snapshoting a splitting region results in corrupted snapshot
>
>
> Key: HBASE-23995
> URL: https://issues.apache.org/jira/browse/HBASE-23995
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Affects Versions: 2.0.2
>Reporter: Szabolcs Bukros
>Priority: Major
>
> The problem seems to originate from the fact that while the region split
> itself runs in a lock, the compactions following it run in separate threads.
> Alternatively the use of space quota policies can prevent compaction after a
> split and leads to the same issue.
> In both cases the resulting snapshot will keep the split status of the parent
> region, but do not keep the references to the daughter regions, because they
> (splitA, splitB qualifiers) are stored separately in the meta table and do
> not propagate with the snapshot.
> This is important because the in the freshly cloned table CatalogJanitor will
> find the parent region, realizes it is in split state, but because it can not
> find the daughter region references (haven't propagated) assumes parent could
> be cleaned up and deletes it. The archived region used in the snaphost only
> has back reference to the now also archived parent region and if the snapshot
> is deleted they both gets cleaned up. Unfortunately the daughter regions only
> contains hfile links, so at this point the data is lost.
> How to reproduce:
> {code:java}
> hbase shell < create 'test', 'cf'
> (0...2000).each{|i| put "test", "row#{i}", "cf:col", "val"}
> flush 'test'
> split 'test'
> snapshot 'test', 'testshot'
> EOF
> {code}
> This should make sure the snapshot is made before the compaction could be
> finished even with small amount of data.
> {code:java}
> sudo -u habse hbase org.apache.hadoop.hbase.snapshot.ExportSnapshot -snapshot
> testshot -copy-to hdfs://target:8020/apps/hbase/data/
> {code}
> I export the snapshot to make the usecase cleaner but deleting both the
> snapshot and the original table after the cloning should have the same effect.
> {code:java}
> clone_snapshot 'testshot', 'test2'
> delete_snapshot "testshot"
> {code}
> I'm not sure what would be the best way to fix this. Preventing snapshots
> when a region is in split state, would make snapshot creation problematic.
> Forcing to run compaction as part of the split thread would make it rather
> slow. Propagating the daughter region references could prevent the deletion
> of the cloned parent region and the data would not be broken anymore but I'm
> not sure we have a logic in place that could pick up the pieces and finish
> the split process.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23958) Balancer keeps balancing indefinitely
[
https://issues.apache.org/jira/browse/HBASE-23958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065192#comment-17065192
]
Nick Dimiduk commented on HBASE-23958:
--
Also, what's the intended {{affectsVerison}} here?
> Balancer keeps balancing indefinitely
> --
>
> Key: HBASE-23958
> URL: https://issues.apache.org/jira/browse/HBASE-23958
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment
>Affects Versions: 2.0.2
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Major
> Fix For: 2.3.0
>
>
> Before raising this issue - am not sure if this got fixed directly or
> indirectly in other latest versions of hbase.
> The steps are
> 1) Create a cluster and create some tables. (assume we have RS 1,2,3, 4 and
> 5)
> 2) After the table creation and some ops done, the cluster was restarted. Due
> to this some regions are in RIT. the RIT in progress was to be assigned to
> RS 3.
> 3) After the cluster comes back RS 3 and 4 are stopped. (RS 3 will have
> newer timestamp)
> 4) Now the master that comes up sees there are some RIT in place and tries to
> load the entries to process the procedures again. As part of this the
> RegionStateStore is populated with the old RS 3 hostname. (older timestamp).
> This adds to the ServerStateNode creating a RS 3 with old timestamp as one
> server.
> 5) Now after the master restarts and all regions assigned, the balancer
> infinitely tries to balance the region to the RS 3 (old timestamp server)
> thinking it is part of the cluster.
> 6)the other problem is the MoveProcedure has the target as RS 3 (with old
> timestamp) but the AM realizes that it is a down server and move it to the
> one of the active server. But this is not recorded anywhere.
> I will continue to check the latest code if this case is valid.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] nyl3532016 commented on a change in pull request #1324: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t…
nyl3532016 commented on a change in pull request #1324: HBASE-23949 refactor
loadBalancer implements for rsgroup balance by t…
URL: https://github.com/apache/hbase/pull/1324#discussion_r396869888
##
File path:
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java
##
@@ -110,50 +108,46 @@ public void setMasterServices(MasterServices
masterServices) {
this.masterServices = masterServices;
}
+ /**
+ * Override to balance by RSGroup
+ * not invoke {@link #balanceTable(TableName, Map)}
+ */
@Override
- public List balanceCluster(TableName tableName, Map>
- clusterState) throws HBaseIOException {
-return balanceCluster(clusterState);
- }
-
- @Override
- public List balanceCluster(Map>
clusterState)
- throws HBaseIOException {
+ public List balanceCluster(
+ Map>> loadOfAllTable) throws
IOException {
if (!isOnline()) {
throw new ConstraintException(RSGroupInfoManager.RSGROUP_TABLE_NAME +
" is not online, unable to perform balance");
}
-
-Map> correctedState =
correctAssignments(clusterState);
-List regionPlans = new ArrayList<>();
-
-List misplacedRegions =
correctedState.get(LoadBalancer.BOGUS_SERVER_NAME);
-for (RegionInfo regionInfo : misplacedRegions) {
- ServerName serverName = findServerForRegion(clusterState, regionInfo);
- regionPlans.add(new RegionPlan(regionInfo, serverName, null));
-}
+// Calculate correct assignments and a list of RegionPlan for mis-placed
regions
+Pair>>, List>
+ correctedStateAndRegionPlans = correctAssignments(loadOfAllTable);
+Map>> correctedLoadOfAllTable =
+correctedStateAndRegionPlans.getFirst();
+List regionPlans = correctedStateAndRegionPlans.getSecond();
+// Add RegionPlan
Review comment:
see TestRSGroupBasedLoadBalancer#testBalanceCluster , we add test for
rsgroup with bytable
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #1323: HBASE-23981 PBType which is marked as IA.Public references protobuf M…
Apache9 commented on issue #1323: HBASE-23981 PBType which is marked as IA.Public references protobuf M… URL: https://github.com/apache/hbase/pull/1323#issuecomment-603001960 > everything in hbase-examples should be IA.Public, right? In my opinion, No. For me, example means you can copy the code, but not depend on the code... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23957) [flakey test] client.TestMultiParallel fails to read hbase-site.xml
[
https://issues.apache.org/jira/browse/HBASE-23957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065308#comment-17065308
]
Huaxiang Sun commented on HBASE-23957:
--
[~ndimiduk], yep, I already pushed to master/branch-2/branch-2.3, branch-2.2 is
going on (need to check a few unitest failures before push). Plan to push to
branch-1 as well.
> [flakey test] client.TestMultiParallel fails to read hbase-site.xml
> ---
>
> Key: HBASE-23957
> URL: https://issues.apache.org/jira/browse/HBASE-23957
> Project: HBase
> Issue Type: Test
> Components: test
>Reporter: Nick Dimiduk
>Priority: Minor
>
> Saw this on a [PreCommit
> run|https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1258/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt].
> Log file says
> {noformat}
> 2020-03-09 22:48:26,295 FATAL [Time-limited test] conf.Configuration(2853):
> error parsing conf hbase-site.xml
> java.io.FileNotFoundException:
> /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1258@2/yetus-jdk8-hadoop2-check/src/hbase-server/target/test-classes/hbase-site.xml
> (No such file or directory)
> at java.io.FileInputStream.open0(Native Method)
> at java.io.FileInputStream.open(FileInputStream.java:195)
> at java.io.FileInputStream.(FileInputStream.java:138)
> at java.io.FileInputStream.(FileInputStream.java:93)
> at
> sun.net.www.protocol.file.FileURLConnection.connect(FileURLConnection.java:90)
> at
> sun.net.www.protocol.file.FileURLConnection.getInputStream(FileURLConnection.java:188)
> at org.apache.hadoop.conf.Configuration.parse(Configuration.java:2672)
> at
> org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:2746)
> at
> org.apache.hadoop.conf.Configuration.loadResources(Configuration.java:2706)
> at
> org.apache.hadoop.conf.Configuration.getProps(Configuration.java:2579)
> at org.apache.hadoop.conf.Configuration.get(Configuration.java:1091)
> at
> org.apache.hadoop.conf.Configuration.getTrimmed(Configuration.java:1145)
> at
> org.apache.hadoop.conf.Configuration.getClass(Configuration.java:2363)
> at
> org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2793)
> at
> org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2810)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:100)
> at
> org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2849)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2831)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:389)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:181)
> at org.apache.hadoop.hbase.fs.HFileSystem.(HFileSystem.java:85)
> at org.apache.hadoop.hbase.fs.HFileSystem.get(HFileSystem.java:465)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getTestFileSystem(HBaseTestingUtility.java:3180)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getNewDataTestDirOnTestFS(HBaseTestingUtility.java:507)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.setupDataTestDirOnTestFS(HBaseTestingUtility.java:496)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getDataTestDirOnTestFS(HBaseTestingUtility.java:469)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getDataTestDirOnTestFS(HBaseTestingUtility.java:483)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.createDirsAndSetProperties(HBaseTestingUtility.java:651)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:603)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:586)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1039)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1004)
> at
> org.apache.hadoop.hbase.client.TestMultiParallel.beforeClass(TestMultiParallel.java:96)
> {noformat}
> This stage ran on H9.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1324: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t…
Apache-HBase commented on issue #1324: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t… URL: https://github.com/apache/hbase/pull/1324#issuecomment-603014886 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 27s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 8m 48s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 22s | branch-2 passed | | +1 :green_heart: | spotbugs | 4m 14s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 8m 16s | the patch passed | | -0 :warning: | checkstyle | 1m 54s | hbase-server: The patch generated 1 new + 413 unchanged - 19 fixed = 414 total (was 432) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 15m 38s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 4m 32s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 32s | The patch does not generate ASF License warnings. | | | | 60m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1324 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 4d9c24904506 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 50161f2de4 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1324/3/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-23919) [Flakey Test] Standalone Zookeeper won't start (minizookeepercluster won't come up)
[
https://issues.apache.org/jira/browse/HBASE-23919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-23919.
---
Resolution: Not A Problem
HBASE-23993 fixed this condition
> [Flakey Test] Standalone Zookeeper won't start (minizookeepercluster won't
> come up)
> ---
>
> Key: HBASE-23919
> URL: https://issues.apache.org/jira/browse/HBASE-23919
> Project: HBase
> Issue Type: Bug
> Components: flakies
>Reporter: Michael Stack
>Priority: Major
>
> I've seen this on occasion across different hardwares; the standalone
> zookeeper won't come up and then random unit test fails in its junit startup
> phase as part of launching mini cluster.
> I've been trying to track this w/ a while now adding in logging, using more
> of zk client instead of the copy/paste we've had a long while now, and adding
> in logging (I've been running locally w/ zk logging set to INFO).
> It looks like this currently where the last thing out of the server launch is
> this
> {code:java}
> 2020-03-02 07:57:46,129 INFO [Time-limited test]
> server.ZooKeeperServer(854): maxSessionTimeout set to -1
>
> 2020-03-02 07:57:46,139 INFO [Time-limited test]
> server.NIOServerCnxnFactory(89): binding to port 0.0.0.0/0.0.0.0:49316
>
> 2020-03-02 07:57:46,181 INFO [Time-limited test]
> zookeeper.MiniZooKeeperCluster(256): Started connectionTimeout=3,
> dir=/Users/stack/checkouts/hbase.git/hbase-server/target/test-data/89d57393-fe97-9200-630f-7843ee406bd2/
> cluster_6b4d6f67-7978-dc67-a1a3-7b1b0c0e4268/zookeeper_0,
> clientPort=49316,
> dataDir=/Users/stack/checkouts/hbase.git/hbase-server/target/test-data/89d57393-fe97-9200-630f-7843ee406bd2/cluster_6b4d6f67-7978-dc67-a1a3-7b1b0c0e4268/
> zookeeper_0/version-2,
> dataLogDir=/Users/stack/checkouts/hbase.git/hbase-server/target/test-data/89d57393-fe97-9200-630f-7843ee406bd2/cluster_6b4d6f67-7978-dc67-a1a3-7b1b0c0e4268/zookeeper_0/version-2,
> tickTime=2000, maxClientCnxns=300, minSessionTimeout=4000,
> maxSessionTimeout=4, serverId=0{code}
> ... then the client just does this over and over:
> {code:java}
> 2020-03-02 07:57:46,182 INFO [Time-limited test]
> client.FourLetterWordMain(65): connecting to localhost 49316
>
> 2020-03-02 07:57:46,213 INFO [Time-limited test]
> zookeeper.MiniZooKeeperCluster(453): localhost:49316 not up
>
> java.net.SocketException: Connection reset
>
>
> at
> java.net.SocketInputStream.read(SocketInputStream.java:209)
>
>at
> java.net.SocketInputStream.read(SocketInputStream.java:141)
>
>at
> sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:284)
>
>at
> sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:326)
>
>at
> sun.nio.cs.StreamDecoder.read(StreamDecoder.java:178)
>
>at
> java.io.InputStreamReader.read(InputStreamReader.java:184)
>
>at
> java.io.BufferedReader.fill(BufferedReader.java:161)
>
>at
>
[GitHub] [hbase] Reidddddd commented on issue #1319: HBASE-24032 [RSGroup] Assign created tables to respective rsgroup aut…
Reidd commented on issue #1319: HBASE-24032 [RSGroup] Assign created tables to respective rsgroup aut… URL: https://github.com/apache/hbase/pull/1319#issuecomment-603025385 Thanks for the review! @binlijin This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd merged pull request #1319: HBASE-24032 [RSGroup] Assign created tables to respective rsgroup aut…
Reidd merged pull request #1319: HBASE-24032 [RSGroup] Assign created tables to respective rsgroup aut… URL: https://github.com/apache/hbase/pull/1319 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24032) [RSGroup] Assign created tables to respective rsgroup automatically instead of manual operations
[ https://issues.apache.org/jira/browse/HBASE-24032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-24032: -- Fix Version/s: 1.4.14 1.7.0 master > [RSGroup] Assign created tables to respective rsgroup automatically instead > of manual operations > - > > Key: HBASE-24032 > URL: https://issues.apache.org/jira/browse/HBASE-24032 > Project: HBase > Issue Type: Improvement > Components: master, rsgroup >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Major > Fix For: master, 1.7.0, 1.4.14 > > > In prod practise, it's time consuming and tiring to assign tables to their > rsgroups for HBase admin by shell, especially in 1.x rsgroup client is > IA.private, we could not even write some programs to do that. > And I'm here proposing a solution to do the automated rsgroup assignment by > allowing running a shell in postCreateTable to determine which table should > go to which rsgroup (way in branch-1 not master). The benefit is obvious, > admin can determine or change at any time the mapping rule in script without > restarting or re-config anything. It's flexible, convenience and time saving. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22740) [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x
[ https://issues.apache.org/jira/browse/HBASE-22740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-22740: -- Fix Version/s: 2.2.5 master 2.3.0 > [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x > -- > > Key: HBASE-22740 > URL: https://issues.apache.org/jira/browse/HBASE-22740 > Project: HBase > Issue Type: Bug > Components: rsgroup >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Major > Fix For: 2.3.0, master, 2.2.5 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-22740) [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x
[ https://issues.apache.org/jira/browse/HBASE-22740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065329#comment-17065329 ] Reid Chan commented on HBASE-22740: --- Applied to master, branch-2, branch-2.3 and branch 2.2 > [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x > -- > > Key: HBASE-22740 > URL: https://issues.apache.org/jira/browse/HBASE-22740 > Project: HBase > Issue Type: Bug > Components: rsgroup >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Major > Fix For: 2.3.0, master, 2.2.5 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Reidddddd merged pull request #1318: HBASE-24032 [RSGroup] Assign created tables to respective rsgroup aut…
Reidd merged pull request #1318: HBASE-24032 [RSGroup] Assign created tables to respective rsgroup aut… URL: https://github.com/apache/hbase/pull/1318 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1336: HBASE-24037 Add ut for root dir and wal root dir are different
Apache-HBase commented on issue #1336: HBASE-24037 Add ut for root dir and wal root dir are different URL: https://github.com/apache/hbase/pull/1336#issuecomment-603023567 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 45s | master passed | | +1 :green_heart: | compile | 0m 59s | master passed | | +1 :green_heart: | shadedjars | 5m 6s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 29s | the patch passed | | +1 :green_heart: | compile | 1m 0s | the patch passed | | +1 :green_heart: | javac | 1m 0s | the patch passed | | +1 :green_heart: | shadedjars | 5m 0s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 62m 46s | hbase-server in the patch passed. | | | | 90m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1336/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1336 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c0dce18fee7a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / bdcfd6a4a8 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1336/1/testReport/ | | Max. process+thread count | 5851 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1336/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-22740) [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x
[ https://issues.apache.org/jira/browse/HBASE-22740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-22740. --- Hadoop Flags: Reviewed Resolution: Fixed > [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x > -- > > Key: HBASE-22740 > URL: https://issues.apache.org/jira/browse/HBASE-22740 > Project: HBase > Issue Type: Bug > Components: rsgroup >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Major > Fix For: 2.3.0, master, 2.2.5 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1293: HBASE-23970 TestUsersOperationsWithSecureHadoop fails when an existing ticket is present
Apache-HBase commented on issue #1293: HBASE-23970 TestUsersOperationsWithSecureHadoop fails when an existing ticket is present URL: https://github.com/apache/hbase/pull/1293#issuecomment-603032764 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 35s | master passed | | +1 :green_heart: | compile | 1m 6s | master passed | | -1 :x: | shadedjars | 0m 11s | branch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in master failed. | | -0 :warning: | patch | 1m 6s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 31s | the patch passed | | +1 :green_heart: | compile | 1m 7s | the patch passed | | +1 :green_heart: | javac | 1m 7s | the patch passed | | -1 :x: | shadedjars | 0m 10s | patch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -0 :warning: | unit | 110m 16s | hbase-server in the patch failed. | | | | 130m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1293/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1293 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3eef14fa91b9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / bdcfd6a4a8 | | Default Java | 2020-01-14 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1293/3/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1293/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1293/3/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1293/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1293/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1293/3/testReport/ | | Max. process+thread count | 5405 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1293/3/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1331: Backport "HBASE-23980 Use enforcer plugin to print JVM info in maven output" to branch-2
Apache-HBase commented on issue #1331: Backport "HBASE-23980 Use enforcer plugin to print JVM info in maven output" to branch-2 URL: https://github.com/apache/hbase/pull/1331#issuecomment-602885878 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 20s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | ||| _ Patch Compile Tests _ | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 12m 14s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. | | | | 21m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1331/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1331 | | Optional Tests | dupname asflicense hadoopcheck xml | | uname | Linux 69115da13d8d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 1147c23627 | | Max. process+thread count | 63 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1331/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1313: HBASE-23980 Use enforcer plugin to print JVM info in maven output
Apache-HBase commented on issue #1313: HBASE-23980 Use enforcer plugin to print JVM info in maven output URL: https://github.com/apache/hbase/pull/1313#issuecomment-602886152 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 22s | master passed | | +1 :green_heart: | compile | 3m 21s | master passed | | +1 :green_heart: | shadedjars | 5m 9s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 45s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 29s | the patch passed | | +1 :green_heart: | compile | 3m 34s | the patch passed | | +1 :green_heart: | javac | 3m 34s | the patch passed | | +1 :green_heart: | shadedjars | 7m 1s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 49s | root in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 14m 45s | root in the patch failed. | | | | 51m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1313 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 56ae4c6d6163 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2f26d8a623 | | Default Java | 1.8.0_232 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/2/artifact/yetus-jdk8-hadoop2-check/output/patch-javadoc-root.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/2/testReport/ | | Max. process+thread count | 812 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
