mattf-apache commented on a change in pull request #1643:
URL: https://github.com/apache/hbase/pull/1643#discussion_r420526164
##
File path: dev-support/create-release/release-build.sh
##
@@ -20,114 +20,180 @@
trap cleanup EXIT
# Source in utils.
-SELF=$(cd $(dirname $0)
Apache-HBase commented on pull request #1593:
URL: https://github.com/apache/hbase/pull/1593#issuecomment-624430676
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #1662:
URL: https://github.com/apache/hbase/pull/1662#issuecomment-624430786
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
mattf-apache commented on a change in pull request #1643:
URL: https://github.com/apache/hbase/pull/1643#discussion_r420526164
##
File path: dev-support/create-release/release-build.sh
##
@@ -20,114 +20,180 @@
trap cleanup EXIT
# Source in utils.
-SELF=$(cd $(dirname $0)
[
https://issues.apache.org/jira/browse/HBASE-24118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-24118.
---
Resolution: Fixed
Re-resolving.
For those trying to follow-behind, there were FOUR commits
[
https://issues.apache.org/jira/browse/HBASE-23785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100336#comment-17100336
]
Michael Stack edited comment on HBASE-23785 at 5/6/20, 5:12 AM:
Needs
mattf-apache commented on a change in pull request #1643:
URL: https://github.com/apache/hbase/pull/1643#discussion_r420554402
##
File path: dev-support/create-release/release-build.sh
##
@@ -20,114 +20,180 @@
trap cleanup EXIT
# Source in utils.
-SELF=$(cd $(dirname $0)
nyl3532016 edited a comment on pull request #1629:
URL: https://github.com/apache/hbase/pull/1629#issuecomment-624068135
@saintstack could you help review this one ? This patch is related to
HBASE-24250
This is an automated
mattf-apache commented on a change in pull request #1643:
URL: https://github.com/apache/hbase/pull/1643#discussion_r420520956
##
File path: dev-support/create-release/release-build.sh
##
@@ -20,114 +20,180 @@
trap cleanup EXIT
# Source in utils.
-SELF=$(cd $(dirname $0)
gjacoby126 commented on a change in pull request #1655:
URL: https://github.com/apache/hbase/pull/1655#discussion_r420520899
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScanInfo.java
##
@@ -174,8 +174,13 @@ public boolean
nyl3532016 commented on a change in pull request #1629:
URL: https://github.com/apache/hbase/pull/1629#discussion_r420518956
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/GCMultipleMergedRegionsProcedure.java
##
@@ -78,6 +78,13 @@
Apache-HBase commented on pull request #1656:
URL: https://github.com/apache/hbase/pull/1656#issuecomment-624421167
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 4m
mattf-apache commented on a change in pull request #1643:
URL: https://github.com/apache/hbase/pull/1643#discussion_r420526164
##
File path: dev-support/create-release/release-build.sh
##
@@ -20,114 +20,180 @@
trap cleanup EXIT
# Source in utils.
-SELF=$(cd $(dirname $0)
jojochuang commented on pull request #1342:
URL: https://github.com/apache/hbase/pull/1342#issuecomment-624440493
+1 although I don't understand why, but the test no longer fails.
This is an automated message from the Apache
saintstack commented on a change in pull request #1643:
URL: https://github.com/apache/hbase/pull/1643#discussion_r420552836
##
File path: dev-support/create-release/do-release.sh
##
@@ -66,26 +82,34 @@ function should_build {
fi
}
-if should_build "tag" && [ $SKIP_TAG =
saintstack commented on a change in pull request #1643:
URL: https://github.com/apache/hbase/pull/1643#discussion_r420552786
##
File path: dev-support/create-release/release-build.sh
##
@@ -20,114 +20,180 @@
trap cleanup EXIT
# Source in utils.
-SELF=$(cd $(dirname $0) &&
saintstack commented on a change in pull request #1643:
URL: https://github.com/apache/hbase/pull/1643#discussion_r420552955
##
File path: dev-support/create-release/do-release.sh
##
@@ -66,26 +82,34 @@ function should_build {
fi
}
-if should_build "tag" && [ $SKIP_TAG =
saintstack commented on a change in pull request #1643:
URL: https://github.com/apache/hbase/pull/1643#discussion_r420552985
##
File path: dev-support/create-release/do-release-docker.sh
##
@@ -64,24 +65,26 @@ This script runs the release scripts inside a docker image.
mattf-apache commented on a change in pull request #1643:
URL: https://github.com/apache/hbase/pull/1643#discussion_r420553720
##
File path: dev-support/create-release/do-release.sh
##
@@ -66,26 +82,34 @@ function should_build {
fi
}
-if should_build "tag" && [ $SKIP_TAG
mattf-apache commented on a change in pull request #1643:
URL: https://github.com/apache/hbase/pull/1643#discussion_r420553720
##
File path: dev-support/create-release/do-release.sh
##
@@ -66,26 +82,34 @@ function should_build {
fi
}
-if should_build "tag" && [ $SKIP_TAG
Apache-HBase commented on pull request #1661:
URL: https://github.com/apache/hbase/pull/1661#issuecomment-624415634
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
mattf-apache commented on a change in pull request #1643:
URL: https://github.com/apache/hbase/pull/1643#discussion_r420508959
##
File path: dev-support/create-release/release-build.sh
##
@@ -20,114 +20,180 @@
trap cleanup EXIT
# Source in utils.
-SELF=$(cd $(dirname $0)
nyl3532016 commented on a change in pull request #1629:
URL: https://github.com/apache/hbase/pull/1629#discussion_r420518956
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/GCMultipleMergedRegionsProcedure.java
##
@@ -78,6 +78,13 @@
Apache-HBase commented on pull request #1656:
URL: https://github.com/apache/hbase/pull/1656#issuecomment-624419193
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 4m
gjacoby126 commented on a change in pull request #1655:
URL: https://github.com/apache/hbase/pull/1655#discussion_r420527391
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScanOptions.java
##
@@ -64,4 +66,10 @@ default void readAllVersions() {
mattf-apache commented on a change in pull request #1643:
URL: https://github.com/apache/hbase/pull/1643#discussion_r420508959
##
File path: dev-support/create-release/release-build.sh
##
@@ -20,114 +20,180 @@
trap cleanup EXIT
# Source in utils.
-SELF=$(cd $(dirname $0)
Apache-HBase commented on pull request #1593:
URL: https://github.com/apache/hbase/pull/1593#issuecomment-624432537
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-24307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-24307.
---
Assignee: Michael Stack
Resolution: Fixed
Pushed on branch-2.3+
> [Flakey Tests] krb
[
https://issues.apache.org/jira/browse/HBASE-23976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-23976.
---
Fix Version/s: 2.3.0
3.0.0-alpha-1
Hadoop Flags: Reviewed
saintstack commented on pull request #1415:
URL: https://github.com/apache/hbase/pull/1415#issuecomment-624446446
@shenshengli have you seen the @ndimiduk comment above? Any response?
Thank you.
This is an automated
saintstack commented on pull request #1628:
URL: https://github.com/apache/hbase/pull/1628#issuecomment-624446854
Approved for master. You think this good for branch-2 and branch-2.3
@Apache9 . I suppose it ok. Go for it.
Apache-HBase commented on pull request #1643:
URL: https://github.com/apache/hbase/pull/1643#issuecomment-624452897
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #1643:
URL: https://github.com/apache/hbase/pull/1643#issuecomment-624452673
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Apache-HBase commented on pull request #1628:
URL: https://github.com/apache/hbase/pull/1628#issuecomment-624456292
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m
[
https://issues.apache.org/jira/browse/HBASE-24314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100405#comment-17100405
]
Hudson commented on HBASE-24314:
Results for branch branch-2
[build #2644 on
[
https://issues.apache.org/jira/browse/HBASE-24322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100406#comment-17100406
]
Hudson commented on HBASE-24322:
Results for branch branch-2
[build #2644 on
[
https://issues.apache.org/jira/browse/HBASE-24311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100404#comment-17100404
]
Hudson commented on HBASE-24311:
Results for branch branch-2
[build #2644 on
Apache-HBase commented on pull request #1628:
URL: https://github.com/apache/hbase/pull/1628#issuecomment-624412558
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
binlijin commented on a change in pull request #1588:
URL: https://github.com/apache/hbase/pull/1588#discussion_r420518128
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/CompactionThroughputControllerFactory.java
##
@@ -47,24 +53,35 @@
Apache-HBase commented on pull request #1660:
URL: https://github.com/apache/hbase/pull/1660#issuecomment-624420028
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache9 commented on a change in pull request #1655:
URL: https://github.com/apache/hbase/pull/1655#discussion_r420522949
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/SimpleRegionObserver.java
##
@@ -685,6 +687,40 @@ public StoreFileReader
Apache9 commented on a change in pull request #1655:
URL: https://github.com/apache/hbase/pull/1655#discussion_r420529237
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScanOptions.java
##
@@ -64,4 +66,13 @@ default void readAllVersions() {
huaxiangsun commented on a change in pull request #1629:
URL: https://github.com/apache/hbase/pull/1629#discussion_r419797107
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/GCMultipleMergedRegionsProcedure.java
##
@@ -78,6 +78,13 @@
[
https://issues.apache.org/jira/browse/HBASE-24118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100446#comment-17100446
]
Michael Stack edited comment on HBASE-24118 at 5/6/20, 4:12 AM:
[
https://issues.apache.org/jira/browse/HBASE-24118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack reopened HBASE-24118:
---
Reopening. I needed to undo more; add back the problematic bit:
diff --git
Apache-HBase commented on pull request #1655:
URL: https://github.com/apache/hbase/pull/1655#issuecomment-624431932
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-24331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100459#comment-17100459
]
Michael Stack commented on HBASE-24331:
---
[~markrmiller] I pushed the parent issue which has
Apache-HBase commented on pull request #1662:
URL: https://github.com/apache/hbase/pull/1662#issuecomment-624437948
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 4m
Apache-HBase commented on pull request #1657:
URL: https://github.com/apache/hbase/pull/1657#issuecomment-62946
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
saintstack commented on a change in pull request #1643:
URL: https://github.com/apache/hbase/pull/1643#discussion_r420552310
##
File path: dev-support/create-release/release-build.sh
##
@@ -20,114 +20,180 @@
trap cleanup EXIT
# Source in utils.
-SELF=$(cd $(dirname $0) &&
saintstack commented on pull request #1643:
URL: https://github.com/apache/hbase/pull/1643#issuecomment-624448967
@busbey and @ndimiduk You both are about to RM. You could review this as
sub-task of RM'ing but may I suggest that you'll have your hands full RM'ing
anyways; just take what
saintstack commented on a change in pull request #1643:
URL: https://github.com/apache/hbase/pull/1643#discussion_r420552406
##
File path: dev-support/create-release/release-build.sh
##
@@ -20,114 +20,180 @@
trap cleanup EXIT
# Source in utils.
-SELF=$(cd $(dirname $0) &&
Apache-HBase commented on pull request #1648:
URL: https://github.com/apache/hbase/pull/1648#issuecomment-623974017
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
bsglz commented on pull request #1500:
URL: https://github.com/apache/hbase/pull/1500#issuecomment-623977565
rebase
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/HBASE-24311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anoop Sam John resolved HBASE-24311.
Hadoop Flags: Reviewed
Resolution: Fixed
Pushed to branch-2 and master. Thanks all
nyl3532016 removed a comment on pull request #1629:
URL: https://github.com/apache/hbase/pull/1629#issuecomment-623927540
@huaxiangsun, thanks for review .
Yes,I think you can submit another PR for HBASE-24316
This is
Apache-HBase commented on pull request #1552:
URL: https://github.com/apache/hbase/pull/1552#issuecomment-624003442
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #1500:
URL: https://github.com/apache/hbase/pull/1500#issuecomment-623988245
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #1500:
URL: https://github.com/apache/hbase/pull/1500#issuecomment-623989415
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #1593:
URL: https://github.com/apache/hbase/pull/1593#issuecomment-623989541
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-24250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099795#comment-17099795
]
niuyulin commented on HBASE-24250:
--
[~huaxiangsun] yes, You are right! The deleteMergeQualifiers
Apache9 commented on a change in pull request #1639:
URL: https://github.com/apache/hbase/pull/1639#discussion_r420052958
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/ServerName.java
##
@@ -366,22 +286,32 @@ public int hashCode() {
@Override
public
[
https://issues.apache.org/jira/browse/HBASE-24262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099778#comment-17099778
]
Junhong Xu commented on HBASE-24262:
Got it, thank you [~y_static_y]
> Improvement update_config
[
https://issues.apache.org/jira/browse/HBASE-24315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099818#comment-17099818
]
Duo Zhang commented on HBASE-24315:
---
Thanks [~stack] and [~janh] for reviewing.
> Remove
[
https://issues.apache.org/jira/browse/HBASE-24311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099816#comment-17099816
]
Anoop Sam John commented on HBASE-24311:
Ya we have seen.. So I thought it will be better if we
[
https://issues.apache.org/jira/browse/HBASE-24315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-24315.
---
Hadoop Flags: Reviewed
Resolution: Fixed
> Remove hadoop-two-compat.xml in hbase-assembly
>
[
https://issues.apache.org/jira/browse/HBASE-24169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-24169:
--
Release Note:
The 'hadoop-2.0' profile has been removed. Now execute mvn command without
[
https://issues.apache.org/jira/browse/HBASE-24169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-24169.
---
Resolution: Fixed
> Drop hadoop 2 support for hbase 3.x
> ---
>
>
[
https://issues.apache.org/jira/browse/HBASE-19146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099812#comment-17099812
]
Martin Tzvetanov Grigorov commented on HBASE-19146:
---
I've just build `master` branch
Apache-HBase commented on pull request #1257:
URL: https://github.com/apache/hbase/pull/1257#issuecomment-624023828
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #1257:
URL: https://github.com/apache/hbase/pull/1257#issuecomment-623978763
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #1500:
URL: https://github.com/apache/hbase/pull/1500#issuecomment-623992799
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #1653:
URL: https://github.com/apache/hbase/pull/1653#issuecomment-623979514
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
martin-g commented on pull request #1186:
URL: https://github.com/apache/hbase/pull/1186#issuecomment-624005070
@saintstack Perfect! I just tried to build `master` and there are no issues
related to PB anymore!
There are few unit tests and several IT tests failing here but none of them
201 - 274 of 274 matches
Mail list logo
