[GitHub] [hbase] Apache9 commented on a change in pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion

2020-05-31 Thread GitBox
Apache9 commented on a change in pull request #1811: URL: https://github.com/apache/hbase/pull/1811#discussion_r432913204 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegion.java ## @@ -284,18 +284,21 @@ public static LocalRegion

[GitHub] [hbase] Apache-HBase commented on pull request #1801: [HBASE-24441]CacheConfig details logged at Store open is not really u…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1801: URL: https://github.com/apache/hbase/pull/1801#issuecomment-636427775 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache9 commented on a change in pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion

2020-05-31 Thread GitBox
Apache9 commented on a change in pull request #1811: URL: https://github.com/apache/hbase/pull/1811#discussion_r432913252 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegionFactory.java ## @@ -89,45 +82,8 @@ private static final

[GitHub] [hbase] Apache-HBase commented on pull request #1803: [HBASE-24468]Add region info when log meessages in HStore.

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1803: URL: https://github.com/apache/hbase/pull/1803#issuecomment-636428434 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-636430851 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-636431557 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #1801: [HBASE-24441]CacheConfig details logged at Store open is not really u…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1801: URL: https://github.com/apache/hbase/pull/1801#issuecomment-636431530 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] songxincun commented on pull request #1803: [HBASE-24468]Add region info when log meessages in HStore.

2020-05-31 Thread GitBox
songxincun commented on pull request #1803: URL: https://github.com/apache/hbase/pull/1803#issuecomment-636434718 @saintstack @anoopsjohn I changed HStore#toString from "getColumnFamilyName" to "getShortNameToLog/getColumnFamilyName", getShortNameToLog is actually what

[GitHub] [hbase] songxincun commented on a change in pull request #1801: [HBASE-24441]CacheConfig details logged at Store open is not really u…

2020-05-31 Thread GitBox
songxincun commented on a change in pull request #1801: URL: https://github.com/apache/hbase/pull/1801#discussion_r432919519 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -379,6 +379,9 @@ private MemStore getMemstore() {

[GitHub] [hbase] songxincun commented on a change in pull request #1801: [HBASE-24441]CacheConfig details logged at Store open is not really u…

2020-05-31 Thread GitBox
songxincun commented on a change in pull request #1801: URL: https://github.com/apache/hbase/pull/1801#discussion_r432919519 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -379,6 +379,9 @@ private MemStore getMemstore() {

[GitHub] [hbase] Apache-HBase commented on pull request #1817: HBASE-24412 Canary support check only one column family per RegionTask

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1817: URL: https://github.com/apache/hbase/pull/1817#issuecomment-636437479 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1801: [HBASE-24441]CacheConfig details logged at Store open is not really u…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1801: URL: https://github.com/apache/hbase/pull/1801#issuecomment-636441598 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1803: [HBASE-24468]Add region info when log meessages in HStore.

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1803: URL: https://github.com/apache/hbase/pull/1803#issuecomment-636446182 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] mmpataki commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-05-31 Thread GitBox
mmpataki commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-636447111 Updated the conf key name in HttpServer.java This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-636427405 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1817: HBASE-24412 Canary support check only one column family per RegionTask

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1817: URL: https://github.com/apache/hbase/pull/1817#issuecomment-636427424 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] anoopsjohn commented on a change in pull request #1801: [HBASE-24441]CacheConfig details logged at Store open is not really u…

2020-05-31 Thread GitBox
anoopsjohn commented on a change in pull request #1801: URL: https://github.com/apache/hbase/pull/1801#discussion_r432914093 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -379,6 +379,9 @@ private MemStore getMemstore() {

[GitHub] [hbase] Apache-HBase commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-636432545 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-23349) Low refCount preventing archival of compacted away files

2020-05-31 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-23349: - Status: Open (was: Patch Available) > Low refCount preventing archival of compacted away files

[GitHub] [hbase] Apache-HBase commented on pull request #1801: [HBASE-24441]CacheConfig details logged at Store open is not really u…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1801: URL: https://github.com/apache/hbase/pull/1801#issuecomment-636428565 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-636428793 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] songxincun commented on a change in pull request #1801: [HBASE-24441]CacheConfig details logged at Store open is not really u…

2020-05-31 Thread GitBox
songxincun commented on a change in pull request #1801: URL: https://github.com/apache/hbase/pull/1801#discussion_r432919519 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -379,6 +379,9 @@ private MemStore getMemstore() {

[GitHub] [hbase] Apache-HBase commented on pull request #1817: HBASE-24412 Canary support check only one column family per RegionTask

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1817: URL: https://github.com/apache/hbase/pull/1817#issuecomment-636436907 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1803: [HBASE-24468]Add region info when log meessages in HStore.

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1803: URL: https://github.com/apache/hbase/pull/1803#issuecomment-636438800 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Issue Comment Deleted] (HBASE-24441) CacheConfig details logged at Store open is not really useful

2020-05-31 Thread song XinCun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] song XinCun updated HBASE-24441: Comment: was deleted (was: Log after patch would look like: {code:java} 2020-05-28 21:35:46,842

[jira] [Updated] (HBASE-24456) Immutable Scan as unmodifiable subclass or wrapper of Scan

2020-05-31 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24456: - Status: Patch Available (was: In Progress) > Immutable Scan as unmodifiable subclass or

[jira] [Work started] (HBASE-24456) Immutable Scan as unmodifiable subclass or wrapper of Scan

2020-05-31 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24456 started by Viraj Jasani. > Immutable Scan as unmodifiable subclass or wrapper of Scan >

[GitHub] [hbase] Apache-HBase commented on pull request #1803: [HBASE-24468]Add region info when log meessages in HStore.

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1803: URL: https://github.com/apache/hbase/pull/1803#issuecomment-636462817 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani opened a new pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoB…

2020-05-31 Thread GitBox
virajjasani opened a new pull request #1818: URL: https://github.com/apache/hbase/pull/1818 …uilder This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (HBASE-23716) [hbase-thirdparty] Make release 3.2.0

2020-05-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120469#comment-17120469 ] Hudson commented on HBASE-23716: Results for branch branch-2.3 [build #114 on

[jira] [Commented] (HBASE-23715) MasterFileSystem should not create MasterProcWALs dir on fresh installs

2020-05-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120471#comment-17120471 ] Hudson commented on HBASE-23715: Results for branch branch-2.3 [build #114 on

[jira] [Commented] (HBASE-23941) get_slowlog_responses filters with AND/OR operator support

2020-05-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120470#comment-17120470 ] Hudson commented on HBASE-23941: Results for branch branch-2.3 [build #114 on

[GitHub] [hbase] Apache-HBase commented on pull request #1801: [HBASE-24441]CacheConfig details logged at Store open is not really u…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1801: URL: https://github.com/apache/hbase/pull/1801#issuecomment-636449397 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1803: [HBASE-24468]Add region info when log meessages in HStore.

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1803: URL: https://github.com/apache/hbase/pull/1803#issuecomment-636450241 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-636450950 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-636452417 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-20904) Prometheus /metrics http endpoint for monitoring integration

2020-05-31 Thread Madhusoodan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120482#comment-17120482 ] Madhusoodan commented on HBASE-20904: - As you may already know we built a new API to record metrics,

[GitHub] [hbase] songxincun commented on a change in pull request #1801: [HBASE-24441]CacheConfig details logged at Store open is not really u…

2020-05-31 Thread GitBox
songxincun commented on a change in pull request #1801: URL: https://github.com/apache/hbase/pull/1801#discussion_r432919519 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -379,6 +379,9 @@ private MemStore getMemstore() {

[jira] [Commented] (HBASE-24454) BucketCache disabled instantly before error duration toleration is reached due to timing issue

2020-05-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120507#comment-17120507 ] Hudson commented on HBASE-24454: Results for branch branch-1 [build #1304 on

[jira] [Created] (HBASE-24478) The regionInfo parameter for MasterProcedureScheduler#waitRegions should be plural

2020-05-31 Thread song XinCun (Jira)
song XinCun created HBASE-24478: --- Summary: The regionInfo parameter for MasterProcedureScheduler#waitRegions should be plural Key: HBASE-24478 URL: https://issues.apache.org/jira/browse/HBASE-24478

[GitHub] [hbase] Apache-HBase commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoB…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-636467951 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1803: [HBASE-24468]Add region info when log meessages in HStore.

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1803: URL: https://github.com/apache/hbase/pull/1803#issuecomment-636474521 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-636451274 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] songxincun commented on pull request #1803: [HBASE-24468]Add region info when log meessages in HStore.

2020-05-31 Thread GitBox
songxincun commented on pull request #1803: URL: https://github.com/apache/hbase/pull/1803#issuecomment-636457128 @anoopsjohn Thanks for the review. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] songxincun opened a new pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…

2020-05-31 Thread GitBox
songxincun opened a new pull request #1819: URL: https://github.com/apache/hbase/pull/1819 …tRegions should be plural This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (HBASE-24478) The regionInfo parameter for MasterProcedureScheduler#waitRegions should be plural

2020-05-31 Thread song XinCun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120545#comment-17120545 ] song XinCun commented on HBASE-24478: - Same so for MasterProcedureScheduler#wakeRegions > The

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120590#comment-17120590 ] Danil Lipovoy edited comment on HBASE-23887 at 5/31/20, 5:27 PM: - All

[GitHub] [hbase] bharathv merged pull request #1815: HBASE-24477: Move ConfigurationObserver and related classes to hbase-c…

2020-05-31 Thread GitBox
bharathv merged pull request #1815: URL: https://github.com/apache/hbase/pull/1815 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636515170 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-636515189 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636519538 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636519452 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636519476 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-05-31 Thread GitBox
saintstack commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-636519732 Sorry you didn't response on mailing list. Yeah, i think it should be optional opt-in. We publish metrics on the /metrics servlet, we then also publish to jmx, we also

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120565#comment-17120565 ] Danil Lipovoy edited comment on HBASE-23887 at 5/31/20, 8:06 PM: - Seems

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636514608 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636515004 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on a change in pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-05-31 Thread GitBox
saintstack commented on a change in pull request #1814: URL: https://github.com/apache/hbase/pull/1814#discussion_r432978537 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -1727,6 +1727,15 @@ possible configurations would overwhelm and obscure the

[GitHub] [hbase] Apache-HBase commented on pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1819: URL: https://github.com/apache/hbase/pull/1819#issuecomment-636524347 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-636525402 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120590#comment-17120590 ] Danil Lipovoy edited comment on HBASE-23887 at 5/31/20, 8:43 PM: - All

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120565#comment-17120565 ] Danil Lipovoy edited comment on HBASE-23887 at 5/31/20, 8:44 PM: - Seems

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120590#comment-17120590 ] Danil Lipovoy edited comment on HBASE-23887 at 5/31/20, 9:18 PM: - All

[jira] [Resolved] (HBASE-24477) Move ConfigurationObserver and related classes to hbase-common

2020-05-31 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada resolved HBASE-24477. -- Fix Version/s: 2.4.0 1.7.0 2.3.0

[GitHub] [hbase] bharathv merged pull request #1755: HBASE-24069 Provide an ExponentialBackOffPolicy sleep between failed …

2020-05-31 Thread GitBox
bharathv merged pull request #1755: URL: https://github.com/apache/hbase/pull/1755 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (HBASE-24479) Deflake TestCompaction#testStopStartCompaction

2020-05-31 Thread Bharath Vissapragada (Jira)
Bharath Vissapragada created HBASE-24479: Summary: Deflake TestCompaction#testStopStartCompaction Key: HBASE-24479 URL: https://issues.apache.org/jira/browse/HBASE-24479 Project: HBase

[jira] [Commented] (HBASE-24479) Deflake TestCompaction#testStopStartCompaction

2020-05-31 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120648#comment-17120648 ] Bharath Vissapragada commented on HBASE-24479: -- I think the test is racy.. (following

[GitHub] [hbase] bharathv opened a new pull request #1820: HBASE-24479: Deflake TestCompaction#testStopStartCompaction

2020-05-31 Thread GitBox
bharathv opened a new pull request #1820: URL: https://github.com/apache/hbase/pull/1820 Polling of active compaction count is racy. Tightened the asserts to be more reliable. This is an automated message from the Apache

[GitHub] [hbase] bharathv commented on pull request #1820: HBASE-24479: Deflake TestCompaction#testStopStartCompaction

2020-05-31 Thread GitBox
bharathv commented on pull request #1820: URL: https://github.com/apache/hbase/pull/1820#issuecomment-636543041 I have branch-1 checked out locally, so I submitted a PR for branch-1 now, will forward port this to other branches after this is merged. This applies to all branches AFAICT.

[jira] [Updated] (HBASE-24479) Deflake TestCompaction#testStopStartCompaction

2020-05-31 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-24479: - Labels: compaction (was: ) > Deflake TestCompaction#testStopStartCompaction >

[jira] [Commented] (HBASE-24454) BucketCache disabled instantly before error duration toleration is reached due to timing issue

2020-05-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120557#comment-17120557 ] Hudson commented on HBASE-24454: Results for branch master [build #1742 on

[jira] [Commented] (HBASE-24475) Clean up the master thread name getting in SplitLogManager and AssignmentManager

2020-05-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120558#comment-17120558 ] Hudson commented on HBASE-24475: Results for branch master [build #1742 on

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636489567 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danil Lipovoy updated HBASE-23887: -- Attachment: eviction_100p.png > BlockCache performance improve by reduce eviction rate >

[jira] [Updated] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danil Lipovoy updated HBASE-23887: -- Attachment: gc_100p.png > BlockCache performance improve by reduce eviction rate >

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636494546 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636494911 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636495075 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120590#comment-17120590 ] Danil Lipovoy edited comment on HBASE-23887 at 5/31/20, 4:56 PM: - All

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120590#comment-17120590 ] Danil Lipovoy edited comment on HBASE-23887 at 5/31/20, 5:05 PM: - All

[GitHub] [hbase] Apache-HBase commented on pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1819: URL: https://github.com/apache/hbase/pull/1819#issuecomment-636499260 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24475) Clean up the master thread name getting in SplitLogManager and AssignmentManager

2020-05-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120600#comment-17120600 ] Hudson commented on HBASE-24475: Results for branch branch-2.3 [build #115 on

[jira] [Commented] (HBASE-24454) BucketCache disabled instantly before error duration toleration is reached due to timing issue

2020-05-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120599#comment-17120599 ] Hudson commented on HBASE-24454: Results for branch branch-2.3 [build #115 on

[GitHub] [hbase] Apache-HBase commented on pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1819: URL: https://github.com/apache/hbase/pull/1819#issuecomment-636478352 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120565#comment-17120565 ] Danil Lipovoy commented on HBASE-23887: --- Seems like our trouble with the servers for a long time

[jira] [Updated] (HBASE-24478) The regionInfo parameter for MasterProcedureScheduler#waitRegions and MasterProcedureScheduler#wakeRegions should be plural

2020-05-31 Thread song XinCun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] song XinCun updated HBASE-24478: Description: MasterProcedureScheduler#waitRegions and MasterProcedureScheduler#wakeRegions deal

[jira] [Updated] (HBASE-24478) The regionInfo parameter for MasterProcedureScheduler#waitRegions and MasterProcedureScheduler#wakeRegions should be plural

2020-05-31 Thread song XinCun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] song XinCun updated HBASE-24478: Summary: The regionInfo parameter for MasterProcedureScheduler#waitRegions and

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636490239 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoB…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-636494325 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120590#comment-17120590 ] Danil Lipovoy commented on HBASE-23887: --- All tests below have done on: _AMD Ryzen 7 2700X

[jira] [Updated] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danil Lipovoy updated HBASE-23887: -- Attachment: eviction_100p.png > BlockCache performance improve by reduce eviction rate >

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120591#comment-17120591 ] Danil Lipovoy commented on HBASE-23887: --- All tests below have done on: _AMD Ryzen 7 2700X

[jira] [Updated] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danil Lipovoy updated HBASE-23887: -- Attachment: requests_100p.png > BlockCache performance improve by reduce eviction rate >

[jira] [Issue Comment Deleted] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danil Lipovoy updated HBASE-23887: -- Comment: was deleted (was: All tests below have done on: _AMD Ryzen 7 2700X Eight-Core

[GitHub] [hbase] Apache-HBase commented on pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1819: URL: https://github.com/apache/hbase/pull/1819#issuecomment-636500690 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danil Lipovoy updated HBASE-23887: -- Attachment: requests_100p.png > BlockCache performance improve by reduce eviction rate >

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636490011 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1819: URL: https://github.com/apache/hbase/pull/1819#issuecomment-636493877 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danil Lipovoy updated HBASE-23887: -- Attachment: eviction_100p.png > BlockCache performance improve by reduce eviction rate >

[GitHub] [hbase] Apache-HBase commented on pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1819: URL: https://github.com/apache/hbase/pull/1819#issuecomment-636494729 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

  1   2   >