[jira] [Assigned] (HBASE-24688) AssignRegionHandler uses EventType.M_RS_CLOSE_META instead of EventType.M_RS_OPEN_META

2020-07-06 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun reassigned HBASE-24688: Assignee: Huaxiang Sun > AssignRegionHandler uses EventType.M_RS_CLOSE_META instead of

[GitHub] [hbase] huaxiangsun opened a new pull request #2029: HBASE-24688 AssignRegionHandler uses EventType.M_RS_CLOSE_META instea…

2020-07-06 Thread GitBox
huaxiangsun opened a new pull request #2029: URL: https://github.com/apache/hbase/pull/2029 …d of EventType.M_RS_OPEN_META for meta region This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (HBASE-24688) AssignRegionHandler uses EventType.M_RS_CLOSE_META instead of EventType.M_RS_OPEN_META for meta region

2020-07-06 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-24688: - Summary: AssignRegionHandler uses EventType.M_RS_CLOSE_META instead of EventType.M_RS_OPEN_META

[GitHub] [hbase] huaxiangsun commented on pull request #2029: HBASE-24688 AssignRegionHandler uses EventType.M_RS_CLOSE_META instea…

2020-07-06 Thread GitBox
huaxiangsun commented on pull request #2029: URL: https://github.com/apache/hbase/pull/2029#issuecomment-654521294 A straightforward fix. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] ndimiduk commented on a change in pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-06 Thread GitBox
ndimiduk commented on a change in pull request #1970: URL: https://github.com/apache/hbase/pull/1970#discussion_r450430879 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java ## @@ -46,6 +46,10 @@ protected

[GitHub] [hbase] ndimiduk commented on a change in pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-06 Thread GitBox
ndimiduk commented on a change in pull request #1970: URL: https://github.com/apache/hbase/pull/1970#discussion_r450435239 ## File path: hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/WrapperAsyncFSOutput.java ## @@ -91,7 +93,11 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #2028: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2.3

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2028: URL: https://github.com/apache/hbase/pull/2028#issuecomment-654432059 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2006: HBASE-24632 Enable procedure-based log splitting as default in hbase3

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2006: URL: https://github.com/apache/hbase/pull/2006#issuecomment-654457327 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152282#comment-17152282 ] Nick Dimiduk commented on HBASE-24625: -- I'm seeing this on the 2.3 backport PR as well,

[GitHub] [hbase] Apache-HBase commented on pull request #2006: HBASE-24632 Enable procedure-based log splitting as default in hbase3

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2006: URL: https://github.com/apache/hbase/pull/2006#issuecomment-654458964 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152321#comment-17152321 ] Nick Dimiduk commented on HBASE-24625: -- Running {{TestWALEntryStream}} on the branch-2.3 backport,

[jira] [Created] (HBASE-24689) Generate CHANGES.md and RELEASENOTES.md for 2.2.6

2020-07-06 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-24689: -- Summary: Generate CHANGES.md and RELEASENOTES.md for 2.2.6 Key: HBASE-24689 URL: https://issues.apache.org/jira/browse/HBASE-24689 Project: HBase Issue

[jira] [Created] (HBASE-24690) Set version to 2.2.6 in branch-2.2 for first RC of 2.2.6

2020-07-06 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-24690: -- Summary: Set version to 2.2.6 in branch-2.2 for first RC of 2.2.6 Key: HBASE-24690 URL: https://issues.apache.org/jira/browse/HBASE-24690 Project: HBase

[jira] [Commented] (HBASE-24615) MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

2020-07-06 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152415#comment-17152415 ] wenfeiyi666 commented on HBASE-24615: - thanks, I go it. >

[jira] [Assigned] (HBASE-24684) Fetch ReplicationSink servers list from HMaster instead of ZooKeeper

2020-07-06 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sun Xin reassigned HBASE-24684: --- Assignee: Sun Xin > Fetch ReplicationSink servers list from HMaster instead of ZooKeeper >

[GitHub] [hbase] Apache9 commented on a change in pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-06 Thread GitBox
Apache9 commented on a change in pull request #1970: URL: https://github.com/apache/hbase/pull/1970#discussion_r450577129 ## File path: hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/WrapperAsyncFSOutput.java ## @@ -91,7 +93,11 @@ private void

[jira] [Commented] (HBASE-24546) CloneSnapshotProcedure unlimited retry

2020-07-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152441#comment-17152441 ] Hudson commented on HBASE-24546: Results for branch branch-2.2 [build #907 on

[GitHub] [hbase] Apache-HBase commented on pull request #2029: HBASE-24688 AssignRegionHandler uses EventType.M_RS_CLOSE_META instea…

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2029: URL: https://github.com/apache/hbase/pull/2029#issuecomment-654565032 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #2029: HBASE-24688 AssignRegionHandler uses EventType.M_RS_CLOSE_META instea…

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2029: URL: https://github.com/apache/hbase/pull/2029#issuecomment-654566841 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #2016: HBASE-24653 Show snapshot owner on Master WebUI

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2016: URL: https://github.com/apache/hbase/pull/2016#issuecomment-654568086 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #2029: HBASE-24688 AssignRegionHandler uses EventType.M_RS_CLOSE_META instea…

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2029: URL: https://github.com/apache/hbase/pull/2029#issuecomment-654533110 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[jira] [Commented] (HBASE-24663) Add procedure process time statistics UI

2020-07-06 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152407#comment-17152407 ] Guanghao Zhang commented on HBASE-24663: Assigned to you [~Joseph295]. > Add procedure process

[jira] [Assigned] (HBASE-24663) Add procedure process time statistics UI

2020-07-06 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-24663: -- Assignee: Junhong Xu > Add procedure process time statistics UI >

[jira] [Assigned] (HBASE-24691) Fix flaky TestWALEntryStream

2020-07-06 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-24691: -- Assignee: Guanghao Zhang > Fix flaky TestWALEntryStream >

[jira] [Created] (HBASE-24691) Fix flaky TestWALEntryStream

2020-07-06 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-24691: -- Summary: Fix flaky TestWALEntryStream Key: HBASE-24691 URL: https://issues.apache.org/jira/browse/HBASE-24691 Project: HBase Issue Type: Sub-task

[GitHub] [hbase] Apache9 commented on a change in pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-06 Thread GitBox
Apache9 commented on a change in pull request #1970: URL: https://github.com/apache/hbase/pull/1970#discussion_r450569339 ## File path: hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/WrapperAsyncFSOutput.java ## @@ -91,7 +93,11 @@ private void

[jira] [Commented] (HBASE-24546) CloneSnapshotProcedure unlimited retry

2020-07-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152424#comment-17152424 ] Hudson commented on HBASE-24546: Results for branch branch-2 [build #2736 on

[jira] [Assigned] (HBASE-24683) Add a basic ReplicationServer which only implement ReplicationSink Service

2020-07-06 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sun Xin reassigned HBASE-24683: --- Assignee: Sun Xin > Add a basic ReplicationServer which only implement ReplicationSink Service >

[jira] [Commented] (HBASE-24691) Fix flaky TestWALEntryStream

2020-07-06 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152437#comment-17152437 ] Guanghao Zhang commented on HBASE-24691: {code:java} 2020-07-07 09:17:39,962 INFO [Time-limited

[GitHub] [hbase] bsglz commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-07-06 Thread GitBox
bsglz commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-654562715 The hostAndWeights stores weight of hosts for a region, currently the hosts in special mode has a bit diff, shows below. ``` #local mode(run by IDEA in windows)

[GitHub] [hbase] bsglz commented on a change in pull request #2011: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-06 Thread GitBox
bsglz commented on a change in pull request #2011: URL: https://github.com/apache/hbase/pull/2011#discussion_r450583983 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java ## @@ -68,22 +76,14 @@ protected void

[jira] [Updated] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24625: - Fix Version/s: (was: 2.3.0) 2.3.1 >

[jira] [Updated] (HBASE-24546) CloneSnapshotProcedure unlimited retry

2020-07-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24546: - Fix Version/s: (was: 1.3.0) 2.3.0 > CloneSnapshotProcedure unlimited

[jira] [Created] (HBASE-24687) New Connection being created for each table

2020-07-06 Thread Manas (Jira)
Manas created HBASE-24687: - Summary: New Connection being created for each table Key: HBASE-24687 URL: https://issues.apache.org/jira/browse/HBASE-24687 Project: HBase Issue Type: Bug

[GitHub] [hbase] bsglz commented on a change in pull request #2011: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-06 Thread GitBox
bsglz commented on a change in pull request #2011: URL: https://github.com/apache/hbase/pull/2011#discussion_r450587742 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java ## @@ -94,4 +94,33 @@ long

[jira] [Commented] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-06 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152461#comment-17152461 ] Michael Stack commented on HBASE-24625: --- [~zghao] HBASE-24691 FYI see above. >

[GitHub] [hbase] brfrn169 merged pull request #1991: HBASE-24650 Change the return types of the new checkAndMutate methods…

2020-07-06 Thread GitBox
brfrn169 merged pull request #1991: URL: https://github.com/apache/hbase/pull/1991 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] ddupg opened a new pull request #2030: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-07-06 Thread GitBox
ddupg opened a new pull request #2030: URL: https://github.com/apache/hbase/pull/2030 backport HBASE-24431 to branch2 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] Apache9 commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-07-06 Thread GitBox
Apache9 commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-654585976 > In distributed mode, this code would not make effect, because no host named "localhost". Is this a strong assumption?

[GitHub] [hbase] bsglz commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-07-06 Thread GitBox
bsglz commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-654588129 > > In distributed mode, this code would not make effect, because no host named "localhost". > > Is this a strong assumption? Not strong enough...maybe i can add a

[GitHub] [hbase] tsuna commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-07-06 Thread GitBox
tsuna commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-654592451 Not sure whether my opinion matters but these kinds of side effects during deserialization are usually code smells. I would also be surprised to find that out.

<    1   2