[jira] [Updated] (HBASE-25322) Redundant Reference file in bottom region of split

2020-11-24 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-25322: --- Description: When we split a region ranges from (,), the bottom region should contain keys

[GitHub] [hbase] Apache-HBase commented on pull request #2700: HBASE-25322 Redundant Reference file in bottom region of split

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2700: URL: https://github.com/apache/hbase/pull/2700#issuecomment-732765000 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25187) Improve SizeCachedKV variants initialization

2020-11-24 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237995#comment-17237995 ] ramkrishna.s.vasudevan commented on HBASE-25187: [~ndimiduk] and [~zghao] thanks for the

[jira] [Issue Comment Deleted] (HBASE-25277) postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-11-24 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25277: - Comment: was deleted (was: Env Detail: 1 HM, 5 RS Test Input: 1 Table with 500 region No of

[jira] [Commented] (HBASE-25277) postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-11-24 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238003#comment-17238003 ] Pankaj Kumar commented on HBASE-25277: -- Env Detail: 1 HM, 5 RS Test Input: 1 Table with 500

[jira] [Updated] (HBASE-25277) postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-11-24 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25277: - Attachment: test_report.png > postScannerFilterRow impacts Scan performance a lot in HBase 2.x

[GitHub] [hbase] yuqi1129 opened a new pull request #2702: Hbase 25323 Fix potential NPE when the zookeeper path of RegionServerTracker does not exist when start

2020-11-24 Thread GitBox
yuqi1129 opened a new pull request #2702: URL: https://github.com/apache/hbase/pull/2702 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (HBASE-25325) Remove unused class ClusterSchemaException

2020-11-24 Thread yuqi (Jira)
yuqi created HBASE-25325: Summary: Remove unused class ClusterSchemaException Key: HBASE-25325 URL: https://issues.apache.org/jira/browse/HBASE-25325 Project: HBase Issue Type: Improvement

[GitHub] [hbase] Apache-HBase commented on pull request #2419: HBASE-25050 - We initialize Filesystems more than once.

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2419: URL: https://github.com/apache/hbase/pull/2419#issuecomment-732812212 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Assigned] (HBASE-25323) Fix potential NPE when the zookeeper path of RegionServerTracker does not exist when start

2020-11-24 Thread yuqi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuqi reassigned HBASE-25323: Assignee: yuqi > Fix potential NPE when the zookeeper path of RegionServerTracker does not > exist when

[jira] [Created] (HBASE-25323) Fix potential NPE when the zookeeper path of RegionServerTracker does not exist when start

2020-11-24 Thread yuqi (Jira)
yuqi created HBASE-25323: Summary: Fix potential NPE when the zookeeper path of RegionServerTracker does not exist when start Key: HBASE-25323 URL: https://issues.apache.org/jira/browse/HBASE-25323 Project:

[GitHub] [hbase] Apache-HBase commented on pull request #2674: HBASE-25299 Scan#setRowPrefixFilter Unexpected behavior

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2674: URL: https://github.com/apache/hbase/pull/2674#issuecomment-732786082 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2699: HBASE-25287 Forgetting to unbuffer streams results in many CLOSE_WAIT…

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2699: URL: https://github.com/apache/hbase/pull/2699#issuecomment-732796165 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25324) Remove unnecessary array to list conversion in SplitLogManager

2020-11-24 Thread yuqi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuqi updated HBASE-25324: - Summary: Remove unnecessary array to list conversion in SplitLogManager (was: Remove unnecessary array to list

[GitHub] [hbase] Apache-HBase commented on pull request #2704: HBASE-25325 Remove unused class ClusterSchemaException

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2704: URL: https://github.com/apache/hbase/pull/2704#issuecomment-732828866 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-25324) Remove unnecessary array to list conversion SplitLogManager

2020-11-24 Thread yuqi (Jira)
yuqi created HBASE-25324: Summary: Remove unnecessary array to list conversion SplitLogManager Key: HBASE-25324 URL: https://issues.apache.org/jira/browse/HBASE-25324 Project: HBase Issue Type:

[GitHub] [hbase] ramkrish86 merged pull request #2419: HBASE-25050 - We initialize Filesystems more than once.

2020-11-24 Thread GitBox
ramkrish86 merged pull request #2419: URL: https://github.com/apache/hbase/pull/2419 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] ramkrish86 commented on a change in pull request #2663: HBASE-24637 - Reseek regression related to filter SKIP hinting

2020-11-24 Thread GitBox
ramkrish86 commented on a change in pull request #2663: URL: https://github.com/apache/hbase/pull/2663#discussion_r529410112 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java ## @@ -786,6 +791,19 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #2701: HBASE-25213 Should request Compaction when bulkLoadHFiles is done (addendum)

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2701: URL: https://github.com/apache/hbase/pull/2701#issuecomment-732856739 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2657: HBASE-25282 Remove processingServers in DeadServer as we can get this…

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2657: URL: https://github.com/apache/hbase/pull/2657#issuecomment-732752332 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25277) postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-11-24 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25277: - Attachment: (was: Screenshot from 2020-11-24 15-23-29.png) > postScannerFilterRow impacts

[GitHub] [hbase] Apache-HBase commented on pull request #2657: HBASE-25282 Remove processingServers in DeadServer as we can get this…

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2657: URL: https://github.com/apache/hbase/pull/2657#issuecomment-732829253 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2701: HBASE-25213 Should request Compaction when bulkLoadHFiles is done (addendum)

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2701: URL: https://github.com/apache/hbase/pull/2701#issuecomment-732760354 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25324) Remove unnecessary array to list conversion SplitLogManager

2020-11-24 Thread yuqi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuqi updated HBASE-25324: - Description: {code:java} public static List getFileList(final Configuration conf, final List logDirs,

[jira] [Updated] (HBASE-25277) postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-11-24 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-25277: --- Labels: perfomance scanning (was: ) > postScannerFilterRow impacts Scan

[jira] [Updated] (HBASE-25324) Remove unnecessary array to list conversion SplitLogManager

2020-11-24 Thread yuqi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuqi updated HBASE-25324: - Description: {code:java} public static List getFileList(final Configuration conf, final List logDirs,

[GitHub] [hbase] ramkrish86 commented on a change in pull request #2675: HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-11-24 Thread GitBox
ramkrish86 commented on a change in pull request #2675: URL: https://github.com/apache/hbase/pull/2675#discussion_r529401094 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java ## @@ -1848,13 +1848,6 @@ public void

[GitHub] [hbase] sunhelly closed pull request #715: HBASE-22940 Fix snapshot NoNode error

2020-11-24 Thread GitBox
sunhelly closed pull request #715: URL: https://github.com/apache/hbase/pull/715 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] nyl3532016 opened a new pull request #2701: HBASE-25213 Should request Compaction when bulkLoadHFiles is done (addendum)

2020-11-24 Thread GitBox
nyl3532016 opened a new pull request #2701: URL: https://github.com/apache/hbase/pull/2701 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] Apache-HBase commented on pull request #2699: HBASE-25287 Forgetting to unbuffer streams results in many CLOSE_WAIT…

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2699: URL: https://github.com/apache/hbase/pull/2699#issuecomment-732760970 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ramkrish86 commented on pull request #2419: HBASE-25050 - We initialize Filesystems more than once.

2020-11-24 Thread GitBox
ramkrish86 commented on pull request #2419: URL: https://github.com/apache/hbase/pull/2419#issuecomment-732791711 Thanks for the reviews @busbey and @saintstack . This is an automated message from the Apache Git Service. To

[jira] [Updated] (HBASE-25050) We initialize Filesystems more than once.

2020-11-24 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-25050: --- Fix Version/s: 2.4.0 3.0.0-alpha-1 > We initialize

[GitHub] [hbase] Apache-HBase commented on pull request #2702: Hbase 25323 Fix potential NPE when the zookeeper path of RegionServerTracker does not exist when start

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2702: URL: https://github.com/apache/hbase/pull/2702#issuecomment-732797456 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] yuqi1129 opened a new pull request #2703: HBASE-25324 Remove unnecessary array to list conversion in SplitLogManager

2020-11-24 Thread GitBox
yuqi1129 opened a new pull request #2703: URL: https://github.com/apache/hbase/pull/2703 …nager This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] Apache-HBase commented on pull request #2700: HBASE-25322 Redundant Reference file in bottom region of split

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2700: URL: https://github.com/apache/hbase/pull/2700#issuecomment-732801778 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] yuqi1129 opened a new pull request #2704: HBASE-25325 Remove unused class ClusterSchemaException

2020-11-24 Thread GitBox
yuqi1129 opened a new pull request #2704: URL: https://github.com/apache/hbase/pull/2704 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (HBASE-25324) Remove unnecessary array to list conversion SplitLogManager

2020-11-24 Thread yuqi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuqi updated HBASE-25324: - Environment: (was: {code:java} public static List getFileList(final Configuration conf, final List

[jira] [Commented] (HBASE-25277) postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-11-24 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238002#comment-17238002 ] Pankaj Kumar commented on HBASE-25277: -- Env Detail: 1 HM, 5 RS Test Input: 1 Table with 500

[jira] [Updated] (HBASE-25277) postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-11-24 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25277: - Attachment: Screenshot from 2020-11-24 15-23-29.png > postScannerFilterRow impacts Scan

[jira] [Updated] (HBASE-25324) Remove unnecessary array to list conversion SplitLogManager

2020-11-24 Thread yuqi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuqi updated HBASE-25324: - Description: {code:java} public static List getFileList(final Configuration conf, final List logDirs,

[jira] [Updated] (HBASE-25277) postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-11-24 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25277: - Attachment: (was: Screenshot from 2020-11-24 15-23-29.png) > postScannerFilterRow impacts

[jira] [Updated] (HBASE-25277) postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-11-24 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25277: - Attachment: Screenshot from 2020-11-24 15-23-29.png > postScannerFilterRow impacts Scan

[GitHub] [hbase] Apache-HBase commented on pull request #2674: HBASE-25299 Scan#setRowPrefixFilter Unexpected behavior

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2674: URL: https://github.com/apache/hbase/pull/2674#issuecomment-732792234 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #2703: HBASE-25324 Remove unnecessary array to list conversion in SplitLogManager

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2703: URL: https://github.com/apache/hbase/pull/2703#issuecomment-732826234 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2705: HBASE-25237 : 'hbase master stop' shuts down the cluster, not the master only

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2705: URL: https://github.com/apache/hbase/pull/2705#issuecomment-733171123 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] apurtell commented on pull request #2695: HBASE-24640 Purge use of VisibleForTesting

2020-11-24 Thread GitBox
apurtell commented on pull request #2695: URL: https://github.com/apache/hbase/pull/2695#issuecomment-733239058 Thanks @Reidd ! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] apurtell commented on pull request #2696: HBASE-24640 [branch-2] Purge use of VisibleForTesting

2020-11-24 Thread GitBox
apurtell commented on pull request #2696: URL: https://github.com/apache/hbase/pull/2696#issuecomment-733239288 @Reidd Approved the master version of this PR, merging down the line. This is an automated message from the

[GitHub] [hbase] Apache-HBase commented on pull request #2685: HBASE-25307 ThreadLocal pooling leads to NullPointerException

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2685: URL: https://github.com/apache/hbase/pull/2685#issuecomment-733190213 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] shahrs87 opened a new pull request #2706: [HBASE-25246] Backup/Restore hbase cell tags.

2020-11-24 Thread GitBox
shahrs87 opened a new pull request #2706: URL: https://github.com/apache/hbase/pull/2706 Added support for tags to import and export tool. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase-connectors] LucaCanali commented on pull request #75: [HBASE-25326] Allow running and building hbase-connectors with Apache Spark 3.0

2020-11-24 Thread GitBox
LucaCanali commented on pull request #75: URL: https://github.com/apache/hbase-connectors/pull/75#issuecomment-733172592 Thanks @saintstack for looking at this. I am not sure I understand yet how the build errors relate to the patch. Could it be an issue with jenkins or am I missing

[GitHub] [hbase] busbey commented on a change in pull request #2685: HBASE-25307 ThreadLocal pooling leads to NullPointerException

2020-11-24 Thread GitBox
busbey commented on a change in pull request #2685: URL: https://github.com/apache/hbase/pull/2685#discussion_r529793609 ## File path: hbase-client/src/test/java/org/apache/hadoop/hbase/util/TestRoundRobinPoolMap.java ## @@ -45,58 +52,104 @@ protected PoolType getPoolType() {

[jira] [Assigned] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2020-11-24 Thread Caroline (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caroline reassigned HBASE-25329: Assignee: Caroline > Dump region hashes in logs for the regions that are stuck in transition for

[jira] [Created] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2020-11-24 Thread Caroline (Jira)
Caroline created HBASE-25329: Summary: Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time Key: HBASE-25329 URL:

[GitHub] [hbase] Apache-HBase commented on pull request #2705: HBASE-25237 : 'hbase master stop' shuts down the cluster, not the master only

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2705: URL: https://github.com/apache/hbase/pull/2705#issuecomment-733231916 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] shahrs87 opened a new pull request #2707: [HBASE-25328] Make some Tag related classes annotation as LimitatePrivate.

2020-11-24 Thread GitBox
shahrs87 opened a new pull request #2707: URL: https://github.com/apache/hbase/pull/2707 Need to make the following classes LP since we want to use some api's in Phoenix Coproc: https://issues.apache.org/jira/browse/PHOENIX-6213 ArrayBackedTag ByteBufferTag PrivateCellUtil

[jira] [Commented] (HBASE-25187) Improve SizeCachedKV variants initialization

2020-11-24 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238309#comment-17238309 ] Hudson commented on HBASE-25187: Results for branch branch-2.2 [build #122 on

[GitHub] [hbase] Apache-HBase commented on pull request #2685: HBASE-25307 ThreadLocal pooling leads to NullPointerException

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2685: URL: https://github.com/apache/hbase/pull/2685#issuecomment-733191809 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2685: HBASE-25307 ThreadLocal pooling leads to NullPointerException

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2685: URL: https://github.com/apache/hbase/pull/2685#issuecomment-733196559 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2511: HBASE-24960 reduce invalid subprocedure task

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2511: URL: https://github.com/apache/hbase/pull/2511#issuecomment-733196305 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2705: HBASE-25237 : 'hbase master stop' shuts down the cluster, not the master only

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2705: URL: https://github.com/apache/hbase/pull/2705#issuecomment-733227793 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2676: HBASE-25263 Change encryption key generation algorithm used in the HBase shell

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2676: URL: https://github.com/apache/hbase/pull/2676#issuecomment-732954227 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2703: HBASE-25324 Remove unnecessary array to list conversion in SplitLogManager

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2703: URL: https://github.com/apache/hbase/pull/2703#issuecomment-732966973 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25050) We initialize Filesystems more than once.

2020-11-24 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238124#comment-17238124 ] ramkrishna.s.vasudevan commented on HBASE-25050: Pushed to master and branch-2. Thanks

[jira] [Commented] (HBASE-22769) Runtime Error on join (with filter) when using hbase-spark connector

2020-11-24 Thread Luca Canali (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238127#comment-17238127 ] Luca Canali commented on HBASE-22769: - The error can be worked around with

[jira] [Commented] (HBASE-22769) Runtime Error on join (with filter) when using hbase-spark connector

2020-11-24 Thread Luca Canali (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238129#comment-17238129 ] Luca Canali commented on HBASE-22769: - [https://github.com/apache/hbase-connectors/pull/74] is a PR

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #74: [HBASE-22769] Make reflection explicit in to avoid ClassNotFoundException in SQL pushdown with filters

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #74: URL: https://github.com/apache/hbase-connectors/pull/74#issuecomment-732982683 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[jira] [Updated] (HBASE-25326) Allow hbase-connector to be used with Apache Spark 3.0

2020-11-24 Thread Luca Canali (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luca Canali updated HBASE-25326: Description: Currently hbase-spark connector only works with Spark 2.x. Apache Spark 3.0 has

[GitHub] [hbase] virajjasani closed pull request #2674: HBASE-25299 Scan#setRowPrefixFilter Unexpected behavior

2020-11-24 Thread GitBox
virajjasani closed pull request #2674: URL: https://github.com/apache/hbase/pull/2674 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #75: [HBASE-25326] Allow running and building hbase-connectors with Apache Spark 3.0

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #75: URL: https://github.com/apache/hbase-connectors/pull/75#issuecomment-733005091 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #75: [HBASE-25326] Allow running and building hbase-connectors with Apache Spark 3.0

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #75: URL: https://github.com/apache/hbase-connectors/pull/75#issuecomment-733011552 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[jira] [Commented] (HBASE-25326) Allow hbase-connector to be used with Apache Spark 3.0

2020-11-24 Thread Luca Canali (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238194#comment-17238194 ] Luca Canali commented on HBASE-25326: - [https://github.com/apache/hbase-connectors/pull/75] is

[GitHub] [hbase] Apache-HBase commented on pull request #2703: HBASE-25324 Remove unnecessary array to list conversion in SplitLogManager

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2703: URL: https://github.com/apache/hbase/pull/2703#issuecomment-733070412 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] apurtell commented on pull request #2697: HBASE-24640 [branch-1] Purge use of VisibleForTesting

2020-11-24 Thread GitBox
apurtell commented on pull request #2697: URL: https://github.com/apache/hbase/pull/2697#issuecomment-733096844 @Reidd Will rebase. I can also make a pass over these checkstyle warns. Was expecting some legacy issues to turn up.

[jira] [Resolved] (HBASE-25187) Improve SizeCachedKV variants initialization

2020-11-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell resolved HBASE-25187. - Hadoop Flags: Reviewed Resolution: Fixed > Improve SizeCachedKV variants

[GitHub] [hbase] Apache-HBase commented on pull request #2676: HBASE-25263 Change encryption key generation algorithm used in the HBase shell

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2676: URL: https://github.com/apache/hbase/pull/2676#issuecomment-733115024 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-24268) REST and Thrift server do not handle the "doAs" parameter case insensitively

2020-11-24 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser resolved HBASE-24268. Hadoop Flags: Reviewed Release Note: This change allows the REST and Thrift servers to handle

[GitHub] [hbase] Apache-HBase commented on pull request #2690: HBASE-24395 backport HBASE-20589

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2690: URL: https://github.com/apache/hbase/pull/2690#issuecomment-733128421 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 17m

[GitHub] [hbase] Apache-HBase commented on pull request #2676: HBASE-25263 Change encryption key generation algorithm used in the HBase shell

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2676: URL: https://github.com/apache/hbase/pull/2676#issuecomment-733152866 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on a change in pull request #2703: HBASE-25324 Remove unnecessary array to list conversion in SplitLogManager

2020-11-24 Thread GitBox
saintstack commented on a change in pull request #2703: URL: https://github.com/apache/hbase/pull/2703#discussion_r529731374 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java ## @@ -242,11 +242,11 @@ public long

[GitHub] [hbase] pankaj72981 edited a comment on pull request #2675: HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-11-24 Thread GitBox
pankaj72981 edited a comment on pull request #2675: URL: https://github.com/apache/hbase/pull/2675#issuecomment-733078611 > In the parent JIRA for the perf report how many CPs were exactly added in your tests ? Following region CPs were configured. 1.3.1 -> AccessController,

[GitHub] [hbase] meszibalu commented on a change in pull request #2685: HBASE-25307 ThreadLocal pooling leads to NullPointerException

2020-11-24 Thread GitBox
meszibalu commented on a change in pull request #2685: URL: https://github.com/apache/hbase/pull/2685#discussion_r529707941 ## File path: hbase-client/src/test/java/org/apache/hadoop/hbase/util/TestThreadLocalPoolMap.java ## @@ -43,42 +43,42 @@ protected PoolType

[GitHub] [hbase] apurtell commented on pull request #2695: HBASE-24640 Purge use of VisibleForTesting

2020-11-24 Thread GitBox
apurtell commented on pull request #2695: URL: https://github.com/apache/hbase/pull/2695#issuecomment-733097251 @Reidd Mind adding your +1 here as well so I can merge down the line? Sorry to bother. This is an automated

[GitHub] [hbase] Apache-HBase commented on pull request #2685: HBASE-25307 ThreadLocal pooling leads to NullPointerException

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2685: URL: https://github.com/apache/hbase/pull/2685#issuecomment-733109652 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Created] (HBASE-25328) Make PrivateCellUtil annotation as LimitatePrivate.

2020-11-24 Thread Rushabh Shah (Jira)
Rushabh Shah created HBASE-25328: Summary: Make PrivateCellUtil annotation as LimitatePrivate. Key: HBASE-25328 URL: https://issues.apache.org/jira/browse/HBASE-25328 Project: HBase Issue

[GitHub] [hbase] Apache-HBase commented on pull request #2511: HBASE-24960 reduce invalid subprocedure task

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2511: URL: https://github.com/apache/hbase/pull/2511#issuecomment-733147017 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] pankaj72981 commented on pull request #2675: HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-11-24 Thread GitBox
pankaj72981 commented on pull request #2675: URL: https://github.com/apache/hbase/pull/2675#issuecomment-733078611 > In the parent JIRA for the perf report how many CPs were exactly added in your tests ? Following region CPs were configured. 1.3.1 -> AccessController,

[jira] [Updated] (HBASE-25242) Add Increment/Append support to RowMutations

2020-11-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25242: Priority: Critical (was: Major) > Add Increment/Append support to RowMutations >

[GitHub] [hbase] Apache-HBase commented on pull request #2685: HBASE-25307 ThreadLocal pooling leads to NullPointerException

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2685: URL: https://github.com/apache/hbase/pull/2685#issuecomment-733104804 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25127) Enhance PerformanceEvaluation to profile meta replica performance.

2020-11-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238254#comment-17238254 ] Andrew Kyle Purtell commented on HBASE-25127: - Thanks [~huaxiangsun] , please resolve this

[GitHub] [hbase] joshelser commented on pull request #1843: HBASE-24268 REST and Thrift server do not handle the "doAs" parameter case insensitively

2020-11-24 Thread GitBox
joshelser commented on pull request #1843: URL: https://github.com/apache/hbase/pull/1843#issuecomment-733118156 > That's a great suggestion. Can we get a unit test please? @busbey I see a unit test was added, so I'm assuming your request is satisfied. Merging this so it will ship

[GitHub] [hbase] asfgit closed pull request #1843: HBASE-24268 REST and Thrift server do not handle the "doAs" parameter case insensitively

2020-11-24 Thread GitBox
asfgit closed pull request #1843: URL: https://github.com/apache/hbase/pull/1843 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] lokiore opened a new pull request #2705: HBASE-25237 : 'hbase master stop' shuts down the cluster, not the master only

2020-11-24 Thread GitBox
lokiore opened a new pull request #2705: URL: https://github.com/apache/hbase/pull/2705 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (HBASE-25237) 'hbase master stop' shuts down the cluster, not the master only

2020-11-24 Thread Lokesh Khurana (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lokesh Khurana updated HBASE-25237: --- Attachment: HBASE-25237.patch Status: Patch Available (was: In Progress) > 'hbase

[GitHub] [hbase] Apache-HBase commented on pull request #2703: HBASE-25324 Remove unnecessary array to list conversion in SplitLogManager

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2703: URL: https://github.com/apache/hbase/pull/2703#issuecomment-733079483 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25242) Add Increment/Append support to RowMutations

2020-11-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238252#comment-17238252 ] Andrew Kyle Purtell commented on HBASE-25242: - Thanks for letting me know. Agree, reverts

[GitHub] [hbase-connectors] saintstack commented on pull request #75: [HBASE-25326] Allow running and building hbase-connectors with Apache Spark 3.0

2020-11-24 Thread GitBox
saintstack commented on pull request #75: URL: https://github.com/apache/hbase-connectors/pull/75#issuecomment-733104249 The failing seems to be because of this... ``` [WARNING] [Warn] : there were 18 deprecation warnings; re-run with -deprecation for details [WARNING] one

[jira] [Resolved] (HBASE-25050) We initialize Filesystems more than once.

2020-11-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell resolved HBASE-25050. - Hadoop Flags: Reviewed Resolution: Fixed > We initialize Filesystems more

[GitHub] [hbase] Apache-HBase commented on pull request #2685: HBASE-25307 ThreadLocal pooling leads to NullPointerException

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2685: URL: https://github.com/apache/hbase/pull/2685#issuecomment-733112043 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-24268) REST and Thrift server do not handle the "doAs" parameter case insensitively

2020-11-24 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-24268: --- Fix Version/s: 2.4.0 3.0.0-alpha-1 > REST and Thrift server do not handle the

[GitHub] [hbase] Apache-HBase commented on pull request #2419: HBASE-25050 - We initialize Filesystems more than once.

2020-11-24 Thread GitBox
Apache-HBase commented on pull request #2419: URL: https://github.com/apache/hbase/pull/2419#issuecomment-732960419 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

  1   2   3   >