[jira] [Commented] (HBASE-25494) Compilation failed due to conflict of plugin dependent packages
[
https://issues.apache.org/jira/browse/HBASE-25494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264655#comment-17264655
]
Xiaolin Ha commented on HBASE-25494:
Thanks，[~stack]. It fails on both branch-2 and master. My local maven
environment is ,
{code:java}
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /Users/haxl/soft/apache-maven-3.6.3
Java version: 1.8.0_201, vendor: Oracle Corporation, runtime:
/Library/Java/JavaVirtualMachines/jdk1.8.0_201.jdk/Contents/Home/jre
Default locale: en_CN, platform encoding: UTF-8
OS name: "mac os x", version: "10.15.7", arch: "x86_64", family: "mac"
{code}
I have tried to remove all the repositories in .m2 directory and recompiled the
project, but it didn't work.
After fixed it like the PR, it compiled successfully.
> Compilation failed due to conflict of plugin dependent packages
> ---
>
> Key: HBASE-25494
> URL: https://issues.apache.org/jira/browse/HBASE-25494
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
>
> Compile the project fails, error messages are as follow. My maven version is
> 3.6.3
> {code:java}
> [ERROR] Failed to execute goal
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> (compile-protoc) on project hbase-protocol-shaded: Execution compile-protoc
> of goal org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> failed: A required class was missing while executing
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile:
> org/codehaus/plexus/util/io/InputStreamFacade
> [ERROR] -
> [ERROR] realm =
> plugin>org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> [ERROR] urls[0] =
> file:/Users/haxl/.m2/repository/org/xolstice/maven/plugins/protobuf-maven-plugin/0.6.1/protobuf-maven-plugin-0.6.1.jar
> [ERROR] urls[1] =
> file:/Users/haxl/.m2/repository/org/codehaus/plexus/plexus-utils/1.1/plexus-utils-1.1.jar
> [ERROR] Number of foreign imports: 1
> [ERROR] import: Entry[import from realm
> ClassRealm[project>org.apache.hbase:hbase:3.0.0-SNAPSHOT, parent:
> ClassRealm[maven.api, parent: null]]]
> [ERROR]
> [ERROR] -
> [ERROR] : org.codehaus.plexus.util.io.InputStreamFacade
> [ERROR] -> [Help 1]
> [ERROR]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on a change in pull request #2866: HBASE-25478 - Implement retries when enabling tables in TestRegionReplicaReplicationEndpoint
virajjasani commented on a change in pull request #2866:
URL: https://github.com/apache/hbase/pull/2866#discussion_r557059396
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestRegionReplicaReplicationEndpoint.java
##
@@ -122,7 +125,7 @@ public static void afterClass() throws Exception {
}
@Test
- public void testRegionReplicaReplicationPeerIsCreated() throws IOException {
+ public void testRegionReplicaReplicationPeerIsCreated() throws IOException,
InterruptedException {
Review comment:
I think now we don't need this, IOException alone is enough?
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestRegionReplicaReplicationEndpoint.java
##
@@ -487,4 +490,26 @@ private void testRegionReplicaReplicationIgnores(boolean
dropTable, boolean disa
connection.close();
}
}
+
+ private void createOrEnableTableWithRetries(TableDescriptor htd, boolean
createTableOperation) {
+// Helper function to run create/enable table operations with a retry
feature
+boolean continueToRetry = true;
+int tries = 0;
+while (continueToRetry && tries < 100) {
Review comment:
Although we don't expect `ReplicationException` to keep showing up till
100s, but 100s is huge duration that we are waiting on here. It will make tests
timeout if we have some issue. Let's keep this 50 maybe?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher
[
https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264634#comment-17264634
]
Viraj Jasani commented on HBASE-25279:
--
>From historical context,
One of the critical bugs to make ZK sync() sync, was fixed in HBASE-24603 and
it just went in 2.3.0, 2.2.6 releases. It's not been that long. However, with
this fix, [~bharathv] also fixed possible deadlock during ZK event processing
by introducing Single threaded executor pool, which would process event
notifications from ZK and thus event processing is now decoupled from ZK cncx
EventThread context. While doing so, our internal utility
Threads.getNamedThreadFactory() was used, and this was always clumsy, we never
had any proper pick for using ThreadFactory, some code used to get
ThreadFactory from our internal utility, some used guava libs. I wanted to
clean this up (IIRC, it was this very Jira HBASE-24603 in which I saw
differences of opinion for using ThreadFactory during review and I decided to
clean this up in HBASE-24750). HBASE-24750 had consensus to start using guava
only and get rid of our utility, which is what was done and now we only use
guava ThreadFactoryBuilder everywhere. However, I missed daemonizing threads
which led to bug HBASE-25037 , which [~zhangduo] fixed it quite sooner and we
are good there.
With respect to current Jira, I think Bharath didn't want to daemonize thread
used in Single threaded executor pool in the first place. It happened just
because our internal utility always used daemon mode. See *if (!t.isDaemon())
\{ t.setDaemon(true); }* here:
{code:java}
public static ThreadFactory newDaemonThreadFactory(final String prefix,
final UncaughtExceptionHandler handler) {
final ThreadFactory namedFactory = getNamedThreadFactory(prefix);
return new ThreadFactory() {
@Override
public Thread newThread(Runnable r) {
Thread t = namedFactory.newThread(r);
if (handler != null) {
t.setUncaughtExceptionHandler(handler);
} else {
t.setUncaughtExceptionHandler(LOGGING_EXCEPTION_HANDLER);
}
if (!t.isDaemon()) {
t.setDaemon(true);
}
if (t.getPriority() != Thread.NORM_PRIORITY) {
t.setPriority(Thread.NORM_PRIORITY);
}
return t;
}
};
}
{code}
This no longer exists in our code in the favour of using guava
ThreadFactoryBuilder.
[~zhangduo] Let me spend some time today and revisit HBASE-25037 to ensure if
we are not missing daemonizing any other place. If you could also cross verify
when you get time, that would be really great. WDYT?
> Non-daemon thread in ZKWatcher
> --
>
> Key: HBASE-25279
> URL: https://issues.apache.org/jira/browse/HBASE-25279
> Project: HBase
> Issue Type: Bug
> Components: Zookeeper
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.1
>
>
> ZKWatcher spawns an ExecutorService which doesn't mark its threads as daemons
> which will prevent clean shut downs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2878: HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase…
Apache-HBase commented on pull request #2878: URL: https://github.com/apache/hbase/pull/2878#issuecomment-759616210 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 20s | master passed | | +1 :green_heart: | compile | 1m 36s | master passed | | +1 :green_heart: | shadedjars | 6m 50s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 5s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 9s | the patch passed | | +1 :green_heart: | compile | 1m 35s | the patch passed | | +1 :green_heart: | javac | 1m 35s | the patch passed | | +1 :green_heart: | shadedjars | 7m 10s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 5s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 48s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 136m 34s | hbase-server in the patch passed. | | | | 169m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2878 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux fe283594ae26 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dfefff7e59 | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/2/testReport/ | | Max. process+thread count | 3934 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-25504) [branch-2.4] Restore AccessController method removed by HBASE-25277
Andrew Kyle Purtell created HBASE-25504: --- Summary: [branch-2.4] Restore AccessController method removed by HBASE-25277 Key: HBASE-25504 URL: https://issues.apache.org/jira/browse/HBASE-25504 Project: HBase Issue Type: Improvement Components: compatibility, Coprocessors, security Affects Versions: 2.4.1 Reporter: Andrew Kyle Purtell Assignee: Andrew Kyle Purtell Fix For: 2.4.1 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25503) HBase code download is failing on windows with invalid path error
[
https://issues.apache.org/jira/browse/HBASE-25503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264320#comment-17264320
]
Mohammad Arshad commented on HBASE-25503:
-
Thanks [~stack] for merging the PR
> HBase code download is failing on windows with invalid path error
> -
>
> Key: HBASE-25503
> URL: https://issues.apache.org/jira/browse/HBASE-25503
> Project: HBase
> Issue Type: Bug
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.2
>
>
> git pull command is failing with "error: invalid path"
> {noformat}
> Host1 MINGW64 /d/hbase (master)
> $ git pull
> error: invalid path
> 'dev-support/design-docs/HBASE-18070-ROOT_hbase:meta_Region_Replicas.pdf'
> Updating 2e96a5b2d3..dfefff7e59{noformat}
> This problem is coming only on windows machines. Tried on windows 7 and
> windows 10 both have problem. Searched on net, seems no any easy solution.
> Problem is because file HBASE-18070-ROOT_hbase:meta_Region_Replicas.pdf has
> colon in its name.
> To fix the problem we should remove the colon : from file name
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-25504) [branch-2.4] Restore AccessController method removed by HBASE-25277
[
https://issues.apache.org/jira/browse/HBASE-25504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell resolved HBASE-25504.
-
Resolution: Fixed
> [branch-2.4] Restore AccessController method removed by HBASE-25277
> ---
>
> Key: HBASE-25504
> URL: https://issues.apache.org/jira/browse/HBASE-25504
> Project: HBase
> Issue Type: Bug
> Components: compatibility, Coprocessors, security
>Affects Versions: 2.4.1
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.4.1
>
>
> We can't do this in a patch release on a LimitedPrivate interface:
> {code}
> - @Override
> - public boolean postScannerFilterRow(final
> ObserverContext e,
> - final InternalScanner s, final Cell curRowCell, final boolean hasMore)
> throws IOException {
> -// 'default' in RegionObserver might do unnecessary copy for Off heap
> backed Cells.
> -return hasMore;
> - }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time
[ https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25329: - Fix Version/s: (was: 2.4.2) (was: 2.3.5) (was: 1.7.0) 2.4.1 Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch [~caroliney14]. Thanks for the heads up [~apurtell], I will revisit this after some time for remaining backports. > Dump region hashes in logs for the regions that are stuck in transition for > more than a configured amount of time > - > > Key: HBASE-25329 > URL: https://issues.apache.org/jira/browse/HBASE-25329 > Project: HBase > Issue Type: Improvement >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.1 > > Attachments: HBASE-25329.branch-1.000.patch, > HBASE-25329.branch-2.000.patch, HBASE-25329.master.000.patch > > > We have metrics for number of RITs as well as number of RITs above a certain > threshold, but we don't have any way of keeping track of the region hashes of > those RITs. It would be beneficial to emit those region hashes as a metric, > as well as log them, so that we don't accidentally lose this information for > debugging the RIT at a later tiime. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25504) [branch-2.4] Restore AccessController method removed by HBASE-25277
[
https://issues.apache.org/jira/browse/HBASE-25504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-25504:
Issue Type: Bug (was: Improvement)
> [branch-2.4] Restore AccessController method removed by HBASE-25277
> ---
>
> Key: HBASE-25504
> URL: https://issues.apache.org/jira/browse/HBASE-25504
> Project: HBase
> Issue Type: Bug
> Components: compatibility, Coprocessors, security
>Affects Versions: 2.4.1
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.4.1
>
>
> We can't do this in a patch release on a LimitedPrivate interface:
> {code}
> - @Override
> - public boolean postScannerFilterRow(final
> ObserverContext e,
> - final InternalScanner s, final Cell curRowCell, final boolean hasMore)
> throws IOException {
> -// 'default' in RegionObserver might do unnecessary copy for Off heap
> backed Cells.
> -return hasMore;
> - }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] christinefeng commented on pull request #2866: HBASE-25478 - Implement retries when enabling tables in TestRegionReplicaReplicationEndpoint
christinefeng commented on pull request #2866: URL: https://github.com/apache/hbase/pull/2866#issuecomment-759596990 > Left few comments, looks good otherwise. @virajjasani Thanks for the feedback, I've addressed your comments and tested locally. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack merged pull request #2880: HBASE-25503: HBase code download is failing on windows with invalid path error
saintstack merged pull request #2880: URL: https://github.com/apache/hbase/pull/2880 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25504) [branch-2.4] Restore AccessController method removed by HBASE-25277
[
https://issues.apache.org/jira/browse/HBASE-25504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264322#comment-17264322
]
Andrew Kyle Purtell commented on HBASE-25504:
-
Fine for master and branch-2, but not branch-2.4.
> [branch-2.4] Restore AccessController method removed by HBASE-25277
> ---
>
> Key: HBASE-25504
> URL: https://issues.apache.org/jira/browse/HBASE-25504
> Project: HBase
> Issue Type: Improvement
> Components: compatibility, Coprocessors, security
>Affects Versions: 2.4.1
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.4.1
>
>
> We can't do this in a patch release on a LimitedPrivate interface:
> {code}
> - @Override
> - public boolean postScannerFilterRow(final
> ObserverContext e,
> - final InternalScanner s, final Cell curRowCell, final boolean hasMore)
> throws IOException {
> -// 'default' in RegionObserver might do unnecessary copy for Off heap
> backed Cells.
> -return hasMore;
> - }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time
[ https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264345#comment-17264345 ] Viraj Jasani commented on HBASE-25329: -- Sure thing, let me commit and resolve this Jira. Will reopen later for branch-2.3, 2.2 and branch-1 backports. > Dump region hashes in logs for the regions that are stuck in transition for > more than a configured amount of time > - > > Key: HBASE-25329 > URL: https://issues.apache.org/jira/browse/HBASE-25329 > Project: HBase > Issue Type: Improvement >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0, 2.3.5, 2.4.2 > > Attachments: HBASE-25329.branch-1.000.patch, > HBASE-25329.branch-2.000.patch, HBASE-25329.master.000.patch > > > We have metrics for number of RITs as well as number of RITs above a certain > threshold, but we don't have any way of keeping track of the region hashes of > those RITs. It would be beneficial to emit those region hashes as a metric, > as well as log them, so that we don't accidentally lose this information for > debugging the RIT at a later tiime. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-25317) [github]rename HBASE-18070-ROOT_hbase:meta_Region_Replicas.pdf
[ https://issues.apache.org/jira/browse/HBASE-25317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar resolved HBASE-25317. -- Resolution: Duplicate HBASE-25503 fixed this issue. > [github]rename HBASE-18070-ROOT_hbase:meta_Region_Replicas.pdf > -- > > Key: HBASE-25317 > URL: https://issues.apache.org/jira/browse/HBASE-25317 > Project: HBase > Issue Type: Bug >Reporter: Bo Cui >Priority: Minor > Attachments: image-2020-11-21-14-48-23-794.png > > > use git pull to obtain an exception, because filename has ':' > !image-2020-11-21-14-48-23-794.png! > workaround:git config core.protectNTFS false > [~stack] i think we can ranme filename... > . -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25503) HBase code download is failing on windows with invalid path error
[
https://issues.apache.org/jira/browse/HBASE-25503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264319#comment-17264319
]
Michael Stack commented on HBASE-25503:
---
There are no references to this doc so rename looks safe.
Thanks for the PR [~arshad.mohammad]. Merged to master and branch-2 and
branch-2.4.
> HBase code download is failing on windows with invalid path error
> -
>
> Key: HBASE-25503
> URL: https://issues.apache.org/jira/browse/HBASE-25503
> Project: HBase
> Issue Type: Bug
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.2
>
>
> git pull command is failing with "error: invalid path"
> {noformat}
> Host1 MINGW64 /d/hbase (master)
> $ git pull
> error: invalid path
> 'dev-support/design-docs/HBASE-18070-ROOT_hbase:meta_Region_Replicas.pdf'
> Updating 2e96a5b2d3..dfefff7e59{noformat}
> This problem is coming only on windows machines. Tried on windows 7 and
> windows 10 both have problem. Searched on net, seems no any easy solution.
> Problem is because file HBASE-18070-ROOT_hbase:meta_Region_Replicas.pdf has
> colon in its name.
> To fix the problem we should remove the colon : from file name
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-25503) HBase code download is failing on windows with invalid path error
[
https://issues.apache.org/jira/browse/HBASE-25503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-25503.
---
Hadoop Flags: Reviewed
Resolution: Fixed
> HBase code download is failing on windows with invalid path error
> -
>
> Key: HBASE-25503
> URL: https://issues.apache.org/jira/browse/HBASE-25503
> Project: HBase
> Issue Type: Bug
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.2
>
>
> git pull command is failing with "error: invalid path"
> {noformat}
> Host1 MINGW64 /d/hbase (master)
> $ git pull
> error: invalid path
> 'dev-support/design-docs/HBASE-18070-ROOT_hbase:meta_Region_Replicas.pdf'
> Updating 2e96a5b2d3..dfefff7e59{noformat}
> This problem is coming only on windows machines. Tried on windows 7 and
> windows 10 both have problem. Searched on net, seems no any easy solution.
> Problem is because file HBASE-18070-ROOT_hbase:meta_Region_Replicas.pdf has
> colon in its name.
> To fix the problem we should remove the colon : from file name
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-25504) [branch-2.4] Restore AccessController method removed by HBASE-25277
[
https://issues.apache.org/jira/browse/HBASE-25504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-25504:
Description:
We can't do this in a patch release on a LimitedPrivate interface:
{code}
- @Override
- public boolean postScannerFilterRow(final
ObserverContext e,
- final InternalScanner s, final Cell curRowCell, final boolean hasMore)
throws IOException {
-// 'default' in RegionObserver might do unnecessary copy for Off heap
backed Cells.
-return hasMore;
- }
{code}
> [branch-2.4] Restore AccessController method removed by HBASE-25277
> ---
>
> Key: HBASE-25504
> URL: https://issues.apache.org/jira/browse/HBASE-25504
> Project: HBase
> Issue Type: Improvement
> Components: compatibility, Coprocessors, security
>Affects Versions: 2.4.1
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.4.1
>
>
> We can't do this in a patch release on a LimitedPrivate interface:
> {code}
> - @Override
> - public boolean postScannerFilterRow(final
> ObserverContext e,
> - final InternalScanner s, final Cell curRowCell, final boolean hasMore)
> throws IOException {
> -// 'default' in RegionObserver might do unnecessary copy for Off heap
> backed Cells.
> -return hasMore;
> - }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2866: HBASE-25478 - Implement retries when enabling tables in TestRegionReplicaReplicationEndpoint
Apache-HBase commented on pull request #2866: URL: https://github.com/apache/hbase/pull/2866#issuecomment-759617420 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 6s | master passed | | +1 :green_heart: | compile | 3m 29s | master passed | | +1 :green_heart: | checkstyle | 1m 14s | master passed | | +1 :green_heart: | spotbugs | 2m 16s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 50s | the patch passed | | +1 :green_heart: | compile | 3m 33s | the patch passed | | +1 :green_heart: | javac | 3m 33s | the patch passed | | +1 :green_heart: | checkstyle | 1m 9s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 18m 24s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 21s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 49m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2866/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2866 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 6f3c179a7d02 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dfefff7e59 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Max. process+thread count | 96 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2866/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time
[ https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264341#comment-17264341 ] Andrew Kyle Purtell commented on HBASE-25329: - [~vjasani][~caroliney14] If you want to make 2.4.1RC0, commit to branch-2.4 within the next hour or two. > Dump region hashes in logs for the regions that are stuck in transition for > more than a configured amount of time > - > > Key: HBASE-25329 > URL: https://issues.apache.org/jira/browse/HBASE-25329 > Project: HBase > Issue Type: Improvement >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0, 2.3.5, 2.4.2 > > Attachments: HBASE-25329.branch-1.000.patch, > HBASE-25329.branch-2.000.patch, HBASE-25329.master.000.patch > > > We have metrics for number of RITs as well as number of RITs above a certain > threshold, but we don't have any way of keeping track of the region hashes of > those RITs. It would be beneficial to emit those region hashes as a metric, > as well as log them, so that we don't accidentally lose this information for > debugging the RIT at a later tiime. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25504) [branch-2.4] Restore method removed by HBASE-25277 to LP(config) coprocessors
[
https://issues.apache.org/jira/browse/HBASE-25504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-25504:
Summary: [branch-2.4] Restore method removed by HBASE-25277 to LP(config)
coprocessors (was: [branch-2.4] Restore AccessController method removed by
HBASE-25277)
> [branch-2.4] Restore method removed by HBASE-25277 to LP(config) coprocessors
> -
>
> Key: HBASE-25504
> URL: https://issues.apache.org/jira/browse/HBASE-25504
> Project: HBase
> Issue Type: Bug
> Components: compatibility, Coprocessors, security
>Affects Versions: 2.4.1
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.4.1
>
>
> We can't do this in a patch release on a LimitedPrivate interface:
> {code}
> - @Override
> - public boolean postScannerFilterRow(final
> ObserverContext e,
> - final InternalScanner s, final Cell curRowCell, final boolean hasMore)
> throws IOException {
> -// 'default' in RegionObserver might do unnecessary copy for Off heap
> backed Cells.
> -return hasMore;
> - }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24972) Wait for connection attempt to succeed before performing operations on ZK
[
https://issues.apache.org/jira/browse/HBASE-24972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264379#comment-17264379
]
Michael Stack commented on HBASE-24972:
---
[~prathyu6] Any comment on above?
> Wait for connection attempt to succeed before performing operations on ZK
> -
>
> Key: HBASE-24972
> URL: https://issues.apache.org/jira/browse/HBASE-24972
> Project: HBase
> Issue Type: Bug
>Reporter: Sandeep Guggilam
>Assignee: Prathyusha
>Priority: Minor
>
> {color:#1d1c1d}Creating the connection with ZK is asynchronous and notified
> via the passed in watcher about the successful connection event. When we
> attempt any operations, we try to create a connection and then perform a
> read/write
> ({color}{color:#1d1c1d}[https://github.com/apache/hbase/blob/979edfe72046b2075adcc869c65ae820e6f3ec2d/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java#L323]{color}{color:#1d1c1d})
> without really waiting for the notification event
> ([https://github.com/apache/hbase/blob/979edfe72046b2075adcc869c65ae820e6f3ec2d/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java#L582)]{color}
>
> {color:#1d1c1d}It is possible we get ConnectionLoss errors when we perform
> operations on ZK without waiting for the connection attempt to succeed{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2870: HBASE-24972 Wait for connection attempt to succeed before performing operations on ZK
Apache-HBase commented on pull request #2870: URL: https://github.com/apache/hbase/pull/2870#issuecomment-759707524 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 1s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 4s | master passed | | +1 :green_heart: | compile | 0m 21s | master passed | | +1 :green_heart: | shadedjars | 7m 34s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 18s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 48s | the patch passed | | +1 :green_heart: | compile | 0m 22s | the patch passed | | +1 :green_heart: | javac | 0m 22s | the patch passed | | +1 :green_heart: | shadedjars | 7m 50s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 18s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 23s | hbase-zookeeper in the patch passed. | | | | 32m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2870/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2870 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 75def88fe1b6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4caab90aa7 | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2870/2/testReport/ | | Max. process+thread count | 264 (vs. ulimit of 3) | | modules | C: hbase-zookeeper U: hbase-zookeeper | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2870/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2870: HBASE-24972 Wait for connection attempt to succeed before performing operations on ZK
Apache-HBase commented on pull request #2870: URL: https://github.com/apache/hbase/pull/2870#issuecomment-759708578 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 49s | master passed | | +1 :green_heart: | compile | 0m 32s | master passed | | +1 :green_heart: | checkstyle | 0m 15s | master passed | | +1 :green_heart: | spotbugs | 0m 35s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 29s | the patch passed | | +1 :green_heart: | compile | 0m 28s | the patch passed | | +1 :green_heart: | javac | 0m 28s | the patch passed | | +1 :green_heart: | checkstyle | 0m 13s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 13s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 0m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 35m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2870/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2870 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux dd1f3930ad18 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4caab90aa7 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Max. process+thread count | 96 (vs. ulimit of 3) | | modules | C: hbase-zookeeper U: hbase-zookeeper | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2870/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2876: HBASE-25494 Compilation failed due to conflict of plugin dependent pa…
Apache-HBase commented on pull request #2876: URL: https://github.com/apache/hbase/pull/2876#issuecomment-759738112 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 34s | master passed | | +1 :green_heart: | compile | 2m 21s | master passed | | +1 :green_heart: | shadedjars | 6m 25s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 21s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 42s | the patch passed | | +1 :green_heart: | compile | 2m 36s | the patch passed | | +1 :green_heart: | javac | 2m 36s | the patch passed | | +1 :green_heart: | shadedjars | 7m 4s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 26s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 329m 31s | root in the patch failed. | | | | 363m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2876/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2876 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4f8fdbf85c41 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dfefff7e59 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2876/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2876/3/testReport/ | | Max. process+thread count | 5526 (vs. ulimit of 3) | | modules | C: hbase-resource-bundle . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2876/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25504) [branch-2.4] Restore method removed by HBASE-25277 to LP(CONFIG) coprocessors
[
https://issues.apache.org/jira/browse/HBASE-25504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-25504:
Summary: [branch-2.4] Restore method removed by HBASE-25277 to LP(CONFIG)
coprocessors (was: [branch-2.4] Restore method removed by HBASE-25277 to
LP(config) coprocessors)
> [branch-2.4] Restore method removed by HBASE-25277 to LP(CONFIG) coprocessors
> -
>
> Key: HBASE-25504
> URL: https://issues.apache.org/jira/browse/HBASE-25504
> Project: HBase
> Issue Type: Bug
> Components: compatibility, Coprocessors, security
>Affects Versions: 2.4.1
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.4.1
>
>
> We can't do this in a patch release on a LimitedPrivate interface:
> {code}
> - @Override
> - public boolean postScannerFilterRow(final
> ObserverContext e,
> - final InternalScanner s, final Cell curRowCell, final boolean hasMore)
> throws IOException {
> -// 'default' in RegionObserver might do unnecessary copy for Off heap
> backed Cells.
> -return hasMore;
> - }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] saintstack merged pull request #2879: HBASE-25502 IntegrationTestMTTR fails with TableNotFoundException
saintstack merged pull request #2879: URL: https://github.com/apache/hbase/pull/2879 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-25502) IntegrationTestMTTR fails with TableNotFoundException
[
https://issues.apache.org/jira/browse/HBASE-25502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-25502.
---
Fix Version/s: 2.4.2
2.3.5
3.0.0-alpha-1
Hadoop Flags: Reviewed
Resolution: Fixed
Thanks [~pankajkumar]. Merged to branch-2.3+
> IntegrationTestMTTR fails with TableNotFoundException
> -
>
> Key: HBASE-25502
> URL: https://issues.apache.org/jira/browse/HBASE-25502
> Project: HBase
> Issue Type: Test
> Components: integration tests
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.5, 2.4.2
>
>
> Admin.getDescriptor() fails beacuse table doesn't exist.
>
> {noformat}
> org.apache.hadoop.hbase.TableNotFoundException: IntegrationTestMTTR
> at java.lang.Thread.getStackTrace(Thread.java:1559)
> at
> org.apache.hadoop.hbase.util.FutureUtils.setStackTrace(FutureUtils.java:130)
> at
> org.apache.hadoop.hbase.util.FutureUtils.rethrow(FutureUtils.java:149)
> at org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:172)
> at
> org.apache.hadoop.hbase.client.AdminOverAsyncAdmin.getDescriptor(AdminOverAsyncAdmin.java:163)
> at
> org.apache.hadoop.hbase.mttr.IntegrationTestMTTR.setupTables(IntegrationTestMTTR.java:236)
> at
> org.apache.hadoop.hbase.mttr.IntegrationTestMTTR.setUp(IntegrationTestMTTR.java:179)
>
> {noformat}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25494) Compilation failed due to conflict of plugin dependent packages
[
https://issues.apache.org/jira/browse/HBASE-25494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264373#comment-17264373
]
Michael Stack commented on HBASE-25494:
---
What branch and what jdk? I'm trying to reproduce your failure [~Xiaolin Ha]
Thanks.
> Compilation failed due to conflict of plugin dependent packages
> ---
>
> Key: HBASE-25494
> URL: https://issues.apache.org/jira/browse/HBASE-25494
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
>
> Compile the project fails, error messages are as follow. My maven version is
> 3.6.3
> {code:java}
> [ERROR] Failed to execute goal
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> (compile-protoc) on project hbase-protocol-shaded: Execution compile-protoc
> of goal org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> failed: A required class was missing while executing
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile:
> org/codehaus/plexus/util/io/InputStreamFacade
> [ERROR] -
> [ERROR] realm =
> plugin>org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> [ERROR] urls[0] =
> file:/Users/haxl/.m2/repository/org/xolstice/maven/plugins/protobuf-maven-plugin/0.6.1/protobuf-maven-plugin-0.6.1.jar
> [ERROR] urls[1] =
> file:/Users/haxl/.m2/repository/org/codehaus/plexus/plexus-utils/1.1/plexus-utils-1.1.jar
> [ERROR] Number of foreign imports: 1
> [ERROR] import: Entry[import from realm
> ClassRealm[project>org.apache.hbase:hbase:3.0.0-SNAPSHOT, parent:
> ClassRealm[maven.api, parent: null]]]
> [ERROR]
> [ERROR] -
> [ERROR] : org.codehaus.plexus.util.io.InputStreamFacade
> [ERROR] -> [Help 1]
> [ERROR]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-25495) fix comment error of admin.rb
[ https://issues.apache.org/jira/browse/HBASE-25495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25495. --- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed Merged to master. Thanks for review [~vjasani] > fix comment error of admin.rb > -- > > Key: HBASE-25495 > URL: https://issues.apache.org/jira/browse/HBASE-25495 > Project: HBase > Issue Type: Bug >Reporter: xijiawen >Assignee: xijiawen >Priority: Minor > Fix For: 3.0.0-alpha-1 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25503) HBase code download is failing on windows with invalid path error
[
https://issues.apache.org/jira/browse/HBASE-25503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-25503:
Fix Version/s: (was: 2.4.2)
2.4.1
> HBase code download is failing on windows with invalid path error
> -
>
> Key: HBASE-25503
> URL: https://issues.apache.org/jira/browse/HBASE-25503
> Project: HBase
> Issue Type: Bug
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.1
>
>
> git pull command is failing with "error: invalid path"
> {noformat}
> Host1 MINGW64 /d/hbase (master)
> $ git pull
> error: invalid path
> 'dev-support/design-docs/HBASE-18070-ROOT_hbase:meta_Region_Replicas.pdf'
> Updating 2e96a5b2d3..dfefff7e59{noformat}
> This problem is coming only on windows machines. Tried on windows 7 and
> windows 10 both have problem. Searched on net, seems no any easy solution.
> Problem is because file HBASE-18070-ROOT_hbase:meta_Region_Replicas.pdf has
> colon in its name.
> To fix the problem we should remove the colon : from file name
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-25502) IntegrationTestMTTR fails with TableNotFoundException
[
https://issues.apache.org/jira/browse/HBASE-25502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-25502:
Fix Version/s: (was: 2.4.2)
2.4.1
> IntegrationTestMTTR fails with TableNotFoundException
> -
>
> Key: HBASE-25502
> URL: https://issues.apache.org/jira/browse/HBASE-25502
> Project: HBase
> Issue Type: Test
> Components: integration tests
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.1, 2.3.5
>
>
> Admin.getDescriptor() fails beacuse table doesn't exist.
>
> {noformat}
> org.apache.hadoop.hbase.TableNotFoundException: IntegrationTestMTTR
> at java.lang.Thread.getStackTrace(Thread.java:1559)
> at
> org.apache.hadoop.hbase.util.FutureUtils.setStackTrace(FutureUtils.java:130)
> at
> org.apache.hadoop.hbase.util.FutureUtils.rethrow(FutureUtils.java:149)
> at org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:172)
> at
> org.apache.hadoop.hbase.client.AdminOverAsyncAdmin.getDescriptor(AdminOverAsyncAdmin.java:163)
> at
> org.apache.hadoop.hbase.mttr.IntegrationTestMTTR.setupTables(IntegrationTestMTTR.java:236)
> at
> org.apache.hadoop.hbase.mttr.IntegrationTestMTTR.setUp(IntegrationTestMTTR.java:179)
>
> {noformat}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2866: HBASE-25478 - Implement retries when enabling tables in TestRegionReplicaReplicationEndpoint
Apache-HBase commented on pull request #2866: URL: https://github.com/apache/hbase/pull/2866#issuecomment-759704335 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 22s | master passed | | +1 :green_heart: | compile | 1m 6s | master passed | | +1 :green_heart: | shadedjars | 6m 47s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 9s | the patch passed | | +1 :green_heart: | compile | 1m 7s | the patch passed | | +1 :green_heart: | javac | 1m 7s | the patch passed | | +1 :green_heart: | shadedjars | 6m 40s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 140m 27s | hbase-server in the patch passed. | | | | 169m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2866/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2866 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c4773ce5d121 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dfefff7e59 | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2866/2/testReport/ | | Max. process+thread count | 4256 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2866/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2870: HBASE-24972 Wait for connection attempt to succeed before performing operations on ZK
Apache-HBase commented on pull request #2870: URL: https://github.com/apache/hbase/pull/2870#issuecomment-759707662 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 45s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 31s | master passed | | +1 :green_heart: | compile | 0m 23s | master passed | | +1 :green_heart: | shadedjars | 8m 53s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 19s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 37s | the patch passed | | +1 :green_heart: | compile | 0m 22s | the patch passed | | +1 :green_heart: | javac | 0m 22s | the patch passed | | +1 :green_heart: | shadedjars | 7m 38s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 16s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 12s | hbase-zookeeper in the patch passed. | | | | 33m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2870/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2870 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux bc2a4249f166 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4caab90aa7 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2870/2/testReport/ | | Max. process+thread count | 510 (vs. ulimit of 3) | | modules | C: hbase-zookeeper U: hbase-zookeeper | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2870/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25499) False-positive findbugs issue on branch-2.2
[
https://issues.apache.org/jira/browse/HBASE-25499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264402#comment-17264402
]
Hudson commented on HBASE-25499:
Results for branch branch-2.2
[build #154 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/154/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/154//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/154//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/154//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/154//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> False-positive findbugs issue on branch-2.2
> ---
>
> Key: HBASE-25499
> URL: https://issues.apache.org/jira/browse/HBASE-25499
> Project: HBase
> Issue Type: Bug
> Components: findbugs
>Affects Versions: 2.2.7
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 2.2.7
>
>
> Findbugs reports a false-positive issue.
> new org.apache.hadoop.hbase.rest.client.Client(Cluster, String, Optional,
> Optional) may fail to clean up java.io.InputStream
> Try-with-resource block is used so the resource is cleaned up but findbugs
> thinks it otherwise. I tried to reproduce the problem locally and using the
> same docker container nightly test is using but findbugs did not report the
> problem for me.
> Since branch-2.2 will be EOL soon I'd like to just add SuppressWarning to
> ignore the false-positive findbugs warning.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time
[
https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264440#comment-17264440
]
Hudson commented on HBASE-25329:
Results for branch branch-2
[build #157 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/157/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/157/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/157/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/157/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/157/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Dump region hashes in logs for the regions that are stuck in transition for
> more than a configured amount of time
> -
>
> Key: HBASE-25329
> URL: https://issues.apache.org/jira/browse/HBASE-25329
> Project: HBase
> Issue Type: Improvement
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.1
>
> Attachments: HBASE-25329.branch-1.000.patch,
> HBASE-25329.branch-2.000.patch, HBASE-25329.master.000.patch
>
>
> We have metrics for number of RITs as well as number of RITs above a certain
> threshold, but we don't have any way of keeping track of the region hashes of
> those RITs. It would be beneficial to emit those region hashes as a metric,
> as well as log them, so that we don't accidentally lose this information for
> debugging the RIT at a later tiime.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25211) Rack awareness in region_mover
[
https://issues.apache.org/jira/browse/HBASE-25211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264439#comment-17264439
]
Hudson commented on HBASE-25211:
Results for branch branch-2
[build #157 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/157/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/157/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/157/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/157/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/157/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Rack awareness in region_mover
> --
>
> Key: HBASE-25211
> URL: https://issues.apache.org/jira/browse/HBASE-25211
> Project: HBase
> Issue Type: Improvement
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.1
>
>
> region_mover should provide an option to ensure while unloading all regions,
> all destination servers are selected from different racks and not the one
> where server (where region_mover unload is getting executed) belongs to. This
> might be helpful option if we want to avail rack downtime (or rack upgrade)
> by stopping all Regionservers that belong to same rack for few hours. Without
> this option, we don't have any control over which destination server is
> selected and hence, some regions might keep bouncing from server A to B in
> the same rack all the way until they are finally moved to RS that belongs to
> separate rack.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25476) Enable error prone check in pre commit
[
https://issues.apache.org/jira/browse/HBASE-25476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264441#comment-17264441
]
Hudson commented on HBASE-25476:
Results for branch branch-2
[build #157 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/157/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/157/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/157/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/157/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/157/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Enable error prone check in pre commit
> --
>
> Key: HBASE-25476
> URL: https://issues.apache.org/jira/browse/HBASE-25476
> Project: HBase
> Issue Type: Improvement
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.1, 2.3.5
>
>
> This has been a pain in the past as the output is not stable, but in
> HBASE-25333, we found that some checks in error prone is really useful.
> So here I think we need to find a way to try to enable it again in pre commit.
> Maybe we could only check for ERROR level problems as it will cause
> compilation error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] joshelser commented on a change in pull request #2878: HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase…
joshelser commented on a change in pull request #2878: URL: https://github.com/apache/hbase/pull/2878#discussion_r556755329 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -1461,15 +1461,15 @@ possible configurations would overwhelm and obscure the important. dfs.client.read.shortcircuit -false + Review comment: hdfs-site.xml should be taking precedence over this property (I had a similar question about dfs.domain.socket.path) and this shouldn't be an issue in real life. However, I would also be ok coming back and just dropping these entries entirely in the future :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time
[ https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264372#comment-17264372 ] Andrew Kyle Purtell commented on HBASE-25329: - Thanks [~vjasani]. Thanks for the contribution [~caroliney14]! > Dump region hashes in logs for the regions that are stuck in transition for > more than a configured amount of time > - > > Key: HBASE-25329 > URL: https://issues.apache.org/jira/browse/HBASE-25329 > Project: HBase > Issue Type: Improvement >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.1 > > Attachments: HBASE-25329.branch-1.000.patch, > HBASE-25329.branch-2.000.patch, HBASE-25329.master.000.patch > > > We have metrics for number of RITs as well as number of RITs above a certain > threshold, but we don't have any way of keeping track of the region hashes of > those RITs. It would be beneficial to emit those region hashes as a metric, > as well as log them, so that we don't accidentally lose this information for > debugging the RIT at a later tiime. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack merged pull request #2873: HBASE-25495 fix comment error of admin.rb
saintstack merged pull request #2873: URL: https://github.com/apache/hbase/pull/2873 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #2870: HBASE-24972 Wait for connection attempt to succeed before performing operations on ZK
saintstack commented on pull request #2870: URL: https://github.com/apache/hbase/pull/2870#issuecomment-759672495 Rerunning build to see if failures related. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2876: HBASE-25494 Compilation failed due to conflict of plugin dependent pa…
Apache-HBase commented on pull request #2876: URL: https://github.com/apache/hbase/pull/2876#issuecomment-759706662 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 52s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 20s | master passed | | +1 :green_heart: | compile | 4m 42s | master passed | | +1 :green_heart: | shadedjars | 7m 51s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 44s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 2s | the patch passed | | +1 :green_heart: | compile | 3m 38s | the patch passed | | +1 :green_heart: | javac | 3m 38s | the patch passed | | +1 :green_heart: | shadedjars | 7m 46s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 252m 59s | root in the patch passed. | | | | 301m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2876/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2876 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e7610a1dd408 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dfefff7e59 | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2876/3/testReport/ | | Max. process+thread count | 4306 (vs. ulimit of 3) | | modules | C: hbase-resource-bundle . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2876/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time
[ https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264369#comment-17264369 ] Caroline commented on HBASE-25329: -- Thanks [~vjasani] > Dump region hashes in logs for the regions that are stuck in transition for > more than a configured amount of time > - > > Key: HBASE-25329 > URL: https://issues.apache.org/jira/browse/HBASE-25329 > Project: HBase > Issue Type: Improvement >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.1 > > Attachments: HBASE-25329.branch-1.000.patch, > HBASE-25329.branch-2.000.patch, HBASE-25329.master.000.patch > > > We have metrics for number of RITs as well as number of RITs above a certain > threshold, but we don't have any way of keeping track of the region hashes of > those RITs. It would be beneficial to emit those region hashes as a metric, > as well as log them, so that we don't accidentally lose this information for > debugging the RIT at a later tiime. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2878: HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase…
Apache-HBase commented on pull request #2878: URL: https://github.com/apache/hbase/pull/2878#issuecomment-759659908 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 13s | master passed | | +1 :green_heart: | compile | 1m 47s | master passed | | +1 :green_heart: | shadedjars | 8m 4s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 26s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 32s | the patch passed | | +1 :green_heart: | compile | 2m 10s | the patch passed | | +1 :green_heart: | javac | 2m 10s | the patch passed | | +1 :green_heart: | shadedjars | 9m 59s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 28s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 55s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 208m 44s | hbase-server in the patch passed. | | | | 249m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2878 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9141838d55ac 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dfefff7e59 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/2/testReport/ | | Max. process+thread count | 3597 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25476) Enable error prone check in pre commit
[ https://issues.apache.org/jira/browse/HBASE-25476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25476: Fix Version/s: (was: 2.4.2) 2.4.1 > Enable error prone check in pre commit > -- > > Key: HBASE-25476 > URL: https://issues.apache.org/jira/browse/HBASE-25476 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.1, 2.3.5 > > > This has been a pain in the past as the output is not stable, but in > HBASE-25333, we found that some checks in error prone is really useful. > So here I think we need to find a way to try to enable it again in pre commit. > Maybe we could only check for ERROR level problems as it will cause > compilation error. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2866: HBASE-25478 - Implement retries when enabling tables in TestRegionReplicaReplicationEndpoint
Apache-HBase commented on pull request #2866: URL: https://github.com/apache/hbase/pull/2866#issuecomment-759705539 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 29s | master passed | | +1 :green_heart: | compile | 0m 56s | master passed | | +1 :green_heart: | shadedjars | 6m 32s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 30s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | +1 :green_heart: | shadedjars | 6m 30s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 145m 47s | hbase-server in the patch passed. | | | | 171m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2866/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2866 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 255650aff769 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dfefff7e59 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2866/2/testReport/ | | Max. process+thread count | 4512 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2866/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25482) Improve SimpleRegionNormalizer#getAverageRegionSizeMb
[ https://issues.apache.org/jira/browse/HBASE-25482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25482: - Fix Version/s: 2.4.2 3.0.0-alpha-1 > Improve SimpleRegionNormalizer#getAverageRegionSizeMb > - > > Key: HBASE-25482 > URL: https://issues.apache.org/jira/browse/HBASE-25482 > Project: HBase > Issue Type: Improvement > Components: Normalizer >Affects Versions: 3.0.0-alpha-1, 2.4.0 >Reporter: Baiqiang Zhao >Assignee: Baiqiang Zhao >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.2 > > > If the table is set NormalizerTargetRegionSize, we take > NormalizerTargetRegionSize as avgRegionSize and return it. So the totalSizeMb > of table is not always calculated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25476) Enable error prone check in pre commit
[
https://issues.apache.org/jira/browse/HBASE-25476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264500#comment-17264500
]
Hudson commented on HBASE-25476:
Results for branch branch-2.3
[build #150 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/150/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/150/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/150/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/150/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/150/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Enable error prone check in pre commit
> --
>
> Key: HBASE-25476
> URL: https://issues.apache.org/jira/browse/HBASE-25476
> Project: HBase
> Issue Type: Improvement
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.1, 2.3.5
>
>
> This has been a pain in the past as the output is not stable, but in
> HBASE-25333, we found that some checks in error prone is really useful.
> So here I think we need to find a way to try to enable it again in pre commit.
> Maybe we could only check for ERROR level problems as it will cause
> compilation error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25317) [github]rename HBASE-18070-ROOT_hbase:meta_Region_Replicas.pdf
[ https://issues.apache.org/jira/browse/HBASE-25317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264503#comment-17264503 ] Michael Stack commented on HBASE-25317: --- Thanks [~pankajkumar] for doing the admin. > [github]rename HBASE-18070-ROOT_hbase:meta_Region_Replicas.pdf > -- > > Key: HBASE-25317 > URL: https://issues.apache.org/jira/browse/HBASE-25317 > Project: HBase > Issue Type: Bug >Reporter: Bo Cui >Priority: Minor > Attachments: image-2020-11-21-14-48-23-794.png > > > use git pull to obtain an exception, because filename has ':' > !image-2020-11-21-14-48-23-794.png! > workaround:git config core.protectNTFS false > [~stack] i think we can ranme filename... > . -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25476) Enable error prone check in pre commit
[ https://issues.apache.org/jira/browse/HBASE-25476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25476: -- Fix Version/s: 2.4.2 2.3.5 2.5.0 3.0.0-alpha-1 > Enable error prone check in pre commit > -- > > Key: HBASE-25476 > URL: https://issues.apache.org/jira/browse/HBASE-25476 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.5, 2.4.2 > > > This has been a pain in the past as the output is not stable, but in > HBASE-25333, we found that some checks in error prone is really useful. > So here I think we need to find a way to try to enable it again in pre commit. > Maybe we could only check for ERROR level problems as it will cause > compilation error. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-25476) Enable error prone check in pre commit
[ https://issues.apache.org/jira/browse/HBASE-25476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25476. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.3+. Thanks [~zghao] for reviewing. > Enable error prone check in pre commit > -- > > Key: HBASE-25476 > URL: https://issues.apache.org/jira/browse/HBASE-25476 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.5, 2.4.2 > > > This has been a pain in the past as the output is not stable, but in > HBASE-25333, we found that some checks in error prone is really useful. > So here I think we need to find a way to try to enable it again in pre commit. > Maybe we could only check for ERROR level problems as it will cause > compilation error. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] virajjasani closed pull request #2763: HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time
virajjasani closed pull request #2763: URL: https://github.com/apache/hbase/pull/2763 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #2763: HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time
virajjasani commented on pull request #2763: URL: https://github.com/apache/hbase/pull/2763#issuecomment-759302288 This is already committed: https://github.com/apache/hbase/commit/f4ad0d09886b7e14d8aeb43e017b19b96d591ce5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time
[ https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17263990#comment-17263990 ] Viraj Jasani commented on HBASE-25329: -- PR#2761 is merged to master and it was cleanly applied to branch-2 without any manual intervention. Closed PR#2763 as it is not needed anymore. Will take a look at branch-1 PR but before committing changes to branch-1, we are still left with few backports on various active branch-2.x. > Dump region hashes in logs for the regions that are stuck in transition for > more than a configured amount of time > - > > Key: HBASE-25329 > URL: https://issues.apache.org/jira/browse/HBASE-25329 > Project: HBase > Issue Type: Improvement >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0, 2.3.5, 2.4.2 > > Attachments: HBASE-25329.branch-1.000.patch, > HBASE-25329.branch-2.000.patch, HBASE-25329.master.000.patch > > > We have metrics for number of RITs as well as number of RITs above a certain > threshold, but we don't have any way of keeping track of the region hashes of > those RITs. It would be beneficial to emit those region hashes as a metric, > as well as log them, so that we don't accidentally lose this information for > debugging the RIT at a later tiime. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on a change in pull request #2874: HBASE-25496 add get_namespace_rsgroup command
virajjasani commented on a change in pull request #2874: URL: https://github.com/apache/hbase/pull/2874#discussion_r556362825 ## File path: hbase-shell/src/main/ruby/shell/commands/get_namespace_rsgroup.rb ## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +module Shell + module Commands +class GetNamespaceRsgroup < Command + def help +<<-EOF +Get the group name the given NameSpace is a member of. + +Example: + + hbase> get_namespace_rsgroup 'namespace_name' + +EOF + end + + def command(namespace_name) +group_name = admin.get_namespace_rsgroup(namespace_name) Review comment: With same changes, can you try searching for namespace which doesn't have any rsgroup? e.g if namespace 'NMn' exists but it is not part of any rsgroup (rsgroup feature is not enabled on cluster), then what will `get_namespace_rsgroup 'NMn'` return? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] leyangyueshan commented on a change in pull request #2874: HBASE-25496 add get_namespace_rsgroup command
leyangyueshan commented on a change in pull request #2874: URL: https://github.com/apache/hbase/pull/2874#discussion_r556365043 ## File path: hbase-shell/src/main/ruby/shell/commands/get_namespace_rsgroup.rb ## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +module Shell + module Commands +class GetNamespaceRsgroup < Command + def help +<<-EOF +Get the group name the given NameSpace is a member of. + +Example: + + hbase> get_namespace_rsgroup 'namespace_name' + +EOF + end + + def command(namespace_name) +group_name = admin.get_namespace_rsgroup(namespace_name) Review comment: thanks a lot， I will update this pr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2762: HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time
virajjasani commented on a change in pull request #2762:
URL: https://github.com/apache/hbase/pull/2762#discussion_r556369037
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
##
@@ -3538,18 +3538,31 @@ public void updateRegionsInTransitionMetrics() {
int totalRITs = 0;
int totalRITsOverThreshold = 0;
long oldestRITTime = 0;
+HashMap ritsOverThreshold = null;
int ritThreshold = this.server.getConfiguration().
getInt(HConstants.METRICS_RIT_STUCK_WARNING_THRESHOLD, 6);
for (RegionState state: regionStates.getRegionsInTransition()) {
totalRITs++;
long ritTime = currentTime - state.getStamp();
if (ritTime > ritThreshold) { // more than the threshold
totalRITsOverThreshold++;
+if (ritsOverThreshold == null) {
+ ritsOverThreshold = new HashMap();
+}
+ritsOverThreshold.put(state.getRegion().getEncodedName(), state);
}
if (oldestRITTime < ritTime) {
oldestRITTime = ritTime;
}
}
+if (LOG.isDebugEnabled() && ritsOverThreshold != null &&
!ritsOverThreshold.isEmpty()) {
+ StringBuilder sb = new StringBuilder();
+ for (String regionName: ritsOverThreshold.keySet()) {
+sb.append(regionName + ":" +
ritsOverThreshold.get(regionName).getState().name() + "\n");
+ }
+ sb.delete(sb.length()-2, sb.length());
Review comment:
Do we want to remove last appended new line char? If so, start index
should be `sb.length()-1` right?
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
##
@@ -3538,18 +3538,31 @@ public void updateRegionsInTransitionMetrics() {
int totalRITs = 0;
int totalRITsOverThreshold = 0;
long oldestRITTime = 0;
+HashMap ritsOverThreshold = null;
int ritThreshold = this.server.getConfiguration().
getInt(HConstants.METRICS_RIT_STUCK_WARNING_THRESHOLD, 6);
for (RegionState state: regionStates.getRegionsInTransition()) {
totalRITs++;
long ritTime = currentTime - state.getStamp();
if (ritTime > ritThreshold) { // more than the threshold
totalRITsOverThreshold++;
+if (ritsOverThreshold == null) {
+ ritsOverThreshold = new HashMap();
+}
+ritsOverThreshold.put(state.getRegion().getEncodedName(), state);
}
if (oldestRITTime < ritTime) {
oldestRITTime = ritTime;
}
}
+if (LOG.isDebugEnabled() && ritsOverThreshold != null &&
!ritsOverThreshold.isEmpty()) {
+ StringBuilder sb = new StringBuilder();
+ for (String regionName: ritsOverThreshold.keySet()) {
+sb.append(regionName + ":" +
ritsOverThreshold.get(regionName).getState().name() + "\n");
Review comment:
nit: use chain of append() to cover String concatenation?
```
sb.append(regionName).append(":")
.append(ritsOverThreshold.get(regionName).getState().name()).append("\n");
```
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
##
@@ -3538,18 +3538,31 @@ public void updateRegionsInTransitionMetrics() {
int totalRITs = 0;
int totalRITsOverThreshold = 0;
long oldestRITTime = 0;
+HashMap ritsOverThreshold = null;
int ritThreshold = this.server.getConfiguration().
getInt(HConstants.METRICS_RIT_STUCK_WARNING_THRESHOLD, 6);
for (RegionState state: regionStates.getRegionsInTransition()) {
totalRITs++;
long ritTime = currentTime - state.getStamp();
if (ritTime > ritThreshold) { // more than the threshold
totalRITsOverThreshold++;
+if (ritsOverThreshold == null) {
+ ritsOverThreshold = new HashMap();
Review comment:
nit: `new HashMap<>()`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2762: HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time
virajjasani commented on a change in pull request #2762:
URL: https://github.com/apache/hbase/pull/2762#discussion_r556370161
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
##
@@ -3538,18 +3538,31 @@ public void updateRegionsInTransitionMetrics() {
int totalRITs = 0;
int totalRITsOverThreshold = 0;
long oldestRITTime = 0;
+HashMap ritsOverThreshold = null;
Review comment:
nit: `Map ritsOverThreshold = null`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-25505) ZK watcher threads are daemonized; reconsider
[ https://issues.apache.org/jira/browse/HBASE-25505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264559#comment-17264559 ] Bharath Vissapragada commented on HBASE-25505: -- Agree with the opinion. Marking them as daemon just for convenience masks the root problem of an orderly shutdown. I'd prefer to fix the root cause instead. > ZK watcher threads are daemonized; reconsider > - > > Key: HBASE-25505 > URL: https://issues.apache.org/jira/browse/HBASE-25505 > Project: HBase > Issue Type: Brainstorming >Reporter: Andrew Kyle Purtell >Priority: Major > > On HBASE-25279 there was some discussion and difference of opinion about > having ZK watcher pool threads be daemonized. This is not necessarily a > problem but should be reconsidered. > Daemon threads are subject to abrupt termination during JVM shutdown and > therefore may be interrupted before state changes are complete or resources > are released. > As long as ZK watchers are properly closed by shutdown logic the pool threads > will be terminated in a controlled manner and the JVM will exit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] leyangyueshan commented on pull request #2875: HBASE-25497 move_namespaces_rsgroup should change hbase.rsgroup.name …
leyangyueshan commented on pull request #2875: URL: https://github.com/apache/hbase/pull/2875#issuecomment-759888910 > I think the type of this patch should be bug other than improvement, if it is true, maybe we'd better to update the related unit test, since it does not cover this case. Thanks. thanks a lot, the ps has updated ! add unit test , please review again ! @bsglz @virajjasani This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] leyangyueshan commented on pull request #2875: HBASE-25497 move_namespaces_rsgroup should change hbase.rsgroup.name …
leyangyueshan commented on pull request #2875: URL: https://github.com/apache/hbase/pull/2875#issuecomment-759889908  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2858: HBASE-25482 Improve SimpleRegionNormalizer#getAverageRegionSizeMb
Apache-HBase commented on pull request #2858: URL: https://github.com/apache/hbase/pull/2858#issuecomment-759891756 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 28s | master passed | | +1 :green_heart: | compile | 1m 1s | master passed | | +1 :green_heart: | shadedjars | 6m 44s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 34s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | +1 :green_heart: | shadedjars | 6m 36s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 144m 59s | hbase-server in the patch passed. | | | | 171m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2858/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2858 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d57292bf8a88 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4caab90aa7 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2858/3/testReport/ | | Max. process+thread count | 4417 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2858/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2875: HBASE-25497 move_namespaces_rsgroup should change hbase.rsgroup.name …
Apache-HBase commented on pull request #2875: URL: https://github.com/apache/hbase/pull/2875#issuecomment-759892298 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 41s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 32s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 16s | the patch passed | | -0 :warning: | rubocop | 0m 10s | The patch generated 6 new + 17 unchanged - 1 fixed = 23 total (was 18) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 12m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2875/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2875 | | Optional Tests | dupname asflicense javac rubocop | | uname | Linux aad1ef213c25 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3488c44a21 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2875/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt | | Max. process+thread count | 65 (vs. ulimit of 3) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2875/3/console | | versions | git=2.17.1 maven=3.6.3 rubocop=0.80.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2875: HBASE-25497 move_namespaces_rsgroup should change hbase.rsgroup.name …
Apache-HBase commented on pull request #2875: URL: https://github.com/apache/hbase/pull/2875#issuecomment-759893985 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 13s | master passed | | +1 :green_heart: | javadoc | 0m 14s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 54s | the patch passed | | +1 :green_heart: | javadoc | 0m 11s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 6m 56s | hbase-shell in the patch passed. | | | | 17m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2875/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2875 | | Optional Tests | javac javadoc unit | | uname | Linux 4ac2338b514a 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3488c44a21 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2875/3/testReport/ | | Max. process+thread count | 1525 (vs. ulimit of 3) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2875/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2875: HBASE-25497 move_namespaces_rsgroup should change hbase.rsgroup.name …
Apache-HBase commented on pull request #2875: URL: https://github.com/apache/hbase/pull/2875#issuecomment-759894224 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 28s | master passed | | +1 :green_heart: | javadoc | 0m 17s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 18s | the patch passed | | +1 :green_heart: | javadoc | 0m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 7m 29s | hbase-shell in the patch passed. | | | | 18m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2875/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2875 | | Optional Tests | javac javadoc unit | | uname | Linux c70881902ccf 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3488c44a21 | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2875/3/testReport/ | | Max. process+thread count | 2197 (vs. ulimit of 3) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2875/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2875: HBASE-25497 move_namespaces_rsgroup should change hbase.rsgroup.name …
Apache-HBase commented on pull request #2875: URL: https://github.com/apache/hbase/pull/2875#issuecomment-759897924 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 41s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 15s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 12s | the patch passed | | -0 :warning: | rubocop | 0m 7s | The patch generated 4 new + 17 unchanged - 1 fixed = 21 total (was 18) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 11m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2875/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2875 | | Optional Tests | dupname asflicense javac rubocop | | uname | Linux a0156fad39ab 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3488c44a21 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2875/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt | | Max. process+thread count | 66 (vs. ulimit of 3) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2875/4/console | | versions | git=2.17.1 maven=3.6.3 rubocop=0.80.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2875: HBASE-25497 move_namespaces_rsgroup should change hbase.rsgroup.name …
Apache-HBase commented on pull request #2875: URL: https://github.com/apache/hbase/pull/2875#issuecomment-759899603 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 33s | master passed | | +1 :green_heart: | javadoc | 0m 14s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 30s | the patch passed | | +1 :green_heart: | javadoc | 0m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 6m 59s | hbase-shell in the patch passed. | | | | 17m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2875/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2875 | | Optional Tests | javac javadoc unit | | uname | Linux 5e1039615253 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3488c44a21 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2875/4/testReport/ | | Max. process+thread count | 2381 (vs. ulimit of 3) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2875/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2875: HBASE-25497 move_namespaces_rsgroup should change hbase.rsgroup.name …
Apache-HBase commented on pull request #2875: URL: https://github.com/apache/hbase/pull/2875#issuecomment-759899751 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 2s | master passed | | +1 :green_heart: | javadoc | 0m 15s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 8s | the patch passed | | +1 :green_heart: | javadoc | 0m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 7m 28s | hbase-shell in the patch passed. | | | | 17m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2875/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2875 | | Optional Tests | javac javadoc unit | | uname | Linux 840f86332dde 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3488c44a21 | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2875/4/testReport/ | | Max. process+thread count | 2214 (vs. ulimit of 3) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2875/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bharathv commented on a change in pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master
bharathv commented on a change in pull request #2769:
URL: https://github.com/apache/hbase/pull/2769#discussion_r557017830
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
##
@@ -100,6 +104,25 @@ public static void afterAllTests() throws Exception {
TEST_UTIL.shutdownMiniCluster();
}
+ @Test
+ public void testRegionServerStartup() throws Exception {
Review comment:
nit: Add some detail about what this test does? (preferably with a
reference to the jira ID).
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
##
@@ -100,6 +104,25 @@ public static void afterAllTests() throws Exception {
TEST_UTIL.shutdownMiniCluster();
}
+ @Test
+ public void testRegionServerStartup() throws Exception {
+MiniHBaseCluster cluster = TEST_UTIL.getHBaseCluster();
+HMaster m = cluster.getMaster();
+// Check there are 2 regionservers in master's online servers list
+Assert.assertEquals(2, m.getServerManager().countOfRegionServers());
+// Add invalid peer so that regionserver startup will take a long time
+try {
+ ReplicationPeerConfig rpc = new ReplicationPeerConfig();
+ admin.addReplicationPeer("INVALID-PEER", rpc);
+} catch (DoNotRetryIOException e) {
Review comment:
The test also passes without the patch, did I miss something? Not sure
I fully understand the intent here, if you get an exception with add_peer RPC,
its not added, right?
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
##
@@ -227,10 +227,6 @@ ServerName regionServerStartup(RegionServerStartupRequest
request, int versionNu
ServerName sn = ServerName.valueOf(hostname, request.getPort(),
request.getServerStartCode());
checkClockSkew(sn, request.getServerCurrentTime());
checkIsDead(sn, "STARTUP");
-if (!checkAndRecordNewServer(sn, ServerMetricsBuilder.of(sn,
versionNumber, version))) {
Review comment:
method javadoc needs updation. Also please add the detail that the
regionserver will be added in it's first report (for readers).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] pankaj72981 merged pull request #2779: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…
pankaj72981 merged pull request #2779: URL: https://github.com/apache/hbase/pull/2779 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-23340) hmaster /hbase/replication/rs session expired (hbase replication default value is true, we don't use ) causes logcleaner can not clean oldWALs, which resulits i
[ https://issues.apache.org/jira/browse/HBASE-23340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264578#comment-17264578 ] Pankaj Kumar edited comment on HBASE-23340 at 1/14/21, 3:38 AM: Thanks [~zhangduo] & [~vjasani] for the review & [~Bo Cui] for the contribution. was (Author: pankajkumar): Thanks [~zhangduo] for the review & [~Bo Cui] for the contribution. > hmaster /hbase/replication/rs session expired (hbase replication default > value is true, we don't use ) causes logcleaner can not clean oldWALs, which > resulits in oldWALs too large (more than 2TB) > - > > Key: HBASE-23340 > URL: https://issues.apache.org/jira/browse/HBASE-23340 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 3.0.0-alpha-1, 2.2.3 >Reporter: jackylau >Assignee: Bo Cui >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0 > > Attachments: Snipaste_2019-11-21_10-39-25.png, > Snipaste_2019-11-21_14-10-36.png > > > hmaster /hbase/replication/rs session expired (hbase replication default > value is true, we don't use ) causes logcleaner can not clean oldWALs, which > resulits in oldWALs too large (more than 2TB). > !Snipaste_2019-11-21_10-39-25.png! > > !Snipaste_2019-11-21_14-10-36.png! > > we can solve it by following : > 1) increase the session timeout(but i think it is not a good idea. because we > do not know how long to set is suitable) > 2) close the hbase replication. It is not a good idea too, when our user uses > this feature > 3) we need add retry times, for example when it has already happened three > times, we set the ReplicationLogCleaner and SnapShotCleaner stop > that is all my ideas, i do not konw it is suitable, If it is suitable, could > i commit a PR? > Does anynode have a good idea. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23340) hmaster /hbase/replication/rs session expired (hbase replication default value is true, we don't use ) causes logcleaner can not clean oldWALs, which resulits in oldWA
[ https://issues.apache.org/jira/browse/HBASE-23340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-23340: - Fix Version/s: 2.5.0 3.0.0-alpha-1 Resolution: Fixed Status: Resolved (was: Patch Available) Thanks [~zhangduo] for the review & [~Bo Cui] for the contribution. > hmaster /hbase/replication/rs session expired (hbase replication default > value is true, we don't use ) causes logcleaner can not clean oldWALs, which > resulits in oldWALs too large (more than 2TB) > - > > Key: HBASE-23340 > URL: https://issues.apache.org/jira/browse/HBASE-23340 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 3.0.0-alpha-1, 2.2.3 >Reporter: jackylau >Assignee: Bo Cui >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0 > > Attachments: Snipaste_2019-11-21_10-39-25.png, > Snipaste_2019-11-21_14-10-36.png > > > hmaster /hbase/replication/rs session expired (hbase replication default > value is true, we don't use ) causes logcleaner can not clean oldWALs, which > resulits in oldWALs too large (more than 2TB). > !Snipaste_2019-11-21_10-39-25.png! > > !Snipaste_2019-11-21_14-10-36.png! > > we can solve it by following : > 1) increase the session timeout(but i think it is not a good idea. because we > do not know how long to set is suitable) > 2) close the hbase replication. It is not a good idea too, when our user uses > this feature > 3) we need add retry times, for example when it has already happened three > times, we set the ReplicationLogCleaner and SnapShotCleaner stop > that is all my ideas, i do not konw it is suitable, If it is suitable, could > i commit a PR? > Does anynode have a good idea. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] petersomogyi merged pull request #2877: HBASE-25499 False-positive findbugs issue on branch-2.2
petersomogyi merged pull request #2877: URL: https://github.com/apache/hbase/pull/2877 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #2861: HBASE-25455 Add trace support for HRegion read/write operation
Apache9 commented on a change in pull request #2861:
URL: https://github.com/apache/hbase/pull/2861#discussion_r556333417
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##
@@ -6637,23 +6655,27 @@ protected RowLock getRowLockInternal(byte[] row,
boolean readLock, final RowLock
}
rowLockContext.setThreadName(Thread.currentThread().getName());
success = true;
+ span.setStatus(StatusCode.OK);
return result;
} catch (InterruptedException ie) {
if (LOG.isDebugEnabled()) {
LOG.debug("Thread interrupted waiting for lock on row: {}, in region
{}", rowKey,
getRegionInfo().getRegionNameAsString());
}
- span.addEvent("Interrupted exception getting row lock");
+ TraceUtil.setError(span, ie);
throw throwOnInterrupt(ie);
} catch (Error error) {
// The maximum lock count for read lock is 64K (hardcoded), when this
maximum count
// is reached, it will throw out an Error. This Error needs to be caught
so it can
// go ahead to process the minibatch with lock acquired.
LOG.warn("Error to get row lock for {}, in region {}, cause: {}",
Bytes.toStringBinary(row),
getRegionInfo().getRegionNameAsString(), error);
+ TraceUtil.setError(span, error);
IOException ioe = new IOException(error);
- span.addEvent("Error getting row lock");
throw ioe;
+} catch (Throwable t) {
Review comment:
This is for recording the span status.
Let me see if we could change to use TraceUtil.trace to increase the
readability.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (HBASE-25499) False-positive findbugs issue on branch-2.2
[ https://issues.apache.org/jira/browse/HBASE-25499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-25499: -- Fix Version/s: 2.2.7 Resolution: Fixed Status: Resolved (was: Patch Available) Merged PR to branch-2.2. > False-positive findbugs issue on branch-2.2 > --- > > Key: HBASE-25499 > URL: https://issues.apache.org/jira/browse/HBASE-25499 > Project: HBase > Issue Type: Bug > Components: findbugs >Affects Versions: 2.2.7 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Major > Fix For: 2.2.7 > > > Findbugs reports a false-positive issue. > new org.apache.hadoop.hbase.rest.client.Client(Cluster, String, Optional, > Optional) may fail to clean up java.io.InputStream > Try-with-resource block is used so the resource is cleaned up but findbugs > thinks it otherwise. I tried to reproduce the problem locally and using the > same docker container nightly test is using but findbugs did not report the > problem for me. > Since branch-2.2 will be EOL soon I'd like to just add SuppressWarning to > ignore the false-positive findbugs warning. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] shenshengli commented on pull request #2878: HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase…
shenshengli commented on pull request #2878: URL: https://github.com/apache/hbase/pull/2878#issuecomment-759855122 Thank you for your revision so that this change can proceed quickly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25449) 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml
[ https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shenshengli updated HBASE-25449: Description: I think this parameter is not suitable for in hbase-default.xml, because in this case, HDFS explicitly set to "dfs.client.read.shortcircuit=true", hbase rely on HDFS configuration, the parameters in hbase service still is false.Must be explicitly in hbase-site.xml is set to "dfs.client.read.shortcircuit=true" to take effect.The same goes for the parameter 'dfs.domain.socket.path', which is already covered in the specific change (was: I think this parameter is not suitable for in hbase-default.xml, because in this case, HDFS explicitly set to "dfs.client.read.shortcircuit=true", hbase rely on HDFS configuration, the parameters in hbase service still is false.Must be explicitly in hbase-site.xml is set to "dfs.client.read.shortcircuit=true" to take effect.) > 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml > - > > Key: HBASE-25449 > URL: https://issues.apache.org/jira/browse/HBASE-25449 > Project: HBase > Issue Type: Improvement > Components: conf >Affects Versions: 2.0.1 >Reporter: shenshengli >Assignee: shenshengli >Priority: Major > Fix For: 3.0.0-alpha-1, 2.2.7, 2.5.0, 2.3.5, 2.4.2 > > > I think this parameter is not suitable for in hbase-default.xml, because in > this case, HDFS explicitly set to "dfs.client.read.shortcircuit=true", hbase > rely on HDFS configuration, the parameters in hbase service still is > false.Must be explicitly in hbase-site.xml is set to > "dfs.client.read.shortcircuit=true" to take effect.The same goes for the > parameter 'dfs.domain.socket.path', which is already covered in the specific > change -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] cuibo01 commented on pull request #2511: HBASE-24960 reduce invalid subprocedure task
cuibo01 commented on pull request #2511: URL: https://github.com/apache/hbase/pull/2511#issuecomment-759859195 @saintstack pls review...thx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] cuibo01 commented on pull request #2779: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…
cuibo01 commented on pull request #2779: URL: https://github.com/apache/hbase/pull/2779#issuecomment-759860457 @Apache9 pls review，thx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] cuibo01 commented on pull request #2690: HBASE-24395 Backport HBASE-20589 to branch-1
cuibo01 commented on pull request #2690: URL: https://github.com/apache/hbase/pull/2690#issuecomment-759861104 @saintstack @pankaj72981 pls review，and merge. thx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] cuibo01 commented on pull request #2843: HBASE-25461 when the cluster has many tables, UI can be opened quickly
cuibo01 commented on pull request #2843: URL: https://github.com/apache/hbase/pull/2843#issuecomment-759862051 @Apache9 @saintstack @pankaj72981 pls review， thx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25279) Non-daemon thread in ZKWatcher
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-25279: --- Fix Version/s: (was: 2.4.2) > Non-daemon thread in ZKWatcher > -- > > Key: HBASE-25279 > URL: https://issues.apache.org/jira/browse/HBASE-25279 > Project: HBase > Issue Type: Bug > Components: Zookeeper >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.5.0 > > > ZKWatcher spawns an ExecutorService which doesn't mark its threads as daemons > which will prevent clean shut downs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264533#comment-17264533 ] Andrew Kyle Purtell commented on HBASE-25279: - Don't commit it there, please. Not everyone agrees it is the right approach. > Non-daemon thread in ZKWatcher > -- > > Key: HBASE-25279 > URL: https://issues.apache.org/jira/browse/HBASE-25279 > Project: HBase > Issue Type: Bug > Components: Zookeeper >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.2 > > > ZKWatcher spawns an ExecutorService which doesn't mark its threads as daemons > which will prevent clean shut downs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25279) Non-daemon thread in ZKWatcher
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-25279: --- Fix Version/s: 2.4.2 > Non-daemon thread in ZKWatcher > -- > > Key: HBASE-25279 > URL: https://issues.apache.org/jira/browse/HBASE-25279 > Project: HBase > Issue Type: Bug > Components: Zookeeper >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.2 > > > ZKWatcher spawns an ExecutorService which doesn't mark its threads as daemons > which will prevent clean shut downs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264534#comment-17264534 ] Duo Zhang commented on HBASE-25279: --- I think this is a bug fix, without the patch it is impossible to do a clean shutdown. So let's cherry-pick it to branch-2.4? > Non-daemon thread in ZKWatcher > -- > > Key: HBASE-25279 > URL: https://issues.apache.org/jira/browse/HBASE-25279 > Project: HBase > Issue Type: Bug > Components: Zookeeper >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.2 > > > ZKWatcher spawns an ExecutorService which doesn't mark its threads as daemons > which will prevent clean shut downs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-25279) Non-daemon thread in ZKWatcher
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264535#comment-17264535 ] Josh Elser edited comment on HBASE-25279 at 1/14/21, 1:49 AM: -- bq. Don't commit it there, please. Not everyone agrees it is the right approach. Uh.. ok? What's the issue? What's your expectation in re-opening this then (if not to just change the fixVersion). I'm confused why we don't fix the bug and then you (or whomever has objections) can make whatever changes they like. I'm genuinely confused how this change is contentious. was (Author: elserj): bq. Don't commit it there, please. Not everyone agrees it is the right approach. Uh.. ok? What's the issue? What's your expectation in re-opening this then (if not to just change the fixVersion). I'm confused why we don't fix the bug and then you (or whomever has objections) can fix make whatever changes they like. I'm genuinely confused how this change is contentious. > Non-daemon thread in ZKWatcher > -- > > Key: HBASE-25279 > URL: https://issues.apache.org/jira/browse/HBASE-25279 > Project: HBase > Issue Type: Bug > Components: Zookeeper >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.5.0 > > > ZKWatcher spawns an ExecutorService which doesn't mark its threads as daemons > which will prevent clean shut downs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264536#comment-17264536 ] Andrew Kyle Purtell commented on HBASE-25279: - [~elserj] [~bharathv] [~larsh] So what do we do here? There is a difference of opinion. I think making ZK watcher threads daemon threads are problematic. These respond to watch events and process them. If they are daemonized if the process exits the thread can be terminated in the middle of updating other state. > Non-daemon thread in ZKWatcher > -- > > Key: HBASE-25279 > URL: https://issues.apache.org/jira/browse/HBASE-25279 > Project: HBase > Issue Type: Bug > Components: Zookeeper >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.5.0 > > > ZKWatcher spawns an ExecutorService which doesn't mark its threads as daemons > which will prevent clean shut downs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264537#comment-17264537 ] Andrew Kyle Purtell commented on HBASE-25279: - Why is the watcher not being closed? That is the bug. Making these threads daemon threads works around a problem but does not address the root cause. > Non-daemon thread in ZKWatcher > -- > > Key: HBASE-25279 > URL: https://issues.apache.org/jira/browse/HBASE-25279 > Project: HBase > Issue Type: Bug > Components: Zookeeper >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.5.0 > > > ZKWatcher spawns an ExecutorService which doesn't mark its threads as daemons > which will prevent clean shut downs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264543#comment-17264543 ] Andrew Kyle Purtell commented on HBASE-25279: - I was going to wait until we have a proper fix in place before moving forward with a release from branch-2.4. [~zhangduo] argues this restores old behavior. I would buy that argument but don't want this issue to get lost. What should we do here? > Non-daemon thread in ZKWatcher > -- > > Key: HBASE-25279 > URL: https://issues.apache.org/jira/browse/HBASE-25279 > Project: HBase > Issue Type: Bug > Components: Zookeeper >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.5.0 > > > ZKWatcher spawns an ExecutorService which doesn't mark its threads as daemons > which will prevent clean shut downs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264545#comment-17264545 ] Andrew Kyle Purtell commented on HBASE-25279: - Ok, I've thought about it, and I'm going to do what [~zhangduo] recommends. Let me pick this to branch-2.4, close this, and open a new issue. > Non-daemon thread in ZKWatcher > -- > > Key: HBASE-25279 > URL: https://issues.apache.org/jira/browse/HBASE-25279 > Project: HBase > Issue Type: Bug > Components: Zookeeper >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.5.0 > > > ZKWatcher spawns an ExecutorService which doesn't mark its threads as daemons > which will prevent clean shut downs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25279) Non-daemon thread in ZKWatcher
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25279: Fix Version/s: 2.4.1 > Non-daemon thread in ZKWatcher > -- > > Key: HBASE-25279 > URL: https://issues.apache.org/jira/browse/HBASE-25279 > Project: HBase > Issue Type: Bug > Components: Zookeeper >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.1 > > > ZKWatcher spawns an ExecutorService which doesn't mark its threads as daemons > which will prevent clean shut downs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-25279) Non-daemon thread in ZKWatcher
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell resolved HBASE-25279. - Resolution: Fixed > Non-daemon thread in ZKWatcher > -- > > Key: HBASE-25279 > URL: https://issues.apache.org/jira/browse/HBASE-25279 > Project: HBase > Issue Type: Bug > Components: Zookeeper >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.1 > > > ZKWatcher spawns an ExecutorService which doesn't mark its threads as daemons > which will prevent clean shut downs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264547#comment-17264547 ] Andrew Kyle Purtell commented on HBASE-25279: - Filed HBASE-25505 for follow up > Non-daemon thread in ZKWatcher > -- > > Key: HBASE-25279 > URL: https://issues.apache.org/jira/browse/HBASE-25279 > Project: HBase > Issue Type: Bug > Components: Zookeeper >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.1 > > > ZKWatcher spawns an ExecutorService which doesn't mark its threads as daemons > which will prevent clean shut downs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25505) ZK watcher threads are daemonized; reconsider
Andrew Kyle Purtell created HBASE-25505: --- Summary: ZK watcher threads are daemonized; reconsider Key: HBASE-25505 URL: https://issues.apache.org/jira/browse/HBASE-25505 Project: HBase Issue Type: Brainstorming Reporter: Andrew Kyle Purtell On HBASE-25279 there was some discussion and difference of opinion about having ZK watcher pool threads be daemonized. This is not necessarily a problem but should be reconsidered. Daemon threads are subject to abrupt termination during JVM shutdown and therefore may be interrupted before state changes are complete or resources are released. As long as ZK watchers are properly closed by shutdown logic the pool threads will be terminated in a controlled manner and the JVM will exit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] joshelser commented on pull request #2816: HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml
joshelser commented on pull request #2816: URL: https://github.com/apache/hbase/pull/2816#issuecomment-759883012 This was submitted, reverted due to breaking tests, but then resubmitted after fixing those tests in #2878 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] joshelser closed pull request #2878: HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase…
joshelser closed pull request #2878: URL: https://github.com/apache/hbase/pull/2878 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] joshelser closed pull request #2816: HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml
joshelser closed pull request #2816: URL: https://github.com/apache/hbase/pull/2816 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25449) 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml
[ https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-25449: --- Resolution: Fixed Status: Resolved (was: Patch Available) Re-resolving. Hopefully this doesn't more headache. I'll watch the QA run tonight. > 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml > - > > Key: HBASE-25449 > URL: https://issues.apache.org/jira/browse/HBASE-25449 > Project: HBase > Issue Type: Improvement > Components: conf >Affects Versions: 2.0.1 >Reporter: shenshengli >Assignee: shenshengli >Priority: Major > Fix For: 3.0.0-alpha-1, 2.2.7, 2.5.0, 2.3.5, 2.4.2 > > > I think this parameter is not suitable for in hbase-default.xml, because in > this case, HDFS explicitly set to "dfs.client.read.shortcircuit=true", hbase > rely on HDFS configuration, the parameters in hbase service still is > false.Must be explicitly in hbase-site.xml is set to > "dfs.client.read.shortcircuit=true" to take effect.The same goes for the > parameter 'dfs.domain.socket.path', which is already covered in the specific > change. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2858: HBASE-25482 Improve SimpleRegionNormalizer#getAverageRegionSizeMb
Apache-HBase commented on pull request #2858: URL: https://github.com/apache/hbase/pull/2858#issuecomment-759853316 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 1s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 30s | master passed | | +1 :green_heart: | compile | 3m 18s | master passed | | +1 :green_heart: | checkstyle | 1m 2s | master passed | | +1 :green_heart: | spotbugs | 1m 59s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 36s | the patch passed | | +1 :green_heart: | compile | 3m 14s | the patch passed | | +1 :green_heart: | javac | 3m 14s | the patch passed | | +1 :green_heart: | checkstyle | 1m 3s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 20m 40s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 52s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 50m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2858/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2858 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux a6e3c955836f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4caab90aa7 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Max. process+thread count | 97 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2858/3/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25449) 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml
[ https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shenshengli updated HBASE-25449: Description: I think this parameter is not suitable for in hbase-default.xml, because in this case, HDFS explicitly set to "dfs.client.read.shortcircuit=true", hbase rely on HDFS configuration, the parameters in hbase service still is false.Must be explicitly in hbase-site.xml is set to "dfs.client.read.shortcircuit=true" to take effect.The same goes for the parameter 'dfs.domain.socket.path', which is already covered in the specific change. (was: I think this parameter is not suitable for in hbase-default.xml, because in this case, HDFS explicitly set to "dfs.client.read.shortcircuit=true", hbase rely on HDFS configuration, the parameters in hbase service still is false.Must be explicitly in hbase-site.xml is set to "dfs.client.read.shortcircuit=true" to take effect.The same goes for the parameter 'dfs.domain.socket.path', which is already covered in the specific change) > 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml > - > > Key: HBASE-25449 > URL: https://issues.apache.org/jira/browse/HBASE-25449 > Project: HBase > Issue Type: Improvement > Components: conf >Affects Versions: 2.0.1 >Reporter: shenshengli >Assignee: shenshengli >Priority: Major > Fix For: 3.0.0-alpha-1, 2.2.7, 2.5.0, 2.3.5, 2.4.2 > > > I think this parameter is not suitable for in hbase-default.xml, because in > this case, HDFS explicitly set to "dfs.client.read.shortcircuit=true", hbase > rely on HDFS configuration, the parameters in hbase service still is > false.Must be explicitly in hbase-site.xml is set to > "dfs.client.read.shortcircuit=true" to take effect.The same goes for the > parameter 'dfs.domain.socket.path', which is already covered in the specific > change. -- This message was sent by Atlassian Jira (v8.3.4#803005)
