[GitHub] [hbase] Apache9 opened a new pull request #3248: HBASE-25852 Move all the intialization work of LoadBalancer implement…

2021-05-08 Thread GitBox
Apache9 opened a new pull request #3248: URL: https://github.com/apache/hbase/pull/3248 …ation to initialize method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [hbase] Apache-HBase commented on pull request #3248: HBASE-25852 Move all the intialization work of LoadBalancer implement…

2021-05-08 Thread GitBox
Apache-HBase commented on pull request #3248: URL: https://github.com/apache/hbase/pull/3248#issuecomment-835427085 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] apurtell commented on a change in pull request #3244: [WIP] HBASE-25869 WAL value compression

2021-05-08 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r628787521 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java ## @@ -256,6 +270,28 @@ public void write(Cell cell)

[jira] [Commented] (HBASE-25837) TestRollingRestart is flaky

2021-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341383#comment-17341383 ] Hudson commented on HBASE-25837: Results for branch branch-2 [build #245 on

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341384#comment-17341384 ] Hudson commented on HBASE-25774: Results for branch branch-2 [build #245 on

[jira] [Commented] (HBASE-25850) Fix spotbugs warnings on branch-2

2021-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341382#comment-17341382 ] Hudson commented on HBASE-25850: Results for branch branch-2 [build #245 on

[jira] [Commented] (HBASE-25860) Add metric for successful wal roll requests.

2021-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341385#comment-17341385 ] Hudson commented on HBASE-25860: Results for branch branch-2 [build #245 on

[GitHub] [hbase] virajjasani merged pull request #3245: HBASE-25790 NamedQueue 'BalancerRejection' for recent history of bala…

2021-05-08 Thread GitBox
virajjasani merged pull request #3245: URL: https://github.com/apache/hbase/pull/3245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache-HBase removed a comment on pull request #3244: [WIP] HBASE-25869 WAL value compression

2021-05-08 Thread GitBox
Apache-HBase removed a comment on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-834987575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341351#comment-17341351 ] Hudson commented on HBASE-25774: Results for branch branch-1 [build #124 on

[jira] [Commented] (HBASE-25860) Add metric for successful wal roll requests.

2021-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341352#comment-17341352 ] Hudson commented on HBASE-25860: Results for branch branch-1 [build #124 on

[GitHub] [hbase] Apache-HBase commented on pull request #3248: HBASE-25852 Move all the intialization work of LoadBalancer implement…

2021-05-08 Thread GitBox
Apache-HBase commented on pull request #3248: URL: https://github.com/apache/hbase/pull/3248#issuecomment-835429631 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3248: HBASE-25852 Move all the intialization work of LoadBalancer implement…

2021-05-08 Thread GitBox
Apache-HBase commented on pull request #3248: URL: https://github.com/apache/hbase/pull/3248#issuecomment-835429528 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3245: HBASE-25790 NamedQueue 'BalancerRejection' for recent history of bala…

2021-05-08 Thread GitBox
Apache-HBase commented on pull request #3245: URL: https://github.com/apache/hbase/pull/3245#issuecomment-835459919 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-25790) NamedQueue 'BalancerRejection' for recent history of balancer skipping

2021-05-08 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-25790. -- Hadoop Flags: Reviewed Resolution: Fixed Thanks for the contribution [~GeorryHuang]. >

[GitHub] [hbase] apurtell commented on pull request #3244: [WIP] HBASE-25869 WAL value compression

2021-05-08 Thread GitBox
apurtell commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-835481646 I broke trunk on an unrelated issue last night. Rebased. Removed some precommit noise that resulted. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [hbase] Apache-HBase commented on pull request #3245: HBASE-25790 NamedQueue 'BalancerRejection' for recent history of bala…

2021-05-08 Thread GitBox
Apache-HBase commented on pull request #3245: URL: https://github.com/apache/hbase/pull/3245#issuecomment-835416528 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341360#comment-17341360 ] Hudson commented on HBASE-25774: Results for branch branch-2.3 [build #216 on

[jira] [Commented] (HBASE-25860) Add metric for successful wal roll requests.

2021-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341361#comment-17341361 ] Hudson commented on HBASE-25860: Results for branch branch-2.3 [build #216 on

[GitHub] [hbase] Apache-HBase commented on pull request #3244: [WIP] HBASE-25869 WAL value compression

2021-05-08 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-835547190 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3244: [WIP] HBASE-25869 WAL value compression

2021-05-08 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-835501037 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-08 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341394#comment-17341394 ] Andrew Kyle Purtell commented on HBASE-25774: - Thanks for the addendum [~zhangduo], I

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-08 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341447#comment-17341447 ] Bharath Vissapragada commented on HBASE-25774: -- Nice find, couldn't think of this race when

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-08 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341450#comment-17341450 ] Duo Zhang commented on HBASE-25774: --- I think the main point of HBASE-25032 is about region assignment.

[jira] [Commented] (HBASE-25860) Add metric for successful wal roll requests.

2021-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341441#comment-17341441 ] Hudson commented on HBASE-25860: Results for branch branch-2.4 [build #112 on

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341440#comment-17341440 ] Hudson commented on HBASE-25774: Results for branch branch-2.4 [build #112 on

[GitHub] [hbase] Apache-HBase commented on pull request #3248: HBASE-25852 Move all the intialization work of LoadBalancer implement…

2021-05-08 Thread GitBox
Apache-HBase commented on pull request #3248: URL: https://github.com/apache/hbase/pull/3248#issuecomment-835688786 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] GeorryHuang opened a new pull request #3245: HBASE-25790 NamedQueue 'BalancerRejection' for recent history of bala…

2021-05-08 Thread GitBox
GeorryHuang opened a new pull request #3245: URL: https://github.com/apache/hbase/pull/3245 …ncer skipping (#3182) Signed-off-by: Viraj Jasani -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (HBASE-25870) Search only ancestors instead of entire history instead for a particular backup

2021-05-08 Thread Mallikarjun (Jira)
Mallikarjun created HBASE-25870: --- Summary: Search only ancestors instead of entire history instead for a particular backup Key: HBASE-25870 URL: https://issues.apache.org/jira/browse/HBASE-25870

[jira] [Work started] (HBASE-25870) Search only ancestors instead of entire history instead for a particular backup

2021-05-08 Thread Mallikarjun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25870 started by Mallikarjun. --- > Search only ancestors instead of entire history instead for a particular >

[jira] [Updated] (HBASE-25870) Validate only direct ancestors instead of entire history for a particular backup

2021-05-08 Thread Mallikarjun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mallikarjun updated HBASE-25870: Summary: Validate only direct ancestors instead of entire history for a particular backup (was:

[jira] [Updated] (HBASE-25870) Validate only ancestors instead of entire history instead for a particular backup

2021-05-08 Thread Mallikarjun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mallikarjun updated HBASE-25870: Summary: Validate only ancestors instead of entire history instead for a particular backup (was:

[jira] [Updated] (HBASE-25870) Validate only direct ancestors instead of entire history instead for a particular backup

2021-05-08 Thread Mallikarjun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mallikarjun updated HBASE-25870: Summary: Validate only direct ancestors instead of entire history instead for a particular backup

[jira] [Updated] (HBASE-25790) NamedQueue 'BalancerRejection' for recent history of balancer skipping

2021-05-08 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang updated HBASE-25790: -- Attachment: image-2021-05-08-17-33-21-753.png > NamedQueue 'BalancerRejection' for recent

[jira] [Commented] (HBASE-25790) NamedQueue 'BalancerRejection' for recent history of balancer skipping

2021-05-08 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341257#comment-17341257 ] Zhuoyue Huang commented on HBASE-25790: --- Have created PR against branch-2. The screenshot below

[GitHub] [hbase] GeorryHuang commented on pull request #3245: HBASE-25790 NamedQueue 'BalancerRejection' for recent history of bala…

2021-05-08 Thread GitBox
GeorryHuang commented on pull request #3245: URL: https://github.com/apache/hbase/pull/3245#issuecomment-835251174 @virajjasani Could you review this PR at your convenience? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache9 commented on pull request #3247: HBASE-25871 Opentelemetry span in ServerRpcConnection is incorrect

2021-05-08 Thread GitBox
Apache9 commented on pull request #3247: URL: https://github.com/apache/hbase/pull/3247#issuecomment-835281521 Let me take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (HBASE-25870) Search only ancestors instead of entire history instead for a particular backup

2021-05-08 Thread Mallikarjun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mallikarjun updated HBASE-25870: Description: While creating a manifest of particular backup, it looks for entire history of

[GitHub] [hbase] rda3mon opened a new pull request #3246: HBASE-25870 while creating manifest, search only for ancestors insteadd of all of…

2021-05-08 Thread GitBox
rda3mon opened a new pull request #3246: URL: https://github.com/apache/hbase/pull/3246 … history -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hbase] Apache-HBase commented on pull request #3246: HBASE-25870 while creating manifest, search only for ancestors insteadd of all of…

2021-05-08 Thread GitBox
Apache-HBase commented on pull request #3246: URL: https://github.com/apache/hbase/pull/3246#issuecomment-835178267 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-25860) Add metric for successful wal roll requests.

2021-05-08 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-25860. -- Fix Version/s: 2.3.6 2.4.3 2.5.0

[jira] [Assigned] (HBASE-25860) Add metric for successful wal roll requests.

2021-05-08 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-25860: Assignee: Rushabh Shah > Add metric for successful wal roll requests. >

[GitHub] [hbase] Apache-HBase commented on pull request #3245: HBASE-25790 NamedQueue 'BalancerRejection' for recent history of bala…

2021-05-08 Thread GitBox
Apache-HBase commented on pull request #3245: URL: https://github.com/apache/hbase/pull/3245#issuecomment-835220833 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] GeorryHuang opened a new pull request #3247: HBASE-25871 Opentelemetry span in ServerRpcConnection is incorrect

2021-05-08 Thread GitBox
GeorryHuang opened a new pull request #3247: URL: https://github.com/apache/hbase/pull/3247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hbase] virajjasani merged pull request #3238: HBASE-25860 Add metric for successful wal roll requests.

2021-05-08 Thread GitBox
virajjasani merged pull request #3238: URL: https://github.com/apache/hbase/pull/3238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache-HBase commented on pull request #3246: HBASE-25870 while creating manifest, search only for ancestors insteadd of all of…

2021-05-08 Thread GitBox
Apache-HBase commented on pull request #3246: URL: https://github.com/apache/hbase/pull/3246#issuecomment-835177316 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3246: HBASE-25870 while creating manifest, search only for ancestors insteadd of all of…

2021-05-08 Thread GitBox
Apache-HBase commented on pull request #3246: URL: https://github.com/apache/hbase/pull/3246#issuecomment-835179628 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani merged pull request #3241: HBASE-25860 Add metric for successful wal roll requests.

2021-05-08 Thread GitBox
virajjasani merged pull request #3241: URL: https://github.com/apache/hbase/pull/3241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] nyl3532016 commented on pull request #3202: HBASE-25803 Add compaction offload switch

2021-05-08 Thread GitBox
nyl3532016 commented on pull request #3202: URL: https://github.com/apache/hbase/pull/3202#issuecomment-835211978 @Apache9 @wchevreuil Design doc has been updated, I'll appreciate it if you could take a look. Thanks! -- This is an automated message from the Apache Git Service. To

[jira] [Created] (HBASE-25871) Opentelemetry span in ServerRpcConnection is incorrect

2021-05-08 Thread Zhuoyue Huang (Jira)
Zhuoyue Huang created HBASE-25871: - Summary: Opentelemetry span in ServerRpcConnection is incorrect Key: HBASE-25871 URL: https://issues.apache.org/jira/browse/HBASE-25871 Project: HBase

[jira] [Commented] (HBASE-25871) Opentelemetry span in ServerRpcConnection is incorrect

2021-05-08 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341268#comment-17341268 ] Zhuoyue Huang commented on HBASE-25871: --- FYI [~zhangduo], Is that a bug? should we fix it like 

[GitHub] [hbase] GeorryHuang commented on pull request #3247: HBASE-25871 Opentelemetry span in ServerRpcConnection is incorrect

2021-05-08 Thread GitBox
GeorryHuang commented on pull request #3247: URL: https://github.com/apache/hbase/pull/3247#issuecomment-835372679 @Apache9 Thank you for your patience to answer my doubts. As you said, there is nothing wrong with this code. I will close this PR -- This is an automated message from the

[GitHub] [hbase] GeorryHuang closed pull request #3247: HBASE-25871 Opentelemetry span in ServerRpcConnection is incorrect

2021-05-08 Thread GitBox
GeorryHuang closed pull request #3247: URL: https://github.com/apache/hbase/pull/3247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Resolved] (HBASE-25871) Opentelemetry span in ServerRpcConnection is incorrect

2021-05-08 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang resolved HBASE-25871. --- Resolution: Not A Problem > Opentelemetry span in ServerRpcConnection is incorrect >

[jira] [Commented] (HBASE-25871) Opentelemetry span in ServerRpcConnection is incorrect

2021-05-08 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341338#comment-17341338 ] Zhuoyue Huang commented on HBASE-25871: --- Not a bug, Resolve issue as 'Not A Problem' >

[GitHub] [hbase] Apache9 commented on pull request #3247: HBASE-25871 Opentelemetry span in ServerRpcConnection is incorrect

2021-05-08 Thread GitBox
Apache9 commented on pull request #3247: URL: https://github.com/apache/hbase/pull/3247#issuecomment-835376904 Never mind, you're welcome :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hbase] Apache-HBase commented on pull request #3247: HBASE-25871 Opentelemetry span in ServerRpcConnection is incorrect

2021-05-08 Thread GitBox
Apache-HBase commented on pull request #3247: URL: https://github.com/apache/hbase/pull/3247#issuecomment-835382540 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3245: HBASE-25790 NamedQueue 'BalancerRejection' for recent history of bala…

2021-05-08 Thread GitBox
Apache-HBase commented on pull request #3245: URL: https://github.com/apache/hbase/pull/3245#issuecomment-835384631 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3245: HBASE-25790 NamedQueue 'BalancerRejection' for recent history of bala…

2021-05-08 Thread GitBox
Apache-HBase commented on pull request #3245: URL: https://github.com/apache/hbase/pull/3245#issuecomment-835314992 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3247: HBASE-25871 Opentelemetry span in ServerRpcConnection is incorrect

2021-05-08 Thread GitBox
Apache-HBase commented on pull request #3247: URL: https://github.com/apache/hbase/pull/3247#issuecomment-835300321 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3245: HBASE-25790 NamedQueue 'BalancerRejection' for recent history of bala…

2021-05-08 Thread GitBox
Apache-HBase commented on pull request #3245: URL: https://github.com/apache/hbase/pull/3245#issuecomment-835345943 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3247: HBASE-25871 Opentelemetry span in ServerRpcConnection is incorrect

2021-05-08 Thread GitBox
Apache-HBase commented on pull request #3247: URL: https://github.com/apache/hbase/pull/3247#issuecomment-835361935 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on pull request #3247: HBASE-25871 Opentelemetry span in ServerRpcConnection is incorrect

2021-05-08 Thread GitBox
Apache9 commented on pull request #3247: URL: https://github.com/apache/hbase/pull/3247#issuecomment-835364810 Please take a look at the implementation of org.apache.hadoop.hbase.ipc.ServerCall. In the constructor, we will store the current span into a class field, and set its