[GitHub] [hbase] Apache-HBase commented on pull request #3330: HBASE-25937: Clarify UnknownRegionException

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3330: URL: https://github.com/apache/hbase/pull/3330#issuecomment-850643263 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3332: HBASE-25932: Ensure replication reads trailer bytes with AsyncWAL imp…

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3332: URL: https://github.com/apache/hbase/pull/3332#issuecomment-850635611 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3328: HBASE-25936: Improve Logging Statement Formatting

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3328: URL: https://github.com/apache/hbase/pull/3328#issuecomment-850634079 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3308: HBASE-25910 - Fix port assignment test

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3308: URL: https://github.com/apache/hbase/pull/3308#issuecomment-850623279 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3328: HBASE-25936: Improve Logging Statement Formatting

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3328: URL: https://github.com/apache/hbase/pull/3328#issuecomment-850619755 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3308: HBASE-25910 - Fix port assignment test

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3308: URL: https://github.com/apache/hbase/pull/3308#issuecomment-850619267 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3329: HBASE-25938 The SnapshotOfRegionAssignmentFromMeta.initialize call in…

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3329: URL: https://github.com/apache/hbase/pull/3329#issuecomment-850618458 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3331: HBASE-25939 Move more tests code for StochasticLoadBalancer to hbase-…

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3331: URL: https://github.com/apache/hbase/pull/3331#issuecomment-850615714 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3330: HBASE-25937: Clarify UnknownRegionException

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3330: URL: https://github.com/apache/hbase/pull/3330#issuecomment-850608059 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Work started] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-28 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25932 started by Bharath Vissapragada. > TestWALEntryStream#testCleanClosedWALs test is failing. >

[jira] [Updated] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-28 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-25932: - Status: Patch Available (was: In Progress) >

[jira] [Work stopped] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-28 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25932 stopped by Bharath Vissapragada. > TestWALEntryStream#testCleanClosedWALs test is failing. >

[jira] [Work started] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-28 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25932 started by Bharath Vissapragada. > TestWALEntryStream#testCleanClosedWALs test is failing. >

[GitHub] [hbase] bharathv commented on pull request #3332: HBASE-25932: Ensure replication reads trailer bytes with AsyncWAL imp…

2021-05-28 Thread GitBox
bharathv commented on pull request #3332: URL: https://github.com/apache/hbase/pull/3332#issuecomment-850602486 @shahrs87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [hbase] bharathv opened a new pull request #3332: HBASE-25932: Ensure replication reads trailer bytes with AsyncWAL imp…

2021-05-28 Thread GitBox
bharathv opened a new pull request #3332: URL: https://github.com/apache/hbase/pull/3332 …lementation. This bug was exposed by the test from HBASE-25924 and is only applicable for Async FSWAL implementation. Since this wal implementation closes the wal asynchronously,

[GitHub] [hbase] Apache-HBase commented on pull request #3331: HBASE-25939 Move more tests code for StochasticLoadBalancer to hbase-…

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3331: URL: https://github.com/apache/hbase/pull/3331#issuecomment-850595431 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3293: HBASE-25903 ReadOnlyZKClient APIs - CompletableFuture.get() calls can cause threads to hang forver when ZK client create throws Non IOExc

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3293: URL: https://github.com/apache/hbase/pull/3293#issuecomment-850592046 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25933) Log trace raw exception, instead of cause message in NettyRpcServerRequestDecoder

2021-05-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353498#comment-17353498 ] Hudson commented on HBASE-25933: Results for branch branch-2 [build #263 on

[jira] [Commented] (HBASE-25908) Exclude jakarta.activation-api

2021-05-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353499#comment-17353499 ] Hudson commented on HBASE-25908: Results for branch branch-2 [build #263 on

[GitHub] [hbase] Apache-HBase commented on pull request #3327: HBASE-25916 Move FavoredNodeLoadBalancer to hbase-balancer module

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3327: URL: https://github.com/apache/hbase/pull/3327#issuecomment-850587854 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3293: HBASE-25903 ReadOnlyZKClient APIs - CompletableFuture.get() calls can cause threads to hang forver when ZK client create throws Non IOExc

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3293: URL: https://github.com/apache/hbase/pull/3293#issuecomment-850586892 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3293: HBASE-25903 ReadOnlyZKClient APIs - CompletableFuture.get() calls can cause threads to hang forver when ZK client create throws Non IOExc

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3293: URL: https://github.com/apache/hbase/pull/3293#issuecomment-850586025 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3330: HBASE-25937: Clarify UnknownRegionException

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3330: URL: https://github.com/apache/hbase/pull/3330#issuecomment-850583606 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] apurtell edited a comment on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-28 Thread GitBox
apurtell edited a comment on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-850569022 > But sometimes we use System.currentTimeMillis just for calculating elapsed time, not for getting system clock, I'm not sure if this is also our goal here, to also

[GitHub] [hbase] apurtell commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-28 Thread GitBox
apurtell commented on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-850572028 Thanks for the approvals. I'm going to rebase, run tests locally, and merge if things look good. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] apurtell commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-28 Thread GitBox
apurtell commented on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-850571678 > It looks like, unless we are too specific about elapsed time that we want only nanosecond level elapsed time, we should prefer System#currentTimeMillis for the perf benefit.

[GitHub] [hbase] Apache-HBase commented on pull request #3329: HBASE-25938 The SnapshotOfRegionAssignmentFromMeta.initialize call in…

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3329: URL: https://github.com/apache/hbase/pull/3329#issuecomment-850570594 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] apurtell commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-28 Thread GitBox
apurtell commented on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-850569022 > But sometimes we use System.currentTimeMillis just for calculating elapsed time, not for getting system clock, I'm not sure if this is also our goal here, to also replace

[GitHub] [hbase] Apache-HBase commented on pull request #3327: HBASE-25916 Move FavoredNodeLoadBalancer to hbase-balancer module

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3327: URL: https://github.com/apache/hbase/pull/3327#issuecomment-85044 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3328: HBASE-25936: Improve Logging Statement Formatting

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3328: URL: https://github.com/apache/hbase/pull/3328#issuecomment-850549149 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Comment Edited] (HBASE-25924) Seeing a spike in uncleanlyClosedWALs metric.

2021-05-28 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353455#comment-17353455 ] Andrew Kyle Purtell edited comment on HBASE-25924 at 5/28/21, 4:35 PM:

[jira] [Commented] (HBASE-25924) Seeing a spike in uncleanlyClosedWALs metric.

2021-05-28 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353455#comment-17353455 ] Andrew Kyle Purtell commented on HBASE-25924: - HBASE-25932 is making progress. We shouldn't

[GitHub] [hbase] Apache-HBase commented on pull request #3308: HBASE-25910 - Fix port assignment test

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3308: URL: https://github.com/apache/hbase/pull/3308#issuecomment-850524135 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-850519249 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3331: HBASE-25939 Move more tests code for StochasticLoadBalancer to hbase-…

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3331: URL: https://github.com/apache/hbase/pull/3331#issuecomment-850519054 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] belugabehr commented on a change in pull request #3330: HBASE-25937: Clarify UnknownRegionException

2021-05-28 Thread GitBox
belugabehr commented on a change in pull request #3330: URL: https://github.com/apache/hbase/pull/3330#discussion_r641657779 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/UnknownRegionException.java ## @@ -26,12 +26,25 @@ */ @InterfaceAudience.Public

[jira] [Commented] (HBASE-25920) Support Hadoop 3.3.1

2021-05-28 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353418#comment-17353418 ] Wei-Chiu Chuang commented on HBASE-25920: - For TestBackupSmallTests, we will revert the

[GitHub] [hbase] Apache-HBase commented on pull request #3330: HBASE-25937: Clarify UnknownRegionException

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3330: URL: https://github.com/apache/hbase/pull/3330#issuecomment-850510607 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3329: HBASE-25938 The SnapshotOfRegionAssignmentFromMeta.initialize call in…

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3329: URL: https://github.com/apache/hbase/pull/3329#issuecomment-850509830 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani edited a comment on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-28 Thread GitBox
virajjasani edited a comment on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-850502504 > https://stackoverflow.com/questions/19052316/why-is-system-nanotime-way-slower-in-performance-than-system-currenttimemill As per the Oracle blog (link to blog

[GitHub] [hbase] virajjasani commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-28 Thread GitBox
virajjasani commented on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-850502504 > https://stackoverflow.com/questions/19052316/why-is-system-nanotime-way-slower-in-performance-than-system-currenttimemill As per the Oracle blog (link to blog is

[jira] [Commented] (HBASE-25920) Support Hadoop 3.3.1

2021-05-28 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353410#comment-17353410 ] Michael Stack commented on HBASE-25920: --- The suggested fix for TestBackupSmallTests works for me.

[jira] [Resolved] (HBASE-25910) Fix TestClusterPortAssignment.testClusterPortAssignment test and re-enable it.

2021-05-28 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-25910. -- Fix Version/s: 2.4.4 2.3.6 2.5.0 Hadoop Flags:

[GitHub] [hbase] pankaj72981 commented on a change in pull request #3319: HBASE-25914 Provide slow/large logs on RegionServer UI

2021-05-28 Thread GitBox
pankaj72981 commented on a change in pull request #3319: URL: https://github.com/apache/hbase/pull/3319#discussion_r641634864 ## File path: hbase-server/src/main/resources/hbase-webapps/regionserver/rsNamedQueueLog.jsp ## @@ -0,0 +1,157 @@ +<%-- +/** + * Licensed to the

[GitHub] [hbase] virajjasani merged pull request #3308: HBASE-25910 - Fix port assignment test

2021-05-28 Thread GitBox
virajjasani merged pull request #3308: URL: https://github.com/apache/hbase/pull/3308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] vli02 commented on a change in pull request #3308: HBASE-25910 - Fix port assignment test

2021-05-28 Thread GitBox
vli02 commented on a change in pull request #3308: URL: https://github.com/apache/hbase/pull/3308#discussion_r641628429 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/TestClusterPortAssignment.java ## @@ -67,13 +71,14 @@ public void

[GitHub] [hbase] busbey commented on a change in pull request #3330: HBASE-25937: Clarify UnknownRegionException

2021-05-28 Thread GitBox
busbey commented on a change in pull request #3330: URL: https://github.com/apache/hbase/pull/3330#discussion_r641627968 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/UnknownRegionException.java ## @@ -26,12 +26,25 @@ */ @InterfaceAudience.Public public

[GitHub] [hbase] pankaj72981 commented on a change in pull request #3319: HBASE-25914 Provide slow/large logs on RegionServer UI

2021-05-28 Thread GitBox
pankaj72981 commented on a change in pull request #3319: URL: https://github.com/apache/hbase/pull/3319#discussion_r641626284 ## File path: hbase-server/src/main/resources/hbase-webapps/regionserver/rsNamedQueueLog.jsp ## @@ -0,0 +1,157 @@ +<%-- +/** + * Licensed to the

[GitHub] [hbase] pankaj72981 commented on a change in pull request #3319: HBASE-25914 Provide slow/large logs on RegionServer UI

2021-05-28 Thread GitBox
pankaj72981 commented on a change in pull request #3319: URL: https://github.com/apache/hbase/pull/3319#discussion_r641626284 ## File path: hbase-server/src/main/resources/hbase-webapps/regionserver/rsNamedQueueLog.jsp ## @@ -0,0 +1,157 @@ +<%-- +/** + * Licensed to the

[GitHub] [hbase] Apache-HBase commented on pull request #3328: HBASE-25936: Improve Logging Statement Formatting

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3328: URL: https://github.com/apache/hbase/pull/3328#issuecomment-850484705 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-05-28 Thread GitBox
saintstack commented on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-850484679 Agree the test failures look unrelated. Rerunning tests just to be sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hbase] Apache-HBase commented on pull request #3328: HBASE-25936: Improve Logging Statement Formatting

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3328: URL: https://github.com/apache/hbase/pull/3328#issuecomment-850483816 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25914) Provide slow/large logs on RegionServer UI

2021-05-28 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353399#comment-17353399 ] Michael Stack commented on HBASE-25914: --- On naming, instead of 'Name Queue Log' , which exposes

[GitHub] [hbase] Apache9 opened a new pull request #3331: HBASE-25939 Move more tests code for StochasticLoadBalancer to hbase-…

2021-05-28 Thread GitBox
Apache9 opened a new pull request #3331: URL: https://github.com/apache/hbase/pull/3331 …balancer module -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [hbase] Apache-HBase commented on pull request #3327: HBASE-25916 Move FavoredNodeLoadBalancer to hbase-balancer module

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3327: URL: https://github.com/apache/hbase/pull/3327#issuecomment-850478116 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] belugabehr opened a new pull request #3330: HBASE-25937: Clarify UnknownRegionException

2021-05-28 Thread GitBox
belugabehr opened a new pull request #3330: URL: https://github.com/apache/hbase/pull/3330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Created] (HBASE-25939) Move more tests code for StochasticLoadBalancer to hbase-balancer module

2021-05-28 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25939: - Summary: Move more tests code for StochasticLoadBalancer to hbase-balancer module Key: HBASE-25939 URL: https://issues.apache.org/jira/browse/HBASE-25939 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #3328: HBASE-25936: Improve Logging Statement Formatting

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3328: URL: https://github.com/apache/hbase/pull/3328#issuecomment-850473233 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-25861) Correct the usage of Configuration#addDeprecation

2021-05-28 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25861. --- Hadoop Flags: Reviewed Resolution: Fixed Re-resolving. Issue addressed over in

[jira] [Resolved] (HBASE-25928) TestHBaseConfiguration#testDeprecatedConfigurations is broken with Hadoop 3.3

2021-05-28 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25928. --- Fix Version/s: 2.5.0 3.0.0-alpha-1 Hadoop Flags: Reviewed

[GitHub] [hbase] Apache9 opened a new pull request #3329: HBASE-25938 The SnapshotOfRegionAssignmentFromMeta.initialize call in…

2021-05-28 Thread GitBox
Apache9 opened a new pull request #3329: URL: https://github.com/apache/hbase/pull/3329 … FavoredNodeLoadBalancer is just a dummy one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (HBASE-25914) Provide slow/large logs on RegionServer UI

2021-05-28 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353388#comment-17353388 ] Viraj Jasani commented on HBASE-25914: -- {quote}My concern w/ 'Name Queue Log' is that it indeed is

[jira] [Commented] (HBASE-25914) Provide slow/large logs on RegionServer UI

2021-05-28 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353386#comment-17353386 ] Michael Stack commented on HBASE-25914: --- Thanks [~vjasani] My concern w/ 'Name Queue Log' is that

[jira] [Assigned] (HBASE-25938) The SnapshotOfRegionAssignmentFromMeta.initialize call in FavoredNodeLoadBalancer is just a dummy one

2021-05-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-25938: - Assignee: Duo Zhang > The SnapshotOfRegionAssignmentFromMeta.initialize call in >

[jira] [Created] (HBASE-25938) The SnapshotOfRegionAssignmentFromMeta.initialize call in FavoredNodeLoadBalancer is just a dummy one

2021-05-28 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25938: - Summary: The SnapshotOfRegionAssignmentFromMeta.initialize call in FavoredNodeLoadBalancer is just a dummy one Key: HBASE-25938 URL: https://issues.apache.org/jira/browse/HBASE-25938

[jira] [Work started] (HBASE-25938) The SnapshotOfRegionAssignmentFromMeta.initialize call in FavoredNodeLoadBalancer is just a dummy one

2021-05-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25938 started by Duo Zhang. - > The SnapshotOfRegionAssignmentFromMeta.initialize call in >

[jira] [Commented] (HBASE-25914) Provide slow/large logs on RegionServer UI

2021-05-28 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353382#comment-17353382 ] Viraj Jasani commented on HBASE-25914: -- Thanks [~stack]. The reason why Name Queue log tab is

[GitHub] [hbase] saintstack merged pull request #3320: HBASE-25928 TestHBaseConfiguration#testDeprecatedConfigurations is broken with Hadoop 3.3

2021-05-28 Thread GitBox
saintstack merged pull request #3320: URL: https://github.com/apache/hbase/pull/3320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Created] (HBASE-25937) Clarify UnknownRegionException

2021-05-28 Thread David Mollitor (Jira)
David Mollitor created HBASE-25937: -- Summary: Clarify UnknownRegionException Key: HBASE-25937 URL: https://issues.apache.org/jira/browse/HBASE-25937 Project: HBase Issue Type: Improvement

[GitHub] [hbase] anoopsjohn commented on pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-05-28 Thread GitBox
anoopsjohn commented on pull request #3318: URL: https://github.com/apache/hbase/pull/3318#issuecomment-850453676 > I write a case how this error could happen in the doc: https://docs.google.com/document/d/1_3HXgOSGHsHFqLiOWUsE3m6pHKjebSwrRObcPTqkSTE/edit?usp=sharing, please have a look,

[jira] [Commented] (HBASE-25914) Provide slow/large logs on RegionServer UI

2021-05-28 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353378#comment-17353378 ] Michael Stack commented on HBASE-25914: --- Thanks [~vjasani]. Now I remember. Would suggest a

[GitHub] [hbase] Apache9 commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-28 Thread GitBox
Apache9 commented on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-850445909 https://stackoverflow.com/questions/19052316/why-is-system-nanotime-way-slower-in-performance-than-system-currenttimemill -- This is an automated message from the Apache Git

[GitHub] [hbase] virajjasani edited a comment on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-28 Thread GitBox
virajjasani edited a comment on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-850442580 > In general we should all use System.nanoTime for calculating elapsed time, but System.nanoTime is usually slower than System.currentTimeMillis @Apache9 do you

[GitHub] [hbase] virajjasani commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-28 Thread GitBox
virajjasani commented on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-850442580 > In general we should all use System.nanoTime for calculating elapsed time, but System.nanoTime is usually slower than System.currentTimeMillis @Apache9 do you have

[GitHub] [hbase] Apache-HBase commented on pull request #3308: HBASE-25910 - Fix port assignment test

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3308: URL: https://github.com/apache/hbase/pull/3308#issuecomment-850436729 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] belugabehr opened a new pull request #3328: HBASE-25936: Improve Logging Statement Formatting

2021-05-28 Thread GitBox
belugabehr opened a new pull request #3328: URL: https://github.com/apache/hbase/pull/3328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Created] (HBASE-25936) Improve Logging Statement Formatting

2021-05-28 Thread David Mollitor (Jira)
David Mollitor created HBASE-25936: -- Summary: Improve Logging Statement Formatting Key: HBASE-25936 URL: https://issues.apache.org/jira/browse/HBASE-25936 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #3308: HBASE-25910 - Fix port assignment test

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3308: URL: https://github.com/apache/hbase/pull/3308#issuecomment-850419738 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Assigned] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-28 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushabh Shah reassigned HBASE-25932: Assignee: Bharath Vissapragada (was: Rushabh Shah) >

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-28 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353339#comment-17353339 ] Rushabh Shah commented on HBASE-25932: -- [~bharathv] Thank you for the rough patch. I think the

[jira] [Created] (HBASE-25935) Data is not getting replicated to secondary replicas after altering a table to enable region replication (async Wal replication)

2021-05-28 Thread chiranjeevi (Jira)
chiranjeevi created HBASE-25935: --- Summary: Data is not getting replicated to secondary replicas after altering a table to enable region replication (async Wal replication) Key: HBASE-25935 URL:

[GitHub] [hbase] Apache-HBase commented on pull request #3321: HBASE-25914 Provide slow/large logs on RegionServer UI

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3321: URL: https://github.com/apache/hbase/pull/3321#issuecomment-850398498 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-28 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353331#comment-17353331 ] Viraj Jasani commented on HBASE-25932: -- While closing WAL,

[jira] [Commented] (HBASE-25908) Exclude jakarta.activation-api

2021-05-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353325#comment-17353325 ] Hudson commented on HBASE-25908: Results for branch master [build #307 on

[GitHub] [hbase] Apache-HBase commented on pull request #3319: HBASE-25914 Provide slow/large logs on RegionServer UI

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3319: URL: https://github.com/apache/hbase/pull/3319#issuecomment-850392539 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[jira] [Commented] (HBASE-25758) Move MetaTableAccessor out of hbase-balancer module

2021-05-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353326#comment-17353326 ] Hudson commented on HBASE-25758: Results for branch master [build #307 on

[jira] [Commented] (HBASE-25926) Cleanup MetaTableAccessor references in FavoredNodeBalancer related code

2021-05-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353323#comment-17353323 ] Hudson commented on HBASE-25926: Results for branch master [build #307 on

[jira] [Commented] (HBASE-25933) Log trace raw exception, instead of cause message in NettyRpcServerRequestDecoder

2021-05-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353324#comment-17353324 ] Hudson commented on HBASE-25933: Results for branch master [build #307 on

[GitHub] [hbase] Apache-HBase commented on pull request #3327: HBASE-25916 Move FavoredNodeLoadBalancer to hbase-balancer module

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3327: URL: https://github.com/apache/hbase/pull/3327#issuecomment-850383161 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3327: HBASE-25916 Move FavoredNodeLoadBalancer to hbase-balancer module

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3327: URL: https://github.com/apache/hbase/pull/3327#issuecomment-850378795 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[jira] [Resolved] (HBASE-25718) Backport HBASE-25705 to branch-2

2021-05-28 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha resolved HBASE-25718. Fix Version/s: 2.5.0 Resolution: Fixed Pushed to branch-2. Thanks [~mokai87] for

[jira] [Resolved] (HBASE-25651) NORMALIZER_TARGET_REGION_SIZE needs a unit in its name

2021-05-28 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha resolved HBASE-25651. Fix Version/s: 3.0.0-alpha-1 Resolution: Fixed Pushed to master. Thanks [~rkrahul324] for

[GitHub] [hbase] Apache-HBase commented on pull request #3321: HBASE-25914 Provide slow/large logs on RegionServer UI

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3321: URL: https://github.com/apache/hbase/pull/3321#issuecomment-850356020 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] sunhelly merged pull request #3063: HBASE-25651: NORMALIZER_TARGET_REGION_SIZE needs a unit in its name

2021-05-28 Thread GitBox
sunhelly merged pull request #3063: URL: https://github.com/apache/hbase/pull/3063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hbase] Apache-HBase commented on pull request #3319: HBASE-25914 Provide slow/large logs on RegionServer UI

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3319: URL: https://github.com/apache/hbase/pull/3319#issuecomment-850350558 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] sunhelly merged pull request #3109: HBASE-25718 Backport HBASE-25705 to branch-2

2021-05-28 Thread GitBox
sunhelly merged pull request #3109: URL: https://github.com/apache/hbase/pull/3109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-28 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353251#comment-17353251 ] Viraj Jasani commented on HBASE-25932: -- {code:java} AsyncWriter temp =

[jira] [Commented] (HBASE-25902) 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is earlier than hbase-2.3.0 first

2021-05-28 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353234#comment-17353234 ] Viraj Jasani commented on HBASE-25902: -- As per HBASE-24625, for replication enabled clusters, going

[GitHub] [hbase] Apache-HBase commented on pull request #3308: HBASE-25910 - Fix port assignment test

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3308: URL: https://github.com/apache/hbase/pull/3308#issuecomment-850316375 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3327: HBASE-25916 Move FavoredNodeLoadBalancer to hbase-balancer module

2021-05-28 Thread GitBox
Apache-HBase commented on pull request #3327: URL: https://github.com/apache/hbase/pull/3327#issuecomment-850304634 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

<    1   2   3   >