Apache9 merged pull request #3858:
URL: https://github.com/apache/hbase/pull/3858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
YutSean opened a new pull request #3867:
URL: https://github.com/apache/hbase/pull/3867
https://issues.apache.org/jira/browse/HBASE-26477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/HBASE-26467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-26467:
--
Hadoop Flags: Reviewed
Resolution: Fixed
Status: Resolved (was: Patch Available)
[
https://issues.apache.org/jira/browse/HBASE-26467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-26467:
--
Component/s: in-memory-compaction
> Wrong Cell Generated by MemStoreLABImpl.forceCopyOfBigCellInto
[
https://issues.apache.org/jira/browse/HBASE-26477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yutong Xiao updated HBASE-26477:
Description:
MiniMapReduceCluster in HBaseTestingUtil.java will not work. Find the error
message
Apache-HBase commented on pull request #3867:
URL: https://github.com/apache/hbase/pull/3867#issuecomment-974816052
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache9 commented on pull request #3862:
URL: https://github.com/apache/hbase/pull/3862#issuecomment-974808700
The code is pretty old...
https://github.com/apache/hbase/commit/02cd4a9b019a8b86b4d077e8bec8c69d7579fae5
This is the commit, a refactoring actually, and there is a
Apache9 merged pull request #3853:
URL: https://github.com/apache/hbase/pull/3853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache9 commented on pull request #3860:
URL: https://github.com/apache/hbase/pull/3860#issuecomment-974812997
I do not have an arm machine so I can not verify the patch...
Mind uploading a screen shot or something else to prove that it works as
expected? @markjens
Thanks.
[
https://issues.apache.org/jira/browse/HBASE-26467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-26467:
--
Fix Version/s: 2.5.0
3.0.0-alpha-2
2.4.9
> Wrong Cell Generated
Apache9 commented on a change in pull request #3831:
URL: https://github.com/apache/hbase/pull/3831#discussion_r753798016
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
##
@@ -299,4 +299,11 @@
* if you try to set a
[
https://issues.apache.org/jira/browse/HBASE-26477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yutong Xiao updated HBASE-26477:
Description:
MiniMapReduceCluster in HBaseTestingUtil.java will not work. Find the error
message
[
https://issues.apache.org/jira/browse/HBASE-26463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-26463.
---
Hadoop Flags: Reviewed
Resolution: Fixed
Pushed to branch-2.4+.
Thanks [~sergey.soldatov]!
[
https://issues.apache.org/jira/browse/HBASE-26463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-26463:
--
Fix Version/s: 2.5.0
3.0.0-alpha-2
2.4.9
> Unreadable table
Yutong Xiao created HBASE-26477:
---
Summary: Fix MiniMapReduceCluster failure under Java17
Key: HBASE-26477
URL: https://issues.apache.org/jira/browse/HBASE-26477
Project: HBase
Issue Type: Task
[
https://issues.apache.org/jira/browse/HBASE-26477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yutong Xiao updated HBASE-26477:
Description:
MiniMapReduceCluster in HBaseTestingUtil.java will not work. Find the error
message
[
https://issues.apache.org/jira/browse/HBASE-26047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447024#comment-17447024
]
Yutong Xiao commented on HBASE-26047:
-
Have fixed the three MR related UTs
Apache-HBase commented on pull request #3867:
URL: https://github.com/apache/hbase/pull/3867#issuecomment-974840490
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache9 commented on pull request #3856:
URL: https://github.com/apache/hbase/pull/3856#issuecomment-974813540
For a ref guide, usually we will only commit it to master branch as it
contains the information for all versions, and we will only build ref guide for
master branch and upload it
Apache9 commented on pull request #3862:
URL: https://github.com/apache/hbase/pull/3862#issuecomment-974593183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Apache9 commented on pull request #3864:
URL: https://github.com/apache/hbase/pull/3864#issuecomment-974675076
When adding UTs I found some new problems, and I added a comment on the
design doc about the fail recovery logic.
The PR is not fully completed yet, still need to add more
shahrs87 commented on pull request #3862:
URL: https://github.com/apache/hbase/pull/3862#issuecomment-974654639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Apache9 commented on pull request #3860:
URL: https://github.com/apache/hbase/pull/3860#issuecomment-974812997
I do not have an arm machine so I can not verify the patch...
Mind uploading a screen shot or something else to prove that it works as
expected? @markjens
Thanks.
Apache9 commented on pull request #3667:
URL: https://github.com/apache/hbase/pull/3667#issuecomment-974845354
Any progress here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
virajjasani commented on pull request #3862:
URL: https://github.com/apache/hbase/pull/3862#issuecomment-974660177
Backport PRs: #3865 #3866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Apache9 commented on a change in pull request #3851:
URL: https://github.com/apache/hbase/pull/3851#discussion_r753632988
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java
##
@@ -854,15 +860,75 @@ public long
Apache-HBase commented on pull request #3864:
URL: https://github.com/apache/hbase/pull/3864#issuecomment-974603881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Apache9 commented on pull request #3856:
URL: https://github.com/apache/hbase/pull/3856#issuecomment-974813540
For a ref guide, usually we will only commit it to master branch as it
contains the information for all versions, and we will only build ref guide for
master branch and upload it
Apache-HBase commented on pull request #3864:
URL: https://github.com/apache/hbase/pull/3864#issuecomment-974857931
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache9 merged pull request #3858:
URL: https://github.com/apache/hbase/pull/3858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on pull request #3867:
URL: https://github.com/apache/hbase/pull/3867#issuecomment-974816052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Apache-HBase commented on pull request #3865:
URL: https://github.com/apache/hbase/pull/3865#issuecomment-974659714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Apache9 commented on pull request #3863:
URL: https://github.com/apache/hbase/pull/3863#issuecomment-974590906
Let's open separated PRs for the different issues? It will be easier to
review
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Apache-HBase commented on pull request #3867:
URL: https://github.com/apache/hbase/pull/3867#issuecomment-974904035
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
zhengzhuobinzzb commented on pull request #3858:
URL: https://github.com/apache/hbase/pull/3858#issuecomment-974850450
Thanks for your help~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Apache-HBase commented on pull request #3858:
URL: https://github.com/apache/hbase/pull/3858#issuecomment-974751261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Apache-HBase commented on pull request #3866:
URL: https://github.com/apache/hbase/pull/3866#issuecomment-974685659
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 8m
Apache9 commented on a change in pull request #3831:
URL: https://github.com/apache/hbase/pull/3831#discussion_r753798016
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
##
@@ -299,4 +299,11 @@
* if you try to set a
Apache-HBase commented on pull request #3867:
URL: https://github.com/apache/hbase/pull/3867#issuecomment-974898154
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3864:
URL: https://github.com/apache/hbase/pull/3864#issuecomment-974875717
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3864:
URL: https://github.com/apache/hbase/pull/3864#issuecomment-974879304
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
virajjasani commented on a change in pull request #3852:
URL: https://github.com/apache/hbase/pull/3852#discussion_r753652443
##
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##
@@ -3150,23 +3150,24 @@ TTL some notion of optional TTL (and optional default
TTL) for
Apache-HBase commented on pull request #3862:
URL: https://github.com/apache/hbase/pull/3862#issuecomment-974661559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
comnetwork edited a comment on pull request #3858:
URL: https://github.com/apache/hbase/pull/3858#issuecomment-974631960
@zhengzhuobinzzb, and please also fix the checkstyle issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
comnetwork commented on a change in pull request #3858:
URL: https://github.com/apache/hbase/pull/3858#discussion_r753662321
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactingToCellFlatMapMemStore.java
##
@@ -903,6 +904,37 @@ public
zhengzhuobinzzb commented on pull request #3858:
URL: https://github.com/apache/hbase/pull/3858#issuecomment-974850450
Thanks for your help~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Apache-HBase commented on pull request #3867:
URL: https://github.com/apache/hbase/pull/3867#issuecomment-974857431
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3867:
URL: https://github.com/apache/hbase/pull/3867#issuecomment-974865586
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache9 commented on pull request #3667:
URL: https://github.com/apache/hbase/pull/3667#issuecomment-974845354
Any progress here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
comnetwork commented on pull request #3858:
URL: https://github.com/apache/hbase/pull/3858#issuecomment-974631960
and please also fix the checkstyle issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Apache9 merged pull request #3853:
URL: https://github.com/apache/hbase/pull/3853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
YutSean commented on pull request #3776:
URL: https://github.com/apache/hbase/pull/3776#issuecomment-974748728
Do i need to push another blank commit to trigger the QA once more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Apache-HBase commented on pull request #3859:
URL: https://github.com/apache/hbase/pull/3859#issuecomment-974655589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Apache9 commented on a change in pull request #3852:
URL: https://github.com/apache/hbase/pull/3852#discussion_r753632040
##
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##
@@ -3150,23 +3150,24 @@ TTL some notion of optional TTL (and optional default
TTL) for snapshots
Apache-HBase commented on pull request #3864:
URL: https://github.com/apache/hbase/pull/3864#issuecomment-975143773
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
sunhelly commented on a change in pull request #3831:
URL: https://github.com/apache/hbase/pull/3831#discussion_r753970108
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##
@@ -7050,11 +7053,15 @@ String prepareBulkLoad(byte[]
Reidd commented on pull request #3776:
URL: https://github.com/apache/hbase/pull/3776#issuecomment-975176216
> Do i need to push another blank commit to trigger the QA once more?
Yes, please try again for sure, thx @YutSean
--
This is an automated message from the Apache Git
Apache-HBase commented on pull request #3867:
URL: https://github.com/apache/hbase/pull/3867#issuecomment-975166517
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Reidd removed a comment on pull request #3776:
URL: https://github.com/apache/hbase/pull/3776#issuecomment-975176216
> Do i need to push another blank commit to trigger the QA once more?
Yes, please try again for sure, thx @YutSean
--
This is an automated message from the
Apache9 commented on a change in pull request #3803:
URL: https://github.com/apache/hbase/pull/3803#discussion_r753919285
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/InputStreamBlockDistribution.java
##
@@ -0,0 +1,143 @@
+/**
+ * Licensed to
Apache9 commented on pull request #3803:
URL: https://github.com/apache/hbase/pull/3803#issuecomment-975031255
Please fix the javac and checkstyle warnings? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/HBASE-26463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447182#comment-17447182
]
Hudson commented on HBASE-26463:
Results for branch branch-2.4
[build #243 on
sunhelly commented on a change in pull request #3831:
URL: https://github.com/apache/hbase/pull/3831#discussion_r753970108
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##
@@ -7050,11 +7053,15 @@ String prepareBulkLoad(byte[]
[
https://issues.apache.org/jira/browse/HBASE-26475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-26475 started by Duo Zhang.
-
> The flush and compact methods in HTU should skip processing secondary replicas
>
[
https://issues.apache.org/jira/browse/HBASE-26475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reassigned HBASE-26475:
-
Assignee: Duo Zhang
> The flush and compact methods in HTU should skip processing secondary
[
https://issues.apache.org/jira/browse/HBASE-26459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yutong Xiao reassigned HBASE-26459:
---
Assignee: Yutong Xiao
> HMaster should move non-meta region only if meta is ONLINE
>
sunhelly commented on a change in pull request #3831:
URL: https://github.com/apache/hbase/pull/3831#discussion_r753972653
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
##
@@ -299,4 +299,11 @@
* if you try to set a
Apache-HBase commented on pull request #3867:
URL: https://github.com/apache/hbase/pull/3867#issuecomment-975012918
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3867:
URL: https://github.com/apache/hbase/pull/3867#issuecomment-975147180
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache9 commented on pull request #3864:
URL: https://github.com/apache/hbase/pull/3864#issuecomment-975003666
Strange. The javadoc for jdk11 is fine but not good for jdk8...
Anyway, let me remove the link...
--
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/HBASE-24605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447183#comment-17447183
]
Hudson commented on HBASE-24605:
Results for branch branch-2.4
[build #243 on
[
https://issues.apache.org/jira/browse/HBASE-26467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447184#comment-17447184
]
Hudson commented on HBASE-26467:
Results for branch branch-2.4
[build #243 on
sunhelly commented on pull request #3831:
URL: https://github.com/apache/hbase/pull/3831#issuecomment-975160762
> But on the API design, do we really need to expose isUnderCompaction
method? What about just add a flag to indicate whether to still request
compaction if the store is already
73 matches
Mail list logo
