[jira] [Commented] (HBASE-27155) Improvements to low level scanner tracing

2022-07-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563323#comment-17563323 ] Andrew Kyle Purtell commented on HBASE-27155: - Thanks Nick. Based on that patch this is

[GitHub] [hbase] Apache-HBase commented on pull request #4599: HBASE-27148 Move minimum hadoop 3 support version to 3.2.3 (#4561)

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4599: URL: https://github.com/apache/hbase/pull/4599#issuecomment-1176266123 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s |

[GitHub] [hbase] bbeaudreault commented on pull request #4453: HBASE-27053 IOException during caching of uncompressed block to the b…

2022-07-06 Thread GitBox
bbeaudreault commented on PR #4453: URL: https://github.com/apache/hbase/pull/4453#issuecomment-1176345408 @ss77892 do you want to give the above a try, or would you like me to take this over? Happy to do either, but would love to get this fixed. -- This is an automated message from the

[GitHub] [hbase] bbeaudreault merged pull request #4562: HBASE-27048 Server side scanner time limit should account for time in queue

2022-07-06 Thread GitBox
bbeaudreault merged PR #4562: URL: https://github.com/apache/hbase/pull/4562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HBASE-27155) Improvements to low level scanner tracing

2022-07-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563268#comment-17563268 ] Nick Dimiduk commented on HBASE-27155: -- [~apurtell] Here's a forward-port of your old

[GitHub] [hbase] Apache9 commented on pull request #4453: HBASE-27053 IOException during caching of uncompressed block to the b…

2022-07-06 Thread GitBox
Apache9 commented on PR #4453: URL: https://github.com/apache/hbase/pull/4453#issuecomment-1176336797 I'd say just try it. I'm not very familiar with the BucketCache, especially the disk based one. I think it is mainly implemented by @anoopsjohn and @ramkrish86 . But anyway, this is not

[GitHub] [hbase] bbeaudreault commented on pull request #4453: HBASE-27053 IOException during caching of uncompressed block to the b…

2022-07-06 Thread GitBox
bbeaudreault commented on PR #4453: URL: https://github.com/apache/hbase/pull/4453#issuecomment-1176342853 tl;dr from above: A very simple fix for this specific problem is to just change `HFileBlock#allocateBuffer` to not include `cksumBytes`. However, this will cause some issues

[GitHub] [hbase] ndimiduk commented on pull request #4600: HBASE-27182 Rework tracing configuration

2022-07-06 Thread GitBox
ndimiduk commented on PR #4600: URL: https://github.com/apache/hbase/pull/4600#issuecomment-1176347546 I have not looked at the windows scripts and I have no environment for testing them. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hbase] bbeaudreault commented on pull request #4453: HBASE-27053 IOException during caching of uncompressed block to the b…

2022-07-06 Thread GitBox
bbeaudreault commented on PR #4453: URL: https://github.com/apache/hbase/pull/4453#issuecomment-1176274853 @joshelser @Apache9 @ss77892 I decided to take a look at this, as we're trying to push forward on BucketCache in prod and this was an issue we see every time a region is split. I

[jira] [Resolved] (HBASE-21165) During ProcedureStore load, there is no listing of progress...

2022-07-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-21165. --- Assignee: (was: Michael Stack) Resolution: Won't Fix We use RegionProcedureStore now,

[GitHub] [hbase] ndimiduk merged pull request #4591: Backport "HBASE-27172 Upgrade OpenTelemetry dependency to 1.15.0" to branch-2.5

2022-07-06 Thread GitBox
ndimiduk merged PR #4591: URL: https://github.com/apache/hbase/pull/4591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (HBASE-27182) Rework tracing configuration

2022-07-06 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-27182: Summary: Rework tracing configuration Key: HBASE-27182 URL: https://issues.apache.org/jira/browse/HBASE-27182 Project: HBase Issue Type: Task

[GitHub] [hbase] Apache9 commented on pull request #4599: HBASE-27148 Move minimum hadoop 3 support version to 3.2.3 (#4561)

2022-07-06 Thread GitBox
Apache9 commented on PR #4599: URL: https://github.com/apache/hbase/pull/4599#issuecomment-1176185510 Ah, so hadoop 2 still needs to use jackson 1.x... Let me change the patch... -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hbase] ndimiduk opened a new pull request, #4600: HBASE-27182 Rework tracing configuration

2022-07-06 Thread GitBox
ndimiduk opened a new pull request, #4600: URL: https://github.com/apache/hbase/pull/4600 * Take advantage of the fact that OpenTelemetry can read its configuration from environment variables and make use of this where possible, only falling back to passing properties into the

[GitHub] [hbase] Apache9 merged pull request #4506: HBASE-27101 support commons-crypto version 1.1.0

2022-07-06 Thread GitBox
Apache9 merged PR #4506: URL: https://github.com/apache/hbase/pull/4506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (HBASE-27101) support commons-crypto version 1.1.0

2022-07-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27101. --- Fix Version/s: 2.5.0 3.0.0-alpha-4 Hadoop Flags: Reviewed Resolution:

[jira] [Assigned] (HBASE-27101) support commons-crypto version 1.1.0

2022-07-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-27101: - Assignee: wenweijian > support commons-crypto version 1.1.0 >

[jira] [Commented] (HBASE-27170) ByteBuffAllocator leak when decompressing blocks near minSizeForReservoirUse

2022-07-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563167#comment-17563167 ] Hudson commented on HBASE-27170: Results for branch branch-2 [build #584 on

[GitHub] [hbase] Apache-HBase commented on pull request #4599: HBASE-27148 Move minimum hadoop 3 support version to 3.2.3 (#4561)

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4599: URL: https://github.com/apache/hbase/pull/4599#issuecomment-1176120857 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s |

[GitHub] [hbase] ndimiduk commented on pull request #4600: HBASE-27182 Rework tracing configuration

2022-07-06 Thread GitBox
ndimiduk commented on PR #4600: URL: https://github.com/apache/hbase/pull/4600#issuecomment-1176208435 Please review the comments in the configuration file, let me know if it all makes sense to you. If you can try it out for yourself, all the better. I'd like export these comments from the

[GitHub] [hbase] Apache-HBase commented on pull request #4600: HBASE-27182 Rework tracing configuration

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4600: URL: https://github.com/apache/hbase/pull/4600#issuecomment-1176214364 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 36s |

[GitHub] [hbase] Apache-HBase commented on pull request #4600: HBASE-27182 Rework tracing configuration

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4600: URL: https://github.com/apache/hbase/pull/4600#issuecomment-1176214355 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 39s |

[jira] [Resolved] (HBASE-23963) Split TestFromClientSide; it takes too long to complete timing out

2022-07-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23963. --- Resolution: Fixed > Split TestFromClientSide; it takes too long to complete timing out >

[GitHub] [hbase] Apache9 opened a new pull request, #4599: HBASE-27148 Move minimum hadoop 3 support version to 3.2.3 (#4561)

2022-07-06 Thread GitBox
Apache9 opened a new pull request, #4599: URL: https://github.com/apache/hbase/pull/4599 Signed-off-by: Xin Sun (cherry picked from commit 41972cb46017f84d39ce85c76121074e0f4b8bbb) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] Apache-HBase commented on pull request #4599: HBASE-27148 Move minimum hadoop 3 support version to 3.2.3 (#4561)

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4599: URL: https://github.com/apache/hbase/pull/4599#issuecomment-1176102097 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 29s |

[GitHub] [hbase] ndimiduk merged pull request #4589: HBASE-27172 Upgrade OpenTelemetry dependency to 1.15.0

2022-07-06 Thread GitBox
ndimiduk merged PR #4589: URL: https://github.com/apache/hbase/pull/4589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] ndimiduk merged pull request #4590: Backport "HBASE-27172 Upgrade OpenTelemetry dependency to 1.15.0" to branch-2

2022-07-06 Thread GitBox
ndimiduk merged PR #4590: URL: https://github.com/apache/hbase/pull/4590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HBASE-27172) Upgrade OpenTelemetry dependency to 1.15.0

2022-07-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-27172: - Resolution: Fixed Status: Resolved (was: Patch Available) Merged to branch-2.5+ >

[GitHub] [hbase] Apache-HBase commented on pull request #4600: HBASE-27182 Rework tracing configuration

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4600: URL: https://github.com/apache/hbase/pull/4600#issuecomment-1176213803 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 45s |

[GitHub] [hbase] Apache-HBase commented on pull request #4595: HBASE-26950 Use AsyncConnection in ReplicationSink

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4595: URL: https://github.com/apache/hbase/pull/4595#issuecomment-1175814360 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

[GitHub] [hbase] shahrs87 commented on a diff in pull request #4556: HBASE-26913 Replication Observability Framework

2022-07-06 Thread GitBox
shahrs87 commented on code in PR #4556: URL: https://github.com/apache/hbase/pull/4556#discussion_r914453595 ## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationMarkerChore.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] Apache-HBase commented on pull request #4595: HBASE-26950 Use AsyncConnection in ReplicationSink

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4595: URL: https://github.com/apache/hbase/pull/4595#issuecomment-1175962968 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 44s |

[GitHub] [hbase] Apache-HBase commented on pull request #4595: HBASE-26950 Use AsyncConnection in ReplicationSink

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4595: URL: https://github.com/apache/hbase/pull/4595#issuecomment-1175883251 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

[GitHub] [hbase] Apache-HBase commented on pull request #4595: HBASE-26950 Use AsyncConnection in ReplicationSink

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4595: URL: https://github.com/apache/hbase/pull/4595#issuecomment-1175883322 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

[GitHub] [hbase] Apache-HBase commented on pull request #4595: HBASE-26950 Use AsyncConnection in ReplicationSink

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4595: URL: https://github.com/apache/hbase/pull/4595#issuecomment-1175883393 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

[GitHub] [hbase] Apache-HBase commented on pull request #4595: HBASE-26950 Use AsyncConnection in ReplicationSink

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4595: URL: https://github.com/apache/hbase/pull/4595#issuecomment-1175885049 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

[GitHub] [hbase] Apache-HBase commented on pull request #4595: HBASE-26950 Use AsyncConnection in ReplicationSink

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4595: URL: https://github.com/apache/hbase/pull/4595#issuecomment-1175885083 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

[GitHub] [hbase] Apache-HBase commented on pull request #4595: HBASE-26950 Use AsyncConnection in ReplicationSink

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4595: URL: https://github.com/apache/hbase/pull/4595#issuecomment-1175884966 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

[GitHub] [hbase] Apache-HBase commented on pull request #4595: HBASE-26950 Use AsyncConnection in ReplicationSink

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4595: URL: https://github.com/apache/hbase/pull/4595#issuecomment-1175833011 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

[GitHub] [hbase] Apache-HBase commented on pull request #4595: HBASE-26950 Use AsyncConnection in ReplicationSink

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4595: URL: https://github.com/apache/hbase/pull/4595#issuecomment-1175832858 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

[GitHub] [hbase] Apache-HBase commented on pull request #4595: HBASE-26950 Use AsyncConnection in ReplicationSink

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4595: URL: https://github.com/apache/hbase/pull/4595#issuecomment-1175833010 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

[GitHub] [hbase] Apache-HBase commented on pull request #4595: HBASE-26950 Use AsyncConnection in ReplicationSink

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4595: URL: https://github.com/apache/hbase/pull/4595#issuecomment-1175814323 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

[GitHub] [hbase] Apache-HBase commented on pull request #4595: HBASE-26950 Use AsyncConnection in ReplicationSink

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4595: URL: https://github.com/apache/hbase/pull/4595#issuecomment-1175814463 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

[jira] [Commented] (HBASE-27157) Potential race condition in WorkerAssigner

2022-07-06 Thread ruanhui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563010#comment-17563010 ] ruanhui commented on HBASE-27157: - OK. I'll start this work ASAP. Thanks for your help Duo. > Potential

[jira] [Updated] (HBASE-27048) Server side scanner time limit should account for time in queue

2022-07-06 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-27048: -- Resolution: Fixed Status: Resolved (was: Patch Available) Merged to master

[jira] [Updated] (HBASE-27048) Server side scanner time limit should account for time in queue

2022-07-06 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-27048: -- Labels: (was: patch-available) > Server side scanner time limit should account for

[jira] [Updated] (HBASE-27048) Server side scanner time limit should account for time in queue

2022-07-06 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-27048: -- Release Note: Server will now account for queue time when determining how long a

[jira] [Reopened] (HBASE-23330) Expose cluster ID for clients using it for delegation token based auth

2022-07-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell reopened HBASE-23330: - > Expose cluster ID for clients using it for delegation token based auth >

[jira] [Updated] (HBASE-23330) Expose cluster ID for clients using it for delegation token based auth

2022-07-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-23330: Fix Version/s: (was: 1.7.0) (was: 2.5.0)

[jira] [Commented] (HBASE-23330) Expose cluster ID for clients using it for delegation token based auth

2022-07-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563413#comment-17563413 ] Hudson commented on HBASE-23330: Results for branch branch-2.5 [build #158 on

[jira] [Commented] (HBASE-27171) Fix Annotation Error in HRegionFileSystem

2022-07-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563414#comment-17563414 ] Hudson commented on HBASE-27171: Results for branch branch-2.5 [build #158 on

[jira] [Comment Edited] (HBASE-23330) Expose cluster ID for clients using it for delegation token based auth

2022-07-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563404#comment-17563404 ] Andrew Kyle Purtell edited comment on HBASE-23330 at 7/6/22 7:20 PM: -

[jira] [Commented] (HBASE-23330) Expose cluster ID for clients using it for delegation token based auth

2022-07-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563404#comment-17563404 ] Andrew Kyle Purtell commented on HBASE-23330: - [~zhangduo] I don't think [~bharathv] is

[GitHub] [hbase] Apache-HBase commented on pull request #4595: HBASE-26950 Use AsyncConnection in ReplicationSink

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4595: URL: https://github.com/apache/hbase/pull/4595#issuecomment-1176567630 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 23s |

[GitHub] [hbase] virajjasani commented on pull request #4596: HBASE-26708 Simplity wrap implementation

2022-07-06 Thread GitBox
virajjasani commented on PR #4596: URL: https://github.com/apache/hbase/pull/4596#issuecomment-1176830281 So far, I have not seen leaks with this. I am still doing some long running tests just to ensure we are 100% good here. -- This is an automated message from the Apache Git Service.

[jira] [Commented] (HBASE-26708) Netty "leak detected" and OutOfDirectMemoryError due to direct memory buffering with SASL implementation

2022-07-06 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563487#comment-17563487 ] Viraj Jasani commented on HBASE-26708: -- So far the changes on PR#4596 looks good, I am going to

[jira] [Comment Edited] (HBASE-26708) Netty "leak detected" and OutOfDirectMemoryError due to direct memory buffering with SASL implementation

2022-07-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563499#comment-17563499 ] Andrew Kyle Purtell edited comment on HBASE-26708 at 7/6/22 11:41 PM:

[jira] [Comment Edited] (HBASE-26708) Netty "leak detected" and OutOfDirectMemoryError due to direct memory buffering with SASL implementation

2022-07-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563499#comment-17563499 ] Andrew Kyle Purtell edited comment on HBASE-26708 at 7/6/22 11:41 PM:

[jira] [Updated] (HBASE-27180) Multiple possible buffer leaks

2022-07-06 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-27180: - Fix Version/s: 2.5.0 3.0.0-alpha-4 2.4.14 > Multiple

[jira] [Assigned] (HBASE-27180) Multiple possible buffer leaks

2022-07-06 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-27180: Assignee: Norman Maurer > Multiple possible buffer leaks >

[jira] [Updated] (HBASE-26708) Netty "leak detected" and OutOfDirectMemoryError due to direct memory buffering

2022-07-06 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-26708: - Fix Version/s: 2.5.0 3.0.0-alpha-4 2.4.14 > Netty "leak

[jira] [Updated] (HBASE-26708) Netty "leak detected" and OutOfDirectMemoryError due to direct memory buffering

2022-07-06 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-26708: - Priority: Blocker (was: Critical) > Netty "leak detected" and OutOfDirectMemoryError due to

[jira] [Comment Edited] (HBASE-26708) Netty "leak detected" and OutOfDirectMemoryError due to direct memory buffering with SASL implementation

2022-07-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563499#comment-17563499 ] Andrew Kyle Purtell edited comment on HBASE-26708 at 7/6/22 11:43 PM:

[GitHub] [hbase] apurtell commented on pull request #4585: HBASE-27078 Allow configuring a separate timeout for meta scans (branch-2 backport)

2022-07-06 Thread GitBox
apurtell commented on PR #4585: URL: https://github.com/apache/hbase/pull/4585#issuecomment-1176794227 @bbeaudreault > that unfortunately in branch-2 scans use hbase.rpc.timeout instead of hbase.read.rpc.timeout. If anyone thinks its allowed, I'd love to fix that. It is

[GitHub] [hbase] huaxiangsun commented on pull request #4453: HBASE-27053 IOException during caching of uncompressed block to the b…

2022-07-06 Thread GitBox
huaxiangsun commented on PR #4453: URL: https://github.com/apache/hbase/pull/4453#issuecomment-1176829273 @bbeaudreault Nice analysis! Could you post the analysis at the jira so it wont get lost? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] virajjasani commented on pull request #4597: HBASE-26708 Fix multiple possible buffer leaks

2022-07-06 Thread GitBox
virajjasani commented on PR #4597: URL: https://github.com/apache/hbase/pull/4597#issuecomment-1176832872 @normanmaurer The changes on this PR would be definitely helpful. For now, you can remove/revert changes from below mentioned 3 files, so that both PRs #4597 and #4596 can be merged.

[jira] [Updated] (HBASE-26708) Netty "leak detected" and OutOfDirectMemoryError due to direct memory buffering with SASL implementation

2022-07-06 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-26708: - Summary: Netty "leak detected" and OutOfDirectMemoryError due to direct memory buffering with

[jira] [Assigned] (HBASE-26708) Netty "leak detected" and OutOfDirectMemoryError due to direct memory buffering with SASL implementation

2022-07-06 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-26708: Assignee: Duo Zhang > Netty "leak detected" and OutOfDirectMemoryError due to direct

[GitHub] [hbase] virajjasani merged pull request #4593: HBASE-27175 - Failure to cleanup WAL split dir log should be at INFO level

2022-07-06 Thread GitBox
virajjasani merged PR #4593: URL: https://github.com/apache/hbase/pull/4593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (HBASE-27175) Failure to cleanup WAL split dir log should be at INFO level

2022-07-06 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-27175. -- Hadoop Flags: Reviewed Resolution: Fixed > Failure to cleanup WAL split dir log should

[GitHub] [hbase] virajjasani commented on pull request #4593: HBASE-27175 - Failure to cleanup WAL split dir log should be at INFO level

2022-07-06 Thread GitBox
virajjasani commented on PR #4593: URL: https://github.com/apache/hbase/pull/4593#issuecomment-1176857482 Thanks for the contribution @ujjawal4046 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HBASE-26708) Netty "leak detected" and OutOfDirectMemoryError due to direct memory buffering with SASL implementation

2022-07-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563499#comment-17563499 ] Andrew Kyle Purtell commented on HBASE-26708: - bq. In general, I prefer we just remove the

[GitHub] [hbase] apurtell commented on pull request #4596: HBASE-26708 Netty leak detected and OutOfDirectMemoryError due to direct memory buffering with SASL implementation

2022-07-06 Thread GitBox
apurtell commented on PR #4596: URL: https://github.com/apache/hbase/pull/4596#issuecomment-1176863377 Those unit test failures seem to be a different issue. They all involve networking issues related to HDFS, which is not touched by this patch. -- This is an automated message from the

[GitHub] [hbase] Apache-HBase commented on pull request #4596: HBASE-26708 Netty leak detected and OutOfDirectMemoryError due to direct memory buffering with SASL implementation

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4596: URL: https://github.com/apache/hbase/pull/4596#issuecomment-1177016739 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

[GitHub] [hbase] Apache-HBase commented on pull request #4599: HBASE-27148 Move minimum hadoop 3 support version to 3.2.3 (#4561)

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4599: URL: https://github.com/apache/hbase/pull/4599#issuecomment-1177017913 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s |

[jira] [Commented] (HBASE-14729) SplitLogManager does not clean files from WALs folder in case of master failover

2022-07-06 Thread Claire Iacono (Jira)
[ https://issues.apache.org/jira/browse/HBASE-14729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563501#comment-17563501 ] Claire Iacono commented on HBASE-14729: --- FYI I saw this exception in a cluster running 2.2.4. This

[GitHub] [hbase] Apache-HBase commented on pull request #4599: HBASE-27148 Move minimum hadoop 3 support version to 3.2.3 (#4561)

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4599: URL: https://github.com/apache/hbase/pull/4599#issuecomment-1176873857 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s |

[jira] [Commented] (HBASE-23330) Expose cluster ID for clients using it for delegation token based auth

2022-07-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563504#comment-17563504 ] Duo Zhang commented on HBASE-23330: --- Ah, I've already cherry-picked the changes to all branch-2.x...

[jira] [Commented] (HBASE-27157) Potential race condition in WorkerAssigner

2022-07-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563508#comment-17563508 ] Duo Zhang commented on HBASE-27157: --- [~frostruan] Due to a UT failure I have to revert the commits to

[jira] [Comment Edited] (HBASE-26708) Netty "leak detected" and OutOfDirectMemoryError due to direct memory buffering with SASL implementation

2022-07-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563499#comment-17563499 ] Andrew Kyle Purtell edited comment on HBASE-26708 at 7/7/22 1:08 AM: -

[jira] [Commented] (HBASE-23330) Expose cluster ID for clients using it for delegation token based auth

2022-07-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563518#comment-17563518 ] Andrew Kyle Purtell commented on HBASE-23330: - I see. If it has already been released in

[GitHub] [hbase] Apache-HBase commented on pull request #4599: HBASE-27148 Move minimum hadoop 3 support version to 3.2.3 (#4561)

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4599: URL: https://github.com/apache/hbase/pull/4599#issuecomment-1176944863 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 25s |

[GitHub] [hbase] mymeiyi commented on pull request #4206: HBASE-26827 RegionServer JVM crash when compact mob table

2022-07-06 Thread GitBox
mymeiyi commented on PR #4206: URL: https://github.com/apache/hbase/pull/4206#issuecomment-1176983848 > So here we can only release all the cells at onceafter shipping them all? Will it cause OOM? Sorry for so late to reply. This problem is also disscussed in

[jira] [Comment Edited] (HBASE-26708) Netty "leak detected" and OutOfDirectMemoryError due to direct memory buffering with SASL implementation

2022-07-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563499#comment-17563499 ] Andrew Kyle Purtell edited comment on HBASE-26708 at 7/6/22 11:53 PM:

[GitHub] [hbase] Apache9 commented on pull request #4596: HBASE-26708 Netty leak detected and OutOfDirectMemoryError due to direct memory buffering with SASL implementation

2022-07-06 Thread GitBox
Apache9 commented on PR #4596: URL: https://github.com/apache/hbase/pull/4596#issuecomment-1176867570 Thanks for confirming. Let me polish the PR and also include some improvements in @normanmaurer 's PR and list him as a co-author. -- This is an automated message from the Apache

[jira] [Commented] (HBASE-27157) Potential race condition in WorkerAssigner

2022-07-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563513#comment-17563513 ] Hudson commented on HBASE-27157: Results for branch master [build #627 on

[jira] [Commented] (HBASE-27171) Fix Annotation Error in HRegionFileSystem

2022-07-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563512#comment-17563512 ] Hudson commented on HBASE-27171: Results for branch master [build #627 on

[jira] [Commented] (HBASE-27148) Move minimum hadoop 3 support version to 3.2.3

2022-07-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563514#comment-17563514 ] Hudson commented on HBASE-27148: Results for branch master [build #627 on

[jira] [Comment Edited] (HBASE-26708) Netty "leak detected" and OutOfDirectMemoryError due to direct memory buffering with SASL implementation

2022-07-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563499#comment-17563499 ] Andrew Kyle Purtell edited comment on HBASE-26708 at 7/7/22 1:09 AM: -

[GitHub] [hbase] Apache-HBase commented on pull request #4596: HBASE-26708 Netty leak detected and OutOfDirectMemoryError due to direct memory buffering with SASL implementation

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4596: URL: https://github.com/apache/hbase/pull/4596#issuecomment-1176925239 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s |

[GitHub] [hbase] Apache-HBase commented on pull request #4596: HBASE-26708 Netty leak detected and OutOfDirectMemoryError due to direct memory buffering with SASL implementation

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4596: URL: https://github.com/apache/hbase/pull/4596#issuecomment-1176925297 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

[GitHub] [hbase] Apache-HBase commented on pull request #4596: HBASE-26708 Netty leak detected and OutOfDirectMemoryError due to direct memory buffering with SASL implementation

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4596: URL: https://github.com/apache/hbase/pull/4596#issuecomment-1176925351 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

[GitHub] [hbase] Apache-HBase commented on pull request #4599: HBASE-27148 Move minimum hadoop 3 support version to 3.2.3 (#4561)

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4599: URL: https://github.com/apache/hbase/pull/4599#issuecomment-1176941040 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 27s |

[GitHub] [hbase] Apache-HBase commented on pull request #4599: HBASE-27148 Move minimum hadoop 3 support version to 3.2.3 (#4561)

2022-07-06 Thread GitBox
Apache-HBase commented on PR #4599: URL: https://github.com/apache/hbase/pull/4599#issuecomment-1176943345 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s |

[GitHub] [hbase] virajjasani commented on pull request #4450: HBASE-18045 Added default SSH connection timeout in Integration tests

2022-07-06 Thread GitBox
virajjasani commented on PR #4450: URL: https://github.com/apache/hbase/pull/4450#issuecomment-1177073920 Changes look good, @saintstack sir you are good with the change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hbase] virajjasani commented on pull request #4596: HBASE-26708 Netty leak detected and OutOfDirectMemoryError due to direct memory buffering with SASL implementation

2022-07-06 Thread GitBox
virajjasani commented on PR #4596: URL: https://github.com/apache/hbase/pull/4596#issuecomment-1177074872 Just few more hours, and we are good to go. We are mostly good :) +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub