[jira] [Created] (HBASE-27723) Fix brotli4j licence issue on native-osx-aarch64

2023-03-16 Thread Frens Jan Rumph (Jira)
Frens Jan Rumph created HBASE-27723: --- Summary: Fix brotli4j licence issue on native-osx-aarch64 Key: HBASE-27723 URL: https://issues.apache.org/jira/browse/HBASE-27723 Project: HBase Issue

[GitHub] [hbase] frensjan opened a new pull request, #5113: Add supplement for com.aayushatharva.brotli4j:native-osx-aarch64

2023-03-16 Thread via GitHub
frensjan opened a new pull request, #5113: URL: https://github.com/apache/hbase/pull/5113 Add supplement for com.aayushatharva.brotli4j:native-osx-aarch64 licence information. https://issues.apache.org/jira/browse/HBASE-27723 -- This is an automated message from the Apache Git Service.

[GitHub] [hbase] Apache-HBase commented on pull request #5113: Add supplement for com.aayushatharva.brotli4j:native-osx-aarch64

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5113: URL: https://github.com/apache/hbase/pull/5113#issuecomment-1472587543 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s |

[jira] [Updated] (HBASE-27724) [HBCK2] addFsRegionsMissingInMeta command should support dumping region list into a file which can be passed as input to assigns command

2023-03-16 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-27724: --- Description: _addFsRegionsMissingInMeta_ command currently outputs a command as last line of

[jira] [Created] (HBASE-27724) [HBCK2] addFsRegionsMissingInMeta command should support dumping region list into a file which can be passed as input to assigns command

2023-03-16 Thread Nihal Jain (Jira)
Nihal Jain created HBASE-27724: -- Summary: [HBCK2] addFsRegionsMissingInMeta command should support dumping region list into a file which can be passed as input to assigns command Key: HBASE-27724 URL:

[jira] [Comment Edited] (HBASE-27706) Possible Zstd incompatibility

2023-03-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701410#comment-17701410 ] Andrew Kyle Purtell edited comment on HBASE-27706 at 3/16/23 10:22 PM:

[GitHub] [hbase] vli02 commented on pull request #5081: HBASE-27684: add client metrics related to user region lock.

2023-03-16 Thread via GitHub
vli02 commented on PR #5081: URL: https://github.com/apache/hbase/pull/5081#issuecomment-1472980140 Are these two known/flaky test failures? Can anyone help re-run the pipeline if needed? Thanks!

[jira] [Commented] (HBASE-24762) Purge protobuf java 2.5.0 dependency

2023-03-16 Thread Frens Jan Rumph (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701339#comment-17701339 ] Frens Jan Rumph commented on HBASE-24762: - Would it still be desirable to remove the 2.5.0

[jira] [Comment Edited] (HBASE-27706) Possible Zstd incompatibility

2023-03-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701410#comment-17701410 ] Andrew Kyle Purtell edited comment on HBASE-27706 at 3/16/23 10:36 PM:

[GitHub] [hbase] Apache-HBase commented on pull request #5081: HBASE-27684: add client metrics related to user region lock.

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5081: URL: https://github.com/apache/hbase/pull/5081#issuecomment-1472960421 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

[jira] [Commented] (HBASE-27708) CPU hot-spot resolving User subject

2023-03-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701347#comment-17701347 ] Hudson commented on HBASE-27708: Results for branch master [build #797 on

[jira] [Commented] (HBASE-27715) Refactoring the long tryAdvanceEntry method in WALEntryStream

2023-03-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701346#comment-17701346 ] Hudson commented on HBASE-27715: Results for branch master [build #797 on

[GitHub] [hbase] NihalJain commented on a diff in pull request #5109: HBASE-27671 Client should not be able to restore/clone a snapshot aft…

2023-03-16 Thread via GitHub
NihalJain commented on code in PR #5109: URL: https://github.com/apache/hbase/pull/5109#discussion_r1139269596 ## hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotWithTTLFromClient.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (HBASE-27652) Client-side lock contention around Configuration when using read replica regions

2023-03-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701369#comment-17701369 ] Hudson commented on HBASE-27652: Results for branch branch-2.5 [build #318 on

[jira] [Comment Edited] (HBASE-27706) Possible Zstd incompatibility

2023-03-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701410#comment-17701410 ] Andrew Kyle Purtell edited comment on HBASE-27706 at 3/16/23 10:35 PM:

[GitHub] [hbase] Apache-HBase commented on pull request #5113: Add supplement for com.aayushatharva.brotli4j:native-osx-aarch64

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5113: URL: https://github.com/apache/hbase/pull/5113#issuecomment-1472585156 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

[GitHub] [hbase] Apache-HBase commented on pull request #5113: Add supplement for com.aayushatharva.brotli4j:native-osx-aarch64

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5113: URL: https://github.com/apache/hbase/pull/5113#issuecomment-1472583612 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 57s |

[jira] [Updated] (HBASE-27724) [HBCK2] addFsRegionsMissingInMeta command should support dumping region list into a file which can be passed as input to assigns command

2023-03-16 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-27724: --- Description: _addFsRegionsMissingInMeta_ command currently outputs a command as last line of

[GitHub] [hbase] Apache-HBase commented on pull request #5081: HBASE-27684: add client metrics related to user region lock.

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5081: URL: https://github.com/apache/hbase/pull/5081#issuecomment-1472808998 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s |

[jira] [Comment Edited] (HBASE-27706) Possible Zstd incompatibility

2023-03-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701410#comment-17701410 ] Andrew Kyle Purtell edited comment on HBASE-27706 at 3/16/23 10:26 PM:

[jira] [Commented] (HBASE-27711) Regions permanently stuck in unknown_server state

2023-03-16 Thread Aaron Beitch (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701337#comment-17701337 ] Aaron Beitch commented on HBASE-27711: -- {quote}So you do the restarting work in a script. How do

[GitHub] [hbase] NihalJain commented on a diff in pull request #5109: HBASE-27671 Client should not be able to restore/clone a snapshot aft…

2023-03-16 Thread via GitHub
NihalJain commented on code in PR #5109: URL: https://github.com/apache/hbase/pull/5109#discussion_r1139295396 ## hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java: ## @@ -465,4 +465,18 @@ public ListMultimap run() throws Exception {

[GitHub] [hbase] apurtell commented on a diff in pull request #5081: HBASE-27684: add client metrics related to user region lock.

2023-03-16 Thread via GitHub
apurtell commented on code in PR #5081: URL: https://github.com/apache/hbase/pull/5081#discussion_r1139343792 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java: ## @@ -443,6 +447,15 @@ protected Ratio getRatio() { this.nsLookups =

[GitHub] [hbase] vli02 commented on a diff in pull request #5081: HBASE-27684: add client metrics related to user region lock.

2023-03-16 Thread via GitHub
vli02 commented on code in PR #5081: URL: https://github.com/apache/hbase/pull/5081#discussion_r1139363918 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java: ## @@ -443,6 +447,15 @@ protected Ratio getRatio() { this.nsLookups =

[jira] [Comment Edited] (HBASE-27706) Possible Zstd incompatibility

2023-03-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701410#comment-17701410 ] Andrew Kyle Purtell edited comment on HBASE-27706 at 3/16/23 10:32 PM:

[jira] [Comment Edited] (HBASE-27706) Possible Zstd incompatibility

2023-03-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701410#comment-17701410 ] Andrew Kyle Purtell edited comment on HBASE-27706 at 3/16/23 10:41 PM:

[GitHub] [hbase] Apache-HBase commented on pull request #5109: HBASE-27671 Client should not be able to restore/clone a snapshot aft…

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5109: URL: https://github.com/apache/hbase/pull/5109#issuecomment-1472896658 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s |

[GitHub] [hbase] virajjasani commented on a diff in pull request #5109: HBASE-27671 Client should not be able to restore/clone a snapshot aft…

2023-03-16 Thread via GitHub
virajjasani commented on code in PR #5109: URL: https://github.com/apache/hbase/pull/5109#discussion_r1139276929 ## hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java: ## @@ -465,4 +465,18 @@ public ListMultimap run() throws Exception {

[GitHub] [hbase] Apache-HBase commented on pull request #5109: HBASE-27671 Client should not be able to restore/clone a snapshot aft…

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5109: URL: https://github.com/apache/hbase/pull/5109#issuecomment-1472680495 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 19s |

[jira] [Commented] (HBASE-27706) Possible Zstd incompatibility

2023-03-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701410#comment-17701410 ] Andrew Kyle Purtell commented on HBASE-27706: - HBase native codecs all work by appending to

[GitHub] [hbase] Apache-HBase commented on pull request #5109: HBASE-27671 Client should not be able to restore/clone a snapshot aft…

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5109: URL: https://github.com/apache/hbase/pull/5109#issuecomment-1472904311 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s |

[GitHub] [hbase] Apache-HBase commented on pull request #5081: HBASE-27684: add client metrics related to user region lock.

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5081: URL: https://github.com/apache/hbase/pull/5081#issuecomment-1472974281 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s |

[GitHub] [hbase] Apache-HBase commented on pull request #5109: HBASE-27671 Client should not be able to restore/clone a snapshot aft…

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5109: URL: https://github.com/apache/hbase/pull/5109#issuecomment-1472936798 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[jira] [Commented] (HBASE-27723) Fix brotli4j licence issue on native-osx-aarch64

2023-03-16 Thread Frens Jan Rumph (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701334#comment-17701334 ] Frens Jan Rumph commented on HBASE-27723: - I've created a PR:

[jira] [Comment Edited] (HBASE-27706) Possible Zstd incompatibility

2023-03-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701410#comment-17701410 ] Andrew Kyle Purtell edited comment on HBASE-27706 at 3/16/23 10:29 PM:

[jira] [Commented] (HBASE-27723) Fix brotli4j licence issue on native-osx-aarch64

2023-03-16 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701507#comment-17701507 ] Duo Zhang commented on HBASE-27723: --- This is for fixing the problem when building on M1 mac? > Fix

[GitHub] [hbase] chaijunjie0101 commented on pull request #5106: HBASE-27718 The regionStateNode only need remove once in regionOffline

2023-03-16 Thread via GitHub
chaijunjie0101 commented on PR #5106: URL: https://github.com/apache/hbase/pull/5106#issuecomment-1473033541 > It was like this in the beginning, when introduced in [HBASE-14614](https://issues.apache.org/jira/browse/HBASE-14614), for me I do not think we need this extra line to remove it

[jira] [Created] (HBASE-27726) ruby shell not handled SyntaxError exceptions properly

2023-03-16 Thread chiranjeevi (Jira)
chiranjeevi created HBASE-27726: --- Summary: ruby shell not handled SyntaxError exceptions properly Key: HBASE-27726 URL: https://issues.apache.org/jira/browse/HBASE-27726 Project: HBase Issue

[jira] [Updated] (HBASE-27725) HBase blocking thread on

2023-03-16 Thread chenfengge (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenfengge updated HBASE-27725: --- Summary: HBase blocking thread on (was: Add ConcurrentHashMap#get() call before

[jira] [Updated] (HBASE-27725) HBase blocking thread on java.util.concurrent.ConcurrentHashMap.computeIfAbsent

2023-03-16 Thread chenfengge (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenfengge updated HBASE-27725: --- Summary: HBase blocking thread on java.util.concurrent.ConcurrentHashMap.computeIfAbsent (was:

[jira] [Commented] (HBASE-27686) Recovery of BucketCache and Prefetched data after RS Crash

2023-03-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701500#comment-17701500 ] Hudson commented on HBASE-27686: Results for branch branch-2 [build #769 on

[jira] [Commented] (HBASE-27708) CPU hot-spot resolving User subject

2023-03-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701499#comment-17701499 ] Hudson commented on HBASE-27708: Results for branch branch-2 [build #769 on

[GitHub] [hbase] Apache-HBase commented on pull request #5109: HBASE-27671 Client should not be able to restore/clone a snapshot aft…

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5109: URL: https://github.com/apache/hbase/pull/5109#issuecomment-1473088622 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s |

[jira] [Created] (HBASE-27725) Add ConcurrentHashMap#get() call before ConcurrentHashMap#computeIfAbsent()

2023-03-16 Thread chenfengge (Jira)
chenfengge created HBASE-27725: -- Summary: Add ConcurrentHashMap#get() call before ConcurrentHashMap#computeIfAbsent() Key: HBASE-27725 URL: https://issues.apache.org/jira/browse/HBASE-27725 Project:

[GitHub] [hbase] virajjasani commented on pull request #5109: HBASE-27671 Client should not be able to restore/clone a snapshot aft…

2023-03-16 Thread via GitHub
virajjasani commented on PR #5109: URL: https://github.com/apache/hbase/pull/5109#issuecomment-1473144263 Thanks @NihalJain, +1. Will merge this in a day's time if there is no objection. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Comment Edited] (HBASE-27726) ruby shell not handled SyntaxError exceptions properly

2023-03-16 Thread Rishabh Murarka (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701518#comment-17701518 ] Rishabh Murarka edited comment on HBASE-27726 at 3/17/23 5:38 AM: -- Hi,

[jira] [Commented] (HBASE-27726) ruby shell not handled SyntaxError exceptions properly

2023-03-16 Thread Rishabh Murarka (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701518#comment-17701518 ] Rishabh Murarka commented on HBASE-27726: - Hi, I would like to work upon this. Can you please

[jira] [Created] (HBASE-27727) Implement filesystem based Replication peer storage

2023-03-16 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-27727: - Summary: Implement filesystem based Replication peer storage Key: HBASE-27727 URL: https://issues.apache.org/jira/browse/HBASE-27727 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #5109: HBASE-27671 Client should not be able to restore/clone a snapshot aft…

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5109: URL: https://github.com/apache/hbase/pull/5109#issuecomment-1473076619 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

[jira] [Commented] (HBASE-24762) Purge protobuf java 2.5.0 dependency

2023-03-16 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701497#comment-17701497 ] Duo Zhang commented on HBASE-24762: --- The CP implementation for 2.x still depends on protobuf-2.5 so it

[jira] [Created] (HBASE-27728) Implement a tool to migrate replication peer data between different storage implementation

2023-03-16 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-27728: - Summary: Implement a tool to migrate replication peer data between different storage implementation Key: HBASE-27728 URL: https://issues.apache.org/jira/browse/HBASE-27728

[jira] [Commented] (HBASE-27688) HFile splitting occurs during bulkload, the CREATE_TIME_TS of hfileinfo is 0

2023-03-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700995#comment-17700995 ] Hudson commented on HBASE-27688: Results for branch branch-2 [build #768 on

[jira] [Commented] (HBASE-27714) WALEntryStreamTestBase creates a new HBTU in startCluster method which causes all sub classes are testing default configurations

2023-03-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700996#comment-17700996 ] Hudson commented on HBASE-27714: Results for branch branch-2 [build #768 on

[GitHub] [hbase] Apache-HBase commented on pull request #5080: HBASE-27686: Recovery of BucketCache and Prefetched data after RS Crash

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5080: URL: https://github.com/apache/hbase/pull/5080#issuecomment-1471404885 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s |

[jira] [Commented] (HBASE-27715) Refactoring the long tryAdvanceEntry method in WALEntryStream

2023-03-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700998#comment-17700998 ] Hudson commented on HBASE-27715: Results for branch branch-2 [build #768 on

[jira] [Commented] (HBASE-27716) Fix TestWALOpenAfterDNRollingStart

2023-03-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700997#comment-17700997 ] Hudson commented on HBASE-27716: Results for branch branch-2 [build #768 on

[jira] [Commented] (HBASE-27652) Client-side lock contention around Configuration when using read replica regions

2023-03-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700999#comment-17700999 ] Hudson commented on HBASE-27652: Results for branch branch-2 [build #768 on

[GitHub] [hbase] Apache9 commented on a diff in pull request #5100: HBASE-27712 Remove unused params in region metrics

2023-03-16 Thread via GitHub
Apache9 commented on code in PR #5100: URL: https://github.com/apache/hbase/pull/5100#discussion_r1138253165 ## hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java: ## @@ -73,15 +73,14 @@ public interface MetricsRegionSource extends

[jira] [Commented] (HBASE-26734) FanOutOneBlockAsyncDFSOutputHelper stuck when run against hadoop-3.3.1

2023-03-16 Thread Frens Jan Rumph (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701154#comment-17701154 ] Frens Jan Rumph commented on HBASE-26734: - Thanks guys for the feedback! We're using

[GitHub] [hbase] ndimiduk merged pull request #5111: Backport "HBASE-27708 CPU hot-spot resolving User subject" to branch-2

2023-03-16 Thread via GitHub
ndimiduk merged PR #5111: URL: https://github.com/apache/hbase/pull/5111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] ndimiduk merged pull request #5112: Backport "HBASE-27708 CPU hot-spot resolving User subject" to branch-2.5

2023-03-16 Thread via GitHub
ndimiduk merged PR #5112: URL: https://github.com/apache/hbase/pull/5112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #5096: HBASE-27702 Remove 'hbase.regionserver.hlog.writer.impl' config

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5096: URL: https://github.com/apache/hbase/pull/5096#issuecomment-1471560815 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 27s |

[jira] [Commented] (HBASE-27706) Possible Zstd incompatibility

2023-03-16 Thread Frens Jan Rumph (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701047#comment-17701047 ] Frens Jan Rumph commented on HBASE-27706: - Thanks [~apurtell] for the feedback. The

[GitHub] [hbase] Apache-HBase commented on pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #4966: URL: https://github.com/apache/hbase/pull/4966#issuecomment-1471600144 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 15s |

[jira] [Commented] (HBASE-26734) FanOutOneBlockAsyncDFSOutputHelper stuck when run against hadoop-3.3.1

2023-03-16 Thread Robin Roy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701092#comment-17701092 ] Robin Roy commented on HBASE-26734: --- Haven't observed this issue in my setup. I have built HBase

[GitHub] [hbase] Apache-HBase commented on pull request #5096: HBASE-27702 Remove 'hbase.regionserver.hlog.writer.impl' config

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5096: URL: https://github.com/apache/hbase/pull/5096#issuecomment-1471885100 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 25s |

[GitHub] [hbase] Apache-HBase commented on pull request #5096: HBASE-27702 Remove 'hbase.regionserver.hlog.writer.impl' config

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5096: URL: https://github.com/apache/hbase/pull/5096#issuecomment-1471929325 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 55s |

[jira] [Updated] (HBASE-27708) CPU hot-spot resolving User subject

2023-03-16 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-27708: - Fix Version/s: 2.6.0 2.5.4 > CPU hot-spot resolving User subject >

[jira] [Updated] (HBASE-27708) CPU hot-spot resolving User subject

2023-03-16 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-27708: - Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the review. >

[GitHub] [hbase-operator-tools] ndimiduk commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-16 Thread via GitHub
ndimiduk commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1471916101 Thanks for the reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hbase-operator-tools] ndimiduk merged pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-16 Thread via GitHub
ndimiduk merged PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HBASE-27696) [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-16 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-27696: - Resolution: Fixed Status: Resolved (was: Patch Available) > [hbase-operator-tools] Use

[jira] [Updated] (HBASE-27696) [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-16 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-27696: - Fix Version/s: hbase-operator-tools-1.3.0 > [hbase-operator-tools] Use $revision as placeholder

[GitHub] [hbase] Apache9 commented on a diff in pull request #5110: HBASE-27720 TestClusterRestartFailover is flakey due to metrics assertion

2023-03-16 Thread via GitHub
Apache9 commented on code in PR #5110: URL: https://github.com/apache/hbase/pull/5110#discussion_r1138257248 ## hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClusterRestartFailover.java: ## @@ -131,10 +132,17 @@ public void test() throws Exception {

[GitHub] [hbase] Apache9 commented on pull request #5110: HBASE-27720 TestClusterRestartFailover is flakey due to metrics assertion

2023-03-16 Thread via GitHub
Apache9 commented on PR #5110: URL: https://github.com/apache/hbase/pull/5110#issuecomment-1471487501 https://issues.apache.org/jira/browse/HBASE-14166 Seems added in this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hbase] ndimiduk merged pull request #5103: HBASE-27708 CPU hot-spot resolving User subject

2023-03-16 Thread via GitHub
ndimiduk merged PR #5103: URL: https://github.com/apache/hbase/pull/5103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase-operator-tools] ndimiduk commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-16 Thread via GitHub
ndimiduk commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1471517632 Okay. One more commit to let flatten plugin remove everything that it can. I started a DISCUSS on the mailing list to solicit other opinions. -- This is an automated

[GitHub] [hbase] Apache9 commented on pull request #5096: HBASE-27702 Remove 'hbase.regionserver.hlog.writer.impl' config

2023-03-16 Thread via GitHub
Apache9 commented on PR #5096: URL: https://github.com/apache/hbase/pull/5096#issuecomment-1471522871 Changed the configuration names to `hbase.regionserver.wal.writer.impl` and `hbase.regionserver.wal.async.writer.impl`, which are mainly used for unit testing. Removed

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1471531958 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[GitHub] [hbase] Apache-HBase commented on pull request #5111: Backport "HBASE-27708 CPU hot-spot resolving User subject" to branch-2

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5111: URL: https://github.com/apache/hbase/pull/5111#issuecomment-1471564588 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 43s |

[GitHub] [hbase] Apache-HBase commented on pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #4966: URL: https://github.com/apache/hbase/pull/4966#issuecomment-1471607120 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 19s |

[jira] [Commented] (HBASE-26734) FanOutOneBlockAsyncDFSOutputHelper stuck when run against hadoop-3.3.1

2023-03-16 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701071#comment-17701071 ] Duo Zhang commented on HBASE-26734: --- HBase 2.5.3 is not built with hadoop 3.3.4, so how do you use

[GitHub] [hbase] Apache-HBase commented on pull request #5100: HBASE-27712 Remove unused params in region metrics

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5100: URL: https://github.com/apache/hbase/pull/5100#issuecomment-1471777471 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 23s |

[GitHub] [hbase] Apache9 commented on a diff in pull request #5107: HBASE-27713 Remove numRegions in Region Metrics

2023-03-16 Thread via GitHub
Apache9 commented on code in PR #5107: URL: https://github.com/apache/hbase/pull/5107#discussion_r1138260580 ## hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionAggregateSourceImpl.java: ## @@ -99,7 +98,6 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #5111: Backport "HBASE-27708 CPU hot-spot resolving User subject" to branch-2

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5111: URL: https://github.com/apache/hbase/pull/5111#issuecomment-1471547590 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 49s |

[GitHub] [hbase] Apache-HBase commented on pull request #5112: Backport "HBASE-27708 CPU hot-spot resolving User subject" to branch-2.5

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5112: URL: https://github.com/apache/hbase/pull/5112#issuecomment-1471549311 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 2s |

[GitHub] [hbase] thangTang commented on a diff in pull request #5107: HBASE-27713 Remove numRegions in Region Metrics

2023-03-16 Thread via GitHub
thangTang commented on code in PR #5107: URL: https://github.com/apache/hbase/pull/5107#discussion_r1138355039 ## hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionAggregateSourceImpl.java: ## @@ -99,7 +98,6 @@ public void

[jira] [Commented] (HBASE-27109) Move replication queue storage from zookeeper to a separated HBase table

2023-03-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701028#comment-17701028 ] Hudson commented on HBASE-27109: Results for branch HBASE-27109/table_based_rqs [build #54 on

[GitHub] [hbase] Apache-HBase commented on pull request #5111: Backport "HBASE-27708 CPU hot-spot resolving User subject" to branch-2

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5111: URL: https://github.com/apache/hbase/pull/5111#issuecomment-1471541134 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 19s |

[GitHub] [hbase] Apache-HBase commented on pull request #5112: Backport "HBASE-27708 CPU hot-spot resolving User subject" to branch-2.5

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5112: URL: https://github.com/apache/hbase/pull/5112#issuecomment-1471552953 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 30s |

[jira] [Commented] (HBASE-26734) FanOutOneBlockAsyncDFSOutputHelper stuck when run against hadoop-3.3.1

2023-03-16 Thread Frens Jan Rumph (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701058#comment-17701058 ] Frens Jan Rumph commented on HBASE-26734: - It can be reproduced fairly easily. The setup I've

[jira] [Comment Edited] (HBASE-26734) FanOutOneBlockAsyncDFSOutputHelper stuck when run against hadoop-3.3.1

2023-03-16 Thread Frens Jan Rumph (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701058#comment-17701058 ] Frens Jan Rumph edited comment on HBASE-26734 at 3/16/23 9:34 AM: -- It

[GitHub] [hbase] Apache-HBase commented on pull request #5080: HBASE-27686: Recovery of BucketCache and Prefetched data after RS Crash

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5080: URL: https://github.com/apache/hbase/pull/5080#issuecomment-1471652741 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 33s |

[jira] [Updated] (HBASE-27708) CPU hot-spot resolving User subject

2023-03-16 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-27708: - Fix Version/s: 3.0.0-alpha-4 > CPU hot-spot resolving User subject >

[GitHub] [hbase] ndimiduk commented on pull request #5103: HBASE-27708 CPU hot-spot resolving User subject

2023-03-16 Thread via GitHub
ndimiduk commented on PR #5103: URL: https://github.com/apache/hbase/pull/5103#issuecomment-1471501256 Thanks @Apache9 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] Apache-HBase commented on pull request #5112: Backport "HBASE-27708 CPU hot-spot resolving User subject" to branch-2.5

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5112: URL: https://github.com/apache/hbase/pull/5112#issuecomment-1471536985 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 31s |

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1471561006 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase] Apache9 commented on pull request #5106: HBASE-27718 The regionStateNode only need remove once in regionOffline

2023-03-16 Thread via GitHub
Apache9 commented on PR #5106: URL: https://github.com/apache/hbase/pull/5106#issuecomment-1471581431 It was like this in the beginning, when introduced in HBASE-14614, for me I do not think we need this extra line to remove it from offlineRegions. -- This is an automated message from

[jira] [Commented] (HBASE-26734) FanOutOneBlockAsyncDFSOutputHelper stuck when run against hadoop-3.3.1

2023-03-16 Thread Frens Jan Rumph (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701056#comment-17701056 ] Frens Jan Rumph commented on HBASE-26734: - I'm not 100% sure, but I think I see the same issue

[GitHub] [hbase] Apache-HBase commented on pull request #5080: HBASE-27686: Recovery of BucketCache and Prefetched data after RS Crash

2023-03-16 Thread via GitHub
Apache-HBase commented on PR #5080: URL: https://github.com/apache/hbase/pull/5080#issuecomment-1471632737 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 8s |

  1   2   >