[jira] [Commented] (HBASE-4681) StringIndexOutOfBoundsException parsing Hostname

2011-11-09 Thread gaojinchao (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13146878#comment-13146878 ] gaojinchao commented on HBASE-4681: --- I tested in 3 nodes cluseter and couldn't reproduce

[jira] [Commented] (HBASE-4748) Race between creating recovered edits for META and master assigning ROOT and META.

2011-11-09 Thread ramkrishna.s.vasudevan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13146908#comment-13146908 ] ramkrishna.s.vasudevan commented on HBASE-4748: --- Two things i observed after

[jira] [Commented] (HBASE-4478) Improve AssignmentManager.handleRegion so that it can process certain ZK state in the case of RS offline

2011-11-09 Thread ramkrishna.s.vasudevan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13146919#comment-13146919 ] ramkrishna.s.vasudevan commented on HBASE-4478: --- Took up this issue - Am

[jira] [Commented] (HBASE-4748) Race between creating recovered edits for META and master assigning ROOT and META.

2011-11-09 Thread ramkrishna.s.vasudevan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147082#comment-13147082 ] ramkrishna.s.vasudevan commented on HBASE-4748: --- Any suggestions here. When

[jira] [Commented] (HBASE-4737) Categorize the tests into small/medium/large; allow small tests to be run in parallel within a single JVM

2011-11-09 Thread Jesse Yates (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147199#comment-13147199 ] Jesse Yates commented on HBASE-4737: Good stuff guys! Do you think we can update the

[jira] [Commented] (HBASE-4737) Categorize the tests into small/medium/large; allow small tests to be run in parallel within a single JVM

2011-11-09 Thread nkeywal (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147206#comment-13147206 ] nkeywal commented on HBASE-4737: Hi, I am fighting with surefire (and it's a difficult

[jira] [Commented] (HBASE-4748) Race between creating recovered edits for META and master assigning ROOT and META.

2011-11-09 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147222#comment-13147222 ] Lars Hofhansl commented on HBASE-4748: -- @Ram, did you actually observe the 2nd

[jira] [Commented] (HBASE-4608) HLog Compression

2011-11-09 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147225#comment-13147225 ] jirapos...@reviews.apache.org commented on HBASE-4608: -- bq. On

[jira] [Commented] (HBASE-4608) HLog Compression

2011-11-09 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147238#comment-13147238 ] jirapos...@reviews.apache.org commented on HBASE-4608: --

[jira] [Commented] (HBASE-4608) HLog Compression

2011-11-09 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147245#comment-13147245 ] jirapos...@reviews.apache.org commented on HBASE-4608: --

[jira] [Updated] (HBASE-4737) Categorize the tests into small/medium/large; allow small tests to be run in parallel within a single JVM

2011-11-09 Thread nkeywal (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nkeywal updated HBASE-4737: --- Attachment: 4737_part2.v1.patch tag the small tests. retags some tests. Does not modify executed code.

[jira] [Updated] (HBASE-4737) Categorize the tests into small/medium/large; allow small tests to be run in parallel within a single JVM

2011-11-09 Thread nkeywal (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nkeywal updated HBASE-4737: --- Status: Open (was: Patch Available) Categorize the tests into small/medium/large; allow small tests to

[jira] [Updated] (HBASE-4737) Categorize the tests into small/medium/large; allow small tests to be run in parallel within a single JVM

2011-11-09 Thread nkeywal (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nkeywal updated HBASE-4737: --- Status: Patch Available (was: Open) Categorize the tests into small/medium/large; allow small tests to

[jira] [Updated] (HBASE-4742) Split dead server's log in parallel

2011-11-09 Thread Phabricator (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-4742: --- Attachment: D237.9.patch Liyin updated the revision [jira] [HBASE-4742] Split dead server's log in

[jira] [Updated] (HBASE-4742) Split dead server's log in parallel

2011-11-09 Thread Phabricator (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-4742: --- Attachment: D237.10.patch Liyin updated the revision [jira] [HBASE-4742] Split dead server's log in

[jira] [Commented] (HBASE-4737) Categorize the tests into small/medium/large; allow small tests to be run in parallel within a single JVM

2011-11-09 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147340#comment-13147340 ] Hadoop QA commented on HBASE-4737: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-4737) Categorize the tests into small/medium/large; allow small tests to be run in parallel within a single JVM

2011-11-09 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147341#comment-13147341 ] Ted Yu commented on HBASE-4737: --- TestDistributedLogSplitting passed for me. Patch for

[jira] [Commented] (HBASE-4608) HLog Compression

2011-11-09 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147345#comment-13147345 ] jirapos...@reviews.apache.org commented on HBASE-4608: --

[jira] [Commented] (HBASE-4742) Split dead server's log in parallel

2011-11-09 Thread Phabricator (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147347#comment-13147347 ] Phabricator commented on HBASE-4742: mbautin has accepted the revision [jira]

[jira] [Commented] (HBASE-4608) HLog Compression

2011-11-09 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147363#comment-13147363 ] jirapos...@reviews.apache.org commented on HBASE-4608: -- bq. On

[jira] [Commented] (HBASE-4742) Split dead server's log in parallel

2011-11-09 Thread Nicolas Spiegelberg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147367#comment-13147367 ] Nicolas Spiegelberg commented on HBASE-4742: +1. I take it this is for 89?

[jira] [Created] (HBASE-4763) Integrate surefire and junit for category management

2011-11-09 Thread nkeywal (Created) (JIRA)
Integrate surefire and junit for category management Key: HBASE-4763 URL: https://issues.apache.org/jira/browse/HBASE-4763 Project: HBase Issue Type: Improvement Components:

[jira] [Created] (HBASE-4764) naming errors for TestHLogUtils and SoftValueSortedMapTest

2011-11-09 Thread nkeywal (Created) (JIRA)
naming errors for TestHLogUtils and SoftValueSortedMapTest -- Key: HBASE-4764 URL: https://issues.apache.org/jira/browse/HBASE-4764 Project: HBase Issue Type: Improvement

[jira] [Created] (HBASE-4765) Enhance HLog metrics

2011-11-09 Thread Nicolas Spiegelberg (Created) (JIRA)
Enhance HLog metrics Key: HBASE-4765 URL: https://issues.apache.org/jira/browse/HBASE-4765 Project: HBase Issue Type: Improvement Affects Versions: 0.94.0 Reporter: Nicolas Spiegelberg

[jira] [Commented] (HBASE-4765) Enhance HLog metrics

2011-11-09 Thread Nicolas Spiegelberg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147381#comment-13147381 ] Nicolas Spiegelberg commented on HBASE-4765: Information about original 89-fb

[jira] [Updated] (HBASE-4765) Enhance HLog metrics

2011-11-09 Thread Nicolas Spiegelberg (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Spiegelberg updated HBASE-4765: --- Attachment: HBASE-4765-1.patch Enhance HLog metrics

[jira] [Updated] (HBASE-4765) Enhance HLog metrics

2011-11-09 Thread Nicolas Spiegelberg (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Spiegelberg updated HBASE-4765: --- Status: Patch Available (was: Open) Enhance HLog metrics

[jira] [Commented] (HBASE-4766) Add Instrumentation for Put Latencies at Critical Paths

2011-11-09 Thread Nicolas Spiegelberg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147401#comment-13147401 ] Nicolas Spiegelberg commented on HBASE-4766: Internal stats... Author: Kannan

[jira] [Created] (HBASE-4766) Add Instrumentation for Put Latencies at Critical Paths

2011-11-09 Thread Nicolas Spiegelberg (Created) (JIRA)
Add Instrumentation for Put Latencies at Critical Paths --- Key: HBASE-4766 URL: https://issues.apache.org/jira/browse/HBASE-4766 Project: HBase Issue Type: Improvement Affects

[jira] [Commented] (HBASE-4765) Enhance HLog metrics

2011-11-09 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147400#comment-13147400 ] Hadoop QA commented on HBASE-4765: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-4737) Categorize the tests into small/medium/large; allow small tests to be run in parallel within a single JVM

2011-11-09 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147416#comment-13147416 ] Hudson commented on HBASE-4737: --- Integrated in HBase-TRUNK #2424 (See

[jira] [Updated] (HBASE-4737) Categorize the tests into small/medium/large; allow small tests to be run in parallel within a single JVM

2011-11-09 Thread Ted Yu (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-4737: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available)

[jira] [Updated] (HBASE-4766) Add Instrumentation for Put Latencies at Critical Paths

2011-11-09 Thread Nicolas Spiegelberg (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Spiegelberg updated HBASE-4766: --- Assignee: (was: Nicolas Spiegelberg) looks like jgray redid the flow for the

[jira] [Created] (HBASE-4767) Upgrading branch 0.92 failed

2011-11-09 Thread Sebastian Bauer (Created) (JIRA)
Upgrading branch 0.92 failed Key: HBASE-4767 URL: https://issues.apache.org/jira/browse/HBASE-4767 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.92.0 Reporter:

[jira] [Updated] (HBASE-4767) Upgrading branch 0.92 failed

2011-11-09 Thread Sebastian Bauer (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Bauer updated HBASE-4767: --- Attachment: hbase-hbase-regionserver-db2a.goldenline.pl.log

[jira] [Commented] (HBASE-4739) Master dying while going to close a region can leave it in transition forever

2011-11-09 Thread gaojinchao (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147458#comment-13147458 ] gaojinchao commented on HBASE-4739: --- I think it's issue about RS. when RS is closing

[jira] [Commented] (HBASE-4767) Upgrading branch 0.92 failed

2011-11-09 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147464#comment-13147464 ] Ted Yu commented on HBASE-4767: --- @Sebastian: I think you were upgrading from

[jira] [Commented] (HBASE-4654) [replication] Add a check to make sure we don't replicate to ourselves

2011-11-09 Thread gaojinchao (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147469#comment-13147469 ] gaojinchao commented on HBASE-4654: --- @J-D Can we fix only in trunk or 0.92? We can use

[jira] [Commented] (HBASE-4737) Categorize the tests into small/medium/large; allow small tests to be run in parallel within a single JVM

2011-11-09 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147472#comment-13147472 ] Lars Hofhansl commented on HBASE-4737: -- It seems some printlns sneaked into

[jira] [Updated] (HBASE-4288) Server not running exception during meta verification causes RS abort

2011-11-09 Thread stack (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-4288: - Attachment: 4288-v2.txt Test to prove that this no longer an issue. I think we should commit this test because

[jira] [Commented] (HBASE-4288) Server not running exception during meta verification causes RS abort

2011-11-09 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147481#comment-13147481 ] stack commented on HBASE-4288: -- Oops... let me reattach the change description: {code} M

[jira] [Updated] (HBASE-4288) Server not running exception during meta verification causes RS abort

2011-11-09 Thread stack (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-4288: - Status: Patch Available (was: Open) Server not running exception during meta verification causes RS abort

[jira] [Updated] (HBASE-4737) Categorize the tests into small/medium/large; allow small tests to be run in parallel within a single JVM

2011-11-09 Thread Ted Yu (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-4737: -- Attachment: 4737.addendum Addendum removes the print Categorize the tests into

[jira] [Commented] (HBASE-4748) Race between creating recovered edits for META and master assigning ROOT and META.

2011-11-09 Thread ramkrishna.s.vasudevan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147485#comment-13147485 ] ramkrishna.s.vasudevan commented on HBASE-4748: --- @Lars I can reproduce all

[jira] [Commented] (HBASE-2856) TestAcidGuarantee broken on trunk

2011-11-09 Thread dhruba borthakur (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147489#comment-13147489 ] dhruba borthakur commented on HBASE-2856: - hi amit, what needs to be done to get

[jira] [Commented] (HBASE-4739) Master dying while going to close a region can leave it in transition forever

2011-11-09 Thread ramkrishna.s.vasudevan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147495#comment-13147495 ] ramkrishna.s.vasudevan commented on HBASE-4739: --- In this scenario what JD

[jira] [Commented] (HBASE-4748) Race between creating recovered edits for META and master assigning ROOT and META.

2011-11-09 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147500#comment-13147500 ] Lars Hofhansl commented on HBASE-4748: -- Reading the explanation of the problem makes

[jira] [Updated] (HBASE-3690) Option to Exclude Bulk Import Files from Minor Compaction

2011-11-09 Thread Phabricator (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-3690: --- Attachment: D357.1.patch nspiegelberg requested code review of [jira] [HBASE-3690] Option to Exclude

[jira] [Updated] (HBASE-2312) Possible data loss when RS goes into GC pause while rolling HLog

2011-11-09 Thread Nicolas Spiegelberg (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Spiegelberg updated HBASE-2312: --- Attachment: HBASE-2312.patch forgot to attach jira with the apache license grant

[jira] [Commented] (HBASE-4748) Race between creating recovered edits for META and master assigning ROOT and META.

2011-11-09 Thread ramkrishna.s.vasudevan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147505#comment-13147505 ] ramkrishna.s.vasudevan commented on HBASE-4748: --- @Lars Sorry if my

[jira] [Commented] (HBASE-4288) Server not running exception during meta verification causes RS abort

2011-11-09 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147508#comment-13147508 ] Hadoop QA commented on HBASE-4288: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-4748) Race between creating recovered edits for META and master assigning ROOT and META.

2011-11-09 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147509#comment-13147509 ] Lars Hofhansl commented on HBASE-4748: -- Thanks Ram. I was referring to the problem

[jira] [Commented] (HBASE-4739) Master dying while going to close a region can leave it in transition forever

2011-11-09 Thread gaojinchao (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147515#comment-13147515 ] gaojinchao commented on HBASE-4739: --- In 0.90 version, I think there is no this scenario,

[jira] [Commented] (HBASE-4737) Categorize the tests into small/medium/large; allow small tests to be run in parallel within a single JVM

2011-11-09 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147522#comment-13147522 ] Hudson commented on HBASE-4737: --- Integrated in HBase-TRUNK #2425 (See

[jira] [Commented] (HBASE-4748) Race between creating recovered edits for META and master assigning ROOT and META.

2011-11-09 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147534#comment-13147534 ] Ted Yu commented on HBASE-4748: --- Here is relevant master log: {code} 2011-11-10 17:04:22,495

[jira] [Commented] (HBASE-4739) Master dying while going to close a region can leave it in transition forever

2011-11-09 Thread gaojinchao (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147543#comment-13147543 ] gaojinchao commented on HBASE-4739: --- It seems HBASE-3789 refactored the code