[jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104479#comment-16104479 ] Rajeshbabu Chintaguntla commented on HBASE-18446: - [~Apache9] [~anoop.hbase] We use LocalIndexStoreFileScanner, IndexHalfStoreFileReader to implement HalfStoreFileReader functionality supported after region split/merges. With HalfStoreFileReader we limit the HFile scan to the child region boundary but with local index we need to do full HFile scan and should be able to find the whether Cell belongs the child region based on actual data row key. We use preStoreFileReaderOpen cp hook to create the custom reader one time. Since the hook returns the reader we need to just extend it instead of wrapping into some other class. > Mark StoreFileScanner as IA.Private > --- > > Key: HBASE-18446 > URL: https://issues.apache.org/jira/browse/HBASE-18446 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang > Fix For: 2.0.0, 3.0.0, 2.0.0-alpha-2 > > > Do not see any reason why it is marked as IA.LimitedPrivate. It is not > referenced in any CPs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18362) hbck should not report split replica parent region from meta as errors
[
https://issues.apache.org/jira/browse/HBASE-18362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104446#comment-16104446
]
Anoop Sam John commented on HBASE-18362:
The fix version is 1.4.1 or 1.4.0 ?
> hbck should not report split replica parent region from meta as errors
> ---
>
> Key: HBASE-18362
> URL: https://issues.apache.org/jira/browse/HBASE-18362
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Affects Versions: 1.4.0, 2.0.0-alpha-1
>Reporter: huaxiang sun
>Assignee: huaxiang sun
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.4.1, 1.2.7
>
> Attachments: HBASE-18362.001.patch, HBASE-18362-branch-1-v001.patch,
> HBASE-18362-branch-1-v002.patch
>
>
> As described in HBASE-18247, replica region shows up as key in meta table. We
> need to find out the code/logic introducing the issue. I suspected that it
> was introduced by hbck, but last round of code review did not find anything.
> Create jira to track this effort.
> Before Catalog Janitor cleans up the split parent region from meta, hbck is
> reporting split replica parent regions as errors and if -fixSplitParents is
> used, the replica parent region will show up as key in meta table. It needs
> to be avoided.
> {code}
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:regioninfo,
> timestamp=1500931787651, value={ENCODED => e10212c467b78104c911ea06c102ece0,
> NAME => 't1,,1500931628959.e10212c467b78104c911ea
> . 06c102ece0.', STARTKEY =>
> '', ENDKEY => '', OFFLINE => true, SPLIT => true}
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen, timestamp=1500931742552,
> value=\x00\x00\x00\x00\x00\x00\x00\x05
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen_0001, timestamp=1500931742492,
> value=\x00\x00\x00\x00\x00\x00\x00\x02
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server,
> timestamp=1500931742552, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server_0001,
> timestamp=1500931742492, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode, timestamp=1500931742552, value=1500931737158
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode_0001, timestamp=1500931742492,
> value=\x00\x00\x01]v\x80\xC6F
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:splitA,
> timestamp=1500931787651, value={ENCODED => dc471b6d9c0c2c451ee4c6d134e50ccc,
> NAME => 't1,,1500931787511.dc471b6d9c0c2c451ee4c6d134
> . e50ccc.', STARTKEY => '',
> ENDKEY => 'r'}
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:splitB,
> timestamp=1500931787651, value={ENCODED =>
[jira] [Commented] (HBASE-18448) Added support for refreshing HFiles through API and shell
[ https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104443#comment-16104443 ] ramkrishna.s.vasudevan commented on HBASE-18448: Oh I can see the same comment from Anoop. I can see in the link that you have given on Amazon S3 is that refreshHFiles is an exposed API that you give for users. > Added support for refreshing HFiles through API and shell > - > > Key: HBASE-18448 > URL: https://issues.apache.org/jira/browse/HBASE-18448 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0, 1.3.1 >Reporter: Ajay Jadhav >Assignee: Ajay Jadhav >Priority: Minor > Fix For: 1.4.0 > > Attachments: HBASE-18448.branch-1.001.patch, > HBASE-18448.branch-1.002.patch > > > In the case where multiple HBase clusters are sharing a common rootDir, even > after flushing the data from > one cluster doesn't mean that other clusters (replicas) will automatically > pick the new HFile. Through this patch, > we are exposing the refresh HFiles API which when issued from a replica will > update the in-memory file handle list > with the newly added file. > This allows replicas to be consistent with the data written through the > primary cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18448) Added support for refreshing HFiles through API and shell
[ https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104441#comment-16104441 ] ramkrishna.s.vasudevan commented on HBASE-18448: You can see if you can use end points which is again external. It can run in every region. You can provide that Endpoint along with your HBase with Amazon S3 and allow users to configure that endpoint. But one thing even this endpoint I think you should use it after every configured time if this whole path of refreshing is not internal to your region servers. > Added support for refreshing HFiles through API and shell > - > > Key: HBASE-18448 > URL: https://issues.apache.org/jira/browse/HBASE-18448 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0, 1.3.1 >Reporter: Ajay Jadhav >Assignee: Ajay Jadhav >Priority: Minor > Fix For: 1.4.0 > > Attachments: HBASE-18448.branch-1.001.patch, > HBASE-18448.branch-1.002.patch > > > In the case where multiple HBase clusters are sharing a common rootDir, even > after flushing the data from > one cluster doesn't mean that other clusters (replicas) will automatically > pick the new HFile. Through this patch, > we are exposing the refresh HFiles API which when issued from a replica will > update the in-memory file handle list > with the newly added file. > This allows replicas to be consistent with the data written through the > primary cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18448) Added support for refreshing HFiles through API and shell
[ https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104438#comment-16104438 ] Anoop Sam John commented on HBASE-18448: I believe u can do this with out any addition to HBase code base. Adding such a public API (which does not make much sense for most of the users) is a worrying point. How u can do this is via CP Endpoints. The EPs will run parallely on each of the Region instance and u can invoke it from client side. (Pls refer AggregationClient , Aggregate.proto and related classes. Also pls refer BulkDeleteEP.) Any way you are using Store#refreshStoreFiles() API. You can see this interface is already exposed to CPs. So in the EP impl (there u will get ref to Region instance) u can get stores in that region and call this API. See Region#getStores(). > Added support for refreshing HFiles through API and shell > - > > Key: HBASE-18448 > URL: https://issues.apache.org/jira/browse/HBASE-18448 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0, 1.3.1 >Reporter: Ajay Jadhav >Assignee: Ajay Jadhav >Priority: Minor > Fix For: 1.4.0 > > Attachments: HBASE-18448.branch-1.001.patch, > HBASE-18448.branch-1.002.patch > > > In the case where multiple HBase clusters are sharing a common rootDir, even > after flushing the data from > one cluster doesn't mean that other clusters (replicas) will automatically > pick the new HFile. Through this patch, > we are exposing the refresh HFiles API which when issued from a replica will > update the in-memory file handle list > with the newly added file. > This allows replicas to be consistent with the data written through the > primary cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17131) Avoid livelock caused by HRegion#processRowsWithLocks
[
https://issues.apache.org/jira/browse/HBASE-17131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104436#comment-16104436
]
Hadoop QA commented on HBASE-17131:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
27s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
29s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
32s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
54s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
47s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
28s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
32s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
11m 57s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
23s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 77m 16s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}102m 27s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat
|
| Timed out junit tests |
org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:933f4b3 |
| JIRA Issue | HBASE-17131 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12879283/HBASE-17131.branch-1.2.v0.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 960bbe8f639d 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool |
[jira] [Commented] (HBASE-18448) Added support for refreshing HFiles through API and shell
[ https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104434#comment-16104434 ] ramkrishna.s.vasudevan commented on HBASE-18448: And one more thing, HBase with read replica support already has this feature of refreshing the store files on the secondary when ever a flush/compaciton happens on the primary. You may want to look at it also(in case you have not) . JFYI. > Added support for refreshing HFiles through API and shell > - > > Key: HBASE-18448 > URL: https://issues.apache.org/jira/browse/HBASE-18448 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0, 1.3.1 >Reporter: Ajay Jadhav >Assignee: Ajay Jadhav >Priority: Minor > Fix For: 1.4.0 > > Attachments: HBASE-18448.branch-1.001.patch, > HBASE-18448.branch-1.002.patch > > > In the case where multiple HBase clusters are sharing a common rootDir, even > after flushing the data from > one cluster doesn't mean that other clusters (replicas) will automatically > pick the new HFile. Through this patch, > we are exposing the refresh HFiles API which when issued from a replica will > update the in-memory file handle list > with the newly added file. > This allows replicas to be consistent with the data written through the > primary cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18448) Added support for refreshing HFiles through API and shell
[
https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104428#comment-16104428
]
ramkrishna.s.vasudevan commented on HBASE-18448:
{code}
if (LOG.isDebugEnabled()) {
2457LOG.debug("Trying to refresh HFiles for " + pair.getFirst()
+ ": " +
2458StringUtils.stringifyException(e));
2459 }
{code}
So when you don't find a region you just try to log it. Is this fine? Say if
the region was split you will not do the refresh of it? And considering you
want to do this manually how frequently do you do it? Is it like every
configured amout of time or how is it? Patch generally looks good to me.
> Added support for refreshing HFiles through API and shell
> -
>
> Key: HBASE-18448
> URL: https://issues.apache.org/jira/browse/HBASE-18448
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.0.0, 1.3.1
>Reporter: Ajay Jadhav
>Assignee: Ajay Jadhav
>Priority: Minor
> Fix For: 1.4.0
>
> Attachments: HBASE-18448.branch-1.001.patch,
> HBASE-18448.branch-1.002.patch
>
>
> In the case where multiple HBase clusters are sharing a common rootDir, even
> after flushing the data from
> one cluster doesn't mean that other clusters (replicas) will automatically
> pick the new HFile. Through this patch,
> we are exposing the refresh HFiles API which when issued from a replica will
> update the in-memory file handle list
> with the newly added file.
> This allows replicas to be consistent with the data written through the
> primary cluster.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (HBASE-18451) PeriodicMemstoreFlusher should inspect the queue before adding a delayed flush request
[
https://issues.apache.org/jira/browse/HBASE-18451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anoop Sam John reassigned HBASE-18451:
--
Assignee: nihed mbarek
> PeriodicMemstoreFlusher should inspect the queue before adding a delayed
> flush request
> --
>
> Key: HBASE-18451
> URL: https://issues.apache.org/jira/browse/HBASE-18451
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 2.0.0-alpha-1
>Reporter: Jean-Marc Spaggiari
>Assignee: nihed mbarek
>
> If you run a big job every 4 hours, impacting many tables (they have 150
> regions per server), ad the end all the regions might have some data to be
> flushed, and we want, after one hour, trigger a periodic flush. That's
> totally fine.
> Now, to avoid a flush storm, when we detect a region to be flushed, we add a
> "randomDelay" to the delayed flush, that way we spread them away.
> RANGE_OF_DELAY is 5 minutes. So we spread the flush over the next 5 minutes,
> which is very good.
> However, because we don't check if there is already a request in the queue,
> 10 seconds after, we create a new request, with a new randomDelay.
> If you generate a randomDelay every 10 seconds, at some point, you will end
> up having a small one, and the flush will be triggered almost immediatly.
> As a result, instead of spreading all the flush within the next 5 minutes,
> you end-up getting them all way more quickly. Like within the first minute.
> Which not only feed the queue to to many flush requests, but also defeats the
> purpose of the randomDelay.
> {code}
> @Override
> protected void chore() {
> final StringBuffer whyFlush = new StringBuffer();
> for (Region r : this.server.onlineRegions.values()) {
> if (r == null) continue;
> if (((HRegion)r).shouldFlush(whyFlush)) {
> FlushRequester requester = server.getFlushRequester();
> if (requester != null) {
> long randomDelay = RandomUtils.nextInt(RANGE_OF_DELAY) +
> MIN_DELAY_TIME;
> LOG.info(getName() + " requesting flush of " +
> r.getRegionInfo().getRegionNameAsString() + " because " +
> whyFlush.toString() +
> " after random delay " + randomDelay + "ms");
> //Throttle the flushes by putting a delay. If we don't throttle,
> and there
> //is a balanced write-load on the regions in a table, we might
> end up
> //overwhelming the filesystem with too many flushes at once.
> requester.requestDelayedFlush(r, randomDelay, false);
> }
> }
> }
> }
> {code}
> {code}
> 2017-07-24 18:44:33,338 INFO
> org.apache.hadoop.hbase.regionserver.HRegionServer:
> hbasetest2.domainname.com,60020,1500916375517-MemstoreFlusherChore requesting
> flush of testflush,,1500932649126.578c27d2eb7ef0ad437bf2ff38c053ae. because f
> has an old edit so flush to free WALs after random delay 270785ms
> 2017-07-24 18:44:43,328 INFO
> org.apache.hadoop.hbase.regionserver.HRegionServer:
> hbasetest2.domainname.com,60020,1500916375517-MemstoreFlusherChore requesting
> flush of testflush,,1500932649126.578c27d2eb7ef0ad437bf2ff38c053ae. because f
> has an old edit so flush to free WALs after random delay 200143ms
> 2017-07-24 18:44:53,954 INFO
> org.apache.hadoop.hbase.regionserver.HRegionServer:
> hbasetest2.domainname.com,60020,1500916375517-MemstoreFlusherChore requesting
> flush of testflush,,1500932649126.578c27d2eb7ef0ad437bf2ff38c053ae. because f
> has an old edit so flush to free WALs after random delay 191082ms
> 2017-07-24 18:45:03,528 INFO
> org.apache.hadoop.hbase.regionserver.HRegionServer:
> hbasetest2.domainname.com,60020,1500916375517-MemstoreFlusherChore requesting
> flush of testflush,,1500932649126.578c27d2eb7ef0ad437bf2ff38c053ae. because f
> has an old edit so flush to free WALs after random delay 92532ms
> 2017-07-24 18:45:14,201 INFO
> org.apache.hadoop.hbase.regionserver.HRegionServer:
> hbasetest2.domainname.com,60020,1500916375517-MemstoreFlusherChore requesting
> flush of testflush,,1500932649126.578c27d2eb7ef0ad437bf2ff38c053ae. because f
> has an old edit so flush to free WALs after random delay 238780ms
> 2017-07-24 18:45:24,195 INFO
> org.apache.hadoop.hbase.regionserver.HRegionServer:
> hbasetest2.domainname.com,60020,1500916375517-MemstoreFlusherChore requesting
> flush of testflush,,1500932649126.578c27d2eb7ef0ad437bf2ff38c053ae. because f
> has an old edit so flush to free WALs after random delay 35390ms
> 2017-07-24 18:45:33,362 INFO
> org.apache.hadoop.hbase.regionserver.HRegionServer:
> hbasetest2.domainname.com,60020,1500916375517-MemstoreFlusherChore requesting
> flush of
[jira] [Commented] (HBASE-18451) PeriodicMemstoreFlusher should inspect the queue before adding a delayed flush request
[
https://issues.apache.org/jira/browse/HBASE-18451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104426#comment-16104426
]
Anoop Sam John commented on HBASE-18451:
Done JMS.
> PeriodicMemstoreFlusher should inspect the queue before adding a delayed
> flush request
> --
>
> Key: HBASE-18451
> URL: https://issues.apache.org/jira/browse/HBASE-18451
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 2.0.0-alpha-1
>Reporter: Jean-Marc Spaggiari
>Assignee: nihed mbarek
>
> If you run a big job every 4 hours, impacting many tables (they have 150
> regions per server), ad the end all the regions might have some data to be
> flushed, and we want, after one hour, trigger a periodic flush. That's
> totally fine.
> Now, to avoid a flush storm, when we detect a region to be flushed, we add a
> "randomDelay" to the delayed flush, that way we spread them away.
> RANGE_OF_DELAY is 5 minutes. So we spread the flush over the next 5 minutes,
> which is very good.
> However, because we don't check if there is already a request in the queue,
> 10 seconds after, we create a new request, with a new randomDelay.
> If you generate a randomDelay every 10 seconds, at some point, you will end
> up having a small one, and the flush will be triggered almost immediatly.
> As a result, instead of spreading all the flush within the next 5 minutes,
> you end-up getting them all way more quickly. Like within the first minute.
> Which not only feed the queue to to many flush requests, but also defeats the
> purpose of the randomDelay.
> {code}
> @Override
> protected void chore() {
> final StringBuffer whyFlush = new StringBuffer();
> for (Region r : this.server.onlineRegions.values()) {
> if (r == null) continue;
> if (((HRegion)r).shouldFlush(whyFlush)) {
> FlushRequester requester = server.getFlushRequester();
> if (requester != null) {
> long randomDelay = RandomUtils.nextInt(RANGE_OF_DELAY) +
> MIN_DELAY_TIME;
> LOG.info(getName() + " requesting flush of " +
> r.getRegionInfo().getRegionNameAsString() + " because " +
> whyFlush.toString() +
> " after random delay " + randomDelay + "ms");
> //Throttle the flushes by putting a delay. If we don't throttle,
> and there
> //is a balanced write-load on the regions in a table, we might
> end up
> //overwhelming the filesystem with too many flushes at once.
> requester.requestDelayedFlush(r, randomDelay, false);
> }
> }
> }
> }
> {code}
> {code}
> 2017-07-24 18:44:33,338 INFO
> org.apache.hadoop.hbase.regionserver.HRegionServer:
> hbasetest2.domainname.com,60020,1500916375517-MemstoreFlusherChore requesting
> flush of testflush,,1500932649126.578c27d2eb7ef0ad437bf2ff38c053ae. because f
> has an old edit so flush to free WALs after random delay 270785ms
> 2017-07-24 18:44:43,328 INFO
> org.apache.hadoop.hbase.regionserver.HRegionServer:
> hbasetest2.domainname.com,60020,1500916375517-MemstoreFlusherChore requesting
> flush of testflush,,1500932649126.578c27d2eb7ef0ad437bf2ff38c053ae. because f
> has an old edit so flush to free WALs after random delay 200143ms
> 2017-07-24 18:44:53,954 INFO
> org.apache.hadoop.hbase.regionserver.HRegionServer:
> hbasetest2.domainname.com,60020,1500916375517-MemstoreFlusherChore requesting
> flush of testflush,,1500932649126.578c27d2eb7ef0ad437bf2ff38c053ae. because f
> has an old edit so flush to free WALs after random delay 191082ms
> 2017-07-24 18:45:03,528 INFO
> org.apache.hadoop.hbase.regionserver.HRegionServer:
> hbasetest2.domainname.com,60020,1500916375517-MemstoreFlusherChore requesting
> flush of testflush,,1500932649126.578c27d2eb7ef0ad437bf2ff38c053ae. because f
> has an old edit so flush to free WALs after random delay 92532ms
> 2017-07-24 18:45:14,201 INFO
> org.apache.hadoop.hbase.regionserver.HRegionServer:
> hbasetest2.domainname.com,60020,1500916375517-MemstoreFlusherChore requesting
> flush of testflush,,1500932649126.578c27d2eb7ef0ad437bf2ff38c053ae. because f
> has an old edit so flush to free WALs after random delay 238780ms
> 2017-07-24 18:45:24,195 INFO
> org.apache.hadoop.hbase.regionserver.HRegionServer:
> hbasetest2.domainname.com,60020,1500916375517-MemstoreFlusherChore requesting
> flush of testflush,,1500932649126.578c27d2eb7ef0ad437bf2ff38c053ae. because f
> has an old edit so flush to free WALs after random delay 35390ms
> 2017-07-24 18:45:33,362 INFO
> org.apache.hadoop.hbase.regionserver.HRegionServer:
> hbasetest2.domainname.com,60020,1500916375517-MemstoreFlusherChore requesting
> flush of
[jira] [Commented] (HBASE-18431) Mitigate compatibility concerns between branch-1.3 and branch-1.4
[
https://issues.apache.org/jira/browse/HBASE-18431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104421#comment-16104421
]
Anoop Sam John commented on HBASE-18431:
For 2.0 I don't think we have Public client APIs which take PB generated
classes as param. I forgot the id, but some old jira that we did, changed
this. Ideally we should not expose PB generated classes as params or return
types.
> Mitigate compatibility concerns between branch-1.3 and branch-1.4
> -
>
> Key: HBASE-18431
> URL: https://issues.apache.org/jira/browse/HBASE-18431
> Project: HBase
> Issue Type: Bug
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0, 1.5.0
>
> Attachments: HBASE-18431-branch-1.4.patch
>
>
> There are compatibility concerns with branch-1.4.
> {noformat}
> Library Name HBase
> Version #11.3.1
> Version #21.4.0-SNAPSHOT
> Subject Binary Compatibility
> Compatibility - 89.9%
> Added Methods - 305
> Removed Methods - 105
> Problems with Data Types
> High - 23
> Medium - 9
> Low - 21
> {noformat}
> {noformat}
> Library Name HBase
> Version #11.3.1
> Version #21.4.0-SNAPSHOT
> Subject Source Compatibility
> Compatibility- 86.5%
> Added Methods - 305
> Removed Methods - 105
> Problems with Data Types
> High - 88
> Medium - 0
> Low - 0
> Other Changes in Data Types- 25
> {noformat}
> This report includes HBASE-15816 which hasn't been committed yet. Otherwise
> it's current.
> I'm not generally concerned with added methods.
> The following methods have been added to Public/Evolving interface Table.
> Pointing them out in case it merits review.
> \\
> * Abstract method Table.getReadRpcTimeout ( ) has been added to this
> interface. No effect.
> * Abstract method Table.getWriteRpcTimeout ( ) has been added to this
> interface. No effect.
> * Abstract method Table.setReadRpcTimeout ( int ) has been added to this
> interface. No effect.
> * Abstract method Table.setWriteRpcTimeout ( int ) has been added to this
> interface.
> The Public/Evolving interface Admin has some signature changes equating to
> removed methods. I don't think this is allowed in a minor release.
> \\
> * Abstract method Admin.isSnapshotFinished ( HBaseProtos.SnapshotDescription
> ) has been removed from Admin.
> * Abstract method Admin.snapshot ( String, TableName,
> HBaseProtos.SnapshotDescription.Type ) has been removed from Admin.
> * Abstract method Admin.snapshot ( HBaseProtos.SnapshotDescription ) has been
> removed from Admin.
> * Abstract method Admin.takeSnapshotAsync ( HBaseProtos.SnapshotDescription
> ) has been removed from Admin.
> The LimitedPrivate(CONFIG) interface AsyncRpcClient has been removed. This
> change is debatable but I think we can allow it.
> \\
> * AsyncRpcClient has been removed
> The Public/Evolving class FastLongHistogram has been removed. I don't believe
> this change is allowed in a minor release.
> \\
> * FastLongHistogram has been removed
> Method signatures in LimitedPrivate(COPROC) interfaces MasterObserver and
> RegionObserver have changed, equating to removed methods. The first set of
> changes is due to move of SnapshotDescription from HBaseProtos to
> SnapshotProtos:
> \\
> * Abstract method MasterObserver.postCloneSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from
> MasterObserver.
> * Abstract method MasterObserver.postDeleteSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription ) has been removed from MasterObserver.
> * Abstract method MasterObserver.postListSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription ) has been removed from MasterObserver.
> * Abstract method MasterObserver.postRestoreSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from
> MasterObserver.
> * Abstract method MasterObserver.postSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from
> MasterObserver.
> * Abstract method MasterObserver.preCloneSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from
> MasterObserver.
> * Abstract method MasterObserver.preDeleteSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription ) has been removed from MasterObserver.
> * Abstract method MasterObserver.preListSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription ) has been removed from MasterObserver.
> * Abstract method MasterObserver.preRestoreSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from
> MasterObserver.
> * Abstract method
[jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104416#comment-16104416 ] Anoop Sam John commented on HBASE-18446: [~chrajeshbab...@gmail.com] Can you tell us the exact needs and usage of StoreFileReader in local index? Sorry I forgot those details totally. > Mark StoreFileScanner as IA.Private > --- > > Key: HBASE-18446 > URL: https://issues.apache.org/jira/browse/HBASE-18446 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang > Fix For: 2.0.0, 3.0.0, 2.0.0-alpha-2 > > > Do not see any reason why it is marked as IA.LimitedPrivate. It is not > referenced in any CPs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18395) Update clock on region open and close
[
https://issues.apache.org/jira/browse/HBASE-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104411#comment-16104411
]
Hadoop QA commented on HBASE-18395:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 13m
50s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 13 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m
30s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
4s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
12s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 17m
20s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
0s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
28s{color} | {color:red} hbase-protocol-shaded in HBASE-14070.HLC has 27 extant
Findbugs warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m
27s{color} | {color:red} hbase-server in HBASE-14070.HLC has 9 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
33s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
23s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 18m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 26 line(s) that end in whitespace. Use
git apply --whitespace=fix <>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
43m 12s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
2m 5s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
58s{color} | {color:red} hbase-server generated 1 new + 9 unchanged - 0 fixed =
10 total (was 9) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
44s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
29s{color} | {color:green} hbase-protocol in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
24s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}100m 35s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
58s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}245m 34s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-server |
| | There is an apparent infinite recursive loop in
[jira] [Commented] (HBASE-18185) IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails with AssertionError
[ https://issues.apache.org/jira/browse/HBASE-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104389#comment-16104389 ] Hudson commented on HBASE-18185: FAILURE: Integrated in Jenkins build HBase-2.0 #246 (See [https://builds.apache.org/job/HBase-2.0/246/]) HBASE-18185 IntegrationTestTimeBoundedRequestsWithRegionReplicas (appy: rev 34a1ae875c216dd601a345e534eb489255c2421b) * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyConstants.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/UnbalanceKillAndRebalanceAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/UnbalanceMonkeyFactory.java > IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails > with AssertionError > --- > > Key: HBASE-18185 > URL: https://issues.apache.org/jira/browse/HBASE-18185 > Project: HBase > Issue Type: Bug > Components: integration tests >Affects Versions: 2.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18185-branch-1.v3.patch, > HBASE-18185-branch-1.v4.patch, HBASE-18185-branch-1.v5.patch, > HBASE-18185.v3.patch, HBASE-18185.v4.patch, HBASE-18185.v5.patch > > > We got the following error: > Exception in thread "main" java.lang.AssertionError: Verification failed with > error code 1 > at org.junit.Assert.fail(Assert.java:88) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.runIngestTest(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:217) > at > org.apache.hadoop.hbase.IntegrationTestIngest.internalRunIngestTest(IntegrationTestIngest.java:123) > at > org.apache.hadoop.hbase.IntegrationTestIngest.runTestFromCommandLine(IntegrationTestIngest.java:106) > at > org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:123) > at > org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.main(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:362) > The reason why we got it because another assertion fails in > UnbalanceKillAndRebalanceAction: > Exception in thread "Thread-57" java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertTrue(Assert.java:52) > at > org.apache.hadoop.hbase.chaos.actions.UnbalanceKillAndRebalanceAction.perform(UnbalanceKillAndRebalanceAction.java:60) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18185) IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails with AssertionError
[ https://issues.apache.org/jira/browse/HBASE-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104383#comment-16104383 ] Hudson commented on HBASE-18185: SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #223 (See [https://builds.apache.org/job/HBase-1.3-JDK8/223/]) HBASE-18185 IntegrationTestTimeBoundedRequestsWithRegionReplicas (appy: rev 488ae4be658f8a968ca6a9a530e0606f93dc5028) * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/UnbalanceMonkeyFactory.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyConstants.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/UnbalanceKillAndRebalanceAction.java > IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails > with AssertionError > --- > > Key: HBASE-18185 > URL: https://issues.apache.org/jira/browse/HBASE-18185 > Project: HBase > Issue Type: Bug > Components: integration tests >Affects Versions: 2.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18185-branch-1.v3.patch, > HBASE-18185-branch-1.v4.patch, HBASE-18185-branch-1.v5.patch, > HBASE-18185.v3.patch, HBASE-18185.v4.patch, HBASE-18185.v5.patch > > > We got the following error: > Exception in thread "main" java.lang.AssertionError: Verification failed with > error code 1 > at org.junit.Assert.fail(Assert.java:88) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.runIngestTest(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:217) > at > org.apache.hadoop.hbase.IntegrationTestIngest.internalRunIngestTest(IntegrationTestIngest.java:123) > at > org.apache.hadoop.hbase.IntegrationTestIngest.runTestFromCommandLine(IntegrationTestIngest.java:106) > at > org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:123) > at > org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.main(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:362) > The reason why we got it because another assertion fails in > UnbalanceKillAndRebalanceAction: > Exception in thread "Thread-57" java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertTrue(Assert.java:52) > at > org.apache.hadoop.hbase.chaos.actions.UnbalanceKillAndRebalanceAction.perform(UnbalanceKillAndRebalanceAction.java:60) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18374) RegionServer Metrics improvements
[ https://issues.apache.org/jira/browse/HBASE-18374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104372#comment-16104372 ] Chia-Ping Tsai commented on HBASE-18374: bq. we go the same way for a single put and batched puts (multi->dobatchmutate), hence the current behavior. The async client calls the mutate() for a single put. (see RawAsyncTableImpl#put) > RegionServer Metrics improvements > - > > Key: HBASE-18374 > URL: https://issues.apache.org/jira/browse/HBASE-18374 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 3.0.0 > > Attachments: HBASE-18374.branch-1.001.patch, > HBASE-18374.branch-1.001.patch, HBASE-18374.branch-1.002.patch, > HBASE-18374.master.001.patch, HBASE-18374.master.002.patch, > HBASE-18374.master.003.patch, HBASE-18374.master.004.patch > > > At the RS level we have latency metrics for mutate/puts and deletes that are > updated per batch (ie. at the end of entire batchop if it contains put/delete > update the respective metric) in contrast with append/increment/get metrics > that are updated per op. This is a bit ambiguous since the delete and put > metrics are updated for multi row mutations that happen to contain a > put/delete. We should rename the metric(eg. delete_batch)/add better > description. Also we should add metrics for single delete client operations > that come through RSRpcServer.mutate path. We should also add metrics for > checkAndPut and checkAndDelete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17131) Avoid livelock caused by HRegion#processRowsWithLocks
[
https://issues.apache.org/jira/browse/HBASE-17131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-17131:
---
Attachment: HBASE-17131.branch-1.2.v0.patch
> Avoid livelock caused by HRegion#processRowsWithLocks
> -
>
> Key: HBASE-17131
> URL: https://issues.apache.org/jira/browse/HBASE-17131
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 2.0.0, 1.4.0, 1.3.1, 1.2.6
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.2.7
>
> Attachments: HBASE-17131.branch-1.2.v0.patch,
> HBASE-17131.branch-1.3.v0.patch, HBASE-17131.branch-1.v0.patch,
> HBASE-17131.v0.patch
>
>
> {code:title=HRegion.java|borderStyle=solid}
> try {
> // STEP 2. Acquire the row lock(s)
> acquiredRowLocks = new ArrayList(rowsToLock.size());
> for (byte[] row : rowsToLock) {
> // Attempt to lock all involved rows, throw if any lock times out
> // use a writer lock for mixed reads and writes
> acquiredRowLocks.add(getRowLockInternal(row, false));
> }
> // STEP 3. Region lock
> lock(this.updatesLock.readLock(), acquiredRowLocks.size() == 0 ? 1 :
> acquiredRowLocks.size());
> locked = true;
> boolean success = false;
> long now = EnvironmentEdgeManager.currentTime();
> try {
> {code}
> We should lock all involved rows in the second try-finally. Otherwise, we
> won’t release the previous locks if any subsequent lock times out.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-18468) Move precommit job to use jenkinsfile
Sean Busbey created HBASE-18468: --- Summary: Move precommit job to use jenkinsfile Key: HBASE-18468 URL: https://issues.apache.org/jira/browse/HBASE-18468 Project: HBase Issue Type: Task Components: community, test Reporter: Sean Busbey In the interests of 1) better tracking when we change our test infra and 2) making it more accessible to those who don't have logins on builds.a.o, we should switch out our current precommit job for one that is defined via a Jenkinsfile. Could also take the opportunity to get our precommit stuff into a common subfolder with a README. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17131) Avoid livelock caused by HRegion#processRowsWithLocks
[
https://issues.apache.org/jira/browse/HBASE-17131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-17131:
---
Status: Patch Available (was: Open)
> Avoid livelock caused by HRegion#processRowsWithLocks
> -
>
> Key: HBASE-17131
> URL: https://issues.apache.org/jira/browse/HBASE-17131
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 1.2.6, 1.3.1, 2.0.0, 1.4.0
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.2.7
>
> Attachments: HBASE-17131.branch-1.2.v0.patch,
> HBASE-17131.branch-1.3.v0.patch, HBASE-17131.branch-1.v0.patch,
> HBASE-17131.v0.patch
>
>
> {code:title=HRegion.java|borderStyle=solid}
> try {
> // STEP 2. Acquire the row lock(s)
> acquiredRowLocks = new ArrayList(rowsToLock.size());
> for (byte[] row : rowsToLock) {
> // Attempt to lock all involved rows, throw if any lock times out
> // use a writer lock for mixed reads and writes
> acquiredRowLocks.add(getRowLockInternal(row, false));
> }
> // STEP 3. Region lock
> lock(this.updatesLock.readLock(), acquiredRowLocks.size() == 0 ? 1 :
> acquiredRowLocks.size());
> locked = true;
> boolean success = false;
> long now = EnvironmentEdgeManager.currentTime();
> try {
> {code}
> We should lock all involved rows in the second try-finally. Otherwise, we
> won’t release the previous locks if any subsequent lock times out.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-17131) Avoid livelock caused by HRegion#processRowsWithLocks
[
https://issues.apache.org/jira/browse/HBASE-17131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-17131:
---
Status: Open (was: Patch Available)
> Avoid livelock caused by HRegion#processRowsWithLocks
> -
>
> Key: HBASE-17131
> URL: https://issues.apache.org/jira/browse/HBASE-17131
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 1.2.6, 1.3.1, 2.0.0, 1.4.0
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.2.7
>
> Attachments: HBASE-17131.branch-1.3.v0.patch,
> HBASE-17131.branch-1.v0.patch, HBASE-17131.v0.patch
>
>
> {code:title=HRegion.java|borderStyle=solid}
> try {
> // STEP 2. Acquire the row lock(s)
> acquiredRowLocks = new ArrayList(rowsToLock.size());
> for (byte[] row : rowsToLock) {
> // Attempt to lock all involved rows, throw if any lock times out
> // use a writer lock for mixed reads and writes
> acquiredRowLocks.add(getRowLockInternal(row, false));
> }
> // STEP 3. Region lock
> lock(this.updatesLock.readLock(), acquiredRowLocks.size() == 0 ? 1 :
> acquiredRowLocks.size());
> locked = true;
> boolean success = false;
> long now = EnvironmentEdgeManager.currentTime();
> try {
> {code}
> We should lock all involved rows in the second try-finally. Otherwise, we
> won’t release the previous locks if any subsequent lock times out.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (HBASE-16728) Add hadoop.profile=3.0 pass to precommit checks.
[ https://issues.apache.org/jira/browse/HBASE-16728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-16728. - Resolution: Fixed Assignee: Jonathan Hsieh this got done at some point. > Add hadoop.profile=3.0 pass to precommit checks. > > > Key: HBASE-16728 > URL: https://issues.apache.org/jira/browse/HBASE-16728 > Project: HBase > Issue Type: Task > Components: build, hadoop3 >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > > once we get hadoop3 profile compiling (mvn test -DskipTests) and passing > licensing muster (mvn install), we should add precommit checks to prevent > regressions in these categories -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18467) nightly job needs to comment on jira
[ https://issues.apache.org/jira/browse/HBASE-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104355#comment-16104355 ] Sean Busbey commented on HBASE-18467: - maybe rephrase as "nightly job needs to communicate results proactively" and expand this to include emailing dev@ > nightly job needs to comment on jira > > > Key: HBASE-18467 > URL: https://issues.apache.org/jira/browse/HBASE-18467 > Project: HBase > Issue Type: Improvement > Components: community, test >Reporter: Sean Busbey >Priority: Critical > > follow on from HBASE-18147, need a post action that pings all newly-committed > jiras with result of the branch build -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18185) IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails with AssertionError
[ https://issues.apache.org/jira/browse/HBASE-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104346#comment-16104346 ] Hudson commented on HBASE-18185: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3447 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3447/]) HBASE-18185 IntegrationTestTimeBoundedRequestsWithRegionReplicas (appy: rev c5d3de0cd40c75334a2ccd0c953eb44dce3dbb2f) * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/UnbalanceKillAndRebalanceAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyConstants.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/UnbalanceMonkeyFactory.java > IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails > with AssertionError > --- > > Key: HBASE-18185 > URL: https://issues.apache.org/jira/browse/HBASE-18185 > Project: HBase > Issue Type: Bug > Components: integration tests >Affects Versions: 2.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18185-branch-1.v3.patch, > HBASE-18185-branch-1.v4.patch, HBASE-18185-branch-1.v5.patch, > HBASE-18185.v3.patch, HBASE-18185.v4.patch, HBASE-18185.v5.patch > > > We got the following error: > Exception in thread "main" java.lang.AssertionError: Verification failed with > error code 1 > at org.junit.Assert.fail(Assert.java:88) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.runIngestTest(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:217) > at > org.apache.hadoop.hbase.IntegrationTestIngest.internalRunIngestTest(IntegrationTestIngest.java:123) > at > org.apache.hadoop.hbase.IntegrationTestIngest.runTestFromCommandLine(IntegrationTestIngest.java:106) > at > org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:123) > at > org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.main(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:362) > The reason why we got it because another assertion fails in > UnbalanceKillAndRebalanceAction: > Exception in thread "Thread-57" java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertTrue(Assert.java:52) > at > org.apache.hadoop.hbase.chaos.actions.UnbalanceKillAndRebalanceAction.perform(UnbalanceKillAndRebalanceAction.java:60) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Work started] (HBASE-18426) nightly job should use independent stages to check supported jdks
[ https://issues.apache.org/jira/browse/HBASE-18426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-18426 started by Sean Busbey. --- > nightly job should use independent stages to check supported jdks > - > > Key: HBASE-18426 > URL: https://issues.apache.org/jira/browse/HBASE-18426 > Project: HBase > Issue Type: Improvement > Components: community, test >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Critical > > follow on from HBASE-18147 to handle the lack of multijdk support for unit > tests. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18467) nightly job needs to comment on jira
Sean Busbey created HBASE-18467: --- Summary: nightly job needs to comment on jira Key: HBASE-18467 URL: https://issues.apache.org/jira/browse/HBASE-18467 Project: HBase Issue Type: Improvement Components: community, test Reporter: Sean Busbey Priority: Critical follow on from HBASE-18147, need a post action that pings all newly-committed jiras with result of the branch build -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16734) add hadoop 3.0.0-alpha1 to post commit checks
[ https://issues.apache.org/jira/browse/HBASE-16734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104334#comment-16104334 ] Sean Busbey commented on HBASE-16734: - I think this will be obviated by the new nightly-via-yetus stuff > add hadoop 3.0.0-alpha1 to post commit checks > - > > Key: HBASE-16734 > URL: https://issues.apache.org/jira/browse/HBASE-16734 > Project: HBase > Issue Type: Improvement > Components: build >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Priority: Blocker > Fix For: 2.0.0 > > > similar to HBASE-16733, we also need the nightly build matrix to cover hte > hadoop 3 profile. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18422) Fix TestRegionRebalancing
[
https://issues.apache.org/jira/browse/HBASE-18422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104320#comment-16104320
]
Hadoop QA commented on HBASE-18422:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
31m 52s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m
29s{color} | {color:red} hbase-server generated 1 new + 0 unchanged - 0 fixed =
1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 89m 22s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
25s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}137m 35s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-server |
| | org.apache.hadoop.hbase.master.HMaster.augmentAssignments(Map) makes
inefficient use of keySet iterator instead of entrySet iterator At
HMaster.java:keySet iterator instead of entrySet iterator At
HMaster.java:[line 1485] |
| Failed junit tests | hadoop.hbase.master.TestMasterMetrics |
| Timed out junit tests |
org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure |
| | org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence |
| | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
| | org.apache.hadoop.hbase.client.TestFromClientSide |
| | org.apache.hadoop.hbase.client.TestMultipleTimestamps |
| | org.apache.hadoop.hbase.client.TestAsyncReplicationAdminApi |
| | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
| | org.apache.hadoop.hbase.master.TestAssignmentManagerMetrics |
| | org.apache.hadoop.hbase.master.assignment.TestAssignmentManager |
| | org.apache.hadoop.hbase.TestHBaseTestingUtility |
| | org.apache.hadoop.hbase.client.TestAsyncProcedureAdminApi |
|
[jira] [Commented] (HBASE-18185) IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails with AssertionError
[ https://issues.apache.org/jira/browse/HBASE-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104318#comment-16104318 ] Hudson commented on HBASE-18185: SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #169 (See [https://builds.apache.org/job/HBase-1.2-JDK8/169/]) HBASE-18185 IntegrationTestTimeBoundedRequestsWithRegionReplicas (appy: rev 2e7f55fe3ed5f0602f74c7d6205ee19d0c836851) * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/UnbalanceMonkeyFactory.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyConstants.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/UnbalanceKillAndRebalanceAction.java > IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails > with AssertionError > --- > > Key: HBASE-18185 > URL: https://issues.apache.org/jira/browse/HBASE-18185 > Project: HBase > Issue Type: Bug > Components: integration tests >Affects Versions: 2.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18185-branch-1.v3.patch, > HBASE-18185-branch-1.v4.patch, HBASE-18185-branch-1.v5.patch, > HBASE-18185.v3.patch, HBASE-18185.v4.patch, HBASE-18185.v5.patch > > > We got the following error: > Exception in thread "main" java.lang.AssertionError: Verification failed with > error code 1 > at org.junit.Assert.fail(Assert.java:88) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.runIngestTest(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:217) > at > org.apache.hadoop.hbase.IntegrationTestIngest.internalRunIngestTest(IntegrationTestIngest.java:123) > at > org.apache.hadoop.hbase.IntegrationTestIngest.runTestFromCommandLine(IntegrationTestIngest.java:106) > at > org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:123) > at > org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.main(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:362) > The reason why we got it because another assertion fails in > UnbalanceKillAndRebalanceAction: > Exception in thread "Thread-57" java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertTrue(Assert.java:52) > at > org.apache.hadoop.hbase.chaos.actions.UnbalanceKillAndRebalanceAction.perform(UnbalanceKillAndRebalanceAction.java:60) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private
[
https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104314#comment-16104314
]
Duo Zhang commented on HBASE-18446:
---
OK, seems there are lots of conflicts...{{StoreFileReader}} is marked as
IA.Private when it was extracted out from StoreFile...
And it is really a pain that coprocessor users need to extend these
implementation classes. [~chrajeshbab...@gmail.com] and [~samarthjain], is it
possible to implement the index based StoreFileReader by wrapping the original
StoreFileReader other than extending it?
Thanks.
> Mark StoreFileScanner as IA.Private
> ---
>
> Key: HBASE-18446
> URL: https://issues.apache.org/jira/browse/HBASE-18446
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Duo Zhang
> Fix For: 2.0.0, 3.0.0, 2.0.0-alpha-2
>
>
> Do not see any reason why it is marked as IA.LimitedPrivate. It is not
> referenced in any CPs.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18185) IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails with AssertionError
[ https://issues.apache.org/jira/browse/HBASE-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104303#comment-16104303 ] Hudson commented on HBASE-18185: FAILURE: Integrated in Jenkins build HBase-1.4 #825 (See [https://builds.apache.org/job/HBase-1.4/825/]) HBASE-18185 IntegrationTestTimeBoundedRequestsWithRegionReplicas (appy: rev 0053cb967b3178cdfff88e50af3f017fa7509118) * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/UnbalanceKillAndRebalanceAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/UnbalanceMonkeyFactory.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyConstants.java > IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails > with AssertionError > --- > > Key: HBASE-18185 > URL: https://issues.apache.org/jira/browse/HBASE-18185 > Project: HBase > Issue Type: Bug > Components: integration tests >Affects Versions: 2.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18185-branch-1.v3.patch, > HBASE-18185-branch-1.v4.patch, HBASE-18185-branch-1.v5.patch, > HBASE-18185.v3.patch, HBASE-18185.v4.patch, HBASE-18185.v5.patch > > > We got the following error: > Exception in thread "main" java.lang.AssertionError: Verification failed with > error code 1 > at org.junit.Assert.fail(Assert.java:88) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.runIngestTest(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:217) > at > org.apache.hadoop.hbase.IntegrationTestIngest.internalRunIngestTest(IntegrationTestIngest.java:123) > at > org.apache.hadoop.hbase.IntegrationTestIngest.runTestFromCommandLine(IntegrationTestIngest.java:106) > at > org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:123) > at > org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.main(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:362) > The reason why we got it because another assertion fails in > UnbalanceKillAndRebalanceAction: > Exception in thread "Thread-57" java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertTrue(Assert.java:52) > at > org.apache.hadoop.hbase.chaos.actions.UnbalanceKillAndRebalanceAction.perform(UnbalanceKillAndRebalanceAction.java:60) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18449) Fix client.locking.TestEntityLocks#testHeartbeatException
[
https://issues.apache.org/jira/browse/HBASE-18449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Appy updated HBASE-18449:
-
Summary: Fix client.locking.TestEntityLocks#testHeartbeatException (was:
Fix client.locking.TestEntityLocks)
> Fix client.locking.TestEntityLocks#testHeartbeatException
> -
>
> Key: HBASE-18449
> URL: https://issues.apache.org/jira/browse/HBASE-18449
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0, 2.0.0-alpha-1
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Minor
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18449.v0.patch
>
>
> {noformat}
> Wanted but not invoked:
> abortable.abort(
> ,
> isA(org.apache.hadoop.hbase.HBaseIOException)
> );
> -> at
> org.apache.hadoop.hbase.client.locking.TestEntityLocks.testHeartbeatException(TestEntityLocks.java:195)
> Actually, there were zero interactions with this mock.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18376) Flaky exclusion doesn't appear to work in precommit
[
https://issues.apache.org/jira/browse/HBASE-18376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104255#comment-16104255
]
Hadoop QA commented on HBASE-18376:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 13m
7s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
29m 30s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
13s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 52m 22s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18376 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12879271/HBASE-18376.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 0fba93309813 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / c5d3de0 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7821/testReport/ |
| modules | C: hbase-common U: hbase-common |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7821/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Flaky exclusion doesn't appear to work in precommit
> ---
>
> Key: HBASE-18376
> URL: https://issues.apache.org/jira/browse/HBASE-18376
> Project: HBase
> Issue Type: Bug
> Components: community, test
>Reporter: Sean Busbey
>
[jira] [Updated] (HBASE-18376) Flaky exclusion doesn't appear to work in precommit
[ https://issues.apache.org/jira/browse/HBASE-18376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-18376: - Resolution: Fixed Assignee: Appy Status: Resolved (was: Patch Available) > Flaky exclusion doesn't appear to work in precommit > --- > > Key: HBASE-18376 > URL: https://issues.apache.org/jira/browse/HBASE-18376 > Project: HBase > Issue Type: Bug > Components: community, test >Reporter: Sean Busbey >Assignee: Appy >Priority: Critical > Attachments: HBASE-18376.master.001.patch, > HBASE-18376.master.002.patch > > > Yesterday we started defaulting the precommit parameter for the flaky test > list to point to the job on builds.a.o. Looks like the personality is > ignoring it. > example build that's marked to keep: > https://builds.apache.org/job/PreCommit-HBASE-Build/7646/ > (search for 'Running unit tests' to skip to the right part of the console') > should add some more debug output in there too. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18376) Flaky exclusion doesn't appear to work in precommit
[ https://issues.apache.org/jira/browse/HBASE-18376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104254#comment-16104254 ] Appy commented on HBASE-18376: -- Successful run: https://builds.apache.org/job/PreCommit-HBASE-Build/7820/console It's excluding flaky tests in mvn command line. Also, not seeing any license issues in the last run, so should be fine to call this one fixed. > Flaky exclusion doesn't appear to work in precommit > --- > > Key: HBASE-18376 > URL: https://issues.apache.org/jira/browse/HBASE-18376 > Project: HBase > Issue Type: Bug > Components: community, test >Reporter: Sean Busbey >Priority: Critical > Attachments: HBASE-18376.master.001.patch, > HBASE-18376.master.002.patch > > > Yesterday we started defaulting the precommit parameter for the flaky test > list to point to the job on builds.a.o. Looks like the personality is > ignoring it. > example build that's marked to keep: > https://builds.apache.org/job/PreCommit-HBASE-Build/7646/ > (search for 'Running unit tests' to skip to the right part of the console') > should add some more debug output in there too. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18376) Flaky exclusion doesn't appear to work in precommit
[
https://issues.apache.org/jira/browse/HBASE-18376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104228#comment-16104228
]
Hadoop QA commented on HBASE-18376:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
32m 9s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
16s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 42m 47s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18376 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12879271/HBASE-18376.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 97b7b20f58d9 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / c5d3de0 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7820/testReport/ |
| modules | C: hbase-common U: hbase-common |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7820/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Flaky exclusion doesn't appear to work in precommit
> ---
>
> Key: HBASE-18376
> URL: https://issues.apache.org/jira/browse/HBASE-18376
> Project: HBase
> Issue Type: Bug
> Components: community, test
>Reporter: Sean Busbey
>
[jira] [Commented] (HBASE-18362) hbck should not report split replica parent region from meta as errors
[
https://issues.apache.org/jira/browse/HBASE-18362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104208#comment-16104208
]
Hudson commented on HBASE-18362:
SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #222 (See
[https://builds.apache.org/job/HBase-1.3-JDK8/222/])
HBASE-18362 hbck should not report split replica parent region from meta
(esteban: rev c23b7c9c80d7663741b598f221cca8b4eb74033c)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
> hbck should not report split replica parent region from meta as errors
> ---
>
> Key: HBASE-18362
> URL: https://issues.apache.org/jira/browse/HBASE-18362
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Affects Versions: 1.4.0, 2.0.0-alpha-1
>Reporter: huaxiang sun
>Assignee: huaxiang sun
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.4.1, 1.2.7
>
> Attachments: HBASE-18362.001.patch, HBASE-18362-branch-1-v001.patch,
> HBASE-18362-branch-1-v002.patch
>
>
> As described in HBASE-18247, replica region shows up as key in meta table. We
> need to find out the code/logic introducing the issue. I suspected that it
> was introduced by hbck, but last round of code review did not find anything.
> Create jira to track this effort.
> Before Catalog Janitor cleans up the split parent region from meta, hbck is
> reporting split replica parent regions as errors and if -fixSplitParents is
> used, the replica parent region will show up as key in meta table. It needs
> to be avoided.
> {code}
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:regioninfo,
> timestamp=1500931787651, value={ENCODED => e10212c467b78104c911ea06c102ece0,
> NAME => 't1,,1500931628959.e10212c467b78104c911ea
> . 06c102ece0.', STARTKEY =>
> '', ENDKEY => '', OFFLINE => true, SPLIT => true}
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen, timestamp=1500931742552,
> value=\x00\x00\x00\x00\x00\x00\x00\x05
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen_0001, timestamp=1500931742492,
> value=\x00\x00\x00\x00\x00\x00\x00\x02
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server,
> timestamp=1500931742552, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server_0001,
> timestamp=1500931742492, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode, timestamp=1500931742552, value=1500931737158
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode_0001, timestamp=1500931742492,
> value=\x00\x00\x01]v\x80\xC6F
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:splitA,
> timestamp=1500931787651, value={ENCODED => dc471b6d9c0c2c451ee4c6d134e50ccc,
> NAME =>
[jira] [Comment Edited] (HBASE-18466) [C++] Support handling exception in RpcTestServer
[ https://issues.apache.org/jira/browse/HBASE-18466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104206#comment-16104206 ] Xiaobing Zhou edited comment on HBASE-18466 at 7/28/17 12:33 AM: - Posted v0: # changed RpcTestService and RpcTestServerSerializeHandler for the purpose # implemented error in test_rpc_service.proto # added unit test for it was (Author: xiaobingo): Posted v0: # changed RpcTestService and RpcTestServerSerializeHandler for the purpose # implemented error in test_rpc_service.proto > [C++] Support handling exception in RpcTestServer > - > > Key: HBASE-18466 > URL: https://issues.apache.org/jira/browse/HBASE-18466 > Project: HBase > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HBASE-18466.000.patch > > > In order simulate various error from servers, exceptions should be handled > properly. The idea is to zip exception into hbase::Response in > RpcTestService, and Serialize response to folly::IOBuf and write it down the > pipeline. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18466) [C++] Support handling exception in RpcTestServer
[ https://issues.apache.org/jira/browse/HBASE-18466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104206#comment-16104206 ] Xiaobing Zhou commented on HBASE-18466: --- Posted v0: # changed RpcTestService and RpcTestServerSerializeHandler for the purpose # implemented error in test_rpc_service.proto > [C++] Support handling exception in RpcTestServer > - > > Key: HBASE-18466 > URL: https://issues.apache.org/jira/browse/HBASE-18466 > Project: HBase > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HBASE-18466.000.patch > > > In order simulate various error from servers, exceptions should be handled > properly. The idea is to zip exception into hbase::Response in > RpcTestService, and Serialize response to folly::IOBuf and write it down the > pipeline. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18466) [C++] Support handling exception in RpcTestServer
[ https://issues.apache.org/jira/browse/HBASE-18466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Zhou updated HBASE-18466: -- Attachment: HBASE-18466.000.patch > [C++] Support handling exception in RpcTestServer > - > > Key: HBASE-18466 > URL: https://issues.apache.org/jira/browse/HBASE-18466 > Project: HBase > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HBASE-18466.000.patch > > > In order simulate various error from servers, exceptions should be handled > properly. The idea is to zip exception into hbase::Response in > RpcTestService, and Serialize response to folly::IOBuf and write it down the > pipeline. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18362) hbck should not report split replica parent region from meta as errors
[
https://issues.apache.org/jira/browse/HBASE-18362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104171#comment-16104171
]
Hudson commented on HBASE-18362:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3446 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/3446/])
HBASE-18362 hbck should not report split replica parent region from meta
(esteban: rev 9a1661832d5f515df2addf706d0e249a8a2bb8cb)
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsckReplicas.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
> hbck should not report split replica parent region from meta as errors
> ---
>
> Key: HBASE-18362
> URL: https://issues.apache.org/jira/browse/HBASE-18362
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Affects Versions: 1.4.0, 2.0.0-alpha-1
>Reporter: huaxiang sun
>Assignee: huaxiang sun
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.4.1, 1.2.7
>
> Attachments: HBASE-18362.001.patch, HBASE-18362-branch-1-v001.patch,
> HBASE-18362-branch-1-v002.patch
>
>
> As described in HBASE-18247, replica region shows up as key in meta table. We
> need to find out the code/logic introducing the issue. I suspected that it
> was introduced by hbck, but last round of code review did not find anything.
> Create jira to track this effort.
> Before Catalog Janitor cleans up the split parent region from meta, hbck is
> reporting split replica parent regions as errors and if -fixSplitParents is
> used, the replica parent region will show up as key in meta table. It needs
> to be avoided.
> {code}
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:regioninfo,
> timestamp=1500931787651, value={ENCODED => e10212c467b78104c911ea06c102ece0,
> NAME => 't1,,1500931628959.e10212c467b78104c911ea
> . 06c102ece0.', STARTKEY =>
> '', ENDKEY => '', OFFLINE => true, SPLIT => true}
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen, timestamp=1500931742552,
> value=\x00\x00\x00\x00\x00\x00\x00\x05
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen_0001, timestamp=1500931742492,
> value=\x00\x00\x00\x00\x00\x00\x00\x02
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server,
> timestamp=1500931742552, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server_0001,
> timestamp=1500931742492, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode, timestamp=1500931742552, value=1500931737158
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode_0001, timestamp=1500931742492,
> value=\x00\x00\x01]v\x80\xC6F
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:splitA,
> timestamp=1500931787651, value={ENCODED => dc471b6d9c0c2c451ee4c6d134e50ccc,
> NAME =>
[jira] [Commented] (HBASE-17839) "Data Model" section: Table 1 has only 5 data rows instead 6.
[ https://issues.apache.org/jira/browse/HBASE-17839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104170#comment-16104170 ] Hudson commented on HBASE-17839: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3446 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3446/]) HBASE-17839 fixed missing column in table 1 from section "Data Model" of (busbey: rev 3536c58afb6ebccd8f9a31beb17d16e74c1ac834) * (edit) src/main/asciidoc/_chapters/datamodel.adoc > "Data Model" section: Table 1 has only 5 data rows instead 6. > - > > Key: HBASE-17839 > URL: https://issues.apache.org/jira/browse/HBASE-17839 > Project: HBase > Issue Type: Bug > Components: documentation >Affects Versions: 2.0.0 >Reporter: Evgeny Kincharov >Assignee: Evgeny Kincharov >Priority: Trivial > Labels: documentation, patch-available, trivial > Fix For: 3.0.0 > > Attachments: 823ac3e0e619f7531513efe6e4b43a6fea7437c6.patch > > > The table from http://hbase.apache.org/book.html#conceptual.view has only 5 > data rows. > Originally intended that there will be 6: > https://raw.githubusercontent.com/apache/hbase/master/src/main/asciidoc/_chapters/datamodel.adoc -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18127) Allow regionobserver to optionally skip postPut/postDelete when postBatchMutate was called
[ https://issues.apache.org/jira/browse/HBASE-18127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104167#comment-16104167 ] Andrew Purtell commented on HBASE-18127: Aside from functional improvements, the big concern is interface compatibility impact. I like how the only interface that CP implementers might use that you have changed is the LP(Coproc)/Evolving interface RowProcessor. OperationCoprocessorContext could just be called OperationContext? Do we need SimpleOperationCoprocessorContext? Will there ever be another kind? Consider making OperationContext a class, like ObserverContext is a class. > Allow regionobserver to optionally skip postPut/postDelete when > postBatchMutate was called > -- > > Key: HBASE-18127 > URL: https://issues.apache.org/jira/browse/HBASE-18127 > Project: HBase > Issue Type: New Feature >Reporter: Lars Hofhansl >Assignee: Abhishek Singh Chouhan > Attachments: HBASE-18127.master.001.patch > > > Right now a RegionObserver can only statically implement one or the other. In > scenarios where we need to work sometimes on the single postPut and > postDelete hooks and sometimes on the batchMutate hooks, there is currently > no place to convey this information to the single hooks. I.e. the work has > been done in the batch, skip the single hooks. > There are various solutions: > 1. Allow some state to be passed _per operation_. > 2. Remove the single hooks and always only call batch hooks (with a default > wrapper for the single hooks). > 3. more? > [~apurtell], what we had discussed a few days back. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18466) [C++] Support handling exception in RpcTestServer
Xiaobing Zhou created HBASE-18466: - Summary: [C++] Support handling exception in RpcTestServer Key: HBASE-18466 URL: https://issues.apache.org/jira/browse/HBASE-18466 Project: HBase Issue Type: Sub-task Reporter: Xiaobing Zhou Assignee: Xiaobing Zhou In order simulate various error from servers, exceptions should be handled properly. The idea is to zip exception into hbase::Response in RpcTestService, and Serialize response to folly::IOBuf and write it down the pipeline. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18376) Flaky exclusion doesn't appear to work in precommit
[ https://issues.apache.org/jira/browse/HBASE-18376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-18376: - Attachment: HBASE-18376.master.002.patch > Flaky exclusion doesn't appear to work in precommit > --- > > Key: HBASE-18376 > URL: https://issues.apache.org/jira/browse/HBASE-18376 > Project: HBase > Issue Type: Bug > Components: community, test >Reporter: Sean Busbey >Priority: Critical > Attachments: HBASE-18376.master.001.patch, > HBASE-18376.master.002.patch > > > Yesterday we started defaulting the precommit parameter for the flaky test > list to point to the job on builds.a.o. Looks like the personality is > ignoring it. > example build that's marked to keep: > https://builds.apache.org/job/PreCommit-HBASE-Build/7646/ > (search for 'Running unit tests' to skip to the right part of the console') > should add some more debug output in there too. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-18127) Allow regionobserver to optionally skip postPut/postDelete when postBatchMutate was called
[ https://issues.apache.org/jira/browse/HBASE-18127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell reassigned HBASE-18127: -- Assignee: Abhishek Singh Chouhan > Allow regionobserver to optionally skip postPut/postDelete when > postBatchMutate was called > -- > > Key: HBASE-18127 > URL: https://issues.apache.org/jira/browse/HBASE-18127 > Project: HBase > Issue Type: New Feature >Reporter: Lars Hofhansl >Assignee: Abhishek Singh Chouhan > Attachments: HBASE-18127.master.001.patch > > > Right now a RegionObserver can only statically implement one or the other. In > scenarios where we need to work sometimes on the single postPut and > postDelete hooks and sometimes on the batchMutate hooks, there is currently > no place to convey this information to the single hooks. I.e. the work has > been done in the batch, skip the single hooks. > There are various solutions: > 1. Allow some state to be passed _per operation_. > 2. Remove the single hooks and always only call batch hooks (with a default > wrapper for the single hooks). > 3. more? > [~apurtell], what we had discussed a few days back. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15134) Add visibility into Flush and Compaction queues
[ https://issues.apache.org/jira/browse/HBASE-15134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104113#comment-16104113 ] Andrew Purtell commented on HBASE-15134: +1 Findbugs and test results aren't germane to this patch > Add visibility into Flush and Compaction queues > --- > > Key: HBASE-15134 > URL: https://issues.apache.org/jira/browse/HBASE-15134 > Project: HBase > Issue Type: New Feature > Components: Compaction, metrics, regionserver >Reporter: Elliott Clark >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-15134.branch-1.001.patch, > HBASE-15134.master.001.patch, HBASE-15134.master.002.patch, > HBASE-15134.master.003.patch, HBASE-15134.patch, HBASE-15134.patch > > > On busy spurts we can see regionservers start to see large queues for > compaction. It's really hard to tell if the server is queueing a lot of > compactions for the same region, lots of compactions for lots of regions, or > just falling behind. > For flushes much the same. There can be flushes in queue that aren't being > run because of delayed flushes. There's no way to know from the metrics how > many flushes are for each region, how many are delayed. Etc. > We should add either more metrics around this ( num per region, max per > region, min per region ) or add on a UI page that has the list of compactions > and flushes. > Or both. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18422) Fix TestRegionRebalancing
[ https://issues.apache.org/jira/browse/HBASE-18422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov updated HBASE-18422: -- Attachment: HBASE-18422-v3.patch v3. > Fix TestRegionRebalancing > - > > Key: HBASE-18422 > URL: https://issues.apache.org/jira/browse/HBASE-18422 > Project: HBase > Issue Type: Sub-task > Components: test >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Attachments: HBASE-18422-v1.patch, HBASE-18422-v2.patch, > HBASE-18422-v3.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17908) Upgrade guava
[ https://issues.apache.org/jira/browse/HBASE-17908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104092#comment-16104092 ] Yi Liang commented on HBASE-17908: -- the error on my machine was caused by HBASE-16351, it seems we do not add guava license into supplemental-models.xml, It seems there are other dependencies which also need license. I will open a jira to fix this if you can reproduce this problem(since it has been long time and nobody report it, I am not sure if this only happen on my machine). > Upgrade guava > - > > Key: HBASE-17908 > URL: https://issues.apache.org/jira/browse/HBASE-17908 > Project: HBase > Issue Type: Sub-task > Components: dependencies >Reporter: Balazs Meszaros >Assignee: stack >Priority: Critical > Fix For: 2.0.0 > > Attachments: 0001-HBASE-17908-Upgrade-guava.022.patch, > HBASE-17908.master.001.patch, HBASE-17908.master.002.patch, > HBASE-17908.master.003.patch, HBASE-17908.master.004.patch, > HBASE-17908.master.005.patch, HBASE-17908.master.006.patch, > HBASE-17908.master.007.patch, HBASE-17908.master.008.patch, > HBASE-17908.master.009.patch, HBASE-17908.master.010.patch, > HBASE-17908.master.011.patch, HBASE-17908.master.012.patch, > HBASE-17908.master.013.patch, HBASE-17908.master.013.patch, > HBASE-17908.master.014.patch, HBASE-17908.master.015.patch, > HBASE-17908.master.015.patch, HBASE-17908.master.016.patch, > HBASE-17908.master.017.patch, HBASE-17908.master.018.patch, > HBASE-17908.master.019.patch, HBASE-17908.master.020.patch, > HBASE-17908.master.021.patch, HBASE-17908.master.021.patch, > HBASE-17908.master.022.patch, HBASE-17908.master.023.patch, > HBASE-17908.master.024.patch, HBASE-17908.master.025.patch, > HBASE-17908.master.026.patch, HBASE-17908.master.027.patch, > HBASE-17908.master.028.patch > > > Currently we are using guava 12.0.1, but the latest version is 21.0. > Upgrading guava is always a hassle because it is not always backward > compatible with itself. > Currently I think there are to approaches: > 1. Upgrade guava to the newest version (21.0) and shade it. > 2. Upgrade guava to a version which does not break or builds (15.0). > If we can update it, some dependencies should be removed: > commons-collections, commons-codec, ... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18395) Update clock on region open and close
[ https://issues.apache.org/jira/browse/HBASE-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-18395: - Status: Patch Available (was: Open) > Update clock on region open and close > - > > Key: HBASE-18395 > URL: https://issues.apache.org/jira/browse/HBASE-18395 > Project: HBase > Issue Type: Sub-task >Reporter: Amit Patel >Assignee: Amit Patel >Priority: Minor > Attachments: HBASE-18395.HBASE-14070.HLC.001.patch, > HBASE-18395.HBASE-14070.HLC.002.patch, HBASE-18395.HBASE-14070.HLC.003.patch, > HBASE-18395.HBASE-14070.HLC.004.patch > > > This task covers the patch for updating the clock on region opening and > closing. > The patch would include the following: > * Addition of a new protobuf message type that contains a field for a > timestamp > * Setting of timestamp field in building region open/close request and > response messages > * Updating the clock upon receiving message > The patch for this task will be going against the > [HBASE-14070.HLC|https://git-wip-us.apache.org/repos/asf?p=hbase.git;a=shortlog;h=refs/heads/HBASE-14070.HLC] > branch with the intent that it would be added as a commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18362) hbck should not report split replica parent region from meta as errors
[
https://issues.apache.org/jira/browse/HBASE-18362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104085#comment-16104085
]
Hudson commented on HBASE-18362:
SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #168 (See
[https://builds.apache.org/job/HBase-1.2-JDK8/168/])
HBASE-18362 hbck should not report split replica parent region from meta
(esteban: rev 34120e896956c3e08ff51a7cd12013888f9bf93e)
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
> hbck should not report split replica parent region from meta as errors
> ---
>
> Key: HBASE-18362
> URL: https://issues.apache.org/jira/browse/HBASE-18362
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Affects Versions: 1.4.0, 2.0.0-alpha-1
>Reporter: huaxiang sun
>Assignee: huaxiang sun
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.4.1, 1.2.7
>
> Attachments: HBASE-18362.001.patch, HBASE-18362-branch-1-v001.patch,
> HBASE-18362-branch-1-v002.patch
>
>
> As described in HBASE-18247, replica region shows up as key in meta table. We
> need to find out the code/logic introducing the issue. I suspected that it
> was introduced by hbck, but last round of code review did not find anything.
> Create jira to track this effort.
> Before Catalog Janitor cleans up the split parent region from meta, hbck is
> reporting split replica parent regions as errors and if -fixSplitParents is
> used, the replica parent region will show up as key in meta table. It needs
> to be avoided.
> {code}
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:regioninfo,
> timestamp=1500931787651, value={ENCODED => e10212c467b78104c911ea06c102ece0,
> NAME => 't1,,1500931628959.e10212c467b78104c911ea
> . 06c102ece0.', STARTKEY =>
> '', ENDKEY => '', OFFLINE => true, SPLIT => true}
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen, timestamp=1500931742552,
> value=\x00\x00\x00\x00\x00\x00\x00\x05
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen_0001, timestamp=1500931742492,
> value=\x00\x00\x00\x00\x00\x00\x00\x02
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server,
> timestamp=1500931742552, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server_0001,
> timestamp=1500931742492, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode, timestamp=1500931742552, value=1500931737158
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode_0001, timestamp=1500931742492,
> value=\x00\x00\x01]v\x80\xC6F
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:splitA,
> timestamp=1500931787651, value={ENCODED => dc471b6d9c0c2c451ee4c6d134e50ccc,
> NAME =>
[jira] [Issue Comment Deleted] (HBASE-17908) Upgrade guava
[
https://issues.apache.org/jira/browse/HBASE-17908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Liang updated HBASE-17908:
-
Comment: was deleted
(was: {quote}
ERROR: Guava: Google Core Libraries for Java dependency found without license
information!
Please find the appropriate license and update supplemental-models.xml or
revert the change that added this dependency.
More info on the dependency:
com.google.guava
guava
11.0.2
{quote}
I will investigate why this happen
)
> Upgrade guava
> -
>
> Key: HBASE-17908
> URL: https://issues.apache.org/jira/browse/HBASE-17908
> Project: HBase
> Issue Type: Sub-task
> Components: dependencies
>Reporter: Balazs Meszaros
>Assignee: stack
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: 0001-HBASE-17908-Upgrade-guava.022.patch,
> HBASE-17908.master.001.patch, HBASE-17908.master.002.patch,
> HBASE-17908.master.003.patch, HBASE-17908.master.004.patch,
> HBASE-17908.master.005.patch, HBASE-17908.master.006.patch,
> HBASE-17908.master.007.patch, HBASE-17908.master.008.patch,
> HBASE-17908.master.009.patch, HBASE-17908.master.010.patch,
> HBASE-17908.master.011.patch, HBASE-17908.master.012.patch,
> HBASE-17908.master.013.patch, HBASE-17908.master.013.patch,
> HBASE-17908.master.014.patch, HBASE-17908.master.015.patch,
> HBASE-17908.master.015.patch, HBASE-17908.master.016.patch,
> HBASE-17908.master.017.patch, HBASE-17908.master.018.patch,
> HBASE-17908.master.019.patch, HBASE-17908.master.020.patch,
> HBASE-17908.master.021.patch, HBASE-17908.master.021.patch,
> HBASE-17908.master.022.patch, HBASE-17908.master.023.patch,
> HBASE-17908.master.024.patch, HBASE-17908.master.025.patch,
> HBASE-17908.master.026.patch, HBASE-17908.master.027.patch,
> HBASE-17908.master.028.patch
>
>
> Currently we are using guava 12.0.1, but the latest version is 21.0.
> Upgrading guava is always a hassle because it is not always backward
> compatible with itself.
> Currently I think there are to approaches:
> 1. Upgrade guava to the newest version (21.0) and shade it.
> 2. Upgrade guava to a version which does not break or builds (15.0).
> If we can update it, some dependencies should be removed:
> commons-collections, commons-codec, ...
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18362) hbck should not report split replica parent region from meta as errors
[
https://issues.apache.org/jira/browse/HBASE-18362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104080#comment-16104080
]
Hudson commented on HBASE-18362:
FAILURE: Integrated in Jenkins build HBase-1.4 #824 (See
[https://builds.apache.org/job/HBase-1.4/824/])
HBASE-18362 hbck should not report split replica parent region from meta
(esteban: rev e662d04321f2c4cec29a775a220752a50168026d)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
> hbck should not report split replica parent region from meta as errors
> ---
>
> Key: HBASE-18362
> URL: https://issues.apache.org/jira/browse/HBASE-18362
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Affects Versions: 1.4.0, 2.0.0-alpha-1
>Reporter: huaxiang sun
>Assignee: huaxiang sun
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.4.1, 1.2.7
>
> Attachments: HBASE-18362.001.patch, HBASE-18362-branch-1-v001.patch,
> HBASE-18362-branch-1-v002.patch
>
>
> As described in HBASE-18247, replica region shows up as key in meta table. We
> need to find out the code/logic introducing the issue. I suspected that it
> was introduced by hbck, but last round of code review did not find anything.
> Create jira to track this effort.
> Before Catalog Janitor cleans up the split parent region from meta, hbck is
> reporting split replica parent regions as errors and if -fixSplitParents is
> used, the replica parent region will show up as key in meta table. It needs
> to be avoided.
> {code}
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:regioninfo,
> timestamp=1500931787651, value={ENCODED => e10212c467b78104c911ea06c102ece0,
> NAME => 't1,,1500931628959.e10212c467b78104c911ea
> . 06c102ece0.', STARTKEY =>
> '', ENDKEY => '', OFFLINE => true, SPLIT => true}
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen, timestamp=1500931742552,
> value=\x00\x00\x00\x00\x00\x00\x00\x05
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen_0001, timestamp=1500931742492,
> value=\x00\x00\x00\x00\x00\x00\x00\x02
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server,
> timestamp=1500931742552, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server_0001,
> timestamp=1500931742492, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode, timestamp=1500931742552, value=1500931737158
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode_0001, timestamp=1500931742492,
> value=\x00\x00\x01]v\x80\xC6F
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:splitA,
> timestamp=1500931787651, value={ENCODED => dc471b6d9c0c2c451ee4c6d134e50ccc,
> NAME =>
[jira] [Commented] (HBASE-17908) Upgrade guava
[
https://issues.apache.org/jira/browse/HBASE-17908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104077#comment-16104077
]
Yi Liang commented on HBASE-17908:
--
{quote}
ERROR: Guava: Google Core Libraries for Java dependency found without license
information!
Please find the appropriate license and update supplemental-models.xml or
revert the change that added this dependency.
More info on the dependency:
com.google.guava
guava
11.0.2
{quote}
I will investigate why this happen
> Upgrade guava
> -
>
> Key: HBASE-17908
> URL: https://issues.apache.org/jira/browse/HBASE-17908
> Project: HBase
> Issue Type: Sub-task
> Components: dependencies
>Reporter: Balazs Meszaros
>Assignee: stack
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: 0001-HBASE-17908-Upgrade-guava.022.patch,
> HBASE-17908.master.001.patch, HBASE-17908.master.002.patch,
> HBASE-17908.master.003.patch, HBASE-17908.master.004.patch,
> HBASE-17908.master.005.patch, HBASE-17908.master.006.patch,
> HBASE-17908.master.007.patch, HBASE-17908.master.008.patch,
> HBASE-17908.master.009.patch, HBASE-17908.master.010.patch,
> HBASE-17908.master.011.patch, HBASE-17908.master.012.patch,
> HBASE-17908.master.013.patch, HBASE-17908.master.013.patch,
> HBASE-17908.master.014.patch, HBASE-17908.master.015.patch,
> HBASE-17908.master.015.patch, HBASE-17908.master.016.patch,
> HBASE-17908.master.017.patch, HBASE-17908.master.018.patch,
> HBASE-17908.master.019.patch, HBASE-17908.master.020.patch,
> HBASE-17908.master.021.patch, HBASE-17908.master.021.patch,
> HBASE-17908.master.022.patch, HBASE-17908.master.023.patch,
> HBASE-17908.master.024.patch, HBASE-17908.master.025.patch,
> HBASE-17908.master.026.patch, HBASE-17908.master.027.patch,
> HBASE-17908.master.028.patch
>
>
> Currently we are using guava 12.0.1, but the latest version is 21.0.
> Upgrading guava is always a hassle because it is not always backward
> compatible with itself.
> Currently I think there are to approaches:
> 1. Upgrade guava to the newest version (21.0) and shade it.
> 2. Upgrade guava to a version which does not break or builds (15.0).
> If we can update it, some dependencies should be removed:
> commons-collections, commons-codec, ...
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18185) IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails with AssertionError
[ https://issues.apache.org/jira/browse/HBASE-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104038#comment-16104038 ] Hudson commented on HBASE-18185: SUCCESS: Integrated in Jenkins build HBase-1.2-IT #908 (See [https://builds.apache.org/job/HBase-1.2-IT/908/]) HBASE-18185 IntegrationTestTimeBoundedRequestsWithRegionReplicas (appy: rev 2e7f55fe3ed5f0602f74c7d6205ee19d0c836851) * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/UnbalanceKillAndRebalanceAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyConstants.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/UnbalanceMonkeyFactory.java > IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails > with AssertionError > --- > > Key: HBASE-18185 > URL: https://issues.apache.org/jira/browse/HBASE-18185 > Project: HBase > Issue Type: Bug > Components: integration tests >Affects Versions: 2.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18185-branch-1.v3.patch, > HBASE-18185-branch-1.v4.patch, HBASE-18185-branch-1.v5.patch, > HBASE-18185.v3.patch, HBASE-18185.v4.patch, HBASE-18185.v5.patch > > > We got the following error: > Exception in thread "main" java.lang.AssertionError: Verification failed with > error code 1 > at org.junit.Assert.fail(Assert.java:88) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.runIngestTest(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:217) > at > org.apache.hadoop.hbase.IntegrationTestIngest.internalRunIngestTest(IntegrationTestIngest.java:123) > at > org.apache.hadoop.hbase.IntegrationTestIngest.runTestFromCommandLine(IntegrationTestIngest.java:106) > at > org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:123) > at > org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.main(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:362) > The reason why we got it because another assertion fails in > UnbalanceKillAndRebalanceAction: > Exception in thread "Thread-57" java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertTrue(Assert.java:52) > at > org.apache.hadoop.hbase.chaos.actions.UnbalanceKillAndRebalanceAction.perform(UnbalanceKillAndRebalanceAction.java:60) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18362) hbck should not report split replica parent region from meta as errors
[
https://issues.apache.org/jira/browse/HBASE-18362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104035#comment-16104035
]
Hudson commented on HBASE-18362:
FAILURE: Integrated in Jenkins build HBase-2.0 #245 (See
[https://builds.apache.org/job/HBase-2.0/245/])
HBASE-18362 hbck should not report split replica parent region from meta
(esteban: rev 75789048c13d925d9ee9b67ad8b8dc356e7547ff)
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsckReplicas.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
> hbck should not report split replica parent region from meta as errors
> ---
>
> Key: HBASE-18362
> URL: https://issues.apache.org/jira/browse/HBASE-18362
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Affects Versions: 1.4.0, 2.0.0-alpha-1
>Reporter: huaxiang sun
>Assignee: huaxiang sun
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.4.1, 1.2.7
>
> Attachments: HBASE-18362.001.patch, HBASE-18362-branch-1-v001.patch,
> HBASE-18362-branch-1-v002.patch
>
>
> As described in HBASE-18247, replica region shows up as key in meta table. We
> need to find out the code/logic introducing the issue. I suspected that it
> was introduced by hbck, but last round of code review did not find anything.
> Create jira to track this effort.
> Before Catalog Janitor cleans up the split parent region from meta, hbck is
> reporting split replica parent regions as errors and if -fixSplitParents is
> used, the replica parent region will show up as key in meta table. It needs
> to be avoided.
> {code}
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:regioninfo,
> timestamp=1500931787651, value={ENCODED => e10212c467b78104c911ea06c102ece0,
> NAME => 't1,,1500931628959.e10212c467b78104c911ea
> . 06c102ece0.', STARTKEY =>
> '', ENDKEY => '', OFFLINE => true, SPLIT => true}
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen, timestamp=1500931742552,
> value=\x00\x00\x00\x00\x00\x00\x00\x05
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen_0001, timestamp=1500931742492,
> value=\x00\x00\x00\x00\x00\x00\x00\x02
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server,
> timestamp=1500931742552, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server_0001,
> timestamp=1500931742492, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode, timestamp=1500931742552, value=1500931737158
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode_0001, timestamp=1500931742492,
> value=\x00\x00\x01]v\x80\xC6F
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:splitA,
> timestamp=1500931787651, value={ENCODED => dc471b6d9c0c2c451ee4c6d134e50ccc,
> NAME =>
[jira] [Commented] (HBASE-18185) IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails with AssertionError
[ https://issues.apache.org/jira/browse/HBASE-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104026#comment-16104026 ] Hudson commented on HBASE-18185: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #146 (See [https://builds.apache.org/job/HBase-1.3-IT/146/]) HBASE-18185 IntegrationTestTimeBoundedRequestsWithRegionReplicas (appy: rev 488ae4be658f8a968ca6a9a530e0606f93dc5028) * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/UnbalanceKillAndRebalanceAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyConstants.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/UnbalanceMonkeyFactory.java > IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails > with AssertionError > --- > > Key: HBASE-18185 > URL: https://issues.apache.org/jira/browse/HBASE-18185 > Project: HBase > Issue Type: Bug > Components: integration tests >Affects Versions: 2.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18185-branch-1.v3.patch, > HBASE-18185-branch-1.v4.patch, HBASE-18185-branch-1.v5.patch, > HBASE-18185.v3.patch, HBASE-18185.v4.patch, HBASE-18185.v5.patch > > > We got the following error: > Exception in thread "main" java.lang.AssertionError: Verification failed with > error code 1 > at org.junit.Assert.fail(Assert.java:88) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.runIngestTest(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:217) > at > org.apache.hadoop.hbase.IntegrationTestIngest.internalRunIngestTest(IntegrationTestIngest.java:123) > at > org.apache.hadoop.hbase.IntegrationTestIngest.runTestFromCommandLine(IntegrationTestIngest.java:106) > at > org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:123) > at > org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.main(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:362) > The reason why we got it because another assertion fails in > UnbalanceKillAndRebalanceAction: > Exception in thread "Thread-57" java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertTrue(Assert.java:52) > at > org.apache.hadoop.hbase.chaos.actions.UnbalanceKillAndRebalanceAction.perform(UnbalanceKillAndRebalanceAction.java:60) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17908) Upgrade guava
[
https://issues.apache.org/jira/browse/HBASE-17908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104029#comment-16104029
]
Yi Liang commented on HBASE-17908:
--
Hi [~stack]
I am trying to run mvn clean install -DskipTests on my local machine, it
always shows
{quote}
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.EvaluateBeanshell failed
with message:
License errors detected, for more detail find ERROR in
~/hbase-assembly/target/maven-shared-archive-resources/META-INF/LICENSE
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce
(check-aggregate-license) on project hbase-assembly: Some Enforcer rules have
failed. Look above for specific messages explaining why the rule failed. ->
[Help 1]
{quote}
But if I run mvn install before this commit, it works fine. Do you have the
same issue?
> Upgrade guava
> -
>
> Key: HBASE-17908
> URL: https://issues.apache.org/jira/browse/HBASE-17908
> Project: HBase
> Issue Type: Sub-task
> Components: dependencies
>Reporter: Balazs Meszaros
>Assignee: stack
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: 0001-HBASE-17908-Upgrade-guava.022.patch,
> HBASE-17908.master.001.patch, HBASE-17908.master.002.patch,
> HBASE-17908.master.003.patch, HBASE-17908.master.004.patch,
> HBASE-17908.master.005.patch, HBASE-17908.master.006.patch,
> HBASE-17908.master.007.patch, HBASE-17908.master.008.patch,
> HBASE-17908.master.009.patch, HBASE-17908.master.010.patch,
> HBASE-17908.master.011.patch, HBASE-17908.master.012.patch,
> HBASE-17908.master.013.patch, HBASE-17908.master.013.patch,
> HBASE-17908.master.014.patch, HBASE-17908.master.015.patch,
> HBASE-17908.master.015.patch, HBASE-17908.master.016.patch,
> HBASE-17908.master.017.patch, HBASE-17908.master.018.patch,
> HBASE-17908.master.019.patch, HBASE-17908.master.020.patch,
> HBASE-17908.master.021.patch, HBASE-17908.master.021.patch,
> HBASE-17908.master.022.patch, HBASE-17908.master.023.patch,
> HBASE-17908.master.024.patch, HBASE-17908.master.025.patch,
> HBASE-17908.master.026.patch, HBASE-17908.master.027.patch,
> HBASE-17908.master.028.patch
>
>
> Currently we are using guava 12.0.1, but the latest version is 21.0.
> Upgrading guava is always a hassle because it is not always backward
> compatible with itself.
> Currently I think there are to approaches:
> 1. Upgrade guava to the newest version (21.0) and shade it.
> 2. Upgrade guava to a version which does not break or builds (15.0).
> If we can update it, some dependencies should be removed:
> commons-collections, commons-codec, ...
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15134) Add visibility into Flush and Compaction queues
[
https://issues.apache.org/jira/browse/HBASE-15134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104027#comment-16104027
]
Hadoop QA commented on HBASE-15134:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
22s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
0s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
31s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
44s{color} | {color:green} branch-1 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
20s{color} | {color:red} hbase-hadoop2-compat in branch-1 has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
50s{color} | {color:green} branch-1 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 29s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
20s{color} | {color:green} hbase-hadoop-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
24s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}122m 38s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
47s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}159m 59s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.mapred.TestTableSnapshotInputFormat |
| | hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
| | hadoop.hbase.replication.TestReplicationKillSlaveRS |
| | hadoop.hbase.client.TestClientScannerRPCTimeout |
| | hadoop.hbase.TestZooKeeper |
| Timed out junit tests |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes |
| | org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-15134 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12879230/HBASE-15134.branch-1.001.patch
|
| Optional Tests | asflicense javac javadoc
[jira] [Commented] (HBASE-18463) Replication sink frequently triggers HBASE-18023 warnings
[ https://issues.apache.org/jira/browse/HBASE-18463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104021#comment-16104021 ] Andrew Purtell commented on HBASE-18463: Yes, potentially harmful, to performance > Replication sink frequently triggers HBASE-18023 warnings > - > > Key: HBASE-18463 > URL: https://issues.apache.org/jira/browse/HBASE-18463 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Andrew Purtell >Priority: Minor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2 > > > After HBASE-18023 we warn if the number of operations in a multi operation > exceeds a threshold. This is meant to catch potential performance problems or > abusive clients. However while testing simple replication scenarios we have > observed frequent warnings issued as the sink applies received edit batches. > I think we want to either introduce a separate threshold for warning about > RPC submitted by the replication client or exclude ops submitted by the sinks > entirely. Not sure distinguishing the replication client from normal clients > is possible yet. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18463) Replication sink frequently triggers HBASE-18023 warnings
[
https://issues.apache.org/jira/browse/HBASE-18463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104025#comment-16104025
]
Andrew Purtell commented on HBASE-18463:
Copied [~elserj] comment from parent:
{quote}
I could see this go either way:
On one side, replication has its own knobs that control how much data is sent
in a single RPC. This (hopefully) implies that the administrator configured
replication to use a certain batch size and knows that they did this.
On the other side, I would not be surprised at admins who don't set this value
and run into memory/GC issues with RegionServers. I could see this message
proactively warning them "hey, you got some big RPCs coming in" which would
hopefully steer them in the right direction.
I would say that if the default configuration values lead us to spamming WARN
messages, that is something we should address in some form.
{quote}
> Replication sink frequently triggers HBASE-18023 warnings
> -
>
> Key: HBASE-18463
> URL: https://issues.apache.org/jira/browse/HBASE-18463
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver
>Reporter: Andrew Purtell
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2
>
>
> After HBASE-18023 we warn if the number of operations in a multi operation
> exceeds a threshold. This is meant to catch potential performance problems or
> abusive clients. However while testing simple replication scenarios we have
> observed frequent warnings issued as the sink applies received edit batches.
> I think we want to either introduce a separate threshold for warning about
> RPC submitted by the replication client or exclude ops submitted by the sinks
> entirely. Not sure distinguishing the replication client from normal clients
> is possible yet.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18465) [AMv2] remove old split region code that is no longer needed
[ https://issues.apache.org/jira/browse/HBASE-18465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Liang updated HBASE-18465: - Issue Type: Task (was: Bug) > [AMv2] remove old split region code that is no longer needed > > > Key: HBASE-18465 > URL: https://issues.apache.org/jira/browse/HBASE-18465 > Project: HBase > Issue Type: Task > Components: Admin, rpc >Affects Versions: 3.0.0, 2.0.0-alpha-1 >Reporter: Yi Liang >Assignee: Yi Liang > Fix For: 2.0.0, 3.0.0 > > > After HBASE-18229, Admin.split go to MasterRpcServices directly, so need to > clean up the old logic going through RSRpcServices. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18185) IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails with AssertionError
[ https://issues.apache.org/jira/browse/HBASE-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104013#comment-16104013 ] Hudson commented on HBASE-18185: FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #208 (See [https://builds.apache.org/job/HBase-1.3-JDK7/208/]) HBASE-18185 IntegrationTestTimeBoundedRequestsWithRegionReplicas (appy: rev 488ae4be658f8a968ca6a9a530e0606f93dc5028) * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyConstants.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/UnbalanceKillAndRebalanceAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/UnbalanceMonkeyFactory.java > IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails > with AssertionError > --- > > Key: HBASE-18185 > URL: https://issues.apache.org/jira/browse/HBASE-18185 > Project: HBase > Issue Type: Bug > Components: integration tests >Affects Versions: 2.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18185-branch-1.v3.patch, > HBASE-18185-branch-1.v4.patch, HBASE-18185-branch-1.v5.patch, > HBASE-18185.v3.patch, HBASE-18185.v4.patch, HBASE-18185.v5.patch > > > We got the following error: > Exception in thread "main" java.lang.AssertionError: Verification failed with > error code 1 > at org.junit.Assert.fail(Assert.java:88) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.runIngestTest(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:217) > at > org.apache.hadoop.hbase.IntegrationTestIngest.internalRunIngestTest(IntegrationTestIngest.java:123) > at > org.apache.hadoop.hbase.IntegrationTestIngest.runTestFromCommandLine(IntegrationTestIngest.java:106) > at > org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:123) > at > org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.main(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:362) > The reason why we got it because another assertion fails in > UnbalanceKillAndRebalanceAction: > Exception in thread "Thread-57" java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertTrue(Assert.java:52) > at > org.apache.hadoop.hbase.chaos.actions.UnbalanceKillAndRebalanceAction.perform(UnbalanceKillAndRebalanceAction.java:60) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18465) [AMv2] remove old split region code that is no longer needed
Yi Liang created HBASE-18465: Summary: [AMv2] remove old split region code that is no longer needed Key: HBASE-18465 URL: https://issues.apache.org/jira/browse/HBASE-18465 Project: HBase Issue Type: Bug Components: Admin, rpc Affects Versions: 2.0.0-alpha-1, 3.0.0 Reporter: Yi Liang Assignee: Yi Liang Fix For: 2.0.0, 3.0.0 After HBASE-18229, Admin.split go to MasterRpcServices directly, so need to clean up the old logic going through RSRpcServices. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17131) Avoid livelock caused by HRegion#processRowsWithLocks
[
https://issues.apache.org/jira/browse/HBASE-17131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104015#comment-16104015
]
Sean Busbey commented on HBASE-17131:
-
+1
> Avoid livelock caused by HRegion#processRowsWithLocks
> -
>
> Key: HBASE-17131
> URL: https://issues.apache.org/jira/browse/HBASE-17131
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 2.0.0, 1.4.0, 1.3.1, 1.2.6
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.2.7
>
> Attachments: HBASE-17131.branch-1.3.v0.patch,
> HBASE-17131.branch-1.v0.patch, HBASE-17131.v0.patch
>
>
> {code:title=HRegion.java|borderStyle=solid}
> try {
> // STEP 2. Acquire the row lock(s)
> acquiredRowLocks = new ArrayList(rowsToLock.size());
> for (byte[] row : rowsToLock) {
> // Attempt to lock all involved rows, throw if any lock times out
> // use a writer lock for mixed reads and writes
> acquiredRowLocks.add(getRowLockInternal(row, false));
> }
> // STEP 3. Region lock
> lock(this.updatesLock.readLock(), acquiredRowLocks.size() == 0 ? 1 :
> acquiredRowLocks.size());
> locked = true;
> boolean success = false;
> long now = EnvironmentEdgeManager.currentTime();
> try {
> {code}
> We should lock all involved rows in the second try-finally. Otherwise, we
> won’t release the previous locks if any subsequent lock times out.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18023) Log multi-* requests for more than threshold number of rows
[ https://issues.apache.org/jira/browse/HBASE-18023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104000#comment-16104000 ] Josh Elser commented on HBASE-18023: bq. I've noticed that replication can trigger this quite a bit as the sink applies the shipped edits. Should we make a distinction between normal clients and replication clients and apply two separate thresholds? I could see this go either way: On one side, replication has its own knobs that control how much data is sent in a single RPC. This (hopefully) implies that the administrator configured replication to use a certain batch size and knows that they did this. On the other side, I would not be surprised at admins who don't set this value and run into memory/GC issues with RegionServers. I could see this message proactively warning them "hey, you got some big RPCs coming in" which would hopefully steer them in the right direction. I would say that if the default configuration values lead us to spamming WARN messages, that is something we should address in some form. > Log multi-* requests for more than threshold number of rows > --- > > Key: HBASE-18023 > URL: https://issues.apache.org/jira/browse/HBASE-18023 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: Clay B. >Assignee: David Harju >Priority: Minor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2 > > Attachments: HBASE-18023.addendum.patch, > HBASE-18023-branch-1.3.patch, HBASE-18023-branch-1.patch, > HBASE-18023.master.001.patch, HBASE-18023.master.002.patch, > HBASE-18023.master.003.patch, HBASE-18023.master.004.patch > > > Today, if a user happens to do something like a large multi-put, they can get > through request throttling (e.g. it is one request) but still crash a region > server with a garbage storm. We have seen regionservers hit this issue and it > is silent and deadly. The RS will report nothing more than a mysterious > garbage collection and exit out. > Ideally, we could report a large multi-* request before starting it, in case > it happens to be deadly. Knowing the client, user and how many rows are > affected would be a good start to tracking down painful users. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18185) IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails with AssertionError
[ https://issues.apache.org/jira/browse/HBASE-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-18185: - Resolution: Fixed Status: Resolved (was: Patch Available) > IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails > with AssertionError > --- > > Key: HBASE-18185 > URL: https://issues.apache.org/jira/browse/HBASE-18185 > Project: HBase > Issue Type: Bug > Components: integration tests >Affects Versions: 2.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18185-branch-1.v3.patch, > HBASE-18185-branch-1.v4.patch, HBASE-18185-branch-1.v5.patch, > HBASE-18185.v3.patch, HBASE-18185.v4.patch, HBASE-18185.v5.patch > > > We got the following error: > Exception in thread "main" java.lang.AssertionError: Verification failed with > error code 1 > at org.junit.Assert.fail(Assert.java:88) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.runIngestTest(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:217) > at > org.apache.hadoop.hbase.IntegrationTestIngest.internalRunIngestTest(IntegrationTestIngest.java:123) > at > org.apache.hadoop.hbase.IntegrationTestIngest.runTestFromCommandLine(IntegrationTestIngest.java:106) > at > org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:123) > at > org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.main(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:362) > The reason why we got it because another assertion fails in > UnbalanceKillAndRebalanceAction: > Exception in thread "Thread-57" java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertTrue(Assert.java:52) > at > org.apache.hadoop.hbase.chaos.actions.UnbalanceKillAndRebalanceAction.perform(UnbalanceKillAndRebalanceAction.java:60) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18185) IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails with AssertionError
[ https://issues.apache.org/jira/browse/HBASE-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103989#comment-16103989 ] Appy commented on HBASE-18185: -- Pushed to all branches back till 1.2. Thanks for fixing this nasty one [~balazs.meszaros]! > IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails > with AssertionError > --- > > Key: HBASE-18185 > URL: https://issues.apache.org/jira/browse/HBASE-18185 > Project: HBase > Issue Type: Bug > Components: integration tests >Affects Versions: 2.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18185-branch-1.v3.patch, > HBASE-18185-branch-1.v4.patch, HBASE-18185-branch-1.v5.patch, > HBASE-18185.v3.patch, HBASE-18185.v4.patch, HBASE-18185.v5.patch > > > We got the following error: > Exception in thread "main" java.lang.AssertionError: Verification failed with > error code 1 > at org.junit.Assert.fail(Assert.java:88) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.runIngestTest(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:217) > at > org.apache.hadoop.hbase.IntegrationTestIngest.internalRunIngestTest(IntegrationTestIngest.java:123) > at > org.apache.hadoop.hbase.IntegrationTestIngest.runTestFromCommandLine(IntegrationTestIngest.java:106) > at > org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:123) > at > org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.main(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:362) > The reason why we got it because another assertion fails in > UnbalanceKillAndRebalanceAction: > Exception in thread "Thread-57" java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertTrue(Assert.java:52) > at > org.apache.hadoop.hbase.chaos.actions.UnbalanceKillAndRebalanceAction.perform(UnbalanceKillAndRebalanceAction.java:60) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18185) IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails with AssertionError
[ https://issues.apache.org/jira/browse/HBASE-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-18185: - Fix Version/s: 1.5.0 > IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails > with AssertionError > --- > > Key: HBASE-18185 > URL: https://issues.apache.org/jira/browse/HBASE-18185 > Project: HBase > Issue Type: Bug > Components: integration tests >Affects Versions: 2.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18185-branch-1.v3.patch, > HBASE-18185-branch-1.v4.patch, HBASE-18185-branch-1.v5.patch, > HBASE-18185.v3.patch, HBASE-18185.v4.patch, HBASE-18185.v5.patch > > > We got the following error: > Exception in thread "main" java.lang.AssertionError: Verification failed with > error code 1 > at org.junit.Assert.fail(Assert.java:88) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.runIngestTest(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:217) > at > org.apache.hadoop.hbase.IntegrationTestIngest.internalRunIngestTest(IntegrationTestIngest.java:123) > at > org.apache.hadoop.hbase.IntegrationTestIngest.runTestFromCommandLine(IntegrationTestIngest.java:106) > at > org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:123) > at > org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.main(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:362) > The reason why we got it because another assertion fails in > UnbalanceKillAndRebalanceAction: > Exception in thread "Thread-57" java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertTrue(Assert.java:52) > at > org.apache.hadoop.hbase.chaos.actions.UnbalanceKillAndRebalanceAction.perform(UnbalanceKillAndRebalanceAction.java:60) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17131) Avoid livelock caused by HRegion#processRowsWithLocks
[
https://issues.apache.org/jira/browse/HBASE-17131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103977#comment-16103977
]
Hadoop QA commented on HBASE-17131:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
30s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
56s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
31s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
6s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
51s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
31s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
32s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 40s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}111m
11s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
25s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}148m 0s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:b3a2a00 |
| JIRA Issue | HBASE-17131 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12879228/HBASE-17131.branch-1.3.v0.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 32ffec47cf75 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/hbase.sh |
| git revision | branch-1.3 / 22233a2 |
| Default Java | 1.7.0_131 |
| Multi-JDK versions |
[jira] [Updated] (HBASE-18395) Update clock on region open and close
[ https://issues.apache.org/jira/browse/HBASE-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Patel updated HBASE-18395: --- Attachment: HBASE-18395.HBASE-14070.HLC.004.patch > Update clock on region open and close > - > > Key: HBASE-18395 > URL: https://issues.apache.org/jira/browse/HBASE-18395 > Project: HBase > Issue Type: Sub-task >Reporter: Amit Patel >Assignee: Amit Patel >Priority: Minor > Attachments: HBASE-18395.HBASE-14070.HLC.001.patch, > HBASE-18395.HBASE-14070.HLC.002.patch, HBASE-18395.HBASE-14070.HLC.003.patch, > HBASE-18395.HBASE-14070.HLC.004.patch > > > This task covers the patch for updating the clock on region opening and > closing. > The patch would include the following: > * Addition of a new protobuf message type that contains a field for a > timestamp > * Setting of timestamp field in building region open/close request and > response messages > * Updating the clock upon receiving message > The patch for this task will be going against the > [HBASE-14070.HLC|https://git-wip-us.apache.org/repos/asf?p=hbase.git;a=shortlog;h=refs/heads/HBASE-14070.HLC] > branch with the intent that it would be added as a commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18374) RegionServer Metrics improvements
[
https://issues.apache.org/jira/browse/HBASE-18374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103961#comment-16103961
]
Hadoop QA commented on HBASE-18374:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
18s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
19s{color} | {color:green} branch-1 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
13s{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
39s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
48s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
28s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
12s{color} | {color:green} branch-1 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
16s{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
18s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 38s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
6s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
21s{color} | {color:green} hbase-hadoop-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
27s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}105m 25s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
51s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}152m 19s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.mapreduce.TestTableSnapshotInputFormat |
| |
[jira] [Commented] (HBASE-18362) hbck should not report split replica parent region from meta as errors
[
https://issues.apache.org/jira/browse/HBASE-18362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103953#comment-16103953
]
Hudson commented on HBASE-18362:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #145 (See
[https://builds.apache.org/job/HBase-1.3-IT/145/])
HBASE-18362 hbck should not report split replica parent region from meta
(esteban: rev c23b7c9c80d7663741b598f221cca8b4eb74033c)
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
> hbck should not report split replica parent region from meta as errors
> ---
>
> Key: HBASE-18362
> URL: https://issues.apache.org/jira/browse/HBASE-18362
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Affects Versions: 1.4.0, 2.0.0-alpha-1
>Reporter: huaxiang sun
>Assignee: huaxiang sun
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.4.1, 1.2.7
>
> Attachments: HBASE-18362.001.patch, HBASE-18362-branch-1-v001.patch,
> HBASE-18362-branch-1-v002.patch
>
>
> As described in HBASE-18247, replica region shows up as key in meta table. We
> need to find out the code/logic introducing the issue. I suspected that it
> was introduced by hbck, but last round of code review did not find anything.
> Create jira to track this effort.
> Before Catalog Janitor cleans up the split parent region from meta, hbck is
> reporting split replica parent regions as errors and if -fixSplitParents is
> used, the replica parent region will show up as key in meta table. It needs
> to be avoided.
> {code}
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:regioninfo,
> timestamp=1500931787651, value={ENCODED => e10212c467b78104c911ea06c102ece0,
> NAME => 't1,,1500931628959.e10212c467b78104c911ea
> . 06c102ece0.', STARTKEY =>
> '', ENDKEY => '', OFFLINE => true, SPLIT => true}
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen, timestamp=1500931742552,
> value=\x00\x00\x00\x00\x00\x00\x00\x05
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen_0001, timestamp=1500931742492,
> value=\x00\x00\x00\x00\x00\x00\x00\x02
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server,
> timestamp=1500931742552, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server_0001,
> timestamp=1500931742492, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode, timestamp=1500931742552, value=1500931737158
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode_0001, timestamp=1500931742492,
> value=\x00\x00\x01]v\x80\xC6F
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:splitA,
> timestamp=1500931787651, value={ENCODED => dc471b6d9c0c2c451ee4c6d134e50ccc,
> NAME =>
[jira] [Commented] (HBASE-16391) Multiple backup/restore sessions support
[ https://issues.apache.org/jira/browse/HBASE-16391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103949#comment-16103949 ] Ted Yu commented on HBASE-16391: Can you outline the reasons why this would not be implemented ? > Multiple backup/restore sessions support > > > Key: HBASE-16391 > URL: https://issues.apache.org/jira/browse/HBASE-16391 > Project: HBase > Issue Type: New Feature >Affects Versions: HBASE-7912 >Reporter: Vladimir Rodionov > Fix For: HBASE-7912 > > > Multiple simultaneous sessions support for backup/restore. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18362) hbck should not report split replica parent region from meta as errors
[
https://issues.apache.org/jira/browse/HBASE-18362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103938#comment-16103938
]
Hudson commented on HBASE-18362:
SUCCESS: Integrated in Jenkins build HBase-1.2-IT #906 (See
[https://builds.apache.org/job/HBase-1.2-IT/906/])
HBASE-18362 hbck should not report split replica parent region from meta
(esteban: rev 34120e896956c3e08ff51a7cd12013888f9bf93e)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
> hbck should not report split replica parent region from meta as errors
> ---
>
> Key: HBASE-18362
> URL: https://issues.apache.org/jira/browse/HBASE-18362
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Affects Versions: 1.4.0, 2.0.0-alpha-1
>Reporter: huaxiang sun
>Assignee: huaxiang sun
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.4.1, 1.2.7
>
> Attachments: HBASE-18362.001.patch, HBASE-18362-branch-1-v001.patch,
> HBASE-18362-branch-1-v002.patch
>
>
> As described in HBASE-18247, replica region shows up as key in meta table. We
> need to find out the code/logic introducing the issue. I suspected that it
> was introduced by hbck, but last round of code review did not find anything.
> Create jira to track this effort.
> Before Catalog Janitor cleans up the split parent region from meta, hbck is
> reporting split replica parent regions as errors and if -fixSplitParents is
> used, the replica parent region will show up as key in meta table. It needs
> to be avoided.
> {code}
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:regioninfo,
> timestamp=1500931787651, value={ENCODED => e10212c467b78104c911ea06c102ece0,
> NAME => 't1,,1500931628959.e10212c467b78104c911ea
> . 06c102ece0.', STARTKEY =>
> '', ENDKEY => '', OFFLINE => true, SPLIT => true}
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen, timestamp=1500931742552,
> value=\x00\x00\x00\x00\x00\x00\x00\x05
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen_0001, timestamp=1500931742492,
> value=\x00\x00\x00\x00\x00\x00\x00\x02
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server,
> timestamp=1500931742552, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server_0001,
> timestamp=1500931742492, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode, timestamp=1500931742552, value=1500931737158
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode_0001, timestamp=1500931742492,
> value=\x00\x00\x01]v\x80\xC6F
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:splitA,
> timestamp=1500931787651, value={ENCODED => dc471b6d9c0c2c451ee4c6d134e50ccc,
> NAME =>
[jira] [Commented] (HBASE-18362) hbck should not report split replica parent region from meta as errors
[
https://issues.apache.org/jira/browse/HBASE-18362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103936#comment-16103936
]
Hudson commented on HBASE-18362:
FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #207 (See
[https://builds.apache.org/job/HBase-1.3-JDK7/207/])
HBASE-18362 hbck should not report split replica parent region from meta
(esteban: rev c23b7c9c80d7663741b598f221cca8b4eb74033c)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
> hbck should not report split replica parent region from meta as errors
> ---
>
> Key: HBASE-18362
> URL: https://issues.apache.org/jira/browse/HBASE-18362
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Affects Versions: 1.4.0, 2.0.0-alpha-1
>Reporter: huaxiang sun
>Assignee: huaxiang sun
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.4.1, 1.2.7
>
> Attachments: HBASE-18362.001.patch, HBASE-18362-branch-1-v001.patch,
> HBASE-18362-branch-1-v002.patch
>
>
> As described in HBASE-18247, replica region shows up as key in meta table. We
> need to find out the code/logic introducing the issue. I suspected that it
> was introduced by hbck, but last round of code review did not find anything.
> Create jira to track this effort.
> Before Catalog Janitor cleans up the split parent region from meta, hbck is
> reporting split replica parent regions as errors and if -fixSplitParents is
> used, the replica parent region will show up as key in meta table. It needs
> to be avoided.
> {code}
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:regioninfo,
> timestamp=1500931787651, value={ENCODED => e10212c467b78104c911ea06c102ece0,
> NAME => 't1,,1500931628959.e10212c467b78104c911ea
> . 06c102ece0.', STARTKEY =>
> '', ENDKEY => '', OFFLINE => true, SPLIT => true}
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen, timestamp=1500931742552,
> value=\x00\x00\x00\x00\x00\x00\x00\x05
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen_0001, timestamp=1500931742492,
> value=\x00\x00\x00\x00\x00\x00\x00\x02
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server,
> timestamp=1500931742552, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server_0001,
> timestamp=1500931742492, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode, timestamp=1500931742552, value=1500931737158
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode_0001, timestamp=1500931742492,
> value=\x00\x00\x01]v\x80\xC6F
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:splitA,
> timestamp=1500931787651, value={ENCODED => dc471b6d9c0c2c451ee4c6d134e50ccc,
> NAME =>
[jira] [Commented] (HBASE-18362) hbck should not report split replica parent region from meta as errors
[
https://issues.apache.org/jira/browse/HBASE-18362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103931#comment-16103931
]
Hudson commented on HBASE-18362:
FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #172 (See
[https://builds.apache.org/job/HBase-1.2-JDK7/172/])
HBASE-18362 hbck should not report split replica parent region from meta
(esteban: rev 34120e896956c3e08ff51a7cd12013888f9bf93e)
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
> hbck should not report split replica parent region from meta as errors
> ---
>
> Key: HBASE-18362
> URL: https://issues.apache.org/jira/browse/HBASE-18362
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Affects Versions: 1.4.0, 2.0.0-alpha-1
>Reporter: huaxiang sun
>Assignee: huaxiang sun
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.4.1, 1.2.7
>
> Attachments: HBASE-18362.001.patch, HBASE-18362-branch-1-v001.patch,
> HBASE-18362-branch-1-v002.patch
>
>
> As described in HBASE-18247, replica region shows up as key in meta table. We
> need to find out the code/logic introducing the issue. I suspected that it
> was introduced by hbck, but last round of code review did not find anything.
> Create jira to track this effort.
> Before Catalog Janitor cleans up the split parent region from meta, hbck is
> reporting split replica parent regions as errors and if -fixSplitParents is
> used, the replica parent region will show up as key in meta table. It needs
> to be avoided.
> {code}
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:regioninfo,
> timestamp=1500931787651, value={ENCODED => e10212c467b78104c911ea06c102ece0,
> NAME => 't1,,1500931628959.e10212c467b78104c911ea
> . 06c102ece0.', STARTKEY =>
> '', ENDKEY => '', OFFLINE => true, SPLIT => true}
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen, timestamp=1500931742552,
> value=\x00\x00\x00\x00\x00\x00\x00\x05
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen_0001, timestamp=1500931742492,
> value=\x00\x00\x00\x00\x00\x00\x00\x02
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server,
> timestamp=1500931742552, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server_0001,
> timestamp=1500931742492, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode, timestamp=1500931742552, value=1500931737158
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode_0001, timestamp=1500931742492,
> value=\x00\x00\x01]v\x80\xC6F
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:splitA,
> timestamp=1500931787651, value={ENCODED => dc471b6d9c0c2c451ee4c6d134e50ccc,
> NAME =>
[jira] [Updated] (HBASE-18362) hbck should not report split replica parent region from meta as errors
[
https://issues.apache.org/jira/browse/HBASE-18362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Esteban Gutierrez updated HBASE-18362:
--
Attachment: HBASE-18362.001.patch
uploaded diff for master just for posterity.
> hbck should not report split replica parent region from meta as errors
> ---
>
> Key: HBASE-18362
> URL: https://issues.apache.org/jira/browse/HBASE-18362
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Affects Versions: 1.4.0, 2.0.0-alpha-1
>Reporter: huaxiang sun
>Assignee: huaxiang sun
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.4.1, 1.2.7
>
> Attachments: HBASE-18362.001.patch, HBASE-18362-branch-1-v001.patch,
> HBASE-18362-branch-1-v002.patch
>
>
> As described in HBASE-18247, replica region shows up as key in meta table. We
> need to find out the code/logic introducing the issue. I suspected that it
> was introduced by hbck, but last round of code review did not find anything.
> Create jira to track this effort.
> Before Catalog Janitor cleans up the split parent region from meta, hbck is
> reporting split replica parent regions as errors and if -fixSplitParents is
> used, the replica parent region will show up as key in meta table. It needs
> to be avoided.
> {code}
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:regioninfo,
> timestamp=1500931787651, value={ENCODED => e10212c467b78104c911ea06c102ece0,
> NAME => 't1,,1500931628959.e10212c467b78104c911ea
> . 06c102ece0.', STARTKEY =>
> '', ENDKEY => '', OFFLINE => true, SPLIT => true}
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen, timestamp=1500931742552,
> value=\x00\x00\x00\x00\x00\x00\x00\x05
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen_0001, timestamp=1500931742492,
> value=\x00\x00\x00\x00\x00\x00\x00\x02
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server,
> timestamp=1500931742552, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server_0001,
> timestamp=1500931742492, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode, timestamp=1500931742552, value=1500931737158
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode_0001, timestamp=1500931742492,
> value=\x00\x00\x01]v\x80\xC6F
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:splitA,
> timestamp=1500931787651, value={ENCODED => dc471b6d9c0c2c451ee4c6d134e50ccc,
> NAME => 't1,,1500931787511.dc471b6d9c0c2c451ee4c6d134
> . e50ccc.', STARTKEY => '',
> ENDKEY => 'r'}
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:splitB,
> timestamp=1500931787651, value={ENCODED =>
[jira] [Updated] (HBASE-18362) hbck should not report split replica parent region from meta as errors
[
https://issues.apache.org/jira/browse/HBASE-18362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Esteban Gutierrez updated HBASE-18362:
--
Resolution: Fixed
Fix Version/s: 1.2.7
1.4.1
1.3.2
3.0.0
2.0.0
Status: Resolved (was: Patch Available)
rebased to branch-2 and master. Thanks [~huaxiang]!
> hbck should not report split replica parent region from meta as errors
> ---
>
> Key: HBASE-18362
> URL: https://issues.apache.org/jira/browse/HBASE-18362
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Affects Versions: 1.4.0, 2.0.0-alpha-1
>Reporter: huaxiang sun
>Assignee: huaxiang sun
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.4.1, 1.2.7
>
> Attachments: HBASE-18362-branch-1-v001.patch,
> HBASE-18362-branch-1-v002.patch
>
>
> As described in HBASE-18247, replica region shows up as key in meta table. We
> need to find out the code/logic introducing the issue. I suspected that it
> was introduced by hbck, but last round of code review did not find anything.
> Create jira to track this effort.
> Before Catalog Janitor cleans up the split parent region from meta, hbck is
> reporting split replica parent regions as errors and if -fixSplitParents is
> used, the replica parent region will show up as key in meta table. It needs
> to be avoided.
> {code}
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:regioninfo,
> timestamp=1500931787651, value={ENCODED => e10212c467b78104c911ea06c102ece0,
> NAME => 't1,,1500931628959.e10212c467b78104c911ea
> . 06c102ece0.', STARTKEY =>
> '', ENDKEY => '', OFFLINE => true, SPLIT => true}
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen, timestamp=1500931742552,
> value=\x00\x00\x00\x00\x00\x00\x00\x05
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen_0001, timestamp=1500931742492,
> value=\x00\x00\x00\x00\x00\x00\x00\x02
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server,
> timestamp=1500931742552, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server_0001,
> timestamp=1500931742492, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode, timestamp=1500931742552, value=1500931737158
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode_0001, timestamp=1500931742492,
> value=\x00\x00\x01]v\x80\xC6F
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:splitA,
> timestamp=1500931787651, value={ENCODED => dc471b6d9c0c2c451ee4c6d134e50ccc,
> NAME => 't1,,1500931787511.dc471b6d9c0c2c451ee4c6d134
> . e50ccc.', STARTKEY => '',
> ENDKEY => 'r'}
>
[jira] [Commented] (HBASE-18374) RegionServer Metrics improvements
[
https://issues.apache.org/jira/browse/HBASE-18374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103887#comment-16103887
]
Hadoop QA commented on HBASE-18374:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
34s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
34m 11s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
25s{color} | {color:green} hbase-hadoop-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
31s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}124m
7s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
56s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}182m 8s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18374 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12879209/HBASE-18374.master.004.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 2d1d7fc07027 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / a649afe |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7814/testReport/ |
| modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: . |
| Console output |
[jira] [Commented] (HBASE-18362) hbck should not report split replica parent region from meta as errors
[
https://issues.apache.org/jira/browse/HBASE-18362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103864#comment-16103864
]
Esteban Gutierrez commented on HBASE-18362:
---
I will go ahead and commit since the change is not related to the failure.
> hbck should not report split replica parent region from meta as errors
> ---
>
> Key: HBASE-18362
> URL: https://issues.apache.org/jira/browse/HBASE-18362
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Affects Versions: 1.4.0, 2.0.0-alpha-1
>Reporter: huaxiang sun
>Assignee: huaxiang sun
>Priority: Minor
> Attachments: HBASE-18362-branch-1-v001.patch,
> HBASE-18362-branch-1-v002.patch
>
>
> As described in HBASE-18247, replica region shows up as key in meta table. We
> need to find out the code/logic introducing the issue. I suspected that it
> was introduced by hbck, but last round of code review did not find anything.
> Create jira to track this effort.
> Before Catalog Janitor cleans up the split parent region from meta, hbck is
> reporting split replica parent regions as errors and if -fixSplitParents is
> used, the replica parent region will show up as key in meta table. It needs
> to be avoided.
> {code}
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:regioninfo,
> timestamp=1500931787651, value={ENCODED => e10212c467b78104c911ea06c102ece0,
> NAME => 't1,,1500931628959.e10212c467b78104c911ea
> . 06c102ece0.', STARTKEY =>
> '', ENDKEY => '', OFFLINE => true, SPLIT => true}
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen, timestamp=1500931742552,
> value=\x00\x00\x00\x00\x00\x00\x00\x05
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:seqnumDuringOpen_0001, timestamp=1500931742492,
> value=\x00\x00\x00\x00\x00\x00\x00\x02
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server,
> timestamp=1500931742552, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:server_0001,
> timestamp=1500931742492, value=dhcp-172-16-1-203.pa.cloudera.com:61099
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode, timestamp=1500931742552, value=1500931737158
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0
> column=info:serverstartcode_0001, timestamp=1500931742492,
> value=\x00\x00\x01]v\x80\xC6F
>
> .
>
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:splitA,
> timestamp=1500931787651, value={ENCODED => dc471b6d9c0c2c451ee4c6d134e50ccc,
> NAME => 't1,,1500931787511.dc471b6d9c0c2c451ee4c6d134
> . e50ccc.', STARTKEY => '',
> ENDKEY => 'r'}
>
> t1,,1500931628959.e10212c467b78104c911ea06c102ece0 column=info:splitB,
> timestamp=1500931787651, value={ENCODED => d86fbd197ca1073e763cb811705587ec,
> NAME =>
[jira] [Commented] (HBASE-18462) HBase server fails to start when rootdir contains spaces
[
https://issues.apache.org/jira/browse/HBASE-18462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103850#comment-16103850
]
Ismaël Mejía commented on HBASE-18462:
--
You can find the full stacktrace in the linked issue (BEAM-2543). I have the
impression that the error is in HBase, I tried just changing the hbase.rootdir
variable during debugging to make encode use the URI instead of the path (so
space became a valid %20) and it worked, however I didn't go farther because I
realized that the whole Path <-> URI use was more tricky than what I expected.
And about the directory with spaces, I understand that this is not a
recommended practice but I don't see why this should break a server considering
that this is not a weird forbidden character in most filesystems.
> HBase server fails to start when rootdir contains spaces
>
>
> Key: HBASE-18462
> URL: https://issues.apache.org/jira/browse/HBASE-18462
> Project: HBase
> Issue Type: Bug
> Components: hbase, test
>Affects Versions: 1.3.1, 1.2.6
>Reporter: Ismaël Mejía
>Priority: Minor
>
> As part of the tests for the HBase connector for Beam I discovered that when
> you start an HBase server instance from a directory that contains spaces
> (rootdir) it does not start correctly. This happens both with the
> HBaseTestingUtility server and with the binary distribution too.
> The concrete exception says:
> {quote}
> Caused by: java.net.URISyntaxException: Illegal character in path at index
> 89:
> file:/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Java_JDK_Versions_Test/jdk/JDK
> 1.7
> (latest)/label/beam/sdks/java/io/hbase/target/test-data/b11a0828-4628-4fe9-885d-073fb641ddc9
> at java.net.URI$Parser.fail(URI.java:2829)
> at java.net.URI$Parser.checkChars(URI.java:3002)
> at java.net.URI$Parser.parseHierarchical(URI.java:3086)
> at java.net.URI$Parser.parse(URI.java:3034)
> at java.net.URI.(URI.java:595)
> at java.net.URI.create(URI.java:857)
> ... 37 more
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18431) Mitigate compatibility concerns between branch-1.3 and branch-1.4
[
https://issues.apache.org/jira/browse/HBASE-18431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103847#comment-16103847
]
Mike Drob commented on HBASE-18431:
---
I thought there was an extend keyword, but it looks like that's gone in
proto-3. It might not have done what I wanted anyway, though.
We could patch the generated sources, but that seems like a very fragile idea
and liable to cause more problems later.
Your idea to have multiple implementations might be the best of a bunch of bad
options.
This came up for me because I've got some folks on my side trying to write
client code that will work with both branch-1 and branch-2. Happy to test any
patches that you put up.
> Mitigate compatibility concerns between branch-1.3 and branch-1.4
> -
>
> Key: HBASE-18431
> URL: https://issues.apache.org/jira/browse/HBASE-18431
> Project: HBase
> Issue Type: Bug
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0, 1.5.0
>
> Attachments: HBASE-18431-branch-1.4.patch
>
>
> There are compatibility concerns with branch-1.4.
> {noformat}
> Library Name HBase
> Version #11.3.1
> Version #21.4.0-SNAPSHOT
> Subject Binary Compatibility
> Compatibility - 89.9%
> Added Methods - 305
> Removed Methods - 105
> Problems with Data Types
> High - 23
> Medium - 9
> Low - 21
> {noformat}
> {noformat}
> Library Name HBase
> Version #11.3.1
> Version #21.4.0-SNAPSHOT
> Subject Source Compatibility
> Compatibility- 86.5%
> Added Methods - 305
> Removed Methods - 105
> Problems with Data Types
> High - 88
> Medium - 0
> Low - 0
> Other Changes in Data Types- 25
> {noformat}
> This report includes HBASE-15816 which hasn't been committed yet. Otherwise
> it's current.
> I'm not generally concerned with added methods.
> The following methods have been added to Public/Evolving interface Table.
> Pointing them out in case it merits review.
> \\
> * Abstract method Table.getReadRpcTimeout ( ) has been added to this
> interface. No effect.
> * Abstract method Table.getWriteRpcTimeout ( ) has been added to this
> interface. No effect.
> * Abstract method Table.setReadRpcTimeout ( int ) has been added to this
> interface. No effect.
> * Abstract method Table.setWriteRpcTimeout ( int ) has been added to this
> interface.
> The Public/Evolving interface Admin has some signature changes equating to
> removed methods. I don't think this is allowed in a minor release.
> \\
> * Abstract method Admin.isSnapshotFinished ( HBaseProtos.SnapshotDescription
> ) has been removed from Admin.
> * Abstract method Admin.snapshot ( String, TableName,
> HBaseProtos.SnapshotDescription.Type ) has been removed from Admin.
> * Abstract method Admin.snapshot ( HBaseProtos.SnapshotDescription ) has been
> removed from Admin.
> * Abstract method Admin.takeSnapshotAsync ( HBaseProtos.SnapshotDescription
> ) has been removed from Admin.
> The LimitedPrivate(CONFIG) interface AsyncRpcClient has been removed. This
> change is debatable but I think we can allow it.
> \\
> * AsyncRpcClient has been removed
> The Public/Evolving class FastLongHistogram has been removed. I don't believe
> this change is allowed in a minor release.
> \\
> * FastLongHistogram has been removed
> Method signatures in LimitedPrivate(COPROC) interfaces MasterObserver and
> RegionObserver have changed, equating to removed methods. The first set of
> changes is due to move of SnapshotDescription from HBaseProtos to
> SnapshotProtos:
> \\
> * Abstract method MasterObserver.postCloneSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from
> MasterObserver.
> * Abstract method MasterObserver.postDeleteSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription ) has been removed from MasterObserver.
> * Abstract method MasterObserver.postListSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription ) has been removed from MasterObserver.
> * Abstract method MasterObserver.postRestoreSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from
> MasterObserver.
> * Abstract method MasterObserver.postSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from
> MasterObserver.
> * Abstract method MasterObserver.preCloneSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from
> MasterObserver.
> * Abstract method MasterObserver.preDeleteSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription ) has been removed from MasterObserver.
> * Abstract method MasterObserver.preListSnapshot (
> ObserverContext,
[jira] [Issue Comment Deleted] (HBASE-18431) Mitigate compatibility concerns between branch-1.3 and branch-1.4
[
https://issues.apache.org/jira/browse/HBASE-18431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-18431:
---
Comment: was deleted
(was: [~mdrob] Sure I can try that. Not sure if the change to the inheritance
hierarchy is a binary compat problem or not. Will find out shortly. )
> Mitigate compatibility concerns between branch-1.3 and branch-1.4
> -
>
> Key: HBASE-18431
> URL: https://issues.apache.org/jira/browse/HBASE-18431
> Project: HBase
> Issue Type: Bug
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0, 1.5.0
>
> Attachments: HBASE-18431-branch-1.4.patch
>
>
> There are compatibility concerns with branch-1.4.
> {noformat}
> Library Name HBase
> Version #11.3.1
> Version #21.4.0-SNAPSHOT
> Subject Binary Compatibility
> Compatibility - 89.9%
> Added Methods - 305
> Removed Methods - 105
> Problems with Data Types
> High - 23
> Medium - 9
> Low - 21
> {noformat}
> {noformat}
> Library Name HBase
> Version #11.3.1
> Version #21.4.0-SNAPSHOT
> Subject Source Compatibility
> Compatibility- 86.5%
> Added Methods - 305
> Removed Methods - 105
> Problems with Data Types
> High - 88
> Medium - 0
> Low - 0
> Other Changes in Data Types- 25
> {noformat}
> This report includes HBASE-15816 which hasn't been committed yet. Otherwise
> it's current.
> I'm not generally concerned with added methods.
> The following methods have been added to Public/Evolving interface Table.
> Pointing them out in case it merits review.
> \\
> * Abstract method Table.getReadRpcTimeout ( ) has been added to this
> interface. No effect.
> * Abstract method Table.getWriteRpcTimeout ( ) has been added to this
> interface. No effect.
> * Abstract method Table.setReadRpcTimeout ( int ) has been added to this
> interface. No effect.
> * Abstract method Table.setWriteRpcTimeout ( int ) has been added to this
> interface.
> The Public/Evolving interface Admin has some signature changes equating to
> removed methods. I don't think this is allowed in a minor release.
> \\
> * Abstract method Admin.isSnapshotFinished ( HBaseProtos.SnapshotDescription
> ) has been removed from Admin.
> * Abstract method Admin.snapshot ( String, TableName,
> HBaseProtos.SnapshotDescription.Type ) has been removed from Admin.
> * Abstract method Admin.snapshot ( HBaseProtos.SnapshotDescription ) has been
> removed from Admin.
> * Abstract method Admin.takeSnapshotAsync ( HBaseProtos.SnapshotDescription
> ) has been removed from Admin.
> The LimitedPrivate(CONFIG) interface AsyncRpcClient has been removed. This
> change is debatable but I think we can allow it.
> \\
> * AsyncRpcClient has been removed
> The Public/Evolving class FastLongHistogram has been removed. I don't believe
> this change is allowed in a minor release.
> \\
> * FastLongHistogram has been removed
> Method signatures in LimitedPrivate(COPROC) interfaces MasterObserver and
> RegionObserver have changed, equating to removed methods. The first set of
> changes is due to move of SnapshotDescription from HBaseProtos to
> SnapshotProtos:
> \\
> * Abstract method MasterObserver.postCloneSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from
> MasterObserver.
> * Abstract method MasterObserver.postDeleteSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription ) has been removed from MasterObserver.
> * Abstract method MasterObserver.postListSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription ) has been removed from MasterObserver.
> * Abstract method MasterObserver.postRestoreSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from
> MasterObserver.
> * Abstract method MasterObserver.postSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from
> MasterObserver.
> * Abstract method MasterObserver.preCloneSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from
> MasterObserver.
> * Abstract method MasterObserver.preDeleteSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription ) has been removed from MasterObserver.
> * Abstract method MasterObserver.preListSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription ) has been removed from MasterObserver.
> * Abstract method MasterObserver.preRestoreSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from
> MasterObserver.
> * Abstract method MasterObserver.preSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been
[jira] [Commented] (HBASE-18431) Mitigate compatibility concerns between branch-1.3 and branch-1.4
[
https://issues.apache.org/jira/browse/HBASE-18431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103819#comment-16103819
]
Andrew Purtell commented on HBASE-18431:
[~mdrob] How would that work? HBaseProtos and SnapshotProtos are generated
classes from protobuf definitions.
> Mitigate compatibility concerns between branch-1.3 and branch-1.4
> -
>
> Key: HBASE-18431
> URL: https://issues.apache.org/jira/browse/HBASE-18431
> Project: HBase
> Issue Type: Bug
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0, 1.5.0
>
> Attachments: HBASE-18431-branch-1.4.patch
>
>
> There are compatibility concerns with branch-1.4.
> {noformat}
> Library Name HBase
> Version #11.3.1
> Version #21.4.0-SNAPSHOT
> Subject Binary Compatibility
> Compatibility - 89.9%
> Added Methods - 305
> Removed Methods - 105
> Problems with Data Types
> High - 23
> Medium - 9
> Low - 21
> {noformat}
> {noformat}
> Library Name HBase
> Version #11.3.1
> Version #21.4.0-SNAPSHOT
> Subject Source Compatibility
> Compatibility- 86.5%
> Added Methods - 305
> Removed Methods - 105
> Problems with Data Types
> High - 88
> Medium - 0
> Low - 0
> Other Changes in Data Types- 25
> {noformat}
> This report includes HBASE-15816 which hasn't been committed yet. Otherwise
> it's current.
> I'm not generally concerned with added methods.
> The following methods have been added to Public/Evolving interface Table.
> Pointing them out in case it merits review.
> \\
> * Abstract method Table.getReadRpcTimeout ( ) has been added to this
> interface. No effect.
> * Abstract method Table.getWriteRpcTimeout ( ) has been added to this
> interface. No effect.
> * Abstract method Table.setReadRpcTimeout ( int ) has been added to this
> interface. No effect.
> * Abstract method Table.setWriteRpcTimeout ( int ) has been added to this
> interface.
> The Public/Evolving interface Admin has some signature changes equating to
> removed methods. I don't think this is allowed in a minor release.
> \\
> * Abstract method Admin.isSnapshotFinished ( HBaseProtos.SnapshotDescription
> ) has been removed from Admin.
> * Abstract method Admin.snapshot ( String, TableName,
> HBaseProtos.SnapshotDescription.Type ) has been removed from Admin.
> * Abstract method Admin.snapshot ( HBaseProtos.SnapshotDescription ) has been
> removed from Admin.
> * Abstract method Admin.takeSnapshotAsync ( HBaseProtos.SnapshotDescription
> ) has been removed from Admin.
> The LimitedPrivate(CONFIG) interface AsyncRpcClient has been removed. This
> change is debatable but I think we can allow it.
> \\
> * AsyncRpcClient has been removed
> The Public/Evolving class FastLongHistogram has been removed. I don't believe
> this change is allowed in a minor release.
> \\
> * FastLongHistogram has been removed
> Method signatures in LimitedPrivate(COPROC) interfaces MasterObserver and
> RegionObserver have changed, equating to removed methods. The first set of
> changes is due to move of SnapshotDescription from HBaseProtos to
> SnapshotProtos:
> \\
> * Abstract method MasterObserver.postCloneSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from
> MasterObserver.
> * Abstract method MasterObserver.postDeleteSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription ) has been removed from MasterObserver.
> * Abstract method MasterObserver.postListSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription ) has been removed from MasterObserver.
> * Abstract method MasterObserver.postRestoreSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from
> MasterObserver.
> * Abstract method MasterObserver.postSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from
> MasterObserver.
> * Abstract method MasterObserver.preCloneSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from
> MasterObserver.
> * Abstract method MasterObserver.preDeleteSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription ) has been removed from MasterObserver.
> * Abstract method MasterObserver.preListSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription ) has been removed from MasterObserver.
> * Abstract method MasterObserver.preRestoreSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from
> MasterObserver.
> * Abstract method MasterObserver.preSnapshot (
> ObserverContext,
> HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from
>
[jira] [Commented] (HBASE-10092) Move up on to log4j2
[ https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103794#comment-16103794 ] Mikael Ståldal commented on HBASE-10092: That's the correct list. > Move up on to log4j2 > > > Key: HBASE-10092 > URL: https://issues.apache.org/jira/browse/HBASE-10092 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: Alex Newman >Priority: Critical > Fix For: 2.0.0 > > Attachments: 10092.txt, 10092v2.txt, HBASE-10092.patch, > HBASE-10092-preview-v0.patch > > > Allows logging with less friction. See http://logging.apache.org/log4j/2.x/ > This rather radical transition can be done w/ minor change given they have an > adapter for apache's logging, the one we use. They also have and adapter for > slf4j so we likely can remove at least some of the 4 versions of this module > our dependencies make use of. > I made a start in attached patch but am currently stuck in maven dependency > resolve hell courtesy of our slf4j. Fixing will take some concentration and > a good net connection, an item I currently lack. Other TODOs are that will > need to fix our little log level setting jsp page -- will likely have to undo > our use of hadoop's tool here -- and the config system changes a little. > I will return to this project soon. Will bring numbers. > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18463) Replication sink frequently triggers HBASE-18023 warnings
[ https://issues.apache.org/jira/browse/HBASE-18463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103784#comment-16103784 ] Dave Latham commented on HBASE-18463: - Are we warning because these types of operations are harmful or dangerous? It seems like if they are, maybe we should change replication to avoid them, but if they are not, then we shouldn't be warning about them. > Replication sink frequently triggers HBASE-18023 warnings > - > > Key: HBASE-18463 > URL: https://issues.apache.org/jira/browse/HBASE-18463 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Andrew Purtell >Priority: Minor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2 > > > After HBASE-18023 we warn if the number of operations in a multi operation > exceeds a threshold. This is meant to catch potential performance problems or > abusive clients. However while testing simple replication scenarios we have > observed frequent warnings issued as the sink applies received edit batches. > I think we want to either introduce a separate threshold for warning about > RPC submitted by the replication client or exclude ops submitted by the sinks > entirely. Not sure distinguishing the replication client from normal clients > is possible yet. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-15134) Add visibility into Flush and Compaction queues
[ https://issues.apache.org/jira/browse/HBASE-15134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Singh Chouhan updated HBASE-15134: --- Attachment: HBASE-15134.branch-1.001.patch > Add visibility into Flush and Compaction queues > --- > > Key: HBASE-15134 > URL: https://issues.apache.org/jira/browse/HBASE-15134 > Project: HBase > Issue Type: New Feature > Components: Compaction, metrics, regionserver >Reporter: Elliott Clark >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-15134.branch-1.001.patch, > HBASE-15134.master.001.patch, HBASE-15134.master.002.patch, > HBASE-15134.master.003.patch, HBASE-15134.patch, HBASE-15134.patch > > > On busy spurts we can see regionservers start to see large queues for > compaction. It's really hard to tell if the server is queueing a lot of > compactions for the same region, lots of compactions for lots of regions, or > just falling behind. > For flushes much the same. There can be flushes in queue that aren't being > run because of delayed flushes. There's no way to know from the metrics how > many flushes are for each region, how many are delayed. Etc. > We should add either more metrics around this ( num per region, max per > region, min per region ) or add on a UI page that has the list of compactions > and flushes. > Or both. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10092) Move up on to log4j2
[ https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103780#comment-16103780 ] Sean Busbey commented on HBASE-10092: - thanks for the update. I'll bring some concerns over to dev@logging.a.o, if that's the correct list. > Move up on to log4j2 > > > Key: HBASE-10092 > URL: https://issues.apache.org/jira/browse/HBASE-10092 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: Alex Newman >Priority: Critical > Fix For: 2.0.0 > > Attachments: 10092.txt, 10092v2.txt, HBASE-10092.patch, > HBASE-10092-preview-v0.patch > > > Allows logging with less friction. See http://logging.apache.org/log4j/2.x/ > This rather radical transition can be done w/ minor change given they have an > adapter for apache's logging, the one we use. They also have and adapter for > slf4j so we likely can remove at least some of the 4 versions of this module > our dependencies make use of. > I made a start in attached patch but am currently stuck in maven dependency > resolve hell courtesy of our slf4j. Fixing will take some concentration and > a good net connection, an item I currently lack. Other TODOs are that will > need to fix our little log level setting jsp page -- will likely have to undo > our use of hadoop's tool here -- and the config system changes a little. > I will return to this project soon. Will bring numbers. > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17839) "Data Model" section: Table 1 has only 5 data rows instead 6.
[ https://issues.apache.org/jira/browse/HBASE-17839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-17839: Resolution: Fixed Fix Version/s: 3.0.0 Status: Resolved (was: Patch Available) Thanks again [~kenmy]! [final commit w/updated message is here|https://github.com/apache/hbase/commit/3536c58afb6ebccd8f9a31beb17d16e74c1ac834] In future contributions, please take a look at [our patch creation guidelines|http://hbase.apache.org/book.html#submitting.patches.create]. In particular, it's important to start your commit message with the JIRA ID. > "Data Model" section: Table 1 has only 5 data rows instead 6. > - > > Key: HBASE-17839 > URL: https://issues.apache.org/jira/browse/HBASE-17839 > Project: HBase > Issue Type: Bug > Components: documentation >Affects Versions: 2.0.0 >Reporter: Evgeny Kincharov >Assignee: Evgeny Kincharov >Priority: Trivial > Labels: documentation, patch-available, trivial > Fix For: 3.0.0 > > Attachments: 823ac3e0e619f7531513efe6e4b43a6fea7437c6.patch > > > The table from http://hbase.apache.org/book.html#conceptual.view has only 5 > data rows. > Originally intended that there will be 6: > https://raw.githubusercontent.com/apache/hbase/master/src/main/asciidoc/_chapters/datamodel.adoc -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17131) Avoid livelock caused by HRegion#processRowsWithLocks
[
https://issues.apache.org/jira/browse/HBASE-17131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-17131:
---
Attachment: HBASE-17131.branch-1.3.v0.patch
> Avoid livelock caused by HRegion#processRowsWithLocks
> -
>
> Key: HBASE-17131
> URL: https://issues.apache.org/jira/browse/HBASE-17131
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 2.0.0, 1.4.0, 1.3.1, 1.2.6
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.2.7
>
> Attachments: HBASE-17131.branch-1.3.v0.patch,
> HBASE-17131.branch-1.v0.patch, HBASE-17131.v0.patch
>
>
> {code:title=HRegion.java|borderStyle=solid}
> try {
> // STEP 2. Acquire the row lock(s)
> acquiredRowLocks = new ArrayList(rowsToLock.size());
> for (byte[] row : rowsToLock) {
> // Attempt to lock all involved rows, throw if any lock times out
> // use a writer lock for mixed reads and writes
> acquiredRowLocks.add(getRowLockInternal(row, false));
> }
> // STEP 3. Region lock
> lock(this.updatesLock.readLock(), acquiredRowLocks.size() == 0 ? 1 :
> acquiredRowLocks.size());
> locked = true;
> boolean success = false;
> long now = EnvironmentEdgeManager.currentTime();
> try {
> {code}
> We should lock all involved rows in the second try-finally. Otherwise, we
> won’t release the previous locks if any subsequent lock times out.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-17131) Avoid livelock caused by HRegion#processRowsWithLocks
[
https://issues.apache.org/jira/browse/HBASE-17131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-17131:
---
Status: Patch Available (was: Reopened)
> Avoid livelock caused by HRegion#processRowsWithLocks
> -
>
> Key: HBASE-17131
> URL: https://issues.apache.org/jira/browse/HBASE-17131
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 1.2.6, 1.3.1, 2.0.0, 1.4.0
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.2.7
>
> Attachments: HBASE-17131.branch-1.3.v0.patch,
> HBASE-17131.branch-1.v0.patch, HBASE-17131.v0.patch
>
>
> {code:title=HRegion.java|borderStyle=solid}
> try {
> // STEP 2. Acquire the row lock(s)
> acquiredRowLocks = new ArrayList(rowsToLock.size());
> for (byte[] row : rowsToLock) {
> // Attempt to lock all involved rows, throw if any lock times out
> // use a writer lock for mixed reads and writes
> acquiredRowLocks.add(getRowLockInternal(row, false));
> }
> // STEP 3. Region lock
> lock(this.updatesLock.readLock(), acquiredRowLocks.size() == 0 ? 1 :
> acquiredRowLocks.size());
> locked = true;
> boolean success = false;
> long now = EnvironmentEdgeManager.currentTime();
> try {
> {code}
> We should lock all involved rows in the second try-finally. Otherwise, we
> won’t release the previous locks if any subsequent lock times out.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17839) "Data Model" section: Table 1 has only 5 data rows instead 6.
[ https://issues.apache.org/jira/browse/HBASE-17839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103763#comment-16103763 ] Sean Busbey commented on HBASE-17839: - looks good to me, I'll push it shortly. > "Data Model" section: Table 1 has only 5 data rows instead 6. > - > > Key: HBASE-17839 > URL: https://issues.apache.org/jira/browse/HBASE-17839 > Project: HBase > Issue Type: Bug > Components: documentation >Affects Versions: 2.0.0 >Reporter: Evgeny Kincharov >Assignee: Evgeny Kincharov >Priority: Trivial > Labels: documentation, patch-available, trivial > Attachments: 823ac3e0e619f7531513efe6e4b43a6fea7437c6.patch > > > The table from http://hbase.apache.org/book.html#conceptual.view has only 5 > data rows. > Originally intended that there will be 6: > https://raw.githubusercontent.com/apache/hbase/master/src/main/asciidoc/_chapters/datamodel.adoc -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17839) "Data Model" section: Table 1 has only 5 data rows instead 6.
[
https://issues.apache.org/jira/browse/HBASE-17839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103762#comment-16103762
]
Sean Busbey commented on HBASE-17839:
-
thanks for the fix!
{quote}
-1 test4tests 0m 0s The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch.
{quote}
This is a docs only fix, so this is a false negative.
{quote}
-1 unit122m 34sroot in the patch failed.
{quote}
This is a docs only fix, so this is a false negative.
{quote}
-1 asflicense 0m 24s The patch generated 1 ASF License warnings.
{quote}
I think this is a side effect of HBASE-18376. It definitely isn't related to
your change, so we can ignore it.
> "Data Model" section: Table 1 has only 5 data rows instead 6.
> -
>
> Key: HBASE-17839
> URL: https://issues.apache.org/jira/browse/HBASE-17839
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Evgeny Kincharov
>Assignee: Evgeny Kincharov
>Priority: Trivial
> Labels: documentation, patch-available, trivial
> Attachments: 823ac3e0e619f7531513efe6e4b43a6fea7437c6.patch
>
>
> The table from http://hbase.apache.org/book.html#conceptual.view has only 5
> data rows.
> Originally intended that there will be 6:
> https://raw.githubusercontent.com/apache/hbase/master/src/main/asciidoc/_chapters/datamodel.adoc
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (HBASE-17839) "Data Model" section: Table 1 has only 5 data rows instead 6.
[ https://issues.apache.org/jira/browse/HBASE-17839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey reassigned HBASE-17839: --- Assignee: Evgeny Kincharov > "Data Model" section: Table 1 has only 5 data rows instead 6. > - > > Key: HBASE-17839 > URL: https://issues.apache.org/jira/browse/HBASE-17839 > Project: HBase > Issue Type: Bug > Components: documentation >Affects Versions: 2.0.0 >Reporter: Evgeny Kincharov >Assignee: Evgeny Kincharov >Priority: Trivial > Labels: documentation, patch-available, trivial > Attachments: 823ac3e0e619f7531513efe6e4b43a6fea7437c6.patch > > > The table from http://hbase.apache.org/book.html#conceptual.view has only 5 > data rows. > Originally intended that there will be 6: > https://raw.githubusercontent.com/apache/hbase/master/src/main/asciidoc/_chapters/datamodel.adoc -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18376) Flaky exclusion doesn't appear to work in precommit
[
https://issues.apache.org/jira/browse/HBASE-18376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103735#comment-16103735
]
Sean Busbey commented on HBASE-18376:
-
huh, and I think we might be causing failures for RAT checks now
[eg|https://builds.apache.org/job/PreCommit-HBASE-Build/7809/artifact/patchprocess/patch-asflicense-problems.txt]
{code}
Lines that start with ? in the ASF License report indicate files that do
not have an Apache license header:
!? excludes
{code}
> Flaky exclusion doesn't appear to work in precommit
> ---
>
> Key: HBASE-18376
> URL: https://issues.apache.org/jira/browse/HBASE-18376
> Project: HBase
> Issue Type: Bug
> Components: community, test
>Reporter: Sean Busbey
>Priority: Critical
> Attachments: HBASE-18376.master.001.patch
>
>
> Yesterday we started defaulting the precommit parameter for the flaky test
> list to point to the job on builds.a.o. Looks like the personality is
> ignoring it.
> example build that's marked to keep:
> https://builds.apache.org/job/PreCommit-HBASE-Build/7646/
> (search for 'Running unit tests' to skip to the right part of the console')
> should add some more debug output in there too.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18374) RegionServer Metrics improvements
[ https://issues.apache.org/jira/browse/HBASE-18374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Singh Chouhan updated HBASE-18374: --- Attachment: HBASE-18374.branch-1.002.patch > RegionServer Metrics improvements > - > > Key: HBASE-18374 > URL: https://issues.apache.org/jira/browse/HBASE-18374 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan > Fix For: 3.0.0 > > Attachments: HBASE-18374.branch-1.001.patch, > HBASE-18374.branch-1.001.patch, HBASE-18374.branch-1.002.patch, > HBASE-18374.master.001.patch, HBASE-18374.master.002.patch, > HBASE-18374.master.003.patch, HBASE-18374.master.004.patch > > > At the RS level we have latency metrics for mutate/puts and deletes that are > updated per batch (ie. at the end of entire batchop if it contains put/delete > update the respective metric) in contrast with append/increment/get metrics > that are updated per op. This is a bit ambiguous since the delete and put > metrics are updated for multi row mutations that happen to contain a > put/delete. We should rename the metric(eg. delete_batch)/add better > description. Also we should add metrics for single delete client operations > that come through RSRpcServer.mutate path. We should also add metrics for > checkAndPut and checkAndDelete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10092) Move up on to log4j2
[ https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103710#comment-16103710 ] Mikael Ståldal commented on HBASE-10092: Yes, we have not made much progress recently on supporting Log4j 1.x config files. We have partial support, but it may not be very useful in practice. Full support would require some more work, and none of the core developers have prioritized that recently. We will soon make a new release (2.9) but it will most likely not contain this. > Move up on to log4j2 > > > Key: HBASE-10092 > URL: https://issues.apache.org/jira/browse/HBASE-10092 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: Alex Newman >Priority: Critical > Fix For: 2.0.0 > > Attachments: 10092.txt, 10092v2.txt, HBASE-10092.patch, > HBASE-10092-preview-v0.patch > > > Allows logging with less friction. See http://logging.apache.org/log4j/2.x/ > This rather radical transition can be done w/ minor change given they have an > adapter for apache's logging, the one we use. They also have and adapter for > slf4j so we likely can remove at least some of the 4 versions of this module > our dependencies make use of. > I made a start in attached patch but am currently stuck in maven dependency > resolve hell courtesy of our slf4j. Fixing will take some concentration and > a good net connection, an item I currently lack. Other TODOs are that will > need to fix our little log level setting jsp page -- will likely have to undo > our use of hadoop's tool here -- and the config system changes a little. > I will return to this project soon. Will bring numbers. > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17131) Avoid livelock caused by HRegion#processRowsWithLocks
[
https://issues.apache.org/jira/browse/HBASE-17131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-17131:
---
Affects Version/s: 1.2.6
> Avoid livelock caused by HRegion#processRowsWithLocks
> -
>
> Key: HBASE-17131
> URL: https://issues.apache.org/jira/browse/HBASE-17131
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 2.0.0, 1.4.0, 1.3.1, 1.2.6
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.2.7
>
> Attachments: HBASE-17131.branch-1.v0.patch, HBASE-17131.v0.patch
>
>
> {code:title=HRegion.java|borderStyle=solid}
> try {
> // STEP 2. Acquire the row lock(s)
> acquiredRowLocks = new ArrayList(rowsToLock.size());
> for (byte[] row : rowsToLock) {
> // Attempt to lock all involved rows, throw if any lock times out
> // use a writer lock for mixed reads and writes
> acquiredRowLocks.add(getRowLockInternal(row, false));
> }
> // STEP 3. Region lock
> lock(this.updatesLock.readLock(), acquiredRowLocks.size() == 0 ? 1 :
> acquiredRowLocks.size());
> locked = true;
> boolean success = false;
> long now = EnvironmentEdgeManager.currentTime();
> try {
> {code}
> We should lock all involved rows in the second try-finally. Otherwise, we
> won’t release the previous locks if any subsequent lock times out.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (HBASE-18464) Backport HBASE-17131 (Avoid livelock caused by HRegion#processRowsWithLocks) into branch-1.3 and branch-1.2
[ https://issues.apache.org/jira/browse/HBASE-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved HBASE-18464. Resolution: Duplicate > Backport HBASE-17131 (Avoid livelock caused by HRegion#processRowsWithLocks) > into branch-1.3 and branch-1.2 > --- > > Key: HBASE-18464 > URL: https://issues.apache.org/jira/browse/HBASE-18464 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.1, 1.2.6 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 1.3.2, 1.2.7 > > > see HBASE-17131 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17131) Avoid livelock caused by HRegion#processRowsWithLocks
[
https://issues.apache.org/jira/browse/HBASE-17131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103705#comment-16103705
]
Chia-Ping Tsai commented on HBASE-17131:
bq. this issue hasn't gone out in a release yet, let's just do the backport
here and update the fix versions.
Okay, copy that.
> Avoid livelock caused by HRegion#processRowsWithLocks
> -
>
> Key: HBASE-17131
> URL: https://issues.apache.org/jira/browse/HBASE-17131
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 2.0.0, 1.4.0, 1.3.1
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.2.7
>
> Attachments: HBASE-17131.branch-1.v0.patch, HBASE-17131.v0.patch
>
>
> {code:title=HRegion.java|borderStyle=solid}
> try {
> // STEP 2. Acquire the row lock(s)
> acquiredRowLocks = new ArrayList(rowsToLock.size());
> for (byte[] row : rowsToLock) {
> // Attempt to lock all involved rows, throw if any lock times out
> // use a writer lock for mixed reads and writes
> acquiredRowLocks.add(getRowLockInternal(row, false));
> }
> // STEP 3. Region lock
> lock(this.updatesLock.readLock(), acquiredRowLocks.size() == 0 ? 1 :
> acquiredRowLocks.size());
> locked = true;
> boolean success = false;
> long now = EnvironmentEdgeManager.currentTime();
> try {
> {code}
> We should lock all involved rows in the second try-finally. Otherwise, we
> won’t release the previous locks if any subsequent lock times out.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
