[jira] [Created] (HBASE-18500) Performance issue: Don't use BufferedMutator for HTable's put method
Guanghao Zhang created HBASE-18500:
--
Summary: Performance issue: Don't use BufferedMutator for HTable's
put method
Key: HBASE-18500
URL: https://issues.apache.org/jira/browse/HBASE-18500
Project: HBase
Issue Type: Bug
Reporter: Guanghao Zhang
Copied the test result from HBASE-17994.
Run start-hbase.sh in my local computer and use the default config to test with
PE tool.
{code}
./bin/hbase org.apache.hadoop.hbase.PerformanceEvaluation --rows=10
--nomapred --autoFlush=True randomWrite 1
./bin/hbase org.apache.hadoop.hbase.PerformanceEvaluation --rows=10
--nomapred --autoFlush=True asyncRandomWrite 1
{code}
Mean latency test result.
|| || Test1 || Test2 || Test3 || Test4 || Test5 ||
| randomWrite | 164.39 | 161.22 | 164.78 | 140.61 | 151.69 |
| asyncRandomWrite | 122.29 | 125.58 | 122.23 | 113.18 | 123.02 |
50th latency test result.
|| || Test1 || Test2 || Test3 || Test4 || Test5 ||
| randomWrite | 130.00 | 125.00 | 123.00 | 112.00 | 121.00 |
| asyncRandomWrite | 95.00 | 97.00 | 95.00 | 88.00 | 95.00 |
99th latency test result.
|| || Test1 || Test2 || Test3 || Test4 || Test5 ||
| randomWrite | 600.00 | 600.00 | 650.00 | 404.00 | 425.00 |
| asyncRandomWrite | 339.00 | 327.00 | 297.00 | 311.00 | 318.00 |
In our internal 0.98 branch, the PE test result shows the async write has the
almost same latency with the blocking write. But for master branch, the result
shows the async write has better latency than the blocking client. Take a look
about the code, I thought the difference is the BufferedMutator. For master
branch, HTable don't have a write buffer and all write request will be flushed
directly. And user can use BufferedMutator when user want to perform
client-side buffering of writes. For the performance issue (autoFlush=True), I
thought we can use rpc caller directly in HTable's put method. Thanks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18395) Update clock on region open and close
[ https://issues.apache.org/jira/browse/HBASE-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110333#comment-16110333 ] Hudson commented on HBASE-18395: FAILURE: Integrated in Jenkins build HBASE-14070.HLC #159 (See [https://builds.apache.org/job/HBASE-14070.HLC/159/]) HBASE-18395 Update clock on region open and close (revision 5) (appy: rev 386b1df1dd9c44bdf5d60d9519c8179af2f75ddb) * (edit) hbase-protocol-shaded/src/main/protobuf/Admin.proto * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/Clock.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java * (edit) hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/generated/AdminProtos.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWALLockup.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestWALReplay.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestClockWithCluster.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * (edit) hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/QuotaProtos.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionSplitPolicy.java * (edit) hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/generated/HBaseProtos.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerServices.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestIncrementTimeRange.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerNoMaster.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockNoopMasterServices.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/MockRegionServerServices.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicasClient.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java * (edit) hbase-protocol-shaded/src/main/protobuf/HBase.proto * (edit) hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java > Update clock on region open and close > - > > Key: HBASE-18395 > URL: https://issues.apache.org/jira/browse/HBASE-18395 > Project: HBase > Issue Type: Sub-task >Reporter: Amit Patel >Assignee: Amit Patel >Priority: Minor > Attachments: HBASE-18395.HBASE-14070.HLC.001.patch, > HBASE-18395.HBASE-14070.HLC.002.patch, HBASE-18395.HBASE-14070.HLC.003.patch, > HBASE-18395.HBASE-14070.HLC.004.patch, HBASE-18395.HBASE-14070.HLC.005.patch, > HBASE-18395.HBASE-14070.HLC.006.patch > > > This task covers the patch for updating the clock on region opening and > closing. > The patch would include the following: > * Addition of a new protobuf message type that contains a field for a > timestamp > * Setting of timestamp field in building region open/close request and > response messages > * Updating the clock upon receiving message > The patch for this task will be going against the > [HBASE-14070.HLC|https://git-wip-us.apache.org/repos/asf?p=hbase.git;a=shortlog;h=refs/heads/HBASE-14070.HLC] > branch with the intent that it would be added as a commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14070) Hybrid Logical Clocks for HBase
[ https://issues.apache.org/jira/browse/HBASE-14070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110332#comment-16110332 ] Hudson commented on HBASE-14070: FAILURE: Integrated in Jenkins build HBASE-14070.HLC #159 (See [https://builds.apache.org/job/HBASE-14070.HLC/159/]) HBASE-14070 Fix TestTimestampType#testPhysicalIsLikelyOfType and (appy: rev 0f52f68de18083ff436596ded1654f4710bb0343) * (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestTimestampType.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/TimestampType.java > Hybrid Logical Clocks for HBase > --- > > Key: HBASE-14070 > URL: https://issues.apache.org/jira/browse/HBASE-14070 > Project: HBase > Issue Type: New Feature >Reporter: Enis Soztutar >Assignee: Amit Patel > Attachments: HBASE-14070.master.001.patch, > HybridLogicalClocksforHBaseandPhoenix.docx, > HybridLogicalClocksforHBaseandPhoenix.pdf > > > HBase and Phoenix uses systems physical clock (PT) to give timestamps to > events (read and writes). This works mostly when the system clock is strictly > monotonically increasing and there is no cross-dependency between servers > clocks. However we know that leap seconds, general clock skew and clock drift > are in fact real. > This jira proposes using Hybrid Logical Clocks (HLC) as an implementation of > hybrid physical clock + a logical clock. HLC is best of both worlds where it > keeps causality relationship similar to logical clocks, but still is > compatible with NTP based physical system clock. HLC can be represented in > 64bits. > A design document is attached and also can be found here: > https://docs.google.com/document/d/1LL2GAodiYi0waBz5ODGL4LDT4e_bXy8P9h6kWC05Bhw/edit# -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18470) `RetriesExhaustedWithDetailsException#getDesc` describe is not right
[ https://issues.apache.org/jira/browse/HBASE-18470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110315#comment-16110315 ] Benedict Jin commented on HBASE-18470: -- Hi [~chia7712]. Thx for your comment. Sorry, I don't understand your point. Maybe you made a mistake that we don't think the `getDesc()` has the performance issues and we just discuss `substring` solution is always faster than `skipping add comma`. If you look at the description of this issues, you will figure out the meanning of the issues. By the way, i think you should take a look at the patch file, the code already considered the situation about uniqAddr is empty. Anyway, thx again. > `RetriesExhaustedWithDetailsException#getDesc` describe is not right > > > Key: HBASE-18470 > URL: https://issues.apache.org/jira/browse/HBASE-18470 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Benedict Jin >Assignee: Benedict Jin > Attachments: HBASE-18470.master.001.patch > > Original Estimate: 72h > Remaining Estimate: 72h > > The describe from `RetriesExhaustedWithDetailsException#getDesc` is ` > org.apache.hadoop.hbase.client.RetriesExhaustedWithDetailsException: Failed 3 > actions: FailedServerException: 3 times, `, there is a not need ', ' in the > tail. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18490) Modifying a table descriptor to enable replicas does not create replica regions
[
https://issues.apache.org/jira/browse/HBASE-18490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110311#comment-16110311
]
ramkrishna.s.vasudevan commented on HBASE-18490:
[~enis]
Thanks for the pointers.
bq.TestMasterOperationsForRegionReplicas#testCreateTableWithMultipleReplicas()
have a section to increase the number of replicas.
Yes. But I can see that the code pertaining to increasing the number of
replicas has been commented out.
{code}
/* DISABLED! FOR NOW
{code}
So I think it is a known limitation?
> Modifying a table descriptor to enable replicas does not create replica
> regions
> ---
>
> Key: HBASE-18490
> URL: https://issues.apache.org/jira/browse/HBASE-18490
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment
>Affects Versions: 1.3.1, 1.2.6, 2.0.0-alpha-1
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Attachments: TestRegionReplicasWithRestartScenarios.java
>
>
> After creating a table, if we try to modify the table to enable region
> replication, the new Htable Descriptor is not taken into account and the
> table is enabled again with default single region.
> Ping [~enis], [~tedyu], [~devaraj].
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18480) The cost of BaseLoadBalancer.cluster is changed even if the rollback is done
[ https://issues.apache.org/jira/browse/HBASE-18480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110303#comment-16110303 ] Hudson commented on HBASE-18480: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3477 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3477/]) HBASE-18480 The cost of BaseLoadBalancer.cluster is changed even if the (chia7712: rev f260f09865a0f10da2cd4c700a47ddf48ded982c) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java > The cost of BaseLoadBalancer.cluster is changed even if the rollback is done > > > Key: HBASE-18480 > URL: https://issues.apache.org/jira/browse/HBASE-18480 > Project: HBase > Issue Type: Bug > Components: Balancer >Affects Versions: 3.0.0, 1.3.0, 1.2.6, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18480.branch-1.2.v0.patch, > HBASE-18480.branch-1.3.v0.patch, HBASE-18480.branch-1.v0.patch, > HBASE-18480.branch-1.v1.patch, HBASE-18480.v0.patch, HBASE-18480.v1.patch, > HBASE-18480.v1.patch > > > If the cost of cluster isn't restored after the undo action, > StochasticLoadBalancer will be hard to generate the "good" action to balance > the cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18491) [AMv2] Fail UnassignProcedure if source Region Server is not online.
[ https://issues.apache.org/jira/browse/HBASE-18491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110302#comment-16110302 ] Hudson commented on HBASE-18491: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3477 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3477/]) HBASE-18491 [AMv2] Fail UnassignProcedure if source Region Server is not (stack: rev ba5e8706dee615357222ab652fcc9bc2a1923a94) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestServerCrashProcedure.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/UnassignProcedure.java > [AMv2] Fail UnassignProcedure if source Region Server is not online. > > > Key: HBASE-18491 > URL: https://issues.apache.org/jira/browse/HBASE-18491 > Project: HBase > Issue Type: Bug > Components: amv2 >Affects Versions: 2.0.0 >Reporter: Umesh Agashe >Assignee: Umesh Agashe >Priority: Critical > Fix For: 2.0.0 > > Attachments: hbase-18491.master.001.patch > > > Currently UnassignProcedure returns success when server carrying a region is > NOT online. Assumption here is that ServerCrashProcedure will handle > splitting logs etc for these regions. When UnassignProcedure completes, > MoveRegionProcedure resumes with AssignProcedure. AssignProcedure can some > times assign regions without pre-requisite steps (done either by > UnassignProcedure or ServerCrashProcedure). Fix is to fail UnassignProcedure > and parent MoveRegionProcedure if source server is not online. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18498) Design improvements to Clock.java
[
https://issues.apache.org/jira/browse/HBASE-18498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110295#comment-16110295
]
Hadoop QA commented on HBASE-18498:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
27s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
44s{color} | {color:red} hbase-server in HBASE-14070.HLC has 10 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
29m 6s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
23s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
15s{color} | {color:red} hbase-common generated 1 new + 0 unchanged - 0 fixed =
1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
25s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 94m 17s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
44s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}144m 50s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure |
| | org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence |
| | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
| | org.apache.hadoop.hbase.client.TestFromClientSide |
| | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
| | org.apache.hadoop.hbase.master.TestAssignmentManagerMetrics |
| | org.apache.hadoop.hbase.namespace.TestNamespaceAuditor |
| | org.apache.hadoop.hbase.TestHBaseTestingUtility |
| |
[jira] [Commented] (HBASE-16290) Dump summary of callQueue content; can help debugging
[ https://issues.apache.org/jira/browse/HBASE-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110280#comment-16110280 ] Chia-Ping Tsai commented on HBASE-16290: Why not dump something for FifoRpcScheduler? > Dump summary of callQueue content; can help debugging > - > > Key: HBASE-16290 > URL: https://issues.apache.org/jira/browse/HBASE-16290 > Project: HBase > Issue Type: Bug > Components: Operability >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Sreeram Venkatasubramanian >Priority: Critical > Labels: beginner > Fix For: 2.0.0 > > Attachments: 0001-Dump-Call-Queue-Summary.patch, > DebugDump_screenshot.png, Sample Summary.txt > > > Being able to get a clue what is in a backedup callQueue could give insight > on what is going on on a jacked server. Just needs to summarize count, sizes, > call types. Useful debugging. In a servlet? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16290) Dump summary of callQueue content; can help debugging
[
https://issues.apache.org/jira/browse/HBASE-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110264#comment-16110264
]
Chia-Ping Tsai commented on HBASE-16290:
{code}
+ @Override
+ public Map getCallQueueCountsSummary() {
+return new HashMap<>();
+ }
+
+ @Override
+ public Map getCallQueueSizeSummary() {
+return new HashMap<>();
+ }
+
+ @Override
+ public Map getPriorityQueueCountsSummary() {
+return new HashMap<>();
+ }
+
+ @Override
+ public Map getPriorityQueueSizeSummary() {
+return new HashMap<>();
+ }
+
+ @Override
+ public Map getReplicationQueueCountsSummary() {
+return new HashMap<>();
+ }
+
+ @Override
+ public Map getReplicationQueueSizeSummary() {
+return new HashMap<>();
+ }
{code}
Instead of creating an new HashMap, you can use Collections.EMPTY_MAP.
> Dump summary of callQueue content; can help debugging
> -
>
> Key: HBASE-16290
> URL: https://issues.apache.org/jira/browse/HBASE-16290
> Project: HBase
> Issue Type: Bug
> Components: Operability
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Sreeram Venkatasubramanian
>Priority: Critical
> Labels: beginner
> Fix For: 2.0.0
>
> Attachments: 0001-Dump-Call-Queue-Summary.patch,
> DebugDump_screenshot.png, Sample Summary.txt
>
>
> Being able to get a clue what is in a backedup callQueue could give insight
> on what is going on on a jacked server. Just needs to summarize count, sizes,
> call types. Useful debugging. In a servlet?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18485) Performance issue: ClientAsyncPrefetchScanner is slower than ClientSimpleScanner
[
https://issues.apache.org/jira/browse/HBASE-18485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110258#comment-16110258
]
Hadoop QA commented on HBASE-18485:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
35m 34s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
54s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 48m 23s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18485 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12879949/HBASE-18485-v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 6cb70ac6d3ea 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / f260f09 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7882/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7882/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Performance issue: ClientAsyncPrefetchScanner is slower than
> ClientSimpleScanner
>
>
> Key: HBASE-18485
> URL: https://issues.apache.org/jira/browse/HBASE-18485
> Project: HBase
> Issue Type: Bug
>Reporter:
[jira] [Commented] (HBASE-16290) Dump summary of callQueue content; can help debugging
[ https://issues.apache.org/jira/browse/HBASE-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110246#comment-16110246 ] Sreeram Venkatasubramanian commented on HBASE-16290: Hi [~saint@gmail.com], I have attached a patch for this change. Also attaching a sample screenshot for reference. > Dump summary of callQueue content; can help debugging > - > > Key: HBASE-16290 > URL: https://issues.apache.org/jira/browse/HBASE-16290 > Project: HBase > Issue Type: Bug > Components: Operability >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Sreeram Venkatasubramanian >Priority: Critical > Labels: beginner > Fix For: 2.0.0 > > Attachments: 0001-Dump-Call-Queue-Summary.patch, > DebugDump_screenshot.png, Sample Summary.txt > > > Being able to get a clue what is in a backedup callQueue could give insight > on what is going on on a jacked server. Just needs to summarize count, sizes, > call types. Useful debugging. In a servlet? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16290) Dump summary of callQueue content; can help debugging
[ https://issues.apache.org/jira/browse/HBASE-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sreeram Venkatasubramanian updated HBASE-16290: --- Attachment: DebugDump_screenshot.png > Dump summary of callQueue content; can help debugging > - > > Key: HBASE-16290 > URL: https://issues.apache.org/jira/browse/HBASE-16290 > Project: HBase > Issue Type: Bug > Components: Operability >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Sreeram Venkatasubramanian >Priority: Critical > Labels: beginner > Fix For: 2.0.0 > > Attachments: 0001-Dump-Call-Queue-Summary.patch, > DebugDump_screenshot.png, Sample Summary.txt > > > Being able to get a clue what is in a backedup callQueue could give insight > on what is going on on a jacked server. Just needs to summarize count, sizes, > call types. Useful debugging. In a servlet? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18431) Mitigate compatibility concerns between branch-1.3 and branch-1.4
[
https://issues.apache.org/jira/browse/HBASE-18431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110243#comment-16110243
]
Hudson commented on HBASE-18431:
FAILURE: Integrated in Jenkins build HBase-2.0 #276 (See
[https://builds.apache.org/job/HBase-2.0/276/])
HBASE-18431 Mitigate compatibility concerns between branch-1.3 and (stack: rev
5e21e30682147a45c50ff7067ed40d21bb52239d)
* (edit) hbase-protocol/src/main/protobuf/Client.proto
* (edit) hbase-rsgroup/src/main/protobuf/RSGroup.proto
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RSGroupProtos.java
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupProtobufUtil.java
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RSGroupAdminProtos.java
* (edit) hbase-rsgroup/src/main/protobuf/RSGroupAdmin.proto
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* (edit)
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
* (add) hbase-protocol/src/main/protobuf/Table.proto
* (edit)
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
* (edit) hbase-protocol/src/main/protobuf/HBase.proto
* (edit)
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java
* (edit) hbase-protocol/src/main/protobuf/AccessControl.proto
* (edit) hbase-protocol/src/main/protobuf/ZooKeeper.proto
* (edit)
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/QuotaProtos.java
* (edit)
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
* (add)
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/TableProtos.java
* (edit) hbase-protocol/src/main/protobuf/WAL.proto
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
* (edit)
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AccessControlProtos.java
> Mitigate compatibility concerns between branch-1.3 and branch-1.4
> -
>
> Key: HBASE-18431
> URL: https://issues.apache.org/jira/browse/HBASE-18431
> Project: HBase
> Issue Type: Bug
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0, 1.5.0
>
> Attachments: HBASE-18431-branch-1.4.patch,
> HBASE-18431-branch-1.patch, HBASE-18431-branch-2-WIP.patch
>
>
> There are compatibility concerns with branch-1.4.
> {noformat}
> Library Name HBase
> Version #11.3.1
> Version #21.4.0-SNAPSHOT
> Subject Binary Compatibility
> Compatibility - 89.9%
> Added Methods - 305
> Removed Methods - 105
> Problems with Data Types
> High - 23
> Medium - 9
> Low - 21
> {noformat}
> {noformat}
> Library Name HBase
> Version #11.3.1
> Version #21.4.0-SNAPSHOT
> Subject Source Compatibility
> Compatibility- 86.5%
> Added Methods - 305
> Removed Methods - 105
> Problems with Data Types
> High - 88
> Medium - 0
> Low - 0
> Other Changes in Data Types- 25
> {noformat}
> This report includes HBASE-15816 which hasn't been committed yet. Otherwise
> it's current.
> I'm not generally concerned with added methods.
> The following methods have been added to Public/Evolving interface Table.
> Pointing them out in case it merits review.
> \\
> * Abstract method Table.getReadRpcTimeout ( ) has been added to this
> interface. No effect.
> * Abstract method Table.getWriteRpcTimeout ( ) has been added to this
> interface. No effect.
> * Abstract method Table.setReadRpcTimeout ( int ) has been added to this
> interface. No effect.
> * Abstract method Table.setWriteRpcTimeout ( int ) has been added to this
> interface.
> The Public/Evolving interface Admin has some signature changes equating to
> removed methods. I don't think this is allowed in a minor release.
> \\
> * Abstract method Admin.isSnapshotFinished ( HBaseProtos.SnapshotDescription
> ) has been removed from Admin.
> * Abstract method Admin.snapshot ( String, TableName,
> HBaseProtos.SnapshotDescription.Type ) has been removed from Admin.
> * Abstract method Admin.snapshot ( HBaseProtos.SnapshotDescription ) has been
> removed from Admin.
> * Abstract method Admin.takeSnapshotAsync ( HBaseProtos.SnapshotDescription
> ) has been removed from Admin.
> The LimitedPrivate(CONFIG) interface AsyncRpcClient has been removed. This
> change is debatable but I think we can allow it.
> \\
> * AsyncRpcClient has been removed
> The Public/Evolving class FastLongHistogram has been removed. I don't believe
> this change is allowed in a minor release.
> \\
> * FastLongHistogram has been removed
> Method signatures in LimitedPrivate(COPROC)
[jira] [Commented] (HBASE-18480) The cost of BaseLoadBalancer.cluster is changed even if the rollback is done
[ https://issues.apache.org/jira/browse/HBASE-18480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110245#comment-16110245 ] Hudson commented on HBASE-18480: FAILURE: Integrated in Jenkins build HBase-2.0 #276 (See [https://builds.apache.org/job/HBase-2.0/276/]) HBASE-18480 The cost of BaseLoadBalancer.cluster is changed even if the (chia7712: rev b4f8377aa08448ef75be8277af87b1bc89d58529) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java > The cost of BaseLoadBalancer.cluster is changed even if the rollback is done > > > Key: HBASE-18480 > URL: https://issues.apache.org/jira/browse/HBASE-18480 > Project: HBase > Issue Type: Bug > Components: Balancer >Affects Versions: 3.0.0, 1.3.0, 1.2.6, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18480.branch-1.2.v0.patch, > HBASE-18480.branch-1.3.v0.patch, HBASE-18480.branch-1.v0.patch, > HBASE-18480.branch-1.v1.patch, HBASE-18480.v0.patch, HBASE-18480.v1.patch, > HBASE-18480.v1.patch > > > If the cost of cluster isn't restored after the undo action, > StochasticLoadBalancer will be hard to generate the "good" action to balance > the cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18491) [AMv2] Fail UnassignProcedure if source Region Server is not online.
[ https://issues.apache.org/jira/browse/HBASE-18491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110244#comment-16110244 ] Hudson commented on HBASE-18491: FAILURE: Integrated in Jenkins build HBase-2.0 #276 (See [https://builds.apache.org/job/HBase-2.0/276/]) HBASE-18491 [AMv2] Fail UnassignProcedure if source Region Server is not (stack: rev 3f540f3801c93813a3a018dddb7fdf24d4aff27d) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestServerCrashProcedure.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/UnassignProcedure.java > [AMv2] Fail UnassignProcedure if source Region Server is not online. > > > Key: HBASE-18491 > URL: https://issues.apache.org/jira/browse/HBASE-18491 > Project: HBase > Issue Type: Bug > Components: amv2 >Affects Versions: 2.0.0 >Reporter: Umesh Agashe >Assignee: Umesh Agashe >Priority: Critical > Fix For: 2.0.0 > > Attachments: hbase-18491.master.001.patch > > > Currently UnassignProcedure returns success when server carrying a region is > NOT online. Assumption here is that ServerCrashProcedure will handle > splitting logs etc for these regions. When UnassignProcedure completes, > MoveRegionProcedure resumes with AssignProcedure. AssignProcedure can some > times assign regions without pre-requisite steps (done either by > UnassignProcedure or ServerCrashProcedure). Fix is to fail UnassignProcedure > and parent MoveRegionProcedure if source server is not online. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16290) Dump summary of callQueue content; can help debugging
[ https://issues.apache.org/jira/browse/HBASE-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sreeram Venkatasubramanian updated HBASE-16290: --- Attachment: 0001-Dump-Call-Queue-Summary.patch > Dump summary of callQueue content; can help debugging > - > > Key: HBASE-16290 > URL: https://issues.apache.org/jira/browse/HBASE-16290 > Project: HBase > Issue Type: Bug > Components: Operability >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Sreeram Venkatasubramanian >Priority: Critical > Labels: beginner > Fix For: 2.0.0 > > Attachments: 0001-Dump-Call-Queue-Summary.patch, Sample Summary.txt > > > Being able to get a clue what is in a backedup callQueue could give insight > on what is going on on a jacked server. Just needs to summarize count, sizes, > call types. Useful debugging. In a servlet? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16290) Dump summary of callQueue content; can help debugging
[ https://issues.apache.org/jira/browse/HBASE-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sreeram Venkatasubramanian updated HBASE-16290: --- Fix Version/s: 2.0.0 Release Note: Patch to print summary of call queues by size and count. This is displayed on the debug dump page of region server UI Affects Version/s: 2.0.0 Status: Patch Available (was: In Progress) I have attached the patch for printing call queue summary by size and counts. > Dump summary of callQueue content; can help debugging > - > > Key: HBASE-16290 > URL: https://issues.apache.org/jira/browse/HBASE-16290 > Project: HBase > Issue Type: Bug > Components: Operability >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Sreeram Venkatasubramanian >Priority: Critical > Labels: beginner > Fix For: 2.0.0 > > Attachments: 0001-Dump-Call-Queue-Summary.patch, Sample Summary.txt > > > Being able to get a clue what is in a backedup callQueue could give insight > on what is going on on a jacked server. Just needs to summarize count, sizes, > call types. Useful debugging. In a servlet? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-17104) Improve cryptic error message "Memstore size is" on region close
[
https://issues.apache.org/jira/browse/HBASE-17104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110233#comment-16110233
]
Sahil Aggarwal edited comment on HBASE-17104 at 8/2/17 3:48 AM:
[~tedyu] How do i request for review?
was (Author: awked06):
How do i request for review?
> Improve cryptic error message "Memstore size is" on region close
>
>
> Key: HBASE-17104
> URL: https://issues.apache.org/jira/browse/HBASE-17104
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Reporter: Matteo Bertozzi
>Assignee: Sahil Aggarwal
>Priority: Trivial
> Labels: beginner, noob
> Fix For: 2.0.0
>
> Attachments: HBASE-17104.master.001 (1).patch,
> HBASE-17104.master.001.patch
>
>
> while grepping my RS log for ERROR I found a cryptic
> {noformat}
> ERROR [RS_CLOSE_REGION-u1604vm:35021-1] regionserver.HRegion(1601): Memstore
> size is 33744
> {noformat}
> from the code looks like we seems to want to notify the user about the fact
> that on close the rs was not able to flush and there were things in the RS.
> https://github.com/apache/hbase/blob/c3685760f004450667920144f926383eb307de53/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L1601
> {code}
> if (!canFlush) {
> this.decrMemstoreSize(new MemstoreSize(memstoreDataSize.get(),
> getMemstoreHeapOverhead()));
> } else if (memstoreDataSize.get() != 0) {
> LOG.error("Memstore size is " + memstoreDataSize.get());
> }
> {code}
> this should probably not even be an error but a warn or even info, unless we
> have puts that specifically asked to not be written to the wal, otherwise
> the data in the memstore should be safe in the wals.
> In any case it will be nice to have a message describing what is going on and
> why we are notifying about the memstore size.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17104) Improve cryptic error message "Memstore size is" on region close
[
https://issues.apache.org/jira/browse/HBASE-17104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110233#comment-16110233
]
Sahil Aggarwal commented on HBASE-17104:
How do i request for review?
> Improve cryptic error message "Memstore size is" on region close
>
>
> Key: HBASE-17104
> URL: https://issues.apache.org/jira/browse/HBASE-17104
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Reporter: Matteo Bertozzi
>Assignee: Sahil Aggarwal
>Priority: Trivial
> Labels: beginner, noob
> Fix For: 2.0.0
>
> Attachments: HBASE-17104.master.001 (1).patch,
> HBASE-17104.master.001.patch
>
>
> while grepping my RS log for ERROR I found a cryptic
> {noformat}
> ERROR [RS_CLOSE_REGION-u1604vm:35021-1] regionserver.HRegion(1601): Memstore
> size is 33744
> {noformat}
> from the code looks like we seems to want to notify the user about the fact
> that on close the rs was not able to flush and there were things in the RS.
> https://github.com/apache/hbase/blob/c3685760f004450667920144f926383eb307de53/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L1601
> {code}
> if (!canFlush) {
> this.decrMemstoreSize(new MemstoreSize(memstoreDataSize.get(),
> getMemstoreHeapOverhead()));
> } else if (memstoreDataSize.get() != 0) {
> LOG.error("Memstore size is " + memstoreDataSize.get());
> }
> {code}
> this should probably not even be an error but a warn or even info, unless we
> have puts that specifically asked to not be written to the wal, otherwise
> the data in the memstore should be safe in the wals.
> In any case it will be nice to have a message describing what is going on and
> why we are notifying about the memstore size.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Work started] (HBASE-17104) Improve cryptic error message "Memstore size is" on region close
[
https://issues.apache.org/jira/browse/HBASE-17104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-17104 started by Sahil Aggarwal.
--
> Improve cryptic error message "Memstore size is" on region close
>
>
> Key: HBASE-17104
> URL: https://issues.apache.org/jira/browse/HBASE-17104
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Reporter: Matteo Bertozzi
>Assignee: Sahil Aggarwal
>Priority: Trivial
> Labels: beginner, noob
> Fix For: 2.0.0
>
> Attachments: HBASE-17104.master.001 (1).patch,
> HBASE-17104.master.001.patch
>
>
> while grepping my RS log for ERROR I found a cryptic
> {noformat}
> ERROR [RS_CLOSE_REGION-u1604vm:35021-1] regionserver.HRegion(1601): Memstore
> size is 33744
> {noformat}
> from the code looks like we seems to want to notify the user about the fact
> that on close the rs was not able to flush and there were things in the RS.
> https://github.com/apache/hbase/blob/c3685760f004450667920144f926383eb307de53/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L1601
> {code}
> if (!canFlush) {
> this.decrMemstoreSize(new MemstoreSize(memstoreDataSize.get(),
> getMemstoreHeapOverhead()));
> } else if (memstoreDataSize.get() != 0) {
> LOG.error("Memstore size is " + memstoreDataSize.get());
> }
> {code}
> this should probably not even be an error but a warn or even info, unless we
> have puts that specifically asked to not be written to the wal, otherwise
> the data in the memstore should be safe in the wals.
> In any case it will be nice to have a message describing what is going on and
> why we are notifying about the memstore size.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Work stopped] (HBASE-17104) Improve cryptic error message "Memstore size is" on region close
[
https://issues.apache.org/jira/browse/HBASE-17104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-17104 stopped by Sahil Aggarwal.
--
> Improve cryptic error message "Memstore size is" on region close
>
>
> Key: HBASE-17104
> URL: https://issues.apache.org/jira/browse/HBASE-17104
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Reporter: Matteo Bertozzi
>Assignee: Sahil Aggarwal
>Priority: Trivial
> Labels: beginner, noob
> Fix For: 2.0.0
>
> Attachments: HBASE-17104.master.001 (1).patch,
> HBASE-17104.master.001.patch
>
>
> while grepping my RS log for ERROR I found a cryptic
> {noformat}
> ERROR [RS_CLOSE_REGION-u1604vm:35021-1] regionserver.HRegion(1601): Memstore
> size is 33744
> {noformat}
> from the code looks like we seems to want to notify the user about the fact
> that on close the rs was not able to flush and there were things in the RS.
> https://github.com/apache/hbase/blob/c3685760f004450667920144f926383eb307de53/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L1601
> {code}
> if (!canFlush) {
> this.decrMemstoreSize(new MemstoreSize(memstoreDataSize.get(),
> getMemstoreHeapOverhead()));
> } else if (memstoreDataSize.get() != 0) {
> LOG.error("Memstore size is " + memstoreDataSize.get());
> }
> {code}
> this should probably not even be an error but a warn or even info, unless we
> have puts that specifically asked to not be written to the wal, otherwise
> the data in the memstore should be safe in the wals.
> In any case it will be nice to have a message describing what is going on and
> why we are notifying about the memstore size.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Work started] (HBASE-17104) Improve cryptic error message "Memstore size is" on region close
[
https://issues.apache.org/jira/browse/HBASE-17104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-17104 started by Sahil Aggarwal.
--
> Improve cryptic error message "Memstore size is" on region close
>
>
> Key: HBASE-17104
> URL: https://issues.apache.org/jira/browse/HBASE-17104
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Reporter: Matteo Bertozzi
>Assignee: Sahil Aggarwal
>Priority: Trivial
> Labels: beginner, noob
> Fix For: 2.0.0
>
> Attachments: HBASE-17104.master.001 (1).patch,
> HBASE-17104.master.001.patch
>
>
> while grepping my RS log for ERROR I found a cryptic
> {noformat}
> ERROR [RS_CLOSE_REGION-u1604vm:35021-1] regionserver.HRegion(1601): Memstore
> size is 33744
> {noformat}
> from the code looks like we seems to want to notify the user about the fact
> that on close the rs was not able to flush and there were things in the RS.
> https://github.com/apache/hbase/blob/c3685760f004450667920144f926383eb307de53/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L1601
> {code}
> if (!canFlush) {
> this.decrMemstoreSize(new MemstoreSize(memstoreDataSize.get(),
> getMemstoreHeapOverhead()));
> } else if (memstoreDataSize.get() != 0) {
> LOG.error("Memstore size is " + memstoreDataSize.get());
> }
> {code}
> this should probably not even be an error but a warn or even info, unless we
> have puts that specifically asked to not be written to the wal, otherwise
> the data in the memstore should be safe in the wals.
> In any case it will be nice to have a message describing what is going on and
> why we are notifying about the memstore size.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sahil Aggarwal reassigned HBASE-18439:
--
Assignee: Sahil Aggarwal
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Sahil Aggarwal
>Priority: Minor
> Labels: beginner
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18142) Deletion of a cell deletes the previous versions too
[ https://issues.apache.org/jira/browse/HBASE-18142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110218#comment-16110218 ] Chia-Ping Tsai commented on HBASE-18142: bq. just pass flag in _createdelete_internal to call d.addColumns/d.addColumn. Nice suggestion. > Deletion of a cell deletes the previous versions too > > > Key: HBASE-18142 > URL: https://issues.apache.org/jira/browse/HBASE-18142 > Project: HBase > Issue Type: Bug > Components: API >Affects Versions: 3.0.0 >Reporter: Karthick >Assignee: ChunHao > Labels: beginner > Fix For: 3.0.0 > > Attachments: HBASE-18142.master.v0.patch > > > When I tried to delete a cell using it's timestamp in the Hbase Shell, the > previous versions of the same cell also got deleted. But when I tried the > same using the Java API, then the previous versions are not deleted and I can > retrive the previous values. > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Delete.java > see this file to fix the issue. This method (public Delete addColumns(final > byte [] family, final byte [] qualifier, final long timestamp)) only deletes > the current version of the cell. The previous versions are not deleted. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18142) Deletion of a cell deletes the previous versions too
[ https://issues.apache.org/jira/browse/HBASE-18142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110214#comment-16110214 ] Sahil Aggarwal commented on HBASE-18142: [~chia7712] Thanks for clarification. We probably then need to decouple _createdelete_internal for deleteall and delete, something like _createdelete_internal and _createdeleteall_internal or just pass flag in _createdelete_internal to call d.addColumns/d.addColumn. > Deletion of a cell deletes the previous versions too > > > Key: HBASE-18142 > URL: https://issues.apache.org/jira/browse/HBASE-18142 > Project: HBase > Issue Type: Bug > Components: API >Affects Versions: 3.0.0 >Reporter: Karthick >Assignee: ChunHao > Labels: beginner > Fix For: 3.0.0 > > Attachments: HBASE-18142.master.v0.patch > > > When I tried to delete a cell using it's timestamp in the Hbase Shell, the > previous versions of the same cell also got deleted. But when I tried the > same using the Java API, then the previous versions are not deleted and I can > retrive the previous values. > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Delete.java > see this file to fix the issue. This method (public Delete addColumns(final > byte [] family, final byte [] qualifier, final long timestamp)) only deletes > the current version of the cell. The previous versions are not deleted. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18485) Performance issue: ClientAsyncPrefetchScanner is slower than ClientSimpleScanner
[
https://issues.apache.org/jira/browse/HBASE-18485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110207#comment-16110207
]
Guanghao Zhang commented on HBASE-18485:
Test with the v1 patch.
Mean latency.
|| ||Test1|| Test2 || Test3 || Test4|| Test5||
|scan with prefetch=True | 8.81 | 9.26 | 9.15 | 9.52 | 8.99 |
And I run mvn clean test -Dtest=Test*Scan*. All unit tests passed.
> Performance issue: ClientAsyncPrefetchScanner is slower than
> ClientSimpleScanner
>
>
> Key: HBASE-18485
> URL: https://issues.apache.org/jira/browse/HBASE-18485
> Project: HBase
> Issue Type: Bug
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Attachments: HBASE-18485-v1.patch
>
>
> Copied the test result from HBASE-17994.
> {code}
> ./bin/hbase org.apache.hadoop.hbase.PerformanceEvaluation --rows=10
> --nomapred scan 1
> ./bin/hbase org.apache.hadoop.hbase.PerformanceEvaluation --rows=10
> --nomapred --asyncPrefetch=True scan 1
> {code}
> Mean latency.
> || ||Test1|| Test2 || Test3 || Test4|| Test5||
> |scan| 12.21 | 14.32 | 13.25 | 13.07 | 11.83 |
> |scan with prefetch=True | 37.36 | 37.88 | 37.56 | 37.66 | 38.28 |
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18485) Performance issue: ClientAsyncPrefetchScanner is slower than ClientSimpleScanner
[
https://issues.apache.org/jira/browse/HBASE-18485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang updated HBASE-18485:
---
Attachment: HBASE-18485-v1.patch
> Performance issue: ClientAsyncPrefetchScanner is slower than
> ClientSimpleScanner
>
>
> Key: HBASE-18485
> URL: https://issues.apache.org/jira/browse/HBASE-18485
> Project: HBase
> Issue Type: Bug
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Attachments: HBASE-18485-v1.patch
>
>
> Copied the test result from HBASE-17994.
> {code}
> ./bin/hbase org.apache.hadoop.hbase.PerformanceEvaluation --rows=10
> --nomapred scan 1
> ./bin/hbase org.apache.hadoop.hbase.PerformanceEvaluation --rows=10
> --nomapred --asyncPrefetch=True scan 1
> {code}
> Mean latency.
> || ||Test1|| Test2 || Test3 || Test4|| Test5||
> |scan| 12.21 | 14.32 | 13.25 | 13.07 | 11.83 |
> |scan with prefetch=True | 37.36 | 37.88 | 37.56 | 37.66 | 38.28 |
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18485) Performance issue: ClientAsyncPrefetchScanner is slower than ClientSimpleScanner
[
https://issues.apache.org/jira/browse/HBASE-18485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang updated HBASE-18485:
---
Status: Patch Available (was: Open)
> Performance issue: ClientAsyncPrefetchScanner is slower than
> ClientSimpleScanner
>
>
> Key: HBASE-18485
> URL: https://issues.apache.org/jira/browse/HBASE-18485
> Project: HBase
> Issue Type: Bug
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Attachments: HBASE-18485-v1.patch
>
>
> Copied the test result from HBASE-17994.
> {code}
> ./bin/hbase org.apache.hadoop.hbase.PerformanceEvaluation --rows=10
> --nomapred scan 1
> ./bin/hbase org.apache.hadoop.hbase.PerformanceEvaluation --rows=10
> --nomapred --asyncPrefetch=True scan 1
> {code}
> Mean latency.
> || ||Test1|| Test2 || Test3 || Test4|| Test5||
> |scan| 12.21 | 14.32 | 13.25 | 13.07 | 11.83 |
> |scan with prefetch=True | 37.36 | 37.88 | 37.56 | 37.66 | 38.28 |
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (HBASE-18485) Performance issue: ClientAsyncPrefetchScanner is slower than ClientSimpleScanner
[
https://issues.apache.org/jira/browse/HBASE-18485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang reassigned HBASE-18485:
--
Assignee: Guanghao Zhang
> Performance issue: ClientAsyncPrefetchScanner is slower than
> ClientSimpleScanner
>
>
> Key: HBASE-18485
> URL: https://issues.apache.org/jira/browse/HBASE-18485
> Project: HBase
> Issue Type: Bug
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>
> Copied the test result from HBASE-17994.
> {code}
> ./bin/hbase org.apache.hadoop.hbase.PerformanceEvaluation --rows=10
> --nomapred scan 1
> ./bin/hbase org.apache.hadoop.hbase.PerformanceEvaluation --rows=10
> --nomapred --asyncPrefetch=True scan 1
> {code}
> Mean latency.
> || ||Test1|| Test2 || Test3 || Test4|| Test5||
> |scan| 12.21 | 14.32 | 13.25 | 13.07 | 11.83 |
> |scan with prefetch=True | 37.36 | 37.88 | 37.56 | 37.66 | 38.28 |
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18498) Design improvements to Clock.java
[ https://issues.apache.org/jira/browse/HBASE-18498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-18498: - Attachment: HBASE-18498.HBASE-14070.HLC.001.patch > Design improvements to Clock.java > - > > Key: HBASE-18498 > URL: https://issues.apache.org/jira/browse/HBASE-18498 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Appy > Attachments: HBASE-18498.HBASE-14070.HLC.001.patch > > > - Delete PhysicalClock interface which seems useless give we have SYSTEM > implementation of Clock which is basically the same. > - Embed systemMonotonic clock into HLC to get rid of redundancy in management > of physical component, esp logic around ensuring monotonicity. > - Make max_skew in clocks configurable > - Remove isMonotonicallyIncreasing() which is not used. > - update logical overflow test to not use hooks but prod code path > - Added lots of comments. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18498) Design improvements to Clock.java
[ https://issues.apache.org/jira/browse/HBASE-18498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-18498: - Status: Patch Available (was: Open) > Design improvements to Clock.java > - > > Key: HBASE-18498 > URL: https://issues.apache.org/jira/browse/HBASE-18498 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Appy > Attachments: HBASE-18498.HBASE-14070.HLC.001.patch > > > - Delete PhysicalClock interface which seems useless give we have SYSTEM > implementation of Clock which is basically the same. > - Embed systemMonotonic clock into HLC to get rid of redundancy in management > of physical component, esp logic around ensuring monotonicity. > - Make max_skew in clocks configurable > - Remove isMonotonicallyIncreasing() which is not used. > - update logical overflow test to not use hooks but prod code path > - Added lots of comments. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18432) Prevent clock from getting stuck after update()
[ https://issues.apache.org/jira/browse/HBASE-18432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110127#comment-16110127 ] Appy commented on HBASE-18432: -- Breaking out design changes in 001.patch into separate jira (HBASE-18498) so that this one can focus on real problem - how to handle skews? > Prevent clock from getting stuck after update() > --- > > Key: HBASE-18432 > URL: https://issues.apache.org/jira/browse/HBASE-18432 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Appy > Attachments: HBASE-18432.HBASE-14070.HLC.001.patch > > > There were a [bunch of > problems|https://issues.apache.org/jira/browse/HBASE-14070?focusedCommentId=16094013=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16094013] > (also copied below) with clock getting stuck after call to update() until > it's own system time caught up. > > PT = physical time, LT = logical time, ST = system time, X = don't care terms > > Core issue: > - Note that in current implementation, we are passing master clock to RS in > open/close region request and RS clock to master in the responses. And they > both update their own time on receiving these request/response. > - On receiving a clock ahead of its own, they update their own clock to its > PT+LT, and keep increasing LT till their own ST catches that PT. > > Proposed solution: > Keep track of skew in clock. And instead of keeping track of physical time, > always compute it by adding system time and skew. > On update(), recalculate skew and validate if it's greater than max_skew. > On toTimestamp(), calculate PT = ST+skew. > - > - > Issues with current approach: > > Problem 1: Logical time window too small. > RS clock (10, X) > Master clock (20, X) > Master --request-> RS > RS clock (20, X) > While RS's physical java clock (which is backing up physical component of hlc > clock) will still take 10 sec to catch up, we'll keep incrementing logical > component. That means, in worst case, our logical clock window should be big > enough to support all the events that can happen in max skew time. > The problem is, that doesn't seem to be the case. Our logical window is 1M > events (20bits) and max skew time is 30 sec, that results in 33k max write > qps, which is quite low. We can easily see 150k update qps per beefy server > with 1k values. > Even 22 bits won't be enough. We'll need minimum of 23 bits and 20 sec max > skew time to support ~420k max events per second in worst case clock skew. > > Problem 2: Cascading logical time increment. > When more RS are involved say - 3 RS and 1 master. Let's say max skew is 30 > sec. > HLC Clocks (physical time, logical time): X = don't care > RS1: (50, 100k) > Master: (40, X) > RS2: (30, X) > RS3: (20, X) > [RS3's ST behind RS1's by 30 sec.] > RS1 replies to master, sends it's clock (50,X). > Master's clock (50, X). It'll be another 10 sec before it's own physical > clock reaches 50, so HLC's PT will remain 50 for next 10 sec. > Master --> RS2 > RS2's clock = (50, X). > RS2 keeps incrementing LT on writes (since it's own PT is behind) for few > seconds before it replies back to master with (50, X+ few 100k). > Master's clock = (50, X+ few 100k) [Since master's physical clock hasn't > caught up yet, note that it was 10 seconds behind, PT remains 50.]. > Master --> RS3 > RS3's clock (50, X+few 100k) > But RS3's ST is behind RS1's ST by 30 sec, which means it'll keep > incrementing LT for next 30 sec (unless it gets a newer clock from master). > But the problem is, RS3 has much smaller LT window than actual 1M!! > — > Problem 3: Single bad RS clock crashing the cluster: > If a single RS's clock is bad and a bit faster, it'll catch time and keep > pulling master's PT with it. If 'real time' is say 20, max skew time is 10, > and bad RS is at time 29.9, it'll pull master to 29.9 (via next response), > and then any RS less than 19.9, i.e. just 0.1 sec away from real time will > die due to higher than max skew. > This can bring whole clusters down! > — > Problem 4: Time jumps (not a bug, but more of a nuisance) > Say a RS is behind master by 20 sec. On each communication from master, RS > will update its own PT to master's PT, and it'll remain that till RS's ST > catches up. If there are frequent communication from master, ST might never > catch up and RS's PT will actually look like discrete time jumps rather than > continuous time. > For eg. If master communicated with RS at times 30, 40, 50 (RSs corresponding > times are 10, 20, 30), than all events on RS between time [10, 50] will be > timestamped with either 30, 40 or 50. > — -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18499) Design improvements to Clock.java
[ https://issues.apache.org/jira/browse/HBASE-18499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110126#comment-16110126 ] Appy commented on HBASE-18499: -- Jira screwed up. Clicking on 'create' created HBASE-18498 jira but didn't send ack back to my frontend, and it kept showing me the create dialog box. So clicked on it again after few seconds, which ended up creating this duplicate. Closing this one. > Design improvements to Clock.java > - > > Key: HBASE-18499 > URL: https://issues.apache.org/jira/browse/HBASE-18499 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Appy > > - Delete PhysicalClock interface which seems useless give we have SYSTEM > implementation of Clock which is basically the same. > - Embed systemMonotonic clock into HLC to get rid of redundancy in management > of physical component, esp logic around ensuring monotonicity. > - Make max_skew in clocks configurable > - Remove isMonotonicallyIncreasing() which is not used. > - update logical overflow test to not use hooks but prod code path > - Added lots of comments. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (HBASE-18499) Design improvements to Clock.java
[ https://issues.apache.org/jira/browse/HBASE-18499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy resolved HBASE-18499. -- Resolution: Duplicate > Design improvements to Clock.java > - > > Key: HBASE-18499 > URL: https://issues.apache.org/jira/browse/HBASE-18499 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Appy > > - Delete PhysicalClock interface which seems useless give we have SYSTEM > implementation of Clock which is basically the same. > - Embed systemMonotonic clock into HLC to get rid of redundancy in management > of physical component, esp logic around ensuring monotonicity. > - Make max_skew in clocks configurable > - Remove isMonotonicallyIncreasing() which is not used. > - update logical overflow test to not use hooks but prod code path > - Added lots of comments. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18499) Design improvements to Clock.java
Appy created HBASE-18499: Summary: Design improvements to Clock.java Key: HBASE-18499 URL: https://issues.apache.org/jira/browse/HBASE-18499 Project: HBase Issue Type: Sub-task Reporter: Appy Assignee: Appy - Delete PhysicalClock interface which seems useless give we have SYSTEM implementation of Clock which is basically the same. - Embed systemMonotonic clock into HLC to get rid of redundancy in management of physical component, esp logic around ensuring monotonicity. - Make max_skew in clocks configurable - Remove isMonotonicallyIncreasing() which is not used. - update logical overflow test to not use hooks but prod code path - Added lots of comments. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18498) Design improvements to Clock.java
Appy created HBASE-18498: Summary: Design improvements to Clock.java Key: HBASE-18498 URL: https://issues.apache.org/jira/browse/HBASE-18498 Project: HBase Issue Type: Sub-task Reporter: Appy Assignee: Appy - Delete PhysicalClock interface which seems useless give we have SYSTEM implementation of Clock which is basically the same. - Embed systemMonotonic clock into HLC to get rid of redundancy in management of physical component, esp logic around ensuring monotonicity. - Make max_skew in clocks configurable - Remove isMonotonicallyIncreasing() which is not used. - update logical overflow test to not use hooks but prod code path - Added lots of comments. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18470) `RetriesExhaustedWithDetailsException#getDesc` describe is not right
[ https://issues.apache.org/jira/browse/HBASE-18470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110114#comment-16110114 ] Chia-Ping Tsai commented on HBASE-18470: I'm not convinced we have the performance issue about getDesc(). I prefer the way "make the last iteration skip adding comma". If the uniqAddr is empty, using substring() will cause incorrect string. > `RetriesExhaustedWithDetailsException#getDesc` describe is not right > > > Key: HBASE-18470 > URL: https://issues.apache.org/jira/browse/HBASE-18470 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Benedict Jin >Assignee: Benedict Jin > Attachments: HBASE-18470.master.001.patch > > Original Estimate: 72h > Remaining Estimate: 72h > > The describe from `RetriesExhaustedWithDetailsException#getDesc` is ` > org.apache.hadoop.hbase.client.RetriesExhaustedWithDetailsException: Failed 3 > actions: FailedServerException: 3 times, `, there is a not need ', ' in the > tail. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18470) `RetriesExhaustedWithDetailsException#getDesc` describe is not right
[
https://issues.apache.org/jira/browse/HBASE-18470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110091#comment-16110091
]
Benedict Jin commented on HBASE-18470:
--
Hi, [~tedyu]. Thank you for comment. Sure, skipping add comma is a good
solution and i tried it in the beginning. But i changed my mind after some
performance tests that seems `substring` solution is always faster than
`skipping add comma`. Details is here:
```java
/*
JVM: -ea -Xmx512M -Xms512M -Xmn128M -XX:+AlwaysPreTouch
Time: 0.023948 ms
Time: 0.012752 ms
*/
@Test
public void testStringBuilder() {
Set uniqAddr = new HashSet<>();
StringBuilder addrs = new StringBuilder();
long begin, performanceTime;
{
uniqAddr.add("a");
uniqAddr.add("b");
uniqAddr.add("c");
begin = System.nanoTime();
int count = 0, addrLen = uniqAddr.size();
for (String addr : uniqAddr) {
addrs.append(addr);
count++;
if (count != addrLen) {
addrs.append(", ");
}
}
String withoutTail = addrs.toString();
performanceTime = System.nanoTime() - begin;
_log.info("Time: {} ms", performanceTime * Math.pow(10, -6));
assertEquals("a, b, c", withoutTail);
}
{
addrs = new StringBuilder();
uniqAddr.clear();
uniqAddr.add("a");
uniqAddr.add("b");
uniqAddr.add("c");
begin = System.nanoTime();
for (String addr : uniqAddr) {
addrs.append(addr).append(", ");
}
String withoutTail = uniqAddr.size() > 0 ? addrs.substring(0,
addrs.length() - 2) : addrs.toString();
performanceTime = System.nanoTime() - begin;
_log.info("Time: {} ms", performanceTime * Math.pow(10, -6));
assertEquals("a, b, c", withoutTail);
assertEquals("a, b, c", uniqAddr.size() > 0 ?
addrs.delete(addrs.length() - 2, addrs.length()).toString() :
addrs.toString());
}
}
```
(Full code:
https://github.com/asdf2014/yuzhouwan/blob/master/yuzhouwan-hacker/src/test/java/com/yuzhouwan/hacker/algorithms/collection/StringTest.java#L38)
> `RetriesExhaustedWithDetailsException#getDesc` describe is not right
>
>
> Key: HBASE-18470
> URL: https://issues.apache.org/jira/browse/HBASE-18470
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: Benedict Jin
>Assignee: Benedict Jin
> Attachments: HBASE-18470.master.001.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> The describe from `RetriesExhaustedWithDetailsException#getDesc` is `
> org.apache.hadoop.hbase.client.RetriesExhaustedWithDetailsException: Failed 3
> actions: FailedServerException: 3 times, `, there is a not need ', ' in the
> tail.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18490) Modifying a table descriptor to enable replicas does not create replica regions
[
https://issues.apache.org/jira/browse/HBASE-18490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110088#comment-16110088
]
Enis Soztutar commented on HBASE-18490:
---
This is implemented in HBASE-10361, and the test
{{TestMasterOperationsForRegionReplicas#testCreateTableWithMultipleReplicas()}}
have a section to increase the number of replicas.
bq. So if the config 'hbase.region.replica.replication.enabled' is not set then
ideally we should not allow any region replica itself? Or even without this
config we can create replica regions?
Region replica replication is an "optional" feature for region replicas. Region
replicas can keep sync'ing with the primary replica using either "periodic
store file refreshing", or through region replica replication. So in theory,
the region replica setup is not dependent on region replica replication.
> Modifying a table descriptor to enable replicas does not create replica
> regions
> ---
>
> Key: HBASE-18490
> URL: https://issues.apache.org/jira/browse/HBASE-18490
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment
>Affects Versions: 1.3.1, 1.2.6, 2.0.0-alpha-1
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Attachments: TestRegionReplicasWithRestartScenarios.java
>
>
> After creating a table, if we try to modify the table to enable region
> replication, the new Htable Descriptor is not taken into account and the
> table is enabled again with default single region.
> Ping [~enis], [~tedyu], [~devaraj].
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18480) The cost of BaseLoadBalancer.cluster is changed even if the rollback is done
[ https://issues.apache.org/jira/browse/HBASE-18480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110082#comment-16110082 ] Hudson commented on HBASE-18480: ABORTED: Integrated in Jenkins build HBase-1.4 #831 (See [https://builds.apache.org/job/HBase-1.4/831/]) HBASE-18480 The cost of BaseLoadBalancer.cluster is changed even if the (chia7712: rev a35dc0dddf4182122dc2fbbc0167f2182495a5ec) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java > The cost of BaseLoadBalancer.cluster is changed even if the rollback is done > > > Key: HBASE-18480 > URL: https://issues.apache.org/jira/browse/HBASE-18480 > Project: HBase > Issue Type: Bug > Components: Balancer >Affects Versions: 3.0.0, 1.3.0, 1.2.6, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18480.branch-1.2.v0.patch, > HBASE-18480.branch-1.3.v0.patch, HBASE-18480.branch-1.v0.patch, > HBASE-18480.branch-1.v1.patch, HBASE-18480.v0.patch, HBASE-18480.v1.patch, > HBASE-18480.v1.patch > > > If the cost of cluster isn't restored after the undo action, > StochasticLoadBalancer will be hard to generate the "good" action to balance > the cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18480) The cost of BaseLoadBalancer.cluster is changed even if the rollback is done
[ https://issues.apache.org/jira/browse/HBASE-18480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110081#comment-16110081 ] Hudson commented on HBASE-18480: FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #215 (See [https://builds.apache.org/job/HBase-1.3-JDK7/215/]) HBASE-18480 The cost of BaseLoadBalancer.cluster is changed even if the (chia7712: rev d0c93b250afab3a0c57ad8e45a700cd62825db08) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java > The cost of BaseLoadBalancer.cluster is changed even if the rollback is done > > > Key: HBASE-18480 > URL: https://issues.apache.org/jira/browse/HBASE-18480 > Project: HBase > Issue Type: Bug > Components: Balancer >Affects Versions: 3.0.0, 1.3.0, 1.2.6, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18480.branch-1.2.v0.patch, > HBASE-18480.branch-1.3.v0.patch, HBASE-18480.branch-1.v0.patch, > HBASE-18480.branch-1.v1.patch, HBASE-18480.v0.patch, HBASE-18480.v1.patch, > HBASE-18480.v1.patch > > > If the cost of cluster isn't restored after the undo action, > StochasticLoadBalancer will be hard to generate the "good" action to balance > the cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18142) Deletion of a cell deletes the previous versions too
[
https://issues.apache.org/jira/browse/HBASE-18142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110078#comment-16110078
]
Chia-Ping Tsai commented on HBASE-18142:
{code}
-d.addColumns(family, qualifier, timestamp)
+d.addColumn(family, qualifier, timestamp)
{code}
The method "_createdelete_internal" is also used by deleteall.rb. If the
"d.addColumns" is replaced by " d.addColumn", the deleteall.rb will be broken.
As I see it, the method which need to be adjusted is "_delete_internal".
{code}
# Delete a cell
def _delete_internal(row, column,
timestamp =
org.apache.hadoop.hbase.HConstants::LATEST_TIMESTAMP, args = {})
_deleteall_internal(row, column, timestamp, args)
end
{code}
Would you please add the tests for "delete" and "deleteall" ?
> Deletion of a cell deletes the previous versions too
>
>
> Key: HBASE-18142
> URL: https://issues.apache.org/jira/browse/HBASE-18142
> Project: HBase
> Issue Type: Bug
> Components: API
>Affects Versions: 3.0.0
>Reporter: Karthick
>Assignee: ChunHao
> Labels: beginner
> Fix For: 3.0.0
>
> Attachments: HBASE-18142.master.v0.patch
>
>
> When I tried to delete a cell using it's timestamp in the Hbase Shell, the
> previous versions of the same cell also got deleted. But when I tried the
> same using the Java API, then the previous versions are not deleted and I can
> retrive the previous values.
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Delete.java
> see this file to fix the issue. This method (public Delete addColumns(final
> byte [] family, final byte [] qualifier, final long timestamp)) only deletes
> the current version of the cell. The previous versions are not deleted.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18480) The cost of BaseLoadBalancer.cluster is changed even if the rollback is done
[ https://issues.apache.org/jira/browse/HBASE-18480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110077#comment-16110077 ] Hudson commented on HBASE-18480: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #153 (See [https://builds.apache.org/job/HBase-1.3-IT/153/]) HBASE-18480 The cost of BaseLoadBalancer.cluster is changed even if the (chia7712: rev d0c93b250afab3a0c57ad8e45a700cd62825db08) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java > The cost of BaseLoadBalancer.cluster is changed even if the rollback is done > > > Key: HBASE-18480 > URL: https://issues.apache.org/jira/browse/HBASE-18480 > Project: HBase > Issue Type: Bug > Components: Balancer >Affects Versions: 3.0.0, 1.3.0, 1.2.6, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18480.branch-1.2.v0.patch, > HBASE-18480.branch-1.3.v0.patch, HBASE-18480.branch-1.v0.patch, > HBASE-18480.branch-1.v1.patch, HBASE-18480.v0.patch, HBASE-18480.v1.patch, > HBASE-18480.v1.patch > > > If the cost of cluster isn't restored after the undo action, > StochasticLoadBalancer will be hard to generate the "good" action to balance > the cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18480) The cost of BaseLoadBalancer.cluster is changed even if the rollback is done
[ https://issues.apache.org/jira/browse/HBASE-18480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18480: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Push this to master, branch-2, branch-1, branch-1.4, branch-1.3, and branch-1.2 Thanks for the reviews. [~tedyu] > The cost of BaseLoadBalancer.cluster is changed even if the rollback is done > > > Key: HBASE-18480 > URL: https://issues.apache.org/jira/browse/HBASE-18480 > Project: HBase > Issue Type: Bug > Components: Balancer >Affects Versions: 3.0.0, 1.3.0, 1.2.6, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18480.branch-1.2.v0.patch, > HBASE-18480.branch-1.3.v0.patch, HBASE-18480.branch-1.v0.patch, > HBASE-18480.branch-1.v1.patch, HBASE-18480.v0.patch, HBASE-18480.v1.patch, > HBASE-18480.v1.patch > > > If the cost of cluster isn't restored after the undo action, > StochasticLoadBalancer will be hard to generate the "good" action to balance > the cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18480) The cost of BaseLoadBalancer.cluster is changed even if the rollback is done
[ https://issues.apache.org/jira/browse/HBASE-18480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110069#comment-16110069 ] Hudson commented on HBASE-18480: FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #180 (See [https://builds.apache.org/job/HBase-1.2-JDK7/180/]) HBASE-18480 The cost of BaseLoadBalancer.cluster is changed even if the (chia7712: rev 5f6cca9967f5d77b46d1dda493b290e2935933c9) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java > The cost of BaseLoadBalancer.cluster is changed even if the rollback is done > > > Key: HBASE-18480 > URL: https://issues.apache.org/jira/browse/HBASE-18480 > Project: HBase > Issue Type: Bug > Components: Balancer >Affects Versions: 3.0.0, 1.3.0, 1.2.6, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18480.branch-1.2.v0.patch, > HBASE-18480.branch-1.3.v0.patch, HBASE-18480.branch-1.v0.patch, > HBASE-18480.branch-1.v1.patch, HBASE-18480.v0.patch, HBASE-18480.v1.patch, > HBASE-18480.v1.patch > > > If the cost of cluster isn't restored after the undo action, > StochasticLoadBalancer will be hard to generate the "good" action to balance > the cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18480) The cost of BaseLoadBalancer.cluster is changed even if the rollback is done
[ https://issues.apache.org/jira/browse/HBASE-18480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110068#comment-16110068 ] Hudson commented on HBASE-18480: SUCCESS: Integrated in Jenkins build HBase-1.2-IT #914 (See [https://builds.apache.org/job/HBase-1.2-IT/914/]) HBASE-18480 The cost of BaseLoadBalancer.cluster is changed even if the (chia7712: rev 5f6cca9967f5d77b46d1dda493b290e2935933c9) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java > The cost of BaseLoadBalancer.cluster is changed even if the rollback is done > > > Key: HBASE-18480 > URL: https://issues.apache.org/jira/browse/HBASE-18480 > Project: HBase > Issue Type: Bug > Components: Balancer >Affects Versions: 3.0.0, 1.3.0, 1.2.6, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18480.branch-1.2.v0.patch, > HBASE-18480.branch-1.3.v0.patch, HBASE-18480.branch-1.v0.patch, > HBASE-18480.branch-1.v1.patch, HBASE-18480.v0.patch, HBASE-18480.v1.patch, > HBASE-18480.v1.patch > > > If the cost of cluster isn't restored after the undo action, > StochasticLoadBalancer will be hard to generate the "good" action to balance > the cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18492) [AMv2] Embed code for selecting highest versioned region server for system table regions in AssignmentManager.processAssignQueue()
[
https://issues.apache.org/jira/browse/HBASE-18492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110062#comment-16110062
]
Hadoop QA commented on HBASE-18492:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
41s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 8m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
28s{color} | {color:red} hbase-protocol-shaded in master has 27 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 7m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
29m 21s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
28s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}117m
17s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
34s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}187m 25s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.13.1 Server=1.13.1 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18492 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12879913/hbase-18492.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile cc hbaseprotoc |
| uname | Linux 092c4f3c29d4 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7
11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
|
[jira] [Updated] (HBASE-18497) Add clock type to proto message for HLC region open/close
[ https://issues.apache.org/jira/browse/HBASE-18497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Patel updated HBASE-18497: --- Attachment: (was: HBASE-18497.HBASE-14070.HLC.001.patch) > Add clock type to proto message for HLC region open/close > - > > Key: HBASE-18497 > URL: https://issues.apache.org/jira/browse/HBASE-18497 > Project: HBase > Issue Type: Sub-task >Reporter: Amit Patel >Assignee: Amit Patel >Priority: Minor > Attachments: HBASE-18497.HBASE-14070.HLC.002.patch > > > This task covers the work for adding clock type to the protobuf message > NodeTime used for sending timestamps of each clock during region open and > close requests/responses. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18497) Add clock type to proto message for HLC region open/close
[ https://issues.apache.org/jira/browse/HBASE-18497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Patel updated HBASE-18497: --- Attachment: HBASE-18497.HBASE-14070.HLC.002.patch > Add clock type to proto message for HLC region open/close > - > > Key: HBASE-18497 > URL: https://issues.apache.org/jira/browse/HBASE-18497 > Project: HBase > Issue Type: Sub-task >Reporter: Amit Patel >Assignee: Amit Patel >Priority: Minor > Attachments: HBASE-18497.HBASE-14070.HLC.001.patch, > HBASE-18497.HBASE-14070.HLC.002.patch > > > This task covers the work for adding clock type to the protobuf message > NodeTime used for sending timestamps of each clock during region open and > close requests/responses. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18497) Add clock type to proto message for HLC region open/close
[ https://issues.apache.org/jira/browse/HBASE-18497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Patel updated HBASE-18497: --- Attachment: HBASE-18497.HBASE-14070.HLC.001.patch > Add clock type to proto message for HLC region open/close > - > > Key: HBASE-18497 > URL: https://issues.apache.org/jira/browse/HBASE-18497 > Project: HBase > Issue Type: Sub-task >Reporter: Amit Patel >Assignee: Amit Patel >Priority: Minor > Attachments: HBASE-18497.HBASE-14070.HLC.001.patch > > > This task covers the work for adding clock type to the protobuf message > NodeTime used for sending timestamps of each clock during region open and > close requests/responses. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18497) Add clock type to proto message for HLC region open/close
Amit Patel created HBASE-18497: -- Summary: Add clock type to proto message for HLC region open/close Key: HBASE-18497 URL: https://issues.apache.org/jira/browse/HBASE-18497 Project: HBase Issue Type: Sub-task Reporter: Amit Patel Assignee: Amit Patel Priority: Minor This task covers the work for adding clock type to the protobuf message NodeTime used for sending timestamps of each clock during region open and close requests/responses. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18395) Update clock on region open and close
[ https://issues.apache.org/jira/browse/HBASE-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-18395: - Resolution: Fixed Status: Resolved (was: Patch Available) > Update clock on region open and close > - > > Key: HBASE-18395 > URL: https://issues.apache.org/jira/browse/HBASE-18395 > Project: HBase > Issue Type: Sub-task >Reporter: Amit Patel >Assignee: Amit Patel >Priority: Minor > Attachments: HBASE-18395.HBASE-14070.HLC.001.patch, > HBASE-18395.HBASE-14070.HLC.002.patch, HBASE-18395.HBASE-14070.HLC.003.patch, > HBASE-18395.HBASE-14070.HLC.004.patch, HBASE-18395.HBASE-14070.HLC.005.patch, > HBASE-18395.HBASE-14070.HLC.006.patch > > > This task covers the patch for updating the clock on region opening and > closing. > The patch would include the following: > * Addition of a new protobuf message type that contains a field for a > timestamp > * Setting of timestamp field in building region open/close request and > response messages > * Updating the clock upon receiving message > The patch for this task will be going against the > [HBASE-14070.HLC|https://git-wip-us.apache.org/repos/asf?p=hbase.git;a=shortlog;h=refs/heads/HBASE-14070.HLC] > branch with the intent that it would be added as a commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18395) Update clock on region open and close
[ https://issues.apache.org/jira/browse/HBASE-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110037#comment-16110037 ] Appy commented on HBASE-18395: -- Great patch [~amit.patel] with lots of nice testing. Pushed patch 5 to HBASE-14070.HLC. Open a new jira for followup work (patch v6) please? > Update clock on region open and close > - > > Key: HBASE-18395 > URL: https://issues.apache.org/jira/browse/HBASE-18395 > Project: HBase > Issue Type: Sub-task >Reporter: Amit Patel >Assignee: Amit Patel >Priority: Minor > Attachments: HBASE-18395.HBASE-14070.HLC.001.patch, > HBASE-18395.HBASE-14070.HLC.002.patch, HBASE-18395.HBASE-14070.HLC.003.patch, > HBASE-18395.HBASE-14070.HLC.004.patch, HBASE-18395.HBASE-14070.HLC.005.patch, > HBASE-18395.HBASE-14070.HLC.006.patch > > > This task covers the patch for updating the clock on region opening and > closing. > The patch would include the following: > * Addition of a new protobuf message type that contains a field for a > timestamp > * Setting of timestamp field in building region open/close request and > response messages > * Updating the clock upon receiving message > The patch for this task will be going against the > [HBASE-14070.HLC|https://git-wip-us.apache.org/repos/asf?p=hbase.git;a=shortlog;h=refs/heads/HBASE-14070.HLC] > branch with the intent that it would be added as a commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18395) Update clock on region open and close
[ https://issues.apache.org/jira/browse/HBASE-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110037#comment-16110037 ] Appy edited comment on HBASE-18395 at 8/2/17 12:29 AM: --- Great patch [~amit.patel] with lots of nice testing. Pushed patch 5 to branch HBASE-14070.HLC. Open a new jira for followup work (patch v6) please? was (Author: appy): Great patch [~amit.patel] with lots of nice testing. Pushed patch 5 to HBASE-14070.HLC. Open a new jira for followup work (patch v6) please? > Update clock on region open and close > - > > Key: HBASE-18395 > URL: https://issues.apache.org/jira/browse/HBASE-18395 > Project: HBase > Issue Type: Sub-task >Reporter: Amit Patel >Assignee: Amit Patel >Priority: Minor > Attachments: HBASE-18395.HBASE-14070.HLC.001.patch, > HBASE-18395.HBASE-14070.HLC.002.patch, HBASE-18395.HBASE-14070.HLC.003.patch, > HBASE-18395.HBASE-14070.HLC.004.patch, HBASE-18395.HBASE-14070.HLC.005.patch, > HBASE-18395.HBASE-14070.HLC.006.patch > > > This task covers the patch for updating the clock on region opening and > closing. > The patch would include the following: > * Addition of a new protobuf message type that contains a field for a > timestamp > * Setting of timestamp field in building region open/close request and > response messages > * Updating the clock upon receiving message > The patch for this task will be going against the > [HBASE-14070.HLC|https://git-wip-us.apache.org/repos/asf?p=hbase.git;a=shortlog;h=refs/heads/HBASE-14070.HLC] > branch with the intent that it would be added as a commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110034#comment-16110034 ] Hudson commented on HBASE-18487: FAILURE: Integrated in Jenkins build HBase-2.0 #275 (See [https://builds.apache.org/job/HBase-2.0/275/]) HBASE-18487 Minor fixes in row lock implementation (apurtell: rev f67dae90f952e84681a07a612b8005a2d688cae5) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110027#comment-16110027 ] Hudson commented on HBASE-18487: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3476 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3476/]) HBASE-18487 Minor fixes in row lock implementation (apurtell: rev 422a57223a9a3cccfdc6db7c9f43ca083e6f3037) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-18102) [SHELL] Purge close_region command that allows by-pass of Master
[ https://issues.apache.org/jira/browse/HBASE-18102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy reassigned HBASE-18102: Assignee: Appy (was: Umesh Agashe) > [SHELL] Purge close_region command that allows by-pass of Master > > > Key: HBASE-18102 > URL: https://issues.apache.org/jira/browse/HBASE-18102 > Project: HBase > Issue Type: Sub-task > Components: Operability, shell >Reporter: stack >Assignee: Appy > Fix For: 2.0.0 > > > In AMv2, if a RS is not aligned with Master notions of how the world is, then > the Master will kill the deviant RS (TODO: is forcing compliance via less > radical means -- but that is how it is currently). > The shell currently allows by-passing the Master to make cluster > modifications such as our being able to send a close directly to a > RegionServer for it to execute locally. This facility was used in the past to > do fix-up when Master lost account of Region locations. In the new regime, > such mis-accounting should no longer happen and, should a user mistakenly do > an explicit close against a RS, the consequences will be more than the user > bargained for; the Master will shut down the RS as soon as it reports close > of a Region the master thinks should be open (No independence allowed!). > This issue is to review shell Region and Table manipulation commands to purge > those that by-pass Master or at least to add big warning. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18491) [AMv2] Fail UnassignProcedure if source Region Server is not online.
[ https://issues.apache.org/jira/browse/HBASE-18491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18491: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Thats sweet that that is all it took to fix the failing test. I like this. This is the way it should be. Thanks [~uagashe] > [AMv2] Fail UnassignProcedure if source Region Server is not online. > > > Key: HBASE-18491 > URL: https://issues.apache.org/jira/browse/HBASE-18491 > Project: HBase > Issue Type: Bug > Components: amv2 >Affects Versions: 2.0.0 >Reporter: Umesh Agashe >Assignee: Umesh Agashe >Priority: Critical > Fix For: 2.0.0 > > Attachments: hbase-18491.master.001.patch > > > Currently UnassignProcedure returns success when server carrying a region is > NOT online. Assumption here is that ServerCrashProcedure will handle > splitting logs etc for these regions. When UnassignProcedure completes, > MoveRegionProcedure resumes with AssignProcedure. AssignProcedure can some > times assign regions without pre-requisite steps (done either by > UnassignProcedure or ServerCrashProcedure). Fix is to fail UnassignProcedure > and parent MoveRegionProcedure if source server is not online. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18395) Update clock on region open and close
[ https://issues.apache.org/jira/browse/HBASE-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Patel updated HBASE-18395: --- Attachment: HBASE-18395.HBASE-14070.HLC.006.patch > Update clock on region open and close > - > > Key: HBASE-18395 > URL: https://issues.apache.org/jira/browse/HBASE-18395 > Project: HBase > Issue Type: Sub-task >Reporter: Amit Patel >Assignee: Amit Patel >Priority: Minor > Attachments: HBASE-18395.HBASE-14070.HLC.001.patch, > HBASE-18395.HBASE-14070.HLC.002.patch, HBASE-18395.HBASE-14070.HLC.003.patch, > HBASE-18395.HBASE-14070.HLC.004.patch, HBASE-18395.HBASE-14070.HLC.005.patch, > HBASE-18395.HBASE-14070.HLC.006.patch > > > This task covers the patch for updating the clock on region opening and > closing. > The patch would include the following: > * Addition of a new protobuf message type that contains a field for a > timestamp > * Setting of timestamp field in building region open/close request and > response messages > * Updating the clock upon receiving message > The patch for this task will be going against the > [HBASE-14070.HLC|https://git-wip-us.apache.org/repos/asf?p=hbase.git;a=shortlog;h=refs/heads/HBASE-14070.HLC] > branch with the intent that it would be added as a commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18395) Update clock on region open and close
[ https://issues.apache.org/jira/browse/HBASE-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Patel updated HBASE-18395: --- Attachment: (was: HBASE-18395.HBASE-14070.HLC.006.patch) > Update clock on region open and close > - > > Key: HBASE-18395 > URL: https://issues.apache.org/jira/browse/HBASE-18395 > Project: HBase > Issue Type: Sub-task >Reporter: Amit Patel >Assignee: Amit Patel >Priority: Minor > Attachments: HBASE-18395.HBASE-14070.HLC.001.patch, > HBASE-18395.HBASE-14070.HLC.002.patch, HBASE-18395.HBASE-14070.HLC.003.patch, > HBASE-18395.HBASE-14070.HLC.004.patch, HBASE-18395.HBASE-14070.HLC.005.patch > > > This task covers the patch for updating the clock on region opening and > closing. > The patch would include the following: > * Addition of a new protobuf message type that contains a field for a > timestamp > * Setting of timestamp field in building region open/close request and > response messages > * Updating the clock upon receiving message > The patch for this task will be going against the > [HBASE-14070.HLC|https://git-wip-us.apache.org/repos/asf?p=hbase.git;a=shortlog;h=refs/heads/HBASE-14070.HLC] > branch with the intent that it would be added as a commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18395) Update clock on region open and close
[ https://issues.apache.org/jira/browse/HBASE-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Patel updated HBASE-18395: --- Attachment: HBASE-18395.HBASE-14070.HLC.006.patch > Update clock on region open and close > - > > Key: HBASE-18395 > URL: https://issues.apache.org/jira/browse/HBASE-18395 > Project: HBase > Issue Type: Sub-task >Reporter: Amit Patel >Assignee: Amit Patel >Priority: Minor > Attachments: HBASE-18395.HBASE-14070.HLC.001.patch, > HBASE-18395.HBASE-14070.HLC.002.patch, HBASE-18395.HBASE-14070.HLC.003.patch, > HBASE-18395.HBASE-14070.HLC.004.patch, HBASE-18395.HBASE-14070.HLC.005.patch, > HBASE-18395.HBASE-14070.HLC.006.patch > > > This task covers the patch for updating the clock on region opening and > closing. > The patch would include the following: > * Addition of a new protobuf message type that contains a field for a > timestamp > * Setting of timestamp field in building region open/close request and > response messages > * Updating the clock upon receiving message > The patch for this task will be going against the > [HBASE-14070.HLC|https://git-wip-us.apache.org/repos/asf?p=hbase.git;a=shortlog;h=refs/heads/HBASE-14070.HLC] > branch with the intent that it would be added as a commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18488) Backport HBASE-15710(Include issue servers information in RetriesExhaustedWithDetailsException message) to branch-1.2
[ https://issues.apache.org/jira/browse/HBASE-18488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kh87313 updated HBASE-18488: Status: Patch Available (was: Open) > Backport HBASE-15710(Include issue servers information in > RetriesExhaustedWithDetailsException message) to branch-1.2 > - > > Key: HBASE-18488 > URL: https://issues.apache.org/jira/browse/HBASE-18488 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: Chia-Ping Tsai >Assignee: kh87313 >Priority: Minor > Labels: beginner > Fix For: 1.2.7 > > Attachments: HBASE-18488.branch-1.2.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18488) Backport HBASE-15710(Include issue servers information in RetriesExhaustedWithDetailsException message) to branch-1.2
[ https://issues.apache.org/jira/browse/HBASE-18488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kh87313 updated HBASE-18488: Status: Open (was: Patch Available) > Backport HBASE-15710(Include issue servers information in > RetriesExhaustedWithDetailsException message) to branch-1.2 > - > > Key: HBASE-18488 > URL: https://issues.apache.org/jira/browse/HBASE-18488 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: Chia-Ping Tsai >Assignee: kh87313 >Priority: Minor > Labels: beginner > Fix For: 1.2.7 > > Attachments: HBASE-18488.branch-1.2.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18422) Fix TestRegionRebalancing
[ https://issues.apache.org/jira/browse/HBASE-18422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109970#comment-16109970 ] Vladimir Rodionov commented on HBASE-18422: --- It seems that Apache build is broken > Fix TestRegionRebalancing > - > > Key: HBASE-18422 > URL: https://issues.apache.org/jira/browse/HBASE-18422 > Project: HBase > Issue Type: Sub-task > Components: test >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Attachments: HBASE-18422-v1.patch, HBASE-18422-v2.patch, > HBASE-18422-v3.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (HBASE-18459) [C++] Fix Segfault in location-cache
[ https://issues.apache.org/jira/browse/HBASE-18459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar resolved HBASE-18459. --- Resolution: Fixed Hadoop Flags: Reviewed Pushed this. Thanks [~xiaobingo] for the review. > [C++] Fix Segfault in location-cache > > > Key: HBASE-18459 > URL: https://issues.apache.org/jira/browse/HBASE-18459 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: HBASE-14850 > > Attachments: hbase-18459-v1.patch > > > When testing with the new multi-threaded load-client (implemented in > HBASE-18086), I've noticed that sometimes we get a segfault when zookeeper or > master connection gets an exception. > It seems to be from the way the we invalidate meta and refresh the meta. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109967#comment-16109967 ] Hudson commented on HBASE-18487: SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #229 (See [https://builds.apache.org/job/HBase-1.3-JDK8/229/]) HBASE-18487 Minor fixes in row lock implementation (apurtell: rev 84368110268ba0d2e75ce5acff2704eef615e3c6) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18424) Fix TestAsyncTableGetMultiThreaded
[
https://issues.apache.org/jira/browse/HBASE-18424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109951#comment-16109951
]
Hadoop QA commented on HBASE-18424:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
24s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
34m 22s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}156m 27s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}208m 43s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestBlockEvictionFromClient |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18424 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12879898/HBASE-18424-v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux ba07483ef517 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / a5db120 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/7877/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7877/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7877/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Fix TestAsyncTableGetMultiThreaded
> --
>
> Key: HBASE-18424
> URL: https://issues.apache.org/jira/browse/HBASE-18424
> Project: HBase
> Issue Type: Sub-task
>
[jira] [Updated] (HBASE-18248) Warn if monitored RPC task has been tied up beyond a configurable threshold
[ https://issues.apache.org/jira/browse/HBASE-18248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-18248: --- Summary: Warn if monitored RPC task has been tied up beyond a configurable threshold (was: Warn if monitored task has been tied up beyond a configurable threshold) > Warn if monitored RPC task has been tied up beyond a configurable threshold > --- > > Key: HBASE-18248 > URL: https://issues.apache.org/jira/browse/HBASE-18248 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 3.0.0, 1.4.0 > > Attachments: HBASE-18248-branch-1.patch, HBASE-18248-branch-1.patch, > HBASE-18248.patch, HBASE-18248.patch > > > Warn if monitored task has been tied up beyond a configurable threshold. We > especially want to do this for RPC tasks. Use a separate threshold for > warning about stuck RPC tasks versus other types of tasks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18102) [SHELL] Purge close_region command that allows by-pass of Master
[ https://issues.apache.org/jira/browse/HBASE-18102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-18102: - Summary: [SHELL] Purge close_region command that allows by-pass of Master (was: [SHELL] Purge commands that allow by-pass of Master; e.g. close of a region sent to regionserver explicitly) > [SHELL] Purge close_region command that allows by-pass of Master > > > Key: HBASE-18102 > URL: https://issues.apache.org/jira/browse/HBASE-18102 > Project: HBase > Issue Type: Sub-task > Components: Operability, shell >Reporter: stack >Assignee: Umesh Agashe > Fix For: 2.0.0 > > > In AMv2, if a RS is not aligned with Master notions of how the world is, then > the Master will kill the deviant RS (TODO: is forcing compliance via less > radical means -- but that is how it is currently). > The shell currently allows by-passing the Master to make cluster > modifications such as our being able to send a close directly to a > RegionServer for it to execute locally. This facility was used in the past to > do fix-up when Master lost account of Region locations. In the new regime, > such mis-accounting should no longer happen and, should a user mistakenly do > an explicit close against a RS, the consequences will be more than the user > bargained for; the Master will shut down the RS as soon as it reports close > of a Region the master thinks should be open (No independence allowed!). > This issue is to review shell Region and Table manipulation commands to purge > those that by-pass Master or at least to add big warning. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18491) [AMv2] Fail UnassignProcedure if source Region Server is not online.
[
https://issues.apache.org/jira/browse/HBASE-18491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109926#comment-16109926
]
Hadoop QA commented on HBASE-18491:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
30m 34s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}108m
37s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}155m 3s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18491 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12879900/hbase-18491.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 2f6bb501da33 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 422a572 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7878/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7878/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> [AMv2] Fail UnassignProcedure if source Region Server is not online.
>
>
> Key: HBASE-18491
> URL: https://issues.apache.org/jira/browse/HBASE-18491
> Project: HBase
> Issue Type: Bug
> Components: amv2
>Affects Versions: 2.0.0
>Reporter: Umesh Agashe
>Assignee: Umesh Agashe
>Priority: Critical
>
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109895#comment-16109895 ] Hudson commented on HBASE-18487: SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #174 (See [https://builds.apache.org/job/HBase-1.2-JDK8/174/]) HBASE-18487 Minor fixes in row lock implementation (apurtell: rev 6cadd1def796656efbcb3ca10befe5d323b53f1a) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18231) Deprecate and throw unsupported operation when Admin#closeRegion is called.
[
https://issues.apache.org/jira/browse/HBASE-18231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109879#comment-16109879
]
Hadoop QA commented on HBASE-18231:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
29s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 8 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
32m 14s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
44s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}156m 21s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
42s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}213m 53s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.TestMasterFailover |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18231 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12879887/HBASE-18231.master.003.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 790a68cae13f 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / a5db120 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/7875/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7875/testReport/ |
| modules | C: hbase-client hbase-server U: . |
| Console output |
[jira] [Commented] (HBASE-18470) `RetriesExhaustedWithDetailsException#getDesc` describe is not right
[ https://issues.apache.org/jira/browse/HBASE-18470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109877#comment-16109877 ] Ted Yu commented on HBASE-18470: Instead of calling substring() after the loop, you can make the last iteration skip adding comma. > `RetriesExhaustedWithDetailsException#getDesc` describe is not right > > > Key: HBASE-18470 > URL: https://issues.apache.org/jira/browse/HBASE-18470 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Benedict Jin >Assignee: Benedict Jin > Attachments: HBASE-18470.master.001.patch > > Original Estimate: 72h > Remaining Estimate: 72h > > The describe from `RetriesExhaustedWithDetailsException#getDesc` is ` > org.apache.hadoop.hbase.client.RetriesExhaustedWithDetailsException: Failed 3 > actions: FailedServerException: 3 times, `, there is a not need ', ' in the > tail. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109865#comment-16109865 ] Hudson commented on HBASE-18487: FAILURE: Integrated in Jenkins build HBase-1.4 #830 (See [https://builds.apache.org/job/HBase-1.4/830/]) HBASE-18487 Minor fixes in row lock implementation (apurtell: rev 80b85a857c87c66d45275e5716d02186918e9b5d) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18493) [AMv2] On region server crash do not process system table regions through AssignmentManager.checkIfShouldMoveSystemRegionAsync()
[ https://issues.apache.org/jira/browse/HBASE-18493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Umesh Agashe updated HBASE-18493: - Priority: Critical (was: Major) > [AMv2] On region server crash do not process system table regions through > AssignmentManager.checkIfShouldMoveSystemRegionAsync() > > > Key: HBASE-18493 > URL: https://issues.apache.org/jira/browse/HBASE-18493 > Project: HBase > Issue Type: Bug > Components: amv2 >Affects Versions: 2.0.0 >Reporter: Umesh Agashe >Assignee: Umesh Agashe >Priority: Critical > Fix For: 2.0.0 > > > On Region Server crash, as ServerCrashProcedure handles reassignment of all > the regions on a crashed server, don't process those regions through > AssignmentManager.checkIfShouldMoveSystemRegionAsync(). This avoids duplicate > and makes ServerCrashProcedure as one place to find all related code for > handling server crash. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18491) [AMv2] Fail UnassignProcedure if source Region Server is not online.
[ https://issues.apache.org/jira/browse/HBASE-18491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Umesh Agashe updated HBASE-18491: - Priority: Critical (was: Major) > [AMv2] Fail UnassignProcedure if source Region Server is not online. > > > Key: HBASE-18491 > URL: https://issues.apache.org/jira/browse/HBASE-18491 > Project: HBase > Issue Type: Bug > Components: amv2 >Affects Versions: 2.0.0 >Reporter: Umesh Agashe >Assignee: Umesh Agashe >Priority: Critical > Fix For: 2.0.0 > > Attachments: hbase-18491.master.001.patch > > > Currently UnassignProcedure returns success when server carrying a region is > NOT online. Assumption here is that ServerCrashProcedure will handle > splitting logs etc for these regions. When UnassignProcedure completes, > MoveRegionProcedure resumes with AssignProcedure. AssignProcedure can some > times assign regions without pre-requisite steps (done either by > UnassignProcedure or ServerCrashProcedure). Fix is to fail UnassignProcedure > and parent MoveRegionProcedure if source server is not online. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12341) Overhaul logging; log4j2, machine-readable, etc.
[ https://issues.apache.org/jira/browse/HBASE-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109809#comment-16109809 ] stack commented on HBASE-12341: --- Unscheduling from 2.0.0. We are not going to do log4j2. Other issues raised herein have not gotten any attention. > Overhaul logging; log4j2, machine-readable, etc. > > > Key: HBASE-12341 > URL: https://issues.apache.org/jira/browse/HBASE-12341 > Project: HBase > Issue Type: Umbrella >Reporter: stack >Priority: Critical > > This is a general umbrella issue for 2.x logging improvements. Hang related > work off this one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-12341) Overhaul logging; log4j2, machine-readable, etc.
[ https://issues.apache.org/jira/browse/HBASE-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-12341: -- Fix Version/s: (was: 2.0.0) > Overhaul logging; log4j2, machine-readable, etc. > > > Key: HBASE-12341 > URL: https://issues.apache.org/jira/browse/HBASE-12341 > Project: HBase > Issue Type: Umbrella >Reporter: stack >Priority: Critical > > This is a general umbrella issue for 2.x logging improvements. Hang related > work off this one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18422) Fix TestRegionRebalancing
[
https://issues.apache.org/jira/browse/HBASE-18422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109799#comment-16109799
]
Hadoop QA commented on HBASE-18422:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
30m 12s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m
3s{color} | {color:red} hbase-server generated 1 new + 0 unchanged - 0 fixed =
1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 66m 40s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
32s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}113m 13s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-server |
| | org.apache.hadoop.hbase.master.HMaster.augmentAssignments(Map) makes
inefficient use of keySet iterator instead of entrySet iterator At
HMaster.java:keySet iterator instead of entrySet iterator At
HMaster.java:[line 1479] |
| Failed junit tests | hadoop.hbase.master.TestMasterMetrics |
| Timed out junit tests |
org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure |
| | org.apache.hadoop.hbase.client.TestScanWithoutFetchingData |
| | org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay |
| | org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure |
| | org.apache.hadoop.hbase.regionserver.TestRowTooBig |
| | org.apache.hadoop.hbase.regionserver.TestSplitLogWorker |
| | org.apache.hadoop.hbase.regionserver.wal.TestAsyncWALReplay |
| | org.apache.hadoop.hbase.mapreduce.TestWALPlayer |
| | org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence |
| | org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy
|
| | org.apache.hadoop.hbase.mapreduce.TestTableInputFormat |
| | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId
[jira] [Commented] (HBASE-18488) Backport HBASE-15710(Include issue servers information in RetriesExhaustedWithDetailsException message) to branch-1.2
[ https://issues.apache.org/jira/browse/HBASE-18488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109798#comment-16109798 ] Andrew Purtell commented on HBASE-18488: +1 > Backport HBASE-15710(Include issue servers information in > RetriesExhaustedWithDetailsException message) to branch-1.2 > - > > Key: HBASE-18488 > URL: https://issues.apache.org/jira/browse/HBASE-18488 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: Chia-Ping Tsai >Assignee: kh87313 >Priority: Minor > Labels: beginner > Fix For: 1.2.7 > > Attachments: HBASE-18488.branch-1.2.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18492) [AMv2] Embed code for selecting highest versioned region server for system table regions in AssignmentManager.processAssignQueue()
[ https://issues.apache.org/jira/browse/HBASE-18492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Umesh Agashe updated HBASE-18492: - Attachment: hbase-18492.master.001.patch > [AMv2] Embed code for selecting highest versioned region server for system > table regions in AssignmentManager.processAssignQueue() > -- > > Key: HBASE-18492 > URL: https://issues.apache.org/jira/browse/HBASE-18492 > Project: HBase > Issue Type: Bug > Components: amv2 >Affects Versions: 2.0.0 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > Attachments: hbase-18492.master.001.patch > > > Embed logic of selecting highest versioned region server for system table > regions in AssignmentManager.processAssignQueue(). This way from any section > of the code when system table regions are re/assigned, only highest versioned > RS are candidates for target servers. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18492) [AMv2] Embed code for selecting highest versioned region server for system table regions in AssignmentManager.processAssignQueue()
[ https://issues.apache.org/jira/browse/HBASE-18492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Umesh Agashe updated HBASE-18492: - Status: Patch Available (was: In Progress) > [AMv2] Embed code for selecting highest versioned region server for system > table regions in AssignmentManager.processAssignQueue() > -- > > Key: HBASE-18492 > URL: https://issues.apache.org/jira/browse/HBASE-18492 > Project: HBase > Issue Type: Bug > Components: amv2 >Affects Versions: 2.0.0 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > Attachments: hbase-18492.master.001.patch > > > Embed logic of selecting highest versioned region server for system table > regions in AssignmentManager.processAssignQueue(). This way from any section > of the code when system table regions are re/assigned, only highest versioned > RS are candidates for target servers. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-15898) Document G1GC Recommendations
[ https://issues.apache.org/jira/browse/HBASE-15898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-15898: -- Fix Version/s: (was: 2.0.0) > Document G1GC Recommendations > - > > Key: HBASE-15898 > URL: https://issues.apache.org/jira/browse/HBASE-15898 > Project: HBase > Issue Type: Bug > Components: documentation, java >Affects Versions: 2.0.0 >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Attachments: HBASE-15898.patch > > > Document G1GC recommendations for HBase -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15898) Document G1GC Recommendations
[ https://issues.apache.org/jira/browse/HBASE-15898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109796#comment-16109796 ] stack commented on HBASE-15898: --- Unscheduling. No movement. > Document G1GC Recommendations > - > > Key: HBASE-15898 > URL: https://issues.apache.org/jira/browse/HBASE-15898 > Project: HBase > Issue Type: Bug > Components: documentation, java >Affects Versions: 2.0.0 >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Attachments: HBASE-15898.patch > > > Document G1GC recommendations for HBase -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16279) Separate and rewrite intro and quickstart
[ https://issues.apache.org/jira/browse/HBASE-16279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-16279: -- Fix Version/s: (was: 2.0.0) > Separate and rewrite intro and quickstart > - > > Key: HBASE-16279 > URL: https://issues.apache.org/jira/browse/HBASE-16279 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Attachments: HBASE-16279.patch, HBASE-16279-v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16279) Separate and rewrite intro and quickstart
[ https://issues.apache.org/jira/browse/HBASE-16279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109795#comment-16109795 ] stack commented on HBASE-16279: --- Unscheduling > Separate and rewrite intro and quickstart > - > > Key: HBASE-16279 > URL: https://issues.apache.org/jira/browse/HBASE-16279 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Attachments: HBASE-16279.patch, HBASE-16279-v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17442) Move most of the replication related classes to hbase-server package
[ https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109753#comment-16109753 ] Andrew Purtell commented on HBASE-17442: bq. Do we expect users to move to latest branch-1 release before upgrading to 2.0 ? I think the answer has to be no. > Move most of the replication related classes to hbase-server package > > > Key: HBASE-17442 > URL: https://issues.apache.org/jira/browse/HBASE-17442 > Project: HBase > Issue Type: Sub-task > Components: build, Replication >Affects Versions: 2.0.0 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Critical > Fix For: 2.0.0 > > Attachments: 0001-hbase-replication-module.patch, > HBASE-17442.v1.patch, HBASE-17442.v2.patch, HBASE-17442.v2.patch, > HBASE-17442.v3.patch > > > After the replication requests are routed through master, replication > implementation details didn't need be exposed to client. We should move most > of the replication related classes to hbase-server package. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Work started] (HBASE-18492) [AMv2] Embed code for selecting highest versioned region server for system table regions in AssignmentManager.processAssignQueue()
[ https://issues.apache.org/jira/browse/HBASE-18492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-18492 started by Umesh Agashe. > [AMv2] Embed code for selecting highest versioned region server for system > table regions in AssignmentManager.processAssignQueue() > -- > > Key: HBASE-18492 > URL: https://issues.apache.org/jira/browse/HBASE-18492 > Project: HBase > Issue Type: Bug > Components: amv2 >Affects Versions: 2.0.0 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > > Embed logic of selecting highest versioned region server for system table > regions in AssignmentManager.processAssignQueue(). This way from any section > of the code when system table regions are re/assigned, only highest versioned > RS are candidates for target servers. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (HBASE-18496) Fix TestTimestampType failing on isLikelyOfType tests
[ https://issues.apache.org/jira/browse/HBASE-18496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy resolved HBASE-18496. -- Resolution: Fixed > Fix TestTimestampType failing on isLikelyOfType tests > - > > Key: HBASE-18496 > URL: https://issues.apache.org/jira/browse/HBASE-18496 > Project: HBase > Issue Type: Sub-task >Reporter: Amit Patel >Assignee: Amit Patel >Priority: Trivial > Attachments: HBASE-18496.HBASE-14070.HLC.001.patch > > > The tests testPhysicalIsLikelyOfType and testHybridIsLikelyOfType were > failing after the initial commit of core HLC so this patch fixes that. Note > that both Physical#isLikelyOfType and Hybrid#isLikelyOfType will return false > if the input timestamp is from before the first half of the first day of 1970. > Changes > * Offset date by second day of year > * Fixed instance of not properly setting ZonedDateTime in > TestTimestampType#testPhysicalIsLikelyOfType > * Changed timestamp for year 2016 in TimestampType to be UTC+0 instead of > UTC+8 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18496) Fix TestTimestampType failing on isLikelyOfType tests
[ https://issues.apache.org/jira/browse/HBASE-18496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109696#comment-16109696 ] Appy commented on HBASE-18496: -- +1 Thanks for the fix [~amit.patel]. Pushed to brach HBASE-14070.HLC. > Fix TestTimestampType failing on isLikelyOfType tests > - > > Key: HBASE-18496 > URL: https://issues.apache.org/jira/browse/HBASE-18496 > Project: HBase > Issue Type: Sub-task >Reporter: Amit Patel >Assignee: Amit Patel >Priority: Trivial > Attachments: HBASE-18496.HBASE-14070.HLC.001.patch > > > The tests testPhysicalIsLikelyOfType and testHybridIsLikelyOfType were > failing after the initial commit of core HLC so this patch fixes that. Note > that both Physical#isLikelyOfType and Hybrid#isLikelyOfType will return false > if the input timestamp is from before the first half of the first day of 1970. > Changes > * Offset date by second day of year > * Fixed instance of not properly setting ZonedDateTime in > TestTimestampType#testPhysicalIsLikelyOfType > * Changed timestamp for year 2016 in TimestampType to be UTC+0 instead of > UTC+8 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109673#comment-16109673 ] Hudson commented on HBASE-18487: SUCCESS: Integrated in Jenkins build HBase-1.2-IT #913 (See [https://builds.apache.org/job/HBase-1.2-IT/913/]) HBASE-18487 Minor fixes in row lock implementation (apurtell: rev 6cadd1def796656efbcb3ca10befe5d323b53f1a) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109654#comment-16109654 ] Hudson commented on HBASE-18487: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #152 (See [https://builds.apache.org/job/HBase-1.3-IT/152/]) HBASE-18487 Minor fixes in row lock implementation (apurtell: rev 84368110268ba0d2e75ce5acff2704eef615e3c6) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18496) Fix TestTimestampType failing on isLikelyOfType tests
[ https://issues.apache.org/jira/browse/HBASE-18496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Patel updated HBASE-18496: --- Attachment: HBASE-18496.HBASE-14070.HLC.001.patch > Fix TestTimestampType failing on isLikelyOfType tests > - > > Key: HBASE-18496 > URL: https://issues.apache.org/jira/browse/HBASE-18496 > Project: HBase > Issue Type: Sub-task >Reporter: Amit Patel >Assignee: Amit Patel >Priority: Trivial > Attachments: HBASE-18496.HBASE-14070.HLC.001.patch > > > The tests testPhysicalIsLikelyOfType and testHybridIsLikelyOfType were > failing after the initial commit of core HLC so this patch fixes that. Note > that both Physical#isLikelyOfType and Hybrid#isLikelyOfType will return false > if the input timestamp is from before the first half of the first day of 1970. > Changes > * Offset date by second day of year > * Fixed instance of not properly setting ZonedDateTime in > TestTimestampType#testPhysicalIsLikelyOfType > * Changed timestamp for year 2016 in TimestampType to be UTC+0 instead of > UTC+8 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18496) Fix TestTimestampType failing on isLikelyOfType tests
[ https://issues.apache.org/jira/browse/HBASE-18496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Patel updated HBASE-18496: --- Description: The tests testPhysicalIsLikelyOfType and testHybridIsLikelyOfType were failing after the initial commit of core HLC so this patch fixes that. Note that both Physical#isLikelyOfType and Hybrid#isLikelyOfType will return false if the input timestamp is from before the first half of the first day of 1970. Changes * Offset date by second day of year * Fixed instance of not properly setting ZonedDateTime in TestTimestampType#testPhysicalIsLikelyOfType * Changed timestamp for year 2016 in TimestampType to be UTC+0 instead of UTC+8 was:The tests testPhysicalIsLikelyOfType and testHybridIsLikelyOfType were failing after the initial commit of core HLC so this patch fixes that. Note that both Physical#isLikelyOfType and Hybrid#isLikelyOfType will return false if the input timestamp is from before the first half of the first day of 1970. > Fix TestTimestampType failing on isLikelyOfType tests > - > > Key: HBASE-18496 > URL: https://issues.apache.org/jira/browse/HBASE-18496 > Project: HBase > Issue Type: Sub-task >Reporter: Amit Patel >Assignee: Amit Patel >Priority: Trivial > > The tests testPhysicalIsLikelyOfType and testHybridIsLikelyOfType were > failing after the initial commit of core HLC so this patch fixes that. Note > that both Physical#isLikelyOfType and Hybrid#isLikelyOfType will return false > if the input timestamp is from before the first half of the first day of 1970. > Changes > * Offset date by second day of year > * Fixed instance of not properly setting ZonedDateTime in > TestTimestampType#testPhysicalIsLikelyOfType > * Changed timestamp for year 2016 in TimestampType to be UTC+0 instead of > UTC+8 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18491) [AMv2] Fail UnassignProcedure if source Region Server is not online.
[ https://issues.apache.org/jira/browse/HBASE-18491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109645#comment-16109645 ] Stephen Yuan Jiang commented on HBASE-18491: Looks good. > [AMv2] Fail UnassignProcedure if source Region Server is not online. > > > Key: HBASE-18491 > URL: https://issues.apache.org/jira/browse/HBASE-18491 > Project: HBase > Issue Type: Bug > Components: amv2 >Affects Versions: 2.0.0 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > Attachments: hbase-18491.master.001.patch > > > Currently UnassignProcedure returns success when server carrying a region is > NOT online. Assumption here is that ServerCrashProcedure will handle > splitting logs etc for these regions. When UnassignProcedure completes, > MoveRegionProcedure resumes with AssignProcedure. AssignProcedure can some > times assign regions without pre-requisite steps (done either by > UnassignProcedure or ServerCrashProcedure). Fix is to fail UnassignProcedure > and parent MoveRegionProcedure if source server is not online. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109646#comment-16109646 ] Hudson commented on HBASE-18487: FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #179 (See [https://builds.apache.org/job/HBase-1.2-JDK7/179/]) HBASE-18487 Minor fixes in row lock implementation (apurtell: rev 6cadd1def796656efbcb3ca10befe5d323b53f1a) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109639#comment-16109639 ] Hudson commented on HBASE-18487: FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #214 (See [https://builds.apache.org/job/HBase-1.3-JDK7/214/]) HBASE-18487 Minor fixes in row lock implementation (apurtell: rev 84368110268ba0d2e75ce5acff2704eef615e3c6) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18496) Fix TestTimestampType failing on isLikelyOfType tests
Amit Patel created HBASE-18496: -- Summary: Fix TestTimestampType failing on isLikelyOfType tests Key: HBASE-18496 URL: https://issues.apache.org/jira/browse/HBASE-18496 Project: HBase Issue Type: Sub-task Reporter: Amit Patel Assignee: Amit Patel Priority: Trivial The tests testPhysicalIsLikelyOfType and testHybridIsLikelyOfType were failing after the initial commit of core HLC so this patch fixes that. Note that both Physical#isLikelyOfType and Hybrid#isLikelyOfType will return false if the input timestamp is from before the first half of the first day of 1970. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18491) [AMv2] Fail UnassignProcedure if source Region Server is not online.
[ https://issues.apache.org/jira/browse/HBASE-18491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Umesh Agashe updated HBASE-18491: - Status: Patch Available (was: In Progress) > [AMv2] Fail UnassignProcedure if source Region Server is not online. > > > Key: HBASE-18491 > URL: https://issues.apache.org/jira/browse/HBASE-18491 > Project: HBase > Issue Type: Bug > Components: amv2 >Affects Versions: 2.0.0 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > Attachments: hbase-18491.master.001.patch > > > Currently UnassignProcedure returns success when server carrying a region is > NOT online. Assumption here is that ServerCrashProcedure will handle > splitting logs etc for these regions. When UnassignProcedure completes, > MoveRegionProcedure resumes with AssignProcedure. AssignProcedure can some > times assign regions without pre-requisite steps (done either by > UnassignProcedure or ServerCrashProcedure). Fix is to fail UnassignProcedure > and parent MoveRegionProcedure if source server is not online. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
