[jira] [Commented] (HBASE-18807) Remove PB references from Observers for Quotas
[ https://issues.apache.org/jira/browse/HBASE-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178562#comment-16178562 ] Anoop Sam John commented on HBASE-18807: bq.If it's OK with you, I'd like to work on that in a follow-on (which I would like to get done in time for alpha4) to change GlobalQuotaSettings to not expose PBs either. Sure.. we can have other subtasks to fix these issues :-) Thanks.. > Remove PB references from Observers for Quotas > -- > > Key: HBASE-18807 > URL: https://issues.apache.org/jira/browse/HBASE-18807 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 3.0.0, 2.0.0-alpha-4 > > Attachments: HBASE-18807.001.branch-2.patch, > HBASE-18807.002.branch-2.patch, HBASE-18807.003.branch-2.patch, > HBASE-18807.004.branch-2.patch > > > Break-out from the parent: > Same idea, just applied to the Observer methods for pre/post quota > operations. Requires changes to MasterQuotaManager and the QuotaSettings > implementations as some business logic is written on the PB objects directly. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18862) apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3
[ https://issues.apache.org/jira/browse/HBASE-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178560#comment-16178560 ] Pankaj Kumar commented on HBASE-18862: -- +1, LGTM.. > apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3 > - > > Key: HBASE-18862 > URL: https://issues.apache.org/jira/browse/HBASE-18862 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.3.1, 1.2.6, 1.1.12 >Reporter: Yechao Chen >Assignee: Yechao Chen >Priority: Critical > Fix For: 1.3.2, 1.2.7, 1.1.13 > > Attachments: HBASE-18862-branch-1.1.patch, > HBASE-18862-branch-1.2.patch, HBASE-18862-branch-1.3.patch, > HBASE-18862-branch-1.patch > > > HBASE-15109 should apply to branch-1.1,branch-1.2,branch-1.3 also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-18864) NullPointerException thrown when adding rows to a table from peer cluster, table with replication factor other than 0 or 1
[ https://issues.apache.org/jira/browse/HBASE-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Singhi reassigned HBASE-18864: - Assignee: Ashish Singhi > NullPointerException thrown when adding rows to a table from peer cluster, > table with replication factor other than 0 or 1 > -- > > Key: HBASE-18864 > URL: https://issues.apache.org/jira/browse/HBASE-18864 > Project: HBase > Issue Type: Bug > Components: hbase >Affects Versions: 1.3.0 >Reporter: smita >Assignee: Ashish Singhi > > Scenario: > = > add_peer > create a table > alter table with REPLICATION_SCOPE => '5' > enable table replication > login to peer cluster and try putting data to the table -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Empty byte array values for cells which doesn't exist
Hi, we have a table which when queried with more than one columkey for a row key (using addcolumn(colfamily, columkey)), returns cells which are not present. It returns a empty byte array as value for those cells. Using debugger we found the timestamp of those cells to *'OLDEST_TIMESTAMP'* and the type to be *'Minimum'*. These cells turns out to be fake cells, however when queried with only columnkey it doesn't return any cells. Please look into the following files and suggest some ways to rectify this problem. 1. HConstant.java 2. KeyValue.java 3. ScanQueryMatcher.java 4. StoreFileScanner.java NOTE: We are not able to reproduce the same in other tables.
[jira] [Commented] (HBASE-18845) TestReplicationSmallTests fails after HBASE-14004
[ https://issues.apache.org/jira/browse/HBASE-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178509#comment-16178509 ] Duo Zhang commented on HBASE-18845: --- Also did some refactoring to remove warnings. [~tedyu] Could you please verify if this patch works for you? Thanks. > TestReplicationSmallTests fails after HBASE-14004 > - > > Key: HBASE-18845 > URL: https://issues.apache.org/jira/browse/HBASE-18845 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 3.0.0, 2.0.0-alpha-3 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-4 > > Attachments: HBASE-18845.patch > > > testEmptyWALRecovery and testVerifyRepJob -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18845) TestReplicationSmallTests fails after HBASE-14004
[ https://issues.apache.org/jira/browse/HBASE-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-18845: -- Status: Patch Available (was: Open) > TestReplicationSmallTests fails after HBASE-14004 > - > > Key: HBASE-18845 > URL: https://issues.apache.org/jira/browse/HBASE-18845 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 2.0.0-alpha-3, 3.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-4 > > Attachments: HBASE-18845.patch > > > testEmptyWALRecovery and testVerifyRepJob -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18845) TestReplicationSmallTests fails after HBASE-14004
[ https://issues.apache.org/jira/browse/HBASE-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-18845: -- Attachment: HBASE-18845.patch Fix testEmptyWALRecovery. This is a test issue. We do not rely on the number of queued files to determine if the current file is still being written, so we need to modify the UT. Add comments in the UT. And Seems the test itself is flakey so it still fails sometimes... > TestReplicationSmallTests fails after HBASE-14004 > - > > Key: HBASE-18845 > URL: https://issues.apache.org/jira/browse/HBASE-18845 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 3.0.0, 2.0.0-alpha-3 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-4 > > Attachments: HBASE-18845.patch > > > testEmptyWALRecovery and testVerifyRepJob -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-18845) TestReplicationSmallTests fails after HBASE-14004
[ https://issues.apache.org/jira/browse/HBASE-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-18845: - Assignee: Duo Zhang > TestReplicationSmallTests fails after HBASE-14004 > - > > Key: HBASE-18845 > URL: https://issues.apache.org/jira/browse/HBASE-18845 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 3.0.0, 2.0.0-alpha-3 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-4 > > > testEmptyWALRecovery and testVerifyRepJob -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17732) Coprocessor Design Improvements
[
https://issues.apache.org/jira/browse/HBASE-17732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Appy updated HBASE-17732:
-
Attachment: HBASE-17732.master.008.patch
> Coprocessor Design Improvements
> ---
>
> Key: HBASE-17732
> URL: https://issues.apache.org/jira/browse/HBASE-17732
> Project: HBase
> Issue Type: Improvement
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-17732.master.001.patch,
> HBASE-17732.master.002.patch, HBASE-17732.master.003.patch,
> HBASE-17732.master.004.patch, HBASE-17732.master.005.patch,
> HBASE-17732.master.006.patch, HBASE-17732.master.007.patch,
> HBASE-17732.master.008.patch
>
>
> The two main changes are:
> * *Adding template for coprocessor type to CoprocessorEnvironment i.e.
> {{interface CoprocessorEnvironment}}*
> ** Enables us to load only relevant coprocessors in hosts. Right now each
> type of host loads all types of coprocs and it's only during execOperation
> that it checks if the coproc is of correct type i.e. XCoprocessorHost will
> load XObserver, YObserver, and all others, and will check in execOperation if
> {{coproc instanceOf XObserver}} and ignore the rest.
> ** Allow sharing of a bunch functions/classes which are currently
> duplicated in each host. For eg. CoprocessorOperations,
> CoprocessorOperationWithResult, execOperations().
> * *Introduce 4 coprocessor classes and use composition between these new
> classes and and old observers*
> ** The real gold here is, moving forward, we'll be able to break down giant
> everything-in-one observers (masterobserver has 100+ functions) into smaller,
> more focused observers. These smaller observer can then have different compat
> guarantees!!
> Here's a more detailed design doc:
> https://docs.google.com/document/d/1mPkM1CRRvBMZL4dBQzrus8obyvNnHhR5it2yyhiFXTg/edit?usp=sharing
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-18825: -- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to master and branch-2. Thanks all for reviewing. > Use HStoreFile instead of StoreFile in our own code base and remove > unnecessary methods in StoreFile interface > -- > > Key: HBASE-18825 > URL: https://issues.apache.org/jira/browse/HBASE-18825 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Affects Versions: 3.0.0, 2.0.0-alpha-3 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-4 > > Attachments: HBASE-18825.patch, HBASE-18825-v1.patch, > HBASE-18825-v2.patch, HBASE-18825-v3.patch, HBASE-18825-v3.patch, > HBASE-18825-v4.patch, HBASE-18825-v5.patch, HBASE-18825-v6.patch > > > Use generic types to avoid too many casts. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16290) Dump summary of callQueue content; can help debugging
[ https://issues.apache.org/jira/browse/HBASE-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sreeram Venkatasubramanian updated HBASE-16290: --- Status: Patch Available (was: Open) Hi [~chia7712], I have rebased the patch as well as made changes based on your comments. > Dump summary of callQueue content; can help debugging > - > > Key: HBASE-16290 > URL: https://issues.apache.org/jira/browse/HBASE-16290 > Project: HBase > Issue Type: Bug > Components: Operability >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Sreeram Venkatasubramanian > Labels: beginner > Fix For: 2.0.0 > > Attachments: 0001-Changes-for-HBASE-16290.patch.old, > 0001-Changes-for-HBASE-16290-to-dump-callqueue-contents.patch, > 0001-Dump-call-queue-summaries.patch.old, DebugDump_screenshot.png, Sample > Summary.txt > > > Being able to get a clue what is in a backedup callQueue could give insight > on what is going on on a jacked server. Just needs to summarize count, sizes, > call types. Useful debugging. In a servlet? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16290) Dump summary of callQueue content; can help debugging
[ https://issues.apache.org/jira/browse/HBASE-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sreeram Venkatasubramanian updated HBASE-16290: --- Attachment: 0001-Changes-for-HBASE-16290-to-dump-callqueue-contents.patch > Dump summary of callQueue content; can help debugging > - > > Key: HBASE-16290 > URL: https://issues.apache.org/jira/browse/HBASE-16290 > Project: HBase > Issue Type: Bug > Components: Operability >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Sreeram Venkatasubramanian > Labels: beginner > Fix For: 2.0.0 > > Attachments: 0001-Changes-for-HBASE-16290.patch.old, > 0001-Changes-for-HBASE-16290-to-dump-callqueue-contents.patch, > 0001-Dump-call-queue-summaries.patch.old, DebugDump_screenshot.png, Sample > Summary.txt > > > Being able to get a clue what is in a backedup callQueue could give insight > on what is going on on a jacked server. Just needs to summarize count, sizes, > call types. Useful debugging. In a servlet? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16290) Dump summary of callQueue content; can help debugging
[ https://issues.apache.org/jira/browse/HBASE-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sreeram Venkatasubramanian updated HBASE-16290: --- Status: Open (was: Patch Available) > Dump summary of callQueue content; can help debugging > - > > Key: HBASE-16290 > URL: https://issues.apache.org/jira/browse/HBASE-16290 > Project: HBase > Issue Type: Bug > Components: Operability >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Sreeram Venkatasubramanian > Labels: beginner > Fix For: 2.0.0 > > Attachments: 0001-Changes-for-HBASE-16290.patch.old, > 0001-Dump-call-queue-summaries.patch.old, DebugDump_screenshot.png, Sample > Summary.txt > > > Being able to get a clue what is in a backedup callQueue could give insight > on what is going on on a jacked server. Just needs to summarize count, sizes, > call types. Useful debugging. In a servlet? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16290) Dump summary of callQueue content; can help debugging
[ https://issues.apache.org/jira/browse/HBASE-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sreeram Venkatasubramanian updated HBASE-16290: --- Status: Patch Available (was: Open) > Dump summary of callQueue content; can help debugging > - > > Key: HBASE-16290 > URL: https://issues.apache.org/jira/browse/HBASE-16290 > Project: HBase > Issue Type: Bug > Components: Operability >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Sreeram Venkatasubramanian > Labels: beginner > Fix For: 2.0.0 > > Attachments: 0001-Changes-for-HBASE-16290.patch.old, > 0001-Dump-call-queue-summaries.patch.old, DebugDump_screenshot.png, Sample > Summary.txt > > > Being able to get a clue what is in a backedup callQueue could give insight > on what is going on on a jacked server. Just needs to summarize count, sizes, > call types. Useful debugging. In a servlet? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16290) Dump summary of callQueue content; can help debugging
[ https://issues.apache.org/jira/browse/HBASE-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sreeram Venkatasubramanian updated HBASE-16290: --- Status: Open (was: Patch Available) > Dump summary of callQueue content; can help debugging > - > > Key: HBASE-16290 > URL: https://issues.apache.org/jira/browse/HBASE-16290 > Project: HBase > Issue Type: Bug > Components: Operability >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Sreeram Venkatasubramanian > Labels: beginner > Fix For: 2.0.0 > > Attachments: 0001-Changes-for-HBASE-16290.patch.old, > 0001-Dump-call-queue-summaries.patch.old, DebugDump_screenshot.png, Sample > Summary.txt > > > Being able to get a clue what is in a backedup callQueue could give insight > on what is going on on a jacked server. Just needs to summarize count, sizes, > call types. Useful debugging. In a servlet? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16290) Dump summary of callQueue content; can help debugging
[ https://issues.apache.org/jira/browse/HBASE-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sreeram Venkatasubramanian updated HBASE-16290: --- Attachment: 0001-Changes-for-HBASE-16290.patch.old > Dump summary of callQueue content; can help debugging > - > > Key: HBASE-16290 > URL: https://issues.apache.org/jira/browse/HBASE-16290 > Project: HBase > Issue Type: Bug > Components: Operability >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Sreeram Venkatasubramanian > Labels: beginner > Fix For: 2.0.0 > > Attachments: 0001-Changes-for-HBASE-16290.patch.old, > 0001-Dump-call-queue-summaries.patch.old, DebugDump_screenshot.png, Sample > Summary.txt > > > Being able to get a clue what is in a backedup callQueue could give insight > on what is going on on a jacked server. Just needs to summarize count, sizes, > call types. Useful debugging. In a servlet? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16290) Dump summary of callQueue content; can help debugging
[ https://issues.apache.org/jira/browse/HBASE-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sreeram Venkatasubramanian updated HBASE-16290: --- Attachment: (was: 0001-Changes-for-HBASE-16290.patch) > Dump summary of callQueue content; can help debugging > - > > Key: HBASE-16290 > URL: https://issues.apache.org/jira/browse/HBASE-16290 > Project: HBase > Issue Type: Bug > Components: Operability >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Sreeram Venkatasubramanian > Labels: beginner > Fix For: 2.0.0 > > Attachments: 0001-Changes-for-HBASE-16290.patch.old, > 0001-Dump-call-queue-summaries.patch.old, DebugDump_screenshot.png, Sample > Summary.txt > > > Being able to get a clue what is in a backedup callQueue could give insight > on what is going on on a jacked server. Just needs to summarize count, sizes, > call types. Useful debugging. In a servlet? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17732) Coprocessor Design Improvements
[
https://issues.apache.org/jira/browse/HBASE-17732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178457#comment-16178457
]
Hadoop QA commented on HBASE-17732:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} HBASE-17732 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-17732 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12888765/HBASE-17732.master.007.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8762/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Coprocessor Design Improvements
> ---
>
> Key: HBASE-17732
> URL: https://issues.apache.org/jira/browse/HBASE-17732
> Project: HBase
> Issue Type: Improvement
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-17732.master.001.patch,
> HBASE-17732.master.002.patch, HBASE-17732.master.003.patch,
> HBASE-17732.master.004.patch, HBASE-17732.master.005.patch,
> HBASE-17732.master.006.patch, HBASE-17732.master.007.patch
>
>
> The two main changes are:
> * *Adding template for coprocessor type to CoprocessorEnvironment i.e.
> {{interface CoprocessorEnvironment}}*
> ** Enables us to load only relevant coprocessors in hosts. Right now each
> type of host loads all types of coprocs and it's only during execOperation
> that it checks if the coproc is of correct type i.e. XCoprocessorHost will
> load XObserver, YObserver, and all others, and will check in execOperation if
> {{coproc instanceOf XObserver}} and ignore the rest.
> ** Allow sharing of a bunch functions/classes which are currently
> duplicated in each host. For eg. CoprocessorOperations,
> CoprocessorOperationWithResult, execOperations().
> * *Introduce 4 coprocessor classes and use composition between these new
> classes and and old observers*
> ** The real gold here is, moving forward, we'll be able to break down giant
> everything-in-one observers (masterobserver has 100+ functions) into smaller,
> more focused observers. These smaller observer can then have different compat
> guarantees!!
> Here's a more detailed design doc:
> https://docs.google.com/document/d/1mPkM1CRRvBMZL4dBQzrus8obyvNnHhR5it2yyhiFXTg/edit?usp=sharing
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-17732) Coprocessor Design Improvements
[
https://issues.apache.org/jira/browse/HBASE-17732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Appy updated HBASE-17732:
-
Attachment: HBASE-17732.master.007.patch
> Coprocessor Design Improvements
> ---
>
> Key: HBASE-17732
> URL: https://issues.apache.org/jira/browse/HBASE-17732
> Project: HBase
> Issue Type: Improvement
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-17732.master.001.patch,
> HBASE-17732.master.002.patch, HBASE-17732.master.003.patch,
> HBASE-17732.master.004.patch, HBASE-17732.master.005.patch,
> HBASE-17732.master.006.patch, HBASE-17732.master.007.patch
>
>
> The two main changes are:
> * *Adding template for coprocessor type to CoprocessorEnvironment i.e.
> {{interface CoprocessorEnvironment}}*
> ** Enables us to load only relevant coprocessors in hosts. Right now each
> type of host loads all types of coprocs and it's only during execOperation
> that it checks if the coproc is of correct type i.e. XCoprocessorHost will
> load XObserver, YObserver, and all others, and will check in execOperation if
> {{coproc instanceOf XObserver}} and ignore the rest.
> ** Allow sharing of a bunch functions/classes which are currently
> duplicated in each host. For eg. CoprocessorOperations,
> CoprocessorOperationWithResult, execOperations().
> * *Introduce 4 coprocessor classes and use composition between these new
> classes and and old observers*
> ** The real gold here is, moving forward, we'll be able to break down giant
> everything-in-one observers (masterobserver has 100+ functions) into smaller,
> more focused observers. These smaller observer can then have different compat
> guarantees!!
> Here's a more detailed design doc:
> https://docs.google.com/document/d/1mPkM1CRRvBMZL4dBQzrus8obyvNnHhR5it2yyhiFXTg/edit?usp=sharing
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18868) metrics error and the jmx loss many metrics like 'Hadoop:service=HBase,name=RegionServer,sub=IPC'
[ https://issues.apache.org/jira/browse/HBASE-18868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wuchengzhi updated HBASE-18868: --- Description: so many metrics error log printed in the regionserver log all the time, then the web-gui http://hbase-master1:16010/jmx loss some metrics like 'Hadoop:service=HBase,name=RegionServer,sub=Regions' , 'Hadoop:service=HBase,name=RegionServer,sub=IPC' ... is there something wrong i configured at my hbase-site.xml or hbase-env.sh? regionserver logs: 2017-09-21 05:03:42,088 INFO [HBase-Metrics2-1] impl.MetricsSystemImpl: Scheduled snapshot period at 10 second(s). 2017-09-21 05:03:42,088 INFO [HBase-Metrics2-1] impl.MetricsSystemImpl: HBase metrics system started 2017-09-21 05:03:42,088 WARN [HBase-Metrics2-1] util.MBeans: Error creating MBean object name: Hadoop:service=HBase,name=JvmMetrics org.apache.hadoop.metrics2.MetricsException: org.apache.hadoop.metrics2.MetricsException: Hadoop:service=HBase,name=JvmMetrics already exists! at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.newObjectName(DefaultMetricsSystem.java:117) at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.newMBeanName(DefaultMetricsSystem.java:102) at org.apache.hadoop.metrics2.util.MBeans.getMBeanName(MBeans.java:91) at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:55) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:220) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:95) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.registerSource(MetricsSystemImpl.java:244) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl$1.postStart(MetricsSystemImpl.java:228) at sun.reflect.GeneratedMethodAccessor84.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl$3.invoke(MetricsSystemImpl.java:289) at com.sun.proxy.$Proxy11.postStart(Unknown Source) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:184) at org.apache.hadoop.metrics2.impl.JmxCacheBuster$JmxCacheBusterRunnable.run(JmxCacheBuster.java:78) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) Caused by: org.apache.hadoop.metrics2.MetricsException: Hadoop:service=HBase,name=JvmMetrics already exists! at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.newObjectName(DefaultMetricsSystem.java:113) ... 21 more 2017-09-21 05:03:42,090 WARN [HBase-Metrics2-1] util.MBeans: Failed to register MBean "null" javax.management.RuntimeOperationsException: Exception occurred trying to register the MBean at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerDynamicMBean(DefaultMBeanServerInterceptor.java:951) at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerObject(DefaultMBeanServerInterceptor.java:900) at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:324) at com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522) at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:57) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:220) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:95) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.registerSource(MetricsSystemImpl.java:244) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl$1.postStart(MetricsSystemImpl.java:228) at sun.reflect.GeneratedMethodAccessor84.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl$3.invoke(MetricsSystemImpl.java:289) at com.sun.proxy.$Proxy11.postStart(Unknown Source) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:184) at
[jira] [Updated] (HBASE-18868) metrics error and the jmx loss many metrics like 'Hadoop:service=HBase,name=RegionServer,sub=IPC'
[ https://issues.apache.org/jira/browse/HBASE-18868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wuchengzhi updated HBASE-18868: --- Attachment: jmx-iffy.json the jmx show so little info as the attachment > metrics error and the jmx loss many metrics like > 'Hadoop:service=HBase,name=RegionServer,sub=IPC' > - > > Key: HBASE-18868 > URL: https://issues.apache.org/jira/browse/HBASE-18868 > Project: HBase > Issue Type: Bug > Components: metrics >Affects Versions: 1.2.1, 1.2.4, 1.2.6 > Environment: 2*6 cores process,E5-2620v3 , 128G memory , 1*600G > SAS，12*6T SATA > Linux version 2.6.32-504.el6.x86_64 (mockbu...@c6b9.bsys.dev.centos.org) (gcc > version 4.4.7 20120313 (Red Hat 4.4.7-11) (GCC) ) #1 SMP Wed Oct 15 04:27:16 > UTC 2014 >Reporter: wuchengzhi >Priority: Critical > Labels: jmx, metrics > Attachments: jmx-iffy.json > > Original Estimate: 48h > Remaining Estimate: 48h > > so many metrics error log printed in the regionserver log all the time, then > the web-gui http://hbase-master1:16010/jmx loss some metrics like > 'Hadoop:service=HBase,name=RegionServer,sub=Regions' , > 'Hadoop:service=HBase,name=RegionServer,sub=IPC' ... > is there something wrong i configured at my hbase-site.xml or hbase-env.sh? > ver.thread.wakefrequency > 1000 > > > hbase.rpc.timeout > 5400 > > > hbase.hstore.blockingStoreFiles > 500 > > > hbase.client.scanner.timeout.period > 60 > > > zookeeper.session.timeout > 18 > > > hbase.regionserver.optionallogflushinterval > 5000 > > > hbase.client.write.buffer > 5242880 > > > hbase.hstore.compactionThreshold > 5 > > >hbase.hstore.compaction.max > 12 > > > > hbase.regionserver.regionSplitLimit > 1 > > > hbase.regionserver.thread.compaction.large > 3 > > > hbase.regionserver.thread.compaction.small > 8 > > > hbase.master.logcleaner.ttl > 360 > > > hbase.bucketcache.ioengine > offheap> > > > hbase.bucketcache.percentage.in.combinedcache > 0.9 > > > hbase.bucketcache.size > 26214 > > > hbase.master.maxclockskew > 15 > > > >hbase.regionserver.port >16021 > > >hbase.regionserver.info.port >16011 > > > > > hbase.replication > true > > > replication.source.nb.capacity > 6000 > > > replication.source.size.capacity > 67108864 > > > replication.source.ratio > 1 > > > hbase.regionserver.wal.enablecompression > false > > >replication.sleep.before.failover > 5000 > > > replication.executor.workers > 5 > > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18868) metrics error and the jmx loss many metrics like 'Hadoop:service=HBase,name=RegionServer,sub=IPC'
[ https://issues.apache.org/jira/browse/HBASE-18868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wuchengzhi updated HBASE-18868: --- Labels: jmx metrics (was: ) > metrics error and the jmx loss many metrics like > 'Hadoop:service=HBase,name=RegionServer,sub=IPC' > - > > Key: HBASE-18868 > URL: https://issues.apache.org/jira/browse/HBASE-18868 > Project: HBase > Issue Type: Bug > Components: metrics >Affects Versions: 1.2.1, 1.2.4, 1.2.6 > Environment: 2*6 cores process,E5-2620v3 , 128G memory , 1*600G > SAS，12*6T SATA > Linux version 2.6.32-504.el6.x86_64 (mockbu...@c6b9.bsys.dev.centos.org) (gcc > version 4.4.7 20120313 (Red Hat 4.4.7-11) (GCC) ) #1 SMP Wed Oct 15 04:27:16 > UTC 2014 >Reporter: wuchengzhi >Priority: Critical > Labels: jmx, metrics > Original Estimate: 48h > Remaining Estimate: 48h > > so many metrics error log printed in the regionserver log all the time, then > the web-gui http://hbase-master1:16010/jmx loss some metrics like > 'Hadoop:service=HBase,name=RegionServer,sub=Regions' , > 'Hadoop:service=HBase,name=RegionServer,sub=IPC' ... > is there something wrong i configured at my hbase-site.xml or hbase-env.sh? > ver.thread.wakefrequency > 1000 > > > hbase.rpc.timeout > 5400 > > > hbase.hstore.blockingStoreFiles > 500 > > > hbase.client.scanner.timeout.period > 60 > > > zookeeper.session.timeout > 18 > > > hbase.regionserver.optionallogflushinterval > 5000 > > > hbase.client.write.buffer > 5242880 > > > hbase.hstore.compactionThreshold > 5 > > >hbase.hstore.compaction.max > 12 > > > > hbase.regionserver.regionSplitLimit > 1 > > > hbase.regionserver.thread.compaction.large > 3 > > > hbase.regionserver.thread.compaction.small > 8 > > > hbase.master.logcleaner.ttl > 360 > > > hbase.bucketcache.ioengine > offheap> > > > hbase.bucketcache.percentage.in.combinedcache > 0.9 > > > hbase.bucketcache.size > 26214 > > > hbase.master.maxclockskew > 15 > > > >hbase.regionserver.port >16021 > > >hbase.regionserver.info.port >16011 > > > > > hbase.replication > true > > > replication.source.nb.capacity > 6000 > > > replication.source.size.capacity > 67108864 > > > replication.source.ratio > 1 > > > hbase.regionserver.wal.enablecompression > false > > >replication.sleep.before.failover > 5000 > > > replication.executor.workers > 5 > > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18868) metrics error and the jmx loss many metrics like 'Hadoop:service=HBase,name=RegionServer,sub=IPC'
wuchengzhi created HBASE-18868: -- Summary: metrics error and the jmx loss many metrics like 'Hadoop:service=HBase,name=RegionServer,sub=IPC' Key: HBASE-18868 URL: https://issues.apache.org/jira/browse/HBASE-18868 Project: HBase Issue Type: Bug Components: metrics Affects Versions: 1.2.6, 1.2.4, 1.2.1 Environment: 2*6 cores process,E5-2620v3 , 128G memory , 1*600G SAS，12*6T SATA Linux version 2.6.32-504.el6.x86_64 (mockbu...@c6b9.bsys.dev.centos.org) (gcc version 4.4.7 20120313 (Red Hat 4.4.7-11) (GCC) ) #1 SMP Wed Oct 15 04:27:16 UTC 2014 Reporter: wuchengzhi Priority: Critical so many metrics error log printed in the regionserver log all the time, then the web-gui http://hbase-master1:16010/jmx loss some metrics like 'Hadoop:service=HBase,name=RegionServer,sub=Regions' , 'Hadoop:service=HBase,name=RegionServer,sub=IPC' ... is there something wrong i configured at my hbase-site.xml or hbase-env.sh? ver.thread.wakefrequency 1000 hbase.rpc.timeout 5400 hbase.hstore.blockingStoreFiles 500 hbase.client.scanner.timeout.period 60 zookeeper.session.timeout 18 hbase.regionserver.optionallogflushinterval 5000 hbase.client.write.buffer 5242880 hbase.hstore.compactionThreshold 5 hbase.hstore.compaction.max 12 hbase.regionserver.regionSplitLimit 1 hbase.regionserver.thread.compaction.large 3 hbase.regionserver.thread.compaction.small 8 hbase.master.logcleaner.ttl 360 hbase.bucketcache.ioengine offheap> hbase.bucketcache.percentage.in.combinedcache 0.9 hbase.bucketcache.size 26214 hbase.master.maxclockskew 15 hbase.regionserver.port 16021 hbase.regionserver.info.port 16011 hbase.replication true replication.source.nb.capacity 6000 replication.source.size.capacity 67108864 replication.source.ratio 1 hbase.regionserver.wal.enablecompression false replication.sleep.before.failover 5000 replication.executor.workers 5 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18467) nightly job needs to comment on jira
[
https://issues.apache.org/jira/browse/HBASE-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178444#comment-16178444
]
Hadoop QA commented on HBASE-18467:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
32s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
5s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
26s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
6s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 2 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
53s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
36m 10s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 48m 26s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18467 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12888761/HBASE-18467.0.patch |
| Optional Tests | asflicense shadedjars shellcheck shelldocs |
| uname | Linux 2d38a513bf9b 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 1540483 |
| shellcheck | v0.4.6 |
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/8761/artifact/patchprocess/whitespace-tabs.txt
|
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8761/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> nightly job needs to comment on jira
>
>
> Key: HBASE-18467
> URL: https://issues.apache.org/jira/browse/HBASE-18467
> Project: HBase
> Issue Type: Improvement
> Components: community, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Attachments: HBASE-18467.0.patch, HBASE-18467.0.WIP.patch
>
>
> follow on from HBASE-18147, need a post action that pings all newly-committed
> jiras with result of the branch build
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178435#comment-16178435 ] Duo Zhang commented on HBASE-18825: --- Let me commit. > Use HStoreFile instead of StoreFile in our own code base and remove > unnecessary methods in StoreFile interface > -- > > Key: HBASE-18825 > URL: https://issues.apache.org/jira/browse/HBASE-18825 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Affects Versions: 3.0.0, 2.0.0-alpha-3 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-4 > > Attachments: HBASE-18825.patch, HBASE-18825-v1.patch, > HBASE-18825-v2.patch, HBASE-18825-v3.patch, HBASE-18825-v3.patch, > HBASE-18825-v4.patch, HBASE-18825-v5.patch, HBASE-18825-v6.patch > > > Use generic types to avoid too many casts. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18467) nightly job needs to comment on jira
[ https://issues.apache.org/jira/browse/HBASE-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-18467: Attachment: HBASE-18467.0.patch -0 - don't fail individual stages - generate a jira comment about the individual stage statuses - post to jira > nightly job needs to comment on jira > > > Key: HBASE-18467 > URL: https://issues.apache.org/jira/browse/HBASE-18467 > Project: HBase > Issue Type: Improvement > Components: community, test >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Critical > Attachments: HBASE-18467.0.patch, HBASE-18467.0.WIP.patch > > > follow on from HBASE-18147, need a post action that pings all newly-committed > jiras with result of the branch build -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18467) nightly job needs to comment on jira
[ https://issues.apache.org/jira/browse/HBASE-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-18467: Status: Patch Available (was: Open) > nightly job needs to comment on jira > > > Key: HBASE-18467 > URL: https://issues.apache.org/jira/browse/HBASE-18467 > Project: HBase > Issue Type: Improvement > Components: community, test >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Critical > Attachments: HBASE-18467.0.patch, HBASE-18467.0.WIP.patch > > > follow on from HBASE-18147, need a post action that pings all newly-committed > jiras with result of the branch build -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18467) nightly job needs to comment on jira
[ https://issues.apache.org/jira/browse/HBASE-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178425#comment-16178425 ] Sean Busbey commented on HBASE-18467: - that job failed because the jdk8 checks didn't produce any test results (and AFAICT I can't tell jenkins both to publish junit results and ignore if there aren't any). > nightly job needs to comment on jira > > > Key: HBASE-18467 > URL: https://issues.apache.org/jira/browse/HBASE-18467 > Project: HBase > Issue Type: Improvement > Components: community, test >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Critical > Attachments: HBASE-18467.0.WIP.patch > > > follow on from HBASE-18147, need a post action that pings all newly-committed > jiras with result of the branch build -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18467) nightly job needs to comment on jira
[
https://issues.apache.org/jira/browse/HBASE-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178420#comment-16178420
]
Hudson commented on HBASE-18467:
Results for branch HBASE-18467, done in 4 min 16 sec and counting
[build #124 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18467/124/]:
FAILURE
details (if available):
(x) *{color:red}-1 overall{color}*
Committer, please check your recent inclusion of a patch for this issue.
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18467/124//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 checks{color}
-- For more information [see jdk8
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18467/124//JDK8_Nightly_Build_Report/]
> nightly job needs to comment on jira
>
>
> Key: HBASE-18467
> URL: https://issues.apache.org/jira/browse/HBASE-18467
> Project: HBase
> Issue Type: Improvement
> Components: community, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Attachments: HBASE-18467.0.WIP.patch
>
>
> follow on from HBASE-18147, need a post action that pings all newly-committed
> jiras with result of the branch build
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-13844) Move static helper methods from KeyValue into CellUtils
[
https://issues.apache.org/jira/browse/HBASE-13844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178355#comment-16178355
]
Hadoop QA commented on HBASE-13844:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 5 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
36s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
3s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
2s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
17s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 7m
15s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
35s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
47s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 2 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
56s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
35m 55s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
17s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
29s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 98m
47s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m
57s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
58s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
3s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}192m 4s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
|
[jira] [Commented] (HBASE-18807) Remove PB references from Observers for Quotas
[ https://issues.apache.org/jira/browse/HBASE-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178316#comment-16178316 ] Josh Elser commented on HBASE-18807: bq. Sorry for being late here No worries! I wanted to make sure I ran it by you. bq. GlobalQuotaSettings , I can see states like QuotaProtos.Throttle and getters for that Yeah, that's going to be even more work to untangle. For whatever reason, the ThrottleSettings and related PB messages aren't bidirectional when it comes to serialization and all of the server-side code was written expecting the Quotas PB object. If it's OK with you, I'd like to work on that in a follow-on (which I would like to get done in time for alpha4) to change GlobalQuotaSettings to not expose PBs either. > Remove PB references from Observers for Quotas > -- > > Key: HBASE-18807 > URL: https://issues.apache.org/jira/browse/HBASE-18807 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 3.0.0, 2.0.0-alpha-4 > > Attachments: HBASE-18807.001.branch-2.patch, > HBASE-18807.002.branch-2.patch, HBASE-18807.003.branch-2.patch, > HBASE-18807.004.branch-2.patch > > > Break-out from the parent: > Same idea, just applied to the Observer methods for pre/post quota > operations. Requires changes to MasterQuotaManager and the QuotaSettings > implementations as some business logic is written on the PB objects directly. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-13844) Move static helper methods from KeyValue into CellUtils
[ https://issues.apache.org/jira/browse/HBASE-13844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Yang updated HBASE-13844: -- Status: Open (was: Patch Available) > Move static helper methods from KeyValue into CellUtils > --- > > Key: HBASE-13844 > URL: https://issues.apache.org/jira/browse/HBASE-13844 > Project: HBase > Issue Type: Improvement >Affects Versions: 1.1.0 >Reporter: Lars George >Assignee: Andy Yang >Priority: Minor > Labels: beginner > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-13844.1.patch, HBASE-13844.2.patch, > HBASE-13844.3.patch, HBASE-13844.branch-2.v0.patch, > HBASE-13844.branch-2.v1.patch, HBASE-13844.branch-2.v2.patch > > > Add KeyValue.parseColumn() to CellUtils (also any other public static helper) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-13844) Move static helper methods from KeyValue into CellUtils
[ https://issues.apache.org/jira/browse/HBASE-13844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Yang updated HBASE-13844: -- Status: Patch Available (was: Open) > Move static helper methods from KeyValue into CellUtils > --- > > Key: HBASE-13844 > URL: https://issues.apache.org/jira/browse/HBASE-13844 > Project: HBase > Issue Type: Improvement >Affects Versions: 1.1.0 >Reporter: Lars George >Assignee: Andy Yang >Priority: Minor > Labels: beginner > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-13844.1.patch, HBASE-13844.2.patch, > HBASE-13844.3.patch, HBASE-13844.branch-2.v0.patch, > HBASE-13844.branch-2.v1.patch, HBASE-13844.branch-2.v2.patch > > > Add KeyValue.parseColumn() to CellUtils (also any other public static helper) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-13844) Move static helper methods from KeyValue into CellUtils
[ https://issues.apache.org/jira/browse/HBASE-13844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Yang updated HBASE-13844: -- Attachment: HBASE-13844.branch-2.v2.patch > Move static helper methods from KeyValue into CellUtils > --- > > Key: HBASE-13844 > URL: https://issues.apache.org/jira/browse/HBASE-13844 > Project: HBase > Issue Type: Improvement >Affects Versions: 1.1.0 >Reporter: Lars George >Assignee: Andy Yang >Priority: Minor > Labels: beginner > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-13844.1.patch, HBASE-13844.2.patch, > HBASE-13844.3.patch, HBASE-13844.branch-2.v0.patch, > HBASE-13844.branch-2.v1.patch, HBASE-13844.branch-2.v2.patch > > > Add KeyValue.parseColumn() to CellUtils (also any other public static helper) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Reopened] (HBASE-17249) Get/Scan's setTimeRange/setColumnFamilyTimeRange can take the TimeRange reference as the parameter instead of creating a new setColumnFamilyTimeRange instance
[ https://issues.apache.org/jira/browse/HBASE-17249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huaxiang sun reopened HBASE-17249: -- > Get/Scan's setTimeRange/setColumnFamilyTimeRange can take the TimeRange > reference as the parameter instead of creating a new setColumnFamilyTimeRange > instance > -- > > Key: HBASE-17249 > URL: https://issues.apache.org/jira/browse/HBASE-17249 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 2.0.0 > > Attachments: HBASE-17249-master-001.patch, > HBASE-17249.master.001.patch, HBASE-17249-master-002.patch, > HBASE-17249-master-003.patch > > > Going through the code, found For Get/Scan's > setTimeRange/setColumnFamilyTimeRange, it can use TimeRange as reference > instead of creating a new one. > Reference: > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L500 > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L506 > We can implement this in a similar way as filter: > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L510 > I checked it is same with branch-1. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (HBASE-17249) Get/Scan's setTimeRange/setColumnFamilyTimeRange can take the TimeRange reference as the parameter instead of creating a new setColumnFamilyTimeRange instance
[ https://issues.apache.org/jira/browse/HBASE-17249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huaxiang sun resolved HBASE-17249. -- Resolution: Won't Fix Yeah, you are right. I change it to wont fix. > Get/Scan's setTimeRange/setColumnFamilyTimeRange can take the TimeRange > reference as the parameter instead of creating a new setColumnFamilyTimeRange > instance > -- > > Key: HBASE-17249 > URL: https://issues.apache.org/jira/browse/HBASE-17249 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 2.0.0 > > Attachments: HBASE-17249-master-001.patch, > HBASE-17249.master.001.patch, HBASE-17249-master-002.patch, > HBASE-17249-master-003.patch > > > Going through the code, found For Get/Scan's > setTimeRange/setColumnFamilyTimeRange, it can use TimeRange as reference > instead of creating a new one. > Reference: > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L500 > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L506 > We can implement this in a similar way as filter: > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L510 > I checked it is same with branch-1. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18010) Connect CellChunkMap to be used for flattening in CompactingMemStore
[
https://issues.apache.org/jira/browse/HBASE-18010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178257#comment-16178257
]
Hadoop QA commented on HBASE-18010:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 10 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
26s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
0s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
10s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
30s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
56s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
21s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
31s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
43m 57s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
27s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 62m 28s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
50s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}135m 52s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure |
| | org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence |
| | org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy
|
| | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
|
[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface
[
https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178235#comment-16178235
]
Hadoop QA commented on HBASE-18825:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 68 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 8m
55s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 1m
8s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} scalac {color} | {color:green} 2m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
53s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
36m 0s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 96m
1s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m
30s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 9m
6s{color} | {color:green} hbase-backup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
2s{color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m
7s{color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
16s{color} | {color:green} The patch does not generate ASF License
[jira] [Updated] (HBASE-18010) Connect CellChunkMap to be used for flattening in CompactingMemStore
[ https://issues.apache.org/jira/browse/HBASE-18010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anastasia Braginsky updated HBASE-18010: Attachment: HBASE-18010-branch-2.patch > Connect CellChunkMap to be used for flattening in CompactingMemStore > > > Key: HBASE-18010 > URL: https://issues.apache.org/jira/browse/HBASE-18010 > Project: HBase > Issue Type: Sub-task >Reporter: Anastasia Braginsky >Assignee: Anastasia Braginsky > Fix For: 2.0.0, 3.0.0 > > Attachments: HBASE-18010-branch-2.patch, HBASE-18010-V04.patch, > HBASE-18010-V06.patch, HBASE-18010-V07.patch, HBASE-18010-V08.patch, > HBASE-18010-V09.patch, HBASE-18010-V10.patch, HBASE-18010-V11.patch > > > The CellChunkMap helps to create a new type of ImmutableSegment, where the > index (CellSet's delegatee) is going to be CellChunkMap. No big cells or > upserted cells are going to be supported here. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18010) Connect CellChunkMap to be used for flattening in CompactingMemStore
[ https://issues.apache.org/jira/browse/HBASE-18010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anastasia Braginsky updated HBASE-18010: Attachment: (was: HBASE-18010-branch-2.patch) > Connect CellChunkMap to be used for flattening in CompactingMemStore > > > Key: HBASE-18010 > URL: https://issues.apache.org/jira/browse/HBASE-18010 > Project: HBase > Issue Type: Sub-task >Reporter: Anastasia Braginsky >Assignee: Anastasia Braginsky > Fix For: 2.0.0, 3.0.0 > > Attachments: HBASE-18010-branch-2.patch, HBASE-18010-V04.patch, > HBASE-18010-V06.patch, HBASE-18010-V07.patch, HBASE-18010-V08.patch, > HBASE-18010-V09.patch, HBASE-18010-V10.patch, HBASE-18010-V11.patch > > > The CellChunkMap helps to create a new type of ImmutableSegment, where the > index (CellSet's delegatee) is going to be CellChunkMap. No big cells or > upserted cells are going to be supported here. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-18825: -- Release Note: Cleanup the StoreFile interface. The metadata keys are moved to HStoreFile. These methods are removed: CacheConfig getCacheConf(); byte[] getMetadataValue(byte[] key); boolean isCompactedAway(); boolean isReferencedInReads(); void initReader() throws IOException; StoreFileScanner getPreadScanner(boolean cacheBlocks, long readPt, long scannerOrder, boolean canOptimizeForNonNullColumn); StoreFileScanner getStreamScanner(boolean canUseDropBehind, boolean cacheBlocks, boolean isCompaction, long readPt, long scannerOrder, boolean canOptimizeForNonNullColumn) throws IOException; StoreFileReader getReader(); void closeReader(boolean evictOnClose) throws IOException; void markCompactedAway(); void deleteReader() throws IOException; Notice that these methods are still available in HStoreFile. And the return value of getFirstKey and getLastKey are changed from Cell to Optional to better indicate that they may not be available. was: Cleanup the StoreFile interface. The metadata keys are moved to HStoreFile. These methods are removed: CacheConfig getCacheConf(); byte[] getMetadataValue(byte[] key); boolean isCompactedAway(); boolean isReferencedInReads(); void initReader() throws IOException; StoreFileScanner getPreadScanner(boolean cacheBlocks, long readPt, long scannerOrder, boolean canOptimizeForNonNullColumn); StoreFileScanner getStreamScanner(boolean canUseDropBehind, boolean cacheBlocks, boolean isCompaction, long readPt, long scannerOrder, boolean canOptimizeForNonNullColumn) throws IOException; StoreFileReader getReader(); void closeReader(boolean evictOnClose) throws IOException; void markCompactedAway(); void deleteReader() throws IOException; Notice that they are still available in HStoreFile. And the return value of getFirstKey and getLastKey are changed from Cell to Optional to better indicate that they may not be available. > Use HStoreFile instead of StoreFile in our own code base and remove > unnecessary methods in StoreFile interface > -- > > Key: HBASE-18825 > URL: https://issues.apache.org/jira/browse/HBASE-18825 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Affects Versions: 3.0.0, 2.0.0-alpha-3 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-4 > > Attachments: HBASE-18825.patch, HBASE-18825-v1.patch, > HBASE-18825-v2.patch, HBASE-18825-v3.patch, HBASE-18825-v3.patch, > HBASE-18825-v4.patch, HBASE-18825-v5.patch, HBASE-18825-v6.patch > > > Use generic types to avoid too many casts. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-18825: -- Release Note: Cleanup the StoreFile interface. The metadata keys are moved to HStoreFile. These methods are removed: CacheConfig getCacheConf(); byte[] getMetadataValue(byte[] key); boolean isCompactedAway(); boolean isReferencedInReads(); void initReader() throws IOException; StoreFileScanner getPreadScanner(boolean cacheBlocks, long readPt, long scannerOrder, boolean canOptimizeForNonNullColumn); StoreFileScanner getStreamScanner(boolean canUseDropBehind, boolean cacheBlocks, boolean isCompaction, long readPt, long scannerOrder, boolean canOptimizeForNonNullColumn) throws IOException; StoreFileReader getReader(); void closeReader(boolean evictOnClose) throws IOException; void markCompactedAway(); void deleteReader() throws IOException; Notice that they are still available in HStoreFile. And the return value of getFirstKey and getLastKey are changed from Cell to Optional to better indicate that they may not be available. > Use HStoreFile instead of StoreFile in our own code base and remove > unnecessary methods in StoreFile interface > -- > > Key: HBASE-18825 > URL: https://issues.apache.org/jira/browse/HBASE-18825 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Affects Versions: 3.0.0, 2.0.0-alpha-3 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-4 > > Attachments: HBASE-18825.patch, HBASE-18825-v1.patch, > HBASE-18825-v2.patch, HBASE-18825-v3.patch, HBASE-18825-v3.patch, > HBASE-18825-v4.patch, HBASE-18825-v5.patch, HBASE-18825-v6.patch > > > Use generic types to avoid too many casts. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16290) Dump summary of callQueue content; can help debugging
[
https://issues.apache.org/jira/browse/HBASE-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178179#comment-16178179
]
Chia-Ping Tsai commented on HBASE-16290:
You need to rebase the patch.
{code}
+
+public class CallQueueInfo {
{code}
add IA.Private
{code}
+Map> callQueueMethodCountsSummary;
+Map> callQueueMethodSizeSummary;
+
+public CallQueueInfo() {
+callQueueMethodCountsSummary = new HashMap<>();
+callQueueMethodSizeSummary = new HashMap<>();
+}
{code}
Make the fields final.
{code}
-import java.util.ArrayList;
-import java.util.Comparator;
-import java.util.List;
-import java.util.Locale;
+import java.util.*;
{code}
We don't use the glob pattern.
BTW, The tab size is 2 space.
> Dump summary of callQueue content; can help debugging
> -
>
> Key: HBASE-16290
> URL: https://issues.apache.org/jira/browse/HBASE-16290
> Project: HBase
> Issue Type: Bug
> Components: Operability
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Sreeram Venkatasubramanian
> Labels: beginner
> Fix For: 2.0.0
>
> Attachments: 0001-Changes-for-HBASE-16290.patch,
> 0001-Dump-call-queue-summaries.patch.old, DebugDump_screenshot.png, Sample
> Summary.txt
>
>
> Being able to get a clue what is in a backedup callQueue could give insight
> on what is going on on a jacked server. Just needs to summarize count, sizes,
> call types. Useful debugging. In a servlet?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17249) Get/Scan's setTimeRange/setColumnFamilyTimeRange can take the TimeRange reference as the parameter instead of creating a new setColumnFamilyTimeRange instance
[
https://issues.apache.org/jira/browse/HBASE-17249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178175#comment-16178175
]
Chia-Ping Tsai commented on HBASE-17249:
It was reverted and therefore the {{Resolution}} should not be marked as
{{Fixed}}. [~huaxiang] WDYT?
> Get/Scan's setTimeRange/setColumnFamilyTimeRange can take the TimeRange
> reference as the parameter instead of creating a new setColumnFamilyTimeRange
> instance
> --
>
> Key: HBASE-17249
> URL: https://issues.apache.org/jira/browse/HBASE-17249
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.0.0
>Reporter: huaxiang sun
>Assignee: huaxiang sun
> Fix For: 2.0.0
>
> Attachments: HBASE-17249-master-001.patch,
> HBASE-17249.master.001.patch, HBASE-17249-master-002.patch,
> HBASE-17249-master-003.patch
>
>
> Going through the code, found For Get/Scan's
> setTimeRange/setColumnFamilyTimeRange, it can use TimeRange as reference
> instead of creating a new one.
> Reference:
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L500
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L506
> We can implement this in a similar way as filter:
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L510
> I checked it is same with branch-1.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18183) Region interface cleanup for CP expose
[ https://issues.apache.org/jira/browse/HBASE-18183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178174#comment-16178174 ] Anoop Sam John commented on HBASE-18183: The issue is to make sure that what we expose for the CPs should contain only the needed APIs. Now that can be fixed by making our internal code to make use of HRegion and interface just for CP expose.. Let me see.. Not sure how the tests are making use of the interface wrt mocking and all if any. Seems may not be as we used to work with HRegion directly than any interface. Much later (at 0.98 time) only we introduced the Region interface. I will be back here after committing the 1st sub task. bq.Can we deprecate RowProcessor as well? If CP hooks are called, do we need separate RowProcessor hooks called by processRowsWithLocks(). Seeing the usage and how we exposed this. This was done for the users to implement their own CP services to do row atomic processing. Let me see the history of that. > Region interface cleanup for CP expose > -- > > Key: HBASE-18183 > URL: https://issues.apache.org/jira/browse/HBASE-18183 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 2.0.0-alpha-4 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18183) Region interface cleanup for CP expose
[ https://issues.apache.org/jira/browse/HBASE-18183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178173#comment-16178173 ] Chia-Ping Tsai commented on HBASE-18183: The general consensus in HBASE-18825 is that Region is subset for CPs and is not for use internal. Should we iron that out here? Or file another issue to address the cleanup of inner use of Region? [~anoop.hbase] WDYT? > Region interface cleanup for CP expose > -- > > Key: HBASE-18183 > URL: https://issues.apache.org/jira/browse/HBASE-18183 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 2.0.0-alpha-4 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18807) Remove PB references from Observers for Quotas
[ https://issues.apache.org/jira/browse/HBASE-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178171#comment-16178171 ] Anoop Sam John commented on HBASE-18807: Sorry for being late here. GlobalQuotaSettings , I can see states like QuotaProtos.Throttle and getters for that. So we expect CP users to make use of these PB objects via the getters and do some thing? This also should NOT be ideally happening.. PB is our internal stuff and we should not expose that to the users. If we are not doing that, we can change our PB stuff (Like the shading what we did recently) with out much worry. > Remove PB references from Observers for Quotas > -- > > Key: HBASE-18807 > URL: https://issues.apache.org/jira/browse/HBASE-18807 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 3.0.0, 2.0.0-alpha-4 > > Attachments: HBASE-18807.001.branch-2.patch, > HBASE-18807.002.branch-2.patch, HBASE-18807.003.branch-2.patch, > HBASE-18807.004.branch-2.patch > > > Break-out from the parent: > Same idea, just applied to the Observer methods for pre/post quota > operations. Requires changes to MasterQuotaManager and the QuotaSettings > implementations as some business logic is written on the PB objects directly. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-18825: -- Attachment: HBASE-18825-v6.patch Fix compile error. > Use HStoreFile instead of StoreFile in our own code base and remove > unnecessary methods in StoreFile interface > -- > > Key: HBASE-18825 > URL: https://issues.apache.org/jira/browse/HBASE-18825 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Affects Versions: 3.0.0, 2.0.0-alpha-3 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-4 > > Attachments: HBASE-18825.patch, HBASE-18825-v1.patch, > HBASE-18825-v2.patch, HBASE-18825-v3.patch, HBASE-18825-v3.patch, > HBASE-18825-v4.patch, HBASE-18825-v5.patch, HBASE-18825-v6.patch > > > Use generic types to avoid too many casts. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface
[
https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178149#comment-16178149
]
Hadoop QA commented on HBASE-18825:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 68 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 7m
47s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
54s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m
23s{color} | {color:red} The patch causes 23 errors with Hadoop v2.6.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 8m
53s{color} | {color:red} The patch causes 23 errors with Hadoop v2.6.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 11m
19s{color} | {color:red} The patch causes 23 errors with Hadoop v2.6.3. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 13m
47s{color} | {color:red} The patch causes 23 errors with Hadoop v2.6.4. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 16m
18s{color} | {color:red} The patch causes 23 errors with Hadoop v2.6.5. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 18m
45s{color} | {color:red} The patch causes 23 errors with Hadoop v2.7.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 21m
15s{color} | {color:red} The patch causes 23 errors with Hadoop v2.7.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 23m
42s{color} | {color:red} The patch causes 23 errors with Hadoop v2.7.3. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 26m
11s{color} | {color:red} The patch causes 23 errors with Hadoop v3.0.0-alpha4.
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 90m
[jira] [Commented] (HBASE-18807) Remove PB references from Observers for Quotas
[ https://issues.apache.org/jira/browse/HBASE-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178130#comment-16178130 ] Hudson commented on HBASE-18807: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #3769 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3769/]) HBASE-18807 Remove protobuf references from CP quota API calls (elserj: rev 15404831355f2217669c6d66ff46bdb3229a9643) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/ThrottleSettings.java * (add) hbase-client/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaGlobalsSettingsBypass.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestWithDisabledAuthorization.java * (add) hbase-client/src/test/java/org/apache/hadoop/hbase/quotas/TestThrottleSettings.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaThrottle.java * (add) hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/GlobalQuotaSettings.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestGlobalQuotaSettings.java * (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceLimitSettings.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterQuotaManager.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaSettingsFactory.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaSettings.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaAdmin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaTableUtil.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/SpaceLimitSettings.java > Remove PB references from Observers for Quotas > -- > > Key: HBASE-18807 > URL: https://issues.apache.org/jira/browse/HBASE-18807 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 3.0.0, 2.0.0-alpha-4 > > Attachments: HBASE-18807.001.branch-2.patch, > HBASE-18807.002.branch-2.patch, HBASE-18807.003.branch-2.patch, > HBASE-18807.004.branch-2.patch > > > Break-out from the parent: > Same idea, just applied to the Observer methods for pre/post quota > operations. Requires changes to MasterQuotaManager and the QuotaSettings > implementations as some business logic is written on the PB objects directly. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-18825: -- Affects Version/s: 3.0.0 2.0.0-alpha-3 Hadoop Flags: Incompatible change,Reviewed Fix Version/s: 3.0.0 > Use HStoreFile instead of StoreFile in our own code base and remove > unnecessary methods in StoreFile interface > -- > > Key: HBASE-18825 > URL: https://issues.apache.org/jira/browse/HBASE-18825 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Affects Versions: 3.0.0, 2.0.0-alpha-3 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-4 > > Attachments: HBASE-18825.patch, HBASE-18825-v1.patch, > HBASE-18825-v2.patch, HBASE-18825-v3.patch, HBASE-18825-v3.patch, > HBASE-18825-v4.patch, HBASE-18825-v5.patch > > > Use generic types to avoid too many casts. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18807) Remove PB references from Observers for Quotas
[ https://issues.apache.org/jira/browse/HBASE-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178118#comment-16178118 ] Hudson commented on HBASE-18807: FAILURE: Integrated in Jenkins build HBase-2.0 #568 (See [https://builds.apache.org/job/HBase-2.0/568/]) HBASE-18807 Remove protobuf references from CP quota API calls (elserj: rev 40a73c9be512ed6cc750937f20edab9c91efe740) * (add) hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/GlobalQuotaSettings.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaSettingsFactory.java * (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceLimitSettings.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaSettings.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaThrottle.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestWithDisabledAuthorization.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/SpaceLimitSettings.java * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestGlobalQuotaSettings.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/ThrottleSettings.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaAdmin.java * (add) hbase-client/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaGlobalsSettingsBypass.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaTableUtil.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterQuotaManager.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java * (add) hbase-client/src/test/java/org/apache/hadoop/hbase/quotas/TestThrottleSettings.java > Remove PB references from Observers for Quotas > -- > > Key: HBASE-18807 > URL: https://issues.apache.org/jira/browse/HBASE-18807 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 3.0.0, 2.0.0-alpha-4 > > Attachments: HBASE-18807.001.branch-2.patch, > HBASE-18807.002.branch-2.patch, HBASE-18807.003.branch-2.patch, > HBASE-18807.004.branch-2.patch > > > Break-out from the parent: > Same idea, just applied to the Observer methods for pre/post quota > operations. Requires changes to MasterQuotaManager and the QuotaSettings > implementations as some business logic is written on the PB objects directly. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface
[ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-18825: -- Attachment: HBASE-18825-v5.patch More cleanups. Add comment to StoreFile interface to tell developers that you should not use this interface if you are implementation something inside HBase, use HStoreFile directly. > Use HStoreFile instead of StoreFile in our own code base and remove > unnecessary methods in StoreFile interface > -- > > Key: HBASE-18825 > URL: https://issues.apache.org/jira/browse/HBASE-18825 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18825.patch, HBASE-18825-v1.patch, > HBASE-18825-v2.patch, HBASE-18825-v3.patch, HBASE-18825-v3.patch, > HBASE-18825-v4.patch, HBASE-18825-v5.patch > > > Use generic types to avoid too many casts. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
