[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199835#comment-16199835
 ] 

Hadoop QA commented on HBASE-18411:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
11s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
46s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
39s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
55s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
52s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
37s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
27s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m  
8s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
49s{color} | {color:green} HBASE-18410 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
55s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
36m 23s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
37s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 90m 
49s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
28s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}156m 22s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18411 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12891413/HBASE-18411-HBASE-18410.v3.patch
 |
| Optional Tests |  asflicense  shadedjars  javac  javadoc  unit  findbugs  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 9b75b5c9407e 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | HBASE-18410 / 

[jira] [Commented] (HBASE-18183) Region interface cleanup for CP expose

[Anoop Sam John (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199834#comment-16199834
 ] 

Anoop Sam John commented on HBASE-18183:


Fixed comments from Stack. On the CPRSS, lets discuss after this is in and the 
MS related sub task.

> Region interface cleanup for CP expose
> --
>
> Key: HBASE-18183
> URL: https://issues.apache.org/jira/browse/HBASE-18183
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18183.patch, HBASE-18183_V2.patch, 
> HBASE-18183_V3.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18183) Region interface cleanup for CP expose

[Anoop Sam John (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anoop Sam John updated HBASE-18183:
---
Hadoop Flags: Incompatible change,Reviewed
  Status: Patch Available  (was: Open)

> Region interface cleanup for CP expose
> --
>
> Key: HBASE-18183
> URL: https://issues.apache.org/jira/browse/HBASE-18183
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18183.patch, HBASE-18183_V2.patch, 
> HBASE-18183_V3.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18183) Region interface cleanup for CP expose

[Anoop Sam John (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anoop Sam John updated HBASE-18183:
---
Attachment: HBASE-18183_V3.patch

> Region interface cleanup for CP expose
> --
>
> Key: HBASE-18183
> URL: https://issues.apache.org/jira/browse/HBASE-18183
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18183.patch, HBASE-18183_V2.patch, 
> HBASE-18183_V3.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-16417) In-Memory MemStore Policy for Flattening and Compactions

[ramkrishna.s.vasudevan (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-16417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199817#comment-16199817
 ] 

ramkrishna.s.vasudevan commented on HBASE-16417:


bq.However, global pressure triggered many flushes, and there as you know it 
does check heap size and not data size
Ya I meant this but said as blocking updates.
bq.ith fast SSD hardware this has higher affect on throughput as memory 
management is more of a bottleneck.
There are two aspects here -  one is how much index is getting reduced and so 
the region size changes and so the frequencey of flushes and how is the 
hardware helping in the flushes to be faster or slower. 


> In-Memory MemStore Policy for Flattening and Compactions
> 
>
> Key: HBASE-16417
> URL: https://issues.apache.org/jira/browse/HBASE-16417
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Anastasia Braginsky
>Assignee: Eshcar Hillel
> Fix For: 3.0.0
>
> Attachments: HBASE-16417 - Adaptive Compaction Policy - 20171001.pdf, 
> HBASE-16417 - parameter tuning - 20171001.pdf, HBASE-16417-V01.patch, 
> HBASE-16417-benchmarkresults-20161101.pdf, 
> HBASE-16417-benchmarkresults-20161110.pdf, 
> HBASE-16417-benchmarkresults-20161123.pdf, 
> HBASE-16417-benchmarkresults-20161205.pdf, 
> HBASE-16417-benchmarkresults-20170309.pdf, 
> HBASE-16417-benchmarkresults-20170317.pdf, HBASE-16417.01.patch, 
> HBASE-16417.02.patch, HBASE-16417.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18945) Make a Public interface for CellComparator

[ramkrishna.s.vasudevan (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199815#comment-16199815
 ] 

ramkrishna.s.vasudevan commented on HBASE-18945:


Ping [~saint@gmail.com] and [~chia7712].

> Make a Public interface for CellComparator
> --
>
> Key: HBASE-18945
> URL: https://issues.apache.org/jira/browse/HBASE-18945
> Project: HBase
>  Issue Type: Sub-task
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18495.patch, HBASE-18945_2.patch
>
>
> Based on discussions over in HBASE-18826 and HBASE-18183 it is better we 
> expose CellComparator as a public interface so that it could be used in 
> Region/Store interfaces to be exposed to CPs.
> Currently the Comparator is exposed in Region, STore and StoreFile. There is 
> another discussion whether to expose it at all layers or only at Region. 
> However since we are exposing this to CPs CellComparator being @Private is 
> not the ideal way to do it. We have to change it to LimitedPrivate. But 
> CellComparator has lot of additional methods which are internal (like where a 
> Cell is compared with an incoming byte[] used in index comparsions etc).
> One way to expose is that as being done now in HBASE-18826 - by exposing the 
> return type as Comparator. But this is not powerful. It only allows to 
> compare cells. So we try to expose an IA.LimitedPrivate interface that is 
> more powerful and allows comparing individual cell components also. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18900) Backport HBASE-17290 "Potential loss of data for replication of bulk loaded hfiles" to 1.3

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199761#comment-16199761
 ] 

Hudson commented on HBASE-18900:


FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #316 (See 
[https://builds.apache.org/job/HBase-1.3-JDK8/316/])
HBASE-18900 Backport HBASE-17290 - revert due to incompatibility (tedyu: rev 
ccf9b85d040e9028bcab0d49321be104d67fc76e)
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueues.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesZKImpl.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceInterface.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java
* (delete) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationObserver.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStateBasic.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestReplicationHFileCleaner.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HFileReplicator.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java


> Backport HBASE-17290 "Potential loss of data for replication of bulk loaded 
> hfiles" to 1.3
> --
>
> Key: HBASE-18900
> URL: https://issues.apache.org/jira/browse/HBASE-18900
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 1.3.2
>
> Attachments: 17290-branch-1.3.patch, 18900.branch-1.3.patch
>
>
> HBASE-17290 fixes data loss bug.
> Bulk loaded hfile replication support is in branch-1.3
> This issue is to backport HBASE-17290 to branch-1.3



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-17290) Potential loss of data for replication of bulk loaded hfiles

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-17290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199762#comment-16199762
 ] 

Hudson commented on HBASE-17290:


FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #316 (See 
[https://builds.apache.org/job/HBase-1.3-JDK8/316/])
HBASE-18900 Backport HBASE-17290 - revert due to incompatibility (tedyu: rev 
ccf9b85d040e9028bcab0d49321be104d67fc76e)
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueues.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestReplicationHFileCleaner.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceInterface.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HFileReplicator.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesZKImpl.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStateBasic.java
* (delete) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationObserver.java


> Potential loss of data for replication of bulk loaded hfiles
> 
>
> Key: HBASE-17290
> URL: https://issues.apache.org/jira/browse/HBASE-17290
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.3.0
>Reporter: Ted Yu
>Assignee: Ashish Singhi
>  Labels: replication
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-17290.branch-1.patch, HBASE-17290.patch, 
> HBASE-17290.v1.patch
>
>
> Currently the support for replication of bulk loaded hfiles relies on bulk 
> load marker written in the WAL.
> The move of bulk loaded hfile(s) (into region directory) may succeed but the 
> write of bulk load marker may fail.
> This means that although bulk loaded hfile is being served in source cluster, 
> the replication wouldn't happen.
> Normally operator is supposed to retry the bulk load. But relying on human 
> retry is not robust solution.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND

[Zheng Hu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zheng Hu updated HBASE-18411:
-
Attachment: HBASE-18411-HBASE-18410.v3.patch

Hadoop QA again.

> Dividing FiterList  into two separate sub-classes:  FilterListWithOR , 
> FilterListWithAND
> 
>
> Key: HBASE-18411
> URL: https://issues.apache.org/jira/browse/HBASE-18411
> Project: HBase
>  Issue Type: Sub-task
>  Components: Filters
>Reporter: Zheng Hu
>Assignee: Zheng Hu
> Attachments: HBASE-18411-HBASE-18410.v3.patch, 
> HBASE-18411-HBASE-18410.v3.patch, HBASE-18411.v1.patch, HBASE-18411.v1.patch, 
> HBASE-18411.v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND

[Zheng Hu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199737#comment-16199737
 ] 

Zheng Hu commented on HBASE-18411:
--

bq. So this will go into HBASE-18410 first? 
Yes,  I think so.   See comments under HBASE-18410.

> Dividing FiterList  into two separate sub-classes:  FilterListWithOR , 
> FilterListWithAND
> 
>
> Key: HBASE-18411
> URL: https://issues.apache.org/jira/browse/HBASE-18411
> Project: HBase
>  Issue Type: Sub-task
>  Components: Filters
>Reporter: Zheng Hu
>Assignee: Zheng Hu
> Attachments: HBASE-18411-HBASE-18410.v3.patch, HBASE-18411.v1.patch, 
> HBASE-18411.v1.patch, HBASE-18411.v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18410) FilterList Improvement.

[Zheng Hu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199726#comment-16199726
 ] 

Zheng Hu commented on HBASE-18410:
--

bq. I'm more concerned about us getting to a point where we can get this branch 
merged in time for 2.0.0-beta-1 rather than e.g. in time for 1.4.0.
OK ,  So let's finish this issues in master branch first (Commit in HBASE-18410 
branch first, then merging HBASE-18410 with master).   After 2.0.0-beta-1 works 
fine, I can backport them to branch-1.x . 

> FilterList  Improvement. 
> -
>
> Key: HBASE-18410
> URL: https://issues.apache.org/jira/browse/HBASE-18410
> Project: HBase
>  Issue Type: Umbrella
>  Components: Filters
>Reporter: Zheng Hu
>Assignee: Zheng Hu
> Fix For: 2.0.0-beta-1
>
>
> FilterList.java is complex now, and we have found some improvements for it.  
> So create an issue to address it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18960) A few bug fixes and minor improvements around batchMutate()

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199711#comment-16199711
 ] 

Hadoop QA commented on HBASE-18960:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
10s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
58s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
58s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
33m 19s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 91m 
49s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
20s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}143m 15s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18960 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12891389/hbase-18960.master.006.patch
 |
| Optional Tests |  asflicense  shadedjars  javac  javadoc  unit  findbugs  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux e203b3e18e45 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 
12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 690ff38 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9034/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9034/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |

[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND

[Duo Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199703#comment-16199703
 ] 

Duo Zhang commented on HBASE-18411:
---

So this will go into HBASE-18410 first? [~psomogyi] [~busbey]

> Dividing FiterList  into two separate sub-classes:  FilterListWithOR , 
> FilterListWithAND
> 
>
> Key: HBASE-18411
> URL: https://issues.apache.org/jira/browse/HBASE-18411
> Project: HBase
>  Issue Type: Sub-task
>  Components: Filters
>Reporter: Zheng Hu
>Assignee: Zheng Hu
> Attachments: HBASE-18411-HBASE-18410.v3.patch, HBASE-18411.v1.patch, 
> HBASE-18411.v1.patch, HBASE-18411.v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18552) Backport the server side change in HBASE-18489 to branch-1

[Duo Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199685#comment-16199685
 ] 

Duo Zhang commented on HBASE-18552:
---

[~apurtell] These methods are only in branch-1 and branch-1.4, which are not 
released yet so I think it is OK to do it in a clean way?

> Backport the server side change in HBASE-18489 to branch-1
> --
>
> Key: HBASE-18552
> URL: https://issues.apache.org/jira/browse/HBASE-18552
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 1.4.0, 1.5.0
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 1.4.0, 1.5.0
>
> Attachments: HBASE-18552-branch-1-v1.patch, 
> HBASE-18552-branch-1.patch, HBASE-18552-branch-1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18770) We should not allow RegionObserver.preBulkLoadHFile to bypass the default behavior

[Duo Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199680#comment-16199680
 ] 

Duo Zhang commented on HBASE-18770:
---

Thanks [~apurtell] for taking this.

> We should not allow RegionObserver.preBulkLoadHFile to bypass the default 
> behavior
> --
>
> Key: HBASE-18770
> URL: https://issues.apache.org/jira/browse/HBASE-18770
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
>
> As now we do not allow users to create a StoreFile instance. Users can still 
> select the files to be bulk loaded by modifying the familyPaths passed in.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18355) Enable export snapshot tests that were disabled by Proc-V2 AM in HBASE-14614

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199673#comment-16199673
 ] 

Hadoop QA commented on HBASE-18355:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
11s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 4 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
34s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m  
8s{color} | {color:red} hbase-mapreduce in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m  
6s{color} | {color:red} hbase-mapreduce in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m  6s{color} 
| {color:red} hbase-mapreduce in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} mvneclipse {color} | {color:red}  0m 
10s{color} | {color:red} hbase-mapreduce in the patch failed. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red}  3m 
10s{color} | {color:red} patch has 10 errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  4m 
56s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.1. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  6m 
34s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.2. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  8m  
8s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  9m 
42s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.4. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 11m 
17s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.5. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 12m 
49s{color} | {color:red} The patch causes 10 errors with Hadoop v2.7.1. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 14m 
36s{color} | {color:red} The patch causes 10 errors with Hadoop v2.7.2. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 16m 
21s{color} | {color:red} The patch causes 10 errors with Hadoop v2.7.3. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 18m  
0s{color} | {color:red} The patch causes 10 errors with Hadoop v3.0.0-alpha4. 
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m  
7s{color} | {color:red} hbase-mapreduce in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m  
8s{color} | {color:red} hbase-mapreduce in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m  7s{color} 
| {color:red} hbase-mapreduce in the patch failed. {color} |
| 

[jira] [Commented] (HBASE-18923) TestTableResource flaky on branch-1

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199672#comment-16199672
 ] 

Hudson commented on HBASE-18923:


SUCCESS: Integrated in Jenkins build HBase-1.3-IT #232 (See 
[https://builds.apache.org/job/HBase-1.3-IT/232/])
HBASE-18923 TestTableResource flaky on branch-1 (apurtell: rev 
48d1a699034449ff21810c82dce2c6b685d5dc5c)
* (edit) 
hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java


> TestTableResource flaky on branch-1
> ---
>
> Key: HBASE-18923
> URL: https://issues.apache.org/jira/browse/HBASE-18923
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.0, 1.3.1, 1.5.0
>Reporter: Andrew Purtell
>Assignee: Pankaj Kumar
> Fix For: 1.4.0, 1.3.2, 1.5.0
>
> Attachments: HBASE-18923-branch-1-V2.patch, HBASE-18923-branch-1.patch
>
>
> Occasional NPE
> Flaked tests: 
> org.apache.hadoop.hbase.rest.TestTableResource.testTableInfoPB(org.apache.hadoop.hbase.rest.TestTableResource)
>   Run 1: TestTableResource.testTableInfoPB:271->checkTableInfo:184 NullPointer
>   Run 2: PASS
> org.apache.hadoop.hbase.rest.TestTableResource.testTableInfoXML(org.apache.hadoop.hbase.rest.TestTableResource)
>   Run 1: TestTableResource.testTableInfoXML:254->checkTableInfo:184 
> NullPointer
>   Run 2: PASS
> Tests run: 213, Failures: 0, Errors: 0, Skipped: 0, Flakes: 2



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18923) TestTableResource flaky on branch-1

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199668#comment-16199668
 ] 

Hudson commented on HBASE-18923:


FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #304 (See 
[https://builds.apache.org/job/HBase-1.3-JDK7/304/])
HBASE-18923 TestTableResource flaky on branch-1 (apurtell: rev 
48d1a699034449ff21810c82dce2c6b685d5dc5c)
* (edit) 
hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java


> TestTableResource flaky on branch-1
> ---
>
> Key: HBASE-18923
> URL: https://issues.apache.org/jira/browse/HBASE-18923
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.0, 1.3.1, 1.5.0
>Reporter: Andrew Purtell
>Assignee: Pankaj Kumar
> Fix For: 1.4.0, 1.3.2, 1.5.0
>
> Attachments: HBASE-18923-branch-1-V2.patch, HBASE-18923-branch-1.patch
>
>
> Occasional NPE
> Flaked tests: 
> org.apache.hadoop.hbase.rest.TestTableResource.testTableInfoPB(org.apache.hadoop.hbase.rest.TestTableResource)
>   Run 1: TestTableResource.testTableInfoPB:271->checkTableInfo:184 NullPointer
>   Run 2: PASS
> org.apache.hadoop.hbase.rest.TestTableResource.testTableInfoXML(org.apache.hadoop.hbase.rest.TestTableResource)
>   Run 1: TestTableResource.testTableInfoXML:254->checkTableInfo:184 
> NullPointer
>   Run 2: PASS
> Tests run: 213, Failures: 0, Errors: 0, Skipped: 0, Flakes: 2



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18923) TestTableResource flaky on branch-1

[Andrew Purtell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-18923:
---
Affects Version/s: 1.3.1
Fix Version/s: 1.3.2

Looks like only branch-1.3 of the branch-1.x has HBASE-18796 that didn't get 
this fix, so I picked this there. If you'd like to provide patches for master 
and branch-2 (are they affected?) then I'll commit them. 

> TestTableResource flaky on branch-1
> ---
>
> Key: HBASE-18923
> URL: https://issues.apache.org/jira/browse/HBASE-18923
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.0, 1.3.1, 1.5.0
>Reporter: Andrew Purtell
>Assignee: Pankaj Kumar
> Fix For: 1.4.0, 1.3.2, 1.5.0
>
> Attachments: HBASE-18923-branch-1-V2.patch, HBASE-18923-branch-1.patch
>
>
> Occasional NPE
> Flaked tests: 
> org.apache.hadoop.hbase.rest.TestTableResource.testTableInfoPB(org.apache.hadoop.hbase.rest.TestTableResource)
>   Run 1: TestTableResource.testTableInfoPB:271->checkTableInfo:184 NullPointer
>   Run 2: PASS
> org.apache.hadoop.hbase.rest.TestTableResource.testTableInfoXML(org.apache.hadoop.hbase.rest.TestTableResource)
>   Run 1: TestTableResource.testTableInfoXML:254->checkTableInfo:184 
> NullPointer
>   Run 2: PASS
> Tests run: 213, Failures: 0, Errors: 0, Skipped: 0, Flakes: 2



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18967) Backport HBASE-17181 to branch-1.3

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199655#comment-16199655
 ] 

Hadoop QA commented on HBASE-18967:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
26s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
34s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
45s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
38s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
45s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
44s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
26s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
43s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
31s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
46s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
25s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 1s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
44s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
27m 45s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3. 
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 18m 23s{color} 
| {color:red} hbase-thrift in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 7s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 70m 21s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | 
org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce 

[jira] [Updated] (HBASE-18355) Enable export snapshot tests that were disabled by Proc-V2 AM in HBASE-14614

[huaxiang sun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

huaxiang sun updated HBASE-18355:
-
Attachment: HBASE-18355-master_v001.patch

v1 patch.

> Enable export snapshot tests that were disabled by Proc-V2 AM in HBASE-14614
> 
>
> Key: HBASE-18355
> URL: https://issues.apache.org/jira/browse/HBASE-18355
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.0.0-alpha-1
>Reporter: Stephen Yuan Jiang
>Assignee: huaxiang sun
> Attachments: HBASE-18355-master_v001.patch
>
>
> The Proc-V2 AM in HBASE-14614 disabled the following tests:
> - Disabled TestExportSnapshot Hangs. 
> - Disabled TestSecureExportSnapshot
> - Disabled TestMobSecureExportSnapshot and TestMobExportSnapshot
> This JIRA tracks the work to enable them.  If MOB requires more work, we 
> could split to 2 tickets.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18355) Enable export snapshot tests that were disabled by Proc-V2 AM in HBASE-14614

[huaxiang sun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

huaxiang sun updated HBASE-18355:
-
Status: Patch Available  (was: Open)

> Enable export snapshot tests that were disabled by Proc-V2 AM in HBASE-14614
> 
>
> Key: HBASE-18355
> URL: https://issues.apache.org/jira/browse/HBASE-18355
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.0.0-alpha-1
>Reporter: Stephen Yuan Jiang
>Assignee: huaxiang sun
> Attachments: HBASE-18355-master_v001.patch
>
>
> The Proc-V2 AM in HBASE-14614 disabled the following tests:
> - Disabled TestExportSnapshot Hangs. 
> - Disabled TestSecureExportSnapshot
> - Disabled TestMobSecureExportSnapshot and TestMobExportSnapshot
> This JIRA tracks the work to enable them.  If MOB requires more work, we 
> could split to 2 tickets.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-17292) Add observer notification before bulk loaded hfile is moved to region directory

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-17292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199635#comment-16199635
 ] 

Hudson commented on HBASE-17292:


SUCCESS: Integrated in Jenkins build HBase-1.3-IT #231 (See 
[https://builds.apache.org/job/HBase-1.3-IT/231/])
HBASE-18910 Backport HBASE-17292 - revert due to incompatibility (tedyu: rev 
eb475f00af711455b4c31d47f06317529db62232)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java


> Add observer notification before bulk loaded hfile is moved to region 
> directory
> ---
>
> Key: HBASE-17292
> URL: https://issues.apache.org/jira/browse/HBASE-17292
> Project: HBase
>  Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.4.0
>
> Attachments: 17292.addendum, 17292.branch-1.v1.txt, 17292.v1.txt, 
> 17292.v2.txt, 17292.v3.txt
>
>
> Currently the postBulkLoadHFile() hook notifies the locations of bulk loaded 
> hfiles.
> However, if bulk load fails after hfile is moved to region directory but 
> before postBulkLoadHFile() hook is called, there is no way for pluggable 
> components (replication - see HBASE-17290, backup / restore) to know which 
> hfile(s) have been moved to region directory.
> Even if postBulkLoadHFile() is called in finally block, the write (to backup 
> table or zookeeper) issued from postBulkLoadHFile() may fail, ending up with 
> same situation.
> This issue adds a preCommitStoreFile() hook which notifies path of to be 
> committed hfile before bulk loaded hfile is moved to region directory.
> With preCommitStoreFile() hook, write (to backup table or zookeeper) can be 
> issued before the movement of hfile.
> If write fails, IOException would make bulk load fail, not leaving hfile in 
> region directory.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18975) B hadoop3 incompatibility

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199633#comment-16199633
 ] 

Hadoop QA commented on HBASE-18975:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
 0s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
56s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
37m  8s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  8m 
29s{color} | {color:green} hbase-backup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 9s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 59m 18s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18975 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12891205/HBASE-18975-v2.patch |
| Optional Tests |  asflicense  shadedjars  javac  javadoc  unit  findbugs  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 850d18f449ba 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 690ff38 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9033/testReport/ |
| modules | C: hbase-backup U: hbase-backup |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9033/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message 

[jira] [Commented] (HBASE-18910) Backport HBASE-17292 "Add observer notification before bulk loaded hfile is moved to region directory" to 1.3

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199634#comment-16199634
 ] 

Hudson commented on HBASE-18910:


SUCCESS: Integrated in Jenkins build HBase-1.3-IT #231 (See 
[https://builds.apache.org/job/HBase-1.3-IT/231/])
HBASE-18910 Backport HBASE-17292 - revert due to incompatibility (tedyu: rev 
eb475f00af711455b4c31d47f06317529db62232)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java


> Backport HBASE-17292 "Add observer notification before bulk loaded hfile is 
> moved to region directory" to 1.3
> -
>
> Key: HBASE-18910
> URL: https://issues.apache.org/jira/browse/HBASE-18910
> Project: HBase
>  Issue Type: Bug
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 1.3.2
>
> Attachments: HBASE-18910.branch-1.3.v1.patch
>
>
> HBASE-18900 will backport HBASE-17290 to branch-1.3.But  HBASE-17290 is 
> dependent on HBASE-17292.so this issue will backport HBASE-17292 to 
> branch-1.3.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (HBASE-18355) Enable export snapshot tests that were disabled by Proc-V2 AM in HBASE-14614

[huaxiang sun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

huaxiang sun reassigned HBASE-18355:


Assignee: huaxiang sun  (was: Vladimir Rodionov)

> Enable export snapshot tests that were disabled by Proc-V2 AM in HBASE-14614
> 
>
> Key: HBASE-18355
> URL: https://issues.apache.org/jira/browse/HBASE-18355
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.0.0-alpha-1
>Reporter: Stephen Yuan Jiang
>Assignee: huaxiang sun
>
> The Proc-V2 AM in HBASE-14614 disabled the following tests:
> - Disabled TestExportSnapshot Hangs. 
> - Disabled TestSecureExportSnapshot
> - Disabled TestMobSecureExportSnapshot and TestMobExportSnapshot
> This JIRA tracks the work to enable them.  If MOB requires more work, we 
> could split to 2 tickets.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18693) adding an option to restore_snapshot to move mob files from archive dir to working dir

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199628#comment-16199628
 ] 

Hadoop QA commented on HBASE-18693:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
13s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
37s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
10s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  6m  
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
19s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green}  2m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  1m 
 0s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red}  0m  
9s{color} | {color:red} The patch generated 3 new + 334 unchanged - 1 fixed = 
337 total (was 335) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red}  0m  
5s{color} | {color:red} The patch generated 1 new + 743 unchanged - 0 fixed = 
744 total (was 743) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
46s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
60m 34s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}  
2m 43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 11m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
57s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  4m 
15s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}124m 16s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  7m 43s{color} 
| {color:red} hbase-shell in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  1m 

[jira] [Commented] (HBASE-17290) Potential loss of data for replication of bulk loaded hfiles

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-17290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199624#comment-16199624
 ] 

Hudson commented on HBASE-17290:


FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #302 (See 
[https://builds.apache.org/job/HBase-1.3-JDK7/302/])
HBASE-18900 Backport HBASE-17290 - revert due to incompatibility (tedyu: rev 
ccf9b85d040e9028bcab0d49321be104d67fc76e)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceInterface.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestReplicationHFileCleaner.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueues.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HFileReplicator.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStateBasic.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* (delete) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationObserver.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesZKImpl.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java


> Potential loss of data for replication of bulk loaded hfiles
> 
>
> Key: HBASE-17290
> URL: https://issues.apache.org/jira/browse/HBASE-17290
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.3.0
>Reporter: Ted Yu
>Assignee: Ashish Singhi
>  Labels: replication
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-17290.branch-1.patch, HBASE-17290.patch, 
> HBASE-17290.v1.patch
>
>
> Currently the support for replication of bulk loaded hfiles relies on bulk 
> load marker written in the WAL.
> The move of bulk loaded hfile(s) (into region directory) may succeed but the 
> write of bulk load marker may fail.
> This means that although bulk loaded hfile is being served in source cluster, 
> the replication wouldn't happen.
> Normally operator is supposed to retry the bulk load. But relying on human 
> retry is not robust solution.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18981) Address issues found by error-prone in hbase-client

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199627#comment-16199627
 ] 

Hudson commented on HBASE-18981:


SUCCESS: Integrated in Jenkins build HBase-2.0 #663 (See 
[https://builds.apache.org/job/HBase-2.0/663/])
HBASE-18981 Address issues found by error-prone in hbase-client (mdrob: rev 
2e368cf46159a7ea0dfaac7784f625c9421aebb6)
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java


> Address issues found by error-prone in hbase-client
> ---
>
> Key: HBASE-18981
> URL: https://issues.apache.org/jira/browse/HBASE-18981
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Trivial
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18981.patch
>
>
> I thought this was something that we would already catch in findbugs, but 
> maybe not?
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile 
> (default-compile) on project hbase-client: Compilation failure
> [ERROR] 
> /Users/mdrob/IdeaProjects/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:[2476,5]
>  [MissingCasesInEnumSwitch] Non-exhaustive switch; either add a default or 
> handle the remaining cases: GLOBAL_BYPASS
> [ERROR] (see http://errorprone.info/bugpattern/MissingCasesInEnumSwitch)
> {noformat}
> cc: [~elserj], this looks like it is part of quota code. I'm happy to add a 
> trivial patch to error on the missing case, but want somebody with more 
> contextual knowledge to look at it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18900) Backport HBASE-17290 "Potential loss of data for replication of bulk loaded hfiles" to 1.3

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199623#comment-16199623
 ] 

Hudson commented on HBASE-18900:


FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #302 (See 
[https://builds.apache.org/job/HBase-1.3-JDK7/302/])
HBASE-18900 Backport HBASE-17290 - revert due to incompatibility (tedyu: rev 
ccf9b85d040e9028bcab0d49321be104d67fc76e)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceInterface.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestReplicationHFileCleaner.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueues.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HFileReplicator.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStateBasic.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* (delete) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationObserver.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesZKImpl.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java


> Backport HBASE-17290 "Potential loss of data for replication of bulk loaded 
> hfiles" to 1.3
> --
>
> Key: HBASE-18900
> URL: https://issues.apache.org/jira/browse/HBASE-18900
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 1.3.2
>
> Attachments: 17290-branch-1.3.patch, 18900.branch-1.3.patch
>
>
> HBASE-17290 fixes data loss bug.
> Bulk loaded hfile replication support is in branch-1.3
> This issue is to backport HBASE-17290 to branch-1.3



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-17292) Add observer notification before bulk loaded hfile is moved to region directory

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-17292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199626#comment-16199626
 ] 

Hudson commented on HBASE-17292:


FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #302 (See 
[https://builds.apache.org/job/HBase-1.3-JDK7/302/])
HBASE-18910 Backport HBASE-17292 - revert due to incompatibility (tedyu: rev 
eb475f00af711455b4c31d47f06317529db62232)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java


> Add observer notification before bulk loaded hfile is moved to region 
> directory
> ---
>
> Key: HBASE-17292
> URL: https://issues.apache.org/jira/browse/HBASE-17292
> Project: HBase
>  Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.4.0
>
> Attachments: 17292.addendum, 17292.branch-1.v1.txt, 17292.v1.txt, 
> 17292.v2.txt, 17292.v3.txt
>
>
> Currently the postBulkLoadHFile() hook notifies the locations of bulk loaded 
> hfiles.
> However, if bulk load fails after hfile is moved to region directory but 
> before postBulkLoadHFile() hook is called, there is no way for pluggable 
> components (replication - see HBASE-17290, backup / restore) to know which 
> hfile(s) have been moved to region directory.
> Even if postBulkLoadHFile() is called in finally block, the write (to backup 
> table or zookeeper) issued from postBulkLoadHFile() may fail, ending up with 
> same situation.
> This issue adds a preCommitStoreFile() hook which notifies path of to be 
> committed hfile before bulk loaded hfile is moved to region directory.
> With preCommitStoreFile() hook, write (to backup table or zookeeper) can be 
> issued before the movement of hfile.
> If write fails, IOException would make bulk load fail, not leaving hfile in 
> region directory.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18910) Backport HBASE-17292 "Add observer notification before bulk loaded hfile is moved to region directory" to 1.3

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199625#comment-16199625
 ] 

Hudson commented on HBASE-18910:


FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #302 (See 
[https://builds.apache.org/job/HBase-1.3-JDK7/302/])
HBASE-18910 Backport HBASE-17292 - revert due to incompatibility (tedyu: rev 
eb475f00af711455b4c31d47f06317529db62232)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java


> Backport HBASE-17292 "Add observer notification before bulk loaded hfile is 
> moved to region directory" to 1.3
> -
>
> Key: HBASE-18910
> URL: https://issues.apache.org/jira/browse/HBASE-18910
> Project: HBase
>  Issue Type: Bug
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 1.3.2
>
> Attachments: HBASE-18910.branch-1.3.v1.patch
>
>
> HBASE-18900 will backport HBASE-17290 to branch-1.3.But  HBASE-17290 is 
> dependent on HBASE-17292.so this issue will backport HBASE-17292 to 
> branch-1.3.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18900) Backport HBASE-17290 "Potential loss of data for replication of bulk loaded hfiles" to 1.3

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199617#comment-16199617
 ] 

Hudson commented on HBASE-18900:


SUCCESS: Integrated in Jenkins build HBase-1.3-IT #230 (See 
[https://builds.apache.org/job/HBase-1.3-IT/230/])
HBASE-18900 Backport HBASE-17290 - revert due to incompatibility (tedyu: rev 
ccf9b85d040e9028bcab0d49321be104d67fc76e)
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesZKImpl.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceInterface.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestReplicationHFileCleaner.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueues.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* (delete) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationObserver.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HFileReplicator.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStateBasic.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java


> Backport HBASE-17290 "Potential loss of data for replication of bulk loaded 
> hfiles" to 1.3
> --
>
> Key: HBASE-18900
> URL: https://issues.apache.org/jira/browse/HBASE-18900
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 1.3.2
>
> Attachments: 17290-branch-1.3.patch, 18900.branch-1.3.patch
>
>
> HBASE-17290 fixes data loss bug.
> Bulk loaded hfile replication support is in branch-1.3
> This issue is to backport HBASE-17290 to branch-1.3



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-17290) Potential loss of data for replication of bulk loaded hfiles

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-17290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199618#comment-16199618
 ] 

Hudson commented on HBASE-17290:


SUCCESS: Integrated in Jenkins build HBase-1.3-IT #230 (See 
[https://builds.apache.org/job/HBase-1.3-IT/230/])
HBASE-18900 Backport HBASE-17290 - revert due to incompatibility (tedyu: rev 
ccf9b85d040e9028bcab0d49321be104d67fc76e)
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesZKImpl.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceInterface.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestReplicationHFileCleaner.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueues.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* (delete) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationObserver.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HFileReplicator.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStateBasic.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java


> Potential loss of data for replication of bulk loaded hfiles
> 
>
> Key: HBASE-17290
> URL: https://issues.apache.org/jira/browse/HBASE-17290
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.3.0
>Reporter: Ted Yu
>Assignee: Ashish Singhi
>  Labels: replication
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-17290.branch-1.patch, HBASE-17290.patch, 
> HBASE-17290.v1.patch
>
>
> Currently the support for replication of bulk loaded hfiles relies on bulk 
> load marker written in the WAL.
> The move of bulk loaded hfile(s) (into region directory) may succeed but the 
> write of bulk load marker may fail.
> This means that although bulk loaded hfile is being served in source cluster, 
> the replication wouldn't happen.
> Normally operator is supposed to retry the bulk load. But relying on human 
> retry is not robust solution.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18910) Backport HBASE-17292 "Add observer notification before bulk loaded hfile is moved to region directory" to 1.3

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199607#comment-16199607
 ] 

Andrew Purtell commented on HBASE-18910:


HBASE-18900 depends on this change.

I believe both this issue and HBASE-18900 should be reverted.

> Backport HBASE-17292 "Add observer notification before bulk loaded hfile is 
> moved to region directory" to 1.3
> -
>
> Key: HBASE-18910
> URL: https://issues.apache.org/jira/browse/HBASE-18910
> Project: HBase
>  Issue Type: Bug
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 1.3.2
>
> Attachments: HBASE-18910.branch-1.3.v1.patch
>
>
> HBASE-18900 will backport HBASE-17290 to branch-1.3.But  HBASE-17290 is 
> dependent on HBASE-17292.so this issue will backport HBASE-17292 to 
> branch-1.3.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (HBASE-18900) Backport HBASE-17290 "Potential loss of data for replication of bulk loaded hfiles" to 1.3

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199605#comment-16199605
 ] 

Andrew Purtell edited comment on HBASE-18900 at 10/11/17 12:16 AM:
---

This depends on an incompatible change introduced for a point release on 
HBASE-18910 which breaks implementors of RegionObserver. 

I believe both HBASE-18910 and this issue should be reverted. 


was (Author: apurtell):
This depends on an incompatible change introduced into a point release on 
HBASE-18910 which breaks implementors of RegionObserver. 

I believe both HBASE-18910 and this issue should be reverted. 

> Backport HBASE-17290 "Potential loss of data for replication of bulk loaded 
> hfiles" to 1.3
> --
>
> Key: HBASE-18900
> URL: https://issues.apache.org/jira/browse/HBASE-18900
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 1.3.2
>
> Attachments: 17290-branch-1.3.patch, 18900.branch-1.3.patch
>
>
> HBASE-17290 fixes data loss bug.
> Bulk loaded hfile replication support is in branch-1.3
> This issue is to backport HBASE-17290 to branch-1.3



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Reopened] (HBASE-18900) Backport HBASE-17290 "Potential loss of data for replication of bulk loaded hfiles" to 1.3

[Andrew Purtell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell reopened HBASE-18900:


This depends on an incompatible change introduced into a point release on 
HBASE-18910 which breaks implementors of RegionObserver. 

I believe both HBASE-18910 and this issue should be reverted. 

> Backport HBASE-17290 "Potential loss of data for replication of bulk loaded 
> hfiles" to 1.3
> --
>
> Key: HBASE-18900
> URL: https://issues.apache.org/jira/browse/HBASE-18900
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 1.3.2
>
> Attachments: 17290-branch-1.3.patch, 18900.branch-1.3.patch
>
>
> HBASE-17290 fixes data loss bug.
> Bulk loaded hfile replication support is in branch-1.3
> This issue is to backport HBASE-17290 to branch-1.3



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18981) Address issues found by error-prone in hbase-client

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199606#comment-16199606
 ] 

Hudson commented on HBASE-18981:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3864 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/3864/])
HBASE-18981 Address issues found by error-prone in hbase-client (mdrob: rev 
690ff38f54d0de588465cda410ac4496cd9a3369)
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java


> Address issues found by error-prone in hbase-client
> ---
>
> Key: HBASE-18981
> URL: https://issues.apache.org/jira/browse/HBASE-18981
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Trivial
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18981.patch
>
>
> I thought this was something that we would already catch in findbugs, but 
> maybe not?
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile 
> (default-compile) on project hbase-client: Compilation failure
> [ERROR] 
> /Users/mdrob/IdeaProjects/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:[2476,5]
>  [MissingCasesInEnumSwitch] Non-exhaustive switch; either add a default or 
> handle the remaining cases: GLOBAL_BYPASS
> [ERROR] (see http://errorprone.info/bugpattern/MissingCasesInEnumSwitch)
> {noformat}
> cc: [~elserj], this looks like it is part of quota code. I'm happy to add a 
> trivial patch to error on the missing case, but want somebody with more 
> contextual knowledge to look at it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Reopened] (HBASE-18910) Backport HBASE-17292 "Add observer notification before bulk loaded hfile is moved to region directory" to 1.3

[Andrew Purtell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell reopened HBASE-18910:


This change breaks RegionObserver implementors because it adds two methods to 
the interface:

{code}
index 8c5c15ab19..0bea61457c 100644
--- 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
+++ 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
@@ -1187,6 +1187,29 @@ public interface RegionObserver extends Coprocessor {
 List> familyPaths) throws IOException;
 
   /**
+   * Called before moving bulk loaded hfile to region directory.
+   *
+   * @param ctx
+   * @param family column family
+   * @param pairs List of pairs of { HFile location in staging dir, HFile path 
in region dir }
+   * Each pair are for the same hfile.
+   * @throws IOException
+   */
+  void preCommitStoreFile(final ObserverContext 
ctx,
+  final byte[] family, final List> pairs) throws 
IOException;
+
+  /**
+   * Called after moving bulk loaded hfile to region directory.
+   *
+   * @param ctx
+   * @param family column family
+   * @param srcPath Path to file before the move
+   * @param dstPath Path to file after the move
+   */
+  void postCommitStoreFile(final ObserverContext 
ctx,
+  final byte[] family, Path srcPath, Path dstPath) throws IOException;
+
+  /**
* Called after bulkLoadHFile.
*
* @param ctx

{code}

This isn't allowed in a patch release, right?

[~mantonov]

> Backport HBASE-17292 "Add observer notification before bulk loaded hfile is 
> moved to region directory" to 1.3
> -
>
> Key: HBASE-18910
> URL: https://issues.apache.org/jira/browse/HBASE-18910
> Project: HBase
>  Issue Type: Bug
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 1.3.2
>
> Attachments: HBASE-18910.branch-1.3.v1.patch
>
>
> HBASE-18900 will backport HBASE-17290 to branch-1.3.But  HBASE-17290 is 
> dependent on HBASE-17292.so this issue will backport HBASE-17292 to 
> branch-1.3.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18960) A few bug fixes and minor improvements around batchMutate()

[Umesh Agashe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Umesh Agashe updated HBASE-18960:
-
Attachment: hbase-18960.master.006.patch

Changes per [~appy]'s review comments.

> A few bug fixes and minor improvements around batchMutate()
> ---
>
> Key: HBASE-18960
> URL: https://issues.apache.org/jira/browse/HBASE-18960
> Project: HBase
>  Issue Type: Sub-task
>  Components: regionserver
>Affects Versions: 2.0.0-alpha-3
>Reporter: Umesh Agashe
>Assignee: Umesh Agashe
> Fix For: 2.0.0-alpha-4
>
> Attachments: hbase-18960.master.001.patch, 
> hbase-18960.master.002.patch, hbase-18960.master.003.patch, 
> hbase-18960.master.004.patch, hbase-18960.master.005.patch, 
> hbase-18960.master.005.patch, hbase-18960.master.006.patch
>
>
> Batch validation and preparation can be done before we start iterating over 
> batch operations for writes. observedExceptions, familyCellMaps and 
> durability can be stored in BatchOperation as they are batch wide. For all 
> operations, done by preBatchMutate() CP hook, operation status needs to be 
> SUCCESS. Modify and use doWALAppend() from doMiniBatchMutate().



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18967) Backport HBASE-17181 to branch-1.3

[Peter Somogyi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-18967:
--
Attachment: HBASE-18967.branch-1.3.001.patch

> Backport HBASE-17181 to branch-1.3
> --
>
> Key: HBASE-18967
> URL: https://issues.apache.org/jira/browse/HBASE-18967
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Chia-Ping Tsai
>Assignee: Peter Somogyi
> Fix For: 1.3.2
>
> Attachments: HBASE-18967.branch-1.3.001.patch, 
> HBASE-18967.branch-1.3.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18967) Backport HBASE-17181 to branch-1.3

[Peter Somogyi (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199585#comment-16199585
 ] 

Peter Somogyi commented on HBASE-18967:
---

TestThriftServerCmdLine passes locally. Reattaching patch for retry.

> Backport HBASE-17181 to branch-1.3
> --
>
> Key: HBASE-18967
> URL: https://issues.apache.org/jira/browse/HBASE-18967
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Chia-Ping Tsai
>Assignee: Peter Somogyi
> Fix For: 1.3.2
>
> Attachments: HBASE-18967.branch-1.3.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18355) Enable export snapshot tests that were disabled by Proc-V2 AM in HBASE-14614

[huaxiang sun (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199580#comment-16199580
 ] 

huaxiang sun commented on HBASE-18355:
--

Thanks [~vrodionov].

> Enable export snapshot tests that were disabled by Proc-V2 AM in HBASE-14614
> 
>
> Key: HBASE-18355
> URL: https://issues.apache.org/jira/browse/HBASE-18355
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.0.0-alpha-1
>Reporter: Stephen Yuan Jiang
>Assignee: Vladimir Rodionov
>
> The Proc-V2 AM in HBASE-14614 disabled the following tests:
> - Disabled TestExportSnapshot Hangs. 
> - Disabled TestSecureExportSnapshot
> - Disabled TestMobSecureExportSnapshot and TestMobExportSnapshot
> This JIRA tracks the work to enable them.  If MOB requires more work, we 
> could split to 2 tickets.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18355) Enable export snapshot tests that were disabled by Proc-V2 AM in HBASE-14614

[Vladimir Rodionov (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199579#comment-16199579
 ] 

Vladimir Rodionov commented on HBASE-18355:
---

Sure, go ahead.

> Enable export snapshot tests that were disabled by Proc-V2 AM in HBASE-14614
> 
>
> Key: HBASE-18355
> URL: https://issues.apache.org/jira/browse/HBASE-18355
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.0.0-alpha-1
>Reporter: Stephen Yuan Jiang
>Assignee: Vladimir Rodionov
>
> The Proc-V2 AM in HBASE-14614 disabled the following tests:
> - Disabled TestExportSnapshot Hangs. 
> - Disabled TestSecureExportSnapshot
> - Disabled TestMobSecureExportSnapshot and TestMobExportSnapshot
> This JIRA tracks the work to enable them.  If MOB requires more work, we 
> could split to 2 tickets.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18975) B hadoop3 incompatibility

[Vladimir Rodionov (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199577#comment-16199577
 ] 

Vladimir Rodionov commented on HBASE-18975:
---

Submitted patch. It should work fine under hadoop2 (tested locally)

> B hadoop3 incompatibility
> ---
>
> Key: HBASE-18975
> URL: https://issues.apache.org/jira/browse/HBASE-18975
> Project: HBase
>  Issue Type: Bug
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Attachments: HBASE-18975-v1.patch, HBASE-18975-v2.patch, 
> testIncrementalBackup-output.tar.gz
>
>
> Due to changes in hadoop 3, reflection in BackupDistCp is broken
> {code}
> java.lang.NoSuchFieldException: inputOptions
>   at java.lang.Class.getDeclaredField(Class.java:2070)
>   at 
> org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupCopyJob$BackupDistCp.execute(MapReduceBackupCopyJob.java:168)
> {code}  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18975) B hadoop3 incompatibility

[Vladimir Rodionov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Rodionov updated HBASE-18975:
--
Status: Patch Available  (was: In Progress)

> B hadoop3 incompatibility
> ---
>
> Key: HBASE-18975
> URL: https://issues.apache.org/jira/browse/HBASE-18975
> Project: HBase
>  Issue Type: Bug
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Attachments: HBASE-18975-v1.patch, HBASE-18975-v2.patch, 
> testIncrementalBackup-output.tar.gz
>
>
> Due to changes in hadoop 3, reflection in BackupDistCp is broken
> {code}
> java.lang.NoSuchFieldException: inputOptions
>   at java.lang.Class.getDeclaredField(Class.java:2070)
>   at 
> org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupCopyJob$BackupDistCp.execute(MapReduceBackupCopyJob.java:168)
> {code}  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18355) Enable export snapshot tests that were disabled by Proc-V2 AM in HBASE-14614

[huaxiang sun (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199574#comment-16199574
 ] 

huaxiang sun commented on HBASE-18355:
--

Hi [~vrodionov], I am working on enabling these tests and had an initial patch. 
Do you mind if I take this jira from you? Thanks.

> Enable export snapshot tests that were disabled by Proc-V2 AM in HBASE-14614
> 
>
> Key: HBASE-18355
> URL: https://issues.apache.org/jira/browse/HBASE-18355
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.0.0-alpha-1
>Reporter: Stephen Yuan Jiang
>Assignee: Vladimir Rodionov
>
> The Proc-V2 AM in HBASE-14614 disabled the following tests:
> - Disabled TestExportSnapshot Hangs. 
> - Disabled TestSecureExportSnapshot
> - Disabled TestMobSecureExportSnapshot and TestMobExportSnapshot
> This JIRA tracks the work to enable them.  If MOB requires more work, we 
> could split to 2 tickets.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18967) Backport HBASE-17181 to branch-1.3

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199572#comment-16199572
 ] 

Hadoop QA commented on HBASE-18967:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
17s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
22s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
25s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
26s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
17s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
15s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
19s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
21s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
40s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
23s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
27m 59s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3. 
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 18m 34s{color} 
| {color:red} hbase-thrift in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 60m 39s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | 
org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce 

[jira] [Commented] (HBASE-18960) A few bug fixes and minor improvements around batchMutate()

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199562#comment-16199562
 ] 

Hadoop QA commented on HBASE-18960:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 26m 
22s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  7m 
44s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  6m 
11s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
63m 43s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
55s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}148m 15s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
34s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}270m 27s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | 
org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries |
|   | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
|   | 
org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster |
|   | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer |
|   | org.apache.hadoop.hbase.master.TestMasterShutdown |
|   | org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache |
|   | org.apache.hadoop.hbase.master.assignment.TestSplitTableRegionProcedure |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18960 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12891325/hbase-18960.master.005.patch
 |
| Optional Tests |  asflicense  shadedjars  javac  javadoc  unit  findbugs  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 50df6201f399 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 
13:48:03 UTC 2016 x86_64 

[jira] [Updated] (HBASE-18108) Procedure WALs are archived but not cleaned; fix

[Peter Somogyi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-18108:
--
Status: In Progress  (was: Patch Available)

> Procedure WALs are archived but not cleaned; fix
> 
>
> Key: HBASE-18108
> URL: https://issues.apache.org/jira/browse/HBASE-18108
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Peter Somogyi
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-18108.master.001.patch, 
> HBASE-18108.master.002.patch, HBASE-18108.master.003.patch, 
> HBASE-18108.master.004.patch
>
>
> The Procedure WAL files used to be deleted when done. HBASE-14614 keeps them 
> around in case issue but what is missing is a GC for no-longer-needed WAL 
> files. This one is pretty important.
> From WALProcedureStore Cleaner TODO in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.r2pc835nb7vi



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18108) Procedure WALs are archived but not cleaned; fix

[Peter Somogyi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-18108:
--
Status: Patch Available  (was: In Progress)

> Procedure WALs are archived but not cleaned; fix
> 
>
> Key: HBASE-18108
> URL: https://issues.apache.org/jira/browse/HBASE-18108
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Peter Somogyi
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-18108.master.001.patch, 
> HBASE-18108.master.002.patch, HBASE-18108.master.003.patch, 
> HBASE-18108.master.004.patch
>
>
> The Procedure WAL files used to be deleted when done. HBASE-14614 keeps them 
> around in case issue but what is missing is a GC for no-longer-needed WAL 
> files. This one is pretty important.
> From WALProcedureStore Cleaner TODO in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.r2pc835nb7vi



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18975) B hadoop3 incompatibility

[Ted Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199527#comment-16199527
 ] 

Ted Yu commented on HBASE-18975:


Vlad:
Can you change the status to Patch Available so that we know how the patch 
behaves on hadoop-2 ?

> B hadoop3 incompatibility
> ---
>
> Key: HBASE-18975
> URL: https://issues.apache.org/jira/browse/HBASE-18975
> Project: HBase
>  Issue Type: Bug
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Attachments: HBASE-18975-v1.patch, HBASE-18975-v2.patch, 
> testIncrementalBackup-output.tar.gz
>
>
> Due to changes in hadoop 3, reflection in BackupDistCp is broken
> {code}
> java.lang.NoSuchFieldException: inputOptions
>   at java.lang.Class.getDeclaredField(Class.java:2070)
>   at 
> org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupCopyJob$BackupDistCp.execute(MapReduceBackupCopyJob.java:168)
> {code}  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18984) [AMv2] Retain assignment does not work well in AMv2

[Yi Liang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199515#comment-16199515
 ] 

Yi Liang commented on HBASE-18984:
--

I will do some research on this. Thanks for the information


> [AMv2] Retain assignment does not work well in AMv2
> ---
>
> Key: HBASE-18984
> URL: https://issues.apache.org/jira/browse/HBASE-18984
> Project: HBase
>  Issue Type: Bug
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: Yi Liang
>Assignee: Yi Liang
> Fix For: 2.0.0
>
> Attachments: Screen Shot 2017-10-10 at 2.24.19 PM.png
>
>
> work on 8.17 Retain assignment in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.epjn9nege80k
> To reproduce this error, in hbase shell:
> createTable t1 --> list_regions 't1' --> disable 't1' ---> enable 't1' --> 
> list_reigons 't1' (maybe you need to try enable/disable multiple times)
> See attached images. same region assigned to different region servers



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-16338) update jackson to 2.y

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-16338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199508#comment-16199508
 ] 

Hadoop QA commented on HBASE-16338:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
11s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
6s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 17 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
40s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  7m 
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  4m 
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  4m 
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 7s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hbase-resource-bundle hbase-shaded hbase-shaded/hbase-shaded-mapreduce . 
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m 
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  6m  
2s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
23s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
16s{color} | {color:red} hbase-mapreduce in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
16s{color} | {color:red} hbase-it in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  3m 
40s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  3m 
12s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  3m 12s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  4m 
50s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} mvneclipse {color} | {color:red}  1m 
40s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} rubocop {color} | {color:green}  0m  
4s{color} | {color:green} There were no new rubocop issues. {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green}  0m  
1s{color} | {color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
 5s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m 
12s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
27s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  7m 
40s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.1. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 10m 
48s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.2. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck 

[jira] [Commented] (HBASE-18967) Backport HBASE-17181 to branch-1.3

[Peter Somogyi (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199499#comment-16199499
 ] 

Peter Somogyi commented on HBASE-18967:
---

Backporting patch is attached for branch-1.3.

> Backport HBASE-17181 to branch-1.3
> --
>
> Key: HBASE-18967
> URL: https://issues.apache.org/jira/browse/HBASE-18967
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Chia-Ping Tsai
>Assignee: Peter Somogyi
> Fix For: 1.3.2
>
> Attachments: HBASE-18967.branch-1.3.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18984) [AMv2] Retain assignment does not work well in AMv2

[Umesh Agashe (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199498#comment-16199498
 ] 

Umesh Agashe commented on HBASE-18984:
--

Checkout HBASE-18575. Its about retaining assignments after restart. Looks like 
just disabling and re-enabling table is messing up with assignment.

> [AMv2] Retain assignment does not work well in AMv2
> ---
>
> Key: HBASE-18984
> URL: https://issues.apache.org/jira/browse/HBASE-18984
> Project: HBase
>  Issue Type: Bug
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: Yi Liang
>Assignee: Yi Liang
> Fix For: 2.0.0
>
> Attachments: Screen Shot 2017-10-10 at 2.24.19 PM.png
>
>
> work on 8.17 Retain assignment in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.epjn9nege80k
> To reproduce this error, in hbase shell:
> createTable t1 --> list_regions 't1' --> disable 't1' ---> enable 't1' --> 
> list_reigons 't1' (maybe you need to try enable/disable multiple times)
> See attached images. same region assigned to different region servers



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18967) Backport HBASE-17181 to branch-1.3

[Peter Somogyi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-18967:
--
Status: Patch Available  (was: Open)

> Backport HBASE-17181 to branch-1.3
> --
>
> Key: HBASE-18967
> URL: https://issues.apache.org/jira/browse/HBASE-18967
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Chia-Ping Tsai
>Assignee: Peter Somogyi
> Fix For: 1.3.2
>
> Attachments: HBASE-18967.branch-1.3.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (HBASE-18967) Backport HBASE-17181 to branch-1.3

[Peter Somogyi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi reassigned HBASE-18967:
-

Assignee: Peter Somogyi

> Backport HBASE-17181 to branch-1.3
> --
>
> Key: HBASE-18967
> URL: https://issues.apache.org/jira/browse/HBASE-18967
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Chia-Ping Tsai
>Assignee: Peter Somogyi
> Fix For: 1.3.2
>
> Attachments: HBASE-18967.branch-1.3.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18967) Backport HBASE-17181 to branch-1.3

[Peter Somogyi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-18967:
--
Attachment: HBASE-18967.branch-1.3.001.patch

> Backport HBASE-17181 to branch-1.3
> --
>
> Key: HBASE-18967
> URL: https://issues.apache.org/jira/browse/HBASE-18967
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Chia-Ping Tsai
>Assignee: Peter Somogyi
> Fix For: 1.3.2
>
> Attachments: HBASE-18967.branch-1.3.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-16538) Version mismatch in HBaseConfiguration.checkDefaultsVersion

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-16538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199494#comment-16199494
 ] 

Hudson commented on HBASE-16538:


FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #315 (See 
[https://builds.apache.org/job/HBase-1.3-JDK8/315/])
Amend HBASE-16538 Changes the way version information is stored during 
(apurtell: rev 8cace342f3e4f94f704f43931b8e86abf8b1f309)
* (edit) hbase-common/src/saveVersion.sh


> Version mismatch in HBaseConfiguration.checkDefaultsVersion
> ---
>
> Key: HBASE-16538
> URL: https://issues.apache.org/jira/browse/HBASE-16538
> Project: HBase
>  Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
>  Labels: configuration, test-failure
> Fix For: 2.0.0, 1.0.4, 1.4.0, 0.98.22, 1.1.7, 1.2.4
>
> Attachments: HBASE-16538-addendum.patch, 
> HBASE-16538.master.001.patch, HBASE-16538.master.002.patch
>
>
> {noformat}
> org.apache.hadoop.hbase.procedure2.TestYieldProcedures
> testYieldEachExecutionStep(org.apache.hadoop.hbase.procedure2.TestYieldProcedures)
>   Time elapsed: 0.255 sec  <<< ERROR!
> java.lang.RuntimeException: hbase-default.xml file seems to be for an older 
> version of HBase (2.0.0-SNAPSHOT), this version is Unknown
>   at 
> org.apache.hadoop.hbase.HBaseConfiguration.checkDefaultsVersion(HBaseConfiguration.java:73)
>   at 
> org.apache.hadoop.hbase.HBaseConfiguration.addHbaseResources(HBaseConfiguration.java:83)
>   at 
> org.apache.hadoop.hbase.HBaseConfiguration.create(HBaseConfiguration.java:98)
>   at 
> org.apache.hadoop.hbase.HBaseCommonTestingUtility.(HBaseCommonTestingUtility.java:46)
>   at 
> org.apache.hadoop.hbase.procedure2.TestYieldProcedures.setUp(TestYieldProcedures.java:63)
> {noformat}
> (Exact test is not important)
> Reference run:
> https://builds.apache.org/view/All/job/HBase-Trunk_matrix/jdk=JDK%201.8%20(latest),label=yahoo-not-h2/1515/console



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18786) FileNotFoundException should not be silently handled for primary region replicas

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199491#comment-16199491
 ] 

Andrew Purtell commented on HBASE-18786:


bq. If we really want to handle this situation then we need to introduce 
fencing at the HDFS level during failed server processing.

We should follow up on that.

bq. The current situation with handleFileNotFound() seems worse than the 
original problem, since it can hide other problems.

Yeah, definitely agree, that's the motivation of this change.

> FileNotFoundException should not be silently handled for primary region 
> replicas
> 
>
> Key: HBASE-18786
> URL: https://issues.apache.org/jira/browse/HBASE-18786
> Project: HBase
>  Issue Type: Sub-task
>  Components: regionserver, Scanners
>Reporter: Ashu Pachauri
>Assignee: Andrew Purtell
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.5.0
>
> Attachments: HBASE-18786-branch-1.3.patch, 
> HBASE-18786-branch-1.patch, HBASE-18786-branch-1.patch, HBASE-18786.patch, 
> HBASE-18786.patch
>
>
> This is a follow up for HBASE-18186.
> FileNotFoundException while scanning from a primary region replica can be 
> indicative of a more severe problem. Handling them silently can cause many 
> underlying issues go undetected. We should either
> 1. Hard fail the regionserver if there is a FNFE on a primary region replica, 
> OR
> 2. Report these exceptions as some region / server level metric so that these 
> can be proactively investigated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18786) FileNotFoundException should not be silently handled for primary region replicas

[Gary Helmling (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199483#comment-16199483
 ] 

Gary Helmling commented on HBASE-18786:
---

Seems fine to remove from 1.3.  

handleFileNotFound() was introduced by HBASE-13651 to handle a situation where 
regionserver A is hosting a region and starts a compaction, enters GC pause, 
region is reassigned, then regionserver A emerges from pause and archives the 
compacted files before aborting.  If we really want to handle this situation 
then we need to introduce fencing at the HDFS level during failed server 
processing.  The current situation with handleFileNotFound() seems worse than 
the original problem, since it can hide other problems.

> FileNotFoundException should not be silently handled for primary region 
> replicas
> 
>
> Key: HBASE-18786
> URL: https://issues.apache.org/jira/browse/HBASE-18786
> Project: HBase
>  Issue Type: Sub-task
>  Components: regionserver, Scanners
>Reporter: Ashu Pachauri
>Assignee: Andrew Purtell
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.5.0
>
> Attachments: HBASE-18786-branch-1.3.patch, 
> HBASE-18786-branch-1.patch, HBASE-18786-branch-1.patch, HBASE-18786.patch, 
> HBASE-18786.patch
>
>
> This is a follow up for HBASE-18186.
> FileNotFoundException while scanning from a primary region replica can be 
> indicative of a more severe problem. Handling them silently can cause many 
> underlying issues go undetected. We should either
> 1. Hard fail the regionserver if there is a FNFE on a primary region replica, 
> OR
> 2. Report these exceptions as some region / server level metric so that these 
> can be proactively investigated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18108) Procedure WALs are archived but not cleaned; fix

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199482#comment-16199482
 ] 

Hadoop QA commented on HBASE-18108:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
48s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
 2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  7m 
 0s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
9s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
28s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
17s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
50m  9s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
43s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}126m 41s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
47s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}212m 52s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | 
org.apache.hadoop.hbase.io.asyncfs.TestSaslFanOutOneBlockAsyncDFSOutput |
|   | org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput |
|   | org.apache.hadoop.hbase.TestClusterBootOrder |
|   | org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders |
|   | org.apache.hadoop.hbase.client.TestAvoidCellReferencesIntoShippedBlocks |
|   | org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite |
|   | org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd |
|   | 

[jira] [Commented] (HBASE-18984) [AMv2] Retain assignment does not work well in AMv2

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199480#comment-16199480
 ] 

stack commented on HBASE-18984:
---

I was under the impression that it worked. There was a bug but my coworker 
[~uagashe] thought he'd fixed it. Maybe its broke though? Thanks [~easyliangjob]

> [AMv2] Retain assignment does not work well in AMv2
> ---
>
> Key: HBASE-18984
> URL: https://issues.apache.org/jira/browse/HBASE-18984
> Project: HBase
>  Issue Type: Bug
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: Yi Liang
>Assignee: Yi Liang
> Fix For: 2.0.0
>
> Attachments: Screen Shot 2017-10-10 at 2.24.19 PM.png
>
>
> work on 8.17 Retain assignment in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.epjn9nege80k
> To reproduce this error, in hbase shell:
> createTable t1 --> list_regions 't1' --> disable 't1' ---> enable 't1' --> 
> list_reigons 't1' (maybe you need to try enable/disable multiple times)
> See attached images. same region assigned to different region servers



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18984) [AMv2] Retain assignment does not work well in AMv2

[Yi Liang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199464#comment-16199464
 ] 

Yi Liang commented on HBASE-18984:
--

ping [~stack],  do you know about retain assignment?  Just make sure this is a 
problem before dig into it. 

> [AMv2] Retain assignment does not work well in AMv2
> ---
>
> Key: HBASE-18984
> URL: https://issues.apache.org/jira/browse/HBASE-18984
> Project: HBase
>  Issue Type: Bug
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: Yi Liang
>Assignee: Yi Liang
> Fix For: 2.0.0
>
> Attachments: Screen Shot 2017-10-10 at 2.24.19 PM.png
>
>
> work on 8.17 Retain assignment in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.epjn9nege80k
> To reproduce this error, in hbase shell:
> createTable t1 --> list_regions 't1' --> disable 't1' ---> enable 't1' --> 
> list_reigons 't1' (maybe you need to try enable/disable multiple times)
> See attached images. same region assigned to different region servers



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18984) [AMv2] Retain assignment does not work well in AMv2

[Yi Liang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yi Liang updated HBASE-18984:
-
Attachment: Screen Shot 2017-10-10 at 2.24.19 PM.png

> [AMv2] Retain assignment does not work well in AMv2
> ---
>
> Key: HBASE-18984
> URL: https://issues.apache.org/jira/browse/HBASE-18984
> Project: HBase
>  Issue Type: Bug
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: Yi Liang
>Assignee: Yi Liang
> Fix For: 2.0.0
>
> Attachments: Screen Shot 2017-10-10 at 2.24.19 PM.png
>
>
> work on 8.17 Retain assignment in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.epjn9nege80k
> To reproduce this error, in hbase shell:
> createTable t1 --> list_regions 't1' --> disable 't1' ---> enable 't1' --> 
> list_reigons 't1' (maybe you need to try enable/disable multiple times)
> See attached images. same region assigned to different region servers



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-18984) [AMv2] Retain assignment does not work well in AMv2

[Yi Liang (JIRA)]

Yi Liang created HBASE-18984:


 Summary: [AMv2] Retain assignment does not work well in AMv2
 Key: HBASE-18984
 URL: https://issues.apache.org/jira/browse/HBASE-18984
 Project: HBase
  Issue Type: Bug
  Components: proc-v2
Affects Versions: 2.0.0
Reporter: Yi Liang
Assignee: Yi Liang
 Fix For: 2.0.0


work on 8.17 Retain assignment in 
https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.epjn9nege80k

To reproduce this error, in hbase shell:
createTable t1 --> list_regions 't1' --> disable 't1' ---> enable 't1' --> 
list_reigons 't1' (maybe you need to try enable/disable multiple times)

See attached images. same region assigned to different region servers



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (HBASE-18786) FileNotFoundException should not be silently handled for primary region replicas

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199403#comment-16199403
 ] 

Andrew Purtell edited comment on HBASE-18786 at 10/10/17 9:28 PM:
--

What this patch removed was a silent rescan of storefiles if there is some kind 
of glitch leading to a FNFE during scanning.  If there was a temporary store 
file accounting failure then after one server aborts and another picks it up, 
the new server will not see another FNFE, and so this is not a cascading 
failure condition. 

If there is a permanent condition which could lead to a cascade, like hard loss 
of files or directories in HDFS, leading to FNFEs and a cascading failure 
situation, then I don't see how rescanning would help, and anyway we should 
handle it differently. Previously we would have silently opened the region with 
missing files (?). That would be bad. Aborting would be bad too in that case. 
Rather than aborting we should fail the region open. This should be handled 
with a new JIRA.


was (Author: apurtell):
What this patch removed was a silent rescan of storefiles if there is some kind 
of glitch leading to a FNFE during scanning.  If there was a temporary store 
file accounting failure then after one server aborts and another picks it up, 
the new server will not see another FNFE. 

If there is a permanent condition, like loss of files or directories in HDFS, 
leading to FNFEs and a cascading failure situation, then I don't see how 
rescanning would help, and anyway we should handle it differently. Previously 
we would have silently opened the region with missing files (?). That would be 
bad. Aborting would be bad too in that case. Rather than aborting we should 
fail the region open. This should be handled with a new JIRA.

> FileNotFoundException should not be silently handled for primary region 
> replicas
> 
>
> Key: HBASE-18786
> URL: https://issues.apache.org/jira/browse/HBASE-18786
> Project: HBase
>  Issue Type: Sub-task
>  Components: regionserver, Scanners
>Reporter: Ashu Pachauri
>Assignee: Andrew Purtell
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.5.0
>
> Attachments: HBASE-18786-branch-1.3.patch, 
> HBASE-18786-branch-1.patch, HBASE-18786-branch-1.patch, HBASE-18786.patch, 
> HBASE-18786.patch
>
>
> This is a follow up for HBASE-18186.
> FileNotFoundException while scanning from a primary region replica can be 
> indicative of a more severe problem. Handling them silently can cause many 
> underlying issues go undetected. We should either
> 1. Hard fail the regionserver if there is a FNFE on a primary region replica, 
> OR
> 2. Report these exceptions as some region / server level metric so that these 
> can be proactively investigated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18786) FileNotFoundException should not be silently handled for primary region replicas

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199403#comment-16199403
 ] 

Andrew Purtell commented on HBASE-18786:


What this patch removed was a silent rescan of storefiles if there is some kind 
of glitch leading to a FNFE during scanning.  If there was a temporary store 
file accounting failure then after one server aborts and another picks it up, 
the new server will not see another FNFE. 

If there is a permanent condition, like loss of files or directories in HDFS, 
leading to FNFEs and a cascading failure situation, then I don't see how 
rescanning would help, and anyway we should handle it differently. Previously 
we would have silently opened the region with missing files (?). That would be 
bad. Aborting would be bad too in that case. Rather than aborting we should 
fail the region open. This should be handled with a new JIRA.

> FileNotFoundException should not be silently handled for primary region 
> replicas
> 
>
> Key: HBASE-18786
> URL: https://issues.apache.org/jira/browse/HBASE-18786
> Project: HBase
>  Issue Type: Sub-task
>  Components: regionserver, Scanners
>Reporter: Ashu Pachauri
>Assignee: Andrew Purtell
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.5.0
>
> Attachments: HBASE-18786-branch-1.3.patch, 
> HBASE-18786-branch-1.patch, HBASE-18786-branch-1.patch, HBASE-18786.patch, 
> HBASE-18786.patch
>
>
> This is a follow up for HBASE-18186.
> FileNotFoundException while scanning from a primary region replica can be 
> indicative of a more severe problem. Handling them silently can cause many 
> underlying issues go undetected. We should either
> 1. Hard fail the regionserver if there is a FNFE on a primary region replica, 
> OR
> 2. Report these exceptions as some region / server level metric so that these 
> can be proactively investigated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18945) Make a Public interface for CellComparator

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199398#comment-16199398
 ] 

Hadoop QA commented on HBASE-18945:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 13m 
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
37s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  6m 
21s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
16s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 9s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
39m 27s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
18s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
36s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 99m 
42s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  9m 
37s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  1m 
 1s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}199m 50s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18945 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12891314/HBASE-18945_2.patch |
| Optional Tests |  asflicense  shadedjars  javac  javadoc  unit  findbugs  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 52c6d5727757 3.13.0-123-generic 

[jira] [Commented] (HBASE-18980) Address issues found by error-prone in hbase-hadoop2-compat

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199389#comment-16199389
 ] 

Hudson commented on HBASE-18980:


FAILURE: Integrated in Jenkins build HBase-1.5 #92 (See 
[https://builds.apache.org/job/HBase-1.5/92/])
HBASE-18980 Suppress SelfComparison error in tests (mdrob: rev 
739ca50e9c50da5e89f5d8d0c68a69f9c124ca07)
* (edit) 
hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java
* (edit) 
hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsTableSourceImpl.java


> Address issues found by error-prone in hbase-hadoop2-compat
> ---
>
> Key: HBASE-18980
> URL: https://issues.apache.org/jira/browse/HBASE-18980
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Trivial
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 1.1.13, 2.0.0-alpha-4
>
> Attachments: HBASE-18980.patch
>
>
> There are a few instances of self comparison found in hadoop2-compat module. 
> Because they are in tests specifically for verifying compareTo, I think 
> they're ok to keep and we should suppress them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18786) FileNotFoundException should not be silently handled for primary region replicas

[Mikhail Antonov (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199385#comment-16199385
 ] 

Mikhail Antonov commented on HBASE-18786:
-

[~ghelmling] I kind of remember that about a year ago or so some silent 
handling for FNFE was added to avoid possible cascading server restarts. Do you 
remember any more details of it, am I wrong in my recollection?

> FileNotFoundException should not be silently handled for primary region 
> replicas
> 
>
> Key: HBASE-18786
> URL: https://issues.apache.org/jira/browse/HBASE-18786
> Project: HBase
>  Issue Type: Sub-task
>  Components: regionserver, Scanners
>Reporter: Ashu Pachauri
>Assignee: Andrew Purtell
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.5.0
>
> Attachments: HBASE-18786-branch-1.3.patch, 
> HBASE-18786-branch-1.patch, HBASE-18786-branch-1.patch, HBASE-18786.patch, 
> HBASE-18786.patch
>
>
> This is a follow up for HBASE-18186.
> FileNotFoundException while scanning from a primary region replica can be 
> indicative of a more severe problem. Handling them silently can cause many 
> underlying issues go undetected. We should either
> 1. Hard fail the regionserver if there is a FNFE on a primary region replica, 
> OR
> 2. Report these exceptions as some region / server level metric so that these 
> can be proactively investigated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18980) Address issues found by error-prone in hbase-hadoop2-compat

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199365#comment-16199365
 ] 

Hudson commented on HBASE-18980:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3863 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/3863/])
HBASE-18980 Suppress SelfComparison error in tests (mdrob: rev 
73b6bd0283eb4a9a9704a15d07974cde829ee2b6)
* (edit) 
hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsTableSourceImpl.java
* (edit) 
hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java


> Address issues found by error-prone in hbase-hadoop2-compat
> ---
>
> Key: HBASE-18980
> URL: https://issues.apache.org/jira/browse/HBASE-18980
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Trivial
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 1.1.13, 2.0.0-alpha-4
>
> Attachments: HBASE-18980.patch
>
>
> There are a few instances of self comparison found in hadoop2-compat module. 
> Because they are in tests specifically for verifying compareTo, I think 
> they're ok to keep and we should suppress them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18979) TestInterfaceAudienceAnnotations fails on branch-1.3

[Mikhail Antonov (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199349#comment-16199349
 ] 

Mikhail Antonov commented on HBASE-18979:
-

Thanks [~apurtell]

> TestInterfaceAudienceAnnotations fails on branch-1.3
> 
>
> Key: HBASE-18979
> URL: https://issues.apache.org/jira/browse/HBASE-18979
> Project: HBase
>  Issue Type: Test
>  Components: Client
>Reporter: Mike Drob
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 1.3.2
>
>
> {noformat}
> 2017-10-10 09:15:15,609 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): These are the classes that DO 
> NOT have @InterfaceAudience annotation:
> 2017-10-10 09:15:15,609 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(256): class 
> org.apache.hadoop.hbase.Version
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18980) Address issues found by error-prone in hbase-hadoop2-compat

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199340#comment-16199340
 ] 

Hudson commented on HBASE-18980:


FAILURE: Integrated in Jenkins build HBase-2.0 #662 (See 
[https://builds.apache.org/job/HBase-2.0/662/])
HBASE-18980 Suppress SelfComparison error in tests (mdrob: rev 
e268ec8d7773762ab79ee69c28aea311104d4531)
* (edit) 
hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java
* (edit) 
hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsTableSourceImpl.java


> Address issues found by error-prone in hbase-hadoop2-compat
> ---
>
> Key: HBASE-18980
> URL: https://issues.apache.org/jira/browse/HBASE-18980
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Trivial
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 1.1.13, 2.0.0-alpha-4
>
> Attachments: HBASE-18980.patch
>
>
> There are a few instances of self comparison found in hadoop2-compat module. 
> Because they are in tests specifically for verifying compareTo, I think 
> they're ok to keep and we should suppress them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18397) StoreFile accounting issues on branch-1.3 and branch-1

[Mikhail Antonov (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199332#comment-16199332
 ] 

Mikhail Antonov commented on HBASE-18397:
-

All right, marked it as Major and kicked out of 1.3.2 timeline (added 1.3.3 
version)

> StoreFile accounting issues on branch-1.3 and branch-1
> --
>
> Key: HBASE-18397
> URL: https://issues.apache.org/jira/browse/HBASE-18397
> Project: HBase
>  Issue Type: Umbrella
>  Components: regionserver, Scanners
>Affects Versions: 1.3.0
>Reporter: Mikhail Antonov
> Fix For: 2.0.0, 1.3.3
>
>
> This jira is an umbrella for a set of issues around store file accounting on 
> branch-1.3 and branch-1 (I believe).
> At this point I do believe that many / most of those issues are related to 
> backport of HBASE-13082 done  long time ago. A number of related issues were 
> identified and fixed previously, but some still yet to be debugged and fixed. 
> I think that this class of problems prevents us from releasing 1.3.2 and 
> moving stable pointer to branch 1.3 at this point, so marking as critical.
> Below is overview by Andrew Purtell from dev list: (Subject: _Re: Branch 1.4 
> update_):
> {quote}
> Let me provide some context.
> The root issue was fallout from a locking change introduced just prior to
> release of 1.3. That change was HBASE-13082. Lars H proposed a change. It
> was committed to trunk but quickly reverted. After the revert Lars decided
> to drop the work rather than fix it for reapplication. However, the work
> was picked up by others and eventually found its way into branch-1, then
> branch-1.3, then 1.3.x releases. There were unintended side effects,
> causing bugs. The umbrella issue HBASE-18397 tracks a bunch of fix work the
> community has done since. The last known bug fix was HBASE-18771, found and
> fixed by our Abhishek. The last known change I know of was work I did on
> HBASE-18786 to remove some dodgy exception handling (prefer aborts to
> silent data corruption). Is this enough to move the stable pointer?
> According to our testing at Salesforce, yes, so far. We have yet to run in
> full production. Give us a few months of that and my answer will be
> unconditional one way or another. According to some offline conversation
> with Mikhail and Gary, the answer is in fact no, they still have one hairy
> use case causing occasional problems that look like more of this, but that
> feedback predates HBASE-18771.{quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18397) StoreFile accounting issues on branch-1.3 and branch-1

[Mikhail Antonov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikhail Antonov updated HBASE-18397:

Fix Version/s: (was: 1.3.2)
   1.3.3

> StoreFile accounting issues on branch-1.3 and branch-1
> --
>
> Key: HBASE-18397
> URL: https://issues.apache.org/jira/browse/HBASE-18397
> Project: HBase
>  Issue Type: Umbrella
>  Components: regionserver, Scanners
>Affects Versions: 1.3.0
>Reporter: Mikhail Antonov
> Fix For: 2.0.0, 1.3.3
>
>
> This jira is an umbrella for a set of issues around store file accounting on 
> branch-1.3 and branch-1 (I believe).
> At this point I do believe that many / most of those issues are related to 
> backport of HBASE-13082 done  long time ago. A number of related issues were 
> identified and fixed previously, but some still yet to be debugged and fixed. 
> I think that this class of problems prevents us from releasing 1.3.2 and 
> moving stable pointer to branch 1.3 at this point, so marking as critical.
> Below is overview by Andrew Purtell from dev list: (Subject: _Re: Branch 1.4 
> update_):
> {quote}
> Let me provide some context.
> The root issue was fallout from a locking change introduced just prior to
> release of 1.3. That change was HBASE-13082. Lars H proposed a change. It
> was committed to trunk but quickly reverted. After the revert Lars decided
> to drop the work rather than fix it for reapplication. However, the work
> was picked up by others and eventually found its way into branch-1, then
> branch-1.3, then 1.3.x releases. There were unintended side effects,
> causing bugs. The umbrella issue HBASE-18397 tracks a bunch of fix work the
> community has done since. The last known bug fix was HBASE-18771, found and
> fixed by our Abhishek. The last known change I know of was work I did on
> HBASE-18786 to remove some dodgy exception handling (prefer aborts to
> silent data corruption). Is this enough to move the stable pointer?
> According to our testing at Salesforce, yes, so far. We have yet to run in
> full production. Give us a few months of that and my answer will be
> unconditional one way or another. According to some offline conversation
> with Mikhail and Gary, the answer is in fact no, they still have one hairy
> use case causing occasional problems that look like more of this, but that
> feedback predates HBASE-18771.{quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18397) StoreFile accounting issues on branch-1.3 and branch-1

[Mikhail Antonov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikhail Antonov updated HBASE-18397:

Priority: Major  (was: Critical)

> StoreFile accounting issues on branch-1.3 and branch-1
> --
>
> Key: HBASE-18397
> URL: https://issues.apache.org/jira/browse/HBASE-18397
> Project: HBase
>  Issue Type: Umbrella
>  Components: regionserver, Scanners
>Affects Versions: 1.3.0
>Reporter: Mikhail Antonov
> Fix For: 2.0.0, 1.3.3
>
>
> This jira is an umbrella for a set of issues around store file accounting on 
> branch-1.3 and branch-1 (I believe).
> At this point I do believe that many / most of those issues are related to 
> backport of HBASE-13082 done  long time ago. A number of related issues were 
> identified and fixed previously, but some still yet to be debugged and fixed. 
> I think that this class of problems prevents us from releasing 1.3.2 and 
> moving stable pointer to branch 1.3 at this point, so marking as critical.
> Below is overview by Andrew Purtell from dev list: (Subject: _Re: Branch 1.4 
> update_):
> {quote}
> Let me provide some context.
> The root issue was fallout from a locking change introduced just prior to
> release of 1.3. That change was HBASE-13082. Lars H proposed a change. It
> was committed to trunk but quickly reverted. After the revert Lars decided
> to drop the work rather than fix it for reapplication. However, the work
> was picked up by others and eventually found its way into branch-1, then
> branch-1.3, then 1.3.x releases. There were unintended side effects,
> causing bugs. The umbrella issue HBASE-18397 tracks a bunch of fix work the
> community has done since. The last known bug fix was HBASE-18771, found and
> fixed by our Abhishek. The last known change I know of was work I did on
> HBASE-18786 to remove some dodgy exception handling (prefer aborts to
> silent data corruption). Is this enough to move the stable pointer?
> According to our testing at Salesforce, yes, so far. We have yet to run in
> full production. Give us a few months of that and my answer will be
> unconditional one way or another. According to some offline conversation
> with Mikhail and Gary, the answer is in fact no, they still have one hairy
> use case causing occasional problems that look like more of this, but that
> feedback predates HBASE-18771.{quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18108) Procedure WALs are archived but not cleaned; fix

[Peter Somogyi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-18108:
--
Attachment: HBASE-18108.master.004.patch

> Procedure WALs are archived but not cleaned; fix
> 
>
> Key: HBASE-18108
> URL: https://issues.apache.org/jira/browse/HBASE-18108
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Peter Somogyi
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-18108.master.001.patch, 
> HBASE-18108.master.002.patch, HBASE-18108.master.003.patch, 
> HBASE-18108.master.004.patch
>
>
> The Procedure WAL files used to be deleted when done. HBASE-14614 keeps them 
> around in case issue but what is missing is a GC for no-longer-needed WAL 
> files. This one is pretty important.
> From WALProcedureStore Cleaner TODO in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.r2pc835nb7vi



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18108) Procedure WALs are archived but not cleaned; fix

[Peter Somogyi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-18108:
--
Release Note: 
The archived Procedure WALs are moved to 
/oldWALs/masterProcedureWALs
directory. TimeToLiveProcedureWALCleaner class was added which regularly cleans 
the Procedure WAL files from there.
The TimeToLiveProcedureWALCleaner is added to hbase.master.logcleaner.plugins 
configuration value.

A new config parameter is added: hbase.master.proclogcleaner.ttl, which 
specifies how long a Procedure WAL should stay in the
archive directory.

> Procedure WALs are archived but not cleaned; fix
> 
>
> Key: HBASE-18108
> URL: https://issues.apache.org/jira/browse/HBASE-18108
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Peter Somogyi
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-18108.master.001.patch, 
> HBASE-18108.master.002.patch, HBASE-18108.master.003.patch
>
>
> The Procedure WAL files used to be deleted when done. HBASE-14614 keeps them 
> around in case issue but what is missing is a GC for no-longer-needed WAL 
> files. This one is pretty important.
> From WALProcedureStore Cleaner TODO in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.r2pc835nb7vi



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18980) Address issues found by error-prone in hbase-hadoop2-compat

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199319#comment-16199319
 ] 

Hudson commented on HBASE-18980:


SUCCESS: Integrated in Jenkins build HBase-1.4 #947 (See 
[https://builds.apache.org/job/HBase-1.4/947/])
HBASE-18980 Suppress SelfComparison error in tests (mdrob: rev 
411e4d6c79ed8127754c7fdf7362e6f3f9cd2e98)
* (edit) 
hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java
* (edit) 
hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsTableSourceImpl.java


> Address issues found by error-prone in hbase-hadoop2-compat
> ---
>
> Key: HBASE-18980
> URL: https://issues.apache.org/jira/browse/HBASE-18980
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Trivial
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 1.1.13, 2.0.0-alpha-4
>
> Attachments: HBASE-18980.patch
>
>
> There are a few instances of self comparison found in hadoop2-compat module. 
> Because they are in tests specifically for verifying compareTo, I think 
> they're ok to keep and we should suppress them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18693) adding an option to restore_snapshot to move mob files from archive dir to working dir

[huaxiang sun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

huaxiang sun updated HBASE-18693:
-
Attachment: HBASE-18693.master.002.patch

> adding an option to restore_snapshot to move mob files from archive dir to 
> working dir
> --
>
> Key: HBASE-18693
> URL: https://issues.apache.org/jira/browse/HBASE-18693
> Project: HBase
>  Issue Type: Improvement
>  Components: mob
>Affects Versions: 2.0.0-alpha-2
>Reporter: huaxiang sun
>Assignee: huaxiang sun
> Attachments: HBASE-18693.master.001.patch, 
> HBASE-18693.master.002.patch
>
>
> Today, there is a single mob region where mob files for all user regions are 
> saved. There could be many files (one million) in a single mob directory. 
> When one mob table is restored or cloned from snapshot, links are created for 
> these mob files. This creates a scaling issue for mob compaction. In mob 
> compaction's select() logic, for each hFileLink, it needs to call NN's 
> getFileStatus() to get the size of the linked hfile. Assume that one such 
> call takes 20ms, 20ms * 100 = 6 hours. 
> To avoid this overhead, we want to add an option so that restore_snapshot can 
> move mob files from archive dir to working dir. clone_snapshot is more 
> complicated as it can clone a snapshot to a different table so moving that 
> can destroy the snapshot. No option will be added for clone_snapshot.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-16538) Version mismatch in HBaseConfiguration.checkDefaultsVersion

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-16538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199309#comment-16199309
 ] 

Hudson commented on HBASE-16538:


FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #301 (See 
[https://builds.apache.org/job/HBase-1.3-JDK7/301/])
Amend HBASE-16538 Changes the way version information is stored during 
(apurtell: rev 8cace342f3e4f94f704f43931b8e86abf8b1f309)
* (edit) hbase-common/src/saveVersion.sh


> Version mismatch in HBaseConfiguration.checkDefaultsVersion
> ---
>
> Key: HBASE-16538
> URL: https://issues.apache.org/jira/browse/HBASE-16538
> Project: HBase
>  Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
>  Labels: configuration, test-failure
> Fix For: 2.0.0, 1.0.4, 1.4.0, 0.98.22, 1.1.7, 1.2.4
>
> Attachments: HBASE-16538-addendum.patch, 
> HBASE-16538.master.001.patch, HBASE-16538.master.002.patch
>
>
> {noformat}
> org.apache.hadoop.hbase.procedure2.TestYieldProcedures
> testYieldEachExecutionStep(org.apache.hadoop.hbase.procedure2.TestYieldProcedures)
>   Time elapsed: 0.255 sec  <<< ERROR!
> java.lang.RuntimeException: hbase-default.xml file seems to be for an older 
> version of HBase (2.0.0-SNAPSHOT), this version is Unknown
>   at 
> org.apache.hadoop.hbase.HBaseConfiguration.checkDefaultsVersion(HBaseConfiguration.java:73)
>   at 
> org.apache.hadoop.hbase.HBaseConfiguration.addHbaseResources(HBaseConfiguration.java:83)
>   at 
> org.apache.hadoop.hbase.HBaseConfiguration.create(HBaseConfiguration.java:98)
>   at 
> org.apache.hadoop.hbase.HBaseCommonTestingUtility.(HBaseCommonTestingUtility.java:46)
>   at 
> org.apache.hadoop.hbase.procedure2.TestYieldProcedures.setUp(TestYieldProcedures.java:63)
> {noformat}
> (Exact test is not important)
> Reference run:
> https://builds.apache.org/view/All/job/HBase-Trunk_matrix/jdk=JDK%201.8%20(latest),label=yahoo-not-h2/1515/console



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18981) Address issues found by error-prone in hbase-client

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199302#comment-16199302
 ] 

Hadoop QA commented on HBASE-18981:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 18m 
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
44s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
13s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
40m 12s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
53s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 9s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 75m 36s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18981 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12891327/HBASE-18981.patch |
| Optional Tests |  asflicense  shadedjars  javac  javadoc  unit  findbugs  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux d8c906b9b3e6 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 73b6bd0 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9029/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9029/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was 

[jira] [Commented] (HBASE-18552) Backport the server side change in HBASE-18489 to branch-1

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199287#comment-16199287
 ] 

Hadoop QA commented on HBASE-18552:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
13s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
 8s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
32s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
36s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
55s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
17s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
40s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m  
3s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
28s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
33s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
34s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
35s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
24s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
25m 40s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3. 
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
34s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}375m 33s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  3m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}421m 53s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 
|
|   | hadoop.hbase.client.TestAdmin2 |
| Timed out junit tests | 

[jira] [Commented] (HBASE-18867) maven enforcer plugin needs update to work with jdk9

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199278#comment-16199278
 ] 

Andrew Purtell commented on HBASE-18867:


+1 for branch-1 and branch-1.4

> maven enforcer plugin needs update to work with jdk9
> 
>
> Key: HBASE-18867
> URL: https://issues.apache.org/jira/browse/HBASE-18867
> Project: HBase
>  Issue Type: Sub-task
>  Components: build
>Affects Versions: 2.0.0-alpha-3
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13
>
> Attachments: HBASE-18867.0.patch, HBASE-18867.branch-1.3.patch, 
> HBASE-18867.branch-1.patch
>
>
> build fails under jdk9, even when targeting java 8
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-enforcer-plugin:1.4:enforce 
> (min-maven-min-java-banned-xerces) on project hbase: Execution 
> min-maven-min-java-banned-xerces of goal 
> org.apache.maven.plugins:maven-enforcer-plugin:1.4:enforce failed: An API 
> incompatibility was encountered while executing 
> org.apache.maven.plugins:maven-enforcer-plugin:1.4:enforce: 
> java.lang.ExceptionInInitializerError: null
> [ERROR] -
> [ERROR] realm =plugin>org.apache.maven.plugins:maven-enforcer-plugin:1.4
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> [ERROR] urls[0] = 
> file:/Users/busbey/.m2/repository/org/apache/maven/plugins/maven-enforcer-plugin/1.4/maven-enforcer-plugin-1.4.jar
> [ERROR] urls[1] = 
> file:/Users/busbey/.m2/repository/org/codehaus/mojo/extra-enforcer-rules/1.0-beta-6/extra-enforcer-rules-1.0-beta-6.jar
> [ERROR] urls[2] = 
> file:/Users/busbey/.m2/repository/org/apache/maven/shared/maven-dependency-tree/2.2/maven-dependency-tree-2.2.jar
> [ERROR] urls[3] = 
> file:/Users/busbey/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar
> [ERROR] urls[4] = 
> file:/Users/busbey/.m2/repository/org/eclipse/aether/aether-util/0.9.0.M2/aether-util-0.9.0.M2.jar
> [ERROR] urls[5] = 
> file:/Users/busbey/.m2/repository/org/apache/maven/shared/maven-common-artifact-filters/1.4/maven-common-artifact-filters-1.4.jar
> [ERROR] urls[6] = 
> file:/Users/busbey/.m2/repository/com/ibm/icu/icu4j/56.1/icu4j-56.1.jar
> [ERROR] urls[7] = 
> file:/Users/busbey/.m2/repository/backport-util-concurrent/backport-util-concurrent/3.1/backport-util-concurrent-3.1.jar
> [ERROR] urls[8] = 
> file:/Users/busbey/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.11/plexus-interpolation-1.11.jar
> [ERROR] urls[9] = 
> file:/Users/busbey/.m2/repository/org/slf4j/slf4j-jdk14/1.5.6/slf4j-jdk14-1.5.6.jar
> [ERROR] urls[10] = 
> file:/Users/busbey/.m2/repository/org/slf4j/jcl-over-slf4j/1.5.6/jcl-over-slf4j-1.5.6.jar
> [ERROR] urls[11] = 
> file:/Users/busbey/.m2/repository/org/apache/maven/reporting/maven-reporting-api/2.2.1/maven-reporting-api-2.2.1.jar
> [ERROR] urls[12] = 
> file:/Users/busbey/.m2/repository/org/apache/maven/doxia/doxia-sink-api/1.1/doxia-sink-api-1.1.jar
> [ERROR] urls[13] = 
> file:/Users/busbey/.m2/repository/org/apache/maven/doxia/doxia-logging-api/1.1/doxia-logging-api-1.1.jar
> [ERROR] urls[14] = 
> file:/Users/busbey/.m2/repository/commons-cli/commons-cli/1.2/commons-cli-1.2.jar
> [ERROR] urls[15] = 
> file:/Users/busbey/.m2/repository/org/codehaus/plexus/plexus-interactivity-api/1.0-alpha-4/plexus-interactivity-api-1.0-alpha-4.jar
> [ERROR] urls[16] = 
> file:/Users/busbey/.m2/repository/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar
> [ERROR] urls[17] = 
> file:/Users/busbey/.m2/repository/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar
> [ERROR] urls[18] = 
> file:/Users/busbey/.m2/repository/org/codehaus/plexus/plexus-utils/3.0.20/plexus-utils-3.0.20.jar
> [ERROR] urls[19] = 
> file:/Users/busbey/.m2/repository/commons-lang/commons-lang/2.3/commons-lang-2.3.jar
> [ERROR] urls[20] = 
> file:/Users/busbey/.m2/repository/org/apache/maven/enforcer/enforcer-api/1.4/enforcer-api-1.4.jar
> [ERROR] urls[21] = 
> file:/Users/busbey/.m2/repository/org/apache/maven/enforcer/enforcer-rules/1.4/enforcer-rules-1.4.jar
> [ERROR] urls[22] = 
> file:/Users/busbey/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4.jar
> [ERROR] urls[23] = 
> file:/Users/busbey/.m2/repository/org/codehaus/plexus/plexus-i18n/1.0-beta-6/plexus-i18n-1.0-beta-6.jar
> [ERROR] urls[24] = 
> file:/Users/busbey/.m2/repository/org/apache/maven/plugin-testing/maven-plugin-testing-harness/1.3/maven-plugin-testing-harness-1.3.jar
> [ERROR] urls[25] = 
> file:/Users/busbey/.m2/repository/org/codehaus/plexus/plexus-archiver/2.2/plexus-archiver-2.2.jar
> [ERROR] urls[26] = 
> 

[jira] [Updated] (HBASE-18981) Address issues found by error-prone in hbase-client

[Mike Drob (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Drob updated HBASE-18981:
--
   Resolution: Fixed
Fix Version/s: (was: 2.0.0-beta-1)
   2.0.0-alpha-4
   Status: Resolved  (was: Patch Available)

> Address issues found by error-prone in hbase-client
> ---
>
> Key: HBASE-18981
> URL: https://issues.apache.org/jira/browse/HBASE-18981
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Mike Drob
>Assignee: Mike Drob
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18981.patch
>
>
> I thought this was something that we would already catch in findbugs, but 
> maybe not?
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile 
> (default-compile) on project hbase-client: Compilation failure
> [ERROR] 
> /Users/mdrob/IdeaProjects/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:[2476,5]
>  [MissingCasesInEnumSwitch] Non-exhaustive switch; either add a default or 
> handle the remaining cases: GLOBAL_BYPASS
> [ERROR] (see http://errorprone.info/bugpattern/MissingCasesInEnumSwitch)
> {noformat}
> cc: [~elserj], this looks like it is part of quota code. I'm happy to add a 
> trivial patch to error on the missing case, but want somebody with more 
> contextual knowledge to look at it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18981) Address issues found by error-prone in hbase-client

[Mike Drob (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Drob updated HBASE-18981:
--
Priority: Trivial  (was: Major)

> Address issues found by error-prone in hbase-client
> ---
>
> Key: HBASE-18981
> URL: https://issues.apache.org/jira/browse/HBASE-18981
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Trivial
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18981.patch
>
>
> I thought this was something that we would already catch in findbugs, but 
> maybe not?
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile 
> (default-compile) on project hbase-client: Compilation failure
> [ERROR] 
> /Users/mdrob/IdeaProjects/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:[2476,5]
>  [MissingCasesInEnumSwitch] Non-exhaustive switch; either add a default or 
> handle the remaining cases: GLOBAL_BYPASS
> [ERROR] (see http://errorprone.info/bugpattern/MissingCasesInEnumSwitch)
> {noformat}
> cc: [~elserj], this looks like it is part of quota code. I'm happy to add a 
> trivial patch to error on the missing case, but want somebody with more 
> contextual knowledge to look at it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18980) Address issues found by error-prone in hbase-hadoop2-compat

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199259#comment-16199259
 ] 

Hudson commented on HBASE-18980:


SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #231 (See 
[https://builds.apache.org/job/HBase-1.2-JDK8/231/])
HBASE-18980 Suppress SelfComparison error in tests (mdrob: rev 
fd8d4e24ba50683c0e9243c850dc24b46c8a4a1c)
* (edit) 
hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java


> Address issues found by error-prone in hbase-hadoop2-compat
> ---
>
> Key: HBASE-18980
> URL: https://issues.apache.org/jira/browse/HBASE-18980
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Trivial
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 1.1.13, 2.0.0-alpha-4
>
> Attachments: HBASE-18980.patch
>
>
> There are a few instances of self comparison found in hadoop2-compat module. 
> Because they are in tests specifically for verifying compareTo, I think 
> they're ok to keep and we should suppress them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18981) Address issues found by error-prone in hbase-client

[Josh Elser (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199251#comment-16199251
 ] 

Josh Elser commented on HBASE-18981:


LGTM

> Address issues found by error-prone in hbase-client
> ---
>
> Key: HBASE-18981
> URL: https://issues.apache.org/jira/browse/HBASE-18981
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Mike Drob
>Assignee: Mike Drob
> Fix For: 3.0.0, 2.0.0-beta-1
>
> Attachments: HBASE-18981.patch
>
>
> I thought this was something that we would already catch in findbugs, but 
> maybe not?
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile 
> (default-compile) on project hbase-client: Compilation failure
> [ERROR] 
> /Users/mdrob/IdeaProjects/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:[2476,5]
>  [MissingCasesInEnumSwitch] Non-exhaustive switch; either add a default or 
> handle the remaining cases: GLOBAL_BYPASS
> [ERROR] (see http://errorprone.info/bugpattern/MissingCasesInEnumSwitch)
> {noformat}
> cc: [~elserj], this looks like it is part of quota code. I'm happy to add a 
> trivial patch to error on the missing case, but want somebody with more 
> contextual knowledge to look at it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18979) TestInterfaceAudienceAnnotations fails on branch-1.3

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199240#comment-16199240
 ] 

Andrew Purtell commented on HBASE-18979:


This was committed to branch-1 but not branch-1.3

commit abbb36f625fb4dc021eff8969c1666567ef93f08
Author: Andrew Purtell 
Date:   Fri Sep 2 19:51:33 2016 -0700

Amend HBASE-16538 Changes the way version information is stored during build

Generated Version class needs an interface audience annotation

HBASE-16538 was backported to branch-1.3 without the addendum by

commit af9de6ed8b3b33d0f87103d98b194bd7e9ddb5d5
Author: Ashish Singhi 
Date:   Thu Oct 5 21:47:35 2017 +0530

HBASE-18939 Backport HBASE-16538 to branch-1.3

Signed-off-by: Ashish Singhi 

Picked the addendum to branch-1.3. 

> TestInterfaceAudienceAnnotations fails on branch-1.3
> 
>
> Key: HBASE-18979
> URL: https://issues.apache.org/jira/browse/HBASE-18979
> Project: HBase
>  Issue Type: Test
>  Components: Client
>Reporter: Mike Drob
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 1.3.2
>
>
> {noformat}
> 2017-10-10 09:15:15,609 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): These are the classes that DO 
> NOT have @InterfaceAudience annotation:
> 2017-10-10 09:15:15,609 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(256): class 
> org.apache.hadoop.hbase.Version
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (HBASE-18979) TestInterfaceAudienceAnnotations fails on branch-1.3

[Andrew Purtell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell resolved HBASE-18979.

   Resolution: Fixed
Fix Version/s: (was: 1.1.13)
   (was: 1.2.7)
   (was: 1.5.0)
   (was: 1.4.0)
   (was: 3.0.0)
   (was: 2.0.0)

> TestInterfaceAudienceAnnotations fails on branch-1.3
> 
>
> Key: HBASE-18979
> URL: https://issues.apache.org/jira/browse/HBASE-18979
> Project: HBase
>  Issue Type: Test
>  Components: Client
>Reporter: Mike Drob
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 1.3.2
>
>
> {noformat}
> 2017-10-10 09:15:15,609 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): These are the classes that DO 
> NOT have @InterfaceAudience annotation:
> 2017-10-10 09:15:15,609 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(256): class 
> org.apache.hadoop.hbase.Version
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18981) Address issues found by error-prone in hbase-client

[Mike Drob (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Drob updated HBASE-18981:
--
Fix Version/s: 3.0.0

> Address issues found by error-prone in hbase-client
> ---
>
> Key: HBASE-18981
> URL: https://issues.apache.org/jira/browse/HBASE-18981
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Mike Drob
>Assignee: Mike Drob
> Fix For: 3.0.0, 2.0.0-beta-1
>
> Attachments: HBASE-18981.patch
>
>
> I thought this was something that we would already catch in findbugs, but 
> maybe not?
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile 
> (default-compile) on project hbase-client: Compilation failure
> [ERROR] 
> /Users/mdrob/IdeaProjects/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:[2476,5]
>  [MissingCasesInEnumSwitch] Non-exhaustive switch; either add a default or 
> handle the remaining cases: GLOBAL_BYPASS
> [ERROR] (see http://errorprone.info/bugpattern/MissingCasesInEnumSwitch)
> {noformat}
> cc: [~elserj], this looks like it is part of quota code. I'm happy to add a 
> trivial patch to error on the missing case, but want somebody with more 
> contextual knowledge to look at it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18981) Address issues found by error-prone in hbase-client

[Mike Drob (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Drob updated HBASE-18981:
--
Attachment: HBASE-18981.patch

Thanks, Josh! Attaching the trivial fix.

> Address issues found by error-prone in hbase-client
> ---
>
> Key: HBASE-18981
> URL: https://issues.apache.org/jira/browse/HBASE-18981
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Mike Drob
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18981.patch
>
>
> I thought this was something that we would already catch in findbugs, but 
> maybe not?
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile 
> (default-compile) on project hbase-client: Compilation failure
> [ERROR] 
> /Users/mdrob/IdeaProjects/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:[2476,5]
>  [MissingCasesInEnumSwitch] Non-exhaustive switch; either add a default or 
> handle the remaining cases: GLOBAL_BYPASS
> [ERROR] (see http://errorprone.info/bugpattern/MissingCasesInEnumSwitch)
> {noformat}
> cc: [~elserj], this looks like it is part of quota code. I'm happy to add a 
> trivial patch to error on the missing case, but want somebody with more 
> contextual knowledge to look at it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18981) Address issues found by error-prone in hbase-client

[Mike Drob (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Drob updated HBASE-18981:
--
Assignee: Mike Drob
  Status: Patch Available  (was: Open)

> Address issues found by error-prone in hbase-client
> ---
>
> Key: HBASE-18981
> URL: https://issues.apache.org/jira/browse/HBASE-18981
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Mike Drob
>Assignee: Mike Drob
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18981.patch
>
>
> I thought this was something that we would already catch in findbugs, but 
> maybe not?
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile 
> (default-compile) on project hbase-client: Compilation failure
> [ERROR] 
> /Users/mdrob/IdeaProjects/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:[2476,5]
>  [MissingCasesInEnumSwitch] Non-exhaustive switch; either add a default or 
> handle the remaining cases: GLOBAL_BYPASS
> [ERROR] (see http://errorprone.info/bugpattern/MissingCasesInEnumSwitch)
> {noformat}
> cc: [~elserj], this looks like it is part of quota code. I'm happy to add a 
> trivial patch to error on the missing case, but want somebody with more 
> contextual knowledge to look at it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18980) Address issues found by error-prone in hbase-hadoop2-compat

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199198#comment-16199198
 ] 

Hudson commented on HBASE-18980:


SUCCESS: Integrated in Jenkins build HBase-1.1-JDK7 #1920 (See 
[https://builds.apache.org/job/HBase-1.1-JDK7/1920/])
HBASE-18980 Suppress SelfComparison error in tests (mdrob: rev 
1e391bb868bc73027398be2d1e6f9ac8ee2e7a78)
* (edit) 
hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java


> Address issues found by error-prone in hbase-hadoop2-compat
> ---
>
> Key: HBASE-18980
> URL: https://issues.apache.org/jira/browse/HBASE-18980
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Trivial
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 1.1.13, 2.0.0-alpha-4
>
> Attachments: HBASE-18980.patch
>
>
> There are a few instances of self comparison found in hadoop2-compat module. 
> Because they are in tests specifically for verifying compareTo, I think 
> they're ok to keep and we should suppress them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18970) The version of jruby we use now can't handle the ctrl-m

[Mike Drob (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199186#comment-16199186
 ] 

Mike Drob commented on HBASE-18970:
---

[~chia7712] - the JRuby team suggested that we can exec out to stty from jirb 
and I confirmed that it worked locally on a small test case.

So sometime before getting user input (maybe on init) we need to run {{`stty 
icrnl`}}. I'll try to get a PR into JRuby too and get this into a release, but 
if that takes too long we can hack it ourselves.

> The version of jruby we use now can't handle the ctrl-m
> ---
>
> Key: HBASE-18970
> URL: https://issues.apache.org/jira/browse/HBASE-18970
> Project: HBase
>  Issue Type: Task
>  Components: shell
>Reporter: Chia-Ping Tsai
> Fix For: 2.0.0-beta-1
>
>
> case 1: press enter
> {code}
> hbase(main):002:0> disable_all 'chia(.*)'
> chia_1
>   
>
> Disable the above 1 tables (y/n)?
> y^M
> {code}
> case 2: press ctrl-j
> {code}
> hbase(main):001:0> disable_all 'chia(.*)'
> chia_1
>   
>
> Disable the above 1 tables (y/n)?
> y^J1 tables successfully disabled
> Took 5.0059 seconds  
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18980) Address issues found by error-prone in hbase-hadoop2-compat

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199188#comment-16199188
 ] 

Hudson commented on HBASE-18980:


SUCCESS: Integrated in Jenkins build HBase-1.1-JDK8 #2003 (See 
[https://builds.apache.org/job/HBase-1.1-JDK8/2003/])
HBASE-18980 Suppress SelfComparison error in tests (mdrob: rev 
1e391bb868bc73027398be2d1e6f9ac8ee2e7a78)
* (edit) 
hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java


> Address issues found by error-prone in hbase-hadoop2-compat
> ---
>
> Key: HBASE-18980
> URL: https://issues.apache.org/jira/browse/HBASE-18980
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Trivial
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 1.1.13, 2.0.0-alpha-4
>
> Attachments: HBASE-18980.patch
>
>
> There are a few instances of self comparison found in hadoop2-compat module. 
> Because they are in tests specifically for verifying compareTo, I think 
> they're ok to keep and we should suppress them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18960) A few bug fixes and minor improvements around batchMutate()

[Umesh Agashe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Umesh Agashe updated HBASE-18960:
-
Attachment: hbase-18960.master.005.patch

retry

> A few bug fixes and minor improvements around batchMutate()
> ---
>
> Key: HBASE-18960
> URL: https://issues.apache.org/jira/browse/HBASE-18960
> Project: HBase
>  Issue Type: Sub-task
>  Components: regionserver
>Affects Versions: 2.0.0-alpha-3
>Reporter: Umesh Agashe
>Assignee: Umesh Agashe
> Fix For: 2.0.0-alpha-4
>
> Attachments: hbase-18960.master.001.patch, 
> hbase-18960.master.002.patch, hbase-18960.master.003.patch, 
> hbase-18960.master.004.patch, hbase-18960.master.005.patch, 
> hbase-18960.master.005.patch
>
>
> Batch validation and preparation can be done before we start iterating over 
> batch operations for writes. observedExceptions, familyCellMaps and 
> durability can be stored in BatchOperation as they are batch wide. For all 
> operations, done by preBatchMutate() CP hook, operation status needs to be 
> SUCCESS. Modify and use doWALAppend() from doMiniBatchMutate().



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18108) Procedure WALs are archived but not cleaned; fix

[Peter Somogyi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-18108:
--
Attachment: HBASE-18108.master.003.patch

> Procedure WALs are archived but not cleaned; fix
> 
>
> Key: HBASE-18108
> URL: https://issues.apache.org/jira/browse/HBASE-18108
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Peter Somogyi
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-18108.master.001.patch, 
> HBASE-18108.master.002.patch, HBASE-18108.master.003.patch
>
>
> The Procedure WAL files used to be deleted when done. HBASE-14614 keeps them 
> around in case issue but what is missing is a GC for no-longer-needed WAL 
> files. This one is pretty important.
> From WALProcedureStore Cleaner TODO in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.r2pc835nb7vi



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)