[jira] [Commented] (HBASE-19325) Pass a list of server name to postClearDeadServers
[ https://issues.apache.org/jira/browse/HBASE-19325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266474#comment-16266474 ] Chia-Ping Tsai commented on HBASE-19325: {code} 13:52:18 -1 overall 13:52:18 13:52:18 _ _ __ 13:52:18 | ___|_ _(_) |_ _ _ __ ___| | 13:52:18 | |_ / _` | | | | | | '__/ _ \ | 13:52:18 | _| (_| | | | |_| | | | __/_| 13:52:18 |_| \__,_|_|_|\__,_|_| \___(_) 13:52:18 13:52:18 13:52:18 13:52:18 | Vote | Subsystem | Runtime | Comment 13:52:18 13:52:18 | | || Prechecks 13:52:18 | +1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. 13:52:18 | +1 |@author | 0m 0s | The patch does not contain any @author 13:52:18 | | || tags. 13:52:18 | +1 | test4tests | 0m 0s | The patch appears to include 1 new or 13:52:18 | | || modified test files. 13:52:18 | | || branch-1 Compile Tests 13:52:18 | 0 | mvndep | 6m 1s | Maven dependency ordering for branch 13:52:18 | +1 | mvninstall | 1m 2s | branch-1 passed 13:52:18 | +1 |compile | 0m 25s | branch-1 passed 13:52:18 | +1 | checkstyle | 0m 50s | branch-1 passed 13:52:18 | 0 | findbugs | 0m 57s | hbase-server in branch-1 has 1 extant 13:52:18 | | || Findbugs warnings. 13:52:18 | +1 |javadoc | 0m 32s | branch-1 passed 13:52:18 | | || Patch Compile Tests 13:52:18 | 0 | mvndep | 0m 6s | Maven dependency ordering for patch 13:52:18 | +1 | mvninstall | 0m 29s | the patch passed 13:52:18 | +1 |compile | 0m 25s | the patch passed 13:52:18 | +1 | javac | 0m 25s | the patch passed 13:52:19 | +1 | checkstyle | 0m 37s | the patch passed 13:52:19 | +1 | whitespace | 0m 0s | The patch has no whitespace issues. 13:52:19 | +1 |hadoopcheck | 8m 38s | The patch does not cause any errors 13:52:19 | | || with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 13:52:19 | | || 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. 13:52:19 | +1 | findbugs | 1m 17s | the patch passed 13:52:19 | +1 |javadoc | 0m 18s | the patch passed 13:52:19 | | || Other Tests 13:52:19 | -1 | unit | 80m 29s | hbase-server in the patch failed. 13:52:19 | +1 | unit | 3m 58s | hbase-rsgroup in the patch passed. 13:52:19 | +1 | asflicense | 0m 19s | The patch does not generate ASF License 13:52:19 | | || warnings. 13:52:19 | | | 107m 21s | 13:52:19 13:52:19 13:52:19 Reason | Tests 13:52:19 Failed junit tests | hadoop.hbase.client.TestHTableMultiplexerFlushCache 13:52:19 | hadoop.hbase.replication.TestReplicationSmallTests 13:52:19 | hadoop.hbase.client.TestMetaWithReplicas 13:52:19 | hadoop.hbase.regionserver.TestEndToEndSplitTransaction 13:52:19 | hadoop.hbase.mapreduce.TestMultithreadedTableMapper 13:52:19 | hadoop.hbase.regionserver.TestCompactionInDeadRegionServer 13:52:19 13:52:19 13:52:19 || Subsystem || Report/Notes || 13:52:19 13:52:19 | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | 13:52:19 | uname | Linux 2060d48154ce 4.10.0-38-generic #42-Ubuntu SMP Tue Oct 10 13:24:27 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | 13:52:19 | Build tool | maven | 13:52:19 | Personality | /script/yetus/precommit/personality/hbase.sh | 13:52:19 | git revision | branch-1 / 20d811121f | 13:52:19 | maven | version: Apache Maven 3.3.9 | 13:52:19 | Default Java | 1.8.0_131 | 13:52:19 | findbugs | v3.1.0-RC1 | 13:52:19 | unit | /patchprocess/patch-unit-hbase-server.txt | 13:52:19 | modules | C: hbase-server hbase-rsgroup U: . | 13:52:19 | Powered by | Apache Yetus 0.6.0 http://yetus.apache.org | {code} TestCompactionInDeadRegionServer is traced by HBASE-19056. TestMultithreadedTableMapper -> HBASE-19300 Others fail without the patch. Will commit it tomorrow if no objections. > Pass a list of server name to postClearDeadServers > -- > > Key: HBASE-19325 > URL: https://issues.apache.org/jira/browse/HBASE-19325 > Project: HBase > Issue Type: Bug >Affects Versions:
[jira] [Updated] (HBASE-19112) Suspect methods on Cell to be deprecated
[ https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-19112: --- Attachment: HBASE-19112_branch-2.patch Initial Patch for branch-2. Adds new APIs to RawCell and ExtendedCell Deprecates APIs in Cell. Introduces RawCellBuilder, RawCellBuilderFactory and RawCellBuilderImpl. This builder just accepts a list of tags and cells are built using it. and always by DEEP_COPY. I have not yet deprecated Put#add (Delete/append/increment) methods. Just an initial version so that we can see if we can create sub-tasks and submit patch in smaller chunks. > Suspect methods on Cell to be deprecated > > > Key: HBASE-19112 > URL: https://issues.apache.org/jira/browse/HBASE-19112 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Josh Elser >Assignee: ramkrishna.s.vasudevan >Priority: Blocker > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19112_branch-2.patch > > > [~chia7712] suggested on the [mailing > list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E] > that we have some methods on Cell which should be deprecated for removal: > * {{#getType()}} > * {{#getTimestamp()}} > * {{#getTag()}} > * {{#getSequenceId()}} > Let's make a pass over these (and maybe the rest) to make sure that there > aren't others which are either implementation details or methods returning > now-private-marked classes. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19349) Introduce wrong version depencency of servlet-api jar
[ https://issues.apache.org/jira/browse/HBASE-19349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19349: --- Description: Build a tarball. {code} mvn -DskipTests clean install && mvn -DskipTests package assembly:single tar zxvf hbase-2.0.0-beta-1-SNAPSHOT-bin.tar.gz {code} Then I found there is a servlet-api-2.5.jar in the lib directory. The right depencency should be javax.servlet-api-3.1.0.jar. Start a distributed cluster with this tarball. And got exception when access Master/RS info jsp. {code} 2017-11-27,10:02:05,066 WARN org.eclipse.jetty.server.HttpChannel: / java.lang.NoSuchMethodError: javax.servlet.http.HttpServletRequest.isAsyncSupported()Z at org.eclipse.jetty.server.ResourceService.sendData(ResourceService.java:689) at org.eclipse.jetty.server.ResourceService.doGet(ResourceService.java:294) at org.eclipse.jetty.servlet.DefaultServlet.doGet(DefaultServlet.java:458) at javax.servlet.http.HttpServlet.service(HttpServlet.java:707) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:841) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1650) at org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:113) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1374) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:533) {code} Try mvn depencency:tree but didn't find why servlet-api-2.5.jar was introduced. I download hbase-2.0.0-alpha4-bin.tar.gz and didn't find servlet-api-2.5.jar. And build a tar from hbase-2.0.0-alpha4-src.tar.gz and didn't find servlet-api-2.5.jar, too. So this may be introduced by recently commits. And should fix this when release 2.0.0-beta1. was: Build a tarball. {code} mvn -DskipTests clean install && mvn -DskipTests package assembly:single tar zxvf hbase-2.0.0-beta-1-SNAPSHOT-bin.tar.gz {code} Then I found there is a servlet-api-2.5.jar in the lib directory. Start a distributed cluster with this tarball. And got exception when access Master/RS info jsp. {code} 2017-11-27,10:02:05,066 WARN org.eclipse.jetty.server.HttpChannel: / java.lang.NoSuchMethodError: javax.servlet.http.HttpServletRequest.isAsyncSupported()Z at org.eclipse.jetty.server.ResourceService.sendData(ResourceService.java:689) at org.eclipse.jetty.server.ResourceService.doGet(ResourceService.java:294) at org.eclipse.jetty.servlet.DefaultServlet.doGet(DefaultServlet.java:458) at javax.servlet.http.HttpServlet.service(HttpServlet.java:707) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:841) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1650) at org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:113) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1374) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:533) {code} Try mvn
[jira] [Created] (HBASE-19349) Introduce wrong version depencency of servlet-api jar
Guanghao Zhang created HBASE-19349: -- Summary: Introduce wrong version depencency of servlet-api jar Key: HBASE-19349 URL: https://issues.apache.org/jira/browse/HBASE-19349 Project: HBase Issue Type: Bug Affects Versions: 2.0.0-beta-1 Reporter: Guanghao Zhang Fix For: 3.0.0, 2.0.0-beta-1 Build a tarball. {code} mvn -DskipTests clean install && mvn -DskipTests package assembly:single tar zxvf hbase-2.0.0-beta-1-SNAPSHOT-bin.tar.gz {code} Then I found there is a servlet-api-2.5.jar in the lib directory. Start a distributed cluster with this tarball. And got exception when access Master/RS info jsp. {code} 2017-11-27,10:02:05,066 WARN org.eclipse.jetty.server.HttpChannel: / java.lang.NoSuchMethodError: javax.servlet.http.HttpServletRequest.isAsyncSupported()Z at org.eclipse.jetty.server.ResourceService.sendData(ResourceService.java:689) at org.eclipse.jetty.server.ResourceService.doGet(ResourceService.java:294) at org.eclipse.jetty.servlet.DefaultServlet.doGet(DefaultServlet.java:458) at javax.servlet.http.HttpServlet.service(HttpServlet.java:707) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:841) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1650) at org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:113) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1374) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:533) {code} Try mvn depencency:tree but didn't find why servlet-api-2.5.jar was introduced. I download hbase-2.0.0-alpha4-bin.tar.gz and didn't find servlet-api-2.5.jar. And build a tar from hbase-2.0.0-alpha4-src.tar.gz and didn't find servlet-api-2.5.jar, too. So this may be introduced by recently commits. And should fix this when release 2.0.0-beta1. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19346) Use EventLoopGroup to create AsyncFSOutput
[ https://issues.apache.org/jira/browse/HBASE-19346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19346: -- Attachment: HBASE-19346-v1.patch Move the guess method to a separated class called SendBufSizePredictor. > Use EventLoopGroup to create AsyncFSOutput > -- > > Key: HBASE-19346 > URL: https://issues.apache.org/jira/browse/HBASE-19346 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19346-v1.patch, HBASE-19346.patch > > > So that we can use different event loop to manage the connections to > different datanodes. And since EventLoop itself is also an EventLoopGroup, we > could still use the event loop to create AsyncFSOutput so the logic of > AsyncFSWAL will not be broken. > Will open a new issue to modify AsyncFSWAL and finally we can use multiple > event loop. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19112) Suspect methods on Cell to be deprecated
[ https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266415#comment-16266415 ] ramkrishna.s.vasudevan commented on HBASE-19112: Thanks [~chia7712] First we need to create some sub tasks under this and address each of this so that we don have a bigger patch. As I said first I think lets add RawCell and other related APIs by deprecating the Cell APIs. Then we start addressing all other sub issues. Yes the question is do we have time before 2.0? > Suspect methods on Cell to be deprecated > > > Key: HBASE-19112 > URL: https://issues.apache.org/jira/browse/HBASE-19112 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Josh Elser >Assignee: ramkrishna.s.vasudevan >Priority: Blocker > Fix For: 2.0.0-beta-1 > > > [~chia7712] suggested on the [mailing > list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E] > that we have some methods on Cell which should be deprecated for removal: > * {{#getType()}} > * {{#getTimestamp()}} > * {{#getTag()}} > * {{#getSequenceId()}} > Let's make a pass over these (and maybe the rest) to make sure that there > aren't others which are either implementation details or methods returning > now-private-marked classes. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19331) Region start-key/end-key corruption in Hbase meta table
[ https://issues.apache.org/jira/browse/HBASE-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266388#comment-16266388 ] Anoop Sam John commented on HBASE-19331: bq.Every key that i inserted to table are long. hence why should there be a start/end key in HRegionInfo which is not long. The region splits are done by HBase. What HBase make sure is the rows fall in appropriate region boundaries. When there is a need for split, the split key is generated based on the mid index key so that we have a possibly 50:50 split. There can not be any guarantee on the region keys. That key has no strict relation to what RKs u write. If ur business need requires a strict long - long region boundary, u should pre create all the region in a table and disable split for this table. > Region start-key/end-key corruption in Hbase meta table > --- > > Key: HBASE-19331 > URL: https://issues.apache.org/jira/browse/HBASE-19331 > Project: HBase > Issue Type: Bug > Components: Region Assignment >Affects Versions: 0.98.8 > Environment: Reproduced on HBase 0.98.8 on hadoop-2 >Reporter: Shamith kumar > Attachments: TestSplit.java > > > when a region split happens on a key with trailing byte equals zero, the end > key of the first resulting region and and start key of the second resulting > region in meta table gets corrupted. > Here is the link to code to reproduce this issue > https://bitbucket.org/flytxt/hbase-meta-corruption-test > > *+Test Result+* > [INFO] --- > [INFO] T E S T S > [INFO] --- > [INFO] Running com.flytxt.HbaseRegionMetaTest > log4j:WARN No appenders could be found for logger > (org.apache.hadoop.metrics2.lib.MutableMetricsFactory). > log4j:WARN Please initialize the log4j system properly. > log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more > info. > 18:23:54.346 [main] INFO com.flytxt.HbaseRegionMetaTest - Dropping table > SAMPLE_TBL_1 > 18:23:56.094 [main] INFO com.flytxt.HbaseRegionMetaTest - Dropping table > SAMPLE_TBL_2 > 18:23:58.107 [main] INFO com.flytxt.HbaseRegionMetaTest - Creating new table > SAMPLE_TBL_1 > 18:23:58.658 [main] INFO com.flytxt.HbaseRegionMetaTest - Creating new table > SAMPLE_TBL_1 > 18:23:59.212 [main] INFO com.flytxt.HbaseRegionMetaTest - Starting puts to > table SAMPLE_TBL_1 > 18:24:00.046 [main] INFO com.flytxt.HbaseRegionMetaTest - Puts complete .. > lets split SAMPLE_TBL_1 > 18:24:00.500 [main] INFO com.flytxt.HbaseRegionMetaTest - Starting puts to > table SAMPLE_TBL_2 > 18:24:02.073 [main] INFO com.flytxt.HbaseRegionMetaTest - Puts complete .. > lets split SAMPLE_TBL_2 > 18:24:02.753 [main] INFO com.flytxt.HbaseRegionMetaTest - region split > complete .. Lets verify region infos for table SAMPLE_TBL_1 > 18:24:02.754 [main] INFO com.flytxt.HbaseRegionMetaTest - > === > 18:24:02.754 [main] INFO com.flytxt.HbaseRegionMetaTest - Region Name : > SAMPLE_TBL_1,,1511355240515.56c8fd8e42228c3c1ec71f9a4da65f5f. > 18:24:02.755 [main] INFO com.flytxt.HbaseRegionMetaTest - Region Id > :1511355240515 > 18:24:02.755 [main] INFO com.flytxt.HbaseRegionMetaTest - Region start key > :[] , Key length :0 > 18:24:02.755 [main] INFO com.flytxt.HbaseRegionMetaTest - Region end key : > [0, 0, 0, 0, 0, 19, -76] , Key length :7 > 18:24:02.755 [main] INFO com.flytxt.HbaseRegionMetaTest - > --- > 18:24:02.762 [main] INFO com.flytxt.HbaseRegionMetaTest - > === > 18:24:02.762 [main] INFO com.flytxt.HbaseRegionMetaTest - Region Name : > SAMPLE_TBL_1,\x00\x00\x00\x00\x00\x13\xB4,1511355240515.c06afed17b2a5c4fb54bacf704dd8a9e. > 18:24:02.762 [main] INFO com.flytxt.HbaseRegionMetaTest - Region Id > :1511355240515 > 18:24:02.762 [main] INFO com.flytxt.HbaseRegionMetaTest - Region start key > :[0, 0, 0, 0, 0, 19, -76] , Key length :7 > 18:24:02.763 [main] INFO com.flytxt.HbaseRegionMetaTest - Region end key : [] > , Key length :0 > 18:24:02.763 [main] INFO com.flytxt.HbaseRegionMetaTest - > --- > 18:24:03.005 [main] INFO com.flytxt.HbaseRegionMetaTest - region split > complete .. Lets verify region infos for table SAMPLE_TBL_2 > 18:24:03.006 [main] INFO com.flytxt.HbaseRegionMetaTest - > === > 18:24:03.006 [main] INFO com.flytxt.HbaseRegionMetaTest - Region Name : > SAMPLE_TBL_2,,1511355242363.0679851100e16aad005c743af618452e. > 18:24:03.006 [main] INFO com.flytxt.HbaseRegionMetaTest - Region Id > :1511355242363 > 18:24:03.007 [main] INFO
[jira] [Commented] (HBASE-19112) Suspect methods on Cell to be deprecated
[ https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266387#comment-16266387 ] Anoop Sam John commented on HBASE-19112: This looks to be a good overall plan.. Ya ideally we have to clean it up all and the server code path to work with RawCell rather than Cell. (Now Cell is flawing throughout). Not just RawCell , the ExtendedCell itself which is having the private methods. I believe we can make the byte[]/BB backed cell check and usage in a much better way then. But the big Q , do we have time for all these before 2.0? > Suspect methods on Cell to be deprecated > > > Key: HBASE-19112 > URL: https://issues.apache.org/jira/browse/HBASE-19112 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Josh Elser >Assignee: ramkrishna.s.vasudevan >Priority: Blocker > Fix For: 2.0.0-beta-1 > > > [~chia7712] suggested on the [mailing > list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E] > that we have some methods on Cell which should be deprecated for removal: > * {{#getType()}} > * {{#getTimestamp()}} > * {{#getTag()}} > * {{#getSequenceId()}} > Let's make a pass over these (and maybe the rest) to make sure that there > aren't others which are either implementation details or methods returning > now-private-marked classes. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-19347) Source Download misses the director hbase-native-client with respect to git tag
[ https://issues.apache.org/jira/browse/HBASE-19347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266034#comment-16266034 ] Ted Yu edited comment on HBASE-19347 at 11/27/17 5:16 AM: -- Edit: I forgot about HBASE-13088 was (Author: yuzhih...@gmail.com): lgtm [~ndimiduk]: FYI > Source Download misses the director hbase-native-client with respect to git > tag > --- > > Key: HBASE-19347 > URL: https://issues.apache.org/jira/browse/HBASE-19347 > Project: HBase > Issue Type: Bug >Affects Versions: 1.1.12 >Reporter: Olaf Flebbe > Attachments: 0001-Add-hbase-native-client-to-hbase-src.tgz.patch > > > In the download hbase-1.1.12-src.tar.gz the directory hbase-native-client is > missing. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19347) Source Download misses the director hbase-native-client with respect to git tag
[ https://issues.apache.org/jira/browse/HBASE-19347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-19347: Resolution: Won't Fix Fix Version/s: (was: 1.1.13) Status: Resolved (was: Patch Available) This is intentional, that stuff doesn't work. See HBASE-13088 and HBASE-19176 for more info. > Source Download misses the director hbase-native-client with respect to git > tag > --- > > Key: HBASE-19347 > URL: https://issues.apache.org/jira/browse/HBASE-19347 > Project: HBase > Issue Type: Bug >Affects Versions: 1.1.12 >Reporter: Olaf Flebbe > Attachments: 0001-Add-hbase-native-client-to-hbase-src.tgz.patch > > > In the download hbase-1.1.12-src.tar.gz the directory hbase-native-client is > missing. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19325) Pass a list of server name to postClearDeadServers
[ https://issues.apache.org/jira/browse/HBASE-19325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266360#comment-16266360 ] Ted Yu commented on HBASE-19325: lgtm > Pass a list of server name to postClearDeadServers > -- > > Key: HBASE-19325 > URL: https://issues.apache.org/jira/browse/HBASE-19325 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-beta-2 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Fix For: 1.4.0, 2.0.0-beta-1 > > Attachments: HBASE-19325.branch-1.001.patch, > HBASE-19325.branch-1.001.patch, HBASE-19325.branch-2.001.patch > > > Over on the tail of HBASE-18131. [~chia7712] said > {quote} > (Revisiting the AccessController remind me of this issue) > Could we remove the duplicate code on the server side? Why not pass a list of > server name to postClearDeadServers and postListDeadServers? > {quote} > The duplicate code has been removed in HBASE-19131.Now Pass a list of server > name to postClearDeadServers -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19346) Use EventLoopGroup to create AsyncFSOutput
[ https://issues.apache.org/jira/browse/HBASE-19346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19346: -- Status: Patch Available (was: Open) > Use EventLoopGroup to create AsyncFSOutput > -- > > Key: HBASE-19346 > URL: https://issues.apache.org/jira/browse/HBASE-19346 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19346.patch > > > So that we can use different event loop to manage the connections to > different datanodes. And since EventLoop itself is also an EventLoopGroup, we > could still use the event loop to create AsyncFSOutput so the logic of > AsyncFSWAL will not be broken. > Will open a new issue to modify AsyncFSWAL and finally we can use multiple > event loop. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19346) Use EventLoopGroup to create AsyncFSOutput
[ https://issues.apache.org/jira/browse/HBASE-19346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19346: -- Attachment: HBASE-19346.patch > Use EventLoopGroup to create AsyncFSOutput > -- > > Key: HBASE-19346 > URL: https://issues.apache.org/jira/browse/HBASE-19346 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19346.patch > > > So that we can use different event loop to manage the connections to > different datanodes. And since EventLoop itself is also an EventLoopGroup, we > could still use the event loop to create AsyncFSOutput so the logic of > AsyncFSWAL will not be broken. > Will open a new issue to modify AsyncFSWAL and finally we can use multiple > event loop. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19325) Pass a list of server name to postClearDeadServers
[ https://issues.apache.org/jira/browse/HBASE-19325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-19325: --- Fix Version/s: 2.0.0-beta-1 1.4.0 > Pass a list of server name to postClearDeadServers > -- > > Key: HBASE-19325 > URL: https://issues.apache.org/jira/browse/HBASE-19325 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-beta-2 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Fix For: 1.4.0, 2.0.0-beta-1 > > Attachments: HBASE-19325.branch-1.001.patch, > HBASE-19325.branch-1.001.patch, HBASE-19325.branch-2.001.patch > > > Over on the tail of HBASE-18131. [~chia7712] said > {quote} > (Revisiting the AccessController remind me of this issue) > Could we remove the duplicate code on the server side? Why not pass a list of > server name to postClearDeadServers and postListDeadServers? > {quote} > The duplicate code has been removed in HBASE-19131.Now Pass a list of server > name to postClearDeadServers -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19325) Pass a list of server name to postClearDeadServers
[ https://issues.apache.org/jira/browse/HBASE-19325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266347#comment-16266347 ] Chia-Ping Tsai commented on HBASE-19325: LGTM. Let me run the QA locally. Will attach the result asap. > Pass a list of server name to postClearDeadServers > -- > > Key: HBASE-19325 > URL: https://issues.apache.org/jira/browse/HBASE-19325 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-beta-2 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Attachments: HBASE-19325.branch-1.001.patch, > HBASE-19325.branch-1.001.patch, HBASE-19325.branch-2.001.patch > > > Over on the tail of HBASE-18131. [~chia7712] said > {quote} > (Revisiting the AccessController remind me of this issue) > Could we remove the duplicate code on the server side? Why not pass a list of > server name to postClearDeadServers and postListDeadServers? > {quote} > The duplicate code has been removed in HBASE-19131.Now Pass a list of server > name to postClearDeadServers -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19342) fix TestTableBasedReplicationSourceManagerImpl#testRemovePeerMetricsCleanup
[ https://issues.apache.org/jira/browse/HBASE-19342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266345#comment-16266345 ] Chia-Ping Tsai commented on HBASE-19342: The mini cluster created by TestTableBasedReplicationSourceManagerImpl will influence the global metrics so the patch make the following changes to stabilize the tests. # wait the replication table to be created. Otherwise, it is hard to assure the correct metrics in test case # ReplicationSourceManager add the peer to source list before updating the related metrics, and consequently the metrics we get may be stale even though the peer is in the source list. The patch add a condition check in {{startup}} as it is executed after the metrics update. I run the patch 50 times locally. All passed. Our QA has some trouble so I don't click the "submit patch" [~ashu210890] Would you please take a look? > fix TestTableBasedReplicationSourceManagerImpl#testRemovePeerMetricsCleanup > --- > > Key: HBASE-19342 > URL: https://issues.apache.org/jira/browse/HBASE-19342 > Project: HBase > Issue Type: Test >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Attachments: HBASE-19342.v0.patch > > > It is number one in [flaky > tests|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html]. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19348) Fix error-prone errors for branch-1
[ https://issues.apache.org/jira/browse/HBASE-19348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-19348: --- Attachment: HBASE-19348.branch-1.patch Most changes are copied from the master branch excluding the following one. {code} --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java @@ -55,6 +55,7 @@ import org.apache.hadoop.hbase.client.Table; import org.apache.hadoop.hbase.util.Bytes; import org.junit.AfterClass; import org.junit.BeforeClass; +import org.junit.Ignore; import org.junit.Test; import org.junit.experimental.categories.Category; @@ -232,7 +233,7 @@ public class TestMasterOperationsForRegionReplicas { } } - //@Test (TODO: enable when we have support for alter_table- HBASE-10361). + @Test public void testIncompleteMetaTableReplicaInformation() throws Exception { final TableName table = TableName.valueOf("fooTableTest1"); final int numRegions = 3; {code} Looped the test 19 times locally which it passed, so the test should be enabled. I will run the QA locally. > Fix error-prone errors for branch-1 > --- > > Key: HBASE-19348 > URL: https://issues.apache.org/jira/browse/HBASE-19348 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Fix For: 1.4.0 > > Attachments: HBASE-19348.branch-1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18619) Should we add a postOpenDeployTasks after open splited or merged region?
[ https://issues.apache.org/jira/browse/HBASE-18619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266341#comment-16266341 ] Jingyun Tian commented on HBASE-18619: -- [~apurtell] sorry for not catching up this issue recently. Of course I am interested. Will submitting a patch asap. > Should we add a postOpenDeployTasks after open splited or merged region? > > > Key: HBASE-18619 > URL: https://issues.apache.org/jira/browse/HBASE-18619 > Project: HBase > Issue Type: Bug > Components: Region Assignment >Affects Versions: 0.98.6, 1.4.0, 1.2.6, 1.1.11 >Reporter: Jingyun Tian >Assignee: Jingyun Tian > > I have a question that why we skip postOpenDeployTasks() when we not using zk > for assignment? > {code:java} > if (services != null) { > try { > if (useZKForAssignment) { > // add 2nd daughter first (see HBASE-4335) > services.postOpenDeployTasks(b); > } else if > (!services.reportRegionStateTransition(TransitionCode.SPLIT, > parent.getRegionInfo(), hri_a, hri_b)) { > throw new IOException("Failed to report split region to master: " > + parent.getRegionInfo().getShortNameToLog()); > } > // Should add it to OnlineRegions > services.addToOnlineRegions(b); > if (useZKForAssignment) { > services.postOpenDeployTasks(a); > } > services.addToOnlineRegions(a); > } catch (KeeperException ke) { > throw new IOException(ke); > } > } > {code} > It causes a new splitted region or new merged region will not compact their > reference files. Then if the normalizer thread want to split this region, it > will get stuck. > {code:java} > public boolean canSplit() { > this.lock.readLock().lock(); > try { > // Not split-able if we find a reference store file present in the > store. > boolean result = !hasReferences(); > if (!result && LOG.isDebugEnabled()) { > LOG.debug("Cannot split region due to reference files being there"); > } > return result; > } finally { > this.lock.readLock().unlock(); > } > } > {code} > According to the code, should we add a services.postOpenDeployTasks after > successfully _*reportRegionStateTransition(TransitionCode.SPLIT, > parent.getRegionInfo(), hri_a, hri_b)*_ ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19342) fix TestTableBasedReplicationSourceManagerImpl#testRemovePeerMetricsCleanup
[ https://issues.apache.org/jira/browse/HBASE-19342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-19342: --- Attachment: HBASE-19342.v0.patch > fix TestTableBasedReplicationSourceManagerImpl#testRemovePeerMetricsCleanup > --- > > Key: HBASE-19342 > URL: https://issues.apache.org/jira/browse/HBASE-19342 > Project: HBase > Issue Type: Test >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Attachments: HBASE-19342.v0.patch > > > It is number one in [flaky > tests|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html]. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19348) Fix error-prone errors for branch-1
[ https://issues.apache.org/jira/browse/HBASE-19348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266339#comment-16266339 ] Chia-Ping Tsai commented on HBASE-19348: I run the error-prone for branch-1, and then it still report some errors. Most of errors in master are fixed by HBASE-19240. Seems [~mdrob] doesn't backport all fixes to branch-1 as there are too many conflict. {quote} attached branch-1 patch which was only the parts the didn't have any conflicts. for anything that did have conflicts, i left the code unchanged on the assumption that because the base is different we will need to review it separately anyway. {quote} > Fix error-prone errors for branch-1 > --- > > Key: HBASE-19348 > URL: https://issues.apache.org/jira/browse/HBASE-19348 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Fix For: 1.4.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19344) improve asyncWAL by using Independent thread for netty #IO in FanOutOneBlockAsyncDFSOutput
[ https://issues.apache.org/jira/browse/HBASE-19344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266330#comment-16266330 ] Chance Li commented on HBASE-19344: --- Get it. > improve asyncWAL by using Independent thread for netty #IO in > FanOutOneBlockAsyncDFSOutput > --- > > Key: HBASE-19344 > URL: https://issues.apache.org/jira/browse/HBASE-19344 > Project: HBase > Issue Type: Sub-task > Components: wal >Affects Versions: 2.0.0-beta-1 >Reporter: Chance Li >Assignee: Chance Li > Fix For: 2.0.0 > > Attachments: HBASE-19344-branch2.patch, > HBASE-19344-branch2.patch.2.POC, wal-1-test-result.png, > wal-8-test-result.png, ycsb_result_apache20_async_wal.pdf > > > The logic now is that the netty #IO thread and asyncWal's thread are the same > one. > Improvement proposal: > 1, Split into two. > 2, All multiWal share the netty #IO thread pool. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19344) improve asyncWAL by using Independent thread for netty #IO in FanOutOneBlockAsyncDFSOutput
[ https://issues.apache.org/jira/browse/HBASE-19344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266315#comment-16266315 ] Duo Zhang commented on HBASE-19344: --- More protections are always welcomed. But you need to find a proper way to do it without making the code too ugly since it does not effect correctness... Thanks. > improve asyncWAL by using Independent thread for netty #IO in > FanOutOneBlockAsyncDFSOutput > --- > > Key: HBASE-19344 > URL: https://issues.apache.org/jira/browse/HBASE-19344 > Project: HBase > Issue Type: Sub-task > Components: wal >Affects Versions: 2.0.0-beta-1 >Reporter: Chance Li >Assignee: Chance Li > Fix For: 2.0.0 > > Attachments: HBASE-19344-branch2.patch, > HBASE-19344-branch2.patch.2.POC, wal-1-test-result.png, > wal-8-test-result.png, ycsb_result_apache20_async_wal.pdf > > > The logic now is that the netty #IO thread and asyncWal's thread are the same > one. > Improvement proposal: > 1, Split into two. > 2, All multiWal share the netty #IO thread pool. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19344) improve asyncWAL by using Independent thread for netty #IO in FanOutOneBlockAsyncDFSOutput
[ https://issues.apache.org/jira/browse/HBASE-19344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266309#comment-16266309 ] Chance Li commented on HBASE-19344: --- Thanks. sir Is it possible that we encounter this situation: #createWriterInstance is ok but #flush is fail. or is it necessary to do some protect on exception situation like this? It's maybe a tradeoff about boundary between with HDFS. > improve asyncWAL by using Independent thread for netty #IO in > FanOutOneBlockAsyncDFSOutput > --- > > Key: HBASE-19344 > URL: https://issues.apache.org/jira/browse/HBASE-19344 > Project: HBase > Issue Type: Sub-task > Components: wal >Affects Versions: 2.0.0-beta-1 >Reporter: Chance Li >Assignee: Chance Li > Fix For: 2.0.0 > > Attachments: HBASE-19344-branch2.patch, > HBASE-19344-branch2.patch.2.POC, wal-1-test-result.png, > wal-8-test-result.png, ycsb_result_apache20_async_wal.pdf > > > The logic now is that the netty #IO thread and asyncWal's thread are the same > one. > Improvement proposal: > 1, Split into two. > 2, All multiWal share the netty #IO thread pool. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19325) Pass a list of server name to postClearDeadServers
[ https://issues.apache.org/jira/browse/HBASE-19325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266307#comment-16266307 ] Andrew Purtell commented on HBASE-19325: Sure, we can get it in now before the 1.4.0 release. > Pass a list of server name to postClearDeadServers > -- > > Key: HBASE-19325 > URL: https://issues.apache.org/jira/browse/HBASE-19325 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-beta-2 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Attachments: HBASE-19325.branch-1.001.patch, > HBASE-19325.branch-1.001.patch, HBASE-19325.branch-2.001.patch > > > Over on the tail of HBASE-18131. [~chia7712] said > {quote} > (Revisiting the AccessController remind me of this issue) > Could we remove the duplicate code on the server side? Why not pass a list of > server name to postClearDeadServers and postListDeadServers? > {quote} > The duplicate code has been removed in HBASE-19131.Now Pass a list of server > name to postClearDeadServers -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19348) Fix error-prone errors for branch-1
[ https://issues.apache.org/jira/browse/HBASE-19348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266306#comment-16266306 ] Andrew Purtell commented on HBASE-19348: What is this about? Parent (HBASE-19239) has already been pushed to 1.4. > Fix error-prone errors for branch-1 > --- > > Key: HBASE-19348 > URL: https://issues.apache.org/jira/browse/HBASE-19348 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Fix For: 1.4.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19325) Pass a list of server name to postClearDeadServers
[ https://issues.apache.org/jira/browse/HBASE-19325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266304#comment-16266304 ] Guangxu Cheng commented on HBASE-19325: --- ping [~chia7712] [~yuzhih...@gmail.com] [~apurtell], Any other concerns? Thanks. > Pass a list of server name to postClearDeadServers > -- > > Key: HBASE-19325 > URL: https://issues.apache.org/jira/browse/HBASE-19325 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-beta-2 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng > Attachments: HBASE-19325.branch-1.001.patch, > HBASE-19325.branch-1.001.patch, HBASE-19325.branch-2.001.patch > > > Over on the tail of HBASE-18131. [~chia7712] said > {quote} > (Revisiting the AccessController remind me of this issue) > Could we remove the duplicate code on the server side? Why not pass a list of > server name to postClearDeadServers and postListDeadServers? > {quote} > The duplicate code has been removed in HBASE-19131.Now Pass a list of server > name to postClearDeadServers -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19344) improve asyncWAL by using Independent thread for netty #IO in FanOutOneBlockAsyncDFSOutput
[ https://issues.apache.org/jira/browse/HBASE-19344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266299#comment-16266299 ] Duo Zhang commented on HBASE-19344: --- There is a "hbase.wal.async.create.retries" config which limits the max retries when creating wal and default value is 10, which means if we fail 10 times when creating wal writer then we will throw the exception out and in LogRoller we will abort the RS. Thanks. > improve asyncWAL by using Independent thread for netty #IO in > FanOutOneBlockAsyncDFSOutput > --- > > Key: HBASE-19344 > URL: https://issues.apache.org/jira/browse/HBASE-19344 > Project: HBase > Issue Type: Sub-task > Components: wal >Affects Versions: 2.0.0-beta-1 >Reporter: Chance Li >Assignee: Chance Li > Fix For: 2.0.0 > > Attachments: HBASE-19344-branch2.patch, > HBASE-19344-branch2.patch.2.POC, wal-1-test-result.png, > wal-8-test-result.png, ycsb_result_apache20_async_wal.pdf > > > The logic now is that the netty #IO thread and asyncWal's thread are the same > one. > Improvement proposal: > 1, Split into two. > 2, All multiWal share the netty #IO thread pool. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19344) improve asyncWAL by using Independent thread for netty #IO in FanOutOneBlockAsyncDFSOutput
[ https://issues.apache.org/jira/browse/HBASE-19344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266298#comment-16266298 ] Chance Li commented on HBASE-19344: --- bq. And I haven’t understand the second question on sync fail, could you please explain a bit more? only suggestion, sir. When Fanout do #flush failed, AsyncFSWal will do #syncFailed putting the edit from #unackedAppends to #toWriteAppends, and rolling to new log, then redo all. maybe retry again and again util timeout by #blockOnSync. Maybe it's not enough for the AsyncWal. On this case which NN is ok, but DN has some exception, I think this can lead to create many many logs. And we can't enumerate all the exception. So maybe it's neccessary for 'define the bound'. > improve asyncWAL by using Independent thread for netty #IO in > FanOutOneBlockAsyncDFSOutput > --- > > Key: HBASE-19344 > URL: https://issues.apache.org/jira/browse/HBASE-19344 > Project: HBase > Issue Type: Sub-task > Components: wal >Affects Versions: 2.0.0-beta-1 >Reporter: Chance Li >Assignee: Chance Li > Fix For: 2.0.0 > > Attachments: HBASE-19344-branch2.patch, > HBASE-19344-branch2.patch.2.POC, wal-1-test-result.png, > wal-8-test-result.png, ycsb_result_apache20_async_wal.pdf > > > The logic now is that the netty #IO thread and asyncWal's thread are the same > one. > Improvement proposal: > 1, Split into two. > 2, All multiWal share the netty #IO thread pool. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19056) TestCompactionInDeadRegionServer is top of the flakies charts!
[ https://issues.apache.org/jira/browse/HBASE-19056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266296#comment-16266296 ] Ted Yu commented on HBASE-19056: Looped each test 19 times locally which all passed. > TestCompactionInDeadRegionServer is top of the flakies charts! > --- > > Key: HBASE-19056 > URL: https://issues.apache.org/jira/browse/HBASE-19056 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: Ted Yu > Attachments: 19056.v5.txt > > > The test came in recently as part of HBASE-17712 "Remove/Simplify the logic > of RegionScannerImpl.handleFileNotFound" > [~Apache9] when you have a chance, help me out. I was going to just remove > the test since it made no sense to me but then I saw you wrote it (smile). > When the region.compact(true); is called on the end, what is supposed to be > going on? > When I trace, the compact is not done because the Region is not writeEnabled > (we check if Region is writeEnabled down in Store before we go ahead and > compact). So, I thought the problem was that the region reference was stale > because it came from the rsToSuspend which had just been killed. > After a while, I figured that you intend the region reference to be stale so > you can try an append AFTER the WAL has been taken over by WAL splitter. > But the writeEnabled flag is set so compactions don't run. I tried unsetting > this flag and closed flags and but compaction won't run. > Was this your intent sir? If so, I'll work w/ it np. Just looking for > clarity. Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned HBASE-19340: -- Assignee: zhaoyuan > SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell > --- > > Key: HBASE-19340 > URL: https://issues.apache.org/jira/browse/HBASE-19340 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: zhaoyuan >Assignee: zhaoyuan > Fix For: 1.2.8 > > > Recently I wanna try to alter the split policy for a table on my cluster > which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute > of the HTable so I run the command in hbase shell console below. > alter 'tablex',SPLIT_POLICY => > 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy' > However, It gave the information like this and I confused > Unknown argument ignored: SPLIT_POLICY > Updating all regions with the new schema... > So I check the source code That admin.rb might miss the setting for this > argument . > htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if > arg[MAX_FILESIZE] > htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY] > ... > So I think it may be a bug ,is it? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266292#comment-16266292 ] zhaoyuan commented on HBASE-19340: -- Let me try to work on this patch~ > SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell > --- > > Key: HBASE-19340 > URL: https://issues.apache.org/jira/browse/HBASE-19340 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: zhaoyuan > Fix For: 1.2.8 > > > Recently I wanna try to alter the split policy for a table on my cluster > which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute > of the HTable so I run the command in hbase shell console below. > alter 'tablex',SPLIT_POLICY => > 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy' > However, It gave the information like this and I confused > Unknown argument ignored: SPLIT_POLICY > Updating all regions with the new schema... > So I check the source code That admin.rb might miss the setting for this > argument . > htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if > arg[MAX_FILESIZE] > htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY] > ... > So I think it may be a bug ,is it? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19096) Add RowMutions batch support in AsyncTable
[ https://issues.apache.org/jira/browse/HBASE-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266285#comment-16266285 ] Jerry He commented on HBASE-19096: -- Attached v2 to address comments from [~zghaobac] and [~stack]. Pushed down the looping to RequestConverter and refactored. > Add RowMutions batch support in AsyncTable > -- > > Key: HBASE-19096 > URL: https://issues.apache.org/jira/browse/HBASE-19096 > Project: HBase > Issue Type: Sub-task >Reporter: Jerry He >Assignee: Jerry He > Fix For: 2.0.0 > > Attachments: HBASE-19096-master-v2.patch, HBASE-19096-master.patch > > > Batch support for RowMutations has been added in the Table interface, but is > not in AsyncTable. This JIRA will add it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19096) Add RowMutions batch support in AsyncTable
[ https://issues.apache.org/jira/browse/HBASE-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jerry He updated HBASE-19096: - Attachment: HBASE-19096-master-v2.patch > Add RowMutions batch support in AsyncTable > -- > > Key: HBASE-19096 > URL: https://issues.apache.org/jira/browse/HBASE-19096 > Project: HBase > Issue Type: Sub-task >Reporter: Jerry He >Assignee: Jerry He > Fix For: 2.0.0 > > Attachments: HBASE-19096-master-v2.patch, HBASE-19096-master.patch > > > Batch support for RowMutations has been added in the Table interface, but is > not in AsyncTable. This JIRA will add it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19336) Improve rsgroup to allow assign all tables within a specified namespace by only writing namespace
[ https://issues.apache.org/jira/browse/HBASE-19336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266275#comment-16266275 ] xinxin fan commented on HBASE-19336: add ut for move_servers_namespaces_rsgroup and move_servers_tables_rsgroup > Improve rsgroup to allow assign all tables within a specified namespace by > only writing namespace > - > > Key: HBASE-19336 > URL: https://issues.apache.org/jira/browse/HBASE-19336 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Affects Versions: 2.0.0-alpha-4 >Reporter: xinxin fan >Assignee: xinxin fan > Attachments: HBASE-19336-master-V2.patch, > HBASE-19336-master-V3.patch, HBASE-19336-master-V4.patch, > HBASE-19336-master.patch > > > Currently, use can only assign tables within a namespace from one group to > another by writing all table names in move_tables_rsgroup command. Allowing > to assign all tables within a specifed namespace by only wirting namespace > name is useful. > Usage as follows: > {code:java} > hbase(main):055:0> move_namespaces_rsgroup 'dest_rsgroup',['ns1'] > Took 2.2211 seconds > {code} > {code:java} > hbase(main):051:0* move_servers_namespaces_rsgroup > 'dest_rsgroup',['hbase39.lt.163.org:60020'],['ns1','ns2'] > Took 15.3710 seconds > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19336) Improve rsgroup to allow assign all tables within a specified namespace by only writing namespace
[ https://issues.apache.org/jira/browse/HBASE-19336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinxin fan updated HBASE-19336: --- Attachment: HBASE-19336-master-V4.patch > Improve rsgroup to allow assign all tables within a specified namespace by > only writing namespace > - > > Key: HBASE-19336 > URL: https://issues.apache.org/jira/browse/HBASE-19336 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Affects Versions: 2.0.0-alpha-4 >Reporter: xinxin fan >Assignee: xinxin fan > Attachments: HBASE-19336-master-V2.patch, > HBASE-19336-master-V3.patch, HBASE-19336-master-V4.patch, > HBASE-19336-master.patch > > > Currently, use can only assign tables within a namespace from one group to > another by writing all table names in move_tables_rsgroup command. Allowing > to assign all tables within a specifed namespace by only wirting namespace > name is useful. > Usage as follows: > {code:java} > hbase(main):055:0> move_namespaces_rsgroup 'dest_rsgroup',['ns1'] > Took 2.2211 seconds > {code} > {code:java} > hbase(main):051:0* move_servers_namespaces_rsgroup > 'dest_rsgroup',['hbase39.lt.163.org:60020'],['ns1','ns2'] > Took 15.3710 seconds > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19204) branch-1.2 times out and is taking 6-7 hours to complete
[ https://issues.apache.org/jira/browse/HBASE-19204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19204: -- Attachment: HBASE-19204.branch-1.2.005.patch > branch-1.2 times out and is taking 6-7 hours to complete > > > Key: HBASE-19204 > URL: https://issues.apache.org/jira/browse/HBASE-19204 > Project: HBase > Issue Type: Umbrella > Components: test >Reporter: stack >Assignee: stack > Attachments: 19024.branch-1.2.004.patch, > HBASE-19024.branch-1.2.002.patch, HBASE-19024.branch-1.2.002.patch, > HBASE-19024.branch-1.2.003.patch, HBASE-19204.branch-1.2.005.patch, > HBASE-19204.branch-1.2.005.patch, HBASE-19204.branch-1.2.005.patch > > > Sean has been looking at tooling and infra. This Umbrellas is about looking > at actual tests. For example, running locally on dedicated machine I picked a > random test, TestPerColumnFamilyFlush. In my test run, it wrote 16M lines. It > seems to be having zk issues but it is catching interrupts and ignoring them > ([~carp84] fixed this in later versions over in HBASE-18441). > Let me try and do some fixup under this umbrella so we can get a 1.2.7 out > the door. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-19204) branch-1.2 times out and is taking 6-7 hours to complete
[ https://issues.apache.org/jira/browse/HBASE-19204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack reassigned HBASE-19204: - Assignee: stack > branch-1.2 times out and is taking 6-7 hours to complete > > > Key: HBASE-19204 > URL: https://issues.apache.org/jira/browse/HBASE-19204 > Project: HBase > Issue Type: Umbrella > Components: test >Reporter: stack >Assignee: stack > Attachments: 19024.branch-1.2.004.patch, > HBASE-19024.branch-1.2.002.patch, HBASE-19024.branch-1.2.002.patch, > HBASE-19024.branch-1.2.003.patch, HBASE-19204.branch-1.2.005.patch, > HBASE-19204.branch-1.2.005.patch > > > Sean has been looking at tooling and infra. This Umbrellas is about looking > at actual tests. For example, running locally on dedicated machine I picked a > random test, TestPerColumnFamilyFlush. In my test run, it wrote 16M lines. It > seems to be having zk issues but it is catching interrupts and ignoring them > ([~carp84] fixed this in later versions over in HBASE-18441). > Let me try and do some fixup under this umbrella so we can get a 1.2.7 out > the door. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19204) branch-1.2 times out and is taking 6-7 hours to complete
[ https://issues.apache.org/jira/browse/HBASE-19204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19204: -- Status: In Progress (was: Patch Available) > branch-1.2 times out and is taking 6-7 hours to complete > > > Key: HBASE-19204 > URL: https://issues.apache.org/jira/browse/HBASE-19204 > Project: HBase > Issue Type: Umbrella > Components: test >Reporter: stack > Attachments: 19024.branch-1.2.004.patch, > HBASE-19024.branch-1.2.002.patch, HBASE-19024.branch-1.2.002.patch, > HBASE-19024.branch-1.2.003.patch, HBASE-19204.branch-1.2.005.patch, > HBASE-19204.branch-1.2.005.patch > > > Sean has been looking at tooling and infra. This Umbrellas is about looking > at actual tests. For example, running locally on dedicated machine I picked a > random test, TestPerColumnFamilyFlush. In my test run, it wrote 16M lines. It > seems to be having zk issues but it is catching interrupts and ignoring them > ([~carp84] fixed this in later versions over in HBASE-18441). > Let me try and do some fixup under this umbrella so we can get a 1.2.7 out > the door. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19204) branch-1.2 times out and is taking 6-7 hours to complete
[ https://issues.apache.org/jira/browse/HBASE-19204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266257#comment-16266257 ] stack commented on HBASE-19204: --- [~chia7712] Yeah. Locally I installed azul openjdk 161 and the unit tests seemed to do much better. I wanted to get a 1.2 build done here so I had a log to compare too. Plan was to amend our docker file to add azul repo and install zulu-7, their jvm When I add debug, I get this: 23:37:31 Processing: HBASE-19204 23:37:31 [Sun Nov 26 23:37:31 UTC 2017 DEBUG]: jira_locate_patch: trying https://issues.apache.org/jira/browse/HBASE-19204 23:37:31 [Sun Nov 26 23:37:31 UTC 2017 DEBUG]: jira_http_fetch: https://issues.apache.org/jira/browse/HBASE-19204 23:37:31 [Sun Nov 26 23:37:31 UTC 2017 DEBUG]: jira_http_fetch: https://issues.apache.org/jira/browse/HBASE-19204 returned 4xx status code. Maybe incorrect username/password? 23:37:31 [Sun Nov 26 23:37:31 UTC 2017 DEBUG]: jira_locate_patch: not a JIRA. 23:37:32 [Sun Nov 26 23:37:32 UTC 2017 DEBUG]: generic_locate_patch: failed to download the patch. 23:37:32 ERROR: Unsure how to process HBASE-19204. ... Which is odd. Trying to figure it. [~misty] has to give you access to jenkins via the https://cwiki.apache.org/confluence/display/INFRA/Jenkins#Jenkins-HowdoIgetanaccount > branch-1.2 times out and is taking 6-7 hours to complete > > > Key: HBASE-19204 > URL: https://issues.apache.org/jira/browse/HBASE-19204 > Project: HBase > Issue Type: Umbrella > Components: test >Reporter: stack > Attachments: 19024.branch-1.2.004.patch, > HBASE-19024.branch-1.2.002.patch, HBASE-19024.branch-1.2.002.patch, > HBASE-19024.branch-1.2.003.patch, HBASE-19204.branch-1.2.005.patch, > HBASE-19204.branch-1.2.005.patch > > > Sean has been looking at tooling and infra. This Umbrellas is about looking > at actual tests. For example, running locally on dedicated machine I picked a > random test, TestPerColumnFamilyFlush. In my test run, it wrote 16M lines. It > seems to be having zk issues but it is catching interrupts and ignoring them > ([~carp84] fixed this in later versions over in HBASE-18441). > Let me try and do some fixup under this umbrella so we can get a 1.2.7 out > the door. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19056) TestCompactionInDeadRegionServer is top of the flakies charts!
[ https://issues.apache.org/jira/browse/HBASE-19056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19056: --- Assignee: Ted Yu Status: Patch Available (was: Open) > TestCompactionInDeadRegionServer is top of the flakies charts! > --- > > Key: HBASE-19056 > URL: https://issues.apache.org/jira/browse/HBASE-19056 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: Ted Yu > Attachments: 19056.v5.txt > > > The test came in recently as part of HBASE-17712 "Remove/Simplify the logic > of RegionScannerImpl.handleFileNotFound" > [~Apache9] when you have a chance, help me out. I was going to just remove > the test since it made no sense to me but then I saw you wrote it (smile). > When the region.compact(true); is called on the end, what is supposed to be > going on? > When I trace, the compact is not done because the Region is not writeEnabled > (we check if Region is writeEnabled down in Store before we go ahead and > compact). So, I thought the problem was that the region reference was stale > because it came from the rsToSuspend which had just been killed. > After a while, I figured that you intend the region reference to be stale so > you can try an append AFTER the WAL has been taken over by WAL splitter. > But the writeEnabled flag is set so compactions don't run. I tried unsetting > this flag and closed flags and but compaction won't run. > Was this your intent sir? If so, I'll work w/ it np. Just looking for > clarity. Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19056) TestCompactionInDeadRegionServer is top of the flakies charts!
[ https://issues.apache.org/jira/browse/HBASE-19056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19056: --- Attachment: 19056.v5.txt > TestCompactionInDeadRegionServer is top of the flakies charts! > --- > > Key: HBASE-19056 > URL: https://issues.apache.org/jira/browse/HBASE-19056 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack > Attachments: 19056.v5.txt > > > The test came in recently as part of HBASE-17712 "Remove/Simplify the logic > of RegionScannerImpl.handleFileNotFound" > [~Apache9] when you have a chance, help me out. I was going to just remove > the test since it made no sense to me but then I saw you wrote it (smile). > When the region.compact(true); is called on the end, what is supposed to be > going on? > When I trace, the compact is not done because the Region is not writeEnabled > (we check if Region is writeEnabled down in Store before we go ahead and > compact). So, I thought the problem was that the region reference was stale > because it came from the rsToSuspend which had just been killed. > After a while, I figured that you intend the region reference to be stale so > you can try an append AFTER the WAL has been taken over by WAL splitter. > But the writeEnabled flag is set so compactions don't run. I tried unsetting > this flag and closed flags and but compaction won't run. > Was this your intent sir? If so, I'll work w/ it np. Just looking for > clarity. Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19056) TestCompactionInDeadRegionServer is top of the flakies charts!
[ https://issues.apache.org/jira/browse/HBASE-19056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266255#comment-16266255 ] Ted Yu commented on HBASE-19056: I spent a bit time on this test and the following is what I found. For current test, most likely the assertion fails for the second parameterized run where table region and hbase:meta were on same server before the watcher.getRecoverableZooKeeper().delete() call. I also verified the un-writable store condition which causes the compaction request to come back without actually triggering the compaction, leading to fail() assertion. In the modified tests, I would detect whether table region is on the same server as hbase:meta. If so, I would move the region to the other server before issuing the watcher.getRecoverableZooKeeper().delete() call. I have looped both tests 9 times locally which passed. > TestCompactionInDeadRegionServer is top of the flakies charts! > --- > > Key: HBASE-19056 > URL: https://issues.apache.org/jira/browse/HBASE-19056 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack > Attachments: 19056.v5.txt > > > The test came in recently as part of HBASE-17712 "Remove/Simplify the logic > of RegionScannerImpl.handleFileNotFound" > [~Apache9] when you have a chance, help me out. I was going to just remove > the test since it made no sense to me but then I saw you wrote it (smile). > When the region.compact(true); is called on the end, what is supposed to be > going on? > When I trace, the compact is not done because the Region is not writeEnabled > (we check if Region is writeEnabled down in Store before we go ahead and > compact). So, I thought the problem was that the region reference was stale > because it came from the rsToSuspend which had just been killed. > After a while, I figured that you intend the region reference to be stale so > you can try an append AFTER the WAL has been taken over by WAL splitter. > But the writeEnabled flag is set so compactions don't run. I tried unsetting > this flag and closed flags and but compaction won't run. > Was this your intent sir? If so, I'll work w/ it np. Just looking for > clarity. Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19204) branch-1.2 times out and is taking 6-7 hours to complete
[ https://issues.apache.org/jira/browse/HBASE-19204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19204: -- Attachment: HBASE-19204.branch-1.2.005.patch > branch-1.2 times out and is taking 6-7 hours to complete > > > Key: HBASE-19204 > URL: https://issues.apache.org/jira/browse/HBASE-19204 > Project: HBase > Issue Type: Umbrella > Components: test >Reporter: stack > Attachments: 19024.branch-1.2.004.patch, > HBASE-19024.branch-1.2.002.patch, HBASE-19024.branch-1.2.002.patch, > HBASE-19024.branch-1.2.003.patch, HBASE-19204.branch-1.2.005.patch, > HBASE-19204.branch-1.2.005.patch > > > Sean has been looking at tooling and infra. This Umbrellas is about looking > at actual tests. For example, running locally on dedicated machine I picked a > random test, TestPerColumnFamilyFlush. In my test run, it wrote 16M lines. It > seems to be having zk issues but it is catching interrupts and ignoring them > ([~carp84] fixed this in later versions over in HBASE-18441). > Let me try and do some fixup under this umbrella so we can get a 1.2.7 out > the door. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19204) branch-1.2 times out and is taking 6-7 hours to complete
[ https://issues.apache.org/jira/browse/HBASE-19204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266253#comment-16266253 ] Chia-Ping Tsai commented on HBASE-19204: Are you testing the jenkins config? [~stack] I noticed the following error happens after the jenkins config change {code} 23:31:03 Modes: MultiJDK Jenkins Robot Docker ResetRepo UnitTests 23:31:03 Processing: HBASE-19024 23:31:04 ERROR: Unsure how to process HBASE-19024. {code} I can't access the [config change|https://builds.apache.org/view/H-L/view/HBase/job/PreCommit-HBASE-Build/jobConfigHistory/showDiffFiles?timestamp1=2017-11-06_13-27-38=2017-11-23_20-16-38] as I don't have the permission. > branch-1.2 times out and is taking 6-7 hours to complete > > > Key: HBASE-19204 > URL: https://issues.apache.org/jira/browse/HBASE-19204 > Project: HBase > Issue Type: Umbrella > Components: test >Reporter: stack > Attachments: 19024.branch-1.2.004.patch, > HBASE-19024.branch-1.2.002.patch, HBASE-19024.branch-1.2.002.patch, > HBASE-19024.branch-1.2.003.patch, HBASE-19204.branch-1.2.005.patch, > HBASE-19204.branch-1.2.005.patch > > > Sean has been looking at tooling and infra. This Umbrellas is about looking > at actual tests. For example, running locally on dedicated machine I picked a > random test, TestPerColumnFamilyFlush. In my test run, it wrote 16M lines. It > seems to be having zk issues but it is catching interrupts and ignoring them > ([~carp84] fixed this in later versions over in HBASE-18441). > Let me try and do some fixup under this umbrella so we can get a 1.2.7 out > the door. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19204) branch-1.2 times out and is taking 6-7 hours to complete
[ https://issues.apache.org/jira/browse/HBASE-19204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19204: -- Attachment: HBASE-19204.branch-1.2.005.patch > branch-1.2 times out and is taking 6-7 hours to complete > > > Key: HBASE-19204 > URL: https://issues.apache.org/jira/browse/HBASE-19204 > Project: HBase > Issue Type: Umbrella > Components: test >Reporter: stack > Attachments: 19024.branch-1.2.004.patch, > HBASE-19024.branch-1.2.002.patch, HBASE-19024.branch-1.2.002.patch, > HBASE-19024.branch-1.2.003.patch, HBASE-19204.branch-1.2.005.patch > > > Sean has been looking at tooling and infra. This Umbrellas is about looking > at actual tests. For example, running locally on dedicated machine I picked a > random test, TestPerColumnFamilyFlush. In my test run, it wrote 16M lines. It > seems to be having zk issues but it is catching interrupts and ignoring them > ([~carp84] fixed this in later versions over in HBASE-18441). > Let me try and do some fixup under this umbrella so we can get a 1.2.7 out > the door. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19204) branch-1.2 times out and is taking 6-7 hours to complete
[ https://issues.apache.org/jira/browse/HBASE-19204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19204: -- Attachment: 19024.branch-1.2.004.patch > branch-1.2 times out and is taking 6-7 hours to complete > > > Key: HBASE-19204 > URL: https://issues.apache.org/jira/browse/HBASE-19204 > Project: HBase > Issue Type: Umbrella > Components: test >Reporter: stack > Attachments: 19024.branch-1.2.004.patch, > HBASE-19024.branch-1.2.002.patch, HBASE-19024.branch-1.2.002.patch, > HBASE-19024.branch-1.2.003.patch > > > Sean has been looking at tooling and infra. This Umbrellas is about looking > at actual tests. For example, running locally on dedicated machine I picked a > random test, TestPerColumnFamilyFlush. In my test run, it wrote 16M lines. It > seems to be having zk issues but it is catching interrupts and ignoring them > ([~carp84] fixed this in later versions over in HBASE-18441). > Let me try and do some fixup under this umbrella so we can get a 1.2.7 out > the door. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19344) improve asyncWAL by using Independent thread for netty #IO in FanOutOneBlockAsyncDFSOutput
[ https://issues.apache.org/jira/browse/HBASE-19344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266248#comment-16266248 ] Duo Zhang commented on HBASE-19344: --- For cellEncoder, as its name, is used to serialize the cells so no doubt it will be the CPU bound. Maybe we can encode the cell before insert it into the ring buffer? This would be another optimization. And I haven’t understand the second question on sync fail, could you please explain a bit more? Thanks. > improve asyncWAL by using Independent thread for netty #IO in > FanOutOneBlockAsyncDFSOutput > --- > > Key: HBASE-19344 > URL: https://issues.apache.org/jira/browse/HBASE-19344 > Project: HBase > Issue Type: Sub-task > Components: wal >Affects Versions: 2.0.0-beta-1 >Reporter: Chance Li >Assignee: Chance Li > Fix For: 2.0.0 > > Attachments: HBASE-19344-branch2.patch, > HBASE-19344-branch2.patch.2.POC, wal-1-test-result.png, > wal-8-test-result.png, ycsb_result_apache20_async_wal.pdf > > > The logic now is that the netty #IO thread and asyncWal's thread are the same > one. > Improvement proposal: > 1, Split into two. > 2, All multiWal share the netty #IO thread pool. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19204) branch-1.2 times out and is taking 6-7 hours to complete
[ https://issues.apache.org/jira/browse/HBASE-19204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19204: -- Attachment: HBASE-19024.branch-1.2.003.patch > branch-1.2 times out and is taking 6-7 hours to complete > > > Key: HBASE-19204 > URL: https://issues.apache.org/jira/browse/HBASE-19204 > Project: HBase > Issue Type: Umbrella > Components: test >Reporter: stack > Attachments: HBASE-19024.branch-1.2.002.patch, > HBASE-19024.branch-1.2.002.patch, HBASE-19024.branch-1.2.003.patch > > > Sean has been looking at tooling and infra. This Umbrellas is about looking > at actual tests. For example, running locally on dedicated machine I picked a > random test, TestPerColumnFamilyFlush. In my test run, it wrote 16M lines. It > seems to be having zk issues but it is catching interrupts and ignoring them > ([~carp84] fixed this in later versions over in HBASE-18441). > Let me try and do some fixup under this umbrella so we can get a 1.2.7 out > the door. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19024) provide a configurable option to hsync WAL edits to the disk for better durability
[ https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19024: -- Attachment: HBASE-19024.branch-1.2.003.patch > provide a configurable option to hsync WAL edits to the disk for better > durability > -- > > Key: HBASE-19024 > URL: https://issues.apache.org/jira/browse/HBASE-19024 > Project: HBase > Issue Type: Improvement > Components: wal > Environment: >Reporter: Vikas Vishwakarma >Assignee: Harshal Jain > Attachments: HBASE-19024.branch-1.2.001.patch, > HBASE-19024.branch-1.2.002.patch, HBASE-19024.branch-1.2.003.patch, > branch-1.branch-1.patch, branch-1.v1.branch-1.patch, master.patch, > master.v2.patch, master.v3.patch, master.v5.patch, master.v5.patch, > master.v6.patch, master.v9.patch > > > At present we do not have an option to hsync WAL edits to the disk for better > durability. In our local tests we see 10-15% latency impact of using hsync > instead of hflush which is not very high. > We should have a configurable option to hysnc WAL edits instead of just > sync/hflush which will call the corresponding API on the hadoop side. > Currently HBase handles both SYNC_WAL and FSYNC_WAL as the same calling > FSDataOutputStream sync/hflush on the hadoop side. This can be modified to > let FSYNC_WAL call hsync on the hadoop side instead of sync/hflush. We can > keep the default value to sync as the current behavior and hsync can be > enabled based on explicit configuration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19204) branch-1.2 times out and is taking 6-7 hours to complete
[ https://issues.apache.org/jira/browse/HBASE-19204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19204: -- Attachment: HBASE-19024.branch-1.2.002.patch > branch-1.2 times out and is taking 6-7 hours to complete > > > Key: HBASE-19204 > URL: https://issues.apache.org/jira/browse/HBASE-19204 > Project: HBase > Issue Type: Umbrella > Components: test >Reporter: stack > Attachments: HBASE-19024.branch-1.2.002.patch, > HBASE-19024.branch-1.2.002.patch > > > Sean has been looking at tooling and infra. This Umbrellas is about looking > at actual tests. For example, running locally on dedicated machine I picked a > random test, TestPerColumnFamilyFlush. In my test run, it wrote 16M lines. It > seems to be having zk issues but it is catching interrupts and ignoring them > ([~carp84] fixed this in later versions over in HBASE-18441). > Let me try and do some fixup under this umbrella so we can get a 1.2.7 out > the door. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19112) Suspect methods on Cell to be deprecated
[ https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266201#comment-16266201 ] Chia-Ping Tsai commented on HBASE-19112: I feel we should process the client module and common module first as it has us think how to put the {{RawCell}} in the right place for user. For example, # deprecate the Put#add(Cell) and add the Put#add(RawCell). ditto for Delete/Append/Increment # change the {{Cell}} reference to {{RawCell}} for Put. ditto for Delete/Append/Increment # make Scan#setRaw be IA.LP # make {{Result}} be interface in order to introduce the {{RawResult} which carries the {{RawCell}} for raw scan # introduce the {{RawResultScanner}} for raw scan # adding the {{RawCellComparator}}, {{RawCellBuilder}}, {{RawCellScannable}}, and {{RawCellScanner}} # deprecate the help methods which get tag/type from {{Cell}}, and then add the alternative help methods which apply the {{RawCell}}. > Suspect methods on Cell to be deprecated > > > Key: HBASE-19112 > URL: https://issues.apache.org/jira/browse/HBASE-19112 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Josh Elser >Assignee: ramkrishna.s.vasudevan >Priority: Blocker > Fix For: 2.0.0-beta-1 > > > [~chia7712] suggested on the [mailing > list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E] > that we have some methods on Cell which should be deprecated for removal: > * {{#getType()}} > * {{#getTimestamp()}} > * {{#getTag()}} > * {{#getSequenceId()}} > Let's make a pass over these (and maybe the rest) to make sure that there > aren't others which are either implementation details or methods returning > now-private-marked classes. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19240) Fix error-prone errors, part four?
[ https://issues.apache.org/jira/browse/HBASE-19240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266162#comment-16266162 ] Chia-Ping Tsai commented on HBASE-19240: Sorry for missing this jira. {quote} attached branch-1 patch which was only the parts the didn't have any conflicts. for anything that did have conflicts, i left the code unchanged on the assumption that because the base is different we will need to review it separately anyway. {quote} Let me file a jira to complete the fixes for branch-1. see HBASE-19348 > Fix error-prone errors, part four? > -- > > Key: HBASE-19240 > URL: https://issues.apache.org/jira/browse/HBASE-19240 > Project: HBase > Issue Type: Bug >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 1.5.0, 2.0.0-beta-1 > > Attachments: HBASE-19240.branch-1.patch, > HBASE-19240.branch-1.v2.patch, HBASE-19240.patch, HBASE-19240.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19348) Fix error-prone errors for branch-1
Chia-Ping Tsai created HBASE-19348: -- Summary: Fix error-prone errors for branch-1 Key: HBASE-19348 URL: https://issues.apache.org/jira/browse/HBASE-19348 Project: HBase Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19204) branch-1.2 times out and is taking 6-7 hours to complete
[ https://issues.apache.org/jira/browse/HBASE-19204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266160#comment-16266160 ] stack commented on HBASE-19204: --- Thanks [~chia7712] for pointer. I was looking at master branch. > branch-1.2 times out and is taking 6-7 hours to complete > > > Key: HBASE-19204 > URL: https://issues.apache.org/jira/browse/HBASE-19204 > Project: HBase > Issue Type: Umbrella > Components: test >Reporter: stack > Attachments: HBASE-19024.branch-1.2.002.patch > > > Sean has been looking at tooling and infra. This Umbrellas is about looking > at actual tests. For example, running locally on dedicated machine I picked a > random test, TestPerColumnFamilyFlush. In my test run, it wrote 16M lines. It > seems to be having zk issues but it is catching interrupts and ignoring them > ([~carp84] fixed this in later versions over in HBASE-18441). > Let me try and do some fixup under this umbrella so we can get a 1.2.7 out > the door. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19300) TestMultithreadedTableMapper fails in branch-1.4
[ https://issues.apache.org/jira/browse/HBASE-19300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266151#comment-16266151 ] Chia-Ping Tsai commented on HBASE-19300: +1 > TestMultithreadedTableMapper fails in branch-1.4 > > > Key: HBASE-19300 > URL: https://issues.apache.org/jira/browse/HBASE-19300 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 19300.branch-1.4.patch, 19300.branch-1.4.patch > > > From > https://builds.apache.org/job/HBase-1.4/1023/jdk=JDK_1_7,label=Hadoop&&!H13/testReport/org.apache.hadoop.hbase.mapreduce/TestMultithreadedTableMapper/testMultithreadedTableMapper/ > : > {code} > java.lang.AssertionError > at > org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper.verify(TestMultithreadedTableMapper.java:195) > at > org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper.runTestOnTable(TestMultithreadedTableMapper.java:163) > at > org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper.testMultithreadedTableMapper(TestMultithreadedTableMapper.java:136) > {code} > I ran the test locally which failed. > Noticed the following in test output: > {code} > 2017-11-18 19:28:13,929 ERROR [hconnection-0x11db8653-shared--pool24-t9] > protobuf.ResponseConverter(425): Results sent from server=703. But only got 0 > results completely atclient. Resetting the scanner to scan again. > 2017-11-18 19:28:13,929 ERROR [hconnection-0x11db8653-shared--pool24-t3] > protobuf.ResponseConverter(425): Results sent from server=703. But only got 0 > results completely atclient. Resetting the scanner to scan again. > 2017-11-18 19:28:14,461 ERROR [hconnection-0x11db8653-shared--pool24-t8] > protobuf.ResponseConverter(432): Exception while reading cells from > result.Resetting the scanner toscan again. > org.apache.hadoop.hbase.DoNotRetryIOException: Results sent from server=703. > But only got 0 results completely at client. Resetting the scanner to scan > again. > at > org.apache.hadoop.hbase.protobuf.ResponseConverter.getResults(ResponseConverter.java:426) > at > org.apache.hadoop.hbase.client.ScannerCallable.call(ScannerCallable.java:284) > at > org.apache.hadoop.hbase.client.ScannerCallable.call(ScannerCallable.java:62) > at > org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithoutRetries(RpcRetryingCaller.java:219) > at > org.apache.hadoop.hbase.client.ScannerCallableWithReplicas$RetryingRPC.call(ScannerCallableWithReplicas.java:388) > at > org.apache.hadoop.hbase.client.ScannerCallableWithReplicas$RetryingRPC.call(ScannerCallableWithReplicas.java:362) > at > org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:142) > at > org.apache.hadoop.hbase.client.ResultBoundedCompletionService$QueueingFuture.run(ResultBoundedCompletionService.java:80) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > 2017-11-18 19:28:14,464 ERROR [hconnection-0x11db8653-shared--pool24-t2] > protobuf.ResponseConverter(432): Exception while reading cells from > result.Resetting the scanner toscan again. > java.io.EOFException: Partial cell read > at > org.apache.hadoop.hbase.codec.BaseDecoder.rethrowEofException(BaseDecoder.java:86) > at org.apache.hadoop.hbase.codec.BaseDecoder.advance(BaseDecoder.java:70) > at > org.apache.hadoop.hbase.protobuf.ResponseConverter.getResults(ResponseConverter.java:419) > at > org.apache.hadoop.hbase.client.ScannerCallable.call(ScannerCallable.java:284) > at > org.apache.hadoop.hbase.client.ScannerCallable.call(ScannerCallable.java:62) > at > org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithoutRetries(RpcRetryingCaller.java:219) > at > org.apache.hadoop.hbase.client.ScannerCallableWithReplicas$RetryingRPC.call(ScannerCallableWithReplicas.java:388) > at > org.apache.hadoop.hbase.client.ScannerCallableWithReplicas$RetryingRPC.call(ScannerCallableWithReplicas.java:362) > at > org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:142) > at > org.apache.hadoop.hbase.client.ResultBoundedCompletionService$QueueingFuture.run(ResultBoundedCompletionService.java:80) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > Caused by: java.io.IOException: Premature EOF from inputStream > at org.apache.hadoop.io.IOUtils.readFully(IOUtils.java:202) > at org.apache.hadoop.hbase.KeyValueUtil.iscreate(KeyValueUtil.java:611) > at >
[jira] [Commented] (HBASE-19345) TestJMXConnectorServer can fail with java.net.BindException
[ https://issues.apache.org/jira/browse/HBASE-19345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266126#comment-16266126 ] Chia-Ping Tsai commented on HBASE-19345: Excuse me. Does the patch try to fix the port conflict? > TestJMXConnectorServer can fail with java.net.BindException > --- > > Key: HBASE-19345 > URL: https://issues.apache.org/jira/browse/HBASE-19345 > Project: HBase > Issue Type: Bug >Reporter: stack > Attachments: 19345.test.cleanup.txt > > > See nightly > https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-1.2/136 > {code} > 2017-11-21 20:28:11,973 ERROR [2831917ab33b:39603.activeMasterManager] > coprocessor.CoprocessorHost(524): The coprocessor > org.apache.hadoop.hbase.JMXListener threw java.rmi.server.ExportException: > Port already in use: 61120; nested exception is: > java.net.BindException: Address already in use (Bind failed) > java.rmi.server.ExportException: Port already in use: 61120; nested exception > is: > java.net.BindException: Address already in use (Bind failed) > at sun.rmi.transport.tcp.TCPTransport.listen(TCPTransport.java:341) > at > sun.rmi.transport.tcp.TCPTransport.exportObject(TCPTransport.java:249) > at sun.rmi.transport.tcp.TCPEndpoint.exportObject(TCPEndpoint.java:411) > at sun.rmi.transport.LiveRef.exportObject(LiveRef.java:147) > at > sun.rmi.server.UnicastServerRef.exportObject(UnicastServerRef.java:236) > at sun.rmi.registry.RegistryImpl.setup(RegistryImpl.java:196) > at sun.rmi.registry.RegistryImpl.(RegistryImpl.java:182) > at > java.rmi.registry.LocateRegistry.createRegistry(LocateRegistry.java:203) > at > org.apache.hadoop.hbase.JMXListener.startConnectorServer(JMXListener.java:132) > at org.apache.hadoop.hbase.JMXListener.start(JMXListener.java:207) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost$Environment.startup(CoprocessorHost.java:414) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.loadInstance(CoprocessorHost.java:255) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.loadSystemCoprocessors(CoprocessorHost.java:161) > at > org.apache.hadoop.hbase.master.MasterCoprocessorHost.(MasterCoprocessorHost.java:87) > at > org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:721) > at org.apache.hadoop.hbase.master.HMaster.access$600(HMaster.java:189) > at org.apache.hadoop.hbase.master.HMaster$2.run(HMaster.java:1803) > at java.lang.Thread.run(Thread.java:748) > Caused by: java.net.BindException: Address already in use (Bind failed) > at java.net.PlainSocketImpl.socketBind(Native Method) > at > java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:376) > at java.net.ServerSocket.bind(ServerSocket.java:376) > at java.net.ServerSocket.(ServerSocket.java:237) > at java.net.ServerSocket.(ServerSocket.java:128) > at > sun.rmi.transport.proxy.RMIDirectSocketFactory.createServerSocket(RMIDirectSocketFactory.java:45) > at > sun.rmi.transport.proxy.RMIMasterSocketFactory.createServerSocket(RMIMasterSocketFactory.java:345) > at > sun.rmi.transport.tcp.TCPEndpoint.newServerSocket(TCPEndpoint.java:666) > at sun.rmi.transport.tcp.TCPTransport.listen(TCPTransport.java:330) > ... 17 more > {code} > The RMI port is hardcoded. A concurrent cluster can make this test fail. We > don't have facility for retrying alternate RMI port. We don't want it even, > for prod. deploy. Would be good though if the port changed if problem in unit > tests. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19344) improve asyncWAL by using Independent thread for netty #IO in FanOutOneBlockAsyncDFSOutput
[ https://issues.apache.org/jira/browse/HBASE-19344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266113#comment-16266113 ] Chance Li commented on HBASE-19344: --- bq. For me, I will start working on implementing the new logic described in the POC. As said above it is not straight-forward for fail recovery. [~Apache9] Would you give some doc for your design? As we see, there are some 'cpu bound' on AsyncFSWal, such as # cellEncoder.write(cell); And what's the limit when #sync always fail. > improve asyncWAL by using Independent thread for netty #IO in > FanOutOneBlockAsyncDFSOutput > --- > > Key: HBASE-19344 > URL: https://issues.apache.org/jira/browse/HBASE-19344 > Project: HBase > Issue Type: Sub-task > Components: wal >Affects Versions: 2.0.0-beta-1 >Reporter: Chance Li >Assignee: Chance Li > Fix For: 2.0.0 > > Attachments: HBASE-19344-branch2.patch, > HBASE-19344-branch2.patch.2.POC, wal-1-test-result.png, > wal-8-test-result.png, ycsb_result_apache20_async_wal.pdf > > > The logic now is that the netty #IO thread and asyncWal's thread are the same > one. > Improvement proposal: > 1, Split into two. > 2, All multiWal share the netty #IO thread pool. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18601) Update Htrace to 4.2
[ https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266105#comment-16266105 ] Chia-Ping Tsai commented on HBASE-18601: {code:title=TraceTree.java} if (span.getParents().length == 0) { LinkedList list = parentToSpans.get(Long.valueOf(0L)); <-- here if (list == null) { list = new LinkedList(); parentToSpans.put(new SpanId(Long.MIN_VALUE, Long.MIN_VALUE), list); } list.add(span); } {code} It seems we pass the wrong type to the {{parentToSpans#get}}. [~balazs.meszaros] Would you please take a look? > Update Htrace to 4.2 > > > Key: HBASE-18601 > URL: https://issues.apache.org/jira/browse/HBASE-18601 > Project: HBase > Issue Type: Improvement > Components: dependencies, tracing >Affects Versions: 2.0.0, 3.0.0 >Reporter: Tamas Penzes >Assignee: Balazs Meszaros > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18601.master.001.patch, > HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch, > HBASE-18601.master.003.patch, HBASE-18601.master.004.patch, > HBASE-18601.master.004.patch, HBASE-18601.master.005.patch, > HBASE-18601.master.006.patch, HBASE-18601.master.006.patch, > HBASE-18601.master.007.patch, HBASE-18601.master.007.patch, > HBASE-18601.master.007.patch, HBASE-18601.master.008.patch, > HBASE-18601.master.009.patch, HBASE-18601.master.009.patch, > HBASE-18601.master.010.patch, HBASE-18601.master.010.patch, > HBASE-18601.master.011.patch, HBASE-18601.master.012.patch, > HBASE-18601.master.013.patch, HBASE-18601.master.014.patch, > HBASE-18601.master.014.patch, HBASE-18601.master.015.patch > > > HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, > the upgrade to 4.x is not trivial and would take time. It might not worth to > keep it in this state, so would be better to remove it. > Of course it doesn't mean tracing would be useless, just that in this form > the use of HTrace 3.2 might not add any value to the project and fixing it > would be far too much effort. > - > Based on the decision of the community we keep htrace now and update version -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266053#comment-16266053 ] Olaf Flebbe edited comment on HBASE-19188 at 11/26/17 3:55 PM: --- The issue is we use different maven targets. I drilled it down to {code} mvn clean site -DskipTests {code} on hbase-1.1.12 result with your patch is {code} ... [INFO] [INFO] Forking Apache HBase - Thrift 1.1.12 [INFO] [INFO] [INFO] --- build-helper-maven-plugin:1.9.1:bsh-property (negate-license-bundles-property) @ hbase-thrift --- [INFO] [INFO] --- maven-enforcer-plugin:1.0.1:enforce (min-maven-min-java-banned-xerces) @ hbase-thrift --- [INFO] [INFO] --- maven-enforcer-plugin:1.0.1:enforce (banned-jsr305) @ hbase-thrift --- [INFO] [INFO] --- buildnumber-maven-plugin:1.3:create-timestamp (default) @ hbase-thrift --- [INFO] [INFO] --- build-helper-maven-plugin:1.9.1:add-source (jspcSource-packageInfo-source) @ hbase-thrift --- [INFO] Source directory: /tmp/hbase/hbase-thrift/target/generated-sources/java added. [INFO] [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-thrift --- [INFO] Executing tasks main: log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC). log4j:WARN Please initialize the log4j system properly. log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info. [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via org.mortbay.log.Slf4jLog java.util.MissingResourceException: Can't find bundle for base name org.apache.jasper.resources.LocalStrings, locale en_US at java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) [INFO] Apache HBase - Native Client ... SKIPPED [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 10.915 s [INFO] Finished at: 2017-11-26T15:48:40Z [INFO] Final Memory: 61M/419M [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project hbase: failed to get report for org.apache.maven.plugins:maven-javadoc-plugin: Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.6:run (generate) on project hbase-thrift: An Ant BuildException has occured: java.lang.NullPointerException -> [Help 1] [ERROR] {code} was (Author: oflebbe): The issue is we use different maven targets. I drilled it down to {code} mvn clean site -DskipTests {code} on hbase-1.1.12 result with your patch is {code} ... [INFO] [INFO] Forking Apache HBase - Thrift 1.1.12 [INFO] [INFO] [INFO] --- build-helper-maven-plugin:1.9.1:bsh-property (negate-license-bundles-property) @ hbase-thrift --- [INFO] [INFO] --- maven-enforcer-plugin:1.0.1:enforce (min-maven-min-java-banned-xerces) @ hbase-thrift --- [INFO] [INFO] --- maven-enforcer-plugin:1.0.1:enforce (banned-jsr305) @ hbase-thrift --- [INFO] [INFO] --- buildnumber-maven-plugin:1.3:create-timestamp (default) @ hbase-thrift --- [INFO] [INFO] --- build-helper-maven-plugin:1.9.1:add-source (jspcSource-packageInfo-source) @ hbase-thrift --- [INFO] Source directory: /tmp/hbase/hbase-thrift/target/generated-sources/java added. [INFO] [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-thrift --- [INFO] Executing tasks main: log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC). log4j:WARN Please initialize the log4j system properly. log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info. [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via org.mortbay.log.Slf4jLog java.util.MissingResourceException: Can't find bundle for base name org.apache.jasper.resources.LocalStrings, locale en_US at java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) {code} > Build fails on branch-1 using maven-3.5.2 > - > > Key: HBASE-19188 > URL: https://issues.apache.org/jira/browse/HBASE-19188 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical >
[jira] [Commented] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266054#comment-16266054 ] Olaf Flebbe commented on HBASE-19188: - In order to reproduce the issue you may use this docker environment {code} docker run --it bigtop/slaves:bigtop-fedora-26 bash -l {code} > Build fails on branch-1 using maven-3.5.2 > - > > Key: HBASE-19188 > URL: https://issues.apache.org/jira/browse/HBASE-19188 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-19188.branch-1.2.001.patch > > > With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and > branch-1. On branch-1.1, branch-2 and master the build succeeds. With older > maven versions the build finishes. > {code:title=Maven version} > $ mvn -v > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m; > support was removed in 8.0 > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T09:58:13+02:00) > Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2 > Java version: 1.8.0_141, vendor: Oracle Corporation > Java home: > /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" > {code} > {code} > $ mvn clean install -DskipTests > ... > [INFO] --- jamon-maven-plugin:2.4.1:translate (default) @ hbase-server --- > [INFO] > [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-server --- > [INFO] Executing tasks > main: > log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC). > log4j:WARN Please initialize the log4j system properly. > log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more > info. > [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via > org.mortbay.log.Slf4jLog > java.util.MissingResourceException: Can't find bundle for base name > org.apache.jasper.resources.LocalStrings, locale en_US > at > java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) > at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) > at java.util.ResourceBundle.getBundle(ResourceBundle.java:773) > at org.apache.jasper.compiler.Localizer.(Localizer.java:36) > at > org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:103) > at org.apache.jasper.JspC.initServletContext(JspC.java:1242) > at org.apache.jasper.JspC.execute(JspC.java:1103) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154) > at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) > at sun.reflect.GeneratedMethodAccessor122.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.Task.perform(Task.java:348) > at org.apache.tools.ant.Target.execute(Target.java:390) > at org.apache.tools.ant.Target.performTasks(Target.java:411) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1397) > at org.apache.tools.ant.Project.executeTarget(Project.java:1366) > at > org.apache.maven.plugin.antrun.AntRunMojo.execute(AntRunMojo.java:270) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > at > org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions(MojoExecutor.java:353) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:198) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > at >
[jira] [Comment Edited] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266053#comment-16266053 ] Olaf Flebbe edited comment on HBASE-19188 at 11/26/17 3:54 PM: --- The issue is we use different maven targets. I drilled it down to {code} mvn clean site -DskipTests {code} on hbase-1.1.12 result with your patch is {code} ... [INFO] [INFO] Forking Apache HBase - Thrift 1.1.12 [INFO] [INFO] [INFO] --- build-helper-maven-plugin:1.9.1:bsh-property (negate-license-bundles-property) @ hbase-thrift --- [INFO] [INFO] --- maven-enforcer-plugin:1.0.1:enforce (min-maven-min-java-banned-xerces) @ hbase-thrift --- [INFO] [INFO] --- maven-enforcer-plugin:1.0.1:enforce (banned-jsr305) @ hbase-thrift --- [INFO] [INFO] --- buildnumber-maven-plugin:1.3:create-timestamp (default) @ hbase-thrift --- [INFO] [INFO] --- build-helper-maven-plugin:1.9.1:add-source (jspcSource-packageInfo-source) @ hbase-thrift --- [INFO] Source directory: /tmp/hbase/hbase-thrift/target/generated-sources/java added. [INFO] [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-thrift --- [INFO] Executing tasks main: log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC). log4j:WARN Please initialize the log4j system properly. log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info. [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via org.mortbay.log.Slf4jLog java.util.MissingResourceException: Can't find bundle for base name org.apache.jasper.resources.LocalStrings, locale en_US at java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) {code} was (Author: oflebbe): The issue is we use different maven targets. I drilled it down to {clean} mvn clean site -DskipTests {clean} on hbase-1.1.12 result with your patch is {code} ... [INFO] [INFO] Forking Apache HBase - Thrift 1.1.12 [INFO] [INFO] [INFO] --- build-helper-maven-plugin:1.9.1:bsh-property (negate-license-bundles-property) @ hbase-thrift --- [INFO] [INFO] --- maven-enforcer-plugin:1.0.1:enforce (min-maven-min-java-banned-xerces) @ hbase-thrift --- [INFO] [INFO] --- maven-enforcer-plugin:1.0.1:enforce (banned-jsr305) @ hbase-thrift --- [INFO] [INFO] --- buildnumber-maven-plugin:1.3:create-timestamp (default) @ hbase-thrift --- [INFO] [INFO] --- build-helper-maven-plugin:1.9.1:add-source (jspcSource-packageInfo-source) @ hbase-thrift --- [INFO] Source directory: /tmp/hbase/hbase-thrift/target/generated-sources/java added. [INFO] [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-thrift --- [INFO] Executing tasks main: log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC). log4j:WARN Please initialize the log4j system properly. log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info. [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via org.mortbay.log.Slf4jLog java.util.MissingResourceException: Can't find bundle for base name org.apache.jasper.resources.LocalStrings, locale en_US at java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) {code} > Build fails on branch-1 using maven-3.5.2 > - > > Key: HBASE-19188 > URL: https://issues.apache.org/jira/browse/HBASE-19188 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-19188.branch-1.2.001.patch > > > With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and > branch-1. On branch-1.1, branch-2 and master the build succeeds. With older > maven versions the build finishes. > {code:title=Maven version} > $ mvn -v > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m; > support was removed in 8.0 > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T09:58:13+02:00) > Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2 > Java version: 1.8.0_141, vendor: Oracle Corporation > Java home: > /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" > {code} > {code} >
[jira] [Commented] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266053#comment-16266053 ] Olaf Flebbe commented on HBASE-19188: - The issue is we use different maven targets. I drilled it down to {clean} mvn clean site -DskipTests {clean} on hbase-1.1.12 result with your patch is {code} ... [INFO] [INFO] Forking Apache HBase - Thrift 1.1.12 [INFO] [INFO] [INFO] --- build-helper-maven-plugin:1.9.1:bsh-property (negate-license-bundles-property) @ hbase-thrift --- [INFO] [INFO] --- maven-enforcer-plugin:1.0.1:enforce (min-maven-min-java-banned-xerces) @ hbase-thrift --- [INFO] [INFO] --- maven-enforcer-plugin:1.0.1:enforce (banned-jsr305) @ hbase-thrift --- [INFO] [INFO] --- buildnumber-maven-plugin:1.3:create-timestamp (default) @ hbase-thrift --- [INFO] [INFO] --- build-helper-maven-plugin:1.9.1:add-source (jspcSource-packageInfo-source) @ hbase-thrift --- [INFO] Source directory: /tmp/hbase/hbase-thrift/target/generated-sources/java added. [INFO] [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-thrift --- [INFO] Executing tasks main: log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC). log4j:WARN Please initialize the log4j system properly. log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info. [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via org.mortbay.log.Slf4jLog java.util.MissingResourceException: Can't find bundle for base name org.apache.jasper.resources.LocalStrings, locale en_US at java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) {code} > Build fails on branch-1 using maven-3.5.2 > - > > Key: HBASE-19188 > URL: https://issues.apache.org/jira/browse/HBASE-19188 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-19188.branch-1.2.001.patch > > > With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and > branch-1. On branch-1.1, branch-2 and master the build succeeds. With older > maven versions the build finishes. > {code:title=Maven version} > $ mvn -v > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m; > support was removed in 8.0 > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T09:58:13+02:00) > Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2 > Java version: 1.8.0_141, vendor: Oracle Corporation > Java home: > /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" > {code} > {code} > $ mvn clean install -DskipTests > ... > [INFO] --- jamon-maven-plugin:2.4.1:translate (default) @ hbase-server --- > [INFO] > [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-server --- > [INFO] Executing tasks > main: > log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC). > log4j:WARN Please initialize the log4j system properly. > log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more > info. > [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via > org.mortbay.log.Slf4jLog > java.util.MissingResourceException: Can't find bundle for base name > org.apache.jasper.resources.LocalStrings, locale en_US > at > java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) > at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) > at java.util.ResourceBundle.getBundle(ResourceBundle.java:773) > at org.apache.jasper.compiler.Localizer.(Localizer.java:36) > at > org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:103) > at org.apache.jasper.JspC.initServletContext(JspC.java:1242) > at org.apache.jasper.JspC.execute(JspC.java:1103) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154) > at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) >
[jira] [Commented] (HBASE-19347) Source Download misses the director hbase-native-client with respect to git tag
[ https://issues.apache.org/jira/browse/HBASE-19347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266034#comment-16266034 ] Ted Yu commented on HBASE-19347: lgtm [~ndimiduk]: FYI > Source Download misses the director hbase-native-client with respect to git > tag > --- > > Key: HBASE-19347 > URL: https://issues.apache.org/jira/browse/HBASE-19347 > Project: HBase > Issue Type: Bug >Affects Versions: 1.1.12 >Reporter: Olaf Flebbe > Fix For: 1.1.13 > > Attachments: 0001-Add-hbase-native-client-to-hbase-src.tgz.patch > > > In the download hbase-1.1.12-src.tar.gz the directory hbase-native-client is > missing. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19347) Source Download misses the director hbase-native-client with respect to git tag
[ https://issues.apache.org/jira/browse/HBASE-19347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olaf Flebbe updated HBASE-19347: Fix Version/s: 1.1.13 Status: Patch Available (was: Open) > Source Download misses the director hbase-native-client with respect to git > tag > --- > > Key: HBASE-19347 > URL: https://issues.apache.org/jira/browse/HBASE-19347 > Project: HBase > Issue Type: Bug >Affects Versions: 1.1.12 >Reporter: Olaf Flebbe > Fix For: 1.1.13 > > Attachments: 0001-Add-hbase-native-client-to-hbase-src.tgz.patch > > > In the download hbase-1.1.12-src.tar.gz the directory hbase-native-client is > missing. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19347) Source Download misses the director hbase-native-client with respect to git tag
Olaf Flebbe created HBASE-19347: --- Summary: Source Download misses the director hbase-native-client with respect to git tag Key: HBASE-19347 URL: https://issues.apache.org/jira/browse/HBASE-19347 Project: HBase Issue Type: Bug Affects Versions: 1.1.12 Reporter: Olaf Flebbe In the download hbase-1.1.12-src.tar.gz the directory hbase-native-client is missing. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19347) Source Download misses the director hbase-native-client with respect to git tag
[ https://issues.apache.org/jira/browse/HBASE-19347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olaf Flebbe updated HBASE-19347: Attachment: 0001-Add-hbase-native-client-to-hbase-src.tgz.patch > Source Download misses the director hbase-native-client with respect to git > tag > --- > > Key: HBASE-19347 > URL: https://issues.apache.org/jira/browse/HBASE-19347 > Project: HBase > Issue Type: Bug >Affects Versions: 1.1.12 >Reporter: Olaf Flebbe > Attachments: 0001-Add-hbase-native-client-to-hbase-src.tgz.patch > > > In the download hbase-1.1.12-src.tar.gz the directory hbase-native-client is > missing. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265999#comment-16265999 ] Peter Somogyi commented on HBASE-19188: --- On pure hbase branch-1.1 works even now, so that branch does not need modification. However, branch-1.2, branch-1.3, branch-1.4 and branch-1 need is. What hbase version are you using in bigtop? Maybe you depend on a newer version than hbase-1.1 which has the problem. > Build fails on branch-1 using maven-3.5.2 > - > > Key: HBASE-19188 > URL: https://issues.apache.org/jira/browse/HBASE-19188 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-19188.branch-1.2.001.patch > > > With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and > branch-1. On branch-1.1, branch-2 and master the build succeeds. With older > maven versions the build finishes. > {code:title=Maven version} > $ mvn -v > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m; > support was removed in 8.0 > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T09:58:13+02:00) > Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2 > Java version: 1.8.0_141, vendor: Oracle Corporation > Java home: > /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" > {code} > {code} > $ mvn clean install -DskipTests > ... > [INFO] --- jamon-maven-plugin:2.4.1:translate (default) @ hbase-server --- > [INFO] > [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-server --- > [INFO] Executing tasks > main: > log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC). > log4j:WARN Please initialize the log4j system properly. > log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more > info. > [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via > org.mortbay.log.Slf4jLog > java.util.MissingResourceException: Can't find bundle for base name > org.apache.jasper.resources.LocalStrings, locale en_US > at > java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) > at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) > at java.util.ResourceBundle.getBundle(ResourceBundle.java:773) > at org.apache.jasper.compiler.Localizer.(Localizer.java:36) > at > org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:103) > at org.apache.jasper.JspC.initServletContext(JspC.java:1242) > at org.apache.jasper.JspC.execute(JspC.java:1103) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154) > at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) > at sun.reflect.GeneratedMethodAccessor122.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.Task.perform(Task.java:348) > at org.apache.tools.ant.Target.execute(Target.java:390) > at org.apache.tools.ant.Target.performTasks(Target.java:411) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1397) > at org.apache.tools.ant.Project.executeTarget(Project.java:1366) > at > org.apache.maven.plugin.antrun.AntRunMojo.execute(AntRunMojo.java:270) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > at > org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions(MojoExecutor.java:353) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:198) > at >
[jira] [Comment Edited] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265984#comment-16265984 ] Olaf Flebbe edited comment on HBASE-19188 at 11/26/17 12:39 PM: Ok : hbase-1.1.9 has other problems related to assembling the jar. hbase-1.1.12 works with this patch as well. I am not sure what happend yesterday: Maybe it was to late. Will propose to update hbase in bigtop to 1.1.12. Can confirm that this patch is needed for branch-1.3 as well and works here as well And while I am at it: Same for branch-1.4 And to add to the description of this JIRA: This patch is needed for branch-1.1 as well, cannot confirm not to be needed. Summary: LGTM +1 for this patch. was (Author: oflebbe): Ok : hbase-1.1.9 has other problems related to assembling the jar. hbase-1.1.12 works with this patch as well. I am not sure what happend yesterday: Maybe it was to late. Will propose to update hbase in bigtop to 1.1.12. Can confirm that this patch is needed for branch-1.3 as well and works here as well And while I am at it: Same for branch-1.4 Summary: LGTM +1 for this patch. > Build fails on branch-1 using maven-3.5.2 > - > > Key: HBASE-19188 > URL: https://issues.apache.org/jira/browse/HBASE-19188 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-19188.branch-1.2.001.patch > > > With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and > branch-1. On branch-1.1, branch-2 and master the build succeeds. With older > maven versions the build finishes. > {code:title=Maven version} > $ mvn -v > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m; > support was removed in 8.0 > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T09:58:13+02:00) > Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2 > Java version: 1.8.0_141, vendor: Oracle Corporation > Java home: > /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" > {code} > {code} > $ mvn clean install -DskipTests > ... > [INFO] --- jamon-maven-plugin:2.4.1:translate (default) @ hbase-server --- > [INFO] > [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-server --- > [INFO] Executing tasks > main: > log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC). > log4j:WARN Please initialize the log4j system properly. > log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more > info. > [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via > org.mortbay.log.Slf4jLog > java.util.MissingResourceException: Can't find bundle for base name > org.apache.jasper.resources.LocalStrings, locale en_US > at > java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) > at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) > at java.util.ResourceBundle.getBundle(ResourceBundle.java:773) > at org.apache.jasper.compiler.Localizer.(Localizer.java:36) > at > org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:103) > at org.apache.jasper.JspC.initServletContext(JspC.java:1242) > at org.apache.jasper.JspC.execute(JspC.java:1103) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154) > at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) > at sun.reflect.GeneratedMethodAccessor122.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.Task.perform(Task.java:348) > at org.apache.tools.ant.Target.execute(Target.java:390) > at org.apache.tools.ant.Target.performTasks(Target.java:411) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1397) > at org.apache.tools.ant.Project.executeTarget(Project.java:1366) > at >
[jira] [Comment Edited] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265984#comment-16265984 ] Olaf Flebbe edited comment on HBASE-19188 at 11/26/17 12:37 PM: Ok : hbase-1.1.9 has other problems related to assembling the jar. hbase-1.1.12 works with this patch as well. I am not sure what happend yesterday: Maybe it was to late. Will propose to update hbase in bigtop to 1.1.12. Can confirm that this patch is needed for branch-1.3 as well and works here as well And while I am at it: Same for branch-1.4 Summary: LGTM +1 for this patch. was (Author: oflebbe): Ok : hbase-1.1.9 has other problems related to assembling the jar. hbase-1.1.12 works with this patch as well. I am not sure what happend yesterday: Maybe it was to late. Will propose to update hbase in bigtop to 1.1.12. Can confirm that this patch is needed for branch-1.3 as well and works here as well Summary: LGTM +1 for this patch. > Build fails on branch-1 using maven-3.5.2 > - > > Key: HBASE-19188 > URL: https://issues.apache.org/jira/browse/HBASE-19188 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-19188.branch-1.2.001.patch > > > With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and > branch-1. On branch-1.1, branch-2 and master the build succeeds. With older > maven versions the build finishes. > {code:title=Maven version} > $ mvn -v > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m; > support was removed in 8.0 > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T09:58:13+02:00) > Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2 > Java version: 1.8.0_141, vendor: Oracle Corporation > Java home: > /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" > {code} > {code} > $ mvn clean install -DskipTests > ... > [INFO] --- jamon-maven-plugin:2.4.1:translate (default) @ hbase-server --- > [INFO] > [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-server --- > [INFO] Executing tasks > main: > log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC). > log4j:WARN Please initialize the log4j system properly. > log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more > info. > [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via > org.mortbay.log.Slf4jLog > java.util.MissingResourceException: Can't find bundle for base name > org.apache.jasper.resources.LocalStrings, locale en_US > at > java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) > at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) > at java.util.ResourceBundle.getBundle(ResourceBundle.java:773) > at org.apache.jasper.compiler.Localizer.(Localizer.java:36) > at > org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:103) > at org.apache.jasper.JspC.initServletContext(JspC.java:1242) > at org.apache.jasper.JspC.execute(JspC.java:1103) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154) > at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) > at sun.reflect.GeneratedMethodAccessor122.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.Task.perform(Task.java:348) > at org.apache.tools.ant.Target.execute(Target.java:390) > at org.apache.tools.ant.Target.performTasks(Target.java:411) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1397) > at org.apache.tools.ant.Project.executeTarget(Project.java:1366) > at > org.apache.maven.plugin.antrun.AntRunMojo.execute(AntRunMojo.java:270) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) > at >
[jira] [Comment Edited] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265984#comment-16265984 ] Olaf Flebbe edited comment on HBASE-19188 at 11/26/17 12:33 PM: Ok : hbase-1.1.9 has other problems related to assembling the jar. hbase-1.1.12 works with this patch as well. I am not sure what happend yesterday: Maybe it was to late. Will propose to update hbase in bigtop to 1.1.12. Can confirm that this patch is needed for branch-1.3 as well and works here as well Summary: LGTM +1 for this patch. was (Author: oflebbe): Ok : hbase-1.1.9 has other problems related to assembling the jar. hbase-1.1.12 works with this patch as well. I am not sure what happend yesterday: Maybe it was to late. Will propose to update hbase in bigtop to 1.1.12. Summary: LGTM +1 for this patch. > Build fails on branch-1 using maven-3.5.2 > - > > Key: HBASE-19188 > URL: https://issues.apache.org/jira/browse/HBASE-19188 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-19188.branch-1.2.001.patch > > > With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and > branch-1. On branch-1.1, branch-2 and master the build succeeds. With older > maven versions the build finishes. > {code:title=Maven version} > $ mvn -v > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m; > support was removed in 8.0 > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T09:58:13+02:00) > Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2 > Java version: 1.8.0_141, vendor: Oracle Corporation > Java home: > /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" > {code} > {code} > $ mvn clean install -DskipTests > ... > [INFO] --- jamon-maven-plugin:2.4.1:translate (default) @ hbase-server --- > [INFO] > [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-server --- > [INFO] Executing tasks > main: > log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC). > log4j:WARN Please initialize the log4j system properly. > log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more > info. > [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via > org.mortbay.log.Slf4jLog > java.util.MissingResourceException: Can't find bundle for base name > org.apache.jasper.resources.LocalStrings, locale en_US > at > java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) > at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) > at java.util.ResourceBundle.getBundle(ResourceBundle.java:773) > at org.apache.jasper.compiler.Localizer.(Localizer.java:36) > at > org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:103) > at org.apache.jasper.JspC.initServletContext(JspC.java:1242) > at org.apache.jasper.JspC.execute(JspC.java:1103) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154) > at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) > at sun.reflect.GeneratedMethodAccessor122.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.Task.perform(Task.java:348) > at org.apache.tools.ant.Target.execute(Target.java:390) > at org.apache.tools.ant.Target.performTasks(Target.java:411) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1397) > at org.apache.tools.ant.Project.executeTarget(Project.java:1366) > at > org.apache.maven.plugin.antrun.AntRunMojo.execute(AntRunMojo.java:270) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > at >
[jira] [Commented] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265984#comment-16265984 ] Olaf Flebbe commented on HBASE-19188: - Ok : hbase-1.1.9 has other problems related to assembling the jar. hbase-1.1.12 works with this patch as well. I am not sure what happend yesterday: Maybe it was to late. Will propose to update hbase in bigtop to 1.1.12. Summary: LGTM +1 for this patch. > Build fails on branch-1 using maven-3.5.2 > - > > Key: HBASE-19188 > URL: https://issues.apache.org/jira/browse/HBASE-19188 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-19188.branch-1.2.001.patch > > > With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and > branch-1. On branch-1.1, branch-2 and master the build succeeds. With older > maven versions the build finishes. > {code:title=Maven version} > $ mvn -v > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m; > support was removed in 8.0 > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T09:58:13+02:00) > Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2 > Java version: 1.8.0_141, vendor: Oracle Corporation > Java home: > /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" > {code} > {code} > $ mvn clean install -DskipTests > ... > [INFO] --- jamon-maven-plugin:2.4.1:translate (default) @ hbase-server --- > [INFO] > [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-server --- > [INFO] Executing tasks > main: > log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC). > log4j:WARN Please initialize the log4j system properly. > log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more > info. > [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via > org.mortbay.log.Slf4jLog > java.util.MissingResourceException: Can't find bundle for base name > org.apache.jasper.resources.LocalStrings, locale en_US > at > java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) > at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) > at java.util.ResourceBundle.getBundle(ResourceBundle.java:773) > at org.apache.jasper.compiler.Localizer.(Localizer.java:36) > at > org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:103) > at org.apache.jasper.JspC.initServletContext(JspC.java:1242) > at org.apache.jasper.JspC.execute(JspC.java:1103) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154) > at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) > at sun.reflect.GeneratedMethodAccessor122.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.Task.perform(Task.java:348) > at org.apache.tools.ant.Target.execute(Target.java:390) > at org.apache.tools.ant.Target.performTasks(Target.java:411) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1397) > at org.apache.tools.ant.Project.executeTarget(Project.java:1366) > at > org.apache.maven.plugin.antrun.AntRunMojo.execute(AntRunMojo.java:270) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > at > org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions(MojoExecutor.java:353) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:198) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) >
[jira] [Commented] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265982#comment-16265982 ] Olaf Flebbe commented on HBASE-19188: - And your patch works for branch-1.1 as well. Now testing 1.1.9 and 1.1.12 in my environment -- not ci.bigtop.apache.org > Build fails on branch-1 using maven-3.5.2 > - > > Key: HBASE-19188 > URL: https://issues.apache.org/jira/browse/HBASE-19188 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-19188.branch-1.2.001.patch > > > With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and > branch-1. On branch-1.1, branch-2 and master the build succeeds. With older > maven versions the build finishes. > {code:title=Maven version} > $ mvn -v > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m; > support was removed in 8.0 > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T09:58:13+02:00) > Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2 > Java version: 1.8.0_141, vendor: Oracle Corporation > Java home: > /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" > {code} > {code} > $ mvn clean install -DskipTests > ... > [INFO] --- jamon-maven-plugin:2.4.1:translate (default) @ hbase-server --- > [INFO] > [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-server --- > [INFO] Executing tasks > main: > log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC). > log4j:WARN Please initialize the log4j system properly. > log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more > info. > [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via > org.mortbay.log.Slf4jLog > java.util.MissingResourceException: Can't find bundle for base name > org.apache.jasper.resources.LocalStrings, locale en_US > at > java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) > at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) > at java.util.ResourceBundle.getBundle(ResourceBundle.java:773) > at org.apache.jasper.compiler.Localizer.(Localizer.java:36) > at > org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:103) > at org.apache.jasper.JspC.initServletContext(JspC.java:1242) > at org.apache.jasper.JspC.execute(JspC.java:1103) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154) > at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) > at sun.reflect.GeneratedMethodAccessor122.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.Task.perform(Task.java:348) > at org.apache.tools.ant.Target.execute(Target.java:390) > at org.apache.tools.ant.Target.performTasks(Target.java:411) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1397) > at org.apache.tools.ant.Project.executeTarget(Project.java:1366) > at > org.apache.maven.plugin.antrun.AntRunMojo.execute(AntRunMojo.java:270) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > at > org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions(MojoExecutor.java:353) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:198) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > at >
[jira] [Commented] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265980#comment-16265980 ] Olaf Flebbe commented on HBASE-19188: - [~psomogyi] : I can confirm that your patch https://issues.apache.org/jira/secure/attachment/12899291/HBASE-19188.branch-1.2.001.patch works on branch-1.2 Now going back to branch-1.1 > Build fails on branch-1 using maven-3.5.2 > - > > Key: HBASE-19188 > URL: https://issues.apache.org/jira/browse/HBASE-19188 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-19188.branch-1.2.001.patch > > > With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and > branch-1. On branch-1.1, branch-2 and master the build succeeds. With older > maven versions the build finishes. > {code:title=Maven version} > $ mvn -v > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m; > support was removed in 8.0 > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T09:58:13+02:00) > Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2 > Java version: 1.8.0_141, vendor: Oracle Corporation > Java home: > /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" > {code} > {code} > $ mvn clean install -DskipTests > ... > [INFO] --- jamon-maven-plugin:2.4.1:translate (default) @ hbase-server --- > [INFO] > [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-server --- > [INFO] Executing tasks > main: > log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC). > log4j:WARN Please initialize the log4j system properly. > log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more > info. > [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via > org.mortbay.log.Slf4jLog > java.util.MissingResourceException: Can't find bundle for base name > org.apache.jasper.resources.LocalStrings, locale en_US > at > java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) > at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) > at java.util.ResourceBundle.getBundle(ResourceBundle.java:773) > at org.apache.jasper.compiler.Localizer.(Localizer.java:36) > at > org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:103) > at org.apache.jasper.JspC.initServletContext(JspC.java:1242) > at org.apache.jasper.JspC.execute(JspC.java:1103) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154) > at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) > at sun.reflect.GeneratedMethodAccessor122.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.Task.perform(Task.java:348) > at org.apache.tools.ant.Target.execute(Target.java:390) > at org.apache.tools.ant.Target.performTasks(Target.java:411) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1397) > at org.apache.tools.ant.Project.executeTarget(Project.java:1366) > at > org.apache.maven.plugin.antrun.AntRunMojo.execute(AntRunMojo.java:270) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > at > org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions(MojoExecutor.java:353) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:198) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > at >
[jira] [Comment Edited] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265976#comment-16265976 ] Olaf Flebbe edited comment on HBASE-19188 at 11/26/17 12:15 PM: [~psomogyi] : The patch I proposed seems not to work on top of the bigtop version. 1.1.9 {code} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.6:run (generate) on project hbase-server: An Ant BuildException has occured: java.lang.NoSuchFieldError: STANDARD_IMPORTS -> [Help 1] [ERROR] {code} I retest your patch on branch-1.2 in a minute (but I am quite sure that compile will fail in hbase-thrift ). was (Author: oflebbe): [~psomogyi] : The patch I proposed seems not to work on top of the bigtop version. 1.4 {code} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.6:run (generate) on project hbase-server: An Ant BuildException has occured: java.lang.NoSuchFieldError: STANDARD_IMPORTS -> [Help 1] [ERROR] {code} I retest your patch on branch-1.2 in a minute (but I am quite sure that compile will fail in hbase-thrift ). > Build fails on branch-1 using maven-3.5.2 > - > > Key: HBASE-19188 > URL: https://issues.apache.org/jira/browse/HBASE-19188 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-19188.branch-1.2.001.patch > > > With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and > branch-1. On branch-1.1, branch-2 and master the build succeeds. With older > maven versions the build finishes. > {code:title=Maven version} > $ mvn -v > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m; > support was removed in 8.0 > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T09:58:13+02:00) > Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2 > Java version: 1.8.0_141, vendor: Oracle Corporation > Java home: > /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" > {code} > {code} > $ mvn clean install -DskipTests > ... > [INFO] --- jamon-maven-plugin:2.4.1:translate (default) @ hbase-server --- > [INFO] > [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-server --- > [INFO] Executing tasks > main: > log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC). > log4j:WARN Please initialize the log4j system properly. > log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more > info. > [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via > org.mortbay.log.Slf4jLog > java.util.MissingResourceException: Can't find bundle for base name > org.apache.jasper.resources.LocalStrings, locale en_US > at > java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) > at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) > at java.util.ResourceBundle.getBundle(ResourceBundle.java:773) > at org.apache.jasper.compiler.Localizer.(Localizer.java:36) > at > org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:103) > at org.apache.jasper.JspC.initServletContext(JspC.java:1242) > at org.apache.jasper.JspC.execute(JspC.java:1103) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154) > at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) > at sun.reflect.GeneratedMethodAccessor122.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.Task.perform(Task.java:348) > at org.apache.tools.ant.Target.execute(Target.java:390) > at org.apache.tools.ant.Target.performTasks(Target.java:411) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1397) > at org.apache.tools.ant.Project.executeTarget(Project.java:1366) > at >
[jira] [Comment Edited] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265976#comment-16265976 ] Olaf Flebbe edited comment on HBASE-19188 at 11/26/17 11:56 AM: [~psomogyi] : The patch I proposed seems not to work on top of the bigtop version. 1.4 {code} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.6:run (generate) on project hbase-server: An Ant BuildException has occured: java.lang.NoSuchFieldError: STANDARD_IMPORTS -> [Help 1] [ERROR] {code} I retest your patch on branch-1.2 in a minute (but I am quite sure that compile will fail in hbase-thrift ). was (Author: oflebbe): [~psomogyi] : The patch I proposed seems not to work on top of the bigtop version. 1.4 {code} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.6:run (generate) on project hbase-server: An Ant BuildException has occured: java.lang.NoSuchFieldError: STANDARD_IMPORTS -> [Help 1] [ERROR] {code} I retest your patch on branch-1.2 in a minute. I will now test branch-1.2 from git with your patch attached (but I am quite sure that compile will fail in hbase-thrift ). And yes the > Build fails on branch-1 using maven-3.5.2 > - > > Key: HBASE-19188 > URL: https://issues.apache.org/jira/browse/HBASE-19188 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-19188.branch-1.2.001.patch > > > With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and > branch-1. On branch-1.1, branch-2 and master the build succeeds. With older > maven versions the build finishes. > {code:title=Maven version} > $ mvn -v > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m; > support was removed in 8.0 > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T09:58:13+02:00) > Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2 > Java version: 1.8.0_141, vendor: Oracle Corporation > Java home: > /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" > {code} > {code} > $ mvn clean install -DskipTests > ... > [INFO] --- jamon-maven-plugin:2.4.1:translate (default) @ hbase-server --- > [INFO] > [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-server --- > [INFO] Executing tasks > main: > log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC). > log4j:WARN Please initialize the log4j system properly. > log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more > info. > [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via > org.mortbay.log.Slf4jLog > java.util.MissingResourceException: Can't find bundle for base name > org.apache.jasper.resources.LocalStrings, locale en_US > at > java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) > at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) > at java.util.ResourceBundle.getBundle(ResourceBundle.java:773) > at org.apache.jasper.compiler.Localizer.(Localizer.java:36) > at > org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:103) > at org.apache.jasper.JspC.initServletContext(JspC.java:1242) > at org.apache.jasper.JspC.execute(JspC.java:1103) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154) > at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) > at sun.reflect.GeneratedMethodAccessor122.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.Task.perform(Task.java:348) > at org.apache.tools.ant.Target.execute(Target.java:390) > at org.apache.tools.ant.Target.performTasks(Target.java:411) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1397) > at org.apache.tools.ant.Project.executeTarget(Project.java:1366) >
[jira] [Commented] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265976#comment-16265976 ] Olaf Flebbe commented on HBASE-19188: - [~psomogyi] : The patch I proposed seems not to work on top of the bigtop version. 1.4 {code} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.6:run (generate) on project hbase-server: An Ant BuildException has occured: java.lang.NoSuchFieldError: STANDARD_IMPORTS -> [Help 1] [ERROR] {code} I retest your patch on branch-1.2 in a minute. I will now test branch-1.2 from git with your patch attached (but I am quite sure that compile will fail in hbase-thrift ). And yes the > Build fails on branch-1 using maven-3.5.2 > - > > Key: HBASE-19188 > URL: https://issues.apache.org/jira/browse/HBASE-19188 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-19188.branch-1.2.001.patch > > > With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and > branch-1. On branch-1.1, branch-2 and master the build succeeds. With older > maven versions the build finishes. > {code:title=Maven version} > $ mvn -v > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m; > support was removed in 8.0 > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T09:58:13+02:00) > Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2 > Java version: 1.8.0_141, vendor: Oracle Corporation > Java home: > /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" > {code} > {code} > $ mvn clean install -DskipTests > ... > [INFO] --- jamon-maven-plugin:2.4.1:translate (default) @ hbase-server --- > [INFO] > [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-server --- > [INFO] Executing tasks > main: > log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC). > log4j:WARN Please initialize the log4j system properly. > log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more > info. > [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via > org.mortbay.log.Slf4jLog > java.util.MissingResourceException: Can't find bundle for base name > org.apache.jasper.resources.LocalStrings, locale en_US > at > java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) > at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) > at java.util.ResourceBundle.getBundle(ResourceBundle.java:773) > at org.apache.jasper.compiler.Localizer.(Localizer.java:36) > at > org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:103) > at org.apache.jasper.JspC.initServletContext(JspC.java:1242) > at org.apache.jasper.JspC.execute(JspC.java:1103) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154) > at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) > at sun.reflect.GeneratedMethodAccessor122.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.Task.perform(Task.java:348) > at org.apache.tools.ant.Target.execute(Target.java:390) > at org.apache.tools.ant.Target.performTasks(Target.java:411) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1397) > at org.apache.tools.ant.Project.executeTarget(Project.java:1366) > at > org.apache.maven.plugin.antrun.AntRunMojo.execute(AntRunMojo.java:270) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > at >
[jira] [Updated] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-19188: -- Attachment: HBASE-19188.branch-1.2.001.patch Attached patch for branch-1.2. This patch will need manual testing since QA does not use maven-3.5.2 where the failure happens. > Build fails on branch-1 using maven-3.5.2 > - > > Key: HBASE-19188 > URL: https://issues.apache.org/jira/browse/HBASE-19188 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-19188.branch-1.2.001.patch > > > With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and > branch-1. On branch-1.1, branch-2 and master the build succeeds. With older > maven versions the build finishes. > {code:title=Maven version} > $ mvn -v > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m; > support was removed in 8.0 > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T09:58:13+02:00) > Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2 > Java version: 1.8.0_141, vendor: Oracle Corporation > Java home: > /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" > {code} > {code} > $ mvn clean install -DskipTests > ... > [INFO] --- jamon-maven-plugin:2.4.1:translate (default) @ hbase-server --- > [INFO] > [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-server --- > [INFO] Executing tasks > main: > log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC). > log4j:WARN Please initialize the log4j system properly. > log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more > info. > [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via > org.mortbay.log.Slf4jLog > java.util.MissingResourceException: Can't find bundle for base name > org.apache.jasper.resources.LocalStrings, locale en_US > at > java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) > at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) > at java.util.ResourceBundle.getBundle(ResourceBundle.java:773) > at org.apache.jasper.compiler.Localizer.(Localizer.java:36) > at > org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:103) > at org.apache.jasper.JspC.initServletContext(JspC.java:1242) > at org.apache.jasper.JspC.execute(JspC.java:1103) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154) > at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) > at sun.reflect.GeneratedMethodAccessor122.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.Task.perform(Task.java:348) > at org.apache.tools.ant.Target.execute(Target.java:390) > at org.apache.tools.ant.Target.performTasks(Target.java:411) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1397) > at org.apache.tools.ant.Project.executeTarget(Project.java:1366) > at > org.apache.maven.plugin.antrun.AntRunMojo.execute(AntRunMojo.java:270) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > at > org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions(MojoExecutor.java:353) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:198) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > at >
[jira] [Updated] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-19188: -- Status: Patch Available (was: Open) > Build fails on branch-1 using maven-3.5.2 > - > > Key: HBASE-19188 > URL: https://issues.apache.org/jira/browse/HBASE-19188 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 1.2.6, 1.3.1, 1.4.0, 1.5.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-19188.branch-1.2.001.patch > > > With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and > branch-1. On branch-1.1, branch-2 and master the build succeeds. With older > maven versions the build finishes. > {code:title=Maven version} > $ mvn -v > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m; > support was removed in 8.0 > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T09:58:13+02:00) > Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2 > Java version: 1.8.0_141, vendor: Oracle Corporation > Java home: > /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" > {code} > {code} > $ mvn clean install -DskipTests > ... > [INFO] --- jamon-maven-plugin:2.4.1:translate (default) @ hbase-server --- > [INFO] > [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-server --- > [INFO] Executing tasks > main: > log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC). > log4j:WARN Please initialize the log4j system properly. > log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more > info. > [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via > org.mortbay.log.Slf4jLog > java.util.MissingResourceException: Can't find bundle for base name > org.apache.jasper.resources.LocalStrings, locale en_US > at > java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) > at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) > at java.util.ResourceBundle.getBundle(ResourceBundle.java:773) > at org.apache.jasper.compiler.Localizer.(Localizer.java:36) > at > org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:103) > at org.apache.jasper.JspC.initServletContext(JspC.java:1242) > at org.apache.jasper.JspC.execute(JspC.java:1103) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154) > at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) > at sun.reflect.GeneratedMethodAccessor122.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.Task.perform(Task.java:348) > at org.apache.tools.ant.Target.execute(Target.java:390) > at org.apache.tools.ant.Target.performTasks(Target.java:411) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1397) > at org.apache.tools.ant.Project.executeTarget(Project.java:1366) > at > org.apache.maven.plugin.antrun.AntRunMojo.execute(AntRunMojo.java:270) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > at > org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions(MojoExecutor.java:353) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:198) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117) > at >
[jira] [Commented] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265974#comment-16265974 ] Peter Somogyi commented on HBASE-19188: --- I'm not sure if we need it for all modules. Probably adding it to the ones that invoke ANT with JspC would be sufficient. These are hbase-server, hbase-thrift and hbase-rest. For me the build succeeds if I modify the scope only in hbase-server by running {{mvn clean install -DskipTests}} using hbase branch-1.2. [~oflebbe], any guess why it still fails for you that way? > Build fails on branch-1 using maven-3.5.2 > - > > Key: HBASE-19188 > URL: https://issues.apache.org/jira/browse/HBASE-19188 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > > With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and > branch-1. On branch-1.1, branch-2 and master the build succeeds. With older > maven versions the build finishes. > {code:title=Maven version} > $ mvn -v > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m; > support was removed in 8.0 > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T09:58:13+02:00) > Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2 > Java version: 1.8.0_141, vendor: Oracle Corporation > Java home: > /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" > {code} > {code} > $ mvn clean install -DskipTests > ... > [INFO] --- jamon-maven-plugin:2.4.1:translate (default) @ hbase-server --- > [INFO] > [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-server --- > [INFO] Executing tasks > main: > log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC). > log4j:WARN Please initialize the log4j system properly. > log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more > info. > [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via > org.mortbay.log.Slf4jLog > java.util.MissingResourceException: Can't find bundle for base name > org.apache.jasper.resources.LocalStrings, locale en_US > at > java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) > at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) > at java.util.ResourceBundle.getBundle(ResourceBundle.java:773) > at org.apache.jasper.compiler.Localizer.(Localizer.java:36) > at > org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:103) > at org.apache.jasper.JspC.initServletContext(JspC.java:1242) > at org.apache.jasper.JspC.execute(JspC.java:1103) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154) > at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) > at sun.reflect.GeneratedMethodAccessor122.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) > at org.apache.tools.ant.Task.perform(Task.java:348) > at org.apache.tools.ant.Target.execute(Target.java:390) > at org.apache.tools.ant.Target.performTasks(Target.java:411) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1397) > at org.apache.tools.ant.Project.executeTarget(Project.java:1366) > at > org.apache.maven.plugin.antrun.AntRunMojo.execute(AntRunMojo.java:270) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > at > org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions(MojoExecutor.java:353) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:198) > at >
[jira] [Commented] (HBASE-18112) Write RequestTooBigException back to client for NettyRpcServer
[ https://issues.apache.org/jira/browse/HBASE-18112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265971#comment-16265971 ] Toshihiro Suzuki commented on HBASE-18112: -- Sure [~Apache9]. Thanks. > Write RequestTooBigException back to client for NettyRpcServer > -- > > Key: HBASE-18112 > URL: https://issues.apache.org/jira/browse/HBASE-18112 > Project: HBase > Issue Type: Sub-task > Components: IPC/RPC >Reporter: Duo Zhang >Assignee: Toshihiro Suzuki > Attachments: HBASE-18112-v2.patch, HBASE-18112-v2.patch, > HBASE-18112-v2.patch, HBASE-18112-v3.patch, HBASE-18112-v3.patch, > HBASE-18112-v4.patch, HBASE-18112.patch > > > For now we just close the connection so NettyRpcServer can not pass TestIPC. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19204) branch-1.2 times out and is taking 6-7 hours to complete
[ https://issues.apache.org/jira/browse/HBASE-19204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265968#comment-16265968 ] Chia-Ping Tsai commented on HBASE-19204: bq. The JVM we use for JDK7 builds in hadoopqa seems to be native ubuntu 14.04: The JVM we used is changed from oracle-jdk-7u80 to openjdk-7. see HBASE-18159. . The latest version of openjdk-7 in ubuntu-trusty is 7u151-2.6.11. (see [ubuntu package|https://packages.ubuntu.com/trusty/openjdk-7-jdk]. Unfortunately, 7u151 is what may cause the hang in {{Jetty}}. > branch-1.2 times out and is taking 6-7 hours to complete > > > Key: HBASE-19204 > URL: https://issues.apache.org/jira/browse/HBASE-19204 > Project: HBase > Issue Type: Umbrella > Components: test >Reporter: stack > Attachments: HBASE-19024.branch-1.2.002.patch > > > Sean has been looking at tooling and infra. This Umbrellas is about looking > at actual tests. For example, running locally on dedicated machine I picked a > random test, TestPerColumnFamilyFlush. In my test run, it wrote 16M lines. It > seems to be having zk issues but it is catching interrupts and ignoring them > ([~carp84] fixed this in later versions over in HBASE-18441). > Let me try and do some fixup under this umbrella so we can get a 1.2.7 out > the door. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19346) Use EventLoopGroup to create AsyncFSOutput
Duo Zhang created HBASE-19346: - Summary: Use EventLoopGroup to create AsyncFSOutput Key: HBASE-19346 URL: https://issues.apache.org/jira/browse/HBASE-19346 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang Assignee: Duo Zhang Fix For: 2.0.0-beta-1 So that we can use different event loop to manage the connections to different datanodes. And since EventLoop itself is also an EventLoopGroup, we could still use the event loop to create AsyncFSOutput so the logic of AsyncFSWAL will not be broken. Will open a new issue to modify AsyncFSWAL and finally we can use multiple event loop. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19336) Improve rsgroup to allow assign all tables within a specified namespace by only writing namespace
[ https://issues.apache.org/jira/browse/HBASE-19336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265951#comment-16265951 ] Guanghao Zhang commented on HBASE-19336: The patch didn't add ut for move_servers_namespaces_rsgroup? > Improve rsgroup to allow assign all tables within a specified namespace by > only writing namespace > - > > Key: HBASE-19336 > URL: https://issues.apache.org/jira/browse/HBASE-19336 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Affects Versions: 2.0.0-alpha-4 >Reporter: xinxin fan >Assignee: xinxin fan > Attachments: HBASE-19336-master-V2.patch, > HBASE-19336-master-V3.patch, HBASE-19336-master.patch > > > Currently, use can only assign tables within a namespace from one group to > another by writing all table names in move_tables_rsgroup command. Allowing > to assign all tables within a specifed namespace by only wirting namespace > name is useful. > Usage as follows: > {code:java} > hbase(main):055:0> move_namespaces_rsgroup 'dest_rsgroup',['ns1'] > Took 2.2211 seconds > {code} > {code:java} > hbase(main):051:0* move_servers_namespaces_rsgroup > 'dest_rsgroup',['hbase39.lt.163.org:60020'],['ns1','ns2'] > Took 15.3710 seconds > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19344) improve asyncWAL by using Independent thread for netty #IO in FanOutOneBlockAsyncDFSOutput
[ https://issues.apache.org/jira/browse/HBASE-19344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265950#comment-16265950 ] Duo Zhang commented on HBASE-19344: --- Talked with [~chancelq] offline and we have done more tests. Seems the reason is not sharing event loop with others, but we only use one thread for every thing in AsyncFSWAL and AsyncDFSOutput so the thread is over loaded. He will put all the tests results later since he losses the connection to the world out of China temporarily... For me, I will start working on implementing the new logic described in the POC. As said above it is not straight-forward for fail recovery. Thanks. > improve asyncWAL by using Independent thread for netty #IO in > FanOutOneBlockAsyncDFSOutput > --- > > Key: HBASE-19344 > URL: https://issues.apache.org/jira/browse/HBASE-19344 > Project: HBase > Issue Type: Sub-task > Components: wal >Affects Versions: 2.0.0-beta-1 >Reporter: Chance Li >Assignee: Chance Li > Fix For: 2.0.0 > > Attachments: HBASE-19344-branch2.patch, > HBASE-19344-branch2.patch.2.POC, wal-1-test-result.png, > wal-8-test-result.png, ycsb_result_apache20_async_wal.pdf > > > The logic now is that the netty #IO thread and asyncWal's thread are the same > one. > Improvement proposal: > 1, Split into two. > 2, All multiWal share the netty #IO thread pool. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18112) Write RequestTooBigException back to client for NettyRpcServer
[ https://issues.apache.org/jira/browse/HBASE-18112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265947#comment-16265947 ] Duo Zhang commented on HBASE-18112: --- Seems the pre commit job is broken and It's thanks-giving is the US so let's wait a while... Maybe Monday they will fix the job. Thanks for your patience [~brfrn169]. > Write RequestTooBigException back to client for NettyRpcServer > -- > > Key: HBASE-18112 > URL: https://issues.apache.org/jira/browse/HBASE-18112 > Project: HBase > Issue Type: Sub-task > Components: IPC/RPC >Reporter: Duo Zhang >Assignee: Toshihiro Suzuki > Attachments: HBASE-18112-v2.patch, HBASE-18112-v2.patch, > HBASE-18112-v2.patch, HBASE-18112-v3.patch, HBASE-18112-v3.patch, > HBASE-18112-v4.patch, HBASE-18112.patch > > > For now we just close the connection so NettyRpcServer can not pass TestIPC. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265945#comment-16265945 ] Eshcar Hillel commented on HBASE-18294: --- Ram and Anoop, the reason we see so much heap global pressure is that the regions themselves are not conservative enough to make flush decisions early on. *Changing default values is not a way to fix this inherent problem*: (1) Reducing the threshold may solve the problem for some setting but will not solve it for other settings. For example, in the same experiment if we have the threshold set to 64MB but with twice as much regions we will see the same affect. (2) There are claims pro reducing memstore size like for reducing GC, but there are also claims pro increasing the size to reduce number of flushes, reduce number of compactions and reduce write amplification. (3) In addition, even if we change the default values the system should have optimal performance with the values set by the admin which can be any number. The core changes in this patch focus on the mechanism and decision making for region level flushes, namely evaluate total heap size instead of data size only. The changes at the region server accounting level are mainly cosmetic changes, to make on-heap and off-heap symmetric (why should we ignore the CCM index when it is allocated off-heap, even if it is small, if we can count it the same way we count the CAM index for on-heap?). And I think the changes are not that dramatic about 20 lines of code in {{RegionServerAccounting}}, they do not complicate things much. Can we in-parallel to the discussion here continue with concrete comments on the code in RB so we can converge towards commit. Thanks > Reduce global heap pressure: flush based on heap occupancy > -- > > Key: HBASE-18294 > URL: https://issues.apache.org/jira/browse/HBASE-18294 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Eshcar Hillel >Assignee: Eshcar Hillel > Attachments: HBASE-18294.01.patch, HBASE-18294.02.patch, > HBASE-18294.03.patch, HBASE-18294.04.patch, HBASE-18294.05.patch, > HBASE-18294.06.patch > > > A region is flushed if its memory component exceed a threshold (default size > is 128MB). > A flush policy decides whether to flush a store by comparing the size of the > store to another threshold (that can be configured with > hbase.hregion.percolumnfamilyflush.size.lower.bound). > Currently the implementation (in both cases) compares the data size > (key-value only) to the threshold where it should compare the heap size > (which includes index size, and metadata). -- This message was sent by Atlassian JIRA (v6.4.14#64029)