[jira] [Commented] (HBASE-19112) Suspect methods on Cell to be deprecated
[
https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285129#comment-16285129
]
Anoop Sam John commented on HBASE-19112:
Ya seems like that is the best option. We can have the getType() in Cell and
the Enum also moved to Cell. So this will have only the Put and 3 Delete
types. We have the max/min internal types also. As of now it is ok as we have
deprecated getTypeByte() also and the server code uses that for the compare.
There we can get the fake cells. So those Cells what it will return for the
new getType() enum? We dont have enum types for min and max? Also we can not
extend an Enum. Or else it would have been possible by RawCell's override the
getType by returning an extended type.. So may be the Type can be an
Interface? Cell return an interface type which is having only Put and Delete
types. There is an extended Type interface which include the internal types
also. And the RawCell override the getType by returning the Extended Interface
type. (?)
> Suspect methods on Cell to be deprecated
>
>
> Key: HBASE-19112
> URL: https://issues.apache.org/jira/browse/HBASE-19112
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: Josh Elser
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19112_branch-2.patch
>
>
> [~chia7712] suggested on the [mailing
> list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E]
> that we have some methods on Cell which should be deprecated for removal:
> * {{#getType()}}
> * {{#getTimestamp()}}
> * {{#getTag()}}
> * {{#getSequenceId()}}
> Let's make a pass over these (and maybe the rest) to make sure that there
> aren't others which are either implementation details or methods returning
> now-private-marked classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19112) Suspect methods on Cell to be deprecated
[
https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285083#comment-16285083
]
Chia-Ping Tsai commented on HBASE-19112:
I agree on adding the DataType to Cell since it is the acceptable solution in
2.0. It still expose the stuff which is particular of KeyValue but it should be
ok in 2.0 since we allow user to get the type via public CellUtil.
The #2 is what I intend to accomplish in 3.0 or 2.1 since it can simplify our
Delete which is not friendly to be used for user - Even us had misused it in
shell. See HBASE-18142. If user want to do the multi-deletes on same row or in
single rpc, the RowMutation is the alternative way.
The #3 will make the Delete be more complicated.
The RawCell should be added in 2.0 for cp user, and we haven’t prepare to
introduce it to client. So the #4 is excluded.
bq. What to be done in here.
Ram is not available over the weekend. :)
Personally, we should 1) deprecate the getter of seqid and tag in Cell. And 2)
introduce the RawCell having the deprecated APIs explicitly.
> Suspect methods on Cell to be deprecated
>
>
> Key: HBASE-19112
> URL: https://issues.apache.org/jira/browse/HBASE-19112
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: Josh Elser
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19112_branch-2.patch
>
>
> [~chia7712] suggested on the [mailing
> list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E]
> that we have some methods on Cell which should be deprecated for removal:
> * {{#getType()}}
> * {{#getTimestamp()}}
> * {{#getTag()}}
> * {{#getSequenceId()}}
> Let's make a pass over these (and maybe the rest) to make sure that there
> aren't others which are either implementation details or methods returning
> now-private-marked classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19473) Review of ClientScanner Class
[
https://issues.apache.org/jira/browse/HBASE-19473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285070#comment-16285070
]
Hadoop QA commented on HBASE-19473:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
0s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
40s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
55m 11s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
38s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 74m 49s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19473 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12901386/HBASE-19473.1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 7babe9c2fa93 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 3eb87802c8 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10320/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10320/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Review of ClientScanner Class
>
[jira] [Commented] (HBASE-19472) Remove ArrayUtil Class
[
https://issues.apache.org/jira/browse/HBASE-19472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285066#comment-16285066
]
Hadoop QA commented on HBASE-19472:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
7s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
24s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
58s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} hbase-common: The patch generated 0 new + 9
unchanged - 2 fixed = 9 total (was 11) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} hbase-client: The patch generated 0 new + 6
unchanged - 1 fixed = 6 total (was 7) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
16s{color} | {color:red} hbase-mapreduce: The patch generated 1 new + 2
unchanged - 1 fixed = 3 total (was 3) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} The patch hbase-endpoint passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
13s{color} | {color:red} hbase-backup: The patch generated 1 new + 24 unchanged
- 1 fixed = 25 total (was 25) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
22s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
52m 1s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
22s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
17s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
35s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m
50s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} |
[jira] [Commented] (HBASE-16890) Analyze the performance of AsyncWAL and fix the same
[ https://issues.apache.org/jira/browse/HBASE-16890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285065#comment-16285065 ] stack commented on HBASE-16890: --- 24 threads ||workload||OldFSHLog||asyncfs||acyncfs+own_eventloop|| |loadinga|9483 ops/s|12659 ops/s|15676 ops/| |workloada 50/50|17982 ops/s|29572 ops/s|21815 ops/s| |workloadw 85/15|12851 ops/s|25604 ops/s|25503 ops/s| hbase.wal.async.use-shared-event-loop doesn't seem to help here or when 48 threads. Better than old FSHLog. > Analyze the performance of AsyncWAL and fix the same > > > Key: HBASE-16890 > URL: https://issues.apache.org/jira/browse/HBASE-16890 > Project: HBase > Issue Type: Sub-task > Components: wal >Affects Versions: 2.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Blocker > Fix For: 2.0.0-beta-1 > > Attachments: AsyncWAL_disruptor.patch, AsyncWAL_disruptor_1 > (2).patch, AsyncWAL_disruptor_3.patch, AsyncWAL_disruptor_3.patch, > AsyncWAL_disruptor_4.patch, AsyncWAL_disruptor_6.patch, > HBASE-16890-rc-v2.patch, HBASE-16890-rc-v3.patch, > HBASE-16890-remove-contention-v1.patch, HBASE-16890-remove-contention.patch, > Screen Shot 2016-10-25 at 7.34.47 PM.png, Screen Shot 2016-10-25 at 7.39.07 > PM.png, Screen Shot 2016-10-25 at 7.39.48 PM.png, Screen Shot 2016-11-04 at > 5.21.27 PM.png, Screen Shot 2016-11-04 at 5.30.18 PM.png, async.svg, > classic.svg, contention.png, contention_defaultWAL.png, > ycsb_FSHlog.vs.Async.png > > > Tests reveal that AsyncWAL under load in single node cluster performs slower > than the Default WAL. This task is to analyze and see if we could fix it. > See some discussions in the tail of JIRA HBASE-15536. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15482) Provide an option to skip calculating block locations for SnapshotInputFormat
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285062#comment-16285062
]
Jerry He commented on HBASE-15482:
--
The patch looks good!
I just think the first patch 000 is cleaner. But, as Ted suggested, change
hbase.TableSnapshotInputFormat.locality to
hbase.TableSnapshotInputFormat.locality.enable. (Change the name
SNAPSHOT_INPUTFORMAT_CARE_BLOCK_LOCALITY_KEY too). The other changes look
unnecessary except making it more complicated.
{code}
if (careBlockLocality) {
Assert.assertTrue(split.getLocations() != null && split.getLocations().length
!= 0);
} else {
Assert.assertTrue(split.getLocations() != null && split.getLocations().length
== 0);
}
{code}
This is ok too. The first test is an existing test, and it has not failed
previously.
> Provide an option to skip calculating block locations for SnapshotInputFormat
> -
>
> Key: HBASE-15482
> URL: https://issues.apache.org/jira/browse/HBASE-15482
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce
>Reporter: Liyin Tang
>Assignee: Xiang Li
>Priority: Minor
> Fix For: 2.1.0
>
> Attachments: HBASE-15482.master.000.patch,
> HBASE-15482.master.001.patch, HBASE-15482.master.002.patch
>
>
> When a MR job is reading from SnapshotInputFormat, it needs to calculate the
> splits based on the block locations in order to get best locality. However,
> this process may take a long time for large snapshots.
> In some setup, the computing layer, Spark, Hive or Presto could run out side
> of HBase cluster. In these scenarios, the block locality doesn't matter.
> Therefore, it will be great to have an option to skip calculating the block
> locations for every job. That will super useful for the Hive/Presto/Spark
> connectors.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19473) Review of ClientScanner Class
[
https://issues.apache.org/jira/browse/HBASE-19473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated HBASE-19473:
Status: Patch Available (was: Open)
> Review of ClientScanner Class
> -
>
> Key: HBASE-19473
> URL: https://issues.apache.org/jira/browse/HBASE-19473
> Project: HBase
> Issue Type: Improvement
> Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Attachments: HBASE-19473.1.patch
>
>
> # Remove superfluous logging code guard
> # Simplify some of the code
> # Use ArrayDeque instead of LinkedList for queue implementation
> https://docs.oracle.com/javase/8/docs/api/index.html?java/util/ArrayDeque.html
> {quote}
> Resizable-array implementation of the Deque interface. Array deques have no
> capacity restrictions; they grow as necessary to support usage. They are not
> thread-safe; in the absence of external synchronization, they do not support
> concurrent access by multiple threads. Null elements are prohibited. This
> class is likely to be faster than Stack when used as a stack, and *faster
> than LinkedList when used as a queue.*
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19473) Review of ClientScanner Class
[
https://issues.apache.org/jira/browse/HBASE-19473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated HBASE-19473:
Attachment: HBASE-19473.1.patch
> Review of ClientScanner Class
> -
>
> Key: HBASE-19473
> URL: https://issues.apache.org/jira/browse/HBASE-19473
> Project: HBase
> Issue Type: Improvement
> Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Attachments: HBASE-19473.1.patch
>
>
> # Remove superfluous logging code guard
> # Simplify some of the code
> # Use ArrayDeque instead of LinkedList for queue implementation
> https://docs.oracle.com/javase/8/docs/api/index.html?java/util/ArrayDeque.html
> {quote}
> Resizable-array implementation of the Deque interface. Array deques have no
> capacity restrictions; they grow as necessary to support usage. They are not
> thread-safe; in the absence of external synchronization, they do not support
> concurrent access by multiple threads. Null elements are prohibited. This
> class is likely to be faster than Stack when used as a stack, and *faster
> than LinkedList when used as a queue.*
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-19473) Review of ClientScanner
BELUGA BEHR created HBASE-19473:
---
Summary: Review of ClientScanner
Key: HBASE-19473
URL: https://issues.apache.org/jira/browse/HBASE-19473
Project: HBase
Issue Type: Improvement
Components: hbase
Affects Versions: 3.0.0
Reporter: BELUGA BEHR
Assignee: BELUGA BEHR
Priority: Trivial
# Remove superfluous logging code guard
# Simplify some of the code
# Use ArrayDeque instead of LinkedList for queue implementation
https://docs.oracle.com/javase/8/docs/api/index.html?java/util/ArrayDeque.html
{quote}
Resizable-array implementation of the Deque interface. Array deques have no
capacity restrictions; they grow as necessary to support usage. They are not
thread-safe; in the absence of external synchronization, they do not support
concurrent access by multiple threads. Null elements are prohibited. This class
is likely to be faster than Stack when used as a stack, and *faster than
LinkedList when used as a queue.*
{quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19473) Review of ClientScanner Class
[
https://issues.apache.org/jira/browse/HBASE-19473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated HBASE-19473:
Summary: Review of ClientScanner Class (was: Review of ClientScanner)
> Review of ClientScanner Class
> -
>
> Key: HBASE-19473
> URL: https://issues.apache.org/jira/browse/HBASE-19473
> Project: HBase
> Issue Type: Improvement
> Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
>
> # Remove superfluous logging code guard
> # Simplify some of the code
> # Use ArrayDeque instead of LinkedList for queue implementation
> https://docs.oracle.com/javase/8/docs/api/index.html?java/util/ArrayDeque.html
> {quote}
> Resizable-array implementation of the Deque interface. Array deques have no
> capacity restrictions; they grow as necessary to support usage. They are not
> thread-safe; in the absence of external synchronization, they do not support
> concurrent access by multiple threads. Null elements are prohibited. This
> class is likely to be faster than Stack when used as a stack, and *faster
> than LinkedList when used as a queue.*
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19472) Remove ArrayUtil Class
[
https://issues.apache.org/jira/browse/HBASE-19472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated HBASE-19472:
Status: Patch Available (was: Open)
> Remove ArrayUtil Class
> --
>
> Key: HBASE-19472
> URL: https://issues.apache.org/jira/browse/HBASE-19472
> Project: HBase
> Issue Type: Improvement
> Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
> Attachments: HBASE-19472.1.patch
>
>
> Remove the class {{ArrayUtils}} from the project. Most of it is not used,
> and what little is, already exists in Apache Commons library.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (HBASE-19472) Remove ArrayUtil Class
[
https://issues.apache.org/jira/browse/HBASE-19472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR reassigned HBASE-19472:
---
Assignee: BELUGA BEHR
> Remove ArrayUtil Class
> --
>
> Key: HBASE-19472
> URL: https://issues.apache.org/jira/browse/HBASE-19472
> Project: HBase
> Issue Type: Improvement
> Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
> Attachments: HBASE-19472.1.patch
>
>
> Remove the class {{ArrayUtils}} from the project. Most of it is not used,
> and what little is, already exists in Apache Commons library.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-19472) Remove ArrayUtil Class
BELUGA BEHR created HBASE-19472:
---
Summary: Remove ArrayUtil Class
Key: HBASE-19472
URL: https://issues.apache.org/jira/browse/HBASE-19472
Project: HBase
Issue Type: Improvement
Components: hbase
Affects Versions: 3.0.0
Reporter: BELUGA BEHR
Remove the class {{ArrayUtils}} from the project. Most of it is not used, and
what little is, already exists in Apache Commons library.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19472) Remove ArrayUtil Class
[
https://issues.apache.org/jira/browse/HBASE-19472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated HBASE-19472:
Attachment: HBASE-19472.1.patch
> Remove ArrayUtil Class
> --
>
> Key: HBASE-19472
> URL: https://issues.apache.org/jira/browse/HBASE-19472
> Project: HBase
> Issue Type: Improvement
> Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
> Attachments: HBASE-19472.1.patch
>
>
> Remove the class {{ArrayUtils}} from the project. Most of it is not used,
> and what little is, already exists in Apache Commons library.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19469) Review Of BackupSystemTable
[ https://issues.apache.org/jira/browse/HBASE-19469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285042#comment-16285042 ] Hudson commented on HBASE-19469: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4197 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4197/]) HBASE-19469 Review Of BackupSystemTable (BELUGA BEHR) (tedyu: rev 82e278be55ff1096684e29e827e0c90c1a2598d1) * (edit) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupSystemTable.java * (edit) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java > Review Of BackupSystemTable > --- > > Key: HBASE-19469 > URL: https://issues.apache.org/jira/browse/HBASE-19469 > Project: HBase > Issue Type: Improvement > Components: hbase >Affects Versions: 3.0.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Trivial > Fix For: 3.0.0 > > Attachments: HBASE-19469.1.patch, HBASE-19469.2.patch > > > * Remove superfluous logging guards > * Fix spelling mistake in log message > * Fixed some DEBUG log messages that were guarded by an _isTraceEnabled_ > * Use more Java auto-close functionality > * Some code simplifications > * Use better data structures for merge/disjoin -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19375) Fix import order in hbase-thrift
[ https://issues.apache.org/jira/browse/HBASE-19375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285043#comment-16285043 ] Hudson commented on HBASE-19375: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4197 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4197/]) HBASE-19375 Fixed Checkstyle import order errors in hbase-thrift (jan.hentschel: rev 3eb87802c802b553764b38f804f91e87bd27d2b5) * (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java * (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftHttpServlet.java * (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java * (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HThreadedSelectorServerArgs.java * (edit) hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java * (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/TBoundedThreadPoolServer.java * (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java * (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java * (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java * (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java * (edit) hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/ErrorThrowingGetObserver.java * (edit) hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandlerWithReadOnly.java * (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java * (edit) hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java * (edit) hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandlerWithLabels.java * (edit) hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java > Fix import order in hbase-thrift > > > Key: HBASE-19375 > URL: https://issues.apache.org/jira/browse/HBASE-19375 > Project: HBase > Issue Type: Sub-task > Components: Thrift >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: HBASE-19375.master.001.patch, > HBASE-19375.master.002.patch > > > Currently Checkstyle complains about the import order in some classes > (*ImportOrderCheck*). They should get fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19458) Allow building HBase 1.3.x against Hadoop 2.8.2
[ https://issues.apache.org/jira/browse/HBASE-19458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285037#comment-16285037 ] Lars Hofhansl commented on HBASE-19458: --- branch-1 is fine. There were a bunch of changes in this area. > Allow building HBase 1.3.x against Hadoop 2.8.2 > --- > > Key: HBASE-19458 > URL: https://issues.apache.org/jira/browse/HBASE-19458 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.1 >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Fix For: 1.3.2 > > Attachments: 19458.txt > > > Currently the 1.3 branch cannot be built against Hadoop 2.8.2. (that latest > stable 2.x release). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15482) Provide an option to skip calculating block locations for SnapshotInputFormat
[ https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284998#comment-16284998 ] Ted Yu commented on HBASE-15482: [~davelatham]: Can you take another look ? > Provide an option to skip calculating block locations for SnapshotInputFormat > - > > Key: HBASE-15482 > URL: https://issues.apache.org/jira/browse/HBASE-15482 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Reporter: Liyin Tang >Assignee: Xiang Li >Priority: Minor > Fix For: 2.1.0 > > Attachments: HBASE-15482.master.000.patch, > HBASE-15482.master.001.patch, HBASE-15482.master.002.patch > > > When a MR job is reading from SnapshotInputFormat, it needs to calculate the > splits based on the block locations in order to get best locality. However, > this process may take a long time for large snapshots. > In some setup, the computing layer, Spark, Hive or Presto could run out side > of HBase cluster. In these scenarios, the block locality doesn't matter. > Therefore, it will be great to have an option to skip calculating the block > locations for every job. That will super useful for the Hive/Presto/Spark > connectors. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19112) Suspect methods on Cell to be deprecated
[
https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284992#comment-16284992
]
stack commented on HBASE-19112:
---
Thanks for working on this boys and the nice writeup [~ram_krish]
On #1, getType would return an enum. We'd move the DataType from CellBuilder to
Cell (CellBuilder is new so could just move the DataType over)? Sounds least
disruptive. DataType will be where folks expect to find it (better in Cell than
in CellBuilder -- see Josh's original dilemma up on the dev list linked out of
the description on this JIRA).
Agree that #2, #3, and #4 are too much work for this stage in game.
Whats to be done in here?
Thanks.
> Suspect methods on Cell to be deprecated
>
>
> Key: HBASE-19112
> URL: https://issues.apache.org/jira/browse/HBASE-19112
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: Josh Elser
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19112_branch-2.patch
>
>
> [~chia7712] suggested on the [mailing
> list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E]
> that we have some methods on Cell which should be deprecated for removal:
> * {{#getType()}}
> * {{#getTimestamp()}}
> * {{#getTag()}}
> * {{#getSequenceId()}}
> Let's make a pass over these (and maybe the rest) to make sure that there
> aren't others which are either implementation details or methods returning
> now-private-marked classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19471) Fix remaining Checkstyle errors in hbase-thrift
[
https://issues.apache.org/jira/browse/HBASE-19471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284985#comment-16284985
]
Hadoop QA commented on HBASE-19471:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
7s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 6 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
57s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} hbase-thrift: The patch generated 0 new + 1
unchanged - 447 fixed = 1 total (was 448) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
25s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
50m 43s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
7s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 69m 21s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19471 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12901370/HBASE-19471.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 53f5ce157a99 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 3eb87802c8 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10318/testReport/ |
| modules | C: hbase-thrift U: hbase-thrift |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10318/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Fix remaining Checkstyle errors in hbase-thrift
> ---
>
>
[jira] [Commented] (HBASE-17425) Fix calls to deprecated APIs in TestUpdateConfiguration
[
https://issues.apache.org/jira/browse/HBASE-17425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284978#comment-16284978
]
Hudson commented on HBASE-17425:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4196 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/4196/])
HBASE-17425 Fixed deprecated calls in TestUpdateConfiguration (jan.hentschel:
rev c98bab51de22a20990ff8805825e8638e0686464)
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestUpdateConfiguration.java
> Fix calls to deprecated APIs in TestUpdateConfiguration
> ---
>
> Key: HBASE-17425
> URL: https://issues.apache.org/jira/browse/HBASE-17425
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0, 1.3.2, 1.4.1, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-17425.master.001.patch
>
>
> Currently there are two calls to the deprecated method
> {code:java}HBaseTestingUtil.getHBaseAdmin(){code} in
> *TestUpdateConfiguration*. These calls should be changed to
> {code:java}HBaseTestingUtil.getAdmin(){code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (HBASE-19374) Fix Checkstyle errors in TestThriftServer
[
https://issues.apache.org/jira/browse/HBASE-19374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel resolved HBASE-19374.
---
Resolution: Duplicate
Assignee: Jan Hentschel
Will be part of HBASE-19471.
> Fix Checkstyle errors in TestThriftServer
> -
>
> Key: HBASE-19374
> URL: https://issues.apache.org/jira/browse/HBASE-19374
> Project: HBase
> Issue Type: Sub-task
> Components: Thrift
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> Checkstyle currently complains about the following things in the
> *TestThriftServer* class. They should be fixed.
> {code:xml}
> source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.NonEmptyAtclauseDescriptionCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.NonEmptyAtclauseDescriptionCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.NonEmptyAtclauseDescriptionCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.NonEmptyAtclauseDescriptionCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.NonEmptyAtclauseDescriptionCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.NonEmptyAtclauseDescriptionCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.coding.EmptyStatementCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.whitespace.ParenPadCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.whitespace.ParenPadCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.NonEmptyAtclauseDescriptionCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.NonEmptyAtclauseDescriptionCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.NonEmptyAtclauseDescriptionCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.NonEmptyAtclauseDescriptionCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.NonEmptyAtclauseDescriptionCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.NonEmptyAtclauseDescriptionCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTagContinuationIndentationCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTagContinuationIndentationCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTagContinuationIndentationCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTagContinuationIndentationCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTagContinuationIndentationCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTagContinuationIndentationCheck"/>
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.NonEmptyAtclauseDescriptionCheck"/>
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19471) Fix remaining Checkstyle errors in hbase-thrift
[ https://issues.apache.org/jira/browse/HBASE-19471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-19471: -- Status: Patch Available (was: In Progress) > Fix remaining Checkstyle errors in hbase-thrift > --- > > Key: HBASE-19471 > URL: https://issues.apache.org/jira/browse/HBASE-19471 > Project: HBase > Issue Type: Sub-task > Components: Thrift >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Attachments: HBASE-19471.master.001.patch > > > Some Checkstyle errors are left in the *hbase-thrift* module and should be > fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19471) Fix remaining Checkstyle errors in hbase-thrift
[ https://issues.apache.org/jira/browse/HBASE-19471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-19471: -- Attachment: HBASE-19471.master.002.patch > Fix remaining Checkstyle errors in hbase-thrift > --- > > Key: HBASE-19471 > URL: https://issues.apache.org/jira/browse/HBASE-19471 > Project: HBase > Issue Type: Sub-task > Components: Thrift >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Attachments: HBASE-19471.master.001.patch > > > Some Checkstyle errors are left in the *hbase-thrift* module and should be > fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19449) Implement SLF4J and SLF4J Parameter Substitution
[
https://issues.apache.org/jira/browse/HBASE-19449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284968#comment-16284968
]
stack commented on HBASE-19449:
---
Seems to be no movement on LOG4J2-63, making log4j2 read log4j1 property files.
Let me up the ante on the dev thread [~belugabehr] started.
> Implement SLF4J and SLF4J Parameter Substitution
>
>
> Key: HBASE-19449
> URL: https://issues.apache.org/jira/browse/HBASE-19449
> Project: HBase
> Issue Type: Improvement
> Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Fix For: 2.0.0
>
> Attachments: HBASE-19449.1.patch, HBASE-19449.2.patch,
> HBASE-19449.3.patch, HBASE-19449.4.patch
>
>
> For the {{HFileArchiver.java}} class...
> * Use SLF4J logging
> * Use SLF4J parameter substitution
> * Fix some small issues with missing spaces between words in the log message
> and the like
> https://www.slf4j.org/faq.html#logging_performance
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19471) Fix remaining Checkstyle errors in hbase-thrift
[ https://issues.apache.org/jira/browse/HBASE-19471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-19471: -- Attachment: (was: HBASE-19471.master.002.patch) > Fix remaining Checkstyle errors in hbase-thrift > --- > > Key: HBASE-19471 > URL: https://issues.apache.org/jira/browse/HBASE-19471 > Project: HBase > Issue Type: Sub-task > Components: Thrift >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Attachments: HBASE-19471.master.001.patch > > > Some Checkstyle errors are left in the *hbase-thrift* module and should be > fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19471) Fix remaining Checkstyle errors in hbase-thrift
[ https://issues.apache.org/jira/browse/HBASE-19471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-19471: -- Attachment: HBASE-19471.master.001.patch > Fix remaining Checkstyle errors in hbase-thrift > --- > > Key: HBASE-19471 > URL: https://issues.apache.org/jira/browse/HBASE-19471 > Project: HBase > Issue Type: Sub-task > Components: Thrift >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Attachments: HBASE-19471.master.001.patch > > > Some Checkstyle errors are left in the *hbase-thrift* module and should be > fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19375) Fix import order in hbase-thrift
[ https://issues.apache.org/jira/browse/HBASE-19375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-19375: -- Resolution: Fixed Fix Version/s: 2.0.0-beta-1 3.0.0 Status: Resolved (was: Patch Available) > Fix import order in hbase-thrift > > > Key: HBASE-19375 > URL: https://issues.apache.org/jira/browse/HBASE-19375 > Project: HBase > Issue Type: Sub-task > Components: Thrift >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: HBASE-19375.master.001.patch, > HBASE-19375.master.002.patch > > > Currently Checkstyle complains about the import order in some classes > (*ImportOrderCheck*). They should get fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Work started] (HBASE-19471) Fix remaining Checkstyle errors in hbase-thrift
[ https://issues.apache.org/jira/browse/HBASE-19471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-19471 started by Jan Hentschel. - > Fix remaining Checkstyle errors in hbase-thrift > --- > > Key: HBASE-19471 > URL: https://issues.apache.org/jira/browse/HBASE-19471 > Project: HBase > Issue Type: Sub-task > Components: Thrift >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > > Some Checkstyle errors are left in the *hbase-thrift* module and should be > fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19471) Fix remaining Checkstyle errors in hbase-thrift
Jan Hentschel created HBASE-19471: - Summary: Fix remaining Checkstyle errors in hbase-thrift Key: HBASE-19471 URL: https://issues.apache.org/jira/browse/HBASE-19471 Project: HBase Issue Type: Sub-task Components: Thrift Reporter: Jan Hentschel Assignee: Jan Hentschel Priority: Minor Some Checkstyle errors are left in the *hbase-thrift* module and should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19469) Review Of BackupSystemTable
[ https://issues.apache.org/jira/browse/HBASE-19469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19469: --- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch, Beluga. > Review Of BackupSystemTable > --- > > Key: HBASE-19469 > URL: https://issues.apache.org/jira/browse/HBASE-19469 > Project: HBase > Issue Type: Improvement > Components: hbase >Affects Versions: 3.0.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Trivial > Fix For: 3.0.0 > > Attachments: HBASE-19469.1.patch, HBASE-19469.2.patch > > > * Remove superfluous logging guards > * Fix spelling mistake in log message > * Fixed some DEBUG log messages that were guarded by an _isTraceEnabled_ > * Use more Java auto-close functionality > * Some code simplifications > * Use better data structures for merge/disjoin -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19469) Review Of BackupSystemTable
[ https://issues.apache.org/jira/browse/HBASE-19469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19469: --- Hadoop Flags: Reviewed Fix Version/s: 3.0.0 > Review Of BackupSystemTable > --- > > Key: HBASE-19469 > URL: https://issues.apache.org/jira/browse/HBASE-19469 > Project: HBase > Issue Type: Improvement > Components: hbase >Affects Versions: 3.0.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Trivial > Fix For: 3.0.0 > > Attachments: HBASE-19469.1.patch, HBASE-19469.2.patch > > > * Remove superfluous logging guards > * Fix spelling mistake in log message > * Fixed some DEBUG log messages that were guarded by an _isTraceEnabled_ > * Use more Java auto-close functionality > * Some code simplifications > * Use better data structures for merge/disjoin -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19469) Review Of BackupSystemTable
[
https://issues.apache.org/jira/browse/HBASE-19469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284828#comment-16284828
]
Hadoop QA commented on HBASE-19469:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
8s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
37s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
14s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
13s{color} | {color:red} hbase-backup: The patch generated 3 new + 24 unchanged
- 4 fixed = 27 total (was 28) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
22s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
50m 37s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m
59s{color} | {color:green} hbase-backup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 77m 2s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19469 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12901361/HBASE-19469.2.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 2070963b705c 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / c98bab51de |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/10317/artifact/patchprocess/diff-checkstyle-hbase-backup.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10317/testReport/ |
| modules | C: hbase-backup U: hbase-backup |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10317/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically
[jira] [Commented] (HBASE-19463) Make CPEnv#getConnection return a facade that throws Unsupported if CP calls #close
[ https://issues.apache.org/jira/browse/HBASE-19463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284814#comment-16284814 ] Hudson commented on HBASE-19463: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4195 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4195/]) HBASE-19463 Make CPEnv#getConnection return a facade that throws (zghao: rev e880946f53a9217f322c75dda8b9285e566c7406) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionServerCoprocessorEnvironment.java * (add) hbase-server/src/main/java/org/apache/hadoop/hbase/SharedConnection.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorShortCircuitRPC.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionCoprocessorEnvironment.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterCoprocessorEnvironment.java > Make CPEnv#getConnection return a facade that throws Unsupported if CP calls > #close > --- > > Key: HBASE-19463 > URL: https://issues.apache.org/jira/browse/HBASE-19463 > Project: HBase > Issue Type: Improvement > Components: Coprocessors >Reporter: stack >Assignee: Guanghao Zhang > Labels: beginner > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19463.master.001.patch, > HBASE-19463.master.002.patch > > > Follows from HBASE-19301, a suggestion by [~zghaobac]. > To prevent a CP accidentally closing the connection returned by > CpEnv#getConnection -- which returns the hosting Servers Connection -- we > should throw UnsupportedException if the CP calls #close Do it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19469) Review Of BackupSystemTable
[ https://issues.apache.org/jira/browse/HBASE-19469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-19469: Attachment: HBASE-19469.2.patch > Review Of BackupSystemTable > --- > > Key: HBASE-19469 > URL: https://issues.apache.org/jira/browse/HBASE-19469 > Project: HBase > Issue Type: Improvement > Components: hbase >Affects Versions: 3.0.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Trivial > Attachments: HBASE-19469.1.patch, HBASE-19469.2.patch > > > * Remove superfluous logging guards > * Fix spelling mistake in log message > * Fixed some DEBUG log messages that were guarded by an _isTraceEnabled_ > * Use more Java auto-close functionality > * Some code simplifications > * Use better data structures for merge/disjoin -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19469) Review Of BackupSystemTable
[ https://issues.apache.org/jira/browse/HBASE-19469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-19469: Status: Patch Available (was: Open) > Review Of BackupSystemTable > --- > > Key: HBASE-19469 > URL: https://issues.apache.org/jira/browse/HBASE-19469 > Project: HBase > Issue Type: Improvement > Components: hbase >Affects Versions: 3.0.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Trivial > Attachments: HBASE-19469.1.patch, HBASE-19469.2.patch > > > * Remove superfluous logging guards > * Fix spelling mistake in log message > * Fixed some DEBUG log messages that were guarded by an _isTraceEnabled_ > * Use more Java auto-close functionality > * Some code simplifications > * Use better data structures for merge/disjoin -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19469) Review Of BackupSystemTable
[ https://issues.apache.org/jira/browse/HBASE-19469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-19469: Status: Open (was: Patch Available) > Review Of BackupSystemTable > --- > > Key: HBASE-19469 > URL: https://issues.apache.org/jira/browse/HBASE-19469 > Project: HBase > Issue Type: Improvement > Components: hbase >Affects Versions: 3.0.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Trivial > Attachments: HBASE-19469.1.patch > > > * Remove superfluous logging guards > * Fix spelling mistake in log message > * Fixed some DEBUG log messages that were guarded by an _isTraceEnabled_ > * Use more Java auto-close functionality > * Some code simplifications > * Use better data structures for merge/disjoin -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19449) Implement SLF4J and SLF4J Parameter Substitution
[
https://issues.apache.org/jira/browse/HBASE-19449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284787#comment-16284787
]
stack commented on HBASE-19449:
---
HADOOP-12956 is the hadoop logging issue. Good back and forth. It starts out
with:
{quote}
5 August 2015 --The Apache Logging Services™ Project Management Committee (PMC)
has announced that the Log4j™ 1.x logging framework has reached its end of life
(EOL) and is no longer officially supported.
https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
A whole framework log4j2 upgrade has to be synchronized, partly for improved
performance brought about by log4j2.
https://logging.apache.org/log4j/2.x/manual/async.html#Performance
{quote}
Gems from the long issue:
{quote}
The only thing that supports the log4j 1 properties files is Log4j 1.x. That
was declared EOL 2 years ago. The last release of Log4j 1 was 5 1/2 years ago.
It doesn't run in Java 9 without hacking it.
{quote}
Ralph of Log4j Project:
{quote}I should also point out, SLF4J isn't really an answer for this problem
either as Logback doesn't support Log4j 1 configurations and its migration tool
can't handle custom Appenders or Layouts either.
{quote}
Our Sean:
{quote}
SLF4j is exactly the operational answer Hadoop needs. It lets us move our
code's assumptions off of log4j1 while providing a log4j 1 bridge that will
work with existing log4j 1 properties files. That way we can work incrementally
on updating the code base while not requiring operators to change anything.
Once we're done, operators who want to switch early can do so. As a project we
can wait for our next major version to move the default to some other logging
implementation.
{quote}
There is patch on end of this issue posted recently by the log4j2 folks. It
uses the log4j1 => 2 bridge (Need to check if supports old-style property files
-- don't think so... TODO).
In the end, hadoop moves to slf4 for 2.9 and 3.0j. See HADOOP-14289
> Implement SLF4J and SLF4J Parameter Substitution
>
>
> Key: HBASE-19449
> URL: https://issues.apache.org/jira/browse/HBASE-19449
> Project: HBase
> Issue Type: Improvement
> Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Fix For: 2.0.0
>
> Attachments: HBASE-19449.1.patch, HBASE-19449.2.patch,
> HBASE-19449.3.patch, HBASE-19449.4.patch
>
>
> For the {{HFileArchiver.java}} class...
> * Use SLF4J logging
> * Use SLF4J parameter substitution
> * Fix some small issues with missing spaces between words in the log message
> and the like
> https://www.slf4j.org/faq.html#logging_performance
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19371) Running WALPerformanceEvaluation against asyncfswal throws exceptions
[ https://issues.apache.org/jira/browse/HBASE-19371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284767#comment-16284767 ] stack commented on HBASE-19371: --- Thanks [~Apache9] Will try it after finish numbers on HBASE-16890 > Running WALPerformanceEvaluation against asyncfswal throws exceptions > - > > Key: HBASE-19371 > URL: https://issues.apache.org/jira/browse/HBASE-19371 > Project: HBase > Issue Type: Bug >Reporter: stack > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19371.patch > > > Was trying to do a perf eval on asyncfswal. I ran w/ these args: > Performance counter stats for '/home/stack/hbase/bin/hbase --config > /home/stack/conf_hbase org.apache.hadoop.hbase.wal.WALPerformanceEvaluation > -path /user/stack/logs/ -verify -threads 25 -iterations 100 -keySize 50 > -valueSize 100 -syncInterval 10': > The verify fails on all runs: > Exception in thread "main" java.lang.IllegalStateException: Counted=12390228, > expected=2500 > at > org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.run(WALPerformanceEvaluation.java:368) > > at > org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) > at > org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.innerMain(WALPerformanceEvaluation.java:597) > > at > org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.main(WALPerformanceEvaluation.java:601) > I need to fix test or figure what is wrong in asyncfswal. > Also seeing these when I run w/ one thread only: > 2017-11-28 21:25:49,952 WARN [AsyncFSWAL-1-1] wal.AsyncFSWAL: > RingBufferTruck with unexpected type: EMPTY > Log has a spew of them. > Has stuff like this too: > 2017-11-28 21:25:40,065 WARN [Close-WAL-Writer-3] > wal.AsyncProtobufLogWriter: normal close failed, try recover > > java.io.IOException: stream already broken > > at > org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.endBlock(FanOutOneBlockAsyncDFSOutput.java:510) > > at > org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.lambda$close$12(FanOutOneBlockAsyncDFSOutput.java:550) > >at > org.apache.hadoop.hbase.shaded.io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163) > at > org.apache.hadoop.hbase.shaded.io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:403) > at > org.apache.hadoop.hbase.shaded.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:462) > at > org.apache.hadoop.hbase.shaded.io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:858) > > at > org.apache.hadoop.hbase.shaded.io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:138) > at java.lang.Thread.run(Thread.java:748) > Starts out spewing EMPTY here: > 2017-11-28 21:16:52,051 INFO [main] regionserver.HRegion: Setting > FlushNonSloppyStoresFirstPolicy for the > region=WALPerformanceEvaluation:0,,1511932610787.deca03e0ca447fa25d02fe9cd6e31aa4. > 2017-11-28 21:16:52,058 DEBUG [main] regionserver.HRegion: Found 0 recovered > edits file(s) under > hdfs://ve0524.halxg.cloudera.com:8020/user/stack/logs/data/WALPerformanceEvaluation/0/deca03e0ca447fa25d02fe9cd6e31aa4 > 2017-11-28 21:16:52,068 DEBUG [main] regionserver.FlushLargeStoresPolicy: No > hbase.hregion.percolumnfamilyflush.size.lower.bound set in description of > table WALPerformanceEvaluation:0, use config (134217728) instead > 2017-11-28 21:16:52,084 DEBUG [main] wal.WALSplitter: Wrote > file=hdfs://ve0524.halxg.cloudera.com:8020/user/stack/logs/data/WALPerformanceEvaluation/0/deca03e0ca447fa25d02fe9cd6e31aa4/recovered.edits/2.seqid, > newSeqId=2, maxSeqId=0 > 2017-11-28 21:16:52,084 INFO [main] regionserver.HRegion: Onlined > deca03e0ca447fa25d02fe9cd6e31aa4; next sequenceid=2 > 2017-11-28 21:16:52,185 WARN [AsyncFSWAL-1-1] wal.AsyncFSWAL: > RingBufferTruck with unexpected type: EMPTY > 2017-11-28 21:16:52,185 WARN [AsyncFSWAL-1-1] wal.AsyncFSWAL: > RingBufferTruck with unexpected type:
[jira] [Commented] (HBASE-19375) Fix import order in hbase-thrift
[
https://issues.apache.org/jira/browse/HBASE-19375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284762#comment-16284762
]
Hadoop QA commented on HBASE-19375:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
55s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 6 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
59s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} hbase-thrift: The patch generated 0 new + 367
unchanged - 29 fixed = 367 total (was 396) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
22s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
50m 36s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
2s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 71m 3s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19375 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12901358/HBASE-19375.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 70ddc36b12d0 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / e880946f53 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10315/testReport/ |
| modules | C: hbase-thrift U: hbase-thrift |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10315/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Fix import order in hbase-thrift
>
>
> Key:
[jira] [Commented] (HBASE-16890) Analyze the performance of AsyncWAL and fix the same
[ https://issues.apache.org/jira/browse/HBASE-16890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284760#comment-16284760 ] stack commented on HBASE-16890: --- Here is another run w/ 48 YCSB clients on one machine and then a RS on another standing over an HDFS of 7 nodes. Each stage ran 30 mins. ||workload||current||asyncfs||asyncfs+own+eventloop|| |loadinga|15184 ops/s|15823 ops/s|16619 ops/s| |workloada 50/50|52574 ops/s|52710 ops/s|52776 ops/s| |workloadw 85/15|44212 ops/s|44973 ops/s|44341 ops/s| So, as concurrency goes up, asyncfswal makes less of a difference. When concurrency, our server core probably hampers throughput. One more measurement at 24 threads (these are 48 core machines). > Analyze the performance of AsyncWAL and fix the same > > > Key: HBASE-16890 > URL: https://issues.apache.org/jira/browse/HBASE-16890 > Project: HBase > Issue Type: Sub-task > Components: wal >Affects Versions: 2.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Blocker > Fix For: 2.0.0-beta-1 > > Attachments: AsyncWAL_disruptor.patch, AsyncWAL_disruptor_1 > (2).patch, AsyncWAL_disruptor_3.patch, AsyncWAL_disruptor_3.patch, > AsyncWAL_disruptor_4.patch, AsyncWAL_disruptor_6.patch, > HBASE-16890-rc-v2.patch, HBASE-16890-rc-v3.patch, > HBASE-16890-remove-contention-v1.patch, HBASE-16890-remove-contention.patch, > Screen Shot 2016-10-25 at 7.34.47 PM.png, Screen Shot 2016-10-25 at 7.39.07 > PM.png, Screen Shot 2016-10-25 at 7.39.48 PM.png, Screen Shot 2016-11-04 at > 5.21.27 PM.png, Screen Shot 2016-11-04 at 5.30.18 PM.png, async.svg, > classic.svg, contention.png, contention_defaultWAL.png, > ycsb_FSHlog.vs.Async.png > > > Tests reveal that AsyncWAL under load in single node cluster performs slower > than the Default WAL. This task is to analyze and see if we could fix it. > See some discussions in the tail of JIRA HBASE-15536. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17425) Fix calls to deprecated APIs in TestUpdateConfiguration
[
https://issues.apache.org/jira/browse/HBASE-17425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284744#comment-16284744
]
Hudson commented on HBASE-17425:
FAILURE: Integrated in Jenkins build HBase-1.1-JDK8 #2035 (See
[https://builds.apache.org/job/HBase-1.1-JDK8/2035/])
HBASE-17425 Fixed deprecated calls in TestUpdateConfiguration (jan.hentschel:
rev 8b1e10ae5d7ea92ebd6b0291d7ab676bfe1cabe6)
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestUpdateConfiguration.java
> Fix calls to deprecated APIs in TestUpdateConfiguration
> ---
>
> Key: HBASE-17425
> URL: https://issues.apache.org/jira/browse/HBASE-17425
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0, 1.3.2, 1.4.1, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-17425.master.001.patch
>
>
> Currently there are two calls to the deprecated method
> {code:java}HBaseTestingUtil.getHBaseAdmin(){code} in
> *TestUpdateConfiguration*. These calls should be changed to
> {code:java}HBaseTestingUtil.getAdmin(){code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17425) Fix calls to deprecated APIs in TestUpdateConfiguration
[
https://issues.apache.org/jira/browse/HBASE-17425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284743#comment-16284743
]
Hudson commented on HBASE-17425:
FAILURE: Integrated in Jenkins build HBase-1.1-JDK7 #1950 (See
[https://builds.apache.org/job/HBase-1.1-JDK7/1950/])
HBASE-17425 Fixed deprecated calls in TestUpdateConfiguration (jan.hentschel:
rev 8b1e10ae5d7ea92ebd6b0291d7ab676bfe1cabe6)
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestUpdateConfiguration.java
> Fix calls to deprecated APIs in TestUpdateConfiguration
> ---
>
> Key: HBASE-17425
> URL: https://issues.apache.org/jira/browse/HBASE-17425
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0, 1.3.2, 1.4.1, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-17425.master.001.patch
>
>
> Currently there are two calls to the deprecated method
> {code:java}HBaseTestingUtil.getHBaseAdmin(){code} in
> *TestUpdateConfiguration*. These calls should be changed to
> {code:java}HBaseTestingUtil.getAdmin(){code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-17425) Fix calls to deprecated APIs in TestUpdateConfiguration
[
https://issues.apache.org/jira/browse/HBASE-17425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated HBASE-17425:
--
Resolution: Fixed
Fix Version/s: 1.1.13
2.0.0-beta-1
1.2.7
1.5.0
1.4.1
1.3.2
3.0.0
Status: Resolved (was: Patch Available)
Pushed to master, branch-2, branch-1, branch-1.4, branch-1.3, branch-1.2 and
branch-1.1.
> Fix calls to deprecated APIs in TestUpdateConfiguration
> ---
>
> Key: HBASE-17425
> URL: https://issues.apache.org/jira/browse/HBASE-17425
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0, 1.3.2, 1.4.1, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-17425.master.001.patch
>
>
> Currently there are two calls to the deprecated method
> {code:java}HBaseTestingUtil.getHBaseAdmin(){code} in
> *TestUpdateConfiguration*. These calls should be changed to
> {code:java}HBaseTestingUtil.getAdmin(){code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17425) Fix calls to deprecated APIs in TestUpdateConfiguration
[
https://issues.apache.org/jira/browse/HBASE-17425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284740#comment-16284740
]
Hudson commented on HBASE-17425:
FAILURE: Integrated in Jenkins build HBase-1.3-IT #315 (See
[https://builds.apache.org/job/HBase-1.3-IT/315/])
HBASE-17425 Fixed deprecated calls in TestUpdateConfiguration (jan.hentschel:
rev d2731cee6d1b7fed8c917aba0c9da0c34969)
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestUpdateConfiguration.java
> Fix calls to deprecated APIs in TestUpdateConfiguration
> ---
>
> Key: HBASE-17425
> URL: https://issues.apache.org/jira/browse/HBASE-17425
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Attachments: HBASE-17425.master.001.patch
>
>
> Currently there are two calls to the deprecated method
> {code:java}HBaseTestingUtil.getHBaseAdmin(){code} in
> *TestUpdateConfiguration*. These calls should be changed to
> {code:java}HBaseTestingUtil.getAdmin(){code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17425) Fix calls to deprecated APIs in TestUpdateConfiguration
[
https://issues.apache.org/jira/browse/HBASE-17425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284741#comment-16284741
]
Hudson commented on HBASE-17425:
FAILURE: Integrated in Jenkins build HBase-1.2-IT #1039 (See
[https://builds.apache.org/job/HBase-1.2-IT/1039/])
HBASE-17425 Fixed deprecated calls in TestUpdateConfiguration (jan.hentschel:
rev bbdccb79dd9d44d09f4e79de4dc3bd010bc586a5)
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestUpdateConfiguration.java
> Fix calls to deprecated APIs in TestUpdateConfiguration
> ---
>
> Key: HBASE-17425
> URL: https://issues.apache.org/jira/browse/HBASE-17425
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Attachments: HBASE-17425.master.001.patch
>
>
> Currently there are two calls to the deprecated method
> {code:java}HBaseTestingUtil.getHBaseAdmin(){code} in
> *TestUpdateConfiguration*. These calls should be changed to
> {code:java}HBaseTestingUtil.getAdmin(){code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19375) Fix import order in hbase-thrift
[ https://issues.apache.org/jira/browse/HBASE-19375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284737#comment-16284737 ] Jan Hentschel commented on HBASE-19375: --- Updated the patch to address the * imports and blank lines in the imports. > Fix import order in hbase-thrift > > > Key: HBASE-19375 > URL: https://issues.apache.org/jira/browse/HBASE-19375 > Project: HBase > Issue Type: Sub-task > Components: Thrift >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Attachments: HBASE-19375.master.001.patch, > HBASE-19375.master.002.patch > > > Currently Checkstyle complains about the import order in some classes > (*ImportOrderCheck*). They should get fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19375) Fix import order in hbase-thrift
[ https://issues.apache.org/jira/browse/HBASE-19375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-19375: -- Attachment: HBASE-19375.master.002.patch > Fix import order in hbase-thrift > > > Key: HBASE-19375 > URL: https://issues.apache.org/jira/browse/HBASE-19375 > Project: HBase > Issue Type: Sub-task > Components: Thrift >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Attachments: HBASE-19375.master.001.patch, > HBASE-19375.master.002.patch > > > Currently Checkstyle complains about the import order in some classes > (*ImportOrderCheck*). They should get fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19389) Limit concurrency of put with dense (hundreds) columns to prevent write handler exhausted
[
https://issues.apache.org/jira/browse/HBASE-19389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284732#comment-16284732
]
Hadoop QA commented on HBASE-19389:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} HBASE-19389 does not apply to branch-2. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.6.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-19389 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12901357/HBASE-19389-branch-2-V5.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10314/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Limit concurrency of put with dense (hundreds) columns to prevent write
> handler exhausted
> -
>
> Key: HBASE-19389
> URL: https://issues.apache.org/jira/browse/HBASE-19389
> Project: HBase
> Issue Type: Improvement
> Components: Performance
>Affects Versions: 2.0.0
> Environment: 2000+ Region Servers
> PCI-E ssd
>Reporter: Chance Li
>Assignee: Chance Li
> Fix For: 2.0.0
>
> Attachments: CSLM-concurrent-write.png,
> HBASE-19389-branch-2-V2.patch, HBASE-19389-branch-2-V3.patch,
> HBASE-19389-branch-2-V4.patch, HBASE-19389-branch-2-V5.patch,
> HBASE-19389-branch-2.patch, metrics-1.png, ycsb-result.png
>
>
> In a large cluster, with a large number of clients, we found the RS's
> handlers are all busy sometimes. And after investigation we found the root
> cause is about CSLM, such as compare function heavy load. We reviewed the
> related WALs, and found that there were many columns (more than 1000 columns)
> were writing at that time.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19389) Limit concurrency of put with dense (hundreds) columns to prevent write handler exhausted
[ https://issues.apache.org/jira/browse/HBASE-19389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284728#comment-16284728 ] Chance Li commented on HBASE-19389: --- [~carp84] Thanks for the reviews. Update the patch. > Limit concurrency of put with dense (hundreds) columns to prevent write > handler exhausted > - > > Key: HBASE-19389 > URL: https://issues.apache.org/jira/browse/HBASE-19389 > Project: HBase > Issue Type: Improvement > Components: Performance >Affects Versions: 2.0.0 > Environment: 2000+ Region Servers > PCI-E ssd >Reporter: Chance Li >Assignee: Chance Li > Fix For: 2.0.0 > > Attachments: CSLM-concurrent-write.png, > HBASE-19389-branch-2-V2.patch, HBASE-19389-branch-2-V3.patch, > HBASE-19389-branch-2-V4.patch, HBASE-19389-branch-2-V5.patch, > HBASE-19389-branch-2.patch, metrics-1.png, ycsb-result.png > > > In a large cluster, with a large number of clients, we found the RS's > handlers are all busy sometimes. And after investigation we found the root > cause is about CSLM, such as compare function heavy load. We reviewed the > related WALs, and found that there were many columns (more than 1000 columns) > were writing at that time. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19389) Limit concurrency of put with dense (hundreds) columns to prevent write handler exhausted
[ https://issues.apache.org/jira/browse/HBASE-19389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chance Li updated HBASE-19389: -- Attachment: HBASE-19389-branch-2-V5.patch > Limit concurrency of put with dense (hundreds) columns to prevent write > handler exhausted > - > > Key: HBASE-19389 > URL: https://issues.apache.org/jira/browse/HBASE-19389 > Project: HBase > Issue Type: Improvement > Components: Performance >Affects Versions: 2.0.0 > Environment: 2000+ Region Servers > PCI-E ssd >Reporter: Chance Li >Assignee: Chance Li > Fix For: 2.0.0 > > Attachments: CSLM-concurrent-write.png, > HBASE-19389-branch-2-V2.patch, HBASE-19389-branch-2-V3.patch, > HBASE-19389-branch-2-V4.patch, HBASE-19389-branch-2-V5.patch, > HBASE-19389-branch-2.patch, metrics-1.png, ycsb-result.png > > > In a large cluster, with a large number of clients, we found the RS's > handlers are all busy sometimes. And after investigation we found the root > cause is about CSLM, such as compare function heavy load. We reviewed the > related WALs, and found that there were many columns (more than 1000 columns) > were writing at that time. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19463) Make CPEnv#getConnection return a facade that throws Unsupported if CP calls #close
[ https://issues.apache.org/jira/browse/HBASE-19463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19463: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushed to master and branch-2. Thanks all for reviewing. > Make CPEnv#getConnection return a facade that throws Unsupported if CP calls > #close > --- > > Key: HBASE-19463 > URL: https://issues.apache.org/jira/browse/HBASE-19463 > Project: HBase > Issue Type: Improvement > Components: Coprocessors >Reporter: stack >Assignee: Guanghao Zhang > Labels: beginner > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19463.master.001.patch, > HBASE-19463.master.002.patch > > > Follows from HBASE-19301, a suggestion by [~zghaobac]. > To prevent a CP accidentally closing the connection returned by > CpEnv#getConnection -- which returns the hosting Servers Connection -- we > should throw UnsupportedException if the CP calls #close Do it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19463) Make CPEnv#getConnection return a facade that throws Unsupported if CP calls #close
[
https://issues.apache.org/jira/browse/HBASE-19463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284689#comment-16284689
]
Hadoop QA commented on HBASE-19463:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
42s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
36s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
54m 48s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}105m
48s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}180m 29s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19463 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12901352/HBASE-19463.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux d307f17601e2 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 7092b814bd |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10313/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10313/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Make CPEnv#getConnection return a facade that throws Unsupported if CP calls
> #close
>
[jira] [Commented] (HBASE-19371) Running WALPerformanceEvaluation against asyncfswal throws exceptions
[
https://issues.apache.org/jira/browse/HBASE-19371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284683#comment-16284683
]
Hadoop QA commented on HBASE-19371:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
28s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
3s{color} | {color:green} hbase-server: The patch generated 0 new + 1
unchanged - 2 fixed = 1 total (was 3) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
24s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
53m 16s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}105m
39s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}177m 37s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19371 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12901349/HBASE-19371.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 0c4d9f677a87 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 7092b814bd |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10312/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10312/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically
