[ 
https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285129#comment-16285129
 ] 

Anoop Sam John commented on HBASE-19112:
----------------------------------------

Ya seems like that is the best option.  We can have the getType() in Cell and 
the Enum also moved to Cell.  So this will have only the Put and 3 Delete 
types.  We have the max/min internal types also. As of now it is ok as we have 
deprecated getTypeByte() also and the server code uses that for the compare. 
There we can get the fake cells.   So those Cells what it will return for the 
new getType() enum?  We dont have enum types for min and max?  Also we can not 
extend an Enum. Or else it would have been possible by RawCell's override the 
getType by returning an extended type..  So may be the Type can be an 
Interface?   Cell return an interface type which is having only Put and Delete 
types.  There is an extended Type interface which include the internal types 
also. And the RawCell override the getType by returning the Extended Interface 
type. (?)

> Suspect methods on Cell to be deprecated
> ----------------------------------------
>
>                 Key: HBASE-19112
>                 URL: https://issues.apache.org/jira/browse/HBASE-19112
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>            Reporter: Josh Elser
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Blocker
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-19112_branch-2.patch
>
>
> [~chia7712] suggested on the [mailing 
> list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E]
>  that we have some methods on Cell which should be deprecated for removal:
> * {{#getType()}}
> * {{#getTimestamp()}}
> * {{#getTag()}}
> * {{#getSequenceId()}}
> Let's make a pass over these (and maybe the rest) to make sure that there 
> aren't others which are either implementation details or methods returning 
> now-private-marked classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to