[jira] [Commented] (HBASE-19506) Support variable sized chunks from ChunkCreator

2018-02-20 Thread Anastasia Braginsky (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371063#comment-16371063
 ] 

Anastasia Braginsky commented on HBASE-19506:
-

OK, since no more comments, I am committing this change...

> Support variable sized chunks from ChunkCreator
> ---
>
> Key: HBASE-19506
> URL: https://issues.apache.org/jira/browse/HBASE-19506
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Anastasia Braginsky
>Priority: Major
> Attachments: HBASE-19506-V01.patch, HBASE-19506-V02.patch, 
> HBASE-19506-V03.patch, HBASE-19506-V04.patch, HBASE-19506-V05.patch, 
> HBASE-19506-V06.patch, HBASE-19506-V07.patch, HBASE-19506-V08.patch, 
> HBASE-19506-V09.patch
>
>
> When CellChunkMap is created it allocates a special index chunk (or chunks) 
> where array of cell-representations is stored. When the number of 
> cell-representations is small, it is preferable to allocate a chunk smaller 
> than a default value which is 2MB.
> On the other hand, those "non-standard size" chunks can not be used in pool. 
> On-demand allocations in off-heap are costly. So this JIRA is about to 
> investigate the trade of between memory usage and the final performance. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20036) TestAvoidCellReferencesIntoShippedBlocks timed out

2018-02-20 Thread ramkrishna.s.vasudevan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371056#comment-16371056
 ] 

ramkrishna.s.vasudevan commented on HBASE-20036:


I will take a look. I ran some 10 times but it did not fail. I think with the 
logs I can do a compare to see if any other case happens in the flow. 

> TestAvoidCellReferencesIntoShippedBlocks timed out
> --
>
> Key: HBASE-20036
> URL: https://issues.apache.org/jira/browse/HBASE-20036
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Priority: Major
>
> Looks like it is stuck can't flush; bad math?
> See the dashboard where it hung here: 
> https://builds.apache.org/job/HBASE-Flaky-Tests-branch2.0/2428/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.client.TestAvoidCellReferencesIntoShippedBlocks-output.txt
> ... the provocation could be this?
> 2018-02-21 04:18:44,973 DEBUG [Thread-178] bucket.BucketCache(629): This 
> block eefaa9a7b10e437b9fc2b55a67d63191_4356 is still referred by 1 readers. 
> Can not be freed now. Hence will mark this for evicting at a later point
> Exception in thread "Thread-178" java.lang.AssertionError: old blocks should 
> still be found  expected:<6> but was:<5>
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:834)
>   at org.junit.Assert.assertEquals(Assert.java:645)
> ... Then we get stuck doing this:
> 2018-02-21 04:23:34,661 DEBUG [master/asf903:0.Chore.1] master.HMaster(1524): 
> Skipping normalization for table: testHBase16372InCompactionWritePath, as 
> it's either system table or doesn't have auto normalization turned on
> 2018-02-21 04:23:35,695 INFO  [regionserver/asf903:0.Chore.1] 
> regionserver.HRegionServer$PeriodicMemStoreFlusher(1752): 
> MemstoreFlusherChore requesting flush of hbase:meta,,1.1588230740 because 
> info has an old edit so flush to free WALs after random delay 286820ms
> 2018-02-21 04:23:36,009 DEBUG [ReadOnlyZKClient-localhost:61855@0x227ea3ed] 
> zookeeper.ReadOnlyZKClient(316): 0x227ea3ed to localhost:61855 inactive for 
> 6ms; closing (Will reconnect when new requests)
> It also failed a recent nightly for same reason:
> https://builds.apache.org/job/HBase%20Nightly/job/branch-2/355/
> Any chance you'd take a look [~ram_krish]? You best at this stuff?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20017) BufferedMutatorImpl submit the same mutation repeatedly

2018-02-20 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371055#comment-16371055
 ] 

Hudson commented on HBASE-20017:


SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #4621 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/4621/])
HBASE-20017 BufferedMutatorImpl submit the same mutation repeatedly (apurtell: 
rev 79d9403a79cca60e614834659e3d9005d5482cac)
* (edit) 
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ReaderBase.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorImpl.java


> BufferedMutatorImpl submit the same mutation repeatedly
> ---
>
> Key: HBASE-20017
> URL: https://issues.apache.org/jira/browse/HBASE-20017
> Project: HBase
>  Issue Type: Bug
>  Components: Client
>Affects Versions: 1.4.0, 1.4.1, 1.4.2
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Blocker
> Fix For: 2.0.0, 1.5.0, 1.4.2
>
> Attachments: HBASE-20017.branch-1.4.v0.patch.patch, 
> HBASE-20017.branch-1.v0.patch.patch, HBASE-20017.v0.patch.patch
>
>
> BMI pass a iter of inner buffer to AsyncProcess to take the undealt 
> mutations, AsyncProcess call iter#next to get the mutation and then call 
> iter#remove to delete the mutation from inner buffer. Hence, There's a good 
> chance that  the mutation is processed repeatedly in case there are a bunch 
> of threads which are running the flush.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20032) Receving multiple warnings for missing reporting.plugins.plugin.version

2018-02-20 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371054#comment-16371054
 ] 

Hudson commented on HBASE-20032:


SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #4621 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/4621/])
HBASE-20032 Receving multiple warnings for missing (stack: rev 
0068b95c854d13e359b619aaa9879b5cbb993729)
* (edit) pom.xml


> Receving multiple warnings for missing reporting.plugins.plugin.version
> ---
>
> Key: HBASE-20032
> URL: https://issues.apache.org/jira/browse/HBASE-20032
> Project: HBase
>  Issue Type: Bug
>  Components: hbase
>Affects Versions: 2.0.0-beta-1
> Environment: Apache Maven 3.0.5 (Red Hat 3.0.5-17)
> Maven home: /usr/share/maven
> Java version: 1.8.0_161, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.161-0.b14.el7_4.x86_64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.10.0-693.11.6.el7.x86_64", arch: "amd64", 
> family: "unix"
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20032.v01.patch
>
>
> getting multiple warnings for the following
> {noformat}
> [WARNING] 'reporting.plugins.plugin.version' for 
> org.apache.maven.plugins:maven-project-info-reports-plugin is missing. @ 
> org.apache.hbase:hbase:3.0.0-SNAPSHOT, /home/vagrant/hbase/pom.xml, line 
> 3492, column 15
> [WARNING] 'reporting.plugins.plugin.version' for 
> org.apache.maven.plugins:maven-javadoc-plugin is missing. @ 
> org.apache.hbase:hbase:3.0.0-SNAPSHOT, /home/vagrant/hbase/pom.xml, line 
> 3520, column 15
> [WARNING] 'reporting.plugins.plugin.version' for 
> org.apache.maven.plugins:maven-checkstyle-plugin is missing. @ 
> org.apache.hbase:hbase:3.0.0-SNAPSHOT, /home/vagrant/hbase/pom.xml, line 
> 3721, column 15
> [WARNING] 'reporting.plugins.plugin.version' for 
> org.scala-tools:maven-scala-plugin is missing. @ 
> org.apache.hbase:hbase:3.0.0-SNAPSHOT, /home/vagrant/hbase/pom.xml, line 
> 3729, column 15
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19954) Separate TestBlockReorder into individual tests to avoid ShutdownHook suppression error against hadoop3

2018-02-20 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371053#comment-16371053
 ] 

Hudson commented on HBASE-19954:


SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #4621 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/4621/])
HBASE-19954 Separate TestBlockReorder into individual tests to avoid (stack: 
rev b75a8f4047e2a33031b121dfe091a992809ebae1)
* (add) 
hbase-server/src/test/java/org/apache/hadoop/hbase/fs/TestBlockReorderBlockLocation.java
* (add) 
hbase-server/src/test/java/org/apache/hadoop/hbase/fs/TestBlockReorderMultiBlocks.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/fs/TestBlockReorder.java


> Separate TestBlockReorder into individual tests to avoid ShutdownHook 
> suppression error against hadoop3 
> 
>
> Key: HBASE-19954
> URL: https://issues.apache.org/jira/browse/HBASE-19954
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: 19954.v1.txt, 19954.v2.txt, 19954.v3.txt, 19954.v4.txt
>
>
> TestBlockReorder fails against hadoop 3 due to the following error:
> {code}
> 2018-02-08 17:22:23,389 ERROR [RS:0;cn012:38253] 
> helpers.MarkerIgnoringBase(159): * ABORTING region server 
> cn012.l42scl.hortonworks.com,38253,1518110542271: Unhandled: Failed 
> suppression of fs shutdown hook: 
> org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@6a0c707e *
> java.lang.RuntimeException: Failed suppression of fs shutdown hook: 
> org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@6a0c707e
>   at 
> org.apache.hadoop.hbase.regionserver.ShutdownHook.suppressHdfsShutdownHook(ShutdownHook.java:207)
>   at 
> org.apache.hadoop.hbase.regionserver.ShutdownHook.install(ShutdownHook.java:85)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:927)
>   at 
> org.apache.hadoop.hbase.MiniHBaseCluster$MiniHBaseClusterRegionServer.runRegionServer(MiniHBaseCluster.java:187)
> {code}
> This is because when MiniDFSCluster is stopped in first subtest, hadoop 3 
> clears ShutdownHook.
> When the 2nd test starts, suppression of ShutdownHook fails.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-20037) Race when calling SequenceIdAccounting.resetHighest

2018-02-20 Thread Duo Zhang (JIRA)
Duo Zhang created HBASE-20037:
-

 Summary: Race when calling SequenceIdAccounting.resetHighest
 Key: HBASE-20037
 URL: https://issues.apache.org/jira/browse/HBASE-20037
 Project: HBase
  Issue Type: Bug
  Components: wal
Reporter: Duo Zhang
Assignee: Duo Zhang
 Fix For: 2.0.0-beta-2






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19554) AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit

2018-02-20 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371035#comment-16371035
 ] 

Duo Zhang commented on HBASE-19554:
---

Oh, maybe the same problem with numEntries. We should also reset 
sequenceIdAccounting before processing new requests. Let me file an issue to 
address it.

> AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit
> --
>
> Key: HBASE-19554
> URL: https://issues.apache.org/jira/browse/HBASE-19554
> Project: HBase
>  Issue Type: Sub-task
>  Components: Recovery, wal
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19554-thread-dump.patch, HBASE-19554.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/10554/artifact/patchprocess/patch-unit-hbase-server.txt
> The error message is a bit strange:
> {quote}
> [ERROR] testThreeRSAbort(org.apache.hadoop.hbase.master.TestDLSAsyncFSWAL) 
> Time elapsed: 20.627 s <<< ERROR!
> org.apache.hadoop.hbase.TableNotFoundException: Region of 
> 'hbase:namespace,,1513320505933.451650152885a3b41d0b1110deca513c.' is 
> expected in the table of 'testThreeRSAbort', but hbase:meta says it is in the 
> table of 'hbase:namespace'. hbase:meta might be damaged.
> {quote}
> It fails for both FSHLog and AsyncFSWAL. Need to dig more.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19989) READY_TO_MERGE and READY_TO_SPLIT do not update region state correctly

2018-02-20 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371033#comment-16371033
 ] 

Hadoop QA commented on HBASE-19989:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
34s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
34s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
37s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
21s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
10s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m  
4s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
48s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
51s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m 
43s{color} | {color:red} hbase-server: The patch generated 3 new + 265 
unchanged - 2 fixed = 268 total (was 267) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
22s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  4m 
39s{color} | {color:red} The patch causes 44 errors with Hadoop v2.4.1. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  5m 
52s{color} | {color:red} The patch causes 44 errors with Hadoop v2.5.2. {color} 
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}122m 51s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
26s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}154m 51s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestAdmin1 |
|   | hadoop.hbase.util.TestHBaseFsck |
|   | hadoop.hbase.client.TestAdmin2 |
|   | hadoop.hbase.master.TestCatalogJanitorInMemoryStates |
\\
\\
|| 

[jira] [Commented] (HBASE-19554) AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit

2018-02-20 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371024#comment-16371024
 ] 

Duo Zhang commented on HBASE-19554:
---

OK the numEntries is incorrect, will file an issue to address it, not critical, 
just logging.

And I think this is the problem
{noformat}
2018-02-20 16:33:41,183 INFO  [regionserver/asf903:0.logRoller] 
wal.AbstractFSWAL(690): Rolled WAL 
/user/jenkins/test-data/46c46c01-4dc8-4506-a228-a4460f2a28e9/WALs/asf903.gq1.ygridcore.net,52039,1519144411613/asf903.gq1.ygridcore.net%2C52039%2C1519144411613.1519144421143
 with entries=0, filesize=35.46 KB; new WAL 
/user/jenkins/test-data/46c46c01-4dc8-4506-a228-a4460f2a28e9/WALs/asf903.gq1.ygridcore.net,52039,1519144411613/asf903.gq1.ygridcore.net%2C52039%2C1519144411613.1519144421171
2018-02-20 16:33:41,184 DEBUG [regionserver/asf903:0.logRoller] 
wal.AbstractFSWAL(757): Create new FSHLog writer with pipeline: 
[DatanodeInfoWithStorage[127.0.0.1:60898,DS-fe8309dd-a316-4ef5-a474-7167557c5c76,DISK],
 
DatanodeInfoWithStorage[127.0.0.1:53328,DS-0f9fbb3d-3cd1-47ea-9867-52f1ecac6f19,DISK],
 
DatanodeInfoWithStorage[127.0.0.1:57523,DS-fc2097ed-4d98-40d7-a4a0-adfd31a5bf68,DISK]]
2018-02-20 16:33:41,184 INFO  [regionserver/asf903:0.logRoller] 
wal.AbstractFSWAL(652): Archiving 
hdfs://localhost:55625/user/jenkins/test-data/46c46c01-4dc8-4506-a228-a4460f2a28e9/WALs/asf903.gq1.ygridcore.net,52039,1519144411613/asf903.gq1.ygridcore.net%2C52039%2C1519144411613.1519144421143
 to 
hdfs://localhost:55625/user/jenkins/test-data/46c46c01-4dc8-4506-a228-a4460f2a28e9/oldWALs/asf903.gq1.ygridcore.net%2C52039%2C1519144411613.1519144421143
{noformat}

Here we move the wal file to oldWALs soon after rolling. We write to WAL 
directly in the test, so this should not happen. Let me dig more.

> AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit
> --
>
> Key: HBASE-19554
> URL: https://issues.apache.org/jira/browse/HBASE-19554
> Project: HBase
>  Issue Type: Sub-task
>  Components: Recovery, wal
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19554-thread-dump.patch, HBASE-19554.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/10554/artifact/patchprocess/patch-unit-hbase-server.txt
> The error message is a bit strange:
> {quote}
> [ERROR] testThreeRSAbort(org.apache.hadoop.hbase.master.TestDLSAsyncFSWAL) 
> Time elapsed: 20.627 s <<< ERROR!
> org.apache.hadoop.hbase.TableNotFoundException: Region of 
> 'hbase:namespace,,1513320505933.451650152885a3b41d0b1110deca513c.' is 
> expected in the table of 'testThreeRSAbort', but hbase:meta says it is in the 
> table of 'hbase:namespace'. hbase:meta might be damaged.
> {quote}
> It fails for both FSHLog and AsyncFSWAL. Need to dig more.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19985) Redundant instanceof check in ProtobufUtil#getServiceException

2018-02-20 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371009#comment-16371009
 ] 

Chia-Ping Tsai commented on HBASE-19985:


{quote}It seems dropping the 'e instanceof ServiceException' check but keeping 
the getCause() call should be good enough.
{quote}
+1

> Redundant instanceof check in ProtobufUtil#getServiceException
> --
>
> Key: HBASE-19985
> URL: https://issues.apache.org/jira/browse/HBASE-19985
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.1
>Reporter: Ted Yu
>Priority: Trivial
> Fix For: 1.5.0, 1.4.3
>
>
> {code}
>   public static IOException getServiceException(ServiceException e) {
> Throwable t = e;
> if (e instanceof ServiceException) {
>   t = e.getCause();
> {code}
> The instanceof check would always return true.
> This was reported by 
> https://builds.apache.org/job/PreCommit-HBASE-Build/11495/artifact/patchprocess/branch-findbugs-hbase-client-warnings.html#Warnings_STYLE



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20001) cleanIfNoMetaEntry() uses encoded instead of region name to lookup region

2018-02-20 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371001#comment-16371001
 ] 

Chia-Ping Tsai commented on HBASE-20001:


002 fix the TestSplitTransactionOnCluster.

[~apurtell] Could we add this to 1.4.2? [~thiruvel] said the bug cause the data 
lose on their cluster.

> cleanIfNoMetaEntry() uses encoded instead of region name to lookup region
> -
>
> Key: HBASE-20001
> URL: https://issues.apache.org/jira/browse/HBASE-20001
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.2.0, 1.3.0, 1.4.0, 1.1.7
>Reporter: Francis Liu
>Assignee: Thiruvel Thirumoolan
>Priority: Major
> Fix For: 1.3.2, 1.5.0, 1.2.7, 1.4.3
>
> Attachments: HBASE-20001.branch-1.4.001.patch, 
> HBASE-20001.branch-1.4.002.patch
>
>
> In RegionStates.cleanIfNoMetaEntry()
> {{if (MetaTableAccessor.getRegion(server.getConnection(), 
> hri.getEncodedNameAsBytes()) == null) {}}
> {{regionOffline(hri);}}
> {{FSUtils.deleteRegionDir(server.getConfiguration(), hri);}}
> }
> But api expects regionname
> {{public static Pair getRegion(Connection 
> connection, byte [] regionName)}}
> So we might end up cleaning good regions.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20001) cleanIfNoMetaEntry() uses encoded instead of region name to lookup region

2018-02-20 Thread Chia-Ping Tsai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chia-Ping Tsai updated HBASE-20001:
---
Attachment: HBASE-20001.branch-1.4.002.patch

> cleanIfNoMetaEntry() uses encoded instead of region name to lookup region
> -
>
> Key: HBASE-20001
> URL: https://issues.apache.org/jira/browse/HBASE-20001
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.2.0, 1.3.0, 1.4.0, 1.1.7
>Reporter: Francis Liu
>Assignee: Thiruvel Thirumoolan
>Priority: Major
> Fix For: 1.3.2, 1.5.0, 1.2.7, 1.4.3
>
> Attachments: HBASE-20001.branch-1.4.001.patch, 
> HBASE-20001.branch-1.4.002.patch
>
>
> In RegionStates.cleanIfNoMetaEntry()
> {{if (MetaTableAccessor.getRegion(server.getConnection(), 
> hri.getEncodedNameAsBytes()) == null) {}}
> {{regionOffline(hri);}}
> {{FSUtils.deleteRegionDir(server.getConfiguration(), hri);}}
> }
> But api expects regionname
> {{public static Pair getRegion(Connection 
> connection, byte [] regionName)}}
> So we might end up cleaning good regions.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19554) AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit

2018-02-20 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370998#comment-16370998
 ] 

Duo Zhang commented on HBASE-19554:
---

Oh they are not same... But still a bit strange that the file sizes are same 
but the entries numbers are different...

> AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit
> --
>
> Key: HBASE-19554
> URL: https://issues.apache.org/jira/browse/HBASE-19554
> Project: HBase
>  Issue Type: Sub-task
>  Components: Recovery, wal
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19554-thread-dump.patch, HBASE-19554.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/10554/artifact/patchprocess/patch-unit-hbase-server.txt
> The error message is a bit strange:
> {quote}
> [ERROR] testThreeRSAbort(org.apache.hadoop.hbase.master.TestDLSAsyncFSWAL) 
> Time elapsed: 20.627 s <<< ERROR!
> org.apache.hadoop.hbase.TableNotFoundException: Region of 
> 'hbase:namespace,,1513320505933.451650152885a3b41d0b1110deca513c.' is 
> expected in the table of 'testThreeRSAbort', but hbase:meta says it is in the 
> table of 'hbase:namespace'. hbase:meta might be damaged.
> {quote}
> It fails for both FSHLog and AsyncFSWAL. Need to dig more.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20004) Client is not able to execute REST queries through browser in a secure cluster

2018-02-20 Thread Ashish Singhi (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370994#comment-16370994
 ] 

Ashish Singhi commented on HBASE-20004:
---

Note this issue is not only with the REST browser client, we found the same 
problem with REST java client also and another issue with our REST java client 
code is, it has no logic to negotiate authentication with the server, anyways 
that can be taken as part of another jira. 

> Client is not able to execute REST queries through browser in a secure cluster
> --
>
> Key: HBASE-20004
> URL: https://issues.apache.org/jira/browse/HBASE-20004
> Project: HBase
>  Issue Type: Bug
>  Components: REST, security
>Affects Versions: 1.3.1
>Reporter: Ashish Singhi
>Assignee: Ashish Singhi
>Priority: Minor
> Fix For: 1.5.0
>
> Attachments: HBASE-20004.branch-1.patch, HBASE-20004.patch
>
>
> Firefox browser is not able to negotiate REST queries with server in secure 
> mode.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20008) [backport] NullPointerException when restoring a snapshot after splitting a region

2018-02-20 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370993#comment-16370993
 ] 

Hadoop QA commented on HBASE-20008:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
23s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
30s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
34s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
12s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
32s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
58s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
24s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
31s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
30s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
32s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
11s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  2m 
58s{color} | {color:red} The patch causes 44 errors with Hadoop v2.4.1. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  3m 
43s{color} | {color:red} The patch causes 44 errors with Hadoop v2.5.2. {color} 
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
33s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}105m 
22s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
20s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}128m 35s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:36a7029 |
| JIRA Issue | HBASE-20008 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12911333/HBASE-20008.branch-1.003.patch
 |
| Optional Tests |  asflicense  javac  

[jira] [Created] (HBASE-20036) TestAvoidCellReferencesIntoShippedBlocks timed out

2018-02-20 Thread stack (JIRA)
stack created HBASE-20036:
-

 Summary: TestAvoidCellReferencesIntoShippedBlocks timed out
 Key: HBASE-20036
 URL: https://issues.apache.org/jira/browse/HBASE-20036
 Project: HBase
  Issue Type: Sub-task
Reporter: stack


Looks like it is stuck can't flush; bad math?

See the dashboard where it hung here: 
https://builds.apache.org/job/HBASE-Flaky-Tests-branch2.0/2428/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.client.TestAvoidCellReferencesIntoShippedBlocks-output.txt



... the provocation could be this?

2018-02-21 04:18:44,973 DEBUG [Thread-178] bucket.BucketCache(629): This block 
eefaa9a7b10e437b9fc2b55a67d63191_4356 is still referred by 1 readers. Can not 
be freed now. Hence will mark this for evicting at a later point
Exception in thread "Thread-178" java.lang.AssertionError: old blocks should 
still be found  expected:<6> but was:<5>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)

... Then we get stuck doing this:

2018-02-21 04:23:34,661 DEBUG [master/asf903:0.Chore.1] master.HMaster(1524): 
Skipping normalization for table: testHBase16372InCompactionWritePath, as it's 
either system table or doesn't have auto normalization turned on
2018-02-21 04:23:35,695 INFO  [regionserver/asf903:0.Chore.1] 
regionserver.HRegionServer$PeriodicMemStoreFlusher(1752): MemstoreFlusherChore 
requesting flush of hbase:meta,,1.1588230740 because info has an old edit so 
flush to free WALs after random delay 286820ms
2018-02-21 04:23:36,009 DEBUG [ReadOnlyZKClient-localhost:61855@0x227ea3ed] 
zookeeper.ReadOnlyZKClient(316): 0x227ea3ed to localhost:61855 inactive for 
6ms; closing (Will reconnect when new requests)

It also failed a recent nightly for same reason:

https://builds.apache.org/job/HBase%20Nightly/job/branch-2/355/

Any chance you'd take a look [~ram_krish]? You best at this stuff?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20034) Make periodic flusher delay configurable

2018-02-20 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370990#comment-16370990
 ] 

Chia-Ping Tsai commented on HBASE-20034:


How we handle the invalid config? ex. negative value. BTW, is there a use case 
that you have to change the delay time?

> Make periodic flusher delay configurable
> 
>
> Key: HBASE-20034
> URL: https://issues.apache.org/jira/browse/HBASE-20034
> Project: HBase
>  Issue Type: Improvement
>  Components: regionserver
>Affects Versions: 3.0.0
>Reporter: Vincent Poon
>Assignee: Vincent Poon
>Priority: Major
> Attachments: HBASE-20034.branch-1.patch, HBASE-20034.master.patch
>
>
> PeriodicMemstoreFlusher is currently configured to flush with a random delay 
> of up to 5 minutes.  Make this configurable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20024) TestMergeTableRegionsProcedure is STILL flakey

2018-02-20 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370979#comment-16370979
 ] 

stack commented on HBASE-20024:
---

We are on to a new failure type. 


java.lang.AssertionError: expected: but was:
at 
org.apache.hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure.testRollbackAndDoubleExecution(TestMergeTableRegionsProcedure.java:273)

Happens in the PONR test too but only on GCE it seems... so it not disturbing 
nightlies.

Our incidence does not seem to have gone down though. It has just changed. 
[~uagashe] Want to have a look at this one?

> TestMergeTableRegionsProcedure is STILL flakey
> --
>
> Key: HBASE-20024
> URL: https://issues.apache.org/jira/browse/HBASE-20024
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: stack
>Priority: Major
> Attachments: HBASE-20024.branch-2.001.patch
>
>
> This is a follow-on from HBASE-20015. Root issue is that merge does not 
> support rollback once it has hit the point-of-no-return; it can only 
> roll-forward at this point.
> HBASE-18018 added abort to all procedures. HBASE-18016 added ignoring abort 
> to the truncate procedure to get around flakeyness. HBASE-20022 is a new 
> issue to figure what to do w/ unabortable procedures.
> Meantime, merge and split have PONR and the procedure executor test harness 
> does abort regardless making these tests flakies. Adding an ignore of the 
> abort once into the PONR makes sense (Always? HBASE-20022 is for those as yet 
> unknown cases where it does not). Let me ignore to merge and split in this 
> issue to address flakeyness.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20017) BufferedMutatorImpl submit the same mutation repeatedly

2018-02-20 Thread ramkrishna.s.vasudevan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370978#comment-16370978
 ] 

ramkrishna.s.vasudevan commented on HBASE-20017:


Its not at all a problem :). You need not apologize. I was just saying that I 
too faced this issue. 

> BufferedMutatorImpl submit the same mutation repeatedly
> ---
>
> Key: HBASE-20017
> URL: https://issues.apache.org/jira/browse/HBASE-20017
> Project: HBase
>  Issue Type: Bug
>  Components: Client
>Affects Versions: 1.4.0, 1.4.1, 1.4.2
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Blocker
> Fix For: 2.0.0, 1.5.0, 1.4.2
>
> Attachments: HBASE-20017.branch-1.4.v0.patch.patch, 
> HBASE-20017.branch-1.v0.patch.patch, HBASE-20017.v0.patch.patch
>
>
> BMI pass a iter of inner buffer to AsyncProcess to take the undealt 
> mutations, AsyncProcess call iter#next to get the mutation and then call 
> iter#remove to delete the mutation from inner buffer. Hence, There's a good 
> chance that  the mutation is processed repeatedly in case there are a bunch 
> of threads which are running the flush.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-20035) .TestQuotaStatusRPCs.testQuotaStatusFromMaster failed with NPEs and RuntimeExceptions

2018-02-20 Thread stack (JIRA)
stack created HBASE-20035:
-

 Summary: .TestQuotaStatusRPCs.testQuotaStatusFromMaster failed 
with NPEs and RuntimeExceptions
 Key: HBASE-20035
 URL: https://issues.apache.org/jira/browse/HBASE-20035
 Project: HBase
  Issue Type: Sub-task
Reporter: stack


It failed the nightly.

Says this...

Error Message
Waiting timed out after [30,000] msec
Stacktrace
java.lang.AssertionError: Waiting timed out after [30,000] msec
at 
org.apache.hadoop.hbase.quotas.TestQuotaStatusRPCs.testQuotaStatusFromMaster(TestQuotaStatusRPCs.java:267)

... but looking in log I see following:

Odd thing is the test is run three times and it failed all three times for same 
reason.

[ERROR] Failures: 
[ERROR] 
org.apache.hadoop.hbase.quotas.TestQuotaStatusRPCs.testQuotaStatusFromMaster(org.apache.hadoop.hbase.quotas.TestQuotaStatusRPCs)
[ERROR]   Run 1: TestQuotaStatusRPCs.testQuotaStatusFromMaster:267 Waiting 
timed out after [30,000] msec
[ERROR]   Run 2: TestQuotaStatusRPCs.testQuotaStatusFromMaster:267 Waiting 
timed out after [30,000] msec
[ERROR]   Run 3: TestQuotaStatusRPCs.testQuotaStatusFromMaster:267 Waiting 
timed out after [30,000] msec


If you go to build artifacts you can download full -output.txt log. I see stuff 
like this which might be ok

{code}
2018-02-21 01:29:59,546 INFO  
[StoreCloserThread-testQuotaStatusFromMaster4,0,1519176558800.1dbd00f38915cd276410065f85140b26.-1]
 regionserver.HStore(930): Closed f1
2018-02-21 01:29:59,551 ERROR [master/ad51e354307e:0.Chore.2] 
hbase.ScheduledChore(189): Caught error
java.lang.RuntimeException: java.util.concurrent.RejectedExecutionException: 
Task 
org.apache.hadoop.hbase.client.ResultBoundedCompletionService$QueueingFuture@79ec2ef9
 rejected from java.util.concurrent.ThreadPoolExecutor@5198a326[Terminated, 
pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 142]
  at 
org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithoutRetries(RpcRetryingCallerImpl.java:200)
  at org.apache.hadoop.hbase.client.ClientScanner.call(ClientScanner.java:269)
  at 
org.apache.hadoop.hbase.client.ClientScanner.loadCache(ClientScanner.java:437)
  at 
org.apache.hadoop.hbase.client.ClientScanner.nextWithSyncCache(ClientScanner.java:312)
  at org.apache.hadoop.hbase.client.ClientScanner.next(ClientScanner.java:597)
  at org.apache.hadoop.hbase.quotas.QuotaRetriever.next(QuotaRetriever.java:106)
  at 
org.apache.hadoop.hbase.quotas.QuotaRetriever$Iter.(QuotaRetriever.java:125)
  at 
org.apache.hadoop.hbase.quotas.QuotaRetriever.iterator(QuotaRetriever.java:117)
  at 
org.apache.hadoop.hbase.quotas.QuotaObserverChore.fetchAllTablesWithQuotasDefined(QuotaObserverChore.java:458)
  at 
org.apache.hadoop.hbase.quotas.QuotaObserverChore._chore(QuotaObserverChore.java:148)
  at 
org.apache.hadoop.hbase.quotas.QuotaObserverChore.chore(QuotaObserverChore.java:136)
  at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:186)
  at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
  at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
  at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
  at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
  at 
org.apache.hadoop.hbase.JitterScheduledThreadPoolExecutorImpl$JitteredRunnableScheduledFuture.run(JitterScheduledThreadPoolExecutorImpl.java:111)
  at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
  at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
  at java.lang.Thread.run(Thread.java:748)
Caused by: java.util.concurrent.RejectedExecutionException: Task 
org.apache.hadoop.hbase.client.ResultBoundedCompletionService$QueueingFuture@79ec2ef9
 rejected from java.util.concurrent.ThreadPoolExecutor@5198a326[Terminated, 
pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 142]
  at 
java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2063)
  at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:830)
  at 
java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1379)
  at 
org.apache.hadoop.hbase.client.ResultBoundedCompletionService.submit(ResultBoundedCompletionService.java:171)
  at 
org.apache.hadoop.hbase.client.ScannerCallableWithReplicas.addCallsForCurrentReplica(ScannerCallableWithReplicas.java:320)
  at 
org.apache.hadoop.hbase.client.ScannerCallableWithReplicas.call(ScannerCallableWithReplicas.java:182)
  at 
org.apache.hadoop.hbase.client.ScannerCallableWithReplicas.call(ScannerCallableWithReplicas.java:58)
  at 
org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithoutRetries(RpcRetryingCallerImpl.java:192)
  ... 19 more
{code}

.. but then this which looks less ok:

[jira] [Commented] (HBASE-20017) BufferedMutatorImpl submit the same mutation repeatedly

2018-02-20 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370976#comment-16370976
 ] 

Chia-Ping Tsai commented on HBASE-20017:


{quote}I spent lot of time debugging our internal branch code thinking it was 
doing something wrong on server side and finally convinced myself it is from 
the client or the RPC layer.
{quote}
I must apologize for wasting your time. 

> BufferedMutatorImpl submit the same mutation repeatedly
> ---
>
> Key: HBASE-20017
> URL: https://issues.apache.org/jira/browse/HBASE-20017
> Project: HBase
>  Issue Type: Bug
>  Components: Client
>Affects Versions: 1.4.0, 1.4.1, 1.4.2
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Blocker
> Fix For: 2.0.0, 1.5.0, 1.4.2
>
> Attachments: HBASE-20017.branch-1.4.v0.patch.patch, 
> HBASE-20017.branch-1.v0.patch.patch, HBASE-20017.v0.patch.patch
>
>
> BMI pass a iter of inner buffer to AsyncProcess to take the undealt 
> mutations, AsyncProcess call iter#next to get the mutation and then call 
> iter#remove to delete the mutation from inner buffer. Hence, There's a good 
> chance that  the mutation is processed repeatedly in case there are a bunch 
> of threads which are running the flush.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20017) BufferedMutatorImpl submit the same mutation repeatedly

2018-02-20 Thread ramkrishna.s.vasudevan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370975#comment-16370975
 ] 

ramkrishna.s.vasudevan commented on HBASE-20017:


Ok. I could see the fix branches now. Seeing the patch names I thought it is 
branch-1 issue only. I spent lot of time debugging our internal branch code 
thinking it was doing something wrong on server side and finally convinced 
myself it is from the client or the RPC layer. But was yet to find the root 
cause. Thanks for the finding.

> BufferedMutatorImpl submit the same mutation repeatedly
> ---
>
> Key: HBASE-20017
> URL: https://issues.apache.org/jira/browse/HBASE-20017
> Project: HBase
>  Issue Type: Bug
>  Components: Client
>Affects Versions: 1.4.0, 1.4.1, 1.4.2
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Blocker
> Fix For: 2.0.0, 1.5.0, 1.4.2
>
> Attachments: HBASE-20017.branch-1.4.v0.patch.patch, 
> HBASE-20017.branch-1.v0.patch.patch, HBASE-20017.v0.patch.patch
>
>
> BMI pass a iter of inner buffer to AsyncProcess to take the undealt 
> mutations, AsyncProcess call iter#next to get the mutation and then call 
> iter#remove to delete the mutation from inner buffer. Hence, There's a good 
> chance that  the mutation is processed repeatedly in case there are a bunch 
> of threads which are running the flush.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20017) BufferedMutatorImpl submit the same mutation repeatedly

2018-02-20 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370966#comment-16370966
 ] 

Chia-Ping Tsai commented on HBASE-20017:


{quote}I have not checked the code in detail but are you sure this is not there 
in any of the newer branches after 1.4?
{quote}
Pardon me. Not only the branch-1.4 but also branch-1, branch-2, and master are 
impacted. The patches I had attached are against branch-1, branch-1.4, and 
master. [~apurtell] have committed the patches to all of them. There's great 
shame in introducing this critical bug. :(

> BufferedMutatorImpl submit the same mutation repeatedly
> ---
>
> Key: HBASE-20017
> URL: https://issues.apache.org/jira/browse/HBASE-20017
> Project: HBase
>  Issue Type: Bug
>  Components: Client
>Affects Versions: 1.4.0, 1.4.1, 1.4.2
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Blocker
> Fix For: 2.0.0, 1.5.0, 1.4.2
>
> Attachments: HBASE-20017.branch-1.4.v0.patch.patch, 
> HBASE-20017.branch-1.v0.patch.patch, HBASE-20017.v0.patch.patch
>
>
> BMI pass a iter of inner buffer to AsyncProcess to take the undealt 
> mutations, AsyncProcess call iter#next to get the mutation and then call 
> iter#remove to delete the mutation from inner buffer. Hence, There's a good 
> chance that  the mutation is processed repeatedly in case there are a bunch 
> of threads which are running the flush.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20017) BufferedMutatorImpl submit the same mutation repeatedly

2018-02-20 Thread ramkrishna.s.vasudevan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370962#comment-16370962
 ] 

ramkrishna.s.vasudevan commented on HBASE-20017:


[~chia7712]
I have not checked the code in detail but are you sure this is not there in any 
of the newer branches after 1.4? In one of our internal branch based on some 
old master (trunk) I found this happening. I did not dig in deep as was doing 
some other things. But wanted to get back to it. 

> BufferedMutatorImpl submit the same mutation repeatedly
> ---
>
> Key: HBASE-20017
> URL: https://issues.apache.org/jira/browse/HBASE-20017
> Project: HBase
>  Issue Type: Bug
>  Components: Client
>Affects Versions: 1.4.0, 1.4.1, 1.4.2
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Blocker
> Fix For: 2.0.0, 1.5.0, 1.4.2
>
> Attachments: HBASE-20017.branch-1.4.v0.patch.patch, 
> HBASE-20017.branch-1.v0.patch.patch, HBASE-20017.v0.patch.patch
>
>
> BMI pass a iter of inner buffer to AsyncProcess to take the undealt 
> mutations, AsyncProcess call iter#next to get the mutation and then call 
> iter#remove to delete the mutation from inner buffer. Hence, There's a good 
> chance that  the mutation is processed repeatedly in case there are a bunch 
> of threads which are running the flush.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (HBASE-20001) cleanIfNoMetaEntry() uses encoded instead of region name to lookup region

2018-02-20 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368726#comment-16368726
 ] 

Chia-Ping Tsai edited comment on HBASE-20001 at 2/21/18 4:51 AM:
-

-Could we use MetaTableAccessor#etRegionLocation instead? The passed region 
name is converted to HRegionInfo if we use MetaTableAccessor#getRegion. That is 
a litter ugly I'd say.-

Seems MetaTableAccessor#etRegionLocation won't return null even if no entry is 
in .meta. 


was (Author: chia7712):
Could we use MetaTableAccessor#etRegionLocation instead? The passed region name 
is converted to HRegionInfo if we use MetaTableAccessor#getRegion. That is a 
litter ugly I'd say.

> cleanIfNoMetaEntry() uses encoded instead of region name to lookup region
> -
>
> Key: HBASE-20001
> URL: https://issues.apache.org/jira/browse/HBASE-20001
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.2.0, 1.3.0, 1.4.0, 1.1.7
>Reporter: Francis Liu
>Assignee: Thiruvel Thirumoolan
>Priority: Major
> Fix For: 1.3.2, 1.5.0, 1.2.7, 1.4.3
>
> Attachments: HBASE-20001.branch-1.4.001.patch
>
>
> In RegionStates.cleanIfNoMetaEntry()
> {{if (MetaTableAccessor.getRegion(server.getConnection(), 
> hri.getEncodedNameAsBytes()) == null) {}}
> {{regionOffline(hri);}}
> {{FSUtils.deleteRegionDir(server.getConfiguration(), hri);}}
> }
> But api expects regionname
> {{public static Pair getRegion(Connection 
> connection, byte [] regionName)}}
> So we might end up cleaning good regions.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20027) Add test TestClusterPortAssignment

2018-02-20 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370951#comment-16370951
 ] 

Hadoop QA commented on HBASE-20027:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
34s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
35s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
39s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
17s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
55s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
14s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
28s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
35s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
35s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m 
17s{color} | {color:red} hbase-server: The patch generated 1 new + 47 unchanged 
- 0 fixed = 48 total (was 47) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
39s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  3m 
32s{color} | {color:red} The patch causes 44 errors with Hadoop v2.4.1. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  4m 
25s{color} | {color:red} The patch causes 44 errors with Hadoop v2.5.2. {color} 
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}108m 
46s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
20s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}135m 21s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:36a7029 |
| JIRA Issue | HBASE-20027 |
| JIRA Patch URL | 

[jira] [Updated] (HBASE-20008) [backport] NullPointerException when restoring a snapshot after splitting a region

2018-02-20 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-20008:
---
   Resolution: Fixed
 Hadoop Flags: Reviewed
Fix Version/s: 1.4.2
   Status: Resolved  (was: Patch Available)

Thanks for the patch, Toshihiro

> [backport] NullPointerException when restoring a snapshot after splitting a 
> region
> --
>
> Key: HBASE-20008
> URL: https://issues.apache.org/jira/browse/HBASE-20008
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 1.4.2
>
> Attachments: HBASE-20008.branch-1.001.patch, 
> HBASE-20008.branch-1.002.patch, HBASE-20008.branch-1.003.patch
>
>
> Bring parent fix back to branch-1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19989) READY_TO_MERGE and READY_TO_SPLIT do not update region state correctly

2018-02-20 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-19989:
---
Hadoop Flags: Reviewed
  Status: Patch Available  (was: Open)

> READY_TO_MERGE and READY_TO_SPLIT do not update region state correctly
> --
>
> Key: HBASE-19989
> URL: https://issues.apache.org/jira/browse/HBASE-19989
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.1, 1.3.1
>Reporter: Ben Lau
>Assignee: Ben Lau
>Priority: Major
> Attachments: HBASE-19989-branch-1.patch
>
>
> Region state transitions do not work correctly for READY_TO_MERGE/SPLIT.  
> [~thiruvel] and I noticed this is due to break statements being in the wrong 
> place in AssignmentManager.  This allows a race condition for example in 
> which one of the regions being merged could be moved concurrently, resulting 
> in the merge transaction failing and then double assignment and/or dataloss.  
> This bug appears to only affect branch-1 (for example 1.3 and 1.4) and not 
> branch-2 as the relevant code in AM has since been rewritten.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20008) [backport] NullPointerException when restoring a snapshot after splitting a region

2018-02-20 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370928#comment-16370928
 ] 

Hadoop QA commented on HBASE-20008:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
56s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
42s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
42s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
24s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 8s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
29s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
34s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
40s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
35s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
37s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  3m 
30s{color} | {color:red} The patch causes 44 errors with Hadoop v2.4.1. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  4m 
22s{color} | {color:red} The patch causes 44 errors with Hadoop v2.5.2. {color} 
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
35s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}108m 
27s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
19s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}135m 57s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:36a7029 |
| JIRA Issue | HBASE-20008 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12911321/HBASE-20008.branch-1.001.patch
 |
| Optional Tests |  asflicense  javac  

[jira] [Commented] (HBASE-20034) Make periodic flusher delay configurable

2018-02-20 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370925#comment-16370925
 ] 

Hadoop QA commented on HBASE-20034:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 13m 
39s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
45s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
32s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
37s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
18s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
54s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
13s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
34s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
33s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
31s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  3m 
29s{color} | {color:red} The patch causes 44 errors with Hadoop v2.4.1. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  4m 
24s{color} | {color:red} The patch causes 44 errors with Hadoop v2.5.2. {color} 
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
25s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}123m 
42s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
28s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}163m 27s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:36a7029 |
| JIRA Issue | HBASE-20034 |
| JIRA Patch URL | 

[jira] [Updated] (HBASE-20008) [backport] NullPointerException when restoring a snapshot after splitting a region

2018-02-20 Thread Toshihiro Suzuki (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Toshihiro Suzuki updated HBASE-20008:
-
Attachment: HBASE-20008.branch-1.003.patch

> [backport] NullPointerException when restoring a snapshot after splitting a 
> region
> --
>
> Key: HBASE-20008
> URL: https://issues.apache.org/jira/browse/HBASE-20008
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Toshihiro Suzuki
>Priority: Major
> Attachments: HBASE-20008.branch-1.001.patch, 
> HBASE-20008.branch-1.002.patch, HBASE-20008.branch-1.003.patch
>
>
> Bring parent fix back to branch-1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20008) [backport] NullPointerException when restoring a snapshot after splitting a region

2018-02-20 Thread Toshihiro Suzuki (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370915#comment-16370915
 ] 

Toshihiro Suzuki commented on HBASE-20008:
--

Thanks [~yuzhih...@gmail.com]. I just attached v3 patch.

> [backport] NullPointerException when restoring a snapshot after splitting a 
> region
> --
>
> Key: HBASE-20008
> URL: https://issues.apache.org/jira/browse/HBASE-20008
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Toshihiro Suzuki
>Priority: Major
> Attachments: HBASE-20008.branch-1.001.patch, 
> HBASE-20008.branch-1.002.patch, HBASE-20008.branch-1.003.patch
>
>
> Bring parent fix back to branch-1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20007) rest server doesn't start against hadoop-3

2018-02-20 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370914#comment-16370914
 ] 

Hadoop QA commented on HBASE-20007:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
22s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
 9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  6m 
27s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
43s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  3m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
11s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  6m  
8s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.5. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  8m  
9s{color} | {color:red} The patch causes 10 errors with Hadoop v2.7.4. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 10m 
20s{color} | {color:red} The patch causes 10 errors with Hadoop v3.0.0. {color} 
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
41s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}168m 
19s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
34s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}209m 26s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-20007 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12911298/HBASE-20007.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  xml  |
| uname | Linux 514364a409da 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 

[jira] [Commented] (HBASE-20008) [backport] NullPointerException when restoring a snapshot after splitting a region

2018-02-20 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370911#comment-16370911
 ] 

Ted Yu commented on HBASE-20008:


Minor comment:
{code}
+  } catch (InterruptedException ex) {
+throw new IOException(ex);
{code}
Please throw InterruptedIOException.

Thanks

> [backport] NullPointerException when restoring a snapshot after splitting a 
> region
> --
>
> Key: HBASE-20008
> URL: https://issues.apache.org/jira/browse/HBASE-20008
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Toshihiro Suzuki
>Priority: Major
> Attachments: HBASE-20008.branch-1.001.patch, 
> HBASE-20008.branch-1.002.patch
>
>
> Bring parent fix back to branch-1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20008) [backport] NullPointerException when restoring a snapshot after splitting a region

2018-02-20 Thread Toshihiro Suzuki (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370909#comment-16370909
 ] 

Toshihiro Suzuki commented on HBASE-20008:
--

The correct snippet is:
{code}
diff --git 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
index 0ed75a3..f9aea13 100644
--- 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
+++ 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
@@ -183,8 +183,9 @@ public class RestoreSnapshotHandler extends 
TableEventHandler implements Snapsho
   String msg = "restore snapshot=" + 
ClientSnapshotDescriptionUtils.toString(snapshot)
   + " failed. Try re-running the restore command.";
   LOG.error(msg, e);
-  monitor.receive(new 
ForeignException(masterServices.getServerName().toString(), e));
-  throw new RestoreSnapshotException(msg, e);
+  IOException rse = new RestoreSnapshotException(msg, e);
+  monitor.receive(new 
ForeignException(masterServices.getServerName().toString(), rse));
+  throw rse;
 }
   }
{code}

> [backport] NullPointerException when restoring a snapshot after splitting a 
> region
> --
>
> Key: HBASE-20008
> URL: https://issues.apache.org/jira/browse/HBASE-20008
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Toshihiro Suzuki
>Priority: Major
> Attachments: HBASE-20008.branch-1.001.patch, 
> HBASE-20008.branch-1.002.patch
>
>
> Bring parent fix back to branch-1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20008) [backport] NullPointerException when restoring a snapshot after splitting a region

2018-02-20 Thread Toshihiro Suzuki (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370906#comment-16370906
 ] 

Toshihiro Suzuki commented on HBASE-20008:
--

[~yuzhih...@gmail.com] I mistook. I just attached v2 patch.

> [backport] NullPointerException when restoring a snapshot after splitting a 
> region
> --
>
> Key: HBASE-20008
> URL: https://issues.apache.org/jira/browse/HBASE-20008
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Toshihiro Suzuki
>Priority: Major
> Attachments: HBASE-20008.branch-1.001.patch, 
> HBASE-20008.branch-1.002.patch
>
>
> Bring parent fix back to branch-1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20008) [backport] NullPointerException when restoring a snapshot after splitting a region

2018-02-20 Thread Toshihiro Suzuki (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Toshihiro Suzuki updated HBASE-20008:
-
Attachment: HBASE-20008.branch-1.002.patch

> [backport] NullPointerException when restoring a snapshot after splitting a 
> region
> --
>
> Key: HBASE-20008
> URL: https://issues.apache.org/jira/browse/HBASE-20008
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Toshihiro Suzuki
>Priority: Major
> Attachments: HBASE-20008.branch-1.001.patch, 
> HBASE-20008.branch-1.002.patch
>
>
> Bring parent fix back to branch-1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20008) [backport] NullPointerException when restoring a snapshot after splitting a region

2018-02-20 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370897#comment-16370897
 ] 

Ted Yu commented on HBASE-20008:


In the above snippet, why do we need to create two instances of 
RestoreSnapshotException ?

> [backport] NullPointerException when restoring a snapshot after splitting a 
> region
> --
>
> Key: HBASE-20008
> URL: https://issues.apache.org/jira/browse/HBASE-20008
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Toshihiro Suzuki
>Priority: Major
> Attachments: HBASE-20008.branch-1.001.patch
>
>
> Bring parent fix back to branch-1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20029) @Ignore TestQuotaThrottle and TestReplicasClient#testCancelOfMultiGet

2018-02-20 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370891#comment-16370891
 ] 

Hudson commented on HBASE-20029:


SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #4620 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/4620/])
HBASE-20029 @Ignore TestQuotaThrottle and (stack: rev 
148356a7bfeacce17aa85029348e5548579e78d6)
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaThrottle.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicasClient.java


> @Ignore TestQuotaThrottle and TestReplicasClient#testCancelOfMultiGet
> -
>
> Key: HBASE-20029
> URL: https://issues.apache.org/jira/browse/HBASE-20029
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20029.branch-2.001.patch
>
>
> We are down to the last few flakies on branch-2. These two fail mostly on a 
> constrained GCE machine (4cpus, 15G). The TestQuotaThrottling fails about 30% 
> of the time. It needs someone to dive in and add counting of RPCs and study 
> the difference when it fails. The TestReplicas#testCancleOfMultiGet fails 
> occasionally on Apache and about %17 of the time on GCE machine. 
> I'm disabling them because I'm not going to try and figure them. If someone 
> wants to take up the cause that'd be great but meantime I don't want them 
> failing our nightlies.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19400) Add missing security checks in MasterRpcServices

2018-02-20 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370892#comment-16370892
 ] 

Hudson commented on HBASE-19400:


SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #4620 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/4620/])
HBASE-19400 Add missing security checks in MasterRpcServices (appy: rev 
6b8439366134b6749895b6019bc068d169865b48)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
* (add) 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAdminOnlyOperations.java
* (edit) 
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessChecker.java


> Add missing security checks in MasterRpcServices
> 
>
> Key: HBASE-19400
> URL: https://issues.apache.org/jira/browse/HBASE-19400
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.0.0-beta-1
>Reporter: Balazs Meszaros
>Assignee: Appy
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19400.master.001.patch, 
> HBASE-19400.master.002.patch, HBASE-19400.master.003.patch, 
> HBASE-19400.master.004.patch, HBASE-19400.master.004.patch, 
> HBASE-19400.master.005.patch, HBASE-19400.master.006.patch, 
> HBASE-19400.master.007.patch, HBASE-19400.master.007.patch
>
>
> The following RPC methods in MasterRpcServices do not have ACL check for 
> ADMIN rights.
> - normalize
> - setNormalizerRunning
> - runCatalogScan
> - enableCatalogJanitor
> - runCleanerChore
> - setCleanerChoreRunning
> - execMasterService
> - execProcedure
> - execProcedureWithRet



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20024) TestMergeTableRegionsProcedure is STILL flakey

2018-02-20 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370890#comment-16370890
 ] 

Hudson commented on HBASE-20024:


SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #4620 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/4620/])
HBASE-20024 TestMergeTableRegionsProcedure is STILL flakey (stack: rev 
51cea3e2c3c75b82148f14ca7903a88daa3738d9)
* (edit) 
hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/StateMachineProcedure.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java
* (edit) 
hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DeleteTableProcedure.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestMergeTableRegionsProcedure.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureTestingUtility.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureScheduler.java


> TestMergeTableRegionsProcedure is STILL flakey
> --
>
> Key: HBASE-20024
> URL: https://issues.apache.org/jira/browse/HBASE-20024
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: stack
>Priority: Major
> Attachments: HBASE-20024.branch-2.001.patch
>
>
> This is a follow-on from HBASE-20015. Root issue is that merge does not 
> support rollback once it has hit the point-of-no-return; it can only 
> roll-forward at this point.
> HBASE-18018 added abort to all procedures. HBASE-18016 added ignoring abort 
> to the truncate procedure to get around flakeyness. HBASE-20022 is a new 
> issue to figure what to do w/ unabortable procedures.
> Meantime, merge and split have PONR and the procedure executor test harness 
> does abort regardless making these tests flakies. Adding an ignore of the 
> abort once into the PONR makes sense (Always? HBASE-20022 is for those as yet 
> unknown cases where it does not). Let me ignore to merge and split in this 
> issue to address flakeyness.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20027) Add test TestClusterPortAssignment

2018-02-20 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370866#comment-16370866
 ] 

Andrew Purtell commented on HBASE-20027:


Redid the earlier patches because I put a new constant for a new configuration 
key into HBaseCluster, which isn't inherited by LocalHBaseCluster on branch-2 
or master, only in branch-1, so I moved it to LocalHBaseCluster everywhere.

> Add test TestClusterPortAssignment
> --
>
> Key: HBASE-20027
> URL: https://issues.apache.org/jira/browse/HBASE-20027
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.0, 1.4.1
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Fix For: 1.4.2
>
> Attachments: HBASE-20027-branch-1.patch, HBASE-20027.patch
>
>
> Port assignments for master ports in site configuration appear to be ignored.
> We are not catching this in tests because there appears to be no positive 
> test for port assignment and the only fixed information we require is the 
> zookeeper quorum and client port. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20027) Add test TestClusterPortAssignment

2018-02-20 Thread Andrew Purtell (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-20027:
---
Status: Patch Available  (was: Open)

> Add test TestClusterPortAssignment
> --
>
> Key: HBASE-20027
> URL: https://issues.apache.org/jira/browse/HBASE-20027
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.1, 1.4.0
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Fix For: 1.4.2
>
> Attachments: HBASE-20027-branch-1.patch, HBASE-20027.patch
>
>
> Port assignments for master ports in site configuration appear to be ignored.
> We are not catching this in tests because there appears to be no positive 
> test for port assignment and the only fixed information we require is the 
> zookeeper quorum and client port. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Issue Comment Deleted] (HBASE-20027) Add test TestClusterPortAssignment

2018-02-20 Thread Andrew Purtell (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-20027:
---
Comment: was deleted

(was: | (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
48s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
36s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
40s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
19s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
50s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
18s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
30s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
35s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
57s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 
24s{color} | {color:red} hbase-server in the patch failed with JDK v1.8.0_162. 
{color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 24s{color} 
| {color:red} hbase-server in the patch failed with JDK v1.8.0_162. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 
29s{color} | {color:red} hbase-server in the patch failed with JDK v1.7.0_171. 
{color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 29s{color} 
| {color:red} hbase-server in the patch failed with JDK v1.7.0_171. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m 
16s{color} | {color:red} hbase-server: The patch generated 1 new + 50 unchanged 
- 0 fixed = 51 total (was 50) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red}  1m 
35s{color} | {color:red} patch has 16 errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  2m 
30s{color} | {color:red} The patch causes 48 errors with Hadoop v2.4.1. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  3m 
24s{color} | {color:red} The patch causes 48 errors with Hadoop v2.5.2. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  4m 
21s{color} | {color:red} The patch causes 16 errors with Hadoop v2.6.5. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  5m 
19s{color} | {color:red} The patch causes 16 errors with Hadoop v2.7.4. {color} 
|
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
29s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
28s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
36s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 29s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch 

[jira] [Comment Edited] (HBASE-20008) [backport] NullPointerException when restoring a snapshot after splitting a region

2018-02-20 Thread Toshihiro Suzuki (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370864#comment-16370864
 ] 

Toshihiro Suzuki edited comment on HBASE-20008 at 2/21/18 2:27 AM:
---

[~yuzhih...@gmail.com] Sorry, forgot to mention. To reproduce the issue, we 
need the following diff:
{code}
diff --git 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
index 0ed75a3..9eb20b0 100644
--- 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
+++ 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
@@ -183,8 +183,9 @@ public class RestoreSnapshotHandler extends 
TableEventHandler implements Snapsho
   String msg = "restore snapshot=" + 
ClientSnapshotDescriptionUtils.toString(snapshot)
   + " failed. Try re-running the restore command.";
   LOG.error(msg, e);
-  monitor.receive(new 
ForeignException(masterServices.getServerName().toString(), e));
-  throw new RestoreSnapshotException(msg, e);
+  IOException rse = new RestoreSnapshotException(msg, e, snapshot);
+  monitor.receive(new 
ForeignException(masterServices.getServerName().toString(), rse));
+  throw new RestoreSnapshotException(msg, rse);
 }
   }
{code}

Previously, it seems like the errors during restoring a snapshot are ignored 
and we should wrap IOException in RestoreSnapshotException as 
RestoreSnapshotException is DoNotRetryIOException.



was (Author: brfrn169):
[~yuzhih...@gmail.com] Sorry, forgot to mention. To reproduce the issue, we 
need the following diff:
{code}
diff --git 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
index 0ed75a3..9eb20b0 100644
--- 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
+++ 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
@@ -183,8 +183,9 @@ public class RestoreSnapshotHandler extends 
TableEventHandler implements Snapsho
   String msg = "restore snapshot=" + 
ClientSnapshotDescriptionUtils.toString(snapshot)
   + " failed. Try re-running the restore command.";
   LOG.error(msg, e);
-  monitor.receive(new 
ForeignException(masterServices.getServerName().toString(), e));
-  throw new RestoreSnapshotException(msg, e);
+  IOException rse = new RestoreSnapshotException(msg, e, snapshot);
+  monitor.receive(new 
ForeignException(masterServices.getServerName().toString(), rse));
+  throw new RestoreSnapshotException(msg, rse);
 }
   }
{code}

Previously, it seems like the errors during restoring a snapshot ignores and we 
should wrap IOException in RestoreSnapshotException as RestoreSnapshotException 
is DoNotRetryIOException.


> [backport] NullPointerException when restoring a snapshot after splitting a 
> region
> --
>
> Key: HBASE-20008
> URL: https://issues.apache.org/jira/browse/HBASE-20008
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Toshihiro Suzuki
>Priority: Major
> Attachments: HBASE-20008.branch-1.001.patch
>
>
> Bring parent fix back to branch-1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20008) [backport] NullPointerException when restoring a snapshot after splitting a region

2018-02-20 Thread Toshihiro Suzuki (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370864#comment-16370864
 ] 

Toshihiro Suzuki commented on HBASE-20008:
--

[~yuzhih...@gmail.com] Sorry, forgot to mention. To reproduce the issue, we 
need the following diff:
{code}
diff --git 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
index 0ed75a3..9eb20b0 100644
--- 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
+++ 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
@@ -183,8 +183,9 @@ public class RestoreSnapshotHandler extends 
TableEventHandler implements Snapsho
   String msg = "restore snapshot=" + 
ClientSnapshotDescriptionUtils.toString(snapshot)
   + " failed. Try re-running the restore command.";
   LOG.error(msg, e);
-  monitor.receive(new 
ForeignException(masterServices.getServerName().toString(), e));
-  throw new RestoreSnapshotException(msg, e);
+  IOException rse = new RestoreSnapshotException(msg, e, snapshot);
+  monitor.receive(new 
ForeignException(masterServices.getServerName().toString(), rse));
+  throw new RestoreSnapshotException(msg, rse);
 }
   }
{code}

Previously, it seems like the errors during restoring a snapshot ignores and we 
should wrap IOException in RestoreSnapshotException as RestoreSnapshotException 
is DoNotRetryIOException.


> [backport] NullPointerException when restoring a snapshot after splitting a 
> region
> --
>
> Key: HBASE-20008
> URL: https://issues.apache.org/jira/browse/HBASE-20008
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Toshihiro Suzuki
>Priority: Major
> Attachments: HBASE-20008.branch-1.001.patch
>
>
> Bring parent fix back to branch-1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20027) Add test TestClusterPortAssignment

2018-02-20 Thread Andrew Purtell (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-20027:
---
Attachment: HBASE-20027-branch-1.patch

> Add test TestClusterPortAssignment
> --
>
> Key: HBASE-20027
> URL: https://issues.apache.org/jira/browse/HBASE-20027
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.0, 1.4.1
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Fix For: 1.4.2
>
> Attachments: HBASE-20027-branch-1.patch, HBASE-20027.patch
>
>
> Port assignments for master ports in site configuration appear to be ignored.
> We are not catching this in tests because there appears to be no positive 
> test for port assignment and the only fixed information we require is the 
> zookeeper quorum and client port. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20027) Add test TestClusterPortAssignment

2018-02-20 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370860#comment-16370860
 ] 

Hadoop QA commented on HBASE-20027:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
48s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
36s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
40s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
19s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
50s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
18s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
30s{color} | {color:green} branch-1 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
35s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
57s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 
24s{color} | {color:red} hbase-server in the patch failed with JDK v1.8.0_162. 
{color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 24s{color} 
| {color:red} hbase-server in the patch failed with JDK v1.8.0_162. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 
29s{color} | {color:red} hbase-server in the patch failed with JDK v1.7.0_171. 
{color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 29s{color} 
| {color:red} hbase-server in the patch failed with JDK v1.7.0_171. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m 
16s{color} | {color:red} hbase-server: The patch generated 1 new + 50 unchanged 
- 0 fixed = 51 total (was 50) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red}  1m 
35s{color} | {color:red} patch has 16 errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  2m 
30s{color} | {color:red} The patch causes 48 errors with Hadoop v2.4.1. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  3m 
24s{color} | {color:red} The patch causes 48 errors with Hadoop v2.5.2. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  4m 
21s{color} | {color:red} The patch causes 16 errors with Hadoop v2.6.5. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  5m 
19s{color} | {color:red} The patch causes 16 errors with Hadoop v2.7.4. {color} 
|
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
29s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
28s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
36s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 29s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch 

[jira] [Updated] (HBASE-20027) Add test TestClusterPortAssignment

2018-02-20 Thread Andrew Purtell (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-20027:
---
Attachment: HBASE-20027.patch

> Add test TestClusterPortAssignment
> --
>
> Key: HBASE-20027
> URL: https://issues.apache.org/jira/browse/HBASE-20027
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.0, 1.4.1
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Fix For: 1.4.2
>
> Attachments: HBASE-20027.patch
>
>
> Port assignments for master ports in site configuration appear to be ignored.
> We are not catching this in tests because there appears to be no positive 
> test for port assignment and the only fixed information we require is the 
> zookeeper quorum and client port. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20032) Receving multiple warnings for missing reporting.plugins.plugin.version

2018-02-20 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370859#comment-16370859
 ] 

Hadoop QA commented on HBASE-20032:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  4m 
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 13m 
33s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
41s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  4m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  4m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
 5s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
19m 29s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  3m 
12s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}180m 
24s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
29s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}229m  7s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-20032 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12911287/HBASE-20032.v01.patch 
|
| Optional Tests |  asflicense  javac  javadoc  unit  shadedjars  hadoopcheck  
xml  compile  |
| uname | Linux c89dff6a42fb 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 6b84393661 |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11587/testReport/ |
| Max. process+thread count | 5116 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11587/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Receving multiple warnings for missing reporting.plugins.plugin.version
> ---
>
> Key: HBASE-20032
> URL: https://issues.apache.org/jira/browse/HBASE-20032
> Project: HBase
>  Issue Type: Bug
>  Components: hbase
>Affects Versions: 2.0.0-beta-1
> Environment: Apache Maven 3.0.5 (Red Hat 3.0.5-17)
> Maven home: /usr/share/maven
> Java version: 1.8.0_161, vendor: Oracle Corporation
> 

[jira] [Commented] (HBASE-20008) [backport] NullPointerException when restoring a snapshot after splitting a region

2018-02-20 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370853#comment-16370853
 ] 

Ted Yu commented on HBASE-20008:


I extracted the testRestoreSnapshotAfterSplittingRegions and ran it without the 
fix which passed.

Can you double check ?

Thanks

> [backport] NullPointerException when restoring a snapshot after splitting a 
> region
> --
>
> Key: HBASE-20008
> URL: https://issues.apache.org/jira/browse/HBASE-20008
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Toshihiro Suzuki
>Priority: Major
> Attachments: HBASE-20008.branch-1.001.patch
>
>
> Bring parent fix back to branch-1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20027) Add test TestClusterPortAssignment

2018-02-20 Thread Andrew Purtell (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-20027:
---
Attachment: (was: HBASE-20027.patch)

> Add test TestClusterPortAssignment
> --
>
> Key: HBASE-20027
> URL: https://issues.apache.org/jira/browse/HBASE-20027
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.0, 1.4.1
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Fix For: 1.4.2
>
>
> Port assignments for master ports in site configuration appear to be ignored.
> We are not catching this in tests because there appears to be no positive 
> test for port assignment and the only fixed information we require is the 
> zookeeper quorum and client port. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20027) Add test TestClusterPortAssignment

2018-02-20 Thread Andrew Purtell (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-20027:
---
Status: Open  (was: Patch Available)

> Add test TestClusterPortAssignment
> --
>
> Key: HBASE-20027
> URL: https://issues.apache.org/jira/browse/HBASE-20027
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.1, 1.4.0
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Fix For: 1.4.2
>
>
> Port assignments for master ports in site configuration appear to be ignored.
> We are not catching this in tests because there appears to be no positive 
> test for port assignment and the only fixed information we require is the 
> zookeeper quorum and client port. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20027) Add test TestClusterPortAssignment

2018-02-20 Thread Andrew Purtell (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-20027:
---
Attachment: (was: HBASE-20027-branch-1.patch)

> Add test TestClusterPortAssignment
> --
>
> Key: HBASE-20027
> URL: https://issues.apache.org/jira/browse/HBASE-20027
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.0, 1.4.1
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Fix For: 1.4.2
>
>
> Port assignments for master ports in site configuration appear to be ignored.
> We are not catching this in tests because there appears to be no positive 
> test for port assignment and the only fixed information we require is the 
> zookeeper quorum and client port. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20027) Add test TestClusterPortAssignment

2018-02-20 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370850#comment-16370850
 ] 

Ted Yu commented on HBASE-20027:


+1

> Add test TestClusterPortAssignment
> --
>
> Key: HBASE-20027
> URL: https://issues.apache.org/jira/browse/HBASE-20027
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.0, 1.4.1
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Fix For: 1.4.2
>
> Attachments: HBASE-20027-branch-1.patch, HBASE-20027.patch
>
>
> Port assignments for master ports in site configuration appear to be ignored.
> We are not catching this in tests because there appears to be no positive 
> test for port assignment and the only fixed information we require is the 
> zookeeper quorum and client port. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20008) [backport] NullPointerException when restoring a snapshot after splitting a region

2018-02-20 Thread Toshihiro Suzuki (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370846#comment-16370846
 ] 

Toshihiro Suzuki commented on HBASE-20008:
--

The issue occurs when reference files to parent region are remaining. So we 
needed to delay the compactions to reproduce the issue.

> [backport] NullPointerException when restoring a snapshot after splitting a 
> region
> --
>
> Key: HBASE-20008
> URL: https://issues.apache.org/jira/browse/HBASE-20008
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Toshihiro Suzuki
>Priority: Major
> Attachments: HBASE-20008.branch-1.001.patch
>
>
> Bring parent fix back to branch-1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20008) [backport] NullPointerException when restoring a snapshot after splitting a region

2018-02-20 Thread Toshihiro Suzuki (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370844#comment-16370844
 ] 

Toshihiro Suzuki commented on HBASE-20008:
--

[~apurtell] Yes, I'm working on reproducing the NullPointerException in 
branch-1.

And finally, I was able to reproduce the issue in branch-1. I attached the 
patch.

> [backport] NullPointerException when restoring a snapshot after splitting a 
> region
> --
>
> Key: HBASE-20008
> URL: https://issues.apache.org/jira/browse/HBASE-20008
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Toshihiro Suzuki
>Priority: Major
> Attachments: HBASE-20008.branch-1.001.patch
>
>
> Bring parent fix back to branch-1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20027) Add test TestClusterPortAssignment

2018-02-20 Thread Andrew Purtell (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-20027:
---
Status: Patch Available  (was: Open)

> Add test TestClusterPortAssignment
> --
>
> Key: HBASE-20027
> URL: https://issues.apache.org/jira/browse/HBASE-20027
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.1, 1.4.0
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Fix For: 1.4.2
>
> Attachments: HBASE-20027-branch-1.patch, HBASE-20027.patch
>
>
> Port assignments for master ports in site configuration appear to be ignored.
> We are not catching this in tests because there appears to be no positive 
> test for port assignment and the only fixed information we require is the 
> zookeeper quorum and client port. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20027) Add test TestClusterPortAssignment

2018-02-20 Thread Andrew Purtell (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-20027:
---
Attachment: HBASE-20027-branch-1.patch
HBASE-20027.patch

> Add test TestClusterPortAssignment
> --
>
> Key: HBASE-20027
> URL: https://issues.apache.org/jira/browse/HBASE-20027
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.0, 1.4.1
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Fix For: 1.4.2
>
> Attachments: HBASE-20027-branch-1.patch, HBASE-20027.patch
>
>
> Port assignments for master ports in site configuration appear to be ignored.
> We are not catching this in tests because there appears to be no positive 
> test for port assignment and the only fixed information we require is the 
> zookeeper quorum and client port. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20008) [backport] NullPointerException when restoring a snapshot after splitting a region

2018-02-20 Thread Toshihiro Suzuki (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Toshihiro Suzuki updated HBASE-20008:
-
Status: Patch Available  (was: Open)

> [backport] NullPointerException when restoring a snapshot after splitting a 
> region
> --
>
> Key: HBASE-20008
> URL: https://issues.apache.org/jira/browse/HBASE-20008
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Toshihiro Suzuki
>Priority: Major
> Attachments: HBASE-20008.branch-1.001.patch
>
>
> Bring parent fix back to branch-1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20027) Add test TestClusterPortAssignment

2018-02-20 Thread Andrew Purtell (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-20027:
---
Summary: Add test TestClusterPortAssignment  (was: Port assignments in site 
configuration are ignored)

> Add test TestClusterPortAssignment
> --
>
> Key: HBASE-20027
> URL: https://issues.apache.org/jira/browse/HBASE-20027
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.0, 1.4.1
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Fix For: 1.4.2
>
>
> Port assignments for master ports in site configuration appear to be ignored.
> We are not catching this in tests because there appears to be no positive 
> test for port assignment and the only fixed information we require is the 
> zookeeper quorum and client port. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20008) [backport] NullPointerException when restoring a snapshot after splitting a region

2018-02-20 Thread Toshihiro Suzuki (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Toshihiro Suzuki updated HBASE-20008:
-
Attachment: HBASE-20008.branch-1.001.patch

> [backport] NullPointerException when restoring a snapshot after splitting a 
> region
> --
>
> Key: HBASE-20008
> URL: https://issues.apache.org/jira/browse/HBASE-20008
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Toshihiro Suzuki
>Priority: Major
> Attachments: HBASE-20008.branch-1.001.patch
>
>
> Bring parent fix back to branch-1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19989) READY_TO_MERGE and READY_TO_SPLIT do not update region state correctly

2018-02-20 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370835#comment-16370835
 ] 

Ted Yu commented on HBASE-19989:


lgtm, pending QA

> READY_TO_MERGE and READY_TO_SPLIT do not update region state correctly
> --
>
> Key: HBASE-19989
> URL: https://issues.apache.org/jira/browse/HBASE-19989
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.3.1, 1.4.1
>Reporter: Ben Lau
>Assignee: Ben Lau
>Priority: Major
> Attachments: HBASE-19989-branch-1.patch
>
>
> Region state transitions do not work correctly for READY_TO_MERGE/SPLIT.  
> [~thiruvel] and I noticed this is due to break statements being in the wrong 
> place in AssignmentManager.  This allows a race condition for example in 
> which one of the regions being merged could be moved concurrently, resulting 
> in the merge transaction failing and then double assignment and/or dataloss.  
> This bug appears to only affect branch-1 (for example 1.3 and 1.4) and not 
> branch-2 as the relevant code in AM has since been rewritten.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19995) Current Jetty 9 version in HBase master branch can memory leak under high traffic

2018-02-20 Thread Ben Lau (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370830#comment-16370830
 ] 

Ben Lau commented on HBASE-19995:
-

[~mdrob] Uploaded the same patch with a proper name to run QA against master 
branch.  Should we kick off a QA test run or are you suggesting that more needs 
to be done to validate this memory leak fix? 

> Current Jetty 9 version in HBase master branch can memory leak under high 
> traffic
> -
>
> Key: HBASE-19995
> URL: https://issues.apache.org/jira/browse/HBASE-19995
> Project: HBase
>  Issue Type: Bug
>  Components: REST
>Affects Versions: 2.0
>Reporter: Ben Lau
>Priority: Major
> Attachments: HBASE-19995-master.patch
>
>
> There is a memory-leak in Jetty 9 that manifests whenever you hit the call 
> queue limit in HBase REST.  The memory-leak leaks both on-heap and off-heap 
> objects permanently.  It happens because whenever the call queue for Jetty 
> server overflows, the task that is rejected runs a 'reject' method if it is a 
> Rejectable to do any cleanup. This clean up is necessary to for example close 
> the connection, deallocate any buffers, etc. Unfortunately, in Jetty 9, they 
> implemented the 'reject' / cleanup method of the SelectChannelEndpoint as a 
> non-blocking call that is not guaranteed to run.  This was later fixed in 
> Jetty 9.4 and later backported however the version of Jetty 9 pulled in HBase 
> for REST comes before this fix.  See 
> [https://github.com/eclipse/jetty.project/issues/1804] and 
> [https://github.com/apache/hbase/blob/master/pom.xml#L1416.]
> If we want to stay on 9.3.X we could update to 
> [9.3.22.v20171030|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.3.22.v20171030]
>  which is the latest version of 9.3.  Thoughts?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19995) Current Jetty 9 version in HBase master branch can memory leak under high traffic

2018-02-20 Thread Ben Lau (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ben Lau updated HBASE-19995:

Attachment: HBASE-19995-master.patch

> Current Jetty 9 version in HBase master branch can memory leak under high 
> traffic
> -
>
> Key: HBASE-19995
> URL: https://issues.apache.org/jira/browse/HBASE-19995
> Project: HBase
>  Issue Type: Bug
>  Components: REST
>Affects Versions: 2.0
>Reporter: Ben Lau
>Priority: Major
> Attachments: HBASE-19995-master.patch
>
>
> There is a memory-leak in Jetty 9 that manifests whenever you hit the call 
> queue limit in HBase REST.  The memory-leak leaks both on-heap and off-heap 
> objects permanently.  It happens because whenever the call queue for Jetty 
> server overflows, the task that is rejected runs a 'reject' method if it is a 
> Rejectable to do any cleanup. This clean up is necessary to for example close 
> the connection, deallocate any buffers, etc. Unfortunately, in Jetty 9, they 
> implemented the 'reject' / cleanup method of the SelectChannelEndpoint as a 
> non-blocking call that is not guaranteed to run.  This was later fixed in 
> Jetty 9.4 and later backported however the version of Jetty 9 pulled in HBase 
> for REST comes before this fix.  See 
> [https://github.com/eclipse/jetty.project/issues/1804] and 
> [https://github.com/apache/hbase/blob/master/pom.xml#L1416.]
> If we want to stay on 9.3.X we could update to 
> [9.3.22.v20171030|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.3.22.v20171030]
>  which is the latest version of 9.3.  Thoughts?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19995) Current Jetty 9 version in HBase master branch can memory leak under high traffic

2018-02-20 Thread Ben Lau (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ben Lau updated HBASE-19995:

Attachment: (was: HBASE-19995.patch)

> Current Jetty 9 version in HBase master branch can memory leak under high 
> traffic
> -
>
> Key: HBASE-19995
> URL: https://issues.apache.org/jira/browse/HBASE-19995
> Project: HBase
>  Issue Type: Bug
>  Components: REST
>Affects Versions: 2.0
>Reporter: Ben Lau
>Priority: Major
> Attachments: HBASE-19995-master.patch
>
>
> There is a memory-leak in Jetty 9 that manifests whenever you hit the call 
> queue limit in HBase REST.  The memory-leak leaks both on-heap and off-heap 
> objects permanently.  It happens because whenever the call queue for Jetty 
> server overflows, the task that is rejected runs a 'reject' method if it is a 
> Rejectable to do any cleanup. This clean up is necessary to for example close 
> the connection, deallocate any buffers, etc. Unfortunately, in Jetty 9, they 
> implemented the 'reject' / cleanup method of the SelectChannelEndpoint as a 
> non-blocking call that is not guaranteed to run.  This was later fixed in 
> Jetty 9.4 and later backported however the version of Jetty 9 pulled in HBase 
> for REST comes before this fix.  See 
> [https://github.com/eclipse/jetty.project/issues/1804] and 
> [https://github.com/apache/hbase/blob/master/pom.xml#L1416.]
> If we want to stay on 9.3.X we could update to 
> [9.3.22.v20171030|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.3.22.v20171030]
>  which is the latest version of 9.3.  Thoughts?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19989) READY_TO_MERGE and READY_TO_SPLIT do not update region state correctly

2018-02-20 Thread Ben Lau (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370828#comment-16370828
 ] 

Ben Lau commented on HBASE-19989:
-

[~yuzhih...@gmail.com] Uploaded with new name, how about now?

> READY_TO_MERGE and READY_TO_SPLIT do not update region state correctly
> --
>
> Key: HBASE-19989
> URL: https://issues.apache.org/jira/browse/HBASE-19989
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.3.1, 1.4.1
>Reporter: Ben Lau
>Assignee: Ben Lau
>Priority: Major
> Attachments: HBASE-19989-branch-1.patch
>
>
> Region state transitions do not work correctly for READY_TO_MERGE/SPLIT.  
> [~thiruvel] and I noticed this is due to break statements being in the wrong 
> place in AssignmentManager.  This allows a race condition for example in 
> which one of the regions being merged could be moved concurrently, resulting 
> in the merge transaction failing and then double assignment and/or dataloss.  
> This bug appears to only affect branch-1 (for example 1.3 and 1.4) and not 
> branch-2 as the relevant code in AM has since been rewritten.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19989) READY_TO_MERGE and READY_TO_SPLIT do not update region state correctly

2018-02-20 Thread Ben Lau (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ben Lau updated HBASE-19989:

Attachment: (was: HBASE-19989.patch)

> READY_TO_MERGE and READY_TO_SPLIT do not update region state correctly
> --
>
> Key: HBASE-19989
> URL: https://issues.apache.org/jira/browse/HBASE-19989
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.3.1, 1.4.1
>Reporter: Ben Lau
>Assignee: Ben Lau
>Priority: Major
> Attachments: HBASE-19989-branch-1.patch
>
>
> Region state transitions do not work correctly for READY_TO_MERGE/SPLIT.  
> [~thiruvel] and I noticed this is due to break statements being in the wrong 
> place in AssignmentManager.  This allows a race condition for example in 
> which one of the regions being merged could be moved concurrently, resulting 
> in the merge transaction failing and then double assignment and/or dataloss.  
> This bug appears to only affect branch-1 (for example 1.3 and 1.4) and not 
> branch-2 as the relevant code in AM has since been rewritten.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19989) READY_TO_MERGE and READY_TO_SPLIT do not update region state correctly

2018-02-20 Thread Ben Lau (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ben Lau updated HBASE-19989:

Attachment: HBASE-19989-branch-1.patch

> READY_TO_MERGE and READY_TO_SPLIT do not update region state correctly
> --
>
> Key: HBASE-19989
> URL: https://issues.apache.org/jira/browse/HBASE-19989
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.3.1, 1.4.1
>Reporter: Ben Lau
>Assignee: Ben Lau
>Priority: Major
> Attachments: HBASE-19989-branch-1.patch
>
>
> Region state transitions do not work correctly for READY_TO_MERGE/SPLIT.  
> [~thiruvel] and I noticed this is due to break statements being in the wrong 
> place in AssignmentManager.  This allows a race condition for example in 
> which one of the regions being merged could be moved concurrently, resulting 
> in the merge transaction failing and then double assignment and/or dataloss.  
> This bug appears to only affect branch-1 (for example 1.3 and 1.4) and not 
> branch-2 as the relevant code in AM has since been rewritten.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20034) Make periodic flusher delay configurable

2018-02-20 Thread Vincent Poon (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vincent Poon updated HBASE-20034:
-
Attachment: HBASE-20034.branch-1.patch

> Make periodic flusher delay configurable
> 
>
> Key: HBASE-20034
> URL: https://issues.apache.org/jira/browse/HBASE-20034
> Project: HBase
>  Issue Type: Improvement
>  Components: regionserver
>Affects Versions: 3.0.0
>Reporter: Vincent Poon
>Assignee: Vincent Poon
>Priority: Major
> Attachments: HBASE-20034.branch-1.patch, HBASE-20034.master.patch
>
>
> PeriodicMemstoreFlusher is currently configured to flush with a random delay 
> of up to 5 minutes.  Make this configurable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20034) Make periodic flusher delay configurable

2018-02-20 Thread Vincent Poon (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vincent Poon updated HBASE-20034:
-
Attachment: HBASE-20034.master.patch

> Make periodic flusher delay configurable
> 
>
> Key: HBASE-20034
> URL: https://issues.apache.org/jira/browse/HBASE-20034
> Project: HBase
>  Issue Type: Improvement
>  Components: regionserver
>Affects Versions: 3.0.0
>Reporter: Vincent Poon
>Assignee: Vincent Poon
>Priority: Major
> Attachments: HBASE-20034.branch-1.patch, HBASE-20034.master.patch
>
>
> PeriodicMemstoreFlusher is currently configured to flush with a random delay 
> of up to 5 minutes.  Make this configurable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20034) Make periodic flusher delay configurable

2018-02-20 Thread Vincent Poon (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vincent Poon updated HBASE-20034:
-
Status: Patch Available  (was: Open)

> Make periodic flusher delay configurable
> 
>
> Key: HBASE-20034
> URL: https://issues.apache.org/jira/browse/HBASE-20034
> Project: HBase
>  Issue Type: Improvement
>  Components: regionserver
>Affects Versions: 3.0.0
>Reporter: Vincent Poon
>Assignee: Vincent Poon
>Priority: Major
> Attachments: HBASE-20034.branch-1.patch, HBASE-20034.master.patch
>
>
> PeriodicMemstoreFlusher is currently configured to flush with a random delay 
> of up to 5 minutes.  Make this configurable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-20034) Make periodic flusher delay configurable

2018-02-20 Thread Vincent Poon (JIRA)
Vincent Poon created HBASE-20034:


 Summary: Make periodic flusher delay configurable
 Key: HBASE-20034
 URL: https://issues.apache.org/jira/browse/HBASE-20034
 Project: HBase
  Issue Type: Improvement
  Components: regionserver
Affects Versions: 3.0.0
Reporter: Vincent Poon
Assignee: Vincent Poon


PeriodicMemstoreFlusher is currently configured to flush with a random delay of 
up to 5 minutes.  Make this configurable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19554) AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit

2018-02-20 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370818#comment-16370818
 ] 

Duo Zhang commented on HBASE-19554:
---

A bit strange, we roll wal with the same name twice...

{noformat}
2018-02-20 16:33:41,128 INFO  [regionserver/asf903:0.logRoller] 
wal.AbstractFSWAL(690): Rolled WAL 
/user/jenkins/test-data/46c46c01-4dc8-4506-a228-a4460f2a28e9/WALs/asf903.gq1.ygridcore.net,52039,1519144411613/asf903.gq1.ygridcore.net%2C52039%2C1519144411613.1519144421057
 with entries=614, filesize=124.20 KB; new WAL 
/user/jenkins/test-data/46c46c01-4dc8-4506-a228-a4460f2a28e9/WALs/asf903.gq1.ygridcore.net,52039,1519144411613/asf903.gq1.ygridcore.net%2C52039%2C1519144411613.1519144421109
2018-02-20 16:33:41,164 INFO  [regionserver/asf903:0.logRoller] 
wal.AbstractFSWAL(690): Rolled WAL 
/user/jenkins/test-data/46c46c01-4dc8-4506-a228-a4460f2a28e9/WALs/asf903.gq1.ygridcore.net,52039,1519144411613/asf903.gq1.ygridcore.net%2C52039%2C1519144411613.1519144421109
 with entries=789, filesize=124.20 KB; new WAL 
/user/jenkins/test-data/46c46c01-4dc8-4506-a228-a4460f2a28e9/WALs/asf903.gq1.ygridcore.net,52039,1519144411613/asf903.gq1.ygridcore.net%2C52039%2C1519144411613.1519144421143
{noformat}

Will dig more.

> AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit
> --
>
> Key: HBASE-19554
> URL: https://issues.apache.org/jira/browse/HBASE-19554
> Project: HBase
>  Issue Type: Sub-task
>  Components: Recovery, wal
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19554-thread-dump.patch, HBASE-19554.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/10554/artifact/patchprocess/patch-unit-hbase-server.txt
> The error message is a bit strange:
> {quote}
> [ERROR] testThreeRSAbort(org.apache.hadoop.hbase.master.TestDLSAsyncFSWAL) 
> Time elapsed: 20.627 s <<< ERROR!
> org.apache.hadoop.hbase.TableNotFoundException: Region of 
> 'hbase:namespace,,1513320505933.451650152885a3b41d0b1110deca513c.' is 
> expected in the table of 'testThreeRSAbort', but hbase:meta says it is in the 
> table of 'hbase:namespace'. hbase:meta might be damaged.
> {quote}
> It fails for both FSHLog and AsyncFSWAL. Need to dig more.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (HBASE-19554) AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit

2018-02-20 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370774#comment-16370774
 ] 

Duo Zhang edited comment on HBASE-19554 at 2/21/18 1:15 AM:


https://builds.apache.org/job/HBASE-Flaky-Tests-branch2.0/2393/testReport/junit/org.apache.hadoop.hbase.master/TestDLSFSHLog/testRecoveredEdits/

{noformat}
java.lang.AssertionError: expected:<1> but was:<9825>
{noformat}


was (Author: apache9):
https://builds.apache.org/job/HBASE-Flaky-Tests-branch2.0/2393/testReport/junit/org.apache.hadoop.hbase.master/TestDLSFSHLog/testRecoveredEdits/

{quote}
java.lang.AssertionError: expected:<1> but was:<9825>
{quote}

> AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit
> --
>
> Key: HBASE-19554
> URL: https://issues.apache.org/jira/browse/HBASE-19554
> Project: HBase
>  Issue Type: Sub-task
>  Components: Recovery, wal
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19554-thread-dump.patch, HBASE-19554.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/10554/artifact/patchprocess/patch-unit-hbase-server.txt
> The error message is a bit strange:
> {quote}
> [ERROR] testThreeRSAbort(org.apache.hadoop.hbase.master.TestDLSAsyncFSWAL) 
> Time elapsed: 20.627 s <<< ERROR!
> org.apache.hadoop.hbase.TableNotFoundException: Region of 
> 'hbase:namespace,,1513320505933.451650152885a3b41d0b1110deca513c.' is 
> expected in the table of 'testThreeRSAbort', but hbase:meta says it is in the 
> table of 'hbase:namespace'. hbase:meta might be damaged.
> {quote}
> It fails for both FSHLog and AsyncFSWAL. Need to dig more.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20033) Backport HBASE-19920 TokenUtil.obtainToken unnecessarily creates a local directory to branch-1

2018-02-20 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370813#comment-16370813
 ] 

Andrew Purtell commented on HBASE-20033:


+1

> Backport HBASE-19920 TokenUtil.obtainToken unnecessarily creates a local 
> directory to branch-1
> --
>
> Key: HBASE-20033
> URL: https://issues.apache.org/jira/browse/HBASE-20033
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 1.4.2
>Reporter: stack
>Assignee: Mike Drob
>Priority: Major
>
> Backport parent to branch-1. [~apurtell] ?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (HBASE-19920) TokenUtil.obtainToken unnecessarily creates a local directory

2018-02-20 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack resolved HBASE-19920.
---
Resolution: Fixed

Re-resolving. I made a subtask for the backport. Hope that is ok [~mdrob] 
Trying to make the hbase-2 beta-2 JIRA count look better.

> TokenUtil.obtainToken unnecessarily creates a local directory
> -
>
> Key: HBASE-19920
> URL: https://issues.apache.org/jira/browse/HBASE-19920
> Project: HBase
>  Issue Type: Bug
>Reporter: Rohini Palaniswamy
>Assignee: Mike Drob
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19920.patch, HBASE-19920.v2.patch, 
> HBASE-19920.v3.patch, HBASE-19920.v4.patch, HBASE-19920.v5.patch, 
> HBASE-19920.v6.patch, HBASE-19920.v7.patch, HBASE-19920.v8.patch, 
> HBASE-19920.v9.patch
>
>
> On client code, when one calls TokenUtil.obtainToken it loads ProtobufUtil 
> which in its static block initializes DynamicClassLoader and that creates the 
> directory ${hbase.local.dir}/jars/ and also instantiates a filesystem class 
> to access hbase.dynamic.jars.dir.
> https://github.com/apache/hbase/blob/master/hbase-common/src/main/java/org/apache/hadoop/hbase/util/DynamicClassLoader.java#L109-L127
> Since this is region server specific code, not expecting this to happen when 
> one accesses hbase as a client.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-20033) Backport HBASE-19920 TokenUtil.obtainToken unnecessarily creates a local directory to branch-1

2018-02-20 Thread stack (JIRA)
stack created HBASE-20033:
-

 Summary: Backport HBASE-19920 TokenUtil.obtainToken unnecessarily 
creates a local directory to branch-1
 Key: HBASE-20033
 URL: https://issues.apache.org/jira/browse/HBASE-20033
 Project: HBase
  Issue Type: Sub-task
Affects Versions: 1.4.2
Reporter: stack
Assignee: Mike Drob


Backport parent to branch-1. [~apurtell] ?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20017) BufferedMutatorImpl submit the same mutation repeatedly

2018-02-20 Thread Andrew Purtell (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-20017:
---
  Resolution: Fixed
Hadoop Flags: Reviewed
Release Note: This change fixes multithreading issues in the implementation 
of BufferedMutator. BufferedMutator should not be used with 1.4 releases prior 
to 1.4.2.
  Status: Resolved  (was: Patch Available)

> BufferedMutatorImpl submit the same mutation repeatedly
> ---
>
> Key: HBASE-20017
> URL: https://issues.apache.org/jira/browse/HBASE-20017
> Project: HBase
>  Issue Type: Bug
>  Components: Client
>Affects Versions: 1.4.0, 1.4.1, 1.4.2
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Blocker
> Fix For: 2.0.0, 1.5.0, 1.4.2
>
> Attachments: HBASE-20017.branch-1.4.v0.patch.patch, 
> HBASE-20017.branch-1.v0.patch.patch, HBASE-20017.v0.patch.patch
>
>
> BMI pass a iter of inner buffer to AsyncProcess to take the undealt 
> mutations, AsyncProcess call iter#next to get the mutation and then call 
> iter#remove to delete the mutation from inner buffer. Hence, There's a good 
> chance that  the mutation is processed repeatedly in case there are a bunch 
> of threads which are running the flush.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (HBASE-20008) [backport] NullPointerException when restoring a snapshot after splitting a region

2018-02-20 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370800#comment-16370800
 ] 

Andrew Purtell edited comment on HBASE-20008 at 2/21/18 12:51 AM:
--

I found a branch-1 patch on parent issue: 
https://issues.apache.org/jira/secure/attachment/12910709/HBASE-19980.branch-1.001.patch

Just included here for reference because parent suggests more work is needed


was (Author: apurtell):
I found a branch-1 patch on parent issue: [^HBASE-19980.branch-1.001.patch]

Just included here for reference because parent suggests more work is needed

> [backport] NullPointerException when restoring a snapshot after splitting a 
> region
> --
>
> Key: HBASE-20008
> URL: https://issues.apache.org/jira/browse/HBASE-20008
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Toshihiro Suzuki
>Priority: Major
>
> Bring parent fix back to branch-1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (HBASE-20008) [backport] NullPointerException when restoring a snapshot after splitting a region

2018-02-20 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370800#comment-16370800
 ] 

Andrew Purtell edited comment on HBASE-20008 at 2/21/18 12:50 AM:
--

I found a branch-1 patch on parent issue: [^HBASE-19980.branch-1.001.patch]

Just included here for reference because parent suggests more work is needed


was (Author: apurtell):
I found a branch-1 patch on parent issue: 
https://issues.apache.org/jira/secure/attachment/12910709/HBASE-19980.branch-1.001.patch

> [backport] NullPointerException when restoring a snapshot after splitting a 
> region
> --
>
> Key: HBASE-20008
> URL: https://issues.apache.org/jira/browse/HBASE-20008
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Toshihiro Suzuki
>Priority: Major
>
> Bring parent fix back to branch-1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20008) [backport] NullPointerException when restoring a snapshot after splitting a region

2018-02-20 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370800#comment-16370800
 ] 

Andrew Purtell commented on HBASE-20008:


I found a branch-1 patch on parent issue: 
https://issues.apache.org/jira/secure/attachment/12910709/HBASE-19980.branch-1.001.patch

> [backport] NullPointerException when restoring a snapshot after splitting a 
> region
> --
>
> Key: HBASE-20008
> URL: https://issues.apache.org/jira/browse/HBASE-20008
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: Toshihiro Suzuki
>Priority: Major
>
> Bring parent fix back to branch-1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20017) BufferedMutatorImpl submit the same mutation repeatedly

2018-02-20 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370798#comment-16370798
 ] 

Andrew Purtell commented on HBASE-20017:


Working on the commit now

> BufferedMutatorImpl submit the same mutation repeatedly
> ---
>
> Key: HBASE-20017
> URL: https://issues.apache.org/jira/browse/HBASE-20017
> Project: HBase
>  Issue Type: Bug
>  Components: Client
>Affects Versions: 1.4.0, 1.4.1, 1.4.2
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Blocker
> Fix For: 2.0.0, 1.5.0, 1.4.2
>
> Attachments: HBASE-20017.branch-1.4.v0.patch.patch, 
> HBASE-20017.branch-1.v0.patch.patch, HBASE-20017.v0.patch.patch
>
>
> BMI pass a iter of inner buffer to AsyncProcess to take the undealt 
> mutations, AsyncProcess call iter#next to get the mutation and then call 
> iter#remove to delete the mutation from inner buffer. Hence, There's a good 
> chance that  the mutation is processed repeatedly in case there are a bunch 
> of threads which are running the flush.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-18864) NullPointerException thrown when adding rows to a table from peer cluster, table with replication factor other than 0 or 1

2018-02-20 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370795#comment-16370795
 ] 

Andrew Purtell commented on HBASE-18864:


Go ahead! Thanks

> NullPointerException thrown when adding rows to a table from peer cluster, 
> table with replication factor other than 0 or 1
> --
>
> Key: HBASE-18864
> URL: https://issues.apache.org/jira/browse/HBASE-18864
> Project: HBase
>  Issue Type: Bug
>  Components: hbase
>Affects Versions: 1.3.0
>Reporter: smita
>Assignee: Azhaku Sakthi Vel Muthu Krishnan
>Priority: Major
>  Labels: beginner
>
> Scenario:
> =
> add_peer
> create a table
> alter table with REPLICATION_SCOPE => '5'
> enable table replication
> login to peer cluster and try putting data to the table 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19713) Enable TestInterfaceAudienceAnnotations

2018-02-20 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370792#comment-16370792
 ] 

Chia-Ping Tsai commented on HBASE-19713:


{quote}Land this for branch-2 Chia-Ping Tsai ?
{quote}
yep. Making classes have audience annotations is friendly to user. 

> Enable TestInterfaceAudienceAnnotations
> ---
>
> Key: HBASE-19713
> URL: https://issues.apache.org/jira/browse/HBASE-19713
> Project: HBase
>  Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-19713.branch-2.v0.patch, 
> HBASE-19713.branch-2.v1.patch, HBASE-19713.branch-2.v2.patch, 
> HBASE-19713.v0.patch
>
>
> Make sure TestInterfaceAudienceAnnotations pass before 2.0 release.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19713) Enable TestInterfaceAudienceAnnotations

2018-02-20 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370781#comment-16370781
 ] 

stack commented on HBASE-19713:
---

Land this for branch-2 [~chia7712] ? Let me break it off the parent class so it 
is standalone.

> Enable TestInterfaceAudienceAnnotations
> ---
>
> Key: HBASE-19713
> URL: https://issues.apache.org/jira/browse/HBASE-19713
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-19713.branch-2.v0.patch, 
> HBASE-19713.branch-2.v1.patch, HBASE-19713.branch-2.v2.patch, 
> HBASE-19713.v0.patch
>
>
> Make sure TestInterfaceAudienceAnnotations pass before 2.0 release.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19713) Enable TestInterfaceAudienceAnnotations

2018-02-20 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-19713:
--
Issue Type: Bug  (was: Sub-task)
Parent: (was: HBASE-19147)

> Enable TestInterfaceAudienceAnnotations
> ---
>
> Key: HBASE-19713
> URL: https://issues.apache.org/jira/browse/HBASE-19713
> Project: HBase
>  Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-19713.branch-2.v0.patch, 
> HBASE-19713.branch-2.v1.patch, HBASE-19713.branch-2.v2.patch, 
> HBASE-19713.v0.patch
>
>
> Make sure TestInterfaceAudienceAnnotations pass before 2.0 release.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20021) TestFromClientSideWithCoprocessor is flakey

2018-02-20 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-20021:
--
  Resolution: Fixed
Hadoop Flags: Reviewed
  Status: Resolved  (was: Patch Available)

Resolving. Not on flakey list.

> TestFromClientSideWithCoprocessor is flakey
> ---
>
> Key: HBASE-20021
> URL: https://issues.apache.org/jira/browse/HBASE-20021
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20021.patch
>
>
> The same reason with HBASE-19731.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20007) rest server doesn't start against hadoop-3

2018-02-20 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370776#comment-16370776
 ] 

stack commented on HBASE-20007:
---

Failed


[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   
TestReplicationKillMasterRSCompressedWithMultipleWAL>TestReplicationKillMasterRS.killOneMasterRS:43->TestReplicationKillRS.loadTableAndKillRS:72
 » RetriesExhausted
[INFO] 
[ERROR] Tests run: 3561, Failures: 0, Errors: 1, Skipped: 43
[INFO] 



Seems unrelated. Let me retry.

> rest server doesn't start against hadoop-3
> --
>
> Key: HBASE-20007
> URL: https://issues.apache.org/jira/browse/HBASE-20007
> Project: HBase
>  Issue Type: Bug
>  Components: REST
>Affects Versions: 2.0.0-alpha-3
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20007.patch, HBASE-20007.patch
>
>
> While fixing HBASE-19991 I discovered that this command fails:
> {noformat}
> mvn clean package -Dhadoop.profile=3.0 -DskipTests && bin/hbase-daemon.sh 
> start rest
> {noformat}
> The command itself actually succeeds, but the rest server fails to start with
> {noformat}
> Exception in thread "main" java.lang.NoClassDefFoundError: 
> com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate
>   at java.lang.ClassLoader.defineClass1(Native Method)
>   at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
>   at 
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
>   at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
>   at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
>   at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
>   at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
>   at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
>   at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335)
>   at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>   at java.lang.Class.forName0(Native Method)
>   at java.lang.Class.forName(Class.java:348)
>   at javax.ws.rs.ext.FactoryFinder.newInstance(FactoryFinder.java:107)
>   at javax.ws.rs.ext.FactoryFinder.find(FactoryFinder.java:166)
>   at 
> javax.ws.rs.ext.RuntimeDelegate.findDelegate(RuntimeDelegate.java:135)
>   at javax.ws.rs.ext.RuntimeDelegate.getInstance(RuntimeDelegate.java:120)
>   at javax.ws.rs.core.MediaType.valueOf(MediaType.java:179)
>   at 
> org.glassfish.jersey.server.model.IntrospectionModeller.extractMediaTypes(IntrospectionModeller.java:297)
>   at 
> org.glassfish.jersey.server.model.IntrospectionModeller.extractMediaTypes(IntrospectionModeller.java:282)
>   at 
> org.glassfish.jersey.server.model.IntrospectionModeller.doCreateResourceBuilder(IntrospectionModeller.java:129)
>   at 
> org.glassfish.jersey.server.model.IntrospectionModeller.access$000(IntrospectionModeller.java:80)
>   at 
> org.glassfish.jersey.server.model.IntrospectionModeller$1.call(IntrospectionModeller.java:112)
>   at 
> org.glassfish.jersey.server.model.IntrospectionModeller$1.call(IntrospectionModeller.java:109)
>   at org.glassfish.jersey.internal.Errors.process(Errors.java:315)
>   at org.glassfish.jersey.internal.Errors.process(Errors.java:297)
>   at 
> org.glassfish.jersey.internal.Errors.processWithException(Errors.java:255)
>   at 
> org.glassfish.jersey.server.model.IntrospectionModeller.createResourceBuilder(IntrospectionModeller.java:109)
>   at org.glassfish.jersey.server.model.Resource.from(Resource.java:797)
>   at 
> org.glassfish.jersey.server.ApplicationHandler.initialize(ApplicationHandler.java:465)
>   at 
> org.glassfish.jersey.server.ApplicationHandler.access$500(ApplicationHandler.java:184)
>   at 
> org.glassfish.jersey.server.ApplicationHandler$3.call(ApplicationHandler.java:350)
>   at 
> org.glassfish.jersey.server.ApplicationHandler$3.call(ApplicationHandler.java:347)
>   at org.glassfish.jersey.internal.Errors.process(Errors.java:315)
>   at org.glassfish.jersey.internal.Errors.process(Errors.java:297)
>   at 
> org.glassfish.jersey.internal.Errors.processWithException(Errors.java:255)
>   at 
> org.glassfish.jersey.server.ApplicationHandler.(ApplicationHandler.java:347)
>   at 
> org.glassfish.jersey.servlet.WebComponent.(WebComponent.java:392)
>   at 
> org.glassfish.jersey.servlet.ServletContainer.init(ServletContainer.java:177)
>   at 
> org.glassfish.jersey.servlet.ServletContainer.init(ServletContainer.java:369)
>   at javax.servlet.GenericServlet.init(GenericServlet.java:244)
>   at 
> 

[jira] [Updated] (HBASE-20007) rest server doesn't start against hadoop-3

2018-02-20 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-20007:
--
Attachment: HBASE-20007.patch

> rest server doesn't start against hadoop-3
> --
>
> Key: HBASE-20007
> URL: https://issues.apache.org/jira/browse/HBASE-20007
> Project: HBase
>  Issue Type: Bug
>  Components: REST
>Affects Versions: 2.0.0-alpha-3
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20007.patch, HBASE-20007.patch
>
>
> While fixing HBASE-19991 I discovered that this command fails:
> {noformat}
> mvn clean package -Dhadoop.profile=3.0 -DskipTests && bin/hbase-daemon.sh 
> start rest
> {noformat}
> The command itself actually succeeds, but the rest server fails to start with
> {noformat}
> Exception in thread "main" java.lang.NoClassDefFoundError: 
> com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate
>   at java.lang.ClassLoader.defineClass1(Native Method)
>   at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
>   at 
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
>   at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
>   at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
>   at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
>   at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
>   at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
>   at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335)
>   at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>   at java.lang.Class.forName0(Native Method)
>   at java.lang.Class.forName(Class.java:348)
>   at javax.ws.rs.ext.FactoryFinder.newInstance(FactoryFinder.java:107)
>   at javax.ws.rs.ext.FactoryFinder.find(FactoryFinder.java:166)
>   at 
> javax.ws.rs.ext.RuntimeDelegate.findDelegate(RuntimeDelegate.java:135)
>   at javax.ws.rs.ext.RuntimeDelegate.getInstance(RuntimeDelegate.java:120)
>   at javax.ws.rs.core.MediaType.valueOf(MediaType.java:179)
>   at 
> org.glassfish.jersey.server.model.IntrospectionModeller.extractMediaTypes(IntrospectionModeller.java:297)
>   at 
> org.glassfish.jersey.server.model.IntrospectionModeller.extractMediaTypes(IntrospectionModeller.java:282)
>   at 
> org.glassfish.jersey.server.model.IntrospectionModeller.doCreateResourceBuilder(IntrospectionModeller.java:129)
>   at 
> org.glassfish.jersey.server.model.IntrospectionModeller.access$000(IntrospectionModeller.java:80)
>   at 
> org.glassfish.jersey.server.model.IntrospectionModeller$1.call(IntrospectionModeller.java:112)
>   at 
> org.glassfish.jersey.server.model.IntrospectionModeller$1.call(IntrospectionModeller.java:109)
>   at org.glassfish.jersey.internal.Errors.process(Errors.java:315)
>   at org.glassfish.jersey.internal.Errors.process(Errors.java:297)
>   at 
> org.glassfish.jersey.internal.Errors.processWithException(Errors.java:255)
>   at 
> org.glassfish.jersey.server.model.IntrospectionModeller.createResourceBuilder(IntrospectionModeller.java:109)
>   at org.glassfish.jersey.server.model.Resource.from(Resource.java:797)
>   at 
> org.glassfish.jersey.server.ApplicationHandler.initialize(ApplicationHandler.java:465)
>   at 
> org.glassfish.jersey.server.ApplicationHandler.access$500(ApplicationHandler.java:184)
>   at 
> org.glassfish.jersey.server.ApplicationHandler$3.call(ApplicationHandler.java:350)
>   at 
> org.glassfish.jersey.server.ApplicationHandler$3.call(ApplicationHandler.java:347)
>   at org.glassfish.jersey.internal.Errors.process(Errors.java:315)
>   at org.glassfish.jersey.internal.Errors.process(Errors.java:297)
>   at 
> org.glassfish.jersey.internal.Errors.processWithException(Errors.java:255)
>   at 
> org.glassfish.jersey.server.ApplicationHandler.(ApplicationHandler.java:347)
>   at 
> org.glassfish.jersey.servlet.WebComponent.(WebComponent.java:392)
>   at 
> org.glassfish.jersey.servlet.ServletContainer.init(ServletContainer.java:177)
>   at 
> org.glassfish.jersey.servlet.ServletContainer.init(ServletContainer.java:369)
>   at javax.servlet.GenericServlet.init(GenericServlet.java:244)
>   at 
> org.eclipse.jetty.servlet.ServletHolder.initServlet(ServletHolder.java:643)
>   at 
> org.eclipse.jetty.servlet.ServletHolder.initialize(ServletHolder.java:422)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:892)
>   at 
> 

[jira] [Commented] (HBASE-19554) AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit

2018-02-20 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370774#comment-16370774
 ] 

Duo Zhang commented on HBASE-19554:
---

https://builds.apache.org/job/HBASE-Flaky-Tests-branch2.0/2393/testReport/junit/org.apache.hadoop.hbase.master/TestDLSFSHLog/testRecoveredEdits/

{quote}
java.lang.AssertionError: expected:<1> but was:<9825>
{quote}

> AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit
> --
>
> Key: HBASE-19554
> URL: https://issues.apache.org/jira/browse/HBASE-19554
> Project: HBase
>  Issue Type: Sub-task
>  Components: Recovery, wal
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19554-thread-dump.patch, HBASE-19554.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/10554/artifact/patchprocess/patch-unit-hbase-server.txt
> The error message is a bit strange:
> {quote}
> [ERROR] testThreeRSAbort(org.apache.hadoop.hbase.master.TestDLSAsyncFSWAL) 
> Time elapsed: 20.627 s <<< ERROR!
> org.apache.hadoop.hbase.TableNotFoundException: Region of 
> 'hbase:namespace,,1513320505933.451650152885a3b41d0b1110deca513c.' is 
> expected in the table of 'testThreeRSAbort', but hbase:meta says it is in the 
> table of 'hbase:namespace'. hbase:meta might be damaged.
> {quote}
> It fails for both FSHLog and AsyncFSWAL. Need to dig more.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20025) TestZKPermissionWatcher is flakey in branch-1

2018-02-20 Thread Chia-Ping Tsai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chia-Ping Tsai updated HBASE-20025:
---
Resolution: Not A Problem
Status: Resolved  (was: Patch Available)

HBASE-19970 is reverted from branch-1 and branch-1.4. The fix can be merged to 
HBASE-19970. Closing it.

> TestZKPermissionWatcher is flakey in branch-1
> -
>
> Key: HBASE-20025
> URL: https://issues.apache.org/jira/browse/HBASE-20025
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: Chia-Ping Tsai
>Priority: Major
> Fix For: 1.5.0, 1.4.3
>
> Attachments: HBASE-20025.branch-1.v0.patch
>
>
> HBASE-20013 addressed flakeyness in branch-2. This issue is about backport 
> for branch-1. The patch on HBASE-20013 and perhaps some portion of 
> HBASE-20020 would help?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19970) Remove unused functions from TableAuthManager

2018-02-20 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370739#comment-16370739
 ] 

Chia-Ping Tsai commented on HBASE-19970:


{quote}I'll revert it...
{quote}
HBASE-20025 tried to fix the bug introduced by this issue. I think the fix can 
be merged to next commit so I'll close HBASE-20025.

> Remove unused functions from TableAuthManager
> -
>
> Key: HBASE-19970
> URL: https://issues.apache.org/jira/browse/HBASE-19970
> Project: HBase
>  Issue Type: Task
>Reporter: Appy
>Assignee: Appy
>Priority: Minor
> Fix For: 2.0.0, 1.5.0, 1.4.2
>
> Attachments: HBASE-19970.master.001.patch
>
>
> Functions deleted in TableAuthManager:
> - setTableUserPermissions
> - setTableGroupPermissions
> - setNamespaceUserPermissions
> - setNamespaceGroupPermissions
> - writeTableToZooKeeper
> - writeNamespaceToZooKeeper
> To make sure it was not a bug, and that relevant functionality moved to some 
> alternate code path, tried to find out why and when these functions went out 
> of use. But just couldn't figure out...until i reached the patch which added 
> them. Looks like they were dead functions to start with :)
> Jira which added them: HBASE-8409. Commit id: 
> ac10b3c13d6b66e12d0c9601204b01dfa525ed19



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20032) Receving multiple warnings for missing reporting.plugins.plugin.version

2018-02-20 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-20032:
--
  Resolution: Fixed
Hadoop Flags: Reviewed
Release Note: Add (latest) version elements missing from reporting plugins 
in top-level pom.
  Status: Resolved  (was: Patch Available)

Pushed to branch-2 and master. Thanks [~dbist13]

> Receving multiple warnings for missing reporting.plugins.plugin.version
> ---
>
> Key: HBASE-20032
> URL: https://issues.apache.org/jira/browse/HBASE-20032
> Project: HBase
>  Issue Type: Bug
>  Components: hbase
>Affects Versions: 2.0.0-beta-1
> Environment: Apache Maven 3.0.5 (Red Hat 3.0.5-17)
> Maven home: /usr/share/maven
> Java version: 1.8.0_161, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.161-0.b14.el7_4.x86_64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.10.0-693.11.6.el7.x86_64", arch: "amd64", 
> family: "unix"
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20032.v01.patch
>
>
> getting multiple warnings for the following
> {noformat}
> [WARNING] 'reporting.plugins.plugin.version' for 
> org.apache.maven.plugins:maven-project-info-reports-plugin is missing. @ 
> org.apache.hbase:hbase:3.0.0-SNAPSHOT, /home/vagrant/hbase/pom.xml, line 
> 3492, column 15
> [WARNING] 'reporting.plugins.plugin.version' for 
> org.apache.maven.plugins:maven-javadoc-plugin is missing. @ 
> org.apache.hbase:hbase:3.0.0-SNAPSHOT, /home/vagrant/hbase/pom.xml, line 
> 3520, column 15
> [WARNING] 'reporting.plugins.plugin.version' for 
> org.apache.maven.plugins:maven-checkstyle-plugin is missing. @ 
> org.apache.hbase:hbase:3.0.0-SNAPSHOT, /home/vagrant/hbase/pom.xml, line 
> 3721, column 15
> [WARNING] 'reporting.plugins.plugin.version' for 
> org.scala-tools:maven-scala-plugin is missing. @ 
> org.apache.hbase:hbase:3.0.0-SNAPSHOT, /home/vagrant/hbase/pom.xml, line 
> 3729, column 15
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (HBASE-20032) Receving multiple warnings for missing reporting.plugins.plugin.version

2018-02-20 Thread Artem Ervits (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370719#comment-16370719
 ] 

Artem Ervits edited comment on HBASE-20032 at 2/20/18 11:08 PM:


[~stack] I used the latest according to maven central, yes. By the way, all 
small tests pass locally.


was (Author: dbist13):
[~stack] I used the latest according to maven central, yes.

> Receving multiple warnings for missing reporting.plugins.plugin.version
> ---
>
> Key: HBASE-20032
> URL: https://issues.apache.org/jira/browse/HBASE-20032
> Project: HBase
>  Issue Type: Bug
>  Components: hbase
>Affects Versions: 2.0.0-beta-1
> Environment: Apache Maven 3.0.5 (Red Hat 3.0.5-17)
> Maven home: /usr/share/maven
> Java version: 1.8.0_161, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.161-0.b14.el7_4.x86_64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.10.0-693.11.6.el7.x86_64", arch: "amd64", 
> family: "unix"
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20032.v01.patch
>
>
> getting multiple warnings for the following
> {noformat}
> [WARNING] 'reporting.plugins.plugin.version' for 
> org.apache.maven.plugins:maven-project-info-reports-plugin is missing. @ 
> org.apache.hbase:hbase:3.0.0-SNAPSHOT, /home/vagrant/hbase/pom.xml, line 
> 3492, column 15
> [WARNING] 'reporting.plugins.plugin.version' for 
> org.apache.maven.plugins:maven-javadoc-plugin is missing. @ 
> org.apache.hbase:hbase:3.0.0-SNAPSHOT, /home/vagrant/hbase/pom.xml, line 
> 3520, column 15
> [WARNING] 'reporting.plugins.plugin.version' for 
> org.apache.maven.plugins:maven-checkstyle-plugin is missing. @ 
> org.apache.hbase:hbase:3.0.0-SNAPSHOT, /home/vagrant/hbase/pom.xml, line 
> 3721, column 15
> [WARNING] 'reporting.plugins.plugin.version' for 
> org.scala-tools:maven-scala-plugin is missing. @ 
> org.apache.hbase:hbase:3.0.0-SNAPSHOT, /home/vagrant/hbase/pom.xml, line 
> 3729, column 15
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20032) Receving multiple warnings for missing reporting.plugins.plugin.version

2018-02-20 Thread Artem Ervits (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370719#comment-16370719
 ] 

Artem Ervits commented on HBASE-20032:
--

[~stack] I used the latest according to maven central, yes.

> Receving multiple warnings for missing reporting.plugins.plugin.version
> ---
>
> Key: HBASE-20032
> URL: https://issues.apache.org/jira/browse/HBASE-20032
> Project: HBase
>  Issue Type: Bug
>  Components: hbase
>Affects Versions: 2.0.0-beta-1
> Environment: Apache Maven 3.0.5 (Red Hat 3.0.5-17)
> Maven home: /usr/share/maven
> Java version: 1.8.0_161, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.161-0.b14.el7_4.x86_64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.10.0-693.11.6.el7.x86_64", arch: "amd64", 
> family: "unix"
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20032.v01.patch
>
>
> getting multiple warnings for the following
> {noformat}
> [WARNING] 'reporting.plugins.plugin.version' for 
> org.apache.maven.plugins:maven-project-info-reports-plugin is missing. @ 
> org.apache.hbase:hbase:3.0.0-SNAPSHOT, /home/vagrant/hbase/pom.xml, line 
> 3492, column 15
> [WARNING] 'reporting.plugins.plugin.version' for 
> org.apache.maven.plugins:maven-javadoc-plugin is missing. @ 
> org.apache.hbase:hbase:3.0.0-SNAPSHOT, /home/vagrant/hbase/pom.xml, line 
> 3520, column 15
> [WARNING] 'reporting.plugins.plugin.version' for 
> org.apache.maven.plugins:maven-checkstyle-plugin is missing. @ 
> org.apache.hbase:hbase:3.0.0-SNAPSHOT, /home/vagrant/hbase/pom.xml, line 
> 3721, column 15
> [WARNING] 'reporting.plugins.plugin.version' for 
> org.scala-tools:maven-scala-plugin is missing. @ 
> org.apache.hbase:hbase:3.0.0-SNAPSHOT, /home/vagrant/hbase/pom.xml, line 
> 3729, column 15
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20032) Receving multiple warnings for missing reporting.plugins.plugin.version

2018-02-20 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370711#comment-16370711
 ] 

stack commented on HBASE-20032:
---

[~dbist13] These are the latest versions of the plugins sir?

> Receving multiple warnings for missing reporting.plugins.plugin.version
> ---
>
> Key: HBASE-20032
> URL: https://issues.apache.org/jira/browse/HBASE-20032
> Project: HBase
>  Issue Type: Bug
>  Components: hbase
>Affects Versions: 2.0.0-beta-1
> Environment: Apache Maven 3.0.5 (Red Hat 3.0.5-17)
> Maven home: /usr/share/maven
> Java version: 1.8.0_161, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.161-0.b14.el7_4.x86_64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.10.0-693.11.6.el7.x86_64", arch: "amd64", 
> family: "unix"
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20032.v01.patch
>
>
> getting multiple warnings for the following
> {noformat}
> [WARNING] 'reporting.plugins.plugin.version' for 
> org.apache.maven.plugins:maven-project-info-reports-plugin is missing. @ 
> org.apache.hbase:hbase:3.0.0-SNAPSHOT, /home/vagrant/hbase/pom.xml, line 
> 3492, column 15
> [WARNING] 'reporting.plugins.plugin.version' for 
> org.apache.maven.plugins:maven-javadoc-plugin is missing. @ 
> org.apache.hbase:hbase:3.0.0-SNAPSHOT, /home/vagrant/hbase/pom.xml, line 
> 3520, column 15
> [WARNING] 'reporting.plugins.plugin.version' for 
> org.apache.maven.plugins:maven-checkstyle-plugin is missing. @ 
> org.apache.hbase:hbase:3.0.0-SNAPSHOT, /home/vagrant/hbase/pom.xml, line 
> 3721, column 15
> [WARNING] 'reporting.plugins.plugin.version' for 
> org.scala-tools:maven-scala-plugin is missing. @ 
> org.apache.hbase:hbase:3.0.0-SNAPSHOT, /home/vagrant/hbase/pom.xml, line 
> 3729, column 15
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19954) Separate TestBlockReorder into individual tests to avoid ShutdownHook suppression error against hadoop3

2018-02-20 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-19954:
--
  Resolution: Fixed
Hadoop Flags: Reviewed
Release Note: hadoop3 minidfscluster removes all shutdown handlers when the 
cluster goes down which made this test that does FS-stuff fail (Fix was to 
break up the test so each test method ran with an unadulterated FS).
  Status: Resolved  (was: Patch Available)

+1

Pushed to branch-2 and master after fixing whitespace and checkstyle.

> Separate TestBlockReorder into individual tests to avoid ShutdownHook 
> suppression error against hadoop3 
> 
>
> Key: HBASE-19954
> URL: https://issues.apache.org/jira/browse/HBASE-19954
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: 19954.v1.txt, 19954.v2.txt, 19954.v3.txt, 19954.v4.txt
>
>
> TestBlockReorder fails against hadoop 3 due to the following error:
> {code}
> 2018-02-08 17:22:23,389 ERROR [RS:0;cn012:38253] 
> helpers.MarkerIgnoringBase(159): * ABORTING region server 
> cn012.l42scl.hortonworks.com,38253,1518110542271: Unhandled: Failed 
> suppression of fs shutdown hook: 
> org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@6a0c707e *
> java.lang.RuntimeException: Failed suppression of fs shutdown hook: 
> org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@6a0c707e
>   at 
> org.apache.hadoop.hbase.regionserver.ShutdownHook.suppressHdfsShutdownHook(ShutdownHook.java:207)
>   at 
> org.apache.hadoop.hbase.regionserver.ShutdownHook.install(ShutdownHook.java:85)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:927)
>   at 
> org.apache.hadoop.hbase.MiniHBaseCluster$MiniHBaseClusterRegionServer.runRegionServer(MiniHBaseCluster.java:187)
> {code}
> This is because when MiniDFSCluster is stopped in first subtest, hadoop 3 
> clears ShutdownHook.
> When the 2nd test starts, suppression of ShutdownHook fails.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (HBASE-17921) TestBlockReorder always fails against hadoop3.0.0-alpha2

2018-02-20 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-17921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack resolved HBASE-17921.
---
Resolution: Duplicate

Resolving as a dupe of HBASE-19954 (Scream if I have this wrong [~mdrob])

> TestBlockReorder always fails against hadoop3.0.0-alpha2
> 
>
> Key: HBASE-17921
> URL: https://issues.apache.org/jira/browse/HBASE-17921
> Project: HBase
>  Issue Type: Sub-task
>  Components: hadoop3
>Reporter: Jonathan Hsieh
>Assignee: Mike Drob
>Priority: Major
>
> {code}
> java.lang.ExceptionInInitializerError: null
>   at 
> org.apache.hadoop.hbase.fs.TestBlockReorder.(TestBlockReorder.java:83)
> testBlockLocation(org.apache.hadoop.hbase.fs.TestBlockReorder)  Time elapsed: 
> 0.023 sec  <<< ERROR!
> java.lang.NoClassDefFoundError: Could not initialize class 
> org.apache.hadoop.hbase.fs.TestBlockReorder
>   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>   at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.createTest(BlockJUnit4ClassRunner.java:217)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner$1.runReflectiveCall(BlockJUnit4ClassRunner.java:266)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.methodBlock(BlockJUnit4ClassRunner.java:263)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
> testHBaseCluster(org.apache.hadoop.hbase.fs.TestBlockReorder)  Time elapsed: 
> 0.011 sec  <<< ERROR!
> java.lang.NoClassDefFoundError: Could not initialize class 
> org.apache.hadoop.hbase.fs.TestBlockReorder
>   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>   at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.createTest(BlockJUnit4ClassRunner.java:217)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner$1.runReflectiveCall(BlockJUnit4ClassRunner.java:266)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.methodBlock(BlockJUnit4ClassRunner.java:263)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
>   at 
> 

[jira] [Commented] (HBASE-19954) Separate TestBlockReorder into individual tests to avoid ShutdownHook suppression error against hadoop3

2018-02-20 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370696#comment-16370696
 ] 

stack commented on HBASE-19954:
---

Subtask of this issue, 
https://issues.apache.org/jira/secure/attachment/12751805/HDFS-8838-HDFS-7285-20150821.patch#file-6,
 changed the minidfs cluster in hadoop3 such that it clears all shutdown hooks 
on mini dfs cluster shutdown.

> Separate TestBlockReorder into individual tests to avoid ShutdownHook 
> suppression error against hadoop3 
> 
>
> Key: HBASE-19954
> URL: https://issues.apache.org/jira/browse/HBASE-19954
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: 19954.v1.txt, 19954.v2.txt, 19954.v3.txt, 19954.v4.txt
>
>
> TestBlockReorder fails against hadoop 3 due to the following error:
> {code}
> 2018-02-08 17:22:23,389 ERROR [RS:0;cn012:38253] 
> helpers.MarkerIgnoringBase(159): * ABORTING region server 
> cn012.l42scl.hortonworks.com,38253,1518110542271: Unhandled: Failed 
> suppression of fs shutdown hook: 
> org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@6a0c707e *
> java.lang.RuntimeException: Failed suppression of fs shutdown hook: 
> org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@6a0c707e
>   at 
> org.apache.hadoop.hbase.regionserver.ShutdownHook.suppressHdfsShutdownHook(ShutdownHook.java:207)
>   at 
> org.apache.hadoop.hbase.regionserver.ShutdownHook.install(ShutdownHook.java:85)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:927)
>   at 
> org.apache.hadoop.hbase.MiniHBaseCluster$MiniHBaseClusterRegionServer.runRegionServer(MiniHBaseCluster.java:187)
> {code}
> This is because when MiniDFSCluster is stopped in first subtest, hadoop 3 
> clears ShutdownHook.
> When the 2nd test starts, suppression of ShutdownHook fails.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


  1   2   3   >