[ https://issues.apache.org/jira/browse/HBASE-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371009#comment-16371009 ]
Chia-Ping Tsai commented on HBASE-19985: ---------------------------------------- {quote}It seems dropping the 'e instanceof ServiceException' check but keeping the getCause() call should be good enough. {quote} +1 > Redundant instanceof check in ProtobufUtil#getServiceException > -------------------------------------------------------------- > > Key: HBASE-19985 > URL: https://issues.apache.org/jira/browse/HBASE-19985 > Project: HBase > Issue Type: Bug > Affects Versions: 1.4.1 > Reporter: Ted Yu > Priority: Trivial > Fix For: 1.5.0, 1.4.3 > > > {code} > public static IOException getServiceException(ServiceException e) { > Throwable t = e; > if (e instanceof ServiceException) { > t = e.getCause(); > {code} > The instanceof check would always return true. > This was reported by > https://builds.apache.org/job/PreCommit-HBASE-Build/11495/artifact/patchprocess/branch-findbugs-hbase-client-warnings.html#Warnings_STYLE -- This message was sent by Atlassian JIRA (v7.6.3#76005)