[jira] [Updated] (HBASE-20390) IMC Default Parameters for 2.0.0
[ https://issues.apache.org/jira/browse/HBASE-20390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-20390: -- Attachment: HBASE-20390-branch-2.0-01.patch > IMC Default Parameters for 2.0.0 > > > Key: HBASE-20390 > URL: https://issues.apache.org/jira/browse/HBASE-20390 > Project: HBase > Issue Type: Sub-task >Reporter: Eshcar Hillel >Assignee: Eshcar Hillel >Priority: Major > Attachments: HBASE-20390-branch-2.0-01.patch, > HBASE-20390-branch-2.0-01.patch > > > Setting new default parameters for in-memory compaction based on performance > tests done in HBASE-20188 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20390) IMC Default Parameters for 2.0.0
[ https://issues.apache.org/jira/browse/HBASE-20390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439003#comment-16439003 ] stack commented on HBASE-20390: --- Want to note the benefit [~eshcar] in the release note? Let me reload it. We don't seem to be running patches these times > IMC Default Parameters for 2.0.0 > > > Key: HBASE-20390 > URL: https://issues.apache.org/jira/browse/HBASE-20390 > Project: HBase > Issue Type: Sub-task >Reporter: Eshcar Hillel >Assignee: Eshcar Hillel >Priority: Major > Attachments: HBASE-20390-branch-2.0-01.patch > > > Setting new default parameters for in-memory compaction based on performance > tests done in HBASE-20188 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20411) Ameliorate MutableSegment synchronize
[ https://issues.apache.org/jira/browse/HBASE-20411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-20411: -- Attachment: HBASE-20411.branch-2.0.002.patch > Ameliorate MutableSegment synchronize > - > > Key: HBASE-20411 > URL: https://issues.apache.org/jira/browse/HBASE-20411 > Project: HBase > Issue Type: Bug >Reporter: stack >Priority: Major > Attachments: 2.load.patched.17704.lock.svg, > 2.load.patched.2.17704.lock.svg, 41901.lock.svg, > HBASE-20411.branch-2.0.001.patch, HBASE-20411.branch-2.0.002.patch > > > This item is migrated from HBASE-20236 so it gets dedicated issue. > Let me upload evidence that has this synchronize as a stake in our write-time > perf. I'll migrate the patch I posted with updates that come of comments > posted by [~mdrob] on the HBASE-20236 issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20419) Two Potential NPE
[
https://issues.apache.org/jira/browse/HBASE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438974#comment-16438974
]
Ted Yu commented on HBASE-20419:
lgtm
> Two Potential NPE
> --
>
> Key: HBASE-20419
> URL: https://issues.apache.org/jira/browse/HBASE-20419
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.1, 2.0.0-beta-2, 1.1.13
>Reporter: lujie
>Assignee: lujie
>Priority: Major
> Attachments: HBASE-20419.v3.patch, HBASE-20419_1.patch,
> HBASE-20419_2.patch
>
>
> We have developed a static analysis tool
> [NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential
> NPE. Our analysis shows that some callees may return null in corner case(e.g.
> node crash , IO exception), some of their callers have _!=null_ check but
> some do not have. For example:
> Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8
> callers, 6 of the caller have null checker like:
> {code:java}
> List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw,
> zkw.znodePaths.rsZNode);
> if (children == null) {
> return Collections.emptyList();
> }
> {code}
> but another two callers do not have null
> checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures.
>
> We attach the patch to fix this problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (HBASE-20419) Two Potential NPE
[
https://issues.apache.org/jira/browse/HBASE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu Li reassigned HBASE-20419:
-
Assignee: lujie
> Two Potential NPE
> --
>
> Key: HBASE-20419
> URL: https://issues.apache.org/jira/browse/HBASE-20419
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.1, 2.0.0-beta-2, 1.1.13
>Reporter: lujie
>Assignee: lujie
>Priority: Major
> Attachments: HBASE-20419.v3.patch, HBASE-20419_1.patch,
> HBASE-20419_2.patch
>
>
> We have developed a static analysis tool
> [NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential
> NPE. Our analysis shows that some callees may return null in corner case(e.g.
> node crash , IO exception), some of their callers have _!=null_ check but
> some do not have. For example:
> Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8
> callers, 6 of the caller have null checker like:
> {code:java}
> List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw,
> zkw.znodePaths.rsZNode);
> if (children == null) {
> return Collections.emptyList();
> }
> {code}
> but another two callers do not have null
> checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures.
>
> We attach the patch to fix this problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20419) Two Potential NPE
[
https://issues.apache.org/jira/browse/HBASE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438970#comment-16438970
]
Yu Li commented on HBASE-20419:
---
Thanks for reporting the issue [~xiaoheipangzi].
Patch lgtm except for the checkstyle issue (some indentation issue in the newly
added {{if}} block). Also checked the caller of the two modified methods and
confirmed return empty list/directly won't cause incorrect semantic.
Attaching a new version patch which fixes checkstyle error.
> Two Potential NPE
> --
>
> Key: HBASE-20419
> URL: https://issues.apache.org/jira/browse/HBASE-20419
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.1, 2.0.0-beta-2, 1.1.13
>Reporter: lujie
>Priority: Major
> Attachments: HBASE-20419.v3.patch, HBASE-20419_1.patch,
> HBASE-20419_2.patch
>
>
> We have developed a static analysis tool
> [NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential
> NPE. Our analysis shows that some callees may return null in corner case(e.g.
> node crash , IO exception), some of their callers have _!=null_ check but
> some do not have. For example:
> Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8
> callers, 6 of the caller have null checker like:
> {code:java}
> List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw,
> zkw.znodePaths.rsZNode);
> if (children == null) {
> return Collections.emptyList();
> }
> {code}
> but another two callers do not have null
> checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures.
>
> We attach the patch to fix this problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20419) Two Potential NPE
[
https://issues.apache.org/jira/browse/HBASE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu Li updated HBASE-20419:
--
Attachment: HBASE-20419.v3.patch
> Two Potential NPE
> --
>
> Key: HBASE-20419
> URL: https://issues.apache.org/jira/browse/HBASE-20419
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.1, 2.0.0-beta-2, 1.1.13
>Reporter: lujie
>Priority: Major
> Attachments: HBASE-20419.v3.patch, HBASE-20419_1.patch,
> HBASE-20419_2.patch
>
>
> We have developed a static analysis tool
> [NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential
> NPE. Our analysis shows that some callees may return null in corner case(e.g.
> node crash , IO exception), some of their callers have _!=null_ check but
> some do not have. For example:
> Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8
> callers, 6 of the caller have null checker like:
> {code:java}
> List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw,
> zkw.znodePaths.rsZNode);
> if (children == null) {
> return Collections.emptyList();
> }
> {code}
> but another two callers do not have null
> checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures.
>
> We attach the patch to fix this problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20128) Add new UTs which extends the old replication UTs but set replication scope to SERIAL
[ https://issues.apache.org/jira/browse/HBASE-20128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu updated HBASE-20128: - Attachment: HBASE-20128.v6.patch > Add new UTs which extends the old replication UTs but set replication scope > to SERIAL > - > > Key: HBASE-20128 > URL: https://issues.apache.org/jira/browse/HBASE-20128 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Zheng Hu >Priority: Major > Attachments: HBASE-20128.v1.patch, HBASE-20128.v2.patch, > HBASE-20128.v3.patch, HBASE-20128.v3.patch, HBASE-20128.v4.patch, > HBASE-20128.v5.patch, HBASE-20128.v5.patch, HBASE-20128.v6.patch, > HBASE-20128.v6.patch > > > Make sure that the basic function for replicationstill works. The serial > replication UTs are focused on order. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19761) Fix Checkstyle errors in hbase-zookeeper
[ https://issues.apache.org/jira/browse/HBASE-19761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated HBASE-19761: Status: Patch Available (was: In Progress) > Fix Checkstyle errors in hbase-zookeeper > > > Key: HBASE-19761 > URL: https://issues.apache.org/jira/browse/HBASE-19761 > Project: HBase > Issue Type: Sub-task >Reporter: Jan Hentschel >Assignee: maoling >Priority: Minor > Attachments: HBASE-19761-master-v0.patch, HBASE-19761-master-v1.patch > > > Fix the remaining Checkstyle errors in the *hbase-zookeeper* module and > enable Checkstyle to fail on violations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19761) Fix Checkstyle errors in hbase-zookeeper
[ https://issues.apache.org/jira/browse/HBASE-19761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated HBASE-19761: Attachment: HBASE-19761-master-v1.patch > Fix Checkstyle errors in hbase-zookeeper > > > Key: HBASE-19761 > URL: https://issues.apache.org/jira/browse/HBASE-19761 > Project: HBase > Issue Type: Sub-task >Reporter: Jan Hentschel >Assignee: maoling >Priority: Minor > Attachments: HBASE-19761-master-v0.patch, HBASE-19761-master-v1.patch > > > Fix the remaining Checkstyle errors in the *hbase-zookeeper* module and > enable Checkstyle to fail on violations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20419) Two Potential NPE
[
https://issues.apache.org/jira/browse/HBASE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438933#comment-16438933
]
lujie commented on HBASE-20419:
---
Hum, i found HBASE-5722 can indicate that those two NPE can happen. Am I
right
> Two Potential NPE
> --
>
> Key: HBASE-20419
> URL: https://issues.apache.org/jira/browse/HBASE-20419
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.1, 2.0.0-beta-2, 1.1.13
>Reporter: lujie
>Priority: Major
> Attachments: HBASE-20419_1.patch, HBASE-20419_2.patch
>
>
> We have developed a static analysis tool
> [NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential
> NPE. Our analysis shows that some callees may return null in corner case(e.g.
> node crash , IO exception), some of their callers have _!=null_ check but
> some do not have. For example:
> Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8
> callers, 6 of the caller have null checker like:
> {code:java}
> List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw,
> zkw.znodePaths.rsZNode);
> if (children == null) {
> return Collections.emptyList();
> }
> {code}
> but another two callers do not have null
> checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures.
>
> We attach the patch to fix this problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20419) Two Potential NPE
[
https://issues.apache.org/jira/browse/HBASE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-20419:
--
Affects Version/s: 1.4.1
1.1.13
> Two Potential NPE
> --
>
> Key: HBASE-20419
> URL: https://issues.apache.org/jira/browse/HBASE-20419
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.1, 2.0.0-beta-2, 1.1.13
>Reporter: lujie
>Priority: Major
> Attachments: HBASE-20419_1.patch, HBASE-20419_2.patch
>
>
> We have developed a static analysis tool
> [NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential
> NPE. Our analysis shows that some callees may return null in corner case(e.g.
> node crash , IO exception), some of their callers have _!=null_ check but
> some do not have. For example:
> Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8
> callers, 6 of the caller have null checker like:
> {code:java}
> List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw,
> zkw.znodePaths.rsZNode);
> if (children == null) {
> return Collections.emptyList();
> }
> {code}
> but another two callers do not have null
> checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures.
>
> We attach the patch to fix this problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20420) Fix Some Potential NPE
[ https://issues.apache.org/jira/browse/HBASE-20420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438919#comment-16438919 ] lujie commented on HBASE-20420: --- [~Apache9]: _AccessControlLists#removeTablePermissions_ call the _Result#getFamilyMap_ to get the _NavigableMap_, _getFamilyMap_ will return null while the Result isEmpty(eg Result.cell == null), i have analysed the code related the cell, I think it is possible to return null. But due to i am not very familiar to HBASE, so i may be wrong, and if so, i will update the patch. And could you please review the other NPE case in the patch. Thanks very much. > Fix Some Potential NPE > --- > > Key: HBASE-20420 > URL: https://issues.apache.org/jira/browse/HBASE-20420 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-beta-2 >Reporter: lujie >Priority: Major > Attachments: HBASE-20420_2.patch, hbase-20420.patch > > > We have used the tool [NPEDetector|https://github.com/lujiefsi/NPEDetector] > find another six problems that similar to HBASE-20419. > list here and attach the patch. > CommonFSUtils#listStatus > RSGroupInfoManagerImpl#getRSGroupOfServer > BackupSystemTable#readBackupInfo > SnapshotManifest#getRegionManifestsMap > HRegionFileSystem#getFamilies > Result#getFamilyMap -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20364) nightly job gives old results or no results for stages that timeout on SCM
[
https://issues.apache.org/jira/browse/HBASE-20364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438863#comment-16438863
]
Hudson commented on HBASE-20364:
Results for branch branch-1.3
[build #297 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/297/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/297//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/297//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/297//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> nightly job gives old results or no results for stages that timeout on SCM
> --
>
> Key: HBASE-20364
> URL: https://issues.apache.org/jira/browse/HBASE-20364
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 2.1.0, 1.5.0, 1.2.7, 1.3.3, 1.4.4, 2.0.1
>
> Attachments: HBASE-20364.0.patch
>
>
> seen in the branch-2.0 nightly report for HBASE-18828:
>
> {quote}
> Results for branch branch-2.0
> [build #143 on
> builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/143/]:
> (x) *\{color:red}-1 overall\{color}*
>
> details (if available):
> (/) \{color:green}+1 general checks\{color}
> -- For more information [see general
> report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/140//General_Nightly_Build_Report/]
>
> (/) \{color:green}+1 jdk8 hadoop2 checks\{color}
> -- For more information [see jdk8 (hadoop2)
> report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/143//JDK8_Nightly_Build_Report_(Hadoop2)/]
> (/) \{color:green}+1 jdk8 hadoop3 checks\{color}
> -- For more information [see jdk8 (hadoop3)
> report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/143//JDK8_Nightly_Build_Report_(Hadoop3)/]
>
> {quote}
>
> -1 for the overall build was correct. build #143 failed both the general
> check and the source tarball check.
>
> but in the posted comment, we get a false "passing" that links to the general
> result from build #140. and we get no result for the source tarball at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20364) nightly job gives old results or no results for stages that timeout on SCM
[
https://issues.apache.org/jira/browse/HBASE-20364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438828#comment-16438828
]
Hudson commented on HBASE-20364:
Results for branch branch-1.4
[build #290 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/290/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/290//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/290//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/290//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> nightly job gives old results or no results for stages that timeout on SCM
> --
>
> Key: HBASE-20364
> URL: https://issues.apache.org/jira/browse/HBASE-20364
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 2.1.0, 1.5.0, 1.2.7, 1.3.3, 1.4.4, 2.0.1
>
> Attachments: HBASE-20364.0.patch
>
>
> seen in the branch-2.0 nightly report for HBASE-18828:
>
> {quote}
> Results for branch branch-2.0
> [build #143 on
> builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/143/]:
> (x) *\{color:red}-1 overall\{color}*
>
> details (if available):
> (/) \{color:green}+1 general checks\{color}
> -- For more information [see general
> report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/140//General_Nightly_Build_Report/]
>
> (/) \{color:green}+1 jdk8 hadoop2 checks\{color}
> -- For more information [see jdk8 (hadoop2)
> report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/143//JDK8_Nightly_Build_Report_(Hadoop2)/]
> (/) \{color:green}+1 jdk8 hadoop3 checks\{color}
> -- For more information [see jdk8 (hadoop3)
> report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/143//JDK8_Nightly_Build_Report_(Hadoop3)/]
>
> {quote}
>
> -1 for the overall build was correct. build #143 failed both the general
> check and the source tarball check.
>
> but in the posted comment, we get a false "passing" that links to the general
> result from build #140. and we get no result for the source tarball at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20419) Two Potential NPE
[
https://issues.apache.org/jira/browse/HBASE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438817#comment-16438817
]
Hadoop QA commented on HBASE-20419:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
37s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
27s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
21s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
4s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
2s{color} | {color:red} hbase-server: The patch generated 1 new + 3 unchanged -
0 fixed = 4 total (was 3) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
11s{color} | {color:red} hbase-rsgroup: The patch generated 1 new + 0 unchanged
- 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
18s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
13m 11s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}146m
37s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 5m
14s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
40s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}197m 55s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20419 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12919111/HBASE-20419_2.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 23c805c32c3a 4.4.0-104-generic #127-Ubuntu SMP Mon Dec
[jira] [Commented] (HBASE-20420) Fix Some Potential NPE
[
https://issues.apache.org/jira/browse/HBASE-20420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438811#comment-16438811
]
Hadoop QA commented on HBASE-20420:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
51s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
40s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
10s{color} | {color:red} hbase-server: The patch generated 1 new + 71 unchanged
- 0 fixed = 72 total (was 71) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
43s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
14m 26s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}107m
35s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
23s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 11m
20s{color} | {color:green} hbase-backup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
1s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}175m 3s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20420 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12919112/HBASE-20420_2.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux e1857d0fb624 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 GNU/Linux |
|
[jira] [Work started] (HBASE-20416) [DOC] Fix hbck option intros
[
https://issues.apache.org/jira/browse/HBASE-20416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-20416 started by Wei-Chiu Chuang.
---
> [DOC] Fix hbck option intros
>
>
> Key: HBASE-20416
> URL: https://issues.apache.org/jira/browse/HBASE-20416
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Attachments: HBASE-20416.master.001.patch
>
>
> {quote}In this case, you can use the -fixSplitParents
> This option should not normally be used, and it is not in -fixAll.
> {quote}
> There is no such option "-fixAll". From the context, it seems to refer to
> -repair
> In addition, -repair option also covers -fixReferenceFiles, -fixHFileLinks,
> which are not introduced in the doc.
> {code:java|title=HBaseFsck#exec}
> else if (cmd.equals("-repair")) {
> // this attempts to merge overlapping hdfs regions, needs testing
> // under load
> setFixHdfsHoles(true);
> setFixHdfsOrphans(true);
> setFixMeta(true);
> setFixAssignments(true);
> setFixHdfsOverlaps(true);
> setFixVersionFile(true);
> setSidelineBigOverlaps(true);
> setFixSplitParents(false);
> setCheckHdfs(true);
> setFixReferenceFiles(true);
> setFixHFileLinks(true);
> {code}
> {quote}-repair includes all the region consistency options and only the hole
> repairing table integrity options.
> {quote}
> ... seems untrue to me.
>
> Finally,
> {quote}
> In this case there is a special -fixMetaOnly option that can try to fix meta
> assignments.
> {quote}
> -fixMetaOnly option no longer exists.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20416) [DOC] Fix hbck option intros
[
https://issues.apache.org/jira/browse/HBASE-20416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438809#comment-16438809
]
Wei-Chiu Chuang commented on HBASE-20416:
-
Rev01:
# Updated -repair to make it explicit what options does it include.
# Added intro to -fixReferenceFiles and -fixHFileLinks.
# Changed -fixMetaOnly to -metaonly.
I also found a few other hbck options not mentioned in the doc:
{noformat}
-removeParents (HBASE-15941)
-fixReplication (HBASE-12769)
-boundaries (HBASE-9346)
-fixEmptyMetaCells (HBASE-7930)
-checkCorruptHFiles (HBASE-6586)
-sidelineCorruptHFiles (HBASE-6586)
ignorePreCheckPermission (HBASE-5714)
-fixTableOrphans (HBASE-5631)
-noHdfsChecking (HBASE-7190)
{noformat}
These combinations are quite complex so I am not dealing with them this time.
This doc is meant to fix the ones that are already in the doc but are incorrect.
> [DOC] Fix hbck option intros
>
>
> Key: HBASE-20416
> URL: https://issues.apache.org/jira/browse/HBASE-20416
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Attachments: HBASE-20416.master.001.patch
>
>
> {quote}In this case, you can use the -fixSplitParents
> This option should not normally be used, and it is not in -fixAll.
> {quote}
> There is no such option "-fixAll". From the context, it seems to refer to
> -repair
> In addition, -repair option also covers -fixReferenceFiles, -fixHFileLinks,
> which are not introduced in the doc.
> {code:java|title=HBaseFsck#exec}
> else if (cmd.equals("-repair")) {
> // this attempts to merge overlapping hdfs regions, needs testing
> // under load
> setFixHdfsHoles(true);
> setFixHdfsOrphans(true);
> setFixMeta(true);
> setFixAssignments(true);
> setFixHdfsOverlaps(true);
> setFixVersionFile(true);
> setSidelineBigOverlaps(true);
> setFixSplitParents(false);
> setCheckHdfs(true);
> setFixReferenceFiles(true);
> setFixHFileLinks(true);
> {code}
> {quote}-repair includes all the region consistency options and only the hole
> repairing table integrity options.
> {quote}
> ... seems untrue to me.
>
> Finally,
> {quote}
> In this case there is a special -fixMetaOnly option that can try to fix meta
> assignments.
> {quote}
> -fixMetaOnly option no longer exists.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HBASE-20416) [DOC] Fix hbck option intros
[
https://issues.apache.org/jira/browse/HBASE-20416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438809#comment-16438809
]
Wei-Chiu Chuang edited comment on HBASE-20416 at 4/15/18 7:11 PM:
--
Rev01:
# Updated -repair to make it explicit what options does it include.
# Added intro to -fixReferenceFiles and -fixHFileLinks.
# Changed -fixMetaOnly to -metaonly.
I also found a few other hbck options not mentioned in the doc:
{noformat}
-removeParents (HBASE-15941)
-fixReplication (HBASE-12769)
-boundaries (HBASE-9346)
-fixEmptyMetaCells (HBASE-7930)
-checkCorruptHFiles (HBASE-6586)
-sidelineCorruptHFiles (HBASE-6586)
-ignorePreCheckPermission (HBASE-5714)
-fixTableOrphans (HBASE-5631)
-noHdfsChecking (HBASE-7190)
{noformat}
These combinations are quite complex so I am not dealing with them this time.
This doc is meant to fix the ones that are already in the doc but are incorrect.
was (Author: jojochuang):
Rev01:
# Updated -repair to make it explicit what options does it include.
# Added intro to -fixReferenceFiles and -fixHFileLinks.
# Changed -fixMetaOnly to -metaonly.
I also found a few other hbck options not mentioned in the doc:
{noformat}
-removeParents (HBASE-15941)
-fixReplication (HBASE-12769)
-boundaries (HBASE-9346)
-fixEmptyMetaCells (HBASE-7930)
-checkCorruptHFiles (HBASE-6586)
-sidelineCorruptHFiles (HBASE-6586)
ignorePreCheckPermission (HBASE-5714)
-fixTableOrphans (HBASE-5631)
-noHdfsChecking (HBASE-7190)
{noformat}
These combinations are quite complex so I am not dealing with them this time.
This doc is meant to fix the ones that are already in the doc but are incorrect.
> [DOC] Fix hbck option intros
>
>
> Key: HBASE-20416
> URL: https://issues.apache.org/jira/browse/HBASE-20416
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Attachments: HBASE-20416.master.001.patch
>
>
> {quote}In this case, you can use the -fixSplitParents
> This option should not normally be used, and it is not in -fixAll.
> {quote}
> There is no such option "-fixAll". From the context, it seems to refer to
> -repair
> In addition, -repair option also covers -fixReferenceFiles, -fixHFileLinks,
> which are not introduced in the doc.
> {code:java|title=HBaseFsck#exec}
> else if (cmd.equals("-repair")) {
> // this attempts to merge overlapping hdfs regions, needs testing
> // under load
> setFixHdfsHoles(true);
> setFixHdfsOrphans(true);
> setFixMeta(true);
> setFixAssignments(true);
> setFixHdfsOverlaps(true);
> setFixVersionFile(true);
> setSidelineBigOverlaps(true);
> setFixSplitParents(false);
> setCheckHdfs(true);
> setFixReferenceFiles(true);
> setFixHFileLinks(true);
> {code}
> {quote}-repair includes all the region consistency options and only the hole
> repairing table integrity options.
> {quote}
> ... seems untrue to me.
>
> Finally,
> {quote}
> In this case there is a special -fixMetaOnly option that can try to fix meta
> assignments.
> {quote}
> -fixMetaOnly option no longer exists.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20416) [DOC] Fix hbck option intros
[
https://issues.apache.org/jira/browse/HBASE-20416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Chiu Chuang updated HBASE-20416:
Attachment: HBASE-20416.master.001.patch
> [DOC] Fix hbck option intros
>
>
> Key: HBASE-20416
> URL: https://issues.apache.org/jira/browse/HBASE-20416
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Attachments: HBASE-20416.master.001.patch
>
>
> {quote}In this case, you can use the -fixSplitParents
> This option should not normally be used, and it is not in -fixAll.
> {quote}
> There is no such option "-fixAll". From the context, it seems to refer to
> -repair
> In addition, -repair option also covers -fixReferenceFiles, -fixHFileLinks,
> which are not introduced in the doc.
> {code:java|title=HBaseFsck#exec}
> else if (cmd.equals("-repair")) {
> // this attempts to merge overlapping hdfs regions, needs testing
> // under load
> setFixHdfsHoles(true);
> setFixHdfsOrphans(true);
> setFixMeta(true);
> setFixAssignments(true);
> setFixHdfsOverlaps(true);
> setFixVersionFile(true);
> setSidelineBigOverlaps(true);
> setFixSplitParents(false);
> setCheckHdfs(true);
> setFixReferenceFiles(true);
> setFixHFileLinks(true);
> {code}
> {quote}-repair includes all the region consistency options and only the hole
> repairing table integrity options.
> {quote}
> ... seems untrue to me.
>
> Finally,
> {quote}
> In this case there is a special -fixMetaOnly option that can try to fix meta
> assignments.
> {quote}
> -fixMetaOnly option no longer exists.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20406) HBase Thrift HTTP - Shouldn't handle TRACE/OPTIONS methods
[
https://issues.apache.org/jira/browse/HBASE-20406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438804#comment-16438804
]
Hadoop QA commented on HBASE-20406:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
32s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
25s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
39s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
38s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 37s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
46s{color} | {color:green} hbase-http in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
2s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 53m 54s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20406 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12919117/HBASE-20406.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 539649defe90 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 125767b44e |
| maven | version: Apache Maven 3.5.3
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_162 |
|
[jira] [Commented] (HBASE-20406) HBase Thrift HTTP - Shouldn't handle TRACE/OPTIONS methods
[ https://issues.apache.org/jira/browse/HBASE-20406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438792#comment-16438792 ] Kevin Risden commented on HBASE-20406: -- Updated patch with tests. > HBase Thrift HTTP - Shouldn't handle TRACE/OPTIONS methods > -- > > Key: HBASE-20406 > URL: https://issues.apache.org/jira/browse/HBASE-20406 > Project: HBase > Issue Type: Improvement > Components: security, Thrift >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Attachments: HBASE-20406.master.001.patch, > HBASE-20406.master.002.patch > > > HBASE-10473 introduced a utility HttpServerUtil.constrainHttpMethods to > prevent Jetty from answering on TRACE and OPTIONS methods. This should be > added to Thrift in HTTP mode as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20406) HBase Thrift HTTP - Shouldn't handle TRACE/OPTIONS methods
[ https://issues.apache.org/jira/browse/HBASE-20406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated HBASE-20406: - Attachment: HBASE-20406.master.002.patch > HBase Thrift HTTP - Shouldn't handle TRACE/OPTIONS methods > -- > > Key: HBASE-20406 > URL: https://issues.apache.org/jira/browse/HBASE-20406 > Project: HBase > Issue Type: Improvement > Components: security, Thrift >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Attachments: HBASE-20406.master.001.patch, > HBASE-20406.master.002.patch > > > HBASE-10473 introduced a utility HttpServerUtil.constrainHttpMethods to > prevent Jetty from answering on TRACE and OPTIONS methods. This should be > added to Thrift in HTTP mode as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20416) [DOC] Fix hbck option intros
[
https://issues.apache.org/jira/browse/HBASE-20416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Chiu Chuang updated HBASE-20416:
Description:
{quote}In this case, you can use the -fixSplitParents
This option should not normally be used, and it is not in -fixAll.
{quote}
There is no such option "-fixAll". From the context, it seems to refer to
-repair
In addition, -repair option also covers -fixReferenceFiles, -fixHFileLinks,
which are not introduced in the doc.
{code:java|title=HBaseFsck#exec}
else if (cmd.equals("-repair")) {
// this attempts to merge overlapping hdfs regions, needs testing
// under load
setFixHdfsHoles(true);
setFixHdfsOrphans(true);
setFixMeta(true);
setFixAssignments(true);
setFixHdfsOverlaps(true);
setFixVersionFile(true);
setSidelineBigOverlaps(true);
setFixSplitParents(false);
setCheckHdfs(true);
setFixReferenceFiles(true);
setFixHFileLinks(true);
{code}
{quote}-repair includes all the region consistency options and only the hole
repairing table integrity options.
{quote}
... seems untrue to me.
Finally,
{quote}
In this case there is a special -fixMetaOnly option that can try to fix meta
assignments.
{quote}
-fixMetaOnly option no longer exists.
was:
{quote}
In this case, you can use the -fixSplitParents
This option should not normally be used, and it is not in -fixAll.
{quote}
There is no such option "-fixAll". From the context, it seems to refer to
-repair
In addition, -repair option also covers -fixReferenceFiles, -fixHFileLinks,
which are not introduced in the doc.
{code:title=HBaseFsck#exec}
else if (cmd.equals("-repair")) {
// this attempts to merge overlapping hdfs regions, needs testing
// under load
setFixHdfsHoles(true);
setFixHdfsOrphans(true);
setFixMeta(true);
setFixAssignments(true);
setFixHdfsOverlaps(true);
setFixVersionFile(true);
setSidelineBigOverlaps(true);
setFixSplitParents(false);
setCheckHdfs(true);
setFixReferenceFiles(true);
setFixHFileLinks(true);
{code}
{quote}
-repair includes all the region consistency options and only the hole repairing
table integrity options.
{quote}
... seems untrue to me.
> [DOC] Fix hbck option intros
>
>
> Key: HBASE-20416
> URL: https://issues.apache.org/jira/browse/HBASE-20416
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
>
> {quote}In this case, you can use the -fixSplitParents
> This option should not normally be used, and it is not in -fixAll.
> {quote}
> There is no such option "-fixAll". From the context, it seems to refer to
> -repair
> In addition, -repair option also covers -fixReferenceFiles, -fixHFileLinks,
> which are not introduced in the doc.
> {code:java|title=HBaseFsck#exec}
> else if (cmd.equals("-repair")) {
> // this attempts to merge overlapping hdfs regions, needs testing
> // under load
> setFixHdfsHoles(true);
> setFixHdfsOrphans(true);
> setFixMeta(true);
> setFixAssignments(true);
> setFixHdfsOverlaps(true);
> setFixVersionFile(true);
> setSidelineBigOverlaps(true);
> setFixSplitParents(false);
> setCheckHdfs(true);
> setFixReferenceFiles(true);
> setFixHFileLinks(true);
> {code}
> {quote}-repair includes all the region consistency options and only the hole
> repairing table integrity options.
> {quote}
> ... seems untrue to me.
>
> Finally,
> {quote}
> In this case there is a special -fixMetaOnly option that can try to fix meta
> assignments.
> {quote}
> -fixMetaOnly option no longer exists.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20420) Fix Some Potential NPE
[ https://issues.apache.org/jira/browse/HBASE-20420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-20420: -- Attachment: HBASE-20420_2.patch > Fix Some Potential NPE > --- > > Key: HBASE-20420 > URL: https://issues.apache.org/jira/browse/HBASE-20420 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-beta-2 >Reporter: lujie >Priority: Major > Attachments: HBASE-20420_2.patch, hbase-20420.patch > > > We have used the tool [NPEDetector|https://github.com/lujiefsi/NPEDetector] > find another six problems that similar to HBASE-20419. > list here and attach the patch. > CommonFSUtils#listStatus > RSGroupInfoManagerImpl#getRSGroupOfServer > BackupSystemTable#readBackupInfo > SnapshotManifest#getRegionManifestsMap > HRegionFileSystem#getFamilies > Result#getFamilyMap -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty
[
https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438757#comment-16438757
]
Reid Chan commented on HBASE-20404:
---
v2 is much clear, lgtm.
> Ugly cleanerchore complaint that dir is not empty
> -
>
> Key: HBASE-20404
> URL: https://issues.apache.org/jira/browse/HBASE-20404
> Project: HBase
> Issue Type: Bug
> Components: master
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-20404.0.patch, HBASE-20404.1.patch,
> HBASE-20404.2.patch
>
>
> I see these big dirty exceptions in my master log during a long-run Lets
> clean them up (Are they exceptions I as an operator can actually do something
> about? Are they 'problems'? Should they be LOG.warn?)
> {code}
> 2018-04-12 16:02:09,911 WARN [ForkJoinPool-1-worker-15]
> cleaner.CleanerChore: Could not delete dir under
> hdfs://ve0524.halxg.cloudera.com:8020/hbase/archive/data/default/IntegrationTestBigLinkedList/1e24549061df3adc4858fbcaf1929553/meta;
> {}
> org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.fs.PathIsNotEmptyDirectoryException):
>
> `/hbase/archive/data/default/IntegrationTestBigLinkedList/1e24549061df3adc4858fbcaf1929553/meta
> is non empty': Directory is not empty
> at
> org.apache.hadoop.hdfs.server.namenode.FSDirDeleteOp.delete(FSDirDeleteOp.java:115)
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.delete(FSNamesystem.java:2848)
> at
> org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.delete(NameNodeRpcServer.java:1048)
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.delete(ClientNamenodeProtocolServerSideTranslatorPB.java:641)
> at
> org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:447)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:989)
> at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:847)
> at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:790)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1836)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2486)
> at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1489)
> at org.apache.hadoop.ipc.Client.call(Client.java:1435)
> at org.apache.hadoop.ipc.Client.call(Client.java:1345)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:227)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:116)
> at com.sun.proxy.$Proxy26.delete(Unknown Source)
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.delete(ClientNamenodeProtocolTranslatorPB.java:568)
> at sun.reflect.GeneratedMethodAccessor28.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:409)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:163)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:155)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:346)
> at com.sun.proxy.$Proxy27.delete(Unknown Source)
> at sun.reflect.GeneratedMethodAccessor28.invoke(Unknown Source)
> ...
> {code}
> Looks like log format is off too...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20409) Set hbase.client.meta.operation.timeout in TestClientOperationTimeout
[
https://issues.apache.org/jira/browse/HBASE-20409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438754#comment-16438754
]
Hudson commented on HBASE-20409:
Results for branch branch-2.0
[build #180 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/180/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/180//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/180//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/180//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Set hbase.client.meta.operation.timeout in TestClientOperationTimeout
> -
>
> Key: HBASE-20409
> URL: https://issues.apache.org/jira/browse/HBASE-20409
> Project: HBase
> Issue Type: Improvement
> Components: test
>Affects Versions: 3.0.0, 2.1.0, 2.0.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Trivial
> Fix For: 3.0.0, 2.1.0, 2.0.0
>
> Attachments: HBASE-20409.master.001.patch
>
>
> In TestClientOperationTimeout the hbase.client.meta.operation.timeout
> property is not, so default value is used which is 120ms. The test
> finishes earlier if we set the timeout to match with
> hbase.client.meta.operation.timeout.
> Since the first call will go to META table where the default timeout is used.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20419) Two Potential NPE
[
https://issues.apache.org/jira/browse/HBASE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-20419:
--
Attachment: HBASE-20419_2.patch
> Two Potential NPE
> --
>
> Key: HBASE-20419
> URL: https://issues.apache.org/jira/browse/HBASE-20419
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0-beta-2
>Reporter: lujie
>Priority: Major
> Attachments: HBASE-20419_1.patch, HBASE-20419_2.patch
>
>
> We have developed a static analysis tool
> [NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential
> NPE. Our analysis shows that some callees may return null in corner case(e.g.
> node crash , IO exception), some of their callers have _!=null_ check but
> some do not have. For example:
> Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8
> callers, 6 of the caller have null checker like:
> {code:java}
> List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw,
> zkw.znodePaths.rsZNode);
> if (children == null) {
> return Collections.emptyList();
> }
> {code}
> but another two callers do not have null
> checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures.
>
> We attach the patch to fix this problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20409) Set hbase.client.meta.operation.timeout in TestClientOperationTimeout
[
https://issues.apache.org/jira/browse/HBASE-20409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438747#comment-16438747
]
Hudson commented on HBASE-20409:
Results for branch branch-2
[build #617 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/617/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/617//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/617//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/617//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Set hbase.client.meta.operation.timeout in TestClientOperationTimeout
> -
>
> Key: HBASE-20409
> URL: https://issues.apache.org/jira/browse/HBASE-20409
> Project: HBase
> Issue Type: Improvement
> Components: test
>Affects Versions: 3.0.0, 2.1.0, 2.0.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Trivial
> Fix For: 3.0.0, 2.1.0, 2.0.0
>
> Attachments: HBASE-20409.master.001.patch
>
>
> In TestClientOperationTimeout the hbase.client.meta.operation.timeout
> property is not, so default value is used which is 120ms. The test
> finishes earlier if we set the timeout to match with
> hbase.client.meta.operation.timeout.
> Since the first call will go to META table where the default timeout is used.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20419) Two Potential NPE
[
https://issues.apache.org/jira/browse/HBASE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438740#comment-16438740
]
Hadoop QA commented on HBASE-20419:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
29s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
47s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
19s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
12s{color} | {color:red} hbase-server: The patch generated 2 new + 3 unchanged
- 0 fixed = 5 total (was 3) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
15s{color} | {color:red} hbase-rsgroup: The patch generated 1 new + 0 unchanged
- 0 fixed = 1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 5 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
58s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 2s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}127m 0s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
34s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
40s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}181m 45s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestAsyncTableBatch |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20419 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12919104/HBASE-20419_1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
[jira] [Commented] (HBASE-20420) Fix Some Potential NPE
[
https://issues.apache.org/jira/browse/HBASE-20420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438739#comment-16438739
]
Hadoop QA commented on HBASE-20420:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
20s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
35s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
1s{color} | {color:red} hbase-server: The patch generated 6 new + 71 unchanged
- 0 fixed = 77 total (was 71) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
8s{color} | {color:red} hbase-rsgroup: The patch generated 2 new + 0 unchanged
- 0 fixed = 2 total (was 0) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
14s{color} | {color:red} hbase-backup: The patch generated 1 new + 0 unchanged
- 0 fixed = 1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 4 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
20s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
13m 28s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}104m
26s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
22s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m
27s{color} | {color:green} hbase-backup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
0s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}169m 45s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce
[jira] [Commented] (HBASE-20406) HBase Thrift HTTP - Shouldn't handle TRACE/OPTIONS methods
[ https://issues.apache.org/jira/browse/HBASE-20406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438705#comment-16438705 ] Ashish Singhi commented on HBASE-20406: --- HBASE-20004. Plan was to make it configurable. I plan to work on it in the coming week. > HBase Thrift HTTP - Shouldn't handle TRACE/OPTIONS methods > -- > > Key: HBASE-20406 > URL: https://issues.apache.org/jira/browse/HBASE-20406 > Project: HBase > Issue Type: Improvement > Components: security, Thrift >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Attachments: HBASE-20406.master.001.patch > > > HBASE-10473 introduced a utility HttpServerUtil.constrainHttpMethods to > prevent Jetty from answering on TRACE and OPTIONS methods. This should be > added to Thrift in HTTP mode as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20388) nightly tests running on a feature branch should only comment on that feature branch's jira
[ https://issues.apache.org/jira/browse/HBASE-20388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438704#comment-16438704 ] Sean Busbey commented on HBASE-20388: - [build 8 changesets|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20388/8/changes] show HBASE-20418, but you can see comment only went here. > nightly tests running on a feature branch should only comment on that feature > branch's jira > --- > > Key: HBASE-20388 > URL: https://issues.apache.org/jira/browse/HBASE-20388 > Project: HBase > Issue Type: Improvement > Components: community, test >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Attachments: HBASE-20388.0.patch, HBASE-20388.1.patch, > HBASE-20388.2.patch > > > It would help improve our signal-to-noise ratio from nightly tests if feature > branch runs stopped commenting on all the jiras that got covered by a rebase > / merge. > should be straight forward to have the commenting bit check the current > branch against our feature branch naming convention. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20128) Add new UTs which extends the old replication UTs but set replication scope to SERIAL
[
https://issues.apache.org/jira/browse/HBASE-20128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438701#comment-16438701
]
Hadoop QA commented on HBASE-20128:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red}419m
52s{color} | {color:red} Docker failed to build yetus/hbase:d8b550f. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-20128 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12919092/HBASE-20128.v6.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/12453/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Add new UTs which extends the old replication UTs but set replication scope
> to SERIAL
> -
>
> Key: HBASE-20128
> URL: https://issues.apache.org/jira/browse/HBASE-20128
> Project: HBase
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Zheng Hu
>Priority: Major
> Attachments: HBASE-20128.v1.patch, HBASE-20128.v2.patch,
> HBASE-20128.v3.patch, HBASE-20128.v3.patch, HBASE-20128.v4.patch,
> HBASE-20128.v5.patch, HBASE-20128.v5.patch, HBASE-20128.v6.patch
>
>
> Make sure that the basic function for replicationstill works. The serial
> replication UTs are focused on order.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20364) nightly job gives old results or no results for stages that timeout on SCM
[
https://issues.apache.org/jira/browse/HBASE-20364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438692#comment-16438692
]
Hudson commented on HBASE-20364:
Results for branch master
[build #300 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/300/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/300//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/300//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/300//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> nightly job gives old results or no results for stages that timeout on SCM
> --
>
> Key: HBASE-20364
> URL: https://issues.apache.org/jira/browse/HBASE-20364
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 2.1.0, 1.5.0, 1.2.7, 1.3.3, 1.4.4, 2.0.1
>
> Attachments: HBASE-20364.0.patch
>
>
> seen in the branch-2.0 nightly report for HBASE-18828:
>
> {quote}
> Results for branch branch-2.0
> [build #143 on
> builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/143/]:
> (x) *\{color:red}-1 overall\{color}*
>
> details (if available):
> (/) \{color:green}+1 general checks\{color}
> -- For more information [see general
> report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/140//General_Nightly_Build_Report/]
>
> (/) \{color:green}+1 jdk8 hadoop2 checks\{color}
> -- For more information [see jdk8 (hadoop2)
> report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/143//JDK8_Nightly_Build_Report_(Hadoop2)/]
> (/) \{color:green}+1 jdk8 hadoop3 checks\{color}
> -- For more information [see jdk8 (hadoop3)
> report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/143//JDK8_Nightly_Build_Report_(Hadoop3)/]
>
> {quote}
>
> -1 for the overall build was correct. build #143 failed both the general
> check and the source tarball check.
>
> but in the posted comment, we get a false "passing" that links to the general
> result from build #140. and we get no result for the source tarball at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20409) Set hbase.client.meta.operation.timeout in TestClientOperationTimeout
[
https://issues.apache.org/jira/browse/HBASE-20409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438693#comment-16438693
]
Hudson commented on HBASE-20409:
Results for branch master
[build #300 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/300/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/300//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/300//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/300//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Set hbase.client.meta.operation.timeout in TestClientOperationTimeout
> -
>
> Key: HBASE-20409
> URL: https://issues.apache.org/jira/browse/HBASE-20409
> Project: HBase
> Issue Type: Improvement
> Components: test
>Affects Versions: 3.0.0, 2.1.0, 2.0.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Trivial
> Fix For: 3.0.0, 2.1.0, 2.0.0
>
> Attachments: HBASE-20409.master.001.patch
>
>
> In TestClientOperationTimeout the hbase.client.meta.operation.timeout
> property is not, so default value is used which is 120ms. The test
> finishes earlier if we set the timeout to match with
> hbase.client.meta.operation.timeout.
> Since the first call will go to META table where the default timeout is used.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20420) Fix Some Potential NPE
[ https://issues.apache.org/jira/browse/HBASE-20420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438691#comment-16438691 ] Duo Zhang commented on HBASE-20420: --- In AccessControlLists, is it possible that we have a Result which does not contain ACL_LIST_FAMILY? > Fix Some Potential NPE > --- > > Key: HBASE-20420 > URL: https://issues.apache.org/jira/browse/HBASE-20420 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-beta-2 >Reporter: lujie >Priority: Major > Attachments: hbase-20420.patch > > > We have used the tool [NPEDetector|https://github.com/lujiefsi/NPEDetector] > find another six problems that similar to HBASE-20419. > list here and attach the patch. > CommonFSUtils#listStatus > RSGroupInfoManagerImpl#getRSGroupOfServer > BackupSystemTable#readBackupInfo > SnapshotManifest#getRegionManifestsMap > HRegionFileSystem#getFamilies > Result#getFamilyMap -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20419) Two Potential NPE
[
https://issues.apache.org/jira/browse/HBASE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-20419:
--
Description:
We have developed a static analysis tool
[NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential
NPE. Our analysis shows that some callees may return null in corner case(e.g.
node crash , IO exception), some of their callers have _!=null_ check but some
do not have. In this issue we post a patch which can add !=null based on
existed !=null check. For example:
Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8
callers, 6 of the caller have null checker like:
{code:java}
List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw,
zkw.znodePaths.rsZNode);
if (children == null) {
return Collections.emptyList();
}
{code}
but another two callers do not have null
checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures.
We attach the patch to fix this problem.
was:
Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8
callers, 6 of the caller have null checker like:
{code:java}
List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw,
zkw.znodePaths.rsZNode);
if (children == null) {
return Collections.emptyList();
}
{code}
but another two callers do not have null
checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures.
We attach the patch to fix this probelm.(We found this bug by tool
[NPEDetector|https://github.com/lujiefsi/NPEDetector])
> Two Potential NPE
> --
>
> Key: HBASE-20419
> URL: https://issues.apache.org/jira/browse/HBASE-20419
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0-beta-2
>Reporter: lujie
>Priority: Major
> Attachments: HBASE-20419_1.patch
>
>
> We have developed a static analysis tool
> [NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential
> NPE. Our analysis shows that some callees may return null in corner case(e.g.
> node crash , IO exception), some of their callers have _!=null_ check but
> some do not have. In this issue we post a patch which can add !=null based
> on existed !=null check. For example:
> Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8
> callers, 6 of the caller have null checker like:
> {code:java}
> List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw,
> zkw.znodePaths.rsZNode);
> if (children == null) {
> return Collections.emptyList();
> }
> {code}
> but another two callers do not have null
> checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures.
>
> We attach the patch to fix this problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20419) Two Potential NPE
[
https://issues.apache.org/jira/browse/HBASE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-20419:
--
Description:
We have developed a static analysis tool
[NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential
NPE. Our analysis shows that some callees may return null in corner case(e.g.
node crash , IO exception), some of their callers have _!=null_ check but some
do not have. For example:
Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8
callers, 6 of the caller have null checker like:
{code:java}
List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw,
zkw.znodePaths.rsZNode);
if (children == null) {
return Collections.emptyList();
}
{code}
but another two callers do not have null
checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures.
We attach the patch to fix this problem.
was:
We have developed a static analysis tool
[NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential
NPE. Our analysis shows that some callees may return null in corner case(e.g.
node crash , IO exception), some of their callers have _!=null_ check but some
do not have. In this issue we post a patch which can add !=null based on
existed !=null check. For example:
Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8
callers, 6 of the caller have null checker like:
{code:java}
List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw,
zkw.znodePaths.rsZNode);
if (children == null) {
return Collections.emptyList();
}
{code}
but another two callers do not have null
checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures.
We attach the patch to fix this problem.
> Two Potential NPE
> --
>
> Key: HBASE-20419
> URL: https://issues.apache.org/jira/browse/HBASE-20419
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0-beta-2
>Reporter: lujie
>Priority: Major
> Attachments: HBASE-20419_1.patch
>
>
> We have developed a static analysis tool
> [NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential
> NPE. Our analysis shows that some callees may return null in corner case(e.g.
> node crash , IO exception), some of their callers have _!=null_ check but
> some do not have. For example:
> Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8
> callers, 6 of the caller have null checker like:
> {code:java}
> List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw,
> zkw.znodePaths.rsZNode);
> if (children == null) {
> return Collections.emptyList();
> }
> {code}
> but another two callers do not have null
> checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures.
>
> We attach the patch to fix this problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-20420) Fix Some Potential NPE
lujie created HBASE-20420: - Summary: Fix Some Potential NPE Key: HBASE-20420 URL: https://issues.apache.org/jira/browse/HBASE-20420 Project: HBase Issue Type: Bug Affects Versions: 2.0.0-beta-2 Reporter: lujie Attachments: hbase-20420.patch We have used the tool [NPEDetector|https://github.com/lujiefsi/NPEDetector] find another six problems that similar to HBASE-20419. list here and attach the patch. CommonFSUtils#listStatus RSGroupInfoManagerImpl#getRSGroupOfServer BackupSystemTable#readBackupInfo SnapshotManifest#getRegionManifestsMap HRegionFileSystem#getFamilies Result#getFamilyMap -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20420) Fix Some Potential NPE
[ https://issues.apache.org/jira/browse/HBASE-20420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-20420: -- Status: Patch Available (was: Open) > Fix Some Potential NPE > --- > > Key: HBASE-20420 > URL: https://issues.apache.org/jira/browse/HBASE-20420 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-beta-2 >Reporter: lujie >Priority: Major > Attachments: hbase-20420.patch > > > We have used the tool [NPEDetector|https://github.com/lujiefsi/NPEDetector] > find another six problems that similar to HBASE-20419. > list here and attach the patch. > CommonFSUtils#listStatus > RSGroupInfoManagerImpl#getRSGroupOfServer > BackupSystemTable#readBackupInfo > SnapshotManifest#getRegionManifestsMap > HRegionFileSystem#getFamilies > Result#getFamilyMap -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20420) Fix Some Potential NPE
[ https://issues.apache.org/jira/browse/HBASE-20420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-20420: -- Attachment: hbase-20420.patch > Fix Some Potential NPE > --- > > Key: HBASE-20420 > URL: https://issues.apache.org/jira/browse/HBASE-20420 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-beta-2 >Reporter: lujie >Priority: Major > Attachments: hbase-20420.patch > > > We have used the tool [NPEDetector|https://github.com/lujiefsi/NPEDetector] > find another six problems that similar to HBASE-20419. > list here and attach the patch. > CommonFSUtils#listStatus > RSGroupInfoManagerImpl#getRSGroupOfServer > BackupSystemTable#readBackupInfo > SnapshotManifest#getRegionManifestsMap > HRegionFileSystem#getFamilies > Result#getFamilyMap -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20419) Two Potential NPE
[
https://issues.apache.org/jira/browse/HBASE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-20419:
--
Status: Patch Available (was: Open)
> Two Potential NPE
> --
>
> Key: HBASE-20419
> URL: https://issues.apache.org/jira/browse/HBASE-20419
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0-beta-2
>Reporter: lujie
>Priority: Major
> Attachments: HBASE-20419_1.patch
>
>
> Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8
> callers, 6 of the caller have null checker like:
> {code:java}
> List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw,
> zkw.znodePaths.rsZNode);
> if (children == null) {
> return Collections.emptyList();
> }
> {code}
> but another two callers do not have null
> checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures.
>
> We attach the patch to fix this probelm.(We found this bug by tool
> [NPEDetector|https://github.com/lujiefsi/NPEDetector])
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20419) Two Potential NPE
[
https://issues.apache.org/jira/browse/HBASE-20419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-20419:
--
Attachment: HBASE-20419_1.patch
> Two Potential NPE
> --
>
> Key: HBASE-20419
> URL: https://issues.apache.org/jira/browse/HBASE-20419
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0-beta-2
>Reporter: lujie
>Priority: Major
> Attachments: HBASE-20419_1.patch
>
>
> Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8
> callers, 6 of the caller have null checker like:
> {code:java}
> List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw,
> zkw.znodePaths.rsZNode);
> if (children == null) {
> return Collections.emptyList();
> }
> {code}
> but another two callers do not have null
> checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures.
>
> We attach the patch to fix this probelm.(We found this bug by tool
> [NPEDetector|https://github.com/lujiefsi/NPEDetector])
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-20419) Two Potential NPE
lujie created HBASE-20419:
-
Summary: Two Potential NPE
Key: HBASE-20419
URL: https://issues.apache.org/jira/browse/HBASE-20419
Project: HBase
Issue Type: Bug
Affects Versions: 2.0.0-beta-2
Reporter: lujie
Attachments: HBASE-20419_1.patch
Callee ZKUtil#listChildrenAndWatchForNewChildren may return null, it has 8
callers, 6 of the caller have null checker like:
{code:java}
List children = ZKUtil.listChildrenAndWatchForNewChildren(zkw,
zkw.znodePaths.rsZNode);
if (children == null) {
return Collections.emptyList();
}
{code}
but another two callers do not have null
checker:RSGroupInfoManagerImpl#retrieveGroupListFromZookeeper,ZKProcedureMemberRpcs#watchForAbortedProcedures.
We attach the patch to fix this probelm.(We found this bug by tool
[NPEDetector|https://github.com/lujiefsi/NPEDetector])
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20388) nightly tests running on a feature branch should only comment on that feature branch's jira
[
https://issues.apache.org/jira/browse/HBASE-20388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438676#comment-16438676
]
Hudson commented on HBASE-20388:
Results for branch HBASE-20388
[build #8 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20388/8/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20388/8//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20388/8//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20388/8//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> nightly tests running on a feature branch should only comment on that feature
> branch's jira
> ---
>
> Key: HBASE-20388
> URL: https://issues.apache.org/jira/browse/HBASE-20388
> Project: HBase
> Issue Type: Improvement
> Components: community, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-20388.0.patch, HBASE-20388.1.patch,
> HBASE-20388.2.patch
>
>
> It would help improve our signal-to-noise ratio from nightly tests if feature
> branch runs stopped commenting on all the jiras that got covered by a rebase
> / merge.
> should be straight forward to have the commenting bit check the current
> branch against our feature branch naming convention.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20364) nightly job gives old results or no results for stages that timeout on SCM
[
https://issues.apache.org/jira/browse/HBASE-20364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438656#comment-16438656
]
Hudson commented on HBASE-20364:
Results for branch branch-1
[build #284 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/284/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/284//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/284//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/284//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> nightly job gives old results or no results for stages that timeout on SCM
> --
>
> Key: HBASE-20364
> URL: https://issues.apache.org/jira/browse/HBASE-20364
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 2.1.0, 1.5.0, 1.2.7, 1.3.3, 1.4.4, 2.0.1
>
> Attachments: HBASE-20364.0.patch
>
>
> seen in the branch-2.0 nightly report for HBASE-18828:
>
> {quote}
> Results for branch branch-2.0
> [build #143 on
> builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/143/]:
> (x) *\{color:red}-1 overall\{color}*
>
> details (if available):
> (/) \{color:green}+1 general checks\{color}
> -- For more information [see general
> report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/140//General_Nightly_Build_Report/]
>
> (/) \{color:green}+1 jdk8 hadoop2 checks\{color}
> -- For more information [see jdk8 (hadoop2)
> report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/143//JDK8_Nightly_Build_Report_(Hadoop2)/]
> (/) \{color:green}+1 jdk8 hadoop3 checks\{color}
> -- For more information [see jdk8 (hadoop3)
> report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/143//JDK8_Nightly_Build_Report_(Hadoop3)/]
>
> {quote}
>
> -1 for the overall build was correct. build #143 failed both the general
> check and the source tarball check.
>
> but in the posted comment, we get a false "passing" that links to the general
> result from build #140. and we get no result for the source tarball at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20415) branches-2 don't need maven-scala-plugin
[
https://issues.apache.org/jira/browse/HBASE-20415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438653#comment-16438653
]
Hudson commented on HBASE-20415:
Results for branch branch-2.0
[build #179 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/179/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/179//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/179//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/179//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> branches-2 don't need maven-scala-plugin
>
>
> Key: HBASE-20415
> URL: https://issues.apache.org/jira/browse/HBASE-20415
> Project: HBase
> Issue Type: Task
> Components: build
>Affects Versions: 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 2.1.0, 2.0.1
>
> Attachments: HBASE-20415-branch-2.v0.patch
>
>
> the spark support revert missed a couple of plugins in the top level pom for
> making sure we get scaladocs.
> verified there is no scala in the source tree, so these plugins aren't needed.
> {code}
> hbase $ find . -name '*.scala'
> hbase $
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20364) nightly job gives old results or no results for stages that timeout on SCM
[
https://issues.apache.org/jira/browse/HBASE-20364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438654#comment-16438654
]
Hudson commented on HBASE-20364:
Results for branch branch-2.0
[build #179 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/179/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/179//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/179//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/179//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> nightly job gives old results or no results for stages that timeout on SCM
> --
>
> Key: HBASE-20364
> URL: https://issues.apache.org/jira/browse/HBASE-20364
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 2.1.0, 1.5.0, 1.2.7, 1.3.3, 1.4.4, 2.0.1
>
> Attachments: HBASE-20364.0.patch
>
>
> seen in the branch-2.0 nightly report for HBASE-18828:
>
> {quote}
> Results for branch branch-2.0
> [build #143 on
> builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/143/]:
> (x) *\{color:red}-1 overall\{color}*
>
> details (if available):
> (/) \{color:green}+1 general checks\{color}
> -- For more information [see general
> report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/140//General_Nightly_Build_Report/]
>
> (/) \{color:green}+1 jdk8 hadoop2 checks\{color}
> -- For more information [see jdk8 (hadoop2)
> report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/143//JDK8_Nightly_Build_Report_(Hadoop2)/]
> (/) \{color:green}+1 jdk8 hadoop3 checks\{color}
> -- For more information [see jdk8 (hadoop3)
> report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/143//JDK8_Nightly_Build_Report_(Hadoop3)/]
>
> {quote}
>
> -1 for the overall build was correct. build #143 failed both the general
> check and the source tarball check.
>
> but in the posted comment, we get a false "passing" that links to the general
> result from build #140. and we get no result for the source tarball at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20364) nightly job gives old results or no results for stages that timeout on SCM
[
https://issues.apache.org/jira/browse/HBASE-20364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438651#comment-16438651
]
Hudson commented on HBASE-20364:
Results for branch branch-2
[build #616 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/616/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/616//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/616//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/616//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> nightly job gives old results or no results for stages that timeout on SCM
> --
>
> Key: HBASE-20364
> URL: https://issues.apache.org/jira/browse/HBASE-20364
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 2.1.0, 1.5.0, 1.2.7, 1.3.3, 1.4.4, 2.0.1
>
> Attachments: HBASE-20364.0.patch
>
>
> seen in the branch-2.0 nightly report for HBASE-18828:
>
> {quote}
> Results for branch branch-2.0
> [build #143 on
> builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/143/]:
> (x) *\{color:red}-1 overall\{color}*
>
> details (if available):
> (/) \{color:green}+1 general checks\{color}
> -- For more information [see general
> report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/140//General_Nightly_Build_Report/]
>
> (/) \{color:green}+1 jdk8 hadoop2 checks\{color}
> -- For more information [see jdk8 (hadoop2)
> report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/143//JDK8_Nightly_Build_Report_(Hadoop2)/]
> (/) \{color:green}+1 jdk8 hadoop3 checks\{color}
> -- For more information [see jdk8 (hadoop3)
> report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/143//JDK8_Nightly_Build_Report_(Hadoop3)/]
>
> {quote}
>
> -1 for the overall build was correct. build #143 failed both the general
> check and the source tarball check.
>
> but in the posted comment, we get a false "passing" that links to the general
> result from build #140. and we get no result for the source tarball at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20415) branches-2 don't need maven-scala-plugin
[
https://issues.apache.org/jira/browse/HBASE-20415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438650#comment-16438650
]
Hudson commented on HBASE-20415:
Results for branch branch-2
[build #616 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/616/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/616//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/616//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/616//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> branches-2 don't need maven-scala-plugin
>
>
> Key: HBASE-20415
> URL: https://issues.apache.org/jira/browse/HBASE-20415
> Project: HBase
> Issue Type: Task
> Components: build
>Affects Versions: 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 2.1.0, 2.0.1
>
> Attachments: HBASE-20415-branch-2.v0.patch
>
>
> the spark support revert missed a couple of plugins in the top level pom for
> making sure we get scaladocs.
> verified there is no scala in the source tree, so these plugins aren't needed.
> {code}
> hbase $ find . -name '*.scala'
> hbase $
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20390) IMC Default Parameters for 2.0.0
[ https://issues.apache.org/jira/browse/HBASE-20390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eshcar Hillel updated HBASE-20390: -- Release Note: Changing in-memory compaction (IMC) defaults: (1) active segment is 2% of entire memstore (hbase.memstore.inmemoryflush.threshold.factor), (2) number of segments in compaction pipeline is 2 (hbase.hregion.compacting.pipeline.segments.limit) Status: Patch Available (was: Open) > IMC Default Parameters for 2.0.0 > > > Key: HBASE-20390 > URL: https://issues.apache.org/jira/browse/HBASE-20390 > Project: HBase > Issue Type: Sub-task >Reporter: Eshcar Hillel >Assignee: Eshcar Hillel >Priority: Major > Attachments: HBASE-20390-branch-2.0-01.patch > > > Setting new default parameters for in-memory compaction based on performance > tests done in HBASE-20188 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20390) IMC Default Parameters for 2.0.0
[ https://issues.apache.org/jira/browse/HBASE-20390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eshcar Hillel updated HBASE-20390: -- Attachment: HBASE-20390-branch-2.0-01.patch > IMC Default Parameters for 2.0.0 > > > Key: HBASE-20390 > URL: https://issues.apache.org/jira/browse/HBASE-20390 > Project: HBase > Issue Type: Sub-task >Reporter: Eshcar Hillel >Assignee: Eshcar Hillel >Priority: Major > Attachments: HBASE-20390-branch-2.0-01.patch > > > Setting new default parameters for in-memory compaction based on performance > tests done in HBASE-20188 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20409) Set hbase.client.meta.operation.timeout in TestClientOperationTimeout
[ https://issues.apache.org/jira/browse/HBASE-20409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-20409: -- Resolution: Fixed Fix Version/s: 2.0.0 2.1.0 3.0.0 Status: Resolved (was: Patch Available) Thanks for the review [~yuzhih...@gmail.com]! Pushed to branch-2.0+ > Set hbase.client.meta.operation.timeout in TestClientOperationTimeout > - > > Key: HBASE-20409 > URL: https://issues.apache.org/jira/browse/HBASE-20409 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 3.0.0, 2.1.0, 2.0.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Trivial > Fix For: 3.0.0, 2.1.0, 2.0.0 > > Attachments: HBASE-20409.master.001.patch > > > In TestClientOperationTimeout the hbase.client.meta.operation.timeout > property is not, so default value is used which is 120ms. The test > finishes earlier if we set the timeout to match with > hbase.client.meta.operation.timeout. > Since the first call will go to META table where the default timeout is used. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20388) nightly tests running on a feature branch should only comment on that feature branch's jira
[ https://issues.apache.org/jira/browse/HBASE-20388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438605#comment-16438605 ] Sean Busbey commented on HBASE-20388: - [builde #8|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20388/8/] is running now. it should have two new commits attributed to HBASE-20418. > nightly tests running on a feature branch should only comment on that feature > branch's jira > --- > > Key: HBASE-20388 > URL: https://issues.apache.org/jira/browse/HBASE-20388 > Project: HBase > Issue Type: Improvement > Components: community, test >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Attachments: HBASE-20388.0.patch, HBASE-20388.1.patch, > HBASE-20388.2.patch > > > It would help improve our signal-to-noise ratio from nightly tests if feature > branch runs stopped commenting on all the jiras that got covered by a rebase > / merge. > should be straight forward to have the commenting bit check the current > branch against our feature branch naming convention. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20388) nightly tests running on a feature branch should only comment on that feature branch's jira
[ https://issues.apache.org/jira/browse/HBASE-20388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438604#comment-16438604 ] Sean Busbey commented on HBASE-20388: - build #7 started before I pushed the additional commits, so it also shows an empty changeset. > nightly tests running on a feature branch should only comment on that feature > branch's jira > --- > > Key: HBASE-20388 > URL: https://issues.apache.org/jira/browse/HBASE-20388 > Project: HBase > Issue Type: Improvement > Components: community, test >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Attachments: HBASE-20388.0.patch, HBASE-20388.1.patch, > HBASE-20388.2.patch > > > It would help improve our signal-to-noise ratio from nightly tests if feature > branch runs stopped commenting on all the jiras that got covered by a rebase > / merge. > should be straight forward to have the commenting bit check the current > branch against our feature branch naming convention. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20388) nightly tests running on a feature branch should only comment on that feature branch's jira
[
https://issues.apache.org/jira/browse/HBASE-20388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438603#comment-16438603
]
Hudson commented on HBASE-20388:
Results for branch HBASE-20388
[build #7 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20388/7/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20388/7//console].
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20388/7//console].
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> nightly tests running on a feature branch should only comment on that feature
> branch's jira
> ---
>
> Key: HBASE-20388
> URL: https://issues.apache.org/jira/browse/HBASE-20388
> Project: HBase
> Issue Type: Improvement
> Components: community, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-20388.0.patch, HBASE-20388.1.patch,
> HBASE-20388.2.patch
>
>
> It would help improve our signal-to-noise ratio from nightly tests if feature
> branch runs stopped commenting on all the jiras that got covered by a rebase
> / merge.
> should be straight forward to have the commenting bit check the current
> branch against our feature branch naming convention.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-20418) placeholder issue to verify jira comments (or lack thereof)
Sean Busbey created HBASE-20418: --- Summary: placeholder issue to verify jira comments (or lack thereof) Key: HBASE-20418 URL: https://issues.apache.org/jira/browse/HBASE-20418 Project: HBase Issue Type: Task Reporter: Sean Busbey Assignee: Sean Busbey placeholder to verify if jenkins jobs post comments here. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20388) nightly tests running on a feature branch should only comment on that feature branch's jira
[ https://issues.apache.org/jira/browse/HBASE-20388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-20388: Status: Patch Available (was: In Progress) -v2 - fix type signature on our helper method for getting jira keys if you look at build #6 above, the changeset is empty so the jira to comment on must be the branch checking path (and the console output lines up). I'll push some dummy commits to the branch next and (hopefully) we'll see it comment here and nowhere else. > nightly tests running on a feature branch should only comment on that feature > branch's jira > --- > > Key: HBASE-20388 > URL: https://issues.apache.org/jira/browse/HBASE-20388 > Project: HBase > Issue Type: Improvement > Components: community, test >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Attachments: HBASE-20388.0.patch, HBASE-20388.1.patch, > HBASE-20388.2.patch > > > It would help improve our signal-to-noise ratio from nightly tests if feature > branch runs stopped commenting on all the jiras that got covered by a rebase > / merge. > should be straight forward to have the commenting bit check the current > branch against our feature branch naming convention. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20388) nightly tests running on a feature branch should only comment on that feature branch's jira
[ https://issues.apache.org/jira/browse/HBASE-20388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-20388: Attachment: HBASE-20388.2.patch > nightly tests running on a feature branch should only comment on that feature > branch's jira > --- > > Key: HBASE-20388 > URL: https://issues.apache.org/jira/browse/HBASE-20388 > Project: HBase > Issue Type: Improvement > Components: community, test >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Attachments: HBASE-20388.0.patch, HBASE-20388.1.patch, > HBASE-20388.2.patch > > > It would help improve our signal-to-noise ratio from nightly tests if feature > branch runs stopped commenting on all the jiras that got covered by a rebase > / merge. > should be straight forward to have the commenting bit check the current > branch against our feature branch naming convention. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty
[
https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20404:
Status: Patch Available (was: In Progress)
-v2
- CleanerChore was incorrectly treating IOE in FileStatus listing as
"directory not found"
- update javadocs in CleanerChore helper to match FSUtils method it invokes
- update CleanerChore to treat IOE in status listing as a failure
- check for {{PathIsNotEmptyDirectoryException}} when we expect dirs might
not be empty, and only output a small DEBUG message in that case.
- for other IOE while deleting, do the full stacktrace but work at INFO
instead of WARN.
- add tests to cover the above.
> Ugly cleanerchore complaint that dir is not empty
> -
>
> Key: HBASE-20404
> URL: https://issues.apache.org/jira/browse/HBASE-20404
> Project: HBase
> Issue Type: Bug
> Components: master
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-20404.0.patch, HBASE-20404.1.patch,
> HBASE-20404.2.patch
>
>
> I see these big dirty exceptions in my master log during a long-run Lets
> clean them up (Are they exceptions I as an operator can actually do something
> about? Are they 'problems'? Should they be LOG.warn?)
> {code}
> 2018-04-12 16:02:09,911 WARN [ForkJoinPool-1-worker-15]
> cleaner.CleanerChore: Could not delete dir under
> hdfs://ve0524.halxg.cloudera.com:8020/hbase/archive/data/default/IntegrationTestBigLinkedList/1e24549061df3adc4858fbcaf1929553/meta;
> {}
> org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.fs.PathIsNotEmptyDirectoryException):
>
> `/hbase/archive/data/default/IntegrationTestBigLinkedList/1e24549061df3adc4858fbcaf1929553/meta
> is non empty': Directory is not empty
> at
> org.apache.hadoop.hdfs.server.namenode.FSDirDeleteOp.delete(FSDirDeleteOp.java:115)
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.delete(FSNamesystem.java:2848)
> at
> org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.delete(NameNodeRpcServer.java:1048)
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.delete(ClientNamenodeProtocolServerSideTranslatorPB.java:641)
> at
> org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:447)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:989)
> at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:847)
> at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:790)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1836)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2486)
> at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1489)
> at org.apache.hadoop.ipc.Client.call(Client.java:1435)
> at org.apache.hadoop.ipc.Client.call(Client.java:1345)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:227)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:116)
> at com.sun.proxy.$Proxy26.delete(Unknown Source)
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.delete(ClientNamenodeProtocolTranslatorPB.java:568)
> at sun.reflect.GeneratedMethodAccessor28.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:409)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:163)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:155)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:346)
> at com.sun.proxy.$Proxy27.delete(Unknown Source)
> at sun.reflect.GeneratedMethodAccessor28.invoke(Unknown Source)
> ...
> {code}
> Looks like log format is off too...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20335) nightly jobs no longer contain machine information
[
https://issues.apache.org/jira/browse/HBASE-20335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438599#comment-16438599
]
Hudson commented on HBASE-20335:
Results for branch HBASE-20335
[build #5 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20335/5/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20335/5//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20335/5//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20335/5//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> nightly jobs no longer contain machine information
> --
>
> Key: HBASE-20335
> URL: https://issues.apache.org/jira/browse/HBASE-20335
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 2.1.0, 1.5.0, 1.2.7, 1.3.3, 1.4.4, 2.0.1
>
> Attachments: HBASE-20335.0.patch, HBASE-20335.1.patch
>
>
> something is up with nightly jobs. they no longer have the machine
> information from HBASE-19228.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty
[
https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20404:
Attachment: HBASE-20404.2.patch
> Ugly cleanerchore complaint that dir is not empty
> -
>
> Key: HBASE-20404
> URL: https://issues.apache.org/jira/browse/HBASE-20404
> Project: HBase
> Issue Type: Bug
> Components: master
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-20404.0.patch, HBASE-20404.1.patch,
> HBASE-20404.2.patch
>
>
> I see these big dirty exceptions in my master log during a long-run Lets
> clean them up (Are they exceptions I as an operator can actually do something
> about? Are they 'problems'? Should they be LOG.warn?)
> {code}
> 2018-04-12 16:02:09,911 WARN [ForkJoinPool-1-worker-15]
> cleaner.CleanerChore: Could not delete dir under
> hdfs://ve0524.halxg.cloudera.com:8020/hbase/archive/data/default/IntegrationTestBigLinkedList/1e24549061df3adc4858fbcaf1929553/meta;
> {}
> org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.fs.PathIsNotEmptyDirectoryException):
>
> `/hbase/archive/data/default/IntegrationTestBigLinkedList/1e24549061df3adc4858fbcaf1929553/meta
> is non empty': Directory is not empty
> at
> org.apache.hadoop.hdfs.server.namenode.FSDirDeleteOp.delete(FSDirDeleteOp.java:115)
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.delete(FSNamesystem.java:2848)
> at
> org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.delete(NameNodeRpcServer.java:1048)
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.delete(ClientNamenodeProtocolServerSideTranslatorPB.java:641)
> at
> org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:447)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:989)
> at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:847)
> at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:790)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1836)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2486)
> at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1489)
> at org.apache.hadoop.ipc.Client.call(Client.java:1435)
> at org.apache.hadoop.ipc.Client.call(Client.java:1345)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:227)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:116)
> at com.sun.proxy.$Proxy26.delete(Unknown Source)
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.delete(ClientNamenodeProtocolTranslatorPB.java:568)
> at sun.reflect.GeneratedMethodAccessor28.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:409)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:163)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:155)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:346)
> at com.sun.proxy.$Proxy27.delete(Unknown Source)
> at sun.reflect.GeneratedMethodAccessor28.invoke(Unknown Source)
> ...
> {code}
> Looks like log format is off too...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20128) Add new UTs which extends the old replication UTs but set replication scope to SERIAL
[ https://issues.apache.org/jira/browse/HBASE-20128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438595#comment-16438595 ] Zheng Hu commented on HBASE-20128: -- I was thinking about that there was a bug existed in serial replication, only just have to increase the sleep time of replication in UT actually. So upload patch.v6 to check hadoop QA again. > Add new UTs which extends the old replication UTs but set replication scope > to SERIAL > - > > Key: HBASE-20128 > URL: https://issues.apache.org/jira/browse/HBASE-20128 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Zheng Hu >Priority: Major > Attachments: HBASE-20128.v1.patch, HBASE-20128.v2.patch, > HBASE-20128.v3.patch, HBASE-20128.v3.patch, HBASE-20128.v4.patch, > HBASE-20128.v5.patch, HBASE-20128.v5.patch, HBASE-20128.v6.patch > > > Make sure that the basic function for replicationstill works. The serial > replication UTs are focused on order. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20128) Add new UTs which extends the old replication UTs but set replication scope to SERIAL
[ https://issues.apache.org/jira/browse/HBASE-20128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu updated HBASE-20128: - Attachment: HBASE-20128.v6.patch > Add new UTs which extends the old replication UTs but set replication scope > to SERIAL > - > > Key: HBASE-20128 > URL: https://issues.apache.org/jira/browse/HBASE-20128 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Zheng Hu >Priority: Major > Attachments: HBASE-20128.v1.patch, HBASE-20128.v2.patch, > HBASE-20128.v3.patch, HBASE-20128.v3.patch, HBASE-20128.v4.patch, > HBASE-20128.v5.patch, HBASE-20128.v5.patch, HBASE-20128.v6.patch > > > Make sure that the basic function for replicationstill works. The serial > replication UTs are focused on order. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
