[GitHub] [hbase] Apache-HBase commented on issue #315: HBASE-22594 Clean up for backup examples

2019-07-22 Thread GitBox
Apache-HBase commented on issue #315: HBASE-22594 Clean up for backup examples
URL: https://github.com/apache/hbase/pull/315#issuecomment-514075344
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 40 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 21 | Maven dependency ordering for branch |
   | +1 | mvninstall | 238 | master passed |
   | +1 | compile | 60 | master passed |
   | +1 | checkstyle | 136 | master passed |
   | +1 | shadedjars | 258 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 42 | master passed |
   | 0 | spotbugs | 250 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | 0 | findbugs | 11 | branch/hbase-checkstyle no findbugs output file 
(findbugsXml.xml) |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 13 | Maven dependency ordering for patch |
   | +1 | mvninstall | 238 | the patch passed |
   | +1 | compile | 61 | the patch passed |
   | +1 | javac | 61 | the patch passed |
   | +1 | checkstyle | 139 | root: The patch generated 0 new + 1 unchanged - 25 
fixed = 1 total (was 26) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | xml | 2 | The patch has no ill-formed XML file. |
   | +1 | shadedjars | 258 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 712 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 46 | the patch passed |
   | 0 | findbugs | 11 | hbase-checkstyle has no data from findbugs |
   ||| _ Other Tests _ |
   | +1 | unit | 11 | hbase-checkstyle in the patch passed. |
   | -1 | unit | 8368 | hbase-server in the patch failed. |
   | +1 | asflicense | 46 | The patch does not generate ASF License warnings. |
   | | | 11524 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.wal.TestWALOpenAfterDNRollingStart |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-315/19/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/315 |
   | Optional Tests | dupname asflicense checkstyle javac javadoc unit xml 
spotbugs findbugs shadedjars hadoopcheck hbaseanti compile |
   | uname | Linux dccd59ed2bfe 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-315/out/precommit/personality/provided.sh
 |
   | git revision | master / 06f5c43de3 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-315/19/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-315/19/testReport/
 |
   | Max. process+thread count | 4402 (vs. ulimit of 1) |
   | modules | C: hbase-checkstyle hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-315/19/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-17992) The snapShot TimeoutException causes the cleanerChore thread to fail to complete the archive correctly

2019-07-22 Thread Arwin S Tio (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890705#comment-16890705
 ] 

Arwin S Tio commented on HBASE-17992:
-

Hi all,

If you get a TimeoutException when restoring a snapshot, is that safe to 
ignore? Doesn't that mean that the restored snapshot has data 
loss/inconsistencies?

> The snapShot TimeoutException causes the cleanerChore thread to fail to 
> complete the archive correctly
> --
>
> Key: HBASE-17992
> URL: https://issues.apache.org/jira/browse/HBASE-17992
> Project: HBase
>  Issue Type: Bug
>  Components: snapshots
>Affects Versions: 0.98.10, 1.3.0
>Reporter: Bo Cui
>Priority: Major
> Attachments: hbase-17992-0.98.patch, hbase-17992-1.3.patch, 
> hbase-17992-master.patch, hbase-17992.patch
>
>
> The problem is that when the snapshot occurs TimeoutException  or other 
> Exceptions, there is no correct delete /hbase/.hbase-snapshot/tmp, which 
> causes the cleanerChore to fail to complete the archive correctly.
> Modifying the configuration parameter (hbase.snapshot.master.timeout.millis = 
> 60) only reduces the probability of the problem occurring.
> So the solution to the problem is: multi-Threaded exceptions or 
> TimeoutExceptions, the Main-thread must wait until all the tasks are finished 
> or canceled, the Main-thread can be cleared 
> /hbase/.hbase-snapshot/tmp/snapshotName.Otherwise the task is likely to write 
> /hbase/.hbase-snapshot/tmp/snapshotName/region - mainfest
> The problem exists in disabledTableSnapshot and enabledTableSnapshot, because 
> I'm currently using the disabledTableSnapshot, so I provide the patch of 
> disabledTableSnapshot



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache-HBase commented on issue #199: HBASE-22313 Add method to FsDelegation token to accept token kind

2019-07-22 Thread GitBox
Apache-HBase commented on issue #199: HBASE-22313 Add method to FsDelegation 
token to accept token kind
URL: https://github.com/apache/hbase/pull/199#issuecomment-514074322
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 35 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 235 | master passed |
   | +1 | compile | 52 | master passed |
   | +1 | checkstyle | 71 | master passed |
   | +1 | shadedjars | 256 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 32 | master passed |
   | 0 | spotbugs | 255 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 252 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 235 | the patch passed |
   | +1 | compile | 50 | the patch passed |
   | +1 | javac | 50 | the patch passed |
   | +1 | checkstyle | 68 | hbase-server: The patch generated 0 new + 0 
unchanged - 1 fixed = 0 total (was 1) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 257 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 720 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 31 | the patch passed |
   | +1 | findbugs | 254 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 8219 | hbase-server in the patch passed. |
   | +1 | asflicense | 21 | The patch does not generate ASF License warnings. |
   | | | 11094 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-199/19/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/199 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 7c6688ae77c3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-199/out/precommit/personality/provided.sh
 |
   | git revision | master / 06f5c43de3 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-199/19/testReport/
 |
   | Max. process+thread count | 4508 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-199/19/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22709) Add a chore thread in master to do hbck checking

2019-07-22 Thread Guanghao Zhang (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890704#comment-16890704
 ] 

Guanghao Zhang commented on HBASE-22709:


I found a bug for "Problematic Regions": the rsReports didn't remove the dead 
server's report. Will fix this in this issue. As I plan to move the 
"Problematic Regions" UI to a new hbck.jsp.

> Add a chore thread in master to do hbck checking
> 
>
> Key: HBASE-22709
> URL: https://issues.apache.org/jira/browse/HBASE-22709
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-22709.master.001.patch
>
>
> See HBASE-21965. There may have two type of failed splited/merged regions. 
> One is orphan region on filesystem. Another one is unassigned daughter 
> regions or merged regions. Plan to add a seperate hbck.jsp for them. Will add 
> more hbck problems to this UI in future.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes

2019-07-22 Thread GitBox
Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for 
org.apache.hadoop.hbase.util.ByteRangeUtils and Classes
URL: https://github.com/apache/hbase/pull/374#issuecomment-514072769
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 133 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 331 | master passed |
   | +1 | compile | 28 | master passed |
   | +1 | checkstyle | 31 | master passed |
   | +1 | shadedjars | 332 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 24 | master passed |
   | 0 | spotbugs | 63 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 60 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 299 | the patch passed |
   | +1 | compile | 27 | the patch passed |
   | +1 | javac | 27 | the patch passed |
   | +1 | checkstyle | 29 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 332 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 974 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 28 | the patch passed |
   | +1 | findbugs | 69 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 201 | hbase-common in the patch passed. |
   | +1 | asflicense | 12 | The patch does not generate ASF License warnings. |
   | | | 3332 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/5/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/374 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux bbc53801038b 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 
08:28:49 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
 |
   | git revision | master / 06f5c43de3 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/5/testReport/
 |
   | Max. process+thread count | 257 (vs. ulimit of 1) |
   | modules | C: hbase-common U: hbase-common |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/5/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22527) [hbck2] Add a master web ui to show the problematic regions

2019-07-22 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890703#comment-16890703
 ] 

Hudson commented on HBASE-22527:


Results for branch branch-2.0
[build #1781 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1781/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1781//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1781//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1781//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> [hbck2] Add a master web ui to show the problematic regions
> ---
>
> Key: HBASE-22527
> URL: https://issues.apache.org/jira/browse/HBASE-22527
> Project: HBase
>  Issue Type: Sub-task
>  Components: hbase-operator-tools, hbck2
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-22527.branch-2.0.001.patch, 
> HBASE-22527.branch-2.0.001.patch, HBASE-22527.branch-2.0.002.patch, 
> HBASE-22527.branch-2.1.001.patch, HBASE-22527.branch-2.1.002.patch, 
> HBASE-22527.branch-2.1.003.patch, HBASE-22527.master.001.patch, 
> HBASE-22527.master.002.patch, HBASE-22527.master.003.patch, 
> HBASE-22527.master.004.patch, HBASE-22527.master.addendum.patch
>
>
> On our cluster which based 2.2.0, we found one problem: there are some opened 
> regions which had wrong regionserver in meta. The regionserver is not exist. 
> We used hbck2 to fix them by the following steps.
>  # disable table
>  # bypass the stucked close region procedure (as the target regionserver is 
> not exist) and disable table procedure.
>  # setRegionState to CLOSED.
>  # setTableState to DISABLED.
>  # enable table
> We found this problem by scan the hbase:meta. I thought we should add this 
> feature to hbck2. The we can use hbck2 to find this problem. Thanks.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HBASE-16464) archive folder grows bigger and bigger due to corrupt snapshot under tmp dir

2019-07-22 Thread Arwin S Tio (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-16464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890700#comment-16890700
 ] 

Arwin S Tio commented on HBASE-16464:
-

Hello all,

We are running on an ancient version of HBase unfortunately and have run into 
this issue aswell.

[~mbertozzi] You mentioned:
{quote}my guess is that the snapshot may have timed out. TakeSnapshotHandler 
had cleaned .tmp but one RS (the one with 8e3179c388e10770eba7d35e30f2777f) was 
still doing trying to snapshot after timeout. HRegion#addRegionToSnapshot() 
writes the region-manifest you have in .tmp. and that will never be cleaned 
since TakeSnapshotHandler is already done.
{quote}
May I ask if the snapshot timeouts imply that there is data loss/inconsistency? 
i.e. if the RS completed the Snapshot after TakeSnapshotHandler cleaned up, is 
the snapshot data for that RS missing/inconsistent?

Thanks

 

> archive folder grows bigger and bigger due to corrupt snapshot under tmp dir
> 
>
> Key: HBASE-16464
> URL: https://issues.apache.org/jira/browse/HBASE-16464
> Project: HBase
>  Issue Type: Bug
>  Components: snapshots
>Affects Versions: 1.1.1
>Reporter: Heng Chen
>Assignee: Heng Chen
>Priority: Major
>  Labels: reviewed
> Fix For: 1.3.0, 1.1.6, 1.2.3, 0.98.22, 2.0.0
>
> Attachments: HBASE-16464-branch-1.1.patch, HBASE-16464.patch, 
> HBASE-16464.v1.patch, HBASE-16464.v1.patch
>
>
> We met the problem on our real production cluster,  we need to cleanup some 
> data on hbase,  we notice the archive folder is much larger than others,  so 
> we delete all snapshots of all tables,  but the archive folder still grows 
> bigger and bigger. 
> After check the hmaster log, we notice the exception below:
> {code}
> 2016-08-22 15:34:33,089 ERROR [f04,16000,1471240833208_ChoreService_1] 
> snapshot.SnapshotHFileCleaner: Exception while checking if files were valid, 
> keeping them just in case.
> org.apache.hadoop.hbase.snapshot.CorruptedSnapshotException: Couldn't read 
> snapshot info 
> from:hdfs://f04/hbase/.hbase-snapshot/.tmp/frog_stastic_2016-08-17/.snapshotinfo
> at 
> org.apache.hadoop.hbase.snapshot.SnapshotDescriptionUtils.readSnapshotInfo(SnapshotDescriptionUtils.java:295)
> at 
> org.apache.hadoop.hbase.snapshot.SnapshotReferenceUtil.getHFileNames(SnapshotReferenceUtil.java:328)
> at 
> org.apache.hadoop.hbase.master.snapshot.SnapshotHFileCleaner$1.filesUnderSnapshot(SnapshotHFileCleaner.java:85)
> at 
> org.apache.hadoop.hbase.master.snapshot.SnapshotFileCache.getSnapshotsInProgress(SnapshotFileCache.java:303)
> at 
> org.apache.hadoop.hbase.master.snapshot.SnapshotFileCache.getUnreferencedFiles(SnapshotFileCache.java:194)
> at 
> org.apache.hadoop.hbase.master.snapshot.SnapshotHFileCleaner.getDeletableFiles(SnapshotHFileCleaner.java:62)
> at 
> org.apache.hadoop.hbase.master.cleaner.CleanerChore.checkAndDeleteFiles(CleanerChore.java:233)
> at 
> org.apache.hadoop.hbase.master.cleaner.CleanerChore.checkAndDeleteEntries(CleanerChore.java:157)
> at 
> org.apache.hadoop.hbase.master.cleaner.CleanerChore.checkAndDeleteDirectory(CleanerChore.java:180)
> at 
> org.apache.hadoop.hbase.master.cleaner.CleanerChore.checkAndDeleteEntries(CleanerChore.java:149)
> at 
> org.apache.hadoop.hbase.master.cleaner.CleanerChore.checkAndDeleteDirectory(CleanerChore.java:180)
> at 
> org.apache.hadoop.hbase.master.cleaner.CleanerChore.checkAndDeleteEntries(CleanerChore.java:149)
> at 
> org.apache.hadoop.hbase.master.cleaner.CleanerChore.checkAndDeleteDirectory(CleanerChore.java:180)
> at 
> org.apache.hadoop.hbase.master.cleaner.CleanerChore.checkAndDeleteEntries(CleanerChore.java:149)
> at 
> org.apache.hadoop.hbase.master.cleaner.CleanerChore.checkAndDeleteDirectory(CleanerChore.java:180)
> at 
> org.apache.hadoop.hbase.master.cleaner.CleanerChore.checkAndDeleteEntries(CleanerChore.java:149)
> at 
> org.apache.hadoop.hbase.master.cleaner.CleanerChore.checkAndDeleteDirectory(CleanerChore.java:180)
> at 
> org.apache.hadoop.hbase.master.cleaner.CleanerChore.checkAndDeleteEntries(CleanerChore.java:149)
> at 
> org.apache.hadoop.hbase.master.cleaner.CleanerChore.chore(CleanerChore.java:124)
> at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:185)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at 
> java.util.concurrent.Schedul

[jira] [Commented] (HBASE-22709) Add a chore thread in master to do hbck checking

2019-07-22 Thread Guanghao Zhang (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890698#comment-16890698
 ] 

Guanghao Zhang commented on HBASE-22709:


bq. Did you see suggestion of an 'adoption service' in HBASE-27145? We'd ask 
the Master to 'adopt' orphans found in HDFS (by your work here for instance).
I thought we only fix it by HBCK2 now... The master UI shows the orphan regions 
and user use HBCK2 to fix them. 

> Add a chore thread in master to do hbck checking
> 
>
> Key: HBASE-22709
> URL: https://issues.apache.org/jira/browse/HBASE-22709
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-22709.master.001.patch
>
>
> See HBASE-21965. There may have two type of failed splited/merged regions. 
> One is orphan region on filesystem. Another one is unassigned daughter 
> regions or merged regions. Plan to add a seperate hbck.jsp for them. Will add 
> more hbck problems to this UI in future.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent

2019-07-22 Thread GitBox
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of 
RSGroup idempotent
URL: https://github.com/apache/hbase/pull/387#issuecomment-514068231
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 59 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 251 | master passed |
   | +1 | compile | 22 | master passed |
   | +1 | checkstyle | 11 | master passed |
   | +1 | shadedjars | 260 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 17 | master passed |
   | 0 | spotbugs | 45 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 43 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 234 | the patch passed |
   | +1 | compile | 22 | the patch passed |
   | +1 | javac | 22 | the patch passed |
   | +1 | checkstyle | 10 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 258 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 730 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 17 | the patch passed |
   | +1 | findbugs | 47 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 621 | hbase-rsgroup in the patch passed. |
   | +1 | asflicense | 10 | The patch does not generate ASF License warnings. |
   | | | 2921 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/5/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/387 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 5bc6a38e7c81 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh
 |
   | git revision | master / 06f5c43de3 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/5/testReport/
 |
   | Max. process+thread count | 4058 (vs. ulimit of 1) |
   | modules | C: hbase-rsgroup U: hbase-rsgroup |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/5/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #384: HBASE-22603 Javadoc Warnings related to @link tag

2019-07-22 Thread GitBox
Apache-HBase commented on issue #384: HBASE-22603 Javadoc Warnings related to 
@link tag
URL: https://github.com/apache/hbase/pull/384#issuecomment-514066478
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 60 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for branch |
   | +1 | mvninstall | 329 | master passed |
   | +1 | compile | 123 | master passed |
   | +1 | checkstyle | 157 | master passed |
   | +1 | shadedjars | 354 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 80 | master passed |
   | 0 | spotbugs | 57 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 407 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | +1 | mvninstall | 304 | the patch passed |
   | +1 | compile | 116 | the patch passed |
   | +1 | javac | 116 | the patch passed |
   | +1 | checkstyle | 29 | The patch passed checkstyle in hbase-common |
   | +1 | checkstyle | 94 | hbase-server: The patch generated 0 new + 13 
unchanged - 1 fixed = 13 total (was 14) |
   | +1 | checkstyle | 19 | The patch passed checkstyle in hbase-mapreduce |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 332 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 948 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 21 | hbase-common generated 0 new + 0 unchanged - 1 fixed = 
0 total (was 1) |
   | +1 | javadoc | 37 | hbase-server in the patch passed. |
   | +1 | javadoc | 17 | hbase-mapreduce in the patch passed. |
   | +1 | findbugs | 398 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 182 | hbase-common in the patch passed. |
   | -1 | unit | 60 | hbase-server in the patch failed. |
   | +1 | unit | 1581 | hbase-mapreduce in the patch passed. |
   | +1 | asflicense | 43 | The patch does not generate ASF License warnings. |
   | | | 6146 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-384/10/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/384 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux dbb5adc5b267 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-384/out/precommit/personality/provided.sh
 |
   | git revision | master / 06f5c43de3 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-384/10/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-384/10/testReport/
 |
   | Max. process+thread count | 4771 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-server hbase-mapreduce U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-384/10/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #392: HBASE-22714 - Fix opertationTimeout typo

2019-07-22 Thread GitBox
Apache-HBase commented on issue #392: HBASE-22714 - Fix opertationTimeout typo
URL: https://github.com/apache/hbase/pull/392#issuecomment-514065729
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 52 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 252 | master passed |
   | +1 | compile | 23 | master passed |
   | +1 | checkstyle | 29 | master passed |
   | +1 | shadedjars | 262 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 20 | master passed |
   | 0 | spotbugs | 70 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 67 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 238 | the patch passed |
   | +1 | compile | 24 | the patch passed |
   | +1 | javac | 24 | the patch passed |
   | +1 | checkstyle | 28 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 285 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 729 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | -1 | javadoc | 19 | hbase-client generated 1 new + 2 unchanged - 0 fixed = 
3 total (was 2) |
   | +1 | findbugs | 73 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 98 | hbase-client in the patch passed. |
   | +1 | asflicense | 11 | The patch does not generate ASF License warnings. |
   | | | 2506 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/6/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/392 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 2702d48e5387 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-392/out/precommit/personality/provided.sh
 |
   | git revision | master / 06f5c43de3 |
   | Default Java | 1.8.0_181 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/6/artifact/out/diff-javadoc-javadoc-hbase-client.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/6/testReport/
 |
   | Max. process+thread count | 292 (vs. ulimit of 1) |
   | modules | C: hbase-client U: hbase-client |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/6/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #401: HBASE-22721 Refactor HBaseFsck: move the inner class out

2019-07-22 Thread GitBox
Apache-HBase commented on issue #401: HBASE-22721 Refactor HBaseFsck: move the 
inner class out
URL: https://github.com/apache/hbase/pull/401#issuecomment-514064656
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 39 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 4 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 244 | master passed |
   | +1 | compile | 53 | master passed |
   | +1 | checkstyle | 77 | master passed |
   | +1 | shadedjars | 275 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 33 | master passed |
   | 0 | spotbugs | 241 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 239 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 253 | the patch passed |
   | +1 | compile | 54 | the patch passed |
   | +1 | javac | 54 | the patch passed |
   | -1 | checkstyle | 75 | hbase-server: The patch generated 34 new + 174 
unchanged - 23 fixed = 208 total (was 197) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 271 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 741 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 33 | the patch passed |
   | -1 | findbugs | 242 | hbase-server generated 1 new + 0 unchanged - 0 fixed 
= 1 total (was 0) |
   ||| _ Other Tests _ |
   | +1 | unit | 7594 | hbase-server in the patch passed. |
   | +1 | asflicense | 29 | The patch does not generate ASF License warnings. |
   | | | 10583 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | FindBugs | module:hbase-server |
   |  |  Should org.apache.hadoop.hbase.util.HbckRegionInfo$OnlineEntry be a 
_static_ inner class?  At HbckRegionInfo.java:inner class?  At 
HbckRegionInfo.java:[lines 346-361] |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/401 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 9e46ed7ed251 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-401/out/precommit/personality/provided.sh
 |
   | git revision | master / fe450b50c1 |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/2/artifact/out/diff-checkstyle-hbase-server.txt
 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/2/artifact/out/new-findbugs-hbase-server.html
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/2/testReport/
 |
   | Max. process+thread count | 4267 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/2/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #237: HBASE-22408 add dead and unknown server open regions metric to AM 01

2019-07-22 Thread GitBox
Apache-HBase commented on issue #237: HBASE-22408 add dead and unknown server 
open regions metric to AM 01
URL: https://github.com/apache/hbase/pull/237#issuecomment-514063930
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 0 | Docker mode activated. |
   | -1 | patch | 10 | https://github.com/apache/hbase/pull/237 does not apply 
to master. Rebase required? Wrong Branch? See 
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for 
help. |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | GITHUB PR | https://github.com/apache/hbase/pull/237 |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-237/5/console |
   | versions | git=2.7.4 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…

2019-07-22 Thread GitBox
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts 
of TokenUtil off into a Clien…
URL: https://github.com/apache/hbase/pull/361#issuecomment-514063814
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 61 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 11 | Maven dependency ordering for branch |
   | +1 | mvninstall | 242 | master passed |
   | +1 | compile | 77 | master passed |
   | +1 | checkstyle | 105 | master passed |
   | +1 | shadedjars | 259 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 55 | master passed |
   | 0 | spotbugs | 239 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 304 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 13 | Maven dependency ordering for patch |
   | +1 | mvninstall | 238 | the patch passed |
   | -1 | compile | 36 | hbase-server in the patch failed. |
   | -1 | javac | 36 | hbase-server in the patch failed. |
   | +1 | checkstyle | 98 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 260 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 739 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 52 | the patch passed |
   | +1 | findbugs | 316 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 100 | hbase-client in the patch passed. |
   | -1 | unit | 1575 | hbase-server in the patch failed. |
   | +1 | asflicense | 23 | The patch does not generate ASF License warnings. |
   | | | 4899 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.io.hfile.TestSeekTo |
   |   | hadoop.hbase.io.hfile.TestLruBlockCache |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/15/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/361 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 9187f4337692 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
 |
   | git revision | master / 06f5c43de3 |
   | Default Java | 1.8.0_181 |
   | compile | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/15/artifact/out/patch-compile-hbase-server.txt
 |
   | javac | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/15/artifact/out/patch-compile-hbase-server.txt
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/15/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/15/testReport/
 |
   | Max. process+thread count | 695 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/15/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #238: HBASE-22410 add the notion of the expected # of servers for non-fixed server sets; report an alternative dead server metric 01

2019-07-22 Thread GitBox
Apache-HBase commented on issue #238: HBASE-22410 add the notion of the 
expected # of servers for non-fixed server sets; report an alternative dead 
server metric 01
URL: https://github.com/apache/hbase/pull/238#issuecomment-514063749
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 0 | Docker mode activated. |
   | -1 | patch | 13 | https://github.com/apache/hbase/pull/238 does not apply 
to master. Rebase required? Wrong Branch? See 
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for 
help. |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | GITHUB PR | https://github.com/apache/hbase/pull/238 |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-238/5/console |
   | versions | git=2.7.4 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #391: HBASE-22628 Document the custom WAL directory (hbase.wal.dir) usage

2019-07-22 Thread GitBox
Apache-HBase commented on issue #391: HBASE-22628 Document the custom WAL 
directory (hbase.wal.dir) usage
URL: https://github.com/apache/hbase/pull/391#issuecomment-514062868
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 57 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   ||| _ master Compile Tests _ |
   | -1 | mvninstall | 268 | root in master failed. |
   | 0 | refguide | 481 | branch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. |
   ||| _ Patch Compile Tests _ |
   | -1 | mvninstall | 235 | root in the patch failed. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | 0 | refguide | 449 | patch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. |
   ||| _ Other Tests _ |
   | +1 | asflicense | 13 | The patch does not generate ASF License warnings. |
   | | | 1561 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/5/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/391 |
   | Optional Tests | dupname asflicense refguide |
   | uname | Linux 0d4afda2c5d5 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 
13:14:43 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-391/out/precommit/personality/provided.sh
 |
   | git revision | master / 06f5c43de3 |
   | mvninstall | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/5/artifact/out/branch-mvninstall-root.txt
 |
   | refguide | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/5/artifact/out/branch-site/book.html
 |
   | mvninstall | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/5/artifact/out/patch-mvninstall-root.txt
 |
   | refguide | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/5/artifact/out/patch-site/book.html
 |
   | Max. process+thread count | 76 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/5/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Assigned] (HBASE-13621) Purge KVComparator and its related code from code base for 3.0

2019-07-22 Thread kevin su (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-13621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

kevin su reassigned HBASE-13621:


Assignee: kevin su

> Purge KVComparator and its related code from code base for 3.0
> --
>
> Key: HBASE-13621
> URL: https://issues.apache.org/jira/browse/HBASE-13621
> Project: HBase
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: ramkrishna.s.vasudevan
>Assignee: kevin su
>Priority: Blocker
>
> This is a reminder JIRA so that while moving to 3.0 we will remove all the 
> code related to KVComparator that has been deprecated in the 2.0 train.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache-HBase commented on issue #385: HBASE-22382 Refactor tests in TestFromClientSide

2019-07-22 Thread GitBox
Apache-HBase commented on issue #385: HBASE-22382 Refactor tests in 
TestFromClientSide
URL: https://github.com/apache/hbase/pull/385#issuecomment-514061164
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 108 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 310 | master passed |
   | +1 | compile | 53 | master passed |
   | +1 | checkstyle | 74 | master passed |
   | +1 | shadedjars | 263 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 34 | master passed |
   | 0 | spotbugs | 245 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 243 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 237 | the patch passed |
   | +1 | compile | 58 | the patch passed |
   | +1 | javac | 58 | the patch passed |
   | +1 | checkstyle | 74 | hbase-server: The patch generated 0 new + 48 
unchanged - 2 fixed = 48 total (was 50) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 271 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 753 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 32 | the patch passed |
   | +1 | findbugs | 248 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 1592 | hbase-server in the patch failed. |
   | +1 | asflicense | 26 | The patch does not generate ASF License warnings. |
   | | | 4681 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.regionserver.TestStoreFileScannerWithTagCompression |
   |   | hadoop.hbase.regionserver.TestHeapMemoryManager |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-385/10/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/385 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux f335ab069925 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-385/out/precommit/personality/provided.sh
 |
   | git revision | master / 06f5c43de3 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-385/10/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-385/10/testReport/
 |
   | Max. process+thread count | 695 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-385/10/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #400: HBASE-22720 Incorrect link for hbase.unittests

2019-07-22 Thread GitBox
Apache-HBase commented on issue #400: HBASE-22720 Incorrect link for 
hbase.unittests
URL: https://github.com/apache/hbase/pull/400#issuecomment-514061112
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 74 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 254 | master passed |
   | 0 | refguide | 456 | branch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 267 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | 0 | refguide | 449 | patch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. |
   ||| _ Other Tests _ |
   | +1 | asflicense | 16 | The patch does not generate ASF License warnings. |
   | | | 1572 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-400/5/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/400 |
   | Optional Tests | dupname asflicense refguide |
   | uname | Linux 152860605b84 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 
13:14:43 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-400/out/precommit/personality/provided.sh
 |
   | git revision | master / 06f5c43de3 |
   | refguide | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-400/5/artifact/out/branch-site/book.html
 |
   | refguide | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-400/5/artifact/out/patch-site/book.html
 |
   | Max. process+thread count | 96 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-400/5/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #382: HBASE-22692 Added Rubocop definition file to bin directory

2019-07-22 Thread GitBox
Apache-HBase commented on issue #382: HBASE-22692 Added Rubocop definition file 
to bin directory
URL: https://github.com/apache/hbase/pull/382#issuecomment-514060899
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 37 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | 0 | yamllint | 0 | yamllint was not available. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   ||| _ master Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   ||| _ Other Tests _ |
   | +1 | asflicense | 12 | The patch does not generate ASF License warnings. |
   | | | 96 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/5/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/382 |
   | Optional Tests | dupname asflicense yamllint |
   | uname | Linux e40b699467da 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-382/out/precommit/personality/provided.sh
 |
   | git revision | master / 06f5c43de3 |
   | Max. process+thread count | 46 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/5/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #401: HBASE-22721 Refactor HBaseFsck: move the inner class out

2019-07-22 Thread GitBox
Apache-HBase commented on issue #401: HBASE-22721 Refactor HBaseFsck: move the 
inner class out
URL: https://github.com/apache/hbase/pull/401#issuecomment-514058293
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 63 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 4 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 244 | master passed |
   | +1 | compile | 54 | master passed |
   | +1 | checkstyle | 75 | master passed |
   | +1 | shadedjars | 261 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 32 | master passed |
   | 0 | spotbugs | 242 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 241 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 247 | the patch passed |
   | +1 | compile | 55 | the patch passed |
   | +1 | javac | 55 | the patch passed |
   | -1 | checkstyle | 74 | hbase-server: The patch generated 34 new + 174 
unchanged - 23 fixed = 208 total (was 197) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 279 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 735 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 31 | the patch passed |
   | -1 | findbugs | 247 | hbase-server generated 1 new + 0 unchanged - 0 fixed 
= 1 total (was 0) |
   ||| _ Other Tests _ |
   | -1 | unit | 1571 | hbase-server in the patch failed. |
   | +1 | asflicense | 11 | The patch does not generate ASF License warnings. |
   | | | 4523 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | FindBugs | module:hbase-server |
   |  |  Should org.apache.hadoop.hbase.util.HbckRegionInfo$OnlineEntry be a 
_static_ inner class?  At HbckRegionInfo.java:inner class?  At 
HbckRegionInfo.java:[lines 346-361] |
   | Failed junit tests | hadoop.hbase.filter.TestFilter |
   |   | hadoop.hbase.client.TestAsyncAccessControlAdminApi |
   |   | hadoop.hbase.filter.TestColumnPrefixFilter |
   |   | hadoop.hbase.filter.TestFilterFromRegionSide |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/401 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux e8d5e8453b19 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-401/out/precommit/personality/provided.sh
 |
   | git revision | master / 06f5c43de3 |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/3/artifact/out/diff-checkstyle-hbase-server.txt
 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/3/artifact/out/new-findbugs-hbase-server.html
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/3/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/3/testReport/
 |
   | Max. process+thread count | 699 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/3/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22649) FileNotFoundException shown in UI when tried to access HFILE URL of a column family name have special char (e.g #)

2019-07-22 Thread Y. SREENIVASULU REDDY (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890682#comment-16890682
 ] 

Y. SREENIVASULU REDDY commented on HBASE-22649:
---

Hi [~wchevreuil], can you please review the attached patch files, and provide 
your comments

> FileNotFoundException shown in UI when tried to access HFILE URL of a column 
> family name have special char (e.g #)
> --
>
> Key: HBASE-22649
> URL: https://issues.apache.org/jira/browse/HBASE-22649
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Affects Versions: 3.0.0, 2.1.5, 1.3.5
>Reporter: Ashok shetty
>Assignee: Y. SREENIVASULU REDDY
>Priority: Major
> Fix For: 3.0.0, 2.1.6, 1.3.6
>
> Attachments: HBASE-22649.branch-1.002.patch, 
> HBASE-22649.branch-1.patch, HBASE-22649.branch-2.patch, HBASE-22649.patch
>
>
> 【Test step】:
> 1. create 'specialchar' ,'#'
> 2.put 'specialchar','r1','#:cq','1000'
> 3.flush 'specialchar'
> 4.put 'specialchar','r2','#:cq','1000'
> 5.flush 'specialchar'
>  
> Once hfile is created, click the hfile link in UI.
> The following error is throwing.
> {noformat}
> java.io.FileNotFoundException: Path is not a file: 
> /hbase/data/default/specialchar/df9d19830c562c4eeb3f8b396211d52d
>  at 
> org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:90)
>  at 
> org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:76)
>  at 
> org.apache.hadoop.hdfs.server.namenode.FSDirStatAndListingOp.getBlockLocations(FSDirStatAndListingOp.java:153)
>  at 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocations(FSNamesystem.java:1942)
>  at 
> org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.getBlockLocations(NameNodeRpcServer.java:739)
>  at 
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.getBlockLocations(ClientNamenodeProtocolServerSideTranslatorPB.java:432)
>  at 
> org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
>  at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:524)
>  at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:991)
>  at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:878)
>  at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:824)
>  at java.security.AccessController.doPrivileged(Native Method)
>  at javax.security.auth.Subject.doAs(Subject.java:422)
>  at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1729)
>  at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2684)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes

2019-07-22 Thread GitBox
Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for 
org.apache.hadoop.hbase.util.ByteRangeUtils and Classes
URL: https://github.com/apache/hbase/pull/374#issuecomment-514056058
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 58 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 247 | master passed |
   | +1 | compile | 19 | master passed |
   | +1 | checkstyle | 22 | master passed |
   | +1 | shadedjars | 260 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 18 | master passed |
   | 0 | spotbugs | 47 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 45 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 242 | the patch passed |
   | +1 | compile | 21 | the patch passed |
   | +1 | javac | 21 | the patch passed |
   | +1 | checkstyle | 22 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 254 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 740 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 18 | the patch passed |
   | +1 | findbugs | 52 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 162 | hbase-common in the patch passed. |
   | +1 | asflicense | 9 | The patch does not generate ASF License warnings. |
   | | | 2485 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/4/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/374 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux b037029ef1a6 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
 |
   | git revision | master / 06f5c43de3 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/4/testReport/
 |
   | Max. process+thread count | 287 (vs. ulimit of 1) |
   | modules | C: hbase-common U: hbase-common |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/4/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent

2019-07-22 Thread GitBox
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of 
RSGroup idempotent
URL: https://github.com/apache/hbase/pull/387#issuecomment-514056099
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 69 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 287 | master passed |
   | +1 | compile | 25 | master passed |
   | +1 | checkstyle | 12 | master passed |
   | +1 | shadedjars | 272 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 18 | master passed |
   | 0 | spotbugs | 43 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 42 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 293 | the patch passed |
   | +1 | compile | 24 | the patch passed |
   | +1 | javac | 24 | the patch passed |
   | +1 | checkstyle | 12 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 264 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 751 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 18 | the patch passed |
   | +1 | findbugs | 52 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 681 | hbase-rsgroup in the patch passed. |
   | +1 | asflicense | 11 | The patch does not generate ASF License warnings. |
   | | | 3174 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/4/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/387 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 7afc968ad102 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 
13:14:43 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh
 |
   | git revision | master / 06f5c43de3 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/4/testReport/
 |
   | Max. process+thread count | 4558 (vs. ulimit of 1) |
   | modules | C: hbase-rsgroup U: hbase-rsgroup |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/4/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #392: HBASE-22714 - Fix opertationTimeout typo

2019-07-22 Thread GitBox
Apache-HBase commented on issue #392: HBASE-22714 - Fix opertationTimeout typo
URL: https://github.com/apache/hbase/pull/392#issuecomment-514054371
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 74 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 288 | master passed |
   | +1 | compile | 24 | master passed |
   | +1 | checkstyle | 36 | master passed |
   | +1 | shadedjars | 299 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 22 | master passed |
   | 0 | spotbugs | 71 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 69 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 281 | the patch passed |
   | +1 | compile | 29 | the patch passed |
   | +1 | javac | 29 | the patch passed |
   | +1 | checkstyle | 36 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 299 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 830 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | -1 | javadoc | 22 | hbase-client generated 1 new + 2 unchanged - 0 fixed = 
3 total (was 2) |
   | +1 | findbugs | 75 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 110 | hbase-client in the patch passed. |
   | +1 | asflicense | 11 | The patch does not generate ASF License warnings. |
   | | | 2842 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/5/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/392 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 20f675b710b1 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-392/out/precommit/personality/provided.sh
 |
   | git revision | master / 06f5c43de3 |
   | Default Java | 1.8.0_181 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/5/artifact/out/diff-javadoc-javadoc-hbase-client.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/5/testReport/
 |
   | Max. process+thread count | 255 (vs. ulimit of 1) |
   | modules | C: hbase-client U: hbase-client |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/5/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #391: HBASE-22628 Document the custom WAL directory (hbase.wal.dir) usage

2019-07-22 Thread GitBox
Apache-HBase commented on issue #391: HBASE-22628 Document the custom WAL 
directory (hbase.wal.dir) usage
URL: https://github.com/apache/hbase/pull/391#issuecomment-514052424
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 80 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 339 | master passed |
   | 0 | refguide | 607 | branch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 333 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | 0 | refguide | 558 | patch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. |
   ||| _ Other Tests _ |
   | +1 | asflicense | 16 | The patch does not generate ASF License warnings. |
   | | | 1996 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/4/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/391 |
   | Optional Tests | dupname asflicense refguide |
   | uname | Linux ef1aad29fabe 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 
05:29:03 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-391/out/precommit/personality/provided.sh
 |
   | git revision | master / 06f5c43de3 |
   | refguide | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/4/artifact/out/branch-site/book.html
 |
   | refguide | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/4/artifact/out/patch-site/book.html
 |
   | Max. process+thread count | 96 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/4/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #237: HBASE-22408 add dead and unknown server open regions metric to AM 01

2019-07-22 Thread GitBox
Apache-HBase commented on issue #237: HBASE-22408 add dead and unknown server 
open regions metric to AM 01
URL: https://github.com/apache/hbase/pull/237#issuecomment-514051992
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 0 | Docker mode activated. |
   | -1 | patch | 11 | https://github.com/apache/hbase/pull/237 does not apply 
to master. Rebase required? Wrong Branch? See 
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for 
help. |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | GITHUB PR | https://github.com/apache/hbase/pull/237 |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-237/4/console |
   | versions | git=2.7.4 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #238: HBASE-22410 add the notion of the expected # of servers for non-fixed server sets; report an alternative dead server metric 01

2019-07-22 Thread GitBox
Apache-HBase commented on issue #238: HBASE-22410 add the notion of the 
expected # of servers for non-fixed server sets; report an alternative dead 
server metric 01
URL: https://github.com/apache/hbase/pull/238#issuecomment-514051862
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 0 | Docker mode activated. |
   | -1 | patch | 8 | https://github.com/apache/hbase/pull/238 does not apply 
to master. Rebase required? Wrong Branch? See 
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for 
help. |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | GITHUB PR | https://github.com/apache/hbase/pull/238 |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-238/4/console |
   | versions | git=2.7.4 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #401: HBASE-22721 Refactor HBaseFsck: move the inner class out

2019-07-22 Thread GitBox
Apache-HBase commented on issue #401: HBASE-22721 Refactor HBaseFsck: move the 
inner class out
URL: https://github.com/apache/hbase/pull/401#issuecomment-514051813
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 37 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 4 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 271 | master passed |
   | +1 | compile | 60 | master passed |
   | +1 | checkstyle | 85 | master passed |
   | +1 | shadedjars | 276 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 34 | master passed |
   | 0 | spotbugs | 227 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 225 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 249 | the patch passed |
   | +1 | compile | 53 | the patch passed |
   | +1 | javac | 53 | the patch passed |
   | -1 | checkstyle | 80 | hbase-server: The patch generated 34 new + 174 
unchanged - 23 fixed = 208 total (was 197) |
   | +1 | whitespace | 1 | The patch has no whitespace issues. |
   | +1 | shadedjars | 256 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 730 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 32 | the patch passed |
   | -1 | findbugs | 245 | hbase-server generated 1 new + 0 unchanged - 0 fixed 
= 1 total (was 0) |
   ||| _ Other Tests _ |
   | +1 | unit | 7857 | hbase-server in the patch passed. |
   | +1 | asflicense | 20 | The patch does not generate ASF License warnings. |
   | | | 10827 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | FindBugs | module:hbase-server |
   |  |  Should org.apache.hadoop.hbase.util.HbckRegionInfo$OnlineEntry be a 
_static_ inner class?  At HbckRegionInfo.java:inner class?  At 
HbckRegionInfo.java:[lines 346-361] |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/401 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 83f69176d395 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-401/out/precommit/personality/provided.sh
 |
   | git revision | master / 9615c644f5 |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/1/artifact/out/diff-checkstyle-hbase-server.txt
 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/1/artifact/out/new-findbugs-hbase-server.html
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/1/testReport/
 |
   | Max. process+thread count | 4775 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #385: HBASE-22382 Refactor tests in TestFromClientSide

2019-07-22 Thread GitBox
Apache-HBase commented on issue #385: HBASE-22382 Refactor tests in 
TestFromClientSide
URL: https://github.com/apache/hbase/pull/385#issuecomment-514051770
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 195 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 1 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 358 | master passed |
   | +1 | compile | 71 | master passed |
   | +1 | checkstyle | 98 | master passed |
   | +1 | shadedjars | 363 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 45 | master passed |
   | 0 | spotbugs | 321 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 318 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 334 | the patch passed |
   | +1 | compile | 68 | the patch passed |
   | +1 | javac | 68 | the patch passed |
   | +1 | checkstyle | 102 | hbase-server: The patch generated 0 new + 48 
unchanged - 2 fixed = 48 total (was 50) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 372 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1028 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 40 | the patch passed |
   | +1 | findbugs | 303 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 1826 | hbase-server in the patch failed. |
   | +1 | asflicense | 14 | The patch does not generate ASF License warnings. |
   | | | 5918 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.coprocessor.TestRegionCoprocessorHost |
   |   | hadoop.hbase.wal.TestWALMethods |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-385/9/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/385 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux f6fbc45f74a5 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-385/out/precommit/personality/provided.sh
 |
   | git revision | master / 0e34dcbf4b |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-385/9/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-385/9/testReport/
 |
   | Max. process+thread count | 686 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-385/9/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #400: HBASE-22720 Incorrect link for hbase.unittests

2019-07-22 Thread GitBox
Apache-HBase commented on issue #400: HBASE-22720 Incorrect link for 
hbase.unittests
URL: https://github.com/apache/hbase/pull/400#issuecomment-514050271
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 73 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 250 | master passed |
   | 0 | refguide | 464 | branch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 239 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | 0 | refguide | 463 | patch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. |
   ||| _ Other Tests _ |
   | +1 | asflicense | 17 | The patch does not generate ASF License warnings. |
   | | | 1562 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-400/4/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/400 |
   | Optional Tests | dupname asflicense refguide |
   | uname | Linux 8d5859795557 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-400/out/precommit/personality/provided.sh
 |
   | git revision | master / 06f5c43de3 |
   | refguide | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-400/4/artifact/out/branch-site/book.html
 |
   | refguide | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-400/4/artifact/out/patch-site/book.html
 |
   | Max. process+thread count | 81 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-400/4/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22610) [BucketCache] Rename "hbase.offheapcache.minblocksize"

2019-07-22 Thread Reid Chan (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890665#comment-16890665
 ] 

Reid Chan commented on HBASE-22610:
---

ping [~murtaza.hassan], please also update release notes which helps user knows 
this change.

> [BucketCache] Rename "hbase.offheapcache.minblocksize"
> --
>
> Key: HBASE-22610
> URL: https://issues.apache.org/jira/browse/HBASE-22610
> Project: HBase
>  Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Murtaza Hassan
>Priority: Trivial
>  Labels: beginner
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.4.11
>
>
> {code}
>   /**
>* The target block size used by blockcache instances. Defaults to
>* {@link HConstants#DEFAULT_BLOCKSIZE}.
>* TODO: this config point is completely wrong, as it's used to determine 
> the
>* target block size of BlockCache instances. Rename.
>*/
>   public static final String BLOCKCACHE_BLOCKSIZE_KEY = 
> "hbase.offheapcache.minblocksize";
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache-HBase commented on issue #382: HBASE-22692 Added Rubocop definition file to bin directory

2019-07-22 Thread GitBox
Apache-HBase commented on issue #382: HBASE-22692 Added Rubocop definition file 
to bin directory
URL: https://github.com/apache/hbase/pull/382#issuecomment-514049272
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 71 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | 0 | yamllint | 0 | yamllint was not available. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   ||| _ master Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   ||| _ Other Tests _ |
   | +1 | asflicense | 12 | The patch does not generate ASF License warnings. |
   | | | 130 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/4/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/382 |
   | Optional Tests | dupname asflicense yamllint |
   | uname | Linux 2d9f7bf23428 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-382/out/precommit/personality/provided.sh
 |
   | git revision | master / 06f5c43de3 |
   | Max. process+thread count | 47 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/4/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (HBASE-22610) [BucketCache] Rename "hbase.offheapcache.minblocksize"

2019-07-22 Thread Reid Chan (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan updated HBASE-22610:
--
Fix Version/s: (was: 2.1.7)
   2.1.6

> [BucketCache] Rename "hbase.offheapcache.minblocksize"
> --
>
> Key: HBASE-22610
> URL: https://issues.apache.org/jira/browse/HBASE-22610
> Project: HBase
>  Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Murtaza Hassan
>Priority: Trivial
>  Labels: beginner
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.4.11
>
>
> {code}
>   /**
>* The target block size used by blockcache instances. Defaults to
>* {@link HConstants#DEFAULT_BLOCKSIZE}.
>* TODO: this config point is completely wrong, as it's used to determine 
> the
>* target block size of BlockCache instances. Rename.
>*/
>   public static final String BLOCKCACHE_BLOCKSIZE_KEY = 
> "hbase.offheapcache.minblocksize";
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Resolved] (HBASE-22610) [BucketCache] Rename "hbase.offheapcache.minblocksize"

2019-07-22 Thread Reid Chan (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-22610.
---
  Resolution: Fixed
Hadoop Flags: Reviewed

> [BucketCache] Rename "hbase.offheapcache.minblocksize"
> --
>
> Key: HBASE-22610
> URL: https://issues.apache.org/jira/browse/HBASE-22610
> Project: HBase
>  Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Murtaza Hassan
>Priority: Trivial
>  Labels: beginner
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.4.11
>
>
> {code}
>   /**
>* The target block size used by blockcache instances. Defaults to
>* {@link HConstants#DEFAULT_BLOCKSIZE}.
>* TODO: this config point is completely wrong, as it's used to determine 
> the
>* target block size of BlockCache instances. Rename.
>*/
>   public static final String BLOCKCACHE_BLOCKSIZE_KEY = 
> "hbase.offheapcache.minblocksize";
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22610) [BucketCache] Rename "hbase.offheapcache.minblocksize"

2019-07-22 Thread Reid Chan (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan updated HBASE-22610:
--
Fix Version/s: 2.1.7
   1.4.11
   2.2.1
   2.3.0
   1.5.0
   3.0.0

> [BucketCache] Rename "hbase.offheapcache.minblocksize"
> --
>
> Key: HBASE-22610
> URL: https://issues.apache.org/jira/browse/HBASE-22610
> Project: HBase
>  Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Murtaza Hassan
>Priority: Trivial
>  Labels: beginner
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 1.4.11, 2.1.7
>
>
> {code}
>   /**
>* The target block size used by blockcache instances. Defaults to
>* {@link HConstants#DEFAULT_BLOCKSIZE}.
>* TODO: this config point is completely wrong, as it's used to determine 
> the
>* target block size of BlockCache instances. Rename.
>*/
>   public static final String BLOCKCACHE_BLOCKSIZE_KEY = 
> "hbase.offheapcache.minblocksize";
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HBASE-22610) [BucketCache] Rename "hbase.offheapcache.minblocksize"

2019-07-22 Thread Reid Chan (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890663#comment-16890663
 ] 

Reid Chan commented on HBASE-22610:
---

Pushed to master, branch-2, branch-2.2, branch-2.1, branch-1, branch-1.4

> [BucketCache] Rename "hbase.offheapcache.minblocksize"
> --
>
> Key: HBASE-22610
> URL: https://issues.apache.org/jira/browse/HBASE-22610
> Project: HBase
>  Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Murtaza Hassan
>Priority: Trivial
>  Labels: beginner
>
> {code}
>   /**
>* The target block size used by blockcache instances. Defaults to
>* {@link HConstants#DEFAULT_BLOCKSIZE}.
>* TODO: this config point is completely wrong, as it's used to determine 
> the
>* target block size of BlockCache instances. Rename.
>*/
>   public static final String BLOCKCACHE_BLOCKSIZE_KEY = 
> "hbase.offheapcache.minblocksize";
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent

2019-07-22 Thread GitBox
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of 
RSGroup idempotent
URL: https://github.com/apache/hbase/pull/387#issuecomment-514047021
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 76 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 366 | master passed |
   | +1 | compile | 31 | master passed |
   | +1 | checkstyle | 16 | master passed |
   | +1 | shadedjars | 357 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 26 | master passed |
   | 0 | spotbugs | 70 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 66 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 342 | the patch passed |
   | +1 | compile | 31 | the patch passed |
   | +1 | javac | 31 | the patch passed |
   | +1 | checkstyle | 15 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 363 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1076 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 23 | the patch passed |
   | +1 | findbugs | 62 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 874 | hbase-rsgroup in the patch passed. |
   | +1 | asflicense | 16 | The patch does not generate ASF License warnings. |
   | | | 4141 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/387 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux d44b70e1093c 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 
05:29:03 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh
 |
   | git revision | master / 0e34dcbf4b |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/3/testReport/
 |
   | Max. process+thread count | 4278 (vs. ulimit of 1) |
   | modules | C: hbase-rsgroup U: hbase-rsgroup |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/3/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (HBASE-22527) [hbck2] Add a master web ui to show the problematic regions

2019-07-22 Thread Guanghao Zhang (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-22527:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

Pushed to branch-2.0 and branch-2.1. Thanks [~stack] for reviewing.

> [hbck2] Add a master web ui to show the problematic regions
> ---
>
> Key: HBASE-22527
> URL: https://issues.apache.org/jira/browse/HBASE-22527
> Project: HBase
>  Issue Type: Sub-task
>  Components: hbase-operator-tools, hbck2
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-22527.branch-2.0.001.patch, 
> HBASE-22527.branch-2.0.001.patch, HBASE-22527.branch-2.0.002.patch, 
> HBASE-22527.branch-2.1.001.patch, HBASE-22527.branch-2.1.002.patch, 
> HBASE-22527.branch-2.1.003.patch, HBASE-22527.master.001.patch, 
> HBASE-22527.master.002.patch, HBASE-22527.master.003.patch, 
> HBASE-22527.master.004.patch, HBASE-22527.master.addendum.patch
>
>
> On our cluster which based 2.2.0, we found one problem: there are some opened 
> regions which had wrong regionserver in meta. The regionserver is not exist. 
> We used hbck2 to fix them by the following steps.
>  # disable table
>  # bypass the stucked close region procedure (as the target regionserver is 
> not exist) and disable table procedure.
>  # setRegionState to CLOSED.
>  # setTableState to DISABLED.
>  # enable table
> We found this problem by scan the hbase:meta. I thought we should add this 
> feature to hbck2. The we can use hbck2 to find this problem. Thanks.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HBASE-22648) Snapshot TTL

2019-07-22 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890661#comment-16890661
 ] 

Hudson commented on HBASE-22648:


Results for branch master
[build #1252 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1252/]: (/) 
*{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1252//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1252//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1252//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Snapshot TTL
> 
>
> Key: HBASE-22648
> URL: https://issues.apache.org/jira/browse/HBASE-22648
> Project: HBase
>  Issue Type: New Feature
>  Components: snapshots
>Affects Versions: 3.0.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-22648-branch-1.patch, HBASE-22648-branch-2.patch, 
> HBASE-22648-master-v2.patch, HBASE-22648-master-v3.patch, 
> HBASE-22648-master-v4.patch, HBASE-22648-master-v5.patch, 
> HBASE-22648-master-v6.patch, HBASE-22648-master-v8.patch, 
> HBASE-22648-master.patch, Screen Shot 2019-07-10 at 8.49.13 PM.png, Screen 
> Shot 2019-07-10 at 8.52.30 PM.png, Screen Shot 2019-07-10 at 9.06.36 PM.png, 
> Screen Shot 2019-07-16 at 11.06.03 AM.png
>
>
> Snapshots have a lifecycle that is independent from the table from which they 
> are created. Although data in a table may be stored with TTL the data files 
> containing them become frozen by the snapshot. Space consumed by expired 
> cells will not be reclaimed by normal table housekeeping like compaction. 
> While this is expected it can be inconvenient at scale. When many snapshots 
> are under management and the data in various tables is expired by TTL some 
> notion of optional TTL (and optional default TTL) for snapshots could be 
> useful. It will help prevent the accumulation of junk files by automatically 
> dropping the snapshot after the assigned TTL, making their data files 
> eligible for cleaning. More comprehensive snapshot lifecycle management may 
> be considered in the future but this one case is expected to be immediately 
> useful given TTls on data are commonly applied for similar convenience. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache-HBase commented on issue #315: HBASE-22594 Clean up for backup examples

2019-07-22 Thread GitBox
Apache-HBase commented on issue #315: HBASE-22594 Clean up for backup examples
URL: https://github.com/apache/hbase/pull/315#issuecomment-514046545
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 78 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 22 | Maven dependency ordering for branch |
   | +1 | mvninstall | 278 | master passed |
   | +1 | compile | 61 | master passed |
   | +1 | checkstyle | 143 | master passed |
   | +1 | shadedjars | 258 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 45 | master passed |
   | 0 | spotbugs | 183 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | 0 | findbugs | 13 | branch/hbase-checkstyle no findbugs output file 
(findbugsXml.xml) |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | +1 | mvninstall | 266 | the patch passed |
   | +1 | compile | 62 | the patch passed |
   | +1 | javac | 62 | the patch passed |
   | +1 | checkstyle | 143 | root: The patch generated 0 new + 0 unchanged - 26 
fixed = 0 total (was 26) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | xml | 2 | The patch has no ill-formed XML file. |
   | +1 | shadedjars | 256 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 821 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 45 | the patch passed |
   | 0 | findbugs | 12 | hbase-checkstyle has no data from findbugs |
   ||| _ Other Tests _ |
   | +1 | unit | 11 | hbase-checkstyle in the patch passed. |
   | -1 | unit | 18193 | hbase-server in the patch failed. |
   | +1 | asflicense | 44 | The patch does not generate ASF License warnings. |
   | | | 21498 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.client.TestConnection |
   |   | hadoop.hbase.regionserver.TestSplitTransactionOnCluster |
   |   | 
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL |
   |   | hadoop.hbase.replication.TestMasterReplication |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-315/18/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/315 |
   | Optional Tests | dupname asflicense checkstyle javac javadoc unit xml 
spotbugs findbugs shadedjars hadoopcheck hbaseanti compile |
   | uname | Linux 33e7179a8f49 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-315/out/precommit/personality/provided.sh
 |
   | git revision | master / 9615c644f5 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-315/18/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-315/18/testReport/
 |
   | Max. process+thread count | 5195 (vs. ulimit of 1) |
   | modules | C: hbase-checkstyle hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-315/18/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #385: HBASE-22382 Refactor tests in TestFromClientSide

2019-07-22 Thread GitBox
Apache-HBase commented on issue #385: HBASE-22382 Refactor tests in 
TestFromClientSide
URL: https://github.com/apache/hbase/pull/385#issuecomment-514045937
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 83 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 355 | master passed |
   | +1 | compile | 56 | master passed |
   | +1 | checkstyle | 74 | master passed |
   | +1 | shadedjars | 257 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 32 | master passed |
   | 0 | spotbugs | 235 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 234 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 271 | the patch passed |
   | +1 | compile | 52 | the patch passed |
   | +1 | javac | 52 | the patch passed |
   | +1 | checkstyle | 73 | hbase-server: The patch generated 0 new + 48 
unchanged - 2 fixed = 48 total (was 50) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 257 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 800 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 32 | the patch passed |
   | +1 | findbugs | 243 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 18213 | hbase-server in the patch failed. |
   | +1 | asflicense | 29 | The patch does not generate ASF License warnings. |
   | | | 21397 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL 
|
   |   | hadoop.hbase.client.TestAsyncTableAdminApi3 |
   |   | hadoop.hbase.replication.TestMasterReplication |
   |   | hadoop.hbase.master.procedure.TestProcedurePriority |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   |   | hadoop.hbase.client.TestAdmin1 |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-385/8/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/385 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 5fc4d573f0c6 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-385/out/precommit/personality/provided.sh
 |
   | git revision | master / 9615c644f5 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-385/8/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-385/8/testReport/
 |
   | Max. process+thread count | 5049 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-385/8/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #360: HBASE-15666 shaded dependencies for hbase-testing-util

2019-07-22 Thread GitBox
Apache-HBase commented on issue #360: HBASE-15666 shaded dependencies for 
hbase-testing-util
URL: https://github.com/apache/hbase/pull/360#issuecomment-514045596
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 63 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | 0 | shelldocs | 1 | Shelldocs was not available. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 3 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 12 | Maven dependency ordering for branch |
   | +1 | mvninstall | 230 | master passed |
   | +1 | compile | 156 | master passed |
   | +1 | checkstyle | 137 | master passed |
   | +1 | shadedjars | 263 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 216 | master passed |
   | 0 | spotbugs | 835 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | 0 | findbugs | 11 | branch/hbase-resource-bundle no findbugs output file 
(findbugsXml.xml) |
   | 0 | findbugs | 24 | branch/hbase-shaded no findbugs output file 
(findbugsXml.xml) |
   | 0 | findbugs | 10 | branch/hbase-shaded/hbase-shaded-check-invariants no 
findbugs output file (findbugsXml.xml) |
   | 0 | findbugs | 10 | 
branch/hbase-shaded/hbase-shaded-with-hadoop-check-invariants no findbugs 
output file (findbugsXml.xml) |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 13 | Maven dependency ordering for patch |
   | +1 | mvninstall | 277 | the patch passed |
   | +1 | compile | 162 | the patch passed |
   | +1 | javac | 162 | the patch passed |
   | +1 | checkstyle | 136 | the patch passed |
   | +1 | shellcheck | 1 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | xml | 9 | The patch has no ill-formed XML file. |
   | +1 | shadedjars | 255 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 885 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 233 | the patch passed |
   | 0 | findbugs | 10 | hbase-resource-bundle has no data from findbugs |
   | 0 | findbugs | 36 | hbase-shaded has no data from findbugs |
   | 0 | findbugs | 19 | hbase-shaded/hbase-shaded-testing-util has no data 
from findbugs |
   | 0 | findbugs | 11 | hbase-shaded/hbase-shaded-check-invariants has no data 
from findbugs |
   | 0 | findbugs | 11 | hbase-shaded/hbase-shaded-with-hadoop-check-invariants 
has no data from findbugs |
   | 0 | findbugs | 12 | hbase-shaded/hbase-shaded-testing-util-tester has no 
data from findbugs |
   ||| _ Other Tests _ |
   | -1 | unit | 15781 | root in the patch failed. |
   | +1 | asflicense | 187 | The patch does not generate ASF License warnings. |
   | | | 21255 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/12/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/360 |
   | Optional Tests | dupname asflicense javac javadoc unit shadedjars 
hadoopcheck xml compile shellcheck shelldocs spotbugs findbugs hbaseanti 
checkstyle |
   | uname | Linux ffd478d65b0e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-360/out/precommit/personality/provided.sh
 |
   | git revision | master / 9615c644f5 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/12/artifact/out/patch-unit-root.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/12/testReport/
 |
   | Max. process+thread count | 4602 (vs. ulimit of 1) |
   | modules | C: hbase-resource-bundle hbase-it hbase-shaded 
hbase-shaded/hbase-shaded-testing-util 
hbase-shaded/hbase-shaded-check-invariants 
hbase-shaded/hbase-shaded-with-hadoop-check-invariants . 
hbase-shaded/hbase-shaded-testing-util-tester U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/12/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 
findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond

[jira] [Commented] (HBASE-22709) Add a chore thread in master to do hbck checking

2019-07-22 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890659#comment-16890659
 ] 

stack commented on HBASE-22709:
---

[~zghaobac]
bq. The patch here only handle the orphan regions on RegionServer or on HDFS 
and the inconsistent regions.

Yes. The work here and in HBASE-22723 compliments each other. I can dump the 
hbase:meta report into whereever the new hbck UI page ends up.

Did you see suggestion of an 'adoption service' in HBASE-27145? We'd ask the 
Master to 'adopt' orphans found in HDFS (by your work here for instance).

> Add a chore thread in master to do hbck checking
> 
>
> Key: HBASE-22709
> URL: https://issues.apache.org/jira/browse/HBASE-22709
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-22709.master.001.patch
>
>
> See HBASE-21965. There may have two type of failed splited/merged regions. 
> One is orphan region on filesystem. Another one is unassigned daughter 
> regions or merged regions. Plan to add a seperate hbck.jsp for them. Will add 
> more hbck problems to this UI in future.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes

2019-07-22 Thread GitBox
Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for 
org.apache.hadoop.hbase.util.ByteRangeUtils and Classes
URL: https://github.com/apache/hbase/pull/374#issuecomment-514045398
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 64 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 1 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 329 | master passed |
   | +1 | compile | 27 | master passed |
   | +1 | checkstyle | 31 | master passed |
   | +1 | shadedjars | 345 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 27 | master passed |
   | 0 | spotbugs | 64 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 61 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 313 | the patch passed |
   | +1 | compile | 27 | the patch passed |
   | +1 | javac | 27 | the patch passed |
   | +1 | checkstyle | 30 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 348 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1005 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 23 | the patch passed |
   | +1 | findbugs | 65 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 191 | hbase-common in the patch passed. |
   | +1 | asflicense | 11 | The patch does not generate ASF License warnings. |
   | | | 3279 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/374 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux f3335a3cd83b 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 
07:56:38 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
 |
   | git revision | master / 0e34dcbf4b |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/3/testReport/
 |
   | Max. process+thread count | 292 (vs. ulimit of 1) |
   | modules | C: hbase-common U: hbase-common |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/3/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-21745) Make HBCK2 be able to fix issues other than region assignment

2019-07-22 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890658#comment-16890658
 ] 

stack commented on HBASE-21745:
---

HBASE-22723 is about implementing first idea above, having CatalogJanitor 
report on holes and overlaps.

> Make HBCK2 be able to fix issues other than region assignment
> -
>
> Key: HBASE-21745
> URL: https://issues.apache.org/jira/browse/HBASE-21745
> Project: HBase
>  Issue Type: Umbrella
>  Components: hbase-operator-tools, hbck2
>Reporter: Duo Zhang
>Assignee: stack
>Priority: Critical
>
> This is what [~apurtell] posted on mailing-list, HBCK2 should support
>  * -Rebuild meta from region metadata in the filesystem, aka offline meta 
> rebuild.-
>  * -Fix assignment errors (undeployed regions, double assignments (yes, 
> should not be possible), etc)- (See 
> https://issues.apache.org/jira/browse/HBASE-21745?focusedCommentId=16888302&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16888302)
>  * Fix region holes, overlaps, and other errors in the region chain
>  * Fix failed split and merge transactions that have failed to roll back due 
> to some bug (related to previous)
>  *  -Enumerate store files to determine file level corruption and sideline 
> corrupt files-
>  * -Fix hfile link problems (dangling / broken)-



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22723) Have CatalogJanitor report holes and overlaps; i.e. problems it sees when doing its regular scan of hbase:meta

2019-07-22 Thread stack (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-22723:
--
Attachment: HBASE-22723.branch-2.001.patch

> Have CatalogJanitor report holes and overlaps; i.e. problems it sees when 
> doing its regular scan of hbase:meta
> --
>
> Key: HBASE-22723
> URL: https://issues.apache.org/jira/browse/HBASE-22723
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Priority: Major
> Attachments: HBASE-22723.branch-2.001.patch
>
>
> CatalogJanitor scans hbase:meta on a configurable period. Currently it just 
> looks for splits and merges to gc. Might as well generate a report on stuff 
> like holds, overlaps, empty regioninfos, and unknown servers while it is at 
> it.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HBASE-20952) Re-visit the WAL API

2019-07-22 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890654#comment-16890654
 ] 

Hudson commented on HBASE-20952:


Results for branch HBASE-20952
[build #99 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20952/99/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20952/99//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20952/99//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20952/99//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Re-visit the WAL API
> 
>
> Key: HBASE-20952
> URL: https://issues.apache.org/jira/browse/HBASE-20952
> Project: HBase
>  Issue Type: Improvement
>  Components: wal
>Reporter: Josh Elser
>Priority: Major
> Attachments: 20952.v1.txt
>
>
> Take a step back from the current WAL implementations and think about what an 
> HBase WAL API should look like. What are the primitive calls that we require 
> to guarantee durability of writes with a high degree of performance?
> The API needs to take the current implementations into consideration. We 
> should also have a mind for what is happening in the Ratis LogService (but 
> the LogService should not dictate what HBase's WAL API looks like RATIS-272).
> Other "systems" inside of HBase that use WALs are replication and 
> backup&restore. Replication has the use-case for "tail"'ing the WAL which we 
> should provide via our new API. B&R doesn't do anything fancy (IIRC). We 
> should make sure all consumers are generally going to be OK with the API we 
> create.
> The API may be "OK" (or OK in a part). We need to also consider other methods 
> which were "bolted" on such as {{AbstractFSWAL}} and 
> {{WALFileLengthProvider}}. Other corners of "WAL use" (like the 
> {{WALSplitter}} should also be looked at to use WAL-APIs only).
> We also need to make sure that adequate interface audience and stability 
> annotations are chosen.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache-HBase commented on issue #392: HBASE-22714 - Fix opertationTimeout typo

2019-07-22 Thread GitBox
Apache-HBase commented on issue #392: HBASE-22714 - Fix opertationTimeout typo
URL: https://github.com/apache/hbase/pull/392#issuecomment-514042514
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 58 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 329 | master passed |
   | +1 | compile | 23 | master passed |
   | +1 | checkstyle | 31 | master passed |
   | +1 | shadedjars | 266 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 22 | master passed |
   | 0 | spotbugs | 70 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 67 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 282 | the patch passed |
   | +1 | compile | 25 | the patch passed |
   | +1 | javac | 25 | the patch passed |
   | +1 | checkstyle | 31 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 297 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 754 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | -1 | javadoc | 21 | hbase-client generated 1 new + 2 unchanged - 0 fixed = 
3 total (was 2) |
   | +1 | findbugs | 70 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 106 | hbase-client in the patch passed. |
   | +1 | asflicense | 12 | The patch does not generate ASF License warnings. |
   | | | 2756 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/4/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/392 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 995d42f2bdb8 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 
13:14:43 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-392/out/precommit/personality/provided.sh
 |
   | git revision | master / fe450b50c1 |
   | Default Java | 1.8.0_181 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/4/artifact/out/diff-javadoc-javadoc-hbase-client.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/4/testReport/
 |
   | Max. process+thread count | 291 (vs. ulimit of 1) |
   | modules | C: hbase-client U: hbase-client |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/4/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (HBASE-22723) Have CatalogJanitor report holes and overlaps; i.e. problems it sees when doing its regular scan of hbase:meta

2019-07-22 Thread stack (JIRA)
stack created HBASE-22723:
-

 Summary: Have CatalogJanitor report holes and overlaps; i.e. 
problems it sees when doing its regular scan of hbase:meta
 Key: HBASE-22723
 URL: https://issues.apache.org/jira/browse/HBASE-22723
 Project: HBase
  Issue Type: Sub-task
Reporter: stack


CatalogJanitor scans hbase:meta on a configurable period. Currently it just 
looks for splits and merges to gc. Might as well generate a report on stuff 
like holds, overlaps, empty regioninfos, and unknown servers while it is at it.





--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache-HBase commented on issue #336: HBASE-22580 Add a table attribute to make user scan snapshot feature configurable for table

2019-07-22 Thread GitBox
Apache-HBase commented on issue #336: HBASE-22580 Add a table attribute to make 
user scan snapshot feature configurable for table
URL: https://github.com/apache/hbase/pull/336#issuecomment-514041630
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 96 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | -1 | mvninstall | 12 | root in master failed. |
   | -1 | compile | 48 | hbase-server in master failed. |
   | +1 | checkstyle | 76 | master passed |
   | +1 | shadedjars | 283 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 33 | master passed |
   | 0 | spotbugs | 353 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | -1 | findbugs | 36 | hbase-server in master failed. |
   ||| _ Patch Compile Tests _ |
   | -1 | mvninstall | 13 | root in the patch failed. |
   | -1 | compile | 33 | hbase-server in the patch failed. |
   | -1 | javac | 33 | hbase-server in the patch failed. |
   | +1 | checkstyle | 71 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 267 | patch has no errors when building our shaded 
downstream artifacts. |
   | -1 | hadoopcheck | 11 | The patch causes 10 errors with Hadoop v2.8.5. |
   | -1 | hadoopcheck | 22 | The patch causes 10 errors with Hadoop v2.9.2. |
   | -1 | hadoopcheck | 32 | The patch causes 10 errors with Hadoop v3.1.2. |
   | +1 | javadoc | 32 | the patch passed |
   | -1 | findbugs | 35 | hbase-server in the patch failed. |
   ||| _ Other Tests _ |
   | -1 | unit | 35 | hbase-server in the patch failed. |
   | +1 | asflicense | 8 | The patch does not generate ASF License warnings. |
   | | | 1172 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/15/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/336 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 5c6726fc0e68 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-336/out/precommit/personality/provided.sh
 |
   | git revision | master / 0e34dcbf4b |
   | Default Java | 1.8.0_181 |
   | mvninstall | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/15/artifact/out/branch-mvninstall-root.txt
 |
   | compile | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/15/artifact/out/branch-compile-hbase-server.txt
 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/15/artifact/out/branch-findbugs-hbase-server.txt
 |
   | mvninstall | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/15/artifact/out/patch-mvninstall-root.txt
 |
   | compile | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/15/artifact/out/patch-compile-hbase-server.txt
 |
   | javac | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/15/artifact/out/patch-compile-hbase-server.txt
 |
   | hadoopcheck | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/15/artifact/out/patch-javac-2.8.5.txt
 |
   | hadoopcheck | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/15/artifact/out/patch-javac-2.9.2.txt
 |
   | hadoopcheck | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/15/artifact/out/patch-javac-3.1.2.txt
 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/15/artifact/out/patch-findbugs-hbase-server.txt
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/15/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/15/testReport/
 |
   | Max. process+thread count | 87 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/15/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log o

[jira] [Updated] (HBASE-22717) [HBCK2] Expose replication fixes from hbck1

2019-07-22 Thread stack (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-22717:
--
Resolution: Fixed
Status: Resolved  (was: Patch Available)

Resolving.

> [HBCK2] Expose replication fixes from hbck1
> ---
>
> Key: HBASE-22717
> URL: https://issues.apache.org/jira/browse/HBASE-22717
> Project: HBase
>  Issue Type: Sub-task
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: hbase-operator-tools-1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache9 opened a new pull request #402: HBASE-22722 Upgrade jackson databind dependencies to 2.9.9.1

2019-07-22 Thread GitBox
Apache9 opened a new pull request #402: HBASE-22722 Upgrade jackson databind 
dependencies to 2.9.9.1
URL: https://github.com/apache/hbase/pull/402
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22716) upgrade zookeeper version to 3.5.5

2019-07-22 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890647#comment-16890647
 ] 

Hadoop QA commented on HBASE-22716:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
32s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
12s{color} | {color:red} root in master failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
21s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
53s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 13m 
48s{color} | {color:blue} Used deprecated FindBugs config; considering 
switching to SpotBugs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
16s{color} | {color:red} hbase-zookeeper in master failed. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
12s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
38s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  0m 
12s{color} | {color:red} The patch causes 10 errors with Hadoop v2.8.5. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  0m 
25s{color} | {color:red} The patch causes 10 errors with Hadoop v2.9.2. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  0m 
37s{color} | {color:red} The patch causes 10 errors with Hadoop v3.1.2. {color} 
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
57s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
17s{color} | {color:red} hbase-zookeeper in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}262m 14s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
46s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}322m 50s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| 

[GitHub] [hbase] Apache-HBase commented on issue #394: HBASE-22716:upgrade zookeeper version to 3.5.5

2019-07-22 Thread GitBox
Apache-HBase commented on issue #394: HBASE-22716:upgrade zookeeper version to 
3.5.5
URL: https://github.com/apache/hbase/pull/394#issuecomment-514040192
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 81 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 32 | Maven dependency ordering for branch |
   | -1 | mvninstall | 12 | root in master failed. |
   | +1 | compile | 166 | master passed |
   | +1 | checkstyle | 135 | master passed |
   | +1 | shadedjars | 261 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 173 | master passed |
   | 0 | spotbugs | 828 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | -1 | findbugs | 16 | hbase-zookeeper in master failed. |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 14 | Maven dependency ordering for patch |
   | -1 | mvninstall | 12 | root in the patch failed. |
   | +1 | compile | 162 | the patch passed |
   | +1 | javac | 162 | the patch passed |
   | +1 | checkstyle | 144 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | xml | 1 | The patch has no ill-formed XML file. |
   | +1 | shadedjars | 278 | patch has no errors when building our shaded 
downstream artifacts. |
   | -1 | hadoopcheck | 12 | The patch causes 10 errors with Hadoop v2.8.5. |
   | -1 | hadoopcheck | 25 | The patch causes 10 errors with Hadoop v2.9.2. |
   | -1 | hadoopcheck | 37 | The patch causes 10 errors with Hadoop v3.1.2. |
   | +1 | javadoc | 177 | the patch passed |
   | -1 | findbugs | 17 | hbase-zookeeper in the patch failed. |
   ||| _ Other Tests _ |
   | -1 | unit | 15734 | root in the patch failed. |
   | +1 | asflicense | 46 | The patch does not generate ASF License warnings. |
   | | | 19370 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-394/7/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/394 |
   | JIRA Issue | HBASE-22716 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile xml |
   | uname | Linux 00443f8fde88 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-394/out/precommit/personality/provided.sh
 |
   | git revision | master / 9615c644f5 |
   | Default Java | 1.8.0_181 |
   | mvninstall | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-394/7/artifact/out/branch-mvninstall-root.txt
 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-394/7/artifact/out/branch-findbugs-hbase-zookeeper.txt
 |
   | mvninstall | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-394/7/artifact/out/patch-mvninstall-root.txt
 |
   | hadoopcheck | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-394/7/artifact/out/patch-javac-2.8.5.txt
 |
   | hadoopcheck | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-394/7/artifact/out/patch-javac-2.9.2.txt
 |
   | hadoopcheck | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-394/7/artifact/out/patch-javac-3.1.2.txt
 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-394/7/artifact/out/patch-findbugs-hbase-zookeeper.txt
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-394/7/artifact/out/patch-unit-root.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-394/7/testReport/
 |
   | Max. process+thread count | 5113 (vs. ulimit of 1) |
   | modules | C: hbase-zookeeper . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-394/7/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the 

[GitHub] [hbase] Apache-HBase commented on issue #400: HBASE-22720 Incorrect link for hbase.unittests

2019-07-22 Thread GitBox
Apache-HBase commented on issue #400: HBASE-22720 Incorrect link for 
hbase.unittests
URL: https://github.com/apache/hbase/pull/400#issuecomment-514040015
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 72 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 346 | master passed |
   | 0 | refguide | 562 | branch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 324 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | 0 | refguide | 560 | patch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. |
   ||| _ Other Tests _ |
   | +1 | asflicense | 18 | The patch does not generate ASF License warnings. |
   | | | 1945 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-400/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/400 |
   | Optional Tests | dupname asflicense refguide |
   | uname | Linux 3dcce041322b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-400/out/precommit/personality/provided.sh
 |
   | git revision | master / fe450b50c1 |
   | refguide | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-400/3/artifact/out/branch-site/book.html
 |
   | refguide | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-400/3/artifact/out/patch-site/book.html
 |
   | Max. process+thread count | 96 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-400/3/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #237: HBASE-22408 add dead and unknown server open regions metric to AM 01

2019-07-22 Thread GitBox
Apache-HBase commented on issue #237: HBASE-22408 add dead and unknown server 
open regions metric to AM 01
URL: https://github.com/apache/hbase/pull/237#issuecomment-514039762
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 0 | Docker mode activated. |
   | -1 | patch | 9 | https://github.com/apache/hbase/pull/237 does not apply 
to master. Rebase required? Wrong Branch? See 
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for 
help. |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | GITHUB PR | https://github.com/apache/hbase/pull/237 |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-237/3/console |
   | versions | git=2.7.4 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #238: HBASE-22410 add the notion of the expected # of servers for non-fixed server sets; report an alternative dead server metric 01

2019-07-22 Thread GitBox
Apache-HBase commented on issue #238: HBASE-22410 add the notion of the 
expected # of servers for non-fixed server sets; report an alternative dead 
server metric 01
URL: https://github.com/apache/hbase/pull/238#issuecomment-514039524
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 0 | Docker mode activated. |
   | -1 | patch | 10 | https://github.com/apache/hbase/pull/238 does not apply 
to master. Rebase required? Wrong Branch? See 
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for 
help. |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | GITHUB PR | https://github.com/apache/hbase/pull/238 |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-238/3/console |
   | versions | git=2.7.4 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (HBASE-22722) Upgrade jackson databind dependencies to 2.9.9.1

2019-07-22 Thread Duo Zhang (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-22722:
--
Summary: Upgrade jackson databind dependencies to 2.9.9.1  (was: Upgrade 
jackson dependencies to 2.9.9.1)

> Upgrade jackson databind dependencies to 2.9.9.1
> 
>
> Key: HBASE-22722
> URL: https://issues.apache.org/jira/browse/HBASE-22722
> Project: HBase
>  Issue Type: Bug
>  Components: dependencies
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Blocker
>
> Due to this CVE



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache-HBase commented on issue #210: HBASE-22346 scanner priorities/deadline units are invalid for non-huge scanners

2019-07-22 Thread GitBox
Apache-HBase commented on issue #210: HBASE-22346 scanner priorities/deadline 
units are invalid for non-huge scanners
URL: https://github.com/apache/hbase/pull/210#issuecomment-514039106
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 55 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 307 | master passed |
   | +1 | compile | 57 | master passed |
   | +1 | checkstyle | 77 | master passed |
   | +1 | shadedjars | 275 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 35 | master passed |
   | 0 | spotbugs | 241 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 239 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 235 | the patch passed |
   | +1 | compile | 56 | the patch passed |
   | +1 | javac | 56 | the patch passed |
   | -1 | checkstyle | 79 | hbase-server: The patch generated 5 new + 103 
unchanged - 1 fixed = 108 total (was 104) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 270 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 808 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 33 | the patch passed |
   | +1 | findbugs | 249 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 15628 | hbase-server in the patch failed. |
   | +1 | asflicense | 25 | The patch does not generate ASF License warnings. |
   | | | 18751 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-210/14/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/210 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 17d435036b22 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-210/out/precommit/personality/provided.sh
 |
   | git revision | master / 9615c644f5 |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-210/14/artifact/out/diff-checkstyle-hbase-server.txt
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-210/14/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-210/14/testReport/
 |
   | Max. process+thread count | 4886 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-210/14/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22721) Refactor HBaseFsck: move the inner class out

2019-07-22 Thread Guanghao Zhang (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890642#comment-16890642
 ] 

Guanghao Zhang commented on HBASE-22721:


bq. Should I do same thing over in hbase-operator-tools? hbasefsck has been 
moved there.
Not need, sir. I refactor it because i want to use HbckRegionInfo class for 
HBASE-22709.

> Refactor HBaseFsck: move the inner class out
> 
>
> Key: HBASE-22721
> URL: https://issues.apache.org/jira/browse/HBASE-22721
> Project: HBase
>  Issue Type: Bug
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
>
> HBaseFsck.java has too many code. And HBASE-22709 will use some inner of 
> HBaseFsck. So plan to refactor it.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache-HBase commented on issue #391: HBASE-22628 Document the custom WAL directory (hbase.wal.dir) usage

2019-07-22 Thread GitBox
Apache-HBase commented on issue #391: HBASE-22628 Document the custom WAL 
directory (hbase.wal.dir) usage
URL: https://github.com/apache/hbase/pull/391#issuecomment-514038132
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 108 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   ||| _ master Compile Tests _ |
   | -1 | mvninstall | 28 | root in master failed. |
   | -1 | refguide | 488 | branch has 2 errors when building the reference 
guide. |
   ||| _ Patch Compile Tests _ |
   | -1 | mvninstall | 12 | root in the patch failed. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | -1 | refguide | 464 | patch has 2 errors when building the reference 
guide. |
   ||| _ Other Tests _ |
   | +1 | asflicense | 13 | The patch does not generate ASF License warnings. |
   | | | 1167 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/391 |
   | Optional Tests | dupname asflicense refguide |
   | uname | Linux c9a8f1ed7b69 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-391/out/precommit/personality/provided.sh
 |
   | git revision | master / fe450b50c1 |
   | mvninstall | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/3/artifact/out/branch-mvninstall-root.txt
 |
   | refguide | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/3/artifact/out/branch-refguide.log
 |
   | mvninstall | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/3/artifact/out/patch-mvninstall-root.txt
 |
   | refguide | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/3/artifact/out/patch-refguide.log
 |
   | Max. process+thread count | 56 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/3/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…

2019-07-22 Thread GitBox
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts 
of TokenUtil off into a Clien…
URL: https://github.com/apache/hbase/pull/361#issuecomment-514036813
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 84 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 34 | Maven dependency ordering for branch |
   | +1 | mvninstall | 283 | master passed |
   | +1 | compile | 75 | master passed |
   | +1 | checkstyle | 103 | master passed |
   | +1 | shadedjars | 254 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 53 | master passed |
   | 0 | spotbugs | 363 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | -1 | findbugs | 18 | hbase-client in master failed. |
   | -1 | findbugs | 37 | hbase-server in master failed. |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 14 | Maven dependency ordering for patch |
   | +1 | mvninstall | 272 | the patch passed |
   | +1 | compile | 79 | the patch passed |
   | +1 | javac | 79 | the patch passed |
   | +1 | checkstyle | 98 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 263 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 743 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 57 | the patch passed |
   | +1 | findbugs | 314 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 113 | hbase-client in the patch passed. |
   | -1 | unit | 14935 | hbase-server in the patch failed. |
   | +1 | asflicense | 50 | The patch does not generate ASF License warnings. |
   | | | 18231 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.regionserver.TestSplitTransactionOnCluster |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/13/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/361 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 36ef92337a30 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
 |
   | git revision | master / 9615c644f5 |
   | Default Java | 1.8.0_181 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/13/artifact/out/branch-findbugs-hbase-client.txt
 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/13/artifact/out/branch-findbugs-hbase-server.txt
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/13/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/13/testReport/
 |
   | Max. process+thread count | 4767 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/13/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #382: HBASE-22692 Added Rubocop definition file to bin directory

2019-07-22 Thread GitBox
Apache-HBase commented on issue #382: HBASE-22692 Added Rubocop definition file 
to bin directory
URL: https://github.com/apache/hbase/pull/382#issuecomment-514035959
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 56 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | 0 | yamllint | 0 | yamllint was not available. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   ||| _ master Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   ||| _ Other Tests _ |
   | +1 | asflicense | 16 | The patch does not generate ASF License warnings. |
   | | | 127 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/382 |
   | Optional Tests | dupname asflicense yamllint |
   | uname | Linux bad4226cd82f 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 
05:29:03 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-382/out/precommit/personality/provided.sh
 |
   | git revision | master / 0e34dcbf4b |
   | Max. process+thread count | 47 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/3/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase

2019-07-22 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890640#comment-16890640
 ] 

Hudson commented on HBASE-22514:


Results for branch HBASE-22514
[build #26 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/26/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/26//console].




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/26//console].


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/26//console].


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
>  Issue Type: Umbrella
>  Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch, 
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public 
> we need to use java api  RSGroupAdminClient  to manager RSG 
> so  RSGroupAdminClient should be public
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase

2019-07-22 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890639#comment-16890639
 ] 

Hudson commented on HBASE-22514:


Results for branch HBASE-22514
[build #25 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/25/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/25//console].




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/25//console].


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/25//console].


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
>  Issue Type: Umbrella
>  Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch, 
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public 
> we need to use java api  RSGroupAdminClient  to manager RSG 
> so  RSGroupAdminClient should be public
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HBASE-22709) Add a chore thread in master to do hbck checking

2019-07-22 Thread Guanghao Zhang (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890638#comment-16890638
 ] 

Guanghao Zhang commented on HBASE-22709:


bq.  It runs once an hour?
Yes. It need to scan all hdfs dir. So I thought no need to run it frequently.
bq. Can operator ask to run it?
Good idea.

bq. I'm working on a patch to beef up CatalogJanitor so when it scans on its 
five minute interval, it reports on holes, overlaps, and unknown servers. 
Great. The patch here only handle the orphan regions on RegionServer or on HDFS 
and the inconsistent regions.

> Add a chore thread in master to do hbck checking
> 
>
> Key: HBASE-22709
> URL: https://issues.apache.org/jira/browse/HBASE-22709
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-22709.master.001.patch
>
>
> See HBASE-21965. There may have two type of failed splited/merged regions. 
> One is orphan region on filesystem. Another one is unassigned daughter 
> regions or merged regions. Plan to add a seperate hbck.jsp for them. Will add 
> more hbck problems to this UI in future.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache-HBase commented on issue #199: HBASE-22313 Add method to FsDelegation token to accept token kind

2019-07-22 Thread GitBox
Apache-HBase commented on issue #199: HBASE-22313 Add method to FsDelegation 
token to accept token kind
URL: https://github.com/apache/hbase/pull/199#issuecomment-514035203
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 80 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 274 | master passed |
   | +1 | compile | 52 | master passed |
   | +1 | checkstyle | 78 | master passed |
   | +1 | shadedjars | 262 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 34 | master passed |
   | 0 | spotbugs | 249 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 246 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 270 | the patch passed |
   | -1 | compile | 42 | hbase-server in the patch failed. |
   | -1 | javac | 42 | hbase-server in the patch failed. |
   | +1 | checkstyle | 70 | hbase-server: The patch generated 0 new + 0 
unchanged - 1 fixed = 0 total (was 1) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 258 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 801 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 32 | the patch passed |
   | +1 | findbugs | 264 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 14320 | hbase-server in the patch passed. |
   | +1 | asflicense | 27 | The patch does not generate ASF License warnings. |
   | | | 17414 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-199/18/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/199 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux a50d213f5522 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 
13:14:43 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-199/out/precommit/personality/provided.sh
 |
   | git revision | master / 9615c644f5 |
   | Default Java | 1.8.0_181 |
   | compile | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-199/18/artifact/out/patch-compile-hbase-server.txt
 |
   | javac | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-199/18/artifact/out/patch-compile-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-199/18/testReport/
 |
   | Max. process+thread count | 5185 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-199/18/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22709) Add a chore thread in master to do hbck checking

2019-07-22 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890635#comment-16890635
 ] 

stack commented on HBASE-22709:
---

Looks good. It runs once an hour? Can operator ask to run it? [~zghaobac]

You see note on end of 
https://issues.apache.org/jira/browse/HBASE-21745?focusedCommentId=16889062&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16889062
 ?

I'm working on a patch to beef up CatalogJanitor so when it scans on its five 
minute interval, it reports on holes, overlaps, and unknown servers. Was going 
to have it manufacture a Report. The Report could show on your hbck UI page. 
Was thinking of adding it to ClusterMetrics.



> Add a chore thread in master to do hbck checking
> 
>
> Key: HBASE-22709
> URL: https://issues.apache.org/jira/browse/HBASE-22709
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-22709.master.001.patch
>
>
> See HBASE-21965. There may have two type of failed splited/merged regions. 
> One is orphan region on filesystem. Another one is unassigned daughter 
> regions or merged regions. Plan to add a seperate hbck.jsp for them. Will add 
> more hbck problems to this UI in future.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Comment Edited] (HBASE-22709) Add a chore thread in master to do hbck checking

2019-07-22 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890635#comment-16890635
 ] 

stack edited comment on HBASE-22709 at 7/23/19 2:59 AM:


Looks good. It runs once an hour? Can operator ask to run it? [~zghaobac]

You see note on end of 
https://issues.apache.org/jira/browse/HBASE-21745?focusedCommentId=16889062&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16889062
 ?

I'm working on a patch to beef up CatalogJanitor so when it scans on its five 
minute interval, it reports on holes, overlaps, and unknown servers. Was going 
to have it manufacture a Report. The Report could show on your hbck UI page. 
Was thinking of adding it to ClusterMetrics.




was (Author: stack):
Looks good. It runs once an hour? Can operator ask to run it? [~zghaobac]

You see note on end of 
https://issues.apache.org/jira/browse/HBASE-21745?focusedCommentId=16889062&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16889062
 ?

I'm working on a patch to beef up CatalogJanitor so when it scans on its five 
minute interval, it reports on holes, overlaps, and unknown servers. Was going 
to have it manufacture a Report. The Report could show on your hbck UI page. 
Was thinking of adding it to ClusterMetrics.



> Add a chore thread in master to do hbck checking
> 
>
> Key: HBASE-22709
> URL: https://issues.apache.org/jira/browse/HBASE-22709
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-22709.master.001.patch
>
>
> See HBASE-21965. There may have two type of failed splited/merged regions. 
> One is orphan region on filesystem. Another one is unassigned daughter 
> regions or merged regions. Plan to add a seperate hbck.jsp for them. Will add 
> more hbck problems to this UI in future.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HBASE-22721) Refactor HBaseFsck: move the inner class out

2019-07-22 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890634#comment-16890634
 ] 

stack commented on HBASE-22721:
---

Should I do same thing over in hbase-operator-tools? hbasefsck has been moved 
there.

> Refactor HBaseFsck: move the inner class out
> 
>
> Key: HBASE-22721
> URL: https://issues.apache.org/jira/browse/HBASE-22721
> Project: HBase
>  Issue Type: Bug
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
>
> HBaseFsck.java has too many code. And HBASE-22709 will use some inner of 
> HBaseFsck. So plan to refactor it.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache-HBase commented on issue #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories…

2019-07-22 Thread GitBox
Apache-HBase commented on issue #337: HBASE-22578 HFileCleaner should not 
delete empty ns/table directories…
URL: https://github.com/apache/hbase/pull/337#issuecomment-514032943
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 118 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 358 | master passed |
   | +1 | compile | 72 | master passed |
   | +1 | checkstyle | 96 | master passed |
   | +1 | shadedjars | 348 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 48 | master passed |
   | 0 | spotbugs | 301 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 298 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 333 | the patch passed |
   | +1 | compile | 72 | the patch passed |
   | +1 | javac | 72 | the patch passed |
   | +1 | checkstyle | 91 | hbase-server: The patch generated 0 new + 4 
unchanged - 1 fixed = 4 total (was 5) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 339 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1007 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 46 | the patch passed |
   | +1 | findbugs | 286 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 12960 | hbase-server in the patch failed. |
   | +1 | asflicense | 25 | The patch does not generate ASF License warnings. |
   | | | 16920 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.client.TestAsyncRegionAdminApi |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-337/15/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/337 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux a53823e839cf 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 
08:28:49 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-337/out/precommit/personality/provided.sh
 |
   | git revision | master / 9615c644f5 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-337/15/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-337/15/testReport/
 |
   | Max. process+thread count | 4701 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-337/15/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #386: HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize.

2019-07-22 Thread GitBox
Apache-HBase commented on issue #386: HBASE-22610 [BucketCache] Rename 
hbase.offheapcache.minblocksize.
URL: https://github.com/apache/hbase/pull/386#issuecomment-514032729
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 64 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 271 | master passed |
   | +1 | compile | 56 | master passed |
   | +1 | checkstyle | 78 | master passed |
   | +1 | shadedjars | 297 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 34 | master passed |
   | 0 | spotbugs | 248 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 244 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 294 | the patch passed |
   | +1 | compile | 58 | the patch passed |
   | +1 | javac | 58 | the patch passed |
   | +1 | checkstyle | 75 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 278 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 792 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 33 | the patch passed |
   | +1 | findbugs | 253 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 13737 | hbase-server in the patch failed. |
   | +1 | asflicense | 26 | The patch does not generate ASF License warnings. |
   | | | 16933 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-386/9/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/386 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 02c2786b8a6e 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 
13:14:43 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-386/out/precommit/personality/provided.sh
 |
   | git revision | master / 9615c644f5 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-386/9/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-386/9/testReport/
 |
   | Max. process+thread count | 4655 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-386/9/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (HBASE-22722) Upgrade jackson dependencies to 2.9.9.1

2019-07-22 Thread Duo Zhang (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-22722:
--
Description: Due to this CVE

> Upgrade jackson dependencies to 2.9.9.1
> ---
>
> Key: HBASE-22722
> URL: https://issues.apache.org/jira/browse/HBASE-22722
> Project: HBase
>  Issue Type: Bug
>  Components: dependencies
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Blocker
>
> Due to this CVE



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Reidddddd merged pull request #386: HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize.

2019-07-22 Thread GitBox
Reidd merged pull request #386: HBASE-22610 [BucketCache] Rename 
hbase.offheapcache.minblocksize.
URL: https://github.com/apache/hbase/pull/386
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (HBASE-22722) Upgrade jackson dependencies to 2.9.9.1

2019-07-22 Thread Duo Zhang (JIRA)
Duo Zhang created HBASE-22722:
-

 Summary: Upgrade jackson dependencies to 2.9.9.1
 Key: HBASE-22722
 URL: https://issues.apache.org/jira/browse/HBASE-22722
 Project: HBase
  Issue Type: Bug
  Components: dependencies
Reporter: Duo Zhang
Assignee: Duo Zhang






--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HBASE-22648) Snapshot TTL

2019-07-22 Thread HBase QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890621#comment-16890621
 ] 

HBase QA commented on HBASE-22648:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  7s{color} 
| {color:red} HBASE-22648 does not apply to branch-2. Rebase required? Wrong 
Branch? See 
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for 
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-22648 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12975454/HBASE-22648-branch-2.patch
 |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/665/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |


This message was automatically generated.



> Snapshot TTL
> 
>
> Key: HBASE-22648
> URL: https://issues.apache.org/jira/browse/HBASE-22648
> Project: HBase
>  Issue Type: New Feature
>  Components: snapshots
>Affects Versions: 3.0.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-22648-branch-1.patch, HBASE-22648-branch-2.patch, 
> HBASE-22648-master-v2.patch, HBASE-22648-master-v3.patch, 
> HBASE-22648-master-v4.patch, HBASE-22648-master-v5.patch, 
> HBASE-22648-master-v6.patch, HBASE-22648-master-v8.patch, 
> HBASE-22648-master.patch, Screen Shot 2019-07-10 at 8.49.13 PM.png, Screen 
> Shot 2019-07-10 at 8.52.30 PM.png, Screen Shot 2019-07-10 at 9.06.36 PM.png, 
> Screen Shot 2019-07-16 at 11.06.03 AM.png
>
>
> Snapshots have a lifecycle that is independent from the table from which they 
> are created. Although data in a table may be stored with TTL the data files 
> containing them become frozen by the snapshot. Space consumed by expired 
> cells will not be reclaimed by normal table housekeeping like compaction. 
> While this is expected it can be inconvenient at scale. When many snapshots 
> are under management and the data in various tables is expired by TTL some 
> notion of optional TTL (and optional default TTL) for snapshots could be 
> useful. It will help prevent the accumulation of junk files by automatically 
> dropping the snapshot after the assigned TTL, making their data files 
> eligible for cleaning. More comprehensive snapshot lifecycle management may 
> be considered in the future but this one case is expected to be immediately 
> useful given TTls on data are commonly applied for similar convenience. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator

2019-07-22 Thread GitBox
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of 
BufferedMutator  
URL: https://github.com/apache/hbase/pull/343#issuecomment-514028184
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 38 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ branch-2.1 Compile Tests _ |
   | +1 | mvninstall | 227 | branch-2.1 passed |
   | +1 | compile | 24 | branch-2.1 passed |
   | +1 | checkstyle | 32 | branch-2.1 passed |
   | +1 | shadedjars | 219 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 21 | branch-2.1 passed |
   | 0 | spotbugs | 70 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 69 | branch-2.1 passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 220 | the patch passed |
   | +1 | compile | 24 | the patch passed |
   | +1 | javac | 24 | the patch passed |
   | +1 | checkstyle | 31 | hbase-client: The patch generated 0 new + 58 
unchanged - 4 fixed = 58 total (was 62) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 221 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 907 | Patch does not cause any errors with Hadoop 2.7.7 
2.8.5 or 3.0.3 3.1.2. |
   | +1 | javadoc | 21 | the patch passed |
   | +1 | findbugs | 75 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 192 | hbase-client in the patch passed. |
   | +1 | asflicense | 10 | The patch does not generate ASF License warnings. |
   | | | 2624 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/343 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 59d4dcc6fcd6 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh
 |
   | git revision | branch-2.1 / 03f9fc3aa8 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/2/testReport/
 |
   | Max. process+thread count | 304 (vs. ulimit of 1) |
   | modules | C: hbase-client U: hbase-client |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/2/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (HBASE-22648) Snapshot TTL

2019-07-22 Thread Andrew Purtell (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-22648:
---
Attachment: HBASE-22648-branch-2.patch
HBASE-22648-branch-1.patch

> Snapshot TTL
> 
>
> Key: HBASE-22648
> URL: https://issues.apache.org/jira/browse/HBASE-22648
> Project: HBase
>  Issue Type: New Feature
>  Components: snapshots
>Affects Versions: 3.0.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-22648-branch-1.patch, HBASE-22648-branch-2.patch, 
> HBASE-22648-master-v2.patch, HBASE-22648-master-v3.patch, 
> HBASE-22648-master-v4.patch, HBASE-22648-master-v5.patch, 
> HBASE-22648-master-v6.patch, HBASE-22648-master-v8.patch, 
> HBASE-22648-master.patch, Screen Shot 2019-07-10 at 8.49.13 PM.png, Screen 
> Shot 2019-07-10 at 8.52.30 PM.png, Screen Shot 2019-07-10 at 9.06.36 PM.png, 
> Screen Shot 2019-07-16 at 11.06.03 AM.png
>
>
> Snapshots have a lifecycle that is independent from the table from which they 
> are created. Although data in a table may be stored with TTL the data files 
> containing them become frozen by the snapshot. Space consumed by expired 
> cells will not be reclaimed by normal table housekeeping like compaction. 
> While this is expected it can be inconvenient at scale. When many snapshots 
> are under management and the data in various tables is expired by TTL some 
> notion of optional TTL (and optional default TTL) for snapshots could be 
> useful. It will help prevent the accumulation of junk files by automatically 
> dropping the snapshot after the assigned TTL, making their data files 
> eligible for cleaning. More comprehensive snapshot lifecycle management may 
> be considered in the future but this one case is expected to be immediately 
> useful given TTls on data are commonly applied for similar convenience. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HBASE-22648) Snapshot TTL

2019-07-22 Thread Andrew Purtell (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890609#comment-16890609
 ] 

Andrew Purtell commented on HBASE-22648:


Attached branch-1 and branch-2 backport patches. Going to push them after tests 
complete.

> Snapshot TTL
> 
>
> Key: HBASE-22648
> URL: https://issues.apache.org/jira/browse/HBASE-22648
> Project: HBase
>  Issue Type: New Feature
>  Components: snapshots
>Affects Versions: 3.0.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-22648-branch-1.patch, HBASE-22648-branch-2.patch, 
> HBASE-22648-master-v2.patch, HBASE-22648-master-v3.patch, 
> HBASE-22648-master-v4.patch, HBASE-22648-master-v5.patch, 
> HBASE-22648-master-v6.patch, HBASE-22648-master-v8.patch, 
> HBASE-22648-master.patch, Screen Shot 2019-07-10 at 8.49.13 PM.png, Screen 
> Shot 2019-07-10 at 8.52.30 PM.png, Screen Shot 2019-07-10 at 9.06.36 PM.png, 
> Screen Shot 2019-07-16 at 11.06.03 AM.png
>
>
> Snapshots have a lifecycle that is independent from the table from which they 
> are created. Although data in a table may be stored with TTL the data files 
> containing them become frozen by the snapshot. Space consumed by expired 
> cells will not be reclaimed by normal table housekeeping like compaction. 
> While this is expected it can be inconvenient at scale. When many snapshots 
> are under management and the data in various tables is expired by TTL some 
> notion of optional TTL (and optional default TTL) for snapshots could be 
> useful. It will help prevent the accumulation of junk files by automatically 
> dropping the snapshot after the assigned TTL, making their data files 
> eligible for cleaning. More comprehensive snapshot lifecycle management may 
> be considered in the future but this one case is expected to be immediately 
> useful given TTls on data are commonly applied for similar convenience. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache9 commented on a change in pull request #385: HBASE-22382 Refactor tests in TestFromClientSide

2019-07-22 Thread GitBox
Apache9 commented on a change in pull request #385: HBASE-22382 Refactor tests 
in TestFromClientSide
URL: https://github.com/apache/hbase/pull/385#discussion_r306101357
 
 

 ##
 File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
 ##
 @@ -1156,20 +1156,28 @@ public void testSingleRowMultipleFamily() throws 
Exception {
   }
 
   @Test
-  public void testNull() throws Exception {
-final TableName tableName = TableName.valueOf(name.getMethodName());
-
+  public void testNullTableName() {
 // Null table name (should NOT work)
 try {
   TEST_UTIL.createTable((TableName)null, FAMILY);
   fail("Creating a table with null name passed, should have failed");
 } catch(Exception e) {}
 
 Review comment:
   Since we have split the method, we can use the @Test(expected = 
XXXException.class) so we do not need to catch the exception any more?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache9 commented on a change in pull request #385: HBASE-22382 Refactor tests in TestFromClientSide

2019-07-22 Thread GitBox
Apache9 commented on a change in pull request #385: HBASE-22382 Refactor tests 
in TestFromClientSide
URL: https://github.com/apache/hbase/pull/385#discussion_r306101651
 
 

 ##
 File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
 ##
 @@ -5965,6 +5985,7 @@ public void testNullWithReverseScan() throws Exception {
   }
 
   @Test
+  @SuppressWarnings("checkstyle:MethodLength")
 
 Review comment:
   Ditto.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache9 commented on a change in pull request #385: HBASE-22382 Refactor tests in TestFromClientSide

2019-07-22 Thread GitBox
Apache9 commented on a change in pull request #385: HBASE-22382 Refactor tests 
in TestFromClientSide
URL: https://github.com/apache/hbase/pull/385#discussion_r306101530
 
 

 ##
 File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
 ##
 @@ -1234,7 +1246,14 @@ public void testNull() throws Exception {
   } catch (Exception e) {
 throw new IOException("Using a row with null qualifier threw 
exception, should ");
 
 Review comment:
   Not your fault but since this is a refactoring, let's fix the message?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache9 commented on a change in pull request #385: HBASE-22382 Refactor tests in TestFromClientSide

2019-07-22 Thread GitBox
Apache9 commented on a change in pull request #385: HBASE-22382 Refactor tests 
in TestFromClientSide
URL: https://github.com/apache/hbase/pull/385#discussion_r306101636
 
 

 ##
 File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
 ##
 @@ -1550,6 +1569,7 @@ public void testVersions() throws Exception {
   }
 
   @Test
+  @SuppressWarnings("checkstyle:MethodLength")
 
 Review comment:
   Maybe in the future we will also split these methods so let's do not 
suppress the warning?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22648) Snapshot TTL

2019-07-22 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890602#comment-16890602
 ] 

Hudson commented on HBASE-22648:


Results for branch branch-2
[build #2098 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2098/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2098//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2098//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2098//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Snapshot TTL
> 
>
> Key: HBASE-22648
> URL: https://issues.apache.org/jira/browse/HBASE-22648
> Project: HBase
>  Issue Type: New Feature
>  Components: snapshots
>Affects Versions: 3.0.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-22648-master-v2.patch, 
> HBASE-22648-master-v3.patch, HBASE-22648-master-v4.patch, 
> HBASE-22648-master-v5.patch, HBASE-22648-master-v6.patch, 
> HBASE-22648-master-v8.patch, HBASE-22648-master.patch, Screen Shot 2019-07-10 
> at 8.49.13 PM.png, Screen Shot 2019-07-10 at 8.52.30 PM.png, Screen Shot 
> 2019-07-10 at 9.06.36 PM.png, Screen Shot 2019-07-16 at 11.06.03 AM.png
>
>
> Snapshots have a lifecycle that is independent from the table from which they 
> are created. Although data in a table may be stored with TTL the data files 
> containing them become frozen by the snapshot. Space consumed by expired 
> cells will not be reclaimed by normal table housekeeping like compaction. 
> While this is expected it can be inconvenient at scale. When many snapshots 
> are under management and the data in various tables is expired by TTL some 
> notion of optional TTL (and optional default TTL) for snapshots could be 
> useful. It will help prevent the accumulation of junk files by automatically 
> dropping the snapshot after the assigned TTL, making their data files 
> eligible for cleaning. More comprehensive snapshot lifecycle management may 
> be considered in the future but this one case is expected to be immediately 
> useful given TTls on data are commonly applied for similar convenience. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Resolved] (HBASE-22676) Move all the code in hbase-rsgroup to hbase-server and remove hbase-rsgroup module

2019-07-22 Thread Duo Zhang (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang resolved HBASE-22676.
---
  Resolution: Fixed
Assignee: Duo Zhang
Hadoop Flags: Reviewed

Pushed to branch HBASE-22514.

Thanks [~openinx] for reviewing.

> Move all the code in hbase-rsgroup to hbase-server and remove hbase-rsgroup 
> module
> --
>
> Key: HBASE-22676
> URL: https://issues.apache.org/jira/browse/HBASE-22676
> Project: HBase
>  Issue Type: Sub-task
>  Components: build, pom, rsgroup
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: HBASE-22514
>
>
> Let's do this first and then try to refactor it.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22676) Move all the code in hbase-rsgroup to hbase-server and remove hbase-rsgroup module

2019-07-22 Thread Duo Zhang (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-22676:
--
Component/s: rsgroup
 pom
 build

> Move all the code in hbase-rsgroup to hbase-server and remove hbase-rsgroup 
> module
> --
>
> Key: HBASE-22676
> URL: https://issues.apache.org/jira/browse/HBASE-22676
> Project: HBase
>  Issue Type: Sub-task
>  Components: build, pom, rsgroup
>Reporter: Duo Zhang
>Priority: Major
> Fix For: HBASE-22514
>
>
> Let's do this first and then try to refactor it.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22676) Move all the code in hbase-rsgroup to hbase-server and remove hbase-rsgroup module

2019-07-22 Thread Duo Zhang (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-22676:
--
Fix Version/s: HBASE-22514

> Move all the code in hbase-rsgroup to hbase-server and remove hbase-rsgroup 
> module
> --
>
> Key: HBASE-22676
> URL: https://issues.apache.org/jira/browse/HBASE-22676
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Duo Zhang
>Priority: Major
> Fix For: HBASE-22514
>
>
> Let's do this first and then try to refactor it.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache-HBase commented on issue #326: HBASE-22613: Bump Apache Avro to 1.9.0

2019-07-22 Thread GitBox
Apache-HBase commented on issue #326: HBASE-22613: Bump Apache Avro to 1.9.0
URL: https://github.com/apache/hbase/pull/326#issuecomment-514021055
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 31 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 12 | Maven dependency ordering for branch |
   | +1 | mvninstall | 230 | master passed |
   | +1 | compile | 164 | master passed |
   | +1 | shadedjars | 272 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 173 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 13 | Maven dependency ordering for patch |
   | -1 | mvninstall | 239 | root in the patch failed. |
   | +1 | compile | 165 | the patch passed |
   | +1 | javac | 165 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | xml | 2 | The patch has no ill-formed XML file. |
   | +1 | shadedjars | 267 | patch has no errors when building our shaded 
downstream artifacts. |
   | -1 | hadoopcheck | 243 | The patch causes 12 errors with Hadoop v2.8.5. |
   | -1 | hadoopcheck | 478 | The patch causes 12 errors with Hadoop v2.9.2. |
   | -1 | hadoopcheck | 722 | The patch causes 12 errors with Hadoop v3.1.2. |
   | +1 | javadoc | 168 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 10599 | root in the patch failed. |
   | +1 | asflicense | 61 | The patch does not generate ASF License warnings. |
   | | | 13192 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.mapreduce.TestSyncTable |
   |   | hadoop.hbase.mapreduce.TestWALRecordReader |
   |   | hadoop.hbase.mapreduce.TestTableInputFormatScanYYXToEmpty |
   |   | hadoop.hbase.mapreduce.TestWALPlayer |
   |   | hadoop.hbase.regionserver.TestCompactionTool |
   |   | hadoop.hbase.mapreduce.TestCopyTable |
   |   | hadoop.hbase.mapreduce.TestHashTable |
   |   | hadoop.hbase.mapreduce.TestTimeRangeMapRed |
   |   | hadoop.hbase.mapreduce.TestRowCounter |
   |   | hadoop.hbase.mapreduce.TestTableInputFormatScanEmptyToEmpty |
   |   | hadoop.hbase.mapreduce.TestImportExport |
   |   | hadoop.hbase.mapreduce.TestTableInputFormatScanEmptyToAPP |
   |   | hadoop.hbase.mapred.TestTableMapReduce |
   |   | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory |
   |   | hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels |
   |   | hadoop.hbase.mapreduce.TestCellCounter |
   |   | hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs |
   |   | hadoop.hbase.mapreduce.TestTableMapReduce |
   |   | hadoop.hbase.mapred.TestMultiTableSnapshotInputFormat |
   |   | hadoop.hbase.mapreduce.TestTableInputFormatScanYZYToEmpty |
   |   | hadoop.hbase.mapreduce.TestTableInputFormatScanEmptyToBBB |
   |   | hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat |
   |   | hadoop.hbase.mapreduce.TestTableInputFormatScanOBBToOPP |
   |   | hadoop.hbase.mapreduce.TestTableRecordReader |
   |   | hadoop.hbase.mapreduce.TestMultiTableInputFormat |
   |   | hadoop.hbase.mapreduce.TestTableInputFormatScanYYYToEmpty |
   |   | hadoop.hbase.mapreduce.TestTableInputFormat |
   |   | hadoop.hbase.mapreduce.TestHRegionPartitioner |
   |   | hadoop.hbase.mapreduce.TestHFileOutputFormat2 |
   |   | hadoop.hbase.mapreduce.TestImportTsv |
   |   | hadoop.hbase.mapreduce.TestMultithreadedTableMapper |
   |   | hadoop.hbase.snapshot.TestMobExportSnapshot |
   |   | hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes |
   |   | hadoop.hbase.snapshot.TestExportSnapshot |
   |   | hadoop.hbase.replication.TestVerifyReplication |
   |   | hadoop.hbase.mapred.TestTableSnapshotInputFormat |
   |   | hadoop.hbase.mapred.TestTableMapReduceUtil |
   |   | hadoop.hbase.mapreduce.TestImportTSVWithTTLs |
   |   | hadoop.hbase.mapreduce.TestTableInputFormatScanEmptyToBBA |
   |   | hadoop.hbase.mapreduce.TestTableSnapshotInputFormat |
   |   | hadoop.hbase.mapred.TestTableOutputFormatConnectionExhaust |
   |   | hadoop.hbase.mapreduce.TestTableInputFormatScanEmptyToOPP |
   |   | hadoop.hbase.mapreduce.TestTableInputFormatScanOPPToEmpty |
   |   | hadoop.hbase.mapreduce.TestTableInputFormatScanOBBToQPP |
   |   | hadoop.hbase.mapreduce.TestTableInputFormatScan |
   |   | hadoop.hbase.snapshot.TestSecureExportSnapshot |
   |   | hadoop.hbase.mapred.TestTableInputFormat |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.

[jira] [Commented] (HBASE-22613) Bump Apache Avro to 1.9.0

2019-07-22 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890592#comment-16890592
 ] 

Hadoop QA commented on HBASE-22613:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
31s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
32s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
53s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  3m 
59s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
27s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  4m  
3s{color} | {color:red} The patch causes 12 errors with Hadoop v2.8.5. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  7m 
58s{color} | {color:red} The patch causes 12 errors with Hadoop v2.9.2. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 12m  
2s{color} | {color:red} The patch causes 12 errors with Hadoop v3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
48s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}176m 39s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  1m 
 1s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}219m 52s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.mapreduce.TestSyncTable |
|   | hadoop.hbase.mapreduce.TestWALRecordReader |
|   | hadoop.hbase.mapreduce.TestTableInputFormatScanYYXToEmpty |
|   | hadoop.hbase.mapreduce.TestWALPlayer |
|   | hadoop.hbase.regionserver.TestCompactionTool |
|   | hadoop.hbase.mapreduce.TestCopyTable |
|   | hadoop.hbase.mapreduce.TestHashTable |
|   | hadoop.hbase.mapreduce.TestTimeRangeMapRed |
|   | hadoop.hbase.mapreduce.TestRowCounter |
|   | hadoop.hbase.mapreduce.TestTableInputFormatScanEmptyToEmpty |
|   | hadoop.hbase.mapreduce.TestImportExport |
|   | hadoop.hbase.mapreduce.TestTableInputFormatScanEmptyToAPP |
|   | hadoop.hbase.mapred.TestTableMapReduce |
|   | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory |
|   | hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels |
|   | hadoop.hbase.mapreduce.TestCellCounter |
|   | hadoop.hbase.

[GitHub] [hbase] Apache9 merged pull request #399: HBASE-22676 Move all the code in hbase-rsgroup to hbase-server and re…

2019-07-22 Thread GitBox
Apache9 merged pull request #399: HBASE-22676 Move all the code in 
hbase-rsgroup to hbase-server and re…
URL: https://github.com/apache/hbase/pull/399
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] openinx commented on issue #399: HBASE-22676 Move all the code in hbase-rsgroup to hbase-server and re…

2019-07-22 Thread GitBox
openinx commented on issue #399: HBASE-22676 Move all the code in hbase-rsgroup 
to hbase-server and re…
URL: https://github.com/apache/hbase/pull/399#issuecomment-514018746
 
 
   Let me have a check on my host...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache9 commented on issue #399: HBASE-22676 Move all the code in hbase-rsgroup to hbase-server and re…

2019-07-22 Thread GitBox
Apache9 commented on issue #399: HBASE-22676 Move all the code in hbase-rsgroup 
to hbase-server and re…
URL: https://github.com/apache/hbase/pull/399#issuecomment-514017272
 
 
   Not sure what's the problem but at least the mvn install failed also for the 
base branch...
   
   Anyway, the UTs are all passed, and tried locally, the mvn install also 
passed.
   
   Let me merge it back as this is on a feature branch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] brfrn169 closed pull request #380: HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+

2019-07-22 Thread GitBox
brfrn169 closed pull request #380: HBASE-22690 Deprecate / Remove 
OfflineMetaRepair in hbase-2+
URL: https://github.com/apache/hbase/pull/380
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] brfrn169 closed pull request #381: HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+

2019-07-22 Thread GitBox
brfrn169 closed pull request #381: HBASE-22690 Deprecate / Remove 
OfflineMetaRepair in hbase-2+
URL: https://github.com/apache/hbase/pull/381
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (HBASE-22690) Deprecate / Remove OfflineMetaRepair in hbase-2+

2019-07-22 Thread Toshihiro Suzuki (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Toshihiro Suzuki updated HBASE-22690:
-
  Resolution: Fixed
Hadoop Flags: Incompatible change,Reviewed
Release Note: 
OfflineMetaRepair is no longer supported in HBase-2+. Please refer to 
https://hbase.apache.org/book.html#HBCK2

This tool is deprecated in 2.x and will be removed in 3.0.
  Status: Resolved  (was: Patch Available)

> Deprecate / Remove OfflineMetaRepair in hbase-2+
> 
>
> Key: HBASE-22690
> URL: https://issues.apache.org/jira/browse/HBASE-22690
> Project: HBase
>  Issue Type: Improvement
>  Components: hbck2
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
>  Labels: hbck2
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22690.branch-2.0.001.patch, 
> HBASE-22690.branch-2.001.patch, HBASE-22690.branch-2.1.001.patch, 
> HBASE-22690.master.001.patch
>
>
> As discussed in the following thread, we can deprecate / remove 
> OfflineMetaRepair.
> https://lists.apache.org/thread.html/f122efdc79be541d678e22cf8cf573352ab468159596d820c38bf84b@%3Cdev.hbase.apache.org%3E
> Maybe we can deprecate in 2.x and remove in 3.0.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HBASE-22690) Deprecate / Remove OfflineMetaRepair in hbase-2+

2019-07-22 Thread Toshihiro Suzuki (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890581#comment-16890581
 ] 

Toshihiro Suzuki commented on HBASE-22690:
--

Pushed to branch-2+. Closing this.

> Deprecate / Remove OfflineMetaRepair in hbase-2+
> 
>
> Key: HBASE-22690
> URL: https://issues.apache.org/jira/browse/HBASE-22690
> Project: HBase
>  Issue Type: Improvement
>  Components: hbck2
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
>  Labels: hbck2
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22690.branch-2.0.001.patch, 
> HBASE-22690.branch-2.001.patch, HBASE-22690.branch-2.1.001.patch, 
> HBASE-22690.master.001.patch
>
>
> As discussed in the following thread, we can deprecate / remove 
> OfflineMetaRepair.
> https://lists.apache.org/thread.html/f122efdc79be541d678e22cf8cf573352ab468159596d820c38bf84b@%3Cdev.hbase.apache.org%3E
> Maybe we can deprecate in 2.x and remove in 3.0.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22690) Deprecate / Remove OfflineMetaRepair in hbase-2+

2019-07-22 Thread Toshihiro Suzuki (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Toshihiro Suzuki updated HBASE-22690:
-
Fix Version/s: 2.1.6
   2.0.6

> Deprecate / Remove OfflineMetaRepair in hbase-2+
> 
>
> Key: HBASE-22690
> URL: https://issues.apache.org/jira/browse/HBASE-22690
> Project: HBase
>  Issue Type: Improvement
>  Components: hbck2
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
>  Labels: hbck2
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22690.branch-2.0.001.patch, 
> HBASE-22690.branch-2.001.patch, HBASE-22690.branch-2.1.001.patch, 
> HBASE-22690.master.001.patch
>
>
> As discussed in the following thread, we can deprecate / remove 
> OfflineMetaRepair.
> https://lists.apache.org/thread.html/f122efdc79be541d678e22cf8cf573352ab468159596d820c38bf84b@%3Cdev.hbase.apache.org%3E
> Maybe we can deprecate in 2.x and remove in 3.0.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] infraio opened a new pull request #401: HBASE-22721 Refactor HBaseFsck: move the inner class out

2019-07-22 Thread GitBox
infraio opened a new pull request #401: HBASE-22721 Refactor HBaseFsck: move 
the inner class out
URL: https://github.com/apache/hbase/pull/401
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #336: HBASE-22580 Add a table attribute to make user scan snapshot feature configurable for table

2019-07-22 Thread GitBox
Apache-HBase commented on issue #336: HBASE-22580 Add a table attribute to make 
user scan snapshot feature configurable for table
URL: https://github.com/apache/hbase/pull/336#issuecomment-514014224
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 33 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 253 | master passed |
   | +1 | compile | 51 | master passed |
   | +1 | checkstyle | 72 | master passed |
   | +1 | shadedjars | 269 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 35 | master passed |
   | 0 | spotbugs | 248 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 244 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 251 | the patch passed |
   | +1 | compile | 55 | the patch passed |
   | +1 | javac | 55 | the patch passed |
   | +1 | checkstyle | 75 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 272 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 768 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 32 | the patch passed |
   | +1 | findbugs | 238 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 8028 | hbase-server in the patch failed. |
   | +1 | asflicense | 29 | The patch does not generate ASF License warnings. |
   | | | 11020 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.regionserver.wal.TestHBaseWalOnEC |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/14/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/336 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux f5eb29de4d02 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-336/out/precommit/personality/provided.sh
 |
   | git revision | master / 9615c644f5 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/14/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/14/testReport/
 |
   | Max. process+thread count | 4578 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/14/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


  1   2   3   >