[jira] [Commented] (HBASE-22632) SplitTableRegionProcedure and MergeTableRegionsProcedure should skip store files for unknown column families
[ https://issues.apache.org/jira/browse/HBASE-22632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906959#comment-16906959 ] Pankaj Kumar commented on HBASE-22632: -- Yeah, let me try... > SplitTableRegionProcedure and MergeTableRegionsProcedure should skip store > files for unknown column families > > > Key: HBASE-22632 > URL: https://issues.apache.org/jira/browse/HBASE-22632 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22632-UT.patch > > > Hit this problem in our internal staging cluster. Not sure why, but probably, > there was a partial successful 'alter table' call that removed a family. As > it is 'partial successful', there are still some stale store files of the > removed family left under the region directory. And in > SplitTableRegionProcedure and MergeTableRegionsProcedure, we will get all the > store files by listing the file system, so we will also get the stale store > files for the family which should have been removed already, and then causes > NPE when we want to access the ColumnFamilyDescriptor. > Although it is not the common case that there are store files for removed > families, but FWIW, I think we can do something to make our procedures more > robust... -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache9 commented on a change in pull request #486: HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
Apache9 commented on a change in pull request #486: HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot URL: https://github.com/apache/hbase/pull/486#discussion_r313725548 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1431,6 +1431,8 @@ private void startServiceThreads() throws IOException{ conf.getInt("hbase.master.executor.meta.serverops.threads", 5)); this.executorService.startExecutorService(ExecutorType.M_LOG_REPLAY_OPS, conf.getInt("hbase.master.executor.logreplayops.threads", 10)); + this.executorService.startExecutorService(ExecutorType.MASTER_SNAPSHOT_OPERATIONS, + conf.getInt("hbase.master.executor.snapshot.threads", 3)); Review comment: Better make a static field for this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #486: HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
Apache9 commented on a change in pull request #486: HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot URL: https://github.com/apache/hbase/pull/486#discussion_r313725311 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1431,6 +1431,8 @@ private void startServiceThreads() throws IOException{ conf.getInt("hbase.master.executor.meta.serverops.threads", 5)); this.executorService.startExecutorService(ExecutorType.M_LOG_REPLAY_OPS, conf.getInt("hbase.master.executor.logreplayops.threads", 10)); + this.executorService.startExecutorService(ExecutorType.MASTER_SNAPSHOT_OPERATIONS, Review comment: IIRC we only allow one snapshot at the same time? No? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #486: HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
Apache9 commented on a change in pull request #486: HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot URL: https://github.com/apache/hbase/pull/486#discussion_r313725028 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventType.java ## @@ -321,11 +321,6 @@ public static EventType get(final int code) { throw new IllegalArgumentException("Unknown code " + code); } - public boolean isOnlineSchemaChangeSupported() { Review comment: Not used any more? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22774) [WAL] RegionGroupingStrategy loses its function after split
[ https://issues.apache.org/jira/browse/HBASE-22774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906947#comment-16906947 ] Hudson commented on HBASE-22774: Results for branch branch-1 [build #1007 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1007/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1007//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1007//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1007//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > [WAL] RegionGroupingStrategy loses its function after split > --- > > Key: HBASE-22774 > URL: https://issues.apache.org/jira/browse/HBASE-22774 > Project: HBase > Issue Type: Bug > Components: Performance, wal >Affects Versions: 1.4.6 >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22774.branch-1.001.patch, > HBASE-22774.branch-1.002.patch > > > Having {{hbase.wal.provider}} set {{multiwal}}, it works fine on regionserver > restart, at the beginning. > But when region split happened, those daughter regions would inherit her > parent's WAL, which violates the setting. For example, when > {{hbase.wal.regiongrouping.strategy}} set {{identity}}, each daughter regions > should create its own WAL instead of inheriting. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22784) OldWALs not cleared in a replication slave cluster (cyclic replication bw 2 clusters)
[ https://issues.apache.org/jira/browse/HBASE-22784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906946#comment-16906946 ] Hudson commented on HBASE-22784: Results for branch branch-1 [build #1007 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1007/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1007//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1007//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1007//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > OldWALs not cleared in a replication slave cluster (cyclic replication bw 2 > clusters) > - > > Key: HBASE-22784 > URL: https://issues.apache.org/jira/browse/HBASE-22784 > Project: HBase > Issue Type: Bug > Components: regionserver, Replication >Affects Versions: 1.4.9, 1.4.10 >Reporter: Solvannan R M >Assignee: Wellington Chevreuil >Priority: Blocker > Fix For: 1.5.0, 1.4.11 > > Attachments: HBASE-22784.branch-1.001.patch, > HBASE-22784.branch-1.002.patch, HBASE-22784.branch-1.003.patch, > HBASE-22784.branch-1.004.patch > > > When a cluster is passive (receiving edits only via replication) in a cyclic > replication setup of 2 clusters, OldWALs size keeps on growing. On analysing, > we observed the following behaviour. > # New entry is added to WAL (Edit replicated from other cluster). > # ReplicationSourceWALReaderThread(RSWALRT) reads and applies the configured > filters (due to cyclic replication setup, ClusterMarkingEntryFilter discards > new entry from other cluster). > # Entry is null, RSWALRT neither updates the batch stats > (WALEntryBatch.lastWalPosition) nor puts it in the entryBatchQueue. > # ReplicationSource thread is blocked in entryBachQueue.take(). > # So ReplicationSource#updateLogPosition has never invoked and WAL file is > never cleared from ReplicationQueue. > # Hence LogCleaner on the master, doesn't deletes the oldWAL files from > hadoop. > NOTE: When a new edit is added via hbase-client, ReplicationSource thread > process and clears the oldWAL files from replication queues and hence master > cleans up the WALs > Please provide us a solution > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22828) Log a region close journal
[ https://issues.apache.org/jira/browse/HBASE-22828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906945#comment-16906945 ] Hudson commented on HBASE-22828: Results for branch branch-1 [build #1007 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1007/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1007//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1007//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1007//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > Log a region close journal > -- > > Key: HBASE-22828 > URL: https://issues.apache.org/jira/browse/HBASE-22828 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 3.0.0, 1.5.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11 > > Attachments: HBASE-22828-branch-1.patch, HBASE-22828.patch > > > We already track region close activity with a MonitoredTask. Enable the > status journal and dump it at DEBUG log level so if for some reasons region > closes are taking a long time we have a timestamped journal of the activity > and how long each step took. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22632) SplitTableRegionProcedure and MergeTableRegionsProcedure should skip store files for unknown column families
[ https://issues.apache.org/jira/browse/HBASE-22632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906942#comment-16906942 ] Duo Zhang commented on HBASE-22632: --- Good. Can you write a UT to reproduce the problem? If so, let's open an issue! [~pankaj2461]. Thanks. > SplitTableRegionProcedure and MergeTableRegionsProcedure should skip store > files for unknown column families > > > Key: HBASE-22632 > URL: https://issues.apache.org/jira/browse/HBASE-22632 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22632-UT.patch > > > Hit this problem in our internal staging cluster. Not sure why, but probably, > there was a partial successful 'alter table' call that removed a family. As > it is 'partial successful', there are still some stale store files of the > removed family left under the region directory. And in > SplitTableRegionProcedure and MergeTableRegionsProcedure, we will get all the > store files by listing the file system, so we will also get the stale store > files for the family which should have been removed already, and then causes > NPE when we want to access the ColumnFamilyDescriptor. > Although it is not the common case that there are store files for removed > families, but FWIW, I think we can do something to make our procedures more > robust... -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22632) SplitTableRegionProcedure and MergeTableRegionsProcedure should skip store files for unknown column families
[ https://issues.apache.org/jira/browse/HBASE-22632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906941#comment-16906941 ] Pankaj Kumar commented on HBASE-22632: -- {quote}there was a partial successful 'alter table' call that removed a family. As it is 'partial successful', there are still some stale store files of the removed family left under the region directory. {quote} I think the problem happens when we are trying to delete a CF dynamically (hbase.online.schema.update.enable is set as true) and if any region memstore contain entries for the deleted CF because we delete the from FS first and then reopen the region. During reopen RS will flush the memstore content to FS. > SplitTableRegionProcedure and MergeTableRegionsProcedure should skip store > files for unknown column families > > > Key: HBASE-22632 > URL: https://issues.apache.org/jira/browse/HBASE-22632 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22632-UT.patch > > > Hit this problem in our internal staging cluster. Not sure why, but probably, > there was a partial successful 'alter table' call that removed a family. As > it is 'partial successful', there are still some stale store files of the > removed family left under the region directory. And in > SplitTableRegionProcedure and MergeTableRegionsProcedure, we will get all the > store files by listing the file system, so we will also get the stale store > files for the family which should have been removed already, and then causes > NPE when we want to access the ColumnFamilyDescriptor. > Although it is not the common case that there are store files for removed > families, but FWIW, I think we can do something to make our procedures more > robust... -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22214) [2.x] Backport missing filter improvements
[ https://issues.apache.org/jira/browse/HBASE-22214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906934#comment-16906934 ] stack commented on HBASE-22214: --- [~elserj] If you around sir, you remember what went on here sir? I don't see this issue in commit log. Thanks. > [2.x] Backport missing filter improvements > -- > > Key: HBASE-22214 > URL: https://issues.apache.org/jira/browse/HBASE-22214 > Project: HBase > Issue Type: Bug > Components: Filters >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: 2.0.6, 2.1.5 > > > HBASE-19008 and HBASE-21129 were never backported beyond branch-2. I can't > find any reason that this was not done. Despite these being public-tagged > classes, no incompatible changes were added. > The lack of these changes prevents HBASE-22144 from being backported cleanly. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22828) Log a region close journal
[ https://issues.apache.org/jira/browse/HBASE-22828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906936#comment-16906936 ] Hudson commented on HBASE-22828: Results for branch branch-1.3 [build #917 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/917/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/917//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/917//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/917//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > Log a region close journal > -- > > Key: HBASE-22828 > URL: https://issues.apache.org/jira/browse/HBASE-22828 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 3.0.0, 1.5.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11 > > Attachments: HBASE-22828-branch-1.patch, HBASE-22828.patch > > > We already track region close activity with a MonitoredTask. Enable the > status journal and dump it at DEBUG log level so if for some reasons region > closes are taking a long time we have a timestamped journal of the activity > and how long each step took. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache9 commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator
Apache9 commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-521117908 Close since no big progress here. Can open a new PR which targets to branch-2 if you have time @sbarnoud . Or I will try to port the patch if I have time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 closed pull request #343: HBASE-22634 : Improve performance of BufferedMutator
Apache9 closed pull request #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-21884) Fix box/unbox findbugs warning in secure bulk load
[ https://issues.apache.org/jira/browse/HBASE-21884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-21884: -- Fix Version/s: (was: 2.0.6) 2.0.5 > Fix box/unbox findbugs warning in secure bulk load > -- > > Key: HBASE-21884 > URL: https://issues.apache.org/jira/browse/HBASE-21884 > Project: HBase > Issue Type: Task >Affects Versions: 3.0.0, 1.5.0, 2.2.0, 2.1.1, 2.0.3, 2.1.2, 2.0.4, 1.4.10, > 1.3.4, 1.2.11, 2.3.0 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Minor > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.5, 1.3.4, 1.2.11, > 2.3.0, 2.1.4 > > Attachments: HBASE-21884-branch-1.v0.patch, > HBASE-21884-master.v0.patch, HBASE-21884-master.v1.patch > > > {code} > ReasonTests > FindBugs module:hbase-server > Boxed value is unboxed and then immediately reboxed in > org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint.incrementUgiReference(UserGroupInformation) > At SecureBulkLoadEndpoint.java:then immediately reboxed in > org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint.incrementUgiReference(UserGroupInformation) > At SecureBulkLoadEndpoint.java:[line 268] > {code} > Looking at branch-2 and master I suspect we're doing the same wasteful > operation but findbugs can't see it through the lambda definition. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22828) Log a region close journal
[ https://issues.apache.org/jira/browse/HBASE-22828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906924#comment-16906924 ] Hudson commented on HBASE-22828: Results for branch branch-1.4 [build #956 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/956/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/956//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/956//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/956//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > Log a region close journal > -- > > Key: HBASE-22828 > URL: https://issues.apache.org/jira/browse/HBASE-22828 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 3.0.0, 1.5.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11 > > Attachments: HBASE-22828-branch-1.patch, HBASE-22828.patch > > > We already track region close activity with a MonitoredTask. Enable the > status journal and dump it at DEBUG log level so if for some reasons region > closes are taking a long time we have a timestamped journal of the activity > and how long each step took. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22784) OldWALs not cleared in a replication slave cluster (cyclic replication bw 2 clusters)
[ https://issues.apache.org/jira/browse/HBASE-22784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906925#comment-16906925 ] Hudson commented on HBASE-22784: Results for branch branch-1.4 [build #956 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/956/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/956//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/956//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/956//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > OldWALs not cleared in a replication slave cluster (cyclic replication bw 2 > clusters) > - > > Key: HBASE-22784 > URL: https://issues.apache.org/jira/browse/HBASE-22784 > Project: HBase > Issue Type: Bug > Components: regionserver, Replication >Affects Versions: 1.4.9, 1.4.10 >Reporter: Solvannan R M >Assignee: Wellington Chevreuil >Priority: Blocker > Fix For: 1.5.0, 1.4.11 > > Attachments: HBASE-22784.branch-1.001.patch, > HBASE-22784.branch-1.002.patch, HBASE-22784.branch-1.003.patch, > HBASE-22784.branch-1.004.patch > > > When a cluster is passive (receiving edits only via replication) in a cyclic > replication setup of 2 clusters, OldWALs size keeps on growing. On analysing, > we observed the following behaviour. > # New entry is added to WAL (Edit replicated from other cluster). > # ReplicationSourceWALReaderThread(RSWALRT) reads and applies the configured > filters (due to cyclic replication setup, ClusterMarkingEntryFilter discards > new entry from other cluster). > # Entry is null, RSWALRT neither updates the batch stats > (WALEntryBatch.lastWalPosition) nor puts it in the entryBatchQueue. > # ReplicationSource thread is blocked in entryBachQueue.take(). > # So ReplicationSource#updateLogPosition has never invoked and WAL file is > never cleared from ReplicationQueue. > # Hence LogCleaner on the master, doesn't deletes the oldWAL files from > hadoop. > NOTE: When a new edit is added via hbase-client, ReplicationSource thread > process and clears the oldWAL files from replication queues and hence master > cleans up the WALs > Please provide us a solution > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[ https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caroline updated HBASE-22804: - Attachment: (was: HBASE-22804.master.002.patch) > Provide an API to get list of successful regions and total expected regions > in Canary > - > > Key: HBASE-22804 > URL: https://issues.apache.org/jira/browse/HBASE-22804 > Project: HBase > Issue Type: Improvement > Components: canary >Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1 >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Labels: Canary > Attachments: HBASE-22804.branch-1.001.patch, > HBASE-22804.branch-1.002.patch, HBASE-22804.branch-2.001.patch, > HBASE-22804.branch-2.002.patch, HBASE-22804.master.001.patch, > HBASE-22804.master.002.patch, HBASE-22804.master.003.patch > > > At present HBase Canary tool only prints the successes as part of logs. > Providing an API to get the list of successes, as well as total number of > expected regions, will make it easier to get a more accurate availability > estimate. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[ https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caroline updated HBASE-22804: - Attachment: HBASE-22804.master.003.patch > Provide an API to get list of successful regions and total expected regions > in Canary > - > > Key: HBASE-22804 > URL: https://issues.apache.org/jira/browse/HBASE-22804 > Project: HBase > Issue Type: Improvement > Components: canary >Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1 >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Labels: Canary > Attachments: HBASE-22804.branch-1.001.patch, > HBASE-22804.branch-1.002.patch, HBASE-22804.branch-2.001.patch, > HBASE-22804.branch-2.002.patch, HBASE-22804.master.001.patch, > HBASE-22804.master.002.patch, HBASE-22804.master.003.patch > > > At present HBase Canary tool only prints the successes as part of logs. > Providing an API to get the list of successes, as well as total number of > expected regions, will make it easier to get a more accurate availability > estimate. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22750) Correct @throws in comment
[ https://issues.apache.org/jira/browse/HBASE-22750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22750: -- Fix Version/s: (was: 2.0.5) 2.0.6 > Correct @throws in comment > -- > > Key: HBASE-22750 > URL: https://issues.apache.org/jira/browse/HBASE-22750 > Project: HBase > Issue Type: Improvement > Components: Client, rpc >Affects Versions: 2.0.5 >Reporter: Wenqiang Li >Assignee: Wenqiang Li >Priority: Trivial > Fix For: 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > > Correct [@throws|https://github.com/throws] in comment. > In the comment of class > org.apache.hadoop.hbase.client.RetryingCallerInterceptor's method > public abstract void intercept( > RetryingCallerInterceptorContext abstractRetryingCallerInterceptorContext) > throws IOException; > It was a PreemptiveFastFailException before while it's current IOException -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22828) Log a region close journal
[ https://issues.apache.org/jira/browse/HBASE-22828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906901#comment-16906901 ] Hudson commented on HBASE-22828: Results for branch branch-2.1 [build #1481 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1481/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1481//General_Nightly_Build_Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1481//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1481//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Log a region close journal > -- > > Key: HBASE-22828 > URL: https://issues.apache.org/jira/browse/HBASE-22828 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 3.0.0, 1.5.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11 > > Attachments: HBASE-22828-branch-1.patch, HBASE-22828.patch > > > We already track region close activity with a MonitoredTask. Enable the > status journal and dump it at DEBUG log level so if for some reasons region > closes are taking a long time we have a timestamped journal of the activity > and how long each step took. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22845) Revert MetaTableAccessor#makePutFromTableState access to public
[ https://issues.apache.org/jira/browse/HBASE-22845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906900#comment-16906900 ] Hudson commented on HBASE-22845: Results for branch branch-2.1 [build #1481 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1481/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1481//General_Nightly_Build_Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1481//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1481//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Revert MetaTableAccessor#makePutFromTableState access to public > --- > > Key: HBASE-22845 > URL: https://issues.apache.org/jira/browse/HBASE-22845 > Project: HBase > Issue Type: Sub-task >Reporter: Sakthi >Assignee: Sakthi >Priority: Blocker > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > > Discussions in HBASE-22843. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-521110244 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 172 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 415 | branch-2.1 passed | | +1 | compile | 59 | branch-2.1 passed | | +1 | checkstyle | 40 | branch-2.1 passed | | +1 | shadedjars | 274 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 52 | branch-2.1 passed | | 0 | spotbugs | 92 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 83 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 337 | the patch passed | | +1 | compile | 25 | the patch passed | | +1 | javac | 25 | the patch passed | | +1 | checkstyle | 42 | hbase-client: The patch generated 0 new + 56 unchanged - 4 fixed = 56 total (was 60) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 265 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1343 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 27 | the patch passed | | +1 | findbugs | 83 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 206 | hbase-client in the patch passed. | | +1 | asflicense | 15 | The patch does not generate ASF License warnings. | | | | 3846 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/63/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/343 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux ee62889b94ba 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh | | git revision | branch-2.1 / 0c906f0fd0 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/63/testReport/ | | Max. process+thread count | 291 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/63/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22846) Internal Error 500 when Using HBASE REST API to Create Namespace.
[ https://issues.apache.org/jira/browse/HBASE-22846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906890#comment-16906890 ] Pankaj Kumar commented on HBASE-22846: -- I also observed this issue, here model is null in case of PUT with body. {code} @PUT @Consumes({MIMETYPE_XML, MIMETYPE_JSON, MIMETYPE_PROTOBUF, MIMETYPE_PROTOBUF_IETF}) public Response put(final NamespacesInstanceModel model, final @Context UriInfo uriInfo) {code} > Internal Error 500 when Using HBASE REST API to Create Namespace. > - > > Key: HBASE-22846 > URL: https://issues.apache.org/jira/browse/HBASE-22846 > Project: HBase > Issue Type: Improvement > Components: hbase-connectors >Affects Versions: 2.1.1 >Reporter: Sailesh Patel >Priority: Major > > When trying to the following URL to create namespace: > Secured cluster: curl --negotiate -u : -i -k -vi -X POST > "http://HBASE_REST_API_HOST:20550/namespaces/datasparktest"; > UnSecured cluster: curl -vi -X POST > "http://HBASE_REST_API_HOST:20550/namespaces/datasparktest"; > The following is returned on the console: > HTTP/1.1 500 Request failed. > The Error in Hbase REST Server log is: > 2019-08-13 15:44:55,080 WARN org.eclipse.jetty.servlet.ServletHandler: > javax.servlet.ServletException: java.lang.NullPointerException > at > org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:489) > at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:427) > ... > Caused by: java.lang.NullPointerException > at > org.apache.hadoop.hbase.rest.NamespacesInstanceResource.createOrUpdate(NamespacesInstanceResource.java:250) > at > org.apache.hadoop.hbase.rest.NamespacesInstanceResource.processUpdate(NamespacesInstanceResource.java:243) > at > org.apache.hadoop.hbase.rest.NamespacesInstanceResource.post(NamespacesInstanceResource.java:183) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory$1.invoke(ResourceMethodInvocationHandlerFactory.java:81) > at > org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:144) > at > org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:161) > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22013) SpaceQuota utilization issue with region replicas enabled
[ https://issues.apache.org/jira/browse/HBASE-22013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shardul Singh updated HBASE-22013: -- Fix Version/s: 2.1.0 > SpaceQuota utilization issue with region replicas enabled > - > > Key: HBASE-22013 > URL: https://issues.apache.org/jira/browse/HBASE-22013 > Project: HBase > Issue Type: Bug >Reporter: Ajeet Rai >Assignee: Shardul Singh >Priority: Major > Labels: Quota, Space > Fix For: 2.1.0 > > Attachments: HBASE-22013.master.v001.patch > > > Space Quota: Space Quota Issue: If a table is created with region replica > then quota calculation is not happening > Steps: > 1: Create a table with 100 regions with region replica 3 > 2: Observe that 'hbase:quota' table doesn't have entry of usage for this > table So In UI only policy Limit and Policy is shown but not Usage and State. > Reason: > It looks like File system utilization core is sending data of 100 reasons > but not the size of region replicas. > But in quota observer chore, it is considering total region(actual regions+ > replica reasons) > So the ratio of reported regions is less then configured > percentRegionsReportedThreshold. > SO quota calculation is not happening -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22146) SpaceQuotaViolationPolicy Disable is not working in Namespace level
[ https://issues.apache.org/jira/browse/HBASE-22146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22146: -- Fix Version/s: (was: 2.0.6) 2.0.7 > SpaceQuotaViolationPolicy Disable is not working in Namespace level > --- > > Key: HBASE-22146 > URL: https://issues.apache.org/jira/browse/HBASE-22146 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 2.0.0 >Reporter: Uma Maheswari >Assignee: Nihal Jain >Priority: Major > Labels: Quota, space > Fix For: 3.0.0, 2.1.7, 2.2.2, 2.0.7 > > > SpaceQuotaViolationPolicy Disable is not working in Namespace level > PFB the steps: > * Create Namespace and set Quota violation policy as Disable > * Create tables under namespace and violate Quota > Expected result: Tables to get disabled > Actual Result: Tables are not getting disabled > Note: mutation operation is not allowed on the table -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22605) Ref guide includes dev guidance only applicable to EOM versions
[ https://issues.apache.org/jira/browse/HBASE-22605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906880#comment-16906880 ] stack commented on HBASE-22605: --- Fixed 2.0 version. It went in after 2.0.5 went out so 2.0.6. > Ref guide includes dev guidance only applicable to EOM versions > --- > > Key: HBASE-22605 > URL: https://issues.apache.org/jira/browse/HBASE-22605 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Sean Busbey >Assignee: Mingliang Liu >Priority: Trivial > Labels: beginner > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.1.6 > > Attachments: HBASE-22605.000.patch > > > The ref guide section on developer guidance has this blurb: > {quote} > h2. Implementing Writable > h3. Applies pre-0.96 only > bq. In 0.96, HBase moved to protocol buffers (protobufs). The below section > on Writables applies to 0.94.x and previous, not to 0.96 and beyond. > Every class returned by RegionServers must implement the Writable interface. > If you are creating a new class that needs to implement this interface, do > not forget the default constructor. > {quote} > ([ref|http://hbase.apache.org/book.html#common.patch.feedback.writable]) > this should be removed. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22605) Ref guide includes dev guidance only applicable to EOM versions
[ https://issues.apache.org/jira/browse/HBASE-22605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22605: -- Fix Version/s: 2.0.6 > Ref guide includes dev guidance only applicable to EOM versions > --- > > Key: HBASE-22605 > URL: https://issues.apache.org/jira/browse/HBASE-22605 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Sean Busbey >Assignee: Mingliang Liu >Priority: Trivial > Labels: beginner > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.1.6 > > Attachments: HBASE-22605.000.patch > > > The ref guide section on developer guidance has this blurb: > {quote} > h2. Implementing Writable > h3. Applies pre-0.96 only > bq. In 0.96, HBase moved to protocol buffers (protobufs). The below section > on Writables applies to 0.94.x and previous, not to 0.96 and beyond. > Every class returned by RegionServers must implement the Writable interface. > If you are creating a new class that needs to implement this interface, do > not forget the default constructor. > {quote} > ([ref|http://hbase.apache.org/book.html#common.patch.feedback.writable]) > this should be removed. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22845) Revert MetaTableAccessor#makePutFromTableState access to public
[ https://issues.apache.org/jira/browse/HBASE-22845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906879#comment-16906879 ] Hudson commented on HBASE-22845: Results for branch branch-2.0 [build #1862 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1862/]: (/) *{color:green}+1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1862//General_Nightly_Build_Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1862//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1862//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > Revert MetaTableAccessor#makePutFromTableState access to public > --- > > Key: HBASE-22845 > URL: https://issues.apache.org/jira/browse/HBASE-22845 > Project: HBase > Issue Type: Sub-task >Reporter: Sakthi >Assignee: Sakthi >Priority: Blocker > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > > Discussions in HBASE-22843. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22013) SpaceQuota utilization issue with region replicas enabled
[ https://issues.apache.org/jira/browse/HBASE-22013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906878#comment-16906878 ] Shardul Singh commented on HBASE-22013: --- Thanks :) [~Uma Murugesan] > SpaceQuota utilization issue with region replicas enabled > - > > Key: HBASE-22013 > URL: https://issues.apache.org/jira/browse/HBASE-22013 > Project: HBase > Issue Type: Bug >Reporter: Ajeet Rai >Assignee: Shardul Singh >Priority: Major > Labels: Quota, Space > Attachments: HBASE-22013.master.v001.patch > > > Space Quota: Space Quota Issue: If a table is created with region replica > then quota calculation is not happening > Steps: > 1: Create a table with 100 regions with region replica 3 > 2: Observe that 'hbase:quota' table doesn't have entry of usage for this > table So In UI only policy Limit and Policy is shown but not Usage and State. > Reason: > It looks like File system utilization core is sending data of 100 reasons > but not the size of region replicas. > But in quota observer chore, it is considering total region(actual regions+ > replica reasons) > So the ratio of reported regions is less then configured > percentRegionsReportedThreshold. > SO quota calculation is not happening -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (HBASE-22013) SpaceQuota utilization issue with region replicas enabled
[ https://issues.apache.org/jira/browse/HBASE-22013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shardul Singh reassigned HBASE-22013: - Assignee: Shardul Singh > SpaceQuota utilization issue with region replicas enabled > - > > Key: HBASE-22013 > URL: https://issues.apache.org/jira/browse/HBASE-22013 > Project: HBase > Issue Type: Bug >Reporter: Ajeet Rai >Assignee: Shardul Singh >Priority: Major > Labels: Quota, Space > Attachments: HBASE-22013.master.v001.patch > > > Space Quota: Space Quota Issue: If a table is created with region replica > then quota calculation is not happening > Steps: > 1: Create a table with 100 regions with region replica 3 > 2: Observe that 'hbase:quota' table doesn't have entry of usage for this > table So In UI only policy Limit and Policy is shown but not Usage and State. > Reason: > It looks like File system utilization core is sending data of 100 reasons > but not the size of region replicas. > But in quota observer chore, it is considering total region(actual regions+ > replica reasons) > So the ratio of reported regions is less then configured > percentRegionsReportedThreshold. > SO quota calculation is not happening -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-521099190 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 136 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 474 | branch-2.1 passed | | +1 | compile | 29 | branch-2.1 passed | | +1 | checkstyle | 47 | branch-2.1 passed | | +1 | shadedjars | 319 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 28 | branch-2.1 passed | | 0 | spotbugs | 99 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 94 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 366 | the patch passed | | +1 | compile | 50 | the patch passed | | +1 | javac | 50 | the patch passed | | +1 | checkstyle | 54 | hbase-client: The patch generated 0 new + 56 unchanged - 4 fixed = 56 total (was 60) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 282 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1627 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 28 | the patch passed | | +1 | findbugs | 100 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 223 | hbase-client in the patch passed. | | +1 | asflicense | 15 | The patch does not generate ASF License warnings. | | | | 4294 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/62/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/343 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux aca5f00e913f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh | | git revision | branch-2.1 / fb7e7d810d | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/62/testReport/ | | Max. process+thread count | 298 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/62/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (HBASE-22013) SpaceQuota utilization issue with region replicas enabled
[ https://issues.apache.org/jira/browse/HBASE-22013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uma Maheswari reassigned HBASE-22013: - Assignee: (was: Uma Maheswari) > SpaceQuota utilization issue with region replicas enabled > - > > Key: HBASE-22013 > URL: https://issues.apache.org/jira/browse/HBASE-22013 > Project: HBase > Issue Type: Bug >Reporter: Ajeet Rai >Priority: Major > Labels: Quota, Space > Attachments: HBASE-22013.master.v001.patch > > > Space Quota: Space Quota Issue: If a table is created with region replica > then quota calculation is not happening > Steps: > 1: Create a table with 100 regions with region replica 3 > 2: Observe that 'hbase:quota' table doesn't have entry of usage for this > table So In UI only policy Limit and Policy is shown but not Usage and State. > Reason: > It looks like File system utilization core is sending data of 100 reasons > but not the size of region replicas. > But in quota observer chore, it is considering total region(actual regions+ > replica reasons) > So the ratio of reported regions is less then configured > percentRegionsReportedThreshold. > SO quota calculation is not happening -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (HBASE-22166) Space Quota issue: Namespace Quota policy is not getting imposed on the table in NS,when table level quota is set on the table and is violated and removed
[ https://issues.apache.org/jira/browse/HBASE-22166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uma Maheswari reassigned HBASE-22166: - Assignee: (was: Uma Maheswari) > Space Quota issue: Namespace Quota policy is not getting imposed on the table > in NS,when table level quota is set on the table and is violated and removed > -- > > Key: HBASE-22166 > URL: https://issues.apache.org/jira/browse/HBASE-22166 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 2.0.0 >Reporter: Uma Maheswari >Priority: Minor > Labels: Quota, space > > Space Quota issue: Namespace Quota policy is not getting imposed on the table > in NS,when table level quota is set on the table and is violated and removed > PFB the steps. > * create a NS and Set Quota > * create table under the NS and set Quota and write data to violate it > * Write data in NS and violate it > * Now remove the Quota in table level > Expected result: > * table should be moved to violation policy at NS level > Actual Result: > * NS level violation is shown in UI for the table > * in hbase:quota table no enry is present for that table > * violation policy is not imposed on the table > * insertion is allowed on the table which quota is removed -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (HBASE-22849) Put up 2.1.6RC0
[ https://issues.apache.org/jira/browse/HBASE-22849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-22849: - Assignee: Duo Zhang > Put up 2.1.6RC0 > --- > > Key: HBASE-22849 > URL: https://issues.apache.org/jira/browse/HBASE-22849 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work started] (HBASE-22849) Put up 2.1.6RC0
[ https://issues.apache.org/jira/browse/HBASE-22849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-22849 started by Duo Zhang. - > Put up 2.1.6RC0 > --- > > Key: HBASE-22849 > URL: https://issues.apache.org/jira/browse/HBASE-22849 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again
Apache-HBase commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again URL: https://github.com/apache/hbase/pull/456#issuecomment-521093662 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 81 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 331 | branch-2.1 passed | | +1 | compile | 63 | branch-2.1 passed | | +1 | checkstyle | 91 | branch-2.1 passed | | +1 | shadedjars | 264 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 37 | branch-2.1 passed | | 0 | spotbugs | 179 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 177 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 312 | the patch passed | | +1 | compile | 57 | the patch passed | | +1 | javac | 57 | the patch passed | | +1 | checkstyle | 86 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 265 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1351 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 35 | the patch passed | | +1 | findbugs | 200 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 13865 | hbase-server in the patch failed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 17643 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/24/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/456 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c44a63e33e95 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-456/out/precommit/personality/provided.sh | | git revision | branch-2.1 / e27ef92e3f | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/24/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/24/testReport/ | | Max. process+thread count | 4809 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/24/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22799) Generate CHANGES.md and RELEASENOTES.md for 2.1.6
[ https://issues.apache.org/jira/browse/HBASE-22799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906855#comment-16906855 ] Duo Zhang commented on HBASE-22799: --- The addendum I pushed to branch-2.1. > Generate CHANGES.md and RELEASENOTES.md for 2.1.6 > - > > Key: HBASE-22799 > URL: https://issues.apache.org/jira/browse/HBASE-22799 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.1.6 > > Attachments: HBASE-22799-addendum.patch > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22631) assign failed may make gced parent region appear again !!!
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906848#comment-16906848 ] yuhuiyang edited comment on HBASE-22631 at 8/14/19 3:54 AM: [~wchevreuil] The serverMap will be undated only for server tempt21 when unassignedprocedure (pid=3) works . But server tempt20 also contains the region in serverMap when unassignedprocedure(pid=3) finished . Because tempt20 tried to open this region in pid=1 and serverMap failed to remove this region from tempt20 according to serverMap . This is because regionNode.offline() was executed before env.getAssignmentManager().undoRegionAsOpening(regionNode) was finished . Server contains this region in serverMap for the region was opend in regionserver tempt21 finally . So server tempt20 and server tempt21 contain the region at the same time according to serverMap . And unassignedprocedure(pid=3) will not work for tempt20 . So i think it is different from [HBASE-21843|https://issues.apache.org/jira/browse/HBASE-21843]. was (Author: yu-huiyang): [~wchevreuil] The serverMap will be undated only for server tempt21 when unassignedprocedure (pid=3) works . But server tempt20 also contains the region in serverMap when unassignedprocedure(pid=3) finished . Because tempt20 tried to open this region in pid=1 and serverMap failed to remove this region from tempt20 according to serverMap . This is because regionNode.offline() was executed before env.getAssignmentManager().undoRegionAsOpening(regionNode) was finished . Server contains this region in serverMap for the region was opend in regionserver tempt21 finally . So server tempt20 and server tempt21 contain the region at the same time according to serverMap . And unassignedprocedure(pid=3) will not work for tempt20 . So i think it is different from [link title|https://issues.apache.org/jira/browse/HBASE-21843] . > assign failed may make gced parent region appear again !!! > -- > > Key: HBASE-22631 > URL: https://issues.apache.org/jira/browse/HBASE-22631 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Affects Versions: 2.1.1 >Reporter: yuhuiyang >Priority: Major > Attachments: HBASE-22631-branch-2.1-01.patch, assign.png, > assignProcedure.txt, serverCrash.png, splitAndGc.png > > > When i assign a region A the process is as follows: > step1 : A is assigned to rs1 , and rs1 fails to open it . > step2 : assignProcedure handleFailure . > step3 : A is assign to rs2 and rs success to open it . > Above is the normal flow . However when rs1 is restart after the reigon A was > split and GCRegionProcedure was successed , the region A appare again ! > The region is that reigon A is not removed from the serverMap correctly when > assignprocedure handleFailure . Because the code regionNode.offline() make > the regionNode's regionLocation to be null and make regionNode's state to > OFFLINE . So when the code > env.getAssignmentManager().undoRegionAsOpening(regionNode) do nothing . So > when the rs1 restart event triggers a serverCrashProcedure, it will get > reigons from serverMap and it will get the region A then A will be assigned > and hdfs dir will be created. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22799) Generate CHANGES.md and RELEASENOTES.md for 2.1.6
[ https://issues.apache.org/jira/browse/HBASE-22799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22799: -- Attachment: HBASE-22799-addendum.patch > Generate CHANGES.md and RELEASENOTES.md for 2.1.6 > - > > Key: HBASE-22799 > URL: https://issues.apache.org/jira/browse/HBASE-22799 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.1.6 > > Attachments: HBASE-22799-addendum.patch > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22631) assign failed may make gced parent region appear again !!!
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906848#comment-16906848 ] yuhuiyang edited comment on HBASE-22631 at 8/14/19 3:53 AM: [~wchevreuil] The serverMap will be undated only for server tempt21 when unassignedprocedure (pid=3) works . But server tempt20 also contains the region in serverMap when unassignedprocedure(pid=3) finished . Because tempt20 tried to open this region in pid=1 and serverMap failed to remove this region from tempt20 according to serverMap . This is because regionNode.offline() was executed before env.getAssignmentManager().undoRegionAsOpening(regionNode) was finished . Server contains this region in serverMap for the region was opend in regionserver tempt21 finally . So server tempt20 and server tempt21 contain the region at the same time according to serverMap . And unassignedprocedure(pid=3) will not work for tempt20 . So i think it is different from [link title|https://issues.apache.org/jira/browse/HBASE-21843] . was (Author: yu-huiyang): [~wchevreuil] The serverMap will be undated only for server tempt21 when unassignedprocedure (pid=3) works . But server tempt20 also contains the region in serverMap when unassignedprocedure(pid=3) finished . Because tempt20 tried to open this region in pid=1 and serverMap failed to remove this region from tempt20 according to serverMap . This is because regionNode.offline() was executed before env.getAssignmentManager().undoRegionAsOpening(regionNode) was finished . Server contains this region in serverMap for the region was opend in regionserver tempt21 finally . So server tempt20 and server tempt21 contain the region at the same time according to serverMap . And unassignedprocedure(pid=3) will not work for tempt20 . So i think it is different from link title . > assign failed may make gced parent region appear again !!! > -- > > Key: HBASE-22631 > URL: https://issues.apache.org/jira/browse/HBASE-22631 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Affects Versions: 2.1.1 >Reporter: yuhuiyang >Priority: Major > Attachments: HBASE-22631-branch-2.1-01.patch, assign.png, > assignProcedure.txt, serverCrash.png, splitAndGc.png > > > When i assign a region A the process is as follows: > step1 : A is assigned to rs1 , and rs1 fails to open it . > step2 : assignProcedure handleFailure . > step3 : A is assign to rs2 and rs success to open it . > Above is the normal flow . However when rs1 is restart after the reigon A was > split and GCRegionProcedure was successed , the region A appare again ! > The region is that reigon A is not removed from the serverMap correctly when > assignprocedure handleFailure . Because the code regionNode.offline() make > the regionNode's regionLocation to be null and make regionNode's state to > OFFLINE . So when the code > env.getAssignmentManager().undoRegionAsOpening(regionNode) do nothing . So > when the rs1 restart event triggers a serverCrashProcedure, it will get > reigons from serverMap and it will get the region A then A will be assigned > and hdfs dir will be created. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22631) assign failed may make gced parent region appear again !!!
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906848#comment-16906848 ] yuhuiyang edited comment on HBASE-22631 at 8/14/19 3:52 AM: [~wchevreuil] The serverMap will be undated only for server tempt21 when unassignedprocedure (pid=3) works . But server tempt20 also contains the region in serverMap when unassignedprocedure(pid=3) finished . Because tempt20 tried to open this region in pid=1 and serverMap failed to remove this region from tempt20 according to serverMap . This is because regionNode.offline() was executed before env.getAssignmentManager().undoRegionAsOpening(regionNode) was finished . Server contains this region in serverMap for the region was opend in regionserver tempt21 finally . So server tempt20 and server tempt21 contain the region at the same time according to serverMap . And unassignedprocedure(pid=3) will not work for tempt20 . So i think it is different from link title . was (Author: yu-huiyang): [~wchevreuil] The serverMap will be undated only for server tempt21 when unassignedprocedure (pid=3) works . But server tempt20 also contains the region in serverMap when unassignedprocedure(pid=3) happend . Because tempt20 tried to open this region in pid=1 and serverMap failed to remove this region from tempt20 according to serverMap . Finally the region is opend in regionserver tempt21 . So server tempt20 and server tempt21 contain the region as the same time according to serverMap . Because the offline was execute before undoRegionAsOpeningwas finished . So i think it is different from [link title|https://issues.apache.org/jira/browse/HBASE-21843] . > assign failed may make gced parent region appear again !!! > -- > > Key: HBASE-22631 > URL: https://issues.apache.org/jira/browse/HBASE-22631 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Affects Versions: 2.1.1 >Reporter: yuhuiyang >Priority: Major > Attachments: HBASE-22631-branch-2.1-01.patch, assign.png, > assignProcedure.txt, serverCrash.png, splitAndGc.png > > > When i assign a region A the process is as follows: > step1 : A is assigned to rs1 , and rs1 fails to open it . > step2 : assignProcedure handleFailure . > step3 : A is assign to rs2 and rs success to open it . > Above is the normal flow . However when rs1 is restart after the reigon A was > split and GCRegionProcedure was successed , the region A appare again ! > The region is that reigon A is not removed from the serverMap correctly when > assignprocedure handleFailure . Because the code regionNode.offline() make > the regionNode's regionLocation to be null and make regionNode's state to > OFFLINE . So when the code > env.getAssignmentManager().undoRegionAsOpening(regionNode) do nothing . So > when the rs1 restart event triggers a serverCrashProcedure, it will get > reigons from serverMap and it will get the region A then A will be assigned > and hdfs dir will be created. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (HBASE-22848) Set version as 2.1.6 in branch-2.1 in prep for first RC of 2.1.6
[ https://issues.apache.org/jira/browse/HBASE-22848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-22848. --- Resolution: Fixed Assignee: Duo Zhang Pushed to branch-2.1. > Set version as 2.1.6 in branch-2.1 in prep for first RC of 2.1.6 > > > Key: HBASE-22848 > URL: https://issues.apache.org/jira/browse/HBASE-22848 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.1.6 > > Attachments: HBASE-22848.patch > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22848) Set version as 2.1.6 in branch-2.1 in prep for first RC of 2.1.6
[ https://issues.apache.org/jira/browse/HBASE-22848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22848: -- Component/s: build > Set version as 2.1.6 in branch-2.1 in prep for first RC of 2.1.6 > > > Key: HBASE-22848 > URL: https://issues.apache.org/jira/browse/HBASE-22848 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Duo Zhang >Priority: Major > Fix For: 2.1.6 > > Attachments: HBASE-22848.patch > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22848) Set version as 2.1.6 in branch-2.1 in prep for first RC of 2.1.6
[ https://issues.apache.org/jira/browse/HBASE-22848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22848: -- Attachment: HBASE-22848.patch > Set version as 2.1.6 in branch-2.1 in prep for first RC of 2.1.6 > > > Key: HBASE-22848 > URL: https://issues.apache.org/jira/browse/HBASE-22848 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Priority: Major > Fix For: 2.1.6 > > Attachments: HBASE-22848.patch > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22848) Set version as 2.1.6 in branch-2.1 in prep for first RC of 2.1.6
[ https://issues.apache.org/jira/browse/HBASE-22848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22848: -- Fix Version/s: 2.1.6 > Set version as 2.1.6 in branch-2.1 in prep for first RC of 2.1.6 > > > Key: HBASE-22848 > URL: https://issues.apache.org/jira/browse/HBASE-22848 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Priority: Major > Fix For: 2.1.6 > > Attachments: HBASE-22848.patch > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility
Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/477#issuecomment-521091207 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 46 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 323 | master passed | | +1 | compile | 52 | master passed | | +1 | checkstyle | 85 | master passed | | +1 | shadedjars | 275 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | master passed | | 0 | spotbugs | 245 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 243 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 292 | the patch passed | | +1 | compile | 53 | the patch passed | | +1 | javac | 53 | the patch passed | | +1 | checkstyle | 81 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 263 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 898 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 256 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 14526 | hbase-server in the patch failed. | | -1 | asflicense | 24 | The patch generated 25 ASF License warnings. | | | | 17849 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotFromClientWithRegionReplicas | | | hadoop.hbase.TestNamespace | | | hadoop.hbase.regionserver.TestEncryptionRandomKeying | | | hadoop.hbase.security.visibility.TestVisibilityWithCheckAuths | | | hadoop.hbase.client.TestMobCloneSnapshotFromClientAfterSplittingRegion | | | hadoop.hbase.coprocessor.TestCoprocessorMetrics | | | hadoop.hbase.client.TestMobSnapshotFromClient | | | hadoop.hbase.procedure.TestFailedProcCleanup | | | hadoop.hbase.client.TestMobCloneSnapshotFromClientNormal | | | hadoop.hbase.security.token.TestDelegationTokenWithEncryption | | | hadoop.hbase.regionserver.TestRegionServerHostname | | | hadoop.hbase.replication.TestSerialReplicationFailover | | | hadoop.hbase.client.TestAsyncRegionLocator | | | hadoop.hbase.master.TestShutdownBackupMaster | | | hadoop.hbase.regionserver.TestRegionReplicasWithRestartScenarios | | | hadoop.hbase.coprocessor.TestPassCustomCellViaRegionObserver | | | hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalCopyToRemote | | | hadoop.hbase.replication.TestPerTableCFReplication | | | hadoop.hbase.client.TestScannerTimeout | | | hadoop.hbase.filter.TestFilterListOnMini | | | hadoop.hbase.client.TestServerBusyException | | | hadoop.hbase.replication.TestSyncReplicationRemoveRemoteWAL | | | hadoop.hbase.TestFullLogReconstruction | | | hadoop.hbase.replication.TestSyncReplicationStandbyKillRS | | | hadoop.hbase.client.TestAppendFromClientSide | | | hadoop.hbase.master.assignment.TestModifyTableWhileMerging | | | hadoop.hbase.coprocessor.TestIncrementAndAppendWithNullResult | | | hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithRemove | | | hadoop.hbase.master.assignment.TestTransitRegionStateProcedure | | | hadoop.hbase.regionserver.wal.TestAsyncFSWAL | | | hadoop.hbase.master.procedure.TestDisableTableProcedure | | | hadoop.hbase.quotas.TestQuotaTableUtil | | | hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL | | | hadoop.hbase.TestMovedRegionsCleaner | | | hadoop.hbase.master.TestMasterFailover | | | hadoop.hbase.wal.TestWALSplitBoundedLogWriterCreation | | | hadoop.hbase.client.TestAsyncReplicationAdminApi | | | hadoop.hbase.TestAcidGuaranteesWithBasicPolicy | | | hadoop.hbase.client.TestRestoreSnapshotFromClientGetCompactionState | | | hadoop.hbase.replication.TestNamespaceReplication | | | hadoop.hbase.coprocessor.TestRegionObserverInterface | | | hadoop.hbase.regionserver.TestClearRegionBlockCache | | | hadoop.hbase.client.TestResultFromCoprocessor | | | hadoop.hbase.client.TestAlwaysSetScannerId | | | hadoop.hbase.master.TestGetInfoPort | | | hadoop.hbase.replication.TestReplicationWithTags | | | hadoop.hbase.coprocessor.TestIncrementTimeRange | | | hadoop.hbase.client.TestAsyncRegionAdminApi | | | hadoop.hbase.maste
[jira] [Commented] (HBASE-22631) assign failed may make gced parent region appear again !!!
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906848#comment-16906848 ] yuhuiyang commented on HBASE-22631: --- [~wchevreuil] The serverMap will be undated only for server tempt21 when unassignedprocedure (pid=3) works . But server tempt20 also contains the region in serverMap when unassignedprocedure(pid=3) happend . Because tempt20 tried to open this region in pid=1 and serverMap failed to remove this region from tempt20 according to serverMap . Finally the region is opend in regionserver tempt21 . So server tempt20 and server tempt21 contain the region as the same time according to serverMap . Because the offline was execute before undoRegionAsOpeningwas finished . So i think it is different from [link title|https://issues.apache.org/jira/browse/HBASE-21843] . > assign failed may make gced parent region appear again !!! > -- > > Key: HBASE-22631 > URL: https://issues.apache.org/jira/browse/HBASE-22631 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Affects Versions: 2.1.1 >Reporter: yuhuiyang >Priority: Major > Attachments: HBASE-22631-branch-2.1-01.patch, assign.png, > assignProcedure.txt, serverCrash.png, splitAndGc.png > > > When i assign a region A the process is as follows: > step1 : A is assigned to rs1 , and rs1 fails to open it . > step2 : assignProcedure handleFailure . > step3 : A is assign to rs2 and rs success to open it . > Above is the normal flow . However when rs1 is restart after the reigon A was > split and GCRegionProcedure was successed , the region A appare again ! > The region is that reigon A is not removed from the serverMap correctly when > assignprocedure handleFailure . Because the code regionNode.offline() make > the regionNode's regionLocation to be null and make regionNode's state to > OFFLINE . So when the code > env.getAssignmentManager().undoRegionAsOpening(regionNode) do nothing . So > when the rs1 restart event triggers a serverCrashProcedure, it will get > reigons from serverMap and it will get the region A then A will be assigned > and hdfs dir will be created. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (HBASE-22849) Put up 2.1.6RC0
Duo Zhang created HBASE-22849: - Summary: Put up 2.1.6RC0 Key: HBASE-22849 URL: https://issues.apache.org/jira/browse/HBASE-22849 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (HBASE-22848) Set version as 2.1.6 in branch-2.1 in prep for first RC of 2.1.6
Duo Zhang created HBASE-22848: - Summary: Set version as 2.1.6 in branch-2.1 in prep for first RC of 2.1.6 Key: HBASE-22848 URL: https://issues.apache.org/jira/browse/HBASE-22848 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (HBASE-22799) Generate CHANGES.md and RELEASENOTES.md for 2.1.6
[ https://issues.apache.org/jira/browse/HBASE-22799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-22799. --- Resolution: Fixed Assignee: Duo Zhang Hadoop Flags: Reviewed Pushed to branch-2.1. Thanks [~zghaobac] for reviewing. > Generate CHANGES.md and RELEASENOTES.md for 2.1.6 > - > > Key: HBASE-22799 > URL: https://issues.apache.org/jira/browse/HBASE-22799 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.1.6 > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (HBASE-22847) Release 2.2.1
Guanghao Zhang created HBASE-22847: -- Summary: Release 2.2.1 Key: HBASE-22847 URL: https://issues.apache.org/jira/browse/HBASE-22847 Project: HBase Issue Type: Umbrella Reporter: Guanghao Zhang -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop
Apache-HBase commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-521089265 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 41 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 1 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 22 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 35 | Maven dependency ordering for branch | | +1 | mvninstall | 306 | master passed | | +1 | compile | 169 | master passed | | +1 | checkstyle | 143 | master passed | | +1 | shadedjars | 263 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 171 | master passed | | 0 | spotbugs | 26 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 26 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for patch | | +1 | mvninstall | 291 | the patch passed | | +1 | compile | 166 | the patch passed | | +1 | javac | 166 | the patch passed | | +1 | checkstyle | 139 | the patch passed | | +1 | shellcheck | 2 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 3 | The patch has no ill-formed XML file. | | +1 | shadedjars | 261 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 918 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 200 | the patch passed | | 0 | findbugs | 27 | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | -1 | unit | 11609 | root in the patch failed. | | -1 | asflicense | 87 | The patch generated 1 ASF License warnings. | | | | 17075 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAdminShell2 | | | hadoop.hbase.client.TestShell | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/11/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/476 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux ae5338c819c0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-476/out/precommit/personality/provided.sh | | git revision | master / 27ed2ac071 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/11/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/11/testReport/ | | asflicense | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/11/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 5521 (vs. ulimit of 1) | | modules | C: hbase-hbtop . hbase-assembly U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/11/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f…
Apache-HBase commented on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f… URL: https://github.com/apache/hbase/pull/484#issuecomment-521089204 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 953 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ branch-1.3 Compile Tests _ | | +1 | mvninstall | 443 | branch-1.3 passed | | +1 | compile | 38 | branch-1.3 passed with JDK v1.8.0_222 | | +1 | compile | 43 | branch-1.3 passed with JDK v1.7.0_232 | | +1 | checkstyle | 105 | branch-1.3 passed | | +1 | shadedjars | 169 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 37 | branch-1.3 passed with JDK v1.8.0_222 | | +1 | javadoc | 42 | branch-1.3 passed with JDK v1.7.0_232 | | 0 | spotbugs | 178 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 175 | branch-1.3 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 114 | the patch passed | | +1 | compile | 42 | the patch passed with JDK v1.8.0_222 | | +1 | javac | 42 | the patch passed | | +1 | compile | 44 | the patch passed with JDK v1.7.0_232 | | +1 | javac | 44 | the patch passed | | -1 | checkstyle | 97 | hbase-server: The patch generated 1 new + 372 unchanged - 23 fixed = 373 total (was 395) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 158 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 580 | Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7. | | +1 | javadoc | 30 | the patch passed with JDK v1.8.0_222 | | +1 | javadoc | 44 | the patch passed with JDK v1.7.0_232 | | +1 | findbugs | 179 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 5856 | hbase-server in the patch failed. | | +1 | asflicense | 21 | The patch does not generate ASF License warnings. | | | | 9270 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.util.TestHBaseFsck | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/484 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 487830f1ae51 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh | | git revision | branch-1.3 / 18c5abe | | Default Java | 1.7.0_232 | | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/3/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/3/testReport/ | | Max. process+thread count | 3996 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/3/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment
Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment URL: https://github.com/apache/hbase/pull/439#issuecomment-521088969 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 62 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 333 | master passed | | +1 | compile | 52 | master passed | | +1 | checkstyle | 75 | master passed | | +1 | shadedjars | 274 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 38 | master passed | | 0 | spotbugs | 249 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 246 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 317 | the patch passed | | +1 | compile | 57 | the patch passed | | +1 | javac | 57 | the patch passed | | +1 | checkstyle | 78 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 268 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 920 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 35 | the patch passed | | +1 | findbugs | 251 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 13540 | hbase-server in the patch failed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 16948 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestCloneSnapshotFromClientNormal | | | hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleWAL | | | hadoop.hbase.client.TestMobSnapshotCloneIndependence | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/49/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/439 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux dd9474274c71 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-439/out/precommit/personality/provided.sh | | git revision | master / 27ed2ac071 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/49/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/49/testReport/ | | Max. process+thread count | 4759 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/49/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #491: HBASE-22799 Generate CHANGES.md and RELEASENOTES.md for 2.1.6
Apache9 commented on a change in pull request #491: HBASE-22799 Generate CHANGES.md and RELEASENOTES.md for 2.1.6 URL: https://github.com/apache/hbase/pull/491#discussion_r313692021 ## File path: RELEASENOTES.md ## @@ -20,11 +20,177 @@ # Be careful doing manual edits in this file. Do not change format # of release header or remove the below marker. This file is generated. # DO NOT REMOVE THIS MARKER; FOR INTERPOLATING CHANGES!--> +# HBASE 2.1.6 Release Notes + +These release notes cover new developer and user-facing incompatibilities, important issues, features, and major improvements. + + +--- + +* [HBASE-22777](https://issues.apache.org/jira/browse/HBASE-22777) | *Major* | **Add a multi-region merge (for fixing overlaps, etc.)** + +Changes merge so you can merge more than two regions at a time. Currently only available inside HBase. HBASE-22827, a follow-on, is about exposing the facility in the Admin API (and then via the shell). + + +--- + +* [HBASE-15666](https://issues.apache.org/jira/browse/HBASE-15666) | *Critical* | **shaded dependencies for hbase-testing-util** + +New shaded artifact for testing: hbase-shaded-testing-util. + + +--- + +* [HBASE-22539](https://issues.apache.org/jira/browse/HBASE-22539) | *Blocker* | **WAL corruption due to early DBBs re-use when Durability.ASYNC\_WAL is used** + +We found a critical bug which can lead to WAL corruption when Durability.ASYNC\_WAL is used. The reason is that we release a ByteBuffer before actually persist the content into WAL file. + +The problem maybe lead to several errors, for example, ArrayIndexOfOutBounds when replaying WAL. This is because that the ByteBuffer is reused by others. + +ERROR org.apache.hadoop.hbase.executor.EventHandler: Caught throwable while processing event RS\_LOG\_REPLAY +java.lang.ArrayIndexOutOfBoundsException: 18056 +at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1365) +at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1358) +at org.apache.hadoop.hbase.PrivateCellUtil.matchingFamily(PrivateCellUtil.java:735) +at org.apache.hadoop.hbase.CellUtil.matchingFamily(CellUtil.java:816) +at org.apache.hadoop.hbase.wal.WALEdit.isMetaEditFamily(WALEdit.java:143) +at org.apache.hadoop.hbase.wal.WALEdit.isMetaEdit(WALEdit.java:148) +at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:297) +at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:195) +at org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:100) + +And may even cause segmentation fault and crash the JVM directly. You will see a hs\_err\_pidXXX.log file and usually the problem is SIGSEGV. This is usually because that the ByteBuffer has already been returned to the OS and used for other purpose. + +The problem has been reported several times in the past and this time Wellington Ramos Chevreuil provided the full logs and deeply analyzed the logs so we can find the root cause. And Lijin Bin figured out that the problem may only happen when Durability.ASYNC\_WAL is used. Thanks to them. + +The problem only effects the 2.x releases, all users are highly recommand to upgrade to a release which has this fix in, especially that if you use Durability.ASYNC\_WAL. + + +--- + +* [HBASE-22771](https://issues.apache.org/jira/browse/HBASE-22771) | *Major* | **[HBCK2] fixMeta method and server-side support** + +Adds a fixMeta method to hbck Service. Fixes holes in hbase:meta. Follow-up to fix overlaps. + +Follow-on is adding a client-side to hbase-operator-tools that can exploit this new addition (HBASE-22825) + + +--- + +* [HBASE-22737](https://issues.apache.org/jira/browse/HBASE-22737) | *Major* | **Add a new admin method and shell cmd to trigger the hbck chore to run** + +Add a new method runHbckChore in Hbck interface and a new shell cmd hbck\_chore\_run to request HBCK chore to run at master side. + + +--- + +* [HBASE-22741](https://issues.apache.org/jira/browse/HBASE-22741) | *Major* | **Show catalogjanitor consistency complaints in new 'HBCK Report' page** + +Adds a "CatalogJanitor hbase:meta Consistency Issues" section to the new 'HBCK Report' page added by HBASE-22709. This section is empty unless the most recent CatalogJanitor scan turned up problems. If so, will show table of issues found. + + +--- + +* [HBASE-22723](https://issues.apache.org/jira/browse/HBASE-22723) | *Major* | **Have CatalogJanitor report holes and overlaps; i.e. problems it sees when doing its regular scan of hbase:meta** + +When CatalogJanitor runs, it now checks for holes, overlaps, empty info:regioninfo columns and bad servers. Dumps findings into log. Follow-up adds report to new 'HBCK Report' linked off the Master UI. + +NOTE: All features but the badserver check made it into branch-2.1 and branch-2.0 backports. + + +--- + +* [HBASE-22709](https://issues.apache.org/jir
[GitHub] [hbase] Apache9 merged pull request #491: HBASE-22799 Generate CHANGES.md and RELEASENOTES.md for 2.1.6
Apache9 merged pull request #491: HBASE-22799 Generate CHANGES.md and RELEASENOTES.md for 2.1.6 URL: https://github.com/apache/hbase/pull/491 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#issuecomment-521087992 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 131 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 42 | Maven dependency ordering for branch | | +1 | mvninstall | 352 | master passed | | +1 | compile | 89 | master passed | | +1 | checkstyle | 119 | master passed | | +1 | shadedjars | 302 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 61 | master passed | | 0 | spotbugs | 301 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 360 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 334 | the patch passed | | +1 | compile | 88 | the patch passed | | +1 | javac | 88 | the patch passed | | +1 | checkstyle | 27 | hbase-common: The patch generated 0 new + 48 unchanged - 2 fixed = 48 total (was 50) | | +1 | checkstyle | 89 | The patch passed checkstyle in hbase-server | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 300 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1038 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 66 | the patch passed | | +1 | findbugs | 352 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 181 | hbase-common in the patch passed. | | +1 | unit | 12150 | hbase-server in the patch passed. | | +1 | asflicense | 46 | The patch does not generate ASF License warnings. | | | | 16578 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/479 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux bc062e63f2f1 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-479/out/precommit/personality/provided.sh | | git revision | master / 27ed2ac071 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/7/testReport/ | | Max. process+thread count | 5127 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/7/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] infraio commented on a change in pull request #491: HBASE-22799 Generate CHANGES.md and RELEASENOTES.md for 2.1.6
infraio commented on a change in pull request #491: HBASE-22799 Generate CHANGES.md and RELEASENOTES.md for 2.1.6 URL: https://github.com/apache/hbase/pull/491#discussion_r313691531 ## File path: RELEASENOTES.md ## @@ -20,11 +20,177 @@ # Be careful doing manual edits in this file. Do not change format # of release header or remove the below marker. This file is generated. # DO NOT REMOVE THIS MARKER; FOR INTERPOLATING CHANGES!--> +# HBASE 2.1.6 Release Notes + +These release notes cover new developer and user-facing incompatibilities, important issues, features, and major improvements. + + +--- + +* [HBASE-22777](https://issues.apache.org/jira/browse/HBASE-22777) | *Major* | **Add a multi-region merge (for fixing overlaps, etc.)** + +Changes merge so you can merge more than two regions at a time. Currently only available inside HBase. HBASE-22827, a follow-on, is about exposing the facility in the Admin API (and then via the shell). + + +--- + +* [HBASE-15666](https://issues.apache.org/jira/browse/HBASE-15666) | *Critical* | **shaded dependencies for hbase-testing-util** + +New shaded artifact for testing: hbase-shaded-testing-util. + + +--- + +* [HBASE-22539](https://issues.apache.org/jira/browse/HBASE-22539) | *Blocker* | **WAL corruption due to early DBBs re-use when Durability.ASYNC\_WAL is used** + +We found a critical bug which can lead to WAL corruption when Durability.ASYNC\_WAL is used. The reason is that we release a ByteBuffer before actually persist the content into WAL file. + +The problem maybe lead to several errors, for example, ArrayIndexOfOutBounds when replaying WAL. This is because that the ByteBuffer is reused by others. + +ERROR org.apache.hadoop.hbase.executor.EventHandler: Caught throwable while processing event RS\_LOG\_REPLAY +java.lang.ArrayIndexOutOfBoundsException: 18056 +at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1365) +at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1358) +at org.apache.hadoop.hbase.PrivateCellUtil.matchingFamily(PrivateCellUtil.java:735) +at org.apache.hadoop.hbase.CellUtil.matchingFamily(CellUtil.java:816) +at org.apache.hadoop.hbase.wal.WALEdit.isMetaEditFamily(WALEdit.java:143) +at org.apache.hadoop.hbase.wal.WALEdit.isMetaEdit(WALEdit.java:148) +at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:297) +at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:195) +at org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:100) + +And may even cause segmentation fault and crash the JVM directly. You will see a hs\_err\_pidXXX.log file and usually the problem is SIGSEGV. This is usually because that the ByteBuffer has already been returned to the OS and used for other purpose. + +The problem has been reported several times in the past and this time Wellington Ramos Chevreuil provided the full logs and deeply analyzed the logs so we can find the root cause. And Lijin Bin figured out that the problem may only happen when Durability.ASYNC\_WAL is used. Thanks to them. + +The problem only effects the 2.x releases, all users are highly recommand to upgrade to a release which has this fix in, especially that if you use Durability.ASYNC\_WAL. + + +--- + +* [HBASE-22771](https://issues.apache.org/jira/browse/HBASE-22771) | *Major* | **[HBCK2] fixMeta method and server-side support** + +Adds a fixMeta method to hbck Service. Fixes holes in hbase:meta. Follow-up to fix overlaps. + +Follow-on is adding a client-side to hbase-operator-tools that can exploit this new addition (HBASE-22825) + + +--- + +* [HBASE-22737](https://issues.apache.org/jira/browse/HBASE-22737) | *Major* | **Add a new admin method and shell cmd to trigger the hbck chore to run** + +Add a new method runHbckChore in Hbck interface and a new shell cmd hbck\_chore\_run to request HBCK chore to run at master side. + + +--- + +* [HBASE-22741](https://issues.apache.org/jira/browse/HBASE-22741) | *Major* | **Show catalogjanitor consistency complaints in new 'HBCK Report' page** + +Adds a "CatalogJanitor hbase:meta Consistency Issues" section to the new 'HBCK Report' page added by HBASE-22709. This section is empty unless the most recent CatalogJanitor scan turned up problems. If so, will show table of issues found. + + +--- + +* [HBASE-22723](https://issues.apache.org/jira/browse/HBASE-22723) | *Major* | **Have CatalogJanitor report holes and overlaps; i.e. problems it sees when doing its regular scan of hbase:meta** + +When CatalogJanitor runs, it now checks for holes, overlaps, empty info:regioninfo columns and bad servers. Dumps findings into log. Follow-up adds report to new 'HBCK Report' linked off the Master UI. + +NOTE: All features but the badserver check made it into branch-2.1 and branch-2.0 backports. + + +--- + +* [HBASE-22709](https://issues.apache.org/jir
[jira] [Updated] (HBASE-22774) [WAL] RegionGroupingStrategy loses its function after split
[ https://issues.apache.org/jira/browse/HBASE-22774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-22774: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) > [WAL] RegionGroupingStrategy loses its function after split > --- > > Key: HBASE-22774 > URL: https://issues.apache.org/jira/browse/HBASE-22774 > Project: HBase > Issue Type: Bug > Components: Performance, wal >Affects Versions: 1.4.6 >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22774.branch-1.001.patch, > HBASE-22774.branch-1.002.patch > > > Having {{hbase.wal.provider}} set {{multiwal}}, it works fine on regionserver > restart, at the beginning. > But when region split happened, those daughter regions would inherit her > parent's WAL, which violates the setting. For example, when > {{hbase.wal.regiongrouping.strategy}} set {{identity}}, each daughter regions > should create its own WAL instead of inheriting. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22774) [WAL] RegionGroupingStrategy loses its function after split
[ https://issues.apache.org/jira/browse/HBASE-22774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-22774: -- Fix Version/s: 1.4.11 1.3.6 1.5.0 > [WAL] RegionGroupingStrategy loses its function after split > --- > > Key: HBASE-22774 > URL: https://issues.apache.org/jira/browse/HBASE-22774 > Project: HBase > Issue Type: Bug > Components: Performance, wal >Affects Versions: 1.4.6 >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22774.branch-1.001.patch, > HBASE-22774.branch-1.002.patch > > > Having {{hbase.wal.provider}} set {{multiwal}}, it works fine on regionserver > restart, at the beginning. > But when region split happened, those daughter regions would inherit her > parent's WAL, which violates the setting. For example, when > {{hbase.wal.regiongrouping.strategy}} set {{identity}}, each daughter regions > should create its own WAL instead of inheriting. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #491: HBASE-22799 Generate CHANGES.md and RELEASENOTES.md for 2.1.6
Apache-HBase commented on issue #491: HBASE-22799 Generate CHANGES.md and RELEASENOTES.md for 2.1.6 URL: https://github.com/apache/hbase/pull/491#issuecomment-521087415 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 78 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | ||| _ branch-2.1 Compile Tests _ | ||| _ Patch Compile Tests _ | | +1 | whitespace | 0 | The patch has no whitespace issues. | ||| _ Other Tests _ | | +1 | asflicense | 22 | The patch does not generate ASF License warnings. | | | | 188 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-491/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/491 | | Optional Tests | dupname asflicense | | uname | Linux 2c9eedcdb871 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-491/out/precommit/personality/provided.sh | | git revision | branch-2.1 / e27ef92e3f | | Max. process+thread count | 47 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-491/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-521087178 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 93 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 35 | Maven dependency ordering for branch | | +1 | mvninstall | 344 | master passed | | +1 | compile | 89 | master passed | | +1 | checkstyle | 123 | master passed | | +1 | shadedjars | 303 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 66 | master passed | | 0 | spotbugs | 309 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 389 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 332 | the patch passed | | +1 | compile | 91 | the patch passed | | +1 | javac | 91 | the patch passed | | +1 | checkstyle | 120 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 299 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1056 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 65 | the patch passed | | +1 | findbugs | 384 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 115 | hbase-client in the patch passed. | | -1 | unit | 11856 | hbase-server in the patch failed. | | +1 | asflicense | 47 | The patch does not generate ASF License warnings. | | | | 16249 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/97/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux fea4295eb1c0 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / 27ed2ac071 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/97/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/97/testReport/ | | Max. process+thread count | 4768 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/97/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation
Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation URL: https://github.com/apache/hbase/pull/478#issuecomment-521086974 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 88 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 45 | Maven dependency ordering for branch | | +1 | mvninstall | 351 | master passed | | +1 | compile | 90 | master passed | | +1 | checkstyle | 126 | master passed | | +1 | shadedjars | 299 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 64 | master passed | | 0 | spotbugs | 311 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 392 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 341 | the patch passed | | +1 | compile | 90 | the patch passed | | +1 | javac | 90 | the patch passed | | +1 | checkstyle | 122 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 301 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1043 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 61 | the patch passed | | +1 | findbugs | 409 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 112 | hbase-client in the patch passed. | | -1 | unit | 11778 | hbase-server in the patch failed. | | +1 | asflicense | 51 | The patch does not generate ASF License warnings. | | | | 16208 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/478 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 559bea935b41 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-478/out/precommit/personality/provided.sh | | git revision | master / 27ed2ac071 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/9/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/9/testReport/ | | Max. process+thread count | 4896 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/9/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #460: HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split
Apache-HBase commented on issue #460: HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split URL: https://github.com/apache/hbase/pull/460#issuecomment-521086400 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 53 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +1 | mvninstall | 492 | branch-1 passed | | +1 | compile | 38 | branch-1 passed with JDK v1.8.0_222 | | +1 | compile | 42 | branch-1 passed with JDK v1.7.0_232 | | +1 | checkstyle | 92 | branch-1 passed | | +1 | shadedjars | 169 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | branch-1 passed with JDK v1.8.0_222 | | +1 | javadoc | 39 | branch-1 passed with JDK v1.7.0_232 | | 0 | spotbugs | 171 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 168 | branch-1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 105 | the patch passed | | +1 | compile | 40 | the patch passed with JDK v1.8.0_222 | | +1 | javac | 40 | the patch passed | | +1 | compile | 44 | the patch passed with JDK v1.7.0_232 | | +1 | javac | 44 | the patch passed | | +1 | checkstyle | 90 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 166 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 304 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 | javadoc | 31 | the patch passed with JDK v1.8.0_222 | | +1 | javadoc | 39 | the patch passed with JDK v1.7.0_232 | | +1 | findbugs | 171 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 6847 | hbase-server in the patch passed. | | +1 | asflicense | 24 | The patch does not generate ASF License warnings. | | | | 9205 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/460 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 194476b74556 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-460/out/precommit/personality/provided.sh | | git revision | branch-1 / 9821fd8 | | Default Java | 1.7.0_232 | | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/10/testReport/ | | Max. process+thread count | 4396 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/10/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #460: HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split
Apache-HBase commented on issue #460: HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split URL: https://github.com/apache/hbase/pull/460#issuecomment-521086360 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 1194 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +1 | mvninstall | 488 | branch-1 passed | | +1 | compile | 39 | branch-1 passed with JDK v1.8.0_222 | | +1 | compile | 42 | branch-1 passed with JDK v1.7.0_232 | | +1 | checkstyle | 90 | branch-1 passed | | +1 | shadedjars | 170 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 39 | branch-1 passed with JDK v1.8.0_222 | | +1 | javadoc | 38 | branch-1 passed with JDK v1.7.0_232 | | 0 | spotbugs | 167 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 164 | branch-1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 108 | the patch passed | | +1 | compile | 41 | the patch passed with JDK v1.8.0_222 | | +1 | javac | 41 | the patch passed | | +1 | compile | 46 | the patch passed with JDK v1.7.0_232 | | +1 | javac | 46 | the patch passed | | +1 | checkstyle | 87 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 161 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 284 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 | javadoc | 29 | the patch passed with JDK v1.8.0_222 | | +1 | javadoc | 40 | the patch passed with JDK v1.7.0_232 | | +1 | findbugs | 167 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 11306 | hbase-server in the patch failed. | | +1 | asflicense | 29 | The patch does not generate ASF License warnings. | | | | 14763 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAdmin2 | | | hadoop.hbase.replication.TestReplicationKillSlaveRS | | | hadoop.hbase.client.TestAdmin1 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/460 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux ee08c856ff10 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-460/out/precommit/personality/provided.sh | | git revision | branch-1 / 73a48b7 | | Default Java | 1.7.0_232 | | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/9/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/9/testReport/ | | Max. process+thread count | 4804 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/9/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #485: HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature
Apache-HBase commented on issue #485: HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature URL: https://github.com/apache/hbase/pull/485#issuecomment-521086020 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 112 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 376 | master passed | | +1 | compile | 57 | master passed | | +1 | checkstyle | 90 | master passed | | +1 | shadedjars | 291 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 38 | master passed | | 0 | spotbugs | 265 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 263 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 336 | the patch passed | | +1 | compile | 60 | the patch passed | | +1 | javac | 60 | the patch passed | | +1 | checkstyle | 88 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 304 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1052 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 37 | the patch passed | | +1 | findbugs | 287 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 12004 | hbase-server in the patch failed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 15847 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAsyncRegionAdminApi | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/485 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b97c032bf2ed 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-485@2/out/precommit/personality/provided.sh | | git revision | master / 27ed2ac071 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/5/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/5/testReport/ | | Max. process+thread count | 4743 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-521085979 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 132 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 374 | master passed | | +1 | compile | 62 | master passed | | +1 | checkstyle | 97 | master passed | | +1 | shadedjars | 301 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 37 | master passed | | 0 | spotbugs | 307 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 304 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 353 | the patch passed | | +1 | compile | 59 | the patch passed | | +1 | javac | 59 | the patch passed | | +1 | checkstyle | 91 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 308 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1037 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 37 | the patch passed | | +1 | findbugs | 294 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 11894 | hbase-server in the patch failed. | | +1 | asflicense | 32 | The patch does not generate ASF License warnings. | | | | 15819 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/18/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/468 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c42c0f8312f5 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh | | git revision | master / 27ed2ac071 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/18/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/18/testReport/ | | Max. process+thread count | 5146 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/18/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 opened a new pull request #491: HBASE-22799 Generate CHANGES.md and RELEASENOTES.md for 2.1.6
Apache9 opened a new pull request #491: HBASE-22799 Generate CHANGES.md and RELEASENOTES.md for 2.1.6 URL: https://github.com/apache/hbase/pull/491 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-21540) when set property "hbase.systemtables.compacting.memstore.type" to "basic" or "eager" will cause an exception
[ https://issues.apache.org/jira/browse/HBASE-21540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-21540: --- Fix Version/s: (was: 2.2.1) 2.2.2 > when set property "hbase.systemtables.compacting.memstore.type" to "basic" > or "eager" will cause an exception > --- > > Key: HBASE-21540 > URL: https://issues.apache.org/jira/browse/HBASE-21540 > Project: HBase > Issue Type: Bug > Components: conf >Affects Versions: 2.0.0 >Reporter: lixiaobao >Assignee: lixiaobao >Priority: Major > Fix For: 3.0.0, 2.0.0, 2.1.1, 2.2.2 > > Attachments: HBASE-21540-and-ut.patch, HBASE-21540.master.001.patch > > > when set property > "hbase.systemtables.compacting.memstore.type" value to lowercase (not > uppercase ) "basic" or "eager" will > cause an exception "java.lang.IllegalArgumentException: No enum constant > org.apache.hadoop.hbase.MemoryCompactionPolicy.basic | eager" > {code:java} > if (this.getTableName().isSystemTable()) { >inMemoryCompaction = > MemoryCompactionPolicy.valueOf(conf.get("hbase.systemtables.compacting.memstore.type", > "NONE").toUpperCase()); > } else { > inMemoryCompaction = family.getInMemoryCompaction(); > }{code} -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-21981) MMaped bucket cache IOEngine does not work with persistence
[ https://issues.apache.org/jira/browse/HBASE-21981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-21981: --- Fix Version/s: (was: 2.2.1) 2.2.2 > MMaped bucket cache IOEngine does not work with persistence > --- > > Key: HBASE-21981 > URL: https://issues.apache.org/jira/browse/HBASE-21981 > Project: HBase > Issue Type: Bug > Components: BucketCache >Affects Versions: 2.1.3 >Reporter: ramkrishna.s.vasudevan >Assignee: Anoop Sam John >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > Attachments: HBASE-21981.patch, HBASE-21981.patch > > > The MMap based IOEngines does not retrieve the data back if > 'hbase.bucketcache.persistent.path' is enabled. FileIOEngine works fine but > only the FileMMapEngine has this problem. > The reason is that we don't get the byte buffers in the proper order while > reading back from the file in case of persistence. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #483: HBASE-22841 Add more factory functions to TimeRange
Apache-HBase commented on issue #483: HBASE-22841 Add more factory functions to TimeRange URL: https://github.com/apache/hbase/pull/483#issuecomment-521085519 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 302 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 43 | Maven dependency ordering for branch | | +1 | mvninstall | 416 | master passed | | +1 | compile | 98 | master passed | | +1 | checkstyle | 127 | master passed | | +1 | shadedjars | 330 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 65 | master passed | | 0 | spotbugs | 295 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 357 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 391 | the patch passed | | +1 | compile | 98 | the patch passed | | +1 | javac | 98 | the patch passed | | +1 | checkstyle | 126 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 332 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1114 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 60 | the patch passed | | +1 | findbugs | 335 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 175 | hbase-common in the patch passed. | | -1 | unit | 10799 | hbase-server in the patch failed. | | +1 | asflicense | 46 | The patch does not generate ASF License warnings. | | | | 15648 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/483 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e8f5fa6a7636 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-483/out/precommit/personality/provided.sh | | git revision | master / 27ed2ac071 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/6/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/6/testReport/ | | Max. process+thread count | 4758 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22146) SpaceQuotaViolationPolicy Disable is not working in Namespace level
[ https://issues.apache.org/jira/browse/HBASE-22146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22146: --- Fix Version/s: (was: 2.2.1) 2.2.2 > SpaceQuotaViolationPolicy Disable is not working in Namespace level > --- > > Key: HBASE-22146 > URL: https://issues.apache.org/jira/browse/HBASE-22146 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 2.0.0 >Reporter: Uma Maheswari >Assignee: Nihal Jain >Priority: Major > Labels: Quota, space > Fix For: 3.0.0, 2.0.6, 2.1.7, 2.2.2 > > > SpaceQuotaViolationPolicy Disable is not working in Namespace level > PFB the steps: > * Create Namespace and set Quota violation policy as Disable > * Create tables under namespace and violate Quota > Expected result: Tables to get disabled > Actual Result: Tables are not getting disabled > Note: mutation operation is not allowed on the table -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22348) allow one to actually disable replication svc
[ https://issues.apache.org/jira/browse/HBASE-22348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22348: --- Fix Version/s: (was: 2.2.1) 2.2.2 > allow one to actually disable replication svc > - > > Key: HBASE-22348 > URL: https://issues.apache.org/jira/browse/HBASE-22348 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 2.2.0 >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Major > Labels: replication > Fix For: 2.2.2 > > Attachments: HBASE-22348.patch > > > Minor, but it does create extra ZK traffic for no reason and there's no way > to disable that it appears. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22356) API to get hdfs block distribution from regionservers
[ https://issues.apache.org/jira/browse/HBASE-22356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22356: --- Fix Version/s: (was: 2.2.1) 2.2.2 > API to get hdfs block distribution from regionservers > - > > Key: HBASE-22356 > URL: https://issues.apache.org/jira/browse/HBASE-22356 > Project: HBase > Issue Type: Sub-task > Components: API, Balancer, regionserver >Reporter: Thiruvel Thirumoolan >Assignee: Thiruvel Thirumoolan >Priority: Major > Labels: balancer > Fix For: 3.0.0, 1.5.0, 2.2.2 > > Attachments: HBASE-22356.master.001.patch, > HBASE-22356.master.002.patch > > > A RegionServer API has to be added which will return HDFSBlockDistribution > for all the regions it hosts. RS already has this info cached and updated > when flush/compaction happens. Master can query and get instead of hitting > the namenode and caching. The larger the cluster becomes, the more costly it > becomes to get this information and more stale the cached information becomes. > This jira is only to add the API to regionserver. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22380) break circle replication when doing bulkload
[ https://issues.apache.org/jira/browse/HBASE-22380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22380: --- Fix Version/s: (was: 2.2.1) 2.2.2 > break circle replication when doing bulkload > > > Key: HBASE-22380 > URL: https://issues.apache.org/jira/browse/HBASE-22380 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.5, 2.3.0, 2.1.5, 1.3.5 >Reporter: chenxu >Assignee: Zheng Hu >Priority: Critical > Labels: bulkload > Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.1.7, 2.2.2 > > > when enabled master-master bulkload replication, HFiles will be replicated > circularly between two clusters -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22640) Random init hstore lastFlushTime
[ https://issues.apache.org/jira/browse/HBASE-22640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22640: --- Fix Version/s: (was: 2.2.1) 2.2.2 > Random init hstore lastFlushTime > - > > Key: HBASE-22640 > URL: https://issues.apache.org/jira/browse/HBASE-22640 > Project: HBase > Issue Type: Improvement >Reporter: Bing Xiao >Assignee: Bing Xiao >Priority: Major > Fix For: 3.0.0, 2.2.2 > > Attachments: HBASE-22640-master-v1.patch > > > During with open region use current time as hstore last flush time, and no > mush data put cause memstore flush, after flushCheckInterval all memstore > will flush together bring concentrated IO and compaction make high request > latency;So random init lastFlushTime -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22822) Re/Un-schedule balancer chore for balance_switch
[ https://issues.apache.org/jira/browse/HBASE-22822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22822: --- Fix Version/s: (was: 2.2.1) 2.2.2 > Re/Un-schedule balancer chore for balance_switch > > > Key: HBASE-22822 > URL: https://issues.apache.org/jira/browse/HBASE-22822 > Project: HBase > Issue Type: Improvement > Components: Balancer, master >Affects Versions: 3.0.0, 1.5.0, 2.2.1 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.2.2 > > > balance_switch turns on/off balancer. When it is turned off, we don't remove > balancer chore from scheduled chores hence it keeps running only to > eventually find out that it is not supposed to perform any action(if balancer > was turned off). We can unschedule the chore to prevent the chore() execution > and reschedule it when it is turned on by balance_switch. > This should also facilitate running balancer immediately after triggering > balance_switch true, and then chore would continue running as per duration > provided in hbase.balancer.period. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22699) refactor isMetaClearingException
[ https://issues.apache.org/jira/browse/HBASE-22699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22699: --- Fix Version/s: (was: 2.2.1) 2.2.2 > refactor isMetaClearingException > > > Key: HBASE-22699 > URL: https://issues.apache.org/jira/browse/HBASE-22699 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Junhong Xu >Assignee: Junhong Xu >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > > It is not so readable -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22774) [WAL] RegionGroupingStrategy loses its function after split
[ https://issues.apache.org/jira/browse/HBASE-22774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906821#comment-16906821 ] Reid Chan commented on HBASE-22774: --- Checked master branch and branch-2.x. They look good, because wal is got from {{rs.getWAL(regionInfo)}} {code:title=AssignRegionHandler.java|borderStyle=solid} try { TableDescriptor htd = tableDesc != null ? tableDesc : rs.getTableDescriptors().get(regionInfo.getTable()); if (htd == null) { throw new IOException("Missing table descriptor for " + regionName); } // pass null for the last parameter, which used to be a CancelableProgressable, as now the // opening can not be interrupted by a close request any more. region = HRegion.openHRegion(regionInfo, htd, rs.getWAL(regionInfo), rs.getConfiguration(), rs, null); } catch (IOException e) { cleanUpAndReportFailure(e); return; } {code} > [WAL] RegionGroupingStrategy loses its function after split > --- > > Key: HBASE-22774 > URL: https://issues.apache.org/jira/browse/HBASE-22774 > Project: HBase > Issue Type: Bug > Components: Performance, wal >Affects Versions: 1.4.6 >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Major > Attachments: HBASE-22774.branch-1.001.patch, > HBASE-22774.branch-1.002.patch > > > Having {{hbase.wal.provider}} set {{multiwal}}, it works fine on regionserver > restart, at the beginning. > But when region split happened, those daughter regions would inherit her > parent's WAL, which violates the setting. For example, when > {{hbase.wal.regiongrouping.strategy}} set {{identity}}, each daughter regions > should create its own WAL instead of inheriting. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22846) Internal Error 500 when Using HBASE REST API to Create Namespace.
[ https://issues.apache.org/jira/browse/HBASE-22846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906818#comment-16906818 ] Zheng Hu commented on HBASE-22846: -- Want to create a github PR for this ? [~saileshpatel] > Internal Error 500 when Using HBASE REST API to Create Namespace. > - > > Key: HBASE-22846 > URL: https://issues.apache.org/jira/browse/HBASE-22846 > Project: HBase > Issue Type: Improvement > Components: hbase-connectors >Affects Versions: 2.1.1 >Reporter: Sailesh Patel >Priority: Major > > When trying to the following URL to create namespace: > Secured cluster: curl --negotiate -u : -i -k -vi -X POST > "http://HBASE_REST_API_HOST:20550/namespaces/datasparktest"; > UnSecured cluster: curl -vi -X POST > "http://HBASE_REST_API_HOST:20550/namespaces/datasparktest"; > The following is returned on the console: > HTTP/1.1 500 Request failed. > The Error in Hbase REST Server log is: > 2019-08-13 15:44:55,080 WARN org.eclipse.jetty.servlet.ServletHandler: > javax.servlet.ServletException: java.lang.NullPointerException > at > org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:489) > at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:427) > ... > Caused by: java.lang.NullPointerException > at > org.apache.hadoop.hbase.rest.NamespacesInstanceResource.createOrUpdate(NamespacesInstanceResource.java:250) > at > org.apache.hadoop.hbase.rest.NamespacesInstanceResource.processUpdate(NamespacesInstanceResource.java:243) > at > org.apache.hadoop.hbase.rest.NamespacesInstanceResource.post(NamespacesInstanceResource.java:183) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory$1.invoke(ResourceMethodInvocationHandlerFactory.java:81) > at > org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:144) > at > org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:161) > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22828) Log a region close journal
[ https://issues.apache.org/jira/browse/HBASE-22828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906817#comment-16906817 ] Hudson commented on HBASE-22828: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #616 (See [https://builds.apache.org/job/HBase-1.3-IT/616/]) HBASE-22828 Log a region close journal (#471) (apurtell: rev 18c5abe43ca476f58aab6dde8c8cb202363e5752) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Log a region close journal > -- > > Key: HBASE-22828 > URL: https://issues.apache.org/jira/browse/HBASE-22828 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 3.0.0, 1.5.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11 > > Attachments: HBASE-22828-branch-1.patch, HBASE-22828.patch > > > We already track region close activity with a MonitoredTask. Enable the > status journal and dump it at DEBUG log level so if for some reasons region > closes are taking a long time we have a timestamped journal of the activity > and how long each step took. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (HBASE-22645) Backport HBASE-19893 to all 2.x branches
[ https://issues.apache.org/jira/browse/HBASE-22645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-22645. --- Resolution: Duplicate Have already pushed the patch to branch-2.1 and branch-2.0 in HBASE-19893. > Backport HBASE-19893 to all 2.x branches > > > Key: HBASE-22645 > URL: https://issues.apache.org/jira/browse/HBASE-22645 > Project: HBase > Issue Type: Task > Components: snapshots >Reporter: Sakthi >Assignee: Sakthi >Priority: Major > Attachments: hbase-22645.branch-2.1.001.patch, > hbase-22645.branch-2.1.001.patch > > > HBASE-19893 is present in 2.3, 2.2 but not in 2.1 or 2.0. This Jira is to > backport it to both these branches as well. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-19893) restore_snapshot is broken in master branch when region splits
[ https://issues.apache.org/jira/browse/HBASE-19893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19893: -- Fix Version/s: 2.1.6 2.0.6 > restore_snapshot is broken in master branch when region splits > -- > > Key: HBASE-19893 > URL: https://issues.apache.org/jira/browse/HBASE-19893 > Project: HBase > Issue Type: Bug > Components: snapshots >Reporter: Toshihiro Suzuki >Assignee: Toshihiro Suzuki >Priority: Critical > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.6 > > Attachments: 19893.master.004.patch, 19893.master.004.patch, > 19893.master.004.patch, HBASE-19893.master.001.patch, > HBASE-19893.master.002.patch, HBASE-19893.master.003.patch, > HBASE-19893.master.003.patch, HBASE-19893.master.004.patch, > HBASE-19893.master.005.patch, HBASE-19893.master.005.patch, > HBASE-19893.master.005.patch, HBASE-19893.master.006.patch, > org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas-output.txt > > > When I was investigating HBASE-19850, I found restore_snapshot didn't work in > master branch. > > Steps to reproduce are as follows: > 1. Create a table > {code:java} > create "test", "cf" > {code} > 2. Load data (2000 rows) to the table > {code:java} > (0...2000).each{|i| put "test", "row#{i}", "cf:col", "val"} > {code} > 3. Split the table > {code:java} > split "test" > {code} > 4. Take a snapshot > {code:java} > snapshot "test", "snap" > {code} > 5. Load more data (2000 rows) to the table and split the table agin > {code:java} > (2000...4000).each{|i| put "test", "row#{i}", "cf:col", "val"} > split "test" > {code} > 6. Restore the table from the snapshot > {code:java} > disable "test" > restore_snapshot "snap" > enable "test" > {code} > 7. Scan the table > {code:java} > scan "test" > {code} > However, this scan returns only 244 rows (it should return 2000 rows) like > the following: > {code:java} > hbase(main):038:0> scan "test" > ROW COLUMN+CELL > row78 column=cf:col, timestamp=1517298307049, value=val > > row999 column=cf:col, timestamp=1517298307608, value=val > 244 row(s) > Took 0.1500 seconds > {code} > > Also, the restored table should have 2 online regions but it has 3 online > regions. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22645) Backport HBASE-19893 to all 2.x branches
[ https://issues.apache.org/jira/browse/HBASE-22645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22645: -- Fix Version/s: (was: 2.1.6) (was: 2.0.6) > Backport HBASE-19893 to all 2.x branches > > > Key: HBASE-22645 > URL: https://issues.apache.org/jira/browse/HBASE-22645 > Project: HBase > Issue Type: Task > Components: snapshots >Reporter: Sakthi >Assignee: Sakthi >Priority: Major > Attachments: hbase-22645.branch-2.1.001.patch, > hbase-22645.branch-2.1.001.patch > > > HBASE-19893 is present in 2.3, 2.2 but not in 2.1 or 2.0. This Jira is to > backport it to both these branches as well. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Reopened] (HBASE-22645) Backport HBASE-19893 to all 2.x branches
[ https://issues.apache.org/jira/browse/HBASE-22645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reopened HBASE-22645: --- We do not have the issue id in the commit history, so plan to resolve as duplicated and add the fix version in HBASE-19893. Sorry to [~jatsakthi]. > Backport HBASE-19893 to all 2.x branches > > > Key: HBASE-22645 > URL: https://issues.apache.org/jira/browse/HBASE-22645 > Project: HBase > Issue Type: Task > Components: snapshots >Reporter: Sakthi >Assignee: Sakthi >Priority: Major > Fix For: 2.0.6, 2.1.6 > > Attachments: hbase-22645.branch-2.1.001.patch, > hbase-22645.branch-2.1.001.patch > > > HBASE-19893 is present in 2.3, 2.2 but not in 2.1 or 2.0. This Jira is to > backport it to both these branches as well. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22440) HRegionServer#getWalGroupsReplicationStatus() throws NPE
[ https://issues.apache.org/jira/browse/HBASE-22440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22440: -- Fix Version/s: (was: 2.1.6) 2.1.5 > HRegionServer#getWalGroupsReplicationStatus() throws NPE > > > Key: HBASE-22440 > URL: https://issues.apache.org/jira/browse/HBASE-22440 > Project: HBase > Issue Type: Bug > Components: regionserver, Replication >Affects Versions: 2.1.4 >Reporter: puleya7 >Assignee: puleya7 >Priority: Major > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.5 > > Attachments: HBASE-22440.branch-1.001.patch, > HBASE-22440.branch-2.patch, HBASE-22440.master.002.patch, > HBASE-22440.master.patch > > > Precondition: > hbase.balancer.tablesOnMaster = true > hbase.balancer.tablesOnMaster.systemTablesOnly = true > > Open the rs page of the master throws NullPointException, because > replicationSourceHandler never initialized. > HRegionServer#getWalGroupsReplicationStatus() need check [is HMaster && CAN'T > host user region]. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22419) Backport hbase-personality changes in HBASE-22399 and HBASE-20970 to all active branches
[ https://issues.apache.org/jira/browse/HBASE-22419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22419: -- Fix Version/s: (was: 2.1.6) 2.1.5 > Backport hbase-personality changes in HBASE-22399 and HBASE-20970 to all > active branches > > > Key: HBASE-22419 > URL: https://issues.apache.org/jira/browse/HBASE-22419 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 1.4.10, 2.0.6, 2.1.5, 1.3.5 > > Attachments: HBASE-22419-branch-1.4.patch, > HBASE-22419-branch-2.0.patch, HBASE-22419-branch-2.1.patch > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22673) Avoid to expose protobuf stuff in Hbck interface
[ https://issues.apache.org/jira/browse/HBASE-22673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22673: -- Fix Version/s: (was: 2.1.6) > Avoid to expose protobuf stuff in Hbck interface > > > Key: HBASE-22673 > URL: https://issues.apache.org/jira/browse/HBASE-22673 > Project: HBase > Issue Type: Sub-task > Components: hbck2 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1 > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22148) Provide an alternative to CellUtil.setTimestamp
[ https://issues.apache.org/jira/browse/HBASE-22148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22148: -- Fix Version/s: (was: 2.1.6) 2.1.5 > Provide an alternative to CellUtil.setTimestamp > > > Key: HBASE-22148 > URL: https://issues.apache.org/jira/browse/HBASE-22148 > Project: HBase > Issue Type: New Feature > Components: API, Coprocessors >Affects Versions: 3.0.0 >Reporter: Thomas D'Silva >Assignee: Sean Busbey >Priority: Blocker > Labels: phoenix > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.5 > > Attachments: HBASE-22148-branch-2.v0.patch, HBASE-22148.0.patch > > > {{CellUtil.setTimestamp}} has been deprecated in 2.0 and is marked for > removal in 3.0. Phoenix currently uses this api to set the timestamp of cells > in its indexing coprocessor for tables that have mutable indexes. We can't > use the CellBuilder api since this involves creating a copy of the cell which > will be expensive. > FYI @stack -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22673) Avoid to expose protobuf stuff in Hbck interface
[ https://issues.apache.org/jira/browse/HBASE-22673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22673: -- Fix Version/s: 2.1.6 > Avoid to expose protobuf stuff in Hbck interface > > > Key: HBASE-22673 > URL: https://issues.apache.org/jira/browse/HBASE-22673 > Project: HBase > Issue Type: Sub-task > Components: hbck2 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6 > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22686) ZkSplitLogWorkerCoordination doesn't allow a regionserver to pick up all of the split work it is capable of
[ https://issues.apache.org/jira/browse/HBASE-22686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22686: -- Fix Version/s: (was: 2.1.7) 2.1.6 > ZkSplitLogWorkerCoordination doesn't allow a regionserver to pick up all of > the split work it is capable of > --- > > Key: HBASE-22686 > URL: https://issues.apache.org/jira/browse/HBASE-22686 > Project: HBase > Issue Type: Bug >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11 > > Attachments: HBASE-22686-branch-1.3.patch, > HBASE-22686-branch-1.3.patch, HBASE-22686-branch-1.patch, > HBASE-22686-branch-1.patch, HBASE-22686-branch-1.patch, HBASE-22686.patch, > HBASE-22686.patch, HBASE-22686.patch > > > A region hosted by a crashed regionserver cannot be reassigned until the > crashed regionserver's write-ahead logs have been processed and split into > per-region recovered edits files. Reassignment of a region from a crashed > server will be held up by the distributed split work backlog. Every > regionserver runs a background daemon thread that manages the acquisition and > execution of distributed log split tasks. This thread registers a watcher on > a znode managed by the master. When the master is processing a server > shutdown or crash or cluster restart when it detects the presence of > unprocessed WAL files it will register the WAL files for processing under the > znode. One or more live regionservers will attempt to get an exclusive lock > on an entry. One of them wins, splits the WAL file, deletes the entry, then > will acquire more work or go back to sleep if the worklist is empty. A > regionserver can acquire at most a fixed number of log split tasks determined > by configuration, hbase.regionserver.wal.max.splitters (default 2). If the > number of entries/logs to process exceeds the number of available split > workers in the cluster, perhaps due to the correlated failure of a > significant subset of the fleet, then splitting work will fall behind. > Regions may remain in RIT until the backlog is cleared. > However, the regionserver side coordination logic - > ZkSplitLogWorkerCoordination - only allows a regionserver to grab one task > one at a time. Nearby javadoc says "This policy puts an upper-limit on the > number of simultaneous log splitting that could be happening in a cluster." > That upper limit will be the number of currently live regionservers. I don't > feel I understand exactly why this is necessary or appropriate because a > regionserver can handle more than one task at once and in fact the max number > of concurrent split tasks it can accept is configurable. > {code:java} > /** >* This function calculates how many splitters it could create based on > expected average tasks per >* RS and the hard limit upper bound(maxConcurrentTasks) set by > configuration. >* At any given time, a RS allows spawn MIN(Expected Tasks/RS, Hard Upper > Bound) >* @param numTasks current total number of available tasks >*/ > private int calculateAvailableSplitters(int numTasks) { > // at lease one RS(itself) available > int availableRSs = 1; > try { > List regionServers = > ZKUtil.listChildrenNoWatch(watcher, watcher.rsZNode); > availableRSs = Math.max(availableRSs, (regionServers == null) ? 0 : > regionServers.size()); > } catch (KeeperException e) { > // do nothing > LOG.debug("getAvailableRegionServers got ZooKeeper exception", e); > } > int expectedTasksPerRS = (numTasks / availableRSs) + ((numTasks % > availableRSs == 0) ? 0 : 1); > expectedTasksPerRS = Math.max(1, expectedTasksPerRS); // at least be one > // calculate how many more splitters we could spawn > return Math.min(expectedTasksPerRS, maxConcurrentTasks) > - this.tasksInProgress.get(); > {code} > Shouldn't this simply be: > {code:java} > private int calculateAvailableSplitters() { > return maxConcurrentTasks - tasksInProgress.get(); > } > {code} > ? > This is branch-1. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (HBASE-22632) SplitTableRegionProcedure and MergeTableRegionsProcedure should skip store files for unknown column families
[ https://issues.apache.org/jira/browse/HBASE-22632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-22632. --- Resolution: Fixed Hadoop Flags: Reviewed Forget to resolve the issue... It has been pushed to branch-2.0+. Thanks [~zghaobac] for reviewing. > SplitTableRegionProcedure and MergeTableRegionsProcedure should skip store > files for unknown column families > > > Key: HBASE-22632 > URL: https://issues.apache.org/jira/browse/HBASE-22632 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22632-UT.patch > > > Hit this problem in our internal staging cluster. Not sure why, but probably, > there was a partial successful 'alter table' call that removed a family. As > it is 'partial successful', there are still some stale store files of the > removed family left under the region directory. And in > SplitTableRegionProcedure and MergeTableRegionsProcedure, we will get all the > store files by listing the file system, so we will also get the stale store > files for the family which should have been removed already, and then causes > NPE when we want to access the ColumnFamilyDescriptor. > Although it is not the common case that there are store files for removed > families, but FWIW, I think we can do something to make our procedures more > robust... -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22643) Delete region without archiving only if regiondir is present
[ https://issues.apache.org/jira/browse/HBASE-22643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22643: -- Fix Version/s: (was: 2.1.7) 2.1.6 > Delete region without archiving only if regiondir is present > > > Key: HBASE-22643 > URL: https://issues.apache.org/jira/browse/HBASE-22643 > Project: HBase > Issue Type: Improvement > Components: HFile >Affects Versions: 3.0.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6 > > Attachments: HBASE-22643-master-v1.patch, > HBASE-22643-master-v2.patch, HBASE-22643-master-v3.patch > > > Put a condition to delete region without archiving only if regionDir is > present -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22656) [Metrics] Tabe metrics 'BatchPut' and 'BatchDelete' are never updated
[ https://issues.apache.org/jira/browse/HBASE-22656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22656: -- Fix Version/s: (was: 2.1.7) > [Metrics] Tabe metrics 'BatchPut' and 'BatchDelete' are never updated > -- > > Key: HBASE-22656 > URL: https://issues.apache.org/jira/browse/HBASE-22656 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 1.4.11 > > Attachments: HBASE-22656.master.001.patch > > > {code} > public void updatePutBatch(TableName tn, long t) { > if (tableMetrics != null && tn != null) { > tableMetrics.updatePut(tn, t); // Here should use updatePutBatch > } > ... > } > public void updateDeleteBatch(TableName tn, long t) { > if (tableMetrics != null && tn != null) { > tableMetrics.updateDelete(tn, t); // Here should use updateDeleteBatch > } > ... > } > {code} -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22656) [Metrics] Tabe metrics 'BatchPut' and 'BatchDelete' are never updated
[ https://issues.apache.org/jira/browse/HBASE-22656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22656: -- Fix Version/s: 2.1.6 > [Metrics] Tabe metrics 'BatchPut' and 'BatchDelete' are never updated > -- > > Key: HBASE-22656 > URL: https://issues.apache.org/jira/browse/HBASE-22656 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.4.11 > > Attachments: HBASE-22656.master.001.patch > > > {code} > public void updatePutBatch(TableName tn, long t) { > if (tableMetrics != null && tn != null) { > tableMetrics.updatePut(tn, t); // Here should use updatePutBatch > } > ... > } > public void updateDeleteBatch(TableName tn, long t) { > if (tableMetrics != null && tn != null) { > tableMetrics.updateDelete(tn, t); // Here should use updateDeleteBatch > } > ... > } > {code} -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22632) SplitTableRegionProcedure and MergeTableRegionsProcedure should skip store files for unknown column families
[ https://issues.apache.org/jira/browse/HBASE-22632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22632: -- Fix Version/s: 2.1.6 2.2.1 2.0.6 2.3.0 3.0.0 > SplitTableRegionProcedure and MergeTableRegionsProcedure should skip store > files for unknown column families > > > Key: HBASE-22632 > URL: https://issues.apache.org/jira/browse/HBASE-22632 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22632-UT.patch > > > Hit this problem in our internal staging cluster. Not sure why, but probably, > there was a partial successful 'alter table' call that removed a family. As > it is 'partial successful', there are still some stale store files of the > removed family left under the region directory. And in > SplitTableRegionProcedure and MergeTableRegionsProcedure, we will get all the > store files by listing the file system, so we will also get the stale store > files for the family which should have been removed already, and then causes > NPE when we want to access the ColumnFamilyDescriptor. > Although it is not the common case that there are store files for removed > families, but FWIW, I think we can do something to make our procedures more > robust... -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Reidddddd merged pull request #460: HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split
Reidd merged pull request #460: HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split URL: https://github.com/apache/hbase/pull/460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22605) Ref guide includes dev guidance only applicable to EOM versions
[ https://issues.apache.org/jira/browse/HBASE-22605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906808#comment-16906808 ] Duo Zhang commented on HBASE-22605: --- Ping [~zghaobac] and [~stack] Please set the correct fix versions for branch-2.2 and branch-2.0? Thanks. > Ref guide includes dev guidance only applicable to EOM versions > --- > > Key: HBASE-22605 > URL: https://issues.apache.org/jira/browse/HBASE-22605 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Sean Busbey >Assignee: Mingliang Liu >Priority: Trivial > Labels: beginner > Fix For: 3.0.0, 2.3.0, 2.1.6 > > Attachments: HBASE-22605.000.patch > > > The ref guide section on developer guidance has this blurb: > {quote} > h2. Implementing Writable > h3. Applies pre-0.96 only > bq. In 0.96, HBase moved to protocol buffers (protobufs). The below section > on Writables applies to 0.94.x and previous, not to 0.96 and beyond. > Every class returned by RegionServers must implement the Writable interface. > If you are creating a new class that needs to implement this interface, do > not forget the default constructor. > {quote} > ([ref|http://hbase.apache.org/book.html#common.patch.feedback.writable]) > this should be removed. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22582) The Compaction writer may access the lastCell whose memory has been released when appending fileInfo in the final
[ https://issues.apache.org/jira/browse/HBASE-22582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22582: -- Fix Version/s: (was: 2.1.7) 2.1.6 > The Compaction writer may access the lastCell whose memory has been released > when appending fileInfo in the final > - > > Key: HBASE-22582 > URL: https://issues.apache.org/jira/browse/HBASE-22582 > Project: HBase > Issue Type: Bug > Components: Compaction >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > > Copy the comment from [~javaman_chen] under HBASE-21879: > https://issues.apache.org/jira/browse/HBASE-21879?focusedCommentId=16862244&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16862244 > In Compactor#compact, we have the following: > {code} > protected List compact(final CompactionRequest request... > ... > try { > ... > } finally { > Closeables.close(scanner, true); > if (!finished && writer != null) { > abortWriter(writer); > } > } > assert finished : "We should have exited the method on all error paths"; > assert writer != null : "Writer should be non-null if no error"; > return commitWriter(writer, fd, request); > } > {code} > should we call writer#beforeShipped() before Closeables.close(scanner, true); > In order to copy some cell's data out of the ByteBuff before it released, or > commitWriter may be wrong in the following call stack > {code} > Compactor#commitWriter > -> HFileWriterImpl#close > -> HFileWriterImpl#writeFileInfo >-> HFileWriterImpl#finishFileInfo > {code} > {code} > protected void finishFileInfo() throws IOException { > if (lastCell != null) { > // Make a copy. The copy is stuffed into our fileinfo map. Needs a clean > // byte buffer. Won't take a tuple. > byte [] lastKey = > PrivateCellUtil.getCellKeySerializedAsKeyValueKey(this.lastCell); > fileInfo.append(FileInfo.LASTKEY, lastKey, false); > } > ... > } > {code} > Because the lastCell may refer to a reused ByteBuff. > Checked the code, It's a bug and will need to fix in all 2.x & master branch. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22605) Ref guide includes dev guidance only applicable to EOM versions
[ https://issues.apache.org/jira/browse/HBASE-22605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22605: -- Fix Version/s: 2.1.6 2.3.0 3.0.0 > Ref guide includes dev guidance only applicable to EOM versions > --- > > Key: HBASE-22605 > URL: https://issues.apache.org/jira/browse/HBASE-22605 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Sean Busbey >Assignee: Mingliang Liu >Priority: Trivial > Labels: beginner > Fix For: 3.0.0, 2.3.0, 2.1.6 > > Attachments: HBASE-22605.000.patch > > > The ref guide section on developer guidance has this blurb: > {quote} > h2. Implementing Writable > h3. Applies pre-0.96 only > bq. In 0.96, HBase moved to protocol buffers (protobufs). The below section > on Writables applies to 0.94.x and previous, not to 0.96 and beyond. > Every class returned by RegionServers must implement the Writable interface. > If you are creating a new class that needs to implement this interface, do > not forget the default constructor. > {quote} > ([ref|http://hbase.apache.org/book.html#common.patch.feedback.writable]) > this should be removed. -- This message was sent by Atlassian JIRA (v7.6.14#76016)