date:20190816

virajjasani opened a new pull request #505: HBASE-22863 : Cleanup transitive 
Jackson1 vulnerable dependencies
URL: https://github.com/apache/hbase/pull/505
 
 
   Partly forwardport from: 
[HBASE-22728](https://issues.apache.org/jira/browse/HBASE-22728)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase



[ 
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909598#comment-16909598
 ] 

Hudson commented on HBASE-22514:


Results for branch HBASE-22514
[build #63 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/63/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/63//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/63//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/63//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
>  Issue Type: Umbrella
>  Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch, 
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public 
> we need to use java api  RSGroupAdminClient  to manager RSG 
> so  RSGroupAdminClient should be public
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…

Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if 
their RSGroup has no highest ve…
URL: https://github.com/apache/hbase/pull/435#issuecomment-522206917
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 41 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | 0 | shelldocs | 0 | Shelldocs was not available. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 38 | Maven dependency ordering for branch |
   | +1 | mvninstall | 340 | master passed |
   | +1 | compile | 98 | master passed |
   | +1 | checkstyle | 112 | master passed |
   | +1 | shadedjars | 285 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 72 | master passed |
   | 0 | spotbugs | 240 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 327 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | +1 | mvninstall | 302 | the patch passed |
   | +1 | compile | 94 | the patch passed |
   | +1 | javac | 94 | the patch passed |
   | -1 | checkstyle | 71 | hbase-server: The patch generated 1 new + 9 
unchanged - 0 fixed = 10 total (was 9) |
   | +1 | shellcheck | 0 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 269 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 916 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 69 | the patch passed |
   | -1 | findbugs | 53 | hbase-common generated 1 new + 0 unchanged - 0 fixed 
= 1 total (was 0) |
   ||| _ Other Tests _ |
   | +1 | unit | 174 | hbase-common in the patch passed. |
   | +1 | unit | 8677 | hbase-server in the patch passed. |
   | +1 | unit | 355 | hbase-rsgroup in the patch passed. |
   | +1 | asflicense | 69 | The patch does not generate ASF License warnings. |
   | | | 13114 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | FindBugs | module:hbase-common |
   |  |  org.apache.hadoop.hbase.Version.() 
invokes inefficient new String(String) constructor  At Version.java:inefficient 
new String(String) constructor  At Version.java:[line 10] |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/52/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/435 |
   | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc 
unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 1212796a0b3a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh
 |
   | git revision | master / 43a0ec80fa |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/52/artifact/out/diff-checkstyle-hbase-server.txt
 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/52/artifact/out/new-findbugs-hbase-common.html
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/52/testReport/
 |
   | Max. process+thread count | 4694 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-server hbase-rsgroup U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/52/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 
findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (HBASE-22866) Multiple slf4j-log4j provider versions included in binary package (branch-1)

2019-08-16 Thread Viraj Jasani (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-22866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viraj Jasani updated HBASE-22866:
-
Attachment: HBASE-22866.branch-1.000.patch

> Multiple slf4j-log4j provider versions included in binary package (branch-1)
> 
>
> Key: HBASE-22866
> URL: https://issues.apache.org/jira/browse/HBASE-22866
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Priority: Minor
> Fix For: 1.5.0
>
> Attachments: HBASE-22866.branch-1.000.patch
>
>
> Examining binary assembly results there are multiple versions of slf4j-log4j 
> in lib/
> {noformat}
> slf4j-api-1.7.7.jar
> slf4j-log4j12-1.6.1.jar
> slf4j-log4j12-1.7.10.jar
> slf4j-log4j12-1.7.7.jar
> {noformat}
> We aren't managing slf4j-log4j12 dependency versions correctly, somehow. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22866) Multiple slf4j-log4j provider versions included in binary package (branch-1)

2019-08-16 Thread Viraj Jasani (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909582#comment-16909582
 ] 

Viraj Jasani commented on HBASE-22866:
--

Oh yes, the top level parent pom has common version defined for slf4j-api but 
not for slf4j-log4j12.

Also, let's take this opportunity to upgrade slf4j version to 1.7.25(similar to 
master and branch-2). Should not be a big change, let me test and upload the 
patch quickly.

> Multiple slf4j-log4j provider versions included in binary package (branch-1)
> 
>
> Key: HBASE-22866
> URL: https://issues.apache.org/jira/browse/HBASE-22866
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Priority: Minor
> Fix For: 1.5.0
>
>
> Examining binary assembly results there are multiple versions of slf4j-log4j 
> in lib/
> {noformat}
> slf4j-api-1.7.7.jar
> slf4j-log4j12-1.6.1.jar
> slf4j-log4j12-1.7.10.jar
> slf4j-log4j12-1.7.7.jar
> {noformat}
> We aren't managing slf4j-log4j12 dependency versions correctly, somehow. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22464) Improvements to hbase-vote script

2019-08-16 Thread Sean Busbey (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909580#comment-16909580
 ] 

Sean Busbey commented on HBASE-22464:
-

When run with no arguments, the newly revamped {{run_tests}} fails:

{code}
+ execute run_tests
+ run_tests
+ rm -f 
/var/folders/_n/t65fnc5x3779rz5qfdgw0f8rgp/T/tmp.bgdowXku/2.0.6RC1_run_tests
+ mvn package '' -Dsurefire.rerunFailingTestsCount=3
+ tee 
/var/folders/_n/t65fnc5x3779rz5qfdgw0f8rgp/T/tmp.bgdowXku/2.0.6RC1_run_tests
[INFO] Scanning for projects...
...
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  3.427 s
[INFO] Finished at: 2019-08-16T19:35:21-05:00
[INFO] 
[ERROR] Unknown lifecycle phase "". You must specify a valid lifecycle phase or 
a goal in the format : or 
:[:]:. Available 
lifecycle phases are: validate, initialize, generate-sources, process-sources, 
generate-resources, process-resources, compile, process-classes, 
generate-test-sources, process-test-sources, generate-test-resources, 
process-test-resources, test-compile, process-test-classes, test, 
prepare-package, package, pre-integration-test, integration-test, 
post-integration-test, verify, install, deploy, pre-clean, clean, post-clean, 
pre-site, site, post-site, site-deploy. -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/LifecyclePhaseNotFoundException
{code}



> Improvements to hbase-vote script
> -
>
> Key: HBASE-22464
> URL: https://issues.apache.org/jira/browse/HBASE-22464
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.9, 1.3.4, 2.3.0, 2.1.4
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Trivial
> Attachments: HBASE-22464.branch-1.patch, HBASE-22464.v01.patch, 
> HBASE-22464.v02.patch, HBASE-22464.v03.patch, HBASE-22464.v04.patch, 
> HBASE-22464.v05.patch, HBASE-22464.v06.patch
>
>
> This Jira proposes to add the following two improvements:
>  # wget -N option for checking timestamp of downloaded RC files, if the local 
> copy of downloaded file is identical on the server, that file will be ignored.
>  # mvn -fn to never fail running the tests, previously with option -fae I 
> could not get the whole suite to run w/out failing.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [hbase] Reidddddd commented on issue #504: HBASE-22871 Move the DirScanPool out and do not use static field

Reidd commented on issue #504: HBASE-22871 Move the DirScanPool out and do 
not use static field
URL: https://github.com/apache/hbase/pull/504#issuecomment-522204797
 
 
   LGTM, just one nit.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Reidddddd commented on a change in pull request #504: HBASE-22871 Move the DirScanPool out and do not use static field

Reidd commented on a change in pull request #504: HBASE-22871 Move the 
DirScanPool out and do not use static field
URL: https://github.com/apache/hbase/pull/504#discussion_r314934449
 
 

 ##
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/DirScanPool.java
 ##
 @@ -0,0 +1,110 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.cleaner;
+
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.ForkJoinTask;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.conf.ConfigurationObserver;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * The thread pool used for scan directories
+ */
+@InterfaceAudience.Private
+public class DirScanPool implements ConfigurationObserver {
+  private static final Logger LOG = LoggerFactory.getLogger(DirScanPool.class);
+  private volatile int size;
+  private ForkJoinPool pool;
+  private int cleanerLatch;
+  private boolean reconfigNotification;
+
+  public DirScanPool(Configuration conf) {
+String poolSize = conf.get(CleanerChore.CHORE_POOL_SIZE, 
CleanerChore.DEFAULT_CHORE_POOL_SIZE);
+size = CleanerChore.calculatePoolSize(poolSize);
+// poolSize may be 0 or 0.0 from a careless configuration,
+// double check to make sure.
+size = size == 0 ? 
CleanerChore.calculatePoolSize(CleanerChore.DEFAULT_CHORE_POOL_SIZE) : size;
+pool = new ForkJoinPool(size);
+LOG.info("Cleaner pool size is {}", size);
+cleanerLatch = 0;
+  }
+
+  /**
+   * Checks if pool can be updated. If so, mark for update later.
+   * @param conf configuration
+   */
+  @Override
+  public synchronized void onConfigurationChange(Configuration conf) {
+int newSize = CleanerChore.calculatePoolSize(
+  conf.get(CleanerChore.CHORE_POOL_SIZE, 
CleanerChore.DEFAULT_CHORE_POOL_SIZE));
+if (newSize == size) {
+  LOG.trace("Size from configuration is same as previous={}, no need to 
update.", newSize);
+  return;
+}
+size = newSize;
+// Chore is working, update it later.
+reconfigNotification = true;
+  }
+
+  synchronized void latchCountUp() {
+cleanerLatch++;
+  }
+
+  synchronized void latchCountDown() {
+cleanerLatch--;
+notifyAll();
+  }
+
+  synchronized void execute(ForkJoinTask task) {
+pool.execute(task);
+  }
+
+  public synchronized void shutdownNow() {
+if (pool == null || pool.isShutdown()) {
+  return;
+}
+pool.shutdownNow();
+  }
+
+  synchronized void tryUpdatePoolSize(long timeout) {
+if (!reconfigNotification) {
+  return;
+}
+reconfigNotification = false;
+long stopTime = System.currentTimeMillis() + timeout;
+while (cleanerLatch != 0 && timeout > 0) {
+  try {
+wait(timeout);
+timeout = stopTime - System.currentTimeMillis();
+  } catch (InterruptedException ie) {
+Thread.currentThread().interrupt();
+break;
+  }
+}
+shutdownNow();
+LOG.info("Update chore's pool size from {} to {}", pool.getParallelism(), 
size);
+pool = new ForkJoinPool(size);
+  }
+
+  public int getSize() {
+return size;
+  }
+}
 
 Review comment:
   nit. empty line at the end of file.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Reidddddd commented on issue #503: HBASE-22870 reflection fails to access a private nested class

Reidd commented on issue #503: HBASE-22870 reflection fails to access a 
private nested class
URL: https://github.com/apache/hbase/pull/503#issuecomment-522204210
 
 
   Let's wait some time to see if any other comment. I'll will commit it 
tomorrow if no further comment.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] satanson commented on a change in pull request #503: HBASE-22870 reflection fails to access a private nested class

satanson commented on a change in pull request #503: HBASE-22870 reflection 
fails to access a private nested class
URL: https://github.com/apache/hbase/pull/503#discussion_r314934107
 
 

 ##
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
 ##
 @@ -3906,7 +3906,7 @@ public boolean isShutDown() {
   /**
* Force to terminate region server when abort timeout.
*/
-  private static class SystemExitWhenAbortTimeout extends TimerTask {
+  public static class SystemExitWhenAbortTimeout extends TimerTask {
 
 Review comment:
   @Reidd 
   done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] satanson commented on a change in pull request #503: HBASE-22870 reflection fails to access a private nested class

satanson commented on a change in pull request #503: HBASE-22870 reflection 
fails to access a private nested class
URL: https://github.com/apache/hbase/pull/503#discussion_r314933949
 
 

 ##
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
 ##
 @@ -3906,7 +3906,7 @@ public boolean isShutDown() {
   /**
* Force to terminate region server when abort timeout.
*/
-  private static class SystemExitWhenAbortTimeout extends TimerTask {
+  public static class SystemExitWhenAbortTimeout extends TimerTask {
 
 Review comment:
   ok, good suggest, setAccessible return void, so should write like this
   ```
   Constructor timerTaskCtor =
 Class.forName(conf.get(ABORT_TIMEOUT_TASK, 
SystemExitWhenAbortTimeout.class.getName()))
   .asSubclass(TimerTask.class).getDeclaredConstructor();
   timerTaskCtor.setAccessible(true);
   abortTimeoutTask = timerTaskCtor.newInstance();
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] satanson commented on a change in pull request #503: HBASE-22870 reflection fails to access a private nested class

satanson commented on a change in pull request #503: HBASE-22870 reflection 
fails to access a private nested class
URL: https://github.com/apache/hbase/pull/503#discussion_r314933949
 
 

 ##
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
 ##
 @@ -3906,7 +3906,7 @@ public boolean isShutDown() {
   /**
* Force to terminate region server when abort timeout.
*/
-  private static class SystemExitWhenAbortTimeout extends TimerTask {
+  public static class SystemExitWhenAbortTimeout extends TimerTask {
 
 Review comment:
   ok, good suggest, setAccessible return void, so should write like this
   ```
   Constructor taskClazz =
 
Class.forName(TestGetDelaredConstructor.SystemExitWhenAbortTimeout.class.getName())
   .asSubclass(TimerTask.class).getDeclaredConstructor();
   taskClazz.setAccessible(true);
   return taskClazz.newInstance();
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (HBASE-22871) Move the DirScanPool out and do not use static field

2019-08-16 Thread Duo Zhang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909572#comment-16909572
 ] 

Duo Zhang commented on HBASE-22871:
---

Ping [~openinx]. I think this could be applied before HBASE-22867 to make it 
easier to change the ForkJoinPool to another type of ThreadPool.

> Move the DirScanPool out and do not use static field
> 
>
> Key: HBASE-22871
> URL: https://issues.apache.org/jira/browse/HBASE-22871
> Project: HBase
>  Issue Type: Improvement
>  Components: master
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> The current implementation is a bit ugly, the onConfigurationChange is an 
> instance method but it writes to a static field and cause a findbugs warning. 
> I think we can just put the DirScanPool in HMaster and pass it when 
> constructing Cleaners...



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [hbase] Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload

Apache-HBase commented on issue #494: HBASE-22380 break circle replication when 
doing bulkload
URL: https://github.com/apache/hbase/pull/494#issuecomment-522203083
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 66 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ branch-2 Compile Tests _ |
   | 0 | mvndep | 17 | Maven dependency ordering for branch |
   | +1 | mvninstall | 439 | branch-2 passed |
   | +1 | compile | 140 | branch-2 passed |
   | +1 | checkstyle | 160 | branch-2 passed |
   | +1 | shadedjars | 335 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 88 | branch-2 passed |
   | 0 | spotbugs | 232 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 503 | branch-2 passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 19 | Maven dependency ordering for patch |
   | +1 | mvninstall | 368 | the patch passed |
   | +1 | compile | 144 | the patch passed |
   | +1 | cc | 144 | the patch passed |
   | +1 | javac | 144 | the patch passed |
   | -1 | checkstyle | 98 | hbase-server: The patch generated 2 new + 302 
unchanged - 0 fixed = 304 total (was 302) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 330 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1173 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | hbaseprotoc | 133 | the patch passed |
   | +1 | javadoc | 86 | the patch passed |
   | -1 | findbugs | 259 | hbase-server generated 1 new + 0 unchanged - 0 fixed 
= 1 total (was 0) |
   ||| _ Other Tests _ |
   | +1 | unit | 47 | hbase-protocol-shaded in the patch passed. |
   | +1 | unit | 237 | hbase-client in the patch passed. |
   | -1 | unit | 2026 | hbase-server in the patch failed. |
   | +1 | asflicense | 47 | The patch does not generate ASF License warnings. |
   | | | 7576 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | FindBugs | module:hbase-server |
   |  |  
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List,
 CellScanner, String, String, String) makes inefficient use of keySet iterator 
instead of entrySet iterator  At ReplicationSink.java:makes inefficient use of 
keySet iterator instead of entrySet iterator  At ReplicationSink.java:[line 
256] |
   | Failed junit tests | hadoop.hbase.regionserver.TestBulkLoad |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/10/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/494 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc |
   | uname | Linux 0d737c8f5317 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 
05:29:03 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
 |
   | git revision | branch-2 / 8cbe20c382 |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/10/artifact/out/diff-checkstyle-hbase-server.txt
 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/10/artifact/out/new-findbugs-hbase-server.html
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/10/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/10/testReport/
 |
   | Max. process+thread count | 696 (vs. ulimit of 1) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/10/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:

[GitHub] [hbase] Apache9 opened a new pull request #504: HBASE-22871 Move the DirScanPool out and do not use static field

Apache9 opened a new pull request #504: HBASE-22871 Move the DirScanPool out 
and do not use static field
URL: https://github.com/apache/hbase/pull/504
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Reidddddd commented on a change in pull request #503: HBASE-22870 reflection fails to access a private nested class

Reidd commented on a change in pull request #503: HBASE-22870 reflection 
fails to access a private nested class
URL: https://github.com/apache/hbase/pull/503#discussion_r314933324
 
 

 ##
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
 ##
 @@ -3906,7 +3906,7 @@ public boolean isShutDown() {
   /**
* Force to terminate region server when abort timeout.
*/
-  private static class SystemExitWhenAbortTimeout extends TimerTask {
+  public static class SystemExitWhenAbortTimeout extends TimerTask {
 
 Review comment:
   It is reasonable to keep it private since it is an inner task which should 
not be seen outside service.
   
   I suggest using 
   `getDeclaredConstructor().setAccessible(true).newInstance()` to bypass it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] satanson commented on issue #503: HBASE-22870 reflection fails to access a private nested class

satanson commented on issue #503: HBASE-22870 reflection fails to access a 
private nested class
URL: https://github.com/apache/hbase/pull/503#issuecomment-522201688
 
 
   > HBASE-22870, is it yours? Please update the description in JIRA too.
   
   @Reidd 
   Yes, jira just created by me a few minutes ago, I have add description 
detail to the ticket, and now both commit and merge request is assocated with 
HBASE-22870


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (HBASE-22870) reflection fails to access a private nested class

2019-08-16 Thread ranpanfeng (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-22870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ranpanfeng updated HBASE-22870:
---
Description: 
HMaster crashes at org/apache/hadoop/hbase/regionserver/HRegionServer.java:1044
*A private static nested class can not be instantiated via reflection.*

*code snippet*

 
{code:java}
 
try {
abortTimeoutTask =
Class.forName(conf.get(ABORT_TIMEOUT_TASK, 
SystemExitWhenAbortTimeout.class.getName()))
.asSubclass(TimerTask.class).getDeclaredConstructor().newInstance();
} catch (Exception e) {
LOG.warn("Initialize abort timeout task failed", e);
}{code}
 

 

*log in product environtment*


{code:java}
2019-08-16 18:01:40,737 [WARN ] HRegionServer:1046 Initialize abort timeout 
task failed
 java.lang.IllegalAccessException: Class 
org.apache.hadoop.hbase.regionserver.HRegionServer can not access a member of 
class org.apache.hadoop.hbase.regionss
 erver.HRegionServer$SystemExitWhenAbortTimeout with modifiers "private"
 at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:102)
 at 
java.lang.reflect.AccessibleObject.slowCheckMemberAccess(AccessibleObject.java:296)
 at java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:288)
 at java.lang.reflect.Constructor.newInstance(Constructor.java:413)
 at 
org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:1044)
 at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:598){code}

  was:
HMaster crashes at org/apache/hadoop/hbase/regionserver/HRegionServer.java:1044
**A private static nested class can not be instantiated via reflection.**

**code snippet**

```
 try {
 abortTimeoutTask =
 Class.forName(conf.get(ABORT_TIMEOUT_TASK, 
SystemExitWhenAbortTimeout.class.getName()))
 .asSubclass(TimerTask.class).getDeclaredConstructor().newInstance();
 } catch (Exception e) {
 LOG.warn("Initialize abort timeout task failed", e);
 }
```

**log in product environtment**
```
2019-08-16 18:01:40,737 [WARN ] HRegionServer:1046 Initialize abort timeout 
task failed
java.lang.IllegalAccessException: Class 
org.apache.hadoop.hbase.regionserver.HRegionServer can not access a member of 
class org.apache.hadoop.hbase.regionss
 erver.HRegionServer$SystemExitWhenAbortTimeout with modifiers "private"
 at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:102)
 at 
java.lang.reflect.AccessibleObject.slowCheckMemberAccess(AccessibleObject.java:296)
 at java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:288)
 at java.lang.reflect.Constructor.newInstance(Constructor.java:413)
 at 
org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:1044)
 at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:598)
```


> reflection fails to access a private nested class
> -
>
> Key: HBASE-22870
> URL: https://issues.apache.org/jira/browse/HBASE-22870
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.1.5
>Reporter: ranpanfeng
>Priority: Major
> Fix For: 2.1.5
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> HMaster crashes at 
> org/apache/hadoop/hbase/regionserver/HRegionServer.java:1044
> *A private static nested class can not be instantiated via reflection.*
> *code snippet*
>  
> {code:java}
>  
> try {
> abortTimeoutTask =
> Class.forName(conf.get(ABORT_TIMEOUT_TASK, 
> SystemExitWhenAbortTimeout.class.getName()))
> .asSubclass(TimerTask.class).getDeclaredConstructor().newInstance();
> } catch (Exception e) {
> LOG.warn("Initialize abort timeout task failed", e);
> }{code}
>  
>  
> *log in product environtment*
> {code:java}
> 2019-08-16 18:01:40,737 [WARN ] HRegionServer:1046 Initialize abort timeout 
> task failed
>  java.lang.IllegalAccessException: Class 
> org.apache.hadoop.hbase.regionserver.HRegionServer can not access a member of 
> class org.apache.hadoop.hbase.regionss
>  erver.HRegionServer$SystemExitWhenAbortTimeout with modifiers "private"
>  at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:102)
>  at 
> java.lang.reflect.AccessibleObject.slowCheckMemberAccess(AccessibleObject.java:296)
>  at java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:288)
>  at java.lang.reflect.Constructor.newInstance(Constructor.java:413)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:1044)
>  at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:598){code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (HBASE-22870) reflection fails to access a private nested class

2019-08-16 Thread ranpanfeng (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-22870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ranpanfeng updated HBASE-22870:
---
Description: 
HMaster crashes at org/apache/hadoop/hbase/regionserver/HRegionServer.java:1044
**A private static nested class can not be instantiated via reflection.**

**code snippet**

```
 try {
 abortTimeoutTask =
 Class.forName(conf.get(ABORT_TIMEOUT_TASK, 
SystemExitWhenAbortTimeout.class.getName()))
 .asSubclass(TimerTask.class).getDeclaredConstructor().newInstance();
 } catch (Exception e) {
 LOG.warn("Initialize abort timeout task failed", e);
 }
```

**log in product environtment**
```
2019-08-16 18:01:40,737 [WARN ] HRegionServer:1046 Initialize abort timeout 
task failed
java.lang.IllegalAccessException: Class 
org.apache.hadoop.hbase.regionserver.HRegionServer can not access a member of 
class org.apache.hadoop.hbase.regionss
 erver.HRegionServer$SystemExitWhenAbortTimeout with modifiers "private"
 at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:102)
 at 
java.lang.reflect.AccessibleObject.slowCheckMemberAccess(AccessibleObject.java:296)
 at java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:288)
 at java.lang.reflect.Constructor.newInstance(Constructor.java:413)
 at 
org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:1044)
 at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:598)
```

> reflection fails to access a private nested class
> -
>
> Key: HBASE-22870
> URL: https://issues.apache.org/jira/browse/HBASE-22870
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.1.5
>Reporter: ranpanfeng
>Priority: Major
> Fix For: 2.1.5
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> HMaster crashes at 
> org/apache/hadoop/hbase/regionserver/HRegionServer.java:1044
> **A private static nested class can not be instantiated via reflection.**
> **code snippet**
> ```
>  try {
>  abortTimeoutTask =
>  Class.forName(conf.get(ABORT_TIMEOUT_TASK, 
> SystemExitWhenAbortTimeout.class.getName()))
>  .asSubclass(TimerTask.class).getDeclaredConstructor().newInstance();
>  } catch (Exception e) {
>  LOG.warn("Initialize abort timeout task failed", e);
>  }
> ```
> **log in product environtment**
> ```
> 2019-08-16 18:01:40,737 [WARN ] HRegionServer:1046 Initialize abort timeout 
> task failed
> java.lang.IllegalAccessException: Class 
> org.apache.hadoop.hbase.regionserver.HRegionServer can not access a member of 
> class org.apache.hadoop.hbase.regionss
>  erver.HRegionServer$SystemExitWhenAbortTimeout with modifiers "private"
>  at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:102)
>  at 
> java.lang.reflect.AccessibleObject.slowCheckMemberAccess(AccessibleObject.java:296)
>  at java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:288)
>  at java.lang.reflect.Constructor.newInstance(Constructor.java:413)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:1044)
>  at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:598)
> ```



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Created] (HBASE-22871) Move the DirScanPool out and do not use static field

2019-08-16 Thread Duo Zhang (JIRA)

Duo Zhang created HBASE-22871:
-

 Summary: Move the DirScanPool out and do not use static field
 Key: HBASE-22871
 URL: https://issues.apache.org/jira/browse/HBASE-22871
 Project: HBase
  Issue Type: Improvement
  Components: master
Reporter: Duo Zhang
Assignee: Duo Zhang


The current implementation is a bit ugly, the onConfigurationChange is an 
instance method but it writes to a static field and cause a findbugs warning. I 
think we can just put the DirScanPool in HMaster and pass it when constructing 
Cleaners...



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [hbase] Reidddddd commented on issue #503: reflection fails to access a private nested class

Reidd commented on issue #503: reflection fails to access a private nested 
class
URL: https://github.com/apache/hbase/pull/503#issuecomment-522199586
 
 
   HBASE-22870, is it yours? Please update the description in JIRA too. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (HBASE-22870) reflection fails to access a private nested class

2019-08-16 Thread ranpanfeng (JIRA)

ranpanfeng created HBASE-22870:
--

 Summary: reflection fails to access a private nested class
 Key: HBASE-22870
 URL: https://issues.apache.org/jira/browse/HBASE-22870
 Project: HBase
  Issue Type: Bug
  Components: master
Affects Versions: 2.1.5
Reporter: ranpanfeng
 Fix For: 2.1.5






--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent

Apache-HBase commented on issue #387: HBASE-22642 Make move operations of 
RSGroup idempotent
URL: https://github.com/apache/hbase/pull/387#issuecomment-522198472
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 65 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 373 | master passed |
   | +1 | compile | 27 | master passed |
   | +1 | checkstyle | 15 | master passed |
   | +1 | shadedjars | 275 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 21 | master passed |
   | 0 | spotbugs | 45 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 43 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 300 | the patch passed |
   | +1 | compile | 25 | the patch passed |
   | +1 | javac | 25 | the patch passed |
   | +1 | checkstyle | 12 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 295 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 946 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 20 | the patch passed |
   | +1 | findbugs | 58 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 785 | hbase-rsgroup in the patch passed. |
   | +1 | asflicense | 12 | The patch does not generate ASF License warnings. |
   | | | 3672 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/96/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/387 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 9c07b21a7c10 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh
 |
   | git revision | master / 43a0ec80fa |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/96/testReport/
 |
   | Max. process+thread count | 4414 (vs. ulimit of 1) |
   | modules | C: hbase-rsgroup U: hbase-rsgroup |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/96/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #501: HBASE-22699 refactor isMetaClearingException

Apache-HBase commented on issue #501: HBASE-22699 refactor 
isMetaClearingException
URL: https://github.com/apache/hbase/pull/501#issuecomment-522198029
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 61 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 436 | master passed |
   | +1 | compile | 31 | master passed |
   | +1 | checkstyle | 39 | master passed |
   | +1 | shadedjars | 344 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 31 | master passed |
   | 0 | spotbugs | 93 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 89 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 373 | the patch passed |
   | +1 | compile | 29 | the patch passed |
   | +1 | javac | 29 | the patch passed |
   | +1 | checkstyle | 37 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 350 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1232 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 26 | the patch passed |
   | +1 | findbugs | 94 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 126 | hbase-client in the patch passed. |
   | +1 | asflicense | 15 | The patch does not generate ASF License warnings. |
   | | | 3754 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/501 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 33d664a73cc4 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-501/out/precommit/personality/provided.sh
 |
   | git revision | master / 43a0ec80fa |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/3/testReport/
 |
   | Max. process+thread count | 292 (vs. ulimit of 1) |
   | modules | C: hbase-client U: hbase-client |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/3/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] satanson commented on issue #503: reflection fails to access a private nested class

satanson commented on issue #503: reflection fails to access a private nested 
class
URL: https://github.com/apache/hbase/pull/503#issuecomment-522197796
 
 
   > Did you raise a related JIRA ticket? If not, please raise one first, it is 
easy for history tracking.
   
   hbase-2.1.5 will be deployed in our product environment, now, interface 
compablity,  integration test and fault exercises are being performed, so more 
and more bugs will be exposed. I want to contribute bugfix, how can I do? It 
there a guide doc for new comer?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #487: HBASE-22844 Fixed Checkstyle violations in client snapshot exceptions

Apache-HBase commented on issue #487: HBASE-22844 Fixed Checkstyle violations 
in client snapshot exceptions
URL: https://github.com/apache/hbase/pull/487#issuecomment-522197423
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 245 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 320 | master passed |
   | +1 | compile | 23 | master passed |
   | +1 | checkstyle | 30 | master passed |
   | +1 | shadedjars | 268 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 23 | master passed |
   | 0 | spotbugs | 70 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 67 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 299 | the patch passed |
   | +1 | compile | 29 | the patch passed |
   | +1 | javac | 29 | the patch passed |
   | +1 | checkstyle | 30 | hbase-client: The patch generated 0 new + 0 
unchanged - 13 fixed = 0 total (was 13) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 269 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 905 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | -1 | javadoc | 20 | hbase-client generated 1 new + 2 unchanged - 0 fixed = 
3 total (was 2) |
   | +1 | findbugs | 71 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 98 | hbase-client in the patch passed. |
   | +1 | asflicense | 11 | The patch does not generate ASF License warnings. |
   | | | 3059 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/12/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/487 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 0bcfcce48278 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-487/out/precommit/personality/provided.sh
 |
   | git revision | master / 43a0ec80fa |
   | Default Java | 1.8.0_181 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/12/artifact/out/diff-javadoc-javadoc-hbase-client.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/12/testReport/
 |
   | Max. process+thread count | 294 (vs. ulimit of 1) |
   | modules | C: hbase-client U: hbase-client |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/12/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (HBASE-22841) TimeRange's factory functions do not support ranges, only `allTime` and `at`



 [ 
https://issues.apache.org/jira/browse/HBASE-22841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zheng Hu resolved HBASE-22841.
--
  Resolution: Fixed
Hadoop Flags: Reviewed
Release Note: 
Add serveral API in TimeRange class for avoiding using the deprecated TimeRange 
constructor: 
* TimeRange#from: Represents the time interval [minStamp, Long.MAX_VALUE)
* TimeRange#until: Represents the time interval [0, maxStamp)
* TimeRange#between: Represents the time interval [minStamp, maxStamp)

[~huonw], Granted you with the contributor permission and assigned this JIRA to 
you. Thanks for your contribution.

> TimeRange's factory functions do not support ranges, only `allTime` and `at`
> 
>
> Key: HBASE-22841
> URL: https://issues.apache.org/jira/browse/HBASE-22841
> Project: HBase
>  Issue Type: Improvement
>  Components: Client
>Affects Versions: 2.2.0, 2.1.5
>Reporter: Huon Wilson
>Assignee: Huon Wilson
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> The {{org.apache.hadoop.hbase.io.TimeRange}} is used in functions like 
> {{org.apache.hadoop.hbase.client.Table.CheckAndMutateBuilder#timeRange}}.
> The current ways to create a {{TimeRange}} are:
> - factory functions: {{at}} (a single instant), {{allTime}} (all valid 
> timestamps)
> - deprecated and {{@InterfaceAudience.Private}} constructors, which support 
> more ranges, like {{[minStamp, maxStamp)}}, and {{[minStamp, MAX)}}
> This is insufficient for all but the simplest use of the 
> {{CheckAndMutateBuilder#timeRange}} function.
> On u...@hbase.apache.org, it was suggested that more factory functions could 
> be added: 
> https://lists.apache.org/thread.html/0ffc5e57c396873d56e49d7b02e823432b053fb98037ee6778d7c2ce@%3Cuser.hbase.apache.org%3E
> However, {{TimeRange}}'s documentation currently says:
> {code:java}
>  * Can be returned and read by clients.  Should not be directly created by 
> clients.
>  * Thus, all constructors are purposely @InterfaceAudience.Private.
> {code}
> so another approach to making {{CheckAndMutateBuilder#timeRange}} useful may 
> be required.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (HBASE-22841) TimeRange's factory functions do not support ranges, only `allTime` and `at`



 [ 
https://issues.apache.org/jira/browse/HBASE-22841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zheng Hu updated HBASE-22841:
-
Fix Version/s: 2.1.6
   2.2.1
   2.0.6
   2.3.0
   3.0.0

> TimeRange's factory functions do not support ranges, only `allTime` and `at`
> 
>
> Key: HBASE-22841
> URL: https://issues.apache.org/jira/browse/HBASE-22841
> Project: HBase
>  Issue Type: Improvement
>  Components: Client
>Affects Versions: 2.2.0, 2.1.5
>Reporter: Huon Wilson
>Assignee: Huon Wilson
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> The {{org.apache.hadoop.hbase.io.TimeRange}} is used in functions like 
> {{org.apache.hadoop.hbase.client.Table.CheckAndMutateBuilder#timeRange}}.
> The current ways to create a {{TimeRange}} are:
> - factory functions: {{at}} (a single instant), {{allTime}} (all valid 
> timestamps)
> - deprecated and {{@InterfaceAudience.Private}} constructors, which support 
> more ranges, like {{[minStamp, maxStamp)}}, and {{[minStamp, MAX)}}
> This is insufficient for all but the simplest use of the 
> {{CheckAndMutateBuilder#timeRange}} function.
> On u...@hbase.apache.org, it was suggested that more factory functions could 
> be added: 
> https://lists.apache.org/thread.html/0ffc5e57c396873d56e49d7b02e823432b053fb98037ee6778d7c2ce@%3Cuser.hbase.apache.org%3E
> However, {{TimeRange}}'s documentation currently says:
> {code:java}
>  * Can be returned and read by clients.  Should not be directly created by 
> clients.
>  * Thus, all constructors are purposely @InterfaceAudience.Private.
> {code}
> so another approach to making {{CheckAndMutateBuilder#timeRange}} useful may 
> be required.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Assigned] (HBASE-22841) TimeRange's factory functions do not support ranges, only `allTime` and `at`



 [ 
https://issues.apache.org/jira/browse/HBASE-22841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zheng Hu reassigned HBASE-22841:


Assignee: Huon Wilson

> TimeRange's factory functions do not support ranges, only `allTime` and `at`
> 
>
> Key: HBASE-22841
> URL: https://issues.apache.org/jira/browse/HBASE-22841
> Project: HBase
>  Issue Type: Improvement
>  Components: Client
>Affects Versions: 2.2.0, 2.1.5
>Reporter: Huon Wilson
>Assignee: Huon Wilson
>Priority: Major
>
> The {{org.apache.hadoop.hbase.io.TimeRange}} is used in functions like 
> {{org.apache.hadoop.hbase.client.Table.CheckAndMutateBuilder#timeRange}}.
> The current ways to create a {{TimeRange}} are:
> - factory functions: {{at}} (a single instant), {{allTime}} (all valid 
> timestamps)
> - deprecated and {{@InterfaceAudience.Private}} constructors, which support 
> more ranges, like {{[minStamp, maxStamp)}}, and {{[minStamp, MAX)}}
> This is insufficient for all but the simplest use of the 
> {{CheckAndMutateBuilder#timeRange}} function.
> On u...@hbase.apache.org, it was suggested that more factory functions could 
> be added: 
> https://lists.apache.org/thread.html/0ffc5e57c396873d56e49d7b02e823432b053fb98037ee6778d7c2ce@%3Cuser.hbase.apache.org%3E
> However, {{TimeRange}}'s documentation currently says:
> {code:java}
>  * Can be returned and read by clients.  Should not be directly created by 
> clients.
>  * Thus, all constructors are purposely @InterfaceAudience.Private.
> {code}
> so another approach to making {{CheckAndMutateBuilder#timeRange}} useful may 
> be required.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [hbase] openinx closed pull request #483: HBASE-22841 Add more factory functions to TimeRange

openinx closed pull request #483: HBASE-22841 Add more factory functions to 
TimeRange
URL: https://github.com/apache/hbase/pull/483
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Assigned] (HBASE-22867) The ForkJoinPool in CleanerChore will spawn thousands of threads in our cluster with thousands table



 [ 
https://issues.apache.org/jira/browse/HBASE-22867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zheng Hu reassigned HBASE-22867:


Assignee: Zheng Hu

> The ForkJoinPool in CleanerChore will spawn thousands of threads in our 
> cluster with thousands table
> 
>
> Key: HBASE-22867
> URL: https://issues.apache.org/jira/browse/HBASE-22867
> Project: HBase
>  Issue Type: Bug
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Attachments: 31162.stack.1
>
>
> The thousands of spawned  threads make the safepoint cost 80+s in our Master 
> JVM processs.
> {code}
> 2019-08-15,19:35:35,861 INFO [main-SendThread(zjy-hadoop-prc-zk02.bj:11000)] 
> org.apache.zookeeper.ClientCnxn: Client session timed out, have not heard 
> from server in 82260ms for sessionid 0x1691332e2d3aae5, closing socket 
> connection and at
> tempting reconnect
> {code}
> The stdout from JVM (can see from here there're 9126 threads & sync cost 80+s)
> {code}
> vmop[threads: total initially_running wait_to_block]
> [time: spin block sync cleanup vmop] page_trap_count
> 32358.859: ForceAsyncSafepoint  [9126 67
> 474]  [ 128 8659687   101]  0
> {code}
> Also we got the jstack: 
> {code}
> $ cat 31162.stack.1  | grep 'ForkJoinPool-1-worker' | wc -l
> 8648
> {code}
> It's a dangerous bug, make it as blocker.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (HBASE-22863) Avoid Jackson versions and dependencies with known CVEs

2019-08-16 Thread Viraj Jasani (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-22863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viraj Jasani updated HBASE-22863:
-
Description: 
Partly forwardport from branch-1 Jira: HBASE-22728

Even though master and branch-2 have moved away from Jackson1 some time back, 
HBase is still pulling in some vulnerable jackson dependencies (e.g. 
jackson-mapper-asl:1.9.13) from Hadoop:

 
{code:java}
[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-mapreduce 
---
[INFO] org.apache.hbase:hbase-mapreduce:jar:3.0.0-SNAPSHOT
[INFO] +- org.apache.hbase:hbase-server:jar:3.0.0-SNAPSHOT:compile
[INFO] |  \- org.apache.hbase:hbase-http:jar:3.0.0-SNAPSHOT:compile
[INFO] | \- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile
[INFO] +- 
org.apache.hadoop:hadoop-mapreduce-client-jobclient:test-jar:tests:2.8.5:test
[INFO] |  \- org.apache.avro:avro:jar:1.7.7:compile
[INFO] | \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:compile
[INFO] \- org.apache.hadoop:hadoop-mapreduce-client-core:jar:2.8.5:compile
[INFO]\- org.apache.hadoop:hadoop-yarn-common:jar:2.8.5:compile
[INFO]   +- org.codehaus.jackson:jackson-jaxrs:jar:1.9.13:compile
[INFO]   \- org.codehaus.jackson:jackson-xc:jar:1.9.13:compile{code}
{code:java}
[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ 
hbase-shaded-testing-util ---
[INFO] org.apache.hbase:hbase-shaded-testing-util:jar:3.0.0-SNAPSHOT
[INFO] \- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:compile
[INFO]+- com.sun.jersey:jersey-json:jar:1.9:compile
[INFO]|  +- org.codehaus.jackson:jackson-jaxrs:jar:1.8.3:compile
[INFO]|  \- org.codehaus.jackson:jackson-xc:jar:1.8.3:compile
[INFO]+- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile
[INFO]\- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:compile{code}
{code:java}
[INFO] org.apache.hbase:hbase-shaded-testing-util-tester:jar:3.0.0-SNAPSHOT
[INFO] \- org.apache.hbase:hbase-shaded-testing-util:jar:3.0.0-SNAPSHOT:test
[INFO]\- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test
[INFO]   +- com.sun.jersey:jersey-json:jar:1.9:test
[INFO]   |  +- org.codehaus.jackson:jackson-jaxrs:jar:1.8.3:test
[INFO]   |  \- org.codehaus.jackson:jackson-xc:jar:1.8.3:test
[INFO]   +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile
[INFO]   \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:compile
{code}
Jackson1 is not being used in HBase code anymore and hence, we should include 
it only at test scope if required by Hadoop but definitely exclude it from 
corresponding Hadoop dependencies.

 

  was:
Partly forwardport from branch-1 Jira: HBASE-22728

Even though master and branch-2 have moved away from Jackson1 some time back, 
HBase is still pulling in some vulnerable jackson dependencies (e.g. 
jackson-mapper-asl:1.9.13) from Hadoop:

 
{code:java}
[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-mapreduce 
---
[INFO] org.apache.hbase:hbase-mapreduce:jar:3.0.0-SNAPSHOT
[INFO] +- org.apache.hbase:hbase-server:jar:3.0.0-SNAPSHOT:compile
[INFO] |  \- org.apache.hbase:hbase-http:jar:3.0.0-SNAPSHOT:compile
[INFO] | \- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile
[INFO] +- 
org.apache.hadoop:hadoop-mapreduce-client-jobclient:test-jar:tests:2.8.5:test
[INFO] |  \- org.apache.avro:avro:jar:1.7.7:compile
[INFO] | \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:compile
[INFO] \- org.apache.hadoop:hadoop-mapreduce-client-core:jar:2.8.5:compile
[INFO]\- org.apache.hadoop:hadoop-yarn-common:jar:2.8.5:compile
[INFO]   +- org.codehaus.jackson:jackson-jaxrs:jar:1.9.13:compile
[INFO]   \- org.codehaus.jackson:jackson-xc:jar:1.9.13:compile{code}
{code:java}
[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ 
hbase-shaded-testing-util ---
[INFO] org.apache.hbase:hbase-shaded-testing-util:jar:3.0.0-SNAPSHOT
[INFO] \- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:compile
[INFO]+- com.sun.jersey:jersey-json:jar:1.9:compile
[INFO]|  +- org.codehaus.jackson:jackson-jaxrs:jar:1.8.3:compile
[INFO]|  \- org.codehaus.jackson:jackson-xc:jar:1.8.3:compile
[INFO]+- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile
[INFO]\- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:compile{code}
{code:java}
[INFO] org.apache.hbase:hbase-shaded-testing-util-tester:jar:3.0.0-SNAPSHOT
[INFO] \- org.apache.hbase:hbase-shaded-testing-util:jar:3.0.0-SNAPSHOT:test
[INFO]\- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test
[INFO]   +- com.sun.jersey:jersey-json:jar:1.9:test
[INFO]   |  +- org.codehaus.jackson:jackson-jaxrs:jar:1.8.3:test
[INFO]   |  \- org.codehaus.jackson:jackson-xc:jar:1.8.3:test
[INFO]   +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile
[INFO]   \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:compile
{code}
jackson-mapper-asl is not being

[GitHub] [hbase] Apache-HBase commented on issue #496: HBASE-22625 documet use scan snapshot feature

Apache-HBase commented on issue #496: HBASE-22625 documet use scan snapshot 
feature
URL: https://github.com/apache/hbase/pull/496#issuecomment-522196474
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 356 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | 0 | shelldocs | 0 | Shelldocs was not available. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 468 | master passed |
   | 0 | refguide | 414 | branch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 377 | the patch passed |
   | +1 | shellcheck | 0 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | 0 | refguide | 409 | patch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. |
   ||| _ Other Tests _ |
   | +1 | asflicense | 21 | The patch does not generate ASF License warnings. |
   | | | 2124 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/7/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/496 |
   | Optional Tests | dupname asflicense shellcheck shelldocs refguide |
   | uname | Linux afc7b96c8aa2 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 
05:29:03 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-496/out/precommit/personality/provided.sh
 |
   | git revision | master / 43a0ec80fa |
   | refguide | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/7/artifact/out/branch-site/book.html
 |
   | refguide | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/7/artifact/out/patch-site/book.html
 |
   | Max. process+thread count | 96 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/7/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Reidddddd commented on issue #503: reflection fails to access a private nested class

Reidd commented on issue #503: reflection fails to access a private nested 
class
URL: https://github.com/apache/hbase/pull/503#issuecomment-522194923
 
 
   Did you raise a related JIRA ticket? If not, please raise one first, it is 
easy for history tracking.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (HBASE-22869) JavaDoc for NullComparator is the same as BinaryComparator



[ 
https://issues.apache.org/jira/browse/HBASE-22869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909538#comment-16909538
 ] 

HBase QA commented on HBASE-22869:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  3m 
24s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
 1s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
 3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
49s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
16m 25s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m  
4s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 
17s{color} | {color:red} hbase-client generated 2 new + 2 unchanged - 0 fixed = 
4 total (was 2) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 
33s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 9s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 52m 22s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/791/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22869 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12977850/0001-HBASE-22869-JavaDoc-for-NullComparator-is-the-same-a.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux e62045392163 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 
13:14:43 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 3eb602c7f7 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HBASE-Build/791/artifact/patchprocess/diff-javadoc-javadoc-hbase-client.txt
 |
|  Test Results |

[GitHub] [hbase] openinx commented on a change in pull request #483: HBASE-22841 Add more factory functions to TimeRange

openinx commented on a change in pull request #483: HBASE-22841 Add more 
factory functions to TimeRange
URL: https://github.com/apache/hbase/pull/483#discussion_r314929726
 
 

 ##
 File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/TimeRange.java
 ##
 @@ -28,9 +28,6 @@
  * 
  * Evaluated according to minStamp = timestamp  maxStamp
  * or [minStamp,maxStamp) in interval notation.
- * 
- * Can be returned and read by clients.  Should not be directly created by 
clients.
 
 Review comment:
   I've added this in the committed patch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] openinx commented on issue #483: HBASE-22841 Add more factory functions to TimeRange

openinx commented on issue #483: HBASE-22841 Add more factory functions to 
TimeRange
URL: https://github.com/apache/hbase/pull/483#issuecomment-522192572
 
 
   I think the patch is good enough now,  plan to commit this patch to avoid 
the daily nosiy from hadoopQA :-) 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (HBASE-22862) Region Server crash with: Added a key not lexically larger than previous



[ 
https://issues.apache.org/jira/browse/HBASE-22862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909529#comment-16909529
 ] 

Zheng Hu commented on HBASE-22862:
--

Similar with HBASE-16931 ?  the current one is in flush process, while the 
HBASE-16931 is in compaction process ?

> Region Server crash with: Added a key not lexically larger than previous
> 
>
> Key: HBASE-22862
> URL: https://issues.apache.org/jira/browse/HBASE-22862
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 1.4.10
> Environment: {code}
> openjdk version "1.8.0_181"
> OpenJDK Runtime Environment (Zulu 8.31.0.1-linux64) (build 1.8.0_181-b02)
> OpenJDK 64-Bit Server VM (Zulu 8.31.0.1-linux64) (build 25.181-b02, mixed 
> mode)
> {code}
>Reporter: Alex Batyrshin
>Priority: Critical
>
> We observe error "Added a key not lexically larger than previous” that cause 
> most of our region-servers to crash in our cluster.
> {code}
> 2019-08-15 18:02:10,554 INFO  [MemStoreFlusher.0] regionserver.HRegion: 
> Flushing 1/1 column families, memstore=56.08 MB
> 2019-08-15 18:02:10,727 WARN  [MemStoreFlusher.0] regionserver.HStore: Failed 
> flushing store file, retrying num=0
> java.io.IOException: Added a key not lexically larger than previous. Current 
> cell = 
> \x0901820448218>wGavb'/d:elr/1565881054828/DeleteColumn/vlen=0/seqid=44456567,
>  lastCell = 
> \x0901820448218>wGavb'/d:elr/1565881054828/Put/vlen=1/seqid=44457770
>at 
> org.apache.hadoop.hbase.io.hfile.AbstractHFileWriter.checkKey(AbstractHFileWriter.java:204)
>at 
> org.apache.hadoop.hbase.io.hfile.HFileWriterV2.append(HFileWriterV2.java:279)
>at 
> org.apache.hadoop.hbase.io.hfile.HFileWriterV3.append(HFileWriterV3.java:87)
>at 
> org.apache.hadoop.hbase.regionserver.StoreFile$Writer.append(StoreFile.java:1127)
>at 
> org.apache.hadoop.hbase.regionserver.StoreFlusher.performFlush(StoreFlusher.java:139)
>at 
> org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:75)
>at 
> org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:1003)
>at 
> org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.flushCache(HStore.java:2523)
>at 
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2622)
>at 
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2352)
>at 
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2314)
>at 
> org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2200)
>at 
> org.apache.hadoop.hbase.regionserver.HRegion.flush(HRegion.java:2125)
>at 
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:512)
>at 
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:482)
>at 
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$900(MemStoreFlusher.java:76)
>at 
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:264)
>at java.lang.Thread.run(Thread.java:748)
> 2019-08-15 18:02:21,776 WARN  [MemStoreFlusher.0] regionserver.HStore: Failed 
> flushing store file, retrying num=9
> java.io.IOException: Added a key not lexically larger than previous. Current 
> cell = 
> \x0901820448218>wGavb'/d:elr/1565881054828/DeleteColumn/vlen=0/seqid=44456567,
>  lastCell = 
> \x0901820448218>wGavb'/d:elr/1565881054828/Put/vlen=1/seqid=44457770
>at 
> org.apache.hadoop.hbase.io.hfile.AbstractHFileWriter.checkKey(AbstractHFileWriter.java:204)
>at 
> org.apache.hadoop.hbase.io.hfile.HFileWriterV2.append(HFileWriterV2.java:279)
>at 
> org.apache.hadoop.hbase.io.hfile.HFileWriterV3.append(HFileWriterV3.java:87)
>at 
> org.apache.hadoop.hbase.regionserver.StoreFile$Writer.append(StoreFile.java:1127)
>at 
> org.apache.hadoop.hbase.regionserver.StoreFlusher.performFlush(StoreFlusher.java:139)
>at 
> org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:75)
>at 
> org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:1003)
>at 
> org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.flushCache(HStore.java:2523)
>at 
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2622)
>at 
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2352)
>at 
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2314)
>at 
> org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2200)
>

[GitHub] [hbase] satanson opened a new pull request #503: reflection fails to access a private nested class

satanson opened a new pull request #503: reflection fails to access a private 
nested class
URL: https://github.com/apache/hbase/pull/503
 
 
   HMaster crashes at 
org/apache/hadoop/hbase/regionserver/HRegionServer.java:1044
   **A private static nested class can not be instantiated via reflection.**
   
   **code snippet**
   
   ```
 try {
   abortTimeoutTask =
   Class.forName(conf.get(ABORT_TIMEOUT_TASK, 
SystemExitWhenAbortTimeout.class.getName()))
   
.asSubclass(TimerTask.class).getDeclaredConstructor().newInstance();
 } catch (Exception e) {
   LOG.warn("Initialize abort timeout task failed", e);
 }
   ```
   
   **log in product environtment**
   ```
   2019-08-16 18:01:40,737 [WARN ] HRegionServer:1046 Initialize abort timeout 
task failed
   java.lang.IllegalAccessException: Class 
org.apache.hadoop.hbase.regionserver.HRegionServer can not access a member of 
class org.apache.hadoop.hbase.regionss
erver.HRegionServer$SystemExitWhenAbortTimeout with modifiers "private"
  at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:102)
  at 
java.lang.reflect.AccessibleObject.slowCheckMemberAccess(AccessibleObject.java:296)
  at 
java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:288)
  at java.lang.reflect.Constructor.newInstance(Constructor.java:413)
  at 
org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:1044)
  at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:598)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] satanson closed pull request #502: My 2.1.5 rc1

satanson closed pull request #502: My 2.1.5 rc1
URL: https://github.com/apache/hbase/pull/502
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (HBASE-22869) JavaDoc for NullComparator is the same as BinaryComparator

2019-08-16 Thread Clay B. (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-22869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clay B. updated HBASE-22869:

Attachment: 0001-HBASE-22869-JavaDoc-for-NullComparator-is-the-same-a.patch
Status: Patch Available  (was: Open)

> JavaDoc for NullComparator is the same as BinaryComparator
> --
>
> Key: HBASE-22869
> URL: https://issues.apache.org/jira/browse/HBASE-22869
> Project: HBase
>  Issue Type: Improvement
>  Components: documentation
>Reporter: Clay B.
>Assignee: Clay B.
>Priority: Trivial
> Attachments: 
> 0001-HBASE-22869-JavaDoc-for-NullComparator-is-the-same-a.patch
>
>
> Looking at the list of default HBase 
> [filters|https://hbase.apache.org/apidocs/org/apache/hadoop/hbase/filter/package-summary.html]
>  one can not see what is null about {{NullComparator}} as its JavaDoc is 
> identical to 
> [{{BinaryComparator}}|https://hbase.apache.org/apidocs/org/apache/hadoop/hbase/filter/BinaryComparator.html].
>  It would be nice to know how it is "null" for easier adoption.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Created] (HBASE-22869) JavaDoc for NullComparator is the same as BinaryComparator

2019-08-16 Thread Clay B. (JIRA)

Clay B. created HBASE-22869:
---

 Summary: JavaDoc for NullComparator is the same as BinaryComparator
 Key: HBASE-22869
 URL: https://issues.apache.org/jira/browse/HBASE-22869
 Project: HBase
  Issue Type: Improvement
  Components: documentation
Reporter: Clay B.
Assignee: Clay B.


Looking at the list of default HBase 
[filters|https://hbase.apache.org/apidocs/org/apache/hadoop/hbase/filter/package-summary.html]
 one can not see what is null about {{NullComparator}} as its JavaDoc is 
identical to 
[{{BinaryComparator}}|https://hbase.apache.org/apidocs/org/apache/hadoop/hbase/filter/BinaryComparator.html].
 It would be nice to know how it is "null" for easier adoption.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [hbase] satanson opened a new pull request #502: My 2.1.5 rc1

satanson opened a new pull request #502: My 2.1.5 rc1
URL: https://github.com/apache/hbase/pull/502
 
 
   HMaster crashes at 
org/apache/hadoop/hbase/regionserver/HRegionServer.java:1044
   **A private static nested class can not be instantiated via reflection.**
   
   **code snippet**
   
   ```
 try {
   abortTimeoutTask =
   Class.forName(conf.get(ABORT_TIMEOUT_TASK, 
SystemExitWhenAbortTimeout.class.getName()))
   
.asSubclass(TimerTask.class).getDeclaredConstructor().newInstance();
 } catch (Exception e) {
   LOG.warn("Initialize abort timeout task failed", e);
 }
   ```
   
   **log in product environtment**
   ```
   2019-08-16 18:01:40,737 [WARN ] HRegionServer:1046 Initialize abort timeout 
task failed
   java.lang.IllegalAccessException: Class 
org.apache.hadoop.hbase.regionserver.HRegionServer can not access a member of 
class org.apache.hadoop.hbase.regionss
erver.HRegionServer$SystemExitWhenAbortTimeout with modifiers "private"
  at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:102)
  at 
java.lang.reflect.AccessibleObject.slowCheckMemberAccess(AccessibleObject.java:296)
  at 
java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:288)
  at java.lang.reflect.Constructor.newInstance(Constructor.java:413)
  at 
org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:1044)
  at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:598)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase



[ 
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909517#comment-16909517
 ] 

Hudson commented on HBASE-22514:


Results for branch HBASE-22514
[build #62 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/62/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/62//General_Nightly_Build_Report/]








(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
>  Issue Type: Umbrella
>  Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch, 
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public 
> we need to use java api  RSGroupAdminClient  to manager RSG 
> so  RSGroupAdminClient should be public
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22860) Master's webui returns NPE/HTTP 500 under maintenance mode



[ 
https://issues.apache.org/jira/browse/HBASE-22860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909515#comment-16909515
 ] 

Hudson commented on HBASE-22860:


Results for branch branch-2.2
[build #520 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/520/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/520//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/495//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/495//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Master's webui returns NPE/HTTP 500 under maintenance mode
> --
>
> Key: HBASE-22860
> URL: https://issues.apache.org/jira/browse/HBASE-22860
> Project: HBase
>  Issue Type: Bug
>  Components: master, UI
>Affects Versions: 3.0.0, 2.2.0, 2.1.5, 2.2.1, 2.1.6
>Reporter: Daisuke Kobayashi
>Assignee: Daisuke Kobayashi
>Priority: Major
> Fix For: 3.0.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22860.master.001.patch, 
> HBASE-22860.master.002.patch, Screen Shot 2019-08-15 at 4.15.51 PM.png
>
>
> Master's webui is not accessible when {{hbase.master.maintenance_mode}} is 
> set to true. This is because it's trying to load a coprocessor 
> {{RSGroupAdminEndpoint}}.
> {code}
> java.lang.NullPointerException
>   at 
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmplImpl.renderNoFlush(MasterStatusTmplImpl.java:326)
>   at 
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.renderNoFlush(MasterStatusTmpl.java:397)
>   at 
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.render(MasterStatusTmpl.java:388)
>   at 
> org.apache.hadoop.hbase.master.MasterStatusServlet.doGet(MasterStatusServlet.java:81)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
>   at 
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:848)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1780)
>   at 
> org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:112)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
>   at 
> org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
>   at 
> org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1374)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
>   at 
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
>   at 
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:583)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
>   at 
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:513)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
>   at 
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119)
>   at 
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
>   at org.eclipse.jetty.server.Server.handle(Server.java:539)
>   at

[jira] [Commented] (HBASE-22860) Master's webui returns NPE/HTTP 500 under maintenance mode



[ 
https://issues.apache.org/jira/browse/HBASE-22860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909516#comment-16909516
 ] 

Hudson commented on HBASE-22860:


Results for branch master
[build #1339 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1339/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1339//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/master/1258//console].


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1258//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Master's webui returns NPE/HTTP 500 under maintenance mode
> --
>
> Key: HBASE-22860
> URL: https://issues.apache.org/jira/browse/HBASE-22860
> Project: HBase
>  Issue Type: Bug
>  Components: master, UI
>Affects Versions: 3.0.0, 2.2.0, 2.1.5, 2.2.1, 2.1.6
>Reporter: Daisuke Kobayashi
>Assignee: Daisuke Kobayashi
>Priority: Major
> Fix For: 3.0.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22860.master.001.patch, 
> HBASE-22860.master.002.patch, Screen Shot 2019-08-15 at 4.15.51 PM.png
>
>
> Master's webui is not accessible when {{hbase.master.maintenance_mode}} is 
> set to true. This is because it's trying to load a coprocessor 
> {{RSGroupAdminEndpoint}}.
> {code}
> java.lang.NullPointerException
>   at 
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmplImpl.renderNoFlush(MasterStatusTmplImpl.java:326)
>   at 
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.renderNoFlush(MasterStatusTmpl.java:397)
>   at 
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.render(MasterStatusTmpl.java:388)
>   at 
> org.apache.hadoop.hbase.master.MasterStatusServlet.doGet(MasterStatusServlet.java:81)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
>   at 
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:848)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1780)
>   at 
> org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:112)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
>   at 
> org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
>   at 
> org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1374)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
>   at 
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
>   at 
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:583)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
>   at 
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:513)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
>   at 
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119)
>   at 
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
>   at org.eclipse.jetty.server.Server.handle(Server.java:539)
>   at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:333)
>

[jira] [Commented] (HBASE-22858) Add HBCK Report to master's header.jsp



[ 
https://issues.apache.org/jira/browse/HBASE-22858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909514#comment-16909514
 ] 

Hudson commented on HBASE-22858:


Results for branch branch-2.2
[build #520 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/520/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/520//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/495//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/495//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Add HBCK Report to master's header.jsp
> --
>
> Key: HBASE-22858
> URL: https://issues.apache.org/jira/browse/HBASE-22858
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22860) Master's webui returns NPE/HTTP 500 under maintenance mode



[ 
https://issues.apache.org/jira/browse/HBASE-22860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909513#comment-16909513
 ] 

Hudson commented on HBASE-22860:


Results for branch branch-2
[build #2172 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2172/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2172//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2118//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2118//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Master's webui returns NPE/HTTP 500 under maintenance mode
> --
>
> Key: HBASE-22860
> URL: https://issues.apache.org/jira/browse/HBASE-22860
> Project: HBase
>  Issue Type: Bug
>  Components: master, UI
>Affects Versions: 3.0.0, 2.2.0, 2.1.5, 2.2.1, 2.1.6
>Reporter: Daisuke Kobayashi
>Assignee: Daisuke Kobayashi
>Priority: Major
> Fix For: 3.0.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22860.master.001.patch, 
> HBASE-22860.master.002.patch, Screen Shot 2019-08-15 at 4.15.51 PM.png
>
>
> Master's webui is not accessible when {{hbase.master.maintenance_mode}} is 
> set to true. This is because it's trying to load a coprocessor 
> {{RSGroupAdminEndpoint}}.
> {code}
> java.lang.NullPointerException
>   at 
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmplImpl.renderNoFlush(MasterStatusTmplImpl.java:326)
>   at 
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.renderNoFlush(MasterStatusTmpl.java:397)
>   at 
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.render(MasterStatusTmpl.java:388)
>   at 
> org.apache.hadoop.hbase.master.MasterStatusServlet.doGet(MasterStatusServlet.java:81)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
>   at 
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:848)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1780)
>   at 
> org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:112)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
>   at 
> org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
>   at 
> org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1374)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
>   at 
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
>   at 
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:583)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
>   at 
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:513)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
>   at 
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119)
>   at 
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
>   at org.eclipse.jetty.server.Server.handle(Server.java:539)
>   at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:333)
>

[jira] [Commented] (HBASE-22842) Tmp directory should not be deleted when master restart used for user scan snapshot feature



[ 
https://issues.apache.org/jira/browse/HBASE-22842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909511#comment-16909511
 ] 

Hudson commented on HBASE-22842:


Results for branch branch-2
[build #2172 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2172/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2172//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2118//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2118//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Tmp directory should not be deleted when master restart used for user scan 
> snapshot feature
> ---
>
> Key: HBASE-22842
> URL: https://issues.apache.org/jira/browse/HBASE-22842
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Yi Mei
>Assignee: Yi Mei
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> When create table, table directories are firstly created in tmp directory and 
> then move to data directory. So HDFS ACLs are set at the following tmp 
> directories used for ACLs inherited:
> {code:java}
> {hbase-rootdir}/.tmp/data
> {hbase-rootdir}/.tmp/data/{namespace}
> {hbase-rootdir}/.tmp/data/{namespace}/{table}
> {code}
> When master restart, it will delete tmp directory and this will break this 
> feature.
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22858) Add HBCK Report to master's header.jsp



[ 
https://issues.apache.org/jira/browse/HBASE-22858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909512#comment-16909512
 ] 

Hudson commented on HBASE-22858:


Results for branch branch-2
[build #2172 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2172/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2172//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2118//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2118//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Add HBCK Report to master's header.jsp
> --
>
> Key: HBASE-22858
> URL: https://issues.apache.org/jira/browse/HBASE-22858
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22833) MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters



[ 
https://issues.apache.org/jira/browse/HBASE-22833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909510#comment-16909510
 ] 

Hudson commented on HBASE-22833:


Results for branch branch-2
[build #2172 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2172/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2172//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2118//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2118//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> MultiRowRangeFilter should provide a method for creating a filter which is 
> functionally equivalent to multiple prefix filters
> -
>
> Key: HBASE-22833
> URL: https://issues.apache.org/jira/browse/HBASE-22833
> Project: HBase
>  Issue Type: Wish
>  Components: Client
>Affects Versions: 3.0.0
>Reporter: Itsuki Toyota
>Assignee: Itsuki Toyota
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.4.11
>
>
> HI,
> I think current formal way to make multiple prefix filters is to create a 
> _FilterList_ and add _PrefixFilter_ instances to the list:
> {code:java}
> FilterList allFilters = new FilterList(FilterList.Operator.MUST_PASS_ONE);
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("123")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("456")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("678")));
> scan.setFilter(allFilters);
> {code}
> (c.f., 
> https://stackoverflow.com/questions/41074213/hbase-how-to-specify-multiple-prefix-filters-in-a-single-scan-operation
>  )
> However, in the case of creating a single prefix filter, HBase provides 
> _scan.setRowPrefixFilter_ method.
> This method creates a range filter by setting a start row and a stop row.
> The value of a stop row is decided by calling 
> _calculateTheClosestNextRowKeyForPrefix_ ( c.f., 
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java#L574-L597
>  )
> _MultiRowRangeFilter_ could leverage a list of start row and stop row pairs 
> and _calculateTheClosestNextRowKeyForPrefix_ could compute the stop row value 
> corresponding to given start row (i.e., a prefix).
> I think this kind of filter (a filter which is functionally equivalent to 
> multiple prefix filters) should be creatable by _MultiRowRangeFilter_ and 
> it's better than the current formal way.
> Cheers,



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (HBASE-22862) Region Server crash with: Added a key not lexically larger than previous

2019-08-16 Thread Alex Batyrshin (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-22862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Batyrshin updated HBASE-22862:
---
Description: 
We observe error "Added a key not lexically larger than previous” that cause 
most of our region-servers to crash in our cluster.

{code}
2019-08-15 18:02:10,554 INFO  [MemStoreFlusher.0] regionserver.HRegion: 
Flushing 1/1 column families, memstore=56.08 MB
2019-08-15 18:02:10,727 WARN  [MemStoreFlusher.0] regionserver.HStore: Failed 
flushing store file, retrying num=0
java.io.IOException: Added a key not lexically larger than previous. Current 
cell = 
\x0901820448218>wGavb'/d:elr/1565881054828/DeleteColumn/vlen=0/seqid=44456567, 
lastCell = \x0901820448218>wGavb'/d:elr/1565881054828/Put/vlen=1/seqid=44457770
   at 
org.apache.hadoop.hbase.io.hfile.AbstractHFileWriter.checkKey(AbstractHFileWriter.java:204)
   at 
org.apache.hadoop.hbase.io.hfile.HFileWriterV2.append(HFileWriterV2.java:279)
   at 
org.apache.hadoop.hbase.io.hfile.HFileWriterV3.append(HFileWriterV3.java:87)
   at 
org.apache.hadoop.hbase.regionserver.StoreFile$Writer.append(StoreFile.java:1127)
   at 
org.apache.hadoop.hbase.regionserver.StoreFlusher.performFlush(StoreFlusher.java:139)
   at 
org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:75)
   at 
org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:1003)
   at 
org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.flushCache(HStore.java:2523)
   at 
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2622)
   at 
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2352)
   at 
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2314)
   at 
org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2200)
   at org.apache.hadoop.hbase.regionserver.HRegion.flush(HRegion.java:2125)
   at 
org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:512)
   at 
org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:482)
   at 
org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$900(MemStoreFlusher.java:76)
   at 
org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:264)
   at java.lang.Thread.run(Thread.java:748)

2019-08-15 18:02:21,776 WARN  [MemStoreFlusher.0] regionserver.HStore: Failed 
flushing store file, retrying num=9
java.io.IOException: Added a key not lexically larger than previous. Current 
cell = 
\x0901820448218>wGavb'/d:elr/1565881054828/DeleteColumn/vlen=0/seqid=44456567, 
lastCell = \x0901820448218>wGavb'/d:elr/1565881054828/Put/vlen=1/seqid=44457770
   at 
org.apache.hadoop.hbase.io.hfile.AbstractHFileWriter.checkKey(AbstractHFileWriter.java:204)
   at 
org.apache.hadoop.hbase.io.hfile.HFileWriterV2.append(HFileWriterV2.java:279)
   at 
org.apache.hadoop.hbase.io.hfile.HFileWriterV3.append(HFileWriterV3.java:87)
   at 
org.apache.hadoop.hbase.regionserver.StoreFile$Writer.append(StoreFile.java:1127)
   at 
org.apache.hadoop.hbase.regionserver.StoreFlusher.performFlush(StoreFlusher.java:139)
   at 
org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:75)
   at 
org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:1003)
   at 
org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.flushCache(HStore.java:2523)
   at 
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2622)
   at 
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2352)
   at 
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2314)
   at 
org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2200)
   at org.apache.hadoop.hbase.regionserver.HRegion.flush(HRegion.java:2125)
   at 
org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:512)
   at 
org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:482)
   at 
org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$900(MemStoreFlusher.java:76)
   at 
org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:264)
   at java.lang.Thread.run(Thread.java:748)

2019-08-15 18:02:21,777 FATAL [MemStoreFlusher.0] regionserver.HRegionServer: 
ABORTING region server prod006,60020,1565873610692: Replay of WAL required. 
Forcing server shutdown
org.apache.hadoop.hbase.DroppedSnapshotException: region: 
TBL_TABLE_CODE,\x0904606203097821slG=sPD,1563070299676.5110b3395ca64a51cea99c6572a4c3d9.
   at 
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2675)

[jira] [Commented] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary



[ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909483#comment-16909483
 ] 

HBase QA commented on HBASE-22804:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m  
5s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
 6s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
49s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 7s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 8s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
29s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
29s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 7s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
14m 51s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}251m 21s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
23s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}301m 14s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | 
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/789/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22804 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12977813/HBASE-22804.branch-2.006.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux cafadfec670a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / f9e20a6189 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/789/artifact/patchprocess/patch-unit-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/789/testReport/ |
| Max. process+thread count | 5023 (vs. ulimit of 1) |
| modules | C: hbase-server

[jira] [Created] (HBASE-22868) Fix NOTICE file

2019-08-16 Thread Ankit Singhal (JIRA)

Ankit Singhal created HBASE-22868:
-

 Summary: Fix NOTICE file
 Key: HBASE-22868
 URL: https://issues.apache.org/jira/browse/HBASE-22868
 Project: HBase
  Issue Type: Bug
Reporter: Ankit Singhal
Assignee: Ankit Singhal


Notice files have entries like 
{code}
Copyright 2007-${copyright-end-year} The Apache Software Foundation
For source see 
'http://commons.apache.org/${pom.artifactId.substring(8)}/commons-configuration'.
{code}

And multiple entries with
{code}
For source see '${dep.url}'.
{code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22833) MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters



[ 
https://issues.apache.org/jira/browse/HBASE-22833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909422#comment-16909422
 ] 

Hudson commented on HBASE-22833:


Results for branch branch-1.4
[build #962 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/962/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/957//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/957//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/957//JDK8_Nightly_Build_Report_(Hadoop2)/]




(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> MultiRowRangeFilter should provide a method for creating a filter which is 
> functionally equivalent to multiple prefix filters
> -
>
> Key: HBASE-22833
> URL: https://issues.apache.org/jira/browse/HBASE-22833
> Project: HBase
>  Issue Type: Wish
>  Components: Client
>Affects Versions: 3.0.0
>Reporter: Itsuki Toyota
>Assignee: Itsuki Toyota
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.4.11
>
>
> HI,
> I think current formal way to make multiple prefix filters is to create a 
> _FilterList_ and add _PrefixFilter_ instances to the list:
> {code:java}
> FilterList allFilters = new FilterList(FilterList.Operator.MUST_PASS_ONE);
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("123")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("456")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("678")));
> scan.setFilter(allFilters);
> {code}
> (c.f., 
> https://stackoverflow.com/questions/41074213/hbase-how-to-specify-multiple-prefix-filters-in-a-single-scan-operation
>  )
> However, in the case of creating a single prefix filter, HBase provides 
> _scan.setRowPrefixFilter_ method.
> This method creates a range filter by setting a start row and a stop row.
> The value of a stop row is decided by calling 
> _calculateTheClosestNextRowKeyForPrefix_ ( c.f., 
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java#L574-L597
>  )
> _MultiRowRangeFilter_ could leverage a list of start row and stop row pairs 
> and _calculateTheClosestNextRowKeyForPrefix_ could compute the stop row value 
> corresponding to given start row (i.e., a prefix).
> I think this kind of filter (a filter which is functionally equivalent to 
> multiple prefix filters) should be creatable by _MultiRowRangeFilter_ and 
> it's better than the current formal way.
> Cheers,



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1



[ 
https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909421#comment-16909421
 ] 

Hudson commented on HBASE-22728:


Results for branch branch-1.4
[build #962 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/962/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/957//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/957//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/957//JDK8_Nightly_Build_Report_(Hadoop2)/]




(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Upgrade jackson dependencies in branch-1
> 
>
> Key: HBASE-22728
> URL: https://issues.apache.org/jira/browse/HBASE-22728
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 1.4.10, 1.3.5, 1.3.6
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 1.5.0, 1.4.11
>
> Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch, 
> HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch, 
> HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch, 
> HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch, 
> HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch, 
> HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch, 
> HBASE-22728.branch-1.18.patch, HBASE-22728.branch-1.19.patch
>
>
> Avoid Jackson versions and dependencies with known CVEs



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [hbase] busbey commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1

busbey commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based 
BlockCache) to branch-1
URL: https://github.com/apache/hbase/pull/251#issuecomment-522157997
 
 
   I don't know if the foundation has something set up to get old Oracle jdks. 
On the project we've been relying on Azul JDK's community edition:
   
   https://www.azul.com/downloads/zulu-community/?=java-7-lts
   
   If you tell Yetus to use the dockerfile from branch-1 you will get exactly 
the version we use in the precommit and nightly checks:
   
   https://github.com/apache/hbase/blob/branch-1/dev-support/docker/Dockerfile


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] ndimiduk commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1

ndimiduk commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based 
BlockCache) to branch-1
URL: https://github.com/apache/hbase/pull/251#issuecomment-522145886
 
 
   @busbey Looks like I cannot download Oracle JDK7 without a support
   contract. Does the Foundation have any kind of support around this?
   
   On Fri, Aug 16, 2019 at 8:46 AM Sean Busbey 
   wrote:
   
   > @busbey  is this "handling of jdk7/jdk8 bit"
   > something that I can take off your plate? Looks like it's something to do
   > with the Yetus hbase-personality used in the pre-commit job.
   >
   > that'd be fabulous. the hbase-personality.sh that's in dev-support needs
   > to have the function personality_modules updated to make sure we're
   > ignoring the new module when jdk7 is active.
   >
   > We already have the maven profiles set up to activate depending on the jdk
   > so that the module is only in the reactor when the correct jdk is available
   > at runtime. Unfortunately, the maven plugin for yetus relies on the
   > presence of a pom.xml file to identify modules rather than presence in the
   > reactor. I'm not sure if it'll be faster to figure out what jdk is around
   > or to figure out if maven thinks the module is in the reactor.
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (HBASE-22464) Improvements to hbase-vote script



[ 
https://issues.apache.org/jira/browse/HBASE-22464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909371#comment-16909371
 ] 

HBase QA commented on HBASE-22464:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  3m 
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
 1s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  3m 53s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/790/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22464 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12977836/HBASE-22464.v06.patch 
|
| Optional Tests |  dupname  asflicense  shellcheck  shelldocs  |
| uname | Linux 690b7e438caf 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 
05:29:03 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 3eb602c7f7 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| shellcheck | v0.4.4 |
| Max. process+thread count | 45 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/790/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |


This message was automatically generated.



> Improvements to hbase-vote script
> -
>
> Key: HBASE-22464
> URL: https://issues.apache.org/jira/browse/HBASE-22464
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.9, 1.3.4, 2.3.0, 2.1.4
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Trivial
> Attachments: HBASE-22464.branch-1.patch, HBASE-22464.v01.patch, 
> HBASE-22464.v02.patch, HBASE-22464.v03.patch, HBASE-22464.v04.patch, 
> HBASE-22464.v05.patch, HBASE-22464.v06.patch
>
>
> This Jira proposes to add the following two improvements:
>  # wget -N option for checking timestamp of downloaded RC files, if the local 
> copy of downloaded file is identical on the server, that file will be ignored.
>  # mvn -fn to never fail running the tests, previously with option -fae I 
> could not get the whole suite to run w/out failing.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22749) Distributed MOB compactions

2019-08-16 Thread Sean Busbey (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909365#comment-16909365
]

Sean Busbey commented on HBASE-22749:
-

h2. region sizing - splitting, normalizers, etc

Need to expressly state wether or not this change to per-region accounting
plans to alter the current assumptions that use of the feature means that the
MOB data isn’t counted when determining region size for decisions to normalize
or split.

h2. write amplification

Current description of the unified compactor’s handling of MOB data doesn’t
include anything about doing the kind of mob file partitioning that was
previously done. I think this will behave a lot like the example from Section
3.1.1 in the MOB Design v5 document you reference, specifically where MOB stuff
is segregated in a dedicated CF. We still end up getting unbounded write
amplification.

Consider this use case, which I think is in line with the assumptions laid out
in both your description and in the MOB Design v5 document:

* Table with 50k regions
* MOB values that are 300KiB
* No updates, no deletes
* periodic flushes set to 6 hours
* periodic major and mob compaction set to weekly
* infrequent writes (slow enough so that only periodic flushes happen, but
enough that all regions have a mob write)

Under the current MOB implementation with a monthly partition policy, I can
reason that:

* we’ll be generating 200k hfiles in the mob directory per day due to periodic
flushes
* at the first week we’ll have 1.4m new hfiles, which we’ll compact probably
into a low-double-digit number of hfiles
* at the second week, we’ll have 1.4m new hfiles plus the results of the first
compaction. we will probably compact this into a low-double-digit number of
hfiles
* at the third week, same thing again
* on the fourth week, same thing again
* After that fourth week things repeat, but the files generated will be in a
new partition and so anything from prior won’t be rewritten again.

In the steady state:

* we should have a number of hfiles that stays under the limits of HDFS
* for a given MOB value, we should only write it to HDFS no more than 5 times
(flush + between 1 and 4 compactions)

So that means we have a write amplification of ~5x regardless of splits or
merges from normalization.

For the new design I don’t think there’s currently any bound. If I use the
default compaction strategy:

* We’ll still be generating 200k hfiles per day
* at the first week we’ll have 1.4m new hfiles which we’ll compact to 50k
hfiles.
* at the end of second week we’ll have 1.4m new hfiles + the existing 50k
hfiles, and we’ll compact to 50k hfiles
* third week, same thing
* forth week, same thing
* this will repeat until each of the 50k files hits 10 GiB - 20 GiB depending
on configs (~35-70k cells)

At the extreme of exactly 1 mob value per region per periodic flush that would
mean 1-2 thousand weeks. Splits over that time period would mean probably we’d
keep rewriting indefinitely. So the amount of amplification is essentially
going to be driven by the periodicity of the mob compaction chore.

With default configs we can still get memstores that have ~1GiB of MOB values
and still only do periodic flushes, so this can remain a non-trivial amount of
load on HDFS.

If we enable partial major mob compaction we’d avoid writing the values
repeatedly, but we’d against HDFS limitations in ~10 days.

h2. MOB compaction request chore and Partial major mob compaction

It’s a bit confusing going through the “Partial major MOB compaction” section
where it currently is in the write up. As I understand things, you’re
essentially describing a strategy for the process that has to pick particular
regions to issue major compaction requests against instead of just requesting
the whole table be compacted. Since this is an optimization of cluster IO use
that’s possible _once we have per-region accounting and maintenance of MOB
data_ I think it’d be clearer if it was in a section _after_ you describe the
“scalable MOB compactions” stuff.

instead of starting that section off with the description of the compaction
request chore, you can explain the accounting changes to store maintenance, the
resulting changes to cleaning, and then end with the explanation about how
folks won’t have to schedule maintenance tasks themselves with a section that’s
labeled as the description of the “MOB Compaction Request Chore” and include
there the description fo the region prioritization strategy. Another good
strategy to mention there is prioritizing the store files we know haven’t been
converted to include accounting information the cleaner needs.

h2. split tracking for the above

Could we do this with entries in hbase:meta or a journal instead of individual
files? It’s going to get very messy when there are tables with
tens-of-thousands or hundreds-of-thousands of regions.

h2.

[GitHub] [hbase-operator-tools] asf-ci commented on issue #15: HBASE-22865 [HBCK2] shows the whole help/usage message after the error message

asf-ci commented on issue #15: HBASE-22865 [HBCK2] shows the whole help/usage 
message after the error message
URL: 
https://github.com/apache/hbase-operator-tools/pull/15#issuecomment-522133906
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/64/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (HBASE-22865) [HBCK2] shows the whole help/usage message after the error message

2019-08-16 Thread Sakthi (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909343#comment-16909343
 ] 

Sakthi commented on HBASE-22865:


Thanks Stack. Have put up the PR. If you get some chance to have a look.

> [HBCK2] shows the whole help/usage message after the error message
> --
>
> Key: HBASE-22865
> URL: https://issues.apache.org/jira/browse/HBASE-22865
> Project: HBase
>  Issue Type: Sub-task
>  Components: hbck2
>Affects Versions: hbase-operator-tools-1.0.0
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
>
> hbck2 shows the whole help/usage message after the error message. 
> Operators/users need to scroll all the way up to find the error message. With 
> the increasing client side support from hbck2 side, I reckon the usage 
> message is only going to get bigger & bigger.
> See an example here:
> {code:java}
> $ 
> HBASE_CLASSPATH_PREFIX=~/dev/hbase-operator-tools/hbase-hbck2/target/hbase-hbck2-1.0.0-SNAPSHOT.jar
>  ./bin/hbase org.apache.hbase.HBCK2 scheduleRecoveries
> ERROR: scheduleRecoveries takes one or more serverNames
> usage: HBCK2 [OPTIONS] COMMAND 
> Options:
>  -d,--debug   run with debug output
>  -h,--helpoutput this help message
>  -p,--hbase.zookeeper.property.clientPortport of hbase ensemble
>  -q,--hbase.zookeeper.quorum hbase ensemble
>  -s,--skipskip hbase version check
>   (PleaseHoldException)
>  -v,--version this hbck2 version
>  -z,--zookeeper.znode.parent parent znode of hbase
>   ensemble
> Command:
>  assigns [OPTIONS] ...
>Options:
> -o,--override  override ownership by another procedure
>A 'raw' assign that can be used even during Master initialization (if
>the -skip flag is specified). Skirts Coprocessors. Pass one or more
>encoded region names. 1588230740 is the hard-coded name for the
>hbase:meta region and de00010733901a05f5a2a3a382e27dd4 is an example of
>what a user-space encoded region name looks like. For example:
>  $ HBCK2 assign 1588230740 de00010733901a05f5a2a3a382e27dd4
>Returns the pid(s) of the created AssignProcedure(s) or -1 if none.
>  bypass [OPTIONS] ...
>Options:
> -o,--override   override if procedure is running/stuck
> -r,--recursive  bypass parent and its children. SLOW! EXPENSIVE!
> -w,--lockWait   milliseconds to wait before giving up; default=1
>Pass one (or more) procedure 'pid's to skip to procedure finish. Parent
>of bypassed procedure will also be skipped to the finish. Entities will
>be left in an inconsistent state and will require manual fixup. May
>need Master restart to clear locks still held. Bypass fails if
>procedure has children. Add 'recursive' if all you have is a parent pid
>to finish parent and children. This is SLOW, and dangerous so use
>selectively. Does not always work.
>  filesystem [OPTIONS] [...]
>Options:
> -f, --fixsideline corrupt hfiles, bad links, and references.
>Report on corrupt hfiles, references, broken links, and integrity.
>Pass '--fix' to sideline corrupt files and links. '--fix' does NOT
>fix integrity issues; i.e. 'holes' or 'orphan' regions. Pass one or
>more tablenames to narrow checkup. Default checks all tables and
>restores 'hbase.version' if missing. Interacts with the filesystem
> only!
>Modified regions need to be reopened to pick-up changes.
>  replication [OPTIONS] [...]
>Options:
> -f, --fixfix any replication issues found.
>Looks for undeleted replication queues and deletes them if passed the
>'--fix' option. Pass a table name to check for replication barrier and
>purge if '--fix'.
>  setRegionState  
>Possible region states:
> OFFLINE, OPENING, OPEN, CLOSING, CLOSED, SPLITTING, SPLIT,
> FAILED_OPEN, FAILED_CLOSE, MERGING, MERGED, SPLITTING_NEW,
> MERGING_NEW, ABNORMALLY_CLOSED
>WARNING: This is a very risky option intended for use as last resort.
>Example scenarios include unassigns/assigns that can't move forward
>because region is in an inconsistent state in 'hbase:meta'. For
>example, the 'unassigns' command can only proceed if passed a region
>in one of the following states: SPLITTING|SPLIT|MERGING|OPEN|CLOSING
>Before manually setting a region state with this command, please
>certify that this region is not being handled by a running procedure,
>such as 'assign' or 'split'. You can get a view of running procedures
>in the hbase shell using the 'list_procedures'

[jira] [Commented] (HBASE-22464) Improvements to hbase-vote script



[ 
https://issues.apache.org/jira/browse/HBASE-22464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909336#comment-16909336
 ] 

Artem Ervits commented on HBASE-22464:
--

[~busbey] thank you, .v06 addresses your comments.

> Improvements to hbase-vote script
> -
>
> Key: HBASE-22464
> URL: https://issues.apache.org/jira/browse/HBASE-22464
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.9, 1.3.4, 2.3.0, 2.1.4
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Trivial
> Attachments: HBASE-22464.branch-1.patch, HBASE-22464.v01.patch, 
> HBASE-22464.v02.patch, HBASE-22464.v03.patch, HBASE-22464.v04.patch, 
> HBASE-22464.v05.patch, HBASE-22464.v06.patch
>
>
> This Jira proposes to add the following two improvements:
>  # wget -N option for checking timestamp of downloaded RC files, if the local 
> copy of downloaded file is identical on the server, that file will be ignored.
>  # mvn -fn to never fail running the tests, previously with option -fae I 
> could not get the whole suite to run w/out failing.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (HBASE-22464) Improvements to hbase-vote script



 [ 
https://issues.apache.org/jira/browse/HBASE-22464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Artem Ervits updated HBASE-22464:
-
Status: Patch Available  (was: Open)

> Improvements to hbase-vote script
> -
>
> Key: HBASE-22464
> URL: https://issues.apache.org/jira/browse/HBASE-22464
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 2.1.4, 1.3.4, 1.4.9, 2.2.0, 3.0.0, 1.5.0, 2.3.0
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Trivial
> Attachments: HBASE-22464.branch-1.patch, HBASE-22464.v01.patch, 
> HBASE-22464.v02.patch, HBASE-22464.v03.patch, HBASE-22464.v04.patch, 
> HBASE-22464.v05.patch, HBASE-22464.v06.patch
>
>
> This Jira proposes to add the following two improvements:
>  # wget -N option for checking timestamp of downloaded RC files, if the local 
> copy of downloaded file is identical on the server, that file will be ignored.
>  # mvn -fn to never fail running the tests, previously with option -fae I 
> could not get the whole suite to run w/out failing.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (HBASE-22464) Improvements to hbase-vote script



 [ 
https://issues.apache.org/jira/browse/HBASE-22464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Artem Ervits updated HBASE-22464:
-
Status: Open  (was: Patch Available)

> Improvements to hbase-vote script
> -
>
> Key: HBASE-22464
> URL: https://issues.apache.org/jira/browse/HBASE-22464
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 2.1.4, 1.3.4, 1.4.9, 2.2.0, 3.0.0, 1.5.0, 2.3.0
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Trivial
> Attachments: HBASE-22464.branch-1.patch, HBASE-22464.v01.patch, 
> HBASE-22464.v02.patch, HBASE-22464.v03.patch, HBASE-22464.v04.patch, 
> HBASE-22464.v05.patch, HBASE-22464.v06.patch
>
>
> This Jira proposes to add the following two improvements:
>  # wget -N option for checking timestamp of downloaded RC files, if the local 
> copy of downloaded file is identical on the server, that file will be ignored.
>  # mvn -fn to never fail running the tests, previously with option -fae I 
> could not get the whole suite to run w/out failing.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (HBASE-22464) Improvements to hbase-vote script



 [ 
https://issues.apache.org/jira/browse/HBASE-22464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Artem Ervits updated HBASE-22464:
-
Attachment: HBASE-22464.v06.patch

> Improvements to hbase-vote script
> -
>
> Key: HBASE-22464
> URL: https://issues.apache.org/jira/browse/HBASE-22464
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.9, 1.3.4, 2.3.0, 2.1.4
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Trivial
> Attachments: HBASE-22464.branch-1.patch, HBASE-22464.v01.patch, 
> HBASE-22464.v02.patch, HBASE-22464.v03.patch, HBASE-22464.v04.patch, 
> HBASE-22464.v05.patch, HBASE-22464.v06.patch
>
>
> This Jira proposes to add the following two improvements:
>  # wget -N option for checking timestamp of downloaded RC files, if the local 
> copy of downloaded file is identical on the server, that file will be ignored.
>  # mvn -fn to never fail running the tests, previously with option -fae I 
> could not get the whole suite to run w/out failing.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22464) Improvements to hbase-vote script

2019-08-16 Thread Sean Busbey (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909264#comment-16909264
 ] 

Sean Busbey commented on HBASE-22464:
-

{code}
-function run_all_tests() {
+function run_tests() {
{code}

Great! I think there are a few places that also need to be updated with the 
function name change. could you get those at the same time as well? (e.g. log 
output file names, invocation, etc) 

> Improvements to hbase-vote script
> -
>
> Key: HBASE-22464
> URL: https://issues.apache.org/jira/browse/HBASE-22464
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.9, 1.3.4, 2.3.0, 2.1.4
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Trivial
> Attachments: HBASE-22464.branch-1.patch, HBASE-22464.v01.patch, 
> HBASE-22464.v02.patch, HBASE-22464.v03.patch, HBASE-22464.v04.patch, 
> HBASE-22464.v05.patch
>
>
> This Jira proposes to add the following two improvements:
>  # wget -N option for checking timestamp of downloaded RC files, if the local 
> copy of downloaded file is identical on the server, that file will be ignored.
>  # mvn -fn to never fail running the tests, previously with option -fae I 
> could not get the whole suite to run w/out failing.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22464) Improvements to hbase-vote script



[ 
https://issues.apache.org/jira/browse/HBASE-22464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909257#comment-16909257
 ] 

HBase QA commented on HBASE-22464:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
 1s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
13s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  1m 56s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/788/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22464 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12977808/HBASE-22464.v05.patch 
|
| Optional Tests |  dupname  asflicense  shellcheck  shelldocs  |
| uname | Linux bd30c8ff24dd 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 3eb602c7f7 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| shellcheck | v0.4.4 |
| Max. process+thread count | 46 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/788/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |


This message was automatically generated.



> Improvements to hbase-vote script
> -
>
> Key: HBASE-22464
> URL: https://issues.apache.org/jira/browse/HBASE-22464
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.9, 1.3.4, 2.3.0, 2.1.4
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Trivial
> Attachments: HBASE-22464.branch-1.patch, HBASE-22464.v01.patch, 
> HBASE-22464.v02.patch, HBASE-22464.v03.patch, HBASE-22464.v04.patch, 
> HBASE-22464.v05.patch
>
>
> This Jira proposes to add the following two improvements:
>  # wget -N option for checking timestamp of downloaded RC files, if the local 
> copy of downloaded file is identical on the server, that file will be ignored.
>  # mvn -fn to never fail running the tests, previously with option -fae I 
> could not get the whole suite to run w/out failing.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [hbase-operator-tools] jatsakthi commented on issue #15: HBASE-22865 [HBCK2] shows the whole help/usage message after the error message

jatsakthi commented on issue #15: HBASE-22865 [HBCK2] shows the whole 
help/usage message after the error message
URL: 
https://github.com/apache/hbase-operator-tools/pull/15#issuecomment-522090918
 
 
   Adding a test case shortly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (HBASE-22865) [HBCK2] shows the whole help/usage message after the error message

2019-08-16 Thread stack (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909239#comment-16909239
 ] 

stack commented on HBASE-22865:
---

I like your first suggestion and second.
S

> [HBCK2] shows the whole help/usage message after the error message
> --
>
> Key: HBASE-22865
> URL: https://issues.apache.org/jira/browse/HBASE-22865
> Project: HBase
>  Issue Type: Sub-task
>  Components: hbck2
>Affects Versions: hbase-operator-tools-1.0.0
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
>
> hbck2 shows the whole help/usage message after the error message. 
> Operators/users need to scroll all the way up to find the error message. With 
> the increasing client side support from hbck2 side, I reckon the usage 
> message is only going to get bigger & bigger.
> See an example here:
> {code:java}
> $ 
> HBASE_CLASSPATH_PREFIX=~/dev/hbase-operator-tools/hbase-hbck2/target/hbase-hbck2-1.0.0-SNAPSHOT.jar
>  ./bin/hbase org.apache.hbase.HBCK2 scheduleRecoveries
> ERROR: scheduleRecoveries takes one or more serverNames
> usage: HBCK2 [OPTIONS] COMMAND 
> Options:
>  -d,--debug   run with debug output
>  -h,--helpoutput this help message
>  -p,--hbase.zookeeper.property.clientPortport of hbase ensemble
>  -q,--hbase.zookeeper.quorum hbase ensemble
>  -s,--skipskip hbase version check
>   (PleaseHoldException)
>  -v,--version this hbck2 version
>  -z,--zookeeper.znode.parent parent znode of hbase
>   ensemble
> Command:
>  assigns [OPTIONS] ...
>Options:
> -o,--override  override ownership by another procedure
>A 'raw' assign that can be used even during Master initialization (if
>the -skip flag is specified). Skirts Coprocessors. Pass one or more
>encoded region names. 1588230740 is the hard-coded name for the
>hbase:meta region and de00010733901a05f5a2a3a382e27dd4 is an example of
>what a user-space encoded region name looks like. For example:
>  $ HBCK2 assign 1588230740 de00010733901a05f5a2a3a382e27dd4
>Returns the pid(s) of the created AssignProcedure(s) or -1 if none.
>  bypass [OPTIONS] ...
>Options:
> -o,--override   override if procedure is running/stuck
> -r,--recursive  bypass parent and its children. SLOW! EXPENSIVE!
> -w,--lockWait   milliseconds to wait before giving up; default=1
>Pass one (or more) procedure 'pid's to skip to procedure finish. Parent
>of bypassed procedure will also be skipped to the finish. Entities will
>be left in an inconsistent state and will require manual fixup. May
>need Master restart to clear locks still held. Bypass fails if
>procedure has children. Add 'recursive' if all you have is a parent pid
>to finish parent and children. This is SLOW, and dangerous so use
>selectively. Does not always work.
>  filesystem [OPTIONS] [...]
>Options:
> -f, --fixsideline corrupt hfiles, bad links, and references.
>Report on corrupt hfiles, references, broken links, and integrity.
>Pass '--fix' to sideline corrupt files and links. '--fix' does NOT
>fix integrity issues; i.e. 'holes' or 'orphan' regions. Pass one or
>more tablenames to narrow checkup. Default checks all tables and
>restores 'hbase.version' if missing. Interacts with the filesystem
> only!
>Modified regions need to be reopened to pick-up changes.
>  replication [OPTIONS] [...]
>Options:
> -f, --fixfix any replication issues found.
>Looks for undeleted replication queues and deletes them if passed the
>'--fix' option. Pass a table name to check for replication barrier and
>purge if '--fix'.
>  setRegionState  
>Possible region states:
> OFFLINE, OPENING, OPEN, CLOSING, CLOSED, SPLITTING, SPLIT,
> FAILED_OPEN, FAILED_CLOSE, MERGING, MERGED, SPLITTING_NEW,
> MERGING_NEW, ABNORMALLY_CLOSED
>WARNING: This is a very risky option intended for use as last resort.
>Example scenarios include unassigns/assigns that can't move forward
>because region is in an inconsistent state in 'hbase:meta'. For
>example, the 'unassigns' command can only proceed if passed a region
>in one of the following states: SPLITTING|SPLIT|MERGING|OPEN|CLOSING
>Before manually setting a region state with this command, please
>certify that this region is not being handled by a running procedure,
>such as 'assign' or 'split'. You can get a view of running procedures
>in the hbase shell using the 'list_procedures' command. An example
>setting

[jira] [Commented] (HBASE-22866) Multiple slf4j-log4j provider versions included in binary package (branch-1)

2019-08-16 Thread Andrew Purtell (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909229#comment-16909229
 ] 

Andrew Purtell commented on HBASE-22866:


I was thinking we just ask for one common version in the dependency 
configuration in the top level project pom for both org.slf4j:slf4j-log4j12 and 
org.slf4j:slf4j-api. Then maven should do the right thing.

> Multiple slf4j-log4j provider versions included in binary package (branch-1)
> 
>
> Key: HBASE-22866
> URL: https://issues.apache.org/jira/browse/HBASE-22866
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Priority: Minor
> Fix For: 1.5.0
>
>
> Examining binary assembly results there are multiple versions of slf4j-log4j 
> in lib/
> {noformat}
> slf4j-api-1.7.7.jar
> slf4j-log4j12-1.6.1.jar
> slf4j-log4j12-1.7.10.jar
> slf4j-log4j12-1.7.7.jar
> {noformat}
> We aren't managing slf4j-log4j12 dependency versions correctly, somehow. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…

Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if 
their RSGroup has no highest ve…
URL: https://github.com/apache/hbase/pull/435#issuecomment-522081227
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 98 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | 0 | shelldocs | 0 | Shelldocs was not available. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 38 | Maven dependency ordering for branch |
   | +1 | mvninstall | 423 | master passed |
   | +1 | compile | 130 | master passed |
   | +1 | checkstyle | 139 | master passed |
   | +1 | shadedjars | 331 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 85 | master passed |
   | 0 | spotbugs | 299 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 409 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 16 | Maven dependency ordering for patch |
   | +1 | mvninstall | 404 | the patch passed |
   | +1 | compile | 123 | the patch passed |
   | +1 | javac | 123 | the patch passed |
   | -1 | checkstyle | 97 | hbase-server: The patch generated 1 new + 9 
unchanged - 0 fixed = 10 total (was 9) |
   | +1 | shellcheck | 0 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 341 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1222 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 88 | the patch passed |
   | -1 | findbugs | 70 | hbase-common generated 1 new + 0 unchanged - 0 fixed 
= 1 total (was 0) |
   ||| _ Other Tests _ |
   | +1 | unit | 200 | hbase-common in the patch passed. |
   | -1 | unit | 19118 | hbase-server in the patch failed. |
   | +1 | unit | 669 | hbase-rsgroup in the patch passed. |
   | +1 | asflicense | 106 | The patch does not generate ASF License warnings. |
   | | | 25084 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | FindBugs | module:hbase-common |
   |  |  org.apache.hadoop.hbase.Version.() 
invokes inefficient new String(String) constructor  At Version.java:inefficient 
new String(String) constructor  At Version.java:[line 10] |
   | Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
   |   | hadoop.hbase.master.TestMasterShutdown |
   |   | hadoop.hbase.replication.TestReplicationSmallTests |
   |   | hadoop.hbase.tool.TestSecureBulkLoadHFiles |
   |   | hadoop.hbase.client.TestCloneSnapshotFromClientNormal |
   |   | hadoop.hbase.util.TestFromClientSide3WoUnsafe |
   |   | hadoop.hbase.client.TestCloneSnapshotFromClientCloneLinksAfterDelete |
   |   | hadoop.hbase.client.TestFromClientSide |
   |   | hadoop.hbase.tool.TestBulkLoadHFiles |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/51/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/435 |
   | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc 
unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux feafa772bf56 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh
 |
   | git revision | master / 3eb602c7f7 |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/51/artifact/out/diff-checkstyle-hbase-server.txt
 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/51/artifact/out/new-findbugs-hbase-common.html
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/51/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/51/testReport/
 |
   | Max. process+thread count | 4985 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-server hbase-rsgroup U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/51/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 
findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This

[jira] [Commented] (HBASE-22860) Master's webui returns NPE/HTTP 500 under maintenance mode



[ 
https://issues.apache.org/jira/browse/HBASE-22860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909218#comment-16909218
 ] 

Hudson commented on HBASE-22860:


Results for branch branch-2.1
[build #1490 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1490/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1490//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1490//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1490//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Master's webui returns NPE/HTTP 500 under maintenance mode
> --
>
> Key: HBASE-22860
> URL: https://issues.apache.org/jira/browse/HBASE-22860
> Project: HBase
>  Issue Type: Bug
>  Components: master, UI
>Affects Versions: 3.0.0, 2.2.0, 2.1.5, 2.2.1, 2.1.6
>Reporter: Daisuke Kobayashi
>Assignee: Daisuke Kobayashi
>Priority: Major
> Fix For: 3.0.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22860.master.001.patch, 
> HBASE-22860.master.002.patch, Screen Shot 2019-08-15 at 4.15.51 PM.png
>
>
> Master's webui is not accessible when {{hbase.master.maintenance_mode}} is 
> set to true. This is because it's trying to load a coprocessor 
> {{RSGroupAdminEndpoint}}.
> {code}
> java.lang.NullPointerException
>   at 
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmplImpl.renderNoFlush(MasterStatusTmplImpl.java:326)
>   at 
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.renderNoFlush(MasterStatusTmpl.java:397)
>   at 
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.render(MasterStatusTmpl.java:388)
>   at 
> org.apache.hadoop.hbase.master.MasterStatusServlet.doGet(MasterStatusServlet.java:81)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
>   at 
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:848)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1780)
>   at 
> org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:112)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
>   at 
> org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
>   at 
> org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1374)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
>   at 
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
>   at 
> org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:583)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
>   at 
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:513)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
>   at 
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119)
>   at 
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
>   at org.eclipse.jetty.server.Server.handle(Server.java:539)
>   at

[jira] [Commented] (HBASE-22858) Add HBCK Report to master's header.jsp



[ 
https://issues.apache.org/jira/browse/HBASE-22858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909217#comment-16909217
 ] 

Hudson commented on HBASE-22858:


Results for branch branch-2.1
[build #1490 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1490/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1490//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1490//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1490//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Add HBCK Report to master's header.jsp
> --
>
> Key: HBASE-22858
> URL: https://issues.apache.org/jira/browse/HBASE-22858
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22863) Avoid Jackson versions and dependencies with known CVEs



[ 
https://issues.apache.org/jira/browse/HBASE-22863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909211#comment-16909211
 ] 

HBase QA commented on HBASE-22863:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
38s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
26s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  6m 
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
47s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  4m 
24s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  6m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  6m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m 
22s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
42s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
16m 40s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  4m 
22s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
57s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
32s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
47s{color} | {color:green} hbase-zookeeper in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m  
2s{color} | {color:green} hbase-http in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m 
32s{color} | {color:green} hbase-procedure in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}141m  2s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 18m  
5s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
48s{color} | {color:green} hbase-testing-util in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
54s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  7m  
8s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m  
9s{color} | {color:green} hbase-endpoint in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 13m 
44s{color} | {color:green} hbase-backup in the patch passed. {color} |
|

[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…

Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts 
of TokenUtil off into a Clien…
URL: https://github.com/apache/hbase/pull/361#issuecomment-522076121
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 71 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 32 | Maven dependency ordering for branch |
   | +1 | mvninstall | 341 | master passed |
   | +1 | compile | 82 | master passed |
   | +1 | checkstyle | 115 | master passed |
   | +1 | shadedjars | 288 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 56 | master passed |
   | 0 | spotbugs | 258 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 324 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | +1 | mvninstall | 298 | the patch passed |
   | +1 | compile | 78 | the patch passed |
   | +1 | javac | 78 | the patch passed |
   | +1 | checkstyle | 102 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 272 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 936 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 54 | the patch passed |
   | +1 | findbugs | 335 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 102 | hbase-client in the patch passed. |
   | -1 | unit | 20011 | hbase-server in the patch failed. |
   | +1 | asflicense | 42 | The patch does not generate ASF License warnings. |
   | | | 23952 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.replication.TestReplicationDisableInactivePeer |
   |   | hadoop.hbase.tool.TestSecureBulkLoadHFiles |
   |   | hadoop.hbase.client.TestAsyncTableAdminApi3 |
   |   | hadoop.hbase.client.TestFromClientSide |
   |   | hadoop.hbase.TestRegionRebalancing |
   |   | hadoop.hbase.tool.TestBulkLoadHFiles |
   |   | hadoop.hbase.client.TestAdmin2 |
   |   | hadoop.hbase.replication.TestReplicationSmallTests |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
   |   | hadoop.hbase.replication.TestReplicationSmallTestsSync |
   |   | hadoop.hbase.util.TestFromClientSide3WoUnsafe |
   |   | hadoop.hbase.client.TestAsyncTableAdminApi |
   |   | hadoop.hbase.client.TestCloneSnapshotFromClientNormal |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/105/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/361 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux c78d1c44dbe2 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
 |
   | git revision | master / 3eb602c7f7 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/105/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/105/testReport/
 |
   | Max. process+thread count | 4939 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/105/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-16 Thread Caroline (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.branch-2.006.patch
HBASE-22804.branch-1.006.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-2.001.patch, 
> HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, 
> HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch, 
> HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, 
> HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, 
> HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [hbase] Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility

Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods 
from HBaseTestingUtility
URL: https://github.com/apache/hbase/pull/477#issuecomment-522072792
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 85 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 46 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 396 | master passed |
   | +1 | compile | 69 | master passed |
   | +1 | checkstyle | 101 | master passed |
   | +1 | shadedjars | 305 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 36 | master passed |
   | 0 | spotbugs | 266 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 264 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 331 | the patch passed |
   | +1 | compile | 57 | the patch passed |
   | +1 | javac | 57 | the patch passed |
   | +1 | checkstyle | 96 | the patch passed |
   | +1 | whitespace | 1 | The patch has no whitespace issues. |
   | +1 | shadedjars | 297 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1025 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 35 | the patch passed |
   | +1 | findbugs | 275 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 19874 | hbase-server in the patch failed. |
   | -1 | asflicense | 30 | The patch generated 18 ASF License warnings. |
   | | | 23680 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.client.TestUpdateConfiguration |
   |   | hadoop.hbase.master.assignment.TestRegionReplicaSplit |
   |   | hadoop.hbase.client.TestCIGetRpcTimeout |
   |   | 
hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleWAL |
   |   | hadoop.hbase.client.TestScanWithoutFetchingData |
   |   | hadoop.hbase.client.TestTableOperationException |
   |   | hadoop.hbase.coprocessor.TestRegionObserverBypass |
   |   | 
hadoop.hbase.security.visibility.TestVisibilityLabelsOnNewVersionBehaviorTable |
   |   | hadoop.hbase.wal.TestWALSplitBoundedLogWriterCreation |
   |   | hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput |
   |   | 
hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint |
   |   | hadoop.hbase.tool.TestSecureBulkLoadHFiles |
   |   | hadoop.hbase.regionserver.wal.TestWALReplayCompressed |
   |   | hadoop.hbase.client.TestScannersFromClientSide |
   |   | hadoop.hbase.master.procedure.TestMasterProcedureEvents |
   |   | hadoop.hbase.client.TestSeparateClientZKCluster |
   |   | hadoop.hbase.client.TestAsyncTableScanMetrics |
   |   | hadoop.hbase.coprocessor.TestWALObserver |
   |   | hadoop.hbase.client.TestFromClientSideScanExcpetion |
   |   | hadoop.hbase.client.TestResultSizeEstimation |
   |   | hadoop.hbase.client.TestSplitOrMergeStatus |
   |   | hadoop.hbase.master.procedure.TestDeleteTableProcedure |
   |   | hadoop.hbase.master.TestWarmupRegion |
   |   | hadoop.hbase.wal.TestFSHLogCorruptionDueToDanglingByteBuffer |
   |   | hadoop.hbase.quotas.TestQuotaTableUtil |
   |   | hadoop.hbase.regionserver.TestRowTooBig |
   |   | hadoop.hbase.TestLocalHBaseCluster |
   |   | hadoop.hbase.client.TestCIGetOperationTimeout |
   |   | 
hadoop.hbase.master.procedure.TestSCPWithMetaWithReplicasWithoutZKCoordinated |
   |   | hadoop.hbase.client.TestRawAsyncScanCursor |
   |   | hadoop.hbase.master.TestMasterFailover |
   |   | hadoop.hbase.master.TestMergeTableRegionsWhileRSCrash |
   |   | 
hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalCopyToRemote |
   |   | hadoop.hbase.wal.TestWALSplitCompressed |
   |   | hadoop.hbase.quotas.TestLowLatencySpaceQuotas |
   |   | hadoop.hbase.client.TestAdmin2 |
   |   | hadoop.hbase.regionserver.TestRegionFavoredNodes |
   |   | hadoop.hbase.master.assignment.TestSCPGetRegionsRace |
   |   | hadoop.hbase.TestClusterBootOrder |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
   |   | 
hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService 
|
   |   | hadoop.hbase.client.TestAdmin |
   |   | hadoop.hbase.client.TestAsyncMetaRegionLocator |
   |   | hadoop.hbase.master.snapshot.TestSnapshotWhileRSCrashes |
   |   | hadoop.hbase.client.TestAsyncBufferMutator |
   |   | hadoop.hbase.client.TestGetScanPartialResult |
   |   | hadoop.hbase.client.TestAsyncTableAdminApi2 |
   |   | hadoop.hbase.quotas.TestQuotaObserverChoreWithMiniCluster |
   |   | hadoop.hbase.master.procedure.TestCreateTableProcedure |
   |   |

[GitHub] [hbase] Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch

Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer 
chore with balance_switch
URL: https://github.com/apache/hbase/pull/468#issuecomment-522072737
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 71 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 332 | master passed |
   | +1 | compile | 53 | master passed |
   | +1 | checkstyle | 74 | master passed |
   | +1 | shadedjars | 272 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 38 | master passed |
   | 0 | spotbugs | 276 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 275 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 313 | the patch passed |
   | +1 | compile | 58 | the patch passed |
   | +1 | javac | 58 | the patch passed |
   | +1 | checkstyle | 81 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 283 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 970 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 33 | the patch passed |
   | +1 | findbugs | 278 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 20048 | hbase-server in the patch failed. |
   | +1 | asflicense | 29 | The patch does not generate ASF License warnings. |
   | | | 23585 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure |
   |   | hadoop.hbase.replication.TestReplicationDisableInactivePeer |
   |   | hadoop.hbase.tool.TestSecureBulkLoadHFiles |
   |   | hadoop.hbase.client.TestFromClientSide |
   |   | hadoop.hbase.tool.TestBulkLoadHFiles |
   |   | hadoop.hbase.client.TestAdmin2 |
   |   | hadoop.hbase.replication.TestReplicationSmallTests |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
   |   | hadoop.hbase.replication.TestReplicationSmallTestsSync |
   |   | 
hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint |
   |   | hadoop.hbase.util.TestFromClientSide3WoUnsafe |
   |   | hadoop.hbase.client.TestAsyncTableAdminApi |
   |   | hadoop.hbase.client.TestCloneSnapshotFromClientNormal |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/26/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/468 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 350b882e9c6c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
 |
   | git revision | master / 3eb602c7f7 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/26/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/26/testReport/
 |
   | Max. process+thread count | 4973 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/26/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (HBASE-22858) Add HBCK Report to master's header.jsp



[ 
https://issues.apache.org/jira/browse/HBASE-22858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909193#comment-16909193
 ] 

Hudson commented on HBASE-22858:


Results for branch branch-2.0
[build #1870 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1870/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1870//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1870//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1870//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Add HBCK Report to master's header.jsp
> --
>
> Key: HBASE-22858
> URL: https://issues.apache.org/jira/browse/HBASE-22858
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22833) MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters



[ 
https://issues.apache.org/jira/browse/HBASE-22833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909192#comment-16909192
 ] 

Hudson commented on HBASE-22833:


Results for branch branch-2.0
[build #1870 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1870/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1870//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1870//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1870//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> MultiRowRangeFilter should provide a method for creating a filter which is 
> functionally equivalent to multiple prefix filters
> -
>
> Key: HBASE-22833
> URL: https://issues.apache.org/jira/browse/HBASE-22833
> Project: HBase
>  Issue Type: Wish
>  Components: Client
>Affects Versions: 3.0.0
>Reporter: Itsuki Toyota
>Assignee: Itsuki Toyota
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.4.11
>
>
> HI,
> I think current formal way to make multiple prefix filters is to create a 
> _FilterList_ and add _PrefixFilter_ instances to the list:
> {code:java}
> FilterList allFilters = new FilterList(FilterList.Operator.MUST_PASS_ONE);
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("123")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("456")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("678")));
> scan.setFilter(allFilters);
> {code}
> (c.f., 
> https://stackoverflow.com/questions/41074213/hbase-how-to-specify-multiple-prefix-filters-in-a-single-scan-operation
>  )
> However, in the case of creating a single prefix filter, HBase provides 
> _scan.setRowPrefixFilter_ method.
> This method creates a range filter by setting a start row and a stop row.
> The value of a stop row is decided by calling 
> _calculateTheClosestNextRowKeyForPrefix_ ( c.f., 
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java#L574-L597
>  )
> _MultiRowRangeFilter_ could leverage a list of start row and stop row pairs 
> and _calculateTheClosestNextRowKeyForPrefix_ could compute the stop row value 
> corresponding to given start row (i.e., a prefix).
> I think this kind of filter (a filter which is functionally equivalent to 
> multiple prefix filters) should be creatable by _MultiRowRangeFilter_ and 
> it's better than the current formal way.
> Cheers,



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [hbase] Apache-HBase commented on issue #498: HBASE-22819 Automatically migrate the rs group config for table after…

Apache-HBase commented on issue #498: HBASE-22819 Automatically migrate the rs 
group config for table after…
URL: https://github.com/apache/hbase/pull/498#issuecomment-522069663
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 87 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ HBASE-22514 Compile Tests _ |
   | 0 | mvndep | 41 | Maven dependency ordering for branch |
   | +1 | mvninstall | 454 | HBASE-22514 passed |
   | +1 | compile | 104 | HBASE-22514 passed |
   | +1 | checkstyle | 124 | HBASE-22514 passed |
   | +1 | shadedjars | 387 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 72 | HBASE-22514 passed |
   | 0 | spotbugs | 321 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 380 | HBASE-22514 passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 18 | Maven dependency ordering for patch |
   | +1 | mvninstall | 409 | the patch passed |
   | +1 | compile | 96 | the patch passed |
   | +1 | javac | 96 | the patch passed |
   | +1 | checkstyle | 130 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 372 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1232 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 63 | the patch passed |
   | +1 | findbugs | 404 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 196 | hbase-common in the patch passed. |
   | -1 | unit | 18556 | hbase-server in the patch failed. |
   | +1 | asflicense | 153 | The patch does not generate ASF License warnings. |
   | | | 23831 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.rsgroup.TestMigrateRSGroupInfo |
   |   | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
   |   | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory |
   |   | hadoop.hbase.tool.TestSecureBulkLoadHFiles |
   |   | hadoop.hbase.snapshot.TestFlushSnapshotFromClient |
   |   | hadoop.hbase.client.TestCloneSnapshotFromClientNormal |
   |   | hadoop.hbase.namespace.TestNamespaceAuditor |
   |   | hadoop.hbase.tool.TestBulkLoadHFiles |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/5/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/498 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux bbf774a75aeb 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-498/out/precommit/personality/provided.sh
 |
   | git revision | HBASE-22514 / 32a2015934 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/5/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/5/testReport/
 |
   | Max. process+thread count | 4500 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/5/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation

Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods 
from Mutation
URL: https://github.com/apache/hbase/pull/478#issuecomment-522067064
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 92 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 37 | Maven dependency ordering for branch |
   | +1 | mvninstall | 418 | master passed |
   | +1 | compile | 107 | master passed |
   | +1 | checkstyle | 137 | master passed |
   | +1 | shadedjars | 358 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 69 | master passed |
   | 0 | spotbugs | 293 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 375 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 18 | Maven dependency ordering for patch |
   | +1 | mvninstall | 445 | the patch passed |
   | +1 | compile | 102 | the patch passed |
   | +1 | javac | 102 | the patch passed |
   | +1 | checkstyle | 144 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 387 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1367 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 68 | the patch passed |
   | +1 | findbugs | 416 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 119 | hbase-client in the patch passed. |
   | -1 | unit | 17320 | hbase-server in the patch failed. |
   | +1 | asflicense | 113 | The patch does not generate ASF License warnings. |
   | | | 22615 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.util.TestFromClientSide3WoUnsafe |
   |   | hadoop.hbase.replication.TestReplicationSmallTests |
   |   | hadoop.hbase.tool.TestSecureBulkLoadHFiles |
   |   | hadoop.hbase.tool.TestBulkLoadHFiles |
   |   | hadoop.hbase.replication.TestReplicationSmallTestsSync |
   |   | hadoop.hbase.client.TestFromClientSide |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/17/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/478 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux a08a6f7e6dc4 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-478/out/precommit/personality/provided.sh
 |
   | git revision | master / 3eb602c7f7 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/17/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/17/testReport/
 |
   | Max. process+thread count | 4840 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/17/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (HBASE-22464) Improvements to hbase-vote script



 [ 
https://issues.apache.org/jira/browse/HBASE-22464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Artem Ervits updated HBASE-22464:
-
Attachment: HBASE-22464.v05.patch

> Improvements to hbase-vote script
> -
>
> Key: HBASE-22464
> URL: https://issues.apache.org/jira/browse/HBASE-22464
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.9, 1.3.4, 2.3.0, 2.1.4
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Trivial
> Attachments: HBASE-22464.branch-1.patch, HBASE-22464.v01.patch, 
> HBASE-22464.v02.patch, HBASE-22464.v03.patch, HBASE-22464.v04.patch, 
> HBASE-22464.v05.patch
>
>
> This Jira proposes to add the following two improvements:
>  # wget -N option for checking timestamp of downloaded RC files, if the local 
> copy of downloaded file is identical on the server, that file will be ignored.
>  # mvn -fn to never fail running the tests, previously with option -fae I 
> could not get the whole suite to run w/out failing.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…

Apache-HBase commented on issue #446: HBASE-22781 optimize the test case 
TestStoreScanner.testScanSameTimes…
URL: https://github.com/apache/hbase/pull/446#issuecomment-522057215
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 145 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 343 | master passed |
   | +1 | compile | 54 | master passed |
   | +1 | checkstyle | 79 | master passed |
   | +1 | shadedjars | 274 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 36 | master passed |
   | 0 | spotbugs | 253 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 250 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 349 | the patch passed |
   | +1 | compile | 52 | the patch passed |
   | +1 | javac | 52 | the patch passed |
   | +1 | checkstyle | 75 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 278 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 978 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 36 | the patch passed |
   | +1 | findbugs | 261 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 16889 | hbase-server in the patch failed. |
   | +1 | asflicense | 72 | The patch does not generate ASF License warnings. |
   | | | 20567 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.master.TestMasterShutdown |
   |   | hadoop.hbase.tool.TestBulkLoadHFiles |
   |   | hadoop.hbase.client.TestSnapshotCloneIndependence |
   |   | hadoop.hbase.client.TestFromClientSide |
   |   | hadoop.hbase.tool.TestSecureBulkLoadHFiles |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/49/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/446 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 21f54dbd61d1 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-446/out/precommit/personality/provided.sh
 |
   | git revision | master / 3eb602c7f7 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/49/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/49/testReport/
 |
   | Max. process+thread count | 4984 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/49/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] busbey commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1

busbey commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based 
BlockCache) to branch-1
URL: https://github.com/apache/hbase/pull/251#issuecomment-522055881
 
 
   > @busbey is this "handling of jdk7/jdk8 bit" something that I can take off 
your plate? Looks like it's something to do with the Yetus hbase-personality 
used in the pre-commit job.
   
   that'd be fabulous. the `hbase-personality.sh` that's in `dev-support` needs 
to have the function `personality_modules` updated to make sure we're ignoring 
the new module when jdk7 is active. 
   
   
   We already have the maven profiles set up to activate depending on the jdk 
so that the module is only in the reactor when the correct jdk is available at 
runtime. Unfortunately, the maven plugin for yetus relies on the presence of a 
pom.xml file to identify modules rather than presence in the reactor. I'm not 
sure if it'll be faster to figure out what jdk is around or to figure out if 
maven thinks the module is in the reactor.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.

2019-08-16 Thread Hadoop QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909135#comment-16909135
 ] 

Hadoop QA commented on HBASE-22601:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m  
6s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
 3s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
37s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  4m  
6s{color} | {color:blue} Used deprecated FindBugs config; considering switching 
to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m  
1s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
 2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
 4s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
16m 55s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
15s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}282m 34s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
30s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}342m 35s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
|   | hadoop.hbase.client.TestFromClientSide |
|   | hadoop.hbase.master.TestMasterShutdown |
|   | hadoop.hbase.util.TestFromClientSide3WoUnsafe |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/6/artifact/out/Dockerfile
 |
| GITHUB PR | https://github.com/apache/hbase/pull/499 |
| JIRA Issue | HBASE-22601 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 96aa07193152 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
|

[GitHub] [hbase] Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.

Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of 
peers leads to cluster shutdown.
URL: https://github.com/apache/hbase/pull/499#issuecomment-522053293
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 66 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 327 | master passed |
   | +1 | compile | 56 | master passed |
   | +1 | checkstyle | 76 | master passed |
   | +1 | shadedjars | 303 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 37 | master passed |
   | 0 | spotbugs | 246 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 241 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 302 | the patch passed |
   | +1 | compile | 54 | the patch passed |
   | +1 | javac | 54 | the patch passed |
   | +1 | checkstyle | 79 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 304 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1015 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 31 | the patch passed |
   | +1 | findbugs | 255 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 16954 | hbase-server in the patch failed. |
   | +1 | asflicense | 30 | The patch does not generate ASF License warnings. |
   | | | 20555 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
   |   | hadoop.hbase.client.TestFromClientSide |
   |   | hadoop.hbase.master.TestMasterShutdown |
   |   | hadoop.hbase.util.TestFromClientSide3WoUnsafe |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/6/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/499 |
   | JIRA Issue | HBASE-22601 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 96aa07193152 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-499/out/precommit/personality/provided.sh
 |
   | git revision | master / 3eb602c7f7 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/6/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/6/testReport/
 |
   | Max. process+thread count | 5016 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/6/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #483: HBASE-22841 Add more factory functions to TimeRange

Apache-HBase commented on issue #483: HBASE-22841 Add more factory functions to 
TimeRange
URL: https://github.com/apache/hbase/pull/483#issuecomment-522052731
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 207 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 34 | Maven dependency ordering for branch |
   | +1 | mvninstall | 482 | master passed |
   | +1 | compile | 98 | master passed |
   | +1 | checkstyle | 107 | master passed |
   | +1 | shadedjars | 327 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 58 | master passed |
   | 0 | spotbugs | 264 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 316 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 19 | Maven dependency ordering for patch |
   | +1 | mvninstall | 351 | the patch passed |
   | +1 | compile | 79 | the patch passed |
   | +1 | javac | 79 | the patch passed |
   | +1 | checkstyle | 97 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 276 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 990 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 55 | the patch passed |
   | +1 | findbugs | 308 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 171 | hbase-common in the patch passed. |
   | +1 | unit | 15563 | hbase-server in the patch passed. |
   | +1 | asflicense | 68 | The patch does not generate ASF License warnings. |
   | | | 20053 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/14/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/483 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux b26c1d90b9d7 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 
13:14:43 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-483/out/precommit/personality/provided.sh
 |
   | git revision | master / 3eb602c7f7 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/14/testReport/
 |
   | Max. process+thread count | 5079 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/14/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (HBASE-22618) Provide a way to have Heterogeneous deployment



[ 
https://issues.apache.org/jira/browse/HBASE-22618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909134#comment-16909134
 ] 

HBase QA commented on HBASE-22618:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m  
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
20s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
29s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
39s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
15m 51s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m  
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}292m 19s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
35s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}347m 35s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.TestMasterShutdown |
|   | hadoop.hbase.replication.TestReplicationSmallTestsSync |
|   | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
|   | hadoop.hbase.client.TestFromClientSide |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/786/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22618 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/1293/HBASE-22618.master.001.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux c7e9d7a1c47e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 3eb602c7f7 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/786/artifact/patchprocess/patch-unit-hbase-server.txt
 |
|  Test Results |

[jira] [Commented] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)

2019-08-16 Thread Reid Chan (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909122#comment-16909122
 ] 

Reid Chan commented on HBASE-22835:
---

See the updated description, I can review it.
But not sure if there still be 1.3.6 release, since branch-1.3's jackson CVE is 
not solved in HBASE-22728.

> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw 
> AssertionError (backport of  HBASE-19863)
> 
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch, 
> HBASE-22835.v2.branch-1.3.patch, HBASE-22835.v3.branch-1.3.patch, 
> HBASE-22835.v4.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw 
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from 
> the same problem.
>  
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
>  actual hfs offset can be behind, in this case heap.next() is not enough. it 
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key 
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller 
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at 
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
>  at 
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551) 
> at 
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150) 
> at 
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
>  at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
>  at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
>  at 
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
>  at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at 
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168) 
> {code}
> I created a backport patch of -HBASE-19863 and  *HBASE-17958*-.
> Exact same testcase included. And changed StoreScanner due to the difference 
> of codes.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22859) [HBCK2] Fix the orphan regions on filesystem

2019-08-16 Thread stack (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909120#comment-16909120
 ] 

stack commented on HBASE-22859:
---

What is the plan here [~zghaobac]? What you thinking sir? Thanks.

> [HBCK2] Fix the orphan regions on filesystem
> 
>
> Key: HBASE-22859
> URL: https://issues.apache.org/jira/browse/HBASE-22859
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
>
> Plan to add this feature to HBCK2 tool firstly.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22867) The ForkJoinPool in CleanerChore will spawn thousands of threads in our cluster with thousands table

2019-08-16 Thread Reid Chan (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909116#comment-16909116
 ] 

Reid Chan commented on HBASE-22867:
---

Need some time to understand the story of SnapshotHFileCleaner and its 
implementation.

> The ForkJoinPool in CleanerChore will spawn thousands of threads in our 
> cluster with thousands table
> 
>
> Key: HBASE-22867
> URL: https://issues.apache.org/jira/browse/HBASE-22867
> Project: HBase
>  Issue Type: Bug
>Reporter: Zheng Hu
>Priority: Critical
> Attachments: 31162.stack.1
>
>
> The thousands of spawned  threads make the safepoint cost 80+s in our Master 
> JVM processs.
> {code}
> 2019-08-15,19:35:35,861 INFO [main-SendThread(zjy-hadoop-prc-zk02.bj:11000)] 
> org.apache.zookeeper.ClientCnxn: Client session timed out, have not heard 
> from server in 82260ms for sessionid 0x1691332e2d3aae5, closing socket 
> connection and at
> tempting reconnect
> {code}
> The stdout from JVM (can see from here there're 9126 threads & sync cost 80+s)
> {code}
> vmop[threads: total initially_running wait_to_block]
> [time: spin block sync cleanup vmop] page_trap_count
> 32358.859: ForceAsyncSafepoint  [9126 67
> 474]  [ 128 8659687   101]  0
> {code}
> Also we got the jstack: 
> {code}
> $ cat 31162.stack.1  | grep 'ForkJoinPool-1-worker' | wc -l
> 8648
> {code}
> It's a dangerous bug, make it as blocker.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22867) The ForkJoinPool in CleanerChore will spawn thousands of threads in our cluster with thousands table

2019-08-16 Thread Reid Chan (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909115#comment-16909115
 ] 

Reid Chan commented on HBASE-22867:
---

The phenomenon is too much threads, but the reason behind is somewhere abnormal 
slow, IMO.

I checked the dump, all BLOCKED at 
{{org.apache.hadoop.hbase.master.snapshot.SnapshotHFileCleaner.getDeletableFiles(SnapshotHFileCleaner.java:68)}}

This method {{return cache.getUnreferencedFiles(files, 
master.getSnapshotManager());}} is synchronized. Inside the method, there is 
one more write {{Lock}}.


> The ForkJoinPool in CleanerChore will spawn thousands of threads in our 
> cluster with thousands table
> 
>
> Key: HBASE-22867
> URL: https://issues.apache.org/jira/browse/HBASE-22867
> Project: HBase
>  Issue Type: Bug
>Reporter: Zheng Hu
>Priority: Critical
> Attachments: 31162.stack.1
>
>
> The thousands of spawned  threads make the safepoint cost 80+s in our Master 
> JVM processs.
> {code}
> 2019-08-15,19:35:35,861 INFO [main-SendThread(zjy-hadoop-prc-zk02.bj:11000)] 
> org.apache.zookeeper.ClientCnxn: Client session timed out, have not heard 
> from server in 82260ms for sessionid 0x1691332e2d3aae5, closing socket 
> connection and at
> tempting reconnect
> {code}
> The stdout from JVM (can see from here there're 9126 threads & sync cost 80+s)
> {code}
> vmop[threads: total initially_running wait_to_block]
> [time: spin block sync cleanup vmop] page_trap_count
> 32358.859: ForceAsyncSafepoint  [9126 67
> 474]  [ 128 8659687   101]  0
> {code}
> Also we got the jstack: 
> {code}
> $ cat 31162.stack.1  | grep 'ForkJoinPool-1-worker' | wc -l
> 8648
> {code}
> It's a dangerous bug, make it as blocker.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop

Apache-HBase commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-522039645
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 36 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | 0 | shelldocs | 1 | Shelldocs was not available. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 1 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 22 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 32 | Maven dependency ordering for branch |
   | +1 | mvninstall | 344 | master passed |
   | +1 | compile | 197 | master passed |
   | +1 | checkstyle | 180 | master passed |
   | +1 | shadedjars | 295 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 193 | master passed |
   | 0 | spotbugs | 30 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | 0 | findbugs | 30 | branch/hbase-assembly no findbugs output file 
(findbugsXml.xml) |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | +1 | mvninstall | 329 | the patch passed |
   | +1 | compile | 201 | the patch passed |
   | +1 | javac | 201 | the patch passed |
   | +1 | checkstyle | 170 | the patch passed |
   | +1 | shellcheck | 1 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | xml | 4 | The patch has no ill-formed XML file. |
   | +1 | shadedjars | 302 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1086 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 280 | the patch passed |
   | 0 | findbugs | 68 | hbase-assembly has no data from findbugs |
   ||| _ Other Tests _ |
   | -1 | unit | 10812 | root in the patch failed. |
   | +1 | asflicense | 81 | The patch does not generate ASF License warnings. |
   | | | 17698 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.master.balancer.TestStochasticLoadBalancerRegionReplicaSameHosts |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/20/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/476 |
   | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc 
unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle |
   | uname | Linux 92949dc72e0d 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 
18:22:20 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-476/out/precommit/personality/provided.sh
 |
   | git revision | master / 3eb602c7f7 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/20/artifact/out/patch-unit-root.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/20/testReport/
 |
   | Max. process+thread count | 4579 (vs. ulimit of 1) |
   | modules | C: hbase-hbtop . hbase-assembly U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/20/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 
findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (HBASE-22858) Add HBCK Report to master's header.jsp



[ 
https://issues.apache.org/jira/browse/HBASE-22858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909099#comment-16909099
 ] 

Hudson commented on HBASE-22858:


Results for branch master
[build #1338 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1338/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1338//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1338//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1338//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Add HBCK Report to master's header.jsp
> --
>
> Key: HBASE-22858
> URL: https://issues.apache.org/jira/browse/HBASE-22858
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose



[ 
https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909079#comment-16909079
 ] 

Hudson commented on HBASE-21879:


Results for branch HBASE-21879
[build #210 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/210/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/210//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/210//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/210//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Read HFile's block to ByteBuffer directly instead of to byte for reducing 
> young gc purpose
> --
>
> Key: HBASE-21879
> URL: https://issues.apache.org/jira/browse/HBASE-21879
> Project: HBase
>  Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-21879.v1.patch, HBASE-21879.v1.patch, 
> QPS-latencies-before-HBASE-21879.png, gc-data-before-HBASE-21879.png
>
>
> In HFileBlock#readBlockDataInternal,  we have the following: 
> {code}
> @VisibleForTesting
> protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset,
> long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum, 
> boolean updateMetrics)
>  throws IOException {
>  // .
>   // TODO: Make this ByteBuffer-based. Will make it easier to go to HDFS with 
> BBPool (offheap).
>   byte [] onDiskBlock = new byte[onDiskSizeWithHeader + hdrSize];
>   int nextBlockOnDiskSize = readAtOffset(is, onDiskBlock, preReadHeaderSize,
>   onDiskSizeWithHeader - preReadHeaderSize, true, offset + 
> preReadHeaderSize, pread);
>   if (headerBuf != null) {
> // ...
>   }
>   // ...
>  }
> {code}
> In the read path,  we still read the block from hfile to on-heap byte[], then 
> copy the on-heap byte[] to offheap bucket cache asynchronously,  and in my  
> 100% get performance test, I also observed some frequent young gc,  The 
> largest memory footprint in the young gen should be the on-heap block byte[].
> In fact, we can read HFile's block to ByteBuffer directly instead of to 
> byte[] for reducing young gc purpose. we did not implement this before, 
> because no ByteBuffer reading interface in the older HDFS client, but 2.7+ 
> has supported this now,  so we can fix this now. I think. 
> Will provide an patch and some perf-comparison for this. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22867) The ForkJoinPool in CleanerChore will spawn thousands of threads in our cluster with thousands table

2019-08-16 Thread Duo Zhang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909059#comment-16909059
 ] 

Duo Zhang commented on HBASE-22867:
---

OK, both in fork and submit, we will try to create new workers if too few 
workers are active. The code are very 'Doug Lea' so not easy to fully 
understand but at least the comments tell this...

So I do not think we should use ForkJoinPool here then. This is not an in 
memory computation, some tasks may be pending for a long time, and introduce 
lots of threads...

> The ForkJoinPool in CleanerChore will spawn thousands of threads in our 
> cluster with thousands table
> 
>
> Key: HBASE-22867
> URL: https://issues.apache.org/jira/browse/HBASE-22867
> Project: HBase
>  Issue Type: Bug
>Reporter: Zheng Hu
>Priority: Critical
> Attachments: 31162.stack.1
>
>
> The thousands of spawned  threads make the safepoint cost 80+s in our Master 
> JVM processs.
> {code}
> 2019-08-15,19:35:35,861 INFO [main-SendThread(zjy-hadoop-prc-zk02.bj:11000)] 
> org.apache.zookeeper.ClientCnxn: Client session timed out, have not heard 
> from server in 82260ms for sessionid 0x1691332e2d3aae5, closing socket 
> connection and at
> tempting reconnect
> {code}
> The stdout from JVM (can see from here there're 9126 threads & sync cost 80+s)
> {code}
> vmop[threads: total initially_running wait_to_block]
> [time: spin block sync cleanup vmop] page_trap_count
> 32358.859: ForceAsyncSafepoint  [9126 67
> 474]  [ 128 8659687   101]  0
> {code}
> Also we got the jstack: 
> {code}
> $ cat 31162.stack.1  | grep 'ForkJoinPool-1-worker' | wc -l
> 8648
> {code}
> It's a dangerous bug, make it as blocker.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.

2019-08-16 Thread Hadoop QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909056#comment-16909056
 ] 

Hadoop QA commented on HBASE-22601:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
40s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
17s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
51s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
15s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
58s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
33s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  3m 
16s{color} | {color:blue} Used deprecated FindBugs config; considering 
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
15s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 6s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
14m 37s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
23s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}138m 53s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
23s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}190m 21s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.replication.TestReplicationProcedureRetry |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/7/artifact/out/Dockerfile
 |
| GITHUB PR | https://github.com/apache/hbase/pull/500 |
| JIRA Issue | HBASE-22601 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 00327df2c799 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-500/out/precommit/personality/provided.sh
 |
| git revision

[GitHub] [hbase] Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.