[GitHub] [hbase] mohapatrasambit opened a new pull request #1674: HBASE-23832 Old config hbase.hstore.compactionThreshold is ignored
mohapatrasambit opened a new pull request #1674: URL: https://github.com/apache/hbase/pull/1674 Updated default value hbase.hstore.compaction.min to null With this change if user uses old key "hbase.hstore.compactionThreshold", then it will take effect. If user doesn't define any then default value of null, will result in 3 for minFilesToComapct, which is expected. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1672: Backport HBASE-24328 skip duplicate GCMultipleMergedRegionsProcedure while previous finished
Apache-HBase commented on pull request #1672: URL: https://github.com/apache/hbase/pull/1672#issuecomment-625042244 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 52s | branch-2 passed | | +1 :green_heart: | compile | 0m 55s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 30s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 24s | the patch passed | | +1 :green_heart: | compile | 0m 55s | the patch passed | | +1 :green_heart: | javac | 0m 55s | the patch passed | | +1 :green_heart: | shadedjars | 4m 35s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 149m 26s | hbase-server in the patch failed. | | | | 171m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1672/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1672 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 25508be0a9c1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / fca0f3f810 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1672/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1672/1/testReport/ | | Max. process+thread count | 3570 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1672/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1672: Backport HBASE-24328 skip duplicate GCMultipleMergedRegionsProcedure while previous finished
Apache-HBase commented on pull request #1672: URL: https://github.com/apache/hbase/pull/1672#issuecomment-625040641 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 32s | branch-2 passed | | +1 :green_heart: | compile | 1m 5s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 25s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in branch-2 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 2s | the patch passed | | +1 :green_heart: | compile | 1m 5s | the patch passed | | +1 :green_heart: | javac | 1m 5s | the patch passed | | +1 :green_heart: | shadedjars | 6m 8s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 51s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 139m 26s | hbase-server in the patch passed. | | | | 166m 15s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1672/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1672 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9419948f341a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / fca0f3f810 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1672/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1672/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1672/1/testReport/ | | Max. process+thread count | 4209 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1672/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1664: HBASE-24333 Backport HBASE-24304 "Separate a hbase-asyncfs module" to…
Apache-HBase commented on pull request #1664: URL: https://github.com/apache/hbase/pull/1664#issuecomment-625035381 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 29s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 19s | branch-2 passed | | +1 :green_heart: | spotbugs | 13m 35s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 11s | the patch passed | | -0 :warning: | checkstyle | 2m 15s | root: The patch generated 2 new + 571 unchanged - 5 fixed = 573 total (was 576) | | -0 :warning: | whitespace | 0m 0s | The patch 1 line(s) with tabs. | | +1 :green_heart: | xml | 0m 21s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 11m 36s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 15m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 2m 19s | The patch does not generate ASF License warnings. | | | | 65m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1664 | | Optional Tests | dupname asflicense xml hadoopcheck spotbugs hbaseanti checkstyle | | uname | Linux 41c2bbf10b57 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / fca0f3f810 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/4/artifact/yetus-general-check/output/whitespace-tabs.txt | | Max. process+thread count | 137 (vs. ulimit of 12500) | | modules | C: hbase-asyncfs . hbase-assembly hbase-endpoint hbase-examples hbase-mapreduce hbase-rest hbase-server hbase-shaded/hbase-shaded-testing-util hbase-testing-util hbase-thrift U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] mwkang opened a new pull request #1673: HBASE-24339 Backport HBASE-23968 to branch-1
mwkang opened a new pull request #1673: URL: https://github.com/apache/hbase/pull/1673 - https://issues.apache.org/jira/browse/HBASE-24339 - https://github.com/apache/hbase/pull/1274 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1634: HBASE-24310 Use Slf4jRequestLog for hbase-http
Apache-HBase commented on pull request #1634: URL: https://github.com/apache/hbase/pull/1634#issuecomment-625027675 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 55s | master passed | | +1 :green_heart: | checkstyle | 2m 15s | master passed | | +1 :green_heart: | spotbugs | 10m 9s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 43s | the patch passed | | +1 :green_heart: | checkstyle | 2m 17s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 12m 22s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 10m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. | | | | 55m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1634/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1634 | | Optional Tests | dupname asflicense hadoopcheck xml spotbugs hbaseanti checkstyle | | uname | Linux 50f2b214c8f2 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f4a446c3d2 | | Max. process+thread count | 122 (vs. ulimit of 12500) | | modules | C: hbase-http . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1634/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24310) Use Slf4jRequestLog for hbase-http
[ https://issues.apache.org/jira/browse/HBASE-24310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101357#comment-17101357 ] Duo Zhang commented on HBASE-24310: --- Let me try to disable it by default through log4j.properties so the default behavior will be kept. And I think we'd better add a section in our ref guide to mention how to config the request logger, maybe after we switch to log4j2. > Use Slf4jRequestLog for hbase-http > -- > > Key: HBASE-24310 > URL: https://issues.apache.org/jira/browse/HBASE-24310 > Project: HBase > Issue Type: Sub-task > Components: logging >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > To remove the direct dependency on log4j in hbase-http server. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1664: HBASE-24333 Backport HBASE-24304 "Separate a hbase-asyncfs module" to…
Apache-HBase commented on pull request #1664: URL: https://github.com/apache/hbase/pull/1664#issuecomment-625014040 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m 4s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 51s | branch-2 passed | | +1 :green_heart: | compile | 2m 20s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 51s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 50s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 31s | the patch passed | | +1 :green_heart: | compile | 2m 21s | the patch passed | | +1 :green_heart: | javac | 2m 21s | the patch passed | | +1 :green_heart: | shadedjars | 5m 4s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 2m 17s | root generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16) | | -0 :warning: | javadoc | 0m 35s | hbase-server generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 353m 49s | root in the patch passed. | | | | 396m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1664 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 621ee8751aed 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 04ac08d49b | | Default Java | 1.8.0_232 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/3/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/3/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/3/testReport/ | | Max. process+thread count | 3138 (vs. ulimit of 12500) | | modules | C: hbase-asyncfs . hbase-assembly hbase-endpoint hbase-examples hbase-mapreduce hbase-rest hbase-server hbase-shaded/hbase-shaded-testing-util hbase-testing-util hbase-thrift U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] arshadmohammad commented on pull request #1321: HBASE-24025: Improve performance of move_servers_rsgroup and move_tables_rsgroup by using async region move API
arshadmohammad commented on pull request #1321: URL: https://github.com/apache/hbase/pull/1321#issuecomment-625013628 Create PR for master, @Apache9 can you please review it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1672: Backport HBASE-24328 skip duplicate GCMultipleMergedRegionsProcedure while previous finished
Apache-HBase commented on pull request #1672: URL: https://github.com/apache/hbase/pull/1672#issuecomment-625008967 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 24s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 59s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 16s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 4s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 28s | the patch passed | | +1 :green_heart: | checkstyle | 1m 11s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 40s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 17s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 36m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1672/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1672 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 4529e44e72f6 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / fca0f3f810 | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1672/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1668: HBASE-24335 Support deleteall with ts but without column in shell mode
Apache-HBase commented on pull request #1668: URL: https://github.com/apache/hbase/pull/1668#issuecomment-625007130 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 28s | master passed | | +1 :green_heart: | javadoc | 0m 12s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 31s | the patch passed | | +1 :green_heart: | javadoc | 0m 12s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 7m 59s | hbase-shell in the patch passed. | | | | 19m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1668 | | Optional Tests | javac javadoc unit | | uname | Linux 60cc363c6291 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f4a446c3d2 | | Default Java | 2020-01-14 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/3/testReport/ | | Max. process+thread count | 1549 (vs. ulimit of 12500) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1668: HBASE-24335 Support deleteall with ts but without column in shell mode
Apache-HBase commented on pull request #1668: URL: https://github.com/apache/hbase/pull/1668#issuecomment-625006335 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 52s | master passed | | +1 :green_heart: | javadoc | 0m 11s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 45s | the patch passed | | +1 :green_heart: | javadoc | 0m 11s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 6m 55s | hbase-shell in the patch passed. | | | | 16m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1668 | | Optional Tests | javac javadoc unit | | uname | Linux 5f4ef248f2de 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f4a446c3d2 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/3/testReport/ | | Max. process+thread count | 1556 (vs. ulimit of 12500) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24331) [Flakey Test] TestJMXListener rmi port clash
[
https://issues.apache.org/jira/browse/HBASE-24331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101338#comment-17101338
]
Hudson commented on HBASE-24331:
Results for branch branch-2
[build #2647 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2647/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2647/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2647/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2647/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2647/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Test] TestJMXListener rmi port clash
>
>
> Key: HBASE-24331
> URL: https://issues.apache.org/jira/browse/HBASE-24331
> Project: HBase
> Issue Type: Sub-task
> Components: flakies, test
>Reporter: Michael Stack
>Priority: Major
>
> The TestJMXListener can fail because the random port it wants to put the jmx
> listener on is occupied when it goes to run. Handle this case in test startup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles
[
https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101339#comment-17101339
]
Hudson commented on HBASE-24273:
Results for branch branch-2
[build #2647 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2647/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2647/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2647/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2647/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2647/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles
>
>
> Key: HBASE-24273
> URL: https://issues.apache.org/jira/browse/HBASE-24273
> Project: HBase
> Issue Type: Bug
> Components: hbck2
>Affects Versions: 2.2.4
> Environment: HBase 2.2.4
> Hadoop 3.1.3
>Reporter: Andrey Elenskiy
>Assignee: Huaxiang Sun
>Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.4.0
>
>
> This issue came up after merging regions. MergeTableRegionsProcedure removes
> the parent regions from hbase:meta and creates HFile references in child
> region to the old parent regions. Running `hbck_chore_run` right after the
> `merge_region` will show the parent regions in "Orphan Regions on FileSystem"
> until major compaction is run on child region which will remove HFile
> references and cause Catalog Janitor to clean up the parent regions.
> There are probably other situations which can cause the same issue (maybe
> region split?)
> Having "Orphan Regions on FileSystem" list parent regions and suggest to
> "_hbase completebulkload_" is dangerous in this case as completing bulk load
> will lead to stale HFile references in child region which will cause its OPEN
> to fail because referenced HFile doesn't exist.
> Figuring out these things for database administrators is tedious, so I think
> it would be reasonable to not consider regions with referenced HFiles to be
> orphans (or maybe could give an extra hint saying that it has referenced
> HFiles).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23968) Periodically check whether a system stop is requested in compaction by time.
[ https://issues.apache.org/jira/browse/HBASE-23968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101336#comment-17101336 ] Anoop Sam John commented on HBASE-23968: Noticed this issue and PRs now only. So we have added time based check (at 10 secs interval by default) along with existing size based check (10 MB by default). The CloseChecker will get called from the compaction threads right? In compaction by default there is Pressure Aware Throughput Controller. This can cause the compaction thread to go into sleep state. (I did not go in detail to see the math there. How long we might sleep). But the point is this sleep can cause the check to get delayed (?). When the RS stop is been requested stopping these threads as early is important. Should we think other possibilities for that also? Like making these threads Daemon? (Not really suggesting but should we think about more options) [~stack] > Periodically check whether a system stop is requested in compaction by time. > > > Key: HBASE-23968 > URL: https://issues.apache.org/jira/browse/HBASE-23968 > Project: HBase > Issue Type: Improvement > Components: Compaction >Reporter: Minwoo Kang >Assignee: Minwoo Kang >Priority: Minor > Fix For: 3.0.0-alpha-1 > > > The compaction check that the system is stopped when it reaches > hbase.hstore.close.check.interval size. > If the size is not reached, the compaction does not stop even though the > system is stopped. > If compaction is not terminated, the region is not closed. > As a result, region remains pending-close. > > Thread A (regionserver/longCompactions): > State: RUNNABLE > Stack: > org.apache.hadoop.hbase.regionserver.compactions.Compactor.performCompaction(Compactor.java:319) > org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:111) > org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:119) > org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1232) > org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:1896) > org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.doCompaction(CompactSplitThread.java:525) > org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.run(CompactSplitThread.java:562) > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > java.lang.Thread.run(Thread.java:748) > Thread B (RS_CLOSE_REGION): > State: WAITING > Waiting on org.apache.hadoop.hbase.regionserver.HRegion$WriteState > Stack: > java.lang.Object.wait(Native Method) > java.lang.Object.wait(Object.java:502) > org.apache.hadoop.hbase.regionserver.HRegion.waitForFlushesAndCompactions(HRegion.java:1567) > org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1417) > org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1380) > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:138) > org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:129) > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > java.lang.Thread.run(Thread.java:748) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1668: HBASE-24335 Support deleteall with ts but without column in shell mode
Apache-HBase commented on pull request #1668: URL: https://github.com/apache/hbase/pull/1668#issuecomment-625002883 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | | -0 :warning: | rubocop | 0m 14s | The patch generated 14 new + 318 unchanged - 3 fixed = 332 total (was 321) | | +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 2m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1668 | | Optional Tests | dupname asflicense rubocop | | uname | Linux 5d3880ac7ec3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f4a446c3d2 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt | | Max. process+thread count | 47 (vs. ulimit of 12500) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) rubocop=0.80.0 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] nyl3532016 commented on pull request #1672: Backport HBASE-24328 skip duplicate GCMultipleMergedRegionsProcedure while previous finished
nyl3532016 commented on pull request #1672: URL: https://github.com/apache/hbase/pull/1672#issuecomment-624998436 @huaxiangsun would you mind merging to branch-2 and branch-2.3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] nyl3532016 opened a new pull request #1672: Backport HBASE-24328 skip duplicate GCMultipleMergedRegionsProcedure while previous finished
nyl3532016 opened a new pull request #1672: URL: https://github.com/apache/hbase/pull/1672 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #1669: HBASE-24338 [Flakey Tests] NPE in TestRaceBetweenSCPAndDTP
Apache9 commented on a change in pull request #1669: URL: https://github.com/apache/hbase/pull/1669#discussion_r421206273 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRaceBetweenSCPAndDTP.java ## @@ -21,11 +21,7 @@ import java.util.Optional; import java.util.concurrent.CountDownLatch; import org.apache.hadoop.conf.Configuration; -import org.apache.hadoop.hbase.HBaseClassTestRule; -import org.apache.hadoop.hbase.HBaseTestingUtility; -import org.apache.hadoop.hbase.HConstants; -import org.apache.hadoop.hbase.ServerName; -import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.*; Review comment: Avoid start imports? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ystaticy commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController
ystaticy commented on a change in pull request #1588:
URL: https://github.com/apache/hbase/pull/1588#discussion_r421202699
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/OffPeakHours.java
##
@@ -87,6 +87,7 @@ private static boolean isValidHour(int hour) {
OffPeakHoursImpl(int startHour, int endHour) {
this.startHour = startHour;
this.endHour = endHour;
+ LOG.info(this.toString());
Review comment:
> The log is not good, do not have info about the region.
delete this log is better?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1668: HBASE-24335 Support deleteall with ts but without column in shell mode
Apache-HBase commented on pull request #1668: URL: https://github.com/apache/hbase/pull/1668#issuecomment-624985979 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 38s | master passed | | +1 :green_heart: | javadoc | 0m 15s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 31s | the patch passed | | +1 :green_heart: | javadoc | 0m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 7m 53s | hbase-shell in the patch passed. | | | | 19m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1668 | | Optional Tests | javac javadoc unit | | uname | Linux 9d713fe12622 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f4a446c3d2 | | Default Java | 2020-01-14 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/2/testReport/ | | Max. process+thread count | 1599 (vs. ulimit of 12500) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1668: HBASE-24335 Support deleteall with ts but without column in shell mode
Apache-HBase commented on pull request #1668: URL: https://github.com/apache/hbase/pull/1668#issuecomment-624985032 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 45s | master passed | | +1 :green_heart: | javadoc | 0m 16s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 24s | the patch passed | | +1 :green_heart: | javadoc | 0m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 6m 57s | hbase-shell in the patch passed. | | | | 15m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1668 | | Optional Tests | javac javadoc unit | | uname | Linux 2deb3e137367 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f4a446c3d2 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/2/testReport/ | | Max. process+thread count | 2403 (vs. ulimit of 12500) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1668: HBASE-24335 Support deleteall with ts but without column in shell mode
Apache-HBase commented on pull request #1668: URL: https://github.com/apache/hbase/pull/1668#issuecomment-624981495 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | | -0 :warning: | rubocop | 0m 13s | The patch generated 14 new + 318 unchanged - 3 fixed = 332 total (was 321) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 2m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1668 | | Optional Tests | dupname asflicense rubocop | | uname | Linux f25dc5a1fad8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f4a446c3d2 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt | | Max. process+thread count | 51 (vs. ulimit of 12500) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1668/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) rubocop=0.80.0 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #1668: HBASE-24335 Support deleteall with ts but without column in shell mode
bsglz commented on a change in pull request #1668: URL: https://github.com/apache/hbase/pull/1668#discussion_r421190599 ## File path: hbase-shell/src/main/ruby/shell/commands/deleteall.rb ## @@ -30,12 +30,14 @@ def help hbase> deleteall 't1', 'r1' hbase> deleteall 't1', 'r1', 'c1' hbase> deleteall 't1', 'r1', 'c1', ts1 + hbase> deleteall 't1', 'r1', '', ts1//'' means not specify column Review comment: fix, thanks for your review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles
[ https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-24273: - Fix Version/s: 2.4.0 > HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles > > > Key: HBASE-24273 > URL: https://issues.apache.org/jira/browse/HBASE-24273 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 2.2.4 > Environment: HBase 2.2.4 > Hadoop 3.1.3 >Reporter: Andrey Elenskiy >Assignee: Huaxiang Sun >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.3.0, 2.4.0 > > > This issue came up after merging regions. MergeTableRegionsProcedure removes > the parent regions from hbase:meta and creates HFile references in child > region to the old parent regions. Running `hbck_chore_run` right after the > `merge_region` will show the parent regions in "Orphan Regions on FileSystem" > until major compaction is run on child region which will remove HFile > references and cause Catalog Janitor to clean up the parent regions. > There are probably other situations which can cause the same issue (maybe > region split?) > Having "Orphan Regions on FileSystem" list parent regions and suggest to > "_hbase completebulkload_" is dangerous in this case as completing bulk load > will lead to stale HFile references in child region which will cause its OPEN > to fail because referenced HFile doesn't exist. > Figuring out these things for database administrators is tedious, so I think > it would be reasonable to not consider regions with referenced HFiles to be > orphans (or maybe could give an extra hint saying that it has referenced > HFiles). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-24114) [Flakey Tests] TestSnapshotScannerHDFSAclController
[
https://issues.apache.org/jira/browse/HBASE-24114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Huaxiang Sun reassigned HBASE-24114:
Assignee: Huaxiang Sun (was: Hua Xiang)
> [Flakey Tests] TestSnapshotScannerHDFSAclController
> ---
>
> Key: HBASE-24114
> URL: https://issues.apache.org/jira/browse/HBASE-24114
> Project: HBase
> Issue Type: Test
> Components: acl
>Affects Versions: 2.3.0, master, 2.4.0
>Reporter: Huaxiang Sun
>Assignee: Huaxiang Sun
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> Still see the following error from the test.
> {code:java}
> ---
> Test set:
> org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
> ---
> Tests run: 23, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 342.32 s <<<
> FAILURE! - in
> org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
> org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController.testGrantTable
> Time elapsed: 6.82 s <<< FAILURE!
> java.lang.AssertionError: expected:<6> but was:<-1>
> at
> org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController.testGrantTable(TestSnapshotScannerHDFSAclController.java:349)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-24073) [flakey test] client.TestAsyncRegionAdminApi messed up compaction state.
[
https://issues.apache.org/jira/browse/HBASE-24073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Huaxiang Sun reassigned HBASE-24073:
Assignee: Huaxiang Sun (was: Hua Xiang)
> [flakey test] client.TestAsyncRegionAdminApi messed up compaction state.
>
>
> Key: HBASE-24073
> URL: https://issues.apache.org/jira/browse/HBASE-24073
> Project: HBase
> Issue Type: Test
> Components: Compaction
>Affects Versions: 3.0.0-alpha-1, 2.3.0, 2.4.0
> Environment:
>Reporter: Huaxiang Sun
>Assignee: Huaxiang Sun
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> {code:java}
> ---
> Test set: org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi
> ---
> Tests run: 20, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 268.838 s
> <<< FAILURE! - in org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi
> org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.testCompact[0] Time
> elapsed: 50.471 s <<< FAILURE!
> java.lang.AssertionError: expected: but was:
> at
> org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.compactionTest(TestAsyncRegionAdminApi.java:415)
> at
> org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.testCompact(TestAsyncRegionAdminApi.java:364)
> Another case found during local test:
> ---
> Test set: org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi
> ---
> Tests run: 20, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 224.399 s
> <<< FAILURE! - in org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi
> org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.testCompact[1] Time
> elapsed: 30.861 s <<< FAILURE!
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:87)
> at org.junit.Assert.assertTrue(Assert.java:42)
> at org.junit.Assert.assertTrue(Assert.java:53)
> at
> org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.compactionTest(TestAsyncRegionAdminApi.java:444)
> at
> org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.testCompact(TestAsyncRegionAdminApi.java:363)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:27)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
>
[jira] [Assigned] (HBASE-24080) [flakey test] TestRegionReplicaFailover.testSecondaryRegionKill fails.
[
https://issues.apache.org/jira/browse/HBASE-24080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Huaxiang Sun reassigned HBASE-24080:
Assignee: Huaxiang Sun (was: Hua Xiang)
> [flakey test] TestRegionReplicaFailover.testSecondaryRegionKill fails.
> --
>
> Key: HBASE-24080
> URL: https://issues.apache.org/jira/browse/HBASE-24080
> Project: HBase
> Issue Type: Test
> Components: read replicas
>Affects Versions: 3.0.0-alpha-1, 2.3.0
>Reporter: Huaxiang Sun
>Assignee: Huaxiang Sun
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> Run into the following error locally:
> {code:java}
> ---
> Test set: org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover
> ---
> Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 97.391 s <<<
> FAILURE! - in org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover
> org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover.testSecondaryRegionKill
> Time elapsed: 28.682 s <<< FAILURE!
> java.lang.AssertionError: Failed verification of row :0
> at org.junit.Assert.fail(Assert.java:89)
> at org.junit.Assert.assertTrue(Assert.java:42)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.verifyNumericRows(HBaseTestingUtility.java:2407)
> at
> org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover.testSecondaryRegionKill(TestRegionReplicaFailover.java:240)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
> at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.lang.Thread.run(Thread.java:748) {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-24120) Flakey Test: TestReplicationAdminWithClusters timeout
[
https://issues.apache.org/jira/browse/HBASE-24120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Huaxiang Sun reassigned HBASE-24120:
Assignee: Huaxiang Sun (was: Hua Xiang)
> Flakey Test: TestReplicationAdminWithClusters timeout
> --
>
> Key: HBASE-24120
> URL: https://issues.apache.org/jira/browse/HBASE-24120
> Project: HBase
> Issue Type: Test
> Components: Replication
>Affects Versions: 2.3.0, master, 2.4.0
>Reporter: Huaxiang Sun
>Assignee: Huaxiang Sun
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> {code:java}
> 2020-04-05 23:36:53,092 ERROR
> [RS_REFRESH_PEER-regionserver/asf905:0-0.replicationSource,2.replicationSource.shipperasf905.gq1.ygridcore.net%2C42849%2C1586129728118,2]
> regionserver.ReplicationSource(397): Unexpected exception in
> RS_REFRESH_PEER-regionserver/asf905:0-0.replicationSource,2.replicationSource.shipperasf905.gq1.ygridcore.net%2C42849%2C1586129728118,2
>
> currentPath=hdfs://localhost:34203/user/jenkins/test-data/03854f9d-2780-eeaa-9645-c341240b62bf/WALs/asf905.gq1.ygridcore.net,42849,1586129728118/asf905.gq1.ygridcore.net%2C42849%2C1586129728118.1586129730509
> java.lang.RuntimeException: Thread is interrupted, the replication source may
> be terminated
> at
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.interruptOrAbortWhenFail(ReplicationSourceManager.java:477)
> at
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.logPositionAndCleanOldLogs(ReplicationSourceManager.java:519)
> at
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceShipper.updateLogPosition(ReplicationSourceShipper.java:264)
> at
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceShipper.shipEdits(ReplicationSourceShipper.java:160)
> at
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceShipper.run(ReplicationSourceShipper.java:118)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-24159) [flakey test] regionserver.TestRegionMergeTransactionOnCluster
[ https://issues.apache.org/jira/browse/HBASE-24159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun reassigned HBASE-24159: Assignee: Huaxiang Sun (was: Hua Xiang) > [flakey test] regionserver.TestRegionMergeTransactionOnCluster > -- > > Key: HBASE-24159 > URL: https://issues.apache.org/jira/browse/HBASE-24159 > Project: HBase > Issue Type: Test > Components: regionserver >Affects Versions: 3.0.0-alpha-1, 2.3.0, 2.4.0 >Reporter: Huaxiang Sun >Assignee: Huaxiang Sun >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0, 2.4.0 > > > As reported in > [https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-2.3/lastSuccessfulBuild/artifact/dashboard.html#job_1,] > > testCleanMergeReference fails when waiting for merge table in meta table to > be cleaned. > Debugged a bit, found that this is case that state is polluted from other > testing cases. > > the meta table is polluted from the previous region merge test cases (tables > are not deleted after the testing case finishes). While compaction still goes > on and janitor kicks in, it will clean up the old table state and breaks the > loop (cleaned > 0), so leave the state under test never cleaned up.The > solution is to delete tables after each test case. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-23853) [Flakey Test] TestBlockEvictionFromClient#testBlockRefCountAfterSplits
[ https://issues.apache.org/jira/browse/HBASE-23853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun reassigned HBASE-23853: Assignee: Huaxiang Sun > [Flakey Test] TestBlockEvictionFromClient#testBlockRefCountAfterSplits > -- > > Key: HBASE-23853 > URL: https://issues.apache.org/jira/browse/HBASE-23853 > Project: HBase > Issue Type: Test > Components: flakies >Affects Versions: 2.3.0, master, 2.4.0 >Reporter: Michael Stack >Assignee: Huaxiang Sun >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0 > > Attachments: > 0001-HBASE-23853-Flakey-Test-TestBlockEvictionFromClient-.patch, Screen Shot > 2020-02-15 at 2.36.47 PM.png > > > Fails 12-25% of the time in the GCE build. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-23928) Add hbck2 command to "completebulkload" a batch of orphaned regions
[
https://issues.apache.org/jira/browse/HBASE-23928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Huaxiang Sun reassigned HBASE-23928:
Assignee: Huaxiang Sun (was: Hua Xiang)
> Add hbck2 command to "completebulkload" a batch of orphaned regions
> ---
>
> Key: HBASE-23928
> URL: https://issues.apache.org/jira/browse/HBASE-23928
> Project: HBase
> Issue Type: Improvement
> Components: hbck2, Operability, Usability
>Reporter: Nick Dimiduk
>Assignee: Huaxiang Sun
>Priority: Major
>
> Cleaning up a cluster with a bunch of messed up region assignments and state,
> hbck2 gets us to the point where meta and hdfs agree on split points, but
> some regions are left orphaned in hdfs. The current solution is to manually
> loop through the list of orphans and invoke {{completebulkload}} one-by-one.
> Let's add this as an action that hbck2 and do on the operator's behalf.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-24256) When fixOverlap hits the max region limit, it is possible to include the same region in multiple merge request
[ https://issues.apache.org/jira/browse/HBASE-24256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun reassigned HBASE-24256: Assignee: Huaxiang Sun > When fixOverlap hits the max region limit, it is possible to include the same > region in multiple merge request > -- > > Key: HBASE-24256 > URL: https://issues.apache.org/jira/browse/HBASE-24256 > Project: HBase > Issue Type: Improvement > Components: hbck2 >Affects Versions: 3.0.0-alpha-1, 2.3.0, 2.4.0 >Reporter: Huaxiang Sun >Assignee: Huaxiang Sun >Priority: Major > > If the same region is included in multiple merge requests, the first merge > cleans up the region state, the second merge request will fail with error msg > "No state for region ". The algo needs to be improved to make sure the > same region is not included in multi merge requests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24316) GCMulitpleMergedRegionsProcedure is not idempotent
[ https://issues.apache.org/jira/browse/HBASE-24316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun resolved HBASE-24316. -- Fix Version/s: 2.4.0 2.3.0 3.0.0-alpha-1 Resolution: Fixed > GCMulitpleMergedRegionsProcedure is not idempotent > --- > > Key: HBASE-24316 > URL: https://issues.apache.org/jira/browse/HBASE-24316 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Affects Versions: 3.0.0-alpha-1, 2.3.0, 2.4.0 >Reporter: Huaxiang Sun >Assignee: Huaxiang Sun >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0, 2.4.0 > > > Currently deleteMergeQualifiers() is not idempotent. If two > GCMulitpleMergedRegionsProcedures are run for the same merged child region, > the second run will delete the row for the merge region from meta table and > leave a hole. It needs to make sure it only deletes columns with merge > qualifiers. > [https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java#L1849] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-24316) GCMulitpleMergedRegionsProcedure is not idempotent
[ https://issues.apache.org/jira/browse/HBASE-24316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun reassigned HBASE-24316: Assignee: Huaxiang Sun > GCMulitpleMergedRegionsProcedure is not idempotent > --- > > Key: HBASE-24316 > URL: https://issues.apache.org/jira/browse/HBASE-24316 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Affects Versions: 3.0.0-alpha-1, 2.3.0, 2.4.0 >Reporter: Huaxiang Sun >Assignee: Huaxiang Sun >Priority: Major > > Currently deleteMergeQualifiers() is not idempotent. If two > GCMulitpleMergedRegionsProcedures are run for the same merged child region, > the second run will delete the row for the merge region from meta table and > leave a hole. It needs to make sure it only deletes columns with merge > qualifiers. > [https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java#L1849] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] huaxiangsun commented on pull request #1671: Backport: HBASE-24316 GCMulitpleMergedRegionsProcedure is not idempotent (#1660)
huaxiangsun commented on pull request #1671: URL: https://github.com/apache/hbase/pull/1671#issuecomment-624936469 Test failure is caused by malformated xml file, going to merge. "Failed to read test report file /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1671/yetus-jdk11-hadoop3-check/src/hbase-server/target/surefire-reports/TEST-org.apache.hadoop.hbase.util.TestHBaseFsckCleanReplicationBarriers.xml org.dom4j.DocumentException: Error on line 104 of document : XML document structures must start and end within the same entity. Nested exception: XML document structures must start and end within the same entity.' This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1664: HBASE-24333 Backport HBASE-24304 "Separate a hbase-asyncfs module" to…
Apache-HBase commented on pull request #1664: URL: https://github.com/apache/hbase/pull/1664#issuecomment-624921965 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 30s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 18s | branch-2 passed | | +1 :green_heart: | spotbugs | 13m 34s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 12s | the patch passed | | -0 :warning: | checkstyle | 2m 17s | root: The patch generated 2 new + 571 unchanged - 5 fixed = 573 total (was 576) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 21s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 11m 41s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 15m 30s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 2m 18s | The patch does not generate ASF License warnings. | | | | 65m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1664 | | Optional Tests | dupname asflicense xml hadoopcheck spotbugs hbaseanti checkstyle | | uname | Linux 7925c16569c1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 04ac08d49b | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | Max. process+thread count | 137 (vs. ulimit of 12500) | | modules | C: hbase-asyncfs . hbase-assembly hbase-endpoint hbase-examples hbase-mapreduce hbase-rest hbase-server hbase-shaded/hbase-shaded-testing-util hbase-testing-util hbase-thrift U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24265) Remove hedged rpc call support, implement the logic in MaterRegistry directly
[
https://issues.apache.org/jira/browse/HBASE-24265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101228#comment-17101228
]
Hudson commented on HBASE-24265:
Results for branch branch-2
[build #2646 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2646/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2646/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2646/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2646/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2646/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove hedged rpc call support, implement the logic in MaterRegistry directly
> -
>
> Key: HBASE-24265
> URL: https://issues.apache.org/jira/browse/HBASE-24265
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24211) Create table is slow in large cluster when AccessController is enabled.
[
https://issues.apache.org/jira/browse/HBASE-24211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101229#comment-17101229
]
Hudson commented on HBASE-24211:
Results for branch branch-2
[build #2646 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2646/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2646/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2646/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2646/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2646/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Create table is slow in large cluster when AccessController is enabled.
> ---
>
> Key: HBASE-24211
> URL: https://issues.apache.org/jira/browse/HBASE-24211
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.6, master, 2.2.4
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0, 1.7.0
>
>
> *Problem:*
> In HBase 1.3.x large, performance test, cluster (100 RS, 60k tables, 600k
> regions) a simple table creation takes around 150 seconds. The time taken
> varies but still takes lot of time.
> *Analysis:*
> 1. When HBase creates a table , it calls AssignmentManager#assign(final
> ServerName destination, final List regions)
> In AssignmentManager#assign，it calls asyncSetOfflineInZooKeeper(state, cb,
> destination), and waits in below code loop for 2 minutes.
> {code:java}
> if (useZKForAssignment) {
> // Wait until all unassigned nodes have been put up and watchers
> set.
> int total = states.size();
> for (int oldCounter = 0; !server.isStopped();) {
> int count = counter.get();
> if (oldCounter != count) {
> LOG.debug(destination.toString() + " unassigned znodes=" +
> count +
> " of total=" + total + "; oldCounter=" + oldCounter);
> oldCounter = count;
> }
> if (count >= total) break;
> Thread.sleep(5);
> }
> }
> {code}
> 2. asyncSetOfflineInZooKeeper creates a znode under
> /hbase/region-in-transition/ and calls exist to ensure that znode is created.
> This is simple operation should not take much time. Then where the time it
> taken!!!
> 3. ZooKeeper client API process watcher notification and async API response
> through a queue one by one.
> If there is a delay in any watcher/response processing by the client, in
> this case HBase, all other response processing is delayed. Then it appears as
> if API call has taken more time.
> Same thing happen in this issue.
> Watcher processing for znode creation under /hbase/acl took most of the time
> and delayed /hbase/region-in-transition/region znode creation processing.
> This is why wait in loop was too long.
> 4. Watcher processing for znode creation under hbase/acl/ calls
> ZKPermissionWatcher#nodeChildrenChanged, which internally calls
> ZKUtil.getChildDataAndWatchForNewChildren
> *which calls ZooKeeper's getData API, in this use case, 60k times which
> takes most of the time.*
> *Solutions:*
> Move getChildDataAndWatchForNewChildren call into the async code block in
> ZKPermissionWatcher#nodeChildrenChanged.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23976) [flakey test] TestVerifyBucketCacheFile
[
https://issues.apache.org/jira/browse/HBASE-23976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101227#comment-17101227
]
Hudson commented on HBASE-23976:
Results for branch branch-2
[build #2646 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2646/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2646/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2646/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2646/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2646/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [flakey test] TestVerifyBucketCacheFile
> ---
>
> Key: HBASE-23976
> URL: https://issues.apache.org/jira/browse/HBASE-23976
> Project: HBase
> Issue Type: Test
> Components: regionserver, test
>Affects Versions: 3.0.0-alpha-1
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> I see sporadic failures in this test class. Sometimes a failure on
> {{assertTrue(file.delete())}}, an inconsistent annoyance. However, this one
> looks more sinister.
> {noformat}
> 2020-03-12 12:11:35,059 ERROR [Time-limited test] bucket.BucketCache(312):
> Can't restore from
> file[/Users/ndimiduk/repos/apache/hbase/hbase-server/target/test-data/5e5c5f5f-d5c2-94b2-8ce9-cf561f4f19f7/bucket.persistence]
> because of
> java.io.IOException: Mismatch of checksum! The persistent checksum is
> ���#20;B#16;k�#3;��2�Ӏk, but the calculate checksum is
> �o���r��w��c��4
> at
> org.apache.hadoop.hbase.io.hfile.bucket.PersistentIOEngine.verifyFileIntegrity(PersistentIOEngine.java:55)
> at
> org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.parsePB(BucketCache.java:1158)
> at
> org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.retrieveFromFile(BucketCache.java:1106)
> at
> org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.(BucketCache.java:310)
> at
> org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.(BucketCache.java:258)
> at
> org.apache.hadoop.hbase.io.hfile.bucket.TestVerifyBucketCacheFile.testRetrieveFromFile(TestVerifyBucketCacheFile.java:116)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24336) [Metrics] FSDataInputStream's localBytesRead is wrong
[
https://issues.apache.org/jira/browse/HBASE-24336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101230#comment-17101230
]
Hudson commented on HBASE-24336:
Results for branch branch-2
[build #2646 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2646/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2646/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2646/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2646/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2646/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Metrics] FSDataInputStream's localBytesRead is wrong
> -
>
> Key: HBASE-24336
> URL: https://issues.apache.org/jira/browse/HBASE-24336
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.0, 1.7.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24336) [Metrics] FSDataInputStream's localBytesRead is wrong
[
https://issues.apache.org/jira/browse/HBASE-24336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101218#comment-17101218
]
Hudson commented on HBASE-24336:
Results for branch branch-2.3
[build #69 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/69/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/69/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/69/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/69/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/69/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Metrics] FSDataInputStream's localBytesRead is wrong
> -
>
> Key: HBASE-24336
> URL: https://issues.apache.org/jira/browse/HBASE-24336
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.0, 1.7.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1671: Backport: HBASE-24316 GCMulitpleMergedRegionsProcedure is not idempotent (#1660)
Apache-HBase commented on pull request #1671: URL: https://github.com/apache/hbase/pull/1671#issuecomment-624894994 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 34s | branch-2 passed | | +1 :green_heart: | compile | 1m 40s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 44s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 29s | hbase-client in branch-2 failed. | | -0 :warning: | javadoc | 0m 39s | hbase-server in branch-2 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 21s | the patch passed | | +1 :green_heart: | compile | 1m 40s | the patch passed | | +1 :green_heart: | javac | 1m 40s | the patch passed | | +1 :green_heart: | shadedjars | 5m 46s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 27s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 36s | hbase-client in the patch passed. | | -1 :x: | unit | 186m 38s | hbase-server in the patch failed. | | | | 219m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1671/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1671 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0507add2b158 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 04ac08d49b | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1671/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1671/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1671/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1671/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1671/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1671/1/testReport/ | | Max. process+thread count | 2930 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1671/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1670: HBASE-24337 Backport HBASE-23968 to branch-2
Apache-HBase commented on pull request #1670: URL: https://github.com/apache/hbase/pull/1670#issuecomment-624887026 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 28s | branch-2 passed | | +1 :green_heart: | compile | 1m 5s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 23s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 42s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 52s | the patch passed | | +1 :green_heart: | compile | 1m 6s | the patch passed | | +1 :green_heart: | javac | 1m 6s | the patch passed | | +1 :green_heart: | shadedjars | 5m 24s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 210m 46s | hbase-server in the patch passed. | | | | 237m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1670/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1670 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4818e74ebc4a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 04ac08d49b | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1670/1/testReport/ | | Max. process+thread count | 2802 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1670/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles
[ https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101179#comment-17101179 ] Huaxiang Sun commented on HBASE-24273: -- Thanks [~busbey] a lot! It has been an issue for me for quite some time, :) I will backport it to branch-2.2. > HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles > > > Key: HBASE-24273 > URL: https://issues.apache.org/jira/browse/HBASE-24273 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 2.2.4 > Environment: HBase 2.2.4 > Hadoop 3.1.3 >Reporter: Andrey Elenskiy >Assignee: Huaxiang Sun >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.3.0 > > > This issue came up after merging regions. MergeTableRegionsProcedure removes > the parent regions from hbase:meta and creates HFile references in child > region to the old parent regions. Running `hbck_chore_run` right after the > `merge_region` will show the parent regions in "Orphan Regions on FileSystem" > until major compaction is run on child region which will remove HFile > references and cause Catalog Janitor to clean up the parent regions. > There are probably other situations which can cause the same issue (maybe > region split?) > Having "Orphan Regions on FileSystem" list parent regions and suggest to > "_hbase completebulkload_" is dangerous in this case as completing bulk load > will lead to stale HFile references in child region which will cause its OPEN > to fail because referenced HFile doesn't exist. > Figuring out these things for database administrators is tedious, so I think > it would be reasonable to not consider regions with referenced HFiles to be > orphans (or maybe could give an extra hint saying that it has referenced > HFiles). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1670: HBASE-24337 Backport HBASE-23968 to branch-2
Apache-HBase commented on pull request #1670: URL: https://github.com/apache/hbase/pull/1670#issuecomment-624881392 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 17s | Docker mode activated. | | -0 :warning: | yetus | 0m 8s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 10s | branch-2 passed | | +1 :green_heart: | compile | 1m 18s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 10s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 48s | hbase-server in branch-2 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 48s | the patch passed | | +1 :green_heart: | compile | 1m 19s | the patch passed | | +1 :green_heart: | javac | 1m 19s | the patch passed | | +1 :green_heart: | shadedjars | 5m 59s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 47s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 189m 36s | hbase-server in the patch passed. | | | | 220m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1670/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1670 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 79c3364499d1 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 04ac08d49b | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1670/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1670/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1670/1/testReport/ | | Max. process+thread count | 2789 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1670/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] lhofhansl commented on a change in pull request #1655: HBASE-24321 - Add writable MinVersions and read-only Scan to coproc S…
lhofhansl commented on a change in pull request #1655:
URL: https://github.com/apache/hbase/pull/1655#discussion_r421080372
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CustomizedScanInfoBuilder.java
##
@@ -80,4 +97,23 @@ public KeepDeletedCells getKeepDeletedCells() {
return keepDeletedCells != null ? keepDeletedCells :
scanInfo.getKeepDeletedCells();
}
+ @Override
+ public int getMinVersions() {
+return minVersions != null ? minVersions : scanInfo.getMinVersions();
+ }
+
+ @Override
+ public void setMinVersions(int minVersions) {
+this.minVersions = minVersions;
+ }
+
+ @Override
+ public Scan getScan() {
+try {
+ return new Scan(scan);
Review comment:
Might be good at some point to have an unmodifiable subclass or wrapper
of Scan, so that any modification would cause an error. (not in this PR, though)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1671: Backport: HBASE-24316 GCMulitpleMergedRegionsProcedure is not idempotent (#1660)
Apache-HBase commented on pull request #1671: URL: https://github.com/apache/hbase/pull/1671#issuecomment-624864560 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 36s | branch-2 passed | | +1 :green_heart: | compile | 1m 20s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 34s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 0s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 19s | the patch passed | | +1 :green_heart: | compile | 1m 20s | the patch passed | | +1 :green_heart: | javac | 1m 20s | the patch passed | | +1 :green_heart: | shadedjars | 4m 32s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 3s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 15s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 129m 28s | hbase-server in the patch passed. | | | | 156m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1671/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1671 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 31176f6830f1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 04ac08d49b | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1671/1/testReport/ | | Max. process+thread count | 4676 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1671/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1664: HBASE-24333 Backport HBASE-24304 "Separate a hbase-asyncfs module" to…
Apache-HBase commented on pull request #1664: URL: https://github.com/apache/hbase/pull/1664#issuecomment-624854240 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 46s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 52s | branch-2 passed | | +1 :green_heart: | compile | 3m 30s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 48s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 26s | root in branch-2 failed. | | -0 :warning: | javadoc | 0m 27s | hbase-examples in branch-2 failed. | | -0 :warning: | javadoc | 0m 26s | hbase-mapreduce in branch-2 failed. | | -0 :warning: | javadoc | 0m 29s | hbase-rest in branch-2 failed. | | -0 :warning: | javadoc | 0m 54s | hbase-server in branch-2 failed. | | -0 :warning: | javadoc | 1m 14s | hbase-thrift in branch-2 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 18s | the patch passed | | +1 :green_heart: | compile | 3m 37s | the patch passed | | +1 :green_heart: | javac | 3m 37s | the patch passed | | +1 :green_heart: | shadedjars | 7m 24s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 19s | hbase-asyncfs in the patch failed. | | -0 :warning: | javadoc | 0m 22s | root in the patch failed. | | -0 :warning: | javadoc | 0m 26s | hbase-examples in the patch failed. | | -0 :warning: | javadoc | 0m 25s | hbase-mapreduce in the patch failed. | | -0 :warning: | javadoc | 0m 27s | hbase-rest in the patch failed. | | -0 :warning: | javadoc | 0m 59s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 1m 19s | hbase-thrift in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 283m 51s | root in the patch failed. | | | | 333m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1664 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4e18f4f8a174 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 20a7a542ff | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-asyncfs.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1664/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt | | javadoc |
[GitHub] [hbase] Apache-HBase commented on pull request #1669: HBASE-24338 [Flakey Tests] NPE in TestRaceBetweenSCPAndDTP
Apache-HBase commented on pull request #1669: URL: https://github.com/apache/hbase/pull/1669#issuecomment-624847567 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 44s | branch-2 passed | | +1 :green_heart: | compile | 0m 53s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 25s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 20s | the patch passed | | +1 :green_heart: | compile | 0m 54s | the patch passed | | +1 :green_heart: | javac | 0m 54s | the patch passed | | +1 :green_heart: | shadedjars | 4m 28s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 148m 22s | hbase-server in the patch passed. | | | | 170m 33s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1669/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1669 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 8f1635aac558 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 89ae3c55c8 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1669/1/testReport/ | | Max. process+thread count | 3338 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1669/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1669: HBASE-24338 [Flakey Tests] NPE in TestRaceBetweenSCPAndDTP
Apache-HBase commented on pull request #1669: URL: https://github.com/apache/hbase/pull/1669#issuecomment-624845135 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 25s | branch-2 passed | | +1 :green_heart: | compile | 1m 5s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 23s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server in branch-2 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 1s | the patch passed | | +1 :green_heart: | compile | 1m 4s | the patch passed | | +1 :green_heart: | javac | 1m 4s | the patch passed | | +1 :green_heart: | shadedjars | 6m 13s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 50s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 138m 53s | hbase-server in the patch failed. | | | | 165m 33s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1669/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1669 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0969f84c1abb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 89ae3c55c8 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1669/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1669/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1669/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1669/1/testReport/ | | Max. process+thread count | 3725 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1669/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-24340) PerformanceEvaluation options should not mandate any specific order
[
https://issues.apache.org/jira/browse/HBASE-24340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sambit Mohapatra reassigned HBASE-24340:
Assignee: Sambit Mohapatra (was: Anoop Sam John)
> PerformanceEvaluation options should not mandate any specific order
> ---
>
> Key: HBASE-24340
> URL: https://issues.apache.org/jira/browse/HBASE-24340
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Anoop Sam John
>Assignee: Sambit Mohapatra
>Priority: Minor
>
> During parsing of options, there are some validations. One such is checking
> whether autoFlush = false AND multiPut > 0. This validation code mandates an
> order that autoFlush=true should be specified before adding multiPut = x in
> PE command.
> {code}
> final String multiPut = "--multiPut=";
> if (cmd.startsWith(multiPut)) {
> opts.multiPut = Integer.parseInt(cmd.substring(multiPut.length()));
> if (!opts.autoFlush && opts.multiPut > 0) {
> throw new IllegalArgumentException("autoFlush must be true when
> multiPut is more than 0");
> }
> continue;
> }
> {code}
> 'autoFlush ' default value is false. If multiPut is specified prior to
> autoFlush in the PE command, we will end up throwing IllegalArgumentException.
> Checking other validations, seems not having such issue. Still better to
> move all the validations together into a private method and call that once
> the parse is over.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24322) UnsafeAvailChecker should also check that required methods are available
[
https://issues.apache.org/jira/browse/HBASE-24322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101106#comment-17101106
]
Hudson commented on HBASE-24322:
Results for branch branch-2.2
[build #855 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/855/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/855//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/855//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/855//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> UnsafeAvailChecker should also check that required methods are available
>
>
> Key: HBASE-24322
> URL: https://issues.apache.org/jira/browse/HBASE-24322
> Project: HBase
> Issue Type: Bug
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.1, 1.7.0, 2.4.0, 2.1.10, 2.2.5
>
>
> We had a weird test failure due to accidentally running tests with some Java
> > 8 (exact version I am unsure of), where Unsafe is available, but the method
> signatures were different or some methods were removed, leading to this:
> {noformat}
> 020-05-02 14:57:15,145 ERROR [main] master.HMasterCommandLine: Master exiting
> java.lang.RuntimeException: Failed construction of Master: class
> org.apache.hadoop.hbase.master.HMasterCommandLine$LocalHMaster
> at
> org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:143)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.addMaster(LocalHBaseCluster.java:237)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.(LocalHBaseCluster.java:163)
> at
> org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:225)
> at
> org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:138)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at
> org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:127)
> at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:2911)
> Caused by: java.lang.NoSuchMethodError: 'void
> sun.misc.Unsafe.putInt(java.lang.Object, int, int)'
> at org.apache.hadoop.hbase.util.UnsafeAccess.putInt(UnsafeAccess.java:233)
> at
> org.apache.hadoop.hbase.util.Bytes$ConverterHolder$UnsafeConverter.putInt(Bytes.java:1499)
> at org.apache.hadoop.hbase.util.Bytes.putInt(Bytes.java:1021)
> at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.appendMetaData(RecoverableZooKeeper.java:850)
> at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.create(RecoverableZooKeeper.java:640)
> at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:1027)
> at
> org.apache.hadoop.hbase.zookeeper.MasterAddressTracker.setMasterAddress(MasterAddressTracker.java:211)
> at
> org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2095)
> at org.apache.hadoop.hbase.master.HMaster.(HMaster.java:520)
> at
> org.apache.hadoop.hbase.master.HMasterCommandLine$LocalHMaster.(HMasterCommandLine.java:315)
> at
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
> at
> org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:138)
> ... 7 more
> {noformat}
> We should also check that all methods that will be invoked on Unsafe in
> UnsafeAccess.java are available when deciding in UnsafeAvailChecker if Unsafe
> is available (and usable).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (HBASE-23938) Replicate slow/large RPC calls to HDFS
[ https://issues.apache.org/jira/browse/HBASE-23938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101081#comment-17101081 ] Viraj Jasani edited comment on HBASE-23938 at 5/6/20, 6:34 PM: --- Attaching sample scan of hbase:slowlog table. was (Author: vjasani): Attaching sample scan of hbase:slowlog table: !Screen Shot 2020-05-07 at 12.01.26 AM.png! > Replicate slow/large RPC calls to HDFS > -- > > Key: HBASE-23938 > URL: https://issues.apache.org/jira/browse/HBASE-23938 > Project: HBase > Issue Type: Sub-task >Affects Versions: 3.0.0-alpha-1, 2.3.0, 1.7.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Attachments: Screen Shot 2020-05-07 at 12.01.26 AM.png > > > We should provide capability to replicate complete slow and large RPC logs to > HDFS or create new system table in addition to Ring Buffer. This way we don't > lose any of slow logs and operator can retrieve all the slow/large logs. > Replicating logs to HDFS / creating new system table should be configurable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23938) Replicate slow/large RPC calls to HDFS
[ https://issues.apache.org/jira/browse/HBASE-23938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101081#comment-17101081 ] Viraj Jasani commented on HBASE-23938: -- Attaching sample scan of hbase:slowlog table: !Screen Shot 2020-05-07 at 12.01.26 AM.png! > Replicate slow/large RPC calls to HDFS > -- > > Key: HBASE-23938 > URL: https://issues.apache.org/jira/browse/HBASE-23938 > Project: HBase > Issue Type: Sub-task >Affects Versions: 3.0.0-alpha-1, 2.3.0, 1.7.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Attachments: Screen Shot 2020-05-07 at 12.01.26 AM.png > > > We should provide capability to replicate complete slow and large RPC logs to > HDFS or create new system table in addition to Ring Buffer. This way we don't > lose any of slow logs and operator can retrieve all the slow/large logs. > Replicating logs to HDFS / creating new system table should be configurable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23938) Replicate slow/large RPC calls to HDFS
[ https://issues.apache.org/jira/browse/HBASE-23938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-23938: - Attachment: Screen Shot 2020-05-07 at 12.01.26 AM.png > Replicate slow/large RPC calls to HDFS > -- > > Key: HBASE-23938 > URL: https://issues.apache.org/jira/browse/HBASE-23938 > Project: HBase > Issue Type: Sub-task >Affects Versions: 3.0.0-alpha-1, 2.3.0, 1.7.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Attachments: Screen Shot 2020-05-07 at 12.01.26 AM.png > > > We should provide capability to replicate complete slow and large RPC logs to > HDFS or create new system table in addition to Ring Buffer. This way we don't > lose any of slow logs and operator can retrieve all the slow/large logs. > Replicating logs to HDFS / creating new system table should be configurable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-23832) Old config hbase.hstore.compactionThreshold is ignored
[
https://issues.apache.org/jira/browse/HBASE-23832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sambit Mohapatra reassigned HBASE-23832:
Assignee: Sambit Mohapatra
> Old config hbase.hstore.compactionThreshold is ignored
> --
>
> Key: HBASE-23832
> URL: https://issues.apache.org/jira/browse/HBASE-23832
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Anoop Sam John
>Assignee: Sambit Mohapatra
>Priority: Major
>
> In 2.x we added new name 'hbase.hstore.compaction.min' for this. Still for
> compatibility we allow the old config name and honor that in code
> {code}
> minFilesToCompact = Math.max(2, conf.getInt(HBASE_HSTORE_COMPACTION_MIN_KEY,
> /*old name*/ conf.getInt("hbase.hstore.compactionThreshold", 3)));
> {code}
> But if hbase.hstore.compactionThreshold alone is configured by user, there is
> no impact of that.
> This is because in hbase-default.xml we have the new config with a value of
> 3. So the call conf.getInt(HBASE_HSTORE_COMPACTION_MIN_KEY) always return a
> value 3 even if it is not explicitly configured by customer and instead used
> the old key.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1671: Backport: HBASE-24316 GCMulitpleMergedRegionsProcedure is not idempotent (#1660)
Apache-HBase commented on pull request #1671: URL: https://github.com/apache/hbase/pull/1671#issuecomment-624811557 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 42s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 11s | branch-2 passed | | +1 :green_heart: | spotbugs | 3m 33s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 22s | the patch passed | | -0 :warning: | checkstyle | 1m 24s | hbase-server: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 16m 7s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 4m 16s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. | | | | 48m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1671/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1671 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 4b150cab757a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 04ac08d49b | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1671/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1671/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles
[ https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey reassigned HBASE-24273: --- Assignee: Huaxiang Sun > HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles > > > Key: HBASE-24273 > URL: https://issues.apache.org/jira/browse/HBASE-24273 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 2.2.4 > Environment: HBase 2.2.4 > Hadoop 3.1.3 >Reporter: Andrey Elenskiy >Assignee: Huaxiang Sun >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.3.0 > > > This issue came up after merging regions. MergeTableRegionsProcedure removes > the parent regions from hbase:meta and creates HFile references in child > region to the old parent regions. Running `hbck_chore_run` right after the > `merge_region` will show the parent regions in "Orphan Regions on FileSystem" > until major compaction is run on child region which will remove HFile > references and cause Catalog Janitor to clean up the parent regions. > There are probably other situations which can cause the same issue (maybe > region split?) > Having "Orphan Regions on FileSystem" list parent regions and suggest to > "_hbase completebulkload_" is dangerous in this case as completing bulk load > will lead to stale HFile references in child region which will cause its OPEN > to fail because referenced HFile doesn't exist. > Figuring out these things for database administrators is tedious, so I think > it would be reasonable to not consider regions with referenced HFiles to be > orphans (or maybe could give an extra hint saying that it has referenced > HFiles). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles
[ https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101058#comment-17101058 ] Sean Busbey commented on HBASE-24273: - [~huaxiangsun] I updated your role in jira so you should be able to resolve things again. > HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles > > > Key: HBASE-24273 > URL: https://issues.apache.org/jira/browse/HBASE-24273 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 2.2.4 > Environment: HBase 2.2.4 > Hadoop 3.1.3 >Reporter: Andrey Elenskiy >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.3.0 > > > This issue came up after merging regions. MergeTableRegionsProcedure removes > the parent regions from hbase:meta and creates HFile references in child > region to the old parent regions. Running `hbck_chore_run` right after the > `merge_region` will show the parent regions in "Orphan Regions on FileSystem" > until major compaction is run on child region which will remove HFile > references and cause Catalog Janitor to clean up the parent regions. > There are probably other situations which can cause the same issue (maybe > region split?) > Having "Orphan Regions on FileSystem" list parent regions and suggest to > "_hbase completebulkload_" is dangerous in this case as completing bulk load > will lead to stale HFile references in child region which will cause its OPEN > to fail because referenced HFile doesn't exist. > Figuring out these things for database administrators is tedious, so I think > it would be reasonable to not consider regions with referenced HFiles to be > orphans (or maybe could give an extra hint saying that it has referenced > HFiles). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles
[ https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101057#comment-17101057 ] Sean Busbey commented on HBASE-24273: - this should also go into branch-2.2 right? > HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles > > > Key: HBASE-24273 > URL: https://issues.apache.org/jira/browse/HBASE-24273 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 2.2.4 > Environment: HBase 2.2.4 > Hadoop 3.1.3 >Reporter: Andrey Elenskiy >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.3.0 > > > This issue came up after merging regions. MergeTableRegionsProcedure removes > the parent regions from hbase:meta and creates HFile references in child > region to the old parent regions. Running `hbck_chore_run` right after the > `merge_region` will show the parent regions in "Orphan Regions on FileSystem" > until major compaction is run on child region which will remove HFile > references and cause Catalog Janitor to clean up the parent regions. > There are probably other situations which can cause the same issue (maybe > region split?) > Having "Orphan Regions on FileSystem" list parent regions and suggest to > "_hbase completebulkload_" is dangerous in this case as completing bulk load > will lead to stale HFile references in child region which will cause its OPEN > to fail because referenced HFile doesn't exist. > Figuring out these things for database administrators is tedious, so I think > it would be reasonable to not consider regions with referenced HFiles to be > orphans (or maybe could give an extra hint saying that it has referenced > HFiles). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1670: HBASE-24337 Backport HBASE-23968 to branch-2
Apache-HBase commented on pull request #1670: URL: https://github.com/apache/hbase/pull/1670#issuecomment-624787669 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 47s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 31s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 20s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 10s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 42s | the patch passed | | +1 :green_heart: | checkstyle | 1m 16s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 42s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 37m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1670/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1670 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 657a21ec5409 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 04ac08d49b | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1670/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1669: HBASE-24338 [Flakey Tests] NPE in TestRaceBetweenSCPAndDTP
Apache-HBase commented on pull request #1669: URL: https://github.com/apache/hbase/pull/1669#issuecomment-624784498 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 41s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 28s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 32s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 32s | the patch passed | | -0 :warning: | checkstyle | 1m 32s | hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 15m 59s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 48s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 43m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1669/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1669 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux d296f74ec727 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 89ae3c55c8 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1669/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1669/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-24298) Reduce cpu load of locating region especially in batch mode.
[ https://issues.apache.org/jira/browse/HBASE-24298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] star reassigned HBASE-24298: Assignee: star > Reduce cpu load of locating region especially in batch mode. > > > Key: HBASE-24298 > URL: https://issues.apache.org/jira/browse/HBASE-24298 > Project: HBase > Issue Type: Bug >Reporter: star >Assignee: star >Priority: Major > Attachments: locating region.svg > > > Binary search is used to speedup the process of locating region. It is > already fast enough, while cpu of HBASE client becomes the bottleneck when > doing TCSB benchmark. We can make the process of locating region faster to > reduce cpu load in some special cases , which however is our common case in > production environment. It is the case: > 1. Predefined splits in uniform distribution. > > 2. Load data in batch mode. > The optimization is very simple, just to contract range of binary search. > Initially, record all startIndex and endIndex of first or two bytes of keys. > When a region key comes, find the contracted startIndex and endIndex of the > key. Then return to normal binary search process with the specified > startIndex and endIndex. > Then we can ideally reduce cpu to 1/8 with 1 byte or 1/16 with 2 bytes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24298) Reduce cpu load of locating region especially in batch mode.
[ https://issues.apache.org/jira/browse/HBASE-24298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] star updated HBASE-24298: - Description: Binary search is used to speedup the process of locating region. It is already fast enough, while cpu of HBASE client becomes the bottleneck when doing TCSB benchmark. We can make the process of locating region faster to reduce cpu load in some special cases , which however is our common case in production environment. It is the case: 1. Predefined splits in uniform distribution. 2. Load data in batch mode. The optimization is very simple, just to contract range of binary search. Initially, record all startIndex and endIndex of first or two bytes of keys. When a region key comes, find the contracted startIndex and endIndex of the key. Then return to normal binary search process with the specified startIndex and endIndex. Then we can ideally reduce cpu to 1/8 with 1 byte or 1/16 with 2 bytes. was: Binary search is used to speedup the process of locating region. It is already fast enough, while cpu of HBASE client becomes the bottleneck when doing TCSB benchmark. We can make the process of locating region faster to reduce cpu load in some special cases , which however it is our common case in production environment. It is the case: 1. Predefined splits in uniform distribution. 2. Load data in batch mode. The optimization is very simple, just to contract range of binary search. Initially, record all startIndex and endIndex of first or two bytes of keys. When a region key comes, find the contracted startIndex and endIndex of the key. Then return to normal binary search process with the specified startIndex and endIndex. When we can ideally reduce cpu to 1/8 with 1 byte or 1/16 with 2 bytes. > Reduce cpu load of locating region especially in batch mode. > > > Key: HBASE-24298 > URL: https://issues.apache.org/jira/browse/HBASE-24298 > Project: HBase > Issue Type: Bug >Reporter: star >Priority: Major > Attachments: locating region.svg > > > Binary search is used to speedup the process of locating region. It is > already fast enough, while cpu of HBASE client becomes the bottleneck when > doing TCSB benchmark. We can make the process of locating region faster to > reduce cpu load in some special cases , which however is our common case in > production environment. It is the case: > 1. Predefined splits in uniform distribution. > > 2. Load data in batch mode. > The optimization is very simple, just to contract range of binary search. > Initially, record all startIndex and endIndex of first or two bytes of keys. > When a region key comes, find the contracted startIndex and endIndex of the > key. Then return to normal binary search process with the specified > startIndex and endIndex. > Then we can ideally reduce cpu to 1/8 with 1 byte or 1/16 with 2 bytes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] huaxiangsun commented on pull request #1629: HBASE-24328 skip duplicate GCMultipleMergedRegionsProcedure while previous finished
huaxiangsun commented on pull request #1629: URL: https://github.com/apache/hbase/pull/1629#issuecomment-624773194 @nyl3532016 I merged the patch. Can you back port it to branch-2 and branch-2.3? Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-24340) PerformanceEvaluation options should not mandate any specific order
Anoop Sam John created HBASE-24340:
--
Summary: PerformanceEvaluation options should not mandate any
specific order
Key: HBASE-24340
URL: https://issues.apache.org/jira/browse/HBASE-24340
Project: HBase
Issue Type: Improvement
Affects Versions: 2.1.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
During parsing of options, there are some validations. One such is checking
whether autoFlush = false AND multiPut > 0. This validation code mandates an
order that autoFlush=true should be specified before adding multiPut = x in PE
command.
{code}
final String multiPut = "--multiPut=";
if (cmd.startsWith(multiPut)) {
opts.multiPut = Integer.parseInt(cmd.substring(multiPut.length()));
if (!opts.autoFlush && opts.multiPut > 0) {
throw new IllegalArgumentException("autoFlush must be true when
multiPut is more than 0");
}
continue;
}
{code}
'autoFlush ' default value is false. If multiPut is specified prior to
autoFlush in the PE command, we will end up throwing IllegalArgumentException.
Checking other validations, seems not having such issue. Still better to move
all the validations together into a private method and call that once the parse
is over.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] huaxiangsun opened a new pull request #1671: Backport: HBASE-24316 GCMulitpleMergedRegionsProcedure is not idempotent (#1660)
huaxiangsun opened a new pull request #1671: URL: https://github.com/apache/hbase/pull/1671 It addresses couple issues: 1. Make sure deleteMergeQualifiers() does not delete the row if there is no columns with "merge" keyword. 2. GCMulitpleMergedRegionsProcedure now acquire an exclusive lock on the child region. Signed-off-by: stack This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles
[ https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100998#comment-17100998 ] Huaxiang Sun commented on HBASE-24273: -- Oh, my Jira id issue is not resolved it, I cannot resolve. [~stack] and [~timoha], please resolve it if you get chance, thanks. > HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles > > > Key: HBASE-24273 > URL: https://issues.apache.org/jira/browse/HBASE-24273 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 2.2.4 > Environment: HBase 2.2.4 > Hadoop 3.1.3 >Reporter: Andrey Elenskiy >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.3.0 > > > This issue came up after merging regions. MergeTableRegionsProcedure removes > the parent regions from hbase:meta and creates HFile references in child > region to the old parent regions. Running `hbck_chore_run` right after the > `merge_region` will show the parent regions in "Orphan Regions on FileSystem" > until major compaction is run on child region which will remove HFile > references and cause Catalog Janitor to clean up the parent regions. > There are probably other situations which can cause the same issue (maybe > region split?) > Having "Orphan Regions on FileSystem" list parent regions and suggest to > "_hbase completebulkload_" is dangerous in this case as completing bulk load > will lead to stale HFile references in child region which will cause its OPEN > to fail because referenced HFile doesn't exist. > Figuring out these things for database administrators is tedious, so I think > it would be reasonable to not consider regions with referenced HFiles to be > orphans (or maybe could give an extra hint saying that it has referenced > HFiles). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles
[ https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100997#comment-17100997 ] Huaxiang Sun commented on HBASE-24273: -- Thanks [~stack]. I have pushed the patch to branch-2 and 2.3, let me resolve it. > HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles > > > Key: HBASE-24273 > URL: https://issues.apache.org/jira/browse/HBASE-24273 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 2.2.4 > Environment: HBase 2.2.4 > Hadoop 3.1.3 >Reporter: Andrey Elenskiy >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.3.0 > > > This issue came up after merging regions. MergeTableRegionsProcedure removes > the parent regions from hbase:meta and creates HFile references in child > region to the old parent regions. Running `hbck_chore_run` right after the > `merge_region` will show the parent regions in "Orphan Regions on FileSystem" > until major compaction is run on child region which will remove HFile > references and cause Catalog Janitor to clean up the parent regions. > There are probably other situations which can cause the same issue (maybe > region split?) > Having "Orphan Regions on FileSystem" list parent regions and suggest to > "_hbase completebulkload_" is dangerous in this case as completing bulk load > will lead to stale HFile references in child region which will cause its OPEN > to fail because referenced HFile doesn't exist. > Figuring out these things for database administrators is tedious, so I think > it would be reasonable to not consider regions with referenced HFiles to be > orphans (or maybe could give an extra hint saying that it has referenced > HFiles). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24316) GCMulitpleMergedRegionsProcedure is not idempotent
[
https://issues.apache.org/jira/browse/HBASE-24316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100991#comment-17100991
]
Hudson commented on HBASE-24316:
Results for branch master
[build #1718 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> GCMulitpleMergedRegionsProcedure is not idempotent
> ---
>
> Key: HBASE-24316
> URL: https://issues.apache.org/jira/browse/HBASE-24316
> Project: HBase
> Issue Type: Bug
> Components: proc-v2
>Affects Versions: 3.0.0-alpha-1, 2.3.0, 2.4.0
>Reporter: Huaxiang Sun
>Priority: Major
>
> Currently deleteMergeQualifiers() is not idempotent. If two
> GCMulitpleMergedRegionsProcedures are run for the same merged child region,
> the second run will delete the row for the merge region from meta table and
> leave a hole. It needs to make sure it only deletes columns with merge
> qualifiers.
> [https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java#L1849]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24304) Separate a hbase-asyncfs module
[
https://issues.apache.org/jira/browse/HBASE-24304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100992#comment-17100992
]
Hudson commented on HBASE-24304:
Results for branch master
[build #1718 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Separate a hbase-asyncfs module
> ---
>
> Key: HBASE-24304
> URL: https://issues.apache.org/jira/browse/HBASE-24304
> Project: HBase
> Issue Type: Improvement
> Components: build, pom
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> To hold the async fs related class for WAL implementation as the hbase-server
> module is too big.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24118) [Flakey Tests] TestCloseRegionWhileRSCrash
[
https://issues.apache.org/jira/browse/HBASE-24118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100988#comment-17100988
]
Hudson commented on HBASE-24118:
Results for branch master
[build #1718 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Tests] TestCloseRegionWhileRSCrash
> --
>
> Key: HBASE-24118
> URL: https://issues.apache.org/jira/browse/HBASE-24118
> Project: HBase
> Issue Type: Test
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
> Attachments:
> 0001-HBASE-24118-Flakey-Tests-TestCloseRegionWhileRSCrash.patch
>
>
> TestCloseRegionWhileRSCrash is flakey because of HBASE-24117 -- because
> moved Region may not online in the end. Remove the last bit of the test...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24265) Remove hedged rpc call support, implement the logic in MaterRegistry directly
[
https://issues.apache.org/jira/browse/HBASE-24265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100993#comment-17100993
]
Hudson commented on HBASE-24265:
Results for branch master
[build #1718 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove hedged rpc call support, implement the logic in MaterRegistry directly
> -
>
> Key: HBASE-24265
> URL: https://issues.apache.org/jira/browse/HBASE-24265
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24284) [h3/jdk11] REST server won't start
[
https://issues.apache.org/jira/browse/HBASE-24284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100986#comment-17100986
]
Hudson commented on HBASE-24284:
Results for branch master
[build #1718 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [h3/jdk11] REST server won't start
> --
>
> Key: HBASE-24284
> URL: https://issues.apache.org/jira/browse/HBASE-24284
> Project: HBase
> Issue Type: Bug
> Components: REST
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> {code}
> 2020-04-29 07:06:31,610 INFO [main] server.AbstractConnector: Started
> ServerConnector@1bdf8190{HTTP/1.1,[http/1.1]}{0.0.0.0:8080}
> Exception in thread "main" java.lang.NoSuchMethodError: 'java.util.Map
> javax.ws.rs.core.Application.getProperties()'
> at
> org.glassfish.jersey.server.ApplicationHandler.(ApplicationHandler.java:331)
> at
> org.glassfish.jersey.servlet.WebComponent.(WebComponent.java:392)
> at
> org.glassfish.jersey.servlet.ServletContainer.init(ServletContainer.java:177)
> {code}
> Seems fine for hadoop2/jdk8.
> I get the above when I do: mvn install -Dhadoop.profile=3.0 building w/ jdk11.
> Fix coming...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24307) [Flakey Tests] krb server for secure thrift tests throws BindException
[
https://issues.apache.org/jira/browse/HBASE-24307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100989#comment-17100989
]
Hudson commented on HBASE-24307:
Results for branch master
[build #1718 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Tests] krb server for secure thrift tests throws BindException
> --
>
> Key: HBASE-24307
> URL: https://issues.apache.org/jira/browse/HBASE-24307
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
>
> Thought I'd put all the BindExceptions in thrift to sleep but just came
> across this one putting up the *krb* server used by the secure thrift http
> tests. There are two tests that use krb:
> {code}
>
> ---
> Test set: org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpFallbackServer
>
> ---
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.042 s <<<
> FAILURE! - in
> org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpFallbackServer
> org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpFallbackServer Time
> elapsed: 0.017 s <<< ERROR!
> org.apache.kerby.kerberos.kerb.KrbException: Failed to start KDC-Server
>at
> org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpFallbackServer.setUpBeforeClass(TestThriftSpnegoHttpFallbackServer.java:137)
> Caused by: java.net.BindException: Address already in use (Bind failed)
>at
> org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpFallbackServer.setUpBeforeClass(TestThriftSpnegoHttpFallbackServer.java:137)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24137) The max merge count of metafixer may be remind in hbase-site.xml
[
https://issues.apache.org/jira/browse/HBASE-24137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100987#comment-17100987
]
Hudson commented on HBASE-24137:
Results for branch master
[build #1718 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> The max merge count of metafixer may be remind in hbase-site.xml
>
>
> Key: HBASE-24137
> URL: https://issues.apache.org/jira/browse/HBASE-24137
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1
>Reporter: Yu Wang
>Assignee: Yu Wang
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
> Attachments: 24137_master_1.patch
>
>
> The max merge count of metafixer should be configurable in MetaFixer
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23976) [flakey test] TestVerifyBucketCacheFile
[
https://issues.apache.org/jira/browse/HBASE-23976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100990#comment-17100990
]
Hudson commented on HBASE-23976:
Results for branch master
[build #1718 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [flakey test] TestVerifyBucketCacheFile
> ---
>
> Key: HBASE-23976
> URL: https://issues.apache.org/jira/browse/HBASE-23976
> Project: HBase
> Issue Type: Test
> Components: regionserver, test
>Affects Versions: 3.0.0-alpha-1
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> I see sporadic failures in this test class. Sometimes a failure on
> {{assertTrue(file.delete())}}, an inconsistent annoyance. However, this one
> looks more sinister.
> {noformat}
> 2020-03-12 12:11:35,059 ERROR [Time-limited test] bucket.BucketCache(312):
> Can't restore from
> file[/Users/ndimiduk/repos/apache/hbase/hbase-server/target/test-data/5e5c5f5f-d5c2-94b2-8ce9-cf561f4f19f7/bucket.persistence]
> because of
> java.io.IOException: Mismatch of checksum! The persistent checksum is
> ���#20;B#16;k�#3;��2�Ӏk, but the calculate checksum is
> �o���r��w��c��4
> at
> org.apache.hadoop.hbase.io.hfile.bucket.PersistentIOEngine.verifyFileIntegrity(PersistentIOEngine.java:55)
> at
> org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.parsePB(BucketCache.java:1158)
> at
> org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.retrieveFromFile(BucketCache.java:1106)
> at
> org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.(BucketCache.java:310)
> at
> org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.(BucketCache.java:258)
> at
> org.apache.hadoop.hbase.io.hfile.bucket.TestVerifyBucketCacheFile.testRetrieveFromFile(TestVerifyBucketCacheFile.java:116)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles
[
https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100983#comment-17100983
]
Hudson commented on HBASE-24273:
Results for branch master
[build #1718 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles
>
>
> Key: HBASE-24273
> URL: https://issues.apache.org/jira/browse/HBASE-24273
> Project: HBase
> Issue Type: Bug
> Components: hbck2
>Affects Versions: 2.2.4
> Environment: HBase 2.2.4
> Hadoop 3.1.3
>Reporter: Andrey Elenskiy
>Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> This issue came up after merging regions. MergeTableRegionsProcedure removes
> the parent regions from hbase:meta and creates HFile references in child
> region to the old parent regions. Running `hbck_chore_run` right after the
> `merge_region` will show the parent regions in "Orphan Regions on FileSystem"
> until major compaction is run on child region which will remove HFile
> references and cause Catalog Janitor to clean up the parent regions.
> There are probably other situations which can cause the same issue (maybe
> region split?)
> Having "Orphan Regions on FileSystem" list parent regions and suggest to
> "_hbase completebulkload_" is dangerous in this case as completing bulk load
> will lead to stale HFile references in child region which will cause its OPEN
> to fail because referenced HFile doesn't exist.
> Figuring out these things for database administrators is tedious, so I think
> it would be reasonable to not consider regions with referenced HFiles to be
> orphans (or maybe could give an extra hint saying that it has referenced
> HFiles).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24315) Remove hadoop-two-compat.xml in hbase-assembly
[
https://issues.apache.org/jira/browse/HBASE-24315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100981#comment-17100981
]
Hudson commented on HBASE-24315:
Results for branch master
[build #1718 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove hadoop-two-compat.xml in hbase-assembly
> --
>
> Key: HBASE-24315
> URL: https://issues.apache.org/jira/browse/HBASE-24315
> Project: HBase
> Issue Type: Sub-task
> Components: build, hadoop2, hadoop3
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1
>
>
> Missed this one.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24303) Undo core of parent TestSecureRESTServer change; use fix over in HBASE-24280 instead
[
https://issues.apache.org/jira/browse/HBASE-24303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100985#comment-17100985
]
Hudson commented on HBASE-24303:
Results for branch master
[build #1718 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Undo core of parent TestSecureRESTServer change; use fix over in HBASE-24280
> instead
>
>
> Key: HBASE-24303
> URL: https://issues.apache.org/jira/browse/HBASE-24303
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 3.0.0-alpha-1, 2.3.0
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> Parent issue puts in a place that makes TestSecureRESTServer pass up on
> jenkins by shoving into the dependency list the jersey1 ServletContainer.
> Root issue was change in how we specified profiles in nightlies; both hadoop3
> and hadoop2 were mistakenly active (HBASE-24280). This issue is about undoing
> the dependency insertion after fix for HBASE-24280 goes in.
> Don't want to revert the parent. It has cleanups that should stay.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] huaxiangsun commented on a change in pull request #1661: Backport: HBASE-24273 HBCK's "Orphan Regions on FileSystem" reports regions wit…
huaxiangsun commented on a change in pull request #1661:
URL: https://github.com/apache/hbase/pull/1661#discussion_r420940702
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java
##
@@ -134,7 +135,7 @@ protected synchronized void chore() {
loadRegionsFromInMemoryState();
loadRegionsFromRSReport();
try {
-loadRegionsFromFS();
+loadRegionsFromFS(scanForMergedParentRegions());
Review comment:
Thanks @wchevreuil, this is good catch. I have pushed the patch as it is
to master and branch-2.3, to keep it consistent, I will push as it is. Will put
up an addendum if it is needed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-24322) UnsafeAvailChecker should also check that required methods are available
[
https://issues.apache.org/jira/browse/HBASE-24322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100984#comment-17100984
]
Hudson commented on HBASE-24322:
Results for branch master
[build #1718 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> UnsafeAvailChecker should also check that required methods are available
>
>
> Key: HBASE-24322
> URL: https://issues.apache.org/jira/browse/HBASE-24322
> Project: HBase
> Issue Type: Bug
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.1, 1.7.0, 2.4.0, 2.1.10, 2.2.5
>
>
> We had a weird test failure due to accidentally running tests with some Java
> > 8 (exact version I am unsure of), where Unsafe is available, but the method
> signatures were different or some methods were removed, leading to this:
> {noformat}
> 020-05-02 14:57:15,145 ERROR [main] master.HMasterCommandLine: Master exiting
> java.lang.RuntimeException: Failed construction of Master: class
> org.apache.hadoop.hbase.master.HMasterCommandLine$LocalHMaster
> at
> org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:143)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.addMaster(LocalHBaseCluster.java:237)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.(LocalHBaseCluster.java:163)
> at
> org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:225)
> at
> org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:138)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at
> org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:127)
> at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:2911)
> Caused by: java.lang.NoSuchMethodError: 'void
> sun.misc.Unsafe.putInt(java.lang.Object, int, int)'
> at org.apache.hadoop.hbase.util.UnsafeAccess.putInt(UnsafeAccess.java:233)
> at
> org.apache.hadoop.hbase.util.Bytes$ConverterHolder$UnsafeConverter.putInt(Bytes.java:1499)
> at org.apache.hadoop.hbase.util.Bytes.putInt(Bytes.java:1021)
> at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.appendMetaData(RecoverableZooKeeper.java:850)
> at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.create(RecoverableZooKeeper.java:640)
> at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:1027)
> at
> org.apache.hadoop.hbase.zookeeper.MasterAddressTracker.setMasterAddress(MasterAddressTracker.java:211)
> at
> org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2095)
> at org.apache.hadoop.hbase.master.HMaster.(HMaster.java:520)
> at
> org.apache.hadoop.hbase.master.HMasterCommandLine$LocalHMaster.(HMasterCommandLine.java:315)
> at
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
> at
> org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:138)
> ... 7 more
> {noformat}
> We should also check that all methods that will be invoked on Unsafe in
> UnsafeAccess.java are available when deciding in UnsafeAvailChecker if Unsafe
> is available (and usable).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24314) Some classes still use log4j logger directly
[
https://issues.apache.org/jira/browse/HBASE-24314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100982#comment-17100982
]
Hudson commented on HBASE-24314:
Results for branch master
[build #1718 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1718/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Some classes still use log4j logger directly
>
>
> Key: HBASE-24314
> URL: https://issues.apache.org/jira/browse/HBASE-24314
> Project: HBase
> Issue Type: Bug
> Components: logging
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Blocker
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.5
>
>
> Found this when implementing HBASE-24309. Should use slf4j instead.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24211) Create table is slow in large cluster when AccessController is enabled.
[
https://issues.apache.org/jira/browse/HBASE-24211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100980#comment-17100980
]
HBase QA commented on HBASE-24211:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
55s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
27s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
7s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} branch-1 passed with JDK v1.8.0_252 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
20s{color} | {color:green} branch-1 passed with JDK v1.7.0_262 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
42s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
4s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
13s{color} | {color:green} branch-1 passed with JDK v1.8.0_252 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
18s{color} | {color:green} branch-1 passed with JDK v1.7.0_262 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 2m
55s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
29s{color} | {color:green} branch-1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} the patch passed with JDK v1.8.0_252 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
9s{color} | {color:green} the patch passed with JDK v1.7.0_262 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
7s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
5m 16s{color} | {color:green} Patch does not cause any errors with Hadoop 2.8.5
2.9.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
50s{color} | {color:green} the patch passed with JDK v1.8.0_252 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} the patch passed with JDK v1.7.0_262 {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
45s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
39s{color} |
[GitHub] [hbase] Apache-HBase commented on pull request #1658: HBASE-24211: [Addendum] Create table is slow in large cluster when AccessController is enabled.
Apache-HBase commented on pull request #1658: URL: https://github.com/apache/hbase/pull/1658#issuecomment-624763730 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 55s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1 Compile Tests _ | | +0 :ok: | mvndep | 1m 27s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 8m 7s | branch-1 passed | | +1 :green_heart: | compile | 1m 12s | branch-1 passed with JDK v1.8.0_252 | | +1 :green_heart: | compile | 1m 20s | branch-1 passed with JDK v1.7.0_262 | | +1 :green_heart: | checkstyle | 2m 42s | branch-1 passed | | +1 :green_heart: | shadedjars | 4m 4s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 13s | branch-1 passed with JDK v1.8.0_252 | | +1 :green_heart: | javadoc | 1m 18s | branch-1 passed with JDK v1.7.0_262 | | +0 :ok: | spotbugs | 2m 55s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 29s | branch-1 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 4s | the patch passed | | +1 :green_heart: | compile | 1m 3s | the patch passed with JDK v1.8.0_252 | | +1 :green_heart: | javac | 1m 3s | the patch passed | | +1 :green_heart: | compile | 1m 9s | the patch passed with JDK v1.7.0_262 | | +1 :green_heart: | javac | 1m 9s | the patch passed | | +1 :green_heart: | checkstyle | 2m 21s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 3m 7s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 5m 16s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | javadoc | 0m 50s | the patch passed with JDK v1.8.0_252 | | +1 :green_heart: | javadoc | 1m 7s | the patch passed with JDK v1.7.0_262 | | +1 :green_heart: | findbugs | 4m 45s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 39s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 149m 20s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 0m 52s | The patch does not generate ASF License warnings. | | | | 206m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1658/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1658 | | JIRA Issue | HBASE-24211 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 5cdcbef42b5f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1658/out/precommit/personality/provided.sh | | git revision | branch-1 / febf15f | | Default Java | 1.7.0_262 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1658/3/testReport/ | | Max. process+thread count | 4616 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1658/3/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-24339) Backport HBASE-23968 to branch-1
Minwoo Kang created HBASE-24339: --- Summary: Backport HBASE-23968 to branch-1 Key: HBASE-24339 URL: https://issues.apache.org/jira/browse/HBASE-24339 Project: HBase Issue Type: Sub-task Reporter: Minwoo Kang Assignee: Minwoo Kang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] mwkang opened a new pull request #1670: HBASE-24337 Backport HBASE-23968 to branch-2
mwkang opened a new pull request #1670: URL: https://github.com/apache/hbase/pull/1670 - https://issues.apache.org/jira/browse/HBASE-24337 - https://github.com/apache/hbase/pull/1274 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack opened a new pull request #1669: HBASE-24338 [Flakey Tests] NPE in TestRaceBetweenSCPAndDTP
saintstack opened a new pull request #1669: URL: https://github.com/apache/hbase/pull/1669 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-24338) [Flakey Tests] NPE in TestRaceBetweenSCPAndDTP
Michael Stack created HBASE-24338: - Summary: [Flakey Tests] NPE in TestRaceBetweenSCPAndDTP Key: HBASE-24338 URL: https://issues.apache.org/jira/browse/HBASE-24338 Project: HBase Issue Type: Bug Components: flakies, test Reporter: Michael Stack Assignee: Michael Stack Seen in local runs -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24331) [Flakey Test] TestJMXListener rmi port clash
[ https://issues.apache.org/jira/browse/HBASE-24331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100957#comment-17100957 ] Michael Stack commented on HBASE-24331: --- I pushed this too. Test fix. [~markrmiller] a PR that cleans up any other impls of randomFreePort appreciated. > [Flakey Test] TestJMXListener rmi port clash > > > Key: HBASE-24331 > URL: https://issues.apache.org/jira/browse/HBASE-24331 > Project: HBase > Issue Type: Sub-task > Components: flakies, test >Reporter: Michael Stack >Priority: Major > > The TestJMXListener can fail because the random port it wants to put the jmx > listener on is occupied when it goes to run. Handle this case in test startup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24337) Backport HBASE-23968 to branch-2
Minwoo Kang created HBASE-24337: --- Summary: Backport HBASE-23968 to branch-2 Key: HBASE-24337 URL: https://issues.apache.org/jira/browse/HBASE-24337 Project: HBase Issue Type: Sub-task Reporter: Minwoo Kang Assignee: Minwoo Kang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1640: HBASE-24309 Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly
Apache-HBase commented on pull request #1640: URL: https://github.com/apache/hbase/pull/1640#issuecomment-624753053 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 42s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 5s | master passed | | +1 :green_heart: | compile | 2m 42s | master passed | | +1 :green_heart: | shadedjars | 5m 24s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 18s | hbase-common in master failed. | | -0 :warning: | javadoc | 0m 16s | hbase-metrics-api in master failed. | | -0 :warning: | javadoc | 0m 15s | hbase-metrics in master failed. | | -0 :warning: | javadoc | 0m 18s | hbase-hadoop-compat in master failed. | | -0 :warning: | javadoc | 0m 24s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 16s | hbase-zookeeper in master failed. | | -0 :warning: | javadoc | 0m 16s | hbase-balancer in master failed. | | -0 :warning: | javadoc | 0m 17s | hbase-http in master failed. | | -0 :warning: | javadoc | 0m 16s | hbase-procedure in master failed. | | -0 :warning: | javadoc | 0m 17s | hbase-hbtop in master failed. | | -0 :warning: | javadoc | 0m 18s | root in master failed. | | -0 :warning: | javadoc | 0m 15s | hbase-client-project in master failed. | | -0 :warning: | javadoc | 0m 16s | hbase-asyncfs in master failed. | | -0 :warning: | javadoc | 0m 17s | hbase-examples in master failed. | | -0 :warning: | javadoc | 0m 18s | hbase-mapreduce in master failed. | | -0 :warning: | javadoc | 0m 15s | hbase-replication in master failed. | | -0 :warning: | javadoc | 0m 19s | hbase-rest in master failed. | | -0 :warning: | javadoc | 0m 38s | hbase-server in master failed. | | -0 :warning: | javadoc | 0m 50s | hbase-thrift in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 50s | the patch passed | | +1 :green_heart: | compile | 2m 44s | the patch passed | | +1 :green_heart: | javac | 2m 44s | the patch passed | | +1 :green_heart: | shadedjars | 5m 21s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 17s | hbase-common in the patch failed. | | -0 :warning: | javadoc | 0m 14s | hbase-metrics-api in the patch failed. | | -0 :warning: | javadoc | 0m 15s | hbase-metrics in the patch failed. | | -0 :warning: | javadoc | 0m 18s | hbase-hadoop-compat in the patch failed. | | -0 :warning: | javadoc | 0m 25s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 16s | hbase-zookeeper in the patch failed. | | -0 :warning: | javadoc | 0m 15s | hbase-replication in the patch failed. | | -0 :warning: | javadoc | 0m 16s | hbase-balancer in the patch failed. | | -0 :warning: | javadoc | 0m 16s | hbase-http in the patch failed. | | -0 :warning: | javadoc | 0m 16s | hbase-asyncfs in the patch failed. | | -0 :warning: | javadoc | 0m 18s | hbase-procedure in the patch failed. | | -0 :warning: | javadoc | 0m 38s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 19s | hbase-mapreduce in the patch failed. | | -0 :warning: | javadoc | 0m 47s | hbase-thrift in the patch failed. | | -0 :warning: | javadoc | 0m 18s | hbase-rest in the patch failed. | | -0 :warning: | javadoc | 0m 17s | hbase-examples in the patch failed. | | -0 :warning: | javadoc | 0m 17s | hbase-hbtop in the patch failed. | | -0 :warning: | javadoc | 0m 15s | hbase-client-project in the patch failed. | | -0 :warning: | javadoc | 0m 16s | root in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 160m 44s | root in the patch failed. | | | | 207m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1640/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1640 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a9ab9c2fa4a8 4.15.0-60-generic #67-Ubuntu SMP Thu
[GitHub] [hbase] mwkang commented on pull request #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time.
mwkang commented on pull request #1274: URL: https://github.com/apache/hbase/pull/1274#issuecomment-624752554 Thanks you. Okay I will. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24310) Use Slf4jRequestLog for hbase-http
[ https://issues.apache.org/jira/browse/HBASE-24310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100951#comment-17100951 ] Michael Stack commented on HBASE-24310: --- ok. Release note the change in behavior and we should be good. > Use Slf4jRequestLog for hbase-http > -- > > Key: HBASE-24310 > URL: https://issues.apache.org/jira/browse/HBASE-24310 > Project: HBase > Issue Type: Sub-task > Components: logging >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > To remove the direct dependency on log4j in hbase-http server. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24118) [Flakey Tests] TestCloseRegionWhileRSCrash
[
https://issues.apache.org/jira/browse/HBASE-24118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100936#comment-17100936
]
Michael Stack commented on HBASE-24118:
---
Having trouble reproducing this failure. Applied below:
{code}
diff --git
a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestCloseRegionWhileRSCrash.java
b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestCloseRegionWhileRSCrash.java
index 4761991e75..3d3901f520 100644
---
a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestCloseRegionWhileRSCrash.java
+++
b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestCloseRegionWhileRSCrash.java
@@ -163,7 +163,8 @@ public class TestCloseRegionWhileRSCrash {
UTIL.shutdownMiniCluster();
}
- @org.junit.Ignore @Test // Until root-cause of flakeyness, HBASE-24117, is
addressed.
+ @Test
+ // @org.junit.Ignore @Test // Until root-cause of flakeyness, HBASE-24117,
is addressed.
public void testRetryBackoff() throws IOException, InterruptedException {
HRegionServer srcRs = UTIL.getRSForFirstRegionInTable(TABLE_NAME);
RegionInfo region = srcRs.getRegions(TABLE_NAME).get(0).getRegionInfo();
@@ -191,6 +192,7 @@ public class TestCloseRegionWhileRSCrash {
// close connection to make sure that we can not finish the TRSP
final HMaster master = UTIL.getMiniHBaseCluster().getMaster();
master.getConnection().close();
+LOG.info("Master1 {}, connection closed", master.getServerName());
RESUME.countDown();
UTIL.waitFor(3, () -> !master.isAlive());
// here we start a new master
{code}
Then did this... :
{code}
../dev-support/adhoc_run_tests/adhoc_run_tests.sh --repeat 30
TestCloseRegionWhileRSCrash#testRetryBackoff
{code}
Let me try in local builds.
> [Flakey Tests] TestCloseRegionWhileRSCrash
> --
>
> Key: HBASE-24118
> URL: https://issues.apache.org/jira/browse/HBASE-24118
> Project: HBase
> Issue Type: Test
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
> Attachments:
> 0001-HBASE-24118-Flakey-Tests-TestCloseRegionWhileRSCrash.patch
>
>
> TestCloseRegionWhileRSCrash is flakey because of HBASE-24117 -- because
> moved Region may not online in the end. Remove the last bit of the test...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] HorizonNet commented on pull request #1639: HBASE-24305 Removed deprecations in ServerName
HorizonNet commented on pull request #1639: URL: https://github.com/apache/hbase/pull/1639#issuecomment-624724479 Closing this in favor of #1666 as it leads to a clean build. The changes are the same. @saintstack & @Apache9 could you please check the other PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] wchevreuil commented on a change in pull request #1668: HBASE-24335 Support deleteall with ts but without column in shell mode
wchevreuil commented on a change in pull request #1668: URL: https://github.com/apache/hbase/pull/1668#discussion_r420865627 ## File path: hbase-shell/src/main/ruby/shell/commands/deleteall.rb ## @@ -30,12 +30,14 @@ def help hbase> deleteall 't1', 'r1' hbase> deleteall 't1', 'r1', 'c1' hbase> deleteall 't1', 'r1', 'c1', ts1 + hbase> deleteall 't1', 'r1', '', ts1//'' means not specify column Review comment: nit: better rephrase comment as: `//'' means no specific column` ## File path: hbase-shell/src/main/ruby/shell/commands/deleteall.rb ## @@ -30,12 +30,14 @@ def help hbase> deleteall 't1', 'r1' hbase> deleteall 't1', 'r1', 'c1' hbase> deleteall 't1', 'r1', 'c1', ts1 + hbase> deleteall 't1', 'r1', '', ts1//'' means not specify column Review comment: Maybe worth also explain that this command deletes all cells in the row which timestamp is lower than the one specified in the command. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24211) Create table is slow in large cluster when AccessController is enabled.
[
https://issues.apache.org/jira/browse/HBASE-24211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100897#comment-17100897
]
Hudson commented on HBASE-24211:
Results for branch branch-2.3
[build #68 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/68/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/68/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/68/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/68/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/68/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Create table is slow in large cluster when AccessController is enabled.
> ---
>
> Key: HBASE-24211
> URL: https://issues.apache.org/jira/browse/HBASE-24211
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.6, master, 2.2.4
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0, 1.7.0
>
>
> *Problem:*
> In HBase 1.3.x large, performance test, cluster (100 RS, 60k tables, 600k
> regions) a simple table creation takes around 150 seconds. The time taken
> varies but still takes lot of time.
> *Analysis:*
> 1. When HBase creates a table , it calls AssignmentManager#assign(final
> ServerName destination, final List regions)
> In AssignmentManager#assign，it calls asyncSetOfflineInZooKeeper(state, cb,
> destination), and waits in below code loop for 2 minutes.
> {code:java}
> if (useZKForAssignment) {
> // Wait until all unassigned nodes have been put up and watchers
> set.
> int total = states.size();
> for (int oldCounter = 0; !server.isStopped();) {
> int count = counter.get();
> if (oldCounter != count) {
> LOG.debug(destination.toString() + " unassigned znodes=" +
> count +
> " of total=" + total + "; oldCounter=" + oldCounter);
> oldCounter = count;
> }
> if (count >= total) break;
> Thread.sleep(5);
> }
> }
> {code}
> 2. asyncSetOfflineInZooKeeper creates a znode under
> /hbase/region-in-transition/ and calls exist to ensure that znode is created.
> This is simple operation should not take much time. Then where the time it
> taken!!!
> 3. ZooKeeper client API process watcher notification and async API response
> through a queue one by one.
> If there is a delay in any watcher/response processing by the client, in
> this case HBase, all other response processing is delayed. Then it appears as
> if API call has taken more time.
> Same thing happen in this issue.
> Watcher processing for znode creation under /hbase/acl took most of the time
> and delayed /hbase/region-in-transition/region znode creation processing.
> This is why wait in loop was too long.
> 4. Watcher processing for znode creation under hbase/acl/ calls
> ZKPermissionWatcher#nodeChildrenChanged, which internally calls
> ZKUtil.getChildDataAndWatchForNewChildren
> *which calls ZooKeeper's getData API, in this use case, 60k times which
> takes most of the time.*
> *Solutions:*
> Move getChildDataAndWatchForNewChildren call into the async code block in
> ZKPermissionWatcher#nodeChildrenChanged.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles
[
https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100895#comment-17100895
]
Hudson commented on HBASE-24273:
Results for branch branch-2.3
[build #68 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/68/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/68/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/68/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/68/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/68/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles
>
>
> Key: HBASE-24273
> URL: https://issues.apache.org/jira/browse/HBASE-24273
> Project: HBase
> Issue Type: Bug
> Components: hbck2
>Affects Versions: 2.2.4
> Environment: HBase 2.2.4
> Hadoop 3.1.3
>Reporter: Andrey Elenskiy
>Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> This issue came up after merging regions. MergeTableRegionsProcedure removes
> the parent regions from hbase:meta and creates HFile references in child
> region to the old parent regions. Running `hbck_chore_run` right after the
> `merge_region` will show the parent regions in "Orphan Regions on FileSystem"
> until major compaction is run on child region which will remove HFile
> references and cause Catalog Janitor to clean up the parent regions.
> There are probably other situations which can cause the same issue (maybe
> region split?)
> Having "Orphan Regions on FileSystem" list parent regions and suggest to
> "_hbase completebulkload_" is dangerous in this case as completing bulk load
> will lead to stale HFile references in child region which will cause its OPEN
> to fail because referenced HFile doesn't exist.
> Figuring out these things for database administrators is tedious, so I think
> it would be reasonable to not consider regions with referenced HFiles to be
> orphans (or maybe could give an extra hint saying that it has referenced
> HFiles).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
