lhofhansl commented on a change in pull request #1655:
URL: https://github.com/apache/hbase/pull/1655#discussion_r421080372



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CustomizedScanInfoBuilder.java
##########
@@ -80,4 +97,23 @@ public KeepDeletedCells getKeepDeletedCells() {
     return keepDeletedCells != null ? keepDeletedCells : 
scanInfo.getKeepDeletedCells();
   }
 
+  @Override
+  public int getMinVersions() {
+    return minVersions != null ? minVersions : scanInfo.getMinVersions();
+  }
+
+  @Override
+  public void setMinVersions(int minVersions) {
+    this.minVersions = minVersions;
+  }
+
+  @Override
+  public Scan getScan() {
+    try {
+      return new Scan(scan);

Review comment:
       Might be good at some point to have an unmodifiable subclass or wrapper 
of Scan, so that any modification would cause an error. (not in this PR, though)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to