[GitHub] [hbase] bsglz commented on pull request #2012: HBASE-24670 KeyPrefix related split policies should exends SteppingSp…

2020-07-06 Thread GitBox
bsglz commented on pull request #2012: URL: https://github.com/apache/hbase/pull/2012#issuecomment-654619572 Please take a look if you have time, thanks. @wchevreuil @virajjasani This is an automated message from the

[jira] [Updated] (HBASE-24670) KeyPrefix related split policies should extends SteppingSplitPolicy

2020-07-06 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24670: --- Description: Currently the KeyPrefixRegionSplitPolicy and DelimitedKeyPrefixRegionSplitPolicy are

[GitHub] [hbase] Apache-HBase commented on pull request #2016: HBASE-24653 Show snapshot owner on Master WebUI

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2016: URL: https://github.com/apache/hbase/pull/2016#issuecomment-654605519 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2030: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2030: URL: https://github.com/apache/hbase/pull/2030#issuecomment-654600556 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] tsuna commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-07-06 Thread GitBox
tsuna commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-654592451 Not sure whether my opinion matters but these kinds of side effects during deserialization are usually code smells. I would also be surprised to find that out.

[GitHub] [hbase] bsglz commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-07-06 Thread GitBox
bsglz commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-654588129 > > In distributed mode, this code would not make effect, because no host named "localhost". > > Is this a strong assumption? Not strong enough...maybe i can add a

[GitHub] [hbase] Apache9 commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-07-06 Thread GitBox
Apache9 commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-654585976 > In distributed mode, this code would not make effect, because no host named "localhost". Is this a strong assumption?

[GitHub] [hbase] ddupg opened a new pull request #2030: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-07-06 Thread GitBox
ddupg opened a new pull request #2030: URL: https://github.com/apache/hbase/pull/2030 backport HBASE-24431 to branch2 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] brfrn169 merged pull request #1991: HBASE-24650 Change the return types of the new checkAndMutate methods…

2020-07-06 Thread GitBox
brfrn169 merged pull request #1991: URL: https://github.com/apache/hbase/pull/1991 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-06 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152461#comment-17152461 ] Michael Stack commented on HBASE-24625: --- [~zghao] HBASE-24691 FYI see above. >

[GitHub] [hbase] bsglz commented on a change in pull request #2011: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-06 Thread GitBox
bsglz commented on a change in pull request #2011: URL: https://github.com/apache/hbase/pull/2011#discussion_r450587742 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java ## @@ -94,4 +94,33 @@ long

[GitHub] [hbase] bsglz commented on a change in pull request #2011: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-06 Thread GitBox
bsglz commented on a change in pull request #2011: URL: https://github.com/apache/hbase/pull/2011#discussion_r450583983 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java ## @@ -68,22 +76,14 @@ protected void

[GitHub] [hbase] Apache-HBase commented on pull request #2016: HBASE-24653 Show snapshot owner on Master WebUI

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2016: URL: https://github.com/apache/hbase/pull/2016#issuecomment-654568086 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #2029: HBASE-24688 AssignRegionHandler uses EventType.M_RS_CLOSE_META instea…

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2029: URL: https://github.com/apache/hbase/pull/2029#issuecomment-654566841 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #2029: HBASE-24688 AssignRegionHandler uses EventType.M_RS_CLOSE_META instea…

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2029: URL: https://github.com/apache/hbase/pull/2029#issuecomment-654565032 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[jira] [Commented] (HBASE-24546) CloneSnapshotProcedure unlimited retry

2020-07-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152441#comment-17152441 ] Hudson commented on HBASE-24546: Results for branch branch-2.2 [build #907 on

[GitHub] [hbase] bsglz commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-07-06 Thread GitBox
bsglz commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-654562715 The hostAndWeights stores weight of hosts for a region, currently the hosts in special mode has a bit diff, shows below. ``` #local mode(run by IDEA in windows)

[jira] [Commented] (HBASE-24691) Fix flaky TestWALEntryStream

2020-07-06 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152437#comment-17152437 ] Guanghao Zhang commented on HBASE-24691: {code:java} 2020-07-07 09:17:39,962 INFO [Time-limited

[GitHub] [hbase] Apache9 commented on a change in pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-06 Thread GitBox
Apache9 commented on a change in pull request #1970: URL: https://github.com/apache/hbase/pull/1970#discussion_r450577129 ## File path: hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/WrapperAsyncFSOutput.java ## @@ -91,7 +93,11 @@ private void

[jira] [Assigned] (HBASE-24684) Fetch ReplicationSink servers list from HMaster instead of ZooKeeper

2020-07-06 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sun Xin reassigned HBASE-24684: --- Assignee: Sun Xin > Fetch ReplicationSink servers list from HMaster instead of ZooKeeper >

[jira] [Assigned] (HBASE-24683) Add a basic ReplicationServer which only implement ReplicationSink Service

2020-07-06 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sun Xin reassigned HBASE-24683: --- Assignee: Sun Xin > Add a basic ReplicationServer which only implement ReplicationSink Service >

[jira] [Commented] (HBASE-24546) CloneSnapshotProcedure unlimited retry

2020-07-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152424#comment-17152424 ] Hudson commented on HBASE-24546: Results for branch branch-2 [build #2736 on

[GitHub] [hbase] Apache9 commented on a change in pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-06 Thread GitBox
Apache9 commented on a change in pull request #1970: URL: https://github.com/apache/hbase/pull/1970#discussion_r450569339 ## File path: hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/WrapperAsyncFSOutput.java ## @@ -91,7 +93,11 @@ private void

[jira] [Commented] (HBASE-24615) MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

2020-07-06 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152415#comment-17152415 ] wenfeiyi666 commented on HBASE-24615: - thanks, I go it. >

[jira] [Commented] (HBASE-24663) Add procedure process time statistics UI

2020-07-06 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152407#comment-17152407 ] Guanghao Zhang commented on HBASE-24663: Assigned to you [~Joseph295]. > Add procedure process

[jira] [Assigned] (HBASE-24663) Add procedure process time statistics UI

2020-07-06 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-24663: -- Assignee: Junhong Xu > Add procedure process time statistics UI >

[jira] [Assigned] (HBASE-24691) Fix flaky TestWALEntryStream

2020-07-06 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-24691: -- Assignee: Guanghao Zhang > Fix flaky TestWALEntryStream >

[jira] [Created] (HBASE-24691) Fix flaky TestWALEntryStream

2020-07-06 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-24691: -- Summary: Fix flaky TestWALEntryStream Key: HBASE-24691 URL: https://issues.apache.org/jira/browse/HBASE-24691 Project: HBase Issue Type: Sub-task

[jira] [Created] (HBASE-24690) Set version to 2.2.6 in branch-2.2 for first RC of 2.2.6

2020-07-06 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-24690: -- Summary: Set version to 2.2.6 in branch-2.2 for first RC of 2.2.6 Key: HBASE-24690 URL: https://issues.apache.org/jira/browse/HBASE-24690 Project: HBase

[jira] [Created] (HBASE-24689) Generate CHANGES.md and RELEASENOTES.md for 2.2.6

2020-07-06 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-24689: -- Summary: Generate CHANGES.md and RELEASENOTES.md for 2.2.6 Key: HBASE-24689 URL: https://issues.apache.org/jira/browse/HBASE-24689 Project: HBase Issue

[GitHub] [hbase] Apache-HBase commented on pull request #2029: HBASE-24688 AssignRegionHandler uses EventType.M_RS_CLOSE_META instea…

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2029: URL: https://github.com/apache/hbase/pull/2029#issuecomment-654533110 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[jira] [Commented] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152383#comment-17152383 ] Nick Dimiduk commented on HBASE-24625: -- >From a thread dump of {{TestWALEntryStream}} when the test

[GitHub] [hbase] huaxiangsun opened a new pull request #2029: HBASE-24688 AssignRegionHandler uses EventType.M_RS_CLOSE_META instea…

2020-07-06 Thread GitBox
huaxiangsun opened a new pull request #2029: URL: https://github.com/apache/hbase/pull/2029 …d of EventType.M_RS_OPEN_META for meta region This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] huaxiangsun commented on pull request #2029: HBASE-24688 AssignRegionHandler uses EventType.M_RS_CLOSE_META instea…

2020-07-06 Thread GitBox
huaxiangsun commented on pull request #2029: URL: https://github.com/apache/hbase/pull/2029#issuecomment-654521294 A straightforward fix. This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (HBASE-24688) AssignRegionHandler uses EventType.M_RS_CLOSE_META instead of EventType.M_RS_OPEN_META for meta region

2020-07-06 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-24688: - Summary: AssignRegionHandler uses EventType.M_RS_CLOSE_META instead of EventType.M_RS_OPEN_META

[jira] [Assigned] (HBASE-24688) AssignRegionHandler uses EventType.M_RS_CLOSE_META instead of EventType.M_RS_OPEN_META

2020-07-06 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun reassigned HBASE-24688: Assignee: Huaxiang Sun > AssignRegionHandler uses EventType.M_RS_CLOSE_META instead of

[jira] [Created] (HBASE-24688) AssignRegionHandler uses EventType.M_RS_CLOSE_META instead of EventType.M_RS_OPEN_META

2020-07-06 Thread Huaxiang Sun (Jira)
Huaxiang Sun created HBASE-24688: Summary: AssignRegionHandler uses EventType.M_RS_CLOSE_META instead of EventType.M_RS_OPEN_META Key: HBASE-24688 URL: https://issues.apache.org/jira/browse/HBASE-24688

[jira] [Created] (HBASE-24687) New Connection being created for each table

2020-07-06 Thread Manas (Jira)
Manas created HBASE-24687: - Summary: New Connection being created for each table Key: HBASE-24687 URL: https://issues.apache.org/jira/browse/HBASE-24687 Project: HBase Issue Type: Bug

[jira] [Updated] (HBASE-24546) CloneSnapshotProcedure unlimited retry

2020-07-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24546: - Fix Version/s: (was: 1.3.0) 2.3.0 > CloneSnapshotProcedure unlimited

[jira] [Updated] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24625: - Fix Version/s: (was: 2.3.0) 2.3.1 >

[jira] [Commented] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152321#comment-17152321 ] Nick Dimiduk commented on HBASE-24625: -- Running {{TestWALEntryStream}} on the branch-2.3 backport,

[GitHub] [hbase] Apache-HBase commented on pull request #2006: HBASE-24632 Enable procedure-based log splitting as default in hbase3

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2006: URL: https://github.com/apache/hbase/pull/2006#issuecomment-654458964 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2006: HBASE-24632 Enable procedure-based log splitting as default in hbase3

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2006: URL: https://github.com/apache/hbase/pull/2006#issuecomment-654457327 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152282#comment-17152282 ] Nick Dimiduk commented on HBASE-24625: -- I'm seeing this on the 2.3 backport PR as well,

[GitHub] [hbase] Apache-HBase commented on pull request #2028: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2.3

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2028: URL: https://github.com/apache/hbase/pull/2028#issuecomment-654432059 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ndimiduk commented on a change in pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-06 Thread GitBox
ndimiduk commented on a change in pull request #1970: URL: https://github.com/apache/hbase/pull/1970#discussion_r450435239 ## File path: hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/WrapperAsyncFSOutput.java ## @@ -91,7 +93,11 @@ private void

[GitHub] [hbase] ndimiduk commented on a change in pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-06 Thread GitBox
ndimiduk commented on a change in pull request #1970: URL: https://github.com/apache/hbase/pull/1970#discussion_r450430879 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java ## @@ -46,6 +46,10 @@ protected

[jira] [Commented] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-06 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152250#comment-17152250 ] Michael Stack commented on HBASE-24625: --- I'd have reopened it because it is failing branch-2. See

[GitHub] [hbase] Apache-HBase commented on pull request #2006: HBASE-24632 Enable procedure-based log splitting as default in hbase3

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2006: URL: https://github.com/apache/hbase/pull/2006#issuecomment-654404214 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-24665) all wal of RegionGroupingProvider together roll

2020-07-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24665: - Fix Version/s: (was: 2.3.0) 2.3.1 > all wal of RegionGroupingProvider

[jira] [Updated] (HBASE-24546) CloneSnapshotProcedure unlimited retry

2020-07-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24546: - Fix Version/s: (was: 2.3.1) 1.3.0 > CloneSnapshotProcedure unlimited

[GitHub] [hbase] saintstack commented on pull request #2006: HBASE-24632 Enable procedure-based log splitting as default in hbase3

2020-07-06 Thread GitBox
saintstack commented on pull request #2006: URL: https://github.com/apache/hbase/pull/2006#issuecomment-654389336 Test faillures are because we try to delete a non-empty directory. The left-over WALs are meta WALs but for meta regions that have since moved to another server (after a

[jira] [Updated] (HBASE-24376) MergeNormalizer is merging non-adjacent regions and causing region overlaps/holes.

2020-07-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24376: - Fix Version/s: (was: 2.4.0) > MergeNormalizer is merging non-adjacent regions and causing

[GitHub] [hbase] timoha commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-07-06 Thread GitBox
timoha commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-654381936 Looks like operator intervention is needed for this issue :) > I for one do not look at TaskMonitor figuring state of Procedures. Do others? Thanks. Just from my

[GitHub] [hbase] Apache-HBase commented on pull request #2028: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2.3

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2028: URL: https://github.com/apache/hbase/pull/2028#issuecomment-654378957 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2028: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2.3

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2028: URL: https://github.com/apache/hbase/pull/2028#issuecomment-654373837 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ndimiduk commented on a change in pull request #2017: HBASE-24669 Logging of ppid should be consistent across all occurrences

2020-07-06 Thread GitBox
ndimiduk commented on a change in pull request #2017: URL: https://github.com/apache/hbase/pull/2017#discussion_r450379754 ## File path: hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java ## @@ -1842,7 +1842,7 @@ private void

[GitHub] [hbase] ndimiduk commented on pull request #2028: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2.3

2020-07-06 Thread GitBox
ndimiduk commented on pull request #2028: URL: https://github.com/apache/hbase/pull/2028#issuecomment-654356936 Patch from branch-2 applies cleanly to branch-2.3. This is an automated message from the Apache Git Service. To

[jira] [Updated] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24625: - Fix Version/s: (was: 2.4.0) (was: 2.3.1) 2.3.0 >

[jira] [Reopened] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reopened HBASE-24625: -- Reopening to apply patch to branch-2.3 > AsyncFSWAL.getLogFileSizeIfBeingWritten does not return

[GitHub] [hbase] ndimiduk opened a new pull request #2028: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2.3

2020-07-06 Thread GitBox
ndimiduk opened a new pull request #2028: URL: https://github.com/apache/hbase/pull/2028 Signed-off-by: Duo Zhang This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] saintstack commented on a change in pull request #2018: HBASE-24659 Calculate FIXED_OVERHEAD automatically

2020-07-06 Thread GitBox
saintstack commented on a change in pull request #2018: URL: https://github.com/apache/hbase/pull/2018#discussion_r449899043 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -8405,12 +8405,7 @@ private static long

[jira] [Commented] (HBASE-24615) MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

2020-07-06 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152157#comment-17152157 ] Rushabh Shah commented on HBASE-24615: -- [~wenfeiyi666] just fyi you dont have to create a separate

[GitHub] [hbase] shahrs87 commented on pull request #1962: HBASE-24615 MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

2020-07-06 Thread GitBox
shahrs87 commented on pull request #1962: URL: https://github.com/apache/hbase/pull/1962#issuecomment-654348836 @WenFeiYi Thank you for the PR. Mind writing a small test case for this. Overall the code looks good to me. Thank you !

[jira] [Updated] (HBASE-24635) Split TestMetaWithReplicas

2020-07-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24635: - Fix Version/s: (was: 2.4.0) (was: 2.3.1) 2.3.0 >

[GitHub] [hbase] huaxiangsun commented on pull request #1986: HBASE-24581 Skip compaction request/check for replica regions at the …

2020-07-06 Thread GitBox
huaxiangsun commented on pull request #1986: URL: https://github.com/apache/hbase/pull/1986#issuecomment-654339877 @busbey @infraio Ping for comments, thanks. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] wchevreuil commented on a change in pull request #2009: HBASE-21596 Delete for a specific cell version can bring back version…

2020-07-06 Thread GitBox
wchevreuil commented on a change in pull request #2009: URL: https://github.com/apache/hbase/pull/2009#discussion_r450329196 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -3170,37 +3171,87 @@ public void

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-07-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152090#comment-17152090 ] Duo Zhang commented on HBASE-11288: --- Any updates here? Thanks. > Splittable Meta > --- >

[jira] [Commented] (HBASE-24546) CloneSnapshotProcedure unlimited retry

2020-07-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152079#comment-17152079 ] Hudson commented on HBASE-24546: Results for branch branch-2.3 [build #173 on

[jira] [Commented] (HBASE-24376) MergeNormalizer is merging non-adjacent regions and causing region overlaps/holes.

2020-07-06 Thread Ruslan Sabitov (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152065#comment-17152065 ] Ruslan Sabitov commented on HBASE-24376: I faced with the issue in branch-1 (HBase

[GitHub] [hbase] Apache-HBase commented on pull request #2025: HBASE-24489 Rewrite TestClusterRestartFailover.test since namespace t…

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2025: URL: https://github.com/apache/hbase/pull/2025#issuecomment-654236150 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2025: HBASE-24489 Rewrite TestClusterRestartFailover.test since namespace t…

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2025: URL: https://github.com/apache/hbase/pull/2025#issuecomment-654230489 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24663) Add procedure process time statistics UI

2020-07-06 Thread Junhong Xu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152002#comment-17152002 ] Junhong Xu commented on HBASE-24663: May I take this issue, sir? [~zghao] > Add procedure process

[GitHub] [hbase] Apache9 edited a comment on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-07-06 Thread GitBox
Apache9 edited a comment on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-654218536 > > I do not fully understand the logic here, why it is OK to use localhost if the returned hostAndWeight is null? We will only use the related methods to get

[GitHub] [hbase] Apache9 commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-07-06 Thread GitBox
Apache9 commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-654218536 > > I do not fully understand the logic here, why it is OK to use localhost if the returned hostAndWeight is null? We will only use the related methods to get hostAndWeight for

[jira] [Updated] (HBASE-24686) [LOG] Log improvement in Connection#close

2020-07-06 Thread mokai (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mokai updated HBASE-24686: -- Description: We met some customers used hbase connection improperly, some threads call failed since the

[GitHub] [hbase] virajjasani commented on pull request #1926: HBASE-24586 Add table level locality in table.jsp

2020-07-06 Thread GitBox
virajjasani commented on pull request #1926: URL: https://github.com/apache/hbase/pull/1926#issuecomment-654214933 @bsglz Thanks for the reminder. Will take a look in some time. This is an automated message from the Apache

[jira] [Created] (HBASE-24686) [LOG] Log improvement in Connection#close

2020-07-06 Thread mokai (Jira)
mokai created HBASE-24686: - Summary: [LOG] Log improvement in Connection#close Key: HBASE-24686 URL: https://issues.apache.org/jira/browse/HBASE-24686 Project: HBase Issue Type: Improvement

[jira] [Commented] (HBASE-24671) Add excludefile and designatedfile options to graceful_stop.sh

2020-07-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151971#comment-17151971 ] Hudson commented on HBASE-24671: Results for branch master [build #1778 on

[jira] [Commented] (HBASE-24578) [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count

2020-07-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151972#comment-17151972 ] Hudson commented on HBASE-24578: Results for branch master [build #1778 on

[jira] [Commented] (HBASE-24546) CloneSnapshotProcedure unlimited retry

2020-07-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151973#comment-17151973 ] Hudson commented on HBASE-24546: Results for branch master [build #1778 on

[jira] [Resolved] (HBASE-24685) MultiAction and FailureInfo should be removed

2020-07-06 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-24685. -- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed >

[GitHub] [hbase] virajjasani merged pull request #2027: HBASE-24685 : Removing MultiAction and FailureInfo

2020-07-06 Thread GitBox
virajjasani merged pull request #2027: URL: https://github.com/apache/hbase/pull/2027 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] wchevreuil commented on a change in pull request #2011: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-06 Thread GitBox
wchevreuil commented on a change in pull request #2011: URL: https://github.com/apache/hbase/pull/2011#discussion_r450139888 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java ## @@ -68,22 +76,14 @@ protected void

[GitHub] [hbase] Apache-HBase commented on pull request #2027: HBASE-24685 : Removing MultiAction and FailureInfo

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2027: URL: https://github.com/apache/hbase/pull/2027#issuecomment-654167129 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2027: HBASE-24685 : Removing MultiAction and FailureInfo

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2027: URL: https://github.com/apache/hbase/pull/2027#issuecomment-654164352 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2027: HBASE-24685 : Removing MultiAction and FailureInfo

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2027: URL: https://github.com/apache/hbase/pull/2027#issuecomment-654164189 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2026: HBASE-22738 Fallback to default group to choose RS when there are no …

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2026: URL: https://github.com/apache/hbase/pull/2026#issuecomment-654159689 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2026: HBASE-22738 Fallback to default group to choose RS when there are no …

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2026: URL: https://github.com/apache/hbase/pull/2026#issuecomment-654158184 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2026: HBASE-22738 Fallback to default group to choose RS when there are no …

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2026: URL: https://github.com/apache/hbase/pull/2026#issuecomment-654156908 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Work started] (HBASE-24685) MultiAction and FailureInfo should be removed

2020-07-06 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24685 started by Viraj Jasani. > MultiAction and FailureInfo should be removed >

[GitHub] [hbase] virajjasani opened a new pull request #2027: HBASE-24685 : Removing MultiAction and FailureInfo

2020-07-06 Thread GitBox
virajjasani opened a new pull request #2027: URL: https://github.com/apache/hbase/pull/2027 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Assigned] (HBASE-24685) MultiAction and FailureInfo should be removed

2020-07-06 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-24685: Assignee: Viraj Jasani > MultiAction and FailureInfo should be removed >

[jira] [Created] (HBASE-24685) MultiAction and FailureInfo should be removed

2020-07-06 Thread Viraj Jasani (Jira)
Viraj Jasani created HBASE-24685: Summary: MultiAction and FailureInfo should be removed Key: HBASE-24685 URL: https://issues.apache.org/jira/browse/HBASE-24685 Project: HBase Issue Type:

[GitHub] [hbase] ddupg opened a new pull request #2026: HBASE-22738 Fallback to default group to choose RS when there are no …

2020-07-06 Thread GitBox
ddupg opened a new pull request #2026: URL: https://github.com/apache/hbase/pull/2026 …RS in current group backport HBASE-22738 to branch2 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HBASE-24666) Offload the replication source/sink job to independent Replication Server

2020-07-06 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151929#comment-17151929 ] Guanghao Zhang commented on HBASE-24666: {quote}you don execute any CP hooks as part of

[jira] [Created] (HBASE-24684) Fetch ReplicationSink servers list from HMaster instead of ZooKeeper

2020-07-06 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-24684: -- Summary: Fetch ReplicationSink servers list from HMaster instead of ZooKeeper Key: HBASE-24684 URL: https://issues.apache.org/jira/browse/HBASE-24684 Project:

[jira] [Created] (HBASE-24683) Add a basic ReplicationServer which only implement ReplicationSink Service

2020-07-06 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-24683: -- Summary: Add a basic ReplicationServer which only implement ReplicationSink Service Key: HBASE-24683 URL: https://issues.apache.org/jira/browse/HBASE-24683

[GitHub] [hbase] brfrn169 commented on a change in pull request #1991: HBASE-24650 Change the return types of the new checkAndMutate methods…

2020-07-06 Thread GitBox
brfrn169 commented on a change in pull request #1991: URL: https://github.com/apache/hbase/pull/1991#discussion_r450112215 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncTableImpl.java ## @@ -497,7 +497,7 @@ public void run(MultiResponse resp)

[GitHub] [hbase] Apache-HBase commented on pull request #2025: HBASE-24489 Rewrite TestClusterRestartFailover.test since namespace t…

2020-07-06 Thread GitBox
Apache-HBase commented on pull request #2025: URL: https://github.com/apache/hbase/pull/2025#issuecomment-654130992 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

  1   2   >